1. 21 Jun, 2009 2 commits
    • levin@chromium.org's avatar
      JavaScriptCore: · 3affb89e
      levin@chromium.org authored
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=25043>
              Added support for multi-threaded MessagePorts.
      
              * wtf/MessageQueue.h:
              (WTF::::appendAndCheckEmpty):
                  Added API to test whether the queue was empty before adding an element.
      
      WebCore:
      
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=25043>
              Removed obsolete MessagePort.startConversation(), active and onclose APIs.
      
              Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
              implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
              entirely into the platform-dependent proxy.
      
              Created a thread-safe default PlatformMessagePortChannel implementation.
      
              Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
              cross-thread MessagePorts work.
      
              * GNUMakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
                  Added MessagePortChannel/PlatformMessagePortChannel files.
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::mark):
                  Changed ports to not mark their entangled pair as reachable, per the spec.
              * bindings/v8/custom/V8MessagePortCustom.cpp:
              * dom/MessageChannel.cpp:
              (WebCore::MessageChannel::MessageChannel):
                  Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
              * dom/MessagePort.cpp:
              (WebCore::MessagePort::MessagePort):
              (WebCore::MessagePort::~MessagePort):
              (WebCore::MessagePort::postMessage):
              (WebCore::MessagePort::disentangle):
              (WebCore::MessagePort::messageAvailable):
              (WebCore::MessagePort::start):
              (WebCore::MessagePort::close):
              (WebCore::MessagePort::entangle):
              (WebCore::MessagePort::contextDestroyed):
              (WebCore::MessagePort::dispatchMessages):
              (WebCore::MessagePort::setOnmessage):
              (WebCore::MessagePort::hasPendingActivity):
                  Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
              * dom/MessagePort.h:
                  Renamed isQueueOpen() to started().
              * dom/MessagePort.idl:
                  Removed startConversation and onclose.
              * dom/MessagePortProxy.h: Removed.
              * dom/MessagePortChannel.cpp: Added.
              (WebCore::MessagePortChannel::EventData::create):
              (WebCore::MessagePortChannel::EventData::EventData):
              (WebCore::MessagePortChannel::~MessagePortChannel):
              * dom/MessagePortChannel.h: Added.
              (WebCore::MessagePortChannel::EventData::message):
              (WebCore::MessagePortChannel::EventData::channel):
                  Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
              (WebCore::MessagePortChannel::MessagePortChannel):
              (WebCore::MessagePortChannel::create):
              * dom/ScriptExecutionContext.cpp:
              (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
                  Renamed isQueueOpen() to started().
              * dom/default/PlatformMessagePortChannel.cpp: Added.
              (WebCore::MessagePortChannel::entangleIfOpen):
              (WebCore::MessagePortChannel::disentangle):
              (WebCore::MessagePortChannel::postMessageToRemote):
              (WebCore::MessagePortChannel::tryGetMessageFromRemote):
              (WebCore::MessagePortChannel::close):
              (WebCore::MessagePortChannel::isConnectedTo):
              (WebCore::MessagePortChannel::hasPendingActivity):
              (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
              (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
              (WebCore::PlatformMessagePortChannel::createChannel):
              (WebCore::PlatformMessagePortChannel::entangleIfOpen):
              (WebCore::PlatformMessagePortChannel::disentangle):
              (WebCore::PlatformMessagePortChannel::setRemotePort):
              (WebCore::PlatformMessagePortChannel::remotePort):
              (WebCore::PlatformMessagePortChannel::entangledChannel):
              (WebCore::PlatformMessagePortChannel::setEntangledChannel):
              (WebCore::PlatformMessagePortChannel::postMessageToRemote):
              (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
              (WebCore::PlatformMessagePortChannel::isConnectedTo):
              (WebCore::PlatformMessagePortChannel::close):
              (WebCore::PlatformMessagePortChannel::closeInternal):
              (WebCore::PlatformMessagePortChannel::hasPendingActivity):
              * dom/default/PlatformMessagePortChannel.h: Added.
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::create):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
              * page/DOMWindow.cpp:
              (WebCore::PostMessageTimer::PostMessageTimer):
                  Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
              (WebCore::PostMessageTimer::event):
              (WebCore::DOMWindow::postMessage):
              (WebCore::DOMWindow::postMessageTimerFired):
      
      LayoutTests:
      
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=25043>
              Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
              Added more tests of port cloning.
      
              * fast/events/message-channel-gc-2-expected.txt:
              * fast/events/message-channel-gc-2.html-disabled:
              * fast/events/message-channel-gc-3-expected.txt:
              * fast/events/message-channel-gc-3.html-disabled:
              * fast/events/message-channel-gc-expected.txt:
              * fast/events/message-channel-gc.html-disabled:
              * fast/events/message-port-clone-expected.txt: Added.
              * fast/events/message-port-clone.html-disabled: Added.
              * fast/events/message-port-expected.txt:
              * fast/events/message-port-no-wrapper-expected.txt: Added.
              * fast/events/message-port-onclose-expected.txt: Removed.
              * fast/events/message-port-onclose.html-disabled: Removed.
              * fast/events/message-port.html-disabled:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3affb89e
    • weinig@apple.com's avatar
      WebCore: · f23f5741
      weinig@apple.com authored
      2009-06-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Eric Seidel
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
              event.currentTarget for listener registered on window should point to the window object like in Firefox
      
              Test: fast/events/event-trace.html
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched
              to it. We previously used the document because DOMWindow was not yet an EventTarget.
      
      LayoutTests:
      
      2009-06-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=26578
              event.currentTarget for listener registered on window should point to the window object like in Firefox
      
              * fast/events/event-trace-expected.txt: Added.
              * fast/events/event-trace.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f23f5741
  2. 18 May, 2009 1 commit
  3. 06 May, 2009 2 commits
    • eric@webkit.org's avatar
      2009-05-06 Eric Seidel <eric@webkit.org> · 017b6ab5
      eric@webkit.org authored
              No review, just fixing my previous broken commit.
      
              Commit correct results for event-function-toString.html
      
              * fast/events/event-function-toString-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      017b6ab5
    • eric@webkit.org's avatar
      2009-05-06 Soren Gjesse <sgjesse@chromium.org> · 410a8a82
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Changed the toString behaviour for non document dom node event handlers in the V8 bindings.
              https://bugs.webkit.org/show_bug.cgi?id=25544
      
              In the V8 bindings non document dom node event handlers are wrapped in a number of with blocks and uses an inner
              function. This causes the default toString on such a handler to return all this wrapper code. As some web sites
              use the source of an event handler to create new functions this wrapper code causes compatibility problems.
      
              Create a specific toString function for these handlers which will return a function source compatible with the
              source returned by the JSC bindings and other browsers.
      
              Test: fast/events/event-function-toString.html
      
              * bindings/v8/ScriptEventListener.cpp:
              (WebCore::createAttributeEventListener):
              * bindings/v8/V8LazyEventListener.cpp:
              (WebCore::V8LazyEventListener::V8LazyEventListener):
              (WebCore::V8LazyEventListener::getListenerFunction):
              (WebCore::V8LazyEventListenerToString):
              (WebCore::V8LazyEventListener::getWrappedListenerFunction):
              * bindings/v8/V8LazyEventListener.h:
              (WebCore::V8LazyEventListener::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      410a8a82
  4. 22 Apr, 2009 4 commits
  5. 21 Apr, 2009 1 commit
    • darin@apple.com's avatar
      2009-04-21 Darin Adler <darin@apple.com> · 58322639
      darin@apple.com authored
              Reviewed by Adele Peterson.
      
              Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
              Added failing tests to the skipped list for SnowLeopard.
      
              * editing/resources/select-all-iframe-src.html: Moved.
              * editing/selection/resources/select-all-iframe-src.html: Moved from
              editing/resources/select-all-iframe-src.html, since this is used by a test in the
              selection directory. Changed mouse coordinates to be farther to the right so we
              don't depend on the rule for what's selected when you click below text on the last line.
              * editing/selection/select-all-iframe.html: Updated for new location of file above.
      
              * fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be
              farther to the right so we don't depend on the rule for what's selected when you click
              below text on the last line.
      
              * platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.
      
              * svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's
              not in the test results. Also removed unneeded use of the layout test controller.
      
              * platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
              * platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
              * platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58322639
  6. 18 Apr, 2009 1 commit
    • ggaren@apple.com's avatar
      WebCore: · 2082428d
      ggaren@apple.com authored
      2009-04-18  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              Fixed <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
              REGRESSION (r42569): Profiles cannot be selected in inspector profiler
              
              EventListeners are shared; RegisteredEventListeners are not. Therefore,
              when a node wrapper needs to invalidate the node's JS event listeners,
              it should invalidate its RegisteredEventListeners, not its EventListeners.
              Otherwise, it might invalidate an EventListener shared by another node.
      
              * dom/RegisteredEventListener.h:
              (WebCore::invalidateEventListeners): ditto
      
      LayoutTests:
      
      2009-04-18  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Cameron Zwarich.
              
              Test for <rdar://problem/6797442> | https://bugs.webkit.org/show_bug.cgi?id=25285
              REGRESSION (r42569): Profiles cannot be selected in inspector profiler
      
              * fast/events/event-listener-sharing-expected.txt: Added.
              * fast/events/event-listener-sharing.html: Added.
              * fast/events/resources/event-listener-sharing.js: Added.
              (gc):
              (clickHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2082428d
  7. 13 Apr, 2009 1 commit
    • darin@apple.com's avatar
      WebCore: · c79077ea
      darin@apple.com authored
      2009-04-13  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
              https://bugs.webkit.org/show_bug.cgi?id=25158
              rdar://problem/6769693
      
              Test: editing/selection/click-after-nested-block.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint
              can share code.
              (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first
              child box. Changed special case for last child box to propertly handle the various
              types of child box that are not hit test candidates (the same ones already handled
              by the hit test loop below), adding in a loop so we find the last candidate.
      
      LayoutTests:
      
      2009-04-13  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
              https://bugs.webkit.org/show_bug.cgi?id=25158
              rdar://problem/6769693
      
              * editing/selection/click-after-nested-block-expected.txt: Added.
              * editing/selection/click-after-nested-block.html: Added.
      
              * fast/events/pointer-events-expected.txt: Updated since this is now a plain-text test.
              * fast/events/pointer-events.html: Changed this to a plain-text test, because the old
              results reflected a difference in hit testing behavior that this test was not intended
              to exercise and it's better to have the test be more cross-platform. Also removed
              unneeded use of waitUntilDone.
      
              * fast/js/finally-codegen-failure.html: Replaced with standard wrapper created by
              running the make-js-test-wrappers script. If we want to include type and charset
              attributes in the script elements, we can change make-js-test-wrappers to do that
              for all tests at some point.
              * fast/js/function-apply-aliased.html: Ditto.
              * fast/js/function-call-aliased.html: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79077ea
  8. 09 Apr, 2009 1 commit
    • weinig@apple.com's avatar
      WebCore: · f239bbf9
      weinig@apple.com authored
      2009-04-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Geoffrey "Big Boy" Garen.
      
              Fix for <rdar://problem/5745677> Possible to stop load during an unload event
              Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
      
              Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
                     fast/events/stop-load-in-unload-handler-using-window-stop.html
      
              Don't allow calling methods that would stop the new load inside the unload
              event.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::stopAllLoaders):
              * loader/FrameLoader.h:
      
      LayoutTests:
      
      2009-04-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Geoffrey "Big Boy" Garen.
      
              Tests for <rdar://problem/5745677> Possible to stop load during an unload event
      
              * fast/events/resources/pass.html: Added.
              * fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added.
              * fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added.
              * fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added.
              * fast/events/stop-load-in-unload-handler-using-document-write.html: Added.
              * fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added.
              * fast/events/stop-load-in-unload-handler-using-window-stop.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f239bbf9
  9. 01 Apr, 2009 1 commit
  10. 20 Mar, 2009 1 commit
  11. 15 Mar, 2009 1 commit
  12. 10 Mar, 2009 1 commit
    • cwzwarich@webkit.org's avatar
      2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 5c7f83df
      cwzwarich@webkit.org authored
              Reviewed by Geoff Garen.
      
              Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
              <https://bugs.webkit.org/show_bug.cgi?id=24291>
              <rdar://problem/6663472>
      
              Add an extra newline to the end of the body of the program text constructed
              by the Function constructor for parsing. This allows single line comments to
              be handled correctly by the parser.
      
              JavaScriptCore:
      
              * runtime/FunctionConstructor.cpp:
              (JSC::constructFunction):
      
              LayoutTests:
      
              * fast/events/onload-single-line-comment-expected.txt: Added.
              * fast/events/onload-single-line-comment.html: Added.
              * fast/js/function-constructor-single-line-comment-expected.txt: Added.
              * fast/js/function-constructor-single-line-comment.html: Added.
              * fast/js/resources/function-constructor-single-line-comment.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c7f83df
  13. 03 Mar, 2009 1 commit
    • dglazkov@chromium.org's avatar
      WebCore: · 78eddf96
      dglazkov@chromium.org authored
      2009-03-03  Scott Violet  <sky@google.com>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24325
              Crash on replacing document contents during drop.
      
              Makes sure a node is in the document during a move before using it.
      
              Test: fast/events/crash-on-mutate-during-drop.html
      
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
      
      LayoutTests:
      
      2009-03-03  Scott Violet  <sky@google.com>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=24325
              Crash on replacing document contents during drop
      
              Makes sure we don't crash during dnd with DOM mutation event listener
              that mutates the document on drop.
      
              * fast/events/crash-on-mutate-during-drop-expected.txt: Added.
              * fast/events/crash-on-mutate-during-drop.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78eddf96
  14. 01 Mar, 2009 1 commit
    • mitz@apple.com's avatar
      WebCore: · 8a089a4e
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
      
              Test: fast/events/scroll-during-zoom-change.html
      
              * dom/Document.cpp:
              (WebCore::Document::recalcStyle): Pause scheduled events during style
              reclaculation. Changes to the zoom property result in scroll events
              being generated during style recalc, and those events need to be
              deferred until the render tree is consistent.
              * page/FrameView.cpp:
              (WebCore::FrameView::layout): Changed to account for a case in which the
              post-layout tasks trigger a nested layout, which reactivates the
              post-layout task timer.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
      
              * fast/events/scroll-during-zoom-change-expected.txt: Added.
              * fast/events/scroll-during-zoom-change.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a089a4e
  15. 24 Feb, 2009 2 commits
  16. 10 Feb, 2009 1 commit
  17. 16 Jan, 2009 1 commit
  18. 05 Jan, 2009 2 commits
    • dino@apple.com's avatar
      2008-01-05 Dean Jackson <dino@apple.com> · 563bd1f6
      dino@apple.com authored
              Reviewed by David Hyatt.
      
              Implement 'pointer-events' for HTML content. This involved
              adding a new value 'auto' which behaves as 'visiblePainted'
              in SVG content.
      
              Moved the property out of the SVG CSS code and into
              the general CSS (both parsing and RenderStyle).
      
              Changes to the hit testing functionality of the Render tree,
              specifically the nodeAtPoint methods. Where they used to
              test for visibility, they now use a helper function defined
              on base classes (RenderObject and InlineBox) that checks both
              visibility and pointer-events.
      
              https://bugs.webkit.org/show_bug.cgi?id=11395
      
              Tests: fast/events/pointer-events-2.html
                     fast/events/pointer-events.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              (WebCore::CSSPrimitiveValue::operator EPointerEvents):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/SVGCSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
              * css/SVGCSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applySVGProperty):
              * manual-tests/pointer-events.html: Added.
              * rendering/EllipsisBox.cpp:
              (WebCore::EllipsisBox::nodeAtPoint):
              * rendering/InlineBox.h:
              (WebCore::InlineBox::visibleToHitTesting):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::nodeAtPoint):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::nodeAtPoint):
              * rendering/PointerEventsHitRules.cpp:
              (WebCore::PointerEventsHitRules::PointerEventsHitRules):
              * rendering/PointerEventsHitRules.h:
              (WebCore::PointerEventsHitRules::):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::nodeAtPoint):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::nodeAtPoint):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::visibleToHitTesting):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::nodeAtPoint):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::nodeAtPoint):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::nodeAtPoint):
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::nodeAtPoint):
              * rendering/TextControlInnerElements.cpp:
              (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
              * rendering/style/RenderStyle.h:
              (WebCore::):
              (WebCore::InheritedFlags::setBitDefaults):
              (WebCore::InheritedFlags::pointerEvents):
              (WebCore::InheritedFlags::setPointerEvents):
              (WebCore::InheritedFlags::initialPointerEvents):
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
              * rendering/style/SVGRenderStyle.h:
              (WebCore::SVGRenderStyle::InheritedFlags::operator==):
              (WebCore::SVGRenderStyle::setBitDefaults):
              * rendering/style/SVGRenderStyleDefs.h:
              * css/CSSValueKeywords.in:
              * css/SVGCSSValueKeywords.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      563bd1f6
    • darin@apple.com's avatar
      WebCore: · 56e37de8
      darin@apple.com authored
      2009-01-05  Darin Adler  <darin@apple.com>
      
              Reviewed by Anders Carlsson.
      
              Bug 23104: minor mistakes in init functions for animation and transition events
              https://bugs.webkit.org/show_bug.cgi?id=23104
      
              Test: fast/events/init-events.html
      
              Also fixed two StorageEvent problems the test case uncovered:
      
                  Made document.createEvent("StorageEvent") work.
                  Allow null values for StorageEvent.oldValue and StorageEvent.newValue.
      
              * dom/Document.cpp:
              (WebCore::Document::createEvent): Sorted alphabetically by the name of the event
              class. Added StorageEvent.
      
              * dom/UIEvent.idl: Fixed typo in a comment.
      
              * dom/WebKitAnimationEvent.cpp:
              (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
              * dom/WebKitTransitionEvent.cpp:
              (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.
      
              * storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the
              arguments to initStorageEvent so it can create events with null values for the
              oldValue and newValue, just like the real storage events. Note that the properties
              already had ConvertNullStringTo=Null, so this is just the other half of that.
      
      LayoutTests:
      
      2009-01-05  Darin Adler  <darin@apple.com>
      
              Reviewed by Anders Carlsson.
      
              Bug 23104: minor mistakes in init functions for animation and transition events
              https://bugs.webkit.org/show_bug.cgi?id=23104
      
              * fast/events/init-events-expected.txt: Added.
              * fast/events/init-events.html: Added.
              * fast/events/resources/init-events.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56e37de8
  19. 18 Dec, 2008 1 commit
    • cwzwarich@webkit.org's avatar
      2008-12-18 Cameron Zwarich <zwarich@apple.com> · 05a4f6a0
      cwzwarich@webkit.org authored
              Reviewed by Geoff Garen.
      
              Bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
              <https://bugs.webkit.org/show_bug.cgi?id=21855>
              <rdar://problem/6278244>
      
              If JavaScript is not currently executing, the handleEvent member function
              of JSAbstractEventListener should set the dynamic global object to the
              global object of the context in which the event occurred.
              
              If this is not set, then JavaScriptCore will simply take the global object
              of the context where the event handler function was created, which may be
              a different frame. This will cause the popup blocker to incorrectly block
              windows opened from onclick events inside of an iframe whose handler was
              created in the outer frame, as it will check the outer frame and see that
              it is not processing any events.
      
              JavaScriptCore:
      
              * interpreter/Interpreter.cpp:
              * runtime/JSGlobalObject.h:
              (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
              (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope):
      
              WebCore:
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
      
              WebKitTools:
      
              * DumpRenderTree/mac/EventSendingController.h:
              * DumpRenderTree/mac/EventSendingController.mm:
              (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
              scheduleAsynchronousClick to JavaScript.
              (-[EventSendingController scheduleAsynchronousClick]): Add.
      
              LayoutTests:
      
              * fast/events/popup-blocking-click-in-iframe-expected.txt: Added.
              * fast/events/popup-blocking-click-in-iframe.html: Added.
              * fast/events/resources/popup-blocking-click-in-iframe-otherFrame.html: Added.
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05a4f6a0
  20. 12 Dec, 2008 1 commit
    • dino@apple.com's avatar
      2008-12-12 Dean Jackson <dino@apple.com> · 572b6eb2
      dino@apple.com authored
              Reviewed by Darin Adler.
      
              Expose WebKitAnimationEvent, WebKitTransitionEvent,
              WebKitCSSTransformValue, WebKitCSSKeyframeRule and
              WebKitCSSKeyframesRule to Window object.
              This required generating constructors for the event
              interfaces.
      
              https://bugs.webkit.org/show_bug.cgi?id=20560
      
              WebCore:
                  * dom/WebKitAnimationEvent.idl:
                  * dom/WebKitTransitionEvent.idl:
                  * page/DOMWindow.idl:
      
              LayoutTests:
                  * animations/keyframes-rule-expected.txt:
                  * animations/keyframes-rule.html:
                  * fast/dom/Window/window-properties-expected.txt:
                  * fast/events/event-instanceof-expected.txt:
                  * fast/events/resources/event-instanceof.js:
                  * fast/js/global-constructors-expected.txt:
                  * transforms/transform-value-types-expected.txt:
                  * transforms/transform-value-types.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      572b6eb2
  21. 09 Dec, 2008 2 commits
  22. 08 Dec, 2008 2 commits
  23. 05 Dec, 2008 2 commits
  24. 29 Nov, 2008 1 commit
    • weinig@apple.com's avatar
      WebCore: · 32e92c57
      weinig@apple.com authored
      2008-11-28  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21063
              NULL pointer crash in dispatchEvent(null);
      
              Test: fast/events/dispatchEvent-crash.html
      
              * dom/MessagePort.cpp:
              (WebCore::MessagePort::dispatchEvent):
              * dom/Worker.cpp:
              (WebCore::Worker::dispatchEvent):
              * dom/WorkerContext.cpp:
              (WebCore::WorkerContext::dispatchEvent):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::dispatchEvent):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::dispatchEvent):
              * xml/XMLHttpRequestUpload.cpp:
              (WebCore::XMLHttpRequestUpload::dispatchEvent):
      
      LayoutTests:
      
      2008-11-28  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=21063
              NULL pointer crash in dispatchEvent(null);
      
              * fast/events/dispatchEvent-crash-expected.txt: Added.
              * fast/events/dispatchEvent-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32e92c57
  25. 18 Nov, 2008 1 commit
    • ap@webkit.org's avatar
      Rubber-stamped by Darin Adler. · 2e143a89
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=22306
              Disable channel messaging support
      
      WebCore:
              * bindings/js/JSDOMWindowBase.cpp:
              (jsDOMWindowBaseMessageChannel):
              * page/DOMWindow.idl:
              Hide MesssagePort and MessageChannel global constructors. Due to the way MessageChannel
              constructor is added, it remains enumerable, but undefined.
      
      LayoutTests:
              * fast/events/message-port-no-wrapper.html-disabled: Added a test that I had in my tree.
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/constructors-cached-expected.txt:
              * fast/dom/constructors-cached-navigate-expected.txt:
              * fast/js/global-constructors-expected.txt:
              Updated results.
      
              * fast/events/destroyed-atomic-string.html: Removed.
              * fast/events/destroyed-atomic-string.html-disabled: Copied from LayoutTests/fast/events/destroyed-atomic-string.html.
              * fast/events/message-channel-gc-2.html: Removed.
              * fast/events/message-channel-gc-2.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc-2.html.
              * fast/events/message-channel-gc-3.html: Removed.
              * fast/events/message-channel-gc-3.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc-3.html.
              * fast/events/message-channel-gc.html: Removed.
              * fast/events/message-channel-gc.html-disabled: Copied from LayoutTests/fast/events/message-channel-gc.html.
              * fast/events/message-channel-listener-circular-ownership.html: Removed.
              * fast/events/message-channel-listener-circular-ownership.html-disabled: Copied from LayoutTests/fast/events/message-channel-listener-circular-ownership.html.
              * fast/events/message-port-constructor-for-deleted-document.html: Removed.
              * fast/events/message-port-constructor-for-deleted-document.html-disabled: Copied from LayoutTests/fast/events/message-port-constructor-for-deleted-document.html.
              * fast/events/message-port-deleted-document.html: Removed.
              * fast/events/message-port-deleted-document.html-disabled: Copied from LayoutTests/fast/events/message-port-deleted-document.html.
              * fast/events/message-port-deleted-frame.html: Removed.
              * fast/events/message-port-deleted-frame.html-disabled: Copied from LayoutTests/fast/events/message-port-deleted-frame.html.
              * fast/events/message-port-inactive-document.html: Removed.
              * fast/events/message-port-inactive-document.html-disabled: Copied from LayoutTests/fast/events/message-port-inactive-document.html.
              * fast/events/message-port-onclose.html: Removed.
              * fast/events/message-port-onclose.html-disabled: Copied from LayoutTests/fast/events/message-port-onclose.html.
              * fast/events/message-port.html: Removed.
              * fast/events/message-port.html-disabled: Copied from LayoutTests/fast/events/message-port.html.
              * http/tests/security/MessagePort/event-listener-context.html: Removed.
              * http/tests/security/MessagePort/event-listener-context.html-disabled: Copied from LayoutTests/http/tests/security/MessagePort/event-listener-context.html.
              Disabled MessagePort tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e143a89
  26. 13 Nov, 2008 1 commit
  27. 06 Nov, 2008 1 commit
  28. 01 Nov, 2008 1 commit
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · ec7365b9
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=22001
              AtomicStringImpl* keys of event listener maps can outlive their strings
      
              Test: fast/events/destroyed-atomic-string.html
      
              * dom/MessagePort.cpp:
              (WebCore::MessagePort::addEventListener):
              (WebCore::MessagePort::removeEventListener):
              (WebCore::MessagePort::dispatchEvent):
              * dom/MessagePort.h:
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::addEventListener):
              (WebCore::DOMApplicationCache::removeEventListener):
              (WebCore::DOMApplicationCache::dispatchEvent):
              * loader/appcache/DOMApplicationCache.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::addEventListener):
              (WebCore::XMLHttpRequest::removeEventListener):
              (WebCore::XMLHttpRequest::dispatchEvent):
              * xml/XMLHttpRequest.h:
              * xml/XMLHttpRequestUpload.cpp:
              (WebCore::XMLHttpRequestUpload::addEventListener):
              (WebCore::XMLHttpRequestUpload::removeEventListener):
              (WebCore::XMLHttpRequestUpload::dispatchEvent):
              * xml/XMLHttpRequestUpload.h:
              Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7365b9
  29. 29 Oct, 2008 1 commit
  30. 23 Oct, 2008 1 commit