1. 19 Jan, 2009 22 commits
    • andersca@apple.com's avatar
      2009-01-19 Anders Carlsson <andersca@apple.com> · 3a6f4624
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Make Evaluate an asynchronous method that has a reply method.
              
              * Plugins/Hosted/NetscapePluginHostProxy.mm:
              (WKPCEvaluate):
              * Plugins/Hosted/WebKitPluginClient.defs:
              * Plugins/Hosted/WebKitPluginHost.defs:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a6f4624
    • christian@webkit.org's avatar
      2009-01-20 Gustavo Noronha Silva <gns@gnome.org> · 685197dc
      christian@webkit.org authored
               Reviewed by Mark Rowe.
      
               https://bugs.webkit.org/show_bug.cgi?id=23419
               removal of FramePrivate.h breaks GTK+'s make dist
      
               * GNUmakefile.am: No longer mention FramePrivate.h in our build,
               since it was removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      685197dc
    • christian@webkit.org's avatar
      2009-01-20 Alexander V. Butenko <alex@digiqube.com> · ab95cec5
      christian@webkit.org authored
              Reviewed by Holger Freyther.
      
              http://bugs.webkit.org/show_bug.cgi?id=23116
              [GTK] Fix crash due a callback called from GIO after the
              destruction of the ResourceHandle
      
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::ResourceHandle::cancel): Only call didFinishLoading if
              'client' is set, otherwise cancelling a load could lead to a crash.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab95cec5
    • darin@apple.com's avatar
      JavaScriptCore: · d91c5977
      darin@apple.com authored
      2009-01-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
              <https://bugs.webkit.org/show_bug.cgi?id=23409>
              <rdar://problem/6505723>
      
              Test: fast/js/string-replace-3.html
      
              * runtime/StringPrototype.cpp:
              (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure
              how this ever worked.
      
      LayoutTests:
      
      2009-01-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
              <https://bugs.webkit.org/show_bug.cgi?id=23409>
              <rdar://problem/6505723>
      
              * fast/js/resources/string-replace-3.js:
              * fast/js/string-replace-3-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d91c5977
    • simon.fraser@apple.com's avatar
      ChangeLog typo fix. · 4d6a62c1
      simon.fraser@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d6a62c1
    • simon.fraser@apple.com's avatar
      2009-01-19 Simon Fraser <simon.fraser@apple.com> · f910e76e
      simon.fraser@apple.com authored
              Build fix: remove duplicate entries in the Xcode project, and
              sort the project with ort-Xcode-project-file .
      
              * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f910e76e
    • simon.fraser@apple.com's avatar
      2009-01-19 Simon Fraser <simon.fraser@apple.com> · 3f6bb38e
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt
      
              https://bugs.webkit.org/show_bug.cgi?id=18078
      
              Support animations and transitions of shorthand properties by creating
              PropertyWrappers that simply wrap a vector of atomci wrappers, and implement
              equal() and blend(). Build that collection of shorthand wrappers using the
              shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
              shorthand wrappers during 'all' transitions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f6bb38e
    • oliver@apple.com's avatar
      Actually add the new header. · d04e1ca2
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d04e1ca2
    • oliver@apple.com's avatar
      2009-01-19 David Levin <levin@chromium.org> · 5ec1362c
      oliver@apple.com authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=22720
      
              Provide a generic class to handle the pattern of task callbacks across worker/parent threads.  It
              only works for methods that need 6 parameters but similar classes could be added as needed for
              other numbers of parameters.
      
              Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.
      
              Use these methods and others to remove document() from XMLHttpRequest in a few more places.
      
              No observable change in behavior, so no test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ec1362c
    • beidson@apple.com's avatar
      2009-01-19 Brady Eidson <beidson@apple.com> · ace6f584
      beidson@apple.com authored
              Rubberstamped by Tim Hatcher
      
              Fix long standing typo.
      
              * History/WebBackForwardList.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ace6f584
    • aroben@apple.com's avatar
      Add links to some recommended Visual Studio hotfixes · 1d9b7761
      aroben@apple.com authored
              Reviewed by Dave Hyatt.
      
              * building/tools.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d9b7761
    • ap@webkit.org's avatar
      Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417. · 14161d4d
      ap@webkit.org authored
              * fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14161d4d
    • cfleizach@apple.com's avatar
    • ap@webkit.org's avatar
      Reviewed by Anders Carlsson. · ad55abef
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=23417
              Implement application cache obsolete state
      
              Test: http/tests/appcache/remove-cache.html
      
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              (WebCore::JSDOMApplicationCache::mark):
              * dom/EventNames.h:
              * loader/appcache/DOMApplicationCache.h:
              (WebCore::DOMApplicationCache::Status):
              (WebCore::DOMApplicationCache::setOnobsolete):
              (WebCore::DOMApplicationCache::onobsolete):
              * loader/appcache/DOMApplicationCache.idl:
              Added "obsolete" event and status.
      
              * loader/appcache/ApplicationCacheGroup.h:
              (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer
              any need to track what the newest cache was during teardown.
              (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing
              confusion with cache group lifecycle status.
              (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete.
              (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does
              not belong to an obsolete group.
              (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto.
              (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen
              via a JS swapCache() call, not only when the loader is destroyed.
              (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer.
              (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is
              a caller responsibility, because this method is also used when loading caches from disk.
              (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and
              inform cache storage, so that it could be removed.
              (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did
              was call cacheUpdateFailed().
              (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure
              handing.
              (WebCore::ApplicationCacheGroup::didFail): Ditto.
              (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound()
              method for 404 and 410 responses.
              (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed()
              directly, instead of the removed didFailToLoadManifest().
              (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm.
              (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage
              after update successfully finishes (moved from setNewestCache()).
              (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using
              an explicitly passed pointer, without the need to save it during teardown.
      
              * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader):
              Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
      
              * loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated
              some comments.
      
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not
              obsolete.
              (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
              (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete
              groups, as they cannot be in storage.
              (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage
              completely, so that a new one could replace it, if necessary.
              (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions.
              (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
      
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state.
              (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the
              application was removed server-side.
              (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
      
              * loader/appcache/DOMApplicationCache.h:
              (WebCore::DOMApplicationCache::Status):
              (WebCore::DOMApplicationCache::setOnobsolete):
              (WebCore::DOMApplicationCache::onobsolete):
              Added support for OBSOLETE state and obsolete event.
      
              * loader/appcache/DOMApplicationCache.idl: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad55abef
    • andersca@apple.com's avatar
      2009-01-19 Anders Carlsson <andersca@apple.com> · 07b8183e
      andersca@apple.com authored
              Reviewed by Kevin Decker.
      
              Allow plug-in views to return an instance directly.
              
              * bindings/js/ScriptControllerMac.mm:
              (WebCore::ScriptController::createScriptInstanceForWidget):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07b8183e
    • cfleizach@apple.com's avatar
    • aroben@apple.com's avatar
      Windows build fix · 90668856
      aroben@apple.com authored
      WebCore:
      
              Windows build fix
      
              * WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into
              $WebKitOutputDir so that WebKit can access them.
      
              * html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild
              and header copy.
      
      WebKit/win:
      
              Windows build fix
      
              * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
              individual using directives for each type we need from that namespace,
              to avoid conflicts between DOMObject and WebCore::DOMObject.
              (DOMElement::font): Added a now-needed WebCore::.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90668856
    • ariya@webkit.org's avatar
      2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com> · faa84c8f
      ariya@webkit.org authored
              Reviewed by Simon Hausmann.
      
              http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry
      
              [Qt] Show focus rect when a button gets the focus for the first time.
              This is important at least for Windows style.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::applyTheme):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faa84c8f
    • hausmann@webkit.org's avatar
      2009-01-19 Simon Hausmann <simon.hausmann@nokia.com> · 7d31a8b8
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Fix calling of onkeypress event handlers on input elements when pressing enter
              and other text insertion commands in the Qt port.
      
              Similar to the win and mac ports don't execute text inserting editor
              commands on RawKeyDown but continue processing the event first in
              WebCore, i.e. also get a keypress event sent. If unhandled it will
              come back to EditorClientQt::handleKeyboardEvent later and we execute
              it then.
      
              This also fixes search by pressing enter on www.trafikanten.no.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d31a8b8
    • ariya@webkit.org's avatar
      2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com> · ab9f2994
      ariya@webkit.org authored
              [Qt] Build fix after r39971.
      
              * platform/qt/LoggingQt.cpp:
              (WebCore::InitializeLoggingChannelsIfNecessary):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab9f2994
    • mrowe@apple.com's avatar
      Fix the build! · 57fb06a1
      mrowe@apple.com authored
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::demarshalValue):
      (WebKit::NetscapePluginInstanceProxy::demarshalValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57fb06a1
    • weinig@apple.com's avatar
      2009-01-18 Sam Weinig <sam@webkit.org> · 61df42ed
      weinig@apple.com authored
              Reviewed by Cameron Zwarich.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
              Remove FramePrivate
      
              Minor PLT speedup.
      
              * WebCore.base.exp:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/FrameLoader.cpp:
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              (WebCore::Frame::~Frame):
              (WebCore::Frame::init):
              (WebCore::Frame::loader):
              (WebCore::Frame::view):
              (WebCore::Frame::setView):
              (WebCore::Frame::script):
              (WebCore::Frame::document):
              (WebCore::Frame::setDocument):
              (WebCore::Frame::settings):
              (WebCore::Frame::selection):
              (WebCore::Frame::editor):
              (WebCore::Frame::selectionGranularity):
              (WebCore::Frame::setSelectionGranularity):
              (WebCore::Frame::dragCaretController):
              (WebCore::Frame::animation):
              (WebCore::Frame::mark):
              (WebCore::Frame::setMark):
              (WebCore::Frame::setCaretVisible):
              (WebCore::Frame::clearCaretRectIfNeeded):
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::caretBlinkTimerFired):
              (WebCore::Frame::paintCaret):
              (WebCore::Frame::paintDragCaret):
              (WebCore::Frame::zoomFactor):
              (WebCore::Frame::isZoomFactorTextOnly):
              (WebCore::Frame::shouldApplyTextZoom):
              (WebCore::Frame::shouldApplyPageZoom):
              (WebCore::Frame::setZoomFactor):
              (WebCore::Frame::setPrinting):
              (WebCore::Frame::setJSStatusBarText):
              (WebCore::Frame::setJSDefaultStatusBarText):
              (WebCore::Frame::jsStatusBarText):
              (WebCore::Frame::jsDefaultStatusBarText):
              (WebCore::Frame::setNeedsReapplyStyles):
              (WebCore::Frame::needsReapplyStyles):
              (WebCore::Frame::reapplyStyles):
              (WebCore::Frame::isContentEditable):
              (WebCore::Frame::updateSecureKeyboardEntryIfActive):
              (WebCore::Frame::typingStyle):
              (WebCore::Frame::setTypingStyle):
              (WebCore::Frame::clearTypingStyle):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::applyEditingStyleToBodyElement):
              (WebCore::Frame::removeEditingStyleFromBodyElement):
              (WebCore::Frame::keepAlive):
              (WebCore::Frame::cancelAllKeepAlive):
              (WebCore::Frame::clearDOMWindow):
              (WebCore::Frame::ownerElement):
              (WebCore::Frame::ownerRenderer):
              (WebCore::Frame::isDisconnected):
              (WebCore::Frame::setIsDisconnected):
              (WebCore::Frame::excludeFromTextSearch):
              (WebCore::Frame::setExcludeFromTextSearch):
              (WebCore::Frame::selectionBounds):
              (WebCore::Frame::selectionTextRects):
              (WebCore::Frame::isFrameSet):
              (WebCore::Frame::currentForm):
              (WebCore::Frame::forceLayout):
              (WebCore::Frame::sendScrollEvent):
              (WebCore::Frame::clearTimers):
              (WebCore::Frame::styleForSelectionStart):
              (WebCore::Frame::inViewSourceMode):
              (WebCore::Frame::setInViewSourceMode):
              (WebCore::Frame::markAllMatchesForText):
              (WebCore::Frame::markedTextMatchesAreHighlighted):
              (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
              (WebCore::Frame::tree):
              (WebCore::Frame::setDOMWindow):
              (WebCore::Frame::domWindow):
              (WebCore::Frame::clearFormerDOMWindow):
              (WebCore::Frame::page):
              (WebCore::Frame::eventHandler):
              (WebCore::Frame::pageDestroyed):
              (WebCore::Frame::disconnectOwnerElement):
              (WebCore::Frame::documentAtPoint):
              * page/Frame.h:
              * page/FramePrivate.h: Removed.
              * page/FrameTree.h:
              * page/chromium/FrameChromium.cpp:
              * page/mac/FrameMac.mm:
              (WebCore::Frame::imageFromRect):
              (WebCore::Frame::selectionImage):
              (WebCore::Frame::snapshotDragImage):
              (WebCore::Frame::nodeImage):
              (WebCore::Frame::setUserStyleSheetLocation):
              (WebCore::Frame::setUserStyleSheet):
              * page/qt/FrameQt.cpp:
              (WebCore::Frame::setUserStyleSheetLocation):
              (WebCore::Frame::setUserStyleSheet):
              * page/win/FrameCGWin.cpp:
              (WebCore::Frame::nodeImage):
              * page/win/FrameWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61df42ed
  2. 18 Jan, 2009 2 commits
  3. 17 Jan, 2009 15 commits
    • sfalken@apple.com's avatar
      Build fix. · ed7b690f
      sfalken@apple.com authored
              * WebCoreSupport/WebDragClient.cpp:
              (WebDragClient::createDragImageForLink):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed7b690f
    • sfalken@apple.com's avatar
      Build fix. · 655fdd00
      sfalken@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      655fdd00
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · aeb42f2c
      hyatt@apple.com authored
              Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin.  isTextNode()
              on Node is now non-virtual and just checks a bit that is set at construction time by Text.
      
              Reviewed by Sam Weinig
      
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::CharacterData):
              * dom/CharacterData.h:
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::EventTargetNode):
              * dom/EventTargetNode.h:
              * dom/Node.cpp:
              (WebCore::Node::Node):
              * dom/Node.h:
              (WebCore::Node::isTextNode):
              (WebCore::Node::isAttributeNode):
              * dom/Text.cpp:
              (WebCore::Text::Text):
              * dom/Text.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeb42f2c
    • hyatt@apple.com's avatar
      Fix failing CSS Selector layout test. Don't test first-letter in a text test,... · 2786a149
      hyatt@apple.com authored
      Fix failing CSS Selector layout test.  Don't test first-letter in a text test, since that causes some of the selector text to be lost.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2786a149
    • hyatt@apple.com's avatar
      WebCore: · cbe8fced
      hyatt@apple.com authored
      2009-01-17  David Hyatt  <hyatt@apple.com>
      
              Change how backslashAsCurrencySymbol() works.  Instead of forcing call sites to do the direct
              replacement themselves, the exact transformation is instead done by the encoding (indirectly through
              a method on Document).
      
              These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
              a slight speedup, and also allow encodings to do future alterations to displayed string content without
              having to patch call sites again.
      
              Reviewed by Oliver Hunt
      
              * WebCore.base.exp:
              * dom/Document.cpp:
              * dom/Document.h:
              (WebCore::Document::displayStringModifiedByEncoding):
              (WebCore::Document::displayBufferModifiedByEncoding):
              * editing/Editor.cpp:
              (WebCore::Editor::addToKillRing):
              * editing/TextIterator.cpp:
              (WebCore::plainTextToMallocAllocatedBuffer):
              (WebCore::plainText):
              * editing/TextIterator.h:
              * html/HTMLOptGroupElement.cpp:
              (WebCore::HTMLOptGroupElement::groupLabelText):
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::text):
              * loader/DocumentLoader.cpp:
              (WebCore::canonicalizedTitle):
              * page/Chrome.cpp:
              (WebCore::displayString):
              (WebCore::Chrome::runJavaScriptAlert):
              (WebCore::Chrome::runJavaScriptConfirm):
              (WebCore::Chrome::runJavaScriptPrompt):
              (WebCore::Chrome::setStatusbarText):
              * page/Frame.cpp:
              (WebCore::Frame::shouldClose):
              * page/Frame.h:
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeSelection):
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::encode):
              * platform/text/TextEncoding.cpp:
              (WebCore::TextEncoding::TextEncoding):
              * platform/text/TextEncoding.h:
              (WebCore::TextEncoding::displayString):
              (WebCore::TextEncoding::displayBuffer):
              * rendering/HitTestResult.cpp:
              (WebCore::displayString):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::paintReplaced):
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderText.cpp:
              (WebCore::RenderText::RenderText):
              (WebCore::RenderText::setTextInternal):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::setInnerTextValue):
              (WebCore::RenderTextControl::finishText):
      
      WebKit/mac:
      
      2009-01-17  David Hyatt  <hyatt@apple.com>
      
              Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
              are done in WebCore instead.
      
              Reviewed by Oliver Hunt
      
              * WebView/WebFrame.mm:
              (-[WebFrame _selectedString]):
              (-[WebFrame _stringForRange:]):
      
      WebKit/win:
      
      2009-01-17  David Hyatt  <hyatt@apple.com>
      
              Eliminate dependencies on backslashAsCurrencySymbol from WebKit.
      
              Reviewed by Oliver Hunt
      
              * WebFrame.cpp:
              (WebFrame::selectedString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbe8fced
    • eric.carlson@apple.com's avatar
      2009-01-17 Eric Carlson <eric.carlson@apple.com> · 01646cae
      eric.carlson@apple.com authored
              Reviewed by Adele Peterson
      
              Complete <rdar://problem/6293969>
      
              * DerivedSources.make: include mediaControlsQT.css for Mac build.
      
              * WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
      
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart, 
              CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
              * css/CSSSelector.h: 
              (WebCore::CSSSelector::): Ditto.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):  include new media 
              controller element styles
      
              * css/CSSValueKeywords.in: add keywords for new media time display controls
      
              * css/mediaControls.css: adjust css for new control elements
      
              * css/mediaControlsQT.css: Added.
      
              * platform/ThemeTypes.h:
              (WebCore::): add media time display controls to ControlPart
      
              * platform/mac/WebCoreSystemInterface.h:
              * platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added
              (WebCore::MediaTextDisplayElement::attachToParent): Added
              (WebCore::MediaTextDisplayElement::update): Added
              (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added
              (WebCore::MediaControlInputElement::MediaControlInputElement): Added
              (WebCore::MediaControlInputElement::hitTest): Added
              (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when
              dragging the thumb
              * rendering/MediaControlElements.h:
              (WebCore::): Add MediaTextDisplayElement
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::createTimelineContainer): Added
              (WebCore::RenderMedia::createTimeline): Parent is now the timeline container
              (WebCore::RenderMedia::createCurrentTimeDisplay): Added
              (WebCore::RenderMedia::createTimeRemainingDisplay): Added
              (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update
              timer when the time display elements are not visible
              (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes
              (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not
              visible. Display time remaining as well as current time.
              (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when
              visibility changes
              (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
              as we can't assume that all controls are rectangular
              * rendering/RenderMedia.h: Updated
      
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call 
              element hitTest() method instead of assuming it is rectangular
              * rendering/RenderSlider.h: make mouseEventIsInThumb virtual
      
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::paint): Deal with time display and timeline container
              * rendering/RenderTheme.h:
              (WebCore::RenderTheme::paintMediaTimelineContainer): Updated
              (WebCore::RenderTheme::paintMediaCurrentTime): Added
              (WebCore::RenderTheme::paintMediaTimeRemaining): Added
      
              * rendering/RenderThemeMac.h: Updated
              * rendering/RenderThemeMac.mm:
              (WebCore::):
              (WebCore::mediaControllerTheme):
              (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb
              size when appropriate
              (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function
              (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto
              (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto
              (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto
              (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto
              (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto
              (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto
              (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added
              (WebCore::RenderThemeMac::paintMediaCurrentTime): Added
              (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added
              (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added
              (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
              * rendering/style/RenderStyle.h: Updated
              (WebCore::):
      
      2009-01-17  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson
      
              Complete <rdar://problem/6293969>
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface): Remove UseSharedMediaUI
      
      2009-01-17  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson
      
              <rdar://problem/6293969>
              Update media controls rendering results for new controls CSS.
      
              * platform/mac/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/video-controls-rendering-expected.txt:
              * platform/mac/media/video-display-toggle-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01646cae
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · d744bc3e
      hyatt@apple.com authored
              Inline a few methods in FrameView for speed.
      
              Reviewed by Oliver Hunt
      
              * page/FrameView.cpp:
              * page/FrameView.h:
              (WebCore::FrameView::layoutCount):
              (WebCore::FrameView::needsFullRepaint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d744bc3e
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · 91463174
      hyatt@apple.com authored
              Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot().  Split off
              the code that fetches and caches the document element into a separate function and inline the part that
              does the null check and the return of the already-cached element.
      
              Reviewed by Oliver Hunt
      
              * dom/Document.cpp:
              (WebCore::Document::cacheDocumentElement):
              * dom/Document.h:
              (WebCore::Document::documentElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91463174
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · 36abe815
      hyatt@apple.com authored
              Minor tweaks to RenderBox::styleChange to speed it up.
      
              Reviewed by Oliver Hunt
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleDidChange):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36abe815
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · 919ddcc3
      hyatt@apple.com authored
              Inline FrameLoader::client().
      
              Reviewed by Oliver Hunt
      
              * WebCore.base.exp:
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::client):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      919ddcc3
    • hyatt@apple.com's avatar
      isNull() should be size().isEmpty(). Duh. · a9fea641
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9fea641
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · 9b7832fb
      hyatt@apple.com authored
              Inline some Image methods for speed.  Fix CachedImage's addClient method to just use isNull rather
              than needlessly creating a rect.
      
              Reviewed by Oliver Hunt
      
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::addClient):
              * platform/graphics/Image.cpp:
              * platform/graphics/Image.h:
              (WebCore::Image::isNull):
              (WebCore::Image::rect):
              (WebCore::Image::width):
              (WebCore::Image::height):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b7832fb
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · 1d5d0252
      hyatt@apple.com authored
              Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.
      
              Reviewed by Oliver Hunt
      
              * css/CSSParserValues.cpp:
              (WebCore::CSSParserValueList::addValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d5d0252
    • hyatt@apple.com's avatar
      2009-01-17 David Hyatt <hyatt@apple.com> · 5515a958
      hyatt@apple.com authored
              Inline Document::inPageCache(), since - because of animation code - it is now called every time
              styles change on any element and so is now super-hot.
      
              Reviewed by Oliver Hunt
      
              * dom/Document.cpp:
              * dom/Document.h:
              (WebCore::Document::inPageCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5515a958
    • hyatt@apple.com's avatar
      2009-01-16 David Hyatt <hyatt@apple.com> · 1e14767d
      hyatt@apple.com authored
              Take Font out of the GraphicsContext.  Fonts are moderately expensive to both compare and to assign to.
              The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
              and was also causing expensive comparison checks to be made before doing alterations of the Font in the
              GraphicsContext.
      
              A font must now be passed as a parameter to all text drawing functions.
      
              Reviewed by Oliver Hunt
      
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::setFont):
              (WebCore::CanvasRenderingContext2D::drawTextInternal):
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawText):
              (WebCore::GraphicsContext::drawBidiText):
              (WebCore::GraphicsContext::drawHighlightForText):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/GraphicsContextPrivate.h:
              * platform/graphics/qt/GraphicsContextQt.cpp:
              * rendering/EllipsisBox.cpp:
              (WebCore::EllipsisBox::paint):
              * rendering/InlineTextBox.cpp:
              (WebCore::paintTextWithShadows):
              (WebCore::InlineTextBox::paint):
              (WebCore::InlineTextBox::paintSelection):
              (WebCore::InlineTextBox::paintCompositionBackground):
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
              (WebCore::InlineTextBox::paintTextMatchMarker):
              (WebCore::InlineTextBox::paintDocumentMarkers):
              * rendering/InlineTextBox.h:
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::paintObject):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::paintReplaced):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::paintItemForeground):
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::paint):
              * rendering/SVGInlineTextBox.cpp:
              (WebCore::SVGInlineTextBox::paintCharacters):
              (WebCore::SVGInlineTextBox::paintSelection):
              * rendering/SVGInlineTextBox.h:
              * svg/SVGFont.cpp:
              (WebCore::Font::drawTextUsingSVGFont):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e14767d
  4. 16 Jan, 2009 1 commit