1. 12 Mar, 2008 37 commits
    • mrowe@apple.com's avatar
      Fix Gtk and Qt builds. · 3964bf45
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3964bf45
    • mrowe@apple.com's avatar
      Mac build fix. · 998fc45e
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      998fc45e
    • sfalken@apple.com's avatar
      Build fix. · dcc3651e
      sfalken@apple.com authored
              * page/win/FrameWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcc3651e
    • sfalken@apple.com's avatar
      Build fix. · 500c4ad7
      sfalken@apple.com authored
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::bindingInstance):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      500c4ad7
    • adachan@apple.com's avatar
      <rdar://problem/5795843> · f1f4e23e
      adachan@apple.com authored
              CFURLDownload needs to be cancelled if we don't have a destination path
              to save resume information.
      
              Reviewed by Brady.
      
              * WebDownload.cpp:
              (WebDownload::cancelForResume):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1f4e23e
    • darin@apple.com's avatar
      WebCore: · b46f9fdd
      darin@apple.com authored
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17640
                eliminate WebCoreFrameBridge
      
              * WebCore.base.exp: Added more exports, needed by code moved from WebCoreFrameBridge
              to WebFrame in WebKit.
              * WebCore.xcodeproj/project.pbxproj: Added more headers, same reason. Also deleted
              WebCoreFrameBridge.h and WebCoreFrameBridge.mm.
      
              * page/Frame.cpp:
              (WebCore::Frame::Frame): Added call to initJavaJSBindings(), formerly handled by
              the WebCoreFrameBridge.
              * page/Frame.h: Added initJavaJSBindings function.
      
              * page/mac/FrameMac.mm:
              (WebCore::updateRenderingForBindings): Moved here from WebCoreFrameBridge.
              (WebCore::Frame::initJavaJSBindings): Ditto; code was in the init function.
      
              * page/mac/WebCoreFrameBridge.h: Removed.
              * page/mac/WebCoreFrameBridge.mm: Removed.
      
      WebKit:
      
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17640
                eliminate WebCoreFrameBridge
      
              * StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebKit.xcodeproj/project.pbxproj: Removed WebFrameBridge.h and WebFrameBridge.mm.
      
      WebKit/mac:
      
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17640
                eliminate WebCoreFrameBridge
      
              Moved all the code from the bridge into WebFrame. This need not be the final
              home of these methods -- they can be moved closer to their callers and improved
              further -- but it eliminates the bridge without requiring a rewrite of the code.
              It's a fairly mechanical process (just adding underscores to method names really).
      
              There's even a chance that some of the methods are unused. Those we can remove
              after checking if that's so.
      
              * DOM/WebDOMOperations.mm:
              (-[DOMNode markupString]): Use WebFrame rather than bridge.
              (-[DOMDocument webFrame]): Changed to use the core and kit functions
              instead of using the bridge.
              (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
              (-[DOMRange markupString]): Ditto.
              * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
              * History/WebHistoryItem.mm: Ditto.
      
              * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
      
              * Misc/WebElementDictionary.mm: Removed unneeded import.
      
              * Misc/WebKitStatistics.m:
              (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
              * Misc/WebKitStatisticsPrivate.h: Ditto.
      
              * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
              * Misc/WebNSPasteboardExtras.mm: Ditto.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
              rather than bridge.
      
              * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
              * Plugins/WebNetscapePluginStream.mm: Ditto.
      
              * Plugins/WebPluginContainerCheck.mm:
              (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
              bridge to get to the WebCore::Frame.
      
              * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
              * Plugins/WebPluginController.mm:
              (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
              rather than bridge.
      
              * WebCoreSupport/WebEditorClient.mm:
              (selectorForKeyEvent): Tweaked comment.
      
              * WebCoreSupport/WebFrameBridge.h: Removed.
              * WebCoreSupport/WebFrameBridge.mm: Removed.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
              (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
              I could remove this function entirely, but it looks like the Qt port is using it.
      
              * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
      
              * WebView/WebArchiver.mm:
              (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
              (+[WebArchiver archiveNode:]): Ditto.
              (+[WebArchiver archiveSelectionInFrame:]): Ditto.
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
              (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
              (-[WebDataSource subresources]): Ditto.
              (-[WebDataSource subresourceForURL:]): Ditto.
      
              * WebView/WebDataSourceInternal.h: Removed _bridge method.
      
              * WebView/WebFrame.mm:
              (-[WebFramePrivate dealloc]): Removed code to release the bridge.
              (core): Go directly to the core frame, not via the bridge.
              (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
              Remove the code to deal with the bridge.
              (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
              shouldCreateRenderers flag, formerly on the bridge.
              (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
              (aeDescFromJSValue): Moved here from bridge.
              (-[WebFrame _domain]): Ditto.
              (-[WebFrame _addData:]): Ditto.
              (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
              (-[WebFrame _nodesFromList:]): Ditto.
              (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
              (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
              (-[WebFrame _selectedString]): Ditto.
              (-[WebFrame _stringForRange:]): Ditto.
              (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
              (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
              (-[WebFrame _sendScrollEvent]): Ditto.
              (-[WebFrame _drawRect:]): Ditto.
              (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
              (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
              (-[WebFrame _copyRenderNode:copier:]): Ditto.
              (-[WebFrame _copyRenderTree:]): Ditto.
              (inputElementFromDOMElement): Ditto.
              (formElementFromDOMElement): Ditto.
              (-[WebFrame _elementWithName:inForm:]): Ditto.
              (-[WebFrame _elementDoesAutoComplete:]): Ditto.
              (-[WebFrame _elementIsPassword:]): Ditto.
              (-[WebFrame _formForElement:]): Ditto.
              (-[WebFrame _currentForm]): Ditto.
              (-[WebFrame _controlsInForm:]): Ditto.
              (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
              (-[WebFrame _matchLabels:againstElement:]): Ditto.
              (-[WebFrame _URLWithAttributeString:]): Ditto.
              (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
              (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
              (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
              (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
              (-[WebFrame _unmarkAllTextMatches]): Ditto.
              (-[WebFrame _rectsForTextMatches]): Ditto.
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
              (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
              (-[WebFrame _firstRectForDOMRange:]): Ditto.
              (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
              (-[WebFrame _baseURL]): Ditto.
              (-[WebFrame _stringWithData:]): Ditto.
              (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
              (-[WebFrame _needsLayout]): Ditto.
              (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
              (-[WebFrame _accessibilityTree]): Ditto.
              (-[WebFrame _setBaseBackgroundColor:]): Ditto.
              (-[WebFrame _setDrawsBackground:]): Ditto.
              (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
              Ditto.
              (-[WebFrame _selectionGranularity]): Ditto.
              (-[WebFrame _convertToNSRange:]): Ditto.
              (-[WebFrame _convertToDOMRange:]): Ditto.
              (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
              (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
              (-[WebFrame _markDOMRange]): Ditto.
              (-[WebFrame _markedTextNSRange]): Ditto.
              (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
              (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
              (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
              (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
              (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
              (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
              (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
              (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
              (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
              (-[WebFrame _visiblePositionForPoint:]): Ditto.
              (-[WebFrame _characterRangeAtPoint:]): Ditto.
              (-[WebFrame _typingStyle]): Ditto.
              (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
              (-[WebFrame _fontForSelection:]): Ditto.
              (-[WebFrame _dragSourceMovedTo:]): Ditto.
              (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
              (-[WebFrame _getData:andResponse:forURL:]): Ditto.
              (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
              (-[WebFrame _canProvideDocumentSource]): Ditto.
              (-[WebFrame _canSaveAsWebArchive]): Ditto.
              (-[WebFrame _receivedData:textEncodingName:]): Ditto.
              (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
              function. Couldn't just keep the bridge method because this was already here with the same name.
              (-[WebFrame _selectedNSRange]): Ditto.
              (-[WebFrame _selectNSRange:]): Ditto.
              (-[WebFrame dealloc]): Remove bridge-related code.
              (-[WebFrame finalize]): Ditto.
      
              * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
              Removed the bridge parameter from the init method. Removed the #if blocks that
              tried to make this header work in non-C++ ObjC files -- they were broken and unused.
              Removed the _bridge method.
      
              * WebView/WebFrameView.mm: Removed the _bridge method.
      
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
              field.
              (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
              (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
              (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
              (-[WebHTMLRepresentation documentSource]): Ditto.
              (-[WebHTMLRepresentation DOMDocument]): Ditto.
              (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
              (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
              (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
              (-[WebHTMLRepresentation formForElement:]): Ditto.
              (-[WebHTMLRepresentation currentForm]): Ditto.
              (-[WebHTMLRepresentation controlsInForm:]): Ditto.
              (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
              (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
      
              * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
              (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
              (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
              (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
              (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
              (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
              (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
              (-[WebHTMLView drawSingleRect:]): Ditto.
              (-[WebHTMLView draggedImage:movedTo:]): Ditto.
              (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
              (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
              (-[WebHTMLView knowsPageRange:]): Ditto.
              (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
              (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
              (-[WebHTMLView accessibilityHitTest:]): Ditto.
              (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
              (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
              (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
              (-[WebHTMLView _changeSpellingToWord:]): Ditto.
              (-[WebHTMLView startSpeaking:]): Ditto.
              (-[WebHTMLView _updateFontPanel]): Ditto.
              (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
              (-[WebHTMLView _layoutIfNeeded]): Ditto.
              (-[WebHTMLView characterIndexForPoint:]): Ditto.
              (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
              (-[WebHTMLView selectedRange]): Ditto.
              (-[WebHTMLView markedRange]): Ditto.
              (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
              (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
              (-[WebHTMLView insertText:]): Ditto.
              (-[WebTextCompleteController _insertMatch:]): Ditto.
              (-[WebTextCompleteController doCompletion]): Ditto.
              (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
              (-[WebHTMLView string]): Ditto.
              (-[WebHTMLView selectedString]): Ditto.
              (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
              (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
              (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
              (-[WebHTMLView unmarkAllTextMatches]): Ditto.
              (-[WebHTMLView rectsForTextMatches]): Ditto.
              * WebView/WebRenderNode.mm:
              (-[WebRenderNode initWithWebFrameView:]): Ditto.
              * WebView/WebResource.mm:
              (-[WebResource _stringValue]): Ditto.
      
              * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
      
              * WebView/WebView.mm:
              (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
              (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
              (-[WebView _setInViewSourceMode:]): Ditto.
              (-[WebView _inViewSourceMode]): Ditto.
              (-[WebView _executeCoreCommandByName:value:]): Ditto.
              (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebView scrollDOMRangeToVisible:]): Ditto.
              (-[WebView setSelectedDOMRange:affinity:]): Ditto.
              (-[WebView setEditable:]): Ditto.
              (-[WebView setTypingStyle:]): Ditto.
              (-[WebView typingStyle]): Ditto.
              (-[WebView replaceSelectionWithNode:]): Ditto.
              (-[WebView replaceSelectionWithText:]): Ditto.
              (-[WebView replaceSelectionWithMarkupString:]): Ditto.
              (-[WebView replaceSelectionWithArchive:]): Ditto.
              (-[WebView _insertNewlineInQuotedContent]): Ditto.
              (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b46f9fdd
    • weinig@apple.com's avatar
      Reviewed by Anders Carlsson. · a244a871
      weinig@apple.com authored
              Don't go through the Document just to get the frame Element.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::frameElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a244a871
    • andersca@apple.com's avatar
      Reviewed by Geoff and Sam. · 94b36ca4
      andersca@apple.com authored
              More Instance cleanup:
              
              * Make Instance inherit from RefCounted instead of doing its own refcounting.        
              * Make all Instance subclasses private, add static create methods.         
              * Have Instance start out with a refcount of 1.
              * Get rid of Instance::createBindingForLanguageInstance and call the individual 
                instance constructor methods instead.
              * Fix many methods to take and return PassRefPtr<Instance> to ensure that the
                refcounting is done correctly.
               
              * bridge/c/c_instance.h:
              (KJS::Bindings::CInstance::create):
              * bridge/c/c_utility.cpp:
              (KJS::Bindings::convertNPVariantToValue):
              * bridge/jni/jni_instance.cpp:
              (JavaInstance::invokeMethod):
              * bridge/jni/jni_instance.h:
              (KJS::Bindings::JavaInstance::create):
              * bridge/jni/jni_jsobject.cpp:
              (JavaJSObject::convertJObjectToValue):
              * bridge/jni/jni_runtime.cpp:
              (JavaField::valueFromInstance):
              (JavaArray::valueAt):
              * bridge/objc/objc_instance.h:
              (KJS::Bindings::ObjcInstance::create):
              * bridge/objc/objc_utility.mm:
              (KJS::Bindings::convertObjcValueToValue):
              * bridge/qt/qt_instance.cpp:
              (KJS::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp):
              (KJS::Bindings::QtInstance::getQtInstance):
              (KJS::Bindings::QtInstance::getRuntimeObject):
              * bridge/qt/qt_instance.h:
              * bridge/runtime.cpp:
              (KJS::Bindings::Instance::Instance):
              (KJS::Bindings::Instance::createRuntimeObject):
              * bridge/runtime.h:
              * bridge/runtime_object.cpp:
              (RuntimeObjectImp::RuntimeObjectImp):
              * bridge/runtime_object.h:
              * page/Frame.h:
              * page/mac/FrameMac.mm:
              (WebCore::Frame::createScriptInstanceForWidget):
              * page/win/FrameWin.cpp:
              (WebCore::Frame::createScriptInstanceForWidget):
              * plugins/PluginView.h:
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::bindingInstance):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94b36ca4
    • mitz@apple.com's avatar
      Suggested by Darin Adler. Reviewed by Dave Hyatt. · 5c2e0e0b
      mitz@apple.com authored
              - speed up BidiIterator::direction()
      
              * rendering/bidi.cpp:
              (WebCore::BidiIterator::current): Made inline and corrected the
              out-of-bounds condition to work with 0-length text and offsets beyond
              the end of the text.
              (WebCore::BidiIterator::direction): Changed to call current() and not
              call the virtual method isListMarker() most of the time.
              (WebCore::addMidpoint): Removed unnecessary null-check of smidpoints.
              (WebCore::appendRunsForObject): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c2e0e0b
    • aroben@apple.com's avatar
      Make URLs not be underlined while editing them in the DOM view · 0e18dca7
      aroben@apple.com authored
              Reviewed by Tim.
      
              * page/inspector/inspector.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e18dca7
    • aroben@apple.com's avatar
      Part of Bug 17224: DOM nodes/attributes should be editable · dd8efb96
      aroben@apple.com authored
              <http://bugs.webkit.org/show_bug.cgi?id=17224>
              <rdar://problem/5732825>
      
              We now start editing if the user single-clicks on an attribute,
              attribute value, or text node while the parent element is selected.
              Previously, we started editing on double-click regardless of the
              selection state of the element.
      
              URLs in the DOM tree are now followed on Alt/Option-click, rather than
              on just click.
      
              Reviewed by Tim.
      
              * English.lproj/InspectorLocalizedStrings.js: Added four new localized
              strings.
              * page/inspector/DocumentPanel.js:
              (WebInspector.DOMNodeTreeElement.onattach): Call new
              _makeURLSActivateOnModifiedClick.
              (WebInspector.DOMNodeTreeElement._makeURLsActivateOnModifiedClick):
              Added. Changes the tooltip of each link in this element to indicate
              that Alt/Option-click will follow the URL, and sets the
              followOnAltClick property on each link.
              (WebInspector.DOMNodeTreeElement.onselect): Mark that we're being
              selected.
              (WebInspector.DOMNodeTreeElement.onmousedown): If we're not currently
              being selected, start editing.
              (WebInspector.DOMNodeTreeElement.ondblclick): We no longer start
              editing here. We block re-rooting of the tree if we're currently
              editing.
              (WebInspector.DOMNodeTreeElement._startEditing):
                - Don't do anything if we're not focused
                - Pass the event down to _startEditingAttribute.
              (WebInspector.DOMNodeTreeElement._startEditingAttribute): Don't do
              anything if the event target is a URL and the Alt/Option key is
              pressed -- in this case we want to follow the link.
              (WebInspector.DOMNodeTreeElement._updateTitle): Call
              _makeURLsActivateOnClick again since the anchor elements have all been
              recreated.
              * page/inspector/inspector.js:
              (WebInspector.documentClick): If the anchor as a followOnAltClick
              property and the Alt/Option key is not pressed, do nothing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd8efb96
    • adachan@apple.com's avatar
      Fixed the initial value of zoom factor. · 6a570466
      adachan@apple.com authored
              Reviewed by Adam.
      
              * page/Frame.cpp:
              (WebCore::FramePrivate::FramePrivate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a570466
    • hyatt@apple.com's avatar
      Make full page zoom vaguely work. This patch uses the CSS transform... · db00ad98
      hyatt@apple.com authored
              Make full page zoom vaguely work.  This patch uses the CSS transform system to turn on full page zoom at the
              document level.  There are many many bugs that I'm going to file to track all the issues (most of the issues
              are just bugs with transforms themselves).
      
              Reviewed by Adam Roben
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
              * dom/Document.cpp:
              (WebCore::Document::recalcStyle):
              * page/Frame.cpp:
              (WebCore::Frame::shouldApplyTextZoom):
              (WebCore::Frame::shouldApplyPageZoom):
              * page/Frame.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPositions):
              (WebCore::RenderLayer::setHasVisibleContent):
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              * rendering/RenderLayer.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db00ad98
    • sfalken@apple.com's avatar
      Touch file to force WebKit rebuild · 61eb36ed
      sfalken@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61eb36ed
    • sfalken@apple.com's avatar
      Build fix. · e8211c60
      sfalken@apple.com authored
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8211c60
    • alp@webkit.org's avatar
      2008-03-12 Tommi Komulainen <tommi.komulainen@iki.fi> · df392e5f
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=17799
              WebView signals should use more specific types
      
              * webkit/webkitwebview.cpp: Use WEBKIT_TYPE_WEB_FRAME argument
              type in "script-alert", "script-confirm", "script-script-prompt"
              signals so that it gets more clearly documented rather than just
              plain GObject.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31004 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df392e5f
    • hyatt@apple.com's avatar
      WebCore: · 29be35f6
      hyatt@apple.com authored
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebCore.base.exp:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
              * page/Frame.cpp:
              (WebCore::Frame::zoomFactor):
              (WebCore::Frame::setZoomFactor):
              * page/Frame.h:
              * page/FramePrivate.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::currentScale):
              (WebCore::SVGSVGElement::setCurrentScale):
      
      WebKit/mac:
      
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebView/WebView.mm:
              (-[WebView _setZoomMultiplier:isTextOnly:]):
      
      WebKit/win:
      
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebFrame.cpp:
              (WebFrame::setTextSizeMultiplier):
      
      WebKit/wx:
      
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebView.cpp:
              (wxWebView::IncreaseTextSize):
              (wxWebView::DecreaseTextSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29be35f6
    • sfalken@apple.com's avatar
      Build fix. · 0cf00fd2
      sfalken@apple.com authored
              * WebKit.vcproj/WebKit.pgd:
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cf00fd2
    • hyatt@apple.com's avatar
      Speculative fix for build bustage. Will be another 20-30 mins before I can... · c3b7da19
      hyatt@apple.com authored
      Speculative fix for build bustage.  Will be another 20-30 mins before I can get compiled enough to know for sure.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3b7da19
    • sfalken@apple.com's avatar
      VSExpress build fix · 6fa02287
      sfalken@apple.com authored
              * WinLauncher/WinLauncher.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fa02287
    • hyatt@apple.com's avatar
      WebCore: · 410f7e72
      hyatt@apple.com authored
              Eliminate setTextMultiplier from the bridge.  Make Webkit just call setZoomFactor on the frame directly.
      
              Reviewed by Tim H.
      
              * WebCore.base.exp:
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
      
      WebKit/mac:
      
              This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
              New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
              can zoom the page in, out or reset it to the standard size.
      
              In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
              and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
              win.
      
              Reviewed by Tim H.
      
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
              * WebView/WebDocumentInternal.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView viewDidMoveToSuperview]):
              * WebView/WebPDFView.h:
              * WebView/WebPDFView.mm:
              (-[WebPDFView _zoomOut:]):
              (-[WebPDFView _zoomIn:]):
              (-[WebPDFView _resetZoom:]):
              (-[WebPDFView _canZoomOut]):
              (-[WebPDFView _canZoomIn]):
              (-[WebPDFView _canResetZoom]):
              * WebView/WebView.mm:
              (-[WebViewPrivate init]):
              (-[WebView setTextSizeMultiplier:]):
              (-[WebView textSizeMultiplier]):
              (-[WebView _setZoomMultiplier:isTextOnly:]):
              (-[WebView _zoomMultiplier:]):
              (-[WebView _realZoomMultiplier]):
              (-[WebView _realZoomMultiplierIsTextOnly]):
              (-[WebView _canZoomOut:]):
              (-[WebView _canZoomIn:]):
              (-[WebView _zoomOut:isTextOnly:]):
              (-[WebView _zoomIn:isTextOnly:]):
              (-[WebView _canResetZoom:]):
              (-[WebView _resetZoom:isTextOnly:]):
              (-[WebView canMakeTextSmaller]):
              (-[WebView makeTextSmaller:]):
              (-[WebView canMakeTextLarger]):
              (-[WebView makeTextLarger:]):
              (-[WebView canMakeTextStandardSize]):
              (-[WebView makeTextStandardSize:]):
              (-[WebView setPageSizeMultiplier:]):
              (-[WebView pageSizeMultiplier]):
              (-[WebView canZoomPageIn]):
              (-[WebView zoomPageIn:]):
              (-[WebView canZoomPageOut]):
              (-[WebView zoomPageOut:]):
              (-[WebView canResetPageZoom]):
              (-[WebView resetPageZoom:]):
              (-[WebView _searchWithSpotlightFromMenu:]):
              * WebView/WebViewInternal.h:
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      410f7e72
    • mitz@apple.com's avatar
      WebCore: · f8923a73
      mitz@apple.com authored
              Reviewed by Darin Adler and Sam Weinig.
      
              - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
      
              Use CTFontCopyGraphicsFont and CTFontGetPlatformFont on Leopard instead
              of wkGetCGFontFromNSFont and wkGetNSFontATSUFontId, relying on NSFont
              and CTFontRef being toll-free bridged.
      
              * WebCore.Tiger.exp:
              * WebCore.base.exp:
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::drawGlyphs): Changed to use the cgFont() accessor.
              * platform/graphics/mac/FontPlatformData.h:
              Made m_cgFont a RetainPtr on Leopard.
              (WebCore::toCTFontRef): Added a function that encapsulates the
              toll-free bridging.
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::FontPlatformData::cgFont): Added this accessor method.
              * platform/graphics/mac/FontPlatformDataMac.mm:
              (WebCore::FontPlatformData::FontPlatformData): Changed to use
              CoreText API on Leopard.
              (WebCore::FontPlatformData::setFont): Ditto.
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::initFontData):
              (WebCore::pathFromFont):
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/mac/WebCoreSystemInterface.mm:
      
      WebKit/mac:
      
              Reviewed by Darin Adler and Sam Weinig.
      
              - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
              WKGetNSFontATSUFontId Tiger-only.
      
      WebKitLibraries:
      
              Reviewed by Darin Adler and Sam Weinig.
      
              - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8923a73
    • alp@webkit.org's avatar
      2008-03-12 Holger Hans Peter Freyther <zecke@selfish.org> · d5015656
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              Run testkjs in the correct productsDir in the GTK+ port.
      
              * Scripts/run-javascriptcore-tests:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5015656
    • sfalken@apple.com's avatar
      Re-enabled PGO. · 6db497e3
      sfalken@apple.com authored
              
              Rubber stamped by Mark Rowe.
      
              * WebKit.vcproj/WebKit.pgd:
              * WebKit.vcproj/WebKit.vcproj:
              * WebKitPrefix.cpp: touched this file to force a re-build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6db497e3
    • alp@webkit.org's avatar
      2008-03-12 Alp Toker <alp@atoker.com> · 90439782
      alp@webkit.org authored
              Another autotools testkjs build fix attempt.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90439782
    • darin@apple.com's avatar
      - fix http://bugs.webkit.org/show_bug.cgi?id=17794 · 7d7b94e7
      darin@apple.com authored
                REGRESSION (r30980): 23 tests hanging on the Mac buildbot
      
              * WebView/WebFrame.mm:
              (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
              up pointer from the bridge to the frame. (My next check-in removes the bridge
              entirely, but we need this until then.)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d7b94e7
    • harrison@apple.com's avatar
      Reviewed by Darin. · 7954df21
      harrison@apple.com authored
              <rdar://problem/5607382> CrashTracer: [REGRESSION] 2290 crashes in Safari at com.apple.WebCore: -[WebCoreAXObject isWebArea] + 8
      
              The problem was that we lost track of the AX cache for a subframe when Frame::disconnectOwnerElement() was
              called, so we were unable to locate the AXObjects to de-register from AppKit's accessibility registry.
              Also saw that cache clearing was missing from Document::detach(), and fixed that.
              
              Also added a debug-only check that AXObjectCache::remove() not finding the AXObject is expected.
              
              Lastly, RenderWidget::destroy() now skips trying to remove the AXObject if accessibility has never been enabled.
             
              * dom/Document.cpp:
              (WebCore::Document::attach):
              Assert that there is no AX cache (since there is no renderer).
              
              (WebCore::Document::detach):
              Destroy the AX cache installed on this document.
              
              (WebCore::Document::clearAXObjectCache):
              New. Destroy the AX cache associated with this document.
              
              (WebCore::Document::axObjectCache):
              Added some comments.
              
              * dom/Document.h:
              Declare clearAXObjectCache().
              
              * page/Frame.cpp:
              (WebCore::Frame::disconnectOwnerElement):
              Destroy the AX cache associated with this frame's document.
              
              * page/mac/AXObjectCacheMac.mm:
              (WebCore::AXObjectCache::remove):        
              * page/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject initWithRenderer:]):
              (-[WebCoreAXObject detach]):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::RenderObject):
              (WebCore::RenderObject::~RenderObject):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::setHasAXObject):
              (WebCore::RenderObject::hasAXObject):
              Add debug-only check that AXObjectCache::remove() not finding the AXObject is expected.
              
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::destroy):
              Skip call to remove the AXObject if accessibility has never been enabled. A simple speed optimization in the
              very common case that the accessibility APIs are not being used. Same as in RenderObject::destroy().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7954df21
    • alp@webkit.org's avatar
      2008-03-12 Alp Toker <alp@atoker.com> · 347bef56
      alp@webkit.org authored
              Attempt to fix the autotools testkjs build on systems with
              non-standard include paths.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      347bef56
    • alp@webkit.org's avatar
      Credit the original patch author in the r30989 ChangeLogs · 720edd61
      alp@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      720edd61
    • alp@webkit.org's avatar
      2008-03-12 Xan Lopez <xan@gnome.org> · 7d9253a9
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=15229
      
              Add Pango font backend.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d9253a9
    • hausmann@webkit.org's avatar
      Fix compilation against Qt 4.3 · 5dfc8edc
      hausmann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dfc8edc
    • justin.garcia@apple.com's avatar
      WebCore: · 07178e16
      justin.garcia@apple.com authored
              Reviewed by Oliver.
              
              <rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list
              
              Fixes some (but not all) of the instances of:
              <rdar://problem/5659795> CrashTracer: [REGRESSION] 187 crashes in Safari at com.apple.WebCore: WebCore::InsertTextCommand::prepareForTextInsertion + 241
              <rdar://problem/5779631> CrashTracer: [USER] 25 crashes in Mail at WebCore::InsertTextCommand::prepareForTextInsertion
      
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply): applyStyle may have destroyed content that held
              the old endingSelection(), so we must recompute it.  Added a FIXME.  Added a few comments.
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply): Added a FIXME.
      
      LayoutTests:
      
              Reviewed by Oliver.
              
              <rdar://problem/5770834> Crash at InsertTextCommand::prepareForTextInsertion() doing RemoveFormat in a certain list
      
              * editing/execCommand/5770834-1-expected.txt: Added.
              * editing/execCommand/5770834-1.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07178e16
    • ap@webkit.org's avatar
      Reviewed by Darin. · 5d8232d7
      ap@webkit.org authored
              <rdar://problem/5640615> REGRESSION (Safari 2-3): Changing subframe encoding rules broke
              some sites.
      
              Other browsers' behavior keeps changing; let's implement what Firefox and Opera do now:
              if the frame and subframe belong to the same site, then the encoding is inherited from parent
              frame to subframe. Otherwise, it is not.
      
              Always inheriting the encoding would cause a security problem.
      
              Tests: http/tests/misc/frame-default-enc-different-domain.html
                     http/tests/misc/frame-default-enc-same-domain.html
                     fast/encoding/frame-default-enc.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::write): Also removed a check for m_frame->document() being non-null -
              this function also has code that uses it without checking, so it must be safe.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d8232d7
    • sfalken@apple.com's avatar
      Fix build. · 61bdd19f
      sfalken@apple.com authored
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61bdd19f
    • mrowe@apple.com's avatar
      Gtk build fix. · 92715024
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92715024
    • ap@webkit.org's avatar
      Reviewed by Darin. · bda7031c
      ap@webkit.org authored
              <rdar://problem/5787743> REGRESSION: Crash at WTF::Collator::CreateCollator() running fast/js/kde/StringObject.html on Windows
      
              * wtf/unicode/icu/CollatorICU.cpp:
              (WTF::Collator::createCollator): Check for null (== user default) m_locale before calling strcmp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bda7031c
    • sfalken@apple.com's avatar
      Touch a file in WebKitWin to cause it to build · 4020fbf3
      sfalken@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4020fbf3
  2. 11 Mar, 2008 3 commits
    • sfalken@apple.com's avatar
      JavaScriptCore: · 27e03268
      sfalken@apple.com authored
              Disable LTCG/PGO for grammar.cpp and nodes.cpp.
              PGO on these files causes us to hang.
              
              Copy newer vsprops files from relative WebKitLibraries path to environment variable based path.
              
              Reviewed by Oliver.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
      
      WebCore:
      
              Disable LTCG/PGO for all of WebCore for now.
              We'll re-enable this as part of follow-on PGO work.
              
              Reviewed by Oliver.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      WebKit/win:
      
              Use PGO to build WebKit.dll.
              
              Reviewed by Oliver.
      
              * WebKit.vcproj/WebKit.pgd: Added.
              * WebKit.vcproj/WebKit.vcproj:
      
      WebKitLibraries:
      
              Disable two PGO/LTCG specific warnings.
              
              Reviewed by Oliver.
      
              * win/tools/vsprops/common.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27e03268
    • darin@apple.com's avatar
      WebCore: · 5670fde4
      darin@apple.com authored
              Reviewed by Sam.
      
              - remove all bridge-related things from WebCore except the bridge itself
      
              * WebCore.base.exp: Removed the bridge and setBridge functions.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::detachFromParent): Removed call to the bridge's
              close method.
      
              * page/Frame.cpp:
              (WebCore::Frame::~Frame): Removed call to setBridge(0).
              (WebCore::FramePrivate::FramePrivate): Removed initialization of m_bridge.
              * page/Frame.h: Removed setBridge and bridge functions.
              * page/FramePrivate.h: Removed m_bridge pointer.
              * page/mac/FrameMac.mm: Removed setBridge and bridge functions.
      
              * page/mac/WebCoreFrameBridge.h: Added setWebCoreFrame: method.
              Removed bridgeForDOMDocument: and clearFrame methods.
              * page/mac/WebCoreFrameBridge.mm: Ditto.
              (-[WebCoreFrameBridge close]): Changed to set m_frame to 0 directly.
              (-[WebCoreFrameBridge setWebCoreFrame:]): Added.
      
      WebKit/mac:
      
              Reviewed by Sam.
      
              - remove all bridge-related things from WebCore except the bridge itself
      
              * DOM/WebDOMOperations.mm:
              (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
      
              * Plugins/WebPluginController.mm: Ditto.
      
              * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
              init and close methods. Added a setWebFrame: method.
      
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge setWebFrame:]): Added.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
              (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
              bridge here. Soon we will be able to remove this entirely!
              (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
              into WebFrame from the bridge.
      
              * WebView/WebFrame.mm:
              (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
              now owned by the frame.
              (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
              debugger under GC without this!
              (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
              use WebFrameLoaderClient instead of the bridge.
              (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
              This is code that used to live in the bridge's init function.
              (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
              (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
              (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
              the WebView is now the bridge's owner.
              (-[WebFrame _updateBackground]): Changed this one call site that was calling the
              WebCore::Frame::bridge function directly to use the kit function instead.
              (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
              This code won't last long -- we're eliminating the bridge soon.
              (-[WebFrame finalize]): Ditto.
      
              * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
              for creating frames.
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
              the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
              where we have to allocate a WebFrameBridge and then immediately release it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5670fde4
    • darin@apple.com's avatar
      WebCore: · 8a24645f
      darin@apple.com authored
              - restored some code I removed in the Range change; this code can't go
                until the rest of the Range fix is in
      
              * dom/Range.cpp:
              (WebCore::Range::commonAncestorContainer): Added back the check for 0
              that I removed erroneously in the Range patch.
              (WebCore::Range::processContents): Left in assertions I used to debug
              this.
      
      LayoutTests:
      
              Reviewed by Beth Dakin.
      
              Update test to catch the SECURITY_ERR thrown by
              CanvasRenderingContext2D::getImageData() and
              HTMLCanvasElement::toDataURL() on a tainted canvas
      
              * http/tests/security/canvas-remote-read-remote-image-expected.txt:
              * http/tests/security/canvas-remote-read-remote-image.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a24645f