1. 12 May, 2012 4 commits
    • barraclough@apple.com's avatar
      Introduce PropertyName class · 38d3c75b
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86241
      
      Reviewed by Geoff Garen.
      
      Replace 'const Identifier&' arguments to functions accessing object properties with a new 'PropertyName' type.
      This change paves the way to allow for properties keyed by values that are not Identifiers.
      
      This change is largely a mechanical find & replace.
      It also changes JSFunction's constructor to take a UString& instead of an Identifier&
      (since in some cases we can no longer guarantee that we'lll have an Identifier), and
      unifies Identifier's methods to obtain array indices onto PropertyName.
      
      The new PropertyName class retains the ability to support .impl() and .ustring(), but
      in a future patch we may need to rework this, since not all PropertyNames should be
      equal based on their string representation.
      
      Source/JavaScriptCore: 
      
      * API/JSCallbackFunction.cpp:
      (JSC::JSCallbackFunction::finishCreation):
      * API/JSCallbackFunction.h:
      (JSCallbackFunction):
      (JSC::JSCallbackFunction::create):
      * API/JSCallbackObject.h:
      (JSCallbackObject):
      * API/JSCallbackObjectFunctions.h:
      (JSC::::getOwnPropertySlot):
      (JSC::::getOwnPropertyDescriptor):
      (JSC::::put):
      (JSC::::deleteProperty):
      (JSC::::getStaticValue):
      (JSC::::staticFunctionGetter):
      (JSC::::callbackGetter):
      * API/JSObjectRef.cpp:
      (JSObjectMakeFunctionWithCallback):
      * JSCTypedArrayStubs.h:
      (JSC):
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::getOwnPropertySlot):
      (JSC::DebuggerActivation::put):
      (JSC::DebuggerActivation::putDirectVirtual):
      (JSC::DebuggerActivation::deleteProperty):
      (JSC::DebuggerActivation::getOwnPropertyDescriptor):
      (JSC::DebuggerActivation::defineOwnProperty):
      * debugger/DebuggerActivation.h:
      (DebuggerActivation):
      * jsc.cpp:
      (GlobalObject::addFunction):
      (GlobalObject::addConstructableFunction):
      * runtime/Arguments.cpp:
      (JSC::Arguments::getOwnPropertySlot):
      (JSC::Arguments::getOwnPropertyDescriptor):
      (JSC::Arguments::put):
      (JSC::Arguments::deleteProperty):
      (JSC::Arguments::defineOwnProperty):
      * runtime/Arguments.h:
      (Arguments):
      * runtime/ArrayConstructor.cpp:
      (JSC::ArrayConstructor::finishCreation):
      (JSC::ArrayConstructor::getOwnPropertySlot):
      (JSC::ArrayConstructor::getOwnPropertyDescriptor):
      * runtime/ArrayConstructor.h:
      (ArrayConstructor):
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::getOwnPropertySlot):
      (JSC::ArrayPrototype::getOwnPropertyDescriptor):
      (JSC::putProperty):
      * runtime/ArrayPrototype.h:
      (ArrayPrototype):
      * runtime/BooleanConstructor.cpp:
      (JSC::BooleanConstructor::finishCreation):
      * runtime/BooleanPrototype.cpp:
      (JSC::BooleanPrototype::getOwnPropertySlot):
      (JSC::BooleanPrototype::getOwnPropertyDescriptor):
      * runtime/BooleanPrototype.h:
      (BooleanPrototype):
      * runtime/ClassInfo.h:
      (MethodTable):
      * runtime/DateConstructor.cpp:
      (JSC::DateConstructor::finishCreation):
      (JSC::DateConstructor::getOwnPropertySlot):
      (JSC::DateConstructor::getOwnPropertyDescriptor):
      * runtime/DateConstructor.h:
      (DateConstructor):
      * runtime/DatePrototype.cpp:
      (JSC::DatePrototype::getOwnPropertySlot):
      (JSC::DatePrototype::getOwnPropertyDescriptor):
      * runtime/DatePrototype.h:
      (DatePrototype):
      * runtime/Error.h:
      (JSC::StrictModeTypeErrorFunction::create):
      * runtime/ErrorConstructor.cpp:
      (JSC::ErrorConstructor::finishCreation):
      * runtime/ErrorPrototype.cpp:
      (JSC::ErrorPrototype::getOwnPropertySlot):
      (JSC::ErrorPrototype::getOwnPropertyDescriptor):
      * runtime/ErrorPrototype.h:
      (ErrorPrototype):
      * runtime/FunctionConstructor.cpp:
      (JSC::FunctionConstructor::finishCreation):
      * runtime/FunctionPrototype.cpp:
      (JSC::FunctionPrototype::finishCreation):
      (JSC::FunctionPrototype::addFunctionProperties):
      (JSC::functionProtoFuncBind):
      * runtime/FunctionPrototype.h:
      (JSC::FunctionPrototype::create):
      (FunctionPrototype):
      * runtime/Identifier.cpp:
      (JSC):
      * runtime/Identifier.h:
      (Identifier):
      * runtime/InternalFunction.cpp:
      (JSC::InternalFunction::finishCreation):
      * runtime/InternalFunction.h:
      (InternalFunction):
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::symbolTableGet):
      (JSC::JSActivation::symbolTablePut):
      (JSC::JSActivation::symbolTablePutWithAttributes):
      (JSC::JSActivation::getOwnPropertySlot):
      (JSC::JSActivation::put):
      (JSC::JSActivation::putDirectVirtual):
      (JSC::JSActivation::deleteProperty):
      (JSC::JSActivation::argumentsGetter):
      * runtime/JSActivation.h:
      (JSActivation):
      * runtime/JSArray.cpp:
      (JSC::JSArray::defineOwnProperty):
      (JSC::JSArray::getOwnPropertySlot):
      (JSC::JSArray::getOwnPropertyDescriptor):
      (JSC::JSArray::put):
      (JSC::JSArray::deleteProperty):
      * runtime/JSArray.h:
      (JSArray):
      (JSC):
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::create):
      (JSC::JSBoundFunction::finishCreation):
      * runtime/JSBoundFunction.h:
      (JSBoundFunction):
      * runtime/JSCell.cpp:
      (JSC::JSCell::getOwnPropertySlot):
      (JSC::JSCell::put):
      (JSC::JSCell::deleteProperty):
      (JSC::JSCell::putDirectVirtual):
      (JSC::JSCell::defineOwnProperty):
      (JSC::JSCell::getOwnPropertyDescriptor):
      * runtime/JSCell.h:
      (JSCell):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::create):
      (JSC::JSFunction::finishCreation):
      (JSC::JSFunction::argumentsGetter):
      (JSC::JSFunction::callerGetter):
      (JSC::JSFunction::lengthGetter):
      (JSC::JSFunction::getOwnPropertySlot):
      (JSC::JSFunction::getOwnPropertyDescriptor):
      (JSC::JSFunction::put):
      (JSC::JSFunction::deleteProperty):
      (JSC::JSFunction::defineOwnProperty):
      (JSC::getCalculatedDisplayName):
      * runtime/JSFunction.h:
      (JSFunction):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::put):
      (JSC::JSGlobalObject::putDirectVirtual):
      (JSC::JSGlobalObject::defineOwnProperty):
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::createThrowTypeError):
      (JSC::JSGlobalObject::getOwnPropertySlot):
      (JSC::JSGlobalObject::getOwnPropertyDescriptor):
      * runtime/JSGlobalObject.h:
      (JSGlobalObject):
      (JSC::JSGlobalObject::hasOwnPropertyForWrite):
      (JSC::JSGlobalObject::symbolTableHasProperty):
      * runtime/JSNotAnObject.cpp:
      (JSC::JSNotAnObject::getOwnPropertySlot):
      (JSC::JSNotAnObject::getOwnPropertyDescriptor):
      (JSC::JSNotAnObject::put):
      (JSC::JSNotAnObject::deleteProperty):
      * runtime/JSNotAnObject.h:
      (JSNotAnObject):
      * runtime/JSONObject.cpp:
      (JSC::JSONObject::getOwnPropertySlot):
      (JSC::JSONObject::getOwnPropertyDescriptor):
      * runtime/JSONObject.h:
      (JSONObject):
      * runtime/JSObject.cpp:
      (JSC::JSObject::put):
      (JSC::JSObject::putDirectVirtual):
      (JSC::JSObject::putDirectAccessor):
      (JSC::JSObject::hasProperty):
      (JSC::JSObject::deleteProperty):
      (JSC::JSObject::hasOwnProperty):
      (JSC::callDefaultValueFunction):
      (JSC::JSObject::findPropertyHashEntry):
      (JSC::JSObject::getPropertySpecificValue):
      (JSC::JSObject::removeDirect):
      (JSC::JSObject::getOwnPropertyDescriptor):
      (JSC::JSObject::getPropertyDescriptor):
      (JSC::putDescriptor):
      (JSC::JSObject::defineOwnProperty):
      * runtime/JSObject.h:
      (JSObject):
      (JSC::JSObject::getDirect):
      (JSC::JSObject::getDirectLocation):
      (JSC::JSObject::inlineGetOwnPropertySlot):
      (JSC::JSObject::getOwnPropertySlot):
      (JSC::JSCell::fastGetOwnPropertySlot):
      (JSC::JSObject::getPropertySlot):
      (JSC::JSObject::get):
      (JSC::JSObject::putDirectInternal):
      (JSC::JSObject::putOwnDataProperty):
      (JSC::JSObject::putDirect):
      (JSC::JSObject::putDirectWithoutTransition):
      (JSC::JSValue::get):
      (JSC::JSValue::put):
      * runtime/JSStaticScopeObject.cpp:
      (JSC::JSStaticScopeObject::put):
      (JSC::JSStaticScopeObject::putDirectVirtual):
      (JSC::JSStaticScopeObject::getOwnPropertySlot):
      * runtime/JSStaticScopeObject.h:
      (JSStaticScopeObject):
      * runtime/JSString.cpp:
      (JSC::JSString::getOwnPropertySlot):
      (JSC::JSString::getStringPropertyDescriptor):
      * runtime/JSString.h:
      (JSString):
      (JSC::JSString::getStringPropertySlot):
      * runtime/JSValue.cpp:
      (JSC::JSValue::putToPrimitive):
      * runtime/JSValue.h:
      (JSC):
      (JSValue):
      * runtime/JSVariableObject.cpp:
      (JSC::JSVariableObject::deleteProperty):
      (JSC::JSVariableObject::symbolTableGet):
      (JSC::JSVariableObject::putDirectVirtual):
      * runtime/JSVariableObject.h:
      (JSVariableObject):
      (JSC::JSVariableObject::symbolTableGet):
      (JSC::JSVariableObject::symbolTablePut):
      (JSC::JSVariableObject::symbolTablePutWithAttributes):
      * runtime/Lookup.cpp:
      (JSC::setUpStaticFunctionSlot):
      * runtime/Lookup.h:
      (JSC::HashTable::entry):
      (JSC):
      (JSC::getStaticPropertySlot):
      (JSC::getStaticPropertyDescriptor):
      (JSC::getStaticFunctionSlot):
      (JSC::getStaticFunctionDescriptor):
      (JSC::getStaticValueSlot):
      (JSC::getStaticValueDescriptor):
      (JSC::lookupPut):
      * runtime/MathObject.cpp:
      (JSC::MathObject::getOwnPropertySlot):
      (JSC::MathObject::getOwnPropertyDescriptor):
      * runtime/MathObject.h:
      (MathObject):
      * runtime/NativeErrorConstructor.h:
      (JSC::NativeErrorConstructor::finishCreation):
      * runtime/NumberConstructor.cpp:
      (JSC):
      (JSC::NumberConstructor::finishCreation):
      (JSC::NumberConstructor::getOwnPropertySlot):
      (JSC::NumberConstructor::getOwnPropertyDescriptor):
      (JSC::NumberConstructor::put):
      (JSC::numberConstructorNaNValue):
      (JSC::numberConstructorNegInfinity):
      (JSC::numberConstructorPosInfinity):
      (JSC::numberConstructorMaxValue):
      (JSC::numberConstructorMinValue):
      * runtime/NumberConstructor.h:
      (NumberConstructor):
      * runtime/NumberPrototype.cpp:
      (JSC::NumberPrototype::getOwnPropertySlot):
      (JSC::NumberPrototype::getOwnPropertyDescriptor):
      * runtime/NumberPrototype.h:
      (NumberPrototype):
      * runtime/ObjectConstructor.cpp:
      (JSC::ObjectConstructor::finishCreation):
      (JSC::ObjectConstructor::getOwnPropertySlot):
      (JSC::ObjectConstructor::getOwnPropertyDescriptor):
      * runtime/ObjectConstructor.h:
      (ObjectConstructor):
      * runtime/ObjectPrototype.cpp:
      (JSC::ObjectPrototype::put):
      (JSC::ObjectPrototype::defineOwnProperty):
      (JSC::ObjectPrototype::getOwnPropertySlot):
      (JSC::ObjectPrototype::getOwnPropertyDescriptor):
      * runtime/ObjectPrototype.h:
      (ObjectPrototype):
      * runtime/PropertySlot.h:
      (PropertySlot):
      (JSC::PropertySlot::getValue):
      * runtime/RegExpConstructor.cpp:
      (JSC):
      (JSC::RegExpConstructor::finishCreation):
      (JSC::RegExpConstructor::getOwnPropertySlot):
      (JSC::RegExpConstructor::getOwnPropertyDescriptor):
      (JSC::regExpConstructorDollar1):
      (JSC::regExpConstructorDollar2):
      (JSC::regExpConstructorDollar3):
      (JSC::regExpConstructorDollar4):
      (JSC::regExpConstructorDollar5):
      (JSC::regExpConstructorDollar6):
      (JSC::regExpConstructorDollar7):
      (JSC::regExpConstructorDollar8):
      (JSC::regExpConstructorDollar9):
      (JSC::regExpConstructorInput):
      (JSC::regExpConstructorMultiline):
      (JSC::regExpConstructorLastMatch):
      (JSC::regExpConstructorLastParen):
      (JSC::regExpConstructorLeftContext):
      (JSC::regExpConstructorRightContext):
      (JSC::RegExpConstructor::put):
      * runtime/RegExpConstructor.h:
      (RegExpConstructor):
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::getOwnPropertySlot):
      (JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
      (JSC::RegExpMatchesArray::put):
      (JSC::RegExpMatchesArray::deleteProperty):
      (JSC::RegExpMatchesArray::defineOwnProperty):
      * runtime/RegExpObject.cpp:
      (JSC):
      (JSC::RegExpObject::getOwnPropertySlot):
      (JSC::RegExpObject::getOwnPropertyDescriptor):
      (JSC::RegExpObject::deleteProperty):
      (JSC::RegExpObject::defineOwnProperty):
      (JSC::regExpObjectGlobal):
      (JSC::regExpObjectIgnoreCase):
      (JSC::regExpObjectMultiline):
      (JSC::regExpObjectSource):
      (JSC::RegExpObject::put):
      * runtime/RegExpObject.h:
      (RegExpObject):
      * runtime/RegExpPrototype.cpp:
      (JSC::RegExpPrototype::getOwnPropertySlot):
      (JSC::RegExpPrototype::getOwnPropertyDescriptor):
      * runtime/RegExpPrototype.h:
      (RegExpPrototype):
      * runtime/StrictEvalActivation.cpp:
      (JSC::StrictEvalActivation::deleteProperty):
      * runtime/StrictEvalActivation.h:
      (StrictEvalActivation):
      * runtime/StringConstructor.cpp:
      (JSC::StringConstructor::finishCreation):
      (JSC::StringConstructor::getOwnPropertySlot):
      (JSC::StringConstructor::getOwnPropertyDescriptor):
      * runtime/StringConstructor.h:
      (StringConstructor):
      * runtime/StringObject.cpp:
      (JSC::StringObject::getOwnPropertySlot):
      (JSC::StringObject::getOwnPropertyDescriptor):
      (JSC::StringObject::put):
      (JSC::StringObject::defineOwnProperty):
      (JSC::StringObject::deleteProperty):
      * runtime/StringObject.h:
      (StringObject):
      * runtime/StringPrototype.cpp:
      (JSC::StringPrototype::getOwnPropertySlot):
      (JSC::StringPrototype::getOwnPropertyDescriptor):
      * runtime/StringPrototype.h:
      (StringPrototype):
      * runtime/Structure.cpp:
      (JSC::Structure::despecifyDictionaryFunction):
      (JSC::Structure::addPropertyTransitionToExistingStructure):
      (JSC::Structure::addPropertyTransition):
      (JSC::Structure::removePropertyTransition):
      (JSC::Structure::despecifyFunctionTransition):
      (JSC::Structure::attributeChangeTransition):
      (JSC::Structure::addPropertyWithoutTransition):
      (JSC::Structure::removePropertyWithoutTransition):
      (JSC::Structure::get):
      (JSC::Structure::despecifyFunction):
      (JSC::Structure::putSpecificValue):
      (JSC::Structure::remove):
      * runtime/Structure.h:
      (Structure):
      (JSC::Structure::get):
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::cssPropertyIDForJSCSSPropertyName):
      (WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
      (WebCore::JSCSSStyleDeclaration::getOwnPropertyDescriptorDelegate):
      (WebCore::JSCSSStyleDeclaration::putDelegate):
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::findAtomicString):
      (WebCore::objectToStringFunctionGetter):
      * bindings/js/JSDOMBinding.h:
      (WebCore):
      (WebCore::propertyNameToString):
      (WebCore::propertyNameToAtomicString):
      * bindings/js/JSDOMMimeTypeArrayCustom.cpp:
      (WebCore::JSDOMMimeTypeArray::canGetItemsForName):
      (WebCore::JSDOMMimeTypeArray::nameGetter):
      * bindings/js/JSDOMPluginArrayCustom.cpp:
      (WebCore::JSDOMPluginArray::canGetItemsForName):
      (WebCore::JSDOMPluginArray::nameGetter):
      * bindings/js/JSDOMPluginCustom.cpp:
      (WebCore::JSDOMPlugin::canGetItemsForName):
      (WebCore::JSDOMPlugin::nameGetter):
      * bindings/js/JSDOMStringMapCustom.cpp:
      (WebCore::JSDOMStringMap::canGetItemsForName):
      (WebCore::JSDOMStringMap::nameGetter):
      (WebCore::JSDOMStringMap::deleteProperty):
      (WebCore::JSDOMStringMap::putDelegate):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::nonCachingStaticFunctionGetter):
      (WebCore::childFrameGetter):
      (WebCore::namedItemGetter):
      (WebCore::JSDOMWindow::getOwnPropertySlot):
      (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
      (WebCore::JSDOMWindow::put):
      (WebCore::JSDOMWindow::deleteProperty):
      (WebCore::JSDOMWindow::defineOwnProperty):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::getOwnPropertySlot):
      (WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
      (WebCore::JSDOMWindowShell::put):
      (WebCore::JSDOMWindowShell::putDirectVirtual):
      (WebCore::JSDOMWindowShell::defineOwnProperty):
      (WebCore::JSDOMWindowShell::deleteProperty):
      * bindings/js/JSDOMWindowShell.h:
      (JSDOMWindowShell):
      * bindings/js/JSHTMLAllCollectionCustom.cpp:
      (WebCore::getNamedItems):
      (WebCore::callHTMLAllCollection):
      (WebCore::JSHTMLAllCollection::canGetItemsForName):
      (WebCore::JSHTMLAllCollection::nameGetter):
      (WebCore::JSHTMLAllCollection::item):
      * bindings/js/JSHTMLAppletElementCustom.cpp:
      (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate):
      (WebCore::JSHTMLAppletElement::getOwnPropertyDescriptorDelegate):
      (WebCore::JSHTMLAppletElement::putDelegate):
      * bindings/js/JSHTMLCollectionCustom.cpp:
      (WebCore::getNamedItems):
      (WebCore::JSHTMLCollection::canGetItemsForName):
      (WebCore::JSHTMLCollection::nameGetter):
      * bindings/js/JSHTMLDocumentCustom.cpp:
      (WebCore::JSHTMLDocument::canGetItemsForName):
      (WebCore::JSHTMLDocument::nameGetter):
      * bindings/js/JSHTMLEmbedElementCustom.cpp:
      (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate):
      (WebCore::JSHTMLEmbedElement::getOwnPropertyDescriptorDelegate):
      (WebCore::JSHTMLEmbedElement::putDelegate):
      * bindings/js/JSHTMLFormElementCustom.cpp:
      (WebCore::JSHTMLFormElement::canGetItemsForName):
      (WebCore::JSHTMLFormElement::nameGetter):
      * bindings/js/JSHTMLFrameSetElementCustom.cpp:
      (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
      (WebCore::JSHTMLFrameSetElement::nameGetter):
      * bindings/js/JSHTMLObjectElementCustom.cpp:
      (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate):
      (WebCore::JSHTMLObjectElement::getOwnPropertyDescriptorDelegate):
      (WebCore::JSHTMLObjectElement::putDelegate):
      * bindings/js/JSHistoryCustom.cpp:
      (WebCore::nonCachingStaticBackFunctionGetter):
      (WebCore::nonCachingStaticForwardFunctionGetter):
      (WebCore::nonCachingStaticGoFunctionGetter):
      (WebCore::JSHistory::getOwnPropertySlotDelegate):
      (WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
      (WebCore::JSHistory::putDelegate):
      (WebCore::JSHistory::deleteProperty):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::nonCachingStaticReplaceFunctionGetter):
      (WebCore::nonCachingStaticReloadFunctionGetter):
      (WebCore::nonCachingStaticAssignFunctionGetter):
      (WebCore::JSLocation::getOwnPropertySlotDelegate):
      (WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
      (WebCore::JSLocation::putDelegate):
      (WebCore::JSLocation::deleteProperty):
      (WebCore::JSLocation::defineOwnProperty):
      (WebCore::JSLocationPrototype::putDelegate):
      (WebCore::JSLocationPrototype::defineOwnProperty):
      * bindings/js/JSNamedNodeMapCustom.cpp:
      (WebCore::JSNamedNodeMap::canGetItemsForName):
      (WebCore::JSNamedNodeMap::nameGetter):
      * bindings/js/JSNodeListCustom.cpp:
      (WebCore::JSNodeList::canGetItemsForName):
      (WebCore::JSNodeList::nameGetter):
      * bindings/js/JSPluginElementFunctions.cpp:
      (WebCore::runtimeObjectPropertyGetter):
      (WebCore::runtimeObjectCustomGetOwnPropertySlot):
      (WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
      (WebCore::runtimeObjectCustomPut):
      * bindings/js/JSPluginElementFunctions.h:
      (WebCore):
      * bindings/js/JSStorageCustom.cpp:
      (WebCore::JSStorage::canGetItemsForName):
      (WebCore::JSStorage::nameGetter):
      (WebCore::JSStorage::deleteProperty):
      (WebCore::JSStorage::putDelegate):
      * bindings/js/JSStyleSheetListCustom.cpp:
      (WebCore::JSStyleSheetList::canGetItemsForName):
      (WebCore::JSStyleSheetList::nameGetter):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
      (WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateGetOwnPropertyDescriptorBody):
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      (GenerateConstructorDefinition):
      * bridge/c/c_class.cpp:
      (JSC::Bindings::CClass::methodsNamed):
      (JSC::Bindings::CClass::fieldNamed):
      * bridge/c/c_class.h:
      (CClass):
      * bridge/c/c_instance.cpp:
      (JSC::Bindings::CRuntimeMethod::create):
      (JSC::Bindings::CRuntimeMethod::finishCreation):
      (JSC::Bindings::CInstance::getMethod):
      * bridge/c/c_instance.h:
      (CInstance):
      * bridge/jni/jsc/JavaClassJSC.cpp:
      (JavaClass::methodsNamed):
      (JavaClass::fieldNamed):
      * bridge/jni/jsc/JavaClassJSC.h:
      (JavaClass):
      * bridge/jni/jsc/JavaInstanceJSC.cpp:
      (JavaRuntimeMethod::create):
      (JavaRuntimeMethod::finishCreation):
      * bridge/jni/jsc/JavaInstanceJSC.h:
      (JavaInstance):
      * bridge/jsc/BridgeJSC.h:
      (Class):
      (JSC::Bindings::Class::fallbackObject):
      (JSC::Bindings::Instance::setValueOfUndefinedField):
      (Instance):
      (JSC::Bindings::Instance::getOwnPropertySlot):
      (JSC::Bindings::Instance::getOwnPropertyDescriptor):
      (JSC::Bindings::Instance::put):
      * bridge/objc/objc_class.h:
      (ObjcClass):
      * bridge/objc/objc_class.mm:
      (JSC::Bindings::ObjcClass::methodsNamed):
      (JSC::Bindings::ObjcClass::fieldNamed):
      (JSC::Bindings::ObjcClass::fallbackObject):
      * bridge/objc/objc_instance.h:
      (ObjcInstance):
      * bridge/objc/objc_instance.mm:
      (ObjCRuntimeMethod::create):
      (ObjCRuntimeMethod::finishCreation):
      (ObjcInstance::setValueOfUndefinedField):
      (ObjcInstance::getValueOfUndefinedField):
      * bridge/objc/objc_runtime.h:
      (JSC::Bindings::ObjcFallbackObjectImp::create):
      (JSC::Bindings::ObjcFallbackObjectImp::propertyName):
      (ObjcFallbackObjectImp):
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
      (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
      (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
      (JSC::Bindings::ObjcFallbackObjectImp::put):
      (JSC::Bindings::callObjCFallbackObject):
      (JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
      (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::lengthGetter):
      (JSC::RuntimeArray::getOwnPropertySlot):
      (JSC::RuntimeArray::getOwnPropertyDescriptor):
      (JSC::RuntimeArray::put):
      (JSC::RuntimeArray::deleteProperty):
      * bridge/runtime_array.h:
      (RuntimeArray):
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::finishCreation):
      (JSC::RuntimeMethod::lengthGetter):
      (JSC::RuntimeMethod::getOwnPropertySlot):
      (JSC::RuntimeMethod::getOwnPropertyDescriptor):
      * bridge/runtime_method.h:
      (JSC::RuntimeMethod::create):
      (RuntimeMethod):
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::fallbackObjectGetter):
      (JSC::Bindings::RuntimeObject::fieldGetter):
      (JSC::Bindings::RuntimeObject::methodGetter):
      (JSC::Bindings::RuntimeObject::getOwnPropertySlot):
      (JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
      (JSC::Bindings::RuntimeObject::put):
      (JSC::Bindings::RuntimeObject::deleteProperty):
      * bridge/runtime_object.h:
      (RuntimeObject):
      
      Source/WebKit/mac: 
      
      * Plugins/Hosted/ProxyInstance.h:
      (ProxyInstance):
      * Plugins/Hosted/ProxyInstance.mm:
      (ProxyClass):
      (WebKit::ProxyClass::methodsNamed):
      (WebKit::ProxyClass::fieldNamed):
      (WebKit::ProxyRuntimeMethod::create):
      (WebKit::ProxyRuntimeMethod::finishCreation):
      (WebKit::ProxyInstance::getMethod):
      (WebKit::ProxyInstance::methodsNamed):
      (WebKit::ProxyInstance::fieldNamed):
      
      Source/WebKit2: 
      
      * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
      (WebKit::JSNPMethod::finishCreation):
      * WebProcess/Plugins/Netscape/JSNPMethod.h:
      (WebKit::JSNPMethod::create):
      (JSNPMethod):
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::npIdentifierFromIdentifier):
      (WebKit::JSNPObject::getOwnPropertySlot):
      (WebKit::JSNPObject::getOwnPropertyDescriptor):
      (WebKit::JSNPObject::put):
      (WebKit::JSNPObject::deleteProperty):
      (WebKit::JSNPObject::propertyGetter):
      (WebKit::JSNPObject::methodGetter):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      (JSNPObject):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38d3c75b
    • commit-queue@webkit.org's avatar
      use after free in WebCore::RenderObject::document · 675d16a0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84891
      
      Patch by David Barton <dbarton@mathscribe.com> on 2012-05-11
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      Change RenderMathMLFenced::addChild() to use the beforeChild parameter. When beforeChild
      is 0, insert child renderers before the closing fence, which might not be the same as
      this->lastChild(), e.g. possibly due to anonymous blocks or generated content.
      
      Tests: mathml/presentation/mfenced-add-child1-expected.html
             mathml/presentation/mfenced-add-child1.html
             mathml/presentation/mfenced-add-child2-expected.html
             mathml/presentation/mfenced-add-child2.html
      
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::RenderMathMLFenced):
      (WebCore::RenderMathMLFenced::makeFences):
      (WebCore::RenderMathMLFenced::addChild):
      * rendering/mathml/RenderMathMLFenced.h:
      (RenderMathMLFenced):
      
      LayoutTests:
      
      * mathml/presentation/mfenced-add-child1-expected.html: Added.
      * mathml/presentation/mfenced-add-child1.html: Added.
      * mathml/presentation/mfenced-add-child2-expected.html: Added.
      * mathml/presentation/mfenced-add-child2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      675d16a0
    • rniwa@webkit.org's avatar
    • andersca@apple.com's avatar
      Can't scroll on webpage after following links from Blogger · 10409afe
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86274
      <rdar://problem/11431352>
      
      Reviewed by Beth Dakin.
      
      When committing a new scroll layer, make sure to reset the scroll position.
      
      * page/scrolling/ScrollingTree.cpp:
      (WebCore::ScrollingTree::commitNewTreeState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10409afe
  2. 11 May, 2012 36 commits
    • commit-queue@webkit.org's avatar
      [TextureMapper] Support drawing debug borders · 4dddbbc1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86237
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-05-11
      Reviewed by Noam Rosenthal.
      
      No new tests. This is the implementation of an interactive debugging
      feature.
      
      * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
      (WebCore::GraphicsLayer::create): Moved this to the top of the file to
      reduce contention for the coveted last spot in the file. This also
      follows the pattern used in many WebCore files of having the factories
      at the top.
      (WebCore::GraphicsLayerTextureMapper::setDebugBorder): Added this
      plumbing.
      * platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added
      plumbing.
      * platform/graphics/texmap/TextureMapper.h: Ditto.
      * platform/graphics/texmap/TextureMapperBackingStore.cpp:
      (WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
      Initialize the new member.
      (WebCore::TextureMapperTiledBackingStore::paintToTextureMapper): When
      debug borders are enabled call the new drawBorder method on the TM.
      (WebCore::TextureMapperTiledBackingStore::setDebugBorder): Added this
      plumbing.
      * platform/graphics/texmap/TextureMapperBackingStore.h: Added plumbing
      and members to store debug border states. This is necessary because of
      the when painting there is no handle on the GraphicsLayers.
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::TextureMapperGL::drawRect): Factored out the common bits of
      drawTexture and drawBorder into this helper.
      (WebCore::TextureMapperGL::drawBorder): Added this method, which works
      very similarly to drawTexture, but uses a different shader program and
      must also set the line width and color.
      (WebCore::TextureMapperGL::drawTexture): Factored out the bits that
      are shared with drawRect.
      * platform/graphics/texmap/TextureMapperGL.h:
      (TextureMapperGL): Added the new method declarations.
      * platform/graphics/texmap/TextureMapperImageBuffer.h:
      (WebCore::TextureMapperImageBuffer::drawBorder): Added an empty
      implementation. Later we can add an implementation for the ImageBuffer
      TM.
      * platform/graphics/texmap/TextureMapperLayer.cpp:
      (WebCore::TextureMapperLayer::updateBackingStore): When updating the
      backing store send the debug border information through.
      (WebCore::TextureMapperLayer::syncCompositingStateSelf): When updating
      the layer state, also update the debug indicators. This is required to
      initialize the debug border values for the layer.
      (WebCore::TextureMapperLayer::setDebugBorder): Added this plumbing.
      * platform/graphics/texmap/TextureMapperLayer.h: Ditto.
      * platform/graphics/texmap/TextureMapperShaderManager.cpp: Added a
      solid color shader that doesn't care about texture coordinates or
      opacity values.
      (WebCore::TextureMapperShaderManager::solidColorProgram): Added. This
      is a shorter getter for the solid color program that doesn't require
      casting from the caller.
      (WebCore::TextureMapperShaderManager::getShaderProgram): Added support
      for the solid color program.
      (WebCore::TextureMapperShaderProgramSolidColor::create): Added.
      (WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
      Ditto.
      (WebCore::TextureMapperShaderProgramSolidColor::vertexShaderSource):
      Ditto.
      (WebCore::TextureMapperShaderProgramSolidColor::fragmentShaderSource):
      Ditto.
      * platform/graphics/texmap/TextureMapperShaderManager.h:
      (TextureMapperShaderProgramSolidColor): Added.
      (WebCore::TextureMapperShaderProgramSolidColor::colorVariable): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dddbbc1
    • msaboff@apple.com's avatar
      Rolling out r116659. · 8a26cff7
      msaboff@apple.com authored
      Causes ASSERT failures on bots.
      
      Rubber stamped by Geoff Garen.
      
      * heap/Heap.cpp:
      (JSC::Heap::markRoots):
      * heap/MarkStack.cpp:
      (JSC::MarkStackThreadSharedData::markingThreadMain):
      (JSC::MarkStackThreadSharedData::markingThreadStartFunc):
      (JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
      (JSC::MarkStackThreadSharedData::reset):
      (JSC::MarkStack::reset):
      (JSC):
      (JSC::SlotVisitor::copyAndAppend):
      * heap/MarkStack.h:
      (MarkStackThreadSharedData):
      (MarkStack):
      * runtime/JSString.h:
      (JSString):
      (JSC::JSString::finishCreation):
      (JSC::JSString::is8Bit):
      (JSC::JSRopeString::finishCreation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a26cff7
    • timothy@apple.com's avatar
      Instrument timer function calls so they show up in the Web Inspector Timeline. · 7e721463
      timothy@apple.com authored
      https://webkit.org/b/86173
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Test: inspector/timeline/timeline-timer.html
      
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::executeFunctionInContext): Wrap the call with JSMainThreadExecState::instrumentFunctionCall
      and InspectorInstrumentation::didCallFunction.
      
      LayoutTests:
      
      * inspector/timeline/timeline-injected-script-eval-expected.txt: Updated for the blocked scriptName and scriptLine.
      * inspector/timeline/timeline-script-tag-1-expected.txt: Updated for the blocked lineNumber.
      * inspector/timeline/timeline-script-tag-2-expected.txt: Ditto.
      * inspector/timeline/timeline-test.js: Block scriptName, scriptLine, lineNumber and timerId.
      * inspector/timeline/timeline-timer-expected.txt: Added.
      * inspector/timeline/timeline-timer.html: Added.
      * platform/chromium/inspector/timeline/timeline-timer-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e721463
    • beidson@apple.com's avatar
      <rdar://problem/11361907> and https://bugs.webkit.org/show_bug.cgi?id=86265 · 1c3a6c93
      beidson@apple.com authored
      REGRESSION(r104885): Images missing from printed YummySoup! recipes
      
      We thought clients were passing paths as URLs.
      It turns out it was more likely they were passing file: URLs with the file: scheme removed.
      And that jives perfectly with the behavior change caused by r104885.
      
      Reviewed by Alexey Proskuryakov.
      
      Rename _webkit_URLFromURLOrPath to _webkit_URLFromURLOrSchemelessFileURL, and change it
      to create the new URL simply by appending "file:":
      * Misc/WebNSURLExtras.h:
      * Misc/WebNSURLExtras.mm:
      (-[NSURL _webkit_URLFromURLOrSchemelessFileURL]):
      
      * WebView/WebFrame.mm:
      (-[WebFrame loadRequest:]): Create the fixed url simply by appending "file:" to the
        existing URL string.
      (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]):
      (-[WebFrame loadHTMLString:baseURL:]):
      (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c3a6c93
    • commit-queue@webkit.org's avatar
      [GTK] [WK2] Memory leak in PluginProcessProxy::scanPlugin · cfc8269c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86240
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-11
      Reviewed by Martin Robinson.
      
      Free the output received from the g_spawn_sync().
      
      * UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
      (WebKit::PluginProcessProxy::scanPlugin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfc8269c
    • oliver@apple.com's avatar
      Appease thread verifier when dealing with the JSC API's shared VM · c711a397
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86268
      
      Reviewed by Geoffrey Garen.
      
      If we're the shared VM, just disable the verifier.  This makes debug builds
      livable against non-webkit clients.
      
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c711a397
    • thakis@chromium.org's avatar
      [chromium/mac] Let libwebkit.dylib link in Debug/components build · 7955051b
      thakis@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86244
      
      Reviewed by James Robinson.
      
      In static builds, this was not needed because the targets depending on
      'webkit' already link in QuartzCore. In Release components builds, it wasn't
      needed because they are built with -dead_strip, which stripped the referencing
      code.
      
      * WebCore.gyp/WebCore.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7955051b
    • rniwa@webkit.org's avatar
      Remove a Chromium test expectation now that the regression is fixed in r116814. · 1ae154d3
      rniwa@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ae154d3
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r116802. · cd64ea36
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/116802
      https://bugs.webkit.org/show_bug.cgi?id=86260
      
      This patch causes compiling error to chromium builds
      (Requested by jianli_ on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11
      
      Source/WebCore:
      
      * WebCore.gypi:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd64ea36
    • rniwa@webkit.org's avatar
      Regression fix after r116798. · 9d753854
      rniwa@webkit.org authored
      We need to return true for the html element in the design mode
      in which case parentNode() is editable and is not a body element.
      
      * dom/Node.cpp:
      (WebCore::Node::isRootEditableElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d753854
    • fpizlo@apple.com's avatar
      JIT memory allocator is not returning memory to the OS on Darwin · 0705091b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86047
      
      Reviewed by Geoff Garen.
      
      * jit/ExecutableAllocatorFixedVMPool.cpp:
      (JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0705091b
    • pilgrim@chromium.org's avatar
      [Chromium] Move createLocalStorageNamespace to Platform.h · 10d837ab
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85766
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/Platform.h:
      (WebKit):
      (Platform):
      (WebKit::Platform::createLocalStorageNamespace):
      * chromium/public/WebStorageArea.h: Added.
      (WebKit):
      (WebStorageArea):
      (WebKit::WebStorageArea::~WebStorageArea):
      (WebKit::WebStorageArea::setItem):
      (WebKit::WebStorageArea::removeItem):
      (WebKit::WebStorageArea::clear):
      * chromium/public/WebStorageNamespace.h: Added.
      (WebKit):
      (WebStorageNamespace):
      (WebKit::WebStorageNamespace::~WebStorageNamespace):
      (WebKit::WebStorageNamespace::isSameNamespace):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * public/WebStorageArea.h:
      * public/WebStorageNamespace.h:
      * public/platform/WebKitPlatformSupport.h:
      (WebKit):
      (WebKit::WebKitPlatformSupport::blobRegistry):
      * src/StorageAreaProxy.cpp:
      * src/StorageNamespaceProxy.cpp:
      (WebCore::StorageNamespace::localStorageNamespace):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10d837ab
    • jamesr@google.com's avatar
      [chromium] Move implementation of WebCore::GraphicsContext3D and related from... · 8dae5d2a
      jamesr@google.com authored
      [chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
      https://bugs.webkit.org/show_bug.cgi?id=86257
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium on top of
      the Platform interface WebGraphicsContext3D. This moves the implementation support code from WebKit/chromium/src
      to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore interfaces and
      allows code in WebCore/platform to use this support code directly where appropriate.
      
      Refactor only, no new functionality or tests.
      
      * WebCore.gypi:
      * platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.
      (WebCore):
      (WebCore::Extensions3DChromium::Extensions3DChromium):
      (WebCore::Extensions3DChromium::~Extensions3DChromium):
      (WebCore::Extensions3DChromium::supports):
      (WebCore::Extensions3DChromium::ensureEnabled):
      (WebCore::Extensions3DChromium::isEnabled):
      (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
      (WebCore::Extensions3DChromium::blitFramebuffer):
      (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
      (WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
      (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
      (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
      (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
      (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
      (WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
      (WebCore::Extensions3DChromium::discardFramebufferEXT):
      (WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
      (WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
      (WebCore::Extensions3DChromium::createVertexArrayOES):
      (WebCore::Extensions3DChromium::deleteVertexArrayOES):
      (WebCore::Extensions3DChromium::isVertexArrayOES):
      (WebCore::Extensions3DChromium::bindVertexArrayOES):
      (WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
      (WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
      (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
      (WebCore::Extensions3DChromium::paintFramebufferToCanvas):
      (WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
      (WebCore::Extensions3DChromium::texStorage2DEXT):
      (WebCore::Extensions3DChromium::createQueryEXT):
      (WebCore::Extensions3DChromium::deleteQueryEXT):
      (WebCore::Extensions3DChromium::isQueryEXT):
      (WebCore::Extensions3DChromium::beginQueryEXT):
      (WebCore::Extensions3DChromium::endQueryEXT):
      (WebCore::Extensions3DChromium::getQueryivEXT):
      (WebCore::Extensions3DChromium::getQueryObjectuivEXT):
      * platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.
      (WebCore):
      (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
      (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
      (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
      (WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
      (WebCore::GraphicsContext3DPrivate::platformGraphicsContext3D):
      (WebCore::GraphicsContext3DPrivate::platformTexture):
      (GrMemoryAllocationChangedCallback):
      (WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
      (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
      (WebCore::GraphicsContext3DPrivate::grContext):
      (WebCore::GraphicsContext3DPrivate::prepareTexture):
      (WebCore::GraphicsContext3DPrivate::markContextChanged):
      (WebCore::GraphicsContext3DPrivate::markLayerComposited):
      (WebCore::GraphicsContext3DPrivate::layerComposited):
      (WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
      (WebCore::GraphicsContext3DPrivate::paintRenderingResultsToCanvas):
      (WebCore::GraphicsContext3DPrivate::paintCompositedResultsToCanvas):
      (WebCore::GraphicsContext3DPrivate::paintRenderingResultsToImageData):
      (WebCore::GraphicsContext3DPrivate::reshape):
      (WebCore::GraphicsContext3DPrivate::getInternalFramebufferSize):
      (WebCore::GraphicsContext3DPrivate::isContextLost):
      (WebCore::GraphicsContext3DPrivate::isGLES2Compliant):
      (WebCore::GraphicsContext3DPrivate::bindAttribLocation):
      (WebCore::GraphicsContext3DPrivate::bufferData):
      (WebCore::GraphicsContext3DPrivate::bufferSubData):
      (WebCore::GraphicsContext3DPrivate::getActiveAttrib):
      (WebCore::GraphicsContext3DPrivate::getActiveUniform):
      (WebCore::GraphicsContext3DPrivate::getAttribLocation):
      (WebCore::GraphicsContext3DPrivate::getContextAttributes):
      (WebCore::GraphicsContext3DPrivate::getProgramInfoLog):
      (WebCore::GraphicsContext3DPrivate::getShaderInfoLog):
      (WebCore::GraphicsContext3DPrivate::getShaderSource):
      (WebCore::GraphicsContext3DPrivate::getString):
      (WebCore::GraphicsContext3DPrivate::getUniformLocation):
      (WebCore::GraphicsContext3DPrivate::shaderSource):
      (WebCore::GraphicsContext3DPrivate::texImage2D):
      (WebCore::GraphicsContext3DPrivate::texSubImage2D):
      (WebCore::GraphicsContext3DPrivate::uniform1fv):
      (WebCore::GraphicsContext3DPrivate::uniform1iv):
      (WebCore::GraphicsContext3DPrivate::uniform2fv):
      (WebCore::GraphicsContext3DPrivate::uniform2iv):
      (WebCore::GraphicsContext3DPrivate::uniform3fv):
      (WebCore::GraphicsContext3DPrivate::uniform3iv):
      (WebCore::GraphicsContext3DPrivate::uniform4fv):
      (WebCore::GraphicsContext3DPrivate::uniform4iv):
      (WebCore::GraphicsContext3DPrivate::uniformMatrix2fv):
      (WebCore::GraphicsContext3DPrivate::uniformMatrix3fv):
      (WebCore::GraphicsContext3DPrivate::uniformMatrix4fv):
      (WebCore::GraphicsContext3DPrivate::getExtensions):
      (WebCore::GraphicsContext3DPrivate::isResourceSafe):
      (WebCore::GraphicsContext3DPrivate::initializeExtensions):
      (WebCore::GraphicsContext3DPrivate::supportsExtension):
      (WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
      (WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
      (WebCore::GraphicsContext3D::GraphicsContext3D):
      (WebCore::GraphicsContext3D::~GraphicsContext3D):
      (WebCore::GraphicsContext3D::create):
      (WebCore::GraphicsContext3D::platformGraphicsContext3D):
      (WebCore::GraphicsContext3D::platformTexture):
      (WebCore::GraphicsContext3D::grContext):
      (WebCore::GraphicsContext3D::prepareTexture):
      (WebCore::GraphicsContext3D::getInternalFramebufferSize):
      (WebCore::GraphicsContext3D::isResourceSafe):
      (WebCore::GraphicsContext3D::platformLayer):
      (WebCore::GraphicsContext3D::layerComposited):
      (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
      (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
      (GraphicsContextLostCallbackAdapter):
      (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
      (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
      (WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
      (WebCore::GraphicsContextLostCallbackAdapter::create):
      (WebCore::GraphicsContext3DPrivate::setContextLostCallback):
      (GraphicsErrorMessageCallbackAdapter):
      (WebCore::GraphicsErrorMessageCallbackAdapter::~GraphicsErrorMessageCallbackAdapter):
      (WebCore::GraphicsErrorMessageCallbackAdapter::GraphicsErrorMessageCallbackAdapter):
      (WebCore::GraphicsErrorMessageCallbackAdapter::onErrorMessage):
      (WebCore::GraphicsErrorMessageCallbackAdapter::create):
      (WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
      (WebCore::GraphicsContext3D::isGLES2Compliant):
      (GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
      (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
      (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
      (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
      (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::create):
      (WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
      (GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
      (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
      (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
      (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
      (WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
      * platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.
      (WebKit):
      (WebCore):
      (GraphicsContext3DPrivate):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8dae5d2a
    • fsamuel@chromium.org's avatar
      [Chromium] Expose WebPluginContainer of WebPlugin to embedder · 91259733
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85916
      
      Reviewed by Darin Fisher.
      
      The browser plugin needs to access its current guest's  WebPluginContainer
      so that it can replace the guest with another guest WebPlugin when navigating
      across processes.
      
      * public/WebPlugin.h:
      (WebPlugin):
      (WebKit::WebPlugin::container):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91259733
    • ggaren@apple.com's avatar
      Clarified JSGlobalData (JavaScript VM) lifetime · a453b2ee
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85142
      
      Reviewed by Alexey Proskuryakov.
      
      (Follow-up fix.)
      
      * API/JSContextRef.cpp:
      (JSGlobalContextCreate): Restored some code I removed because I misread an #ifdef.
      (We don't need to test BUILDING_ON_LEOPARD, but we still need the linked-on
      test, because apps might have been linked on older OS's.)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a453b2ee
    • tomz@codeaurora.org's avatar
      Integrate IETC CSS : xml namespace tests · 3c81b118
      tomz@codeaurora.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86144
      
      Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
      Reviewed by Adam Barth.
      
      Integrating 17 IETC xml namespace tests, along with associated
      reference tests.
      
      * ietestcenter/css3/namespaces/declaring-001-expected.xml: Added.
      * ietestcenter/css3/namespaces/declaring-001.xml: Added.
      * ietestcenter/css3/namespaces/prefix-007-expected.xml: Added.
      * ietestcenter/css3/namespaces/prefix-007.xml: Added.
      * ietestcenter/css3/namespaces/prefix-008-expected.xml: Added.
      * ietestcenter/css3/namespaces/prefix-008.xml: Added.
      * ietestcenter/css3/namespaces/prefix-009-expected.xml: Added.
      * ietestcenter/css3/namespaces/prefix-009.xml: Added.
      * ietestcenter/css3/namespaces/prefix-010-expected.xml: Added.
      * ietestcenter/css3/namespaces/prefix-010.xml: Added.
      * ietestcenter/css3/namespaces/prefix-011-expected.xml: Added.
      * ietestcenter/css3/namespaces/prefix-011.xml: Added.
      * ietestcenter/css3/namespaces/qualifiedNames-001-expected.xml: Added.
      * ietestcenter/css3/namespaces/qualifiedNames-001.xml: Added.
      * ietestcenter/css3/namespaces/scope-003-expected.xml: Added.
      * ietestcenter/css3/namespaces/scope-003.xml: Added.
      * ietestcenter/css3/namespaces/syntax-016-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-016.xml: Added.
      * ietestcenter/css3/namespaces/syntax-017-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-017.xml: Added.
      * ietestcenter/css3/namespaces/syntax-018-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-018.xml: Added.
      * ietestcenter/css3/namespaces/syntax-019-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-019.xml: Added.
      * ietestcenter/css3/namespaces/syntax-020-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-020.xml: Added.
      * ietestcenter/css3/namespaces/syntax-021-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-021.xml: Added.
      * ietestcenter/css3/namespaces/syntax-022-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-022.xml: Added.
      * ietestcenter/css3/namespaces/syntax-023-expected.xml: Added.
      * ietestcenter/css3/namespaces/syntax-023.xml: Added.
      * ietestcenter/css3/namespaces/terminology-001-expected.xml: Added.
      * ietestcenter/css3/namespaces/terminology-001.xml: Added.
      * platform/chromium/test_expectations.txt:
      * platform/efl/test_expectations.txt:
      * platform/gtk/test_expectations.txt:
      * platform/mac/test_expectations.txt:
      * platform/qt/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c81b118
    • jianli@chromium.org's avatar
      Unreviewed. Mark 1 crashed test for chromium mac. · 2ab1272f
      jianli@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ab1272f
    • commit-queue@webkit.org's avatar
      ImageSkia.cpp does not conform to style guidelines · 89e18660
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86219
      
      Patch by Keyar Hood <keyar@chromium.org> on 2012-05-11
      Reviewed by Stephen White.
      
      No tests as this is purely style changees.
      
      * platform/graphics/skia/ImageSkia.cpp:
      (WebCore::TransformDimensions):
      (WebCore::BitmapImage::draw):
      (WebCore::BitmapImageSingleFrameSkia::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e18660
    • jianli@chromium.org's avatar
      Unreviewed. Rebaseline one test for chromium mac. · 2c58cb79
      jianli@chromium.org authored
      * platform/chromium-mac-leopard/css3/filters/custom/effect-color-check-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c58cb79
    • philn@webkit.org's avatar
      Unreviewed, GTK rebaseline after fonts update in r116778. · 7ac891c1
      philn@webkit.org authored
      * platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
      * platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
      * platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
      * platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
      * platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
      * platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
      * platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
      * platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
      * platform/gtk/fast/dynamic/text-combine-expected.txt:
      * platform/gtk/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
      * platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt:
      * platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt:
      * platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
      * platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
      * platform/gtk/fast/ruby/base-shorter-than-text-expected.txt:
      * platform/gtk/fast/ruby/nested-ruby-expected.txt:
      * platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
      * platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
      * platform/gtk/fast/text/emphasis-combined-text-expected.txt:
      * platform/gtk/fast/text/emphasis-vertical-expected.txt:
      * platform/gtk/fast/text/international/001-expected.txt:
      * platform/gtk/fast/text/international/002-expected.txt:
      * platform/gtk/fast/text/international/003-expected.txt:
      * platform/gtk/fast/text/international/plane2-expected.txt:
      * platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
      * platform/gtk/fast/text/international/text-spliced-font-expected.txt:
      * platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt:
      * platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt:
      * platform/gtk/fast/text/international/wrap-CJK-001-expected.txt:
      * platform/gtk/fast/text/justify-ideograph-complex-expected.txt:
      * platform/gtk/fast/text/justify-ideograph-simple-expected.txt:
      * platform/gtk/fast/text/justify-ideograph-vertical-expected.txt:
      * platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt:
      * platform/gtk/fast/writing-mode/fallback-orientation-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
      * platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
      * platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt:
      * platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt:
      * platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt:
      * platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/svg/dom/altGlyph-dom-expected.txt:
      * platform/gtk/svg/text/text-fonts-01-t-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ac891c1
    • timothy_horton@apple.com's avatar
      Unreviewed Chromium build fix after http://trac.webkit.org/changeset/116799. · 7ce2a73b
      timothy_horton@apple.com authored
      * rendering/RenderLayerBacking.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ce2a73b
    • commit-queue@webkit.org's avatar
      [chromium] Compute the best target node on a GestureTap event · 2f8ef8b3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85101
      
      Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-11
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Will be using the tests in the touchadjustment/ directory.
      
      * WebCore.gypi:
      Include TouchAdjustment.* files.
      
      Source/WebKit/chromium:
      
      * features.gypi:
      Enable the touch adjustment code by default.
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
      In the case of a GestureTap, deltaX represents the horizontal padding of the touch
      area and deltaY represents the vertical padding of the touch area.
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      Skipping two layout tests in the touchadjustment/ directory that
      fail using DRT but pass when I run through the test cases manually.
      Allan Jensen experiences a similar problem with these two tests
      on the qt port (see comment 36 in the bug description) and will be
      investigating why these tests have unexpected behavior.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f8ef8b3
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r116498. · d5363701
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/116498
      https://bugs.webkit.org/show_bug.cgi?id=86251
      
      Causes crashes in major sites and security issues (Requested
      by schenney on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-11
      
      Source/WebCore:
      
      * rendering/svg/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::addChild):
      * rendering/svg/RenderSVGInlineText.cpp:
      (WebCore::RenderSVGInlineText::willBeDestroyed):
      (WebCore::RenderSVGInlineText::setTextInternal):
      (WebCore::RenderSVGInlineText::styleDidChange):
      * rendering/svg/RenderSVGText.cpp:
      (WebCore::recursiveUpdateLayoutAttributes):
      (WebCore::RenderSVGText::layoutAttributesChanged):
      (WebCore::RenderSVGText::layoutAttributesWillBeDestroyed):
      (WebCore::RenderSVGText::invalidateTextPositioningElements):
      (WebCore::recursiveUpdateScaledFont):
      (WebCore::RenderSVGText::layout):
      (WebCore::RenderSVGText::addChild):
      (WebCore::recursiveCollectLayoutAttributes):
      (WebCore::RenderSVGText::rebuildLayoutAttributes):
      (WebCore):
      * rendering/svg/RenderSVGText.h:
      (RenderSVGText):
      (WebCore::RenderSVGText::layoutAttributes):
      * rendering/svg/SVGRootInlineBox.cpp:
      (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
      * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
      (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
      
      LayoutTests:
      
      * svg/text/add-tspan-position-bug-expected.html: Removed.
      * svg/text/add-tspan-position-bug.html: Removed.
      * svg/text/modify-tspan-position-bug-expected.html: Removed.
      * svg/text/modify-tspan-position-bug.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5363701
    • kevino@webkit.org's avatar
    • timothy_horton@apple.com's avatar
      FrameView->m_lastPaintTime is not updated in the tiled drawing case · 92102837
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86246
      <rdar://problem/11248475>
      
      Reviewed by Simon Fraser.
      
      Update FrameView's m_lastPaintTime from RenderLayerBacking::paintContents
      if the RenderLayerBacking is backing a tiled drawing layer.
      
      In the future we might want to consider updating m_lastPaintTime when any
      compositing layer is painted into, but this change gets us on par with the
      non-tiled-drawing case as it stands now.
      
      No new tests.
      
      * page/FrameView.h:
      (WebCore::FrameView::setLastPaintTime):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::paintContents):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92102837
    • commit-queue@webkit.org's avatar
      Add helper function for node()->rootEditableElement() == node() · 5f402936
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86217
      
      Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-11
      Reviewed by Ryosuke Niwa.
      
      Added Node::isRootEditableElement and updated existing code that did
      (node->rootEditableElement() == node) to use isRootEditableElement
      instead.
      
      No new tests. No change in behavior.
      
      * dom/Node.cpp:
      (WebCore::Node::isRootEditableElement):
      (WebCore):
      * dom/Node.h:
      (Node):
      Added new helper function.
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode):
      * dom/Element.cpp:
      (WebCore::Element::updateFocusAppearance):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::removeNode):
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      * page/FocusController.cpp:
      (WebCore::FocusController::setFocusedNode):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hasLineIfEmpty):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::addOverflowFromInlineChildren):
      Updates to existing code to use the new helper function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f402936
    • shawnsingh@chromium.org's avatar
      [chromium] Create WebTransformationMatrix interface for chromium platform · 11ed7027
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86049
      
      Reviewed by James Robinson.
      
      Source/Platform:
      
      * Platform.gyp/Platform.gyp:
      * Platform.gypi:
      * chromium/public/WebTransformationMatrix.h: Added.
      (WebCore):
      (WebKit):
      (WebTransformationMatrix):
      
      Source/WebCore:
      
      This patch creates a WebTransformationMatrix interface. It will
      remain unused at the moment, until (a) unit tests are created
      and (b) when we are ready to make a brief transition of all other
      chromium code to use it.
      
      * WebCore.gypi:
      * platform/chromium/support/WebTransformationMatrix.cpp: Added.
      (WebKit):
      (WebKit::WebTransformationMatrix::WebTransformationMatrix):
      (WebKit::WebTransformationMatrix::operator=):
      (WebKit::WebTransformationMatrix::operator==):
      (WebKit::WebTransformationMatrix::operator*):
      (WebKit::WebTransformationMatrix::inverse):
      (WebKit::WebTransformationMatrix::to2dTransform):
      (WebKit::WebTransformationMatrix::multiply):
      (WebKit::WebTransformationMatrix::makeIdentity):
      (WebKit::WebTransformationMatrix::translate):
      (WebKit::WebTransformationMatrix::translate3d):
      (WebKit::WebTransformationMatrix::translateRight3d):
      (WebKit::WebTransformationMatrix::scale):
      (WebKit::WebTransformationMatrix::scaleNonUniform):
      (WebKit::WebTransformationMatrix::scale3d):
      (WebKit::WebTransformationMatrix::rotate):
      (WebKit::WebTransformationMatrix::rotate3d):
      (WebKit::WebTransformationMatrix::skewX):
      (WebKit::WebTransformationMatrix::skewY):
      (WebKit::WebTransformationMatrix::applyPerspective):
      (WebKit::WebTransformationMatrix::blend):
      (WebKit::WebTransformationMatrix::hasPerspective):
      (WebKit::WebTransformationMatrix::isInvertible):
      (WebKit::WebTransformationMatrix::isBackFaceVisible):
      (WebKit::WebTransformationMatrix::isIdentity):
      (WebKit::WebTransformationMatrix::isIdentityOrTranslation):
      (WebKit::WebTransformationMatrix::isIntegerTranslation):
      (WebKit::WebTransformationMatrix::m11):
      (WebKit::WebTransformationMatrix::setM11):
      (WebKit::WebTransformationMatrix::m12):
      (WebKit::WebTransformationMatrix::setM12):
      (WebKit::WebTransformationMatrix::m13):
      (WebKit::WebTransformationMatrix::setM13):
      (WebKit::WebTransformationMatrix::m14):
      (WebKit::WebTransformationMatrix::setM14):
      (WebKit::WebTransformationMatrix::m21):
      (WebKit::WebTransformationMatrix::setM21):
      (WebKit::WebTransformationMatrix::m22):
      (WebKit::WebTransformationMatrix::setM22):
      (WebKit::WebTransformationMatrix::m23):
      (WebKit::WebTransformationMatrix::setM23):
      (WebKit::WebTransformationMatrix::m24):
      (WebKit::WebTransformationMatrix::setM24):
      (WebKit::WebTransformationMatrix::m31):
      (WebKit::WebTransformationMatrix::setM31):
      (WebKit::WebTransformationMatrix::m32):
      (WebKit::WebTransformationMatrix::setM32):
      (WebKit::WebTransformationMatrix::m33):
      (WebKit::WebTransformationMatrix::setM33):
      (WebKit::WebTransformationMatrix::m34):
      (WebKit::WebTransformationMatrix::setM34):
      (WebKit::WebTransformationMatrix::m41):
      (WebKit::WebTransformationMatrix::setM41):
      (WebKit::WebTransformationMatrix::m42):
      (WebKit::WebTransformationMatrix::setM42):
      (WebKit::WebTransformationMatrix::m43):
      (WebKit::WebTransformationMatrix::setM43):
      (WebKit::WebTransformationMatrix::m44):
      (WebKit::WebTransformationMatrix::setM44):
      (WebKit::WebTransformationMatrix::a):
      (WebKit::WebTransformationMatrix::setA):
      (WebKit::WebTransformationMatrix::b):
      (WebKit::WebTransformationMatrix::setB):
      (WebKit::WebTransformationMatrix::c):
      (WebKit::WebTransformationMatrix::setC):
      (WebKit::WebTransformationMatrix::d):
      (WebKit::WebTransformationMatrix::setD):
      (WebKit::WebTransformationMatrix::e):
      (WebKit::WebTransformationMatrix::setE):
      (WebKit::WebTransformationMatrix::f):
      (WebKit::WebTransformationMatrix::setF):
      (WebKit::WebTransformationMatrix::toWebCoreTransform):
      (WebKit::WebTransformationMatrix::mapRect):
      (WebKit::WebTransformationMatrix::mapPoint):
      (WebKit::WebTransformationMatrix::mapQuad):
      (WebKit::WebTransformationMatrix::projectPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11ed7027
    • kling@webkit.org's avatar
      WK2/Plugins: Move enumeration of plugins to a secondary UIProcess thread. · 89ef6688
      kling@webkit.org authored
      <http://webkit.org/b/86143>
      <rdar://problem/10777218>
      
      Reviewed by Anders Carlsson.
      
      To avoid spins beneath PluginInfoStore::getPluginInfo(), do this work on a secondary
      thread in the UIProcess.
      
      * Shared/APIObject.h:
      
          Made APIObject a ThreadSafeRefCounted. In the context of this patch, this is to
          be able to dispatch bound Functions on WebContext.
      
      * WebProcess/mac/KeychainItemShimMethods.mm:
      (WebKit::responseMap):
      * WebProcess/mac/SecItemShimMethods.mm:
      (WebKit::responseMap):
      * WebKit2.xcodeproj/project.pbxproj:
      * Shared/BlockingResponseMap.h:
      (BlockingResponseMap):
      (BlockingResponseMap::waitForResponse):
      (BlockingResponseMap::didReceiveResponse):
      
           Renamed from Source/WebKit2/WebProcess/mac/KeychainShimResponseMap.h.
           Generalize this somewhat since it's useful in more than just the keychain scenario.
           This can/should be generalized further, but that's a topic for another patch.
      
      * UIProcess/Plugins/PluginInfoStore.h:
      * UIProcess/Plugins/PluginInfoStore.cpp:
      (WebKit::PluginInfoStore::plugins):
      (WebKit::PluginInfoStore::findPluginForMIMEType):
      (WebKit::PluginInfoStore::findPluginForExtension):
      (WebKit::PluginInfoStore::findPlugin):
      (WebKit::PluginInfoStore::infoForPluginWithPath):
      
          Slap a mutex on the PluginInfoStore since it can now be called from both the
          main thread (via WKFrameCanShowMIMEType) and the GetPlugin work queue.
      
      * UIProcess/WebContext.messages.in:
      * UIProcess/WebContext.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::WebContext):
      (WebKit::WebContext::~WebContext):
      (WebKit::WebContext::processDidFinishLaunching):
      (WebKit::WebContext::sendDidGetPlugins):
      (WebKit::WebContext::handleGetPlugins):
      (WebKit::WebContext::getPlugins):
      (WebKit::WebContext::didReceiveMessageOnConnectionWorkQueue):
      
          Make GetPlugins a DispatchOnConnectionQueue message and execute it on a new
          plug-in work queue. This effectively makes the GetPlugin call asynchronous.
          On Mac, the built-in PDF reader is still registered on the main thread as that
          ends up calling into localizedString().
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::didGetPlugins):
      * WebProcess/WebProcess.h:
      * WebProcess/WebProcess.messages.in:
      
          Add a DidGetPlugins message to WebProcess. This is passed directly to the handler
          in WebPlatformStrategies.cpp.
      
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::responseMap):
      (WebKit::handleDidGetPlugins):
      (WebKit::generateRequestID):
      (WebKit::WebPlatformStrategies::populatePluginCache):
      
          Use a BlockingResponseMap to block the WebProcess main thread until the UIProcess
          responds with DidGetPlugins.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89ef6688
    • achicu@adobe.com's avatar
      [CSS Shaders] Make CSS Shaders render to texture framebuffers · 8e0452af
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85113
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Added the required members to store the framebuffer, the texture and the depth buffer. Also removed the m_drawingBuffer
      because context->readPixels doesn't require one anymore.
      
      ReadPixels is not flipping the result, so I've also removed the flipping projection matrix that was specific only to Chromium.
      
      Added a test to check that colors are not switched and the resulting image is not mirrored.
      
      Test: css3/filters/custom/effect-color-check.html
      
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::FECustomFilter):
      (WebCore::FECustomFilter::~FECustomFilter):
      (WebCore):
      (WebCore::FECustomFilter::deleteRenderBuffers):
      (WebCore::FECustomFilter::platformApplySoftware):
      (WebCore::FECustomFilter::initializeContext):
      (WebCore::FECustomFilter::resizeContext):
      (WebCore::FECustomFilter::bindProgramAndBuffers):
      * platform/graphics/filters/FECustomFilter.h:
      (FECustomFilter):
      
      LayoutTests:
      
      Added a test to check that colors are not switched and the resulting image is not mirrored.
      
      * css3/filters/custom/effect-color-check-expected.png: Added.
      * css3/filters/custom/effect-color-check-expected.txt: Added.
      * css3/filters/custom/effect-color-check.html: Added.
      * css3/filters/resources/color-fill.fs: Added.
      * platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
      * platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
      * platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e0452af
    • andersca@apple.com's avatar
      REGRESSION(r116687): [Chromium] plugins/embed-attributes-style.html shows a garbled string · 62fd97c2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86170
      
      Reviewed by Andreas Kling.
      
      The string we are passing to the TextRun constructor needs to stay alive for longer so revert back to the old
      behavior where we store it as a member variable.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::unavailablePluginReplacementText):
      (WebCore):
      (WebCore::RenderEmbeddedObject::setPluginUnavailabilityReason):
      (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
      * rendering/RenderEmbeddedObject.h:
      (RenderEmbeddedObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62fd97c2
    • commit-queue@webkit.org's avatar
      [EFL] Tests needs rebaselining after r116776 · d56a35b9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86227
      
      Unreviewed gardening.
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-11
      
      * platform/efl/fast/css/line-height-determined-by-primary-font-expected.png:
      * platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt:
      * platform/efl/fast/dynamic/text-combine-expected.png:
      * platform/efl/fast/dynamic/text-combine-expected.txt:
      * platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
      * platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
      * platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
      * platform/efl/fast/ruby/base-shorter-than-text-expected.png:
      * platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
      * platform/efl/fast/ruby/nested-ruby-expected.png:
      * platform/efl/fast/ruby/nested-ruby-expected.txt:
      * platform/efl/fast/text/backslash-to-yen-sign-euc-expected.png:
      * platform/efl/fast/text/backslash-to-yen-sign-euc-expected.txt:
      * platform/efl/fast/text/backslash-to-yen-sign-expected.png:
      * platform/efl/fast/text/backslash-to-yen-sign-expected.txt:
      * platform/efl/fast/text/emphasis-combined-text-expected.png:
      * platform/efl/fast/text/emphasis-combined-text-expected.txt:
      * platform/efl/fast/text/justify-ideograph-leading-expansion-expected.png:
      * platform/efl/fast/text/justify-ideograph-leading-expansion-expected.txt:
      * platform/efl/fast/text/justify-ideograph-simple-expected.png:
      * platform/efl/fast/text/justify-ideograph-simple-expected.txt:
      * platform/efl/fast/text/justify-ideograph-vertical-expected.png:
      * platform/efl/fast/text/justify-ideograph-vertical-expected.txt:
      * platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.png:
      * platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
      * platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.png:
      * platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d56a35b9
    • simon.fraser@apple.com's avatar
      Source/WebCore: CVDisplayLink keeps running after a single requestAnimationFrame · 08590c81
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=86174
      
      Reviewed by Sam Weinig.
      
      A DisplayRefreshMonitor would keep its CVDisplayLink alive for as long
      as it had clients, and the client is the ScriptedAnimationController, which
      lives on the document. So a single requestAnimationFrame call would kick
      off a CVDisplayLink which lived until the document was destroyed.
      
      Fix by having the DisplayRefreshMonitor kill itself if the CVDisplayLink
      fires for 10 times with no scheduled callbacks (to avoid creation/deletion
      thrash on pages that call requestAnimationFrames with short setTimeouts,
      as some do).
      
      Use a HashMap in DisplayRefreshMonitorManager for the set of DisplayRefreshMonitor,
      with the displayID as the key (using UnsignedWithZeroKeyHashTraits<uint64_t> since
      we want to allow for 0 to be a valid displayID).
      
      Use a HashSet in DisplayRefreshMonitor for the client set, so that we don't have to
      worry about adding clients twice.
      
      Also fix a possible crash when the only client of a DisplayRefreshMonitor
      was removed from inside the callback by making DisplayRefreshMonitor ref-counted,
      with a protector.
      
      Test: fast/animation/request-animation-frame-detach-element2.html
      
      * platform/graphics/DisplayRefreshMonitor.cpp:
      (WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor): Initialize m_unscheduledFireCount
      (WebCore::DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread): Renamed
      from refreshDisplayOnMainThread, since it doesn't just refresh the display.
      (WebCore::DisplayRefreshMonitor::addClient): No longer inline.
      (WebCore::DisplayRefreshMonitor::removeClient): No longer inline.
      (WebCore::DisplayRefreshMonitor::displayDidRefresh): Keep track of m_unscheduledFireCount,
      which we used to kill this monitor if it has been idle for a while.
      Use a RefPtr<DisplayRefreshMonitor> to prevent deletion while running the callback.
      Copy the clients to a vector to protect against mutating the set while enumerating it.
      Notify the DisplayRefreshMonitorManager when we're done, so that it can decide
      to delete inactive monitors.
      
      (WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient): find or allocate
      a DisplayRefreshMonitor for a given client.
      (WebCore::DisplayRefreshMonitorManager::registerClient): Simplified by use of HashMap.
      (WebCore::DisplayRefreshMonitorManager::unregisterClient): Ditto.
      (WebCore::DisplayRefreshMonitorManager::scheduleAnimation): Ditto. Uses
      ensureMonitorForClient() since an earlier inactive monitor may have been removed.
      (WebCore::DisplayRefreshMonitorManager::displayDidRefresh): Remove inactive
      monitors.
      * platform/graphics/DisplayRefreshMonitor.h: Make DisplayRefreshMonitor
      ref-counted, to make it easier to avoid deletion while it's on the stack.
      (WebCore::DisplayRefreshMonitor::create):
      (DisplayRefreshMonitor):
      (WebCore::DisplayRefreshMonitor::shouldBeTerminated):
      (DisplayRefreshMonitorManager):
      * platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp: Attempt to
      keep things building.
      (WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
      (WebCore::DisplayRefreshMonitor::displayLinkFired):
      to give the manager a chance to kill this monitor.
      * platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
      (WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
      (WebCore::DisplayRefreshMonitor::displayLinkFired): Don't bail early
      if not scheduled; we want to call handleDisplayRefreshedNotificationOnMainThread(),
      
      LayoutTests: CVDisplayLink keeps running after a single requestAnimationFrame
      https://bugs.webkit.org/show_bug.cgi?id=86174
      
      Reviewed by Sam Weinig.
      
      Test removing a frame inside its requestAnimationFrame callback.
      
      * fast/animation/request-animation-frame-detach-element2-expected.txt: Added.
      * fast/animation/request-animation-frame-detach-element2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08590c81
    • pfeldman@chromium.org's avatar
      Web Inspector: move canEditScriptSource and setScriptSource from... · 2ea7ad36
      pfeldman@chromium.org authored
      Web Inspector: move canEditScriptSource and setScriptSource from DebuggerPresentationModel into ResourceBinding
      https://bugs.webkit.org/show_bug.cgi?id=86234
      
      Reviewed by Vsevolod Vlasov.
      
      Simple move refactoring.
      
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel):
      (WebInspector.DebuggerResourceBinding):
      (WebInspector.DebuggerResourceBinding.canEditScriptSource):
      (WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
      (WebInspector.DebuggerResourceBinding.setScriptSource):
      (WebInspector.DebuggerResourceBinding.prototype.canSetContent):
      (WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
      (WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
      (WebInspector.JavaScriptSourceFrame.prototype.editContent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ea7ad36
    • jchaffraix@webkit.org's avatar
      Remove RenderLayer::m_scrollOverflow · 3176f6e6
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86226
      
      Reviewed by Simon Fraser.
      
      No expected change in behavior.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::computeScrollDimensions):
      Added 2 local variables to compute the left / top scrollable overflows.
      
      * rendering/RenderLayer.h:
      (WebCore::RenderLayer::scrolledContentOffset):
      Returned m_scrollOffset directly as this is what the old code was doing by adding
      m_scrollOrigin then adding m_scrollOverflow (which was set to -m_scrollOrigin in
      computeScrollDimensions).
      
      (RenderLayer::m_scrollOffset): Improved the comment about what m_scrollOffset is.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3176f6e6
    • pfeldman@chromium.org's avatar
      Web Inspector: extract PresentationConsoleMessageHelper from DebuggerPresentationModel. · b36bfd4e
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86229
      
      Reviewed by Vsevolod Vlasov.
      
      This change also starts tracking messages along with the live location changes.
      
      Tested with script-formatter-console.html.
      
      * inspector/front-end/BreakpointManager.js:
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel):
      (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
      (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
      (WebInspector.PresentationConsoleMessageHelper):
      (WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
      (WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
      (WebInspector.PresentationConsoleMessageHelper.prototype._debuggerReset):
      (WebInspector.PresentationConsoleMessage):
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
      (WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
      (WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b36bfd4e
    • eae@chromium.org's avatar
      Simplify FloatingObject by removing unnecessary convenience methods. · 25d26e9c
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86163
      
      Reviewed by Eric Seidel.
      
      Simplify the pixel snapping in FloatingObject by getting rid of a bunch
      of convenience methods.
      
      No new tests, no change in functionality.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::addOverhangingFloats):
      (WebCore::RenderBlock::addIntrudingFloats):
      (WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
      (WebCore::::string):
      * rendering/RenderBlock.h:
      (FloatingObject):
      (WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
      (WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
      (WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
      (WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25d26e9c