1. 16 Jan, 2003 8 commits
    • darin's avatar
      Reviewed by Maciej. · 389288b2
      darin authored
      	- rolled in a change from the KJS folks
      
              * kjs/number_object.h: Use ObjectImp *, not Object, for the proto.
              * kjs/number_object.cpp:
              (NumberInstanceImp::NumberInstanceImp): Use ObjectImp *, not Object, for the proto.
              (NumberPrototypeImp::NumberPrototypeImp): Pass ObjectImp.
              (NumberObjectImp::construct): Use ObjectImp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      389288b2
    • darin's avatar
      Removed the Safari-49 markers to reduce confusion since · 361e7403
      darin authored
      49 was never used and includes changes that were not in 51.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      361e7403
    • darin's avatar
      * WebView.subproj/WebController.h: Fixed a comment that was out of date. · e579e0b7
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e579e0b7
    • cblu's avatar
      Fixed comment. · 9442c951
      cblu authored
              Reviewed by NOBODY (OOPS!).
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9442c951
    • cblu's avatar
      Fixed: 3125743 - right-click doesn't count as ctrl-click in Flash · f8ae501e
      cblu authored
      	AppKit doesn't call mouseDown or mouseUp on right-click. Simulate control-click mouseDown and mouseUp so plug-ins get the right-click event as they do in Carbon
      
              Reviewed by darin.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView rightMouseDown:]):
              (-[WebBaseNetscapePluginView rightMouseUp:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8ae501e
    • darin's avatar
      WebCore: · 615a7e07
      darin authored
              Reviewed by John.
      
      	- added an API for dumping the external representation of the render tree for testing
      
              * kwq/KWQRenderTreeDebug.h: Added.
              * kwq/KWQRenderTreeDebug.cpp: Added.
      
              * kwq/KWQTextStream.h: Added more overloads for operator<<.
              * kwq/KWQTextStream.mm: (QTextStream::operator<<): Implemented them.
      
              * kwq/WebCoreBridge.h: Added renderTreeAsExternalRepresentation.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge renderTreeAsExternalRepresentation]): Added.
      
      	- removed remnants of an earlier more-naive cut at this same sort of thing
      	- removed ForwardingHeaders from the project since that doesn't really help Project Builder
      
              * kwq/WebCoreTestController.h: Removed.
              * kwq/WebCoreTestController.m: Removed.
              * WebCore.exp: Removed WebCoreTestController.
              * WebCore-combined.exp: Re-generated.
              * WebCore.pbproj/project.pbxproj: Removed WebCoreTestController and ForwardingHeaders.
      
      WebKit:
      
              Reviewed by John.
      
      	- added an API for dumping the external representation of the render tree for testing
      
              * Misc.subproj/WebCoreStatistics.h: Added renderTreeAsExternalRepresentation.
              * Misc.subproj/WebCoreStatistics.m: (-[WebFrame renderTreeAsExternalRepresentation]): Added.
      
      	- removed remnants of an earlier more-naive cut at this same sort of thing
      
              * Misc.subproj/WebTestController.h: Removed.
              * Misc.subproj/WebTestController.m: Removed.
              * WebKit.exp: Removed WebTestController.
              * WebKit.pbproj/project.pbxproj: Removed WebTestController.
      
      	- other changes
      
              * WebCoreSupport.subproj/WebBridge.m: Had added new copyright date to touch a file.
      	That's not needed any more, but the date should be updated anyway.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      615a7e07
    • sheridan's avatar
      Safari-53u; tree is open · f7bab12f
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7bab12f
    • sheridan's avatar
      Safari-52 stamp · de81c91e
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de81c91e
  2. 15 Jan, 2003 4 commits
    • mjs's avatar
      Reviewed by Darin. · a7881fc9
      mjs authored
      	- fixed 3143418 - controller assert in WebStandardPanels _didStartLoadingURL
      	- fixed 3141212 - crash in kjs garbage collection (contextimp mark)
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge startLoadingResource:withURL:]): If the data source
      	doesn't have a controller, then block the load.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7881fc9
    • trey's avatar
      3144458 - user's credentials are present in a form that is revisited via b/f or history · 2c65ac11
      trey authored
      	We now never save/restore password fields.  Also if the page has a form with a password
      	field that would be submitted securely, we do not save anything on that page.
      
              Reviewed by Darin.
      
              * force-clean-timestamp:  PB isn't smart enough to know what to rebuild.
              * khtml/html/html_formimpl.cpp:
              (HTMLFormElementImpl::formWouldHaveSecureSubmission):  Utility function.
              (HTMLFormElementImpl::attach):  Tell doc if we've added a secure form.
              (HTMLFormElementImpl::parseAttribute):  Tell doc if form became secure.
              (HTMLInputElementImpl::state):  Assert that we never save password fields.
              (HTMLInputElementImpl::restoreState):  Assert that we never restore password fields.
              (HTMLInputElementImpl::attach):  Tell doc if we've added a password field.
              * khtml/html/html_formimpl.h:
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::DocumentImpl):  Init count of secure forms, password fields.
              (DocumentImpl::passwordFieldAdded):
              (DocumentImpl::passwordFieldRemoved):
              (DocumentImpl::hasPasswordField):  New methods to count password fields.
              (DocumentImpl::secureFormAdded):
              (DocumentImpl::secureFormRemoved):
              (DocumentImpl::hasSecureForm):  New methods to count secure forms.
              * khtml/xml/dom_docimpl.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::canCachePage):   Never let pages with password fields in the page cache.
              (KWQKHTMLPart::saveDocumentState):  Do not save form state if page has a form with
      	a password field that would be submitted securely
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c65ac11
    • darin's avatar
      Reviewed by Ken. · 13748990
      darin authored
      	- rolled in a change from the KJS folks
      
      	Fixes a bug where the date functions would not accept non-strings.
      	And provides a bit of a speedup.
      
              * kjs/date_object.h: Change parameter type for parseDate.
              * kjs/date_object.cpp:
              (DateObjectFuncImp::call): Always call toString, don't check the type.
              (KJS::parseDate): Take a UString parameter, not a String parameter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13748990
    • darin's avatar
      WebCore: · c12a0350
      darin authored
              Reviewed by Ken.
      
      	- fixed problem where Content-Type was coming in with suffixes like "charset"
      
              * kwq/WebCoreBridge.h: Add contentType and refresh parameters, and remove "headers"
      	parameter, from openURL method.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Get the
      	content type from a parameter, and the refresh header from a separate parameter rather
      	than extracting both from a headers dictionary.
      
      WebKit:
      
              Reviewed by Ken.
      
      	- fixed problem where Content-Type was going into WebCore with suffixes like "charset"
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady:]):
      	Pass in contentType from the response, rather than the "Content-Type" header.
      	Also pass in the refresh header separately.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c12a0350
  3. 14 Jan, 2003 7 commits
    • darin's avatar
      Reviewed by Maciej. · 5c611c4d
      darin authored
      	- fixed 3147036 -- words separated only by newlines are getting rammed together on XML page
      	- fixed 3147032 -- preformatted text is missing much whitespace on XML page
      
              * khtml/xml/xml_tokenizer.cpp: (XMLHandler::characters): Don't try to strip whitespace at all,
      	because it needs to be in the DOM.
      
      	- add support for more MIME types
      
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Add "application/xml" and "application/xhtml+xml".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c611c4d
    • mjs's avatar
      WebFoundation: · 69012bc6
      mjs authored
              Reviewed by Darin, Dave and Trey, and given the seal of approval by Don.
      
      	Added a new NSFileManager extension method which can be used to
      	remove a file but will refuse to remove a directory. Used it
      	wherever we remove files but not directories.
      
              * Misc.subproj/WebNSFileManagerExtras.h:
              * Misc.subproj/WebNSFileManagerExtras.m:
      	(-[NSFileManager _web_removeFileOnlyAtPath:]): New method that
      	removes a file using unlink(2), which means we can't possibly remove a directory.
      	Also unlink ._ file if we are on a filesystem that doesn't support a resource fork.
              * Database.subproj/WebFileDatabase.m:
              (-[WebFileDatabase _truncateToSizeLimit:]):  Use the new method.
              (-[WebFileDatabase performRemoveObjectForKey:]): Use the new method.
      
      WebKit:
      
              Reviewed by Darin, Dave and Trey, and given the seal of approval by Don.
      
      	Use new safer file removal call that does not handle directories.
      
              * Downloads.subproj/WebDownloadHandler.m:
      	(-[WebDownloadHandler cleanUpAfterFailure]): Use
      	_web_removeFileOnlyAtPath:
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream dealloc]): Use _web_removeFileOnlyAtPath:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Use _web_removeFileOnlyAtPath:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69012bc6
    • darin's avatar
      Reviewed by Dave. · a15075e3
      darin authored
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
      	Fixed uninitialized variable warning so builds work again.
      
              * WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): Added "application/xml".
              * WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): Added "application/xml".
      
      	* English.lproj/Localizable.strings: Regenerated.
      	* English.lproj/StringsNotToBeLocalized.txt: Updated for above change.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a15075e3
    • hyatt's avatar
      Make FOUC work with XML. · bcb09ec8
      hyatt authored
              Reviewed by darin.
      
              * khtml/html/html_baseimpl.cpp:
              (HTMLBodyElementImpl::attach):
              * khtml/xml/dom_xmlimpl.cpp:
              (ProcessingInstructionImpl::ProcessingInstructionImpl):
              (ProcessingInstructionImpl::checkStyleSheet):
              (ProcessingInstructionImpl::isLoading):
              (ProcessingInstructionImpl::sheetLoaded):
              (ProcessingInstructionImpl::setStyleSheet):
              * khtml/xml/dom_xmlimpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcb09ec8
    • darin's avatar
      Reviewed by Maciej. · 0bb44c36
      darin authored
      	- first cut at XML parsing with expat
      
              * khtml/khtml_part.cpp: (KHTMLPart::begin): Remove APPLE_CHANGES and use the XML
      	code for text/xml documents.
      
              * WebCore.pbproj/project.pbxproj: Added the ForwardingHeaders to the project.
      	Added new QXml files, removed old ones.
      
              * kwq/KWQXml.h: Removed.
              * kwq/KWQXml.mm: Removed.
      
              * kwq/KWQXmlAttributes.h: Added.
              * kwq/KWQXmlAttributes.mm: Added.
              * kwq/KWQXmlDefaultHandler.h: Added.
              * kwq/KWQXmlDefaultHandler.mm: Added.
              * kwq/KWQXmlSimpleReader.h: Added.
              * kwq/KWQXmlSimpleReader.mm: Added.
      
              * kwq/KWQString.h: Add fromUtf8 functions.
              * kwq/KWQString.mm: (QString::fromUtf8): Added. Simple implementation just
      	calls fromStringWithEncoding. We may need something more efficient later,
      	at least for all-ASCII text.
      
      	- other changes
      
              * khtml/khtml_part.h: Fix spelling of occurrence.
      
              * khtml/misc/decoder.cpp: (Decoder::decode): Turn on Japanese auto-detect.
      	It doesn't seem to work yet, but this does no harm.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bb44c36
    • rjw's avatar
      Fix for 3139120. This patch was contributed by Mitz Pettel. It correctly · 2028aa44
      rjw authored
              handles the visually ordered encodings.  The patch also picks up changes
              from kde that accounts for european numbers correctly in bidiReorderLine().
      
              Reviewed by Dave.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2028aa44
    • darin's avatar
      Reviewed by Trey, John, and Maciej, and given the seal of approval by Don. · 31d40d53
      darin authored
      	- fixed 3143317 -- plug-in supplied URLs cause correspondingly named files in /tmp to be deleted
      	- fixed 3143330 -- plug-in supplied URLs can overwrite files used in other windows by same plug-in
      
              * Plugins.subproj/WebBaseNetscapePluginStream.h: Make path be a char * rather than an NSString.
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream dealloc]): Use unlink() to delete the temporary file we made.
      	Since we created the file, we know it doesn't have any fancy stuff like a resource fork.
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Create the file with mkstemp instead of
      	trying to come up with our own filename. This eliminates the need to delete an old file (because we
      	are guaranteed the file is new) and also mkstemp opens the file for us, so we just need to write
      	the contents.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for above changes.
      
              - unrelated change to help with other bug analysis
      
              * WebView.subproj/WebBaseResourceHandleDelegate.m: Added assertions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31d40d53
  4. 13 Jan, 2003 4 commits
    • cblu's avatar
      WebFoundation: · bd135e16
      cblu authored
      	Fix for checking and creating proper download filenames.
      
              Reviewed by mjs, kocienda, trey.
      
              * CacheLoader.subproj/WebResourceResponse.h:
              * CacheLoader.subproj/WebResourceResponse.m: removed the filename method. That is now a category in WebKit
              * CacheLoader.subproj/WebResourceResponsePrivate.h:
              * Misc.subproj/WebNSStringExtras.h:
              * Misc.subproj/WebNSStringExtras.m:
              (-[NSString _web_filenameByFixingIllegalCharacters]): new, turns "/" into "-", strips leading dots
              * ProtocolHandlers.subproj/WebHTTPProtocolHandler.m:
              (-[WebHTTPProtocolHandler setResponseMetadata:]): don't parse out the content disposition. This is done in WebKit.
      
      WebKit:
      
      	Fix for checking and creating proper download filenames.
      
              Reviewed by mjs, kocienda, trey.
      
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h: changes for renamed savePathForResponse:andRequest: method
              * WebView.subproj/WebDefaultPolicyDelegate.m: changes for renamed savePathForResponse:andRequest: method
              (-[WebDefaultPolicyDelegate savePathForResponse:andRequest:]): renamed
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]): changes for renamed savePathForResponse:andRequest: method
      
      WebBrowser:
      
      	Fix for checking and creating proper download filenames.
      
              Reviewed by mjs, kocienda, trey.
      
              * BrowserDocument.m:
              (-[BrowserDocument pageName]): call _web_filenameByFixingIllegalCharacters on the web page title when saving the document
              * BrowserWebController.m:
              (-[BrowserWebController savePathForResponse:andRequest:]): renamed, removed temporary that checks for invalid filename. That work is done in WebKit.
              * HTMLSourceDocument.m:
              (-[HTMLSourceDocument displayName]): call suggestedFilenameForSaving
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd135e16
    • darin's avatar
      * kjs/ustring.h: Fix spelling of occurrence. · b87b8515
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b87b8515
    • darin's avatar
      Reviewed by Ken. · 908cf2a7
      darin authored
      	- fixed 3143781 -- submitting the same form twice doesn't work properly
      	(example at directory.apple.com)
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Only run the "don't submit the same
      	form twice" logic when the form is one that affects the frame that the form is in.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      908cf2a7
    • darin's avatar
      Reviewed by Maciej. · 60414e6b
      darin authored
      	- turned more recursion into iteration, and fixed some backwards stuff
      
              * kjs/grammar.y: Use the normal idiom for CaseClauses and FormalParameterList
      	rather than using append().
              * kjs/grammar.cpp: Regenerated.
      
              * kjs/nodes.h: Change ClauseListNode and ParameterNode to use the normal idiom,
      	and got rid of append methods. Also added friend declarations and calls to reverseList().
              * kjs/nodes.cpp:
              (StatListNode::ref): Iteration, not recursion.
              (StatListNode::deref): Iteration, not recursion.
              (StatListNode::execute): Iteration, not recursion.
              (StatListNode::processVarDecls): Iteration, not recursion.
              (CaseClauseNode::reverseList): Added.
              (ClauseListNode::ref): Iteration, not recursion.
              (ClauseListNode::deref): Iteration, not recursion.
              (ClauseListNode::processVarDecls): Iteration, not recursion.
              (CaseBlockNode::reverseLists): Added.
              (ParameterNode::ref): Iteration, not recursion.
              (ParameterNode::deref): Iteration, not recursion.
              (FuncDeclNode::reverseParameterList): Added.
              (FuncExprNode::reverseParameterList): Added.
              (SourceElementsNode::ref): Iteration, not recursion.
              (SourceElementsNode::deref): Iteration, not recursion.
              (SourceElementsNode::execute): Use variable name of n to match other functions.
              (SourceElementsNode::processFuncDecl): Ditto.
              (SourceElementsNode::processVarDecls): Ditto.
      
              * kjs/nodes2string.cpp:
              (SourceStream::operator<<): Used a switch statement for a bit of added clarity.
              (ElementNode::streamTo): Iteration, not recursion.
              (PropertyValueNode::streamTo): Iteration, not recursion.
              (ArgumentListNode::streamTo): Iteration, not recursion.
              (StatListNode::streamTo): Iteration, not recursion, and fixed order.
              (VarDeclListNode::streamTo): Iteration, not recursion.
              (ClauseListNode::streamTo): Used for statement to match other functions.
              (CaseBlockNode::streamTo): Used for statement to match other functions.
              (ParameterNode::streamTo): Iteration, not recursion.
              (SourceElementsNode::streamTo): Iteration, not recursion, and fixed order that has been
      	backwards since I changed how this works in nodes.cpp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60414e6b
  5. 12 Jan, 2003 7 commits
    • darin's avatar
      * WebCorePrefix.h: Needed to touch this file since we now have plain C source (expat). · 767b3718
      darin authored
              * kwq/KWQKHTMLPart.cpp: Reformatted a bit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      767b3718
    • darin's avatar
      Reviewed by Maciej. · 68877da7
      darin authored
      	- first step towards integrating expat for XML support: make it compile and link
      
              * kwq/KWQXml.mm: (QXmlSimpleReader::parse): Put in a placeholder that calls expat.
      	Mainly just used to make sure we link.
      
              * WebCore.pbproj/project.pbxproj: Added expat files.
      
              * expat/COPYING: Added.
              * expat/Changes: Added.
              * expat/MANIFEST: Added.
              * expat/README: Added.
              * expat/expat_config.h: Added.
              * expat/lib/ascii.h: Added.
              * expat/lib/asciitab.h: Added.
              * expat/lib/expat.h: Added.
              * expat/lib/iasciitab.h: Added.
              * expat/lib/internal.h: Added.
              * expat/lib/latin1tab.h: Added.
              * expat/lib/nametab.h: Added.
              * expat/lib/utf8tab.h: Added.
              * expat/lib/xmlparse.c: Added.
              * expat/lib/xmlrole.c: Added.
              * expat/lib/xmlrole.h: Added.
              * expat/lib/xmltok.c: Added.
              * expat/lib/xmltok.h: Added.
              * expat/lib/xmltok_impl.c: Added.
              * expat/lib/xmltok_impl.h: Added.
              * expat/lib/xmltok_ns.c: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68877da7
    • darin's avatar
      Reviewed by John. · f9855741
      darin authored
      	- fixed 3144882 -- pretend to be WinIE for abcnews.com
      
              * WebView.subproj/WebControllerPrivate.h: Add an enum, UserAgentStringType, with values
      	Safari, MacIE, and WinIE. Also add NumUserAgentStringTypes and turn the userAgent and
      	userAgentWhenPretendingToBeMacIE strings into an array indexed by type.
      
              * WebView.subproj/WebController.m:
              (-[WebController setApplicationNameForUserAgent:]): Use a loop to discard the user agent
      	strings, since we have an array now.
              (-[WebController userAgentForURL:]): Change user agent algorithm to check two strings rather
      	than once against the spoof table, allowing two dots in the "domain name", which is needed
      	for "abcnews.go.com". Get a user agent string type from the table rather than just a boolean
      	"pretend to be MacIE". Store a string per type rather than one for normalcy and one for MacIE.
      	Add a case for WinIE to the user agent computations.
      
      	* English.lproj/StringsNotToBeLocalized.txt: Update for change above.
      
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebControllerPrivate dealloc]): Use a loop to discard the user agent strings, since we have
      	an array now.
              (-[WebController _defaultsDidChange]): Ditto.
      
              * WebView.subproj/WebUserAgentSpoofTable.gperf: Add a UserAgentStringType field to the struct.
      	Add MacIE to each existing table entry, and add a new one that says WinIE for abcnews.go.com.
      
              * Makefile.am: Pass "-F ,0" to gperf so that we don't get warnings compiling empty entries
      	in the hash table.
      
              * WebView.subproj/WebUserAgentSpoofTable.c: Re-generated.
      
              - other changes
      
              * WebView.subproj/WebHTMLView.m: Removed some old, dead, #if 0'd code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9855741
    • darin's avatar
      Reviewed by John. · ffcf8970
      darin authored
      	- changes inspired by things I noticed reviewing diffs vs. KDE when preparing the tarball
      
              * kjs/function.cpp: (GlobalFuncImp::call): Use strtol when strtoll is
      	not available. Do #ifndef NDEBUG, not #if !NDEBUG.
              * kjs/function.h: Do #ifndef NDEBUG, not #if !NDEBUG.
              * kjs/internal.cpp:
              (InterpreterImp::initGlobalObject): Do #ifndef NDEBUG, not #if !NDEBUG.
              (KJS::printInfo): Remove case for ListType and remove default case that just
      	ends up suppressing the "missing case" warning and does no good.
              * kjs/interpreter.cpp: (Interpreter::evaluate): Do #ifndef NDEBUG, not #if !NDEBUG.
              * kjs/nodes.cpp:
              (Node::finalCheck): Fix accidentally-deleted code in an ifdef we never compile.
              (FunctionCallNode::evaluate): Remove bogus XXX comment. Maciej put this comment in,
              and together we determined it's not needed.
              (TypeOfNode::evaluate): Ditto.
              * kjs/object.cpp: Remove assert that refers to ListType.
              * kjs/value.h: Remove ListType.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffcf8970
    • darin's avatar
      Reviewed by Dave. · d8d3bd9d
      darin authored
      	- minor cleanup of plug-in-related classes in ECMA directory
      
              * khtml/ecma/kjs_navigator.cpp: Remove unneeded PluginBase member functions
      	ref() and deref(). Instead just make Plugin and MimeType both derive from
      	PluginBase and remove APPLE_CHANGES.
              (Navigator::getValueProperty): Don't use "Konqueror" for the fallback.
      	Just return Undefined() for that case since we will never reach it anyway.
      
      	- simplify the logic in khtmlMoveMouseEvent so it's easier to decipher
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::khtmlMouseMoveEvent): By merging two
      	identical if statements, the logic of this function becomes much clearer.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d3bd9d
    • darin's avatar
      Reviewed by Dave. · 50560aa1
      darin authored
      	- fixed a bunch of places where KHTML did !x == y instead of !(x == y) or x != y.
      
              * khtml/css/cssstyleselector.cpp: (CSSStyleSelector::applyRule):
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
              * khtml/misc/loader.cpp: (Cache::requestImage), (Cache::requestStyleSheet):
              * khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
      	Changed !x == y to x != y. In each case, there's a reason that this does not create
      	any problem in practice, which is why we didn't rush to get this in for beta 1.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50560aa1
    • darin's avatar
      Reviewed by John. · 895eae19
      darin authored
      	- fixed 3144789 -- reproducible crash in KHTMLParser::freeBlock on a page at www.library.arizona.edu
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Call freeBlock here rather than
      	waiting until the parser is destroyed. This fixes the bug because when the parser is
              destroyed, the document is already destroyed, so we have a dangling current pointer to an
      	already-destroyed node.
      
      	- fixed 3142024 -- crash/hang/assert on java.sun.com in HTMLTokenizer
      
      	The bug was caused by an erroneous clicked signal that was being emitted by
      	QListBox at just the wrong time.
      
              * kwq/KWQListBox.h: Added _changingSelection boolean.
              * kwq/KWQListBox.mm: (QListBox::QListBox): Set _changingSelection to false.
              (QListBox::setSelected): Set _changingSelection to true.
              (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Only emit the "clicked"
      	signal if _changingSelection is false.
      
              * khtml/html/htmltokenizer.h: Add debug-only boolean inWrite.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::HTMLTokenizer): Set inWrite to false.
      	(HTMLTokenizer::write): Set inWrite to true.
      	(HTMLTokenizer::~HTMLTokenizer): Assert that inWrite is not true.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      895eae19
  6. 11 Jan, 2003 2 commits
    • darin's avatar
      Reviewed by John. · ffe35f4f
      darin authored
      	- fixed 3144479 -- put TITLE from links in status bar
      
              * WebKit.exp: Add _WebElementLinkTitleKey and also sort this file.
      
              * WebCoreSupport.subproj/WebImageRenderer.m: Need to touch a file to get the above
      	to have any effect, so update the copyright date here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffe35f4f
    • darin's avatar
      Reviewed by Dave. · c935e41a
      darin authored
      	- fixed 3136944 -- mouseover feedback over non-mapped part of image map claims
      	link to current page
      
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]):
      	Change code so we won't call completeURL and complete a null ATTR_HREF (which is distinct
      	from an empty ATTR_HREF). Did a similar cleanup on the image code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c935e41a
  7. 10 Jan, 2003 1 commit
    • darin's avatar
      JavaScriptCore: · 33188225
      darin authored
              * JavaScriptCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Updated to match above changes.
      
      WebFoundation:
      
              * WebFoundation.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      WebCore:
      
              * WebCore.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove NSHumanReadableCopyright, remove NSPrincipalClass, remove SKIP_INSTALL
      	that was in the Info plist instead of project settings.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      WebKit:
      
              * WebKit.pbproj/project.pbxproj: Add the year 2003, remove CFBundleIconFile,
      	bump marketing version to 0.8.1 and version to 52u to keep up with the branch,
      	remove CFHumanReadableCopyright, remove NSPrincipalClass.
      
              * English.lproj/InfoPlist.strings: Updated to match above changes.
      
      WebBrowser:
      
              * WebBrowser.pbproj/project.pbxproj: Add 2003 to copyright, bump versions
      	to 0.8.1 and 52u to keep up with the branch.
      
              * English.lproj/InfoPlist.strings: Update to match above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33188225
  8. 09 Jan, 2003 7 commits
    • darin's avatar
      Lets call this 51u, not 50u. · adb2832b
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adb2832b
    • darin's avatar
      WebKit: · 066636cc
      darin authored
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
              Reviewed by Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
              * English.lproj/Localizable.strings: Regenerate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      066636cc
    • rjw's avatar
      Fixed 3143361. This was a regression introduced with some image · a48249a4
      rjw authored
              rendering optimizations.  Don't bypass the tiling code path if
              the image needs to be rendered out-of-phase.
      
              Reviewed by hyatt.
      
              * WebCoreSupport.subproj/WebImageRenderer.m:
              (-[WebImageRenderer tileInRect:fromPoint:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a48249a4
    • darin's avatar
      Reviewed by Chris. · 7b10f2ff
      darin authored
      	- second pass on 3143332 - we still need a test case to be sure this is right
      
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
      	Check for "/". Also report the failure instead of just hanging on forever.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b10f2ff
    • darin's avatar
      Reviewed by Richard. · 88b01630
      darin authored
              - fixed 3143332 -- if path returned is empty string (or "." or "..") it will trash the /tmp symlink
      
              * Plugins.subproj/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
              Check for empty string, ".", and "..", and don't create files by those names.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88b01630
    • trey's avatar
      WebKit: · 38b5508b
      trey authored
      	3143294 - need short-term bulletproofing of download code against bad filenames
      
      	We protect against a download location that is not an absolute path.
      
              Reviewed by Darin
      
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
      	Bail on download if we don't have a abs path to write to.
      
      WebBrowser:
      
      	3143294 - need short-term bulletproofing of download code against bad filenames
      
      	We protect against slashes and leading periods, as well as handling empty filenames.
      
              Reviewed by Darin
      
              * BrowserWebController.m:
              (-[BrowserWebController saveFilenameForResponse:andRequest:]):
      	Check results of [response filename] carefully
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38b5508b
    • mjs's avatar
      Reviewed by Dave. · 3de55bfc
      mjs authored
      	- fixed Radar 3143013 - hang trying to load spiny.com/software
      
              * khtml/rendering/render_table.cpp:
              (RenderTable::layoutRows): Check for the render root as a loop
      	termination condition, to avoid an infinite loop for an absolute
      	but non-fixed table cell.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3de55bfc