1. 12 Aug, 2009 40 commits
    • eric@webkit.org's avatar
      2009-08-12 Shinichiro Hamaji <hamaji@chromium.org> · 3823123f
      eric@webkit.org authored
              Reviewed by Dan Bernstein.
      
              fix a typo in platform/graphics/skia/PlatformContextSkia.cpp
              https://bugs.webkit.org/show_bug.cgi?id=28172
      
              No new tests because it's a just typo fix.
      
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (PlatformContextSkia::setupPaintCommon):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3823123f
    • pkasting@chromium.org's avatar
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=27458 · 08b2ce18
      pkasting@chromium.org authored
      Support for the :default CSS pseudoclass, as per HTML5 spec.
      http://www.whatwg.org/specs/web-apps/current-work/multipage/interactive-elements.html#selector-default
      
      Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
      Reviewed by Darin Adler.
      
      Tests: fast/css/pseudo-default-001.html
             fast/css/pseudo-default-002.html
             fast/css/pseudo-default-003.html
             fast/css/pseudo-default-004.html
      
      * css/CSSSelector.cpp:
      (WebCore::CSSSelector::extractPseudoType): pseudoDefault
      * css/CSSSelector.h:
      (WebCore::CSSSelector::):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::canShareStyleWithElement): sharing stuff is
      aware that only one default button can be present in a form
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): applies
      the :default CSS pseudoclass
      * dom/Element.h:
      (WebCore::Element::isDefaultButtonForForm): new method to determine
      whether a FormControl is a default button for a given form
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::isDefaultButtonForForm): ditto
      * html/HTMLFormControlElement.h:
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::defaultButton): extracts the default button
      from the form
      * html/HTMLFormElement.h:
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=27458
      Test suite for the :default CSS pseudoclass.
      
      Patch by Michelangelo De Simone <micdesim@gmail.com> on 2009-08-12
      Reviewed by Darin Adler.
      
      * fast/css/pseudo-default-001-expected.txt: Added.
      * fast/css/pseudo-default-001.html: Added.
      * fast/css/pseudo-default-002-expected.txt: Added.
      * fast/css/pseudo-default-002.html: Added.
      * fast/css/pseudo-default-003-expected.txt: Added.
      * fast/css/pseudo-default-003.html: Added.
      * fast/css/pseudo-default-004-expected.txt: Added.
      * fast/css/pseudo-default-004.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08b2ce18
    • levin@chromium.org's avatar
      2009-08-12 David Levin <levin@chromium.org> · 7da12e6a
      levin@chromium.org authored
              No review, rolling out r47106.
              https://bugs.webkit.org/show_bug.cgi?id=28215
      
              This patch relied on a new version of v8 which is not available
              in chromium yet.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::v8StringToAtomicWebCoreString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7da12e6a
    • eric@webkit.org's avatar
      2009-08-12 Steve Block <steveblock@google.com> · 86c1e31c
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Bug 26993 : Geolocation::requestPermission()
              https://bugs.webkit.org/show_bug.cgi?id=26993
      
              Second patch to allow the Geolocation permission request to chrome to be asynchronous
              or synchronous. Fixes a bug where callbacks were called twice when permissions
              are granted synchronously.
      
              No new tests required.
      
              * page/Geolocation.cpp:
              (WebCore::Geolocation::setIsAllowed): Modified. Calls makeSuccessCallbacks() rather than geolocationServicePositionChanged().
              (WebCore::Geolocation::geolocationServicePositionChanged): Modified. Updated logic to avoid repeated callbacks when permissions are granted synchronously.
              (WebCore::Geolocation::makeSuccessCallbacks): Added. Calls success callbacks.
              * page/Geolocation.h: Modified. Adds makeSuccessCallbacks().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86c1e31c
    • andersca@apple.com's avatar
      <rdar://problem/6952336> · 6c6fb4b5
      andersca@apple.com authored
      CrashTracer: [USER] 3 crashes in Safari at com.apple.WebCore • WebCore::SecurityOrigin::canAccess const + 27
      
      Reviewed by Sam Weinig.
      
      Make sure to set the security origin before calling dispatchWindowObjectAvailable.
              
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::begin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c6fb4b5
    • eric@webkit.org's avatar
      2009-08-12 Xiaomei Ji <xji@chromium.org> · 6b60a145
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fix [Chromium] drop down menu letter selection, skip selections
              https://bugs.webkit.org/show_bug.cgi?id=28205
      
              Not auto-testable since it is chromim platform specific code, and it involves sending a keyboard
              event to the popup, which is not possible (eventSender sends the key
              events through webview, we want to go through the webwidget).
      
              * manual-tests/keyboard_select_elements_with_same_beginning.html: Added.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::isCharacterTypeEvent): style change.
              (WebCore::PopupListBox::handleKeyEvent): typeAheadFind should be called only when the event is
              a character type event to avoid calling twice for English.
              (WebCore::PopupListBox::typeAheadFind): remove unnecessary checking of isCharacterTypeEvent() since the whole function is only called under that condition.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b60a145
    • eric@webkit.org's avatar
      2009-08-12 Maxime Simon <simon.maxime@gmail.com> · d46e6632
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Adding GraphicsContext to WebCore/platform/graphics/haiku.
              https://bugs.webkit.org/show_bug.cgi?id=28130
      
              * platform/graphics/haiku/GraphicsContextHaiku.cpp: Added.
              (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
              (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::~GraphicsContext):
              (WebCore::GraphicsContext::platformContext):
              (WebCore::GraphicsContext::savePlatformState):
              (WebCore::GraphicsContext::restorePlatformState):
              (WebCore::GraphicsContext::drawRect):
              (WebCore::GraphicsContext::drawLine):
              (WebCore::GraphicsContext::drawEllipse):
              (WebCore::GraphicsContext::strokeArc):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::drawConvexPolygon):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::fillRoundedRect):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::beginPath):
              (WebCore::GraphicsContext::addPath):
              (WebCore::GraphicsContext::clip):
              (WebCore::GraphicsContext::drawFocusRing):
              (WebCore::GraphicsContext::drawLineForText):
              (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
              (WebCore::GraphicsContext::roundToDevicePixels):
              (WebCore::GraphicsContext::beginTransparencyLayer):
              (WebCore::GraphicsContext::endTransparencyLayer):
              (WebCore::GraphicsContext::clearRect):
              (WebCore::GraphicsContext::strokeRect):
              (WebCore::GraphicsContext::setLineCap):
              (WebCore::GraphicsContext::setLineJoin):
              (WebCore::GraphicsContext::setMiterLimit):
              (WebCore::GraphicsContext::setAlpha):
              (WebCore::GraphicsContext::setCompositeOperation):
              (WebCore::GraphicsContext::clipOut):
              (WebCore::GraphicsContext::clipToImageBuffer):
              (WebCore::GraphicsContext::getCTM):
              (WebCore::GraphicsContext::translate):
              (WebCore::GraphicsContext::origin):
              (WebCore::GraphicsContext::rotate):
              (WebCore::GraphicsContext::scale):
              (WebCore::GraphicsContext::clipOutEllipseInRect):
              (WebCore::GraphicsContext::addInnerRoundedRectClip):
              (WebCore::GraphicsContext::concatCTM):
              (WebCore::GraphicsContext::setPlatformShouldAntialias):
              (WebCore::GraphicsContext::setImageInterpolationQuality):
              (WebCore::GraphicsContext::setURLForRect):
              (WebCore::GraphicsContext::setPlatformFont):
              (WebCore::GraphicsContext::setPlatformStrokeColor):
              (WebCore::GraphicsContext::getHaikuStrokeStyle):
              (WebCore::GraphicsContext::setPlatformStrokeStyle):
              (WebCore::GraphicsContext::setPlatformStrokeThickness):
              (WebCore::GraphicsContext::setPlatformFillColor):
              (WebCore::GraphicsContext::clearPlatformShadow):
              (WebCore::GraphicsContext::setPlatformShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d46e6632
    • eric@webkit.org's avatar
      2009-08-12 Maxime Simon <simon.maxime@gmail.com> · ffb4ceed
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Modifying WebCore/platform/graphics files to allow Haiku port.
              https://bugs.webkit.org/show_bug.cgi?id=28128
      
              * platform/graphics/BitmapImage.h: Adding getBBitmap() function.
              * platform/graphics/Color.h: rgb_color is the Color struct in Haiku.
              * platform/graphics/FloatPoint.h: BPoint is the Point class in Haiku.
              * platform/graphics/FloatRect.h: BRect is the Rect class in Haiku.
              * platform/graphics/GraphicsContext.cpp:
              * platform/graphics/GraphicsContext.h: BView is the PlatformGraphicsContext
              class for Haiku. Adding getHaikuStrokeStyle() function.
              * platform/graphics/Icon.h: Adding an empty Icon() constructor because
              this class isn't implemented for the moment.
              * platform/graphics/ImageSource.h: BBitmap is the native bitmap class
              for Haiku.
              * platform/graphics/IntPoint.h: BPoint is the Point class in Haiku.
              * platform/graphics/IntRect.h: BRect is the Rect class in Haiku.
              * platform/graphics/IntSize.h: BSize is the Size class in Haiku.
              * platform/graphics/Path.h: BRegion is the Path class in Haiku.
              * platform/graphics/Pattern.h: Adding the GraphicsDef.h header and the
              native pattern type.
              * platform/graphics/SimpleFontData.h: Adding Haiku's Font.h header.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffb4ceed
    • eric@webkit.org's avatar
      2009-08-12 Maxime Simon <simon.maxime@gmail.com> · c4efd654
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Adding modification to the WebCore/platform/ files to allow
              the Haiku port.
              https://bugs.webkit.org/show_bug.cgi?id=28128
      
              * platform/ContextMenuItem.h: BMenu is the PlatformMenuItemDescription
              class of Haiku.
              * platform/Cursor.h: BCursor is the Cursor class of Haiku.
              * platform/DragData.h: Use a BMessage as DragDataRef.
              * platform/DragImage.h: Use a BBitmap as DragImageRef.
              * platform/PlatformKeyboardEvent.h: Use BMessage as event vehicle.
              * platform/PlatformMenuDescription.h: BMenu is the
              PlatformMenuDescription class of Haiku.
              * platform/PlatformMouseEvent.h: Use BMessage as event vehicle.
              * platform/PlatformWheelEvent.h: Use BMessage as event vehicle.
              * platform/PopupMenu.h: Adding a m_menu attribute for Haiku.
              * platform/Widget.h: BView is the PlatformWidget class of Haiku.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4efd654
    • eric@webkit.org's avatar
      2009-08-12 Maxime Simon <simon.maxime@gmail.com> · 1c3f6321
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Tiny modifications on WebCore files to allow Haiku port.
              https://bugs.webkit.org/show_bug.cgi?id=28128
      
              * bindings/js/ScriptControllerHaiku.cpp: Style cleanup.
              * loader/CachedFont.cpp: Haiku behaves like Qt, Gtk, or Chromium,
              so many PLATFORM(HAIKU) were added to these functions.
              (WebCore::CachedFont::~CachedFont):
              (WebCore::CachedFont::ensureCustomFontData):
              (WebCore::CachedFont::platformDataFromCustomData):
              (WebCore::CachedFont::allClientsRemoved):
              * page/EventHandler.cpp: Like the mac and Qt port, Haiku doesn't need the
              invertSenseOfTabsToLinks() function.
              * page/haiku/DragControllerHaiku.cpp: Style cleanup.
              * platform/image-decoders/ImageDecoder.h: For image decoding Haiku
              behaves like Cairo or Wx, (not like Skia).
              (WebCore::RGBA32Buffer::getAddr):
              * platform/text/PlatformString.h: Adding the String(BString&) and BString()
              methods specific to Haiku.
              * platform/text/UnicodeRange.h: Haiku needs to include stdint.h.
              * platform/text/haiku/TextBreakIteratorInternalICUHaiku.cpp:
              (WebCore::currentSearchLocaleID): Missing function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c3f6321
    • eric@webkit.org's avatar
      2009-08-12 Maxime Simon <simon.maxime@gmail.com> · 8cfa116a
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Adding the ScrollbarTheme files.
              https://bugs.webkit.org/show_bug.cgi?id=28125
      
              * platform/haiku/ScrollbarThemeHaiku.cpp: Added.
              (buttonWidth):
              (WebCore::ScrollbarTheme::nativeTheme):
              (WebCore::ScrollbarThemeHaiku::ScrollbarThemeHaiku):
              (WebCore::ScrollbarThemeHaiku::~ScrollbarThemeHaiku):
              (WebCore::ScrollbarThemeHaiku::scrollbarThickness):
              (WebCore::ScrollbarThemeHaiku::hasButtons):
              (WebCore::ScrollbarThemeHaiku::hasThumb):
              (WebCore::ScrollbarThemeHaiku::backButtonRect):
              (WebCore::ScrollbarThemeHaiku::forwardButtonRect):
              (WebCore::ScrollbarThemeHaiku::trackRect):
              (WebCore::ScrollbarThemeHaiku::paintScrollbarBackground):
              (WebCore::ScrollbarThemeHaiku::paintButton):
              (WebCore::ScrollbarThemeHaiku::paintThumb):
              * platform/haiku/ScrollbarThemeHaiku.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cfa116a
    • eric@webkit.org's avatar
      2009-08-12 Maxime Simon <simon.maxime@gmail.com> · 511e5da2
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Haiku] Adding eight simple files to WebCore/platform/graphics/haiku.
              https://bugs.webkit.org/show_bug.cgi?id=28122
      
              * platform/graphics/haiku/ColorHaiku.cpp: Added.
              (WebCore::Color::Color):
              (WebCore::Color::operator rgb_color):
              (WebCore::focusRingColor):
              * platform/graphics/haiku/FloatPointHaiku.cpp: Added.
              (WebCore::FloatPoint::FloatPoint):
              (WebCore::FloatPoint::operator BPoint):
              * platform/graphics/haiku/FloatRectHaiku.cpp: Added.
              (WebCore::FloatRect::FloatRect):
              (WebCore::FloatRect::operator BRect):
              * platform/graphics/haiku/GradientHaiku.cpp: Added.
              (WebCore::Gradient::platformDestroy):
              (WebCore::Gradient::platformGradient):
              (WebCore::Gradient::fill):
              * platform/graphics/haiku/IntPointHaiku.cpp: Added.
              (WebCore::IntPoint::IntPoint):
              (WebCore::IntPoint::operator BPoint):
              * platform/graphics/haiku/IntRectHaiku.cpp: Added.
              (WebCore::IntRect::IntRect):
              (WebCore::IntRect::operator BRect):
              * platform/graphics/haiku/IntSizeHaiku.cpp: Added.
              (WebCore::IntSize::IntSize):
              (WebCore::IntSize::operator BSize):
              * platform/graphics/haiku/PathHaiku.cpp: Added.
              (WebCore::Path::Path):
              (WebCore::Path::~Path):
              (WebCore::Path::operator=):
              (WebCore::Path::hasCurrentPoint):
              (WebCore::Path::contains):
              (WebCore::Path::translate):
              (WebCore::Path::boundingRect):
              (WebCore::Path::moveTo):
              (WebCore::Path::addLineTo):
              (WebCore::Path::addQuadCurveTo):
              (WebCore::Path::addBezierCurveTo):
              (WebCore::Path::addArcTo):
              (WebCore::Path::closeSubpath):
              (WebCore::Path::addArc):
              (WebCore::Path::addRect):
              (WebCore::Path::addEllipse):
              (WebCore::Path::clear):
              (WebCore::Path::isEmpty):
              (WebCore::Path::debugString):
              (WebCore::Path::apply):
              (WebCore::Path::transform):
              (WebCore::Path::strokeBoundingRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      511e5da2
    • andersca@apple.com's avatar
      As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113... · 4e29e672
      andersca@apple.com authored
      As per Eric Carlson's request, revert r47110 (and the follow-up fixes r47113 and r47117) since it causes ~3000 Qt tests to fail.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e29e672
    • treat@webkit.org's avatar
      WINCE PORT: Implement Keygen for WINCE · 8a415c29
      treat@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Lyon Chen <lyon.chen@torchmobile.com> on 2009-08-12
      Reviewed by George Staikos.
      
      * platform/wince/KeygenWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a415c29
    • bfulgham@webkit.org's avatar
      Rubber-stamped by Kevin Ollivier. · b05b4531
      bfulgham@webkit.org authored
      Handle crash in wx due to null value passed to strlen in
      the CString constructor.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      (WebCore::certificatePath):  Check for null return from getenv
      and use default CString constructor instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b05b4531
    • treat@webkit.org's avatar
      WINCE PORT: simple stubs to make it build for WINCE · 02330792
      treat@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
      Reviewed by Eric Seidel.
      
      * platform/wince/DragDataWince.cpp: Added.
      * platform/wince/DragImageWince.cpp: Added.
      * platform/wince/EditorWince.cpp: Added.
      * platform/wince/KURLWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02330792
    • treat@webkit.org's avatar
      WINCEPORT: FileSystem and FileChooser · e36b9e4c
      treat@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
      Reviewed by George Staikos.
      
      * platform/wince/FileChooserWince.cpp: Added.
      * platform/wince/FileSystemWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e36b9e4c
    • treat@webkit.org's avatar
      WINCE PORT: implement Cursor for WINCE. There's no real cursor on most · 512f599d
      treat@webkit.org authored
      WinMob devices. We pass the cursor info to application, which so that
      can determine what to do.
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
      Reviewed by Eric Seidel.
      
      * platform/wince/CursorWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      512f599d
    • treat@webkit.org's avatar
      WINCE PORT: MIMETypeRegistry · 3ddff728
      treat@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
      Reviewed by George Staikos.
      
      * platform/wince/MIMETypeRegistryWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ddff728
    • treat@webkit.org's avatar
      WINCE PORT: Pasteboard and SearchPopupMenu · 84a29ce6
      treat@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Joe Mason <joe.mason@torchmobile.com> on 2009-08-12
      Reviewed by George Staikos.
      
      * platform/wince/PasteboardWince.cpp: Added.
      * platform/wince/SearchPopupMenuWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84a29ce6
    • treat@webkit.org's avatar
      WINCE PORT: Add SharedTimerWince.cpp and SystemTimeWince.cpp · d78edc50
      treat@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27543
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-12
      Reviewed by George Staikos.
      
      * platform/wince/SharedTimerWince.cpp: Added.
      * platform/wince/SystemTimeWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d78edc50
    • eric@webkit.org's avatar
      2009-08-12 Mark Mentovai <mark@chromium.org> · 485486a6
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=28204
              Allow C++ exceptions to be disabled in WebCore's V8 Mac build.
      
              * WebCorePrefix.h:
              Only undefine |try| and |catch| when building Objective-C[++],
              leaving the C++ library definitions intact for C++.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      485486a6
    • japhet@chromium.org's avatar
      2009-08-12 Nate Chapin <japhet@chromium.org> · a667be55
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Add a Custom Setter for DOMWindowEvent in the V8 bindings.
              https://bugs.webkit.org/show_bug.cgi?id=27719
      
              Tests: fast/events/set-event-in-another-frame.html
                     fast/events/set-event-to-null.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a667be55
    • pkasting@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=27965 · 566436bb
      pkasting@chromium.org authored
      Merge wx/ImageSourceWx.cpp into ImageSource.cpp.  No changes to
      ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.
      
      Reviewed by Adam Treat.
      
      * WebCore.gypi:
      * WebCoreSources.bkl:
      * platform/graphics/wx/ImageSourceWx.cpp: Removed.
      * webcore-wx.bkl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      566436bb
    • pkasting@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=27933 · b8dd3c63
      pkasting@chromium.org authored
      Build fix after r47099.
      
      Reviewed by Dave Levin.
      
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::getImageData):
      (WebCore::putImageData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8dd3c63
    • treat@webkit.org's avatar
      WINCE PORT: Implement Path for WINCE. Most code can be · cf044eba
      treat@webkit.org authored
      reused for other ports that don't have native path support
      https://bugs.webkit.org/show_bug.cgi?id=28188
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
      Reviewed by Adam Treat.
      
      Written also by George Staikos (including quadCurve() and bezier())
      
      * platform/graphics/wince/PathWince.cpp: Added.
      * platform/graphics/wince/PlatformPathWince.cpp: Added.
      * platform/graphics/wince/PlatformPathWince.h: Added.
      * platform/graphics/wince/WinceGraphicsExtras.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf044eba
    • eric@webkit.org's avatar
      2009-08-12 Joseph Pecoraro <joepeck02@gmail.com> · 49ae4a16
      eric@webkit.org authored
              "Double-click to add" new style button does not always show up [quick fix]
              https://bugs.webkit.org/show_bug.cgi?id=28187
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ae4a16
    • eric@webkit.org's avatar
      2009-08-12 Crystal Zhang <crystal.zhang@torchmobile.com> · dbf8a2a6
      eric@webkit.org authored
              Reviewed by George Staikos.
      
              WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
              https://bugs.webkit.org/show_bug.cgi?id=28178
      
              * platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
              * platform/graphics/wince/MediaPlayerProxy.cpp: Added.
              * platform/graphics/wince/MediaPlayerProxy.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbf8a2a6
    • eric@webkit.org's avatar
      2009-08-12 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 0a2a5bb8
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
              https://bugs.webkit.org/show_bug.cgi?id=28175
      
              Call QDir::toNativeSeparators() before the path is passed to the OS.
      
              Based on work by David Leong.
      
              * platform/qt/FileSystemQt.cpp:
              (WebCore::pathByAppendingComponent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a2a5bb8
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · 6a6009e7
      eric.carlson@apple.com authored
              Tiger build fix.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm: 
                  Define NSAccessibilityTimelineSubrole for Tiger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a6009e7
    • krit@webkit.org's avatar
      2009-08-12 Dirk Schulze <krit@webkit.org> · a046f09a
      krit@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
              of getImageData. This changed since r47099.
      
              * platform/graphics/filters/FEColorMatrix.cpp:
              (WebCore::FEColorMatrix::apply):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a046f09a
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · cd791f33
      eric.carlson@apple.com authored
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Test: accessibility/media-element.html
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
                  Add AccessibilityMediaControls.cpp/.h
      
              * accessibility/AXObjectCache.cpp:
              * accessibility/AXObjectCache.h:
              (WebCore::AXObjectCache::getOrCreate):
                  Create AccessibilityMediaControl. Update Copyright
      
              * accessibility/AccessibilityMediaControls.cpp:
              * accessibility/AccessibilityMediaControls.h:
                  Added.
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityObject.h:
                  Add isMediaTimeline. Update Copyright.
      
              * accessibility/AccessibilitySlider.h:
                  Make constructor protected instead of private so AccessibilityMediaTimeline can
                  call it.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
                  Add NSAccessibilityValueDescriptionAttribute to range attributes. 
              (-[AccessibilityObjectWrapper subrole]):
                  Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.
      
              * dom/Node.h:
                  add isMediaControlElement.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/LocalizedStrings.h:
              * platform/mac/LocalizedStringsMac.mm:
              (WebCore::localizedMediaControlElementString): 
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription): 
                  New, return localized media controller strings.
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlElement::MediaControlElement):
                  Initialize m_displayType.
              (WebCore::MediaControlElement::MediaControlElement):
              (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
                  Fix style.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  Set m_displayType based on pseudo style ID.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  rename local "o" to "object".
              (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
              (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
              (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
              (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
              (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
                  Update for MediaControlInputElement constructor change.
              (WebCore::MediaControlTimeDisplayElement::formatTime):
                  New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
              (WebCore::MediaControlTimeDisplayElement::setCurrentValue):
                  New, set text to current time.
              * rendering/MediaControlElements.h:
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::updateControls):
                  Create controls in tab order.
              (WebCore::RenderMedia::formatTime):
                  Moved to MediaControlTimeDisplayElement::formatTime.
              (WebCore::RenderMedia::updateTimeDisplay):
                  Call MediaControlTimeDisplayElement::setCurrentValue.
              * rendering/RenderMedia.h:
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Add localized strings for media controller accessiblility.
      
              * English.lproj/Localizable.strings:
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory localizedMediaControlElementString:]):
              (-[WebViewFactory localizedMediaControlElementHelpText:]):
              (-[WebViewFactory localizedMediaTimeDescription:]):
                  New.
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::localizedMediaControlElementString):
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription):
                  New.
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * accessibility/media-element.html: Added.
              * platform/mac-leopard/accessibility/media-element-expected.txt:
              * platform/mac-leopard/media/controls-strict-expected.txt: 
              * platform/mac/accessibility/media-element-expected.txt:
                  Added.
      
              * platform/mac-leopard/media/controls-after-reload-expected.txt:
              * platform/mac-leopard/media/controls-styling-expected.txt:
              * platform/mac-leopard/media/video-empty-source-expected.txt:
              * platform/mac-leopard/media/video-zoom-controls-expected.txt:
              * media/video-controls-visible-audio-only.html:
              * platform/mac-leopard/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/controls-after-reload-expected.txt:
              * platform/mac/media/controls-styling-expected.txt:
              * platform/mac/media/video-controls-rendering-expected.txt:
              * platform/mac/media/video-display-toggle-expected.txt:
              * platform/mac/media/video-empty-source-expected.txt:
              * platform/mac/media/video-zoom-controls-expected.txt:
                  Update for controller element tab order change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd791f33
    • dglazkov@chromium.org's avatar
      2009-08-12 Viet-Trung Luu <viettrungluu@gmail.com> · 57ffe78b
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Explicitly set control tints for Chromium/Mac, since the controls'
              NSCell(s) lack an NSView and hence their tint isn't updated
              automatically when the application is activated/deactivated.
              https://bugs.webkit.org/show_bug.cgi?id=28108
              http://crbug.com/18199
      
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::updateNSCellControlTint):
              (WebCore::RenderThemeChromiumMac::paintCheckbox):
              (WebCore::RenderThemeChromiumMac::paintRadio):
              (WebCore::RenderThemeChromiumMac::paintButton):
              (WebCore::RenderThemeChromiumMac::paintMenuList):
              (WebCore::RenderThemeChromiumMac::paintSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintSearchField):
              (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton):
              (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57ffe78b
    • dglazkov@chromium.org's avatar
      2009-08-12 Christian Plesner Hansen <christian.plesner.hansen@gmail.com> · 724bff15
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Fix atomic string externalization crash.
              Atomic string externalization assumes that all non-empty strings
              can be externalized which is untrue on 64-bit.  This change fixed
              that.
      
              https://bugs.webkit.org/show_bug.cgi?id=28215
      
              This bug causes loads of test crashes, no need to add new tests
              specifically for this.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::v8StringToAtomicWebCoreString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      724bff15
    • ariya@webkit.org's avatar
      WebCore/ChangeLog: · c7d5cf16
      ariya@webkit.org authored
      2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>
      
              Reviewed by Holger Freyther.
      
              [Qt] Fix box-shadow painting in r47103. The edge should not be blurry.
              Also optimize by not having to save and restore painter state.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::drawRect):
              (WebCore::GraphicsContext::fillRect):
      
      LayoutTests/ChangeLog:
      
      2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>
      
              Reviewed by Holger Hans Peter Freyther.
      
              [Qt] Update the pixel tests for shadow edge fix.
      
              * platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
              * platform/qt/fast/box-shadow/basic-shadows-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7d5cf16
    • ariya@webkit.org's avatar
      2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com> · 8d43ffa1
      ariya@webkit.org authored
              Reviewed by Adam Treat.
      
              [Qt] Fix coding style in GraphicsContextQt.cpp
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::toQtCompositionMode):
              (WebCore::toQtLineCap):
              (WebCore::toQtLineJoin):
              (WebCore::GraphicsContextPlatformPrivate::p):
              (WebCore::GraphicsContext::drawLine):
              (WebCore::GraphicsContext::strokeArc):
              (WebCore::GraphicsContext::drawConvexPolygon):
              (WebCore::GraphicsContext::pen):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::clipPath):
              (WebCore::GraphicsContext::drawFocusRing):
              (WebCore::GraphicsContext::beginTransparencyLayer):
              (WebCore::GraphicsContext::endTransparencyLayer):
              (WebCore::GraphicsContext::clearRect):
              (WebCore::GraphicsContext::setLineCap):
              (WebCore::GraphicsContext::setLineJoin):
              (WebCore::GraphicsContext::setMiterLimit):
              (WebCore::GraphicsContext::setAlpha):
              (WebCore::GraphicsContext::clipOut):
              (WebCore::GraphicsContext::clipOutEllipseInRect):
              (WebCore::GraphicsContext::addInnerRoundedRectClip):
              (WebCore::GraphicsContext::setPlatformStrokeColor):
              (WebCore::GraphicsContext::setPlatformStrokeStyle):
              (WebCore::GraphicsContext::setPlatformStrokeThickness):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d43ffa1
    • ariya@webkit.org's avatar
      WebCore/ChangeLog: · 9b69ed48
      ariya@webkit.org authored
      2009-08-12  Szabo Carol  <carol.szabo@nokia.com>
      
              Reviewed by Simon Hausmann and Ariya Hidayat.
      
              https://bugs.webkit.org/show_bug.cgi?id=23291
      
              [Qt] Partial support for -webkit-box-shadow. Blur is not support and
              the shadow still does not go well with border radius.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::drawRect):
              (WebCore::GraphicsContext::fillRect):
      
      LayoutTests/ChangeLog:
      
      2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Pixel tests for (partial) -webkit-box-shadow support.
      
              * platform/qt/Skipped: Include basic-shadows.
              * platform/qt/fast/box-shadow/basic-shadows-expected.checksum: Added.
              * platform/qt/fast/box-shadow/basic-shadows-expected.png: Added.
              * platform/qt/fast/box-shadow/basic-shadows-expected.txt: Adjusted.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b69ed48
    • xan@webkit.org's avatar
      2009-08-12 Xan Lopez <xlopez@igalia.com> · 4d584889
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Use AM_V_GEN in a few more places, for less noisy builds.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d584889
    • krit@webkit.org's avatar
      2009-08-12 Dirk Schulze <krit@webkit.org> · acfb1ce8
      krit@webkit.org authored
              Reviewed by Oliver Hunt.
      
              SVG Filter premultiplied color support for getImageDate/putImageData
              [https://bugs.webkit.org/show_bug.cgi?id=27933]
      
              Some SVG Filters need premultiplied ImageData for the calculation. Therefore getImageData
              and putImageData of ImageBuffer need support for premultiplied colors.
      
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::getImageData):
              (WebCore::CanvasRenderingContext2D::putImageData):
              * platform/graphics/ImageBuffer.h:
              (WebCore::):
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/cg/ImageBufferCG.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/qt/ImageBufferQt.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/skia/ImageBufferSkia.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/wx/ImageBufferWx.cpp:
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * svg/graphics/SVGResourceMasker.cpp:
              (WebCore::SVGResourceMasker::applyMask):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acfb1ce8
    • pfeldman@chromium.org's avatar
      2009-08-12 Mikhail Naganov <mnaganov@chromium.org> · 6edaa93e
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Changed Number.bytesToString to support low-resolution output.
      
              https://bugs.webkit.org/show_bug.cgi?id=28146
      
              * inspector/front-end/utilities.js:
              (Number.bytesToString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6edaa93e