1. 19 Dec, 2002 3 commits
  2. 18 Dec, 2002 4 commits
    • sheridan's avatar
      Alexander-40 stamp · a5f80239
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5f80239
    • cblu's avatar
      WebKit: · fe1a76e0
      cblu authored
      	Reject the RealPlayer plug-in because we know it doesn't work.
      
              Reviewed by sullivan.
      
              * English.lproj/StringsNotToBeLocalized.txt:
              * Plugins.subproj/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage initWithPath:]): reject the RealPlayer plug-in
      
      WebBrowser:
      
      	Fixed: 3103603 - Safari becomes unresponsive while launching DiskCopy
      	Special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.
      
              Reviewed by sullivan.
      
              * BrowserNSWorkspaceExtras.m:
              (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:event:]): enable async launching of DiskCopy
              * English.lproj/Localizable.strings:
              * English.lproj/StringsNotToBeLocalized.txt:
              * LoadProgressMonitor.m:
              (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe1a76e0
    • mjs's avatar
      Tools: · cc196b5c
      mjs authored
      	Reviewed by John.
      
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
      
              * Scripts/set-alex-version: New the script takes 3 different
      	versions, source version, marketing version and internal version.
      
      JavaScriptCore:
      
      	Reviewed by John.
      
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
      
              * English.lproj/InfoPlist.strings:
              * JavaScriptCore.pbproj/project.pbxproj:
      
      WebFoundation:
      
      	Reviewed by John.
      
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
      
              * English.lproj/InfoPlist.strings:
              * WebFoundation.pbproj/project.pbxproj:
      
      WebCore:
      
      	Reviewed by John.
      
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
      
              * English.lproj/InfoPlist.strings:
      
      WebKit:
      
      	Reviewed by John.
      
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
      
              * English.lproj/InfoPlist.strings:
      
      WebBrowser:
      
      	Reviewed by John.
      
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
      
              * English.lproj/InfoPlist.strings:
              * WebBrowser.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc196b5c
    • cblu's avatar
      Fixed: 3131714 - System becomes unresponsive while downloading · 14c28e89
      cblu authored
      	While downloading a file, Safari and the Finder take up 30%-40% of the CPU each. This is happening because for every chunk of data we write to disk, we call -[NSWorkspace noteFileSystemChanged:]. noteFileSystemChanged is inefficient. It sends 2 AppleEvents each with 60 timeouts. The event also causes the Finder to do a lot of work.
      
      	We should:
      	- Send 1 AppleEvent ourselves with no timeout since we don't care about the reply
      	- Call the notification/event less often. The only benefit of sending the event for every chunk written is that the file size updates in the Finder. Not worth the performance impact.
      
              Reviewed by kocienda.
      
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler cleanUpAfterFailure]): call _web_noteFileChangedAtPath
              (-[WebDownloadHandler createFileIfNecessary]): call _web_noteFileChangedAtPath
              (-[WebDownloadHandler writeDataForkData:resourceForkData:]): don't call noteFileSystemChanged
              (-[WebDownloadHandler finishedLoading]): call _web_noteFileChangedAtPath
              * Misc.subproj/WebNSWorkspaceExtras.h: Added.
              * Misc.subproj/WebNSWorkspaceExtras.m: Added.
              (-[NSWorkspace _web_noteFileChangedAtPath:]): Notifies the Finder (or any other app that cares) that we added, removed or changed the attributes of a file. This method is better than calling noteFileSystemChanged: because noteFileSystemChanged: sends 2 apple events both with a 60 second timeout. This method returns immediately.
              * WebKit.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14c28e89
  3. 17 Dec, 2002 4 commits
    • darin's avatar
      JavaScriptCore: · 7894002d
      darin authored
              Reviewed by Trey.
      
              * JavaScriptCore.pbproj/project.pbxproj: Removed signature.
      
      WebFoundation:
      
              Reviewed by Trey.
      
              * WebFoundation.pbproj/project.pbxproj: Remove signature.
      
      WebCore:
      
              Reviewed by Trey.
      
              * WebCore.pbproj/project.pbxproj: Remove signature.
              * kwq/KWQColor.mm: Turn off inlining so we can build even on the
      	compiler that warns about static data in inline functions.
      
      WebKit:
      
              Reviewed by Trey.
      
              * WebKit.pbproj/project.pbxproj: Remove signature.
              * WebView.subproj/WebController.m: Turn off inlining so we can build even on the
      	compiler that warns about static data in inline functions.
      
      WebBrowser:
      
              Reviewed by Trey.
      
              * Scripting.subproj/Safari.scriptSuite: Change signature to sfri.
              * WebBrowser.pbproj/project.pbxproj: Change signature to sfri.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7894002d
    • sheridan's avatar
      Alexander-39, submitting to B&I · 7146c87d
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7146c87d
    • sheridan's avatar
      Alex-38 · 6535a5fe
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6535a5fe
    • darin's avatar
      top level: · fc4fd1d0
      darin authored
              Reviewed by Don and Maciej.
      
              * force-clean-timestamp: Trigger a full build since we are setting
      	MACOSX_DEPLOYMENT_TARGET to 10.2, which requires remaking all PFEs.
      
      Tools:
      
              * Scripts/check-copyright: Added.
      
      JavaScriptCore:
      
              Reviewed by Don and Maciej.
      
      	- fixed 3129115 -- need Apple copyright added to open source documents
      
      	* tons of files: Added our copyright to files we modified, and updated all to standard format.
      
      	- other changes
      
              * JavaScriptCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
      	Also removed completion.cpp.
              * kjs/completion.cpp: Removed.
              * kjs/completion.h: Made the Completion constructor inline.
      
              * kjs/grammar.y: Removed an obsolete "pretend ifdef". No need to put these in APPLE_CHANGES now.
      
      WebFoundation:
      
              Reviewed by Don and Maciej.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebFoundation.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
      
      WebCore:
      
              Reviewed by Don and Maciej.
      
      	- fixed 3129115 -- need Apple copyright added to open source documents
      
      	* tons of files: Added copyright message to files we modified and
      	standardized format of copyrights too.
      
      	- fixed 3129235 -- assert in LRUList visiting apple.com if "Display images" preference is off
      
              * khtml/misc/loader.cpp:
              (Cache::getLRUListFor): Use the first list for 0-sized objects.
              (Cache::removeFromLRUList): Allow 0-sized objects.
      
      	- other changes
      
              * khtml/rendering/render_style.h: Remove bogus unused private constructor.
      
              * kwq/KWQFont.h: Added copy constructor and assignment operator.
              * kwq/KWQFont.mm:
              (QFont::QFont): Copy constructor now retains the NSFont. The old version didn't which could
      	cause retain/release problems.
              (QFont::operator=): Retain the new NSFont and release the old one.
      
              * WebCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
      
      WebKit:
      
              Reviewed by Don and Maciej.
      
              * WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we
      	spoof as Mac IE, and added comments.
              * WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
      
              * WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2
      
      WebBrowser:
      
              Reviewed by Don and Maciej.
      
      	- fixed 3106686 -- Remove "world leak" debugging window before beta
      
              * Test/PageLoadTestController.m:
              (-[PageLoadTestController windowDidLoad]): (Not part of the bug fix.) Changed the combo
      	box so it automatically sizes to the number of pltsuite files so we don't have to edit
      	the nib all the time.
              (-[PageLoadTestController anyWindowWillClose:]): Don't do any world leak test when the
      	window closes. The one in the page load test window is still there.
      
              * Debug/DebugUtilities.m: (-[NSApplication validate_toggleAlwaysCheckForWorldLeaks:]):
      	Don't enable or check the debug menu item at all. Put an ifdef in so we can turn it on later.
      
      	- fixed 3124310 -- remove "app refuses to launch" code before shipping
      
              * main.m: (main): Remove all the licensing code.
      
      	- other changes
      
              * BrowserNSNetServiceExtras.m: Made all locally-defined-and used functions static
      	so we would know if any were unused and for cleanliness.
              (-[NSNetService hostName:andPort:]): Remove some silly assertions.
              (decode_name): Change printf for errors to ERROR.
              (decode_srv): Ditto.
      	(decode_txt): Removed because it's unused.
              (skip_question): Ditto.
              (MyDictionaryKeyHashCallBack): Removed silly assertion.
              (MyCreateCFDictionaryFromTXT): Ditto.
      
              * WebBrowser.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc4fd1d0
  4. 16 Dec, 2002 5 commits
  5. 12 Dec, 2002 3 commits
    • sheridan's avatar
      version 37u ... tree is open · c1f231f6
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f231f6
    • sheridan's avatar
      Alex-36 versions · 626b54bf
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      626b54bf
    • darin's avatar
      WebCore: · c9a8d22b
      darin authored
              Reviewed by Maciej and Richard.
      
      	- fixed 3125497 -- REGRESSION: Infinite recursion with mouseUp: events
      
      	The problem was that events could end up back at the same part due to the responder chain.
      
              * kwq/KWQKHTMLPart.h: Added mouseDown, mouseDragged, mouseUp, mouseMoved, buttonForCurrentEvent,
      	and stateForCurrentEvent. Remove setCurrentEvent and currentEvent. Renamed handleMouseDownEventForWidget
      	to passWidgetMouseDownEventToWidget. John and I had agreed to this name change before the last commit,
      	but I forgot.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::KWQKHTMLPart): Initialize _sendingEventToSubview to false. No need to initialize
      	_mouseDownWasInSubframe at all since it's only looked at when _mouseDownView is non-nil.
              (KWQKHTMLPart::keyEvent): Save and restore _currentEvent instead of setting to nil.
      	Use stateForCurrentEvent instead of stateForEvent:.
              (KWQKHTMLPart::khtmlMousePressEvent): Name change.
              (KWQKHTMLPart::khtmlMouseDoubleClickEvent): Name change.
              (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Name change. Set _sendingEventToSubview when
              sending event to subview.
              (KWQKHTMLPart::khtmlMouseReleaseEvent): Name change. Set _sendingEventToSubview when sending
      	event to subview.
              (KWQKHTMLPart::passSubframeEventToSubframe): Name change. Set _sendingEventToSubview when
      	sending event to subview.
              (KWQKHTMLPart::buttonForCurrentEvent): Added. Similar to code I moved here from WebCoreBridge.
              (KWQKHTMLPart::stateForCurrentEvent): Added. Similar to code I moved here from WebCoreBridge.
              (KWQKHTMLPart::mouseDown): Added. Similar to code I moved here from WebCoreBridge, except returns
      	and does nothing if _sendingEventToSubview is set.
              (KWQKHTMLPart::mouseDragged): Ditto.
              (KWQKHTMLPart::mouseUp): Ditto.
              (KWQKHTMLPart::mouseMoved): Added. Similar to code I moved here from WebCoreBridge.
      
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge mouseDown:]): Just call _part->mouseDown().
              (-[WebCoreBridge mouseDragged:]): Just call _part->mouseDragged().
              (-[WebCoreBridge mouseUp:]): Just call _part->mouseUp().
              (-[WebCoreBridge mouseMoved:]): Just call _part->mouseMoved().
      
              * kwq/WebCoreBridgePrivate.h: Removed.
              * WebCore.pbproj/project.pbxproj: Removed WebCoreBridgePrivate.h.
      
      WebKit:
      
              Reviewed by Maciej and Richard.
      
              - fixed reentrancy crash I ran into while debugging infinite recursion bugs
      
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _updateMouseoverWithFakeEvent]): Added. Does part of what _frameOrBoundsChanged did.
              (-[WebHTMLView _frameOrBoundsChanged]): Schedule the mouseover update to happen soon, rather than
              doing it right away. If we do it right away, we might reenter because sending a mouse moved event
              can result in another layout since mouse moved events are the same as mouse dragged events in KHTML.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView viewWillMoveToWindow:]): Cancel the scheduled mouseover update.
      
              * WebKit.pbproj/project.pbxproj: Electron uber alles.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9a8d22b
  6. 11 Dec, 2002 1 commit
    • rjw's avatar
      Fixed 3123375. Provide SPI to release all pending page caches · 7dd25690
      rjw authored
              Reviewed by kocienda.
      
              * History.subproj/WebBackForwardList.m:
              * History.subproj/WebHistoryItem.h:
              * History.subproj/WebHistoryItem.m:
              * History.subproj/WebHistoryItemPrivate.h: Added.
              * WebCoreSupport.subproj/WebBridge.m:
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebFramePrivate.m:
      
              Fixed 3123375.  Call SPI to release all pending page caches
      
              Reviewed by kocienda.
      
              * Test/PageLoadTestController.m:
              (-[PageLoadTestController anyWindowWillClose:]):
              * Test/PageLoadTestRunner.m:
              (-[PageLoadTestRunner closeBrowserWindowsAndFinishCheckingForWorldLeaks]):
              (-[PageLoadTestRunner checkForWorldLeaksSoon]):
              (-[PageLoadTestRunner checkForWorldLeaksNow]):
              (-[PageLoadTestRunner startTest]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dd25690
  7. 09 Dec, 2002 1 commit
    • darin's avatar
      Tools: · 030cad4c
      darin authored
              Reviewed by Maciej.
      
              * Scripts/set-alex-version: Make it bump the source version and marketing version
      	of all our subprojects, because that's what we need up until Alex 1.0.
      
      JavaScriptCore:
      
              Reviewed by Maciej.
      
              * JavaScriptCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	* English.lproj/InfoPlist.strings: In here too.
      
      WebFoundation:
      
              Reviewed by Maciej.
      
      	- fixed problems I noticed in my review of Chris's change (which came in too late)
      
              * CacheLoader.subproj/WebResourceLoad.m: (_guessMIMEType): Fix && vs. || confusion that
      	will make CR, LF, and tab not qualify as text characters. Also take end of loop check
      	out of the loop.
      
      	- added a method for use in user-agent computations
      
              * Misc.subproj/WebNSUserDefaultsExtras.h: Added _web_preferredLanguageCode.
              * Misc.subproj/WebNSUserDefaultsExtras.m:
              (+[NSUserDefaults _web_preferredLanguageCode]): Use _web_HTTPStyleLanguageCode on the
      	first element of the AppleLanguages array.
      
              * WebFoundation.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	Make WebNSUserDefaultsExtras.h SPI so we can use it in WebKit. Re-sort things a bit.
      	* English.lproj/InfoPlist.strings: Bump versions in here too.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
      
      WebCore:
      
              Reviewed by Maciej.
      
              * WebCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      
      WebKit:
      
              Reviewed by Maciej.
      
      	- fixed 3028664 -- change user agent string to include application name and version
      
              * WebView.subproj/WebController.m:
              (-[WebController setApplicationNameForUserAgent:]): Remove locking, unneeded since we changed
      	how WebFoundation handles user agent.
              (-[WebController setCustomUserAgent:]): Ditto.
              (-[WebController resetUserAgent]): Ditto.
              (-[WebController userAgentForURL:]): Remove locking. Also add new algorithm for computing the
      	user agent which takes the preferred language into account, and incorporates the WebKit version
      	and the application name.
      
              * WebView.subproj/WebControllerPrivate.h: No need for a lock.
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebControllerPrivate init]): Don't create a lock.
              (-[WebControllerPrivate dealloc]): Don't release a lock.
      
              * WebKit.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	* English.lproj/InfoPlist.strings: In here too.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
      
      WebBrowser:
      
              Reviewed by Maciej.
      
      	- pass properly-formatted application name string to WebKit so it can make a good user-agent
      
              * BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]):
      	Instead of passing "Mr. Poopypants", pass Sherlock, augmented with version strings,
      	to setApplicationNameForUserAgent:. Later we will pass Safari instead.
      
              * WebBrowser.pbproj/project.pbxproj: Bump version to 35u (we won't use " unofficial" any more).
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      030cad4c
  8. 08 Dec, 2002 1 commit
    • darin's avatar
      WebFoundation: · 70b6438f
      darin authored
              Reviewed by Don and Dave.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebFoundation.pbproj/project.pbxproj: Let Electron be Electron.
      
      WebCore:
      
              Reviewed by Don and Dave.
      
      	- fixed 3115845 -- bad-pointer crash destroying DOM tree reproducible at a particular site
      
      	All hail libgmalloc, without which this would just be another bug I can't reproduce!
      
      	This memory trasher bug was caused bug calling setChildrenLoaded after casting a node to
      	HTMLObjectElementImpl, when the node wasn't always an object element. It turns out that this
              fix was made obsolete a while back when I changed close on renderers to be delivered even for
              cases where the renderer is not created yet at close time.
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag): Remove the special case for
      	</object>. Now that this is fixed another way we don't need this at all.
      
              * khtml/html/html_objectimpl.h: Remove setChildrenLoaded and m_childrenLoaded.
              * khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl):
      	Remove code that sets m_childrenLoaded to false.
              (HTMLObjectElementImpl::attach): Remove code that looks at m_childrenLoaded, since we don't
      	need it any more (and in fact there's no way to set it any more).
      
      	- fixed 3120578 -- REGRESSION: going to about:blank creates null view
      
      	If no tokens are ever sent to the parser, then we end up without a render tree.
      
              * khtml/html/htmlparser.h: Add finished() function.
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Make an HTML element if the document is still
      	empty at this point. This is identical to what KHTMLParser::insertNode does when you insert any kind
      	of element other than an HTML element.
      
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::end): Call finished() to let the parser know.
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Turn on the "paint red" feature in development builds.
      	Null view problems are particularly hard to debug without something like this, and we don't care
      	if development builds are ever-so-slightly slower. No change in deployment.
      
      	- fixed 3121527 -- crash in WebCoreBridge frameBorderStyle
      
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]): Handle case where this is called and
      	we don't have a KHTMLView yet.
      
      	- other changes
      
              * WebCore.pbproj/project.pbxproj: Electron is doing his thing.
      
      WebKit:
      
              Reviewed by Don and Dave.
      
      	- fixed 3120578 -- REGRESSION: going to about:blank creates null view
      
      	This part of the fix makes sure that a renderer is created, even when there are no bytes
      	of data passed through. This makes the empty document about:blank case work just like the
      	"document with just whitespace in it case". There's another part of the fix in WebCore that
      	takes care of the remaining problem.
      
              * WebView.subproj/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
      	Call receivedData:withDataSource: on the bridge with nil for the data. It would be even more
      	elegant to add a new call for the case where we finish, but it's not necessary, since the
      	existing receivedData: call does all the right things if passed nil.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _finishedLoading]):
      	Call finishedLoadingWithDataSource: here, to make sure it's done after committing.
      	This parallels what we already do for the didReceiveData call.
              * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]):
      	Remove the call to finishedLoadingWithDataSource: because it's handled by _finishedLoading now.
      	This parallels what we already do for the didReceiveData call.
      
      	- fixed long standing problem where resizing could make you see a "null view"
      
              * WebView.subproj/WebView.m:
              (-[WebView drawRect:]): Add a "paint cyan" feature in development builds.
      	Null view problems are particularly hard to debug without something like this,
      	and we don't care if development builds are slightly slower. No change in deployment.
              (-[WebView setFrameSize:]): Tell the scroll view to draw the background if we are
      	resized. We can't do our "let the old bits show through" thing any more if we have to
      	redraw because of resizing.
      
      	- other changes
      
              * WebKit.pbproj/project.pbxproj: Remove the old -DAPPLE_CHANGES and -DHAVE_CONFIG_H that we
              once needed when WebKit used to compile  C++ headers from the KHTML part of WebCore.
              We haven't needed those for ages. Also sort things a bit, using the new Electron feature for
      	sorting lists of files alphabetically, and some by hand.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      WebBrowser:
      
      	Reviewed by Don and Dave.
      
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b6438f
  9. 06 Dec, 2002 1 commit
    • mjs's avatar
      JavaScriptCore: · 7c2d8083
      mjs authored
              Reviewed by: Darin Adler
      
      	- made framework embedding work correctly with buildit
      
              * JavaScriptCore.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing.
      
      WebFoundation:
      
              Reviewed by: Darin Adler
      
      	- made framework embedding work correctly with buildit
      
              * WebFoundation.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing.
      
      WebCore:
      
              Reviewed by: Darin Adler
      
      	- made framework embedding work correctly with buildit
      
              * WebCore.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing. Also
      	look for other frameworks in
      	${DSTROOT}/AppleInternal/Library/Frameworks.
      
      WebKit:
      
              Reviewed by: Darin Adler
      
      	- made framework embedding work correctly with buildit
      
              * WebKit.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing. Also
      	look for other frameworks in
      	${DSTROOT}/AppleInternal/Library/Frameworks.
      
      WebBrowser:
      
              Reviewed by: Darin Adler
      
      	- made framework embedding work correctly with buildit
      
              * copy-frameworks-to-dstroot.sh: Copy frameworks from
      	/AppleInternal/Library/Frameworks
              * embed-frameworks.sh: Fixed typo.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2d8083
  10. 04 Dec, 2002 2 commits
    • cblu's avatar
      WebKit: · bb4427b9
      cblu authored
      	Fixed: 3116294 - Need "Reload" feature in Downloads window
      
              Reviewed by: rjw
      
              * WebKit.pbproj/project.pbxproj: made WebFramePrivate.h private so that WebBrowser can call _downloadRequest:toPath:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadDataSource:withLoadType:]): commented out assert that complains about lack of WebView. Long-term solution is to catch this earlier and have a lone datasource download mechanism 3118355.
      
      WebBrowser:
      
      	Fixed: 3116294 - Need "Reload" feature in Downloads window
      
      	Added new download button art.
      
              Reviewed by: sullivan & darin
      
              * DownloadMonitor.h:
              * DownloadMonitor.m:
              (-[DownloadMonitor init]): create new dictionary _reloadingDataSourceToEntry that store pointers of dataSources to entries so the download monitor knows which entry started the reload.
              (-[DownloadMonitor resource:didReceiveResponse:fromDataSource:]): check if this is a reload by checking _reloadingDataSourceToEntry
              (-[DownloadMonitor setEntry:forReloadingDataSource:]): new, called by the entry to set itself as a reloading downlaod
              * DownloadProgressEntry.h:
              * DownloadProgressEntry.m:
              (-[DownloadProgressEntry _setController:]): new, for when a controller is created for reload
              (-[DownloadProgressEntry _setDataSource:]): tweak
              (-[DownloadProgressEntry _setRequest:]): new, need to retain the request so it can be used for reload
              (-[DownloadProgressEntry _setStartDate:]): new, allows to set the date more then just once
              (-[DownloadProgressEntry dealloc]): release the request and controller
              (-[DownloadProgressEntry reload]): make a controller, set it up, start download, reset the entry
              (-[DownloadProgressEntry setDone:]): release the controller because it won't be needed
              * DownloadRow.h:
              * DownloadRow.m:
              (-[DownloadRow _repositionSubviews]): new, moves widgets around
              (-[DownloadRow _setButtonAttributes]): new, sets attributes of the button
              (-[DownloadRow _startProgressAnimation]): simplified, just deal with progress bar
              (-[DownloadRow _startDiskCopyAnimation]): simplified, just deal with progress bar
              (-[DownloadRow _stopProgressAnimation]): simplified, just deal with progress bar
              (-[DownloadRow _updateStage]): call _repositionSubviews and _setButtonAttributes
              (-[DownloadRow awakeFromNib]): save the origins of the widgets
              (-[DownloadRow reload:]): call [entry reload]
              * English.lproj/Localizable.strings:
              * ResourceProgressEntry.m:
              (-[ResourceProgressEntry setBytesLoaded:]): remove error, added comment
              * Resources/Images/Download_Reload.tif: Added.
              * Resources/Images/Download_ReloadPressed.tif: Added.
              * Resources/Images/Download_Reveal.tif:
              * Resources/Images/Download_RevealPressed.tif:
              * Resources/Images/Download_Stop.tif:
              * Resources/Images/Download_StopPressed.tif:
              * WebBrowser.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb4427b9
    • darin's avatar
      WebCore: · 6f5b5073
      darin authored
              Reviewed by Trey and Maciej.
      
      	- fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
      	- got rid of the per-part NSEvent in preparation for NSView mouse event handling going through WebCore
      
              * khtml/khtml_part.h: Added declaration for didOpenURL.
              * khtml/khtml_part.cpp: (KHTMLPart::openURL): Changed name to didOpenURL in the APPLE_CHANGES
      	version because calls to openURL from within KHTML need to make the round trip to WebKit.
      	Also disabled the "scroll to anchor" part.
      
              * kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::isFrameSet): Fix to return false when document is 0.
      
              * kwq/KWQKHTMLPart.h: Add scrollToAnchor, remove setCurrentEvent and _currentEvent
              * kwq/KWQKHTMLPart.mm:
              (KHTMLPart::openURL): Pass the openURL call to the KWQKHTMLPart.
              (KWQKHTMLPart::KWQKHTMLPart): Don't initialize _currentEvent.
              (KWQKHTMLPart::~KWQKHTMLPart): Don't release _currentEvent.
              (KWQKHTMLPart::submitForm): Pass [NSApp currentEvent] instead of _currentEvent.
              (KWQKHTMLPart::urlSelected): Pass [NSApp currentEvent] instead of _currentEvent.
              (KWQKHTMLPart::scrollToAnchor): Added. Contains the code from the anchor case inside
      	KHTMLPart::openURL.
      
              * kwq/WebCoreBridge.h: Added scrollToAnchorWithURL:.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:reload:headers:lastModified:pageCache:]): Change around so that we
      	don't do a bunch of irrelevant stuff in the page cache case. I think we might just want to
      	make a separate method for the page cache case.
              (-[WebCoreBridge scrollToAnchorWithURL:]): Added.
              (-[WebCoreBridge mouseUp:]): Simplify check for nil view. Remove calls to setCurrentEvent.
              (-[WebCoreBridge mouseDown:]): Simplify check for nil view. Fix event type constants for
      	right mouse button and other mouse button.
              (-[WebCoreBridge mouseMoved:]): Simplify check for nil view.
              (-[WebCoreBridge mouseDragged:]): Simplify check for nil view.
      
      WebKit:
      
              Reviewed by Trey and Maciej.
      
      	- fixed 3117558 -- Assertion failure in KWQKHTMLPart::slotData after typing "amazon.com" twice
      	- update NSEvent handling in preparation for NSView mouse event handling going through WebCore
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadItem:fromItem:withLoadType:]): Added FIXME comments about matching the _loadURL
      	case more closely.
              (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Only use the event if it's
      	a mouse down event. This prevents trouble when we have other kinds of events coming through.
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]): Call the new scrollToAnchorWithURL:
      	instead of openURL:. This fixes the assertion failure in the bug above.
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Update checks here to more closely
      	match the ones in KHTMLPart::openURL that we are replacing. Add more comments.
      
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): Function to intercept all clicks at the
      	WebHTMLView level, disabled for now because we are not yet ready.
      
      	- started a gzip download decoder, not yet hooked up
      
              * Downloads.subproj/WebGZipDecoder.h: Added.
              * Downloads.subproj/WebGZipDecoder.m: Added.
              * WebKit.pbproj/project.pbxproj: Add WebGZipDecoder and zlib.
      
      	- other changes
      
              * Panels.subproj/WebAuthenticationPanel.m: Fixed screwed-up indentation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f5b5073
  11. 22 Nov, 2002 1 commit
  12. 20 Nov, 2002 1 commit
    • cblu's avatar
      Fixed: 3079134 - Throttle plug-ins while in background · a9f64e93
      cblu authored
              * Plugins.subproj/WebBaseNetscapePluginView.h:
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView sendNullEvent]): new
              (-[WebBaseNetscapePluginView stopNullEvents]): stops timer
              (-[WebBaseNetscapePluginView restartNullEvents]): stops timer if there is one, and starts a new one based on window activation state
              (-[WebBaseNetscapePluginView start]): call restartNullEvents
              (-[WebBaseNetscapePluginView stop]): call stopNullEvents
              (-[WebBaseNetscapePluginView windowBecameKey:]): call restartNullEvents
              (-[WebBaseNetscapePluginView windowResignedKey:]): call restartNullEvents
              (-[WebBaseNetscapePluginView windowDidMiniaturize:]): call stopNullEvents
              (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): call restartNullEvents
              * Plugins.subproj/WebNetscapePluginNullEventSender.h: Removed. No need for another class, use a timer.
              * Plugins.subproj/WebNetscapePluginNullEventSender.m: Removed. No need for another class, use a timer.
              * WebKit.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9f64e93
  13. 18 Nov, 2002 1 commit
    • kocienda's avatar
      WebKit: · 357eb7e0
      kocienda authored
      	Added feature to import bookmarks/favorites from MSIE. This
      	fixes Radar 2961230 (import Mac IE bookmarks).
      
              * Bookmarks.subproj/WebBookmarkImporter.h: Added.
              * Bookmarks.subproj/WebBookmarkImporter.m: Added.
              (_breakStringIntoLines):
              (_HREFRangeFromSpec):
              (_HREFTextFromSpec):
              (_linkTextRangeFromSpec):
              (_linkTextFromSpec):
              (-[WebBookmarkImporter initWithPath:group:]):
              (-[WebBookmarkImporter topBookmark]):
              (-[WebBookmarkImporter error]):
              (-[WebBookmarkImporter dealloc]):
              * Bookmarks.subproj/WebBookmarkList.m:
              (-[WebBookmarkList init]): Create the bookmark list object. This
      	was not created with the -init initializer, causing bookmark lists
      	to fail.
              * English.lproj/Localizable.strings:
              * English.lproj/StringsNotToBeLocalized.txt:
              * WebKit.exp:
              * WebKit.pbproj/project.pbxproj:
      
      WebBrowser:
      
      	Added calls in Debug menu to import IE Favorites.
      	No doubt that this code will move somewhere else once
      	we figure out the interaction design for importing
      	bookmarks.
      
              * Debug/DebugUtilities.m:
              (-[DebugUtilities createDebugMenu]):
              (-[BrowserDocument importInteretExplorerBookmarks:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      357eb7e0
  14. 15 Nov, 2002 1 commit
    • mjs's avatar
      WebKit: · 62074c91
      mjs authored
      	Make navigation policy asynchronous for real.
      
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebControllerPolicyDelegate.m:
              (-[WebPolicyDecisionListenerPrivate initWithTarget:action:]):
              (-[WebPolicyDecisionListenerPrivate dealloc]):
              (-[WebPolicyDecisionListener usePolicy:]):
              (-[WebPolicyDecisionListener _initWithTarget:action:]):
              (-[WebPolicyDecisionListener dealloc]):
              (-[WebPolicyDecisionListener _invalidate]):
              * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Added.
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame stopLoading]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFramePrivate dealloc]):
              (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
              (-[WebFrame _continueAfterNavigationPolicy:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
      
      WebBrowser:
      
      	Make navigation policy asynchronous.
      
              * BrowserWebController.m:
              (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62074c91
  15. 12 Nov, 2002 1 commit
    • mjs's avatar
      WebKit: · ee9af3e5
      mjs authored
      	Removed policy classes and instead use the policy enums directly,
      	since we no longer hold the path in the enum.
      
              * Downloads.subproj/WebDownloadHandler.m:
              * WebKit.exp:
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebControllerPolicyDelegate.m:
              * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
              * WebView.subproj/WebControllerPrivate.m:
              * WebView.subproj/WebDefaultPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]):
              (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
              (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
              (-[WebDefaultPolicyDelegate unableToImplementPolicy:error:forURL:inFrame:]):
              (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]):
              (-[WebFrame _shouldShowRequest:]):
              (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      WebBrowser:
      
      	Adjusted for WebKit API changes.
      
              * BrowserDocument.m:
              (-[BrowserDocument goToRequest:]):
              * BrowserWebController.m:
              (-[BrowserWebController URLPolicyForRequest:inFrame:]):
              (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]):
              (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]):
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]):
              (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee9af3e5
  16. 07 Nov, 2002 1 commit
    • cblu's avatar
      WebKit: · 7f0e2aaa
      cblu authored
              * WebKit.pbproj/project.pbxproj:
      
      WebBrowser:
      
      	Made Alexander responsible for opening downloads.
      
              * BrowserWebController.m:
              (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]): call +[WBPreferences shouldOpenFileWithMIMEType:]
              (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): no open policy
              * Defaults.plist:
              * DownloadProgressEntry.m:
              (-[DownloadProgressEntry isDiskCopyFile]):
              (-[DownloadProgressEntry startDiskCopyInteraction]):
              (-[DownloadProgressEntry openFile]):
              (-[DownloadProgressEntry setCompleted]):
              * Preferences.subproj/WBPreferences.h:
              * Preferences.subproj/WBPreferences.m:
              (+[WBPreferences shouldOpenFileWithMIMEType:]): moved this method here from BrowserWebController as this is now called in 2 different places
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f0e2aaa
  17. 06 Nov, 2002 2 commits
    • darin's avatar
      * Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]): · b5d54a91
      darin authored
      	Fix an off-by-one error handling repeat counts.
      
              * WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5d54a91
    • darin's avatar
      - added a BinHex decoder and did a little work on the MacBinary decoder · 3d3ff661
      darin authored
              I'm not supposed to be working on this, but I didn't feel like doing "real" work.
      
              * Downloads.subproj/WebBinHexDecoder.h: Added.
              * Downloads.subproj/WebBinHexDecoder.m: Added.
              * WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.
      
              * Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
              * Downloads.subproj/WebDownloadHandler.m:
              (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.
      
              * Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
              * Downloads.subproj/WebMacBinaryDecoder.m:
              (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field.
              (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III
      	part that gets the script code.
              (-[WebMacBinaryDecoder filename]): Use the script code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d3ff661
  18. 03 Nov, 2002 1 commit
    • cblu's avatar
      WebKit: · e335bc25
      cblu authored
      	- Added MacBinary decoding code. Not yet used.
      
              * Downloads.subproj/WebMacBinaryDecoder.h: Added.
              * Downloads.subproj/WebMacBinaryDecoder.m: Added.
              (+[WebMacBinaryDecoder canDecodeHeaderData:]):
              (-[WebMacBinaryDecoder init]):
              (-[WebMacBinaryDecoder dealloc]):
              (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]):
              (-[WebMacBinaryDecoder finishDecoding]):
              (-[WebMacBinaryDecoder fileAttributes]):
              * Downloads.subproj/crc16.h: Added.
              * Downloads.subproj/crc16.m: Added.
              (CRC16):
              * Plugins.subproj/WebPluginPackage.m:
              (-[WebPluginPackage isLoaded]):
              * WebKit.pbproj/project.pbxproj:
      
      WebBrowser:
      
      	- Added DiskCopy interaction code. Not yet used.
      	- Added Chuck's table view hacks to get NSViews in a TableView. Not yet used.
      
      
              * DiskCopyPuppetStrings.h: Added.
              * DownloadMonitor.h:
              * DownloadMonitor.m:
              (-[DownloadMonitor init]):
              (-[DownloadMonitor removeEntry:]):
              (-[DownloadMonitor _removeExpiredEntries]):
              (-[DownloadMonitor resource:didFinishLoadingFromDataSource:]):
              (-[DownloadMonitor resource:didFailLoadingWithError:fromDataSource:]):
              * ViewCell.h: Added.
              * ViewCell.m: Added.
              (RectCenteredInRect):
              (+[ViewCell needsToRemainInViewHierarchy]):
              (-[ViewCell init]):
              (-[ViewCell copyWithZone:]):
              (-[ViewCell dealloc]):
              (-[ViewCell instantiateView]):
              (-[ViewCell setObjectValue:]):
              (-[ViewCell objectValue]):
              (-[ViewCell removeViewFromSuperview]):
              (-[ViewCell setView:]):
              (-[ViewCell view]):
              (-[ViewCell setViewFrame:inCellFrame:inView:]):
              (-[ViewCell drawWithFrame:inView:]):
              (-[ViewCell trackMouse:inRect:ofView:]):
              (-[ViewCell editWithFrame:inView:editor:delegate:event:]):
              * ViewCellTableView.h: Added.
              * ViewCellTableView.m: Added.
              (+[ViewCellTableColumn newViewCell]):
              (-[ViewCellTableColumn initWithIdentifier:]):
              (-[ViewCellTableColumn initWithCoder:]):
              (-[ViewCellTableColumn dealloc]):
              (-[ViewCellTableColumn cells]):
              (-[ViewCellTableColumn dataCellForRow:]):
              (-[ViewCellTableColumn removeRows:]):
              (-[ViewCellTableColumn appendRows:]):
              (-[ViewCellTableColumn noteNumberOfTableRowsChanged:]):
              (-[ViewCellTableColumn willRemoveFromTableView:]):
              (-[NSTableColumn noteNumberOfTableRowsChanged:]):
              (-[NSTableColumn willRemoveFromTableView:]):
              (-[ViewCellTableView replaceHeaderView]):
              (-[ViewCellTableView workaroundReorderResizeProblem]):
              (-[ViewCellTableView didReorderOrResizeNotification:]):
              (-[ViewCellTableView initWithFrame:]):
              (-[ViewCellTableView initWithCoder:]):
              (-[ViewCellTableView dealloc]):
              (-[ViewCellTableView noteNumberOfRowsChanged]):
              (-[ViewCellTableView reloadData]):
              (-[ViewCellTableView removeTableColumn:]):
              (-[ViewCellTableView acceptsFirstResponder]):
              (-[ViewCellTableView needsPanelToBecomeKey]):
              * WebBrowser.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e335bc25
  19. 01 Nov, 2002 1 commit
    • cblu's avatar
      WebFoundation: · fb4f8550
      cblu authored
              * Misc.subproj/WebError.m:
      
      WebKit:
      
      	- Moved plug-in error handling to WebResourceLoadDelegate
      	- Report plug-in load failure, java load failure, and plug-in not found errors.
      	- Added WebPluginError, subclass of WebError.
      	- Attempted fix: 3090675 - Standalone WMP (Window Media Player) content crashes Alexander
      
              * English.lproj/Localizable.strings:
              * Misc.subproj/WebKitErrors.h:
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView sendEvent:]): don't send event to null function
              * Plugins.subproj/WebNetscapePluginDocumentView.m:
              (-[WebNetscapePluginDocumentView setDataSource:]): report plug-in load failure
              * Plugins.subproj/WebNullPluginView.h:
              * Plugins.subproj/WebNullPluginView.m: take a WebPluginError
              (-[WebNullPluginView dealloc]):
              (-[WebNullPluginView viewDidMoveToWindow]):
              * Plugins.subproj/WebPluginError.h: Added.
              * Plugins.subproj/WebPluginError.m: Added.
              (-[WebPluginErrorPrivate dealloc]):
              (-[WebPluginError dealloc]):
              (-[WebPluginError pluginPageURL]):
              (-[WebPluginError pluginName]):
              (-[WebPluginError MIMEType]):
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): report plug-in load failure
              (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): report plug-in load failure
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebController.m:
              (-[WebResourceLoadDelegate pluginFailedWithError:dataSource:]): added, does nothing
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebResourceLoadDelegate.h:
              * WebView.subproj/WebView.m:
              (+[WebView initialize]): added new error strings
      
      WebBrowser:
      
      	- Moved plug-in error handling to WebResourceLoadDelegate
      
              * BrowserWebController.m:
              * English.lproj/Localizable.strings:
              * LoadProgressMonitor.m:
              (-[LoadProgressMonitor pluginNotFoundSheetEnded:returnCode:contextInfo:]):
              (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): display special sheets for new errors.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb4f8550
  20. 30 Oct, 2002 1 commit
    • rjw's avatar
      More work on bidi and contextual forms. · 412938f8
      rjw authored
              Table lookup code for unicode characters attributes.
      
              * Misc.subproj/WebUnicode.h: Added.
              * Misc.subproj/WebUnicode.m: Added.
              (_unicodeDigitValue):
              (_unicodeCategory):
              (_unicodeDirection):
              (_unicodeJoining):
              (_unicodeDecompositionTag):
              (_unicodeMirrored):
              (_unicodeMirroredChar):
              (_unicodeCombiningClass):
              (_unicodeLower):
              (_unicodeUpper):
              (WebKitInitializeUnicode):
              * Misc.subproj/WebUnicodeTables.m: Added.
              * WebKit.pbproj/project.pbxproj:
      
              Additional logging parameter.
      
              * Misc.subproj/WebKitLogging.h:
              * Misc.subproj/WebKitLogging.m:
      
              More work on bidi and contextual forms.
              Table lookup code is up in WebKit. Function
              pointers are used to isolate WebCore from private
              implementation in WebKit.  Needs to be fast, so
              the usual ObjC abstraction won't work.
      
              * WebCore.exp:
              * WebCore.pbproj/project.pbxproj:
              * kwq/KWQChar.mm:
              (QChar::direction):
              * kwq/KWQString.h:
              * kwq/WebCoreUnicode.cpp: Added.
              * kwq/WebCoreUnicode.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      412938f8
  21. 29 Oct, 2002 1 commit
    • cblu's avatar
      Created Downloads.subproj to hold the to-be-implemented download decoders. · 0ec738de
      cblu authored
              * Downloads.subproj/WebDownloadDecoder.h: Added.
              * Downloads.subproj/WebDownloadHandler.h: Added.
              * Downloads.subproj/WebDownloadHandler.m: Added.
              (-[WebDownloadHandler initWithDataSource:]):
              (-[WebDownloadHandler dealloc]):
              (-[WebDownloadHandler errorWithCode:]):
              (-[WebDownloadHandler receivedResponse:]):
              (-[WebDownloadHandler receivedData:]):
              (-[WebDownloadHandler finishedLoading]):
              (-[WebDownloadHandler cancel]):
              * Misc.subproj/WebDownloadHandler.h: Removed.
              * Misc.subproj/WebDownloadHandler.m: Removed.
              * WebKit.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ec738de
  22. 25 Oct, 2002 1 commit
    • trey's avatar
      WebKit: · 3629d5a8
      trey authored
      	2919039 - Implement limit on back/forward history list
      	2998200 - access to most-recent in submenu of back & forward buttons
      	3022566 - need WebKit API for accessing and visiting back/forward list items
      	3084051 - forward button incorrectly enabled after going forward all the way
      
      	Remaining issues at this point are getting the title of the pages
      	into the menu items (instead of the URL), and saving document
      	state properly when you jump around in the list.  Solutions are
      	known and coming soon.
      
              * History.subproj/WebBackForwardList.h:
      	Added doc comments to API.  Made ivars private.  Replaced index-
      	based API with item-based API.  Added a sizelimit to the overall
      	list.  Tweaked API to get back and forward lists.
              * History.subproj/WebBackForwardList.m:
      	Straightforward impl of the above, with the note that I dumped
      	WebHistoryList from the API and impl in favor of an NSArray,
      	which is efficient for this sort of use (queue, stack).
              (-[WebBackForwardList init]):
              (-[WebBackForwardList dealloc]):
              (-[WebBackForwardList goBack]):
              (-[WebBackForwardList goForward]):
              (-[WebBackForwardList goToEntry:]):
              (-[WebBackForwardList backEntry]):
              (-[WebBackForwardList forwardEntry]):
              (-[WebBackForwardList maximumSize]):
              (-[WebBackForwardList setMaximumSize:]):
              (-[WebBackForwardList description]):
              * History.subproj/WebHistoryList.h: Removed.
      	Nuked from API, per above.
              * History.subproj/WebHistoryList.m: Removed.
              * Misc.subproj/WebKit.h:
      	WebHistoryList gone from API.
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge loadURL:]):
      	Use if/else instead of buried "return;", so next person doesn;t
      	make the same mis-read I did.
              (-[WebBridge saveDocumentState:]):
      	Site of future work.
              * WebKit.pbproj/project.pbxproj:
      	Nuked WebHistoryList.
              * WebView.subproj/WebController.h:
              * WebView.subproj/WebController.m:
              (-[WebController goBackOrForwardToItem:]):
      	New method to support random access nav in backforward list.
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _setTitle:]):
      	Site of future work (fixing title in items)
              * WebView.subproj/WebFramePrivate.h:
      	WebFrameLoadTypeIndexedBack/WebFrameLoadTypeIndexedForward are
      	collapsed into WebFrameLoadTypeIndexedBackForward.  Vestigial
      	WebFrameLoadTypeIntermediateBack is nuked.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFramePrivate setBackForwardItem:]):
              (-[WebFrame _setBackForwardItem:]):
              (-[WebFrame _backForwardItem]):
      	Must remember the BF item we're going to so we can update the
      	BF list on commit.
              (-[WebFrame _transitionToCommitted]):
      	Update the BF list on commit.
              (-[WebFrame _isLoadComplete]):
              (-[WebFrame _goToItem:withFrameLoadType:]):
      	Update BF list on within-page nav.
      	Remember BF item we are going to for later update on commit.
      
      WebBrowser:
      
      	2919039 - Implement limit on back/forward history list
      	2998200 - access to most-recent in submenu of back & forward buttons
      	3084051 - forward button incorrectly enabled after going forward all the way
      
      	Remaining issues at this point are getting the title of the pages
      	into the menu items (instead of the URL), and saving document
      	state properly when you jump around in the list.  Solutions are
      	known and coming soon.
      
              * BrowserDocument.h:
      	Add BrowserDocumentClientNavigatedWithinPageNotification.
              * BrowserDocument.m:
              (-[BrowserDocument init]):
      	Set up BackForwardListSizeLimit preference.
              (-[BrowserDocument canGoBack]):
              (-[BrowserDocument canGoForward]):
              (-[BrowserDocument goBack:]):
              (-[BrowserDocument goForward:]):
      	Nits adopting new API.
              (-[BrowserDocument goToItem:]):
              (-[BrowserDocument _addItem:toMenu:]):
              (-[BrowserDocument backListMenuForButton:]):
              (-[BrowserDocument forwardListMenuForButton:]):
      	Code to build BF menus, and respond to clicks.
              * BrowserWindowController.m:
              (-[BrowserWindowController windowDidLoad]):
              (-[BrowserWindowController frameLoadWithinPage:]):
      	Register for and handle BrowserDocumentClientNavigatedWithinPageNotification.
      	Must update title bar widgets at this point.
              * Defaults.plist:
      	New defaults: BackForwardListSizeLimit, BackForwardMenuSizeLimit
              * LocationChangeHandler.m:
              (-[LocationChangeHandler locationChangedWithinPageForDataSource:]):
      	Post BrowserDocumentClientNavigatedWithinPageNotification.
              * PreferenceKeys.h:
      	New default keys.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3629d5a8
  23. 23 Oct, 2002 2 commits
    • cblu's avatar
      Forgot to add WebPluginController back to the project after I had a project conflict. · 62b33417
      cblu authored
              * WebKit.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b33417
    • darin's avatar
      WebCore: · cd4186d5
      darin authored
      	- fixed 3080478 -- reproducible incomplete load on apple.com
      
              * kwq/KWQLoaderImpl.mm:
              (-[WebCoreResourceLoader receivedResponse:]): Add an assert.
              (-[WebCoreResourceLoader cancel]): Don't finish here, just disconnect the handle
      	from the job, and disconnect the job from the WebCoreResourceLoader, and let the
      	KHTML code finish the cleanup later. This is the bug fix.
              (KWQCheckCacheObjectStatus): Add an assertion.
      
              * kwq/KWQKjobclasses.mm:
      	(TransferJob::~TransferJob): Don't call kill(); do the work here instead.
      	(TransferJob::kill): Self-destruct. Need this to avoid a storage leak.
      
              * khtml/misc/loader.cpp:
              (CachedObject::~CachedObject): Put some Apple-specific code inside APPLE_CHANGES.
              (CachedObject::setResponse): Streamlined this function.
              (Loader::receivedResponse): Added assertions.
      
              * kwq/qt/qxml.h: Add more stubs.
              * kwq/KWQxml.mm: Ditto.
      
              * kwq/WebCoreViewFactory.h: Add [WebCoreViewFactory fileButton], the
      	WebCoreFileButton protocol, and WebCoreFileButtonFilenameChanged.
              * kwq/WebCoreViewFactory.m: Add WebCoreFileButtonFilenameChanged.
              * WebCore.exp: Export _WebCoreFileButtonFilenameChanged.
      
      WebKit:
      
      	Add WebFileButton, to be used by WebCore soon. It's about 1/2
      	done right now. Compiles but not used yet.
      
              * WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): Added.
      
              * WebCoreSupport.subproj/WebFileButton.h: Added.
              * WebCoreSupport.subproj/WebFileButton.m: Added.
              * WebKit.pbproj/project.pbxproj: Added WebFileButton files.
      
              * WebCoreSupport.subproj/WebSubresourceClient.m:
              (-[WebSubresourceClient handle:didReceiveResponse:]): Add an assertion.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd4186d5