1. 17 Apr, 2012 40 commits
    • fpizlo@apple.com's avatar
      Attempt to fix Windows build. · 37d5bc71
      fpizlo@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37d5bc71
    • rafaelw@chromium.org's avatar
      [MutationObservers] enable V8RecursionScope debug ASSERT() · ac8e2480
      rafaelw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84094
      
      Reviewed by Ojan Vafai.
      
      This patch enables the ASSERT() which enforces usage of
      V8RecursionScope.
      
      * src/WebKit.cpp:
      (WebKit::assertV8RecursionScope):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac8e2480
    • fpizlo@apple.com's avatar
      It should be possible to create an inheritorID for the global this object without crashing · 825f980b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84200
      <rdar://problem/11251082>
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      * runtime/JSGlobalThis.cpp:
      (JSC::JSGlobalThis::setUnwrappedObject):
      * runtime/JSGlobalThis.h:
      (JSC::JSGlobalThis::unwrappedObject):
      (JSGlobalThis):
      * runtime/JSObject.cpp:
      (JSC::JSObject::createInheritorID):
      * runtime/JSObject.h:
      (JSObject):
      (JSC::JSObject::resetInheritorID):
      
      Source/WebCore: 
      
      No new tests, because the circumstances necessary to make this happen are rather hairy.
      
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::window):
      (WebCore::JSDOMWindowShell::setWindow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      825f980b
    • macpherson@chromium.org's avatar
      Make CSSParser::parseValue()'s handling of CSSPropertyCursor more obviously correct. · 93c71bf1
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83544
      
      Reviewed by Kentaro Hara.
      
      No new tests / code cleanup only.
      
      The code as it stands appears to be correct, but static analysis was concerned that value could become null.
      This patch adds a null check and ASSERT_NOT_REACHED() to make the code more obviously correct.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93c71bf1
    • danakj@chromium.org's avatar
      [chromium] Fix gyp for WebFilterOperation.h and WebFilterOperations.h · 318fad7d
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84182
      
      Reviewed by James Robinson.
      
      Source/Platform:
      
      * Platform.gypi:
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      318fad7d
    • andersca@apple.com's avatar
      Source/WebKit2: Need a client callback for when the user tires to interact... · 6d741a97
      andersca@apple.com authored
      Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
      https://bugs.webkit.org/show_bug.cgi?id=84201
      <rdar://problem/11140862>
      
      Reviewed by Andreas Kling.
      
      Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
      fires while it's already unresponsive.
      
      * UIProcess/API/C/WKPage.h:
      * UIProcess/ResponsivenessTimer.cpp:
      (WebKit):
      (WebKit::ResponsivenessTimer::timerFired):
      (WebKit::ResponsivenessTimer::start):
      * UIProcess/ResponsivenessTimer.h:
      (Client):
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::processDidBecomeUnresponsive):
      (WebKit):
      (WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
      * UIProcess/WebLoaderClient.h:
      (WebLoaderClient):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
      (WebKit):
      * UIProcess/WebPageProxy.h:
      (WebPageProxy):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
      (WebKit):
      * UIProcess/WebProcessProxy.h:
      (WebProcessProxy):
      
      Tools: Need a client callback for when the user tries to interact with an already unresponsive page
      https://bugs.webkit.org/show_bug.cgi?id=84201
      <rdar://problem/11140862>
      
      Reviewed by Andreas Kling.
      
      Add new client functions.
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d741a97
    • commit-queue@webkit.org's avatar
      [Chromium] Add TextureUploader which allows us to use persistent GC3D state for texture uploads. · ce314b09
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83972
      
      Patch by David Reveman <reveman@chromium.org> on 2012-04-17
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Add TextureUploader class that allows us to add persistent GC3D state to the upload machinery.
      
      * WebCore.gypi:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::initializeSharedObjects):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::textureUploader):
      (LayerRendererChromium):
      * platform/graphics/chromium/TextureUploader.cpp: Added.
      (WebCore):
      (WebCore::AcceleratedTextureUploader::AcceleratedTextureUploader):
      (WebCore::AcceleratedTextureUploader::~AcceleratedTextureUploader):
      (WebCore::AcceleratedTextureUploader::uploadTexture):
      * platform/graphics/chromium/TextureUploader.h: Added.
      (WebCore):
      (TextureUploader):
      (WebCore::TextureUploader::~TextureUploader):
      (AcceleratedTextureUploader):
      (WebCore::AcceleratedTextureUploader::create):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      (WebCore::CCSingleThreadProxy::doCommit):
      * platform/graphics/chromium/cc/CCTextureUpdater.cpp:
      (WebCore::CCTextureUpdater::update):
      * platform/graphics/chromium/cc/CCTextureUpdater.h:
      (WebCore):
      (CCTextureUpdater):
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
      
      Source/WebKit/chromium:
      
      * tests/CCTiledLayerTestCommon.h:
      (FakeTextureUploader):
      (WebKitTests::FakeTextureUploader::uploadTexture):
      (WebKitTests):
      * tests/Canvas2DLayerChromiumTest.cpp:
      * tests/TiledLayerChromiumTest.cpp:
      (WTF::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce314b09
    • scheib@chromium.org's avatar
      [Chromium] Mark test failing IMAGE: svg/transforms/transform-origin-css-property.xhtml · 173502fa
      scheib@chromium.org authored
      Unreviewed.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      173502fa
    • macpherson@chromium.org's avatar
      Clean up CSSParser::parseFillRepeat(). · 6ceacb7e
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83547
      
      Reviewed by Kentaro Hara.
      
      Removed multiple unnecessary calls to m_valueList->current().
      Restructured logic for parsing second value to make it clearer.
      
      No new tests / code cleanup only.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFillRepeat):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ceacb7e
    • dpranke@chromium.org's avatar
      nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port · 76bd9a7e
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84190
      
      Reviewed by Ojan Vafai.
      
      LayoutTestHelper would exit when the user typed ctrl-c, but we
      would attempt to write to it to shut it down, generating an
      IOError.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      (ChromiumPort.stop_helper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76bd9a7e
    • dpranke@chromium.org's avatar
      rename --experimental-fully-parallel · 2b496844
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84188
      
      Reviewed by Ojan Vafai.
      
      I thought this was done long ago; rename
      --experimental-fully-parallel to just --fully-parallel and
      remove the --no- switch that AFAIK no one uses.
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager._run_tests):
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      (parse_args):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b496844
    • haraken@chromium.org's avatar
      [V8] Pass Isolate to toV8Slow() · 0f9a6c1e
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84173
      
      Reviewed by Nate Chapin.
      
      The final objective is to pass Isolate around in V8 bindings.
      This patch passes the Isolate to toV8Slow().
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeader):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::toV8Slow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f9a6c1e
    • jchaffraix@webkit.org's avatar
      Fix the ACCELERATED_COMPOSITING code to not expose RenderLayer outside rendering · 363c3871
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83816
      
      Reviewed by James Robinson.
      
      No change in behavior expected.
      
      This code adds several functions on RenderBoxModelObject to forward
      to the associated layer. This removes the RenderLayer dependencies
      at the call sites.
      
      Currently only RenderBoxModelObject can be hardware accelerated as
      we need a RenderLayer, this looks like the best place to put those
      new functions.
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::contentChanged):
      (WebCore::RenderBoxModelObject::hasAcceleratedCompositing):
      (WebCore::RenderBoxModelObject::startTransition):
      (WebCore::RenderBoxModelObject::transitionPaused):
      (WebCore::RenderBoxModelObject::transitionFinished):
      (WebCore::RenderBoxModelObject::startAnimation):
      (WebCore::RenderBoxModelObject::animationPaused):
      (WebCore::RenderBoxModelObject::animationFinished):
      (WebCore::RenderBoxModelObject::suspendAnimations):
      * rendering/RenderBoxModelObject.h:
      Added the previous functions to hide the layer need.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::hasAcceleratedCompositing):
      * rendering/RenderLayer.h:
      Removed the previous method as it was superseeded by the
      one on RenderBoxModelObject. Also moved the ContentChangeType
      enumaration.
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::contentChanged):
      * rendering/RenderLayerBacking.h:
      (RenderLayerBacking):
      Updated after the ContentChangeType enumaration move.
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      (WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::didDraw):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::markContextChanged):
      (WebCore::WebGLRenderingContext::reshape):
      * page/animation/AnimationBase.cpp:
      (WebCore::AnimationBase::freezeAtTime):
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::startAnimation):
      (WebCore::ImplicitAnimation::pauseAnimation):
      (WebCore::ImplicitAnimation::endAnimation):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::startAnimation):
      (WebCore::KeyframeAnimation::pauseAnimation):
      (WebCore::KeyframeAnimation::endAnimation):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::imageChanged):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::imageDimensionsChanged):
      (WebCore::RenderImage::notifyFinished):
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::updatePlayer):
      Updated all those call sites to use the new functions. Also
      removed unneeded RenderLayer.h include as we went.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      363c3871
    • fpizlo@apple.com's avatar
      DFG and LLInt should not clobber the frame pointer on ARMv7 · 5fb79492
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84185
      <rdar://problem/10767252>
      
      Reviewed by Gavin Barraclough.
              
      Changed LLInt to use a different register. Changed DFG to use one fewer
      registers. We should revisit this and switch the DFG to use a different
      register instead of r7, but we can do that in a subsequent step since
      the performance effect is tiny.
      
      * dfg/DFGGPRInfo.h:
      (GPRInfo):
      (JSC::DFG::GPRInfo::toRegister):
      (JSC::DFG::GPRInfo::toIndex):
      * offlineasm/armv7.rb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fb79492
    • aestes@apple.com's avatar
      -webkit-mask-box-image does not draw when layer tree flattening is enabled · ef4083e3
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84111
      
      Reviewed by Simon Fraser.
      
      No new tests since taking pixel test results with
      PaintBehaviorFlattenCompositingLayers set is not currently supported.
      <https://bugs.webkit.org/show_bug.cgi?id=84110> tracks fixing this.
      
      When painting mask images, we should take the non-composited path if
      layers are being flattened.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::paintMask):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::paintMaskImages):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef4083e3
    • eae@chromium.org's avatar
      Rollout r114404 as it broke a couple of chromium builds. · b119059f
      eae@chromium.org authored
      * platform/FractionalLayoutUnit.h:
      (WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
      (WebCore::FractionalLayoutUnit::isInBounds):
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b119059f
    • benm@google.com's avatar
      `localStorage.setItem` can overwrite `localStorage` methods · 3868bff6
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30996
      
      Source/WebCore:
      
      Update the JSC and V8 bindings such that if the name of the DOM
      Storage property being retrieved is a match for a property in the
      prototype, always return the prototype version. If there is a DOM
      Storage key of the same name, it can still be retrieved via the
      getItem method. This prevents storage methods from being
      accidentally hidden. This brings WebKit behavior in line with the
      de facto standard implemented by FireFox and IE.
      
      Reviewed by Kentaro Hara.
      
      Test: storage/domstorage/storage-functions-not-overwritten.html
      
      * bindings/js/JSStorageCustom.cpp:
      (WebCore::JSStorage::nameGetter):
      * bindings/v8/custom/V8StorageCustom.cpp:
      (WebCore::V8Storage::namedPropertyGetter):
      
      LayoutTests:
      
      Add a test to verify that setting a DOM Storage key with the same name
      as a function on the Storage object does not prevent that function
      being called, but also that it can still be retrieved via the getItem
      function.
      
      Reviewed by Kentaro Hara.
      
      * storage/domstorage/script-tests/storage-functions-not-overwritten.js: Added.
      (doWedgeThySelf):
      (testStorage):
      (runTest):
      * storage/domstorage/storage-functions-not-overwritten-expected.txt: Added.
      * storage/domstorage/storage-functions-not-overwritten.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3868bff6
    • scheib@chromium.org's avatar
      [Chromium] Rebaseline minor text pixel differences in bidi-menulist-expected. · 63290f26
      scheib@chromium.org authored
      Unreviewed.
      
      * platform/chromium-mac-leopard/fast/text/international/bidi-menulist-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63290f26
    • eae@chromium.org's avatar
      Fix Chromium/Windows build broken by r114404. · f69dd723
      eae@chromium.org authored
      * platform/FractionalLayoutUnit.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f69dd723
    • schenney@chromium.org's avatar
      Reorganise Chromium test_expectations to group SVG expectations. · 5ca7d9b6
      schenney@chromium.org authored
      Unreviewed Chromium expectations change.
      
      This is done to make future maintenance easier.
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ca7d9b6
    • commit-queue@webkit.org's avatar
      EFL's LayoutTestController does not implement callShouldCloseOnWebView · a9c1869d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82301
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
      Reviewed by Martin Robinson.
      
      Source/WebKit/efl:
      
      Implement callShouldCloseOnWebView in EFL's LayoutTestController by
      calling shouldClose() on the FrameLoader, allowing the related
      test to be removed from the skip list.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Tools:
      
      Implement callShouldCloseOnWebView in EFL's LayoutTestController by
      calling shouldClose() on the FrameLoader, allowing the related test
      to be removed from the skip list.
      
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      (LayoutTestController::callShouldCloseOnWebView):
      
      LayoutTests:
      
      Implement callShouldCloseOnWebView in EFL's LayoutTestController by
      calling shouldClose() on the FrameLoader, allowing the related test
      to be removed from the skip list.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9c1869d
    • haraken@chromium.org's avatar
      [Performance][V8] Skip Isolate look-up to find StringCache · 97e4c242
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84103
      
      Reviewed by Nate Chapin.
      
      This patch improves the performance of a lot of DOM attribute
      getters that return a string.
      
      - Improves the performance of Dromaeo/dom-attr.html(element.property)
        by 27.7%.
      - Improves the performance of Dromaeo/dom-attr.html(getAttribute)
        by 10.6%.
      - Improves the performance of div.id, div.className,
        div.nodeName, text.nodeValue, text.textContent by 12% -- 21%.
      
      The followings are the test results in my Linux desktop.
      
      Performance test: Dromaeo/dom-attr.html
      Total:                     674.64runs/s ->  707.03runs/s (+ 4.8%)
      getAttribute:             1537.60runs/s -> 1700.20runs/s (+10.6%)
      element.property:         1389.00runs/s -> 1774.20runs/s (+27.7%)
      setAttribute:              538.88runs/s ->  548.87runs/s (+ 1.9%)
      element.property = value:  644.07runs/s ->  656.67runs/s (+ 2.0%)
      element.expando = value:   219.76runs/s ->  207.14runs/s (- 6.8%)
      element.expando:           578.77runs/s ->  554.67runs/s (- 4.2%)
      
      Performance test: https://bugs.webkit.org/attachment.cgi?id=137440
      div.id:           30.70ns -> 26.70ns (+15%)
      div.className:    31.10ns -> 26.40ns (+18%)
      div.nodeName:     37.70ns -> 33.00ns (+14%)
      text.nodeValue:   31.40ns -> 25.90ns (+21%)
      text.textContent: 51.50ns -> 45.90ns (+12%)
      
      Previously V8 bindings need to look up an Isolate to find
      an Isolate-local StringCache. This patch skips the look-up
      by getting the Isolate from AccessorInfo.GetIsolate()
      or Arguments.GetIsolate().
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateNormalAttrGetter):
      (GenerateFunctionCallString):
      (NativeToJSValue):
      * bindings/v8/V8Binding.cpp:
      (WebCore::getElementStringAttr):
      * bindings/v8/V8Binding.h:
      (WebCore::v8ExternalString): Make 'isolate' an optional argument.
      Ideally we want to make 'isolate' a non-optional argument,
      but it is difficult to rewrite all v8ExternalString() callers
      at a breath. We can rewrite them incrementally.
      (WebCore::v8String): Ditto.
      (WebCore::v8StringOrNull): Ditto.
      (WebCore::v8StringOrUndefined): Ditto.
      (WebCore::v8StringOrFalse): Ditto.
      
      * bindings/scripts/test/V8/V8TestEventConstructor.cpp: Updated run-bindings-tests results.
      (WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
      (WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
      (WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
      (WebCore::TestObjV8Internal::stringAttrAttrGetter):
      (WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
      (WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
      (WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
      (WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
      (WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
      (WebCore::TestObjV8Internal::hashAttrGetter):
      (WebCore::TestObjV8Internal::conditionalMethod1Callback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97e4c242
    • commit-queue@webkit.org's avatar
      [EFL] FrameLoaderClient should send "load,finished" signal for all frame, not just the main one · a2dd9ddf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84052
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      Source/WebKit/efl:
      
      Emit the "load,finished" signal from dispatchDidFinishLoad() / instead of
      postProgressFinishedNotification() in order to send notifications all frames,
      not just the main one.
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
      (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
      
      LayoutTests:
      
      Unskip EFL test cases which rely on the DumpRenderTree support for
      LayoutTestController's dumpFrameLoadCallbacks() and expect notifications for other
      frame than the main one.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2dd9ddf
    • commit-queue@webkit.org's avatar
      [EFL] Add setting API to enable/disable XSSAuditor · f0330aae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83281
      
      Source/WebKit/efl:
      
      Add setting API to enable or disable WebKit's XSSAuditor to protect
      from reflective cross-site scripting attacks. Also, emit the signal
      'xss,detected' and provide addition information received from
      XSSAuditor when reflected XSS is encountered in the page.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::didDetectXSS):
      * ewk/ewk_frame.cpp:
      (ewk_frame_xss_detected):
      * ewk/ewk_frame.h:
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (_ewk_view_priv_new):
      (ewk_view_setting_enable_xss_auditor_get):
      (ewk_view_setting_enable_xss_auditor_set):
      * ewk/ewk_view.h:
      
      Tools:
      
      Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
      in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
      'xss,detected' in DRT to enable a test, which is expecting a line containing
      'didDetectXSS' in the output when reflected XSS is encountered in the page.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::onFrameCreated):
      (DumpRenderTreeChrome::onDidDetectXSS):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      (LayoutTestController::setXSSAuditorEnabled):
      
      LayoutTests:
      
      Unskip tests in http/tests/security/xssAuditor
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0330aae
    • cfleizach@apple.com's avatar
      Crash in invalid index for _textMarkerForIndex · 1f22d13d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84104
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      Test: platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html
      
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
      
      LayoutTests:
      
      * platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt: Added.
      * platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f22d13d
    • jer.noble@apple.com's avatar
      HTML5 Video Full Screen button broken (looks like white square) · 644e6bdf
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84101
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      No new tests; updated platform results which were previously rebaselined.
      
      Use the correct CSS keyword for the -webkit-appearance of the full screen button.
      
      * css/mediaControls.css:
      (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
      
      LayoutTests:
      
      * platform/mac/media/controls-after-reload-expected.png:
      * platform/mac/media/controls-after-reload-expected.txt:
      * platform/mac/media/controls-strict-expected.png:
      * platform/mac/media/controls-strict-expected.txt:
      * platform/mac/media/video-controls-rendering-expected.png:
      * platform/mac/media/video-controls-rendering-expected.txt:
      * platform/mac/media/video-display-toggle-expected.png:
      * platform/mac/media/video-display-toggle-expected.txt:
      * platform/mac/media/video-no-audio-expected.png:
      * platform/mac/media/video-no-audio-expected.txt:
      * platform/mac/media/video-playing-and-pause-expected.png:
      * platform/mac/media/video-playing-and-pause-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      644e6bdf
    • schenney@chromium.org's avatar
      SVG should support transform-origin and relative values · dd763df5
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79068
      
      Unreviewed Chromium expectations update.
      
      * platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Added.
      * platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd763df5
    • schenney@chromium.org's avatar
      Paddings and borders on root SVG element with viewbox causes child SVG... · 64114eb8
      schenney@chromium.org authored
      Paddings and borders on root SVG element with viewbox causes child SVG elements to be rendered with the incorrect size
      https://bugs.webkit.org/show_bug.cgi?id=78613
      
      Unreviewed Chromium expectations update.
      
      * platform/chromium-linux/svg/custom/circle-move-invalidation-expected.png:
      * platform/chromium-mac-leopard/svg/custom/circle-move-invalidation-expected.png:
      * platform/chromium-mac-snowleopard/svg/custom/circle-move-invalidation-expected.png:
      * platform/chromium-mac/svg/custom/circle-move-invalidation-expected.png: Added.
      * platform/chromium-win/svg/custom/circle-move-invalidation-expected.png:
      * platform/chromium-win/svg/custom/circle-move-invalidation-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64114eb8
    • andersca@apple.com's avatar
      Make sure that the layer hosting mode is kept up to date if it changes before... · 6c88c9ed
      andersca@apple.com authored
      Make sure that the layer hosting mode is kept up to date if it changes before the plug-in is initialized
      https://bugs.webkit.org/show_bug.cgi?id=84180
      <rdar://problem/11265113>
      
      Reviewed by Andreas Kling.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::setLayerHostingMode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c88c9ed
    • schenney@chromium.org's avatar
      onclick is not reliable for transformed SVG elements · 48ed8c51
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34714
      
      Unreviewed Chromium expectations update.
      
      * platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
      * platform/chromium-mac-snowleopard/svg/text/select-textLength-spacing-squeeze-2-expected.png: Removed.
      * platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
      * platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
      * platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ed8c51
    • fpizlo@apple.com's avatar
      use after free in JSC::DFG::Node::op / JSC::DFG::ByteCodeParser::flushArgument · cb63e1e9
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83942
      <rdar://problem/11247370>
      
      Reviewed by Gavin Barraclough.
              
      Don't use references to the graph after resizing the graph.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::flushArgument):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb63e1e9
    • schenney@chromium.org's avatar
      getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values · 781370b9
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78631
      
      Unreviewed Chromium expectations update.
      
      * platform/chromium-linux/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
      * platform/chromium-mac-leopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png:
      * platform/chromium-mac/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
      * platform/chromium-win/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      781370b9
    • schenney@chromium.org's avatar
      [Chromium] Cleanup of outdated test expectations · c2ec97f5
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81253
      
      Unreviewed Chromium expectations update.
      
      * platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2ec97f5
    • commit-queue@webkit.org's avatar
      IndexedDB: stub getKey/getObject interfaces for IDBKeyRange · 32c960f9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84089
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-04-17
      Reviewed by Dimitri Glazkov.
      
      Added stub methods on WebIDBIndex.h to cleanly land
      https://bugs.webkit.org/show_bug.cgi?id=83638
      
      * public/WebIDBIndex.h:
      (WebKit::WebIDBIndex::getObject):
      (WebKit::WebIDBIndex::getKey):
      * src/WebIDBIndexImpl.cpp:
      (WebKit::WebIDBIndexImpl::getObject):
      (WebKit):
      (WebKit::WebIDBIndexImpl::getKey):
      * src/WebIDBIndexImpl.h:
      (WebIDBIndexImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32c960f9
    • schenney@chromium.org's avatar
      [chromium] svg/clip-path/clip-in-mask.svg fails on Windows and Linux · e168f0ea
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53378
      
      Unreviewed expectations update after the fix went in.
      
      * platform/chromium-linux-x86/svg/zoom: Removed.
      * platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
      * platform/chromium-mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
      * platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
      * platform/chromium-win-xp/svg/zoom: Removed.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e168f0ea
    • tsepez@chromium.org's avatar
      Framesniffing defense is too aggressive. · 8d3c2c18
      tsepez@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83721
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      The RenderLayer code currently propagates scroll position to parent frames
      without any cross-origin checks.  This gives it a quick origin boundary check
      that is set by FrameLoader only when performing a fragment navigation.  This
      allows us to safely relax the restriction on not scrolling at load time in
      FrameLoader since the safe thing will happen later on at scroll time.
      
      Test: http/tests/navigation/anchor-frames-same-origin.html
      
      * dom/Document.cpp:
      (WebCore::Document::findUnsafeParentScrollPropagationBoundary):
      * dom/Document.h:
      (Document):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::finishedParsing):
      (WebCore::FrameLoader::loadInSameDocument):
      (WebCore::FrameLoader::scrollToFragmentWithParentBoundary):
      * loader/FrameLoader.h:
      (FrameLoader):
      * page/FrameView.cpp:
      (WebCore::FrameView::FrameView):
      (WebCore::FrameView::reset):
      * page/FrameView.h:
      (WebCore::FrameView::safeToPropagateScrollToParent):
      (WebCore::FrameView::setSafeToPropagateScrollToParent):
      (FrameView):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollRectToVisible):
      
      LayoutTests:
      
      * http/tests/inspector/resource-parameters-expected.txt:
      * http/tests/navigation/anchor-frames-cross-origin-expected.txt:
      * http/tests/navigation/anchor-frames-cross-origin.html:
      * http/tests/navigation/anchor-frames-same-origin-expected.txt: Added.
      * http/tests/navigation/anchor-frames-same-origin.html: Added.
      * http/tests/navigation/resources/frame-with-anchor-cross-origin.html:
      * http/tests/navigation/resources/frame-with-anchor-same-origin.html: Added.
      * http/tests/navigation/resources/grandchild-with-anchor.html: Added.
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
      * http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
      * http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d3c2c18
    • barraclough@apple.com's avatar
      Array.prototype.toString should be generic · 364138ec
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=81588
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncToString):
          - check for join function, use fast case if base object is array & join is present & default.
      * runtime/CommonIdentifiers.h:
          - added 'join'.
      
      LayoutTests: 
      
      * fast/js/array-functions-non-arrays-expected.txt:
          - check in new results
      * fast/js/array-prototype-properties-expected.txt:
          - new more detailed error message.
      * fast/js/script-tests/array-functions-non-arrays.js:
          - added new test cases, fix incorrect one.
      * sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.2_Array_prototype_toString/S15.4.4.2_A2_T1-expected.txt:
          - check in failing result (test is wrong)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      364138ec
    • eae@chromium.org's avatar
      Add size_t versions of multiplication and division operators to FractionalLayoutUnit · 374e959b
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83848
      
      Reviewed by Julien Chaffraix.
      
      Add size_t versions of operator* and operator/ for platforms where there
      is no ambiguity between unsigned int and size_t.
      
      No new tests, no new functionality.
      
      * platform/FractionalLayoutUnit.h:
      (FractionalLayoutUnit):
      (WebCore::FractionalLayoutUnit::FractionalLayoutUnit):
      (WebCore::FractionalLayoutUnit::isInBounds):
      (WebCore):
      (WebCore::operator*):
      (WebCore::operator/):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      374e959b
    • schenney@chromium.org's avatar
      Update long-failing Chromium expectations. · f643a5ee
      schenney@chromium.org authored
      Unreviewed Chromium expectation update.
      
      There is some chance that the background test is flaky, as many others are.
      
      * platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
      * platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
      * platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
      * platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f643a5ee
    • jer.noble@apple.com's avatar
      Exiting full screen video brings the wrong Safari window to the foreground · 6007e7bb
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83936
      
      Reviewed by Adele Peterson.
      
      Tell the original webView's window to makeKeyAndOrderFront once the exit
      animation completes.
      
      Source/WebKit/mac:
      
      * WebView/WebFullScreenController.mm:
      (-[WebFullScreenController finishedExitFullScreenAnimation:]):
      
      Source/WebKit2:
      
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6007e7bb