1. 27 Feb, 2008 19 commits
    • mitz@apple.com's avatar
      WebCore: · 37717da4
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - make centered text in right-to-left blocks spill over to the left
      
              Test: fast/text/align-center-rtl-spill.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::computeHorizontalPositionsForLine):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test that centered text in right-to-left blocks spills over to the left
      
              * fast/text/align-center-rtl-spill.html: Added.
              * platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
              * platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
              * platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37717da4
    • beidson@apple.com's avatar
      Tiger build fix · 2442270a
      beidson@apple.com authored
              * libWebKitSystemInterfaceTiger.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2442270a
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · e136420e
      mitz@apple.com authored
              - more bidi.cpp cleanup
      
              * platform/text/BidiResolver.h:
              (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun .
              (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun()
              here.
              (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use
              addRun().
              (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use
              destroy(), avoiding the need to specialize this method in BidiState.
              * rendering/bidi.cpp:
              (WebCore::BidiRun::destroy): Removed the RenderArena parameter.
              (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization.
              (WebCore::BidiState::addRun): Removed now-unnecessary specialization.
              (WebCore::RenderBlock::createLineBoxes): 
              (WebCore::RenderBlock::constructLine):
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME.
              (WebCore::RenderBlock::computeVerticalPositionsForLine):
              (WebCore::buildCompactRuns):
              (WebCore::RenderBlock::layoutInlineChildren):
              (WebCore::RenderBlock::determineStartPosition):
              (WebCore::RenderBlock::determineEndPosition):
              (WebCore::RenderBlock::matchedEndLine):
              (WebCore::skipNonBreakingSpace):
              (WebCore::RenderBlock::skipWhitespace):
              (WebCore::shouldSkipWhitespaceAfterStartObject):
              * rendering/bidi.h:
              (WebCore::BidiRun): Added m_ prefixes to several member variables. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e136420e
    • beidson@apple.com's avatar
      Reviewed by Mark Rowe · 8f61ffe0
      beidson@apple.com authored
              Removed some unused methods:
              WKGetNSURLResponseCalculatedExpiration
              WKGetNSURLResponseMustRevalidate
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f61ffe0
    • eric@webkit.org's avatar
      Rubber-stamped by Adam. · 58f8521c
      eric@webkit.org authored
              Fix svn:eol-style on all LayoutTest results
              I simply ran:
              cd LayoutTests
              find . -name "*-expected.txt" | xargs svn ps svn:eol-style native
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58f8521c
    • weinig@apple.com's avatar
      WebCore: · 014c993b
      weinig@apple.com authored
              Reviewed by Darin.
      
              Fix for <rdar://problem/5768769>
      
              - Don't allow cross-origin calls using window.functionName.call(otherFrame)
                syntax.
      
              * bindings/js/JSLocation.cpp:
              (WebCore::jsLocationProtoFuncToString): Do same-origin check.
              * bindings/js/kjs_window.cpp:
              (KJS::windowProtoFuncAToB): Ditto.
              (KJS::windowProtoFuncBToA): Ditto.
              (KJS::windowProtoFuncOpen): Ditto.
              (KJS::windowProtoFuncClearTimeout): Ditto.
              * bindings/scripts/CodeGeneratorJS.pm: Ditto.
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Updates tests for <rdar://problem/5768769>
      
              * http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
              * http/tests/security/cross-frame-access-call-expected.txt:
              * http/tests/security/cross-frame-access-call.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      014c993b
    • hyatt@apple.com's avatar
      More cleanup in preparation for fixing the HTML5 spec performance regression. · 86b942ba
      hyatt@apple.com authored
              Reviewed by Sam Weinig
      
              * dom/Attr.cpp:
              (WebCore::Attr::childrenChanged):
              * dom/Attr.h:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::insertBefore):
              (WebCore::ContainerNode::replaceChild):
              (WebCore::ContainerNode::removeChild):
              (WebCore::ContainerNode::removeChildren):
              (WebCore::ContainerNode::appendChild):
              (WebCore::ContainerNode::addChild):
              (WebCore::ContainerNode::childrenChanged):
              * dom/ContainerNode.h:
              * dom/Document.cpp:
              (WebCore::Document::childrenChanged):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::childrenChanged):
              * dom/Element.h:
              * dom/Node.h:
              (WebCore::Node::childrenChanged):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::childrenChanged):
              * html/HTMLObjectElement.h:
              * html/HTMLOptGroupElement.cpp:
              (WebCore::HTMLOptGroupElement::childrenChanged):
              * html/HTMLOptGroupElement.h:
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::childrenChanged):
              * html/HTMLOptionElement.h:
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::childrenChanged):
              * html/HTMLScriptElement.h:
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::childrenChanged):
              * html/HTMLSelectElement.h:
              * html/HTMLStyleElement.cpp:
              (WebCore::HTMLStyleElement::childrenChanged):
              * html/HTMLStyleElement.h:
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::childrenChanged):
              * html/HTMLTextAreaElement.h:
              * html/HTMLTitleElement.cpp:
              (WebCore::HTMLTitleElement::childrenChanged):
              * html/HTMLTitleElement.h:
              * svg/SVGClipPathElement.cpp:
              (WebCore::SVGClipPathElement::childrenChanged):
              * svg/SVGClipPathElement.h:
              * svg/SVGDefinitionSrcElement.cpp:
              (WebCore::SVGDefinitionSrcElement::childrenChanged):
              * svg/SVGDefinitionSrcElement.h:
              * svg/SVGFontFaceElement.cpp:
              (WebCore::SVGFontFaceElement::childrenChanged):
              * svg/SVGFontFaceElement.h:
              * svg/SVGFontFaceFormatElement.cpp:
              (WebCore::SVGFontFaceFormatElement::childrenChanged):
              * svg/SVGFontFaceFormatElement.h:
              * svg/SVGFontFaceSrcElement.cpp:
              (WebCore::SVGFontFaceSrcElement::childrenChanged):
              * svg/SVGFontFaceSrcElement.h:
              * svg/SVGFontFaceUriElement.cpp:
              (WebCore::SVGFontFaceUriElement::childrenChanged):
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGGElement.cpp:
              (WebCore::SVGGElement::childrenChanged):
              * svg/SVGGElement.h:
              * svg/SVGGradientElement.cpp:
              (WebCore::SVGGradientElement::childrenChanged):
              * svg/SVGGradientElement.h:
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::childrenChanged):
              * svg/SVGMarkerElement.h:
              * svg/SVGMaskElement.cpp:
              (WebCore::SVGMaskElement::childrenChanged):
              * svg/SVGMaskElement.h:
              * svg/SVGPatternElement.cpp:
              (WebCore::SVGPatternElement::childrenChanged):
              * svg/SVGPatternElement.h:
              * svg/SVGStyleElement.cpp:
              (WebCore::SVGStyleElement::childrenChanged):
              * svg/SVGStyleElement.h:
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::childrenChanged):
              * svg/SVGStyledElement.h:
              * svg/SVGTitleElement.cpp:
              (WebCore::SVGTitleElement::childrenChanged):
              * svg/SVGTitleElement.h:
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::childrenChanged):
              * svg/SVGUseElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86b942ba
    • beidson@apple.com's avatar
      WebKit/mac: · a6171866
      beidson@apple.com authored
              Reviewed by Mark Rowe (code) and Darin (concept)
      
              Much better fix for <rdar://problem/4930688> (see r19549)
              Original fix for <rdar://problem/3947312> (and 14 dupes)
              
              Let me tell you a story:
              A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
              WebArchive code was intertwined with that code in bizarre and complex ways.
              During the months long loader re-factoring where we pushed much loader code down into WebCore,
              many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
              with a sole purpose.
      
              One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
              to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the 
              single entry point for almost all loading (network or web archives)
      
              This method would check various headers and other fields on the NSURLRequest and NSURLResponse 
              to make decisions about the load.  If the cache control fields were expired or other conditions 
              in the headers were met, the load would be forced to go out to the network.
      
              As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.  
              At some point, all that remained was the special cases for loading WebArchives.  
              
              Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
              to be WebArchive specific, further cementing the assumed design.
      
              Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
              specific point in time.  Referring to the request to see if the resource should be reloaded seems
              nonsensical, as does referring to the response headers to see if the resource is "expired".  In the 
              context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
              during the initial load!
      
              After discovering the secret to reproducing all of these bugs is both emptying our your Foundation 
              cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases 
              that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
                inspect the request or response objects - We are loading from a WebArchive, and we should never
                make the decision to go out to the network when we actually have the resource available.
      
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit
      
      LayoutTests:
      
              Reviewed by Mark Rowe
      
              Test for better fix for <rdar://problem/4930688> (see r19549) and
              original fix for <rdar://problem/3947312> (and 14 dupes)
              
              Crafting custom WebArchives for layout tests is a pain and something that should
              be resolved if we decide to pursue a new format.
      
              Using a custom php script to act as a stand in for an image resource, I set its 
              cache-control header to expire immediately.  Without the fix for the above bugs,
              the resource will be "expired" and an attempt to fetch it from the network will
              go out and fail.  This failure will manifest with different ResourceLoadDelegate
              information, as well as different dimensions in the render tree - the missing 
              image icon versus the archived image.
      
              With the fix in place, the response will be ignored and the image will be pulled
              from the WebArchive.
      
              * webarchive/loading/cache-expired-subresource-expected.txt: Added.
              * webarchive/loading/cache-expired-subresource.html: Added.
              * webarchive/loading/resources/cache-expired-subresource.webarchive: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6171866
    • pewtermoose@webkit.org's avatar
      WebKit/mac: · 729cf2f9
      pewtermoose@webkit.org authored
              Reviewed by Adam Roben.
      
              Bug 14348: Messing up the inspector by dragging an URL into it
              http://bugs.webkit.org/show_bug.cgi?id=14348
              <rdar://problem/5283620> and <rdar://problem/5712808>
      
              * WebCoreSupport/WebInspectorClient.mm:
              (-[WebInspectorWindowController init]): Remove duplicate preference setting.
              (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
      
      WebKit/win:
      
              Reviewed by Adam Roben.
      
              Bug 14348: Messing up the inspector by dragging an URL into it
              http://bugs.webkit.org/show_bug.cgi?id=14348
              <rdar://problem/5283620> and <rdar://problem/5712808>
      
              Add a new class to handle the Inspector's delegate calls.
      
              * WebCoreSupport/WebInspectorClient.cpp:
              (WebInspectorClient::createPage):
              * WebCoreSupport/WebInspectorDelegate.cpp: Added.
              (:m_refCount):
              (WebInspectorDelegate::createInstance):
              (WebInspectorDelegate::AddRef):
              (WebInspectorDelegate::Release):
              (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
              * WebCoreSupport/WebInspectorDelegate.h: Added.
              (WebInspectorDelegate::QueryInterface):
              (WebInspectorDelegate::createWebViewWithRequest):
              (WebInspectorDelegate::webViewShow):
              (WebInspectorDelegate::webViewClose):
              (WebInspectorDelegate::webViewFocus):
              (WebInspectorDelegate::webViewUnfocus):
              (WebInspectorDelegate::webViewFirstResponder):
              (WebInspectorDelegate::makeFirstResponder):
              (WebInspectorDelegate::setStatusText):
              (WebInspectorDelegate::webViewStatusText):
              (WebInspectorDelegate::webViewAreToolbarsVisible):
              (WebInspectorDelegate::setToolbarsVisible):
              (WebInspectorDelegate::webViewIsStatusBarVisible):
              (WebInspectorDelegate::setStatusBarVisible):
              (WebInspectorDelegate::webViewIsResizable):
              (WebInspectorDelegate::setResizable):
              (WebInspectorDelegate::setFrame):
              (WebInspectorDelegate::webViewFrame):
              (WebInspectorDelegate::setContentRect):
              (WebInspectorDelegate::webViewContentRect):
              (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage):
              (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage):
              (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt):
              (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage):
              (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener):
              (WebInspectorDelegate::mouseDidMoveOverElement):
              (WebInspectorDelegate::contextMenuItemsForElement):
              (WebInspectorDelegate::validateUserInterfaceItem):
              (WebInspectorDelegate::shouldPerformAction):
              (WebInspectorDelegate::willPerformDragDestinationAction):
              (WebInspectorDelegate::dragSourceActionMaskForPoint):
              (WebInspectorDelegate::willPerformDragSourceAction):
              (WebInspectorDelegate::contextMenuItemSelected):
              (WebInspectorDelegate::hasCustomMenuImplementation):
              (WebInspectorDelegate::trackCustomPopupMenu):
              (WebInspectorDelegate::measureCustomMenuItem):
              (WebInspectorDelegate::drawCustomMenuItem):
              (WebInspectorDelegate::addCustomMenuDrawingData):
              (WebInspectorDelegate::cleanUpCustomMenuDrawingData):
              (WebInspectorDelegate::canTakeFocus):
              (WebInspectorDelegate::takeFocus):
              (WebInspectorDelegate::registerUndoWithTarget):
              (WebInspectorDelegate::removeAllActionsWithTarget):
              (WebInspectorDelegate::setActionTitle):
              (WebInspectorDelegate::undo):
              (WebInspectorDelegate::redo):
              (WebInspectorDelegate::canUndo):
              (WebInspectorDelegate::canRedo):
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      729cf2f9
    • kmccullough@apple.com's avatar
      Landing test that was forgotten in the original patch (r30087). · 9d9b272b
      kmccullough@apple.com authored
              Test for: http://bugs.webkit.org/show_bug.cgi?id=17191
              HTML5: Client-side database queries should return values of type number
      
              * storage/sql-data-types-expected.txt: Added.
              * storage/sql-data-types.html: Added.
              * storage/sql-data-types.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d9b272b
    • ap@webkit.org's avatar
      Add bug number to ChangeLog. · 192dc689
      ap@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      192dc689
    • ap@webkit.org's avatar
      2008-02-27 Julien Chaffraix <julien.chaffraix@gmail.com> · b134ed7f
      ap@webkit.org authored
              Reviewed by Alexey.
      
              http://bugs.webkit.org/show_bug.cgi?id=17481
              Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event
      
              Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::open):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b134ed7f
    • ap@webkit.org's avatar
      Reviewed by Sam Weinig. · 8819f1c4
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=17030
              Small buffer overflow within initialization
      
              * kjs/date_object.cpp:
              (KJS::DateObjectFuncImp::callAsFunction):
              (KJS::parseDate):
              Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8819f1c4
    • ap@webkit.org's avatar
      2008-02-27 Sriram Neelakandan <sriram.neelakandan@gmail.com> · fa64d6c6
      ap@webkit.org authored
              Reviewed, tweaked and landed by ap.
      
              http://bugs.webkit.org/show_bug.cgi?id=17487
              HTMLInput mysteriously fails to work if ICU dat file is missing
      
              * platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator
              has been opened.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa64d6c6
    • aroben@apple.com's avatar
      Attempt to fix the GTK+ build · 56f18231
      aroben@apple.com authored
              * webkit/webkitwebframe.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56f18231
    • aroben@apple.com's avatar
      Fix revision number in ChangeLog · 81294801
      aroben@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81294801
    • aroben@apple.com's avatar
      Windows build fix after r30613 · 47432c2e
      aroben@apple.com authored
              * platform/win/ClipboardWin.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47432c2e
    • zimmermann@webkit.org's avatar
      Reviewed by Simon. · 4ad742f3
      zimmermann@webkit.org authored
      Small style cleanup, and obvious fix: SVGGElement reacted on
      'clipPathUnits' changes, which is a funny copy&paste error.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad742f3
    • zimmermann@webkit.org's avatar
      Reviewed by Simon. · 1ff41d01
      zimmermann@webkit.org authored
      Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
      Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ff41d01
  2. 26 Feb, 2008 21 commits
    • antti@apple.com's avatar
      Reviewed by Darin. · b5be6978
      antti@apple.com authored
              Fix <rdar://problem/5761326>
              REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)
              
              Generate better code with VS:
              - Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
              - Refactor error reporting so that there is no need to construct/destruct Strings in common cases
              - Add a separate version of the function for cases where error messages are not wanted
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::customGetOwnPropertySlot):
              * bindings/js/kjs_window.cpp:
              (KJS::Window::allowsAccessFrom):
              (KJS::Window::allowsAccessFromNoErrorMessage):
              (KJS::Window::allowsAccessFromPrivate):
              (KJS::Window::crossDomainAccessErrorMessage):
              * bindings/js/kjs_window.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5be6978
    • weinig@apple.com's avatar
      Reviewed by Dave Hyatt. · 9a025fca
      weinig@apple.com authored
              - remove DeprecatedCString, DeprecatedArray, and ArrayImpl.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * platform/ArrayImpl.cpp: Removed.
              * platform/ArrayImpl.h: Removed.
              * platform/DeprecatedArray.h: Removed.
              * platform/DeprecatedCString.cpp: Removed.
              * platform/DeprecatedCString.h: Removed.
              * platform/text/CString.cpp:
              (WebCore::CString::length):
              * platform/text/CString.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a025fca
    • hyatt@apple.com's avatar
      Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown. · c057889a
      hyatt@apple.com authored
              Reviewed by Sam Weinig
      
              * dom/Attr.cpp:
              (WebCore::Attr::childrenChanged):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::insertBefore):
              (WebCore::ContainerNode::replaceChild):
              (WebCore::ContainerNode::removeChild):
              (WebCore::ContainerNode::removeChildren):
              (WebCore::ContainerNode::appendChild):
              (WebCore::ContainerNode::addChild):
              (WebCore::ContainerNode::childrenChanged):
              * dom/ContainerNode.h:
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
              * dom/EventTargetNode.h:
              * dom/NamedAttrMap.cpp:
              (WebCore::NamedAttrMap::addAttribute):
              (WebCore::NamedAttrMap::removeAttribute):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c057889a
    • kevino@webkit.org's avatar
    • darin@apple.com's avatar
      Reviewed by Sam. · 263724c6
      darin@apple.com authored
              - remove use of DeprecatedCString from Windows pasteboard code
      
              * platform/win/ClipboardUtilitiesWin.cpp:
              (WebCore::createGlobalData): Added an overload for Vector<char>.
              Streamlined the logic a bit.
              (WebCore::append): Added. Helper functions for appending to a
              Vector<char>.
              (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead
              of DeprecatedCString. Also simplified the logic a bit and used
              macros to handle the integer width.
              (WebCore::urlToMarkup): Use Vector<UChar> instead of String.
              (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
              * platform/win/ClipboardUtilitiesWin.h: Update type of return
              value from markupToCF_HTML. Did a bit of streamlining too.
              * platform/win/ClipboardWin.cpp:
              (WebCore::writeURL): Update for above changes.
              (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto.
              (WebCore::ClipboardWin::writeRange): Ditto.
              * platform/win/PasteboardWin.cpp:
              (WebCore::Pasteboard::writeSelection): Ditto.
              (WebCore::Pasteboard::writeURL): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      263724c6
    • aroben@apple.com's avatar
      Move ResourceLoadDelegate methods to WebFrameLoaderClient · 29417724
      aroben@apple.com authored
               Changed all methods to use early returns where possible and COMPtr's
               AdoptCOM/Query constructors.
      
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::assignIdentifierToInitialRequest):
               (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
               (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
               (WebFrameLoaderClient::dispatchWillSendRequest):
               (WebFrameLoaderClient::dispatchDidReceiveResponse):
               (WebFrameLoaderClient::dispatchDidReceiveContentLength):
               (WebFrameLoaderClient::dispatchDidFinishLoading):
               (WebFrameLoaderClient::dispatchDidFailLoading):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29417724
    • aroben@apple.com's avatar
      Move two more methods to WebFrameLoaderClient · a6b06a6a
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (kit):
               (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to
               early returns, and changed to use the COMPtr Query constructor.
               (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early
               return, and changed to use getWebDataSource.
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6b06a6a
    • aroben@apple.com's avatar
      Get rid of IID_WebFrame · e18f0381
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebFrame.cpp: Removed IID_WebFrame definition.
               (WebFrame::QueryInterface): Use __uuidof(WebFrame) instead of
               IID_WebFrame.
               (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor
               instead of a manual QueryInterface.
               * WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a
               DECLSPEC_UUID.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e18f0381
    • aroben@apple.com's avatar
      Move WebHistory-related methods to WebFrameLoaderClient · 1e8b4177
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::updateGlobalHistory):
               (WebFrameLoaderClient::shouldGoToHistoryItem):
               (WebFrameLoaderClient::setTitle): Changed some nested ifs into early
               returns.
               (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to
               make the reference management foolproof.
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e8b4177
    • aroben@apple.com's avatar
      Move cache-related methods to WebFrameLoaderClient · ab21c83c
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (getWebDataSource): Moved to the top of the file.
               (WebFrameLoaderClient::savePlatformDataToCachedPage):
               (WebFrameLoaderClient::transitionToCommittedForNewPage):
               (WebFrameLoaderClient::canCachePage):
               * WebCoreSupport/WebFrameLoaderClient.h:
               * WebFrame.cpp:
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab21c83c
    • timothy@apple.com's avatar
      Reviewed by Adam Roben. · 50ebc71f
      timothy@apple.com authored
              <rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
              source list does not scroll when item at edge is reached (16572)
      
              Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
              we were using in utilities.js.
      
              * page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
              * page/inspector/Resource.js: Ditto.
              * page/inspector/inspector.js: Ditto.
              * page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead
              of scrollIntoView, so the source line is centered in the view if needed.
              * page/inspector/utilities.js: Removed scrollToElement().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50ebc71f
    • beidson@apple.com's avatar
      Add a skipped storage test for now · 99fc5366
      beidson@apple.com authored
              * platform/win/Skipped: Added storage/multiple-transactions.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99fc5366
    • hyatt@apple.com's avatar
      · cdfc707a
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdfc707a
    • hyatt@apple.com's avatar
      · 95aa614a
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95aa614a
    • hyatt@apple.com's avatar
      Reviewed by Dan · 21cc37a9
      hyatt@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17485
      
              Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
              Fixes a regression on huffingtonpost.com.
      
              New tests added to fast/inline
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::computeLogicalBoxHeights):
              (WebCore::InlineFlowBox::placeBoxesVertically):
              (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::calcMargins):
              * rendering/RenderFlow.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin):
              (WebCore::RenderObject::hasHorizontalBordersOrPadding):
              * rendering/bidi.cpp:
              (WebCore::getBorderPaddingMargin):
              (WebCore::RenderBlock::layoutInlineChildren):
              (WebCore::inlineFlowRequiresLineBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21cc37a9
    • timothy@apple.com's avatar
      .: · 7e518c5b
      timothy@apple.com authored
              Reviewed by Darin Adler.
      
              Add "64" and "64u" make rules to allow easy building of 64-bit versions.
      
              make 64: will build Intel-only 64-bit.
              make 64u: will build 4-way universal for PPC and Intel.
      
              * Makefile:
              * Makefile.shared:
      
      WebKitTools:
      
              Reviewed by Darin Adler.
      
              * Scripts/build-webkit: Add --universal and --64-bit flags to make building
              64-bit architectures easy. Combine the two flags to build 4-way universal.
              * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
              non-zero when the build failes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e518c5b
    • weinig@apple.com's avatar
      Fix Windows build. · 10ac6851
      weinig@apple.com authored
              * platform/text/PlatformString.h:
              (WebCore::reverseFind):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10ac6851
    • mitz@apple.com's avatar
      WebCore: · 8e3f8bda
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17555
                <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
      
              Test: fast/dynamic/subtree-table-cell-height.html
      
              * rendering/RenderObject.cpp:
              (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their
              height depends on their contents even if the CSS height property is
              fixed.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17555
                <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
      
              * fast/dynamic/subtree-table-cell-height.html: Added.
              * platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
              * platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
              * platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3f8bda
    • jess@apple.com's avatar
      Reviewed by Darin. · 6997a5d3
      jess@apple.com authored
              * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
              so that Safari inherits it when launched. Preexisting code in WebKit checks this
              environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
              launched by Safari continue to use the standard system WebKit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6997a5d3
    • weinig@apple.com's avatar
      JavaScriptCore: · f8479433
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              - Add a variant of remove that takes a position and a length.
      
              * wtf/Vector.h:
              (WTF::Vector::remove):
      
      WebCore:
      
              Reviewed by Dan Bernstein.
      
              Make the cleanPath function in CSSStyleSelector more efficient by using
              a Vector<UChar>.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::cleanPath): Make this function work on a Vector<UChar> instead
              of a String.  Also remove unnecessary reverseFind call that could be acomplished
              with two compares.
              (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using
              a stack buffer.
              * platform/text/PlatformString.h:
              (WebCore::find): Make this find generic enough that it can be used for
              String::find.
              (WebCore::reverseFind): Implement reverseFind so that it can be used
              for with a UChar* and length.
              * platform/text/StringImpl.cpp:
              (WebCore::StringImpl::find): Use implementation in PlatformString.cpp
              (WebCore::StringImpl::reverseFind): Ditto,
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8479433
    • ap@webkit.org's avatar
      Reviewed by Darin. Tweaked and landed by Alexey. · a4d42b5d
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=17411
              Ideographic comma and full stop should be treated as line-breakable characters
      
              Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html
      
              * platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
              * rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in
              Unicode 5.0 that is causing this.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4d42b5d