1. 04 Sep, 2012 2 commits
    • commit-queue@webkit.org's avatar
      [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() · 366bc8b8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95740
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Added sanity check to be sure we have a render object prior to seeing if
      said object is an anonymous block.
      
      Testing via unit test because a non-flaky layout test crasher could not
      be found.
      
      * accessibility/gtk/AccessibilityObjectAtk.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Sanity check for render object added.
      
      Source/WebKit/gtk:
      
      Updated unit test.
      
      * tests/testatk.c:
      (testWebkitAtkComboBox): Added checks that the menu popup in a combo box
      has 0 links and, more importantly, that checking doesn't result in a crash.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      366bc8b8
    • commit-queue@webkit.org's avatar
      [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex · 61d00bd3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95618
      
      Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Make sure we only emit the the signal for menu lists and list
      boxes rendered from actual HTML select elements.
      
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::notifyChildrenSelectionChange): We support accessibility
      ListBoxes and MenuLists only here, assuming they represent HTML
      select elements, which might be not always true (e.g. ARIA). Thus,
      check if that condition is true, early returning in other case.
      
      LayoutTests:
      
      New layout test to ensure we don't crash with ATK notifications
      anymore when changing the selection in an ARIA listbox.
      
      * platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
      * platform/gtk/accessibility/aria-listbox-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d00bd3
  2. 01 Sep, 2012 3 commits
    • commit-queue@webkit.org's avatar
      [Gtk] No accessible caret-moved events found in certain content · 84ebe920
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72811
      
      Part of the bug was due to expected accessible objects of DivRole
      and ParagraphRole being ignored, in favor of including child blocks.
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Test: platform/gtk/accessibility/spans-paragraphs-and-divs.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::firstAnonymousBlockChild):
      (WebCore):
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      New method to return the first child which is an anonymous block.
      * accessibility/gtk/AccessibilityObjectAtk.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Include paragraphs and divs which contain a non-nested anonymous block.
      
      LayoutTests:
      
      Added new test to verify that paragraphs and divs which contain anonymous
      blocks are included in the accessible object hierarchy and have the correct
      number of children with the expected role.
      
      * platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt: Added.
      * platform/gtk/accessibility/spans-paragraphs-and-divs.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84ebe920
    • zandobersek@gmail.com's avatar
      [Gtk] No accessible caret-moved events found in certain content · 2b2075f6
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=72811
      
      Part of the bug was due to extraneous accessible objects resulting
      from unignored inline and block spans.
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
      Reviewed by Chris Fleizach.
      
      Source/WebCore: 
      
      Test: platform/gtk/accessibility/spans.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Ignore objects that have spanTag tag name.
      * accessibility/gtk/AccessibilityObjectAtk.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Ignore most anonymous blocks.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (roleIsTextType): Add ListItem to the roles which should implement AtkText.
      
      LayoutTests: 
      
      Added new test, updated the results of one test to reflect the fix,
      corrected a test with a mismatched element tag.
      
      * platform/gtk/accessibility/aria-roles-unignored-expected.txt: Corrected results having fixed tag.
      * platform/gtk/accessibility/aria-roles-unignored.html: Fixed mismatched element tag.
      * platform/gtk/accessibility/media-element-expected.txt: Updated to reflect removal of extraneous object.
      * platform/gtk/accessibility/spans-expected.txt: Added.
      * platform/gtk/accessibility/spans.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b2075f6
    • zandobersek@gmail.com's avatar
      [Gtk] Incorrect/unexpected characters in the text of certain accessibles · a2613b79
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95180
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-01
      Reviewed by Chris Fleizach.
      
      Source/WebCore: 
      
      The bug was caused by failing to properly handle anonymous block text
      which had object replacement characters (multibyte) in it. Calculating
      the string length based on the UTF-8 string meant that we were returning
      more characters than were there and in danger of splitting a multibyte
      character.
      
      Tests: platform/gtk/accessibility/entry-and-password.html
             platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      (webkitAccessibleTextGetText): Convert the text returned by textForObject()
      to Unicode before calculating its length.
      
      Source/WebKit/gtk: 
      
      Corrected a unit test in which the expected accessible text was wrong as
      a result of this bug. In particular, the AtkText inserted into an empty
      text field is expected to be the same text atk_text_get_text() returns.
      That was not happening -- and presumably not noticed as a result of the
      hard to read textual representation of the multibyte password field
      bullets.
      
      * tests/testatk.c:
      (testWebkitAtkTextChangedNotifications): Corrected the test and added a
      comment so that one knows what the multibyte character is.
      
      Tools: 
      
      The bug that was fixed stood in the way of fully implementing stringValue().
      Testing that the bug is fixed requires stringValue() to be fully implemented
      and object replacement characters to be printable.
      
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (replaceCharactersForResults): New method which turns object replacement
      characters into "<obj>" so that the characters can be properly shown in
      Layout Test results. Also turns "\n" into "<\\n>" so that printing the
      accessible text of a single object in the accessible tree doesn't mess up
      the readibility of the results.
      (AccessibilityUIElement::stringValue): Remove the code that immediately
      returned upon encountering an object of ATK_ROLE_PANEL and call the new
      replaceCharactersForResults() prior to returning the accessible string
      value.
      
      LayoutTests: 
      
      Two new layout tests, plus one updated one.
      
      * platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Indicated replaced objects.
      * platform/gtk/accessibility/entry-and-password-expected.txt: Added.
      * platform/gtk/accessibility/entry-and-password.html: Added.
      * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Added.
      * platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2613b79
  3. 29 Aug, 2012 3 commits
    • dmazzoni@google.com's avatar
      AX: Canvas should have a distinct role · 56a82822
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95248
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Add new role for a canvas element, and a method to determine if
      a canvas has fallback content, so each platform can decide on the
      appropriate role mapping to use.
      
      Test: accessibility/canvas-description-and-role.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
      (WebCore):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isCanvas):
      (WebCore::AccessibilityObject::canvasHasFallbackContent):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      Add support for canvas accessibility role.
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      Map new CanvasRole to the same as ImageRole.
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      Add support for canvas accessibility role.
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      Add new tests for canvas role.
      
      * accessibility/canvas.html: Deleted.
      * accessibility/canvas-expected.txt: Deleted.
      * accessibility/canvas-description-and-role.html: Added.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas.html: Added.
      * platform/mac/accessibility/canvas-expected.txt: Added.
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56a82822
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r126972. · 6aa5c7e9
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/126972
      https://bugs.webkit.org/show_bug.cgi?id=95349
      
      accessibility/canvas-description-and-role.html has been
      failing consistently on several bots and Dominic needs some
      time to investigate why (Requested by jchaffraix on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-29
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      * accessibility/AccessibilityNodeObject.h:
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityDescription):
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      * accessibility/canvas-description-and-role.html: Removed.
      * accessibility/canvas-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/canvas-expected.txt.
      * accessibility/canvas.html: Renamed from LayoutTests/platform/mac/accessibility/canvas.html.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa5c7e9
    • dmazzoni@google.com's avatar
      AX: Canvas should have a distinct role · a48d7b3c
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95248
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Add new role for a canvas element, and a method to determine if
      a canvas has fallback content, so each platform can decide on the
      appropriate role mapping to use.
      
      Test: accessibility/canvas-description-and-role.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::canvasHasFallbackContent):
      (WebCore):
      * accessibility/AccessibilityNodeObject.h:
      (AccessibilityNodeObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isCanvas):
      (WebCore::AccessibilityObject::canvasHasFallbackContent):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      (WebCore::AccessibilityRenderObject::canHaveChildren):
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap):
      (-[WebAccessibilityObjectWrapper role]):
      
      Source/WebKit/chromium:
      
      Add support for canvas accessibility role.
      
      * public/WebAccessibilityRole.h:
      * src/AssertMatchingEnums.cpp:
      
      Source/WebKit/win:
      
      Map new CanvasRole to the same as ImageRole.
      
      * AccessibleBase.cpp:
      (MSAARole):
      
      Tools:
      
      Add support for canvas accessibility role.
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      Add new tests for canvas role.
      
      * accessibility/canvas.html: Deleted.
      * accessibility/canvas-expected.txt: Deleted.
      * accessibility/canvas-description-and-role.html: Added.
      * platform/chromium/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/canvas.html: Added.
      * platform/mac/accessibility/canvas-expected.txt: Added.
      * platform/mac/accessibility/canvas-description-and-role-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a48d7b3c
  4. 22 Aug, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Source/WebCore: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON · 6152cb9e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a new role, Toggle Button, based on whether aria-pressed is present.
      http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
      
      Test: platform/gtk/accessibility/aria-toggle-button-role.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::determineAccessibilityRole): using buttonRoleType
      to classify a button-related role.
      (WebCore::AccessibilityNodeObject::determineAriaRoleAttribute): using buttonRoleType
      to classify a button-related role.
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::ariaPressedIsPresent): checks if aria-pressed
      attribute is present.
      (WebCore::AccessibilityObject::buttonRoleType): returns a specific button-related
      role if the object is a button-related role.
      * accessibility/AccessibilityObject.h:
      (AccessibilityObject): added new role ToggleButtonRole.
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole): using buttonRoleType
      to classify a button-related role.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole): added a mapping between ToggleButtonRole and
      ATK_ROLE_TOGGLE_BUTTON.
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (createAccessibilityRoleMap): added a mapping between
      ToggleButtonRole and NSAccessibilityButtonRole
      
      Source/WebKit/chromium: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a new role, Toggle Button, based on whether aria-pressed is present.
      http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
      
      * public/WebAccessibilityRole.h: added WebAccessibilityRoleToggleButton that
      matchs with WebCore ToggleButtonRole
      * src/AssertMatchingEnums.cpp: added the assert matching rule for
      WebAccessibilityRoleToggleButton and ToggleButtonRole
      
      Tools: Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a new role, Toggle Button, based on whether aria-pressed is present.
      http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
      
      LayoutTests: [Gtk] Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
      https://bugs.webkit.org/show_bug.cgi?id=73819
      
      Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-08-22
      Reviewed by Chris Fleizach.
      
      Added a test to verify that when aria-pressed is present, buttons
      will have the appropiate role.
      
      * platform/gtk/accessibility/aria-toggle-button-role-expected.txt: Added.
      * platform/gtk/accessibility/aria-toggle-button-role.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6152cb9e
    • commit-queue@webkit.org's avatar
      Reduce Font.h includes across project -- improves RenderObject.h compile time · d0c076d4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93629
      
      Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-22
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      RenderStyle.h no longer depends on Font.h. The files that transitively
      need to be updated with proper includes are fixed.
      
      No new tests. Functionality should remain the same.
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      * bindings/objc/DOM.mm:
      * css/CSSComputedStyleDeclaration.cpp:
      * css/CSSPrimitiveValue.cpp:
      * css/StyleResolver.h:
      * dom/CharacterData.cpp:
      * dom/ElementRareData.h:
      * dom/NodeRenderingContext.cpp:
      * dom/Text.cpp:
      * editing/TextIterator.cpp:
      * editing/mac/EditorMac.mm:
      * html/HTMLTitleElement.cpp:
      * html/shadow/TextControlInnerElements.cpp:
      * inspector/InspectorOverlay.cpp:
      * page/ContextMenuController.cpp:
      * page/PrintContext.cpp:
      * platform/efl/RenderThemeEfl.cpp:
      * platform/graphics/FontMetrics.h:
      * platform/gtk/RenderThemeGtk.cpp:
      * platform/gtk/RenderThemeGtk2.cpp:
      * platform/mac/HTMLConverter.mm:
      * rendering/EllipsisBox.cpp:
      * rendering/FlowThreadController.cpp:
      * rendering/InlineBox.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/InlineFlowBox.h:
      (WebCore):
      * rendering/RenderButton.cpp:
      * rendering/RenderCombineText.cpp:
      * rendering/RenderCombineText.h:
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      * rendering/RenderEmbeddedObject.h:
      (WebCore):
      * rendering/RenderFileUploadControl.cpp:
      * rendering/RenderFullScreen.h:
      * rendering/RenderImage.cpp:
      * rendering/RenderInline.cpp:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderMultiColumnBlock.cpp:
      * rendering/RenderRegion.h:
      * rendering/RenderRuby.cpp:
      * rendering/RenderRubyRun.cpp:
      * rendering/RenderScrollbar.cpp:
      * rendering/RenderTable.cpp:
      * rendering/RenderTableCell.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/RenderTextControl.cpp:
      * rendering/RenderTextControlMultiLine.cpp:
      * rendering/RenderThemeChromiumSkia.cpp:
      * rendering/RenderView.cpp:
      * rendering/TextAutosizer.cpp:
      * rendering/mathml/RenderMathMLBlock.h:
      * rendering/style/KeyframeList.h:
      * rendering/style/RenderStyle.cpp:
      * rendering/style/RenderStyle.h:
      (WebCore):
      * rendering/style/StyleInheritedData.cpp:
      * rendering/svg/RenderSVGBlock.cpp:
      * rendering/svg/RenderSVGInlineText.h:
      * svg/SVGLengthContext.cpp:
      * svg/SVGTRefElement.cpp:
      
      Source/WebKit/chromium:
      
      Adds includes due to change in RenderStyle.h
      
      * src/WebFrameImpl.cpp:
      * src/mac/WebSubstringUtil.mm:
      
      Source/WebKit/win:
      
      Adds includes due to change in RenderStyle.h
      
      * DOMCoreClasses.cpp:
      
      Source/WebKit2:
      
      Adds includes due to change in RenderStyle.h
      
      * WebProcess/WebPage/mac/WebPageMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0c076d4
  5. 21 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [Gtk] No accessible caret-moved events found in certain content · ca1b1d2a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72811
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-21
      Reviewed by Chris Fleizach.
      
      Part of the bug is due to objects which should claim to implement AtkText
      failed to do so as a result of containing a mixture of inline and block
      spans.
      
      An updated unit test was provided.
      
      Source/WebCore:
      
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (roleIsTextType): New method to check if a role is one expected to have
      implemented the AtkText interface. Currently that is defined as:
       - ParagraphRole
       - HeadingRole
       - DivRole
       - CellRole
      (getInterfaceMaskFromObject): If a role is one of the text type roles,
      automatically add WAI_TEXT to the accessible object's interface mask.
      
      Source/WebKit/gtk:
      
      * tests/testatk.c:
      (testWebkitAtkCaretOffsets): Added instances of objects containing a
      mixture of inline and block spans and tested that they implement AtkText
      and contain the right textual contents.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca1b1d2a
  6. 15 Aug, 2012 3 commits
    • dmazzoni@google.com's avatar
      AX: Calls to AXObjectCache should prefer Node over Renderer · cfbd0dd1
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91794
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Now that it's possible for nodes inside a canvas subtree to be focused and
      represent accessible content, accessibility notifications should be triggered
      with a Node* rather than with a RenderObject* whenever possible.
      
      Every public API in AXObjectCache that took a RenderObject* before now either
      takes a Node* instead, or has a parallel method that takes a Node*.
      
      Tests: accessibility/accessibility-node-memory-management.html
             accessibility/accessibility-node-reparent.html
             accessibility/canvas-fallback-content.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::focusedImageMapUIElement):
      (WebCore::AXObjectCache::focusedUIElementForPage):
      (WebCore::AXObjectCache::get):
      (WebCore::AXObjectCache::getOrCreate):
      (WebCore::AXObjectCache::contentChanged):
      (WebCore):
      (WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
      (WebCore::AXObjectCache::childrenChanged):
      (WebCore::AXObjectCache::postNotification):
      (WebCore::AXObjectCache::checkedStateChanged):
      (WebCore::AXObjectCache::selectedChildrenChanged):
      (WebCore::AXObjectCache::nodeTextChangeNotification):
      (WebCore::AXObjectCache::handleAriaExpandedChange):
      (WebCore::AXObjectCache::handleActiveDescendantChanged):
      (WebCore::AXObjectCache::handleAriaRoleChanged):
      (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
      (WebCore::AXObjectCache::rootAXEditableElement):
      (WebCore::AXObjectCache::nodeIsTextControl):
      * accessibility/AXObjectCache.h:
      (AXObjectCache):
      (WebCore::AXObjectCache::setNodeInUse):
      (WebCore::AXObjectCache::removeNodeForUse):
      (WebCore::AXObjectCache::isNodeInUse):
      (WebCore::AXObjectCache::checkedStateChanged):
      (WebCore::AXObjectCache::childrenChanged):
      (WebCore::AXObjectCache::contentChanged):
      (WebCore::AXObjectCache::updateCacheAfterNodeIsAttached):
      (WebCore::AXObjectCache::handleActiveDescendantChanged):
      (WebCore::AXObjectCache::handleAriaExpandedChange):
      (WebCore::AXObjectCache::handleAriaRoleChanged):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      (WebCore::AXObjectCache::nodeTextChangeNotification):
      (WebCore::AXObjectCache::postNotification):
      (WebCore::AXObjectCache::selectedChildrenChanged):
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::parentObject):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::appendAccessibilityObject):
      (WebCore::replacedNodeNeedsCharacter):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::menuForMenuButton):
      (WebCore::AccessibilityRenderObject::menuButtonForMenu):
      (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
      (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
      (WebCore::AccessibilityRenderObject::titleUIElement):
      (WebCore::AccessibilityRenderObject::isTabItemSelected):
      (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
      (WebCore::AccessibilityRenderObject::nodeIsTextControl):
      (WebCore::AccessibilityRenderObject::activeDescendant):
      (WebCore::AccessibilityRenderObject::correspondingControlForLabelElement):
      (WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/AccessibilityScrollView.cpp:
      (WebCore::AccessibilityScrollView::webAreaObject):
      (WebCore::AccessibilityScrollView::parentObject):
      (WebCore::AccessibilityScrollView::parentObjectIfExists):
      * accessibility/chromium/AXObjectCacheChromium.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * bindings/cpp/WebDOMCustomVoidCallback.cpp:
      (toWebCore):
      * dom/Document.cpp:
      (WebCore::Document::setFocusedNode):
      * dom/Element.cpp:
      (WebCore::Element::attributeChanged):
      * dom/Node.cpp:
      (WebCore::Node::~Node):
      (WebCore::Node::attach):
      * editing/AppendNodeCommand.cpp:
      (WebCore::sendAXTextChangedIgnoringLineBreaks):
      * editing/DeleteFromTextNodeCommand.cpp:
      (WebCore::DeleteFromTextNodeCommand::doApply):
      (WebCore::DeleteFromTextNodeCommand::doUnapply):
      * editing/Editor.cpp:
      (WebCore::Editor::respondToChangedContents):
      (WebCore::Editor::markAndReplaceFor):
      * editing/InsertIntoTextNodeCommand.cpp:
      (WebCore::InsertIntoTextNodeCommand::doApply):
      (WebCore::InsertIntoTextNodeCommand::doUnapply):
      * editing/InsertNodeBeforeCommand.cpp:
      (WebCore::InsertNodeBeforeCommand::doApply):
      (WebCore::InsertNodeBeforeCommand::doUnapply):
      * editing/chromium/FrameSelectionChromium.cpp:
      (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setChecked):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::childrenChanged):
      (WebCore::HTMLSelectElement::optionElementChildrenChanged):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::setInnerTextValue):
      * html/InputType.cpp:
      (WebCore::InputType::applyStep):
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::handleKeydownEvent):
      * page/FocusController.cpp:
      (WebCore::FocusController::setInitialFocus):
      
      LayoutTests:
      
      New tests:
      - canvas-fallback-content tests that objects in a canvas subtree can be
        focused and then you can retrieve the role of the accessible object.
      - accessibility-node-memory-management ensures that an AccessibilityNodeObject
        is detached when its node is destroyed.
      - accessibility-node-reparent ensures that if an AccessibilityNodeObject is
        created for a node without a renderer, but the node later gets a renderer,
        the AccessibilityNodeObject is detached and an AccessibilityRenderObject is
        created instead.
      
      * accessibility/accessibility-node-memory-management-expected.txt: Added.
      * accessibility/accessibility-node-memory-management.html: Added.
      * accessibility/accessibility-node-reparent-expected.txt: Added.
      * accessibility/accessibility-node-reparent.html: Added.
      * accessibility/canvas-fallback-content-expected.txt: Added.
      * accessibility/canvas-fallback-content.html: Added.
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfbd0dd1
    • commit-queue@webkit.org's avatar
      [Gtk] atk_text_set_caret_offset() fails for table cells · d0a8b977
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83501
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Allow using text ranges in accessible table cells.
      
      * accessibility/gtk/AccessibilityObjectAtk.cpp:
      (WebCore::AccessibilityObject::allowsTextRanges):
      Add table cells to the list of accessibility objects supporting text ranges.
      
      Source/WebKit/gtk:
      
      Update unit test to include setting the caret in a table cell via the AtkText interface.
      
      * tests/testatk.c:
      (testWebkitAtkCaretOffsets): Add setting the caret inside the text of a table cell.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a8b977
    • commit-queue@webkit.org's avatar
      [Gtk] atk_text_get_text_at_offset() fails to provide the correct line for... · b042b553
      commit-queue@webkit.org authored
      [Gtk] atk_text_get_text_at_offset() fails to provide the correct line for paragraphs in list items whose text wraps
      https://bugs.webkit.org/show_bug.cgi?id=83435
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-08-15
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Fix a logic error when checking if an object is a list marker.
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      (textForRenderer):
      
      Source/WebKit/gtk:
      
      Updated unit test to include a paragraph in a list item when testing atk_text_get_text_at_offset().
      
      * tests/testatk.c:
      (testWebkitAtkGetTextAtOffsetWithSpecialCharacters):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b042b553
  7. 13 Aug, 2012 1 commit
  8. 10 Aug, 2012 1 commit
    • mario@webkit.org's avatar
      [GTK] Broken implementation of AtkText and AtkEditableText for password fields · 17af9163
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93621
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Fix broken implementation of AtkText and AtkEditableText
      interfaces in the GTK port for password input fields.
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::stringValue): Call the new
      function passwordFieldValue() for password input fields.
      (WebCore::AccessibilityRenderObject::text): Ditto.
      (WebCore::AccessibilityRenderObject::textLength): Return the
      actual length of the password in the field for GTK, return -1
      otherwise (not to break current behavior in other platforms).
      (WebCore::AccessibilityRenderObject::doAXStringForRange): Don't
      early return for password fields in GTK (will rely on text()).
      (WebCore::AccessibilityRenderObject::passwordFieldValue): New, it
      returns the text being actually rendered for a password input
      field (normally a masked string) in GTK. It returns String() in
      the rest of platforms, to ensure we don't break anything there.
      (WebCore):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::passwordFieldValue): Default
      implementation of this new method, returning an empty string.
      (AccessibilityObject):
      
      Ensure the 'text-insert' and 'text-remove' signals for the AtkText
      interface are properly emitted for password input fields.
      
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::AXObjectCache::nodeTextChangePlatformNotification): Make
      sure we never emit the password value for an input field in plain
      text when inserting or removing text. Emit the masked text instead.
      
      Source/WebKit/gtk:
      
      Update unit test to ensure that password input fields behave
      as expected when inserting and removing characters in them.
      
      * tests/testatk.c:
      (testWebkitAtkTextChangedNotifications): Updated unit test to
      cover the special case of password input fields.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17af9163
  9. 09 Aug, 2012 1 commit
  10. 08 Aug, 2012 1 commit
  11. 18 Jun, 2012 1 commit
    • mario@webkit.org's avatar
      [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue · 3f542e93
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89226
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Implement webkitAccessibleValueGetMinimumIncrement() properly,
      doing something similar to what is done in AccessibilityObject's
      increment() and decrement() functions.
      
      Also, added missing bits to webkitAccessibleValueSetCurrentValue
      to make sure we check the new value against range limits.
      
      * accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
      (webkitAccessibleValueGetCurrentValue):
      (webkitAccessibleValueGetMaximumValue):
      (webkitAccessibleValueGetMinimumValue):
      (webkitAccessibleValueSetCurrentValue):
      (webkitAccessibleValueGetMinimumIncrement):
      
      Source/WebKit/gtk:
      
      Remove unnecesary functions incrementAccessibilityValue() and
      decrementAccessibilityValue() from DumpRenderTreeSupportGtk.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Tools:
      
      Implement increment() and decrement() functions in term of the AtkValue interface,
      instead of using DumpRenderTreeSupportGtk helper class.
      
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::intValue):
      (AccessibilityUIElement::minValue):
      (AccessibilityUIElement::maxValue):
      (alterCurrentValue):
      (AccessibilityUIElement::increment):
      (AccessibilityUIElement::decrement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f542e93
  12. 15 Jun, 2012 1 commit
    • rniwa@webkit.org's avatar
      Source/WebCore: The initial value of text-align should be start instead of -webkit-auto · af7f7a4e
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79914
      
      Reviewed by Tony Chang.
      
      Change the initial value of text-align CSS property from -webkit-auto to start as specified in
      http://www.w3.org/TR/css3-text/#text-align
      
      In editing, we have to coerce start and end to left and right for now because match-parent,
      which is the text-align value of li in UA stylesheet is going to result in the computed values of
      left as supposed to start by default, and this causes editing code not being able to remove
      text-align: left when computing typing styles and preserving styles.
      
      In the long term, we should detect this specific case and ignore match-parent but that seemed like
      too much work to be done in a single patch also because the test result improved because of this change.
      
      This behavior change is covered by existing regression tests.
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      (WebCore::getAttributeSetForAccessibilityObject):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): No longer supports TAAUTO since it's identical to TASTART.
      (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto. Parse -webkit-auto as start.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList): Replace TAAUTO by TASTART.
      * editing/EditingStyle.cpp:
      (WebCore):
      (WebCore::textAlignResolvingStartAndEnd): Coerce start and end into left and right based on the directionality
      for editing. Otherwise, we end up adding lots of text-align: left due to li's UA style rule having match-parent
      as the text alignment and its descendent inherits this style. We need to handle it better in the future
      since start and left or end and right are semantically different.
      (WebCore::EditingStyle::prepareToApplyAt):
      (WebCore::getPropertiesNotIn):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::textAlignmentForLine): Justified text is aligned at start by default.
      (WebCore::RenderBlock::updateLogicalWidthForAlignment):
      (WebCore::RenderBlock::startAlignedOffsetForLine):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
      * rendering/RenderListBox.cpp:
      (WebCore::itemOffsetForAlignment):
      * rendering/RenderMarquee.cpp:
      (WebCore::RenderMarquee::updateMarqueeStyle):
      * rendering/RenderRubyText.cpp:
      (WebCore::RenderRubyText::textAlignmentForLine):
      (WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::localCaretRect):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      
      LayoutTests: The default value of text-align should be start instead of -webkit-auto
      https://bugs.webkit.org/show_bug.cgi?id=79914
      
      Reviewed by Tony Chang.
      
      Rebaselined tests. For query-text-alignment.html, we now match start and end
      with justifyLeft and justifyRight, which appears to be consistent with Firefox for time being.
      
      * editing/execCommand/query-text-alignment-expected.txt:
      * editing/execCommand/script-tests/query-text-alignment.js:
      (queryTextAlignment):
      (selectFirstPosition):
      (selectMiddleOfHelloWorld):
      (runRangeTests):
      * editing/pasteboard/paste-4039777-fix-expected.txt:
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/list-item-text-align.html:
      * fast/css/text-align-initial-expected.html: Renamed from fast/css/text-align-webkit-auto-expected.html.
      * fast/css/text-align-initial.html: Ditto.
      * fast/events/ondrop-text-html-expected.txt:
      * platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-snowleopard/fast/lists/001-expected.png:
      * platform/chromium-mac-snowleopard/fast/lists/001-vertical-expected.png:
      * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/fast/lists/001-expected.txt:
      * platform/mac/fast/lists/001-vertical-expected.txt:
      * platform/mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/svg/css/getComputedStyle-basic-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af7f7a4e
  13. 12 Apr, 2012 1 commit
    • leviw@chromium.org's avatar
      Make AccessibilityObject::size non-virtual and fix platform accessibility code's LayoutUnit usage · dbc05944
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83803
      
      Reviewed by Eric Seidel.
      
      AccessibilityObject::size was virtual with a number of overloads, but all the implementations were
      redundant. Avoiding the virtual thunk and code duplication by declaring it non-virtual and only
      implementing it in AccessibilityObject.
      
      Also adding a pixelSnappedSize method that returns an IntSize, and using it in platform
      accessibility code.
      
      No new tests. No change in behavior.
      
      * accessibility/AccessibilityMenuListOption.h:
      (WebCore::AccessibilityMenuListOption::canHaveChildren):
      * accessibility/AccessibilityMenuListPopup.h:
      (WebCore::AccessibilityMenuListPopup::elementRect):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::size):
      (WebCore::AccessibilityObject::pixelSnappedSize):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore):
      * accessibility/AccessibilityRenderObject.h:
      (AccessibilityRenderObject):
      * accessibility/AccessibilitySlider.cpp:
      (WebCore):
      * accessibility/AccessibilitySlider.h:
      (AccessibilitySliderThumb):
      * accessibility/AccessibilityTableColumn.cpp:
      (WebCore):
      * accessibility/AccessibilityTableColumn.h:
      (AccessibilityTableColumn):
      * accessibility/AccessibilityTableHeaderContainer.cpp:
      (WebCore):
      * accessibility/AccessibilityTableHeaderContainer.h:
      (AccessibilityTableHeaderContainer):
      * accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
      (webkitAccessibleComponentGetExtents):
      * accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
      (webkitAccessibleImageGetImagePosition):
      (webkitAccessibleImageGetImageSize):
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      (-[WebAccessibilityObjectWrapper position]):
      (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbc05944
  14. 02 Apr, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r112851. · 82b1ac8f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/112851
      https://bugs.webkit.org/show_bug.cgi?id=82915
      
      Broke 3 Mac accessibility tests (Requested by enrica on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.cpp:
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::AXObjectCache::handleScrolledToAnchor):
      (WebCore):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::handleScrolledToAnchor):
      (WebCore):
      
      LayoutTests:
      
      * accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
      * accessibility/anchor-link-selection-and-focus.html: Removed.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82b1ac8f
    • mario@webkit.org's avatar
      in page anchor and keyboard navigation · 7842a230
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=17450
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Ensure that the position of the caret and the focused element
      get updated when following an anchor link.
      
      The implementation is moved from platform specific files out to
      AXObjectCache.cpp since it should be a cross-platform valid
      solution. However, the new code is currently activated for the Mac
      and GTK ports only, since the windows and chromium ports provide
      their own specific code, and removing it now might break things.
      
      Test: accessibility/anchor-link-selection-and-focus.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore):
      (WebCore::AXObjectCache::handleScrolledToAnchor): Cross-platform
      implementation of the fix, only activated for Mac and GTK for now.
      * accessibility/gtk/AXObjectCacheAtk.cpp: Removed the GTK-specific
      implementation of WebCore::AXObjectCache::handleScrolledToAnchor.
      * accessibility/mac/AXObjectCacheMac.mm: Removed the Mac-specific
      implementation of WebCore::AXObjectCache::handleScrolledToAnchor.
      
      LayoutTests:
      
      Added new test and expectations.
      
      * accessibility/anchor-link-selection-and-focus-expected.txt: Added.
      * accessibility/anchor-link-selection-and-focus.html: Added.
      * platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Added.
      * platform/chromium/test_expectations.txt: Skipped test for chromium.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7842a230
  15. 27 Mar, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Implement vw/vh/vmin (viewport sizes) from CSS3 Values and Units · c558b517
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27160
      
      Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-27
      Reviewed by Antti Koivisto.
      
      vw/vh/vmin are implemented as primitive length units. Added the parsing logic for these new units.
      New Length types such as ViewportRelativeWidth, ViewportRelativeHeight and ViewportRelativeMin are added for these length units
      and included the support for fetching the value of these relative units based on the current viewport size.
      
      The specification related to this implementation is http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
      
      Source/WebCore:
      
      Tests: css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html
             css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html
             css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html
             css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html
             css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html
             css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html
             css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp: Modified to support viewport relative Length types.
      (getAttributeSetForAccessibilityObject):
      * css/CSSComputedStyleDeclaration.cpp: Ditto.
      (WebCore::getPositionOffsetValue):
      (WebCore::getBorderRadiusCornerValues):
      (WebCore::getBorderRadiusCornerValue):
      (WebCore::getBorderRadiusShorthandValue):
      (WebCore::lineHeightFromStyle):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSGrammar.y: Added vw/vh/vmin support.
      * css/CSSParser.cpp: Parsing of relative units and creation of CSSPrimitiveValue.
      (WebCore::CSSParser::validUnit): Added vw/vh/vmin to the valid units.
      (WebCore::CSSParser::createPrimitiveNumericValue): Added vw/vh/vmin as valid primitive units.
      (WebCore::unitFromString):
      (WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitiveValue for vw/vh/vmin.
      (WebCore::CSSParser::detectNumberToken): Parsing the vw/vh/vmin tokens.
      * css/CSSPrimitiveValue.cpp:
      (WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vw/vh/vmin.
      (WebCore::unitCategory): Ditto.
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): Added support for vw/vh/vmin.
      (WebCore::CSSPrimitiveValue::customCssText): Ditto.
      (WebCore::CSSPrimitiveValue::viewportRelativeLength): Function to create the Length structure for the viewport-relative unit types.
      (WebCore):
      * css/CSSPrimitiveValue.h:
      (WebCore::CSSPrimitiveValue::isViewportRelativeLength): Checks whether the primitive value is ViewportRelative Lengths.
      (CSSPrimitiveValue):
      * css/CSSPrimitiveValue.idl: Added support for vw/vh/vmin.
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::convertToLength): Ditto.
      * css/CSSStyleApplyProperty.cpp: Applying relative viewport length units to the specific CSS property.
      (WebCore::ApplyPropertyLength::applyValue):
      (WebCore::ApplyPropertyBorderRadius::applyValue):
      (WebCore::ApplyPropertyFontSize::applyValue):
      (WebCore::ApplyPropertyLineHeight::applyValue):
      (WebCore::ApplyPropertyVerticalAlign::applyValue):
      * css/CSSStyleSelector.cpp: Added support for viewport relative units.
      * css/LengthFunctions.cpp: Calcuation of length value based on the current viewport size.
      (WebCore::miminumValueForLength):
      (WebCore::valueForLength):
      (WebCore::floatValueForLength):
      * css/LengthFunctions.h: Added new RenderView argument.
      (WebCore):
      * dom/Document.cpp:
      (WebCore::Document::pageSizeAndMarginsInPixels): Modified to support viewport relative Length types.
      (WebCore::Document::viewportSize): New function to fetch the current viewport size.
      (WebCore):
      * dom/Document.h: Ditto.
      (Document):
      * html/HTMLAreaElement.cpp: Modified to support viewport relative Length types.
      (WebCore::HTMLAreaElement::getRegion):
      * platform/Length.h:
      (WebCore::Length::isViewportRelative): To check the Length is of type ViewportRelative.
      (WebCore::Length::viewportRelativeLength): To get the relative value.
      * rendering/RenderBR.cpp: Modified to support viewport relative Length types.
      (WebCore::RenderBR::lineHeight):
      * rendering/RenderBlock.cpp: Ditto.
      (WebCore::RenderBlock::textIndentOffset):
      (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
      (WebCore::RenderBlock::lineHeight):
      * rendering/RenderBox.cpp: Ditto.
      (WebCore::RenderBox::reflectionOffset):
      (WebCore::RenderBox::paintBoxDecorations):
      (WebCore::RenderBox::clipRect):
      (WebCore::RenderBox::computeLogicalWidthInRegion):
      (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
      (WebCore::RenderBox::computeInlineDirectionMargins):
      (WebCore::RenderBox::computeContentLogicalHeightUsing):
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
      (WebCore::RenderBox::computeBlockDirectionMargins):
      (WebCore::RenderBox::computePositionedLogicalWidthUsing):
      (WebCore::RenderBox::computePositionedLogicalHeightUsing):
      (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
      (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
      * rendering/RenderBoxModelObject.cpp: Ditto.
      (WebCore::RenderBoxModelObject::relativePositionOffsetX):
      (WebCore::RenderBoxModelObject::relativePositionOffsetY):
      (WebCore::RenderBoxModelObject::paddingTop):
      (WebCore::RenderBoxModelObject::paddingBottom):
      (WebCore::RenderBoxModelObject::paddingLeft):
      (WebCore::RenderBoxModelObject::paddingRight):
      (WebCore::RenderBoxModelObject::paddingBefore):
      (WebCore::RenderBoxModelObject::paddingAfter):
      (WebCore::RenderBoxModelObject::paddingStart):
      (WebCore::RenderBoxModelObject::paddingEnd):
      (WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
      (WebCore::RenderBoxModelObject::calculateFillTileSize):
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      (WebCore::computeBorderImageSide):
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      (WebCore::RenderBoxModelObject::paintBorder):
      (WebCore::RenderBoxModelObject::paintBoxShadow):
      * rendering/RenderFlexibleBox.cpp: Ditto.
      (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
      (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
      (WebCore::RenderFlexibleBox::resolveFlexibleLengths):
      * rendering/RenderInline.cpp: Ditto.
      (WebCore::computeMargin):
      (WebCore::RenderInline::lineHeight):
      * rendering/RenderMenuList.cpp: Ditto.
      (WebCore::RenderMenuList::updateOptionsWidth):
      * rendering/RenderObject.cpp: Ditto.
      (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
      * rendering/RenderReplaced.cpp: Ditto.
      (WebCore::RenderReplaced::paint):
      * rendering/RenderScrollbarPart.cpp: Ditto.
      (WebCore::calcScrollbarThicknessUsing):
      (WebCore::RenderScrollbarPart::computeScrollbarWidth):
      (WebCore::RenderScrollbarPart::computeScrollbarHeight):
      * rendering/RenderTable.cpp: Ditto.
      (WebCore::RenderTable::computeLogicalWidth):
      (WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
      * rendering/RenderTableCell.cpp: Ditto.
      (WebCore::RenderTableCell::logicalHeightForRowSizing):
      * rendering/RenderTableSection.cpp: Ditto.
      (WebCore::RenderTableSection::calcRowLogicalHeight):
      * rendering/RenderText.h: Ditto.
      (WebCore::RenderText::marginLeft):
      (WebCore::RenderText::marginRight):
      * rendering/RenderThemeMac.mm: Ditto.
      (WebCore::RenderThemeMac::paintMenuListButtonGradients):
      * rendering/RenderView.h:
      (WebCore::RenderView::viewportSize):
      * rendering/RenderWidget.cpp: Ditto.
      (WebCore::RenderWidget::paint):
      * rendering/RootInlineBox.cpp: Ditto.
      (WebCore::RootInlineBox::verticalPositionForBox):
      * rendering/style/RenderStyle.cpp: Ditto.
      (WebCore::calcRadiiFor):
      (WebCore::RenderStyle::getRoundedBorderFor):
      * rendering/style/RenderStyle.h: Ditto.
      * rendering/svg/RenderSVGRoot.cpp: Ditto.
      (WebCore::resolveLengthAttributeForSVG):
      (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
      (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
      
      LayoutTests:
      
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle-expected.txt: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-getStyle.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute-expected.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-absolute.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh-expected.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vh.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute-expected.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-absolute.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin-expected.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vmin.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute-expected.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-absolute.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw-expected.html: Added.
      * css3/viewport-relative-lengths/css3-viewport-relative-lengths-vw.html: Added.
      * fast/dom/Window/window-properties-expected.txt:
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/mac/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/win/fast/dom/Window/window-properties-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c558b517
  16. 22 Mar, 2012 1 commit
  17. 19 Mar, 2012 1 commit
    • eric@webkit.org's avatar
      Fix more WTF header include paths in WebCore · 5088d7cc
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81602
      
      Reviewed by Martin Robinson.
      
      Chromium, Mac and Win already build w/o including wtf subdirectories
      in their include paths for WebCore/WebKit.  Gtk, Qt, and other ports
      should eventually do the same.  This patch fixes up a few loose
      wtf includes in these ports using some search/replace across WebCore.
      If the EWS bots pass this patch doesn't really need any other review.
      
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      * platform/KURL.cpp:
      * platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
      * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
      * platform/audio/gtk/AudioBusGtk.cpp:
      * platform/clutter/GRefPtrClutter.h:
      * platform/graphics/gstreamer/GRefPtrGStreamer.h:
      * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
      * platform/graphics/gstreamer/ImageGStreamerQt.cpp:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/graphics/gtk/ImageBufferGtk.cpp:
      * platform/graphics/pango/FontPango.cpp:
      * platform/graphics/qt/ImageBufferDataQt.h:
      * platform/graphics/wx/ImageBufferDataWx.h:
      * platform/gtk/ContextMenuGtk.cpp:
      * platform/gtk/ContextMenuItemGtk.cpp:
      * platform/gtk/FileSystemGtk.cpp:
      * platform/gtk/GOwnPtrGtk.h:
      * platform/gtk/GtkAuthenticationDialog.h:
      * platform/gtk/GtkPopupMenu.cpp:
      * platform/gtk/LanguageGtk.cpp:
      * platform/gtk/LocalizedStringsGtk.cpp:
      * platform/gtk/PopupMenuGtk.cpp:
      * platform/gtk/RenderThemeGtk.cpp:
      * platform/gtk/RenderThemeGtk.h:
      * platform/network/soup/GOwnPtrSoup.h:
      * platform/network/soup/ResourceRequestSoup.cpp:
      * platform/network/soup/ResourceResponseSoup.cpp:
      * platform/network/soup/SocketStreamHandle.h:
      * platform/network/soup/SoupURIUtils.cpp:
      * platform/text/TextEncoding.cpp:
      * platform/text/gtk/TextBreakIteratorGtk.cpp:
      * platform/text/gtk/TextCodecGtk.cpp:
      * platform/text/gtk/TextCodecGtk.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@111354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5088d7cc
  18. 17 Mar, 2012 1 commit
    • commit-queue@webkit.org's avatar
      move calc*Value functions out from Length (and platform) · 7336fc50
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80897
      
      Moving the Length calc*Value functions out from Length structure and also from /WebCore/platform/ folder.
      This helps to avoid the layering violation while length calculation. Otherwise layer violation can be avoided only by adding a virtual interface(bug 27160).
      
      Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-17
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      * GNUmakefile.list.am: Build system changes for adding new files.
      * Target.pri: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      (getAttributeSetForAccessibilityObject):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/LengthFunctions.h: Added. Moved calc*Value functions of Length.
      (WebCore):
      (WebCore::calculateMinimumValue):
      (WebCore::calculateValue):
      (WebCore::calculateFloatValue):
      * dom/Document.cpp:
      (WebCore::Document::pageSizeAndMarginsInPixels):
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::getRegion):
      * platform/CalculationValue.h:
      (WebCore::CalcExpressionLength::evaluate):
      * platform/Length.h: Removed the calc*Value functions from Length structure.
      (Length):
      (WebCore::Length::getFloatValue):
      (WebCore::Length::getIntValue):
      * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::setFilters):
      * platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
      (WebCore::CCRenderSurfaceFilters::apply):
      * platform/graphics/filters/FilterOperations.cpp:
      (WebCore::FilterOperations::getOutsets):
      * platform/graphics/transforms/PerspectiveTransformOperation.cpp:
      (WebCore::PerspectiveTransformOperation::blend):
      * platform/graphics/transforms/PerspectiveTransformOperation.h:
      (WebCore::PerspectiveTransformOperation::isIdentity):
      (WebCore::PerspectiveTransformOperation::apply):
      * platform/graphics/transforms/TranslateTransformOperation.h:
      (WebCore::TranslateTransformOperation::x):
      (WebCore::TranslateTransformOperation::y):
      (WebCore::TranslateTransformOperation::z):
      (WebCore::TranslateTransformOperation::isIdentity):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::paint):
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::layout):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::build):
      * rendering/FixedTableLayout.cpp:
      (WebCore::FixedTableLayout::layout):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::textIndentOffset):
      (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::reflectionOffset):
      (WebCore::RenderBox::clipRect):
      (WebCore::RenderBox::computeLogicalWidthInRegion):
      (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
      (WebCore::RenderBox::computeInlineDirectionMargins):
      (WebCore::RenderBox::computePercentageLogicalHeight):
      (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
      (WebCore::RenderBox::availableLogicalHeightUsing):
      (WebCore::RenderBox::computeBlockDirectionMargins):
      (WebCore::RenderBox::computePositionedLogicalWidthUsing):
      (WebCore::RenderBox::computePositionedLogicalHeightUsing):
      (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
      (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::relativePositionOffsetX):
      (WebCore::RenderBoxModelObject::relativePositionOffsetY):
      (WebCore::RenderBoxModelObject::paddingTop):
      (WebCore::RenderBoxModelObject::paddingBottom):
      (WebCore::RenderBoxModelObject::paddingLeft):
      (WebCore::RenderBoxModelObject::paddingRight):
      (WebCore::RenderBoxModelObject::paddingBefore):
      (WebCore::RenderBoxModelObject::paddingAfter):
      (WebCore::RenderBoxModelObject::paddingStart):
      (WebCore::RenderBoxModelObject::paddingEnd):
      (WebCore::RenderBoxModelObject::calculateFillTileSize):
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      (WebCore::computeBorderImageSide):
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
      (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
      (WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::layOutAxis):
      * rendering/RenderInline.cpp:
      (WebCore::computeMargin):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::perspectiveTransform):
      (WebCore::RenderLayer::perspectiveOrigin):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::computeTransformOrigin):
      (WebCore::RenderLayerBacking::computePerspectiveOrigin):
      * rendering/RenderMarquee.cpp:
      (WebCore::RenderMarquee::timerFired):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::updateOptionsWidth):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::computeReplacedLogicalWidth):
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::calcScrollbarThicknessUsing):
      (WebCore::RenderScrollbarPart::computeScrollbarWidth):
      (WebCore::RenderScrollbarPart::computeScrollbarHeight):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::computeLogicalWidth):
      (WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::logicalHeightForRowSizing):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::calcRowLogicalHeight):
      * rendering/RenderText.h:
      (WebCore::RenderText::marginLeft):
      (WebCore::RenderText::marginRight):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::verticalPositionForBox):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::applyTransform):
      (WebCore::calcRadiiFor):
      * rendering/style/RenderStyle.h:
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
      (WebCore::resolveLengthAttributeForSVG):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::currentViewBoxRect):
      (WebCore::SVGSVGElement::currentViewportSize):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::computeIntrinsicDimensions):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
      (WebKit::WebPopupMenu::setUpPlatformData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@111126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7336fc50
  19. 22 Feb, 2012 1 commit
  20. 08 Feb, 2012 1 commit
  21. 02 Feb, 2012 1 commit
  22. 01 Feb, 2012 1 commit
  23. 24 Jan, 2012 9 commits
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · adc13a8d
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      Don't expose functions for the ATK interfaces in header files.
      
      Expose only the initialization function for each interface, and
      use the generic functions from ATK interfaces where needed.
      
      * accessibility/gtk/WebKitAccessibleInterfaceAction.cpp:
      (webkitAccessibleActionDoAction): Made this function static.
      (webkitAccessibleActionGetNActions): Ditto.
      (webkitAccessibleActionGetDescription): Ditto.
      (webkitAccessibleActionGetKeybinding): Ditto.
      (webkitAccessibleActionGetName): Ditto.
      (webkitAccessibleActionInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceAction.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
      (webkitAccessibleComponentRefAccessibleAtPoint): Made this function static.
      (webkitAccessibleComponentGetExtents): Ditto.
      (webkitAccessibleComponentGrabFocus): Ditto.
      (webkitAccessibleComponentInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp:
      (webkitAccessibleDocumentGetAttributeValue): Made this function static.
      (webkitAccessibleDocumentGetAttributes): Ditto.
      (webkitAccessibleDocumentGetLocale): Ditto.
      (webkitAccessibleDocumentInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
      (webkitAccessibleEditableTextSetRunAttributes): Made this function static.
      (webkitAccessibleEditableTextSetTextContents): Ditto.
      (webkitAccessibleEditableTextInsertText): Ditto.
      (webkitAccessibleEditableTextCopyText): Ditto.
      (webkitAccessibleEditableTextCutText): Ditto.
      (webkitAccessibleEditableTextDeleteText): Ditto.
      (webkitAccessibleEditableTextPasteText): Ditto.
      (webkitAccessibleEditableTextInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp:
      (webkitAccessibleHyperlinkImplGetHyperlink): Made this function static.
      (webkitAccessibleHyperlinkImplInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp:
      (webkitAccessibleHypertextGetLink): Made this function static.
      (webkitAccessibleHypertextGetNLinks): Ditto.
      (webkitAccessibleHypertextGetLinkIndex): Ditto.
      (webkitAccessibleHypertextInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
      (webkitAccessibleImageGetImagePosition): Made this function static.
      (webkitAccessibleImageGetImageDescription): Ditto.
      (webkitAccessibleImageGetImageSize): Ditto.
      (webkitAccessibleImageInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceImage.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp:
      (webkitAccessibleSelectionAddSelection): Made this function static.
      (webkitAccessibleSelectionClearSelection): Ditto.
      (webkitAccessibleSelectionRefSelection): Ditto.
      (webkitAccessibleSelectionGetSelectionCount): Ditto.
      (webkitAccessibleSelectionIsChildSelected): Ditto.
      (webkitAccessibleSelectionRemoveSelection): Ditto.
      (webkitAccessibleSelectionSelectAllSelection): Ditto.
      (webkitAccessibleSelectionInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceTable.cpp:
      (webkitAccessibleTableRefAt): Made this function static.
      (webkitAccessibleTableGetIndexAt): Ditto.
      (webkitAccessibleTableGetColumnAtIndex): Ditto.
      (webkitAccessibleTableGetRowAtIndex): Ditto.
      (webkitAccessibleTableGetNColumns): Ditto.
      (webkitAccessibleTableGetNRows): Ditto.
      (webkitAccessibleTableGetColumnExtentAt): Ditto.
      (webkitAccessibleTableGetRowExtentAt): Ditto.
      (webkitAccessibleTableGetColumnHeader): Ditto.
      (webkitAccessibleTableGetRowHeader): Ditto.
      (webkitAccessibleTableGetCaption): Ditto.
      (webkitAccessibleTableGetColumnDescription): Ditto.
      (webkitAccessibleTableGetRowDescription): Ditto.
      (webkitAccessibleTableInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceTable.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      (textForRenderer): Made this function static.
      (textForObject): Ditto.
      (webkitAccessibleTextGetText): Ditto.
      (webkitAccessibleTextGetTextAfterOffset): Ditto.
      (webkitAccessibleTextGetTextAtOffset): Ditto.
      (webkitAccessibleTextGetTextBeforeOffset): Ditto.
      (webkitAccessibleTextGetCharacterAtOffset): Ditto.
      (webkitAccessibleTextGetCaretOffset): Ditto.
      (webkitAccessibleTextGetRunAttributes): Ditto.
      (webkitAccessibleTextGetDefaultAttributes): Ditto.
      (webkitAccessibleTextGetCharacterExtents): Ditto.
      (webkitAccessibleTextGetRangeExtents): Ditto.
      (webkitAccessibleTextGetCharacterCount): Ditto.
      (webkitAccessibleTextGetOffsetAtPoint): Ditto.
      (webkitAccessibleTextGetNSelections): Ditto.
      (webkitAccessibleTextGetSelection): Ditto.
      (webkitAccessibleTextAddSelection): Ditto.
      (webkitAccessibleTextSetSelection): Ditto.
      (webkitAccessibleTextRemoveSelection): Ditto.
      (webkitAccessibleTextSetCaretOffset): Ditto.
      (webkitAccessibleTextInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceText.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
      (webkitAccessibleValueGetCurrentValue): Made this function static.
      (webkitAccessibleValueGetMaximumValue): Ditto.
      (webkitAccessibleValueGetMinimumValue): Ditto.
      (webkitAccessibleValueSetCurrentValue): Ditto.
      (webkitAccessibleValueGetMinimumIncrement): Ditto.
      (webkitAccessibleValueInterfaceInit): Moved to the bottom.
      * accessibility/gtk/WebKitAccessibleInterfaceValue.h: Removed all
      functions but the one for initializing the interface from here.
      
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (webkitAccessibleGetName): Replace call to
      webkitAccessibleTextGetText with atk_text_get_text.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adc13a8d
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · 5c96677d
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      Fix coding style in the ATK AccessibilityObject wrapper.
      
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
      (webkitAccessibleGetName):
      (webkitAccessibleGetDescription):
      (webkitAccessibleGetParent):
      (webkitAccessibleGetNChildren):
      (webkitAccessibleRefChild):
      (webkitAccessibleGetIndexInParent):
      (webkitAccessibleGetAttributes):
      (atkRole):
      (webkitAccessibleGetRole):
      (setAtkStateSetFromCoreObject):
      (webkitAccessibleRefStateSet):
      (webkitAccessibleRefRelationSet):
      (webkitAccessibleInit):
      (webkitAccessibleFinalize):
      (webkit_accessible_class_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c96677d
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · 970eaf34
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      Cleanup the list of includes in WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Removes
      'include' lines that are no longer needed after the refactor.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      970eaf34
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · cd9f1b3c
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      New files for the implementation of the AtkTable interface,
      containing the related code from WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleInterfaceTable.cpp: Added.
      (core):
      (cell):
      (cellIndex):
      (cellAtIndex):
      (webkitAccessibleTableInterfaceInit):
      (webkitAccessibleTableRefAt):
      (webkitAccessibleTableGetIndexAt):
      (webkitAccessibleTableGetColumnAtIndex):
      (webkitAccessibleTableGetRowAtIndex):
      (webkitAccessibleTableGetNColumns):
      (webkitAccessibleTableGetNRows):
      (webkitAccessibleTableGetColumnExtentAt):
      (webkitAccessibleTableGetRowExtentAt):
      (webkitAccessibleTableGetColumnHeader):
      (webkitAccessibleTableGetRowHeader):
      (webkitAccessibleTableGetCaption):
      (webkitAccessibleTableGetColumnDescription):
      (webkitAccessibleTableGetRowDescription):
      * accessibility/gtk/WebKitAccessibleInterfaceTable.h: Added.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
      related to the implementation of the AtkTable interface.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleInterfaceTable.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd9f1b3c
    • mario@webkit.org's avatar
      Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources · 987d7371
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76868
      
      Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-24
      Reviewed by Yury Semikhatsky.
      
      Configurations of (hopefully) all build systems are fixed.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/CodeGeneratorInspector.py:
      (dash_to_camelcase):
      (InspectorFrontend_h):
      (InspectorBackendDispatcher_h):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      987d7371
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · 980269e5
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      New files for the implementation of the AtkValue interface,
      containing the related code from WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleInterfaceValue.cpp: Added.
      (core):
      (webkitAccessibleValueInterfaceInit):
      (webkitAccessibleValueGetCurrentValue):
      (webkitAccessibleValueGetMaximumValue):
      (webkitAccessibleValueGetMinimumValue):
      (webkitAccessibleValueSetCurrentValue):
      (webkitAccessibleValueGetMinimumIncrement):
      * accessibility/gtk/WebKitAccessibleInterfaceValue.h: Added.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
      related to the implementation of the AtkValue interface.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleInterfaceValue.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      980269e5
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · 7e5931df
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      New files for the implementation of the AtkSelection interface,
      containing the related code from WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp: Added.
      (core):
      (listObjectForSelection):
      (optionFromList):
      (optionFromSelection):
      (webkitAccessibleSelectionInterfaceInit):
      (webkitAccessibleSelectionAddSelection):
      (webkitAccessibleSelectionClearSelection):
      (webkitAccessibleSelectionRefSelection):
      (webkitAccessibleSelectionGetSelectionCount):
      (webkitAccessibleSelectionIsChildSelected):
      (webkitAccessibleSelectionRemoveSelection):
      (webkitAccessibleSelectionSelectAllSelection):
      * accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Added.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
      related to the implementation of the AtkSelection interface.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleInterfaceSelection.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e5931df
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · da3e6080
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      New files for the implementation of the AtkImage interface,
      containing the related code from WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleInterfaceImage.cpp: Added.
      (core):
      (webkitAccessibleImageInterfaceInit):
      (webkitAccessibleImageGetImagePosition):
      (webkitAccessibleImageGetImageDescription):
      (webkitAccessibleImageGetImageSize):
      * accessibility/gtk/WebKitAccessibleInterfaceImage.h: Added.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
      related to the implementation of the AtkImage interface.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleInterfaceImage.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da3e6080
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · 70243534
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      New files for the implementation of the AtkHypertext interface,
      containing the related code from WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp: Added.
      (core):
      (webkitAccessibleHypertextInterfaceInit):
      (webkitAccessibleHypertextGetLink):
      (webkitAccessibleHypertextGetNLinks):
      (webkitAccessibleHypertextGetLinkIndex):
      * accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Added.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
      related to the implementation of the AtkHypertext interface.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleInterfaceHypertext.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70243534