1. 04 Sep, 2012 39 commits
    • commit-queue@webkit.org's avatar
      [GTK] Crash in AccessibilityObject::accessibilityPlatformIncludesObject() · 366bc8b8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95740
      
      Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-04
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Added sanity check to be sure we have a render object prior to seeing if
      said object is an anonymous block.
      
      Testing via unit test because a non-flaky layout test crasher could not
      be found.
      
      * accessibility/gtk/AccessibilityObjectAtk.cpp:
      (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
      Sanity check for render object added.
      
      Source/WebKit/gtk:
      
      Updated unit test.
      
      * tests/testatk.c:
      (testWebkitAtkComboBox): Added checks that the menu popup in a combo box
      has 0 links and, more importantly, that checking doesn't result in a crash.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      366bc8b8
    • ojan@chromium.org's avatar
      Elide test names when running new-run-webkit-tests · 4384ece1
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95626
      
      Patch by Tony Chang <tony@chromium.org> on 2012-09-04
      Reviewed by Dirk Pranke.
      
      When the test name exceeds the number of terminal columns, it leaves
      text on the screen. Avoid this by eliding the test name when running
      tests. This is similar to what ninja does when compiling.
      
      * Scripts/webkitpy/layout_tests/views/metered_stream.py:
      (MeteredStream):
      (MeteredStream.number_of_columns): Helper method to get number of
      terminal columns. Won't work on Win32 python, but meh.
      * Scripts/webkitpy/layout_tests/views/printing.py:
      (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
      because stderr appears to be ascii only.
      (Printer.print_started_test): Route through _test_status_line.
      (Printer.print_finished_test): Route through _test_status_line.
      (Printer._print_test_trace): Route through _test_status_line.
      (Printer._print_baseline): Route through _test_status_line.
      * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
      (test_test_status_line): Test for _test_status_line.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4384ece1
    • commit-queue@webkit.org's avatar
      Automatic features should work in sandboxed iframes if "allow-scripts" flag is set · 5fa0b77a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93961
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-04
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Allow automatic features (video autoplay and form control
      autofocus) in a sandboxed iframe that has "allow-scripts"
      flag set. This behavior is according to the latest
      specification at:
      http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
      
      This sandboxed automatic features browsing context flag is
      relaxed by the same keyword as scripts, because when
      scripts are enabled these features are trivially possible
      anyway, and it would be unfortunate to force authors to
      use script to do them when sandboxed rather than allowing
      them to use the declarative features.
      
      Tests: fast/forms/autofocus-in-sandbox-with-allow-scripts.html
             media/auto-play-in-sandbox-with-allow-scripts.html
      
      * dom/SecurityContext.cpp:
      (WebCore::SecurityContext::parseSandboxPolicy):
      
      LayoutTests:
      
      Add layout tests to check that automatic features (video
      autoplay and form control autofocus) are allowed / working
      in sandboxed iframes if the "allow-scripts" flag is set.
      This behavior is according to the latest specification at:
      http://dev.w3.org/html5/spec/browsers.html#attr-iframe-sandbox-allow-same-origin
      
      The tests to check that automatic features are blocked in
      sandboxed iframes have been removed since they relied on
      the "allow-scripts" flag to work.
      
      * fast/forms/autofocus-in-sandbox-with-allow-scripts-expected.txt: Added.
      * fast/forms/autofocus-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/fast/forms/no-autofocus-in-sandbox.html.
      * fast/forms/no-autofocus-in-sandbox-expected.txt: Removed.
      * media/auto-play-in-sandbox-with-allow-scripts-expected.txt: Added.
      * media/auto-play-in-sandbox-with-allow-scripts.html: Renamed from LayoutTests/media/no-auto-play-in-sandbox.html.
      * media/no-auto-play-in-sandbox-expected.txt: Removed.
      * media/resources/auto-play-in-sandbox-with-allow-scripts-iframe.html: Added.
      * media/resources/no-auto-play-in-sandbox-iframe.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fa0b77a
    • commit-queue@webkit.org's avatar
      Register scrolling layers with ScrollingCoordinator · c032831a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78862
      
      Patch by Sami Kyostila <skyostil@google.com> on 2012-09-04
      Reviewed by James Robinson.
      
      In order to allow scrollable child layers to be scrolled off the main
      thread, register them with the ScrollingCoordinator. These layers are
      also removed from the non-fast scrollable region.
      
      Whenever the scroll offset or other scroll geometry related attribute of
      a compositor scrolled layer changes, the ScrollingCoordinator is
      informed to allow it to update its internal representation of the
      scrollable layer.
      
      No tests because the ScrollingCoordinator is currently not testable.
      
      * page/scrolling/ScrollingCoordinator.cpp:
      (WebCore::computeNonFastScrollableRegion): Composited scrolling layers
      can be scrolled off the main thread.
      (WebCore):
      (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
      Callback to ScrollingCoordinator about changes the composited scrolling layers.
      * page/scrolling/ScrollingCoordinator.h:
      (WebCore):
      (ScrollingCoordinator):
      * page/scrolling/ScrollingCoordinatorNone.cpp:
      (WebCore):
      (WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
      * platform/ScrollableArea.h:
      (WebCore::ScrollableArea::usesCompositedScrolling):
      * rendering/RenderLayer.cpp:
      (WebCore):
      (WebCore::RenderLayer::usesCompositedScrolling):
      * rendering/RenderLayer.h:
      (RenderLayer):
      (WebCore::RenderLayer::usesCompositedScrolling):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
      (WebCore::RenderLayerBacking::updateScrollingLayers):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::scrollingLayerDidChange):
      (WebCore):
      * rendering/RenderLayerCompositor.h:
      (RenderLayerCompositor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c032831a
    • mhahnenberg@apple.com's avatar
      Remove uses of ClassInfo from SpeculativeJIT::compileObjectOrOtherLogicalNot · db8065f2
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95510
      
      Reviewed by Oliver Hunt.
      
      More refactoring to get rid of ClassInfo checks in the DFG.
      
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGSpeculativeJIT.h:
      (SpeculativeJIT):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
      (JSC::DFG::SpeculativeJIT::compileLogicalNot):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
      (JSC::DFG::SpeculativeJIT::compileLogicalNot):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db8065f2
    • tony@chromium.org's avatar
      Elide test names when running new-run-webkit-tests · 3ca57679
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95626
      
      Reviewed by Dirk Pranke.
      
      When the test name exceeds the number of terminal columns, it leaves
      text on the screen. Avoid this by eliding the test name when running
      tests. This is similar to what ninja does when compiling.
      
      * Scripts/webkitpy/layout_tests/views/metered_stream.py:
      (MeteredStream):
      (MeteredStream.number_of_columns): Helper method to get number of
      terminal columns. Won't work on Win32 python, but meh.
      * Scripts/webkitpy/layout_tests/views/printing.py:
      (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
      because stderr appears to be ascii only.
      (Printer.print_started_test): Route through _test_status_line.
      (Printer.print_finished_test): Route through _test_status_line.
      (Printer._print_test_trace): Route through _test_status_line.
      (Printer._print_baseline): Route through _test_status_line.
      * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
      (test_test_status_line): Test for _test_status_line.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ca57679
    • commit-queue@webkit.org's avatar
      [chromium] Do not allow infinite pending frames in CCFrameRateController · 341b68b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94254
      
      Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
      Reviewed by James Robinson.
      
      Removes support for infinite pending frames in CCFrameRateController
      if swap acks are available.
      
      Functionality covered by existing tests.
      
      * platform/graphics/chromium/cc/CCFrameRateController.cpp:
      (WebCore::CCFrameRateController::CCFrameRateController):
      (WebCore::CCFrameRateController::setMaxFramesPending):
      (WebCore::CCFrameRateController::setSwapBuffersCompleteSupported):
      (WebCore):
      (WebCore::CCFrameRateController::onTimerTick):
      (WebCore::CCFrameRateController::didBeginFrame):
      (WebCore::CCFrameRateController::didFinishFrame):
      * platform/graphics/chromium/cc/CCFrameRateController.h:
      (CCFrameRateController):
      * platform/graphics/chromium/cc/CCScheduler.cpp:
      (WebCore::CCScheduler::setSwapBuffersCompleteSupported):
      (WebCore):
      * platform/graphics/chromium/cc/CCScheduler.h:
      (CCScheduler):
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::initializeRendererOnImplThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      341b68b6
    • commit-queue@webkit.org's avatar
      [GTK] Print API missing documentation when generating gtkdoc · 0b338471
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95703
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
      Reviewed by Carlos Garcia Campos.
      
      Print out API missing documentation when generating gtkdoc. This makes it
      easier to fix documentation errors.
      
      * gtk/generate-gtkdoc:
      (print_missing_api): Added.
      (generate_doc): Inline the rebase step, since it now reports an error
      when you try to rebase without generating documentation first.
      * gtk/gtkdoc.py:
      (GTKDoc.rebase_installed_docs): Raise an error when rebasing without
      generating documentation first to enable a small cleanup at the caller.
      (GTKDoc.api_missing_documentation): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b338471
    • timothy_horton@apple.com's avatar
      ASSERTion failure when SVG element is removed from document and readded · 85558650
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95517
      <rdar://problem/12175583>
      
      Reviewed by Brady Eidson.
      
      Previously, SVG animations would cease to animate when their parent
      <svg> element was removed and re-added to the document.
      
      Instead, to match Firefox and Opera, we should continue the animation
      with the same beginTime (i.e. the animation continues as if it had never
      been removed from the document).
      
      Test: svg/animations/reinserting-svg-into-document.html
      
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::insertedInto): Don't call begin() on an already-started SMILTimeContainer().
      * svg/animation/SMILTimeContainer.cpp:
      (WebCore::SMILTimeContainer::isStarted): Added.
      * svg/animation/SMILTimeContainer.h: Add isStarted().
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::insertedInto): Always reschedule SVGSMILElements with
      their parent SMILTimeContainer when they are inserted into the document, otherwise
      they are lost (and never again update) when their subtree is removed and then
      readded to the document.
      
      Add a test that ensures that removing an SVG element from the document
      and readding it continues SMIL animations.
      
      * svg/animations/reinserting-svg-into-document.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85558650
    • scheib@chromium.org's avatar
      [Chromium] Allow asyncronous response of pointer lock requests in layout tests. · 34be567b
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95628
      
      Reviewed by James Robinson.
      
      Tools:
      
      Future tests need the ability to respond asynchronously that
      pointer lock requests have been accepted or rejected. This patch
      adds the following:
          testRunner.setPointerLockWillRespondAsynchronously();
          testRunner.didAcquirePointerLock();
          testRunner.didNotAcquirePointerLock();
      
      Tested in existing test:
          pointerlockchange-pointerlockerror-events.html
      
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      (DRTTestRunner::DRTTestRunner):
      (DRTTestRunner::didAcquirePointerLock):
      (DRTTestRunner::didNotAcquirePointerLock):
      (DRTTestRunner::setPointerLockWillRespondAsynchronously):
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (DRTTestRunner):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::requestPointerLock):
      (WebViewHost::didAcquirePointerLock):
      (WebViewHost::didNotAcquirePointerLock):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      (WebViewHost::setPointerLockWillRespondAsynchronously):
      
      LayoutTests:
      
      Add testing for testRunner.setPointerLockWillRespondAsynchronously().
      
      * pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
      * pointer-lock/pointerlockchange-pointerlockerror-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34be567b
    • commit-queue@webkit.org's avatar
      [CSS Regions] Destroying a render named flow thread without unregistering... · 9e41565f
      commit-queue@webkit.org authored
      [CSS Regions] Destroying a render named flow thread without unregistering left-over content nodes triggered an assertion.
      https://bugs.webkit.org/show_bug.cgi?id=95645
      
      Patch by Andrei Bucur <abucur@adobe.com> on 2012-09-04
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      This patch cleans up the render named flow thread before destruction by unregistering left-over content nodes.
      
      Tests: fast/regions/moved-content-node-crash.html
      
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
      
      LayoutTests:
      
      Simple test case that triggers an ASSERT in debug mode and causes a crash in release.
      The ASSERT appears in RenderFlowThreadController::unregisterNamedFlowContentNode
      ASSERT(it != m_mapNamedFlowContentNodes.end());
      
      It happens because when a content node is added to an iframe document and then moved back, the iframe's RenderNamedFlowThread is destroyed
      without calling unregisterNamedFlowContentNode on the node. This triggers the before mentioned assertion after a lazyAttach and a detach
      in the parent document.
      
      * fast/regions/moved-content-node-crash-expected.txt: Added.
      * fast/regions/moved-content-node-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e41565f
    • peter@chromium.org's avatar
      [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and... · 11128bf8
      peter@chromium.org authored
      [chromium] OpenTypeVerticalData.cpp in both webcore_remaining and webcore_platform seems to break incremental linking on Windows Chromium
      https://bugs.webkit.org/show_bug.cgi?id=95744
      
      Patch by Koji Ishii <kojiishi@gmail.com> on 2012-09-04
      Unreviewed build fix, verified by Scott Graham.
      
      The addition of 'platform/graphics/opentype/*' to webcore_platform in WebCore.gyp was redundant
      because '/opentype/' was already included to webcore_remaining.
      It was not only redundant but also breaks incremental linking.
      
      No new tests are required because no behavior changes.
      
      Patch by Koji Ishii <kojiishi@gmail.com> on 2012-09-04
      
      * WebCore.gyp/WebCore.gyp: Removed platform/graphics/opentype/* from webcore_platform.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11128bf8
    • commit-queue@webkit.org's avatar
      [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection · b0986158
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95747
      
      PR199729
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-04
      Reviewed by Rob Buis.
      Internally Reviewed by Joe Mason.
      
      If the browser has never saved a secure protocol cookie in its mapping before,
      and it tries to set and retreive a secure cookie over a non-secure
      protocol, it will not show up because the link between the secure and
      non-secure mapping isn't created until a cookie (sent through secure) is set.
      
      The fix is to also check for the linkage in getRawCookies. Note that we cannot
      map the secure CookieMap to the non-secure one because getRawCookies is a const
      function.
      
      Manually tested using our Browser Test suite.
      
      * platform/blackberry/CookieManager.cpp:
      (WebCore::CookieManager::getRawCookies):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0986158
    • philn@webkit.org's avatar
      [GStreamer] 0.11 build breaks due to rename of gst_message_new_duration · 1dd0161e
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95751
      
      Reviewed by Martin Robinson.
      
      In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
      gst_message_new_duration was renamed to
      gst_message_new_duration_changed.
      
      However the only place where we used this is in the HTTP source
      element and only if appsrc < 0.10.27 is used at runtime. In the
      case of GStreamer 1.0 this condition will be always false so we
      can disable this code at build time.
      
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      (StreamingClient::didReceiveResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dd0161e
    • vsevik@chromium.org's avatar
      Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event · ad981b04
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93443
      
      Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-04
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Added "regionLayoutUpdate" event to the protocol.
      
      Removed "getFlowByName" from protocol.
      
      The front-end keeps in sync the requested Named Flow Collections.
      
      Modified existing test: inspector/styles/protocol-css-regions-commands.html
      
      * dom/NamedFlowCollection.cpp:
      (WebCore::NamedFlowCollection::ensureFlowWithName):
      (WebCore::NamedFlowCollection::discardNamedFlow):
      * inspector/Inspector.json:
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::didCreateNamedFlow):
      (WebCore::InspectorCSSAgent::willRemoveNamedFlow):
      (WebCore):
      (WebCore::InspectorCSSAgent::didUpdateRegionLayout):
      (WebCore::InspectorCSSAgent::getNamedFlowCollection):
      (WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
      * inspector/InspectorCSSAgent.h:
      (InspectorCSSAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
      (WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
      (WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::didCreateNamedFlow):
      (WebCore::InspectorInstrumentation::willRemoveNamedFlow):
      (WebCore):
      (WebCore::InspectorInstrumentation::didUpdateRegionLayout):
      * inspector/front-end/CSSStyleModel.js:
      (WebInspector.CSSStyleModel):
      (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
      (WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
      (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
      (WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
      (WebInspector.CSSStyleModel.prototype._namedFlowCreated):
      (WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
      (WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
      (WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
      (WebInspector.CSSDispatcher.prototype.namedFlowCreated):
      (WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
      (WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
      (WebInspector.NamedFlow):
      (WebInspector.NamedFlowCollection):
      (WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
      (WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
      (WebInspector.NamedFlowCollection.prototype.flowByName):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):
      
      LayoutTests:
      
      Validate "regionLayoutUpdate" event.
      
      * inspector/styles/protocol-css-regions-commands-expected.txt:
      * inspector/styles/protocol-css-regions-commands.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad981b04
    • commit-queue@webkit.org's avatar
      Fix IDL dependency generation correctly · 533412d7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95730
      
      Patch by Jonathan Liu <net147@gmail.com> on 2012-09-04
      Reviewed by Csaba Osztrogonác.
      
      IDL dependency generation is still not working after
      https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
      added after the filename in an echo command end up being added to the
      file which isn't handled correctly by preprocess-idls.pl. The problem
      is fixed by removing the space after the filename.
      
      * DerivedSources.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      533412d7
    • commit-queue@webkit.org's avatar
      [Stable] [GTK] Crash in WebCore::HTMLSelectElement::selectedIndex · 61d00bd3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95618
      
      Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Make sure we only emit the the signal for menu lists and list
      boxes rendered from actual HTML select elements.
      
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::notifyChildrenSelectionChange): We support accessibility
      ListBoxes and MenuLists only here, assuming they represent HTML
      select elements, which might be not always true (e.g. ARIA). Thus,
      check if that condition is true, early returning in other case.
      
      LayoutTests:
      
      New layout test to ensure we don't crash with ATK notifications
      anymore when changing the selection in an ARIA listbox.
      
      * platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
      * platform/gtk/accessibility/aria-listbox-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d00bd3
    • commit-queue@webkit.org's avatar
      [Cairo] [TextureMapper] Assertion failure in TextureMapperGL · aa1bfb9c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95713
      
      Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
      Reviewed by Noam Rosenthal.
      
      Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
      This is important because TextureMapperGL uses the platform context to perform hashing.
      
      No new tests. This is covered by existing accelerated compositing tests.
      
      * platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
      (WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
      when getting the platform context for private GraphicsContext3DPrivates that render
      to the currently active context.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa1bfb9c
    • commit-queue@webkit.org's avatar
      [EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash · 96d3a434
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86961
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Add ecore_x initialisation check before calling ecore_x_bell
      to avoid crashes when X server is not running.
      
      * platform/efl/SoundEfl.cpp:
      (WebCore::systemBeep):
      
      LayoutTests:
      
      Unskipped two layout tests that were crashing.
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96d3a434
    • commit-queue@webkit.org's avatar
      [EFL][WK2] CSS3 Media Queries functionality is broken · 5f30dea0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95680
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      In WK2, WebProcess doesn't have access to ewk_view evas object.
      Methods that get screen rect or screen depth either return incorrect value or crash.
      This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
      to get screen rectangle or color depth of the screen.
      
      * platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
      * platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration
      (WebCore):
      * platform/efl/PlatformScreenEfl.cpp:
      (WebCore):
      (WebCore::screenHorizontalDPI):
      (WebCore::screenVerticalDPI):
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      
      LayoutTests:
      
      Unskipped passing CSS3 Media Query tests.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f30dea0
    • commit-queue@webkit.org's avatar
      .: [EFL] Context menu restore. · 61e24698
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74179
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
      Reviewed by Gyuyoung Kim.
      
      Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
      approach, the same as used in WebKit2.
      
      * Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port
      
      Source/WebCore: [EFL] Context menu restore.
      https://bugs.webkit.org/show_bug.cgi?id=74179
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
      Reviewed by Gyuyoung Kim.
      
      Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
      approach, the same as used in WebKit2.
      
      * PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1
      
      Source/WebKit: [EFL] Context menu restore.
      https://bugs.webkit.org/show_bug.cgi?id=74179
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
      Reviewed by Gyuyoung Kim.
      
      Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
      approach, the same as used in WebKit2.
      
      * PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list.
      
      Source/WebKit/efl: [EFL] Context menu restore.
      https://bugs.webkit.org/show_bug.cgi?id=74179
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
      Reviewed by Gyuyoung Kim.
      
      Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
      approach, the same as used in WebKit2.
      
      * WebCoreSupport/ContextMenuClientEfl.cpp: Added.
      (WebCore):
      (WebCore::ContextMenuClientEfl::contextMenuDestroyed):
      (WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
      (WebCore::ContextMenuClientEfl::contextMenuItemSelected):
      (WebCore::ContextMenuClientEfl::downloadURL):
      (WebCore::ContextMenuClientEfl::lookUpInDictionary):
      (WebCore::ContextMenuClientEfl::speak):
      (WebCore::ContextMenuClientEfl::isSpeaking):
      (WebCore::ContextMenuClientEfl::stopSpeaking):
      (WebCore::ContextMenuClientEfl::searchWithGoogle):
      * WebCoreSupport/ContextMenuClientEfl.h: Added.
      (WebCore):
      (ContextMenuClientEfl):
      * ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.
      (ewk_context_menu_destroy): Added freeing context menu.
      (ewk_context_menu_new): Added filling ewk_contextmenu list.
      (ewk_context_menu_item_append):
      * ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (_ewk_view_priv_new):
      (_ewk_view_priv_del):
      (ewk_view_context_menu_forward_event):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61e24698
    • vsevik@chromium.org's avatar
      Web Inspector: Skip inspector WebGL tests where WebGL is disabled · c42e66cc
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95733
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
      Reviewed by Vsevolod Vlasov.
      
      This is to update Skipped and TestExpectations files.
      
      * platform/efl/TestExpectations:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c42e66cc
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of failing tests · c58dfc2f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95725
      
      Unreviewed gardening.
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-04
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c58dfc2f
    • commit-queue@webkit.org's avatar
      Web Inspector: [WebGL] Bugfix: wrong texture binding target in replay for 3D textures · 17df9dac
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95687
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
      Reviewed by Vsevolod Vlasov.
      
      gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.
      
      * inspector/InjectedScriptWebGLModuleSource.js:
      (.):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17df9dac
    • allan.jensen@nokia.com's avatar
      Allow child-frame content in hit-tests. · 8083183d
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95204
      
      .:
      
      Reviewed by Antonio Gomes.
      
      Update exported symbols.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      Reviewed by Antonio Gomes.
      
      Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
      it is now handled by the hit test itself controlled by the AllowChildFrameContent
      flag in HitTestRequest.
      
      Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
             touchadjustment/iframe-boundary.html
      
      * WebCore.exp.in:
      * WebCore.order:
      * dom/Document.cpp:
      (WebCore::Document::nodesFromRect):
      * dom/Document.h:
      (Document):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::hitTestResultAtPoint):
      * rendering/HitTestRequest.h:
      (WebCore::HitTestRequest::allowChildFrameContent):
      (WebCore::HitTestRequest::childFrameHitTest):
      (WebCore::HitTestRequest::testChildFrameScrollBars):
      * rendering/RenderFrameBase.cpp:
      (WebCore::RenderFrameBase::nodeAtPoint):
      (WebCore):
      * rendering/RenderFrameBase.h:
      (RenderFrameBase):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::hitTest):
      * testing/Internals.cpp:
      (WebCore::Internals::nodesFromRect):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Source/WebKit2:
      
      Reviewed by Antonio Gomes.
      
      Update symbols for the Windows build-system.
      
      * win/WebKit2.def:
      * win/WebKit2CFLite.def:
      
      LayoutTests:
      
      Reviewed by Antonio Gomes.
      Touch-Adjustment test by Kevin Ellis
      
      Two new tests for hit-testing child frame content. One for testing it as an option to
      nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.
      
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
      * fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
      * fast/dom/nodesFromRect/resources/child-frame.html: Added.
      * fast/dom/nodesFromRect/resources/nodesFromRect.js:
      (check):
      (checkShadowContent):
      (checkRect):
      (nodesFromRectAsString):
      * touchadjustment/iframe-boundary-expected.txt: Added.
      * touchadjustment/iframe-boundary.html: Added.
      * touchadjustment/resources/inner-content-page.html: Added.
      * touchadjustment/resources/inner-navigation-frame.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8083183d
    • vsevik@chromium.org's avatar
      Unreviewed tests fix. · fc2c7c8e
      vsevik@chromium.org authored
      * http/tests/inspector/workspace-test.js:
      * inspector/debugger/dynamic-script-tag-expected.txt:
      * inspector/debugger/dynamic-script-tag.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc2c7c8e
    • commit-queue@webkit.org's avatar
      [EFL] Fix build error in NetworkStateNotifierEfl.cpp · 40aaeec9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95724
      
      Unreviewed EFL build fix.
      
      Make sure <sys/socket.h> is included before
      <linux/netlink.h> to fix build errors on some
      systems (e.g. Ubuntu 11.10).
      
      No new tests, no behavior change.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-04
      
      * platform/network/efl/NetworkStateNotifierEfl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40aaeec9
    • vsevik@chromium.org's avatar
      Web Inspector: Create JavaScriptSources based on network resources. · 192582ad
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95352
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
      RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
      Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
      Removed rawSourceCode as it was not needed anymore.
      
      Tests: inspector/debugger/network-uisourcecode-provider.html
             inspector/debugger/resource-script-mapping.html
      
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * inspector/compile-front-end.py:
      * inspector/front-end/CompilerScriptMapping.js:
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
      * inspector/front-end/JavaScriptSource.js:
      (WebInspector.JavaScriptSource):
      * inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
      (WebInspector.NetworkUISourceCodeProvider):
      (WebInspector.NetworkUISourceCodeProvider.prototype._populate):
      (WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
      (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
      (WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
      (WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
      (WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
      (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
      (WebInspector.NetworkUISourceCodeProvider.prototype._reset):
      * inspector/front-end/RawSourceCode.js:
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping):
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
      (WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
      (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
      (WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
      (WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
      (WebInspector.ResourceScriptMapping.prototype._reset):
      * inspector/front-end/ScriptSnippetModel.js:
      (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
      (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
      (WebInspector.SnippetJavaScriptSource):
      * inspector/front-end/UISourceCode.js:
      (WebInspector.UISourceCode):
      (WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
      (WebInspector.UISourceCode.prototype.setSourceMapping):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
      * inspector/front-end/inspector.html:
      * inspector/front-end/inspector.js:
      
      LayoutTests:
      
      Removed raw-source-code.html test as RawSourceCode was removed by this patch.
      Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
      Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
      Updated dynamic-script-tag.html to better match expected behavior.
      
      * http/tests/inspector/network/network-request-revision-content.html:
      * http/tests/inspector/workspace-test.js: Added.
      (initialize_WorkspaceTest.InspectorTest.createWorkspace):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
      (initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
      (initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
      (initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
      (initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
      (initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
      (initialize_WorkspaceTest):
      * inspector/debugger/breakpoint-manager.html:
      * inspector/debugger/dynamic-script-tag-expected.txt:
      * inspector/debugger/dynamic-script-tag.html:
      * inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
      * inspector/debugger/network-uisourcecode-provider.html: Added.
      * inspector/debugger/raw-source-code-expected.txt: Removed.
      * inspector/debugger/raw-source-code.html: Removed.
      * inspector/debugger/resource-script-mapping-expected.txt: Added.
      * inspector/debugger/resource-script-mapping.html: Added.
      * inspector/debugger/scripts-panel.html:
      * inspector/debugger/source-frame-count.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      192582ad
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r127447. · 9a34e845
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/127447
      https://bugs.webkit.org/show_bug.cgi?id=95726
      
      Mistake, did not reliably pass yet. (Requested by drott on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-04
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a34e845
    • commit-queue@webkit.org's avatar
      Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state... · a51c95d7
      commit-queue@webkit.org authored
      Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
      https://bugs.webkit.org/show_bug.cgi?id=95443
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Save gl.getError() status before taking the GL snapshot and restore it afterwards.
      
      * inspector/InjectedScriptWebGLModuleSource.js:
      (.):
      
      LayoutTests:
      
      Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.
      
      * inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
      * inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
      * inspector/profiler/webgl/webgl-profiler-test.js: Added.
      (initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
      (initialize_WebGLProfilerTest):
      (createWebGLContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a51c95d7
    • commit-queue@webkit.org's avatar
      [CMAKE] Update cmakeconfig.h.cmake · 3a5958b5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95712
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-04
      Reviewed by Gyuyoung Kim.
      
      Update feature definitions which are missing compared to WebKitFeatures.cmake
      
      * Source/cmakeconfig.h.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a5958b5
    • ossy@webkit.org's avatar
      [Qt] REGRESSION(r127321): It made 3 notification test timeout · 92ffbbb7
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95638
      
      Patch by Jon Lee <jonlee@apple.com> on 2012-09-04
      Reviewed by Csaba Osztrogonác.
      
      Dispatch show event instead of display after r127321.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::sendDisplayEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92ffbbb7
    • apavlov@chromium.org's avatar
      Web Inspector: More directional control characters for debugging in inspector · c95edc26
      apavlov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95696
      
      Reviewed by Vsevolod Vlasov.
      
      Source/WebCore:
      
      Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).
      
      * inspector/front-end/ElementsTreeOutline.js:
      
      LayoutTests:
      
      * inspector/elements/elements-panel-structure-expected.txt:
      * inspector/elements/elements-panel-structure.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c95edc26
    • yurys@chromium.org's avatar
      Web Inspector: new CPU Profiles are not shown after reattach · 373635bb
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95686
      
      Reviewed by Vsevolod Vlasov.
      
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
      to true and clear all profiles on the front-end since there are no
      collected profiles yet immediately after render process sitching.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      373635bb
    • dominik.rottsches@intel.com's avatar
      [EFL] Unreviewed gardening. · e58a1ca1
      dominik.rottsches@intel.com authored
      Removing http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
      from skipped crashers section, after https://bugs.webkit.org/show_bug.cgi?id=94458#c14
      
      * platform/efl/TestExpectations: Previously crashing test removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e58a1ca1
    • mary.wu@torchmobile.com.cn's avatar
      [BlackBerry] Add webplatform and browser to build info · 90311e1b
      mary.wu@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=95715
      
      Reviewed by George Staikos.
      
      PR# 202102
      
      * WebKitSupport/AboutData.cpp:
      (BlackBerry::WebKit::buildPage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90311e1b
    • ryuan.choi@samsung.com's avatar
      [EFL] Drop default theme concept · 8f97462a
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=94778
      
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit/efl:
      
      * ewk/ewk_view.h:
      Updated doxygen document not to mention default theme.
      
      Source/WebKit2:
      
      * PlatformEfl.cmake: Removed DEFAULT_THEME_PATH definitions.
      * UIProcess/API/efl/ewk_view.cpp:
      (_ewk_view_initialize): Removed default theme concept.
      * UIProcess/API/efl/ewk_view.h:
      Updated doxygen document not to mention default theme.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f97462a
    • loislo@chromium.org's avatar
      Web Inspector: NMI: cosmetic change, rename m_domMemoryUsage to m_memoryInstrumentation. · 9379ba50
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95716
      
      Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/InspectorMemoryAgent.cpp:
      (WebCore):
      (WebCore::collectDomTreeInfo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9379ba50
    • hausmann@webkit.org's avatar
      [Qt] Port the Qt pixmap JS bindings to use the JSC C API · 6a8271a7
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94702
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Based on patch by Noam Rosenthal.
      
      The conversion uses a simple JSClassRef based binding and only a few
      uses of private JSC API for the HTML element DOM bindings remain.
      
      This is essentially used for wrapping QPixmap and QImage types in
      JavaScript and the other way around, for retrieving the image data
      out of a HTML image element when converting from JS/DOM to Qt.
      
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::copyPixels):
      (JSC::Bindings::toPixmap):
      (JSC::Bindings::toImage):
      (JSC::Bindings::imageSizeForVariant):
      (JSC::Bindings::getPixmapWidth):
      (JSC::Bindings::getPixmapHeight):
      (JSC::Bindings::assignToHTMLImageElement):
      (JSC::Bindings::pixmapToImageData):
      (JSC::Bindings::pixmapToDataUrl):
      (JSC::Bindings::pixmapToString):
      (JSC::Bindings::QtPixmapRuntime::toJS):
      (JSC::Bindings::QtPixmapRuntime::toQt):
      (JSC::Bindings::QtPixmapRuntime::canHandle):
      (JSC::Bindings::QtPixmapRuntime::getClassRef):
      * bridge/qt/qt_pixmapruntime.h:
      (QtPixmapRuntime):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::convertValueToQVariant):
      (JSC::Bindings::convertQVariantToValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a8271a7
  2. 03 Sep, 2012 1 commit