1. 11 Oct, 2010 35 commits
    • tonikitoo@webkit.org's avatar
      2010-10-10 Antonio Gomes <agomes@rim.com> · 35f4ae58
      tonikitoo@webkit.org authored
              Reviewed by Andreas Kling.
      
              Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior
              https://bugs.webkit.org/show_bug.cgi?id=47472
      
              Patch converts the editing/selection/click-in-padding-with-multiple-line-boxes.js to make use of the
              LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
              code paths can be test in the same execution, and we make it possible to share the same
              expected result file through all ports.
      
              * editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Modified with resutls for all editing behaviors, i.e. mac and win.
              * editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
              ():
              * platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
              * platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
              * platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f4ae58
    • joepeck@webkit.org's avatar
      2010-10-11 Joseph Pecoraro <joepeck@webkit.org> · c4b6566b
      joepeck@webkit.org authored
              Reviewed by Eric Carlson.
      
              CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
              https://bugs.webkit.org/show_bug.cgi?id=46777
      
              Another case that could lead to an improper set of states between
              m_currentNode and m_loadingState. Also added an ASSERT and early
              return to prevent crashes if this case can still happen in other ways.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::prepareForLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4b6566b
    • rniwa@webkit.org's avatar
      2010-10-11 Ryosuke Niwa <rniwa@webkit.org> · 2eaf405b
      rniwa@webkit.org authored
              Unreviewed build fix.
      
              Fixed design-mode-spellcheck-off.html so that it passes on platforms that do not support textInputController.
      
              * editing/spelling/design-mode-spellcheck-off.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eaf405b
    • mthole@apple.com's avatar
      Rename WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain() · 3bf4703f
      mthole@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=47495
      
      Reviewed by Darin Adler.
      
      WebKit2: 
      
      * Shared/API/c/mac/WKCertificateInfoMac.h:
      Renamed WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()
      * Shared/API/c/mac/WKCertificateInfoMac.mm:
      (WKCertificateInfoGetCertificateChain): Updated for name change.
      * Shared/mac/PlatformCertificateInfo.h:
      (WebKit::PlatformCertificateInfo::certificateChain): Renamed from peerCertificates()
      * Shared/mac/PlatformCertificateInfo.mm:
      (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Updated for name change.
      (WebKit::PlatformCertificateInfo::encode): Ditto.
      (WebKit::PlatformCertificateInfo::decode): Ditto.
      (WebKit::PlatformCertificateInfo::dump): Ditto.
      
      WebKitLibraries: 
      
      * WebKitSystemInterface.h: 
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bf4703f
    • kbalazs@webkit.org's avatar
      2010-10-11 Balazs Kelemen <kbalazs@webkit.org> · 86cac122
      kbalazs@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Issue a warning when an InjectedBundle can't be loaded.
              https://bugs.webkit.org/show_bug.cgi?id=47497
      
              The original author of the patch is Jocelyn Turcotte <jocelyn.turcotte@nokia.com>.
      
              * WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
              (WebKit::InjectedBundle::load):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86cac122
    • rniwa@webkit.org's avatar
      2010-10-11 Ryosuke Niwa <rniwa@webkit.org> · 6495d703
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              spellcheck="false" not respected in designMode
              https://bugs.webkit.org/show_bug.cgi?id=39978
      
              The bug was caused by WebKit's setting focus to html element rather than body element in design mode.
              Because we disable spell-check only if ancestor nodes of the focused element had spellcheck=false,
              this caused us to ignore body element's spellcheck attribute.
      
              Fixed the bug by overriding supportsFocus in HTMLBodyElement to make body element focusable
              when the parent node of body elements (namely html element) is editable.
      
              Test: editing/spelling/design-mode-spellcheck-off.html
      
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::supportsFocus): Added.
              * html/HTMLBodyElement.h:
      2010-10-11  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              spellcheck="false" not respected in designMode
              https://bugs.webkit.org/show_bug.cgi?id=39978
      
              Added a test to ensure Webkit respects spellcheck=off on body element.
              Rebaselined are due to our setting the focus to body element rather than html element in design mode.
      
              * editing/spelling/design-mode-spellcheck-off-expected.txt: Added.
              * editing/spelling/design-mode-spellcheck-off.html: Added.
              * editing/inserting/space-after-removeformat-expected.txt: Editing delegates change due to focus moving to body.
              * platform/chromium-win/editing/inserting/editable-html-element-expected.txt: Ditto.
              * platform/chromium-win/editing/selection/editable-html-element-expected.txt: Ditto.
              * platform/chromium-win/editing/selection/editable-links-expected.txt: Ditto.
              * platform/chromium-win/editing/selection/focus_editable_html-expected.txt: Ditto.
              * platform/chromium-win/editing/style/designmode-expected.txt: Ditto.
              * platform/mac/editing/inserting/editable-html-element-expected.txt: Ditto.
              * platform/mac/editing/selection/designmode-no-caret-expected.txt: Ditto.
              * platform/mac/editing/selection/editable-html-element-expected.txt: Ditto.
              * platform/mac/editing/selection/editable-links-expected.txt: Ditto.
              * platform/mac/editing/selection/focus_editable_html-expected.txt: Ditto.
              * platform/mac/editing/style/designmode-expected.txt: Ditto.
              * platform/qt/editing/inserting/editable-html-element-expected.txt: Ditto.
              * platform/qt/editing/selection/editable-html-element-expected.txt: Ditto.
              * platform/qt/editing/selection/focus_editable_html-expected.txt: Ditto.
              * platform/qt/editing/style/designmode-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6495d703
    • weinig@apple.com's avatar
      Rename transformToDeviceSpace to convertToDeviceSpace and · 6e21dbc3
      weinig@apple.com authored
      transformToUserSpace to convertToUserSpace at Simon's request.
      
      Reviewed by Simon Fraser.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::convertToDeviceSpace):
      (WebKit::PageClientImpl::convertToUserSpace):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _convertToDeviceSpace:]):
      (-[WKView _convertToUserSpace:]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::convertToDeviceSpace):
      (QWKPagePrivate::convertToUserSpace):
      * UIProcess/API/qt/qwkpage_p.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::setWindowFrame):
      (WebKit::WebPageProxy::getWindowFrame):
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::convertToDeviceSpace):
      (WebKit::WebView::convertToUserSpace):
      * UIProcess/win/WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e21dbc3
    • oliver@apple.com's avatar
    • oliver@apple.com's avatar
      2010-10-11 Oliver Hunt <oliver@apple.com> · 80b742dd
      oliver@apple.com authored
              Reviewed by Andreas Kling.
      
              Incorrect handling of 0 length logs in GraphicsContext3DOpenGL.cpp
              https://bugs.webkit.org/show_bug.cgi?id=47494
      
              Working on another patch I found that there was some screwy behaviour
              when dealing with logs from GL.  GL_INFO_LOG_LENGTH is defined as being
              zero if there is no log message, but we did not check for that case and
              simply perfomed a zero sized alloc and passed the resultant buffer to
              glGetShaderInfoLog, etc.  glGetShaderInfoLog would then write a null
              terminator to the buffer, thus causing an overflow.  This is obviously
              not a problem in practice as allocations are at least 4 bytes long in
              all common allocators, but it is still a bug.
      
              I also removed some unnecessary null checks following calls to fastMalloc.
      
              * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
              (WebCore::GraphicsContext3D::getProgramInfoLog):
              (WebCore::GraphicsContext3D::getShaderInfoLog):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80b742dd
    • zimmermann@webkit.org's avatar
      2010-10-11 Nikolas Zimmermann <nzimmermann@rim.com> · ea2750ee
      zimmermann@webkit.org authored
              Reviewed by Andreas Kling.
      
              Kill Path::debugString()
              https://bugs.webkit.org/show_bug.cgi?id=47493
      
              Remove the obsolete Path::debugString() method. DRT now dumps paths in a platform independant way.
      
              * platform/graphics/Path.h:
              * platform/graphics/cairo/PathCairo.cpp:
              * platform/graphics/cg/PathCG.cpp:
              * platform/graphics/haiku/PathHaiku.cpp:
              * platform/graphics/openvg/PathOpenVG.cpp:
              * platform/graphics/qt/PathQt.cpp:
              * platform/graphics/skia/PathSkia.cpp:
              * platform/graphics/wince/PathWinCE.cpp:
              * platform/graphics/wince/PlatformPathWinCE.cpp:
              * platform/graphics/wince/PlatformPathWinCE.h:
              * platform/graphics/wx/PathWx.cpp:
              * svg/SVGGlyphElement.h:
              (WebCore::SVGGlyphIdentifier::operator==):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea2750ee
    • weinig@apple.com's avatar
      Try to fix the Mac release build. · 05a099fb
      weinig@apple.com authored
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _transformToDeviceSpace:]):
      (-[WKView _transformToUserSpace:]):
      * UIProcess/API/mac/WKViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05a099fb
    • kbalazs@webkit.org's avatar
      2010-10-11 Balazs Kelemen <kbalazs@webkit.org> · ac604f29
      kbalazs@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              WebProcess ASSERTs with a null application cache dir creation parameter
              https://bugs.webkit.org/show_bug.cgi?id=47489
      
              * WebProcess/WebProcess.cpp:
              (WebKit::WebProcess::initializeWebProcess):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac604f29
    • kenneth@webkit.org's avatar
      Unlink the files used for I/O mapped memory as soon as they are · f094beae
      kenneth@webkit.org authored
      created.
      
      Reviewed by Andreas Kling.
      
      * Shared/qt/UpdateChunk.cpp:
      (WebKit::mapMemory):
      (WebKit::mapFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f094beae
    • kenneth@webkit.org's avatar
      Build fix when using MeeGo Touch · 66489e96
      kenneth@webkit.org authored
      Rubberstamped by Andreas Kling.
      
      * WebProcess/qt/WebProcessMainQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66489e96
    • kenneth@webkit.org's avatar
      Use raster for the QtWebProcess. · ca15e19d
      kenneth@webkit.org authored
      Reviewed by Andreas Kling.
      
      * WebProcess/qt/WebProcessMainQt.cpp:
      (WebKit::WebProcessMainQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca15e19d
    • mrobinson@webkit.org's avatar
      2010-10-11 Martin Robinson <mrobinson@igalia.com> · 9de15e78
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Search field icons should be centered vertically in the field
              https://bugs.webkit.org/show_bug.cgi?id=47441
      
              Add a pixel dump result which tests the fix.
      
              * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
              * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png: Added.
      2010-10-11  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] Search field icons should be centered vertically in the field
              https://bugs.webkit.org/show_bug.cgi?id=47441
      
              Center search field icons vertically in the search field.
      
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::centerRectVerticallyInParentInputElement): Added this helper.
              (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Center the search
              field icon by adjusting its drawing rect relative to the containing search field.
              (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9de15e78
    • podivilov@chromium.org's avatar
      2010-10-11 Pavel Podivilov <podivilov@chromium.org> · 46256f42
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: fix event listener breakpoints sidebar pane style
              https://bugs.webkit.org/show_bug.cgi?id=47487
      
              * inspector/front-end/inspector.css:
              (.section .properties, .event-bar .event-properties):
              (.section.expanded .properties, .event-bar.expanded .event-properties):
              (.properties-tree):
              (.properties-tree li):
              (.properties-tree li.parent):
              (.properties-tree li.parent::before):
              (.properties-tree li.parent.expanded::before):
              (.properties-tree li .info):
              (.properties-tree ol, .stack-trace ol, ol.stack-trace):
              (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace):
              (ol.stack-trace):
              (.event-listener-breakpoints .event-category):
              (.event-listener-breakpoints.properties-tree .children li):
              (.event-listener-breakpoints .checkbox-elem):
              (.breakpoint-list .breakpoint-hit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46256f42
    • andreas.kling@nokia.com's avatar
      2010-10-11 Andreas Kling <kling@webkit.org> · a7621bf5
      andreas.kling@nokia.com authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Avoid QPainterPath::operator=(QPainterPath()) when possible
      
              Same concept as <http://trac.webkit.org/changeset/69462>, do nothing
              when clearing an already empty QPainterPath. Avoids one delete+new.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContextPlatformPrivate::clearCurrentPath):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::beginPath):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7621bf5
    • kov@webkit.org's avatar
      2010-10-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · a354acb3
      kov@webkit.org authored
              Unreviewed. Remove unnecessary GTK+ and Pango includes.
      
              * platform/gtk/FileChooserGtk.cpp:
              * platform/gtk/Language.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a354acb3
    • kenneth@webkit.org's avatar
      Unreviewed win build fix. · 2d8152ce
      kenneth@webkit.org authored
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d8152ce
    • kenneth@webkit.org's avatar
      Adding Qt WebKit2 API for dealing with viewport meta info · 4497b34b
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=47202
      
      Reviewed by Sam Weinig.
      
      Add new API for setting scale and layout viewport given the data
      provided by the viewport meta tag.
      
      Any Qt view components who wants to support this, will need to
      compute the viewport attributes before first load using
      viewportAttributesForSize(..), and then again everytime
      the viewport attributes gets invalidates (loading a new page,
      navigating page cache) or every time on of the browser
      attributes change, such as when the device is rotates (which
      changes the actual visible viewport). A signal
      viewportChangeRequested() is provided for the former.
      
      * Shared/WebCoreArgumentCoders.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::setViewportArguments):
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::setViewportArguments):
      (QWKPage::ViewportAttributes::ViewportAttributes):
      (QWKPage::ViewportAttributes::~ViewportAttributes):
      (QWKPage::ViewportAttributes::operator=):
      (QWKPage::viewportAttributesForSize):
      * UIProcess/API/qt/qwkpage.h:
      * UIProcess/API/qt/qwkpage_p.h:
      (QtViewportAttributesPrivate::QtViewportAttributesPrivate):
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::didReceiveMessage):
      (WebKit::WebPageProxy::didChangeViewportData):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::setViewportArguments):
      * UIProcess/win/WebView.h:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::dispatchViewportDataDidChange):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4497b34b
    • tonikitoo@webkit.org's avatar
      2010-10-10 Antonio Gomes <agomes@rim.com> · 73197510
      tonikitoo@webkit.org authored
              Reviewed by Andreas Kling.
      
              Convert editing/selection/script-tests/click-in-margins-inside-editable-div.js to use LayoutTestController::setEditingBeh      avior
              https://bugs.webkit.org/show_bug.cgi?id=47471
      
              Patch converts the editing/selection/click-in-margins-inside-editable-div to make use of the
              LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
              code paths can be test in the same execution, and we make it possible to share the same
              expected result file through all ports.
      
              * editing/selection/click-in-margins-inside-editable-div-expected.txt:
              * editing/selection/script-tests/click-in-margins-inside-editable-div.js:
              ():
              * platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
              * platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
              * platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73197510
    • ossy@webkit.org's avatar
      2010-10-11 Csaba Osztrogonác <ossy@webkit.org> · b9da9b7c
      ossy@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] WebKit2 build scripts are buggy
              https://bugs.webkit.org/show_bug.cgi?id=47377
      
              Generated sources must depends on WebKit2/Scripts/webkit2/messages.py too.
      
              * DerivedSources.pro: Missing dependencies added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9da9b7c
    • apavlov@chromium.org's avatar
      2010-10-11 Alexander Pavlov <apavlov@chromium.org> · e5780194
      apavlov@chromium.org authored
              [Chromium] Unreviewed, build fix.
      
              Disable fast/filesystem/op-remove.html for chromium-win.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5780194
    • apavlov@chromium.org's avatar
      2010-10-11 Alexander Pavlov <apavlov@chromium.org> · 93355d89
      apavlov@chromium.org authored
              [Chromium] Unreviewed, build fix.
      
              Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux and chromium-mac.
      
              * platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
              * platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93355d89
    • kinuko@chromium.org's avatar
      2010-10-11 Kinuko Yasuda <kinuko@google.com> · b107ea23
      kinuko@chromium.org authored
              Reviewed by David Levin.
      
              Support DirectoryEntry.removeRecursively for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=47400
      
              * src/AsyncFileSystemChromium.cpp:
              (WebCore::AsyncFileSystemChromium::removeRecursively): Added.
              * src/AsyncFileSystemChromium.h:
              * src/WorkerAsyncFileSystemChromium.cpp:
              (WebCore::WorkerAsyncFileSystemChromium::removeRecursively): Added.
              * src/WorkerAsyncFileSystemChromium.h:
              * src/WorkerFileSystemCallbacksBridge.cpp:
              (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread): Added.
              (WebKit::WorkerFileSystemCallbacksBridge::removeRecursivelyOnMainThread): Added.
              * src/WorkerFileSystemCallbacksBridge.h:
      2010-10-11  Kinuko Yasuda  <kinuko@chromium.org>
      
              Reviewed by David Levin.
      
              Support DirectoryEntry.removeRecursively for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=47400
      
              Also disallows remove/removeRecursively on the root directory.
      
              Test: fast/filesystem/op-remove.html
      
              * fileapi/DOMFileSystemBase.cpp:
              (WebCore::DOMFileSystemBase::removeRecursively): Added.
              * fileapi/DOMFileSystemBase.h:
              * fileapi/DirectoryEntry.cpp:
              (WebCore::DirectoryEntry::removeRecursively): Added.
              * fileapi/DirectoryEntry.h:
              * fileapi/DirectoryEntry.idl:
              * fileapi/DirectoryEntrySync.cpp:
              (WebCore::DirectoryEntrySync::removeRecursively): Added.
              * fileapi/DirectoryEntrySync.h:
              * fileapi/DirectoryEntrySync.idl:
              * platform/AsyncFileSystem.h:
      2010-10-11  Kinuko Yasuda  <kinuko@chromium.org>
      
              Reviewed by David Levin.
      
              Support DirectoryEntry.removeRecursively for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=47400
      
              * fast/filesystem/resources/async-operations.js:
              * fast/filesystem/resources/fs-test-util.js:
              (removeAllInDirectory): renamed from removeRecursively and changed
              the implemntation to use DirectoryEntry.removeRecursively.
              * fast/filesystem/resources/fs-worker-common.js:
              (removeAllInDirectorySync): ditto.
              * fast/filesystem/resources/op-remove.js: Added removeRecursively test.
              * fast/filesystem/resources/op-tests-helper.js:
              (runOperationTest.OperationTestHelper.this.removeRecursively): Added.
              * fast/filesystem/resources/sync-operations.js:
              * fast/filesystem/script-tests/file-from-file-entry.js:
              * fast/filesystem/script-tests/read-directory.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b107ea23
    • apavlov@chromium.org's avatar
      2010-10-11 Alexander Pavlov <apavlov@chromium.org> · 7f0c03ee
      apavlov@chromium.org authored
              [Chromium] Unreviewed, build fix.
      
              Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux.
              Fix bad expectation.
      
              * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f0c03ee
    • apavlov@chromium.org's avatar
      2010-10-11 Alexander Pavlov <apavlov@chromium.org> · 60588ef2
      apavlov@chromium.org authored
              [Chromium] Unreviewed, build fix.
      
              Update more test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60588ef2
    • krit@webkit.org's avatar
      2010-10-11 Dirk Schulze <krit@webkit.org> · 240c0335
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG feImage take preserveAspectRatio into account for absolute paint rect
              https://bugs.webkit.org/show_bug.cgi?id=47464
      
              Determine the smallest effect region for SVGFEImage by taking preserveAspectRatio into account.
      
              * svg/graphics/filters/SVGFEImage.cpp:
              (WebCore::FEImage::determineAbsolutePaintRect):
              (WebCore::FEImage::apply):
              * svg/graphics/filters/SVGFEImage.h:
      2010-10-11  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG feImage take preserveAspectRatio into account for absolute paint rect
              https://bugs.webkit.org/show_bug.cgi?id=47464
      
              Needs a new baseline for svg/W3C-SVG-1.1-SE/filters-image-03-f.
      
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      240c0335
    • apavlov@chromium.org's avatar
      2010-10-11 Alexander Pavlov <apavlov@chromium.org> · e5a3352c
      apavlov@chromium.org authored
              [Chromium] Unreviewed, build fix.
      
              Rebaseline overhanging-floats-removed for chromium-win and chromium-linux platforms.
      
              * platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
              * platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.png: Added.
              * platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
              * platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a3352c
    • abarth@webkit.org's avatar
      2010-10-11 Adam Barth <abarth@webkit.org> · 877b4d25
      abarth@webkit.org authored
              Unreviewed.
      
              Fix sheriffbot not to crash when there are failing tests.  It turns out
              Python sets don't support the + operator.  We need to use union
              instead.  There's a more elegant way to do this in Python 2.6, but we
              need this code to work in 2.5.
      
              * Scripts/webkitpy/common/net/failuremap.py:
              * Scripts/webkitpy/common/net/failuremap_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      877b4d25
    • inferno@chromium.org's avatar
      2010-10-11 Abhishek Arya <inferno@chromium.org> · 887facdd
      inferno@chromium.org authored
              Unreviewed.
      
              Commit r69478 put the expected file in wrong platform. Correcting that.
      
              * platform/gtk/fast/flexbox: Added.
              * platform/gtk/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
              * platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      887facdd
    • inferno@chromium.org's avatar
      2010-10-10 Abhishek Arya <inferno@chromium.org> · 89edcbff
      inferno@chromium.org authored
              Unreviewed.
      
              Rebaseline overhanging-floats-removed test for GTK platform.
      
              * platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89edcbff
    • mitz@apple.com's avatar
      Added Radar ULR · 84c31655
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c31655
    • inferno@chromium.org's avatar
      2010-10-10 Abhishek Arya <inferno@chromium.org> · f217621f
      inferno@chromium.org authored
              Reviewed by Dan Bernstein.
      
              Overhanging floats are not added to flexible boxes since they behave like
              block formatting contexts. This causes the intruding floats added in siblings
              to not get cleared. Enforce the float release by checking if the parent is a
              flexible box and if yes, use that as the outermost block.
              
              https://bugs.webkit.org/show_bug.cgi?id=47104
      
              Test: fast/flexbox/overhanging-floats-removed.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
      2010-10-10  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Tests that intruding floats get properly cleared in flexible box layout.
              https://bugs.webkit.org/show_bug.cgi?id=47104
      
              * fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
              * fast/flexbox/overhanging-floats-removed-expected.png: Added.
              * fast/flexbox/overhanging-floats-removed-expected.txt: Added.
              * fast/flexbox/overhanging-floats-removed.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f217621f
  2. 10 Oct, 2010 5 commits