1. 04 Mar, 2010 12 commits
    • eric@webkit.org's avatar
      2010-03-04 Fridrich Strba <fridrich.strba@bluewin.ch> · 35236ae9
      eric@webkit.org authored
              Reviewed by Holger Freyther.
      
              https://bugs.webkit.org/show_bug.cgi?id=35726
              Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
      
              Removing orphaned #if USE.
      
              * GNUmakefile.am:
      2010-03-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
      
              Reviewed by Holger Freyther.
      
              https://bugs.webkit.org/show_bug.cgi?id=35726
              Remove orphaned #ifdef WTF_USE_GLIB_ICU_UNICODE_HYBRID
      
              Removing orphaned #if USE.
      
              * platform/ThreadGlobalData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35236ae9
    • jorlow@chromium.org's avatar
      Trottle sync requests sent to the LocalStorage background thread · e6597a77
      jorlow@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34943
      
      Reviewed by Darin Fisher.
      
      Currently, once a second LocalStorage takes all keys/values which have
      been changed and sends them to a background thread to sync.  The problem
      is that this background thread can get overwhelmed and stop being
      responsive.  This means that if any other page tries to start using
      LocalStorage (and thus initiates the initial import) that'll block on
      all the previous syncs completing.
      
      To mitigate this, I'm adding code so that we never schedule another
      sync task when another is still running.  In order to keep the sync
      tasks from growing exponentially when they do take longer than the
      storage sync interval, I've also added a basic rate limiter.  No effort
      is made to ensure fairness/ordering of what gets synced nor is there
      any way for this rate to be changed because most normal uses of
      LocalStorage really shouldn't be hitting these types of limits anyway.
      
      The only behavioral change that's observible in JavaScript is time based
      and thus it's not practical to make new tests that aren't racy.  The
      existing layout tests cover LocalStorage pretty well, though.
      
      * storage/StorageAreaSync.cpp:
      (WebCore::StorageAreaSync::StorageAreaSync):
      (WebCore::StorageAreaSync::scheduleFinalSync):
      (WebCore::StorageAreaSync::syncTimerFired):
      (WebCore::StorageAreaSync::performSync):
      * storage/StorageAreaSync.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6597a77
    • pfeldman@chromium.org's avatar
      2010-03-04 Andrey Kosyakov <caseq@chromium.org> · 3adc7312
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Added support for worker instrumentation in inspector
              (display list of active workers, allow debugging of workers
              by injecting fake JS implementation)
      
              https://bugs.webkit.org/show_bug.cgi?id=35568
      
              * English.lproj/localizedStrings.js:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * dom/Document.cpp:
              (WebCore::Document::inspectorController):
              * dom/Document.h:
              * dom/ScriptExecutionContext.h:
              (WebCore::ScriptExecutionContext::inspectorController):
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::InjectedScriptHost):
              (WebCore::InjectedScriptHost::injectScript):
              (WebCore::InjectedScriptHost::nextWorkerId):
              (WebCore::InjectedScriptHost::didCreateWorker):
              (WebCore::InjectedScriptHost::willDestroyWorker):
              * inspector/InjectedScriptHost.h:
              * inspector/InjectedScriptHost.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::populateScriptObjects):
              (WebCore::InspectorController::resetScriptObjects):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::didCreateWorker):
              (WebCore::InspectorController::willDestroyWorker):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::didCreateWorker):
              (WebCore::InspectorFrontend::willDestroyWorker):
              * inspector/InspectorFrontend.h:
              * inspector/InspectorWorkerResource.h: Added.
              (WebCore::InspectorWorkerResource::create):
              (WebCore::InspectorWorkerResource::id):
              (WebCore::InspectorWorkerResource::url):
              (WebCore::InspectorWorkerResource::isSharedWorker):
              (WebCore::InspectorWorkerResource::InspectorWorkerResource):
              * inspector/front-end/Checkbox.js: Added.
              (WebInspector.Checkbox.callbackWrapper):
              (WebInspector.Checkbox):
              (WebInspector.Checkbox.prototype.checked):
              * inspector/front-end/InjectedFakeWorker.js:
              (InjectedFakeWorker.FakeWorker):
              (InjectedFakeWorker.FakeWorker.prototype.terminate):
              (InjectedFakeWorker.FakeWorker.prototype._handleException):
              (InjectedFakeWorker.FakeWorker.prototype._importScripts):
              (InjectedFakeWorker.FakeWorker.prototype._loadScript):
              (InjectedFakeWorker.FakeWorker.prototype._expandURLAndCheckOrigin):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
              (WebInspector.ScriptsPanel.prototype.reset):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/WorkersSidebarPane.js: Added.
              (WebInspector.WorkersSidebarPane):
              (WebInspector.WorkersSidebarPane.prototype.addWorker):
              (WebInspector.WorkersSidebarPane.prototype.removeWorker):
              (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
              (WebInspector.WorkersSidebarPane.prototype.reset):
              (WebInspector.WorkersSidebarPane.prototype._onTriggerInstrument):
              (WebInspector.Worker):
              (WebInspector.didCreateWorker):
              (WebInspector.willDestroyWorker):
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * workers/AbstractWorker.cpp:
              (WebCore::AbstractWorker::AbstractWorker):
              (WebCore::AbstractWorker::~AbstractWorker):
              (WebCore::AbstractWorker::onDestroyWorker):
              (WebCore::AbstractWorker::contextDestroyed):
              * workers/AbstractWorker.h:
              (WebCore::AbstractWorker::id):
              * workers/SharedWorker.cpp:
              (WebCore::SharedWorker::SharedWorker):
              * workers/Worker.cpp:
              (WebCore::Worker::Worker):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3adc7312
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Make the OUTPUT_DIR variable in qmake projects independent of build-webkit's logic. · 28faeac4
      jocelyn.turcotte@nokia.com authored
      Reviewed by Tor Arne Vestbø.
      
      This also allows shadow builds relying only on qmake to work properly.
      
      .:
      
      * WebKit.pri:
      
      JavaScriptCore:
      
      * jsc.pro:
      * qt/api/QtScript.pro:
      * qt/tests/qscriptengine/qscriptengine.pro:
      * qt/tests/qscriptvalue/qscriptvalue.pro:
      * qt/tests/tests.pri:
      
      WebCore:
      
      * WebCore.pro:
      
      WebKit\qt:
      
      * tests/benchmarks/loading/loading.pro:
      * tests/benchmarks/painting/painting.pro:
      * tests/hybridPixmap/hybridPixmap.pro:
      * tests/qgraphicswebview/qgraphicswebview.pro:
      * tests/qwebelement/qwebelement.pro:
      * tests/qwebframe/qwebframe.pro:
      * tests/qwebhistory/qwebhistory.pro:
      * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
      * tests/qwebinspector/qwebinspector.pro:
      * tests/qwebpage/qwebpage.pro:
      * tests/qwebplugindatabase/qwebplugindatabase.pro:
      
      WebKitTools:
      
      * DumpRenderTree/qt/DumpRenderTree.pro:
      * DumpRenderTree/qt/ImageDiff.pro:
      * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      * QtL...
      28faeac4
    • zecke@webkit.org's avatar
      [Qt] Avoid calling QFont::detach too often from FontQt · 8f71f50f
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=35569
      
      The letter- and wordspacing is inside the WebCore::Font class,
      our QFont is located in the WebCore::FontPlatformData. Everytime
      we need to use a QFont inside WebCore::Font we are calling the
      font method which gets the QFont from the WebCore::FontPlatformData
      and is applying the letter- and wordspacing. Internally this
      will attempt to detach the QFont...
      
      Avoid calling setLetterSpacing and setWordSpacing on QFont if
      the WebCore::Font has the default applied.
      
      * platform/graphics/qt/FontQt.cpp:
      (WebCore::Font::font):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f71f50f
    • apavlov@chromium.org's avatar
      2010-03-04 Alexander Pavlov <apavlov@chromium.org> · f4941ad8
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Nothing happens on navigation to resource via a link if resource tracking is disabled
              https://bugs.webkit.org/show_bug.cgi?id=35574
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
              (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
              * inspector/front-end/inspector.js:
              (WebInspector.documentMouseOver):
              (WebInspector.documentMouseOut):
              (WebInspector.hideBadLinkPopupIfNecessary):
              (WebInspector.documentClick.followLink):
              (WebInspector.documentClick):
              (WebInspector.showBadLinkPopup.popupOverOut):
              (WebInspector.showBadLinkPopup):
              (WebInspector.addMainEventListeners):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4941ad8
    • eric@webkit.org's avatar
      2010-03-04 Vangelis Kokkevis <vangelis@chromium.org> · 193c5f86
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Update existing test to check that getUniformLocation() returns
              null if the uniform requested is not found.
              https://bugs.webkit.org/show_bug.cgi?id=34669
      
              * fast/canvas/webgl/script-tests/uniform-location.js:
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-03-04  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by Oliver Hunt.
      
              getUniformLocation() now returns null if uniform requested
              is not found.
              https://bugs.webkit.org/show_bug.cgi?id=34669
      
              Test:LayoutTests/fast/canvas/webgl/uniform-location.html
              (added missing test)
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::getUniformLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      193c5f86
    • eric@webkit.org's avatar
      2010-03-04 John Abd-El-Malek <jam@chromium.org> · 61ccc4b3
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Fix incorrect setup of DateExtension.
              https://bugs.webkit.org/show_bug.cgi?id=35710
      
              * fast/dom/Window/resources/slow_unload_handler1.html:
      2010-03-04  John Abd-El-Malek  <jam@chromium.org>
      
              Reviewed by Adam Barth.
      
              Fix incorrect setup of DateExtension.
              https://bugs.webkit.org/show_bug.cgi?id=35710
      
              * bindings/v8/DateExtension.cpp:
              (WebCore::DateExtension::setAllowSleep):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ccc4b3
    • oliver@apple.com's avatar
      2010-03-04 Oliver Hunt <oliver@apple.com> · 9cc43765
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=35603
              SVG incorrectly allows nested <use> elements in a <use> shadow tree
      
              Simplify the handling of invalid or missing use-targets by cloning them
              to empty <g> elements rather than just allowing the <use> element to
              be copied into the shadow tree, as this violates a number of assumptions
              in the shadow tree handling code.
      
              Tests: svg/custom/use-nested-disallowed-target.svg
                     svg/custom/use-nested-missing-target-added.svg
                     svg/custom/use-nested-missing-target-removed.svg
                     svg/custom/use-nested-missing-target.svg
                     svg/custom/use-nested-notarget.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::buildPendingResource):
              (WebCore::SVGUseElement::buildShadowAndInstanceTree):
              (WebCore::SVGUseElement::expandUseElementsInShadowTree):
      
      2010-03-04  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              https://bugs.webkit.org/show_bug.cgi?id=35603
              SVG incorrectly allows nested <use> elements in a <use> shadow tree
      
              Add test cases for various combinations of <use> and targets that aren't present.
      
              * platform/mac/svg/custom/use-empty-reference-expected.txt: Added.
              * svg/custom/use-nested-disallowed-target-expected.txt: Added.
              * svg/custom/use-nested-disallowed-target.svg: Added.
              * svg/custom/use-nested-missing-target-added-expected.txt: Added.
              * svg/custom/use-nested-missing-target-added.svg: Added.
              * svg/custom/use-nested-missing-target-expected.txt: Added.
              * svg/custom/use-nested-missing-target-removed-expected.txt: Added.
              * svg/custom/use-nested-missing-target-removed.svg: Added.
              * svg/custom/use-nested-missing-target.svg: Added.
              * svg/custom/use-nested-notarget-expected.txt: Added.
              * svg/custom/use-nested-notarget.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cc43765
    • eric@webkit.org's avatar
      2010-03-04 Leandro Pereira <leandro@profusion.mobi> · b25a5690
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              Move Cairo-related font code from platform/graphics/gtk to
              platform/graphics/cairo, so other ports may use them.
              http://webkit.org/b/35539
      
              * GNUmakefile.am:
              * platform/graphics/cairo/FontCacheCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontCacheGtk.cpp.
              * platform/graphics/cairo/FontCustomPlatformData.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.cpp.
              * platform/graphics/cairo/FontCustomPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformData.h.
              * platform/graphics/cairo/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformData.h.
              * platform/graphics/cairo/FontPlatformDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp.
              * platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp.
              * platform/graphics/cairo/SimpleFontDataCairo.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataGtk.cpp.
              * platform/graphics/gtk/FontCacheGtk.cpp: Removed.
              * platform/graphics/gtk/FontCustomPlatformData.cpp: Removed.
              * platform/graphics/gtk/FontCustomPlatformData.h: Removed.
              * platform/graphics/gtk/FontPlatformData.h: Removed.
              * platform/graphics/gtk/FontPlatformDataGtk.cpp: Removed.
              * platform/graphics/gtk/GlyphPageTreeNodeGtk.cpp: Removed.
              * platform/graphics/gtk/SimpleFontDataGtk.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b25a5690
    • eric@webkit.org's avatar
      2010-03-04 Evan Stade <estade@chromium.org> · 6c5bb944
      eric@webkit.org authored
              Reviewed by David Levin.
      
              https://bugs.webkit.org/show_bug.cgi?id=35261
              [skia] crash when attempting to render certain SVGs with Skia
      
              This test passes if it doesn't crash.
      
              * platform/mac/Skipped: Skip the test on Mac, where it crashes.
              * svg/custom/tiling-regular-hexagonal-crash-expected.txt: Added.
              * svg/custom/tiling-regular-hexagonal-crash.svg: Added.
      2010-03-04  Evan Stade  <estade@chromium.org>
      
              Reviewed by David Levin.
      
              https://bugs.webkit.org/show_bug.cgi?id=35261
              [skia] crash when attempting to render certain SVGs
      
              This fixes the crash, but the SVG still doesn't render properly.
      
              Test: svg/custom/tiling-regular-hexagonal-crash.svg
      
              * platform/graphics/skia/ImageSkia.cpp:
              (WebCore::BitmapImageSingleFrameSkia::create): don't return 0 when
              the copy fails; instead return a blank bitmap. The caller doesn't
              check for 0 before dereferencing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c5bb944
    • tony@chromium.org's avatar
      2010-03-04 Tony Chang <tony@chromium.org> · 565f2315
      tony@chromium.org authored
              Reviewed by Darin Fisher.
      
              Initialize m_isMultipartPayload in other ResourceResponse ctor.
              In r55451 (bug 35628) I added an extra bool, but only initialized
              it in one constructor.
              https://bugs.webkit.org/show_bug.cgi?id=35719
      
              * platform/network/chromium/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      565f2315
  2. 03 Mar, 2010 27 commits
    • ukai@chromium.org's avatar
      2010-03-03 Yuta Kitamura <yutak@chromium.org> · d60141d7
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Add a new class that stores information about Web Socket handshake request.
      
              Instances of this class contain the necessary information to send a Web Socket
              handshake request. In the future, this class will provide request information
              to the Web Inspector.
      
              WebSocketHandshake needs to provide request information
              https://bugs.webkit.org/show_bug.cgi?id=34784
      
              No new tests, since the current tests will suffice (LayoutTests/websocket/*).
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * websockets/WebSocketChannel.cpp:
              * websockets/WebSocketHandshake.cpp:
              (WebCore::WebSocketHandshake::clientHandshakeMessage):
              (WebCore::WebSocketHandshake::clientHandshakeRequest):
              * websockets/WebSocketHandshake.h:
              * websockets/WebSocketHandshakeRequest.cpp: Added.
              (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest):
              (WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest):
              (WebCore::WebSocketHandshakeRequest::addExtraHeaderField):
              (WebCore::WebSocketHandshakeRequest::headerFields):
              (WebCore::WebSocketHandshakeRequest::host):
              * websockets/WebSocketHandshakeRequest.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d60141d7
    • eric@webkit.org's avatar
      2010-03-03 Laszlo Gombos <laszlo.1.gombos@nokia.com> · f0abe7b4
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Build fix after r55452.
      
              No new tests, this is a build fix.
      
              * page/Settings.cpp:
              (WebCore::Settings::setDatabasesEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0abe7b4
    • eric@webkit.org's avatar
      2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org> · 70b14116
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
      
              LayoutTests:
                  fast/events/key-events-in-input-text.html
                  fast/events/special-key-events-in-input-text.html
      
              [Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
              https://bugs.webkit.org/show_bug.cgi?id=35694
      
              * platform/qt/Skipped:
      2010-03-03  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
      
              LayoutTests:
                  fast/events/key-events-in-input-text.html
                  fast/events/special-key-events-in-input-text.html
      
              [Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
              https://bugs.webkit.org/show_bug.cgi?id=35694
      
              * platform/qt/PlatformKeyboardEventQt.cpp:
              (WebCore::keyIdentifierForQtKeyCode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b14116
    • eric@webkit.org's avatar
      2010-03-03 Chad Faragher <wyck@chromium.org> · 1d30efea
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Changed the double-click framework code to pass adjusted page
              coordinates for zoomed pages.  Added a new test to expose
              mistreatment of mouse click coordinates during a double-click.
      
              https://bugs.webkit.org/show_bug.cgi?id=35690
      
              * fast/events/zoom-dblclick-expected.txt: Added.
              * fast/events/zoom-dblclick.html: Added.
      2010-03-03  Chad Faragher  <wyck@chromium.org>
      
              Reviewed by Darin Adler.
              Changed the double-click framework code to pass adjusted page
              coordinates for zoomed pages.  Added a new test to expose
              mistreatment of mouse click coordinates during a double-click.
      
              https://bugs.webkit.org/show_bug.cgi?id=35690
      
              Test: fast/events/zoom-dblclick.html
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchMouseEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d30efea
    • levin@chromium.org's avatar
      No review, rolling out r55474. · ab8390da
      levin@chromium.org authored
      The patch broke fast/frames/sandboxed-iframe-storage.html
      
      Last one (I hope).
      
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab8390da
    • levin@chromium.org's avatar
      No review, rolling out r55474. · 9aac0415
      levin@chromium.org authored
      The patch broke fast/frames/sandboxed-iframe-storage.html
      
      Unfortunately, (the webkit-patch rollout and) I missed these in r55485.
      
      WebCore:
      
      * bindings/js/JSDatabaseCallback.cpp: Removed.
      * bindings/js/JSDatabaseCallback.h: Removed.
      * bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
      * bindings/v8/custom/V8DatabaseCallback.h: Removed.
      * storage/DatabaseCallback.h: Removed.
      
      LayoutTests:
      
      * storage/open-database-creation-callback-expected.txt: Removed.
      * storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
      * storage/open-database-creation-callback-isolated-world.html: Removed.
      * storage/open-database-creation-callback.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aac0415
    • dumi@chromium.org's avatar
      Fix a bug that could lead to a crash. Some parts of · 3187f511
      dumi@chromium.org authored
      SQLTransaction::checkAndHandleClosedDatabase() should only be run
      when that method is invoked on the DB thread.
      
      Reviewed by Dimitri Glazkov.
      
      We cannot test this fix with a test, because the crash happens
      only when all of the following conditions are met:
      1. A database is closing.
      2. A transaction on that database is in progress.
      3. The transaction is in a state where a statement/transaction
      success/error callback needs to be invoked (so there's a task for
      this transaction pending on the main thread).
      4. The DB thread finished processing all its tasks and called
      SQLTransactionCoordinator::shutdown() before the main thread go to
      that task.
      
      The closest thing we have to a test is running
      LayoutTests/storage/database-lock-after-reload.html 1000 times in
      a row. Without the patch, the probability of a crash happening in
      one of the runs is very high. With the patch, the test should
      reliably run 1000 times in a row without a single crash.
      
      https://bugs.webkit.org/show_bug.cgi?id=35624
      
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::checkAndHandleClosedDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3187f511
    • darin@chromium.org's avatar
      2010-03-03 Darin Fisher <darin@chromium.org> · c273e671
      darin@chromium.org authored
              Reviewed by Mark Rowe.
      
              Page should not care about Chromium plug-in implementation details
              https://bugs.webkit.org/show_bug.cgi?id=35623
      
              * WebCore.gypi: Compile PluginViewNone.cpp
              * page/Page.cpp:
              (WebCore::Page::privateBrowsingStateChanged): Remove conditional
              compilation for PLATFORM(CHROMIUM).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c273e671
    • levin@chromium.org's avatar
      2010-03-03 David Levin <levin@chromium.org> · fb077e5f
      levin@chromium.org authored
              No review, rolling out r55474.
              http://trac.webkit.org/changeset/55480
      
              The patch broke fast/frames/sandboxed-iframe-storage.html
      
              * Android.jscbindings.mk:
              * Android.v8bindings.mk:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * dom/Document.cpp:
              (WebCore::Document::postTask):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::openDatabase):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * storage/Database.cpp:
              (WebCore::Database::openDatabase):
              (WebCore::Database::Database):
              (WebCore::Database::performOpenAndVerify):
              * storage/Database.h:
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::openDatabase):
              * workers/WorkerContext.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb077e5f
    • levin@chromium.org's avatar
      2010-03-03 David Levin <levin@chromium.org> · 1bc093fb
      levin@chromium.org authored
              No review, rolling out r55480.
              http://trac.webkit.org/changeset/55480
      
              The patch broke fast/frames/sandboxed-iframe-storage.html
      
              * storage/Database.cpp:
              * storage/Database.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bc093fb
    • mrowe@apple.com's avatar
      Add virtual memory tags for TCMalloc and WebCore's purgeable buffers. · 2b0fad29
      mrowe@apple.com authored
      Reviewed by Geoff Garen.
      
      JavaScriptCore:
      
      * wtf/TCSystemAlloc.cpp:
      (TryMmap): Use the VM tag.
      * wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
      
      WebCore:
      
      * platform/mac/PurgeableBufferMac.cpp:
      (WebCore::PurgeableBuffer::create):  Use the VM tag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b0fad29
    • dumi@chromium.org's avatar
      Move #include "DatabaseCallback.h" from Database.h to · ae4b74f0
      dumi@chromium.org authored
      Database.cpp.
      
      Reviewed by nobody, build fix.
      
      * storage/Database.cpp:
      * storage/Database.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae4b74f0
    • darin@apple.com's avatar
      Fixed Mac build. · 8adba0d3
      darin@apple.com authored
      * WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
      be used in the WebKit project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8adba0d3
    • ap@apple.com's avatar
      Reviewed by Adele Peterson. · 9a3ec0a6
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35044
              Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
      
              I'm often getting a crash even when opening the test for the first time in Safari, but it
              doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
              this condition, so no new regression test.
      
              * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining
              input will pause parsing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a3ec0a6
    • dumi@chromium.org's avatar
      WebCore: Adding support for the optional creation callback that could be · 2d346ae6
      dumi@chromium.org authored
      passed to openDatabase().
      
      Reviewed by Adam Barth.
      
      Test: storage/open-database-creation-callback.html
      
      https://bugs.webkit.org/show_bug.cgi?id=34726
      
      * Android.jscbindings.mk
      * Android.v8bindings.mk
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::openDatabase):
      * bindings/js/JSDatabaseCallback.cpp: Added.
      (WebCore::JSDatabaseCallback::JSDatabaseCallback):
      (WebCore::JSDatabaseCallback::~JSDatabaseCallback):
      (WebCore::JSDatabaseCallback::handleEvent):
      * bindings/js/JSDatabaseCallback.h: Added.
      (WebCore::JSDatabaseCallback::create):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::openDatabaseCallback):
      * bindings/v8/custom/V8DatabaseCallback.cpp: Added.
      (WebCore::V8DatabaseCallback::V8DatabaseCallback):
      (WebCore::V8DatabaseCallback::~V8DatabaseCallback):
      (WebCore::V8DatabaseCallback::handleEvent):
      * bindings/v8/custom/V8DatabaseCallback.h: Added.
      (WebCore::V8DatabaseCallback::create):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::openDatabase):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * storage/Database.cpp:
      (WebCore::DatabaseCreationCallbackTask::create):
      (WebCore::DatabaseCreationCallbackTask::performTask):
      (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
      (WebCore::Database::openDatabase):
      (WebCore::Database::Database):
      (WebCore::Database::performOpenAndVerify):
      (WebCore::Database::performCreationCallback):
      * storage/Database.h:
      (WebCore::Database::isNew):
      * storage/DatabaseCallback.h: Added.
      (WebCore::DatabaseCallback::~DatabaseCallback):
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::openDatabase):
      * workers/WorkerContext.h:
      
      LayoutTests: Adding a test to test the creation callback passed to
      openDatabase() and another one to make sure it is executed in the
      correct world.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=34726
      
      * storage/open-database-creation-callback-expected.txt: Added.
      * storage/open-database-creation-callback.html: Added.
      * storage/open-database-creation-callback-isolated-world-expected.txt: Added.
      * storage/open-database-creation-callback-isolated-world.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d346ae6
    • apavlov@chromium.org's avatar
      2010-03-03 Alexander Pavlov <apavlov@chromium.org> · 6c34e6d6
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: resources panel only shows uncompressed resource size.
              https://bugs.webkit.org/show_bug.cgi?id=35403
      
              * English.lproj/localizedStrings.js:
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              * inspector/front-end/AbstractTimelinePanel.js:
              (WebInspector.AbstractTimelinePanel.prototype.refresh):
              * inspector/front-end/AuditRules.js:
              (WebInspector.AuditRules.GzipRule.prototype.doRun):
              (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
              * inspector/front-end/ImageView.js:
              (WebInspector.ImageView):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get resourceSize):
              (WebInspector.Resource.prototype.set resourceSize):
              (WebInspector.Resource.prototype.get transferSize):
              (WebInspector.Resource.CompareBySize):
              (WebInspector.Resource.CompareByTransferSize):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.populateSidebar):
              (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
              (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
              (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages):
              (WebInspector.ResourceTransferSizeCalculator.prototype._value):
              (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes):
              (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize):
              (WebInspector.ResourceGraph.prototype.refreshLabelPositions):
              (WebInspector.ResourceGraph.prototype.refresh):
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c34e6d6
    • mitz@apple.com's avatar
      Build fix. · 829eca9c
      mitz@apple.com authored
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      829eca9c
    • pfeldman@chromium.org's avatar
      2010-03-03 Pavel Feldman <pfeldman@chromium.org> · 6ad21836
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
      
              https://bugs.webkit.org/show_bug.cgi?id=32331
      
              * inspector/InspectorBackend.cpp:
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled):
              (WebInspector.ProfilesPanel.prototype._updateInterface):
              (WebInspector.ProfilesPanel.prototype._enableProfiling):
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
              (WebInspector.ScriptsPanel.prototype._enableDebugging):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad21836
    • eric.carlson@apple.com's avatar
      2010-03-03 Eric Carlson <eric.carlson@apple.com> · 9f8dbf40
      eric.carlson@apple.com authored
              Reviewed by Adele Peterson.
      
              Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
              https://bugs.webkit.org/show_bug.cgi?id=35385
              rdar://problem/7689602
      
              Tests: media/audio-constructor-preload.html
                     media/video-dom-preload.html
      
              * html/HTMLAttributeNames.in: Remove autobuffer, add preload
      
              * html/HTMLAudioElement.cpp:
              (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of 
                  autobuffer to true.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload.
              (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute.
              (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
                  before calling load() so it can pass the setting through to the media engine.
              (WebCore::HTMLMediaElement::preload): New.
              (WebCore::HTMLMediaElement::setPreload): Ditto
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload.
              (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine.
              (WebCore::MediaPlayer::preload): New, return m_preload.
              (WebCore::MediaPlayer::setPreload): New, set m_preload.
              * platform/graphics/MediaPlayer.h:
              (WebCore::MediaPlayer::):
              * platform/graphics/MediaPlayerPrivate.h:
              (WebCore::MediaPlayerPrivateInterface::setPreload):
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
      
      2010-03-03  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson.
      
              Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
              https://bugs.webkit.org/show_bug.cgi?id=35385
              rdar://problem/7689602
      
              * media/audio-constructor-autobuffer-expected.txt: Removed.
              * media/audio-constructor-autobuffer.html: Removed.
              * media/audio-constructor-preload-expected.txt: Added.
              * media/audio-constructor-preload.html: Added.
              * media/video-dom-autobuffer-expected.txt: Removed.
              * media/video-dom-autobuffer.html: Removed.
              * media/video-dom-preload-expected.txt: Added.
              * media/video-dom-preload.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f8dbf40
    • mitz@apple.com's avatar
      <rdar://problem/7682756> Assertion failure when replacing the contents of a <select> · 1aa6c4d3
      mitz@apple.com authored
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      Test: fast/dom/remove-children-notification-order.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
      before calling removedFromDocument() on each removed child, which matches
      the order removeChild() does things, and avoids the assertion. This required
      temporarily storing the removed children in a vector.
      Also added comments about other discrepancies between this function and
      removeChild().
      
      LayoutTests: 
      
      * fast/dom/remove-children-notification-order-expected.txt: Added.
      * fast/dom/remove-children-notification-order.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa6c4d3
    • abarth@webkit.org's avatar
      2010-03-03 Adam Barth <abarth@webkit.org> · 7d9798f1
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Document cookieURL and firstPartyForCookies
              https://bugs.webkit.org/show_bug.cgi?id=35613
      
              Some folks asked what the cookieURL and the firstPartyForCookies were
              on IRC.  This patch documents these properties in the code so folks
              don't have to ask on IRC anymore.
      
              * dom/Document.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d9798f1
    • eric@webkit.org's avatar
      2010-03-03 Arno Renevier <arno@renevier.net> · dcd44188
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
              https://bugs.webkit.org/show_bug.cgi?id=35666
      
              * platform/gtk/GeolocationServiceGtk.cpp:
              (WebCore::GeolocationServiceGtk::startUpdating):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcd44188
    • eric@webkit.org's avatar
      2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch> · bb8e89f9
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              Miscellaneous little fixes for the windows build of webkit-gtk
              https://bugs.webkit.org/show_bug.cgi?id=35640
      
              * GNUmakefile.am: On Windows with GCC, presence of
              __declspec(dllexport) on some symbols disables the autoexport/autoimport
              feature for all others. Using regex here assures that all symbols that
              need to be exported in the dll are actually exported.
      2010-03-03  Fridrich Strba  <fridrich.strba@bluewin.ch>
      
              Reviewed by Xan Lopez.
      
              Miscellaneous little fixes for the windows build of webkit-gtk
              https://bugs.webkit.org/show_bug.cgi?id=35640
      
              * GNUmakefile.am: dist two new files concerning mathml support.
      2010-03-03  Fridrich Strba  <fridrich.strba@bluewin.ch>
      
              Reviewed by Xan Lopez.
      
              Miscellaneous little fixes for the windows build of webkit-gtk
              https://bugs.webkit.org/show_bug.cgi?id=35640
      
              * webkit/webkitdownload.cpp: Windows headers define ERROR
              which breaks the build. Undef ERROR if it is defined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb8e89f9
    • xan@webkit.org's avatar
      2010-03-03 Xan Lopez <xlopez@igalia.com> · 471d48bb
      xan@webkit.org authored
              Unreviewed distcheck fix.
      
              Add new file to the build.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      471d48bb
    • antti@apple.com's avatar
      Make IntPoint usable as a hash key · ff82af27
      antti@apple.com authored
              
      Reviewed by Oliver Hunt.
      
      https://bugs.webkit.org/show_bug.cgi?id=35586
      
      * WebCore.pro:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/IntPointHash.h: Added.
      (WTF::IntPointHash::hash):
      (WTF::IntPointHash::equal):
      (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff82af27
    • eric@webkit.org's avatar
      2010-03-02 Eric Uhrhane <ericu@chromium.org> · 3b6686bf
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * WebCore.base.exp: Export Database::setIsAvailable
              * WebCore.xcodeproj/project.pbxproj: Export needed headers as Private
              * page/DOMWindow.cpp: Read isAvailable, not Settings::isDatabaseEnabled
              (WebCore::DOMWindow::openDatabase):
              * page/Settings.cpp:  Add a call to Database::setIsAvailable.
              (WebCore::Settings::setDatabasesEnabled):
      2010-03-02  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * webkit/webkitwebview.cpp:  Add calls to Database::setIsAvailable
              (DNDContentsRequest::webkit_web_view_update_settings):
              (DNDContentsRequest::webkit_web_view_settings_notify):
      2010-03-02  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * WebView/WebView.mm:  Added a call to Database::setIsAvailable.
              (-[WebView _preferencesChangedNotification:]):
      2010-03-02  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * Api/qwebsettings.cpp:
              (QWebSettingsPrivate::apply):  Add a call to Database::setIsAvailable
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b6686bf
    • tony@chromium.org's avatar
      2010-03-02 Tony Chang <tony@chromium.org> · 55f35a76
      tony@chromium.org authored
              Reviewed by Darin Fisher.
      
              add a flag to WebURLResponse so we can identify multipart content
              https://bugs.webkit.org/show_bug.cgi?id=35628
      
              * platform/network/chromium/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              (WebCore::ResourceResponse::isMultipartPayload):
              (WebCore::ResourceResponse::setIsMultipartPayload):
      2010-03-02  Tony Chang  <tony@chromium.org>
      
              Reviewed by Darin Fisher.
      
              add a flag to WebURLResponse so we can identify multipart content
              https://bugs.webkit.org/show_bug.cgi?id=35628
      
              * public/WebURLResponse.h:
              * src/WebURLResponse.cpp:
              (WebKit::WebURLResponse::isMultipartPayload):
              (WebKit::WebURLResponse::setIsMultipartPayload):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55f35a76
  3. 02 Mar, 2010 1 commit