1. 25 Apr, 2012 40 commits
    • mhahnenberg@apple.com's avatar
      WebCore shouldn't call collectAllGarbage directly · 34edae48
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84897
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Exported symbol
      for reportAbanondedObjectGraph so WebCore can use it.
      * heap/Heap.h: Ditto.
      
      Source/WebCore:
      
      No new tests.
      
      Currently, GCController calls Heap::collectAllGarbage directly, which leads
      to an overload of collections as the timer in GCController and the timer in
      GCActivityCallback compete for collection time and fire independently. As a
      result, we end up doing almost 600 full collections during an in-browser run
      of SunSpider, or 20 full collections on a single load of TechCrunch.
      
      We can do better by preventing WebCore from calling collectAllGarbage directly
      and instead going through Heap::reportAbandonedObjectGraph, since that is what
      WebCore is trying to do--notify the Heap that a lot of garbage may have just
      been generated when we left a page.
      
      * WebCore.exp.in:
      * bindings/js/GCController.cpp: Removed all timer stuff.
      (WebCore::GCController::GCController):
      (WebCore::GCController::garbageCollectSoon): Changed to call Heap::reportAbandonedObjectGraph.
      (WebCore::GCController::garbageCollectNow): Changed to still directly call collectAllGarbage.
      We will deprecate this function soon hopefully.
      * bindings/js/GCController.h: Removed timer stuff.
      (GCController):
      * bindings/js/ScriptProfiler.cpp:
      (WebCore::ScriptProfiler::collectGarbage): Changed to call garbageCollectSoon.
      
      Source/WebKit2:
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::didClose): Changed to call garbageCollectSoon. This is the
      function that causes us to do so much collection on page navigation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34edae48
    • mhahnenberg@apple.com's avatar
      fast/js/random-array-gc-stress times out in debug mode · dcddfdb7
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84821
      
      Reviewed by Geoffrey Garen.
      
      * fast/js/script-tests/random-array-gc-stress.js: Trying a lower number of iterations
      to make the slow bots happy.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcddfdb7
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r115240. · 4888a32f
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/115240
      https://bugs.webkit.org/show_bug.cgi?id=84928
      
      It broke everything (Requested by Ossy_HOME on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-25
      
      * Scripts/webkitpy/layout_tests/port/gtk.py:
      (GtkDriver):
      (GtkDriver._start):
      (GtkDriver._start.x_filter):
      (GtkDriver.stop):
      (GtkPort._driver_class):
      * Scripts/webkitpy/layout_tests/port/qt.py:
      (QtPort._build_driver):
      * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4888a32f
    • commit-queue@webkit.org's avatar
      [chromium] REGRESSION(112286) Compositor initialization blocks for program compilation / linking · 2a9f93d8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84822
      
      Patch by James Robinson <jamesr@chromium.org> on 2012-04-25
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      r112286 introduced a subtle regression in the chromium compositor startup sequence - by querying the texture
      copy program's uniform location at the end of LayerRendererChromium::initialize(), the compositor's thread was
      blocked until the service side compiled _all_ eagerly initialized shaders. The intent of the way the compositor
      programs are created is that a set of commonly-used programs are sent to the service side, but no blocking calls
      are made until after we go through the first paint (with the hope that the service side will complete the
      compilation by then).
      
      Fixed by moving program initialization (which also grabs uniform locations) until the first actual use of the
      copier. It may be worth deferring the program initialization completely if it's not used very often.
      
      Added unit test in LayerRendererChromiumTests to make sure LRC initialization does not make any
      synchronous calls (like getUniformLocation()).
      
      * platform/graphics/chromium/TextureCopier.cpp:
      (WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
      (WebCore::AcceleratedTextureCopier::copyTexture):
      
      Source/WebKit/chromium:
      
      Add a test that makes sure we don't make blocking calls during LayerRendererChromium initialization.
      
      * tests/LayerRendererChromiumTest.cpp:
      (ForbidSynchronousCallContext):
      (ForbidSynchronousCallContext::ForbidSynchronousCallContext):
      (ForbidSynchronousCallContext::finish):
      (ForbidSynchronousCallContext::getActiveAttrib):
      (ForbidSynchronousCallContext::getActiveUniform):
      (ForbidSynchronousCallContext::getAttachedShaders):
      (ForbidSynchronousCallContext::getAttribLocation):
      (ForbidSynchronousCallContext::getBooleanv):
      (ForbidSynchronousCallContext::getBufferParameteriv):
      (ForbidSynchronousCallContext::getContextAttributes):
      (ForbidSynchronousCallContext::getError):
      (ForbidSynchronousCallContext::getFloatv):
      (ForbidSynchronousCallContext::getFramebufferAttachmentParameteriv):
      (TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a9f93d8
    • commit-queue@webkit.org's avatar
      [BlackBerry] Authenticated proxy isn't working. · 6fdce335
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84579
      
      Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-25
      Reviewed by Antonio Gomes.
      
      We should try to get username and password from WiFi advanced configuration first
      when 407 is received.
      
      No new tests. This is covered by existing http tests when proxy's username and password
      are configured for WiFi.
      
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::sendRequestWithCredentials):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fdce335
    • commit-queue@webkit.org's avatar
      Rebaseline *.png pixel test files after bug 84649 fix · e0934a05
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84905
      
      Patch by David Barton <dbarton@mathscribe.com> on 2012-04-25
      Reviewed by Beth Dakin.
      
      * platform/mac/mathml/presentation/fenced-expected.png:
      * platform/mac/mathml/presentation/fenced-mi-expected.png:
      * platform/mac/mathml/presentation/mo-expected.png:
      * platform/mac/mathml/presentation/mo-stretch-expected.png:
      * platform/mac/mathml/presentation/over-expected.png:
      * platform/mac/mathml/presentation/row-alignment-expected.png:
      * platform/mac/mathml/presentation/row-expected.png:
      * platform/mac/mathml/presentation/sub-expected.png:
      * platform/mac/mathml/presentation/subsup-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0934a05
    • commit-queue@webkit.org's avatar
      IndexedDB: implement cursor.advance() · 0d735253
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84174
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Implement IDBCursor.advance() to spec.
      
      Test: storage/indexeddb/cursor-advance.html
      
      * Modules/indexeddb/IDBBackingStore.h:
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::advance):
      (WebCore):
      * Modules/indexeddb/IDBCursor.h:
      (IDBCursor):
      * Modules/indexeddb/IDBCursor.idl:
      * Modules/indexeddb/IDBCursorBackendImpl.cpp:
      (WebCore::IDBCursorBackendImpl::advance):
      (WebCore):
      (WebCore::IDBCursorBackendImpl::advanceInternal):
      * Modules/indexeddb/IDBCursorBackendImpl.h:
      (IDBCursorBackendImpl):
      * Modules/indexeddb/IDBCursorBackendInterface.h:
      * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
      (WebCore):
      
      Source/WebKit/chromium:
      
      Hook up chromium IPC to IDBCursor.advance().
      
      * src/IDBCursorBackendProxy.cpp:
      (WebKit::IDBCursorBackendProxy::advance):
      (WebKit):
      * src/IDBCursorBackendProxy.h:
      (IDBCursorBackendProxy):
      * src/WebIDBCursorImpl.cpp:
      (WebKit::WebIDBCursorImpl::advance):
      
      LayoutTests:
      
      Tests for cursor.advance().
      
      * storage/indexeddb/cursor-advance-expected.txt: Added.
      * storage/indexeddb/cursor-advance.html: Added.
      * storage/indexeddb/resources/cursor-advance.js: Added.
      (test):
      (openSuccess):
      (createAndPopulateObjectStore):
      (makeAdvanceTest.continueToTest):
      (makeAdvanceTest.request.onerror):
      (makeAdvanceTest):
      (mkCursor):
      (runTest):
      (testAll):
      (testSimple):
      (testContinueThenAdvance):
      (testAdvanceMultiple):
      (testAdvanceToEnd):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d735253
    • enne@google.com's avatar
      [chromium] Hold video provider lock from willDraw to didDraw · 7bb43998
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84805
      
      Reviewed by James Robinson.
      
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      (WebCore::CCVideoLayerImpl::willDraw):
      (WebCore):
      (WebCore::CCVideoLayerImpl::willDrawInternal):
      (WebCore::CCVideoLayerImpl::appendQuads):
      (WebCore::CCVideoLayerImpl::didDraw):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bb43998
    • charles.wei@torchmobile.com.cn's avatar
      [BlackBerry] Input Range element expects mouse events · c7cfe89f
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=84571
      
      Reviewed by Antonio Gomes.
      
      This just cleans up the code a bit to make it less code and more readable.
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::shouldConvertTouchToMouse):
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      (BlackBerry::WebKit::TouchEventHandler::spellCheck):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7cfe89f
    • hclam@chromium.org's avatar
      Unreviewed, rolling out r115262. · 780f1fca
      hclam@chromium.org authored
      http://trac.webkit.org/changeset/115262
      https://bugs.webkit.org/show_bug.cgi?id=84631
      
      r115262 is causing link error in WebKit Win Builder (dbg)
      
      * public/WebIDBDatabase.h:
      (WebKit::WebIDBDatabase::createObjectStore):
      * public/WebIDBIndex.h:
      (WebKit::WebIDBIndex::keyPath):
      (WebKit::WebIDBIndex::keyPathString):
      * public/WebIDBKeyPath.h:
      (WebKit):
      (WebIDBKeyPath):
      * public/WebIDBObjectStore.h:
      (WebKit::WebIDBObjectStore::keyPath):
      (WebKit::WebIDBObjectStore::keyPathString):
      (WebKit::WebIDBObjectStore::createIndex):
      * public/platform/WebKitPlatformSupport.h:
      (WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
      (WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
      * src/IDBIndexBackendProxy.cpp:
      (WebKit::IDBIndexBackendProxy::keyPath):
      * src/IDBObjectStoreBackendProxy.cpp:
      (WebKit::IDBObjectStoreBackendProxy::keyPath):
      * src/WebIDBDatabaseImpl.h:
      (WebIDBDatabaseImpl):
      * src/WebIDBIndexImpl.cpp:
      * src/WebIDBIndexImpl.h:
      (WebIDBIndexImpl):
      * src/WebIDBKeyPath.cpp:
      (WebKit::WebIDBKeyPath::create):
      (WebKit::WebIDBKeyPath::assign):
      (WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&):
      * src/WebIDBObjectStoreImpl.cpp:
      * src/WebIDBObjectStoreImpl.h:
      (WebIDBObjectStoreImpl):
      (WebKit::WebIDBObjectStoreImpl::createIndex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      780f1fca
    • enne@google.com's avatar
      [chromium] Prevent CCLayerImpl::willDraw/didDraw mismatches · 66542893
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84812
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Because some layers lock/unlock resources, it needs to be guaranteed
      that if willDraw is called on a layer then didDraw will also be called
      on that layer before another willDraw or before layer destruction. Add
      asserts to make sure that this is the case.
      
      willDraw is called via CCLayerTreeHostImpl::prepareToDraw ->
      calculateRenderPasses. didDraw was previously called in
      CCLayerTreeHostImpl::drawLayers. Sometimes drawLayers was being
      skipped by the caller of these functions based on what prepareToDraw
      returned (causing didDraw to not be called). Fix this by having an
      explicit step to call didDraw on all layers. This new didDrawAllLayers
      function must be called if and only if prepareToDraw is called.
      
      Tested by existing tests via new asserts in CCLayerImpl.
      
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      (WebCore::CCLayerImpl::CCLayerImpl):
      (WebCore::CCLayerImpl::~CCLayerImpl):
      (WebCore::CCLayerImpl::willDraw):
      (WebCore):
      (WebCore::CCLayerImpl::didDraw):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (CCLayerImpl):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::drawLayers):
      (WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
      (WebCore):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      (CCLayerTreeHostImpl):
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
      (WebCore::CCScrollbarLayerImpl::willDraw):
      (WebCore::CCScrollbarLayerImpl::didDraw):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      (WebCore::CCSingleThreadProxy::doComposite):
      * platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
      (WebCore::CCTextureLayerImpl::willDraw):
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      (WebCore::CCVideoLayerImpl::willDraw):
      (WebCore::CCVideoLayerImpl::didDraw):
      
      Source/WebKit/chromium:
      
      Update all tests to call CCLayerTreeHostImpl::didDrawAllLayers if they
      call CCLayerTreeHostImpl::prepareToDraw.
      
      * tests/CCLayerTreeHostImplTest.cpp:
      (WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
      (WebKitTests::TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66542893
    • tkent@chromium.org's avatar
      Calendar Picker: Resize to minimal size to fit the content · 5cc74afd
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84826
      
      Reviewed by Hajime Morita.
      
      .:
      
      * ManualTests/forms/calendar-picker.html:
      Sync with the size specified in CalendarPickerElement.cpp.
      
      Source/WebCore:
      
      Using fixed-size popup isn't nice. The calender picker popup size should
      be minimal.
      
      The minimal size depends on font settings, localized labels, and
      localized formats. So we put visible objects on a transparent element,
      calculate minimal size, resize the popup, then show the objects.
      
      * Resources/calendarPicker.css:
      (body): Don't use purple. It was for debugging purpose.
      The body is visible for a short period becuse we use transparent element.
      (#main):
       - Add nowrap to avoid text wrapping.
       - Add wider width to avoid wrapping.
       - Add opacity to hide incomplete layout.
      (.year-month-upper): Don't set flexible box yet.
      (.month-selector-box): Fix incorrect display value.
      (.days-area):
      Don't set table-layout:fixed and width:100% in order that it has the
      minimal width.
      
      * Resources/calendarPicker.js:
      (initialize): Make a new functio to resize.
      (fixWindowSize):
      Compute the required width from the right edge of the next year button,
      the maximum cell width, and so on.  Then, set CSS properties to have
      correct layout.
      (YearMonthController.prototype.attachTo):
      Set min-width property for a long year-month string.
      (YearMonthController.prototype._showPopup):
      Center the _monthPopup vertically.
      
      * html/shadow/CalendarPickerElement.cpp:
      (WebCore::CalendarPickerElement::contentSize):
      Specify small size for the initial size. It's better than showing a
      large window then shrink the size.
      * page/PagePopupClient.h:
      (PagePopupClient): Remove a false comment. We should support resize*().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc74afd
    • hclam@chromium.org's avatar
      Unreviewed, rolling out r115260. · 2771496d
      hclam@chromium.org authored
      http://trac.webkit.org/changeset/115260
      https://bugs.webkit.org/show_bug.cgi?id=84467
      
      r115260 is crashing a list of IndexDB tests, revert.
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
      (WebCore):
      * platform/leveldb/LevelDBTransaction.cpp:
      (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
      (WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
      * platform/leveldb/LevelDBTransaction.h:
      (TransactionIterator):
      
      LayoutTests:
      
      * storage/indexeddb/cursor-added-bug-expected.txt: Removed.
      * storage/indexeddb/cursor-added-bug.html: Removed.
      * storage/indexeddb/resources/cursor-added-bug.js: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2771496d
    • simonjam@chromium.org's avatar
      [Web Timing] Add a vendor-prefixed Performance Timeline API · b7dff976
      simonjam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80350
      
      As described here: http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html
      
      The API is there and should be correct, but it isn't particularly useful,
      because nothing is populated. Upcoming changes will add Navigation Timing
      and Resource Timing.
      
      Reviewed by Tony Gentilcore.
      
      No new tests. Functionality is disabled on all platforms.
      
      * CMakeLists.txt: Added PerformanceEntry* files.
      * DerivedSources.pri: Ditto.
      * GNUmakefile.list.am: Ditto.
      * WebCore.gypi: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * page/Performance.cpp:
      (WebCore::Performance::webkitGetEntries): Added.
      (WebCore::Performance::webkitGetEntriesByType): Added.
      (WebCore::Performance::webkitGetEntriesByName): Added.
      * page/Performance.h:
      (Performance):
      * page/Performance.idl:
      * page/PerformanceEntry.cpp: Added.
      (WebCore):
      (WebCore::PerformanceEntry::PerformanceEntry):
      (WebCore::PerformanceEntry::name):
      (WebCore::PerformanceEntry::entryType):
      (WebCore::PerformanceEntry::startTime):
      (WebCore::PerformanceEntry::duration):
      * page/PerformanceEntry.h: Added.
      (WebCore):
      (PerformanceEntry):
      * page/PerformanceEntry.idl: Added.
      * page/PerformanceEntryList.cpp: Added.
      (WebCore):
      (WebCore::PerformanceEntryList::PerformanceEntryList):
      (WebCore::PerformanceEntryList::~PerformanceEntryList):
      (WebCore::PerformanceEntryList::length):
      (WebCore::PerformanceEntryList::item):
      (WebCore::PerformanceEntryList::append):
      * page/PerformanceEntryList.h: Added.
      (WebCore):
      (PerformanceEntryList):
      (WebCore::PerformanceEntryList::create):
      * page/PerformanceEntryList.idl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7dff976
    • dglazkov@chromium.org's avatar
      Remove unnecessary timeouts (and closures) from content-element-in-* tests. · 2a950d3b
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84896
      
      These tests don't need any of them. Not sure how they got there in the first place. Oh wait. I reviewed this code. /me hands head in shame.
      
      Reviewed by Ojan Vafai.
      
      * fast/dom/shadow/content-element-in-media-element.html: Removed the timeout and extra closures.
      * fast/dom/shadow/content-element-in-meter-element.html: Ditto.
      * fast/dom/shadow/content-element-in-progress-element.html: Ditto.
      * fast/dom/shadow/content-element-in-select-element.html: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a950d3b
    • darin@apple.com's avatar
      Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value · 5e1b8bc9
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84524
      
      Reviewed by Antti Koivisto.
      
      * wtf/HashMap.h: Added a struct template, HashMapValueTraits, that derives from
      PairHashTraits, adds an isEmptyValue function that looks only at the key, not
      the mapped value, in the hash table value, and uses the isHashTraitsEmptyValue
      function template to check if the key is empty.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e1b8bc9
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=84913 · a8d29c23
      bdakin@apple.com authored
      WebKit 1: Initialize deviceScaleFactor on creation of the WebView
      -and corresponding-
      <rdar://problem/11322716>
      
      Reviewed by Darin Adler.
      
      Before this patch, we weren't setting the deviceScaleFactor until 
      viewDidMoveToWindow which is quite late for background tabs. setHostWindow will 
      happen early on though. For applications that don't use host windows, also set it 
      from _initWithFrame.
      * WebView/WebView.mm:
      (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]):
      (-[WebView setHostWindow:]):
      (-[WebView _deviceScaleFactor]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8d29c23
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=84909 · da0a3759
      bdakin@apple.com authored
      Background tabs are fuzzy until repaint when deviceScaleFactor > 1
      -and corresponding-
      <rdar://problem/11312064>
      
      Rubber-stamped by Darin Adler.
      
      Re-order the parameters of paintBitmapContext to match paintImage.
      * Platform/cg/CGUtilities.cpp:
      (WebKit::paintBitmapContext):
      * Platform/cg/CGUtilities.h:
      (WebKit):
      * UIProcess/mac/BackingStoreMac.mm:
      (WebKit::BackingStore::resetScrolledRect):
      (WebKit::BackingStore::paint):
      (WebKit::BackingStore::backingStoreContext):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da0a3759
    • benjamin@webkit.org's avatar
      Move convertJSMethodNameToObjc() to be a utility function of ObjcClass · c522dbe9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84915
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-25
      Reviewed by Darin Adler.
      
      The function convertJSMethodNameToObjc() is only useful for ObjcClass::methodsNamed().
      
      This patch moves the function from objc_utility.mm to be a static function in objc_class.mm.
      It aims at simplifying the code for future changes of ObjcClass.
      
      * bridge/objc/objc_class.mm:
      (Bindings):
      (JSC::Bindings::convertJSMethodNameToObjc):
      * bridge/objc/objc_utility.h:
      * bridge/objc/objc_utility.mm:
      (Bindings):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c522dbe9
    • dpranke@chromium.org's avatar
      [chromium] change DRT's "DRT" output to match the other ports · e438fc3d
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84904
      
      Reviewed by Kent Tamura.
      
      Since we run Chromium's DRT in --test-shell mode, the
      non-test-shell output has never been really beaten on to make
      sure it's right. This fixes a few issues and will be tested
      with upcoming NRWT changes that'll land in a separate patch.
      In particular we should never output framing text like "\n"
      or "#EOF" outside of something outside of TestEventPrinter,
      and we weren't handling audio output properly at all.
      
      * DumpRenderTree/chromium/TestEventPrinter.cpp:
      (DRTPrinter):
      (TestShellPrinter):
      (DRTPrinter::handleTextFooter):
      (DRTPrinter::handleAudioFooter):
      (DRTPrinter::handleTestFooter):
      (TestShellPrinter::handleAudioFooter):
      * DumpRenderTree/chromium/TestEventPrinter.h:
      (TestEventPrinter):
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::TestShell):
      (TestShell::dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e438fc3d
    • tkent@chromium.org's avatar
      Unreviewed. Sort Xcode project file. · bd73a9ba
      tkent@chromium.org authored
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd73a9ba
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=84909 · 18ff70a1
      bdakin@apple.com authored
      Background tabs are fuzzy until repaint when deviceScaleFactor > 1
      -and corresponding-
      <rdar://problem/11312064>
      
      Reviewed by Darin Adler.
      
      BackingStoreMac paints into a Bitmap instead of a CGLayer when there is no 
      containing window. That bitmap is used for the initial paint when a background tab 
      first comes to he foreground, so it needs to be HiDPI-aware.  
      
      paintBitmapContext() now takes a scale factor that it passes along to paintImage 
      rather than hardcoding a scale factor of 1 for paintImage.
      * Platform/cg/CGUtilities.cpp:
      (WebKit::paintBitmapContext):
      * Platform/cg/CGUtilities.h:
      (WebKit):
      
      When these functions fall into the bitmap case, they need to adopt the device 
      scale factor, which means they need to scale in size by the scale factor, and also 
      scale their context. 
      * UIProcess/mac/BackingStoreMac.mm:
      (WebKit::BackingStore::resetScrolledRect):
      (WebKit::BackingStore::paint):
      (WebKit::BackingStore::backingStoreContext):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18ff70a1
    • achicu@adobe.com's avatar
      [Chromium] Layout Test css3/filters/custom/custom-filter-property-computed-style.html is failing · 66230b81
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84067
      
      Reviewed by Ryosuke Niwa.
      
      All the CSS filters/shaders script tests expected to have a document.styleSheets.item(0) that they could change.
      The script-tests add a <link> that references a CSS file from a different parent folder, so the script
      has no access to the actual rules anymore. Updated all the tests to use createElement("style")
      and get the styleSheet by using el.sheet instead of assuming that there's one style already created.
      
      * css3/filters/script-tests/custom-filter-property-computed-style.js:
      * css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
      (testInvalidFilterRule):
      * css3/filters/script-tests/effect-custom-disabled.js:
      (testInvalidFilterRule):
      * css3/filters/script-tests/filter-property-computed-style.js:
      (testComputedFilterRule):
      * css3/filters/script-tests/filter-property-parsing-invalid.js:
      (testInvalidFilterRule):
      * css3/filters/script-tests/filter-property-parsing.js:
      (testFilterRule):
      * css3/filters/script-tests/filter-property.js:
      * platform/chromium/test_expectations.txt: Removed reference to this bug.
      * platform/mac/css3/filters/custom/custom-filter-property-computed-style-expected.txt: Removed. This is not necessary anymore.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66230b81
    • commit-queue@webkit.org's avatar
      Implement object-literal constructor for the Intent object. · ca27df9d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84220
      
      Patch by Greg Billock <gbillock@google.com> on 2012-04-25
      Reviewed by Kentaro Hara.
      
      The use of the custom constructor will hopefully be temporary, as we plan
      to convert to just using the object literal constructor, which can then use codegen.
      See spec: http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
      
      Added support for the service and extras parameters in the Intent
      object to support the speced members in the object literal constructor.
      
      Added supporting accessor to Dictionary to retrieve a sub-Dictionary,
      and a utility to ScriptValue to serialize with ports.
      
      Test: webintents/web-intent-obj-constructor.html
      
      (WebCore):
      * Modules/intents/Intent.cpp:
      (WebCore::Intent::create):
      (WebCore::Intent::Intent):
      (WebCore::Intent::service):
      (WebCore):
      (WebCore::Intent::extras):
      * Modules/intents/Intent.h:
      (WebCore):
      (Intent):
      * Modules/intents/Intent.idl:
      * WebCore.gypi:
      * bindings/v8/Dictionary.cpp:
      (WebCore::Dictionary::get):
      (WebCore):
      * bindings/v8/Dictionary.h:
      (Dictionary):
      * bindings/v8/ScriptValue.cpp:
      (WebCore::ScriptValue::serialize):
      (WebCore):
      * bindings/v8/ScriptValue.h:
      (WTF):
      (WebCore):
      (ScriptValue):
      * bindings/v8/custom/V8IntentConstructor.cpp: Added.
      (WebCore):
      (WebCore::V8Intent::constructorCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca27df9d
    • achicu@adobe.com's avatar
      CSS Shaders: Use u_texture instead of s_texture. It was updated in the spec · 6b8c9ad4
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82618
      
      Source/WebCore:
      
      Reviewed by Dean Jackson.
      
      Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
      https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html
      
      No new tests, just updating existing ones.
      
      * platform/graphics/filters/CustomFilterShader.cpp:
      (WebCore::CustomFilterShader::defaultFragmentShaderString):
      (WebCore::CustomFilterShader::initializeParameterLocations):
      
      LayoutTests:
      
      Reviewed by Dean Jackson.
      
      Changed the uniform name passed to the CSS Shaders from s_texture to u_texture.
      https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html
      
      * css3/filters/resources/color-add.fs:
      * css3/filters/resources/color-offset-parameters.fs:
      * css3/filters/resources/color-offset.fs:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b8c9ad4
    • jsbell@chromium.org's avatar
      [Chromium] IndexedDB: Use WebIDBKeyPath type for key paths in WebKit API · cd45b189
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84631
      
      Reviewed by James Robinson.
      
      WebIDBKeyPath was previously a utility class for parsing key paths into components,
      but the API exposed key paths only as nullable strings. To support array-type keypaths,
      WebIDBKeyPath becomes a value class with type flags. For landing, several legacy methods
      are retained but will be cleaned up after all callers have been updated, tracked as
      the bug: http://webkit.org/b/84207
      
      * public/WebIDBDatabase.h:
      (WebKit::WebIDBDatabase::createObjectStore): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
      * public/WebIDBIndex.h:
      (WebKit::WebIDBIndex::keyPath): Calls keyPathString if not overridden.
      (WebKit::WebIDBIndex::keyPathString): Comment change.
      * public/WebIDBKeyPath.h:
      (WebKit::WebIDBKeyPath::create): Overload added for creating array-type key paths.
      (WebKit::WebIDBKeyPath::array): Accessor for array-type key paths.
      (WebKit::WebIDBKeyPath::operator const WebString ): Temporary, for compatibility.
      * public/WebIDBObjectStore.h:
      (WebKit::WebIDBObjectStore::keyPath): Calls keyPathString if not overridden.
      (WebKit::WebIDBObjectStore::keyPathString): Comment change.
      (WebKit::WebIDBObjectStore::createIndex): Add WebIDBKeyPath overload; WebString overload delegates so implementers can switch.
      * public/platform/WebKitPlatformSupport.h:
      (WebKitPlatformSupport): WebIDBKeyPath overloads for these methods added, delegate to WebString version until implementers are updated.
      (WebKit::WebKitPlatformSupport::createIDBKeysFromSerializedValuesAndKeyPath):
      (WebKit::WebKitPlatformSupport::injectIDBKeyIntoSerializedValue):
      * src/IDBIndexBackendProxy.cpp:
      (WebKit::IDBIndexBackendProxy::keyPath): Returns the string version until WebCore is updated.
      * src/IDBObjectStoreBackendProxy.cpp:
      (WebKit::IDBObjectStoreBackendProxy::keyPath): Returns the string version until WebCore is updated.
      * src/WebIDBDatabaseImpl.h:
      (WebIDBDatabaseImpl): Add createObjectStore overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
      * src/WebIDBIndexImpl.cpp:
      (WebKit::WebIDBIndexImpl::keyPath): Implements the new WebIDBKeyPath return type.
      (WebKit):
      * src/WebIDBIndexImpl.h:
      (WebIDBIndexImpl): Implements the new WebIDBKeyPath return type.
      * src/WebIDBKeyPath.cpp:
      (WebKit::WebIDBKeyPath::create): Support null key path types.
      (WebKit::WebIDBKeyPath::createNull): New API.
      (WebKit):
      (WebKit::WebIDBKeyPath::isValid): New API.
      (WebKit::WebIDBKeyPath::type): New API.
      (WebKit::WebIDBKeyPath::string): New API (value accessor).
      (WebKit::WebIDBKeyPath::WebIDBKeyPath):
      (WebKit::WebIDBKeyPath::assign): This API will be removed.
      (WebKit::WebIDBKeyPath::operator const WTF::Vector<WTF::String, 0>&): Ensure it is non-null - only used in copy constructor which guards against this.
      * src/WebIDBObjectStoreImpl.cpp:
      (WebKit::WebIDBObjectStoreImpl::keyPath): Implement the new WebIDBKeyPath return type.
      (WebKit):
      * src/WebIDBObjectStoreImpl.h:
      (WebIDBObjectStoreImpl): Add createIndex overload for WebIDBKeyPath type, delegates to WebString version until callers are updated.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd45b189
    • commit-queue@webkit.org's avatar
      IndexedDB: cursor does not correctly iterate over keys added and removed during iteration · c152537c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84467
      
      Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-04-25
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Ensure that the iterator over the tree of cached adds/removes always points at
      the current key, or if the db iterator is current, the next key:
      
      - When refreshing the tree iterator after a mutation, always seek unless the
      tree iterator is current.
      
      - When handing conflicts and delete markers, only advance the tree iterator as
      far as the db iterator.
      
      Remove the expensive (and now redundant) logic that issued a get() to check
      whether an item had been deleted.
      
      Test: storage/indexeddb/cursor-added-bug.html
      
      * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
      (WebCore):
      * platform/leveldb/LevelDBTransaction.cpp:
      (WebCore::LevelDBTransaction::TransactionIterator::refreshTreeIterator):
      (WebCore::LevelDBTransaction::TransactionIterator::handleConflictsAndDeletes):
      
      LayoutTests:
      
      New test for keys added in reverse order during cursor iteration.
      
      * storage/indexeddb/cursor-added-bug-expected.txt: Added.
      * storage/indexeddb/cursor-added-bug.html: Added.
      * storage/indexeddb/resources/cursor-added-bug.js: Added.
      (test):
      (openSuccess):
      (setVersionSuccess):
      (openCursor):
      (cursorSuccess):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c152537c
    • jsbell@chromium.org's avatar
      Unreviewed: Adding Alec Flett as a contributor (non-committer). · 8a581354
      jsbell@chromium.org authored
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a581354
    • inferno@chromium.org's avatar
      Mark myself as a reviewer. · b3cd7bef
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84902
      
      Reviewed by Dimitri Glazkov.
      
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3cd7bef
    • antti@apple.com's avatar
      Try to fix build with STYLE_SCOPED enabled. · 93755afa
      antti@apple.com authored
      Not reviewed.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::determineScope):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93755afa
    • commit-queue@webkit.org's avatar
      IndexedDB: support openCursor(IDBKey) · e499f7d1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84652
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-04-25
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Add signatures for openCursor/openKeyCursor(IDBKey).
      
      Test: storage/indexeddb/opencursor-key.html
      
      * Modules/indexeddb/IDBIndex.cpp:
      (WebCore::IDBIndex::openCursor):
      (WebCore):
      (WebCore::IDBIndex::openKeyCursor):
      * Modules/indexeddb/IDBIndex.h:
      (WebCore::IDBIndex::openCursor):
      (IDBIndex):
      (WebCore::IDBIndex::openKeyCursor):
      * Modules/indexeddb/IDBIndex.idl:
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore::IDBObjectStore::openCursor):
      (WebCore):
      * Modules/indexeddb/IDBObjectStore.h:
      (WebCore::IDBObjectStore::openCursor):
      (IDBObjectStore):
      * Modules/indexeddb/IDBObjectStore.idl:
      
      LayoutTests:
      
      Augment existing tests, and add new tests to support
      IDBKey parameter to openCursor/openKeyCursor. Note that this removes
      a test that was previously using dictionary-style parameters,
      which have been temporarily broken due to IDL limitations.
      
      * storage/indexeddb/cursor-delete-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/opencursor-key-expected.txt: Added.
      * storage/indexeddb/opencursor-key.html: Added.
      * storage/indexeddb/resources/cursor-delete.js:
      (openCursor):
      * storage/indexeddb/resources/open-cursor.js:
      (emptyCursorWithKeySuccess):
      (openEmptyCursorWithKey):
      (cursorWithKeySuccess):
      (openCursorWithKey):
      (emptyCursorSuccess):
      (openEmptyCursor):
      (cursorSuccess):
      * storage/indexeddb/resources/opencursor-key.js: Added.
      (test):
      (openSuccess):
      (createAndPopulateObjectStore):
      (createIndexes):
      (testAll):
      (testObjectStore.request.onsuccess):
      (testObjectStore):
      (testIndex.request.onsuccess):
      (testIndex):
      (testIndexWithKey.request.onsuccess):
      (testIndexWithKey):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e499f7d1
    • rakuco@webkit.org's avatar
      Include <sys/param.h>, needed for sysctl() on OpenBSD/NetBSD · e702122f
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82585
      
      Patch by Landry Breuil <landry@openbsd.org> on 2012-04-25
      Reviewed by Zoltan Herczeg.
      
      * wtf/NumberOfCores.cpp: include <sys/param.h> on the BSDs
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e702122f
    • oliver@apple.com's avatar
      Biolab disaster crashes on ToT · 0a214151
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84898
      
      Reviewed by Filip Pizlo.
      
      Whoops, committed without saving reviewer requested change.
      
      * dfg/DFGVirtualRegisterAllocationPhase.cpp:
      (JSC::DFG::VirtualRegisterAllocationPhase::run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a214151
    • oliver@apple.com's avatar
      Biolab disaster crashes on ToT · ec4edba8
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84898
      
      Reviewed by Filip Pizlo.
      
      I recently added an assertion to the Interpreter to catch incorrect
      updates of topCallFrame.  This caused a bunch of sites (including biolab
      disaster) to crash as we were not correctly handling callee registers
      of inlined functions, leading to a mismatch.
      
      I could not actually make this trigger directly, although it does trigger
      already on some of the GTK and QT bots.
      
      * dfg/DFGVirtualRegisterAllocationPhase.cpp:
      (JSC::DFG::VirtualRegisterAllocationPhase::run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec4edba8
    • dglazkov@chromium.org's avatar
      [Chromium[ Remove a flaky expectation for a test that's been consistently passing. · 128e8230
      dglazkov@chromium.org authored
      * platform/chromium/test_expectations.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      128e8230
    • antti@apple.com's avatar
      Remove owner node pointer from StyleSheetInternal · fe126eb6
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84882
      
      Reviewed by Andread Kling.
      
      To make sharing between multiple nodes possible StyleSheetInternal should not have a Node pointer.
              
      - Make StyleSheetInternal constructor take CSSParserContext instead of Node*
      - Move owner node pointer to CSSStyleSheet. CSSStyleSheet now acts as a client for StyleSheetInternal.
              
      This gets us closer to being able to cache stylesheet data structures.
              
      * css/CSSImportRule.cpp:
      (WebCore::StyleRuleImport::setCSSStyleSheet):
      (WebCore::StyleRuleImport::requestStyleSheet):
              
          Setup CSSParserContext.
          Remove FIXME about updateBaseURL(). It is no longer possible to change URL of StyleSheetInternal.
      
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::setSelectorText):
      * css/CSSParser.cpp:
      (WebCore::CSSParserContext::CSSParserContext):
      * css/CSSParserMode.h:
      (CSSParserContext):
          
          Expand CSSParserContext constructors.
      
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::setSelectorText):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleResolver.h:
      (StyleResolver):
      * css/CSSStyleSheet.cpp:
      
          User stylesheets went back to being CSSStyleSheets. Adapt to that.
      
      (WebCore::StyleSheetInternal::StyleSheetInternal):
      (WebCore):
      (WebCore::StyleSheetInternal::checkLoaded):
      (WebCore::StyleSheetInternal::startLoadingDynamicSheet):
      (WebCore::StyleSheetInternal::rootStyleSheet):
      (WebCore::StyleSheetInternal::singleOwnerNode):
      (WebCore::StyleSheetInternal::singleOwnerDocument):
      (WebCore::StyleSheetInternal::styleSheetChanged):
              
          The owner node is now located through CSSStyleSheet. Only one client is supported atm.
      
      (WebCore::StyleSheetInternal::registerClient):
      (WebCore::StyleSheetInternal::unregisterClient):
              
          Register CSSStyleSheets.
      
      (WebCore::CSSStyleSheet::CSSStyleSheet):
      (WebCore::CSSStyleSheet::~CSSStyleSheet):
      (WebCore::CSSStyleSheet::rules):
      (WebCore::CSSStyleSheet::cssRules):
      (WebCore::CSSStyleSheet::ownerDocument):
      * css/CSSStyleSheet.h:
      (WebCore::StyleSheetInternal::create):
      (WebCore::StyleSheetInternal::createInline):
      (StyleSheetInternal):
      (WebCore::CSSStyleSheet::create):
      (CSSStyleSheet):
              
          Moved m_ownerNode.
          Changed constructors
          Removed setFinalURL(). 
      
      * css/PropertySetCSSStyleDeclaration.cpp:
      (WebCore::StyleRuleCSSStyleDeclaration::setNeedsStyleRecalc):
      * dom/Document.cpp:
      (WebCore::Document::updateBaseURL):
              
          Instead of setFinalURL, construct a new StyleSheetInternal if the base url ever changes.
      
      (WebCore::Document::pageUserSheet):
      (WebCore::Document::pageGroupUserSheets):
      (WebCore::Document::addUserSheet):
      (WebCore::Document::elementSheet):
      * dom/Document.h:
      (Document):
      (WebCore::Document::documentUserSheets):
              
          Adapt to the new interface.
          Turned user stylesheets CSSStyleSheets so they can find the owner node.
      
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::setCSSStyleSheet):
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::createSheet):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::setCSSStyleSheet):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::SelectorProfile::startSelector):
      (WebCore::InspectorCSSAgent::bindStyleSheet):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::fillMediaListChain):
      (WebCore::InspectorStyleSheet::ownerDocument):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeCSSStyleSheet):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe126eb6
    • adamk@chromium.org's avatar
      Fix uninitialized variable warnings in PasteboardMac.mm after 115145 · 692fa6ff
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84879
      
      Reviewed by Enrica Casucci.
      
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getDataSelection): Initialize attributedString to nil.
      (WebCore::Pasteboard::writeSelectionForTypes): ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692fa6ff
    • kbr@google.com's avatar
      Delete CanvasPixelArray, ByteArray, JSByteArray and JSC code once unreferenced · 94781154
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83655
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.gypi:
      * JavaScriptCore.order:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * bytecode/PredictedType.cpp:
      (JSC::predictionToString):
      (JSC::predictionToAbbreviatedString):
      (JSC::predictionFromClassInfo):
      * bytecode/PredictedType.h:
      (JSC):
      (JSC::isActionableIntMutableArrayPrediction):
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::initialize):
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::performNodeCSE):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::fixupNode):
      * dfg/DFGNode.h:
      * dfg/DFGNodeType.h:
      (DFG):
      * dfg/DFGOperations.cpp:
      (JSC::DFG::putByVal):
      * dfg/DFGPredictionPropagationPhase.cpp:
      (JSC::DFG::PredictionPropagationPhase::propagate):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::checkArgumentTypes):
      (JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::ValueSource::forPrediction):
      (SpeculativeJIT):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * jit/JITStubs.h:
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::getByVal):
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      * runtime/JSByteArray.cpp: Removed.
      * runtime/JSByteArray.h: Removed.
      * runtime/JSGlobalData.cpp:
      
      Source/WebCore:
      
      Removed last few references to ByteArray, replacing with
      Uint8ClampedArray as necessary, and deleted now-obsolete
      CanvasPixelArray, ByteArray and JSByteArray. Removed code from
      JavaScriptCore special-casing ByteArray.
      
      No new tests. Did full layout test run on Mac OS; no regressions
      seen from this change.
      
      * CMakeLists.txt:
      * DerivedSources.pri:
      * ForwardingHeaders/runtime/JSByteArray.h: Removed.
      * GNUmakefile.list.am:
      * PlatformBlackBerry.cmake:
      * Target.pri:
      * UseV8.cmake:
      * WebCore.gypi:
      * WebCore.order:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/v8/SerializedScriptValue.cpp:
      * bindings/v8/V8Binding.h:
      (WebCore::isHostObject):
      * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
      * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
      (WebCore::V8InjectedScriptHost::typeCallback):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::isJSUint8ClampedArray):
      (Bindings):
      (JSC::Bindings::valueRealType):
      (JSC::Bindings::convertValueToQVariant):
      (JSC::Bindings::convertQVariantToValue):
      * html/canvas/CanvasPixelArray.cpp: Removed.
      * html/canvas/CanvasPixelArray.h: Removed.
      * html/canvas/CanvasPixelArray.idl: Removed.
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * platform/graphics/filters/FEConvolveMatrix.h:
      * rendering/svg/RenderSVGResourceMasker.cpp:
      
      Source/WTF:
      
      * GNUmakefile.list.am:
      * WTF.gypi:
      * WTF.pro:
      * WTF.vcproj/WTF.vcproj:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/ByteArray.cpp: Removed.
      * wtf/ByteArray.h: Removed.
      * wtf/CMakeLists.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94781154
    • hclam@chromium.org's avatar
      Unreviewed test expectations update. · 1a2eeef8
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84890
      
      Rebaseline chromium-mac test expectation for media/audio-repaint.html after r115235.
      
      * platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a2eeef8
    • hclam@chromium.org's avatar
      Unreviewed build fix. · 6deaf0d6
      hclam@chromium.org authored
      Build fix for compilation failure due to r115243.
      
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6deaf0d6