1. 05 Nov, 2012 40 commits
    • fpizlo@apple.com's avatar
      Reduce the verbosity of referring to QNaN in JavaScriptCore · 3494d02f
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101174
      
      Reviewed by Geoffrey Garen.
      
      Introduces a #define QNaN in JSValue.h, and replaces all previous uses of
      std::numeric_limits<double>::quiet_NaN() with QNaN.
      
      * API/JSValueRef.cpp:
      (JSValueMakeNumber):
      (JSValueToNumber):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emitFloatTypedArrayGetByVal):
      * runtime/CachedTranscendentalFunction.h:
      (JSC::CachedTranscendentalFunction::initialize):
      * runtime/DateConstructor.cpp:
      (JSC::constructDate):
      * runtime/DateInstanceCache.h:
      (JSC::DateInstanceData::DateInstanceData):
      (JSC::DateInstanceCache::reset):
      * runtime/ExceptionHelpers.cpp:
      (JSC::InterruptedExecutionError::defaultValue):
      (JSC::TerminatedExecutionError::defaultValue):
      * runtime/JSCell.h:
      (JSC::JSValue::getPrimitiveNumber):
      * runtime/JSDateMath.cpp:
      (JSC::parseDateFromNullTerminatedCharacters):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      (JSC::JSGlobalData::resetDateCache):
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::parseInt):
      (JSC::jsStrDecimalLiteral):
      (JSC::toDouble):
      (JSC::jsToNumber):
      (JSC::parseFloat):
      * runtime/JSValue.cpp:
      (JSC::JSValue::toNumberSlowCase):
      * runtime/JSValue.h:
      (JSC):
      * runtime/JSValueInlineMethods.h:
      (JSC::jsNaN):
      * runtime/MathObject.cpp:
      (JSC::mathProtoFuncMax):
      (JSC::mathProtoFuncMin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3494d02f
    • kling@webkit.org's avatar
      Decouple Attr logic from ElementAttributeData. · 86d6cb5f
      kling@webkit.org authored
      <http://webkit.org/b/101126>
      
      Reviewed by Antti Koivisto.
      
      Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
      This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
      can be shared by any number of Elements at a given time.
      
      Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
      "Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.
      
      * dom/Element.h:
      * dom/ElementAttributeData.h:
      * dom/Element.cpp:
      (WebCore::attrNodeListMap):
      (WebCore::attrNodeListForElement):
      (WebCore::ensureAttrNodeListForElement):
      (WebCore::removeAttrNodeListForElement):
      (WebCore::findAttrNodeInList):
      (WebCore::Element::~Element):
      (WebCore::Element::detachAttribute):
      (WebCore::Element::setAttributeNode):
      (WebCore::Element::removeAttributeInternal):
      (WebCore::Element::getAttributeNode):
      (WebCore::Element::getAttributeNodeNS):
      (WebCore::Element::normalizeAttributes):
      (WebCore::Element::attrIfExists):
      (WebCore::Element::ensureAttr):
      (WebCore::Element::detachAttrNodeFromElementWithValue):
      (WebCore::Element::detachAllAttrNodesFromElement):
      (WebCore::Element::cloneAttributesFromElement):
      
          Move everything Attr-related into Element.cpp while simplifying some loops and remove
          conditions that are no longer needed as they used to depend on having an attributeData().
      
      * dom/Node.h:
      (WebCore::Node::hasSyntheticAttrChildNodes):
      (WebCore::Node::setHasSyntheticAttrChildNodes):
      
          Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().
      
      * dom/Attr.cpp:
      (WebCore::Attr::detachFromElementWithValue):
      
          Remove awkward indirection and let the call site deal with removing the Attr node from
          the Element's list of Attr nodes.
      
      * dom/ElementAttributeData.cpp:
      (WebCore::ElementAttributeData::clearAttributes):
      
          Remove now-unused Element* argument.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86d6cb5f
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, unskip a now passing test. · 062c3fed
      ossy@webkit.org authored
      * platform/qt-5.0-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      062c3fed
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Polygon edges should span colinear vertices · 0bac6043
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99343
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      ExclusionPolygonEdges now span coincident and collinear vertices. Currently
      pairs of vertices are only considered coincident if their coordinates are exactly
      equal. Similarly, a vertex is only considered collinear with an edge if the area
      of the triangle defined by the three vertices is exactly zero.  In the future it
      may be useful to relax the comparison with zero.
      
      Tests: fast/exclusions/shape-inside/shape-inside-coincident-vertices.html
             fast/exclusions/shape-inside/shape-inside-collinear-vertices.html
      
      * rendering/ExclusionPolygon.cpp:
      (WebCore::determinant): Used to measure collinearity.
      (WebCore):
      (WebCore::areCollinearPoints): True if three FloatPoint arguments are collinear per the test outlined above.
      (WebCore::areCoincidentPoints): True if the two FloatPoint arguments are equal.
      (WebCore::nextVertexIndex): The next vertex index in clockwise or counterclockwise order.
      (WebCore::ExclusionPolygon::findNextEdgeVertexIndex): Return the index of the next non-coincident, non-collinear vertex.
      (WebCore::ExclusionPolygon::ExclusionPolygon): Skip coincident and collinear vertices when building the list of edges.
      * rendering/ExclusionPolygon.h: Added private findNextEdgeVertexIndex() declaration.
      
      LayoutTests:
      
      Verify that exclusion polygonal shape-inside layout is unaffected by coincident
      or collinear vertices.
      
      * fast/exclusions/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-coincident-vertices.html: Added.
      * fast/exclusions/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-collinear-vertices.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bac6043
    • commit-queue@webkit.org's avatar
      [EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile() · 110bf840
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101228
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Get rid of EFL-specific implementation of SharedBuffer::createWithContentsOfFile()
      and reuse the POSIX one since it is pretty much the same.
      
      No new tests, no behavior change.
      
      * PlatformEfl.cmake:
      * platform/efl/SharedBufferEfl.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      110bf840
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening, unskip now passing tests. · 80e89381
      ossy@webkit.org authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80e89381
    • senorblanco@chromium.org's avatar
      [chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html · f3789da7
      senorblanco@chromium.org authored
      as also crashy, and give it a bug ID.  Unreviewed.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3789da7
    • haraken@chromium.org's avatar
      Add a comment about a return value of IDBKey::toV8() · ed0c2866
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101212
      
      Reviewed by Adam Barth.
      
      Although all other toV8(impl) return null when impl is 0,
      IDBKey::toV8(impl) is expected to return undefined when impl is 0.
      This patch adds a comment about it.
      
      No tests.
      
      * bindings/js/JSIDBKeyCustom.cpp:
      (WebCore::toJS):
      * bindings/v8/custom/V8IDBKeyCustom.cpp:
      (WebCore::toV8):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed0c2866
    • dominik.rottsches@intel.com's avatar
      [Cairo] Make Cairo honor image orientation · deb6589a
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101207
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Implement transformed image drawing in BitmapImageCairo, similar
      as it was done for Skia in bug 100179, r132384.
      The image drawing code needs to transform the graphics context
      depending on exif orientation in order for this to work.
      
      No new tests, covered by fast/images/exif-* which are passing now.
      
      * platform/graphics/BitmapImage.h: Enable draw function which respects image orientation for Cairo.
      * platform/graphics/cairo/BitmapImageCairo.cpp:
      (WebCore::BitmapImage::draw): Apply ImageOrientation's transformFromDefault() transformation to context.
      (WebCore):
      
      LayoutTests:
      
      Unskip and rebaseline exif orientation tests for EFL.
      
      * platform/efl-wk1/TestExpectations: Tests not passing here yet, since DRT needs a setShouldRespectImageOrientation setting.
      * platform/efl/TestExpectations: Unskipping three exif orientation tests.
      * platform/efl/fast/images/exif-orientation-css-expected.png: Added.
      * platform/efl/fast/images/exif-orientation-css-expected.txt: Added.
      * platform/efl/fast/images/exif-orientation-expected.png: Added.
      * platform/efl/fast/images/exif-orientation-expected.txt: Added.
      * platform/efl/fast/images/exif-orientation-image-document-expected.png: Added.
      * platform/efl/fast/images/exif-orientation-image-document-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deb6589a
    • haraken@chromium.org's avatar
      [V8] Dispose() and Clear() should be always coupled for safety · 90a30c57
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101191
      
      Reviewed by Adam Barth.
      
      Clear() is not mandatory. However, to avoid misusing already
      disposed wrappers, Clear() should be always called just
      after Dispose().
      
      No tests. No change in behavior.
      
      * bindings/v8/DOMWrapperMap.h:
      (WebCore::DOMWrapperHashMap::defaultWeakCallback):
      * bindings/v8/IntrusiveDOMWrapperMap.h:
      (WebCore::IntrusiveDOMWrapperMap::weakCallback):
      * bindings/v8/NPV8Object.cpp:
      (WebCore::freeV8NPObject):
      * bindings/v8/ScheduledAction.cpp:
      (WebCore::ScheduledAction::~ScheduledAction):
      * bindings/v8/V8NPObject.cpp:
      (WebCore::V8NPTemplateMap::dispose):
      (WebCore::weakNPObjectCallback):
      (WebCore::forgetV8ObjectForNPObject):
      * bindings/v8/V8PerContextData.cpp:
      (WebCore::V8PerContextData::dispose):
      * bindings/v8/V8ValueCache.cpp:
      (WebCore::cachedStringCallback):
      (WebCore::IntegerCache::~IntegerCache):
      * bindings/v8/custom/V8InjectedScriptManager.cpp:
      (WebCore::WeakReferenceCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90a30c57
    • kpiascik@rim.com's avatar
      [BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing. · 21c310aa
      kpiascik@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101213
      RIM PR 178131
      
      Reviewed by Rob Buis.
      
      Internally Reviewed by Arvid Nilsson.
      
      Added compositing events to the timeline for BlackBerry.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
      (BlackBerry::WebKit::WebPagePrivate::willComposite):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::didComposite):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21c310aa
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Layout of the first shape-inside line can be incorrect · 74e6342b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100996
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Made the conversion from floating point top/bottom logical shape bounds coordinates
      LayoutUnits explicit and corrected the case where the top value was truncated.  A
      float logicalTop value is converted to LayoutUnit with fromFloatCeil() to ensure
      that the LayoutUnit value is within the shape.
      
      Test: fast/exclusions/shape-inside/shape-inside-shape-logical-top.html
      
      * rendering/ExclusionShapeInsideInfo.h:
      (WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Redefined this method in terms of shapeLogicalBoundsY,Max().
      (WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom):  Ditto.
      (WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds):  Ditto.
      (ExclusionShapeInsideInfo):
      (WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsY): Explicit conversion from floating point shape coordinates to LayoutUnits.
      (WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsMaxY): Ditto.
      
      LayoutTests:
      
      Verify that the first line of shape-inside content is laid out correctly
      when the top of the shape's bounds has a non-integral value.
      
      * fast/exclusions/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-shape-logical-top.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e6342b
    • senorblanco@chromium.org's avatar
      [chromium] Mark a flaky test. Unreviewed. · b889c2f1
      senorblanco@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b889c2f1
    • senorblanco@chromium.org's avatar
      [chromium] Add a now-failing test, remove a now-passing test. Unreviewed. · 0bdf0b34
      senorblanco@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bdf0b34
    • antti@apple.com's avatar
      Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize · 2f50870f
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101211
      
      Reviewed by Andreas Kling.
              
      Some crashes have been seen under MemoryCache::pruneDeadResourcesToSize. A possible cause is that
      destroyDecodedData() call ends up evicting the resource pointed by 'previous' pointer during iteration
      and deleting the object. This looks in principle possible via stylesheets and SVG images.
              
      Speculative fix, no repro, no obvious way to construct a test.
      
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::pruneDeadResourcesToSize):
              
          Use CachedResourceHandle to protect the 'previous' pointer during iteration. Check if the
          resource has been kicked out from the cache during destroyDecodedData() and stop iterating
          if has (as it may die when CachedResourceHandle releases it).
          The 'current' pointer is not protected as the resource it points to is allowed to die.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f50870f
    • commit-queue@webkit.org's avatar
      [Chromium] Disable registerProtocolHandler on Android · 1e8415c7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101199
      
      Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-05
      Reviewed by Julien Chaffraix.
      
      Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
      actually wired up internally. Disable the feature to avoid breaking feature detection
      until we can implement it properly.
      
      * features.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e8415c7
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS · 5d699d83
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100674
      
      Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
      Calling ewk_view_base_add creates a desktop style view, that does not support
      fixed layout size, while calling ewk_view_smart_add does support fixed layout size.
      As a result, WebKitTestRunner and the inspector window do not support
      fixed layout size, while MiniBrowser does. This change allows many DumpAsText
      layout tests to pass without modification, when AC is enabled.
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/EwkViewImpl.cpp:
      (EwkViewImpl::EwkViewImpl):
      (EwkViewImpl::transformFromScene):
      (EwkViewImpl::informLoadCommitted):
      (EwkViewImpl::enterAcceleratedCompositingMode):
      (EwkViewImpl::informContentsSizeChange):
      * UIProcess/API/efl/EwkViewImpl.h:
      (WebKit):
      (EwkViewImpl):
      (EwkViewImpl::pageClient):
      (EwkViewImpl::setScaleFactor):
      (EwkViewImpl::scaleFactor):
      (EwkViewImpl::setScrollPosition):
      (EwkViewImpl::scrollPosition):
      * UIProcess/API/efl/ewk_view.cpp:
      (_ewk_view_smart_calculate):
      (createEwkView):
      (ewk_view_base_add):
      * UIProcess/efl/PageClientBase.cpp: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.cpp.
      (WebKit::PageClientBase::PageClientBase):
      (WebKit::PageClientBase::~PageClientBase):
      (WebKit::PageClientBase::viewImpl):
      (WebKit::PageClientBase::createDrawingAreaProxy):
      (WebKit::PageClientBase::setViewNeedsDisplay):
      (WebKit::PageClientBase::displayView):
      (WebKit::PageClientBase::scrollView):
      (WebKit::PageClientBase::viewSize):
      (WebKit::PageClientBase::isViewWindowActive):
      (WebKit::PageClientBase::isViewFocused):
      (WebKit::PageClientBase::isViewVisible):
      (WebKit::PageClientBase::isViewInWindow):
      (WebKit::PageClientBase::processDidCrash):
      (WebKit::PageClientBase::didRelaunchProcess):
      (WebKit::PageClientBase::pageClosed):
      (WebKit::PageClientBase::toolTipChanged):
      (WebKit::PageClientBase::setCursor):
      (WebKit::PageClientBase::setCursorHiddenUntilMouseMoves):
      (WebKit::PageClientBase::registerEditCommand):
      (WebKit::PageClientBase::clearAllEditCommands):
      (WebKit::PageClientBase::canUndoRedo):
      (WebKit::PageClientBase::executeUndoRedo):
      (WebKit::PageClientBase::convertToDeviceSpace):
      (WebKit::PageClientBase::convertToUserSpace):
      (WebKit::PageClientBase::screenToWindow):
      (WebKit::PageClientBase::windowToScreen):
      (WebKit::PageClientBase::doneWithKeyEvent):
      (WebKit::PageClientBase::doneWithTouchEvent):
      (WebKit::PageClientBase::createPopupMenuProxy):
      (WebKit::PageClientBase::createContextMenuProxy):
      (WebKit::PageClientBase::createColorChooserProxy):
      (WebKit::PageClientBase::setFindIndicator):
      (WebKit::PageClientBase::enterAcceleratedCompositingMode):
      (WebKit::PageClientBase::exitAcceleratedCompositingMode):
      (WebKit::PageClientBase::updateAcceleratedCompositingMode):
      (WebKit::PageClientBase::didChangeScrollbarsForMainFrame):
      (WebKit::PageClientBase::didCommitLoadForMainFrame):
      (WebKit::PageClientBase::didFinishLoadingDataForCustomRepresentation):
      (WebKit::PageClientBase::customRepresentationZoomFactor):
      (WebKit::PageClientBase::setCustomRepresentationZoomFactor):
      (WebKit::PageClientBase::flashBackingStoreUpdates):
      (WebKit::PageClientBase::findStringInCustomRepresentation):
      (WebKit::PageClientBase::countStringMatchesInCustomRepresentation):
      (WebKit::PageClientBase::updateTextInputState):
      (WebKit::PageClientBase::handleDownloadRequest):
      * UIProcess/efl/PageClientBase.h: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.h.
      (PageClientBase):
      * UIProcess/efl/PageClientDefaultImpl.cpp: Added.
      (WebKit):
      (WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
      (WebKit::PageClientDefaultImpl::didCommitLoad):
      (WebKit::PageClientDefaultImpl::updateViewportSize):
      (WebKit::PageClientDefaultImpl::didChangeViewportProperties):
      (WebKit::PageClientDefaultImpl::didChangeContentsSize):
      (WebKit::PageClientDefaultImpl::pageDidRequestScroll):
      (WebKit::PageClientDefaultImpl::didRenderFrame):
      (WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
      * UIProcess/efl/PageClientDefaultImpl.h: Added.
      (WebKit):
      (PageClientDefaultImpl):
      (WebKit::PageClientDefaultImpl::create):
      (WebKit::PageClientDefaultImpl::~PageClientDefaultImpl):
      * UIProcess/efl/PageClientImpl.cpp: Removed.
      * UIProcess/efl/PageClientImpl.h: Removed.
      * UIProcess/efl/PageClientLegacyImpl.cpp: Added.
      (WebKit):
      (WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
      (WebKit::PageClientLegacyImpl::didCommitLoad):
      (WebKit::PageClientLegacyImpl::updateViewportSize):
      (WebKit::PageClientLegacyImpl::didChangeViewportProperties):
      (WebKit::PageClientLegacyImpl::didChangeContentsSize):
      (WebKit::PageClientLegacyImpl::pageDidRequestScroll):
      (WebKit::PageClientLegacyImpl::didRenderFrame):
      (WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
      * UIProcess/efl/PageClientLegacyImpl.h: Added.
      (WebKit):
      (PageClientLegacyImpl):
      (WebKit::PageClientLegacyImpl::create):
      (WebKit::PageClientLegacyImpl::~PageClientLegacyImpl):
      * UIProcess/efl/PageViewportControllerClientEfl.cpp:
      (WebKit::PageViewportControllerClientEfl::updateViewportSize):
      (WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
      (WebKit::PageViewportControllerClientEfl::setViewportPosition):
      (WebKit::PageViewportControllerClientEfl::setContentsScale):
      * UIProcess/efl/PageViewportControllerClientEfl.h:
      * UIProcess/efl/WebPageProxyEfl.cpp:
      (WebKit::WebPageProxy::viewWidget):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d699d83
    • commit-queue@webkit.org's avatar
      Web Inspector: Fix jscompiler cast syntax · 3540dbd9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101066
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-05
      Reviewed by Pavel Feldman.
      
      Casts should be in the form of "/** @type {TypeName} */ (expr)" instead of "/** @type {TypeName} */ expr".
      
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/front-end/ApplicationCacheModel.js:
      (WebInspector.ApplicationCacheModel.prototype._frameNavigated):
      (WebInspector.ApplicationCacheModel.prototype._frameDetached):
      * inspector/front-end/AuditLauncherView.js:
      (WebInspector.AuditLauncherView.prototype._onRequestStarted):
      (WebInspector.AuditLauncherView.prototype._onRequestFinished):
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
      (WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
      (WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
      (WebInspector.BreakpointManager.prototype._breakpointResolved):
      (WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
      (WebInspector.BreakpointManager.Storage):
      * inspector/front-end/BreakpointsSidebarPane.js:
      (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
      * inspector/front-end/CSSNamedFlowCollectionsView.js:
      (WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
      (WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
      (WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
      (WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
      * inspector/front-end/CSSSelectorProfileView.js:
      (WebInspector.CSSProfileHeader.prototype.createView):
      * inspector/front-end/CSSStyleModel.js:
      (WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
      (WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
      * inspector/front-end/CompilerScriptMapping.js:
      (WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype._frameAdded):
      (WebInspector.ConsoleView.prototype._frameRemoved):
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMDocument):
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype.didSetBreakpoint):
      (WebInspector.DebuggerModel.prototype.setBreakpointByURL):
      (WebInspector.DebuggerModel.prototype.):
      (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
      (WebInspector.DebuggerModel.CallFrame.prototype.get location):
      * inspector/front-end/DebuggerScriptMapping.js:
      (WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
      * inspector/front-end/DirectoryContentView.js:
      (WebInspector.DirectoryContentView.prototype._sort):
      * inspector/front-end/ElementsPanel.js:
      (WebInspector.ElementsPanel.prototype._updateBreadcrumbIfNeeded):
      * inspector/front-end/ElementsPanelDescriptor.js:
      (WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
      * inspector/front-end/ElementsTreeOutline.js:
      (.get node):
      * inspector/front-end/ExtensionServer.js:
      (WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
      (WebInspector.ExtensionServer.prototype._handleOpenURL):
      (WebInspector.ExtensionServer.prototype._onGetResourceContent):
      (WebInspector.ExtensionServer.prototype._onSetResourceContent):
      (WebInspector.ExtensionServer.prototype._notifyResourceAdded):
      (WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
      (WebInspector.ExtensionServer.prototype._notifyRequestFinished):
      * inspector/front-end/FileContentView.js:
      (WebInspector.FileContentView.prototype._metadataReceived):
      (WebInspector.FileContentView.FileContentProvider.prototype.requestContent):
      * inspector/front-end/FileSystemModel.js:
      (WebInspector.FileSystemModel.prototype._frameAdded):
      (WebInspector.FileSystemModel.prototype._frameNavigated):
      (WebInspector.FileSystemModel.prototype._frameDetached):
      * inspector/front-end/FileSystemView.js:
      (WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
      (WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
      * inspector/front-end/HandlerRegistry.js:
      (WebInspector.HandlerRegistry.prototype._appendHrefItems):
      * inspector/front-end/HeapSnapshotLoader.js:
      (WebInspector.HeapSnapshotLoader.prototype.write):
      * inspector/front-end/HeapSnapshotView.js:
      (WebInspector.HeapSnapshotView.prototype._changeBase):
      (WebInspector.HeapProfileHeader.prototype.load):
      (WebInspector.HeapProfileHeader.prototype._snapshotReceived):
      * inspector/front-end/IndexedDBModel.js:
      (WebInspector.IndexedDBModel.prototype._frameNavigated):
      (WebInspector.IndexedDBModel.prototype._frameDetached):
      * inspector/front-end/IndexedDBViews.js:
      (WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
      (WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
      (WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
      (WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
      (WebInspector.JavaScriptSourceFrame.prototype._consoleMessageRemoved):
      (WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
      (WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
      * inspector/front-end/MemoryStatistics.js:
      (WebInspector.MemoryStatistics.prototype.show):
      * inspector/front-end/NavigatorView.js:
      (WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
      (WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
      (WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
      (WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):
      * inspector/front-end/NetworkLog.js:
      (WebInspector.NetworkLog.prototype._onRequestStarted):
      * inspector/front-end/NetworkManager.js:
      (WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._onRequestUpdated):
      (WebInspector.NetworkLogView.prototype._mainFrameNavigated):
      (WebInspector.NetworkPanel.prototype.reveal):
      (WebInspector.NetworkPanel.prototype.appendApplicableItems):
      * inspector/front-end/NetworkUISourceCodeProvider.js:
      (WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
      (WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
      * inspector/front-end/ObjectPopoverHelper.js:
      (WebInspector.ObjectPopoverHelper.prototype.):
      (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
      * inspector/front-end/PresentationConsoleMessageHelper.js:
      (WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
      (WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
      * inspector/front-end/ProfilesPanel.js:
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
      (WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
      (WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
      * inspector/front-end/ResourceTreeModel.js:
      (WebInspector.ResourceTreeModel.prototype._onRequestFinished):
      (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype._databaseAdded):
      (WebInspector.ResourcesPanel.prototype._domStorageAdded):
      (WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
      (WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
      (WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
      (WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
      (WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
      (WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
      (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
      (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
      * inspector/front-end/RevisionHistoryView.js:
      (WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
      * inspector/front-end/SASSSourceMapping.js:
      (rawLocationToUILocation):
      * inspector/front-end/ScopeChainSidebarPane.js:
      (WebInspector.ScopeChainSidebarPane.prototype.update):
      * inspector/front-end/Script.js:
      (WebInspector.Script.Location.prototype.uiLocation):
      * inspector/front-end/ScriptFormatter.js:
      (WebInspector.ScriptFormatter.prototype.get _worker):
      * inspector/front-end/ScriptsPanel.js:
      (WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
      (WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
      (WebInspector.ScriptsPanel.prototype._editorClosed):
      (WebInspector.ScriptsPanel.prototype._editorSelected):
      (WebInspector.ScriptsPanel.prototype._scriptSelected):
      (WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
      (WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
      (WebInspector.ScriptsPanel.prototype.replaceAllWith):
      (WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
      (WebInspector.ScriptsPanel.prototype.set _fileRenamed):
      (WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
      * inspector/front-end/ScriptsPanelDescriptor.js:
      (WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
      * inspector/front-end/StylesSourceMapping.js:
      (WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
      (WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
      * inspector/front-end/TabbedEditorContainer.js:
      (WebInspector.TabbedEditorContainer.prototype._scrollChanged):
      (WebInspector.TabbedEditorContainer.prototype._selectionChanged):
      (WebInspector.TabbedEditorContainer.prototype._tabClosed):
      (WebInspector.TabbedEditorContainer.prototype._tabSelected):
      (WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
      (WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
      (WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
      (WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):
      * inspector/front-end/TimelineModel.js:
      (WebInspector.TimelineModelLoader.prototype.write):
      * inspector/front-end/UISourceCodeFrame.js:
      (WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
      * inspector/front-end/Workspace.js:
      (WebInspector.WorkspaceController.prototype._frameAdded):
      (WebInspector.Project.prototype._fileAdded):
      (WebInspector.Project.prototype._fileRemoved):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3540dbd9
    • pierre.rossi@gmail.com's avatar
      [Qt] Fix broken comment in WK2 TestExpectations · bb1c079f
      pierre.rossi@gmail.com authored
      Unreviewed fix, just an obviously missing '#' character.
      
      * platform/qt-5.0-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb1c079f
    • commit-queue@webkit.org's avatar
      fast/events/popup-allowed-from-gesture-initiated-event.html is flaky · 4e6949f1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101208
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Close the new popup between each test to make sure the new window
      does not mask the buttons and therefore prevent them from being
      clicked. This addresses flakiness for this test.
      
      * fast/events/popup-allowed-from-gesture-initiated-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e6949f1
    • pfeldman@chromium.org's avatar
      Web Inspector: render message bubbles in CodeMirror experiment. · ae215263
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101164
      
      Reviewed by Vsevolod Vlasov.
      
      It sounds like addLineWidget just makes it happen.
      
      * inspector/front-end/CodeMirrorTextEditor.js:
      (WebInspector.CodeMirrorTextEditor):
      (WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
      (WebInspector.CodeMirrorTextEditor.prototype.get if):
      (WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
      (WebInspector.CodeMirrorTextEditor.prototype._change):
      * inspector/front-end/DefaultTextEditor.js:
      (.preventDefaultOnMouseUp):
      * inspector/front-end/PresentationConsoleMessageHelper.js:
      (WebInspector.PresentationConsoleMessageHelper):
      * inspector/front-end/cm/cmdevtools.css:
      (.CodeMirror .webkit-html-message-bubble):
      (.CodeMirror .webkit-html-message-bubble img):
      (.CodeMirror .webkit-html-warning-message):
      (.CodeMirror .webkit-html-error-message):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae215263
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 7b42d789
      zandobersek@gmail.com authored
      A followup to r133453, adding a baseline for http/tests/inspector/console-websocket-error.html.
      
      * platform/gtk/http/tests/inspector: Added.
      * platform/gtk/http/tests/inspector/console-websocket-error-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b42d789
    • commit-queue@webkit.org's avatar
      Validate CSS Device Adaptation properties and resolve shorthands · 42da6160
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95962
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-05
      Reviewed by Alexis Menard.
      
      Source/WebCore:
      
      Add the missing keywords and properties for the viewport at-rule.
      Note that we have to mark that we are inside a viewport scope because
      some properties are not validated as they would be inside a style
      rule. As an example, the semantics of CSSPropertyWidth are completely
      different: on a viewport rule, it stands for a shorthand for the
      minimum and maximum width.
      
      Test: css3/device-adapt/viewport-properties-validation.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      (WebCore):
      (WebCore::CSSParser::parseViewportProperty):
      (WebCore::CSSParser::parseViewportShorthand):
      * css/CSSParser.h:
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/CSSValueKeywords.in:
      
      LayoutTests:
      
      Added a test for CSS Device Adaptation property parsing validation.
      
      * css3/device-adapt/viewport-properties-validation-expected.txt: Added.
      * css3/device-adapt/viewport-properties-validation.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42da6160
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects · 3af76319
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101205
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
      Reviewed by Gyuyoung Kim.
      
      Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data are using common Ewk_Object interface now.
      
      * UIProcess/API/efl/EwkViewImpl.h:
      * UIProcess/API/efl/ewk_download_job.cpp:
      (Ewk_Download_Job::request):
      (Ewk_Download_Job::response):
      (Ewk_Download_Job::setResponse):
      * UIProcess/API/efl/ewk_download_job_private.h:
      (Ewk_Download_Job):
      * UIProcess/API/efl/ewk_navigation_data.cpp:
      (EwkNavigationData::EwkNavigationData):
      (EwkNavigationData::originalRequest):
      (EwkNavigationData::title):
      (EwkNavigationData::url):
      (ewk_navigation_data_title_get):
      (ewk_navigation_data_original_request_get):
      (ewk_navigation_data_url_get):
      * UIProcess/API/efl/ewk_navigation_data.h:
      * UIProcess/API/efl/ewk_navigation_data_private.h:
      (EwkNavigationData):
      (EwkNavigationData::create):
      * UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
      (Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):
      (Ewk_Navigation_Policy_Decision::request):
      * UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
      (Ewk_Navigation_Policy_Decision::create):
      (Ewk_Navigation_Policy_Decision):
      * UIProcess/API/efl/ewk_url_request.cpp:
      (EwkUrlRequest::EwkUrlRequest):
      (EwkUrlRequest::url):
      (EwkUrlRequest::firstParty):
      (EwkUrlRequest::httpMethod):
      (ewk_url_request_url_get):
      (ewk_request_cookies_first_party_get):
      (ewk_url_request_http_method_get):
      * UIProcess/API/efl/ewk_url_request.h:
      * UIProcess/API/efl/ewk_url_request_private.h:
      (EwkUrlRequest):
      (EwkUrlRequest::create):
      * UIProcess/API/efl/ewk_url_response.cpp:
      (EwkUrlResponse::EwkUrlResponse):
      (EwkUrlResponse::httpStatusCode):
      (EwkUrlResponse::url):
      (EwkUrlResponse::mimeType):
      (EwkUrlResponse::contentLength):
      (ewk_url_response_url_get):
      (ewk_url_response_status_code_get):
      (ewk_url_response_mime_type_get):
      (ewk_url_response_content_length_get):
      * UIProcess/API/efl/ewk_url_response.h:
      * UIProcess/API/efl/ewk_url_response_private.h:
      (EwkUrlResponse):
      (EwkUrlResponse::create):
      * UIProcess/efl/ContextHistoryClientEfl.cpp:
      (WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
      * UIProcess/efl/DownloadManagerEfl.cpp:
      (WebKit::DownloadManagerEfl::didReceiveResponse):
      * UIProcess/efl/ResourceLoadClientEfl.cpp:
      (WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
      (WebKit::ResourceLoadClientEfl::didSendRequestForResource):
      (WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3af76319
    • rakuco@webkit.org's avatar
      [EFL] Unreviewed gardening. · 0a42b24e
      rakuco@webkit.org authored
      Remove a few tests which depend on setIsolatedWorldSecurityOrigin
      since they are already skipped in efl/TestExpectations.
      
      * platform/efl-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a42b24e
    • commit-queue@webkit.org's avatar
      [EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389 · e7415e1e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101203
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Attempt for continue without credential when the client cancels
      authentication (or does not handle the authentication request)
      instead of cancelling the load. We now get a 402 error when
      when cancelling the authentication, which is the behavior we
      want (and the behavior we used to have before r133389).
      
      * UIProcess/API/efl/ewk_auth_request.cpp:
      (Ewk_Auth_Request::~Ewk_Auth_Request):
      (Ewk_Auth_Request::continueWithoutCredential):
      (ewk_auth_request_cancel):
      * UIProcess/API/efl/ewk_auth_request_private.h:
      (Ewk_Auth_Request):
      * UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
      (TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7415e1e
    • commit-queue@webkit.org's avatar
      [EFL] fast/forms/week-multiple-fields does not exist and should be removed from TestExpectations · 8cf8e629
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101202
      
      Unreviewed EFL gardening.
      
      Remove fast/forms/week-multiple-fields from TestExpections since it does
      not exist and makes the style script complain.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cf8e629
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 53e97214
      zandobersek@gmail.com authored
      Clean up the inspector-related test expectations. Instead of marking
      many tests as skipped, proper failure expectations are put in place.
      The tests are still being skipped as their current behavior on the
      buildbots is unknown.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53e97214
    • commit-queue@webkit.org's avatar
      [EFL] Fix build warning in EWebLauncher/main.c · c00dfbe9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101197
      
      Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
      Reviewed by Kentaro Hara.
      
      Because the strp of _Ecore_Getopt_Value is char** (Ecore_Getopt.h),
      The parameter of ECORE_GETOPT_VALUE_STR should be char*
      
      * EWebLauncher/main.c:
      (_User_Arguments):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c00dfbe9
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r133286, r133385, and r133394. · 844de9e1
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/133286
      http://trac.webkit.org/changeset/133385
      http://trac.webkit.org/changeset/133394
      https://bugs.webkit.org/show_bug.cgi?id=101198
      
      Broke image placement on some web sites. (Requested by kling
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-05
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::sweepMatchedPropertiesCache):
      (WebCore::StyleResolver::matchAllRules):
      (WebCore::StyleResolver::canShareStyleWithElement):
      * dom/Attr.cpp:
      (WebCore::Attr::detachFromElementWithValue):
      * dom/Element.cpp:
      (WebCore::Element::~Element):
      (WebCore::Element::detachAttribute):
      (WebCore::Element::getAttribute):
      (WebCore::Element::setAttributeNode):
      (WebCore::Element::removeAttributeInternal):
      (WebCore::Element::getAttributeNode):
      (WebCore::Element::getAttributeNodeNS):
      (WebCore::Element::normalizeAttributes):
      (WebCore::Element::attrIfExists):
      (WebCore::Element::ensureAttr):
      (WebCore::Element::cloneAttributesFromElement):
      * dom/Element.h:
      (Element):
      (WebCore::Element::updateInvalidAttributes):
      * dom/ElementAttributeData.cpp:
      (WebCore::MutableElementAttributeData::MutableElementAttributeData):
      (WebCore):
      (WebCore::attrListMap):
      (WebCore::attrListForElement):
      (WebCore::ensureAttrListForElement):
      (WebCore::removeAttrListForElement):
      (WebCore::findAttrInList):
      (WebCore::ElementAttributeData::attrIfExists):
      (WebCore::ElementAttributeData::ensureAttr):
      (WebCore::ElementAttributeData::setAttr):
      (WebCore::ElementAttributeData::removeAttr):
      (WebCore::ElementAttributeData::detachAttrObjectsFromElement):
      (WebCore::ElementAttributeData::reportMemoryUsage):
      (WebCore::ElementAttributeData::cloneDataFrom):
      (WebCore::ElementAttributeData::clearAttributes):
      (WebCore::ElementAttributeData::getAttributeNode):
      * dom/ElementAttributeData.h:
      (WebCore):
      (WebCore::ElementAttributeData::attributeStyle):
      (WebCore::ElementAttributeData::setAttributeStyle):
      (ElementAttributeData):
      (WebCore::ElementAttributeData::ElementAttributeData):
      * dom/Node.h:
      (WebCore):
      (WebCore::Node::hasAttrList):
      (WebCore::Node::attributeStyleDirty):
      (WebCore::Node::setAttributeStyleDirty):
      (WebCore::Node::clearAttributeStyleDirty):
      (Node):
      (WebCore::Node::setHasAttrList):
      (WebCore::Node::clearHasAttrList):
      (WebCore::Node::isStyleAttributeValid):
      (WebCore::Node::setIsStyleAttributeValid):
      (WebCore::Node::clearIsStyleAttributeValid):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::updateStyleAttribute):
      (WebCore::StyledElement::attributeChanged):
      (WebCore::StyledElement::styleAttributeChanged):
      (WebCore::StyledElement::inlineStyleChanged):
      (WebCore::StyledElement::updateAttributeStyle):
      * dom/StyledElement.h:
      (StyledElement):
      (WebCore::StyledElement::invalidateStyleAttribute):
      (WebCore::StyledElement::attributeStyle):
      * inspector/InspectorCSSAgent.cpp:
      (WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      844de9e1
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Add --window-size command line option to EFL MiniBrowser · 438d7bda
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100942
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Added window-size (-s) command line option to EFL MiniBrowser.
      
      * MiniBrowser/efl/main.c:
      (window_create):
      (parse_window_size):
      (elm_main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      438d7bda
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · 6c0758a2
      kkristof@inf.u-szeged.hu authored
      Skip fast/dom/shadow/shadowroot-type.html because SHADOW_DOM is disabled.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c0758a2
    • hausmann@webkit.org's avatar
      [Qt] Trivial unreviewed: Add missing module dependencies for builds in Qt CI system. · c0345a11
      hausmann@webkit.org authored
      These fields aren't used by anyone except some perl scripts in the Qt CI builds.
      
      * Source/sync.profile:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0345a11
    • hausmann@webkit.org's avatar
      Unreviewed trivial Qt build fix. · 1d9a48ea
      hausmann@webkit.org authored
      Surround imports from QtGui by QT_{BEGIN,END}_NAMESPACE to fix namespaced
      builds.
      
      * platform/graphics/qt/GraphicsContextQt.cpp:
      * platform/graphics/qt/ImageQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d9a48ea
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 9755e96d
      zandobersek@gmail.com authored
      Rebaselining MathML tests after r132264 and r133221 and updating
      pixel baselines with outdated hash.
      
      * platform/gtk/TestExpectations:
      * platform/gtk/mathml/presentation/attributes-expected.png:
      * platform/gtk/mathml/presentation/fenced-expected.png:
      * platform/gtk/mathml/presentation/fenced-expected.txt:
      * platform/gtk/mathml/presentation/mo-expected.png:
      * platform/gtk/mathml/presentation/mo-expected.txt:
      * platform/gtk/mathml/presentation/mo-stretch-expected.png:
      * platform/gtk/mathml/presentation/mo-stretch-expected.txt:
      * platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
      * platform/gtk/mathml/presentation/over-expected.png:
      * platform/gtk/mathml/presentation/over-expected.txt:
      * platform/gtk/mathml/presentation/roots-expected.png:
      * platform/gtk/mathml/presentation/row-alignment-expected.png:
      * platform/gtk/mathml/presentation/row-alignment-expected.txt:
      * platform/gtk/mathml/presentation/row-expected.png:
      * platform/gtk/mathml/presentation/row-expected.txt:
      * platform/gtk/mathml/presentation/style-expected.png:
      * platform/gtk/mathml/presentation/subsup-expected.png:
      * platform/gtk/mathml/presentation/subsup-expected.txt:
      * platform/gtk/mathml/presentation/tables-expected.png:
      * platform/gtk/mathml/presentation/tables-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9755e96d
    • dominik.rottsches@intel.com's avatar
      [EFL] Skip compositing/repaint/invalidations-on-composited-layers.html · 6adf1755
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101181
      
      Unreviewed EFL gardening.
      
      Mark compositing/repaint/invalidations-on-composited-layers.html as
      expected to fail since accelerated compositing is disabled by default
      on EFL port.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6adf1755
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 4ebdc982
      zandobersek@gmail.com authored
      Skipping ENABLE_SUBPIXEL- and ENABLE_INPUT_TYPE_*-related testing
      directories. These features are not enabled yet and most of the
      tests fail.
      
      Removing failure expectation for fast/files/workers/worker-apply-blob-url-to-xhr.html,
      the issue was fixed in r132973.
      
      Moving the skip entry for css3/device-adapt to the proper section.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ebdc982
    • shinyak@chromium.org's avatar
      [Shadow] ShadowRoot type is not set correctly. · 4ea5af09
      shinyak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101188
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      ShadowRoot type is not set correctly in Release build. We have had to remove #ifndef block.
      
      Test: fast/dom/shadow/shadowroot-type.html
      
      * dom/ShadowRoot.cpp:
      (WebCore::ShadowRoot::create):
      * testing/Internals.cpp:
      (WebCore::Internals::shadowRootType):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * fast/dom/shadow/shadowroot-type-expected.txt: Added.
      * fast/dom/shadow/shadowroot-type.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ea5af09
    • commit-queue@webkit.org's avatar
      [EFL][WK2] The icon database path should be set by the client · 92236bc0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101182
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      No longer set the favicon database path in database instance getter.
      Instead, a new ewk_context_favicon_database_directory_set() API
      function was added to let the client set the icon database path.
      This is needed because the icon database path can only be set once
      and setting it unconditionally in the getter prevents the client
      from setting it.
      
      This will also avoid crashes in WebKitTestRunner since WKTR was
      setting the path once and ewk_context was attempting to override it.
      
      Note that the favicon database functionality is disabled until the
      client sets its path.
      
      * UIProcess/API/efl/ewk_context.cpp:
      (Ewk_Context::ensureFaviconDatabase):
      (Ewk_Context::setFaviconDatabaseDirectoryPath):
      (Ewk_Context::faviconDatabase):
      (ewk_context_favicon_database_directory_set):
      * UIProcess/API/efl/ewk_context.h:
      * UIProcess/API/efl/ewk_context_private.h:
      (Ewk_Context):
      * UIProcess/API/efl/ewk_favicon_database.cpp:
      (Ewk_Favicon_Database::Ewk_Favicon_Database):
      (Ewk_Favicon_Database::~Ewk_Favicon_Database):
      (Ewk_Favicon_Database::iconURLForPageURL):
      (Ewk_Favicon_Database::iconForPageURL):
      (Ewk_Favicon_Database::getIconSurfaceSynchronously):
      * UIProcess/API/efl/ewk_favicon_database_private.h:
      (WebKit):
      (Ewk_Favicon_Database::create):
      (Ewk_Favicon_Database):
      * UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
      (TEST_F):
      
      Tools:
      
      Enable favicon database functionality in MiniBrowser since
      it is used and it is no longer enabled by default.
      
      * MiniBrowser/efl/main.c:
      (elm_main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92236bc0
    • tkent@chromium.org's avatar
      BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient · 506558f2
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101038
      
      Reviewed by Hajime Morita.
      
      Add DateTimeChooserClient behavior to BaseChooserOnlyDateAndTimeInputType.
      It means that date/time input elements without
      ENABLE_INPUT_MULTIPLE_FIELDS_UI can open date/time choosers by
      DOMActivate event.
      
      This patch doesn't change behavior yet because Chromimum-Android port
      intercepts user events and doesn't deliver them to date/time input
      elements. <http://crbug.com/159381>
      
      * html/BaseChooserOnlyDateAndTimeInputType.cpp:
      Add DateTimeChooserClient behavior. The code is similar to
      PickerIndicatorElement.
      (WebCore::BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType):
      Closes DateTimeChooser.
      (WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
      Open DateTimeChooser if
       - The element is not disabled,
       - The element is not read-only,
       - The element has a renderer,
       - This event is created by a user gesture, and
       - The element has no DateTimeChooser.
      (WebCore::BaseChooserOnlyDateAndTimeInputType::detach):
      Closes DateTimeChooser.
      (WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
      Set a string value coming from a chooser to the input element.
      (WebCore::BaseChooserOnlyDateAndTimeInputType::didEndChooser):
      Clear m_dateTimeChooser when the chooser was closed.
      (WebCore::BaseChooserOnlyDateAndTimeInputType::closeDateTimeChooser):
      Requests to close the chooser.
      * html/BaseChooserOnlyDateAndTimeInputType.h:
      (BaseChooserOnlyDateAndTimeInputType):
       - Implement DateTimeChooserClient
       - Add closeDateTimeChooser helper function.
       - Add detach override.
       - Add m_dateTimeChooser.
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setupDateTimeChooserParameters):
      Added. The code is moved from PickerIndicatorElement.cpp in order to
      share it with BaseChooserOnlyDateAndTimeInputType.
      * html/HTMLInputElement.h:
      (HTMLInputElement): Declare setupDateTimeChooserParameters.
      * html/shadow/PickerIndicatorElement.cpp:
      (WebCore::PickerIndicatorElement::openPopup):
      Move some code to HTMLInputElement::setupDateTimeChooserParameters.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@133441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      506558f2