1. 18 Sep, 2009 40 commits
    • oliver@apple.com's avatar
      Implement ES5 Object.defineProperty function · 34803ec6
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29503
      
      Reviewed by Geoff Garen
      
      Implement Object.defineProperty.  This requires adding the API to
      ObjectConstructor, along with a helper function that implements the
      ES5 internal [[ToPropertyDescriptor]] function.  It then adds
      JSObject::defineOwnProperty that implements the appropriate ES5 semantics.
      Currently defineOwnProperty uses a delete followed by a put to redefine
      attributes of a property, clearly this is less efficient than it could be
      but we can improve this if it needs to be possible in future.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34803ec6
    • beidson@apple.com's avatar
      Speculative fix for: · effcf9ce
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29322
      and
      https://bugs.webkit.org/show_bug.cgi?id=29505
      
      Reviewed by Alexey Proskuryakov.
      
      Adding a "Connection: close" header might make the tests work more reliably, 
      and doesn't seem to make anything worse: They all continue to pass on my machine!
      
      * http/tests/loading/resources/basic-auth-testing.php:
      * http/tests/loading/resources/othersubresources/protected-resource.php:
      * http/tests/loading/resources/protected-resource.php:
      * http/tests/loading/resources/subresources/protected-resource.php:
      * http/tests/xmlhttprequest/resources/cross-origin-authorization.php:
      * http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php:
      * http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      effcf9ce
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · c97fc777
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=29510
              Active DOM objects should be suspended while a modal dialog is displayed
      
              * manual-tests/js-timers-beneath-modal-dialog.html: Added a test for JS timers.
      
              * page/PageGroupLoadDeferrer.cpp:
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
              Match other platforms, and make Mac also suspend active DOM objects. Since a page that
              currently displays a modal dialog cannot go into page cache, there is no danger of suspending
              an object twice.        
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c97fc777
    • eric@webkit.org's avatar
      2009-09-18 Alpha Lam <hclam@chromium.org> · bff0b2dd
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Media layout tests should have a way to provide test files in different formats
              https://bugs.webkit.org/show_bug.cgi?id=28327
      
              Updating 25 media layout tests to use media files based on supported codecs.
      
              * media/progress-event-at-least-one.html: Use findMediaFile() to locate a supported media file.
              * media/video-pause-empty-events.html: ditto.
              * media/video-play-empty-events.html: ditto.
              * media/video-play-pause-events.html: ditto.
              * media/video-played-collapse.html: ditto.
              * media/video-played-ranges-1.html: ditto.
              * media/video-played-reset.html: ditto.
              * media/video-played.js: ditto.
              (videoPlayedMain):
              * media/video-seek-past-end-paused.html: ditto.
              * media/video-seek-past-end-playing.html: ditto.
              * media/video-seekable.html: ditto.
              * media/video-seeking.html: ditto.
              * media/video-size.html: ditto.
              * media/video-source-error.html: ditto.
              * media/video-source-type-params.html: ditto.
              * media/video-source-type.html: ditto.
              * media/video-source.html: ditto.
              * media/video-src-change.html: ditto.
              * media/video-src-invalid-remove.html: ditto.
              * media/video-src-remove.html: ditto. Use counting.mp4 instead of silence.mpg.
              * media/video-src-remove-expected.txt: Updated results.
              * media/video-src-set.html: ditto.
              * media/video-src-source.html: ditto.
              * media/video-src.html: ditto.
              * media/video-timeupdate-during-playback.html: ditto.
              * media/video-volume.html: ditto.
              * media/video-zoom.html: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bff0b2dd
    • eric@webkit.org's avatar
      2009-09-18 Csaba Osztrogonac <oszi@inf.u-szeged.hu> · e055ab35
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] Buildfix caused by http://trac.webkit.org/changeset/48513
              https://bugs.webkit.org/show_bug.cgi?id=29351
      
              * bridge/qt/qt_instance.h: createRuntimeObject method renamed to newRuntimeObject.
              * bridge/runtime.h: Visibility of newRuntimeObject method modified to protected.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e055ab35
    • andersca@apple.com's avatar
      Add failing tests to the skipped list. · 5f923085
      andersca@apple.com authored
              
      * platform/mac-snowleopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f923085
    • eric@webkit.org's avatar
      2009-09-18 Yury Semikhatsky <yurys@chromium.org> · a44f5f8f
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Fix parameter substitutions in console.log().
      
              https://bugs.webkit.org/show_bug.cgi?id=29366
      
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage.prototype._format):
              * inspector/front-end/InjectedScript.js:
              (InjectedScript.getPrototypes):
              (InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
              * inspector/front-end/utilities.js:
              ():
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a44f5f8f
    • mrowe@apple.com's avatar
      Versioning. · 9764d3a4
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9764d3a4
    • weinig@apple.com's avatar
      Temporarily remove an assertion that was getting hit when going · 45fe8d85
      weinig@apple.com authored
      back to a page in the page cache while a banner in Safari was visible.
      We should re-enable this once that is fixed. See <rdar://problem/7218118>
      
      Reviewed by Geoffrey Garen and Brady Eidson.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scheduleRelayout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45fe8d85
    • andersca@apple.com's avatar
      Try fixing the build again. · 083d1ba9
      andersca@apple.com authored
              
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::wndProc):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      083d1ba9
    • andersca@apple.com's avatar
      Fix windows build. · eb4d0e70
      andersca@apple.com authored
              
      * platform/win/PopupMenuWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb4d0e70
    • weinig@apple.com's avatar
      Convert another callback type object to store the global object · 75e16bb3
      weinig@apple.com authored
      instead of the frame.
      
      Reviewed by Gavin 'BearClaw' Barraclough.
      
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::create):
      (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver):
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/js/JSCustomXPathNSResolver.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75e16bb3
    • andersca@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=29332 · 9c050adc
      andersca@apple.com authored
      <rdar://problem/7231652> 
      REGRESSION (r48446): While a <select> popup menu is open, the
      rest of the WebView doesn't respond to mouse move events.
      
      Reviewed by Sam Weinig.
      
      * platform/win/PopupMenuWin.cpp:
      (WebCore::translatePoint):
      New helper function that translates a point between HWND coordinates.
              
      (WebCore::PopupMenu::show):
      Protect the PopupMenu if someone removes the <select> in response to a mouse
      event. Handle WM_HOST_WINDOW_MOUSEMOVE events.
              
      (WebCore::PopupMenu::wndProc):
      in the WM_MOUSEMOVE handler, if the mouse is not over the popup, post a 
      WM_HOST_WINDOW_MOUSEMOVE event so that the host window (the WebView) gets the
      mouse move event.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c050adc
    • eric@webkit.org's avatar
      2009-09-18 Norbert Leser <norbert.leser@nokia.com> · f1b44a6d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Corrected the Symbian specific UID3 values to be assigned
              from the "unprotected" pool that permits self-signing of
              those test and demo executables. (Added new UID3 values
              where they were missing for new components.)
      
              * QGVLauncher/QGVLauncher.pro:
              * QtLauncher/QtLauncher.pro:
              * tests/benchmarks/loading/tst_loading.pro:
              * tests/benchmarks/painting/tst_painting.pro:
              * tests/qwebelement/qwebelement.pro:
              * tests/qwebframe/qwebframe.pro:
              * tests/qwebhistory/qwebhistory.pro:
              * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
              * tests/qwebpage/qwebpage.pro:
              * tests/qwebplugindatabase/qwebplugindatabase.pro:
              * tests/qwebview/qwebview.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1b44a6d
    • barraclough@apple.com's avatar
      2009-09-18 Gabor Loki <loki@inf.u-szeged.hu> · 0505a8fa
      barraclough@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Build fix to enable ARM_THUMB2 on Linux
              https://bugs.webkit.org/show_bug.cgi?id=
      
              * jit/ExecutableAllocator.h:
              (JSC::ExecutableAllocator::cacheFlush):
              * jit/JITStubs.cpp:
              * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0505a8fa
    • simon.fraser@apple.com's avatar
      2009-09-18 Simon Fraser <simon.fraser@apple.com> · 83c45d04
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Compositing layers are incorrectly positioned after scrolling with position:fixed
              https://bugs.webkit.org/show_bug.cgi?id=29262
      
              When scrolling a page with compositing layers inside a position:fixed element,
              we need to update the compositing layer positions when the scroll position changes.
      
              Test: compositing/geometry/fixed-position.html
      
              * WebCore.base.exp:
              Export FrameView::scrollPositionChanged()
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollPositionChanged):
              New method that sends the scroll event, and updates compositing layers positions if necessary.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c45d04
    • barraclough@apple.com's avatar
      2009-09-18 Gabor Loki <loki@inf.u-szeged.hu> · 32aaad09
      barraclough@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
              https://bugs.webkit.org/show_bug.cgi?id=29122
      
              Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
              macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
              when Thumb-2 instruction set is the required target. The
              PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
              case where the code is common the PLATFORM(ARM) have to be used.
      
              * assembler/ARMAssembler.cpp:
              * assembler/ARMAssembler.h:
              * assembler/ARMv7Assembler.h:
              * assembler/MacroAssembler.h:
              * assembler/MacroAssemblerARM.cpp:
              * assembler/MacroAssemblerARM.h:
              * assembler/MacroAssemblerCodeRef.h:
              (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
              * jit/ExecutableAllocator.h:
              * jit/JIT.h:
              * jit/JITInlineMethods.h:
              (JSC::JIT::beginUninterruptedSequence):
              (JSC::JIT::preserveReturnAddressAfterCall):
              (JSC::JIT::restoreReturnAddressBeforeReturn):
              (JSC::JIT::restoreArgumentReference):
              (JSC::JIT::restoreArgumentReferenceForTrampoline):
              * jit/JITOpcodes.cpp:
              * jit/JITStubs.cpp:
              (JSC::JITThunks::JITThunks):
              * jit/JITStubs.h:
              * wtf/Platform.h:
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::generateEnter):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32aaad09
    • simon.fraser@apple.com's avatar
      2009-09-18 Simon Fraser <simon.fraser@apple.com> · 3c99a321
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Transformed elements inside position:fixed container are clipped incorrectly
              https://bugs.webkit.org/show_bug.cgi?id=29346
      
              Fix clipping and hit testing on transformed elements inside a position:fixed element.
              Previously, the code used the overflowClipRect of the parent clip rects, but
              this is not correct for fixed postion elements. Instead, share code that is
              already present in calculateRects() to get the correct rect.
      
              Test: fast/overflow/position-fixed-transform-clipping.html
      
              * rendering/RenderLayer.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              Call the new backgroundClipRect() to get the correct clipRect.
      
              (WebCore::RenderLayer::backgroundClipRect):
              New method, factored out of calculateRects(), that computes the clip rect,
              doing the right thing for fixed position elements.
      
              (WebCore::RenderLayer::calculateRects):
              Call the new backgroundClipRect() method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c99a321
    • mitz@apple.com's avatar
      Updated test result for <rdar://problem/7050773> · 87a5f65c
      mitz@apple.com authored
      * platform/mac/accessibility/document-attributes-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87a5f65c
    • eric@webkit.org's avatar
      2009-09-18 Alex Milowski <alex@milowski.com> · ede36bb4
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Added checkWebCoreMathMLSupport and hasMathMLSupport to support
              checking for whether MathML tests should be run
      
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ede36bb4
    • mitz@apple.com's avatar
      WebCore: Fix <rdar://problem/7050773> REGRESSION (r40098) Crash at · ca290e54
      mitz@apple.com authored
      WebCore::RenderBlock::layoutBlock()
      https://bugs.webkit.org/show_bug.cgi?id=29498
      
      Reviewed by Darin Adler.
      
      Test: accessibility/nested-layout-crash.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::updateBackingStore): Changed to
          call Document::updateLayoutIgnorePendingStylesheets() instead of
          calling RenderObject::layoutIfNeeded(). The latter requires that
          there be no pending style recalc, which allows methods that call
          Document::updateLayout() to be called during layout without risking
          re-entry into layout.
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityActionNames]): Null-check
          m_object after calling updateBackingStore(), since style recalc may
          destroy the renderer, which destroys the accessibility object and
          detaches it from the wrapper.
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityHitTest:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityIsIgnored]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
           Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformPressAction]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformAction:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
          Ditto.
      
      LayoutTests: Test for <rdar://problem/7050773> REGRESSION (r40098) Crash at
      WebCore::RenderBlock::layoutBlock()
      https://bugs.webkit.org/show_bug.cgi?id=29498
      
      Reviewed by Darin Adler.
      
      * accessibility/nested-layout-crash-expected.txt: Added.
      * accessibility/nested-layout-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca290e54
    • eric@webkit.org's avatar
      2009-09-18 Fumitoshi Ukai <ukai@chromium.org> · 35738bfb
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Update Qt build system for Web Socket.
              https://bugs.webkit.org/show_bug.cgi?id=29270
      
              * WebCore.pro:
              * platform/network/qt/SocketStreamError.h: Added.
              * platform/network/qt/SocketStreamHandle.h: Added.
              * platform/network/qt/SocketStreamHandleSoup.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35738bfb
    • eric.carlson@apple.com's avatar
      2009-09-18 Eric Carlson <eric.carlson@apple.com> · b2498fa7
      eric.carlson@apple.com authored
              Reviewed by Darin Adler.
      
              NULL check HTMLMediaElement::m_playedTimeRanges.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=29494
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::addPlayedRange): New. Create m_playedTimeRanges if
              necessary, add range specified.
              (WebCore::HTMLMediaElement::seek): Use addPlayedRange. 
              (WebCore::HTMLMediaElement::played): Use addPlayedRange. Change time comparison 
              to be more readable.
              (WebCore::HTMLMediaElement::updatePlayState): Ditto.
              * html/HTMLMediaElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2498fa7
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · 22471b2e
      xan@webkit.org authored
              Build fix.
      
              Add missing file to the repository.
      
              * tests/testhittestresult.c: Added.
              (test_info_new):
              (test_info_destroy):
              (hit_test_result_fixture_setup):
              (hit_test_result_fixture_teardown):
              (load_status_cb):
              (test_webkit_hit_test_result):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22471b2e
    • darin@apple.com's avatar
      Added bug number. · 6068b164
      darin@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6068b164
    • darin@apple.com's avatar
      Some small steps toward improving run-webkit-tests. My goal is to · 9daeeca7
      darin@apple.com authored
      refactor much more of the script into functions. Later we can add
      parallel test running to the tool. But better structure may help
      even if someone decides to translate this into another scripting
      language instead.
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-28
      Reviewed by Mark Rowe.
      
      * Scripts/run-webkit-tests: Break more pieces of the script into
      seprate functions. Added readSkippedFiles, findTestsToRun, and
      printResults functions. Removed custom code to skip results.html
      and instead just put it into the ignoredFiles hash. Fixed some
      indentation. Sorted function declarations, global variables,
      and options at the top of the file alphabetically so they're not
      in a semi-random order.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9daeeca7
    • weinig@apple.com's avatar
      WebCore: Follow up fix for https://bugs.webkit.org/show_bug.cgi?id=29276 · 8d13417e
      weinig@apple.com authored
      REGRESSION(r48334): WebKit crashes on file select by drag
      
      Reviewed by Adele Peterson.
      
      Don't use Document.elementFromPoint since it returns null if the point
      is outside the viewport.  Instead, just hit test ourselves.
      
      Test: fast/events/drag-file-crash.html
      
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29276
      REGRESSION(r48334): WebKit crashes on file select by drag
      
      Reviewed by Adele Peterson.
      
      * fast/events/drag-file-crash-expected.txt: Added.
      * fast/events/drag-file-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d13417e
    • darin@apple.com's avatar
      Fix date on a change log entry. · f93e081e
      darin@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f93e081e
    • darin@apple.com's avatar
      Each wrapped Objective-C object should use a single RuntimeObjectImp · f55539ca
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29351
      rdar://problem/7142294
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-18
      Reviewed by Sam Weinig.
      
      * WebCore.base.exp: Added a newly-needed exported symbol.
      
      * bindings/objc/DOMInternal.h: Eliminated unused
      createWrapperCacheWithIntegerKeys; it has not been needed since the
      RGBColor wrappers were reworked.
      * bindings/objc/DOMInternal.mm: Ditto.
      
      * bridge/objc/objc_instance.h: Made the create function non-inline.
      * bridge/objc/objc_instance.mm:
      (createInstanceWrapperCache): Added. Creates an appropriate map table.
      (ObjcInstance::create): Moved here from header. Uses NSMapGet and
      NSMapInsert to cache the instance in a map table.
      (ObjcInstance::~ObjcInstance): Added a call to NSMapRemove to remove
      the instance from the map table.
      
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtInstance::~QtInstance): Remove unneeded code to remove
      the instance from cachedObjects, which no longer exists.
      (JSC::Bindings::QtInstance::newRuntimeObject): Renamed to overload new
      bottleneck. Caching is now handled by the base class.
      
      * bridge/runtime.cpp:
      (JSC::Bindings::Instance::Instance): Initialize m_runtimeObject to 0.
      (JSC::Bindings::Instance::~Instance): Assert m_runtimeObject is 0.
      (JSC::Bindings::Instance::createRuntimeObject): Use m_runtimeObject
      if it's already set. Set m_runtimeObject and call addRuntimeObject
      if it's not.
      (JSC::Bindings::Instance::newRuntimeObject): Added. Virtual function,
      used only by createRuntimeObject.
      (JSC::Bindings::Instance::willDestroyRuntimeObject): Added.
      Calls removeRuntimeObject and then clears m_runtimeObject.
      (JSC::Bindings::Instance::willInvalidateRuntimeObject): Added.
      Clears m_runtimeObject.
      
      * bridge/runtime.h: Made createRuntimeObject non-virtual. Added
      willDestroyRuntimeObject, willInvalidateRuntimeObject,
      newRuntimeObject, and m_runtimeObject.
      
      * bridge/runtime_object.cpp:
      (JSC::RuntimeObjectImp::RuntimeObjectImp): Removed addRuntimeObject
      call, now handled by caller.
      (JSC::RuntimeObjectImp::~RuntimeObjectImp): Replaced removeRuntimeObject
      call with willDestroyRuntimeObject call; the latter nows calls
      removeRuntimeObject.
      (JSC::RuntimeObjectImp::invalidate): Added willInvalidateRuntimeObject
      call.
      
      * bridge/runtime_object.h: Made invalidate non-virtual.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f55539ca
    • kenneth@webkit.org's avatar
      [Gtk] Unreviewed build fix. · 44dbecd6
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-18
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dbecd6
    • kenneth@webkit.org's avatar
      Make PlatformWindow return something else than PlatformWidget · e8249bf2
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29085
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
      Reviewed by Simon Hausmann.
      
      WebCore:
      
      Make platformWindow return a PlatformPageClient
      (for now typedef'ed to PlatformWidget)
      
      Also, change the name of platformWindow to platformPageClient()
      
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (getPangoLayoutForAtk):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::platformPageClient):
      * page/Chrome.cpp:
      (WebCore::Chrome::platformPageClient):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::wheelEvent):
      (WebCore::EventHandler::currentPlatformMouseEvent):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      * platform/HostWindow.h:
      * platform/Widget.h:
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::getVisual):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::show):
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::ScrollView::platformAddChild):
      (WebCore::ScrollView::platformRemoveChild):
      (WebCore::ScrollView::visibleContentRect):
      * platform/gtk/WidgetGtk.cpp:
      (WebCore::Widget::setFocus):
      (WebCore::Widget::setCursor):
      * platform/qt/PlatformScreenQt.cpp:
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/qt/PopupMenuQt.cpp:
      (WebCore::PopupMenu::show):
      * platform/qt/WidgetQt.cpp:
      (WebCore::Widget::setCursor):
      * platform/win/PlatformScreenWin.cpp:
      (WebCore::monitorInfoForWidget):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::show):
      (WebCore::PopupMenu::calculatePositionAndSize):
      (WebCore::PopupMenu::wndProc):
      * platform/wx/RenderThemeWx.cpp:
      (WebCore::nativeWindowForRenderObject):
      * platform/wx/ScrollbarThemeWx.cpp:
      (WebCore::ScrollbarThemeWx::paint):
      * plugins/gtk/PluginViewGtk.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      * plugins/mac/PluginViewMac.cpp:
      (WebCore::PluginView::platformStart):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::handleKeyboardEvent):
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::platformStart):
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      
      WebKit/gtk:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      (WebKit::ChromeClient::runOpenPanel):
      * WebCoreSupport/ChromeClientGtk.h:
      * webkit/webkitprivate.cpp:
      (currentToplevelCallback):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_popup_menu_handler):
      
      WebKit/haiku:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::platformPageClient):
      * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::platformPageClient):
      
      WebKit/qt:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::platformPageClient):
      * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      Reflect the rename of platformWindow and it's return type.
      
      * AccessibleBase.cpp:
      (AccessibleBase::get_accParent):
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::platformPageClient):
      * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::platformPageClient):
      * WebKitSupport/ChromeClientWx.h:
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::isEditable):
      (WebCore::EditorClientWx::registerCommandForUndo):
      (WebCore::EditorClientWx::registerCommandForRedo):
      (WebCore::EditorClientWx::clearUndoRedoOperations):
      (WebCore::EditorClientWx::canUndo):
      (WebCore::EditorClientWx::canRedo):
      (WebCore::EditorClientWx::undo):
      (WebCore::EditorClientWx::redo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8249bf2
    • hausmann@webkit.org's avatar
      [Qt] Web inspector UI adjustments specific to the Qt platform: · daa9f964
      hausmann@webkit.org authored
      - Hide the close button
      - Hide the dock button
      - Disable the draggable toolbar
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=29384
      
      * inspector/front-end/inspector.css:
      * inspector/front-end/inspector.js:
      (WebInspector.toolbarDragStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daa9f964
    • hausmann@webkit.org's avatar
      Fix the Qt/Windows CE build. · fe9f3fda
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * JavaScriptCore.pri: Build the ce_time.cpp functions from
      within Qt externally.
      * wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the
      Qt build these functions are no external, too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9f3fda
    • hausmann@webkit.org's avatar
      QtWebKit Windows CE compile fixes · 7f26dc14
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      Exclude certain pure-WINCE specific code paths from the Qt build.
      
      * platform/graphics/BitmapImage.h:
      * platform/graphics/FontCache.h:
      * platform/graphics/MediaPlayer.cpp:
      * platform/text/TextEncodingRegistry.cpp:
      (WebCore::buildBaseTextCodecMaps):
      (WebCore::extendTextCodecMaps):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
      the corresponding PluginViewWndProc has the same guard in the header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f26dc14
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · 59eabdbb
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Document webkit_web_view_stop_loading.
      
              * webkit/webkitwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59eabdbb
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · fd4dd8e1
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add new tests to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add webkit_web_view_get_hit_test_result, a function to get a hit
              test result from a GdkEventButton. Useful to let applications
              decide between several actions on button press depending on what
              is being pressed.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_stop_loading):
              (documentPointForWindowPoint):
              (webkit_web_view_get_hit_test_result):
              * webkit/webkitwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4dd8e1
    • xan@webkit.org's avatar
      2009-09-14 Xan Lopez <xlopez@igalia.com> · 2266a5b0
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
              context information about a point in the web page.
      
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkithittestresult.cpp: Added.
              (webkit_hit_test_result_finalize):
              (webkit_hit_test_result_get_property):
              (webkit_hit_test_result_set_property):
              (webkit_hit_test_result_class_init):
              (webkit_hit_test_result_init):
              * webkit/webkithittestresult.h: Added.
              * webkit/webkitprivate.cpp:
              (WebKit::kit):
              * webkit/webkitprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2266a5b0
    • hausmann@webkit.org's avatar
      [Qt] Add persistence support for configuration options in the · 9a2d46fb
      hausmann@webkit.org authored
      inspector.
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * Api/qwebinspector.cpp:
      * QtLauncher/main.cpp:
      (main):
      * WebCoreSupport/InspectorClientQt.cpp:
      (WebCore::InspectorClientQt::populateSetting):
      (WebCore::InspectorClientQt::storeSetting):
      (WebCore::variantToSetting):
      (WebCore::settingToVariant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a2d46fb
    • eric@webkit.org's avatar
      2009-09-18 Steve Block <steveblock@google.com> · a05aaad4
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
              * fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.
      2009-09-18  Steve Block  <steveblock@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * bindings/js/JSGeolocationCustom.cpp: Modified.
              (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
              * page/PositionOptions.h: Modified.
              (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age.
              (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age.
              (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age.
              (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set.
              (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05aaad4
    • hausmann@webkit.org's avatar
      Fixed a bunch of documentation warnings. · ee26bcb7
      hausmann@webkit.org authored
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-18
      Reviewed by Ariya Hidayat.
      
      * Api/qwebgraphicsitem.cpp:
      * Api/qwebplugindatabase.cpp:
      * Api/qwebpluginfactory.cpp:
      * Api/qwebsecurityorigin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee26bcb7