1. 07 Oct, 2012 4 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r130596. · 345f46ef
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/130596
      https://bugs.webkit.org/show_bug.cgi?id=98616
      
      Broke build bots without IPV6 support
      
      Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-07
      
      Tools:
      
      * Scripts/webkitpy/common/system/platforminfo_mock.py:
      (MockPlatformInfo.is_cygwin):
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.baseline_version_dir):
      (Port.to.start_websocket_server):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_operating_system):
      (PortTest.test_build_path):
      * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
      (LayoutTestApacheHttpd):
      (LayoutTestApacheHttpd.__init__):
      
      LayoutTests:
      
      * http/conf/apache2-debian-httpd.conf:
      * http/conf/apache2-httpd.conf:
      * http/conf/cygwin-httpd.conf:
      * http/conf/fedora-httpd.conf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      345f46ef
    • rakuco@webkit.org's avatar
      webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files. · e1f08160
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98602
      
      Reviewed by Eric Seidel.
      
      Tools: 
      
      Unify all the different `Listen' directives present in the several
      httpd.conf files we have in LayoutTests/http/conf. For one, we
      were already passing `Listen 127.0.0.1:8000' via webkitpy before,
      and opening the other ports from the conf files.
      
      The configuration files differed mostly in the way they handled
      IPV6 ports. Some of them did not listen to IPV6 ports because the
      systems which used them sometimes did not have IPV6 support. The
      `http_server_supports_ipv6' method has been added to Port to
      address that. cygwin, on its turn, still seems to use Apache 1.3,
      which does not support IPV6 at all; the newly-added method has a
      special case for that.
      
      * Scripts/webkitpy/common/system/platforminfo_mock.py:
      (MockPlatformInfo.is_cygwin):
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.baseline_version_dir):
      (Port.to.start_websocket_server):
      (Port.to):
      (Port.to.http_server_supports_ipv6):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_http_server_supports_ipv6):
      (PortTest.test_build_path):
      * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
      (LayoutTestApacheHttpd):
      (LayoutTestApacheHttpd.__init__):
      
      LayoutTests: 
      
      * http/conf/apache2-debian-httpd.conf: Remove the `Listen'
      directive and related comments, it is passed to httpd by webkitpy
      now.
      * http/conf/apache2-httpd.conf: Ditto.
      * http/conf/cygwin-httpd.conf: Ditto.
      * http/conf/fedora-httpd.conf: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1f08160
    • commit-queue@webkit.org's avatar
      [EFL] Skip css3/masking tests added in r130592 · 4bd3ae3e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98614
      
      Unreviewed EFL gardening.
      
      Skip the two css3/masking ref tests added in r130592 since
      they fail for EFL port and GTK port.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-07
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bd3ae3e
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 224b2552
      zandobersek@gmail.com authored
      Adding crash and failure expectations for regressions introduced through r130584.
      Adding image mismatch expectations for two new tests introduced in r130592.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      224b2552
  2. 06 Oct, 2012 10 commits
    • tkent@chromium.org's avatar
      Update test expectation · f66de7e0
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98479
      
      Skip tests in fast/forms/date-multiple-fields/ because it needs
      ENABLE_INPUT_MULTIPLE_FIELDS_UI.
      
      * platform/chromium-android/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f66de7e0
    • krit@webkit.org's avatar
      -webkit-clip-path should parse IRIs · de10ea72
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96381
      
      Patch by Raul Hudea <rhudea@adobe.com> on 2012-10-06
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Implemented the clipping via referencing a SVG clipPath. Currently it works only if the clipPath is defined
      before using it on an HTML element. The forward reference issue is tracked via https://bugs.webkit.org/show_bug.cgi?id=90405.
      
      Tests: css3/masking/clip-path-reference-userSpaceOnUse.html
             css3/masking/clip-path-reference.html
             fast/masking/parsing-clip-path-iri.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add handling for SVG clipPath references.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue): Add handling for SVG clipPath references.
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyClipPath::applyValue): Add handling for SVG references.
      * rendering/ClipPathOperation.h:
      (ReferenceClipPathOperation): Added a new class corresponding to SVG referenced clipPath.
      (WebCore::ReferenceClipPathOperation::create):
      (WebCore::ReferenceClipPathOperation::url):
      (WebCore::ReferenceClipPathOperation::fragment):
      (WebCore::ReferenceClipPathOperation::operator==):
      (WebCore::ReferenceClipPathOperation::ReferenceClipPathOperation):
      (WebCore):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayerContents): Add handling for ReferenceClipPathOperation.
      * rendering/svg/RenderSVGResourceClipper.h:
      (RenderSVGResourceClipper): Made applyClippingToContext public as it needs to be called directly for HTML elements.
      
      LayoutTests:
      
      Tests for SVG referenced clipPath with both types of clipPathUnits: "userSpaceOnUse" and "objectBoundingBox".
      
      * css3/masking/clip-path-reference-expected.html: Added.
      * css3/masking/clip-path-reference-userSpaceOnUse-expected.html: Added.
      * css3/masking/clip-path-reference-userSpaceOnUse.html: Added.
      * css3/masking/clip-path-reference.html: Added.
      * fast/masking/parsing-clip-path-iri-expected.txt: Added.
      * fast/masking/parsing-clip-path-iri.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de10ea72
    • rakuco@webkit.org's avatar
      [EFL] Mark media/audio-garbage-collect.html as flaky on WK2. · 3d1cb3c1
      rakuco@webkit.org authored
      * platform/efl-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d1cb3c1
    • ggaren@apple.com's avatar
      If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive · e0fc2216
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88834
      
      Reviewed by Gavin Barraclough.
      
      Source/WebCore: 
      
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::isObservable): Clarified this comment, since it seems to have
      misled some folks. 
      
      * bindings/js/JSNodeCustom.h:
      (WebCore::willCreatePossiblyOrphanedTreeByRemoval): New helper function
      to ensure that a disconnected tree is visible to JavaScript.
      
      * bindings/js/ScriptState.cpp:
      (WebCore::mainWorldScriptState): Need to check for null because a document's
      frame can be null.
      
      * dom/ContainerNode.cpp:
      (WebCore::dispatchChildRemovalEvents): When we remove a subtree from the
      document, we sever the reference that JavaScript previously held by
      referencing its root. So, we give JavaScript an opportunity to establish
      a reference to the new root.
      
      LayoutTests: 
      
      * fast/dom/gc-12-expected.txt: Added.
      * fast/dom/gc-12.html: Added. Test case matches an example cited by
      Kentaro Hara <haraken@chromium.org> in bugzilla.
      
      * fast/dom/gc-3-expected.txt:
      * fast/dom/gc-3.html:
      * fast/dom/gc-5-expected.txt:
      * fast/dom/gc-5.html: Updated these tests to reflect new expected behavior.
      We've decided that disconnected trees should persist in memory. This risks
      a programmer accidentally retaining more memory than expected, but it
      also makes the API more obvious.
      
      * fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
      * fast/dom/gc-dom-tree-lifetime.html: Added. Test case written by
      Kentaro Hara <haraken@chromium.org>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0fc2216
    • rakuco@webkit.org's avatar
      [EFL] Gardening. · 32bec245
      rakuco@webkit.org authored
      Skip fast/selectors/unqualified-hover-strict.html because it seems
      to be flaky.
      
      While here, correct its pixel expectation and fix its
      svn:mime-type property.
      
      * platform/efl/fast/selectors/unqualified-hover-strict-expected.png: Modified property svn:mime-type.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32bec245
    • commit-queue@webkit.org's avatar
      [EFL] Gardening to make the bots green · 378144c1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98590
      
      Unreviewed EFL gardening.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
      
      * platform/efl/TestExpectations: Skip
      fast/writing-mode/vertical-subst-font-vert-no-dflt.html after r130570.
      * platform/efl/http/tests/misc/acid3-expected.txt: Update baselines
      after r130555.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      378144c1
    • commit-queue@webkit.org's avatar
      [EFL] Add baselines for the tests which are missing expected results · 5c1a8758
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98576
      
      Unreviewed EFL gardening.
      
      Add platform-specific baselines after r130443 and r130489.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
      * platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
      * platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c1a8758
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of the WK2 Debug Bot failing tests · a40f55f9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98575
      
      Unreviewed EFL gardening.
      
      Skip failing tests in order to make the bots green.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl-wk2/TestExpectations:
      * platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Removed. Current results
      matches the base expectations on WK2.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a40f55f9
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · b187b3a5
      zandobersek@gmail.com authored
      Adding reftest failure expectations for a couple of tests that
      were introduced in r130557 and r130570.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b187b3a5
    • tkent@chromium.org's avatar
      [Chromium] Rebaseline for recent INPUT_MULTIPLE_FIELDS_UI changes · 7db49554
      tkent@chromium.org authored
      * platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
      * platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
      * platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7db49554
  3. 05 Oct, 2012 26 commits
    • wangxianzhu@chromium.org's avatar
      OpenTypeVerticalData issue with DroidSansFallback.ttf on chromium-android and chromium-linux · 61985f74
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97824
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      The issue occurred when a font that contains vert GSUB table but doesn't have
      a DFLT script and the first script doesn't have vert feature. Added logic to
      handle the case.
      
      Test: fast/writing-mode/vertical-subst-font-vert-no-dflt.html
      
      * platform/graphics/opentype/OpenTypeVerticalData.cpp:
      (FeatureList):
      (WebCore::OpenType::FeatureList::findFeature): Added to find the matching feature in FeatureList.
      (WebCore::OpenType::GSUBTable::feature): Added logic to handle the case of no DFLT script and no vert feature under the first script.
      
      LayoutTests:
      
      Ref test for the change. The punctuations in the vertical text are expected to
      be substituted with the corresponding vertical forms.
      
      * fast/writing-mode/vertical-subst-font-vert-no-dflt-expected.html: Added.
      * fast/writing-mode/vertical-subst-font-vert-no-dflt.html: Added.
      * platform/mac/TestExpectations: Added the new test as it fails on Mac because of https://bugs.webkit.org/show_bug.cgi?id=98560.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61985f74
    • tony@chromium.org's avatar
      Form controls should always be horizontal · c3459ef9
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98563
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Fix a regression where we didn't force form controls to be horizontal.
      
      Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
             fast/dom/HTMLProgressElement/progress-writing-mode.html
             fast/table/colspanMinWidth-vertical.html
      
      * css/html.css:
      (input, textarea, keygen, select, button, isindex, meter, progress):
      
      LayoutTests:
      
      Convert fast/dom/HTMLMeterElement/meter-writing-mode.html and
      fast/dom/HTMLProgressElement/progress-writing-mode.html to be ref tests.
      Also rebaseline fast/table/colspanMinWidth-vertical.html and mark the
      test as needing a rebaseline on platforms other than Chromium Linux.
      
      * fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: Added.
      * fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.html: Added.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * platform/efl/TestExpectations:
      * platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/mac/TestExpectations:
      * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/qt/TestExpectations:
      * platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3459ef9
    • commit-queue@webkit.org's avatar
      [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads · fd0d0fe7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98524
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-05
      Reviewed by Alexey Proskuryakov.
      
      Source/WebKit2:
      
      Add implementation for testRunner.setSerializeHTTPLoads in
      WebKitTestRunner.
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetSerialLoadingEnabled):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setSerialLoadingEnabled):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Add implementation for testRunner.setSerializeHTTPLoads in
      WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setSerializeHTTPLoads):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskip tests that are now passing.
      
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd0d0fe7
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r130556 and r130564. · f583bb1a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/130556
      http://trac.webkit.org/changeset/130564
      https://bugs.webkit.org/show_bug.cgi?id=98572
      
      The patch wasn't reviewed by a reviewer and it is breaking
      Chromium Windows (Requested by jchaffraix on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-05
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * css/mediaControls.css:
      (video::-webkit-media-text-track-container):
      (video::-webkit-media-text-track-past-nodes):
      (video::-webkit-media-text-track-future-nodes):
      (video::-webkit-media-text-track-display):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::userIsInterestedInThisLanguage):
      (WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind):
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
      (WebCore::HTMLMediaElement::updateClosedCaptionsControls):
      * html/HTMLMediaElement.h:
      (HTMLMediaElement):
      * html/shadow/MediaControlElements.cpp:
      (WebCore):
      (WebCore::MediaControlTextTrackContainerElement::updateSizes):
      * html/shadow/MediaControlElements.h:
      (MediaControlTextTrackContainerElement):
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::updateTextTrackDisplay):
      * html/shadow/MediaControlRootElement.h:
      (MediaControlRootElement):
      * html/shadow/MediaControls.h:
      (MediaControls):
      * html/track/TextTrack.cpp:
      (WebCore::TextTrack::TextTrack):
      (WebCore::TextTrack::isValidKindKeyword):
      (WebCore::TextTrack::setKind):
      (WebCore::TextTrack::setMode):
      (WebCore::TextTrack::mode):
      * html/track/TextTrack.h:
      (WebCore::TextTrack::create):
      (WebCore::TextTrack::kind):
      (TextTrack):
      (WebCore::TextTrack::label):
      (WebCore::TextTrack::setLabel):
      (WebCore::TextTrack::language):
      (WebCore::TextTrack::setLanguage):
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::TextTrackCueBox):
      (WebCore::TextTrackCueBox::shadowPseudoId):
      (WebCore):
      (WebCore::TextTrackCue::updateDisplayTree):
      * html/track/TextTrackCue.h:
      (TextTrackCueBox):
      (TextTrackCue):
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * rendering/CaptionPreferencesChangedListener.h: Removed.
      * rendering/RenderTheme.h:
      (WebCore):
      (RenderTheme):
      * rendering/RenderThemeMac.h:
      (RenderThemeMac):
      * rendering/RenderThemeMac.mm:
      (WebCore):
      (WebCore::RenderThemeMac::RenderThemeMac):
      (WebCore::RenderThemeMac::~RenderThemeMac):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      WebKitLibraries:
      
      * WebKitSystemInterface.h:
      
      LayoutTests:
      
      * media/track/track-cue-rendering-expected.txt:
      * media/track/track-cue-rendering.html:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f583bb1a
    • jchaffraix@webkit.org's avatar
      Unreviewed Chromium gardening. · c8c0f2d8
      jchaffraix@webkit.org authored
      * platform/chromium/TestExpectations:
      Updated a wrong bug info and rebaselined 2 tests:
      fast/reflections/inline-crash.html and fast/backgrounds/solid-color-context-restore.html
      
      * fast/backgrounds/solid-color-context-restore-expected.txt: Added.
      * fast/reflections/inline-crash-expected.txt: Added.
      * platform/chromium-linux/fast/backgrounds/solid-color-context-restore-expected.png: Added.
      * platform/chromium-linux/fast/reflections/inline-crash-expected.png: Added.
      * platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.png: Added.
      * platform/chromium-win/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
      * platform/chromium-win/fast/reflections/inline-crash-expected.png: Added.
      * platform/chromium-win/fast/reflections/inline-crash-expected.txt: Added.
      * platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
      * platform/efl/fast/reflections/inline-crash-expected.txt: Removed.
      * platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Removed.
      * platform/gtk/fast/reflections/inline-crash-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c0f2d8
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] Add shape-inside tests for rounded rectangles · 6fff8b1c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96669
      
      Patch by Bear Travis <betravis@adobe.com> on 2012-10-05
      Reviewed by Levi Weintraub.
      
      Adding multiple rounded rectangle tests. The more complex tests use float "sandbags"
      to simulate the shape-inside area in the test expectations.
      (See http://www.alistapart.com/articles/sandbags/)
      In general, each line has its own pair of left and right floats (both lineHeight tall),
      to position the text and appropriately limit its width. In the simple, 0 corner radius
      cases, these floats can be merged because they all have the same width on the left and
      right.
      
      * fast/exclusions/resources/rounded-rectangle.js: Contains functionality for generating
      a shape-inside, simulating one, and generating content that should roughly fill the
      shape-inside.
      (xFromEllipseCenter): The x distance from the center of an ellipse, based on its y
      distance from center.
      (xInset): The inset of a rounded rectangle from its bounding box.
      (generateString): Generate a string that roughly fills a shape-inside's content area.
      (simulateShape): Create floats to simulate a shape-inside area.
      (simulateShapeOutline): Create an outline for the rounded rectangle shape-inside.
      (generateSimulatedShapeElement): Simulate a shape-inside and appropriately fill it
      with content.
      (generateShapeElement): Create a shape-inside and fill it with content.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001-expected.html:
      Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle-expected.html.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-001.html:
      Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-rounded-rectangle.html.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-002.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fff8b1c
    • jer.noble@apple.com's avatar
      Allow ports to override text track rendering style · 0846d8de
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97800
      <rdar://problem/12044964>
      
      Patch by Eric Carlson <eric.carlson@apple.com> on 2012-10-04
      Reviewed by Silvia Pfeiffer.
      
      Source/WebCore:
      
      * WebCore.exp.in: Export new WebkitSystemInterface functions.
      * WebCore.xcodeproj/project.pbxproj: Add CaptionPreferencesChangedListener.h.
      
      * css/mediaControls.css: Rearrange the caption CSS so it is possible to style the cue window,
          background, and text independently.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_disableCaptions with theme->userPrefersCaptions().
      (WebCore::HTMLMediaElement::attach): Register for caption preferences change callbacks.
      (WebCore::HTMLMediaElement::detach): Unregister for caption preferences change callbacks.
      (WebCore::HTMLMediaElement::userPrefersCaptions): Return theme->userPrefersCaptions().
      (WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Consider userPrefersCaptions().
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Move the code that marks all tracks as
          un-configured to markCaptionAndSubtitleTracksAsUnconfigured so it can be reused.
      (WebCore::HTMLMediaElement::captionPreferencesChanged): New, force a reevaluation of all text tracks.
      (WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): New, code moved from
          setClosedCaptionsVisible
      * html/HTMLMediaElement.h: Inherit from CaptionPreferencesChangedListener.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::userCaptionPreferencesChanged): New, if theme
          has a captions style sheet override, inject it into the current page group, otherwise
          remove injected sheet.
      (WebCore::MediaControlTextTrackContainerElement::updateSizes): Get rid of unnecessary member
          variable. Get caption font scale from theme instead of hard coding.
      * html/shadow/MediaControlElements.h:
      
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::userCaptionPreferencesChanged): New.
      (WebCore::MediaControlRootElement::updateTextTrackDisplay):
      * html/shadow/MediaControlRootElement.h: Add userCaptionPreferencesChanged, minor cleanup.
      
      * html/shadow/MediaControls.h:
      (WebCore::MediaControls::userCaptionPreferencesChanged): New.
      
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::TextTrackCueBox): Set the shadow pseudo id.
      (WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId): New, class method to return the
          shadow pseudo id so it can be used elsewhere.
      (WebCore::TextTrackCueBox::shadowPseudoId): Call textTrackCueBoxShadowPseudoId.
      (WebCore::TextTrackCue::pastNodesShadowPseudoId): New, class method to return the
          shadow pseudo id so it can be used elsewhere.
      (WebCore::TextTrackCue::futureNodesShadowPseudoId): Ditto.
      (WebCore::TextTrackCue::updateDisplayTree):
      * html/track/TextTrackCue.h:
      
      * platform/mac/WebCoreSystemInterface.h: Updated.
      * platform/mac/WebCoreSystemInterface.mm: Ditto.
      
      * rendering/CaptionPreferencesChangedListener.h: Added.
      
      * rendering/RenderTheme.h:
      (WebCore::RenderTheme::userPrefersCaptions): New, default do-nothing implementation.
      (WebCore::RenderTheme::userHasCaptionPreferences): Ditto.
      (WebCore::RenderTheme::captionFontSizeScale): Ditto.
      (WebCore::RenderTheme::captionsStyleSheetOverride): Ditto.
      (WebCore::RenderTheme::registerForCaptionPreferencesChangedCallbacks): Ditto.
      (WebCore::RenderTheme::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
      
      * rendering/RenderThemeMac.h:
      * rendering/RenderThemeMac.mm:
      (WebCore::userCaptionPreferencesChangedNotificationCallback): New, receives preference changed notifications.
      (WebCore::RenderThemeMac::RenderThemeMac): Initialize m_listeningForCaptionPreferenceNotifications.
      (WebCore::RenderThemeMac::~RenderThemeMac): Unregister for notifications if necessary.
      (WebCore::RenderThemeMac::userHasCaptionPreferences): New, passthrough to WKSI function.
      (WebCore::RenderThemeMac::userPrefersCaptions): Ditto.
      (WebCore::RenderThemeMac::captionsWindowColor): Return Color with user's caption window color preference.
      (WebCore::RenderThemeMac::captionsBackgroundColor): Return Color with user's caption
          background color preference.
      (WebCore::RenderThemeMac::captionsTextColor): Return Color with user's caption text color preference.
      (WebCore::RenderThemeMac::captionsEdgeColorForTextColor): Return Color for text edge effect.
      (WebCore::RenderThemeMac::cssPropertyWithTextEdgeColor): Return String with CSS to set a text-shadow
          or webkit-text-stroke property.
      (WebCore::RenderThemeMac::cssColorProperty): Return a String with css to set a property
          with a color value.
      (WebCore::RenderThemeMac::captionsTextEdgeStyle): Return a String with css to style caption
          text with the user's preferred text edge stye.
      (WebCore::RenderThemeMac::captionsDefaultFont): Return a String with css to style caption
          text with the user's preferred font.
      (WebCore::RenderThemeMac::captionsStyleSheetOverride): Return a String with css to style captions
          with the user's preferred style.
      (WebCore::RenderThemeMac::captionFontSizeScale): Return the user's preferred caption font scale.
      (WebCore::RenderThemeMac::captionPreferencesChanged): Notify listeners of caption preference change.
      (WebCore::RenderThemeMac::registerForCaptionPreferencesChangedCallbacks): Add a caption preferences
          changes listener.
      (WebCore::RenderThemeMac::unregisterForCaptionPreferencesChangedCallbacks): Remove a caption preferences
          changes listener.
      
      Source/WebKit/mac:
      
      Add WCSI support for new WKSI caption functions.
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Initialize new WKSI function pointers.
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Initialize new WKSI function pointers.
      
      WebKitLibraries:
      
      Update WKSI header with SPI for getting the user caption appearance preferences.
      
      * WebKitSystemInterface.h:
      
      LayoutTests:
      
      * media/track/track-cue-rendering-expected.txt: Update results for caption css changes.
      * media/track/track-cue-rendering.html:
      * platform/chromium/TestExpectations: Skip tests that need to be rebaselined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0846d8de
    • commit-queue@webkit.org's avatar
      Inline continuations create :after generated content on style recalcs · cc0f04f3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93170
      
      Patch by Takashi Sakamoto <tasak@google.com> on 2012-10-05
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      The bug is caused by RenderInline::styleDidChange's setContinuation(0).
      RenderObjectChildList uses continuation to know whether the given
      renderer should have AFTER render object or not.
      However, setContinuation(0) makes RenderObjectChildList to
      misunderstand that all continuations are last continuation.
      To avoid the misunderstanding, added a new flag to class
      RenderObejctChildList to enable/disable updating :after content (and
      also :before content).
      
      Tests: fast/css-generated-content/after-with-inline-continuation.html
             fast/css-generated-content/dynamic-apply-after-for-inline.html
      
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      Disable upating :after content for continuations which are not
      the last one during setStyle just after setContinuation(0).
      The setStyle invokes RenderInline::styleDidChange and also invokes
      updateBeforeAfterContent via the styleDidChange. This means,
      the last continuation's updateBeforeAfterContent is also invoked
      after setContinuation(0). We have to update :after for the last
      continuation.
      * rendering/RenderObjectChildList.cpp:
      (WebCore):
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      If s_updateBeforeAfterContent is false, quickly exit
      updateBeforeAfterContent.
      * rendering/RenderObjectChildList.h:
      (RenderObjectChildList):
      Added a new flag s_enableUpdateBeforeAfterContent to enable/disable
      updating :before or :after content.
      
      LayoutTests:
      
      * fast/css-generated-content/after-with-inline-continuation-expected.html: Added.
      * fast/css-generated-content/after-with-inline-continuation.html: Added.
      * fast/css-generated-content/dynamic-apply-after-for-inline-expected.html: Added.
      * fast/css-generated-content/dynamic-apply-after-for-inline.html: Added.
      * http/tests/misc/acid3-expected.txt:
      The acid3-expected.txt has the duplicate RenderBlock (positioned).
      Two 'layer at(638, 18) size 20x20, ... text run at (0,0) width 20: "X"'
      exist. So did reset-results for acid3-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc0f04f3
    • tony@chromium.org's avatar
      Fix margin box ascent computation in flexbox · e9f6357d
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98540
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      The margin box ascent doesn't depend on the margin below the box.
      
      Tests: css3/flexbox/flex-align.html: Fixed a test case and removed a FIXME.
             css3/flexbox/flex-align-vertical-writing-mode.html: Similar test case.
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::marginBoxAscentForChild):
      
      LayoutTests:
      
      Remove a FIXME and update the results.
      
      * css3/flexbox/flex-align-vertical-writing-mode.html:
      * css3/flexbox/flex-align.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9f6357d
    • wjmaclean@chromium.org's avatar
      [chromium] Enhance support for transforms in LinkHighlight. · f28e98cd
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94355
      
      Reviewed by Adrienne Walker.
      
      Improved handling of transformed highlight targets, where the transform goes beyond simple translation.
      
      Source/WebKit/chromium:
      
      * src/LinkHighlight.cpp:
      (WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
      (WebKit):
      (WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
      (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::bestTouchLinkNode):
      
      LayoutTests:
      
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Removed.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Removed.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f28e98cd
    • ojan@chromium.org's avatar
      Deprecated flexboxes subtract scrollbar width/height twice · 7e7af586
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98552
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      This is a regression from http://trac.webkit.org/changeset/119507.
      The problem is that contentHeight subtracts the scrollbar and
      RenderDeprecatedFlexbox subtracts the scrollbar.
      
      -Make it so that we only access override sizes if one has been set.
      I think this makes the calling code more clear.
      -If we don't have one set, grab the height/width - borderAndPadding.
      -Add a FIXME to change this all back to being borderbox sizes.
      There's something trick with making table padding/border work right for that
      though (noted in the original patch).
      
      Test: fast/flexbox/flexing-overflow-scroll-item.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::overrideLogicalContentWidth):
      (WebCore::RenderBox::overrideLogicalContentHeight):
      (WebCore::RenderBox::availableLogicalHeightUsing):
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::contentWidthForChild):
      (WebCore):
      (WebCore::contentHeightForChild):
      (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
      (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
      (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
      
      LayoutTests:
      
      * fast/flexbox/flexing-overflow-scroll-item-expected.txt: Added.
      * fast/flexbox/flexing-overflow-scroll-item.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e7af586
    • rniwa@webkit.org's avatar
      GTK+ and Qt rebaselines after r130532. · c09a745e
      rniwa@webkit.org authored
      * platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/chromium/svg/custom/delete-text-crash-expected.txt: Removed.
      * platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Removed.
      * platform/gtk/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/gtk/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/merge-end-blockquote-expected.txt:
      * platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Removed.
      * platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/qt/editing/pasteboard/interchange-newline-1-expected.txt: Removed.
      * platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
      * platform/qt/editing/pasteboard/paste-text-002-expected.txt: Removed.
      * platform/qt/editing/pasteboard/paste-text-003-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c09a745e
    • rniwa@webkit.org's avatar
      Chromium and Mac rebaselines after r130532. · c095a2a8
      rniwa@webkit.org authored
      * platform/chromium-linux-x86/editing/pasteboard/interchange-newline-1-expected.txt: Added.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-002-expected.txt: Added.
      * platform/chromium-linux-x86/editing/pasteboard/paste-text-003-expected.txt: Added.
      * platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.txt: Added.
      * platform/chromium-linux/editing/pasteboard/paste-text-002-expected.txt: Added.
      * platform/chromium-linux/editing/pasteboard/paste-text-003-expected.txt: Added.
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-002-expected.txt:
      * platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-003-expected.txt:
      * platform/chromium-win-xp/editing/pasteboard/interchange-newline-1-expected.txt: Added.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-002-expected.txt: Added.
      * platform/chromium-win-xp/editing/pasteboard/paste-text-003-expected.txt: Added.
      * platform/chromium-win/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
      * platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.txt:
      * platform/chromium-win/editing/pasteboard/paste-text-002-expected.txt:
      * platform/chromium-win/editing/pasteboard/paste-text-003-expected.txt:
      * platform/chromium/svg/custom/delete-text-crash-expected.txt: Added.
      * platform/chromium/svg/custom/delete-text-innerText-crash-expected.txt: Added.
      * svg/custom/delete-text-crash-expected.txt:
      * svg/custom/delete-text-innerText-crash-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c095a2a8
    • zandobersek@gmail.com's avatar
      [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder · d0f866c2
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=91009
      
      Reviewed by Martin Robinson.
      
      Tools: 
      
      Include libxml2 into the jhbuild module. Version 2.8.0 introduces
      a more correct (but not completely correct) behavior in the
      fast/xsl/xslt-missing-namespace-in-xslt.html test.
      
      * gtk/jhbuild.modules:
      
      LayoutTests: 
      
      Update the test's baselines. The output now properly shows the error.
      
      * platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
      * platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0f866c2
    • dpranke@chromium.org's avatar
      Fix lint error in TestExpectations from previous change. · 6455b472
      dpranke@chromium.org authored
      Unreviewed.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6455b472
    • dpranke@chromium.org's avatar
      [chromium] tests failing after r130443. · 0405bf3f
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98545
      
      Unreviewed, expectations change.
      
       [chromium] fast/text/international/text-spliced-font.html and
       fast/writing-mode/Kusa-Makura-background-canvas.html are failing on
       the Mac after r130443 and we're not quite sure why ...
      
      * platform/chromium-linux/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-mac/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      * platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/chromium-win/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0405bf3f
    • wjmaclean@chromium.org's avatar
      [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and... · eb4ecaa5
      wjmaclean@chromium.org authored
      [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
      https://bugs.webkit.org/show_bug.cgi?id=97355
      
      Reviewed by Adrienne Walker.
      
      This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
      interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.
      
      Source/WebKit/chromium:
      
      * src/LinkHighlight.cpp:
      (WebKit::LinkHighlight::LinkHighlight):
      (WebKit::LinkHighlight::startHighlightAnimationIfNeeded):
      * src/LinkHighlight.h:
      (LinkHighlight):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::handleGestureEvent):
      (WebKit::WebViewImpl::enableTouchHighlight):
      
      LayoutTests:
      
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: removed extra testRunner.display().
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2.html: Added.
      * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.txt: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.png: Added.
      * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb4ecaa5
    • jer.noble@apple.com's avatar
      REGRESSION (r129478-r129480):... · 8d8360da
      jer.noble@apple.com authored
      REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
      https://bugs.webkit.org/show_bug.cgi?id=98527
      
      Unreviewed gardening after r129479.
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d8360da
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 9062e6b5
      zandobersek@gmail.com authored
      Removing failure expectation for fast/text/vertical-rl-rtl-linebreak.html
      since the test only needed platform-specific baselines (which were added
      in r130524).
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9062e6b5
    • ojan@chromium.org's avatar
      Have perf test assert worst order of magnitude · cb1e5cf2
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98535
      
      Reviewed by Tony Chang.
      
      Really we only care if tests get order of magnitude slower.
      Assert that tests are at least a certain magnitude.
      Hopefully this will reduce flakiness some.
      
      * resources/magnitude-perf.js:
      (Magnitude._run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb1e5cf2
    • rniwa@webkit.org's avatar
      Deleting across multiple paragraphs can change the style of surrounding text · 69e647cc
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97266
      
      Reviewed by Levi Weintraub.
      
      Source/WebCore: 
      
      Preserve editing styles from CSS rules in wrappingStyleForSerialization as well as inline styles
      even when we're not annotating. We don't want to preserve all styles because it's against
      the user expectation to keep borders, etc... when merging paragraphs. We also don't want to copy
      styles from a mail blockquote because that's not a style the user has applied. See the comment
      in EditingStyle::wrappingStyleForSerialization.
      
      Test: editing/deleting/merge-paragraph-with-style-from-rule.html
      
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
      (WebCore::EditingStyle::wrappingStyleForSerialization):
      
      LayoutTests: 
      
      Added a regression test and rebaselined tests.
      
      * editing/deleting/delete-before-block-image-2-expected.txt:
      * editing/deleting/merge-paragraph-from-p-with-style-expected.txt:
      * editing/deleting/merge-paragraph-from-p-with-style.html: We changed the behavior. The editing style of p
      is now preserved when merging paragraphs.
      * editing/deleting/merge-paragraph-with-style-from-rule-expected.txt: Added.
      * editing/deleting/merge-paragraph-with-style-from-rule.html: Added.
      * platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
      * platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e647cc
    • jchaffraix@webkit.org's avatar
      Unreviewed rebaseline after r130355. · 68191863
      jchaffraix@webkit.org authored
      r130447 forgot to update the Snow Leopard pixel baselines. The only differences are due to a different font used.
      
      * platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-fixed-position-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68191863
    • ojan@chromium.org's avatar
      Add expected result accidentally left out of http://trac.webkit.org/changeset/130337. · c92b3655
      ojan@chromium.org authored
      * perf/adding-radio-buttons-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c92b3655
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · ea5f0fcd
      zandobersek@gmail.com authored
      Adding platform-specific baselines after r130443 and r130489.
      
      * platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
      * platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
      * platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea5f0fcd
    • commit-queue@webkit.org's avatar
      [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner · 1974686b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98256
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Implement UIClient's focus callbacks for the main page in
      WebKitTestRunner.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::focus):
      (WTR::TestController::initialize):
      
      LayoutTests:
      
      Unskip fast/dom/Window/mozilla-focus-blur.html now that
      WebKitTestRunner implements UIClient's focus callbacks.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1974686b
    • rniwa@webkit.org's avatar
      Remove wrong expectations added in r130452. · 6ab367f3
      rniwa@webkit.org authored
      * platform/chromium-win-xp/editing/pasteboard/5006779-expected.png: Removed.
      * platform/chromium-win-xp/editing/pasteboard/5006779-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab367f3