1. 13 Oct, 2011 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r97362. · 33998592
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/97362
      https://bugs.webkit.org/show_bug.cgi?id=70039
      
      Relies on V8 APIs that have been reverted upstream. (Requested
      by dglazkov on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-13
      
      Source/WebCore:
      
      * English.lproj/localizedStrings.js:
      * bindings/js/ScriptProfiler.cpp:
      * bindings/js/ScriptProfiler.h:
      * bindings/v8/ScriptProfiler.cpp:
      * bindings/v8/ScriptProfiler.h:
      * inspector/Inspector.json:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::create):
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      * inspector/InspectorProfilerAgent.h:
      * inspector/front-end/DetailedHeapshotGridNodes.js:
      (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
      (WebInspector.HeapSnapshotGenericObjectNode):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
      * inspector/front-end/DetailedHeapshotView.js:
      (WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):
      * inspector/front-end/HeapSnapshot.js:
      (WebInspector.HeapSnapshot.prototype._init):
      (WebInspector.HeapSnapshot.prototype.dispose):
      (WebInspector.HeapSnapshot.prototype.updateStaticData):
      (WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
      * inspector/front-end/HeapSnapshotProxy.js:
      * inspector/front-end/RemoteObject.js:
      * inspector/front-end/heapProfiler.css:
      
      LayoutTests:
      
      * inspector/profiler/heap-snapshot-expected.txt:
      * inspector/profiler/heap-snapshot-test.js:
      (initialize_HeapSnapshotTest):
      * inspector/profiler/heap-snapshot.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33998592
    • mnaganov@chromium.org's avatar
      Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile. · 32d0638d
      mnaganov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=61179
      
      This is exteremely helpful when dealing with DOM wrappers, as
      their properties are mostly implemented with getters and thus not
      stored in heap snapshots.
      
      Reviewed by Pavel Feldman.
      
      * English.lproj/localizedStrings.js:
      * bindings/js/ScriptProfiler.cpp:
      (WebCore::ScriptProfiler::objectByHeapObjectId):
      * bindings/js/ScriptProfiler.h:
      * bindings/v8/ScriptProfiler.cpp:
      (WebCore::ScriptProfiler::objectByHeapObjectId):
      * bindings/v8/ScriptProfiler.h:
      * inspector/Inspector.json:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::InspectorController):
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::create):
      (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
      (WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
      * inspector/InspectorProfilerAgent.h:
      * inspector/front-end/DetailedHeapshotGridNodes.js:
      (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
      (WebInspector.HeapSnapshotGenericObjectNode):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
      * inspector/front-end/DetailedHeapshotView.js:
      (WebInspector.DetailedHeapshotView.prototype._showObjectPopover):
      * inspector/front-end/HeapSnapshot.js:
      (WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
      (WebInspector.HeapSnapshotNode.prototype.get flags):
      (WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
      (WebInspector.HeapSnapshot.prototype._init):
      (WebInspector.HeapSnapshot.prototype.dispose):
      (WebInspector.HeapSnapshot.prototype._flagsOfNode):
      (WebInspector.HeapSnapshot.prototype._calculateFlags):
      (WebInspector.HeapSnapshot.prototype.updateStaticData):
      (WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
      * inspector/front-end/HeapSnapshotProxy.js:
      (WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):
      * inspector/front-end/RemoteObject.js:
      (WebInspector.RemoteObject.fromError):
      * inspector/front-end/heapProfiler.css:
      (.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):
      
      * inspector/profiler/heap-snapshot-expected.txt:
      * inspector/profiler/heap-snapshot-test.js:
      (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
      (initialize_HeapSnapshotTest):
      * inspector/profiler/heap-snapshot.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32d0638d
  2. 21 Jun, 2011 1 commit
    • mnaganov@chromium.org's avatar
      2011-06-21 Mikhail Naganov <mnaganov@chromium.org> · aa5ba81b
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
              https://bugs.webkit.org/show_bug.cgi?id=63049
      
              * inspector/profiler/detailed-heapshots-test.js:
      
      2011-06-21  Mikhail Naganov  <mnaganov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Remove old (aggregating) heap profiler.
              https://bugs.webkit.org/show_bug.cgi?id=63049
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::takeHeapSnapshot):
              * inspector/Inspector.json:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.DetailedHeapshotView.prototype.get profile):
              (WebInspector.DetailedHeapshotView.prototype.get baseProfile):
              (WebInspector.DetailedHeapshotView.prototype._profiles):
              (WebInspector.DetailedHeapshotProfileType):
              (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
              * inspector/front-end/HeapSnapshotView.js: Removed.
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot):
              (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
              (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.parsed):
              (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
              (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
              (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
              (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/heapProfiler.css:
              * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa5ba81b
  3. 20 May, 2011 1 commit
    • mnaganov@chromium.org's avatar
      2011-05-20 Mikhail Naganov <mnaganov@chromium.org> · 4cf1ba6d
      mnaganov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Chromium] Use bottom-up CPU profile tree built in VM,
              instead of building it on Inspector's side.
              https://bugs.webkit.org/show_bug.cgi?id=61185
      
              * bindings/js/ScriptProfile.cpp:
              (WebCore::ScriptProfile::bottomUpHead):
              (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
              * bindings/js/ScriptProfile.h:
              * bindings/v8/ScriptProfile.cpp:
              (WebCore::ScriptProfile::bottomUpHead):
              (WebCore::ScriptProfile::buildInspectorObjectForBottomUpHead):
              * bindings/v8/ScriptProfile.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::getProfile):
              * inspector/front-end/ProfileView.js:
              (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cf1ba6d
  4. 20 Apr, 2011 1 commit
    • mihaip@chromium.org's avatar
      2011-04-19 Mihai Parparita <mihaip@chromium.org> · a941ec7f
      mihaip@chromium.org authored
              Reviewed by Adam Barth.
      
              ScriptController.h is included in too many places
              https://bugs.webkit.org/show_bug.cgi?id=58963
      
              Remove ScriptController.h #includes from a bunch of .cpp files where it
              doesn't appear to be necessary.
      
              * bindings/js/JSCustomPositionCallback.cpp:
              * bindings/js/JSCustomPositionErrorCallback.cpp:
              * bindings/js/JSCustomVoidCallback.cpp:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowShell.cpp:
              * bindings/js/JSDocumentCustom.cpp:
              * bindings/js/ScriptDebugServer.cpp:
              * bindings/v8/NPV8Object.cpp:
              * bindings/v8/ScriptCachedFrameData.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/V8DOMWrapper.cpp:
              * bindings/v8/V8IsolatedContext.cpp:
              * bindings/v8/V8Proxy.cpp:
              * bindings/v8/custom/V8LocationCustom.cpp:
              * dom/Node.cpp:
              * dom/ScriptElement.cpp:
              * dom/XMLDocumentParser.cpp:
              * dom/XMLDocumentParserQt.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLTreeBuilder.cpp:
              * inspector/InspectorProfilerAgent.cpp:
              * loader/icon/IconDatabase.cpp:
              * page/Chrome.cpp:
              * page/Navigator.cpp:
              * page/Page.cpp:
              * plugins/PluginView.cpp:
              * plugins/gtk/PluginViewGtk.cpp:
              * plugins/qt/PluginViewQt.cpp:
              * plugins/symbian/PluginViewSymbian.cpp:
              * plugins/win/PluginViewWin.cpp:
              * svg/SVGDocumentExtensions.cpp:
              * xml/XMLTreeViewer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a941ec7f
  5. 30 Mar, 2011 4 commits
    • yurys@chromium.org's avatar
      2011-03-30 Yury Semikhatsky <yurys@chromium.org> · 7f1e51ae
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: split debugger agent into Page and Worker-specific ones
              https://bugs.webkit.org/show_bug.cgi?id=57345
      
              ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
              for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
              and Page/WorkerDebuggerAgent.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * UseJSC.cmake:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::currentCallFrame):
              * bindings/js/PageScriptDebugServer.cpp: Added.
              (WebCore::toPage):
              (WebCore::PageScriptDebugServer::shared):
              (WebCore::PageScriptDebugServer::PageScriptDebugServer):
              (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
              (WebCore::PageScriptDebugServer::addListener):
              (WebCore::PageScriptDebugServer::removeListener):
              (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
              (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
              (WebCore::PageScriptDebugServer::didPause):
              (WebCore::PageScriptDebugServer::didContinue):
              (WebCore::PageScriptDebugServer::didRemoveLastListener):
              (WebCore::PageScriptDebugServer::setJavaScriptPaused):
              * bindings/js/PageScriptDebugServer.h: Added.
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::sourceParsed):
              (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
              (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::pauseIfNeeded):
              * bindings/js/ScriptDebugServer.h:
              * bindings/js/WorkerScriptDebugServer.cpp: Added.
              (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::addListener):
              (WebCore::WorkerScriptDebugServer::removeListener):
              * bindings/js/WorkerScriptDebugServer.h: Added.
              (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
              (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
              (WebCore::WorkerScriptDebugServer::didPause):
              (WebCore::WorkerScriptDebugServer::didContinue):
              * bindings/v8/PageScriptDebugServer.cpp: Added.
              (WebCore::retrieveFrame):
              (WebCore::PageScriptDebugServer::shared):
              (WebCore::PageScriptDebugServer::PageScriptDebugServer):
              (WebCore::PageScriptDebugServer::addListener):
              (WebCore::PageScriptDebugServer::removeListener):
              (WebCore::PageScriptDebugServer::setClientMessageLoop):
              (WebCore::PageScriptDebugServer::getDebugListenerForContext):
              (WebCore::PageScriptDebugServer::runMessageLoopOnPause):
              (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
              * bindings/v8/PageScriptDebugServer.h: Added.
              (WebCore::PageScriptDebugServer::setEnabled):
              (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
              (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::setPauseOnNextStatement):
              (WebCore::ScriptDebugServer::breakProgram):
              (WebCore::ScriptDebugServer::continueProgram):
              (WebCore::ScriptDebugServer::stepIntoStatement):
              (WebCore::ScriptDebugServer::stepOverStatement):
              (WebCore::ScriptDebugServer::stepOutOfFunction):
              (WebCore::ScriptDebugServer::editScriptSource):
              (WebCore::toScriptDebugServer):
              (WebCore::ScriptDebugServer::breakProgramCallback):
              (WebCore::ScriptDebugServer::v8DebugEventCallback):
              (WebCore::ScriptDebugServer::handleV8DebugEvent):
              (WebCore::ScriptDebugServer::isPaused):
              * bindings/v8/ScriptDebugServer.h:
              * bindings/v8/WorkerScriptDebugServer.cpp: Added.
              (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::addListener):
              (WebCore::WorkerScriptDebugServer::removeListener):
              * bindings/v8/WorkerScriptDebugServer.h: Added.
              (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
              (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
              (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::init):
              (WebCore::InjectedScriptHost::debuggerAgent):
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::enable):
              (WebCore::InspectorDebuggerAgent::disable):
              (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
              (WebCore::InspectorDebuggerAgent::removeBreakpoint):
              (WebCore::InspectorDebuggerAgent::continueToLocation):
              (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
              (WebCore::InspectorDebuggerAgent::editScriptSource):
              (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
              (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
              (WebCore::InspectorDebuggerAgent::resume):
              (WebCore::InspectorDebuggerAgent::stepOver):
              (WebCore::InspectorDebuggerAgent::stepInto):
              (WebCore::InspectorDebuggerAgent::stepOut):
              (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
              (WebCore::InspectorDebuggerAgent::didPause):
              (WebCore::InspectorDebuggerAgent::breakProgram):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::disable):
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/PageDebuggerAgent.cpp: Added.
              (WebCore::PageDebuggerAgent::create):
              (WebCore::PageDebuggerAgent::PageDebuggerAgent):
              (WebCore::PageDebuggerAgent::~PageDebuggerAgent):
              (WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
              (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
              (WebCore::PageDebuggerAgent::scriptDebugServer):
              * inspector/PageDebuggerAgent.h: Added.
              * inspector/WorkerDebuggerAgent.cpp: Added.
              (WebCore::WorkerDebuggerAgent::create):
              (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
              (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
              (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
              (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
              (WebCore::WorkerDebuggerAgent::scriptDebugServer):
              * inspector/WorkerDebuggerAgent.h: Added.
      2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: split debugger agent into Page and Worker-specific ones
              https://bugs.webkit.org/show_bug.cgi?id=57345
      
              ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
              for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
              and Page/WorkerDebuggerAgent.
      
              * src/DebuggerAgentManager.cpp:
              (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgent::interruptAndDispatch):
              (WebKit::WebDevToolsAgent::processPendingMessages):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f1e51ae
    • yurys@chromium.org's avatar
      2011-03-30 Yury Semikhatsky <yurys@chromium.org> · f579d84d
      yurys@chromium.org authored
              Unreviewed. Rollout r82438 and r82436.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * UseJSC.cmake:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::currentCallFrame):
              * bindings/js/PageScriptDebugServer.cpp: Removed.
              * bindings/js/PageScriptDebugServer.h: Removed.
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::shared):
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::addListener):
              (WebCore::ScriptDebugServer::removeListener):
              (WebCore::ScriptDebugServer::hasListenersInterestedInPage):
              (WebCore::toPage):
              (WebCore::ScriptDebugServer::sourceParsed):
              (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
              (WebCore::ScriptDebugServer::setJavaScriptPaused):
              (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::pauseIfNeeded):
              (WebCore::ScriptDebugServer::recompileAllJSFunctions):
              (WebCore::ScriptDebugServer::didAddListener):
              (WebCore::ScriptDebugServer::didRemoveListener):
              * bindings/js/ScriptDebugServer.h:
              * bindings/js/WorkerScriptDebugServer.cpp: Removed.
              * bindings/js/WorkerScriptDebugServer.h: Removed.
              * bindings/v8/PageScriptDebugServer.cpp: Removed.
              * bindings/v8/PageScriptDebugServer.h: Removed.
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::retrieveFrame):
              (WebCore::ScriptDebugServer::shared):
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::addListener):
              (WebCore::ScriptDebugServer::removeListener):
              (WebCore::ScriptDebugServer::setPauseOnNextStatement):
              (WebCore::ScriptDebugServer::breakProgram):
              (WebCore::ScriptDebugServer::continueProgram):
              (WebCore::ScriptDebugServer::stepIntoStatement):
              (WebCore::ScriptDebugServer::stepOverStatement):
              (WebCore::ScriptDebugServer::stepOutOfFunction):
              (WebCore::ScriptDebugServer::editScriptSource):
              (WebCore::ScriptDebugServer::setEnabled):
              (WebCore::ScriptDebugServer::breakProgramCallback):
              (WebCore::ScriptDebugServer::v8DebugEventCallback):
              (WebCore::ScriptDebugServer::handleV8DebugEvent):
              (WebCore::ScriptDebugServer::didResume):
              * bindings/v8/ScriptDebugServer.h:
              (WebCore::ScriptDebugServer::pageCreated):
              (WebCore::ScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
              (WebCore::ScriptDebugServer::setClientMessageLoop):
              * bindings/v8/WorkerScriptDebugServer.cpp: Removed.
              * bindings/v8/WorkerScriptDebugServer.h: Removed.
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::init):
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::create):
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::enable):
              (WebCore::InspectorDebuggerAgent::disable):
              (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
              (WebCore::InspectorDebuggerAgent::removeBreakpoint):
              (WebCore::InspectorDebuggerAgent::continueToLocation):
              (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
              (WebCore::InspectorDebuggerAgent::editScriptSource):
              (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
              (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
              (WebCore::InspectorDebuggerAgent::resume):
              (WebCore::InspectorDebuggerAgent::stepOver):
              (WebCore::InspectorDebuggerAgent::stepInto):
              (WebCore::InspectorDebuggerAgent::stepOut):
              (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
              (WebCore::InspectorDebuggerAgent::didPause):
              (WebCore::InspectorDebuggerAgent::breakProgram):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::disable):
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/PageDebuggerAgent.cpp: Removed.
              * inspector/PageDebuggerAgent.h: Removed.
              * inspector/WorkerDebuggerAgent.cpp: Removed.
              * inspector/WorkerDebuggerAgent.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f579d84d
    • yurys@chromium.org's avatar
      2011-03-30 Yury Semikhatsky <yurys@chromium.org> · 61ba86de
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: split debugger agent into Page and Worker-specific ones
              https://bugs.webkit.org/show_bug.cgi?id=57345
      
              ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
              for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
              and Page/WorkerDebuggerAgent.
      
              * GNUmakefile.am:
              * UseJSC.cmake:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::currentCallFrame):
              * bindings/js/PageScriptDebugServer.cpp: Added.
              (WebCore::toPage):
              (WebCore::PageScriptDebugServer::shared):
              (WebCore::PageScriptDebugServer::PageScriptDebugServer):
              (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
              (WebCore::PageScriptDebugServer::addListener):
              (WebCore::PageScriptDebugServer::removeListener):
              (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
              (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
              (WebCore::PageScriptDebugServer::didPause):
              (WebCore::PageScriptDebugServer::didContinue):
              (WebCore::PageScriptDebugServer::didRemoveLastListener):
              (WebCore::PageScriptDebugServer::setJavaScriptPaused):
              * bindings/js/PageScriptDebugServer.h: Added.
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::sourceParsed):
              (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
              (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::pauseIfNeeded):
              * bindings/js/ScriptDebugServer.h:
              * bindings/js/WorkerScriptDebugServer.cpp: Added.
              (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::addListener):
              (WebCore::WorkerScriptDebugServer::removeListener):
              * bindings/js/WorkerScriptDebugServer.h: Added.
              (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
              (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
              (WebCore::WorkerScriptDebugServer::didPause):
              (WebCore::WorkerScriptDebugServer::didContinue):
              * bindings/v8/PageScriptDebugServer.cpp: Added.
              (WebCore::retrieveFrame):
              (WebCore::PageScriptDebugServer::shared):
              (WebCore::PageScriptDebugServer::PageScriptDebugServer):
              (WebCore::PageScriptDebugServer::addListener):
              (WebCore::PageScriptDebugServer::removeListener):
              (WebCore::PageScriptDebugServer::setClientMessageLoop):
              (WebCore::PageScriptDebugServer::getDebugListenerForContext):
              (WebCore::PageScriptDebugServer::runMessageLoopOnPause):
              (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
              * bindings/v8/PageScriptDebugServer.h: Added.
              (WebCore::PageScriptDebugServer::setEnabled):
              (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
              (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::setPauseOnNextStatement):
              (WebCore::ScriptDebugServer::breakProgram):
              (WebCore::ScriptDebugServer::continueProgram):
              (WebCore::ScriptDebugServer::stepIntoStatement):
              (WebCore::ScriptDebugServer::stepOverStatement):
              (WebCore::ScriptDebugServer::stepOutOfFunction):
              (WebCore::ScriptDebugServer::editScriptSource):
              (WebCore::toScriptDebugServer):
              (WebCore::ScriptDebugServer::breakProgramCallback):
              (WebCore::ScriptDebugServer::v8DebugEventCallback):
              (WebCore::ScriptDebugServer::handleV8DebugEvent):
              (WebCore::ScriptDebugServer::isPaused):
              * bindings/v8/ScriptDebugServer.h:
              * bindings/v8/WorkerScriptDebugServer.cpp: Added.
              (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::addListener):
              (WebCore::WorkerScriptDebugServer::removeListener):
              * bindings/v8/WorkerScriptDebugServer.h: Added.
              (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
              (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
              (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
              (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::init):
              (WebCore::InjectedScriptHost::debuggerAgent):
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::enable):
              (WebCore::InspectorDebuggerAgent::disable):
              (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
              (WebCore::InspectorDebuggerAgent::removeBreakpoint):
              (WebCore::InspectorDebuggerAgent::continueToLocation):
              (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
              (WebCore::InspectorDebuggerAgent::editScriptSource):
              (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
              (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
              (WebCore::InspectorDebuggerAgent::resume):
              (WebCore::InspectorDebuggerAgent::stepOver):
              (WebCore::InspectorDebuggerAgent::stepInto):
              (WebCore::InspectorDebuggerAgent::stepOut):
              (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
              (WebCore::InspectorDebuggerAgent::didPause):
              (WebCore::InspectorDebuggerAgent::breakProgram):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::disable):
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/PageDebuggerAgent.cpp: Added.
              (WebCore::PageDebuggerAgent::create):
              (WebCore::PageDebuggerAgent::PageDebuggerAgent):
              (WebCore::PageDebuggerAgent::~PageDebuggerAgent):
              (WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
              (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
              (WebCore::PageDebuggerAgent::scriptDebugServer):
              * inspector/PageDebuggerAgent.h: Added.
              * inspector/WorkerDebuggerAgent.cpp: Added.
              (WebCore::WorkerDebuggerAgent::create):
              (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
              (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
              (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
              (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
              (WebCore::WorkerDebuggerAgent::scriptDebugServer):
              * inspector/WorkerDebuggerAgent.h: Added.
      2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: split debugger agent into Page and Worker-specific ones
              https://bugs.webkit.org/show_bug.cgi?id=57345
      
              ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
              for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
              and Page/WorkerDebuggerAgent.
      
              * src/DebuggerAgentManager.cpp:
              (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgent::interruptAndDispatch):
              (WebKit::WebDevToolsAgent::processPendingMessages):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ba86de
    • mnaganov@chromium.org's avatar
      2011-03-29 Mikhail Naganov <mnaganov@chromium.org> · 678de7dd
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Remove exact retained size request in detailed heap snapshots.
              https://bugs.webkit.org/show_bug.cgi?id=57351
      
              * bindings/js/ScriptHeapSnapshot.h:
              * bindings/v8/ScriptHeapSnapshot.cpp:
              * bindings/v8/ScriptHeapSnapshot.h:
              * inspector/Inspector.json:
              * inspector/InspectorProfilerAgent.cpp:
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/DetailedHeapshotGridNodes.js:
              (WebInspector.HeapSnapshotGenericObjectNode):
              (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      678de7dd
  6. 28 Mar, 2011 1 commit
  7. 21 Mar, 2011 1 commit
    • pfeldman@chromium.org's avatar
      2011-03-21 Pavel Feldman <pfeldman@chromium.org> · 7e420b5a
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: migrate Inspector.json to valid JSON types.
              https://bugs.webkit.org/show_bug.cgi?id=56651
      
              This change migrates inspector from long to int as
              dom, storage, database and other id types.
      
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::inspectedNode):
              (WebCore::InjectedScriptHost::databaseIdImpl):
              (WebCore::InjectedScriptHost::storageIdImpl):
              (WebCore::InjectedScriptHost::didCreateWorker):
              (WebCore::InjectedScriptHost::didDestroyWorker):
              * inspector/InjectedScriptHost.h:
              * inspector/InjectedScriptHost.idl:
              * inspector/Inspector.json:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::highlightDOMNode):
              * inspector/InspectorAgent.h:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/InspectorCSSAgent.cpp:
              (WebCore::InspectorCSSAgent::getStylesForNode):
              (WebCore::InspectorCSSAgent::getInlineStyleForNode):
              (WebCore::InspectorCSSAgent::getComputedStyleForNode):
              (WebCore::InspectorCSSAgent::setPropertyText):
              (WebCore::InspectorCSSAgent::toggleProperty):
              (WebCore::InspectorCSSAgent::addRule):
              (WebCore::InspectorCSSAgent::elementForId):
              * inspector/InspectorCSSAgent.h:
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::count):
              (WebCore::InspectorConsoleAgent::addInspectedNode):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::bind):
              (WebCore::InspectorDOMAgent::unbind):
              (WebCore::InspectorDOMAgent::assertNode):
              (WebCore::InspectorDOMAgent::assertElement):
              (WebCore::InspectorDOMAgent::assertHTMLElement):
              (WebCore::InspectorDOMAgent::nodeToSelectOn):
              (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
              (WebCore::InspectorDOMAgent::nodeForId):
              (WebCore::InspectorDOMAgent::getChildNodes):
              (WebCore::InspectorDOMAgent::querySelector):
              (WebCore::InspectorDOMAgent::querySelectorAll):
              (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
              (WebCore::InspectorDOMAgent::boundNodeId):
              (WebCore::InspectorDOMAgent::setAttribute):
              (WebCore::InspectorDOMAgent::removeAttribute):
              (WebCore::InspectorDOMAgent::removeNode):
              (WebCore::InspectorDOMAgent::setNodeName):
              (WebCore::InspectorDOMAgent::getOuterHTML):
              (WebCore::InspectorDOMAgent::setOuterHTML):
              (WebCore::InspectorDOMAgent::setNodeValue):
              (WebCore::InspectorDOMAgent::getEventListenersForNode):
              (WebCore::InspectorDOMAgent::resolveNode):
              (WebCore::InspectorDOMAgent::pushNodeToFrontend):
              (WebCore::InspectorDOMAgent::buildObjectForNode):
              (WebCore::InspectorDOMAgent::loadEventFired):
              (WebCore::InspectorDOMAgent::didInsertDOMNode):
              (WebCore::InspectorDOMAgent::didRemoveDOMNode):
              (WebCore::InspectorDOMAgent::didModifyDOMAttr):
              (WebCore::InspectorDOMAgent::characterDataModified):
              (WebCore::InspectorDOMAgent::didInvalidateStyleAttr):
              (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
              (WebCore::InspectorDOMAgent::copyNode):
              (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageAgent.cpp:
              (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
              (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::storageId):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
              * inspector/InspectorDOMStorageAgent.h:
              * inspector/InspectorDOMStorageResource.cpp:
              * inspector/InspectorDOMStorageResource.h:
              (WebCore::InspectorDOMStorageResource::id):
              * inspector/InspectorDatabaseAgent.cpp:
              (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
              (WebCore::InspectorDatabaseAgent::executeSQL):
              (WebCore::InspectorDatabaseAgent::databaseId):
              (WebCore::InspectorDatabaseAgent::databaseForId):
              * inspector/InspectorDatabaseAgent.h:
              * inspector/InspectorDatabaseResource.cpp:
              * inspector/InspectorDatabaseResource.h:
              (WebCore::InspectorDatabaseResource::id):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
              * inspector/InspectorProfilerAgent.h:
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::identifierForInitialRequest):
              (WebCore::InspectorResourceAgent::willSendRequest):
              (WebCore::InspectorResourceAgent::markResourceAsCached):
              (WebCore::InspectorResourceAgent::didReceiveResponse):
              (WebCore::InspectorResourceAgent::didReceiveContentLength):
              (WebCore::InspectorResourceAgent::didFinishLoading):
              (WebCore::InspectorResourceAgent::didFailLoading):
              (WebCore::InspectorResourceAgent::setInitialContent):
              (WebCore::InspectorResourceAgent::didCreateWebSocket):
              (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorResourceAgent::didCloseWebSocket):
              * inspector/generate-inspector-idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e420b5a
  8. 12 Mar, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-03-11 Yury Semikhatsky <yurys@chromium.org> · 0928fb99
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move profiler related methods from inspector agent to profiler agent
              https://bugs.webkit.org/show_bug.cgi?id=56204
      
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::populateScriptObjects):
              (WebCore::InspectorAgent::showProfilesPanel):
              * inspector/InspectorAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::profilerEnabled):
              (WebCore::InspectorController::startUserInitiatedProfiling):
              (WebCore::InspectorController::stopUserInitiatedProfiling):
              (WebCore::InspectorController::isRecordingUserInitiatedProfile):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::create):
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::disable):
              (WebCore::InspectorProfilerAgent::setFrontend):
              (WebCore::InspectorProfilerAgent::clearFrontend):
              (WebCore::InspectorProfilerAgent::restore):
              (WebCore::InspectorProfilerAgent::restoreEnablement):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
              (WebCore::InspectorProfilerAgent::start):
              (WebCore::InspectorProfilerAgent::stop):
              * inspector/front-end/ProfileView.js:
              (WebInspector.CPUProfileType.prototype.buttonClicked):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype._registerProfileType):
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0928fb99
  9. 10 Mar, 2011 1 commit
    • pfeldman@chromium.org's avatar
      2011-03-10 Greg Simon <gregsimon@chromium.org> · b35e6870
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Need new graphic icon for garbage collect button.
              https://bugs.webkit.org/show_bug.cgi?id=55794
      
              No new tests: gc tests are flaky due to non-determinisic
              behavior of collection APIs (more notes in bug)
      
              * English.lproj/localizedStrings.js:
              * WebCore.gypi:
              * bindings/js/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::collectGarbage):
              * bindings/js/ScriptProfiler.h:
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::collectGarbage):
              * bindings/v8/ScriptProfiler.h:
              * inspector/Inspector.idl:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::collectGarbage):
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/Images/garbageCollectButtonGlyph.png: Added.
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel.prototype.get statusBarItems):
              (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
              (WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
              * inspector/front-end/inspector.css:
              (.garbage-collect-status-bar-item .glyph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b35e6870
  10. 04 Mar, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-03-04 Yury Semikhatsky <yurys@chromium.org> · 29626f8d
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
              https://bugs.webkit.org/show_bug.cgi?id=55770
      
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::didCommitLoad):
              * inspector/InspectorCSSAgent.cpp:
              (WebCore::InspectorCSSAgent::InspectorCSSAgent):
              (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
              * inspector/InspectorCSSAgent.h:
              * inspector/InspectorDatabaseAgent.cpp:
              (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didCommitLoadImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::didCommitLoad):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::create):
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
              * inspector/InstrumentingAgents.h:
              (WebCore::InstrumentingAgents::InstrumentingAgents):
              (WebCore::InstrumentingAgents::inspectorCSSAgent):
              (WebCore::InstrumentingAgents::setInspectorCSSAgent):
              (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
              (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
              (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
              (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
              (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
              (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
              (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
              (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
              (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
              (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
              (WebCore::InstrumentingAgents::inspectorProfilerAgent):
              (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29626f8d
  11. 02 Mar, 2011 2 commits
    • yurys@chromium.org's avatar
      2011-03-02 Yury Semikhatsky <yurys@chromium.org> · 3fb16635
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: break down InspectorFrontend into domain-specific classes
              https://bugs.webkit.org/show_bug.cgi?id=55584
      
              * inspector/elements/elements-panel-search.html:
      2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: break down InspectorFrontend into domain-specific classes
              https://bugs.webkit.org/show_bug.cgi?id=55584
      
              * inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
              all domains that have event notifications.
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::addToFrontend):
              (WebCore::ConsoleMessage::updateRepeatCountInConsole):
              * inspector/ConsoleMessage.h:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::inspectImpl):
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::populateScriptObjects):
              (WebCore::InspectorAgent::pushDataCollectedOffline):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::domContentLoadedEventFired):
              (WebCore::InspectorAgent::loadEventFired):
              (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
              (WebCore::InspectorAgent::evaluateForTestInFrontend):
              (WebCore::InspectorAgent::showPanel):
              * inspector/InspectorApplicationCacheAgent.cpp:
              (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
              * inspector/InspectorApplicationCacheAgent.h:
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::setFrontend):
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::show):
              (WebCore::InspectorController::close):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::setFrontend):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageResource.cpp:
              (WebCore::InspectorDOMStorageResource::bind):
              * inspector/InspectorDOMStorageResource.h:
              * inspector/InspectorDatabaseAgent.cpp:
              (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
              (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
              (WebCore::InspectorDatabaseAgent::setFrontend):
              * inspector/InspectorDatabaseResource.cpp:
              (WebCore::InspectorDatabaseResource::bind):
              * inspector/InspectorDatabaseResource.h:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setFrontend):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              * inspector/InspectorProfilerAgent.h:
              (WebCore::InspectorProfilerAgent::setFrontend):
              (WebCore::InspectorProfilerAgent::clearFrontend):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::InspectorResourceAgent):
              * inspector/InspectorResourceAgent.h:
              * inspector/InspectorTimelineAgent.cpp:
              (WebCore::InspectorTimelineAgent::setFrontend):
              * inspector/InspectorTimelineAgent.h:
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
              (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
              * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb16635
    • mnaganov@chromium.org's avatar
      2011-03-02 Mikhail Naganov <mnaganov@chromium.org> · 5f7dac94
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
              https://bugs.webkit.org/show_bug.cgi?id=55563
      
              This part adds implementations for data grids used to display
              different heap snapshots projections. We are almost done.
      
              * English.lproj/localizedStrings.js:
              * WebCore.gypi:
              * bindings/v8/ScriptHeapSnapshot.cpp:
              (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
              * bindings/v8/ScriptHeapSnapshot.h:
              * inspector/Inspector.idl:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/DetailedHeapshotGridNodes.js:
              (WebInspector.HeapSnapshotObjectNode):
              (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
              (WebInspector.HeapSnapshotInstanceNode):
              (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
              (WebInspector.HeapSnapshotDominatorObjectNode):
              (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
              (MixInSnapshotNodeFunctions):
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.HeapSnapshotContainmentDataGrid):
              (WebInspector.HeapSnapshotSortableDataGrid):
              (WebInspector.HeapSnapshotConstructorsDataGrid):
              (WebInspector.HeapSnapshotDiffDataGrid):
              (WebInspector.HeapSnapshotDominatorsDataGrid):
              (WebInspector.HeapSnapshotRetainingPathsList):
              (WebInspector.DetailedHeapshotView.profileCallback):
              (WebInspector.DetailedHeapshotView):
              * inspector/front-end/HeapSnapshot.js:
              (WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
              (WebInspector.HeapSnapshotEdge.prototype.toString):
              (WebInspector.HeapSnapshot.prototype._init):
              (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
              (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
              (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
              * inspector/front-end/Images/helpButtonGlyph.png: Added.
              * inspector/front-end/Panel.js:
              (WebInspector.Panel.prototype.reset):
              * inspector/front-end/Popover.js:
              (WebInspector.Popover):
              (WebInspector.Popover.prototype.show):
              (WebInspector.Popover.prototype.hide):
              (WebInspector.Popover.prototype.get visible):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._reset):
              (WebInspector.ProfilesPanel.prototype.getProfile):
              * inspector/front-end/heapProfiler.css:
              * inspector/front-end/inspector.js:
              (WebInspector.resetFocusElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f7dac94
  12. 24 Feb, 2011 1 commit
    • loislo@chromium.org's avatar
      2011-02-24 Ilya Tikhonovsky <loislo@chromium.org> · df5982d5
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: There is a validator of the protocol message format.
      
              It has two parts. InspectorBackendStub.js is the frontend part.
              InspectorBackendDispatcher.cpp is the backend part.
              Both parts are checking protocol message format and report the error if
              the message has not enough fields or the types of fields do not match with
              Inspector.idl specification. These validators are generated automatically.
      
              In addition, we have a number of places at the backend where we check the
              function arguments and do nothing if the arguments are invalid
              from the business logic point of view.
      
              This patch bring us an ability to report a custom error from such function to the frontend.
      
              https://bugs.webkit.org/show_bug.cgi?id=54971
      
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InjectedScriptHost.cpp:
              * inspector/InspectorAgent.cpp:
              * inspector/InspectorAgent.h:
              * inspector/InspectorApplicationCacheAgent.cpp:
              * inspector/InspectorApplicationCacheAgent.h:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/InspectorCSSAgent.cpp:
              * inspector/InspectorCSSAgent.h:
              * inspector/InspectorConsoleAgent.cpp:
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorController.cpp:
              * inspector/InspectorDOMAgent.cpp:
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageAgent.cpp:
              * inspector/InspectorDOMStorageAgent.h:
              * inspector/InspectorDatabaseAgent.cpp:
              * inspector/InspectorDatabaseAgent.h:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              * inspector/InspectorProfilerAgent.h:
              * inspector/InspectorResourceAgent.cpp:
              * inspector/InspectorResourceAgent.h:
              * inspector/InspectorRuntimeAgent.cpp:
              * inspector/InspectorRuntimeAgent.h:
              * inspector/InspectorTimelineAgent.cpp:
              * inspector/InspectorTimelineAgent.h:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df5982d5
  13. 01 Feb, 2011 1 commit
  14. 27 Jan, 2011 3 commits
    • yurys@chromium.org's avatar
      2011-01-27 Yury Semikhatsky <yurys@chromium.org> · 591972aa
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: store all settings related to the agents on the frontend side
              https://bugs.webkit.org/show_bug.cgi?id=53174
      
              * http/tests/inspector/console-xhr-logging.html: since the setting doesn't change on the front-end
              side there is no need to check it after modifying backend's value.
              * inspector/report-protocol-errors.html: use the new signature of disableDebugger method.
      2011-01-27  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: store all settings related to the agents on the frontend side
              https://bugs.webkit.org/show_bug.cgi?id=53174
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptDebugServer.cpp:
              * bindings/js/ScriptDebugServer.h:
              * bindings/js/ScriptProfiler.cpp:
              * bindings/js/ScriptProfiler.h:
              * bindings/v8/ScriptDebugServer.cpp:
              * bindings/v8/ScriptDebugServer.h:
              * bindings/v8/ScriptProfiler.cpp:
              * bindings/v8/ScriptProfiler.h:
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
              on the front-end side and will be pushed to the backend when the frontend is loaded.
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              * inspector/InspectorAgent.h:
              * inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
              if the front-end was opened during current browser session and XHR logging is turned on
              there.
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/InspectorSettings.cpp: Removed.
              * inspector/InspectorSettings.h: Removed.
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      591972aa
    • yurys@chromium.org's avatar
      2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com> · ffb351e8
      yurys@chromium.org authored
              Unreviewed, rolling out r76770.
              http://trac.webkit.org/changeset/76770
              https://bugs.webkit.org/show_bug.cgi?id=53229
      
              Some inspector tests fail (Requested by yurys on #webkit).
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
              * bindings/js/ScriptDebugServer.h:
              * bindings/js/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
              * bindings/js/ScriptProfiler.h:
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
              * bindings/v8/ScriptDebugServer.h:
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
              * bindings/v8/ScriptProfiler.h:
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::ensureSettingsLoaded):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              * inspector/InspectorAgent.h:
              (WebCore::InspectorAgent::settings):
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/InspectorSettings.cpp: Added.
              (WebCore::InspectorSettings::InspectorSettings):
              (WebCore::InspectorSettings::getBoolean):
              (WebCore::InspectorSettings::setBoolean):
              (WebCore::InspectorSettings::getLong):
              (WebCore::InspectorSettings::setLong):
              (WebCore::InspectorSettings::registerBoolean):
              (WebCore::InspectorSettings::registerLong):
              * inspector/InspectorSettings.h: Copied from Source/WebCore/bindings/v8/ScriptProfiler.h.
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged):
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffb351e8
    • yurys@chromium.org's avatar
      2011-01-26 Yury Semikhatsky <yurys@chromium.org> · 84d95409
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: store all settings related to the agents on the frontend side
              https://bugs.webkit.org/show_bug.cgi?id=53174
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored
              on the front-end side and will be pushed to the backend when the frontend is loaded.
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              * inspector/InspectorAgent.h:
              * inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only
              if the front-end was opened during current browser session and XHR logging is turned on
              there.
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
              (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
              * inspector/InspectorSettings.cpp: Removed.
              * inspector/InspectorSettings.h: Removed.
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared):
              (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction):
              (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84d95409
  15. 25 Jan, 2011 1 commit
    • mnaganov@chromium.org's avatar
      2011-01-25 Mikhail Naganov <mnaganov@chromium.org> · 8d2d9a40
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.
      
              - Introduce Preferences.detailedHeapProfiles flag for controlling
                querying of detailed heap snapshots.
              - Add boilerplate code for the new view.
              - Factor out common code.
      
              https://bugs.webkit.org/show_bug.cgi?id=52624
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/js/ScriptProfiler.h:
              (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
              (WebCore::ScriptProfiler::takeHeapSnapshot):
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::takeHeapSnapshot):
              * bindings/v8/ScriptProfiler.h:
              (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
              * inspector/Inspector.idl:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/DetailedHeapshotView.js: Added.
              (WebInspector.DetailedHeapshotView):
              (WebInspector.DetailedHeapshotView.prototype.get statusBarItems):
              (WebInspector.DetailedHeapshotView.prototype.get profile):
              (WebInspector.DetailedHeapshotView.prototype.set profile):
              (WebInspector.DetailedHeapshotView.prototype.show):
              (WebInspector.DetailedHeapshotView.prototype.hide):
              (WebInspector.DetailedHeapshotProfileType):
              (WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip):
              (WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle):
              (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
              (WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage):
              (WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile):
              (WebInspector.DetailedHeapshotProfileType.prototype.createView):
              * inspector/front-end/HeapSnapshot.js: Added.
              (WebInspector.HeapSnapshotEdgesIterator):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get done):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get name):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.next):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get node):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex):
              (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex):
              (WebInspector.HeapSnapshotEdgesIterator.prototype._getType):
              (WebInspector.HeapSnapshotNodeWrapper):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get name):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize):
              (WebInspector.HeapSnapshotNodeWrapper.prototype._getName):
              (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges):
              (WebInspector.HeapSnapshotNodeWrapper.prototype._getType):
              (WebInspector.HeapSnapshot):
              (WebInspector.HeapSnapshot.prototype._init):
              (WebInspector.HeapSnapshot.prototype.get rootEdges):
              * inspector/front-end/HeapSnapshotView.js:
              (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._setRecordingProfile):
              (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
              (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
              (WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
              * inspector/front-end/Settings.js:
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
              * src/js/DevTools.js:
              ():
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d2d9a40
  16. 23 Jan, 2011 1 commit
    • pfeldman@chromium.org's avatar
      2011-01-22 Ilya Tikhonovsky <loislo@chromium.org> · f73e2772
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: next step in splitting InspectorController.
      
              Splitting InspectorController is a bit tricky process.
      
              As a first step I'll do the next things:
              1) rename existing InspectorController to InspectorAgent;
              2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
              3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;
      
              The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.
      
              As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=52955
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::nodeForId):
              (WebCore::JSInjectedScriptHost::selectDOMStorage):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::V8InjectedScriptHost::nodeForIdCallback):
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::InjectedScriptHost):
              (WebCore::InjectedScriptHost::clearConsoleMessages):
              (WebCore::InjectedScriptHost::databaseForId):
              (WebCore::InjectedScriptHost::selectDatabase):
              (WebCore::InjectedScriptHost::selectDOMStorage):
              (WebCore::InjectedScriptHost::injectedScriptForMainFrame):
              (WebCore::InjectedScriptHost::inspectorDOMAgent):
              (WebCore::InjectedScriptHost::frontend):
              (WebCore::InjectedScriptHost::didCreateWorker):
              (WebCore::InjectedScriptHost::didDestroyWorker):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::create):
              (WebCore::InjectedScriptHost::inspectorAgent):
              (WebCore::InjectedScriptHost::disconnectController):
              * inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp.
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::~InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::enabled):
              (WebCore::InspectorAgent::inspectorStartsAttached):
              (WebCore::InspectorAgent::setInspectorStartsAttached):
              (WebCore::InspectorAgent::setInspectorAttachedHeight):
              (WebCore::InspectorAgent::inspectorAttachedHeight):
              (WebCore::InspectorAgent::searchingForNodeInPage):
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::inspect):
              (WebCore::InspectorAgent::focusNode):
              (WebCore::InspectorAgent::highlight):
              (WebCore::InspectorAgent::highlightDOMNode):
              (WebCore::InspectorAgent::highlightFrame):
              (WebCore::InspectorAgent::hideHighlight):
              (WebCore::InspectorAgent::mouseDidMoveOverElement):
              (WebCore::InspectorAgent::handleMousePress):
              (WebCore::InspectorAgent::setInspectorFrontendClient):
              (WebCore::InspectorAgent::didClearWindowObjectInWorld):
              (WebCore::InspectorAgent::setSearchingForNode):
              (WebCore::InspectorAgent::connectFrontend):
              (WebCore::InspectorAgent::show):
              (WebCore::InspectorAgent::showPanel):
              (WebCore::InspectorAgent::close):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::resourceAgent):
              (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
              (WebCore::InspectorAgent::populateScriptObjects):
              (WebCore::InspectorAgent::pushDataCollectedOffline):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::unbindAllResources):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::mainResourceFiredDOMContentEvent):
              (WebCore::InspectorAgent::mainResourceFiredLoadEvent):
              (WebCore::InspectorAgent::isMainResourceLoader):
              (WebCore::InspectorAgent::willSendRequest):
              (WebCore::InspectorAgent::ensureSettingsLoaded):
              (WebCore::InspectorAgent::startTimelineProfiler):
              (WebCore::InspectorAgent::stopTimelineProfiler):
              (WebCore::PostWorkerNotificationToFrontendTask::create):
              (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask):
              (WebCore::PostWorkerNotificationToFrontendTask::performTask):
              (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
              (WebCore::InspectorAgent::didCreateWorker):
              (WebCore::InspectorAgent::didDestroyWorker):
              (WebCore::InspectorAgent::didOpenDatabase):
              (WebCore::InspectorAgent::getCookies):
              (WebCore::InspectorAgent::buildArrayForCookies):
              (WebCore::InspectorAgent::buildObjectForCookie):
              (WebCore::InspectorAgent::deleteCookie):
              (WebCore::InspectorAgent::didUseDOMStorage):
              (WebCore::InspectorAgent::didCreateWebSocket):
              (WebCore::InspectorAgent::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorAgent::didCloseWebSocket):
              (WebCore::InspectorAgent::isRecordingUserInitiatedProfile):
              (WebCore::InspectorAgent::startUserInitiatedProfiling):
              (WebCore::InspectorAgent::stopUserInitiatedProfiling):
              (WebCore::InspectorAgent::profilerEnabled):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              (WebCore::InspectorAgent::resume):
              (WebCore::InspectorAgent::setAllBrowserBreakpoints):
              (WebCore::InspectorAgent::evaluateForTestInFrontend):
              (WebCore::InspectorAgent::didEvaluateForTestInFrontend):
              (WebCore::quadToPath):
              (WebCore::drawOutlinedQuad):
              (WebCore::drawOutlinedQuadWithClip):
              (WebCore::drawHighlightForBox):
              (WebCore::drawHighlightForLineBoxesOrSVGRenderer):
              (WebCore::convertFromFrameToMainFrame):
              (WebCore::frameToMainFrameOffset):
              (WebCore::InspectorAgent::drawNodeHighlight):
              (WebCore::InspectorAgent::drawElementTitle):
              (WebCore::InspectorAgent::openInInspectedWindow):
              (WebCore::InspectorAgent::addScriptToEvaluateOnLoad):
              (WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad):
              (WebCore::InspectorAgent::setInspectorExtensionAPI):
              (WebCore::InspectorAgent::inspectedURL):
              (WebCore::InspectorAgent::reloadPage):
              (WebCore::InspectorAgent::setExtraHeaders):
              * inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h.
              (WebCore::InspectorAgent::inspectorBackendDispatcher):
              (WebCore::InspectorAgent::inspectorClient):
              (WebCore::InspectorAgent::injectedScriptHost):
              (WebCore::InspectorAgent::inspectedPage):
              (WebCore::InspectorAgent::hideDOMNodeHighlight):
              (WebCore::InspectorAgent::hideFrameHighlight):
              (WebCore::InspectorAgent::frontend):
              (WebCore::InspectorAgent::inspectorController):
              (WebCore::InspectorAgent::inspectorAgent):
              (WebCore::InspectorAgent::consoleAgent):
              (WebCore::InspectorAgent::cssAgent):
              (WebCore::InspectorAgent::domAgent):
              (WebCore::InspectorAgent::injectedScriptAgent):
              (WebCore::InspectorAgent::runtimeAgent):
              (WebCore::InspectorAgent::timelineAgent):
              (WebCore::InspectorAgent::databaseAgent):
              (WebCore::InspectorAgent::domStorageAgent):
              (WebCore::InspectorAgent::fileSystemAgent):
              (WebCore::InspectorAgent::browserDebuggerAgent):
              (WebCore::InspectorAgent::debuggerAgent):
              (WebCore::InspectorAgent::profilerAgent):
              (WebCore::InspectorAgent::applicationCacheAgent):
              (WebCore::InspectorAgent::hasInspectorFrontendClient):
              (WebCore::InspectorAgent::hasFrontend):
              (WebCore::InspectorAgent::startProfiling):
              (WebCore::InspectorAgent::stopProfiling):
              (WebCore::InspectorAgent::debuggerEnabled):
              (WebCore::InspectorAgent::state):
              (WebCore::InspectorAgent::settings):
              * inspector/InspectorApplicationCacheAgent.cpp:
              (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
              (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
              * inspector/InspectorApplicationCacheAgent.h:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
              (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
              * inspector/InspectorBrowserDebuggerAgent.h:
              (WebCore::InspectorBrowserDebuggerAgent::create):
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::clearConsoleMessages):
              (WebCore::InspectorConsoleAgent::addMessageToConsole):
              (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorConsoleAgent::didReceiveResponse):
              (WebCore::InspectorConsoleAgent::didFailLoading):
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              (WebCore::InspectorConsoleAgent::addConsoleMessage):
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              * inspector/InspectorController.h:
              * inspector/InspectorDatabaseAgent.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::create):
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
              (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
              (WebCore::InspectorDebuggerAgent::currentCallFrames):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorFileSystemAgent.cpp:
              (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem):
              (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
              (WebCore::InspectorFileSystemAgent::stop):
              (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync):
              (WebCore::InspectorFileSystemAgent::didGetFileSystemPath):
              (WebCore::InspectorFileSystemAgent::didGetFileSystemError):
              * inspector/InspectorFileSystemAgent.h:
              (WebCore::InspectorFileSystemAgent::create):
              * inspector/InspectorFrontendHost.cpp:
              (WebCore::InspectorFrontendHost::setExtensionAPI):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::create):
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
      2011-01-22  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: next step in splitting InspectorController.
      
              #include "InspectorController.h" was added.
      
              https://bugs.webkit.org/show_bug.cgi?id=52955
      
              * WebCoreSupport/InspectorServerQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f73e2772
  17. 21 Jan, 2011 1 commit
  18. 20 Jan, 2011 1 commit
  19. 14 Jan, 2011 1 commit
    • yurys@chromium.org's avatar
      2011-01-13 Yury Semikhatsky <yurys@chromium.org> · 7382e72a
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: extract console related functionality into InspectorConsoleAgent
              https://bugs.webkit.org/show_bug.cgi?id=52282
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::~ConsoleMessage):
              * inspector/ConsoleMessage.h:
              * inspector/Inspector.idl:
              * inspector/InspectorConsoleAgent.cpp: Added.
              (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              (WebCore::InspectorConsoleAgent::clearConsoleMessages):
              (WebCore::InspectorConsoleAgent::reset):
              (WebCore::InspectorConsoleAgent::setFrontend):
              (WebCore::InspectorConsoleAgent::addMessageToConsole):
              (WebCore::InspectorConsoleAgent::startTiming):
              (WebCore::InspectorConsoleAgent::stopTiming):
              (WebCore::InspectorConsoleAgent::count):
              (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorConsoleAgent::didReceiveResponse):
              (WebCore::InspectorConsoleAgent::didFailLoading):
              (WebCore::InspectorConsoleAgent::addConsoleMessage):
              * inspector/InspectorConsoleAgent.h: Added.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::clearConsoleMessages):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              (WebCore::InspectorController::didCommitLoad):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::consoleAgent):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
              (WebCore::InspectorInstrumentation::didFailLoadingImpl):
              (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
              (WebCore::InspectorInstrumentation::addMessageToConsole):
              (WebCore::InspectorInstrumentation::count):
              (WebCore::InspectorInstrumentation::startTiming):
              (WebCore::InspectorInstrumentation::stopTiming):
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView):
              (WebInspector.ConsoleView.prototype.addConsoleMessage):
              (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
              (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
              * inspector/front-end/inspector.js:
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              (WebCore::Console::count):
              (WebCore::Console::profile):
              (WebCore::Console::time):
              (WebCore::Console::timeEnd):
              (WebCore::Console::group):
              (WebCore::Console::groupCollapsed):
              (WebCore::Console::groupEnd):
              * page/Console.h:
              * page/Console.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7382e72a
  20. 08 Jan, 2011 1 commit
  21. 13 Dec, 2010 3 commits
    • loislo@chromium.org's avatar
      2010-12-13 Ilya Tikhonovsky <loislo@chromium.org> · 2c950cf3
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMAgent.prototype.didCommitLoad):
              * inspector/front-end/Database.js:
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.pausedScript):
              (WebInspector.DebuggerModel.prototype.resumedScript):
              (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
              (WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
              (WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
              (WebInspector.DebuggerModel.prototype.parsedScriptSource):
              (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
              (WebInspector.DebuggerModel.prototype.didCreateWorker):
              (WebInspector.DebuggerModel.prototype.didDestroyWorker):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager):
              (WebInspector.ResourceManager.prototype._unbindResourceURL):
              (WebInspector.ResourceManager.prototype.updateDOMStorage):
              (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
              (WebInspector.ResourceManager.prototype.didGetFileSystemPath):
              (WebInspector.ResourceManager.prototype.didGetFileSystemError):
              (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
              (WebInspector.ResourceManager.prototype.updateNetworkState):
              (WebInspector.ResourceManager.prototype.addDOMStorage):
              (WebInspector.ResourceManager.prototype.selectDOMStorage):
              (WebInspector.ResourceManager.prototype.addDatabase):
              (WebInspector.ResourceManager.prototype.selectDatabase):
              (WebInspector.ResourceManager.prototype.sqlTransactionSucceeded):
              (WebInspector.ResourceManager.prototype.sqlTransactionFailed):
              * inspector/front-end/WorkersSidebarPane.js:
              (WebInspector.Worker):
              * inspector/front-end/inspector.js:
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * src/js/Tests.js:
              (.TestSuite.prototype._waitForScriptPause):
              (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
              (.TestSuite.prototype._waitUntilScriptsAreParsed):
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c950cf3
    • loislo@chromium.org's avatar
      2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com> · 19f95c35
      loislo@chromium.org authored
              Unreviewed, rolling out r73898.
              http://trac.webkit.org/changeset/73898
              https://bugs.webkit.org/show_bug.cgi?id=50919
      
              FileSystem and Database API's were broken (Requested by loislo
              on #webkit).
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
      2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73898.
              http://trac.webkit.org/changeset/73898
              https://bugs.webkit.org/show_bug.cgi?id=50919
      
              FileSystem and Database API's were broken (Requested by loislo
              on #webkit).
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              * inspector/front-end/DOMAgent.js:
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.debuggerPaused):
              (WebInspector.DebuggerModel.prototype.debuggerResumed):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager):
              (WebInspector.ResourceManager.prototype._registerNotifyHandlers):
              (WebInspector.ResourceManager.prototype._unbindResourceURL):
              * inspector/front-end/inspector.js:
              (WebInspector.addDatabase):
              (WebInspector.addDOMStorage):
              (WebInspector.updateDOMStorage):
              (WebInspector.updateApplicationCacheStatus):
              (WebInspector.didGetFileSystemPath):
              (WebInspector.didGetFileSystemError):
              (WebInspector.didGetFileSystemDisabled):
              (WebInspector.updateNetworkState):
              (WebInspector.attachDebuggerWhenShown):
              (WebInspector.debuggerWasEnabled):
              (WebInspector.debuggerWasDisabled):
              (WebInspector.profilerWasEnabled):
              (WebInspector.profilerWasDisabled):
              (WebInspector.parsedScriptSource):
              (WebInspector.restoredBreakpoint):
              (WebInspector.failedToParseScriptSource):
              (WebInspector.pausedScript):
              (WebInspector.resumedScript):
              (WebInspector.resetProfilesPanel):
              (WebInspector.didCommitLoad):
              (WebInspector.addProfileHeader):
              (WebInspector.setRecordingProfile):
              (WebInspector.addHeapSnapshotChunk):
              (WebInspector.finishHeapSnapshot):
      2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r73898.
              http://trac.webkit.org/changeset/73898
              https://bugs.webkit.org/show_bug.cgi?id=50919
      
              FileSystem and Database API's were broken (Requested by loislo
              on #webkit).
      
              * src/js/Tests.js:
              (.TestSuite.prototype._waitForScriptPause):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19f95c35
    • loislo@chromium.org's avatar
      2010-12-13 Ilya Tikhonovsky <loislo@chromium.org> · 21577ea9
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::resetState):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMAgent.prototype.didCommitLoad):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.pausedScript):
              (WebInspector.DebuggerModel.prototype.resumedScript):
              (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
              (WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
              (WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
              (WebInspector.DebuggerModel.prototype.parsedScriptSource):
              (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.addHeapSnapshots):
              (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
              * inspector/front-end/ResourceManager.js:
              (WebInspector.ResourceManager):
              (WebInspector.ResourceManager.prototype._unbindResourceURL):
              (WebInspector.ResourceManager.prototype.updateDOMStorage):
              (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
              (WebInspector.ResourceManager.prototype.didGetFileSystemPath):
              (WebInspector.ResourceManager.prototype.didGetFileSystemError):
              (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
              (WebInspector.ResourceManager.prototype.updateNetworkState):
              (WebInspector.ResourceManager.prototype.addDatabase):
              (WebInspector.ResourceManager.prototype.addDOMStorage):
              * inspector/front-end/inspector.js:
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * src/js/Tests.js:
              (.TestSuite.prototype._waitForScriptPause):
      
      2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.
      
              Debugger and Resources related notification functions of Inspector.idl were
              marked as such with help of "domain" attribute. The other changes in js files
              are reflecting this change. Some wrappers in WebInspector namespace were dropped,
              the others were moved to DebuggerModel class.
      
              https://bugs.webkit.org/show_bug.cgi?id=50906
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
              (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21577ea9
  22. 29 Nov, 2010 1 commit
    • mnaganov@chromium.org's avatar
      2010-11-29 Mikhail Naganov <mnaganov@chromium.org> · af7ad7a6
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              WebInspector: Request JSON-serialized heap snapshot from JS engine.
              This simplifies heap snapshots interaction and API. Instead of
              having objects representing snapshot entities, the whole snapshot
              is transferred to WebInspector and parsed there.
      
              https://bugs.webkit.org/show_bug.cgi?id=49974
      
              * bindings/js/ScriptHeapSnapshot.h:
              (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream):
              (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
              (WebCore::ScriptHeapSnapshot::writeJSON):
              (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
              * bindings/v8/ScriptHeapSnapshot.cpp:
              (WebCore::ScriptHeapSnapshot::writeJSON):
              * bindings/v8/ScriptHeapSnapshot.h:
              (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream):
              * inspector/Inspector.idl:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::getProfile):
              * inspector/front-end/HeapSnapshotView.js:
              (WebInspector.HeapSnapshotEdgesIterator):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get done):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get name):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.next):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get node):
              (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex):
              (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex):
              (WebInspector.HeapSnapshotEdgesIterator.prototype._getType):
              (WebInspector.HeapSnapshotNodeWrapper):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get name):
              (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize):
              (WebInspector.HeapSnapshotNodeWrapper.prototype._getName):
              (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges):
              (WebInspector.HeapSnapshotNodeWrapper.prototype._getType):
              (WebInspector.HeapSnapshot):
              (WebInspector.HeapSnapshot.prototype._init):
              (WebInspector.HeapSnapshot.prototype.get rootEdges):
              (WebInspector.HeapSnapshotView.prototype.snapshotLoaded):
              (WebInspector.HeapSnapshotView.prototype._loadProfile.processLoadedSnapshot):
              (WebInspector.HeapSnapshotView.prototype._loadProfile):
              (WebInspector.HeapSnapshotView.prototype._convertSnapshot):
              (WebInspector.HeapSnapshotView.prototype._prepareProfile.mergeRetainers):
              (WebInspector.HeapSnapshotView.prototype._prepareProfile):
              (WebInspector.HeapSnapshotView.prototype._sortData):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk):
              (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
              * inspector/front-end/inspector.js:
              (WebInspector.addHeapSnapshotChunk):
              (WebInspector.finishHeapSnapshot):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af7ad7a6
  23. 24 Nov, 2010 1 commit
    • abecsi@webkit.org's avatar
      2010-11-24 Andras Becsi <abecsi@inf.u-szeged.hu> · 6234000a
      abecsi@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Make WebKit2 compile with !ENABLE(INSPECTOR).
              https://bugs.webkit.org/show_bug.cgi?id=49973
      
              No new tests needed.
      
              * bindings/js/ScriptHeapSnapshot.h:
              * bindings/js/ScriptProfile.cpp:
              * bindings/js/ScriptProfile.h:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              * inspector/InspectorProfilerAgent.h:
              * inspector/ScriptBreakpoint.h:
      2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Make WebKit2 compile with !ENABLE(INSPECTOR).
              https://bugs.webkit.org/show_bug.cgi?id=49973
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::setJavaScriptProfilingEnabled):
      2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Make WebKit2 compile with !ENABLE(INSPECTOR).
              https://bugs.webkit.org/show_bug.cgi?id=49973
      
              * Shared/API/c/WKSharedAPICast.h:
              (WebKit::toAPI):
              (WebKit::toImpl):
              * UIProcess/API/C/WKAPICast.h:
              * UIProcess/API/C/WKInspector.cpp:
              * UIProcess/API/C/WKInspector.h:
              * UIProcess/API/C/WKPage.cpp:
              * UIProcess/API/C/WKPage.h:
              * UIProcess/WebInspectorProxy.cpp:
              * UIProcess/WebInspectorProxy.h:
              * UIProcess/WebInspectorProxy.messages.in:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::close):
              (WebKit::WebPageProxy::didReceiveMessage):
              (WebKit::WebPageProxy::didReceiveSyncMessage):
              (WebKit::WebPageProxy::processDidCrash):
              * UIProcess/WebPageProxy.h:
              * UIProcess/mac/WebInspectorProxyMac.mm:
              * UIProcess/qt/WebInspectorProxyQt.cpp:
              * UIProcess/win/WebInspectorProxyWin.cpp:
              * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
              * WebProcess/WebCoreSupport/WebInspectorClient.h:
              * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
              * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
              * WebProcess/WebPage/WebInspector.cpp:
              * WebProcess/WebPage/WebInspector.h:
              * WebProcess/WebPage/WebInspector.messages.in:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::WebPage):
              (WebKit::WebPage::close):
              (WebKit::WebPage::windowIsFocused):
              (WebKit::WebPage::didReceiveMessage):
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/qt/WebInspectorQt.cpp:
              * WebProcess/WebPage/win/WebInspectorWin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6234000a
  24. 08 Nov, 2010 1 commit
    • mnaganov@chromium.org's avatar
      2010-11-08 Mikhail Naganov <mnaganov@chromium.org> · ccce4021
      mnaganov@chromium.org authored
              Reviewed by Adam Barth.
      
              Web Inspector [Chromium]: Make CPU profiling to survive navigation.
      
              https://bugs.webkit.org/show_bug.cgi?id=48843
      
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              (WebCore::InspectorController::reuseFrontend):
              (WebCore::InspectorController::disconnectFrontend):
              (WebCore::InspectorController::populateScriptObjects):
              (WebCore::InspectorController::restoreProfiler):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::startUserInitiatedProfiling):
              (WebCore::InspectorController::stopUserInitiatedProfiling):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::startProfiling):
              (WebCore::InspectorController::stopProfiling):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype.hasTemporaryProfile):
              (WebInspector.ProfilesPanel.prototype.hasProfile):
              * inspector/front-end/inspector.js:
              (WebInspector.setRecordingProfile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccce4021
  25. 03 Nov, 2010 1 commit
  26. 14 Oct, 2010 1 commit
    • zimmermann@webkit.org's avatar
      2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com> · bbfe2a50
      zimmermann@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              Replace lots of String::format() usages by StringConcatenate
              https://bugs.webkit.org/show_bug.cgi?id=47664
      
              Add StringTypeAdapter<char> to accept single characters for makeString().
      
              * wtf/text/StringConcatenate.h:
              (WTF::makeString):
      2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Gavin Barraclough.
      
              Replace lots of String::format() usages by StringConcatenate
              https://bugs.webkit.org/show_bug.cgi?id=47664
      
              * ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::reportUnsafeAccessTo):
              * dom/ExceptionBase.cpp:
              (WebCore::ExceptionBase::ExceptionBase):
              * dom/XMLDocumentParser.cpp:
              (WebCore::XMLDocumentParser::handleError):
              * history/PageCache.cpp:
              (WebCore::logCanCacheFrameDecision):
              * html/FTPDirectoryDocument.cpp:
              (WebCore::processFileDateString):
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::count):
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::createBreakpointId):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::formatBreakpointId):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
              (WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName):
              (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
              * loader/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::printAccessDeniedMessage):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkIfDisplayInsecureContent):
              (WebCore::FrameLoader::checkIfRunInsecureContent):
              (WebCore::FrameLoader::shouldAllowNavigation):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::createFromSelection):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::postMessageTimerFired):
              * page/PrintContext.cpp:
              (WebCore::PrintContext::pageProperty):
              (WebCore::PrintContext::pageSizeAndMarginsInPixels):
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::canLoadObject):
              * platform/efl/PlatformKeyboardEventEfl.cpp:
              (WebCore::createKeyMap):
              (WebCore::createWindowsKeyMap):
              * platform/graphics/GraphicsLayer.cpp:
              (WebCore::GraphicsLayer::animationNameForTransition):
              * platform/graphics/brew/ImageBrew.cpp:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/cg/ImageBufferCG.cpp:
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/efl/ImageEfl.cpp:
              (WebCore::loadResourceSharedBuffer):
              * platform/graphics/gtk/ImageBufferGtk.cpp:
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/haiku/ImageBufferHaiku.cpp:
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::animationIdentifier):
              * platform/graphics/qt/ImageBufferQt.cpp:
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/skia/ImageBufferSkia.cpp:
              (WebCore::ImageBuffer::toDataURL):
              * platform/graphics/win/WebLayer.cpp:
              (WebCore::WebLayer::drawInContext):
              * platform/network/CredentialStorage.cpp:
              (WebCore::originStringFromURL):
              * platform/sql/SQLiteDatabase.cpp:
              (WebCore::SQLiteDatabase::setSynchronous):
              * platform/text/wince/TextCodecWinCE.cpp:
              (WebCore::LanguageManager::LanguageManager):
              * platform/win/ClipboardUtilitiesWin.cpp:
              (WebCore::markupToCFHTML):
              * platform/win/Language.cpp:
              (WebCore::defaultLanguage):
              * plugins/PluginStream.cpp:
              (WebCore::PluginStream::startStream):
              * svg/SVGUseElement.cpp:
              (WebCore::dumpInstanceTree):
              * websockets/WebSocket.cpp:
              (WebCore::WebSocket::connect):
              * websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::appendToBuffer):
              * websockets/WebSocketHandshake.cpp:
              (WebCore::WebSocketHandshake::readServerHandshake):
      2010-10-14  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Gavin Barraclough.
      
              Replace lots of String::format() usages by StringConcatenate
              https://bugs.webkit.org/show_bug.cgi?id=47664
      
              Rebaseline two xssAuditor tests, that have been changed, after switching from String::format() -> makeString().
      
              * http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
              * http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@69798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbfe2a50
  27. 11 Sep, 2010 1 commit
  28. 26 Aug, 2010 1 commit
    • mnaganov@chromium.org's avatar
      2010-08-26 Mikhail Naganov <mnaganov@chromium.org> · 06106af7
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Store heap snapshots in InspectorProfilerAgent.
      
              Change the way heap snapshots are transported to Inspector
              to be aligned with CPU profiles. As a result, the Heap snapshots
              view of Profiles panel was upstreamed into WebCore.
      
              https://bugs.webkit.org/show_bug.cgi?id=44531
      
              * English.lproj/localizedStrings.js:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptHeapSnapshot.h: Added.
              (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
              (WebCore::ScriptHeapSnapshot::title):
              (WebCore::ScriptHeapSnapshot::uid):
              (WebCore::ScriptHeapSnapshot::buildInspectorObjectForHead):
              (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
              * bindings/js/ScriptProfiler.h:
              (WebCore::ScriptProfiler::takeHeapSnapshot):
              * bindings/v8/ScriptHeapSnapshot.cpp: Added.
              (WebCore::ScriptHeapSnapshot::title):
              (WebCore::ScriptHeapSnapshot::uid):
              (WebCore::buildInspectorObjectFor):
              (WebCore::ScriptHeapSnapshot::buildInspectorObjectForHead):
              * bindings/v8/ScriptHeapSnapshot.h: Added.
              (WebCore::ScriptHeapSnapshot::create):
              (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot):
              (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
              * bindings/v8/ScriptProfile.cpp:
              (WebCore::buildInspectorObjectFor):
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::takeHeapSnapshot):
              * bindings/v8/ScriptProfiler.h:
              * inspector/Inspector.idl:
              * inspector/InspectorBackend.cpp:
              * inspector/InspectorBackend.h:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::createSnapshotHeader):
              (WebCore::InspectorProfilerAgent::getProfileHeaders):
              (WebCore::InspectorProfilerAgent::getProfile):
              (WebCore::InspectorProfilerAgent::removeProfile):
              (WebCore::InspectorProfilerAgent::resetState):
              (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/HeapSnapshotView.js: Added.
              (WebInspector.HeapSnapshotView.profileCallback):
              (WebInspector.HeapSnapshotView.resetCompleted):
              (WebInspector.HeapSnapshotView):
              (WebInspector.HeapSnapshotView.prototype.get statusBarItems):
              (WebInspector.HeapSnapshotView.prototype.get profile):
              (WebInspector.HeapSnapshotView.prototype.set profile):
              (WebInspector.HeapSnapshotView.prototype.show):
              (WebInspector.HeapSnapshotView.prototype.hide):
              (WebInspector.HeapSnapshotView.prototype.resize):
              (WebInspector.HeapSnapshotView.prototype.refresh):
              (WebInspector.HeapSnapshotView.prototype.refreshShowAsPercents):
              (WebInspector.HeapSnapshotView.prototype._deleteSearchMatchedFlags):
              (WebInspector.HeapSnapshotView.prototype.searchCanceled):
              (WebInspector.HeapSnapshotView.prototype.performSearch):
              (WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult.WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult.jumpToLastSearchResult.WebInspector.CPUProfileView.prototype.jumpToLastSearchResult.jumpToNextSearchResult.WebInspector.CPUProfileView.prototype.jumpToNextSearchResult.jumpToPreviousSearchResult.WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult.showingFirstSearchResult.WebInspector.CPUProfileView.prototype.showingFirstSearchResult.showingLastSearchResult.WebInspector.CPUProfileView.prototype.showingLastSearchResult._jumpToSearchResult.WebInspector.CPUProfileView.prototype._jumpToSearchResult.refreshVisibleData):
              (WebInspector.HeapSnapshotView.prototype._changeBase.resetCompleted):
              (WebInspector.HeapSnapshotView.prototype._changeBase):
              (WebInspector.HeapSnapshotView.prototype._createSnapshotDataGridList):
              (WebInspector.HeapSnapshotView.prototype._getProfiles):
              (WebInspector.HeapSnapshotView.prototype._loadProfile.loadedCallback):
              (WebInspector.HeapSnapshotView.prototype._loadProfile):
              (WebInspector.HeapSnapshotView.prototype._mouseDownInDataGrid):
              (WebInspector.HeapSnapshotView.prototype.get _isShowingAsPercent):
              (WebInspector.HeapSnapshotView.prototype._percentClicked):
              (WebInspector.HeapSnapshotView.prototype._prepareProfile.mergeRetainers):
              (WebInspector.HeapSnapshotView.prototype._prepareProfile):
              (WebInspector.HeapSnapshotView.prototype._resetDataGridList.profileLoaded):
              (WebInspector.HeapSnapshotView.prototype._resetDataGridList):
              (WebInspector.HeapSnapshotView.prototype._sortData):
              (WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
              (WebInspector.HeapSnapshotView.prototype._updatePercentButton):
              (WebInspector.HeapSnapshotView.prototype._updateSummaryGraph):
              (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS):
              (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS_OR_EQUAL):
              (WebInspector.HeapSnapshotView.SearchHelper.operations.EQUAL):
              (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER_OR_EQUAL):
              (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER):
              (WebInspector.HeapSnapshotView.SearchHelper.parseOperationAndNumber):
              (WebInspector.HeapSummaryCalculator):
              (WebInspector.HeapSummaryCalculator.prototype.computeSummaryValues):
              (WebInspector.HeapSummaryCalculator.prototype.formatValue):
              (WebInspector.HeapSummaryCalculator.prototype.get showAsPercent):
              (WebInspector.HeapSummaryCalculator.prototype.set showAsPercent):
              (WebInspector.HeapSummaryCountCalculator):
              (WebInspector.HeapSummaryCountCalculator.prototype._highFromLow):
              (WebInspector.HeapSummaryCountCalculator.prototype._valueToString):
              (WebInspector.HeapSummarySizeCalculator):
              (WebInspector.HeapSummarySizeCalculator.prototype._highFromLow):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _hasRetainers):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _parent):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.produceDiff):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.sort):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.signForDelta):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.showDeltaAsPercent):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalCount):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalSize):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countPercent):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizePercent):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countDeltaPercent):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizeDeltaPercent):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get data):
              (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.createCell):
              (WebInspector.HeapSnapshotDataGridNode):
              (WebInspector.HeapSnapshotDataGridList):
              (WebInspector.HeapSnapshotDataGridList.prototype.appendChild):
              (WebInspector.HeapSnapshotDataGridList.prototype.insertChild):
              (WebInspector.HeapSnapshotDataGridList.prototype.removeChildren):
              (WebInspector.HeapSnapshotDataGridList.prototype.populateChildren):
              (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
              (WebInspector.HeapSnapshotDataGridList.propertyComparator):
              (WebInspector.HeapSnapshotDataGridRetainerNode):
              (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizePercent):
              (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizeDeltaPercent):
              (WebInspector.HeapSnapshotDataGridRetainerNode.prototype._calculateRetainers):
              (WebInspector.HeapSnapshotProfileType):
              (WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
              (WebInspector.HeapSnapshotProfileType.prototype.get buttonStyle):
              (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
              (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
              (WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
              (WebInspector.HeapSnapshotProfileType.prototype.createView):
              * inspector/front-end/ProfileView.js:
              (WebInspector.CPUProfileView):
              (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype.addProfileHeader):
              (WebInspector.ProfilesPanel.prototype.removeProfileHeader):
              (WebInspector.ProfilesPanel.prototype.getProfiles):
              (WebInspector.ProfilesPanel.prototype.updateProfile):
              (WebInspector.ProfileSidebarTreeElement):
              (WebInspector.ProfileSidebarTreeElement.prototype.get mainTitle):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              (.heap-snapshot-sidebar-tree-item .icon):
              (.heap-snapshot-sidebar-tree-item.small .icon):
              (.heap-snapshot-view):
              (.heap-snapshot-view.visible):
              (.heap-snapshot-view .data-grid):
              (.heap-snapshot-view .data-grid th.count-column):
              (.heap-snapshot-view .data-grid td.count-column):
              (.heap-snapshot-view .data-grid th.size-column):
              (.heap-snapshot-view .data-grid td.size-column):
              (.heap-snapshot-view .data-grid th.countDelta-column):
              (.heap-snapshot-view .data-grid td.countDelta-column):
              (.heap-snapshot-view .data-grid th.sizeDelta-column):
              (.heap-snapshot-view .data-grid td.sizeDelta-column):
              (#heap-snapshot-summary-container):
              (.heap-snapshot-summary):
              (.heap-snapshot-summary canvas.summary-graph):
              (.heap-snapshot-summary-label):
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
      
              * DEPS:
              * WebKit.gypi:
              * src/js/DevTools.js:
              ():
              * src/js/HeapProfilerPanel.js: Removed.
              * src/js/ProfilerAgent.js: Removed.
              * src/js/ProfilerProcessor.js: Removed.
              * src/js/devTools.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06106af7
  29. 24 Aug, 2010 1 commit
    • loislo@chromium.org's avatar
      2010-08-24 Ilya Tikhonovsky <loislo@chromium.org> · b3d4ff4c
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              WebInspector: RemoteInspectorFrontend can be renamed to InspectorFrontend.
              The old version of InspectorFrontend was removed some time ago and now
              it is possible to rename the new version of inspector frontend class to its
              original name.
              https://bugs.webkit.org/show_bug.cgi?id=44499
      
              * GNUmakefile.am:
              * WebCore.gyp/WebCore.gyp:
              * WebCore.pri:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/ConsoleMessage.cpp:
              * inspector/ConsoleMessage.h:
              * inspector/InjectedScriptHost.cpp:
              * inspector/InjectedScriptHost.h:
              * inspector/InspectorApplicationCacheAgent.cpp:
              * inspector/InspectorApplicationCacheAgent.h:
              * inspector/InspectorBackend.cpp:
              * inspector/InspectorBackend.h:
              * inspector/InspectorCSSStore.cpp:
              * inspector/InspectorCSSStore.h:
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorDOMAgent.cpp:
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorDOMStorageResource.cpp:
              * inspector/InspectorDOMStorageResource.h:
              * inspector/InspectorDatabaseResource.cpp:
              * inspector/InspectorDatabaseResource.h:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorProfilerAgent.cpp:
              * inspector/InspectorProfilerAgent.h:
              * inspector/InspectorResource.cpp:
              * inspector/InspectorResource.h:
              * inspector/InspectorStorageAgent.cpp:
              * inspector/InspectorStorageAgent.h:
              * inspector/InspectorTimelineAgent.cpp:
              * inspector/InspectorTimelineAgent.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3d4ff4c
  30. 23 Aug, 2010 1 commit