1. 11 Oct, 2008 12 commits
  2. 10 Oct, 2008 28 commits
    • oliver@apple.com's avatar
      Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion · 7264bb50
      oliver@apple.com authored
      Reviewed by Cameron Zwarich
      
      When JS is terminated by the user choosing to stop a slow script
      the exception toString method throws, yet the console logger does
      not perform exception checks after logging.  This leaves an
      exception on the Machine, which in turn results in an assertion
      failure next time we attempt to enter JS.  The solution is just to
      clear the exception state after attempting to record the exception.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7264bb50
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · 0f12904e
      hyatt@apple.com authored
              Make textareas work with custom CSS scrollbars and resizers.  Need to access the correct renderer
              when looking for pseudo styles.
      
              Reviewed by Tim Hatcher
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::createScrollbar):
              (WebCore::RenderLayer::styleChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f12904e
    • dino@apple.com's avatar
      2008-10-10 Dean Jackson <dino@apple.com> · ee3700b4
      dino@apple.com authored
              Keyframe example had "0" rather than "0%".
      
              * WebKitSite/specs/CSSVisualEffects/CSSAnimations.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee3700b4
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · ca798134
      hyatt@apple.com authored
              Add the ability to style the scroll corner and the resizer from CSS.
      
              Reviewed by Tim Hatcher
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::RenderLayer):
              (WebCore::RenderLayer::~RenderLayer):
              (WebCore::RenderLayer::paintOverflowControls):
              (WebCore::RenderLayer::paintScrollCorner):
              (WebCore::RenderLayer::paintResizer):
              (WebCore::RenderLayer::styleChanged):
              * rendering/RenderLayer.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::updateScrollbarPart):
              (WebCore::RenderScrollbar::paintPart):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::RenderScrollbarPart):
              (WebCore::RenderScrollbarPart::paintIntoRect):
              * rendering/RenderScrollbarPart.h:
              * rendering/style/RenderStyle.h:
              (WebCore::RenderStyle::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca798134
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · fca034d3
      hyatt@apple.com authored
              Make CSS scrollbars respect the OS setting regarding where buttons should be placed.
      
              Reviewed by Sam Weinig
      
              No test case possible, since the OS setting can vary.
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * platform/Scrollbar.h:
              (WebCore::Scrollbar::styleChanged):
              * platform/mac/ScrollbarThemeMac.mm:
              (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
              (WebCore::ScrollbarThemeMac::preferencesChanged):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::invalidateScrollbarRect):
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::styleChanged):
              (WebCore::RenderScrollbar::updateScrollbarPart):
              * rendering/RenderScrollbar.h:
              * rendering/RenderScrollbarTheme.h:
              (WebCore::RenderScrollbarTheme::buttonsPlacement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fca034d3
    • adachan@apple.com's avatar
      Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can · d4bd621a
      adachan@apple.com authored
              potentially hold onto stale instances of WebPreferences
              https://bugs.webkit.org/show_bug.cgi?id=21526
              
              webPreferencesInstances now keeps a reference to all the instances it holds.
              Fix up callers of WebPreferences::removeReferenceForIdentifier() to call 
              it after they have released their references to the WebPreferences objects.
      
              Reviewed by Adam Roben.
      
              * WebPreferences.cpp:
              (WebPreferences::getInstanceForIdentifier):
              (WebPreferences::removeReferenceForIdentifier):
              * WebView.cpp:
              (WebView::close):
              (WebView::setPreferences):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4bd621a
    • timothy@apple.com's avatar
      Fixes a regression with input search fields, where the placeholder text · c1df5735
      timothy@apple.com authored
              would not be updated when the value of the placeholder attribute changed.
      
              https://bugs.webkit.org/show_bug.cgi?id=21521
      
              Reviewed by Adele Peterson.
      
              Test: fast/forms/search-placeholder-value-changed.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the
              placeholderValueChanged parameter of updatePlaceholderVisibility.
              (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter
              for placeholderValueChanged that informs the method that the value changed.
              * html/HTMLInputElement.h: Add the placeholderValueChanged to the
              updatePlaceholderVisibility method. Made it default to false.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1df5735
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · c92f8c29
      hyatt@apple.com authored
              Allow the track part to have negative margins so that it can slightly overlap buttons.  This
              is necessary to emulate the Aqua look in CSS.
      
              Reviewed by Sam Weinig
      
              * platform/ScrollbarThemeComposite.cpp:
              (WebCore::ScrollbarThemeComposite::paint):
              (WebCore::ScrollbarThemeComposite::hitTest):
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::setHoveredPart):
              (WebCore::RenderScrollbar::trackRect):
              * rendering/RenderScrollbar.h:
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::computeScrollbarWidth):
              (WebCore::RenderScrollbarPart::computeScrollbarHeight):
              * rendering/RenderScrollbarTheme.cpp:
              (WebCore::RenderScrollbarTheme::backButtonRect):
              (WebCore::RenderScrollbarTheme::forwardButtonRect):
              (WebCore::RenderScrollbarTheme::trackRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c92f8c29
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · f9e710bb
      hyatt@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=21527
      
              Make CSS scrollbars support :not, :hover and :active.
      
              Reviewed by Adam Roben
      
              Added WebCore/manual-tests/scrollbar-hover-active.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * platform/Scrollbar.cpp:
              (WebCore::Scrollbar::autoscrollPressedPart):
              (WebCore::Scrollbar::startTimerIfNeeded):
              (WebCore::Scrollbar::setHoveredPart):
              (WebCore::Scrollbar::setPressedPart):
              (WebCore::Scrollbar::mouseMoved):
              (WebCore::Scrollbar::mouseExited):
              (WebCore::Scrollbar::mouseUp):
              (WebCore::Scrollbar::mouseDown):
              * platform/Scrollbar.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::setHoveredPart):
              (WebCore::RenderScrollbar::setPressedPart):
              (WebCore::RenderScrollbar::updateScrollbarParts):
              (WebCore::pseudoForScrollbarPart):
              (WebCore::RenderScrollbar::updateScrollbarPart):
              * rendering/RenderScrollbar.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9e710bb
    • cmarrin@apple.com's avatar
      2008-10-10 Chris Marrin <cmarrin@apple.com> · 274a8cfc
      cmarrin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
              CSS transition with duration=0 and delay=0 doesn't override ongoing transition
      
              Test: transitions/interrupt-zero-duration.html
      
              * page/animation/CompositeAnimation.cpp:
              (WebCore::CompositeAnimation::updateTransitions):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      274a8cfc
    • cmarrin@apple.com's avatar
      2008-10-09 Chris Marrin <cmarrin@apple.com> · 1386c1c3
      cmarrin@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=21310
      
              Redesigned how animation events are sent in order to get rid of
              AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
              are now ref counted. While calling the event handler, I keep a 
              reference to this class to avoid it getting destroyed out from under me.
      
              I also moved most of the functionality of CompositeAnimation to
              and internal class (CompositeAnimationPrivate) to reduce the exposure
              of the internals of the various animation classes.
      
              We have several transition and animation LayoutTests which verify that
              this fix works as expected and continues to avoid crashes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1386c1c3
    • kevino@webkit.org's avatar
      wx build fix. Add new scrollbar-related sources. · 0b227f8f
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b227f8f
    • hyatt@apple.com's avatar
      WebCore: · 676ab7fa
      hyatt@apple.com authored
      2008-10-10  David Hyatt  <hyatt@apple.com>
      
              https://bugs.webkit.org/show_bug.cgi?id=21522
      
              Support increment/decrement/start/end on scrollbars.  Allows a fully functional scrollbar to be
              created.  (Just :hover/:active left to finish it up.)
      
              Reviewed by Adam Roben
      
              Added scrollbars/scrollbar-buttons.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
      
      LayoutTests:
      
      2008-10-10  David Hyatt  <hyatt@apple.com>
      
              Add test for scrollbar buttons and track supporting increment/decrement/start/end.
      
              Reviewed by Adam Roben
      
              * platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
              * platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
              * platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
              * scrollbars/scrollbar-buttons.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      676ab7fa
    • hyatt@apple.com's avatar
      Land updated layout test after pseudoclass rename. · 12e8df61
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12e8df61
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · 0842521e
      hyatt@apple.com authored
              Rename some pseudoclasses.  Removing "-scrollbar-" from a bunch of the pseudoclasses.  Renaming
              back/forward to decrement/increment.  Adding start/end pseudoclasses.
      
              Reviewed by Eric Seidel
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0842521e
    • weinig@apple.com's avatar
      2008-10-10 Sam Weinig <sam@webkit.org> · 8e4ebd63
      weinig@apple.com authored
              Reviewed by Cameron Zwarich.
      
              Remove now unused m_getterSetterFlag variable from PropertyMap.
      
              * kjs/PropertyMap.cpp:
              (JSC::PropertyMap::operator=):
              * kjs/PropertyMap.h:
              (JSC::PropertyMap::PropertyMap):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e4ebd63
    • hyatt@apple.com's avatar
      Fix build. · c73c7f96
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c73c7f96
    • hyatt@apple.com's avatar
      2008-10-10 David Hyatt <hyatt@apple.com> · 216ac3bc
      hyatt@apple.com authored
              Switch window-active to window-inactive, since that will work better as far as degrading in other
              browsers.
      
              Reviewed by Tim Hatcher
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      216ac3bc
    • timothy@apple.com's avatar
      Yet another Tiger build fix. · f1a79801
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1a79801
    • hyatt@apple.com's avatar
      WebCore: · e3803263
      hyatt@apple.com authored
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add support for scrollbar orientation as a pseudoclass.  Add support for whether or not the scrollbar
              is active as well.
      
              Reviewed by Tim Hatcher
      
              Added scrollbars/scrollbar-orientation.html
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * platform/Scrollbar.cpp:
              (WebCore::Scrollbar::isWindowActive):
              * platform/Scrollbar.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::paint):
              (WebCore::RenderScrollbar::partForStyleResolve):
              * rendering/RenderScrollbar.h:
      
      LayoutTests:
      
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add layout test for scrollbars honoring orientation and window active state.
      
              Reviewed by Tim Hatcher
      
              * platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
              * platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
              * platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
              * scrollbars/scrollbar-orientation.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3803263
    • timothy@apple.com's avatar
      Another build fix. · f1790064
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1790064
    • timothy@apple.com's avatar
      Full build fix for the fail on Tiger. · 2e7f6ed7
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e7f6ed7
    • hyatt@apple.com's avatar
      WebCore: · e784a798
      hyatt@apple.com authored
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add support for pseudo classes on scrollbar pseudo elements.  As an initial proof of concept only
              :enabled/:disabled are supported.  More pseudo classes will follow quickly now that this works.
      
              Reviewed by Tim Hatcher
      
              Added scrollbars/disabled-scrollbar.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
              * css/CSSStyleSelector.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::getPseudoStyle):
              * rendering/RenderObject.h:
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::setEnabled):
              (WebCore::RenderScrollbar::scrollbarForStyleResolve):
              (WebCore::RenderScrollbar::getScrollbarPseudoStyle):
              (WebCore::RenderScrollbar::paintPart):
              * rendering/RenderScrollbar.h:
      
      LayoutTests:
      
      2008-10-09  David Hyatt  <hyatt@apple.com>
      
              Add test case for disabled scrollbars.
      
              Reviewed by Tim Hatcher
      
              * platform/mac/scrollbars/disabled-scrollbar-expected.checksum: Added.
              * platform/mac/scrollbars/disabled-scrollbar-expected.png: Added.
              * platform/mac/scrollbars/disabled-scrollbar-expected.txt: Added.
              * scrollbars/disabled-scrollbar.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e784a798
    • timothy@apple.com's avatar
      Tiger build fix. · 24eb4765
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24eb4765
    • eric.carlson@apple.com's avatar
      2008-10-09 Eric Carlson <eric.carlson@apple.com> · 24750589
      eric.carlson@apple.com authored
              Media controls should not show when element is not visible
      
              https://bugs.webkit.org/show_bug.cgi?id=21155
              
              Reviewed by Adele Peterson.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay
              in sync with visibility changes
              * html/HTMLMediaElement.h:
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible
              (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining
              if element is visible or not. Don't animate controller visibility when change triggered by
              showing or hiding media element.
              * rendering/RenderMedia.h: declare m_previousVisible
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24750589
    • hyatt@apple.com's avatar
      Fix Gtk bustage. · f8dab571
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8dab571
    • hyatt@apple.com's avatar
      Fix Qt bustage. · a8d323af
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8d323af
    • hyatt@apple.com's avatar
      Fix Windows bustage. · b1de17f9
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1de17f9