1. 16 Jan, 2014 36 commits
    • bburg@apple.com's avatar
      Web Inspector: add probe breakpoint action to popup breakpoint editor · 3285130b
      bburg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126931
      
      Reviewed by Timothy Hatcher.
      
      Add probes to the breakpoint action dropdown.
      Reuse the "evaluate JavaScript" input UI.
      
      * Localizations/en.lproj/localizedStrings.js:
      * UserInterface/BreakpointAction.js:
      * UserInterface/BreakpointActionView.js:
      (WebInspector.BreakpointActionView.displayStringForType):
      (WebInspector.BreakpointActionView.prototype._updateBody.switch.break):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3285130b
    • mmaxfield@apple.com's avatar
      text-emphasis-position CSS property doesn't recognize 'left' and 'right' · 88ce481c
      mmaxfield@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126611
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      This patch allows the text-emphasis-position to accept the "left" and
      "right" CSS values. In horizontal writing modes, these values no not
      change behavior. In vertical writing modes, however, these values specify
      which side to place the emphasis mark. Similarly, in vertical writing
      modes, the "above" and "below" values should not change behavior.
      
      However, in order to keep existing behavior, if neither "left" nor "right"
      is specified, we should draw as if the appropriate value were
      specified ("over" -> "right" and "under" -> "left"). Note that this
      will have to be updated when we implement the
      "text-orientation: sideways-left" CSS property.
      
      Tests: fast/text/emphasis-horizontal-left-right.html
             fast/text/emphasis-vertical-over-right.html
             fast/text/emphasis-vertical-over-under.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::renderEmphasisPositionFlagsToCSSValue):
      (WebCore::ComputedStyleExtractor::propertyValue):
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue):
      (WebCore::isKeywordPropertyID):
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseTextEmphasisPosition):
      * css/CSSParser.h:
      * css/CSSPrimitiveValueMappings.h:
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::valueToEmphasisPosition):
      (WebCore::ApplyPropertyTextEmphasisPosition::applyValue):
      (WebCore::ApplyPropertyTextEmphasisPosition::createHandler):
      (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
      (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
      (WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
      (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove):
      (WebCore::InlineTextBox::paint):
      * rendering/InlineTextBox.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      * rendering/style/StyleRareInheritedData.h:
      
      LayoutTests:
      
      With regards to text-emphasis-position, "left" and "right" are only valid in
      vertical writing modes, and "over" and "under" are only valid in horizontal
      writing modes.
      
      In order to keep in line with existing pages, specifying "under" without
      "left" or "right" should draw text as if "under left" was specified (and
      vice-versa).
      
      The default value for text-emphasis-position should be "over right".
      
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/parsing-text-emphasis-expected.txt:
      * fast/css/parsing-text-emphasis.html:
      * fast/text/emphasis-horizontal-left-right-expected.html: Added.
      * fast/text/emphasis-horizontal-left-right.html: Added.
      * fast/text/emphasis-vertical-over-right-expected.html: Added.
      * fast/text/emphasis-vertical-over-right.html: Added.
      * fast/text/emphasis-vertical-over-under-expected.html: Added.
      * fast/text/emphasis-vertical-over-under.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88ce481c
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · fd40c766
      m.pakula@samsung.com authored
      Add failure test expectations for tests introduced in r162117.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd40c766
    • oliver@apple.com's avatar
      Stop run-jsc from consuming stderr output · be8d090f
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127115
      
      Reviewed by Mark Lam.
      
      Simple patch to make run-jsc easier to deal with
      
      * Scripts/run-jsc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be8d090f
    • cfleizach@apple.com's avatar
      AX: WebKit is not firing AXMenuOpenedNotification · df8e67cf
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126993
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore: 
      
      To monitor for menu open notifications, we need to know which children are added to
      the render tree, so the childrenChanged() method has been updated to allow for that.
      Once we know the new child, we can then check what kind of role it has.
      
      I also found a flakiness issue with DRT where posting a notification back to DRT
      would sometimes cause a new notification to be queued, which would then be lost when the
      queue was cleared. This was fixed by copying the notifications to post before iterating them.
      
      Test: platform/mac/accessibility/aria-menu-open-notification.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::checkForOpenMenu):
      (WebCore::AXObjectCache::childrenChanged):
      (WebCore::AXObjectCache::notificationPostTimerFired):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::childrenChanged):
      * accessibility/AccessibilityNodeObject.h:
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::insertChildInternal):
      (WebCore::RenderElement::styleWillChange):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-menu-open-notification-expected.txt: Added.
      * platform/mac/accessibility/aria-menu-open-notification.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df8e67cf
    • zalan@apple.com's avatar
      Merged some more subpixel skipped tests. Unreviewed. · fbca66d8
      zalan@apple.com authored
      webkit.org/b/126891 is a duplicate of webkit.org/b/126892
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbca66d8
    • cfleizach@apple.com's avatar
      AX: WebKit is not firing AXMenuItemSelectedNotification · a890493f
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127081
      
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore: 
      
      Monitor for when a menu item either gains focus() or has aria-selected set,
      in which case, we need to fire a specific notification.
      
      Test: platform/mac/accessibility/aria-menu-item-selected-notification.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
          This method was declared in the header, but never implemented, leading to compilation issues.
      (WebCore::AXObjectCache::handleMenuItemSelected):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
          Allow the core class to handle focus changes first, then pass off to platform
      (WebCore::AXObjectCache::selectedChildrenChanged):
      * accessibility/AXObjectCache.h:
      * accessibility/ios/AXObjectCacheIOS.mm:
      (WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      (WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
          Allow menu items to expose a description attribute.
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt: Added.
      * platform/mac/accessibility/aria-menu-item-selected-notification.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a890493f
    • zalan@apple.com's avatar
      Subpixel layout: Enable subpixel layout for Apple Windows. · 1b18deb0
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127074
      
      Reviewed by Antti Koivisto.
      
      This should make the Apple Windows bots happier. It probably still needs rebaselining.
      
      * win/tools/vsprops/FeatureDefines.props:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b18deb0
    • m.pakula@samsung.com's avatar
      Unreviewed EFL gardening · 8d082742
      m.pakula@samsung.com authored
      Add failure test expectations for media tests.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d082742
    • commit-queue@webkit.org's avatar
      Fix unnecessary checks for Clang compiler if the compiler is MSVC. · a0c4beb0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127037
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
      Reviewed by Csaba Osztrogonác.
      
      Inside the #if defined(_MSC_VER) there's no need for checking whether the compiler is not Clang.
      
      * wtf/Compiler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0c4beb0
    • commit-queue@webkit.org's avatar
      Require at least GCC version 4.7 · e03edf62
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127049
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
      Reviewed by Csaba Osztrogonác.
      
      r161770 added a template alias, so the minimum GCC version is 4.7 now.
      
      Also fixed a typo in the error message about old MSVC version.
      
      * wtf/Compiler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e03edf62
    • commit-queue@webkit.org's avatar
      Tools/gtk/generate-feature-defines-files doesn't work with older versions of python · f4d2bc5d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126323
      
      Patch by Eva Balazsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2014-01-16
      Reviewed by Csaba Osztrogonác.
      
      * gtk/generate-feature-defines-files:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4d2bc5d
    • commit-queue@webkit.org's avatar
      [EFL] Rebaselining after r161404 · cb742adb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127105
      
      Unreviewed gardening.
      
      Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-01-16
      
      * platform/efl/editing/selection/after-line-wrap-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb742adb
    • m.pakula@samsung.com's avatar
      [EFL][WK2] Implement TestController::setHidden · 5281ca43
      m.pakula@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127036
      
      Reviewed by Gyuyoung Kim.
      
      WebKitTestRunner needs TestController::setHidden implementation to
      properly handle page visibility API layout tests after r161105.
      
      * WebKitTestRunner/efl/TestControllerEfl.cpp:
      (WTR::TestController::setHidden):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5281ca43
    • zandobersek@gmail.com's avatar
      [GTK][MiniBrowser] The progress entry reset callback can be fired after the... · 56112838
      zandobersek@gmail.com authored
      [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
      https://bugs.webkit.org/show_bug.cgi?id=127083
      
      Reviewed by Carlos Garcia Campos.
      
      When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
      The progress entry is then reset back to 0 in that callback and the timeout source is removed.
      
      The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
      assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
      To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
      BrowserWindow object is being finalized, preventing the callback from firing.
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (resetEntryProgress):
      (webViewLoadProgressChanged):
      (browserWindowFinalize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56112838
    • commit-queue@webkit.org's avatar
      Expose scrollView on WKView · 9688e28e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127085
      
      Patch by Ian Henderson <ianh@apple.com> on 2014-01-16
      Reviewed by Antti Koivisto.
      
      Expose WKView's scroll view as a property.  In order to support
      clients calling setDelegate:, we create a forwarder object that sends
      delegate methods to both WKView (the "internal delegate") and the
      publicly-exposed delegate (the "external delegate").
      
      * UIProcess/API/Cocoa/WKView.h:
      * UIProcess/API/ios/WKScrollView.h:
      * UIProcess/API/ios/WKScrollView.mm:
      (-[WKScrollViewDelegateForwarder initWithInternalDelegate:externalDelegate:]):
      (-[WKScrollViewDelegateForwarder methodSignatureForSelector:]):
      (-[WKScrollViewDelegateForwarder respondsToSelector:]):
      (-[WKScrollViewDelegateForwarder forwardInvocation:]):
      (-[WKScrollView setInternalDelegate:]):
      (-[WKScrollView setDelegate:]):
      (-[WKScrollView delegate]):
      Pretend like _externalDelegate is the real delegate to avoid exposing
      our internal delegate or forwarder object.
      (-[WKScrollView _updateDelegate]):
      (-[WKScrollView dealloc]):
      * UIProcess/API/ios/WKViewIOS.mm:
      (-[WKView scrollView]):
      (-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9688e28e
    • aestes@apple.com's avatar
      [iOS] Fix build issues with exported headers · 5d86e980
      aestes@apple.com authored
      Source/WebCore:
      
      * Configurations/WebCore.xcconfig: Allowed UIKit to link against
      WebCore.
      * page/ios/WebEventRegion.h: Removed ENABLE(TOUCH_EVENTS), which are
      always enabled on iOS.
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj: Removed WebPluginPrivate.h from
      the project.
      
      Source/WebKit/ios:
      
      * Misc/WebNSStringExtrasIOS.h: Changed PLATFORM(IOS) to
      TARGET_OS_IPHONE.
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperationsPrivate.h: Changed PLATFORM(IOS) to
      TARGET_OS_IPHONE.
      * MigrateHeaders.make: Excluded WAKScrollView.h from normal replacement
      rules so that WebCoreFrameScrollView won't inadvertently get changed to
      WebKitFrameScrollView.
      * Plugins/WebPlugin.h: Moved contents of WebPluginPrivate.h to here in
      order to maintain source compatibility.
      * Plugins/WebPluginController.mm: Removed an import of WebPluginPrivate.h.
      * Plugins/WebPluginPrivate.h: Removed.
      * Storage/WebDatabaseManagerPrivate.h: Replaced ENABLE(SQL_DATABASE)
      with ENABLE_SQL_DATABASE.
      * WebView/WebViewPrivate.h: Added declaration of
      -[WebView _touchEventRegions] for source compatibility.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d86e980
    • krit@webkit.org's avatar
      Rename functions in SVGDocumentExtension · 2c9916ff
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127046
      
      Reviewed by Sam Weinig.
      
      Change some function names in SVGDocumentExtension
      to make them more descriptive.
      
      Simple refactoring. No new tests.
      
      * rendering/svg/RenderSVGResourceContainer.cpp:
      (WebCore::RenderSVGResourceContainer::registerResource):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::SVGDocumentExtensions::addPendingResource):
      (WebCore::SVGDocumentExtensions::isIdOfPendingResource):
      (WebCore::SVGDocumentExtensions::isElementWithPendingResources):
      (WebCore::SVGDocumentExtensions::isPendingResource):
      (WebCore::SVGDocumentExtensions::clearHasPendingResourcesIfPossible):
      (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
      (WebCore::SVGDocumentExtensions::removePendingResource):
      (WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
      (WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
      (WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemovalMap): The name is not great but a bit more descriptive.
      * svg/SVGDocumentExtensions.h:
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::buildPendingResourcesIfNeeded):
      * svg/SVGMPathElement.cpp:
      (WebCore::SVGMPathElement::buildPendingResource):
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::buildPendingResource):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::buildPendingResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9916ff
    • carlosgc@webkit.org's avatar
      [GTK][EFL][NIX] Do not use PrintContext, Frame and DocumentLoader in Errors · 56a8ee6f
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127047
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Using PrintContext, Frame and DocumentLoader in platform is a
      layering violation.
      Change printing error methods to receive a failing URL instead of
      receiving a PrintContext that was used only to get the failing
      URL.
      
      * platform/efl/ErrorsEfl.cpp:
      (WebCore::printError):
      (WebCore::printerNotFoundError):
      (WebCore::invalidPageRangeToPrint):
      * platform/efl/ErrorsEfl.h:
      * platform/gtk/ErrorsGtk.cpp:
      (WebCore::printError):
      (WebCore::printerNotFoundError):
      (WebCore::invalidPageRangeToPrint):
      * platform/gtk/ErrorsGtk.h:
      * platform/nix/ErrorsNix.cpp:
      (WebCore::printError):
      (WebCore::printerNotFoundError):
      (WebCore::invalidPageRangeToPrint):
      * platform/nix/ErrorsNix.h:
      
      Source/WebKit2:
      
      * WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
      (WebKit::WebPrintOperationGtk::frameURL): Helper function to get
      the URL of the frame being printed.
      (WebKit::WebPrintOperationGtk::print): Use frameURL() as failing
      URL for printing errors.
      * WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56a8ee6f
    • mihnea@adobe.com's avatar
      [CSS Regions] Enable accelerated compositing for fixed elements in named flows · c38e7d63
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125144
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Add support for compositing for fixed positioned element that are collected
      inside a named flow. Prior to this patch, the fixed positioned elements were
      positioned and sized properly but only in the non-compositing scenario.
      
      Tests: compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html
             compositing/regions/fixed-in-diff-named-flows-zIndex.html
             compositing/regions/fixed-in-named-flow-clip-descendant.html
             compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html
             compositing/regions/fixed-in-named-flow-from-outflow.html
             compositing/regions/fixed-in-named-flow-got-transformed-parent.html
             compositing/regions/fixed-in-named-flow-lost-transformed-parent.html
             compositing/regions/fixed-in-named-flow-overlap-composited.html
             compositing/regions/fixed-in-named-flow-position-changed.html
             compositing/regions/fixed-in-named-flow-transformed-parent.html
             compositing/regions/fixed-in-named-flow-zIndex.html
             compositing/regions/fixed-in-named-flow.html
             compositing/regions/fixed-transformed-in-named-flow.html
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::regionForCompositedLayer):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed):
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      (WebCore::RenderLayerCompositor::rebuildCompositingLayerTreeForNamedFlowFixed):
      (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
      (WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
      (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
      * rendering/RenderLayerCompositor.h:
      * rendering/RenderNamedFlowFragment.h:
      * rendering/RenderNamedFlowThread.h:
      
      LayoutTests:
      
      Added new tests and made the existing tests for fixed positioned elements use the
      non-compositing mode.
      
      * compositing/regions/abs-in-named-flow-from-fixed-in-named-flow-expected.txt: Added.
      * compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html: Added.
      * compositing/regions/fixed-in-diff-named-flows-zIndex-expected.html: Added.
      * compositing/regions/fixed-in-diff-named-flows-zIndex.html: Added.
      * compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-clip-descendant.html: Added.
      * compositing/regions/fixed-in-named-flow-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html: Added.
      * compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-from-outflow.html: Added.
      * compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-got-transformed-parent.html: Added.
      * compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-lost-transformed-parent.html: Added.
      * compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-overlap-composited.html: Added.
      * compositing/regions/fixed-in-named-flow-position-changed-expected.html: Added.
      * compositing/regions/fixed-in-named-flow-position-changed.html: Added.
      * compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Added.
      * compositing/regions/fixed-in-named-flow-transformed-parent.html: Added.
      * compositing/regions/fixed-in-named-flow-zIndex-expected.html: Added.
      * compositing/regions/fixed-in-named-flow-zIndex.html: Added.
      * compositing/regions/fixed-in-named-flow.html: Added.
      * compositing/regions/fixed-transformed-in-named-flow-expected.txt: Added.
      * compositing/regions/fixed-transformed-in-named-flow.html: Added.
      * fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html:
      * fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html:
      * fast/regions/repaint/element-inflow-fixed-from-outflow-static.html:
      * fast/regions/repaint/element-outflow-static-from-inflow-fixed.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c38e7d63
    • benjamin@webkit.org's avatar
      Fix the iOS build after r162114 · c183b40b
      benjamin@webkit.org authored
      Unreviewed.
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-15
      
      Source/WebCore: 
      
      * WebCore.exp.in: Move the symbol to the right section and add the missing symbols for iOS.
      
      Source/WebKit/mac: 
      
      * WebView/WebViewPrivate.h: I forgot to remove the declaration, fix that.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c183b40b
    • commit-queue@webkit.org's avatar
      [CSS Regions] Fix painting when the composited region has overflow:hidden · 12d101b3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124887
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2014-01-15
      Reviewed by Alexandru Chiculita.
      
      Source/WebCore:
      
      When the layer of the region is composited, the region receives a GraphicsLayer of its own
      so the clipping coordinates (caused by overflow:hidden) must be relative to the
      GraphicsLayer coordinates in which the region gets painted.
      
      Also, while the painting is done relative to the location of the region's content box, the
      clipping is bound to the padding box of the region.
      
      Tests: compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html
             compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintFlowThreadIfRegion):
      
      LayoutTests:
      
      * compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html: Added.
      * compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div-expected.html: Added.
      * compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html: Added.
      * compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region-expected.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12d101b3
    • benjamin@webkit.org's avatar
      Move user agent code to WebCore and unify some code between OS X and iOS · f7017ebc
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127080
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-15
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Move the duplicated code from WebView and WebPageProxy to two files
      in WebCore: UserAgentMac and UserAgentIOS.
      
      * Configurations/WebCore.xcconfig:
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * page/ios/UserAgentIOS.mm: Added.
      (WebCore::platformSystemRootDirectory):
      (WebCore::osMarketingVersion):
      (WebCore::standardUserAgentWithApplicationName):
      * page/mac/UserAgent.h: Added.
      * page/mac/UserAgentMac.mm: Added.
      (WebCore::systemMarketingVersionForUserAgentString):
      (WebCore::standardUserAgentWithApplicationName):
      * platform/ios/WebCoreSystemInterfaceIOS.h:
      * platform/ios/WebCoreSystemInterfaceIOS.mm:
      
      Source/WebKit/mac: 
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      * WebView/WebView.mm:
      (userVisibleWebKitVersionString):
      (+[WebView _standardUserAgentWithApplicationName:]):
      (-[WebView _setUIWebViewUserAgentWithBuildVersion:]):
      
      Source/WebKit2: 
      
      * UIProcess/ios/WebPageProxyIOS.mm:
      (WebKit::userVisibleWebKitVersionString):
      (WebKit::WebPageProxy::standardUserAgent):
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::standardUserAgent):
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7017ebc
    • weinig@apple.com's avatar
      Fix windows build. · 23c1f09a
      weinig@apple.com authored
      * platform/text/TextAllInOne.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23c1f09a
    • commit-queue@webkit.org's avatar
      [iOS] Clean up REMOTE_INSPECTOR code in OpenSource after the iOS merge · 3bffb341
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127069
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-15
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      Export XPCConnection because it is needed by RemoteInspector.h.
      
      * inspector/remote/RemoteInspectorXPCConnection.h:
      * inspector/remote/RemoteInspector.h:
      * inspector/remote/RemoteInspector.mm:
      (Inspector::RemoteInspector::startDisabled):
      (Inspector::RemoteInspector::shared):
      Allow RemoteInspector singleton to start disabled.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
      (+[WebView _enableRemoteInspector]):
      (+[WebView _disableRemoteInspector]):
      (+[WebView _disableAutoStartRemoteInspector]):
      (+[WebView _isRemoteInspectorEnabled]):
      (+[WebView _hasRemoteInspectorSession]):
      (-[WebView allowsRemoteInspection]):
      Implement with RemoteInspector.h SPIs.
      
      (-[WebView setAllowsRemoteInspection:]):
      (-[WebView setHostApplicationBundleId:name:]):
      Still unimplemented, update comment.
      
      (-[WebView _didCommitLoadForFrame:]):
      Remove dead path, WebCore now pushes updates on navigations.
      
      * WebView/WebViewData.h:
      * WebView/WebViewData.mm:
      (-[WebViewPrivate init]):
      Remove now unused ivar.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bffb341
    • eunmi15.lee@samsung.com's avatar
      [EFL][WK2] Use timestamp when event occurs for touch events. · ce9f665e
      eunmi15.lee@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126424
      
      Reviewed by Gyuyoung Kim.
      
      Current time is used for touch event's timestamp instead of timestamp
      when event occurs. Timestamp of touch event is used to implement flick
      gesture, so it should be real value for accurate gesture processing.
      
      * UIProcess/API/efl/EwkView.cpp:
      Function names for handling touch events are changed to distinguish
      mouse events and multi events.
      (EwkView::setTouchEventsEnabled):
      (EwkView::feedTouchEvents):
      (EwkView::handleMouseDownForTouch):
      (EwkView::handleMouseUpForTouch):
      (EwkView::handleMouseMoveForTouch):
      (EwkView::handleMultiDownForTouch):
      (EwkView::handleMultiUpForTouch):
      (EwkView::handleMultiMoveForTouch):
      * UIProcess/API/efl/EwkView.h:
      * UIProcess/API/efl/GestureRecognizer.cpp:
      (WebKit::GestureHandler::handlePan):
      (WebKit::GestureRecognizer::processTouchEvent):
      (WebKit::GestureRecognizer::noGesture):
      (WebKit::GestureRecognizer::singleTapGesture):
      (WebKit::GestureRecognizer::doubleTapGesture):
      (WebKit::GestureRecognizer::panGesture):
      (WebKit::GestureRecognizer::pinchGesture):
      * UIProcess/API/efl/GestureRecognizer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce9f665e
    • ryuan.choi@samsung.com's avatar
      Unreviewed. EFL Gardening. · 47c8a176
      ryuan.choi@samsung.com authored
      * platform/efl-wk1/TestExpectations:
      Unskipped some tests in svg/dynamic-updates which are passing now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47c8a176
    • weinig@apple.com's avatar
      TextBreakIterator's should support Latin-1 for all iterator types (Part 2) · 00738f73
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126856
      
      Reviewed by Ryosuke Niwa.
      
      Move the contents of TextBreakIteratorICU.cpp to TextBreakIterator.cpp and remove TextBreakIteratorICU.cpp.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * PlatformGTK.cmake:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/text/TextBreakIterator.cpp:
      * platform/text/TextBreakIteratorICU.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00738f73
    • eric.carlson@apple.com's avatar
      MediaSessionManager shouldn't use std::map · ff361d51
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127003
      
      Reviewed by Sam Weinig.
      
      No new tests, no functional change.
      
      Use an array instead of std::map.
      * platform/audio/MediaSessionManager.cpp:
      (WebCore::MediaSessionManager::MediaSessionManager):
      (WebCore::MediaSessionManager::addRestriction):
      (WebCore::MediaSessionManager::removeRestriction):
      (WebCore::MediaSessionManager::restrictions):
      (WebCore::MediaSessionManager::sessionWillBeginPlayback):
      * platform/audio/MediaSessionManager.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff361d51
    • barraclough@apple.com's avatar
      Change Page, FocusController to use ViewState · 5b401454
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126533
      
      Unreviewed rollout, this caused a regression.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * page/FocusController.cpp:
      (WebCore::FocusController::FocusController):
      (WebCore::FocusController::setFocused):
      (WebCore::FocusController::setActive):
      (WebCore::FocusController::setContentIsVisible):
      * page/FocusController.h:
      (WebCore::FocusController::isActive):
      (WebCore::FocusController::isFocused):
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::setIsInWindow):
      (WebCore::Page::setIsVisuallyIdle):
      (WebCore::Page::setIsVisible):
      (WebCore::Page::visibilityState):
      (WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
      * page/Page.h:
      (WebCore::Page::isVisible):
      (WebCore::Page::isInWindow):
      
      Source/WebKit2: 
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      (WebKit::WebPage::setActive):
      (WebKit::WebPage::setViewIsVisible):
      (WebKit::WebPage::setFocused):
      (WebKit::WebPage::setIsInWindow):
      (WebKit::WebPage::setViewStateInternal):
      (WebKit::WebPage::setIsVisuallyIdle):
      * WebProcess/WebPage/WebPage.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b401454
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=127072 · 009890cf
      commit-queue@webkit.org authored
      Don't autorelease wrapper object (WebProcessPlugInScriptWorld) for InjectedBundleScriptWorld::normalWorld().
      
      Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-15
      Reviewed by Geoffrey Garen.
      
      In [WKWebProcessPlugInScriptWorld normalWorld], InjectedBundleScriptWorld::normalWorld() returns a static
      instance,  autoreleasing its wrapper object could cause a dangling pointer and crash later.
      
      * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:
      (+[WKWebProcessPlugInScriptWorld normalWorld]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      009890cf
    • bfulgham@apple.com's avatar
      [WebGL] Resizing and entering/exiting full screen draws garbage · cd775a44
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127077
      
      Reviewed by Dean Jackson.
      
      * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
      (WebCore::GraphicsContext3D::reshapeFBOs): Simplified logic regarding FBO switching.
      (WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Make sure a few things
      are turned off that might affect blitting data from one FBO to another.
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::prepareTexture): Actually turn dithering off!
      (WebCore::GraphicsContext3D::reshape): Mark the context as dirty when resizing so that
      the GL view is redrawn during resizing events.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd775a44
    • aestes@apple.com's avatar
      [iOS] Properly exclude the shim dylibs this time · 3054cfe4
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127075
      
      Reviewed by Anders Carlsson.
      
      BaseLegacyProcess.xcconfig was setting EXCLUDED_SOURCE_FILE_NAMES in
      conflict with what I added in r161918, and I misspelled the setting
      name in two instances. Fix these two bugs.
      
      Also remove a vestigial OTHER_LDFLAGS from WebContentProcess.xcconfig
      while we're here.
      
      * Configurations/BaseLegacyProcess.xcconfig:
      * Configurations/NetworkProcess.xcconfig:
      * Configurations/PluginProcess.xcconfig:
      * Configurations/WebContentProcess.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3054cfe4
    • enrica@apple.com's avatar
      Support WebSelections in WK2 on iOS. · fa2c59e4
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127015
      
      Reviewed by Benjamin Poulain.
      
      This is the first step towards adding support for selections in
      non editable content on iOS for WK2.
      In particular, this patch adds the basic plumbing to decide which
      gesture recognizers are enabled and adds empty stubs for the gestures
      that we'll need to support.
      There are two separate assistants for selections, one to be used
      in editable text (UIWKTextInteractionAssistant) and one for non editable
      text (UIWKSelectionAssistant) and they are mutually exclusive.
      UIWKSelectionAssistant is created at the time the view is created, 
      and swapped with UIWKTextInteraction assistant
      only when an editable element is focused and the keyboard appears on screen.
      
      gestureRecognizerShouldBegin is the delegate call used to decide which gestures
      should begin based on the position the gesture occurred at.
      We want to avoid as much as possible synchronous calls to the WebProcess to
      retrieve information about the content and in order to do so, we take advantage
      of the order in which the gesture recognizers will trigger, based on the delay
      configured at initialization.
      The first gesture to trigger is highlightLongPress, followed by longpress in the
      active assistant and longpress in the WKInteractionView.
      There are two different scenarios for highlighlongpress based on which assistant is
      currently active.
      
      UIWKSelectionAssistant is active:
          We send a request to the WebProcess to get information on the position
          and we return YES, allowing the gesture to start.
          We delegate to the WebProcess the proper handling of highlight based on the element.
          When longPress gesture fires for the assistant, we assume we have received the reply to our
          previous request, if not we fetch the information synchronously.
          We are then able to make an informed decision about whether
          or not to start the gesture. If the reply is NO, the third and last long press
          gesture can be evaluated to decide whether to show the action sheet or simply generate
          a click event.
      
      UIWKTextInteractionAssistant is active:
          In this case we must have information about the position immediately and we issue
          a synchronous request to the WebProcess.
          If we are not interacting with the same node, we return NO.
          Then the longpress gesture fires for the assistant which performs the same check.
          If the node is the same, the loupe gesture will start, otherwise the last longpress
          gesture will be evaluated to decide about showing the action sheet or generating a
          click event.
      
      * Scripts/webkit2/messages.py:
      * Shared/InteractionInformationAtPosition.cpp: Added.
      (WebKit::InteractionInformationAtPosition::encode):
      (WebKit::InteractionInformationAtPosition::decode):
      * Shared/InteractionInformationAtPosition.h: Added.
      (WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):
      * UIProcess/API/ios/PageClientImplIOS.h:
      * UIProcess/API/ios/PageClientImplIOS.mm:
      (WebKit::PageClientImpl::positionInformationDidChange):
      * UIProcess/API/ios/WKContentView.mm:
      (-[WKContentView _positionInformationDidChange:]):
      * UIProcess/API/ios/WKContentViewInternal.h:
      * UIProcess/API/ios/WKInteractionView.h:
      * UIProcess/API/ios/WKInteractionView.mm:
      (-[WKInteractionView initWithFrame:]):
      (-[WKInteractionView dealloc]):
      (-[WKInteractionView gestureRecognizer:canPreventGestureRecognizer:]):
      (-[WKInteractionView gestureRecognizer:canBePreventedByGestureRecognizer:]):
      (isSamePair):
      (-[WKInteractionView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
      (-[WKInteractionView _showImageSheet]):
      (-[WKInteractionView _showLinkSheet]):
      (-[WKInteractionView _actionForLongPress]):
      (-[WKInteractionView ensurePositionInformationIsUpToDate:]):
      (-[WKInteractionView gestureRecognizerShouldBegin:]):
      (-[WKInteractionView hasSelectablePositionAtPoint:]):
      (-[WKInteractionView pointIsInAssistedNode:]):
      (-[WKInteractionView _longPressRecognized:]):
      (-[WKInteractionView _doubleTapRecognized:]):
      (-[WKInteractionView _twoFingerDoubleTapRecognized:]):
      (-[WKInteractionView _twoFingerPanRecognized:]):
      (-[WKInteractionView useSelectionAssistantWithMode:]):
      (-[WKInteractionView _positionInformationDidChange:]):
      (-[WKInteractionView interactionAssistant]):
      (-[WKInteractionView _startAssistingKeyboard]):
      (-[WKInteractionView _stopAssistingKeyboard]):
      * UIProcess/PageClient.h:
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/ios/WebPageProxyIOS.mm:
      (WebKit::WebPageProxy::didReceivePositionInformation):
      (WebKit::WebPageProxy::getPositionInformation):
      (WebKit::WebPageProxy::requestPositionInformation):
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/ios/WebPageIOS.mm:
      (WebKit::WebPage::selectWithGesture):
      (WebKit::WebPage::getPositionInformation):
      (WebKit::WebPage::requestPositionInformation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa2c59e4
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=127066 · ca4bc74e
      commit-queue@webkit.org authored
      Add WKBrowsingContextHandle.h to WebKit2 private headers.
      
      Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-15
      Reviewed by Dan Bernstein.
      
      Add WKBrowsingContextHandle.h to WebKit2 private headers so that WebKit2 client
      can use WKBrowsingContextHandle class.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca4bc74e
    • roger_fong@apple.com's avatar
      Remove unnecessary call to webGLContextCreated · 62d728fb
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127000
      
      Reviewed by Brent Fulgham.
      
      Source/WebCore:
      
      Note that the functionality of webGLContextCreated will be handled by webGLPolicyForSite now.
      
      Tests: Unskipping tests skipped in r162002.
      
      * html/HTMLCanvasElement.cpp: Remove webGLContextCreated call.
      (WebCore::HTMLCanvasElement::getContext):
      * loader/FrameLoaderClient.h:
      Have the returned load policy default to WebGLAllow so as to not break clients that don't implement the method.
      (WebCore::FrameLoaderClient::webGLPolicyForSite):
      webGLPolicyForSite is now assuming the role of webGLContextCreated as well, pass in the whole site URL instead of just the host.
      * page/ChromeClient.h: Remove webGLContextCreated method.
      (WebCore::ChromeClient::decrementActivePageCount):
      
      LayoutTests:
      
      * platform/mac/TestExpectations: Unskipping tests skipped in r162002.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62d728fb
  2. 15 Jan, 2014 4 commits
    • bdakin@apple.com's avatar
      Repeating background images should continue into margin tiles · 8ce430bf
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127021
      -and corresponding-
      <rdar://problem/15571300>
      
      Reviewed by Simon Fraser.
      
      This patch makes repeating background images continue into margin tiles. 
      
      RenderObject::repaintRectangle() now takes an addition bool parameter which 
      indicates whether or not the repaint rect should be clipped to the layer size.
      * WebCore.exp.in:
      
      These new functions on FrameView provide a way for code in the render tree to know 
      if the TiledBacking has a margin. tiledBacking() is now const. It should have 
      always been const, and it needs to be const to make these new functions const.
      * page/FrameView.cpp:
      (WebCore::FrameView::tiledBacking):
      (WebCore::FrameView::hasExtendedBackground):
      (WebCore::FrameView::extendedBackgroundRect):
      * page/FrameView.h:
      * platform/ScrollableArea.h:
      (WebCore::ScrollableArea::tiledBacking):
      
      If we’re painting the root background and it is an extended background, we need to 
      inflate the repaint rect to span the extended background. 
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::repaintLayerRectsForImage):
      
      To get the phase right on repeated background images on a page with margin tiles, 
      we need to make sure we factor the size of the margin tiles into the left and top 
      values that we use when calculating background image geometry.
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
      
      setBackingNeedsRepaintInRect() now takes GraphicsLayer::ShouldClipToLayer as a 
      parameter, just like setBackingNeedsRepaint(). 
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::calculateClipRects):
      
      setContentsNeedDisplayInRect() also takes a GraphicsLayer::ShouldClipToLayer now, 
      and it passes that information down to the GraphicsLayer.
      * rendering/RenderLayer.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
      * rendering/RenderLayerBacking.h:
      
      These two RenderObject functions now take an optional bool parameter which 
      indicates whether or not the rect should be clipped to the layer size. They use a 
      bool instead of the GraphicsLayer enum in order to avoid including GraphicsLayer.h 
      from within RenderObject.h. This seems like a simpler solution than adding a new 
      stand-alone file for this very simple enum.
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::repaintUsingContainer):
      (WebCore::RenderObject::repaintRectangle):
      * rendering/RenderObject.h:
      
      RenderView::backgroundRect needs to return the extendedBackgroundRect when it had 
      one.
      * rendering/RenderView.cpp:
      (WebCore::RenderView::backgroundRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ce430bf
    • commit-queue@webkit.org's avatar
      toStringVector static function definition should not be redundant. · 13fd9185
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126872.
      
      Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-15
      Reviewed by Anders Carlsson.
      
      toStringVector function was declared twice in InjectedBundle.cpp and WebPageGroup.cpp as static.
      In order to remove redundant definition this function was moved into API::Array.
      
      * Shared/APIArray.cpp:
      (API::Array::toStringVector):
      * Shared/APIArray.h:
      * UIProcess/WebPageGroup.cpp:
      (WebKit::WebPageGroup::addUserStyleSheet):
      (WebKit::WebPageGroup::addUserScript):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::addUserScript):
      (WebKit::InjectedBundle::addUserStyleSheet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13fd9185
    • bburg@apple.com's avatar
      Web Inspector: capture probe samples on the backend · 18911405
      bburg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126668
      
      Reviewed by Joseph Pecoraro.
      
      Source/JavaScriptCore:
      
      Add the 'probe' breakpoint action to the protocol. Change the setBreakpoint
      commands to return a list of assigned breakpoint action identifiers
      Add a type for breakpoint action identifiers. Add an event for sending
      captured probe samples to the inspector frontend.
      
      * inspector/protocol/Debugger.json:
      
      Source/WebCore:
      
      Test: inspector-protocol/debugger/setProbe-multiple-actions.html
      
      Add the probe breakpoint action type. A probe action
      evaluates an expression on the script call frame, and
      the result is aggregated on a per-probe basis. Each
      evaluated expression result is called a probe sample.
      
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::evaluateBreakpointAction): Teach
      the debug server to evaluate a probe.
      
      (WebCore::ScriptDebugServer::dispatchDidSampleProbe): Added.
      (WebCore::ScriptDebugServer::handleBreakpointHit): Increment a hit count.
      (WebCore::ScriptDebugServer::getActionsForBreakpoint):
      * bindings/js/ScriptDebugServer.h:
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::objectGroupForBreakpointAction): Added. Create an object
      group for each breakpoint action. Currently only probes make objects.
      (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
      (WebCore::InspectorDebuggerAgent::disable):
      (WebCore::InspectorDebuggerAgent::enable): Remove stale comment.
      (WebCore::breakpointActionTypeForString): Add new case.
      (WebCore::InspectorDebuggerAgent::breakpointActionsFromProtocol): Make
      this a member function instead of a static function, so it can increment
      the breakpoint action identifier counter.
      (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): Propagate the
      assigned breakpoint action identifiers.
      (WebCore::InspectorDebuggerAgent::setBreakpoint): Propagate the
      assigned breakpoint action identifiers.
      (WebCore::InspectorDebuggerAgent::removeBreakpoint): Release object
      groups for any actions that were associated with the removed breakpoint.
      (WebCore::InspectorDebuggerAgent::didSampleProbe): Added.
      (WebCore::InspectorDebuggerAgent::clearResolvedBreakpointState): Renamed from clear().
      (WebCore::InspectorDebuggerAgent::didClearGlobalObject): Renamed from reset().
      * inspector/InspectorDebuggerAgent.h:
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
      * inspector/ScriptBreakpoint.h:
      (WebCore::ScriptBreakpointAction::ScriptBreakpointAction): Add identifier member.
      * inspector/ScriptDebugListener.h:
      
      Source/WebInspectorUI:
      
      * UserInterface/InspectorJSBackendCommands.js: Add probe enumeration value.
      
      LayoutTests:
      
      Add protocol tests for setting and hitting the probe breakpoint action type.
      
      * inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
      * inspector-protocol/debugger/setBreakpoint-actions.html:
      * inspector-protocol/debugger/setProbe-multiple-actions-expected.txt: Added.
      * inspector-protocol/debugger/setProbe-multiple-actions.html: Added.
      * inspector-protocol/resources/probe-helper.js: Added.
      (ProbeHelper.simplifiedProbeSample):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18911405
    • ap@apple.com's avatar
      More iOS build fixing. · 6641b197
      ap@apple.com authored
      * WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
      Removed a now unused local variable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6641b197