1. 22 Sep, 2011 40 commits
    • barraclough@apple.com's avatar
      Function.prototype.bind.length shoudl be 1. · 31ca2376
      barraclough@apple.com authored
      Rubber stamped by Olier Hunt.
      
      Source/JavaScriptCore: 
      
      * runtime/FunctionPrototype.cpp:
      (JSC::FunctionPrototype::addFunctionProperties):
      
      LayoutTests: 
      
      * fast/js/function-bind-expected.txt:
      * fast/js/script-tests/function-bind.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31ca2376
    • fpizlo@apple.com's avatar
      PPC build fix. · 8f85803f
      fpizlo@apple.com authored
      * bytecode/CodeBlock.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f85803f
    • barraclough@apple.com's avatar
      Windows build fix pt. 2 · ddb51db4
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddb51db4
    • barraclough@apple.com's avatar
      Windows build fix pt. 1 · 65406f63
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65406f63
    • ossy@webkit.org's avatar
      [Qt][Mac]Unreviewed gardening. · b805e628
      ossy@webkit.org authored
      New Qt specific results were added by r95723, but they fail on Qt-Mac platform
      
      * platform/qt-mac/Skipped: Skip css3/selectors3 tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b805e628
    • simon.fraser@apple.com's avatar
      Add APIObjects for Size, Point, Rect · 5520f1ee
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68644
      
      Reviewed by Sam Weinig.
      
      Make APIObjects for size, point and rect so that they can be
      used in WKArrayRefs.
      
      Make some inline helper methods to create WKSize, WKPoint and WKRect
      types.
      
      * GNUmakefile.am:
      * Shared/API/c/WKBase.h:
      * Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.
      (WKSizeGetTypeID):
      (WKPointGetTypeID):
      (WKRectGetTypeID):
      (WKPointCreate):
      (WKSizeCreate):
      (WKRectCreate):
      (WKSizeGetValue):
      (WKPointGetValue):
      (WKRectGetValue):
      * Shared/API/c/WKGeometry.h:
      (WKPoint::WKPointMake):
      (WKPoint::WKSizeMake):
      (WKPoint::WKRectMake):
      * Shared/API/c/WKSharedAPICast.h:
      * Shared/APIObject.h:
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageEncoder::baseEncode):
      (WebKit::UserMessageDecoder::baseDecode):
      * Shared/WebGeometry.h: Added.
      (WebKit::WebSize::create):
      (WebKit::WebSize::size):
      (WebKit::WebSize::WebSize):
      (WebKit::WebSize::type):
      (WebKit::WebPoint::create):
      (WebKit::WebPoint::point):
      (WebKit::WebPoint::WebPoint):
      (WebKit::WebPoint::type):
      (WebKit::WebRect::create):
      (WebKit::WebRect::rect):
      (WebKit::WebRect::WebRect):
      (WebKit::WebRect::type):
      * WebKit2.pro:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebKit2API.pri:
      * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5520f1ee
    • fpizlo@apple.com's avatar
      DFG JIT does not support to_primitive or strcat · 90e5f0ea
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68582
      
      Reviewed by Darin Adler.
              
      This adds functional support for to_primitive and strcat. It focuses
      on minimizing the amount of code emitted on to_primitive (if we know
      that it is a primitive or can speculate cheaply, then we omit the
      slow path) and on keeping the implementation of strcat simple while
      leveraging whatever optimizations we have already. In particular,
      unlike the Call and Construct nodes which require extending the size
      of the DFG's callee registers, StrCat takes advantage of the fact
      that no JS code can run while StrCat is in progress and uses a
      scratch buffer, rather than the register file, to store the list of
      values to concatenate. This was done mainly to keep the code simple,
      but there are probably other benefits to keeping call frame sizes
      down. Essentially, this patch ensures that the presence of an
      op_strcat does not mess up any other optimizations we might do while
      ensuring that if you do execute it, it'll work about as well as you'd
      expect.
              
      When combined with the previous patch for integer division, this is a
      14% speed-up on Kraken. Without it, it would have been a 2% loss.
      
      * assembler/AbstractMacroAssembler.h:
      (JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.h:
      (JSC::DFG::canCompileOpcode):
      * dfg/DFGJITCodeGenerator.h:
      (JSC::DFG::JITCodeGenerator::callOperation):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
      * dfg/DFGNode.h:
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      (JSC::DFG::Propagator::performNodeCSE):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      (JSC::JSGlobalData::~JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSC::JSGlobalData::scratchBufferForSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90e5f0ea
    • jonlee@apple.com's avatar
      Progress control gets cropped on the bottom · cabbc295
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68302
      <rdar://problem/10069915>
      
      Reviewed by Kent Tamura.
      
      As it turns out the smaller control type does not get rendered either, so this patch
      fixes both.
      
      * manual-tests/dom/progressbar.html: Altered to show both sizes of controls
      * rendering/RenderThemeMac.h:
      * rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect
      (WebCore::RenderThemeMac::progressBarSizes):
      (WebCore::RenderThemeMac::progressBarMargins):
      (WebCore::RenderThemeMac::minimumProgressBarHeight):
      (WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
      control height and glow margin.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cabbc295
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68658 · a10d30e1
      hyatt@apple.com authored
      Make matchedEndLine smart enough to not match lines that have moved to new
      regions with different available content logical widths. When this happens, we go ahead and treat
      the line as failing to match.
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Added new tests in fast/regions.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
      * rendering/RenderBlock.h:
      Enhanced to take an optional delta, so that you can check a new position without having to move
      the line box.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
      New function that refactors checking for line width changes from region movement as well as the
      float checks. Since the float checks were duplicated twice, this is a nice refactoring.
      
      (WebCore::RenderBlock::matchedEndLine):
      Changed to call the new helper function that will check both floats and pagination.
      
      LayoutTests: 
      
      * fast/regions/webkit-flow-inlines-dynamic.html: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a10d30e1
    • andersca@apple.com's avatar
      EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:] · 199b7c23
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68660
      
      Reviewed by Adam Barth.
      
      * WebKitTestRunner/mac/EventSenderProxy.mm:
      (WTR::EventSenderProxy::mouseUp):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      199b7c23
    • fpizlo@apple.com's avatar
      DFG JIT should support integer division · de08b63c
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68597
      
      Reviewed by Darin Adler.
              
      This adds support for ArithDiv speculating integer, and speculating
      that the result is integer (i.e. remainder = 0).
              
      This is a 4% win on Kraken and a 1% loss on V8.
      
      * bytecode/CodeBlock.h:
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::makeDivSafe):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasArithNodeFlags):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateArithNodeFlags):
      (JSC::DFG::Propagator::propagateNodePredictions):
      (JSC::DFG::Propagator::fixupNode):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * jit/JITArithmetic.cpp:
      (JSC::JIT::emit_op_div):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de08b63c
    • oliver@apple.com's avatar
      Implement put_scoped_var in the DFG jit · b47299f2
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68653
      
      Reviewed by Gavin Barraclough.
      
      Naive implementation of put_scoped_var.  Same story as the
      get_scoped_var implementation, although I've hoisted scope
      object acquisition into a separate dfg node.  Ideally in the
      future we would reuse the resolved scope chain object, but
      for now we don't.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.h:
      (JSC::DFG::canCompileOpcode):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasScopeChainDepth):
      (JSC::DFG::Node::scopeChainDepth):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b47299f2
    • abarth@webkit.org's avatar
      Skip test that need new baselines. · 4cbb40c7
      abarth@webkit.org authored
      * platform/mac/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cbb40c7
    • barraclough@apple.com's avatar
      Implement Function.prototype.bind · 22215665
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=26382
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      This patch provides a basic functional implementation
      for Function.bind. It should (hopefully!) be fully
      functionally correct, and the bound functions can be
      called to quickly (since they are a subclass of
      JSFunction, not InternalFunction), but we'll probably
      want to follow up with some optimization work to keep
      bound calls in JIT code.
      
      * JavaScriptCore.JSVALUE32_64only.exp:
      * JavaScriptCore.JSVALUE64only.exp:
      * JavaScriptCore.exp:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * jit/JITStubs.cpp:
      (JSC::JITThunks::hostFunctionStub):
      * jit/JITStubs.h:
      * jsc.cpp:
      (GlobalObject::addFunction):
      * runtime/CommonIdentifiers.h:
      * runtime/ConstructData.h:
      * runtime/Executable.h:
      (JSC::NativeExecutable::NativeExecutable):
      * runtime/FunctionPrototype.cpp:
      (JSC::FunctionPrototype::addFunctionProperties):
      (JSC::functionProtoFuncBind):
      * runtime/FunctionPrototype.h:
      * runtime/JSBoundFunction.cpp: Added.
      (JSC::boundFunctionCall):
      (JSC::boundFunctionConstruct):
      (JSC::JSBoundFunction::create):
      (JSC::JSBoundFunction::hasInstance):
      (JSC::JSBoundFunction::getOwnPropertySlot):
      (JSC::JSBoundFunction::getOwnPropertyDescriptor):
      (JSC::JSBoundFunction::JSBoundFunction):
      (JSC::JSBoundFunction::finishCreation):
      * runtime/JSBoundFunction.h: Added.
      (JSC::JSBoundFunction::targetFunction):
      (JSC::JSBoundFunction::boundThis):
      (JSC::JSBoundFunction::boundArgs):
      (JSC::JSBoundFunction::createStructure):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::create):
      (JSC::JSFunction::finishCreation):
      (JSC::createDescriptorForThrowingProperty):
      (JSC::JSFunction::getOwnPropertySlot):
      * runtime/JSFunction.h:
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::getHostFunction):
      * runtime/JSGlobalData.h:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::boundFunctionStructure):
      * runtime/Lookup.cpp:
      (JSC::setUpStaticFunctionSlot):
      
      Source/WebCore: 
      
      Test: fast/js/function-bind.html
      
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::objectToStringFunctionGetter):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::nonCachingStaticFunctionGetter):
      * bindings/js/JSHistoryCustom.cpp:
      (WebCore::nonCachingStaticBackFunctionGetter):
      (WebCore::nonCachingStaticForwardFunctionGetter):
      (WebCore::nonCachingStaticGoFunctionGetter):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::nonCachingStaticReplaceFunctionGetter):
      (WebCore::nonCachingStaticReloadFunctionGetter):
      (WebCore::nonCachingStaticAssignFunctionGetter):
          - Function::create no longer requires functionStructure() to be passed.
      
      LayoutTests: 
      
      We now pass Function.bind tests.
      
      * fast/js/Object-getOwnPropertyNames-expected.txt:
      * fast/js/basic-strict-mode-expected.txt:
      * fast/js/function-bind-expected.txt: Added.
      * fast/js/function-bind.html: Added.
      * fast/js/mozilla/strict/15.3.4.5-expected.txt:
      * fast/js/script-tests/function-bind.js: Added.
      * ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
      * ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22215665
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68650 · 0c6cd7ae
      hyatt@apple.com authored
              
      Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
      region with a different available content logical width. When this happens, we go ahead and treat
      the line as dirty.
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Covered by existing fast/regions tests.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlock):
      Disable region fitting if we detect that the regions all have uniform widths. In this case we know
      the content width can't vary, so there's no reason to waste time worrying about it.
      
      (WebCore::RenderBlock::computeLogicalLocationForFloat):
      Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
      region fitting into the fixed offsets now rather than the line functions.
      
      (WebCore::RenderBlock::positionNewFloats):
      Changed because more code moved from here into computeLogicalLocationForFloat.
              
      (WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
      No changes. Just moved the function above the left offset function.
      
      (WebCore::RenderBlock::logicalLeftOffsetForContent):
      (WebCore::RenderBlock::logicalRightOffsetForContent):
      Added. These new functions give the fixed left and right offsets for lines in a particular region.
      When no regions are present or when all the regions have a uniform width, they are identical
      to the versions of the functions that take no arguments.
      
      (WebCore::RenderBlock::logicalRightOffsetForLine):
      Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.
      
      (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
      New function that takes a root line box and compares its cached old content width with the width
      available at the line's new location.
          
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::logicalRightOffsetForLine):
      (WebCore::RenderBlock::logicalLeftOffsetForLine):
      Modified to call the logicalXXXOffsetForContent functions that take a block direction position.
      
      (WebCore::RenderBlock::logicalRightOffsetForContent):
      (WebCore::RenderBlock::logicalLeftOffsetForContent):
      Added the new functions that take a position so that they can fit to the correct region.
      
      (WebCore::RenderBlock::availableLogicalWidthForContent):
      New helper function that calls right - left (similar to the corresponding line function that includes
      floats).
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::determineStartPosition):
      Patched to check if a line has moved to a place with a different available content width. If so, the line
      is dirtied so that line layout can re-run.
      
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox):
      (WebCore::RootInlineBox::alignBoxesInBlockDirection):
      Sets the paginated line width from the current block logical height.
      
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox::paginationStrut):
      (WebCore::RootInlineBox::setPaginationStrut):
      Fixed paginationStrut to be LayoutUnit instead of int.
      
      (WebCore::RootInlineBox::paginatedLineWidth):
      (WebCore::RootInlineBox::setPaginatedLineWidth):
      Added paginatedLineWidth getter/setter for caching the content width for a given root line.
      
      LayoutTests: 
      
      * platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
      * platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c6cd7ae
    • andersca@apple.com's avatar
      Remove Widget::beforeMouseDown and Widget::afterMouseDown · 5f0ce69a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68570
      
      Reviewed by Darin Adler.
      
      These two member functions were originally added to avoid crashes due to removing NSViews while they were
      being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
      AppKit that lead to crashes have been fixed.
      
      This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
      m_sendingEventToSubview to false.
      
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passMouseDownEventToWidget):
      * platform/Widget.h:
      * platform/mac/WidgetMac.mm:
      (WebCore::Widget::Widget):
      (WebCore::Widget::removeFromSuperview):
      
      * rendering/RenderWidget.cpp:
      Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f0ce69a
    • ap@apple.com's avatar
      [WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it · 2d0fed9a
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=68573
      
              Reviewed by Anders Carlsson.
      
              Re-landing with a slightly less aggressive check.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d0fed9a
    • robert@webkit.org's avatar
      Platform-specific results for test introduced by r95726 · d99b5d5c
      robert@webkit.org authored
      * platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
      * platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
      * platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d99b5d5c
    • rniwa@webkit.org's avatar
      Unreviewed, rolling out r95335 and r95645. · b70a5770
      rniwa@webkit.org authored
      http://trac.webkit.org/changeset/95335
      http://trac.webkit.org/changeset/95645
      https://bugs.webkit.org/show_bug.cgi?id=68649
      
      Wrong fix (Requested by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22
      
      Source/WebCore: 
      
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::saveTypingStyleState):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::removeStyleAddedByNode):
      * editing/EditingStyle.h:
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::serializeNodes):
      (WebCore::ancestorToRetainStructureAndAppearance):
      * editing/markup.h:
      
      LayoutTests: 
      
      * editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
      * editing/deleting/merge-paragraph-from-address.html: Removed.
      * editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
      * editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
      * editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
      * editing/deleting/merge-paragraph-from-h6.html: Removed.
      * editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
      * editing/deleting/merge-paragraph-from-listing.html: Removed.
      * editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
      * editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
      * editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
      * editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
      * editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
      * editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
      * editing/deleting/merge-paragraph-into-h1.html: Removed.
      * editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
      * editing/deleting/merge-paragraph-into-pre.html: Removed.
      * platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
      * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b70a5770
    • robert@webkit.org's avatar
      Unreviewed, update expected results after r95726 · d2076147
      robert@webkit.org authored
      * platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
      * platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
      * platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
      * platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
      * platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
      * platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2076147
    • rniwa@webkit.org's avatar
      Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard. · 38bca254
      rniwa@webkit.org authored
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passMouseDownEventToWidget):
      * platform/Widget.h:
      * platform/mac/WidgetMac.mm:
      (WebCore::Widget::Widget):
      (WebCore::Widget::removeFromSuperview):
      (WebCore::Widget::beforeMouseDown):
      (WebCore::Widget::afterMouseDown):
      * rendering/RenderWidget.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38bca254
    • oliver@apple.com's avatar
      Implement get_scoped_var in the DFG · 4bf42b39
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68640
      
      Reviewed by Gavin Barraclough.
      
      Naive implementation of get_scoped_var in the DFG.  Essentially this
      is the bare minimum required to get correct behaviour, so there's no
      load/store coalescing or type profiling involved, even though these
      would be wins.  No impact on SunSpider or V8.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGCapabilities.h:
      (JSC::DFG::canCompileOpcode):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasVarNumber):
      (JSC::DFG::Node::hasScopeChainDepth):
      (JSC::DFG::Node::scopeChainDepth):
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf42b39
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68645 · f9427307
      hyatt@apple.com authored
              
      Fix the layout test fast/regions directory. Remove platform-specific results that were
      incorrectly checked in to cross-platform locations and add missing pixel test results.
      
      Reviewed by Beth Dakin.
      
      * fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
      * fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
      * fast/regions/flows-dependency-same-flow-expected.txt: Removed.
      * fast/regions/render-region-renderer-expected.txt: Removed.
      * fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
      * fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
      * fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
      * fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
      * fast/regions/webkit-flow-renderer-expected.txt: Removed.
      * fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
      * fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
      * platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
      * platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
      * platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
      * platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
      * platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
      * platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
      * platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
      * platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
      * platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
      * platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
      * platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
      * platform/mac/fast/regions/no-split-line-box-expected.png: Added.
      * platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
      * platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
      * platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9427307
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68638 · 501174db
      hyatt@apple.com authored
              
      Make RenderFlowThread cache whether or not it has regions of varying widths. This will
      be relevant for performance as we begin adding code to do custom block painting and
      layout based off regions not having the same width.
      
      Reviewed by Dan Bernstein and Adam Roben.
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::RenderFlowThread):
      (WebCore::RenderFlowThread::layout):
      * rendering/RenderFlowThread.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      501174db
    • andersca@apple.com's avatar
      FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects · 9d12f46e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68639
      
      Reviewed by David Hyatt.
      
      FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
      member functions that take IntRects, and Widget coordinates are currently defined in terms of
      IntRects (and probably always should since we want them to be pixel-aligned).
      
      * page/FrameView.cpp:
      (WebCore::FrameView::invalidateRect):
      (WebCore::FrameView::setFrameRect):
      * page/FrameView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d12f46e
    • timothy_horton@apple.com's avatar
      Unreviewed build fix (fixes warning about too many parens). · 894b4d0d
      timothy_horton@apple.com authored
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      894b4d0d
    • andersca@apple.com's avatar
      Widget::frameRect shouldn't be virtual · c9daffe7
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68637
      
      Reviewed by Sam Weinig.
      
      Nobody overrides Widget::frameRect and nobody should.
      
      * platform/Widget.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9daffe7
    • aroben@apple.com's avatar
      Remove FindSafari · 345ff7f8
      aroben@apple.com authored
      It isn't used or built anymore.
      
      Fixes <http://webkit.org/b/68628>
      
      Reviewed by Darin Adler.
      
      * FindSafari: Removed this directory and its contents.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      345ff7f8
    • aroben@apple.com's avatar
      Remove FindSafari from all our .sln files · 725b81b6
      aroben@apple.com authored
      It isn't used anymore, so there's no point in building it.
      
      Part of <http://webkit.org/b/68628> Remove FindSafari
      
      Reviewed by Steve Falkenburg.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcproj/JavaScriptCore.sln:
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.sln:
      * WebKitTestRunner/WebKitTestRunner.sln:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      725b81b6
    • aroben@apple.com's avatar
      Remove all uses of FindSafari · 9b58dbcf
      aroben@apple.com authored
      It isn't really needed anymore.
      
      Fixes <http://webkit.org/b/68626>.
      
      Reviewed by Darin Adler.
      
      * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
      
      * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
      WebKit, but now we use WebKit.exe for that.
      
      * Scripts/webkitdirs.pm:
      (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
      do the same thing.
      
      (readRegistryString):
      (writeRegistryString):
      Moved here from old-run-webkit-tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b58dbcf
    • aroben@apple.com's avatar
      Use the "direct object" form of system() to run WebKit.exe · 4c31791e
      aroben@apple.com authored
      This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
      path to WebKit.exe.
      
      Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
      %WEBKITOUTPUTDIR%
      
      Reviewed by Steve Falkenburg.
      
      * Scripts/webkitdirs.pm:
      (runSafari):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c31791e
    • aroben@apple.com's avatar
      Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath · 90015dba
      aroben@apple.com authored
      Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
      spaces in the path to the WebKit source tree
      
      Reviewed by John Sullivan.
      
      * Scripts/webkitdirs.pm:
      (setupCygwinEnv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90015dba
    • aroben@apple.com's avatar
      Add testRegExp.vcproj to WebKit.sln · a817667c
      aroben@apple.com authored
      Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj
      
      Reviewed by Brian Weinstein.
      
      * WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it
      does when built as part of JavaScriptCore.sln.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a817667c
    • vestbo@webkit.org's avatar
      [Qt] Use same DPI for application font as rest of app in DRT and WTR · 45d3c27f
      vestbo@webkit.org authored
      QApplication will initialize the default application font based
      on the application DPI at construction time, but we then override
      the application DPI using QX11Info (hard-coding it to 96 for
      consistency). This hard-coding is not reflected in the application
      font, so we explicitly have update the font ourselves.
      
      The 6 test results that are updated were originally produced with
      a DPI of 75, as this is the default fallback DPI when a QFont is
      constructed before QApplication. This was wrong, and the results
      are updated to match a DPI of 96.
      
      Reviewed by Csaba Osztrogonác.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d3c27f
    • commit-queue@webkit.org's avatar
      Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback · 199ac39b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68630
      
      Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-22
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Test: fast/canvas/webgl/shader-deleted-by-accessor.html
      
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::JSWebGLRenderingContext::getAttachedShaders):
      * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
      (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::getAttachedShaders):
      * html/canvas/WebGLRenderingContext.h:
      
      LayoutTests:
      
      * fast/canvas/webgl/shader-deleted-by-accessor-expected.txt: Added.
      * fast/canvas/webgl/shader-deleted-by-accessor.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      199ac39b
    • robert@webkit.org's avatar
      Unreviewed, platform-specific results for r95721. · bf0109ed
      robert@webkit.org authored
      * platform/mac/fast/css/outline-narrowLine-expected.txt: Added.
      * platform/gtk/fast/css/outline-narrowLine-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf0109ed
    • robert@webkit.org's avatar
      CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000 · 7861a106
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=47148
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::startAlignedOffsetForLine):
            Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
            Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html
      * rendering/RenderBox.cpp:
      (WebCore::computeInlineStaticDistance):
          - The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the
            containing block's direction) when computing static distance. The container block's direction
            is still used in the other width and offset related calculations.
          - In the context of this function, the logicalRight value is just an element that will be used later to calculate
            the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft()
            in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get
            logicalLeft in computePositionedLogicalWidthUsing().
      
      (WebCore::RenderBox::computePositionedLogicalWidth):
         - Update comments and use the container block's direction except when calculating the static distance.
         - Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced
           blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.
      (WebCore::RenderBox::computePositionedLogicalWidthUsing):
         - Update comments and use the container block's direction except when calculating the static distance.
      (WebCore::RenderBox::computePositionedLogicalHeight):
         - Update comments.
      (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
         - Update comments and use the container block's direction except when calculating the static distance.
         - If the containing block is RTL, always assume that values are over-constrained.
      (WebCore::RenderBox::computePositionedLogicalHeightReplaced):
         - Update comments.
      
      LayoutTests:
      
      * platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
      * platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
        New results for CSS 2.1 reference tests. These match exactly the reference test results.
      
      * fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html: Added.
      * platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
      * platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
        New test for left,right and center alignment of inline LTR and RTL blocks. FF and Opera don't pass this test.
      
      * fast/block/positioning/absolute-position-direction-strict.html: Removed.
      * fast/block/positioning/absolute-position-direction.html: Renamed from LayoutTests/fast/block/positioning/absolute-position-direction-quirk.html.
      * platform/chromium-linux/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/absolute-position-direction-quirk-expected.png.
      * platform/chromium-linux/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
      * platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.png.
      * platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
      * platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
      * platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
      * platform/gtk/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.png.
      * platform/gtk/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
      * platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
      * platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
      * platform/mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/block/positioning/absolute-position-direction-quirk-expected.png.
      * platform/mac-leopard/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
      * platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
      * platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
      * platform/mac/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.png.
      * platform/mac/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
      * platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
      * platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
      * platform/qt/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.png.
      * platform/qt/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
      * platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
      * platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
        These tests are superseded by abspos-non-replaced-width-margin-000.htm. Using the parent() block's
        direction to compute static distance is now a strict requirement for CSS 2.1, rather than an IE quirk.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7861a106
    • andersca@apple.com's avatar
      Get rid of Widget::setBoundsSize · 98f7e26b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68491
      
      Reviewed by Sam Weinig.
      
      This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
      which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
      anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
      will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::open):
      * page/FrameView.cpp:
      (WebCore::FrameView::create):
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::visibleContentRect):
      (WebCore::ScrollView::updateScrollbars):
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollView.h:
      * platform/Widget.cpp:
      * platform/Widget.h:
      (WebCore::Widget::resize):
      * platform/chromium/PopupContainer.cpp:
      (WebCore::PopupContainer::refresh):
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::ScrollView::visibleContentRect):
      * platform/mac/WidgetMac.mm:
      (WebCore::Widget::paint):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::setWidgetGeometry):
      (WebCore::RenderWidget::setWidget):
      (WebCore::RenderWidget::updateWidgetPosition):
      * rendering/RenderWidget.h:
      
      Source/WebKit/mac: 
      
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView updateAndSetWindow]):
      * WebView/WebFrameView.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98f7e26b
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=68590 · b1e912bf
      hyatt@apple.com authored
              
      Floats pushed to next page, column or region don't reposition properly if the amount of
      available logical width at the new position changes. Refactor the code so that we can
      run the float placement algorithm again when this happens.
      
      Source/WebCore: 
      
      Covered by an existing regions test that exposes the issue.
      
      Reviewed by Adam Roben.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeLogicalLocationForFloat):
      (WebCore::RenderBlock::positionNewFloats):
      * rendering/RenderBlock.h:
      
      LayoutTests: 
      
      Reviewed by Adam Roben.
      
      * fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1e912bf
    • ossy@webkit.org's avatar
      [Qt] Unreviewed. Add Qt specific expected results for css3/selectors3 tests. · 3d5cf758
      ossy@webkit.org authored
      All of them pass, they are compared to mac png results manually.
      
      * platform/qt/Skipped:
      * platform/qt/css3/selectors3/ [...]: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d5cf758