1. 03 Mar, 2010 37 commits
    • dumi@chromium.org's avatar
      Fix a bug that could lead to a crash. Some parts of · 3187f511
      dumi@chromium.org authored
      SQLTransaction::checkAndHandleClosedDatabase() should only be run
      when that method is invoked on the DB thread.
      
      Reviewed by Dimitri Glazkov.
      
      We cannot test this fix with a test, because the crash happens
      only when all of the following conditions are met:
      1. A database is closing.
      2. A transaction on that database is in progress.
      3. The transaction is in a state where a statement/transaction
      success/error callback needs to be invoked (so there's a task for
      this transaction pending on the main thread).
      4. The DB thread finished processing all its tasks and called
      SQLTransactionCoordinator::shutdown() before the main thread go to
      that task.
      
      The closest thing we have to a test is running
      LayoutTests/storage/database-lock-after-reload.html 1000 times in
      a row. Without the patch, the probability of a crash happening in
      one of the runs is very high. With the patch, the test should
      reliably run 1000 times in a row without a single crash.
      
      https://bugs.webkit.org/show_bug.cgi?id=35624
      
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::checkAndHandleClosedDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3187f511
    • darin@chromium.org's avatar
      2010-03-03 Darin Fisher <darin@chromium.org> · c273e671
      darin@chromium.org authored
              Reviewed by Mark Rowe.
      
              Page should not care about Chromium plug-in implementation details
              https://bugs.webkit.org/show_bug.cgi?id=35623
      
              * WebCore.gypi: Compile PluginViewNone.cpp
              * page/Page.cpp:
              (WebCore::Page::privateBrowsingStateChanged): Remove conditional
              compilation for PLATFORM(CHROMIUM).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c273e671
    • levin@chromium.org's avatar
      2010-03-03 David Levin <levin@chromium.org> · fb077e5f
      levin@chromium.org authored
              No review, rolling out r55474.
              http://trac.webkit.org/changeset/55480
      
              The patch broke fast/frames/sandboxed-iframe-storage.html
      
              * Android.jscbindings.mk:
              * Android.v8bindings.mk:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * dom/Document.cpp:
              (WebCore::Document::postTask):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::openDatabase):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * storage/Database.cpp:
              (WebCore::Database::openDatabase):
              (WebCore::Database::Database):
              (WebCore::Database::performOpenAndVerify):
              * storage/Database.h:
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::openDatabase):
              * workers/WorkerContext.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb077e5f
    • levin@chromium.org's avatar
      2010-03-03 David Levin <levin@chromium.org> · 1bc093fb
      levin@chromium.org authored
              No review, rolling out r55480.
              http://trac.webkit.org/changeset/55480
      
              The patch broke fast/frames/sandboxed-iframe-storage.html
      
              * storage/Database.cpp:
              * storage/Database.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bc093fb
    • mrowe@apple.com's avatar
      Add virtual memory tags for TCMalloc and WebCore's purgeable buffers. · 2b0fad29
      mrowe@apple.com authored
      Reviewed by Geoff Garen.
      
      JavaScriptCore:
      
      * wtf/TCSystemAlloc.cpp:
      (TryMmap): Use the VM tag.
      * wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
      
      WebCore:
      
      * platform/mac/PurgeableBufferMac.cpp:
      (WebCore::PurgeableBuffer::create):  Use the VM tag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b0fad29
    • ap@apple.com's avatar
      Not reviewed. · 801ded60
      ap@apple.com authored
              Try better to fix Java tests on Tiger bot.
      
              * platform/mac-tiger/Skipped:
              * platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed.
              This test gets different resultson each run when it fails, so it needs to be disabled on
              Tiger.
      
              * platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a
              newline I didn't get when copying actual results from buildbot.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      801ded60
    • cmarrin@apple.com's avatar
    • dumi@chromium.org's avatar
      Move #include "DatabaseCallback.h" from Database.h to · ae4b74f0
      dumi@chromium.org authored
      Database.cpp.
      
      Reviewed by nobody, build fix.
      
      * storage/Database.cpp:
      * storage/Database.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae4b74f0
    • ossy@webkit.org's avatar
      [Qt] Skip new test introduced in r55474, because of · b2625d66
      ossy@webkit.org authored
      missing layoutTestController.evaluateScriptInIsolatedWorld()
      
      * platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2625d66
    • darin@apple.com's avatar
      Fixed Mac build. · 8adba0d3
      darin@apple.com authored
      * WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
      be used in the WebKit project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8adba0d3
    • ap@apple.com's avatar
      Rubber-stamped by Dan Bernstein. · 0525fe5e
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35700
              Some of the newly added Java tests fail randomly on buildbot
      
              * fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first
              wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests
              dump results after "TEST COMPLETE", and we need to get bots back to green fast.
      
              * java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of
              execution in this case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0525fe5e
    • sfalken@apple.com's avatar
      Rubber stamped by Adam Roben. · 26a5a25b
      sfalken@apple.com authored
      Fix bogus xcopy that was polluting source tree at build time.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26a5a25b
    • ap@apple.com's avatar
      Reviewed by Adele Peterson. · 9a3ec0a6
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35044
              Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
      
              I'm often getting a crash even when opening the test for the first time in Safari, but it
              doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
              this condition, so no new regression test.
      
              * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining
              input will pause parsing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a3ec0a6
    • dumi@chromium.org's avatar
      WebCore: Adding support for the optional creation callback that could be · 2d346ae6
      dumi@chromium.org authored
      passed to openDatabase().
      
      Reviewed by Adam Barth.
      
      Test: storage/open-database-creation-callback.html
      
      https://bugs.webkit.org/show_bug.cgi?id=34726
      
      * Android.jscbindings.mk
      * Android.v8bindings.mk
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::openDatabase):
      * bindings/js/JSDatabaseCallback.cpp: Added.
      (WebCore::JSDatabaseCallback::JSDatabaseCallback):
      (WebCore::JSDatabaseCallback::~JSDatabaseCallback):
      (WebCore::JSDatabaseCallback::handleEvent):
      * bindings/js/JSDatabaseCallback.h: Added.
      (WebCore::JSDatabaseCallback::create):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::openDatabaseCallback):
      * bindings/v8/custom/V8DatabaseCallback.cpp: Added.
      (WebCore::V8DatabaseCallback::V8DatabaseCallback):
      (WebCore::V8DatabaseCallback::~V8DatabaseCallback):
      (WebCore::V8DatabaseCallback::handleEvent):
      * bindings/v8/custom/V8DatabaseCallback.h: Added.
      (WebCore::V8DatabaseCallback::create):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::openDatabase):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * storage/Database.cpp:
      (WebCore::DatabaseCreationCallbackTask::create):
      (WebCore::DatabaseCreationCallbackTask::performTask):
      (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
      (WebCore::Database::openDatabase):
      (WebCore::Database::Database):
      (WebCore::Database::performOpenAndVerify):
      (WebCore::Database::performCreationCallback):
      * storage/Database.h:
      (WebCore::Database::isNew):
      * storage/DatabaseCallback.h: Added.
      (WebCore::DatabaseCallback::~DatabaseCallback):
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::openDatabase):
      * workers/WorkerContext.h:
      
      LayoutTests: Adding a test to test the creation callback passed to
      openDatabase() and another one to make sure it is executed in the
      correct world.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=34726
      
      * storage/open-database-creation-callback-expected.txt: Added.
      * storage/open-database-creation-callback.html: Added.
      * storage/open-database-creation-callback-isolated-world-expected.txt: Added.
      * storage/open-database-creation-callback-isolated-world.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d346ae6
    • cmarrin@apple.com's avatar
      35f875b4
    • bweinstein@apple.com's avatar
      Touch WebKit.idl to force a rebuild · 3852e2c5
      bweinstein@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3852e2c5
    • ap@apple.com's avatar
      Not reviewed. · 9b2c01fb
      ap@apple.com authored
              Two newly added Java tests fail on Tiger build bot.
      
              Just land actual results as expected. I don't even know which behavior is more correct.
      
              * platform/mac-tiger/java: Added.
              * platform/mac-tiger/java/lc3: Added.
              * platform/mac-tiger/java/lc3/JavaArray: Added.
              * platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added.
              * platform/mac-tiger/java/lc3/JavaObject: Added.
              * platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b2c01fb
    • ap@apple.com's avatar
      Reviewed by Timothy Hatcher. · 0c647c45
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35692
              <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
      
              * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
              Retain the challenge, just like it's done for sheet.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c647c45
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · fd21c99f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35617
              Import Mozilla LiveConnect 3 test suite
      
              * java/lc3/sources: Added (many files). Sources for Mozilla test applet.
      
              * java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to
              modify the above sources.
      
              * java/lc3.java: Added.
              (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but
              WebKit needs an actual applet to call into Java.
              (lc3.createQAObject): Instantiate a class defined in jstests.jar by name.
              (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally
              relied on window.java package interface to do this, but it's not available in WebKit. We
              need more functions like this to work around other uses of window.java, but this is one I
              wrote for now.
      
              * java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests
              other than ones imported here, but it's also harmless, and I don't know how to write good
              makefiles.
      
              * java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL
              results should not be generally relied upon. All html wrappers are identical.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd21c99f
    • eric.carlson@apple.com's avatar
      2010-03-03 Eric Carlson <eric.carlson@apple.com> · a22e7d94
      eric.carlson@apple.com authored
              Unreviewed, build fix.
      
              Update expected results for fast/js/custom-constructors-expected.txt
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a22e7d94
    • cmarrin@apple.com's avatar
    • apavlov@chromium.org's avatar
      2010-03-03 Alexander Pavlov <apavlov@chromium.org> · 6c34e6d6
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: resources panel only shows uncompressed resource size.
              https://bugs.webkit.org/show_bug.cgi?id=35403
      
              * English.lproj/localizedStrings.js:
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              * inspector/front-end/AbstractTimelinePanel.js:
              (WebInspector.AbstractTimelinePanel.prototype.refresh):
              * inspector/front-end/AuditRules.js:
              (WebInspector.AuditRules.GzipRule.prototype.doRun):
              (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
              * inspector/front-end/ImageView.js:
              (WebInspector.ImageView):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get resourceSize):
              (WebInspector.Resource.prototype.set resourceSize):
              (WebInspector.Resource.prototype.get transferSize):
              (WebInspector.Resource.CompareBySize):
              (WebInspector.Resource.CompareByTransferSize):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.populateSidebar):
              (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
              (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
              (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages):
              (WebInspector.ResourceTransferSizeCalculator.prototype._value):
              (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes):
              (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize):
              (WebInspector.ResourceGraph.prototype.refreshLabelPositions):
              (WebInspector.ResourceGraph.prototype.refresh):
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c34e6d6
    • mitz@apple.com's avatar
      Build fix. · 829eca9c
      mitz@apple.com authored
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      829eca9c
    • pfeldman@chromium.org's avatar
      2010-03-03 Pavel Feldman <pfeldman@chromium.org> · 6ad21836
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
      
              https://bugs.webkit.org/show_bug.cgi?id=32331
      
              * inspector/InspectorBackend.cpp:
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled):
              (WebInspector.ProfilesPanel.prototype._updateInterface):
              (WebInspector.ProfilesPanel.prototype._enableProfiling):
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
              (WebInspector.ScriptsPanel.prototype._enableDebugging):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad21836
    • eric.carlson@apple.com's avatar
      2010-03-03 Eric Carlson <eric.carlson@apple.com> · 9f8dbf40
      eric.carlson@apple.com authored
              Reviewed by Adele Peterson.
      
              Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
              https://bugs.webkit.org/show_bug.cgi?id=35385
              rdar://problem/7689602
      
              Tests: media/audio-constructor-preload.html
                     media/video-dom-preload.html
      
              * html/HTMLAttributeNames.in: Remove autobuffer, add preload
      
              * html/HTMLAudioElement.cpp:
              (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of 
                  autobuffer to true.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload.
              (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute.
              (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
                  before calling load() so it can pass the setting through to the media engine.
              (WebCore::HTMLMediaElement::preload): New.
              (WebCore::HTMLMediaElement::setPreload): Ditto
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload.
              (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine.
              (WebCore::MediaPlayer::preload): New, return m_preload.
              (WebCore::MediaPlayer::setPreload): New, set m_preload.
              * platform/graphics/MediaPlayer.h:
              (WebCore::MediaPlayer::):
              * platform/graphics/MediaPlayerPrivate.h:
              (WebCore::MediaPlayerPrivateInterface::setPreload):
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
      
      2010-03-03  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson.
      
              Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
              https://bugs.webkit.org/show_bug.cgi?id=35385
              rdar://problem/7689602
      
              * media/audio-constructor-autobuffer-expected.txt: Removed.
              * media/audio-constructor-autobuffer.html: Removed.
              * media/audio-constructor-preload-expected.txt: Added.
              * media/audio-constructor-preload.html: Added.
              * media/video-dom-autobuffer-expected.txt: Removed.
              * media/video-dom-autobuffer.html: Removed.
              * media/video-dom-preload-expected.txt: Added.
              * media/video-dom-preload.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f8dbf40
    • mitz@apple.com's avatar
      <rdar://problem/7682756> Assertion failure when replacing the contents of a <select> · 1aa6c4d3
      mitz@apple.com authored
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      Test: fast/dom/remove-children-notification-order.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
      before calling removedFromDocument() on each removed child, which matches
      the order removeChild() does things, and avoids the assertion. This required
      temporarily storing the removed children in a vector.
      Also added comments about other discrepancies between this function and
      removeChild().
      
      LayoutTests: 
      
      * fast/dom/remove-children-notification-order-expected.txt: Added.
      * fast/dom/remove-children-notification-order.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa6c4d3
    • abarth@webkit.org's avatar
      2010-03-03 Adam Barth <abarth@webkit.org> · 7d9798f1
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Document cookieURL and firstPartyForCookies
              https://bugs.webkit.org/show_bug.cgi?id=35613
      
              Some folks asked what the cookieURL and the firstPartyForCookies were
              on IRC.  This patch documents these properties in the code so folks
              don't have to ask on IRC anymore.
      
              * dom/Document.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d9798f1
    • eric@webkit.org's avatar
      2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> · fc979642
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Refactor QtLauncher so it respects command line arguments
              and inherits settings when you clone or create a new window.
      
              Implemented with help of Kenneth Rohde Christiansen.
      
              [Qt] QtLauncher must be refactored to fix command line arguments usage
              https://bugs.webkit.org/show_bug.cgi?id=35536
      
              * QtLauncher/main.cpp:
              (LauncherWindow::LauncherWindow):
              (LauncherWindow::init):
              (LauncherWindow::isGraphicsBased):
              (applySetting):
              (LauncherWindow::applyPrefs):
              (LauncherWindow::initializeView):
              (LauncherWindow::newWindow):
              (LauncherWindow::cloneWindow):
              (LauncherWindow::createChrome):
              (main):
              * QtLauncher/webview.cpp:
              (WebViewGraphicsBased::WebViewGraphicsBased):
              (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
              * QtLauncher/webview.h:
              (WebViewGraphicsBased::itemCacheMode):
              (WebViewGraphicsBased::frameRateMeasurementEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc979642
    • eric@webkit.org's avatar
      2010-03-03 Arno Renevier <arno@renevier.net> · dcd44188
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
              https://bugs.webkit.org/show_bug.cgi?id=35666
      
              * platform/gtk/GeolocationServiceGtk.cpp:
              (WebCore::GeolocationServiceGtk::startUpdating):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcd44188
    • kov@webkit.org's avatar
      2010-03-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · f78758d6
      kov@webkit.org authored
              [GTK] build slaves need working geoclue service
              https://bugs.webkit.org/show_bug.cgi?id=35674
      
              Skip tests we're not really able to run for the time being.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f78758d6
    • eric@webkit.org's avatar
      2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch> · bb8e89f9
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              Miscellaneous little fixes for the windows build of webkit-gtk
              https://bugs.webkit.org/show_bug.cgi?id=35640
      
              * GNUmakefile.am: On Windows with GCC, presence of
              __declspec(dllexport) on some symbols disables the autoexport/autoimport
              feature for all others. Using regex here assures that all symbols that
              need to be exported in the dll are actually exported.
      2010-03-03  Fridrich Strba  <fridrich.strba@bluewin.ch>
      
              Reviewed by Xan Lopez.
      
              Miscellaneous little fixes for the windows build of webkit-gtk
              https://bugs.webkit.org/show_bug.cgi?id=35640
      
              * GNUmakefile.am: dist two new files concerning mathml support.
      2010-03-03  Fridrich Strba  <fridrich.strba@bluewin.ch>
      
              Reviewed by Xan Lopez.
      
              Miscellaneous little fixes for the windows build of webkit-gtk
              https://bugs.webkit.org/show_bug.cgi?id=35640
      
              * webkit/webkitdownload.cpp: Windows headers define ERROR
              which breaks the build. Undef ERROR if it is defined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb8e89f9
    • xan@webkit.org's avatar
      2010-03-03 Xan Lopez <xlopez@igalia.com> · 471d48bb
      xan@webkit.org authored
              Unreviewed distcheck fix.
      
              Add new file to the build.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      471d48bb
    • antti@apple.com's avatar
      Make IntPoint usable as a hash key · ff82af27
      antti@apple.com authored
              
      Reviewed by Oliver Hunt.
      
      https://bugs.webkit.org/show_bug.cgi?id=35586
      
      * WebCore.pro:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/IntPointHash.h: Added.
      (WTF::IntPointHash::hash):
      (WTF::IntPointHash::equal):
      (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff82af27
    • philn@webkit.org's avatar
      2010-03-03 Philippe Normand <pnormand@igalia.com> · 050eb97b
      philn@webkit.org authored
              Unreviewed, build fix after r55452.
      
              * webkit/webkitwebview.cpp:
              (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      050eb97b
    • eric@webkit.org's avatar
      2010-03-02 Fridrich Strba <fridrich.strba@bluewin.ch> · d736ab24
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Allow building smoothly on win32 and win64 using GCC
              https://bugs.webkit.org/show_bug.cgi?id=35607
      
              * jit/JITStubs.h:
              * runtime/Collector.cpp:
              (JSC::Heap::allocateBlock):
              (JSC::Heap::freeBlockPtr):
              (JSC::currentThreadStackBase):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d736ab24
    • eric@webkit.org's avatar
      2010-03-02 Eric Uhrhane <ericu@chromium.org> · 3b6686bf
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * WebCore.base.exp: Export Database::setIsAvailable
              * WebCore.xcodeproj/project.pbxproj: Export needed headers as Private
              * page/DOMWindow.cpp: Read isAvailable, not Settings::isDatabaseEnabled
              (WebCore::DOMWindow::openDatabase):
              * page/Settings.cpp:  Add a call to Database::setIsAvailable.
              (WebCore::Settings::setDatabasesEnabled):
      2010-03-02  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * webkit/webkitwebview.cpp:  Add calls to Database::setIsAvailable
              (DNDContentsRequest::webkit_web_view_update_settings):
              (DNDContentsRequest::webkit_web_view_settings_notify):
      2010-03-02  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * WebView/WebView.mm:  Added a call to Database::setIsAvailable.
              (-[WebView _preferencesChangedNotification:]):
      2010-03-02  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              Move database enable bit fully out of settings
              This is stage one of a three-stage commit [webkit, then chromium, then
              webkit again].  In this change I'm adding calls to
              Database::setIsAvailable inside Settings::setDatabaseEnabled and
              anywhere else that called it, and switching webkit fully over to using
              that flag [added in a previous checkin].  Phase two will remove
              Chromium's use of Settings for the Database, and phase three will remove
              the Setting for the Database enable entirely, leaving only
              Database::isAvailable/setIsAvailable.
      
              No new tests; tested by existing storage tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=35310
      
              * Api/qwebsettings.cpp:
              (QWebSettingsPrivate::apply):  Add a call to Database::setIsAvailable
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b6686bf
    • tony@chromium.org's avatar
      2010-03-02 Tony Chang <tony@chromium.org> · 55f35a76
      tony@chromium.org authored
              Reviewed by Darin Fisher.
      
              add a flag to WebURLResponse so we can identify multipart content
              https://bugs.webkit.org/show_bug.cgi?id=35628
      
              * platform/network/chromium/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              (WebCore::ResourceResponse::isMultipartPayload):
              (WebCore::ResourceResponse::setIsMultipartPayload):
      2010-03-02  Tony Chang  <tony@chromium.org>
      
              Reviewed by Darin Fisher.
      
              add a flag to WebURLResponse so we can identify multipart content
              https://bugs.webkit.org/show_bug.cgi?id=35628
      
              * public/WebURLResponse.h:
              * src/WebURLResponse.cpp:
              (WebKit::WebURLResponse::isMultipartPayload):
              (WebKit::WebURLResponse::setIsMultipartPayload):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55f35a76
  2. 02 Mar, 2010 3 commits
    • tony@chromium.org's avatar
      2010-03-02 Tony Chang <tony@chromium.org> · 98b2b800
      tony@chromium.org authored
              Not reviewed, test fix.
      
              Revert r55447 because the new layout test is crashing consistently
              on Leopard Intel Debug (tests).
              https://bugs.webkit.org/show_bug.cgi?id=35261
      
              * svg/custom/tiling-regular-hexagonal-crash-expected.txt: Removed.
              * svg/custom/tiling-regular-hexagonal-crash.svg: Removed.
      2010-03-02  Tony Chang  <tony@chromium.org>
      
              Not reviewed, test fix.
      
              Revert r55447 because the new layout test is crashing consistently
              on Leopard Intel Debug (tests).
              https://bugs.webkit.org/show_bug.cgi?id=35261
      
              * platform/graphics/skia/ImageSkia.cpp:
              (WebCore::BitmapImageSingleFrameSkia::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98b2b800
    • eric@webkit.org's avatar
      2010-03-02 Adam Barth <abarth@webkit.org> · 09d0db51
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Google Analytics triggers "blocked plugin" UI
              https://bugs.webkit.org/show_bug.cgi?id=35565
      
              Just like for running script, we need to distinguish between querying
              whether plug-ins are enabled and actually blocking a page from
              instantiating a plugin.  We need to issue different callbacks to the
              FrameLoaderClient so that the client can inform us that plug-ins are
              disabled in some cases without showing the "plug-in blocked" UI.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::requestObject):
              (WebCore::FrameLoader::allowPlugins):
              * loader/FrameLoader.h:
              (WebCore::):
              * loader/FrameLoaderClient.h:
              (WebCore::FrameLoaderClient::didNotAllowPlugins):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
              * loader/PluginDocument.cpp:
              (WebCore::PluginTokenizer::writeRawData):
              * page/Page.cpp:
              (WebCore::Page::pluginData):
              * plugins/MimeType.cpp:
              (WebCore::MimeType::enabledPlugin):
      2010-03-02  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Fisher.
      
              Google Analytics triggers "blocked plugin" UI
              https://bugs.webkit.org/show_bug.cgi?id=35565
      
              Plumb didNotAllowPlugins to the client.
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::didNotAllowPlugins):
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
              * src/FrameLoaderClientImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09d0db51
    • eric@webkit.org's avatar
      2010-03-02 Andreas Kling <andreas.kling@nokia.com> · b5f57fc0
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Support the HTTP OPTIONS verb (needed for preflight requests)
      
              https://bugs.webkit.org/show_bug.cgi?id=34647
      
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
              (WebCore::QNetworkReplyHandler::start):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5f57fc0