1. 19 Jun, 2012 40 commits
    • adamk@chromium.org's avatar
      Pass ScriptValue by const ref where possible · 2f9fa62f
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89531
      
      Reviewed by Kentaro Hara.
      
      Previously ScriptValue was sometimes passed by value, sometimes by const ref.
      
      For consistency and optimality, pass by const ref everywhere (except where
      ScriptValue is returned from non-accessor methods).
      
      No new tests, no change in behavior.
      
      * bindings/js/ScriptFunctionCall.h:
      (ScriptCallback):
      * bindings/js/ScriptProfiler.cpp:
      (WebCore::ScriptProfiler::getHeapObjectId):
      * bindings/js/ScriptProfiler.h:
      (ScriptProfiler):
      * bindings/js/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::setException):
      * bindings/js/WorkerScriptController.h:
      (WorkerScriptController):
      * bindings/v8/ScriptFunctionCall.cpp:
      (WebCore::ScriptCallback::ScriptCallback):
      * bindings/v8/ScriptFunctionCall.h:
      (ScriptCallback):
      * bindings/v8/ScriptProfiler.cpp:
      (WebCore::ScriptProfiler::getHeapObjectId):
      (WebCore):
      * bindings/v8/ScriptProfiler.h:
      (ScriptProfiler):
      * bindings/v8/ScriptValue.h:
      (WebCore::ScriptValue::operator==):
      (WebCore::ScriptValue::operator!=):
      * bindings/v8/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::setException):
      * bindings/v8/WorkerScriptController.h:
      (WorkerScriptController):
      * css/MediaQueryListListener.h:
      (WebCore::MediaQueryListListener::create):
      (WebCore::MediaQueryListListener::MediaQueryListListener):
      * dom/CustomEvent.cpp:
      (WebCore::CustomEvent::initCustomEvent):
      * dom/CustomEvent.h:
      (CustomEvent):
      (WebCore::CustomEvent::detail):
      * dom/MessageEvent.h:
      (WebCore::MessageEvent::dataAsScriptValue):
      * dom/PopStateEvent.h:
      (WebCore::PopStateEvent::state):
      * inspector/InjectedScript.cpp:
      (WebCore::InjectedScript::wrapObject):
      * inspector/InjectedScript.h:
      (InjectedScript):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f9fa62f
    • philn@webkit.org's avatar
      [GStreamer] 0.11 video-sink · 36de885b
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77087
      
      Reviewed by Martin Robinson.
      
      * configure.ac: Fix required gstreamer 0.11 version
      
      Source/WebCore:
      
      Port the video sink to GStreamer 0.11 APIs. There is no change in
      functionality compared to 0.10, for now.
      
      * platform/graphics/gstreamer/GStreamerVersioning.cpp:
      (webkitGetVideoSizeAndFormatFromCaps):
      (webkitGstCreateBuffer):
      * platform/graphics/gstreamer/GStreamerVersioning.h:
      (WebCore):
      * platform/graphics/gstreamer/ImageGStreamer.h:
      (WebCore::ImageGStreamer::createImage):
      (WebCore::ImageGStreamer::setCropRect):
      (WebCore::ImageGStreamer::rect):
      (ImageGStreamer):
      * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
      (ImageGStreamer::ImageGStreamer):
      * platform/graphics/gstreamer/ImageGStreamerQt.cpp:
      (ImageGStreamer::ImageGStreamer):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
      (WebCore::MediaPlayerPrivateGStreamer::naturalSize):
      * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
      (_WebKitVideoSinkPrivate):
      (webkitVideoSinkRender):
      (webkitVideoSinkProposeAllocation):
      (webkit_video_sink_class_init):
      * platform/graphics/gstreamer/VideoSinkGStreamer.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36de885b
    • commit-queue@webkit.org's avatar
      Add monitor profile support for Win · 26de5ec8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88565
      
      Patch by Tony Payne <tpayne@chromium.org> on 2012-06-19
      Reviewed by Eric Seidel.
      
      Source/Platform:
      
      * chromium/public/Platform.h:
      (Platform):
      (WebKit::Platform::screenColorProfile):
      
      Source/WebCore:
      
      Tests: fast/images/jpeg-with-color-profile.html
      fast/images/png-with-color-profile.html. Also covered by numerous
      layout tests.
      
      * WebCore.gyp/WebCore.gyp:
      * platform/PlatformScreen.h:
      (WebCore):
      * platform/blackberry/PlatformScreenBlackBerry.cpp:
      (WebCore::screenColorProfile):
      (WebCore):
      * platform/chromium/PlatformScreenChromium.cpp:
      (WebCore::screenColorProfile):
      (WebCore):
      * platform/efl/PlatformScreenEfl.cpp:
      (WebCore::screenColorProfile):
      (WebCore):
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::screenColorProfile):
      (WebCore):
      * platform/image-decoders/ImageDecoder.h:
      (ImageFrame):
      (ImageDecoder):
      (WebCore::ImageDecoder::qcmsOutputDeviceProfile):
      * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
      (turboSwizzled):
      (colorSpaceHasAlpha):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26de5ec8
    • abarth@webkit.org's avatar
      garden-o-matic fails to rebaseline tests with MISSING results · 57955542
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89521
      
      Reviewed by Kenneth Russell.
      
      If the bots report "MISSING", we should try to find PNG and TXT results on the server.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57955542
    • abarth@webkit.org's avatar
      svn.delete_list fails to delete empty parent directories · 06da11b9
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89520
      
      Reviewed by Dirk Pranke.
      
      These functions were calling scm.delete and scm.add, which already
      delete the parent directory. We'd get an exception when we tried to
      delete the parent directory again.
      
      * Scripts/webkitpy/common/checkout/scm/svn.py:
      (SVN._add_parent_directories):
      (SVN._delete_parent_directories):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06da11b9
    • fpizlo@apple.com's avatar
      JSC should be able to show disassembly for all generated JIT code · 2adf527e
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89536
      
      Reviewed by Gavin Barraclough.
              
      Now instead of doing linkBuffer.finalizeCode(), you do
      FINALIZE_CODE(linkBuffer, (... explanation ...)). FINALIZE_CODE() then
      prints your explanation and the disassembled code, if
      Options::showDisassembly is set to true.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * assembler/LinkBuffer.cpp: Added.
      (JSC):
      (JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
      (JSC::LinkBuffer::finalizeCodeWithDisassembly):
      (JSC::LinkBuffer::linkCode):
      (JSC::LinkBuffer::performFinalization):
      (JSC::LinkBuffer::dumpLinkStatistics):
      (JSC::LinkBuffer::dumpCode):
      * assembler/LinkBuffer.h:
      (LinkBuffer):
      (JSC):
      * assembler/MacroAssemblerCodeRef.h:
      (JSC::MacroAssemblerCodeRef::tryToDisassemble):
      (MacroAssemblerCodeRef):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::compile):
      (JSC::DFG::JITCompiler::compileFunction):
      * dfg/DFGOSRExitCompiler.cpp:
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::generateProtoChainAccessStub):
      (JSC::DFG::tryCacheGetByID):
      (JSC::DFG::tryBuildGetByIDList):
      (JSC::DFG::emitPutReplaceStub):
      (JSC::DFG::emitPutTransitionStub):
      * dfg/DFGThunks.cpp:
      (JSC::DFG::osrExitGenerationThunkGenerator):
      * disassembler/Disassembler.h:
      (JSC):
      (JSC::tryToDisassemble):
      * disassembler/UDis86Disassembler.cpp:
      (JSC::tryToDisassemble):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompile):
      * jit/JITCode.h:
      (JSC::JITCode::tryToDisassemble):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::privateCompileCTIMachineTrampolines):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::privateCompileCTIMachineTrampolines):
      (JSC::JIT::privateCompileCTINativeCall):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::stringGetByValStubGenerator):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::stringGetByValStubGenerator):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      * jit/SpecializedThunkJIT.h:
      (JSC::SpecializedThunkJIT::finalize):
      * jit/ThunkGenerators.cpp:
      (JSC::charCodeAtThunkGenerator):
      (JSC::charAtThunkGenerator):
      (JSC::fromCharCodeThunkGenerator):
      (JSC::sqrtThunkGenerator):
      (JSC::floorThunkGenerator):
      (JSC::ceilThunkGenerator):
      (JSC::roundThunkGenerator):
      (JSC::expThunkGenerator):
      (JSC::logThunkGenerator):
      (JSC::absThunkGenerator):
      (JSC::powThunkGenerator):
      * llint/LLIntThunks.cpp:
      (JSC::LLInt::generateThunkWithJumpTo):
      (JSC::LLInt::functionForCallEntryThunkGenerator):
      (JSC::LLInt::functionForConstructEntryThunkGenerator):
      (JSC::LLInt::functionForCallArityCheckThunkGenerator):
      (JSC::LLInt::functionForConstructArityCheckThunkGenerator):
      (JSC::LLInt::evalEntryThunkGenerator):
      (JSC::LLInt::programEntryThunkGenerator):
      * runtime/Options.cpp:
      (Options):
      (JSC::Options::initializeOptions):
      * runtime/Options.h:
      (Options):
      * yarr/YarrJIT.cpp:
      (JSC::Yarr::YarrGenerator::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2adf527e
    • commit-queue@webkit.org's avatar
      webkitpy: Simplify fetch_bugs_matching_search() · afc0923a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89497
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
      Reviewed by Adam Barth.
      
      Removed parameter with default value. It's not being used
      and the handling of the parameter was wrong. Saves a check.
      
      * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
      (BugzillaQueries.fetch_bugs_matching_search):
      * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
      (MockBugzillaQueries.fetch_bugs_matching_search):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afc0923a
    • jhoneycutt@apple.com's avatar
      Remove the failing expected results added in · 96a64782
      jhoneycutt@apple.com authored
      http://trac.webkit.org/changeset/119190 now that these tests pass.
      
      Rubber-stamped by Jessie Berlin.
      
      * platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Removed.
      * platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Removed.
      * platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Removed.
      * platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96a64782
    • arv@chromium.org's avatar
      [V8] Fix issue where a callback got a null calling context · ce34cfb3
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89532
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      Test: fast/dom/Window/post-message-crash.html
      
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::handlePostMessageCallback): Check the calling context and throw a type error (like JSC) if it is null.
      
      LayoutTests:
      
      * fast/dom/Window/post-message-crash-expected.txt: Added.
      * fast/dom/Window/post-message-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce34cfb3
    • tony@chromium.org's avatar
      Refactor RenderFlexibleBox terminology to use grow/shrink instead of positive/negative · 227669d0
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89493
      
      Reviewed by Eric Seidel.
      
      The spec stopped referring to positive and negative flex and now
      talks about flex grow and flex shrink. Also, the preferred size is
      now known as the flex basis. Make the code match the terms used in
      the spec. http://dev.w3.org/csswg/css3-flexbox/
      
      This will also make it easier to split flex into long hand notation
      (flex-grow, flex-shrink and flex-basis).
      
      No new tests, covered by existing tests.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyFlex::applyInheritValue):
      (WebCore::ApplyPropertyFlex::applyInitialValue):
      (WebCore::ApplyPropertyFlex::applyValue):
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::PropertyWrapperFlex::equals):
      (WebCore::PropertyWrapperFlex::blend):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::flexBasisForChild):
      (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
      (WebCore::RenderFlexibleBox::layoutFlexItems):
      (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
      (WebCore::RenderFlexibleBox::computeNextFlexLine):
      (WebCore::RenderFlexibleBox::freezeViolations):
      (WebCore::RenderFlexibleBox::resolveFlexibleLengths):
      * rendering/RenderFlexibleBox.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleFlexibleBoxData.cpp:
      (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
      (WebCore::StyleFlexibleBoxData::operator==):
      * rendering/style/StyleFlexibleBoxData.h:
      (StyleFlexibleBoxData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      227669d0
    • kbr@google.com's avatar
      [Chromium] Unreviewed test expectations update. · d4f8d44d
      kbr@google.com authored
      * platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt: Removed.
      * platform/chromium/TestExpectations:
          Referenced bugs 89529 and 89534.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4f8d44d
    • mhahnenberg@apple.com's avatar
      [Qt][Mac] REGRESSION(r120742): It broke the build · 7ffd08de
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89516
      
      Reviewed by Geoffrey Garen.
      
      Removing GCActivityCallbackCF.cpp because it doesn't mesh well with cross-platform
      code on Darwin (e.g. Qt). We now use plain ol' vanilla ifdefs to handle platforms
      without CF support. These if-defs will probably disappear in the future when we
      use cross-platform timers in HeapTimer.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * runtime/GCActivityCallback.cpp:
      (JSC):
      (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
      (JSC::DefaultGCActivityCallback::doWork):
      (JSC::DefaultGCActivityCallback::scheduleTimer):
      (JSC::DefaultGCActivityCallback::cancelTimer):
      (JSC::DefaultGCActivityCallback::didAllocate):
      (JSC::DefaultGCActivityCallback::willCollect):
      (JSC::DefaultGCActivityCallback::cancel):
      * runtime/GCActivityCallbackCF.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ffd08de
    • dpranke@chromium.org's avatar
      webkitpy: remove unneeded imports in layout_tests/port/chromium.py · 24ca0dc1
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89522
      
      Reviewed by Eric Seidel.
      
      They were no longer being used. No tests necessary.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24ca0dc1
    • commit-queue@webkit.org's avatar
      Source/WebCore: Make DOMFileSystem selectively structure clonable so it can be... · f2945c06
      commit-queue@webkit.org authored
      Source/WebCore: Make DOMFileSystem selectively structure clonable so it can be the body of a web intent.
      https://bugs.webkit.org/show_bug.cgi?id=88267
      
      Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-06-19
      Reviewed by David Levin.
      
      This functionality will allow FileSystem API objects to be dispatched to
      web content in order to enable, for instance, an intent notifying web
      content that a particular filesystem has been mounted by the local
      system. The goal at this point is not to enable across-the-board
      clonability, but just for handling the particular use case.
      
      * bindings/v8/SerializedScriptValue.cpp:
      (WebCore::V8ObjectMap::Writer::writeDOMFileSystem):
      (WebCore::V8ObjectMap::Serializer::writeDOMFileSystem):
      (WebCore::V8ObjectMap::Serializer::doSerialize):
      (WebCore::V8ObjectMap::Reader::read):
      (WebCore::V8ObjectMap::Reader::readDOMFileSystem):
      
      LayoutTests: Add filesystem regression test to check that the filesystem object is
      not serializable as created by javascript.
      https://bugs.webkit.org/show_bug.cgi?id=88267
      
      Patch by Greg Billock <gbillock@google.com> on 2012-06-19
      Reviewed by David Levin.
      
      * fast/filesystem/filesystem-unserializable-expected.html: Added.
      * fast/filesystem/filesystem-unserializable.html: Added.
      * fast/filesystem/script-tests/filesystem-unserializable.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2945c06
    • kbr@google.com's avatar
      Unreviewed, rolling out r120772. · 463afcfd
      kbr@google.com authored
      http://trac.webkit.org/changeset/120772
      https://bugs.webkit.org/show_bug.cgi?id=89503
      
      Broke build on Chromium Mac
      
      Source/WebCore:
      
      * platform/graphics/chromium/AnimationTranslationUtil.h:
      (WebCore):
      * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
      * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
      * platform/graphics/chromium/Canvas2DLayerBridge.cpp:
      * platform/graphics/chromium/Canvas2DLayerBridge.h:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      * platform/graphics/chromium/ContentLayerChromium.h:
      * platform/graphics/chromium/DrawingBufferChromium.cpp:
      * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
      * platform/graphics/chromium/GraphicsLayerChromium.h:
      (WebCore):
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore):
      * platform/graphics/chromium/LayerTextureUpdater.h:
      * platform/graphics/chromium/ManagedTexture.cpp:
      * platform/graphics/chromium/ProgramBinding.h:
      * platform/graphics/chromium/RenderSurfaceChromium.cpp:
      * platform/graphics/chromium/RenderSurfaceChromium.h:
      * platform/graphics/chromium/TextureCopier.cpp:
      * platform/graphics/chromium/TextureLayerChromium.cpp:
      * platform/graphics/chromium/TextureManager.cpp:
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      * platform/graphics/chromium/TiledLayerChromium.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCActiveAnimation.h:
      * platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
      * platform/graphics/chromium/cc/CCDrawQuad.cpp:
      * platform/graphics/chromium/cc/CCFontAtlas.cpp:
      * platform/graphics/chromium/cc/CCFrameRateController.cpp:
      * platform/graphics/chromium/cc/CCFrameRateController.h:
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCLayerAnimationController.h:
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      * platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
      * platform/graphics/chromium/cc/CCOcclusionTracker.h:
      * platform/graphics/chromium/cc/CCProxy.cpp:
      * platform/graphics/chromium/cc/CCQuadCuller.cpp:
      * platform/graphics/chromium/cc/CCRenderPass.h:
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      * platform/graphics/chromium/cc/CCRenderer.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCScopedThreadProxy.h:
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
      * platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      * platform/graphics/chromium/cc/CCThreadProxy.h:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
      * platform/graphics/chromium/cc/CCTimer.cpp:
      * platform/graphics/chromium/cc/CCTimer.h:
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      
      Source/WebKit/chromium:
      
      * src/WebCompositorImpl.cpp:
      * src/WebLayerTreeView.cpp:
      * tests/CCLayerTestCommon.cpp:
      * tests/CCLayerTreeHostImplTest.cpp:
      * tests/CCLayerTreeHostTest.cpp:
      * tests/CCOcclusionTrackerTest.cpp:
      * tests/CCQuadCullerTest.cpp:
      * tests/CCTiledLayerImplTest.cpp:
      * tests/ImageLayerChromiumTest.cpp:
      * tests/LayerRendererChromiumTest.cpp:
      * tests/TiledLayerChromiumTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      463afcfd
    • commit-queue@webkit.org's avatar
      [BlackBerry] Should check the return value of fromUTF8() before executing the script. · d1a82f7a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89500
      
      Patch by Yong Li <yoli@rim.com> on 2012-06-19
      Reviewed by Rob Buis.
      PR# 166623.
      
      WebPagePrivate::executeJavaScript() should check the return value of fromUTF8()
      before executing the script to avoid potential crash on invalid script source.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1a82f7a
    • bdakin@apple.com's avatar
      Skipping failing tests to keep the bots green. Filed · 4de9d640
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89528 to track fixing the 
      real problem.
      
      * platform/mac/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4de9d640
    • commit-queue@webkit.org's avatar
      [Chromium] Remove redundant #includes in compositor · c1bb2eb8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89503
      
      Patch by Zeev Lieber <zlieber@chromium.org> on 2012-06-19
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      Removed some redundant #includes to clarify dependency
      picture. Some 90 #includes removed, some 50 less disruptive
      #includes added. This brings the number of class dependencies to
      902 from 1383.
      
      No new tests are required, as this is only affects compile-time behavior.
      
      * platform/graphics/chromium/AnimationTranslationUtil.h:
      (WebCore):
      * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
      * platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
      * platform/graphics/chromium/Canvas2DLayerBridge.cpp:
      * platform/graphics/chromium/Canvas2DLayerBridge.h:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      * platform/graphics/chromium/ContentLayerChromium.h:
      * platform/graphics/chromium/DrawingBufferChromium.cpp:
      * platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
      * platform/graphics/chromium/GraphicsLayerChromium.h:
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore):
      * platform/graphics/chromium/LayerTextureUpdater.h:
      * platform/graphics/chromium/ManagedTexture.cpp:
      * platform/graphics/chromium/ProgramBinding.h:
      * platform/graphics/chromium/RenderSurfaceChromium.cpp:
      * platform/graphics/chromium/RenderSurfaceChromium.h:
      * platform/graphics/chromium/TextureCopier.cpp:
      * platform/graphics/chromium/TextureLayerChromium.cpp:
      * platform/graphics/chromium/TextureManager.cpp:
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      * platform/graphics/chromium/TiledLayerChromium.h:
      * platform/graphics/chromium/cc/CCActiveAnimation.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:
      * platform/graphics/chromium/cc/CCDrawQuad.cpp:
      * platform/graphics/chromium/cc/CCFontAtlas.cpp:
      * platform/graphics/chromium/cc/CCFrameRateController.cpp:
      * platform/graphics/chromium/cc/CCFrameRateController.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCLayerAnimationController.h:
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      * platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
      * platform/graphics/chromium/cc/CCOcclusionTracker.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCProxy.cpp:
      * platform/graphics/chromium/cc/CCQuadCuller.cpp:
      * platform/graphics/chromium/cc/CCRenderPass.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      * platform/graphics/chromium/cc/CCRenderer.h:
      * platform/graphics/chromium/cc/CCScopedThreadProxy.h:
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
      * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
      * platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      * platform/graphics/chromium/cc/CCThreadProxy.h:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCTimer.cpp:
      * platform/graphics/chromium/cc/CCTimer.h:
      (WebCore):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      
      Source/WebKit/chromium:
      
      Minor adjustments to #include statements to remove
      dependencies. No new tests.
      
      * src/WebCompositorImpl.cpp:
      * src/WebLayerTreeView.cpp:
      * tests/CCLayerTestCommon.cpp:
      * tests/CCLayerTreeHostImplTest.cpp:
      * tests/CCLayerTreeHostTest.cpp:
      * tests/CCOcclusionTrackerTest.cpp:
      * tests/CCQuadCullerTest.cpp:
      * tests/CCTiledLayerImplTest.cpp:
      * tests/ImageLayerChromiumTest.cpp:
      * tests/LayerRendererChromiumTest.cpp:
      * tests/TiledLayerChromiumTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1bb2eb8
    • jchaffraix@webkit.org's avatar
      Align RenderLayer's descendant dependent flags semantics · 3ea08ece
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89241
      
      Reviewed by Simon Fraser.
      
      Refactoring only, covered by existing tests.
      
      This change aligns the naming and implementation of the different descendant
      dependent flags. While aligning, I found some bugs (inefficiencies) with how
      the visible descendant flags was computed.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::setHasVisibleContent):
      Changed this method to not take a boolean as every callers was passing 'true'.
      Reworked the logic under this assumption.
      
      (WebCore::RenderLayer::dirtyVisibleContentStatus):
      Updated after the following renaming.
      
      (WebCore::RenderLayer::dirtyAncestorChainVisibleDescendantStatus):
      Renamed this function from dirtyVisibleDescendantStatus to match the hasSelfPaintingLayer
      naming and implementation.
      
      (WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
      Added this function to factor the visible descendant setting out of defunct childVisibilityChanged.
      Also improved the efficiency of the function by clearing the dirty flag as it goes up (an unnoticed bug).
      
      (WebCore::RenderLayer::addChild):
      (WebCore::RenderLayer::removeChild):
      Updated to use the new functions lieu of childVisibilityChanged.
      * rendering/RenderLayer.h:
      (RenderLayer::childVisibilityChanged):
      Removed this function as it wasn't adding much and it's a lot more clear to call
      dirtyAncestorChainVisibleDescendantStatus / setAncestorChainHasVisibleDescendant.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::styleWillChange):
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::appendChildNode):
      (WebCore::RenderObjectChildList::insertChildNode):
      Updated those callers after removing the boolean parameter from setHasVisibleContent.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ea08ece
    • pfeldman@chromium.org's avatar
      Web Inspector: Extract InjectedScriptBase class from the InjectedScript · 52ba9e6d
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89107
      
      Extract methods from the InjectedScript that do not depend on
      the concrete InjectedScriptSource.js implementation.
      
      Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-06-19
      Reviewed by Pavel Feldman.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/InjectedScript.cpp:
      (WebCore::InjectedScript::InjectedScript):
      (WebCore::InjectedScript::evaluate):
      (WebCore::InjectedScript::callFunctionOn):
      (WebCore::InjectedScript::evaluateOnCallFrame):
      (WebCore::InjectedScript::getFunctionDetails):
      (WebCore::InjectedScript::getProperties):
      (WebCore::InjectedScript::nodeForObjectId):
      (WebCore::InjectedScript::releaseObject):
      (WebCore::InjectedScript::wrapCallFrames):
      (WebCore::InjectedScript::wrapObject):
      (WebCore::InjectedScript::wrapSerializedObject):
      (WebCore::InjectedScript::findObjectById):
      (WebCore::InjectedScript::inspectNode):
      (WebCore::InjectedScript::releaseObjectGroup):
      (WebCore::InjectedScript::nodeAsScriptValue):
      * inspector/InjectedScript.h:
      (WebCore):
      (InjectedScript):
      * inspector/InjectedScriptBase.cpp: Added.
      (WebCore):
      (WebCore::InjectedScriptBase::InjectedScriptBase):
      (WebCore::InjectedScriptBase::canAccessInspectedWindow):
      (WebCore::InjectedScriptBase::injectedScriptObject):
      (WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
      (WebCore::InjectedScriptBase::makeCall):
      (WebCore::InjectedScriptBase::makeEvalCall):
      * inspector/InjectedScriptBase.h: Copied from Source/WebCore/bindings/js/ScriptObject.h.
      (WebCore):
      (InjectedScriptBase):
      (WebCore::InjectedScriptBase::~InjectedScriptBase):
      (WebCore::InjectedScriptBase::hasNoValue):
      (WebCore::InjectedScriptBase::scriptState):
      * inspector/InspectorAllInOne.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52ba9e6d
    • kbr@google.com's avatar
      [Chromium][Mac] Layout Test... · 5c8ff9d6
      kbr@google.com authored
      [Chromium][Mac] Layout Test ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm is failing
      https://bugs.webkit.org/show_bug.cgi?id=89411
      
      Unreviewed test expectations update generated by garden-o-matic.
      
      * ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt.
      * platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
      * platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
      * platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png: Added.
      * platform/chromium/TestExpectations:
          Removed IMAGE MISSING expectation for this test.
      * platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c8ff9d6
    • fpizlo@apple.com's avatar
      DFG CFA forgets to notify subsequent phases of found constants if it proves... · 152abff0
      fpizlo@apple.com authored
      DFG CFA forgets to notify subsequent phases of found constants if it proves LogicalNot to be a constant
      https://bugs.webkit.org/show_bug.cgi?id=89511
      <rdar://problem/11700089>
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      
      LayoutTests: 
      
      * fast/js/dfg-constant-fold-logical-not-branch-expected.txt: Added.
      * fast/js/dfg-constant-fold-logical-not-branch.html: Added.
      * fast/js/script-tests/dfg-constant-fold-logical-not-branch.js: Added.
      (foo1):
      (foo2):
      (Stuff):
      (Stuff.prototype.thingy):
      (Stuff.prototype.otherThingy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      152abff0
    • jhoneycutt@apple.com's avatar
      Remove the failing results added in · a890c6cd
      jhoneycutt@apple.com authored
      http://trac.webkit.org/changeset/119144 and
      http://trac.webkit.org/changeset/119149 now that these tests pass
      without them.
      
      Rubber-stamped by Jessie Berlin.
      
      * platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Removed.
      * platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Removed.
      * platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Removed.
      * platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Removed.
      * platform/win/fast/events/popup-blocking-timers-expected.txt: Removed.
      * platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Removed.
      * platform/win/fast/events/remove-target-in-mouseup-expected.txt: Removed.
      * platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Removed.
      * platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Removed.
      * platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a890c6cd
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r120621. · 21a524cd
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/120621
      https://bugs.webkit.org/show_bug.cgi?id=89518
      
      Memory graph should have been behind the experimental flag.
      (Requested by pfeldman on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19
      
      * inspector/front-end/NativeMemorySnapshotView.js:
      * inspector/front-end/ProfileLauncherView.js:
      (WebInspector.ProfileLauncherView):
      * inspector/front-end/nativeMemoryProfiler.css:
      (.memory-blocks-list .item):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21a524cd
    • commit-queue@webkit.org's avatar
      The CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed · a6e45232
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89403
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-06-19
      Reviewed by Eric Seidel.
      
      Removed CSS_WRAP_SHAPE_PATH definition from CSSWrapShapes.h.
      It's no longer required. This definition was never used or
      tested, no new tests are required.
      
      * css/CSSWrapShapes.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6e45232
    • jpetsovits@rim.com's avatar
      [BlackBerry] Missing notifyContentRendered() when resuming rendering · a592bea2
      jpetsovits@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89507
      RIM PR 150049
      
      Reviewed by Antonio Gomes.
      
      All the current calls to notifyContentRendered() are
      located in the RenderQueue, but this omits the case
      when we force rendering from resumeBackingStore()
      after rendering had been suspended for a while.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a592bea2
    • kenrb@chromium.org's avatar
      Absolute positioned objects should not be added to anonymous block lists · 10c6d4ba
      kenrb@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87768
      
      Reviewed by Abhishek Arya.
      
      Source/WebCore:
      
      containingBlock() was returning an anonymous block for absolute
      positioned objects under a relative positioned inline in the case
      that the inline is split and the object is underneath the block
      continuation. Anonymous blocks should never have anything in their
      positioned object lists because they can be destroyed at any time
      for a different reasons such as anonymous block merging, which is
      a problem for layout if they have m_posChildNeedsLayout set.
      
      This patch adds a generic check for anonymous blocks in
      containingBlock() to correct this problem.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::containingBlock):
      
      LayoutTests:
      
      Test crashing condition in bug 87768.
      
      * fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash-expected.txt: Added
      * fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html: Added
      * fast/block/positioning/insert-positioned-in-anonymous-crash-expected.txt: Added
      * fast/block/positioning/insert-positioned-in-anonymous-crash.html: Added
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10c6d4ba
    • commit-queue@webkit.org's avatar
      Source/WebCore: Web Inspector: extensionPanel.onSearch `action` strings should be · ee6ab6e1
      commit-queue@webkit.org authored
      enumerated.
      https://bugs.webkit.org/show_bug.cgi?id=89509
      
      Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
      Reviewed by Pavel Feldman.
      
      Fixed LayoutTests/inspector/extensions/extensions-api-expected.txt
      accordingly.
      
      * inspector/front-end/ExtensionAPI.js:
      (defineCommonExtensionSymbols):
      (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):
      (injectedExtensionAPI.Panels.prototype.get SearchAction):
      * inspector/front-end/ExtensionPanel.js:
      (WebInspector.ExtensionPanel.prototype.searchCanceled):
      (WebInspector.ExtensionPanel.prototype.performSearch):
      (WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
      (WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
      
      LayoutTests: Web Inspector: extensionPanel.onSearch `action` strings should be enumerated
      https://bugs.webkit.org/show_bug.cgi?id=89509
      
      Patch by Jan Keromnes <janx@linux.com> on 2012-06-19
      Reviewed by Pavel Feldman.
      
      * inspector/extensions/extensions-api-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee6ab6e1
    • danakj@chromium.org's avatar
      [chromium] Add an allocation step for CCRenderer before drawing a frame · 695f41e9
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88924
      
      Reviewed by Adrienne Walker.
      
      This step will be used to decide which RenderPass textures can be kept
      alive and do not need to be drawn again.
      
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore):
      (WebCore::LayerRendererChromium::decideRenderPassAllocationsForFrame):
      (WebCore::LayerRendererChromium::beginDrawingFrame):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (LayerRendererChromium):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::drawLayers):
      * platform/graphics/chromium/cc/CCRenderer.h:
      (CCRenderer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      695f41e9
    • kbr@google.com's avatar
      [Chromium] Unreviewed gardening. · 4427d26b
      kbr@google.com authored
      * platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/resize-while-save-active-expected.txt:
          Added expectations without trailing newlines; unclear why this only happens in this configuration.
      * platform/chromium/TestExpectations:
          Added reference to https://bugs.webkit.org/show_bug.cgi?id=89510 .
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4427d26b
    • achicu@adobe.com's avatar
      [CSS Shaders] Create a shared object between FECustomFilter objects to store the shared resources · fc2f4e25
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=87878
      
      Reviewed by Dean Jackson.
      
      An object called CustomFilterGlobalContext is created the first time a new FECustomFilter is needed in a document.
      It is used to store the GraphicsContext3D needed to render the CSS Shaders. The context is shared by all the elements
      in a document (no cross-domain).
      
      More resources will be shared in following patches, including precompiled shaders and vertices/indices data.
      https://bugs.webkit.org/show_bug.cgi?id=88427
      https://bugs.webkit.org/show_bug.cgi?id=88429
      
      The plan is to make CustomFilterGlobalContext and FECustomFilter (or a base class extracted out of it) usable from platform
      code in the hardware accelerated compositing layer. The only dependency of the code is on the GraphicsContext3D.
      
      No new tests. No functionality is changed yet, just added the new objects.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/filters/CustomFilterGlobalContext.cpp: Added.
      (WebCore):
      (WebCore::CustomFilterGlobalContext::CustomFilterGlobalContext):
      (WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
      (WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
      * platform/graphics/filters/CustomFilterGlobalContext.h: Added.
      (WebCore):
      (CustomFilterGlobalContext):
      (WebCore::CustomFilterGlobalContext::context):
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::FECustomFilter): Changed to use the global context instead of the host window.
      (WebCore::FECustomFilter::create):
      (WebCore::FECustomFilter::initializeContext):
      * platform/graphics/filters/FECustomFilter.h:
      (WebCore):
      (FECustomFilter):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::build): Changed to initialize the global context if needed and pass it to the FECustomFilter.
      * rendering/RenderView.cpp:
      (WebCore):
      (WebCore::RenderView::customFilterGlobalContext):
      * rendering/RenderView.h:
      (WebCore):
      (RenderView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc2f4e25
    • abarth@webkit.org's avatar
      Missing results aren't shown in garden-o-matic · e0c5179b
      abarth@webkit.org authored
      Reviewed by Kenneth Russell.
      
      Previously we didn't know to look for text and image results when the
      bot told us that results were missing.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0c5179b
    • commit-queue@webkit.org's avatar
      [cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html · 510a14db
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53085
      
      Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Clipping previously unlimited vertical and horizontal pattern repeats with
      a clip rectangle similar to the Qt Graphics Context.
      
      No new tests, this patch fixes
      canvas/philip/tests/2d.pattern.paint.repeat* tests.
      
      * platform/graphics/Pattern.h:
      (WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.
      * platform/graphics/cairo/PlatformContextCairo.cpp:
      (WebCore::PlatformContextCairo::prepareForFilling):
      (WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.
      * platform/graphics/cairo/PlatformContextCairo.h:
      
      LayoutTests:
      
      canvas/philip/tests/2d.pattern.paint.repeat* tests now passing.
      
      * platform/efl/Skipped:
      * platform/gtk/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      510a14db
    • hayato@chromium.org's avatar
      [Shadow DOM] An upper boundary breaks if a child node of an insertion point is clicked. · e0206030
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89407
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Update an event re-targeting algorithm so that it can set event's
      target correctly when a fallback element in an insertion point is
      clicked. To distinguish between distributed nodes and fallback
      elements in an ancestor chain of composite shadow tree, an event
      dispatcher checks explicitly whether a node is actually
      distributed or assigned to the given insertion point.
      
      Test: fast/dom/shadow/shadow-dom-event-dispatching.html
      
      * dom/EventDispatcher.cpp:
      (WebCore::isAssignedTo):
      (WebCore):
      (WebCore::EventDispatcher::ensureEventAncestors):
      * html/shadow/InsertionPoint.h:
      (WebCore::InsertionPoint::contains):
      
      LayoutTests:
      
      * fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
      * fast/dom/shadow/shadow-dom-event-dispatching.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0206030
    • jsbell@chromium.org's avatar
      IndexedDB: Add new type (and chromium webkit API) for metadata snapshot · d48dd13c
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88678
      
      Reviewed by Darin Fisher.
      
      * WebKit.gyp:
      * public/WebIDBDatabase.h:
      (WebKit::WebIDBDatabase::metadata):
      * public/WebIDBKeyPath.h:
      (WebIDBKeyPath):
      (WebKit::WebIDBKeyPath::WebIDBKeyPath):
      (WebKit::WebIDBKeyPath::~WebIDBKeyPath):
      (WebKit::WebIDBKeyPath::operator=): Used by Chromium backend.
      * public/WebIDBMetadata.h: Added new type.
      (WebKit):
      (WebIDBMetadata):
      (WebKit::WebIDBMetadata::WebIDBMetadata):
      (ObjectStore):
      (WebKit::WebIDBMetadata::ObjectStore::ObjectStore):
      (Index):
      (WebKit::WebIDBMetadata::Index::Index):
      * src/WebIDBKeyPath.cpp: Conform to normal WebXXX patern.
      (WebKit::WebIDBKeyPath::assign):
      (WebKit):
      (WebKit::WebIDBKeyPath::reset):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d48dd13c
    • commit-queue@webkit.org's avatar
      [Chromium] Add LayoutTests for find in page. · df73fea5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89453
      
      Patch by Martin Kosiba <mkosiba@google.com> on 2012-06-19
      Reviewed by Adam Barth.
      
      * platform/chromium/editing/text-iterator/findString-restarts-at-last-position-expected.txt: Added.
      * platform/chromium/editing/text-iterator/findString-restarts-at-last-position.html: Added.
      * platform/chromium/editing/text-iterator/findString-start-search-after-selection-expected.txt: Added.
      * platform/chromium/editing/text-iterator/findString-start-search-after-selection.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df73fea5
    • commit-queue@webkit.org's avatar
      CodeBlock::needsCallReturnIndices() is no longer needed. · b683300c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89490
      
      Patch by Mark Lam <mark.lam@apple.com> on 2012-06-19
      Reviewed by Geoffrey Garen.
      
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::needsCallReturnIndices): removed.
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::link):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b683300c
    • enne@google.com's avatar
      Fix scrollbar layers being misplaced with a clipped owner layer · 5979acb6
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=89486
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Scrollbar layers are positioned relative to their parent layer. If
      that parent gets clipped, then that positioning becomes incorrect and
      scrollbars get positioned relative to the clipped bounds instead of
      the full bounds. Fix by not clipping in this case.
      
      Test: compositing/overflow/scrollbars-with-clipped-owner.html
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::shouldClipCompositedBounds):
      
      LayoutTests:
      
      * compositing/overflow/scrollbars-with-clipped-owner-expected.png: Added.
      * compositing/overflow/scrollbars-with-clipped-owner-expected.txt: Added.
      * compositing/overflow/scrollbars-with-clipped-owner.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5979acb6
    • shinyak@chromium.org's avatar
      [Shadow][Editing] applying document.execCommand('bold') twice to elements... · de416515
      shinyak@chromium.org authored
      [Shadow][Editing] applying document.execCommand('bold') twice to elements having shadow insertion points causes a crash.
      https://bugs.webkit.org/show_bug.cgi?id=88502
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      When inserting or removing insertion points (<shadow> or <content>) into or from Shdaow DOM,
      ElementShadow::invalidateDistribution() will be called immediately. It will remove all the renderers
      of elements in the Shadow DOM. Since Node::rendererIsEditable() returns false when an renderer does not
      exist, all the elements in the Shadow DOM will be considered as non-content-editable until recalculating
      layout, though some of them may actually be content-editable.
      
      Actually the current code does not recalculate layout inside editing command, so a disaster happens.
      For example, performing an editing command quits before completing all the commands, because the command
      thinks it is adding some elements to a non-content-editable element (but actually it's content-editable).
      
      So we have to recalculate layout if necessary when checking an element is content-editable or not.
      This can be achieved by using Node::isContentEditable() instead of Node::rendererIsEditable().
      
      Test: editing/shadow/bold-twice-in-shadow.html
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
      * editing/InsertNodeBeforeCommand.cpp:
      (WebCore::InsertNodeBeforeCommand::doApply):
      (WebCore::InsertNodeBeforeCommand::doUnapply):
      * editing/RemoveNodeCommand.cpp:
      (WebCore::RemoveNodeCommand::doApply):
      
      LayoutTests:
      
      * editing/shadow/bold-twice-in-shadow-expected.txt: Added.
      * editing/shadow/bold-twice-in-shadow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de416515
    • kbr@google.com's avatar
      Unreviewed, rolling out r120744. · 0f82d0d7
      kbr@google.com authored
      http://trac.webkit.org/changeset/120744
      https://bugs.webkit.org/show_bug.cgi?id=89220
      
      Broke build on Chromium Windows canary bots
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * platform/mock/DeviceMotionClientMock.cpp: Removed.
      * platform/mock/DeviceMotionClientMock.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f82d0d7