Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 22 Nov, 2011 1 commit
  3. 18 Nov, 2011 1 commit
    • commit-queue@webkit.org's avatar
      IDL changes for gamepad support · 0ef17682
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=71753

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-18
Reviewed by Adam Barth.

Source/WebCore:

IDL changes and associated plumbing to expose list of gamepad objects
on navigator object (per current spec). Full patch is
https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
test until more plumbing in future patches.

Test: gamepad/gamepad-api.html

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):
* page/Gamepad.cpp: Added.
(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):
* page/Gamepad.h: Added.
* page/Gamepad.idl: Added.
* page/GamepadList.cpp: Added.
(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):
* page/GamepadList.h: Added.
(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):
* page/GamepadList.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::webkitGamepads):
* page/Navigator.h:
* page/Navigator.idl:

Source/WebKit/chromium:

Update to use vendor-prefixed enable.

* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

Tools:

Runtime enable gamepad in chromium test shell.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

Add basic api existence test.

* gamepad/gamepad-api-expected.txt: Added.
* gamepad/gamepad-api.html: Added.
* gamepad/gamepad-test.js: Added.
(logConsole):
(testExpected):
(reportExpected):
(waitForEventAndEnd):
(waitForEvent._eventCallback):
(waitForEvent):
(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):
(endTest):
(logResult):
(consoleWrite):
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ef17682
  5. 15 Nov, 2011 2 commits
    • jchaffraix@webkit.org's avatar
      Add the needed plumbing to parse display: -webkit-grid · 63c7d1af
      jchaffraix@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=72331

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/display-grid-set-get.html

Added parsing support for display: -webkit-grid. From a rendering perspective,
the value is equivalent to display: none until we properly implement it.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:
Added the new CSS value and plumbed the parsing and style application of
the new value.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EDisplay):
Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
-wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
logic outside the EDisplay range which would lead to crashes.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
Fixed the indentation to follow our coding rules.

LayoutTests:

* fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
* fast/css-grid-layout/display-grid-set-get.html: Added.
* fast/css-grid-layout/resources/display-grid-set-get.js: Added.
Test that setting the display to -webkit-grid (from JS or CSS) works
and we get the right value back.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
SKIP the css-grid-layout tests on all platforms for now.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63c7d1af
    • tony@chromium.org's avatar
      enable new flexbox tests everywhere · f6420695
      tony@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=72325

Reviewed by Ojan Vafai.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6420695
  7. 09 Nov, 2011 1 commit
  9. 08 Nov, 2011 1 commit
  11. 07 Nov, 2011 1 commit
  13. 02 Nov, 2011 1 commit
  15. 27 Oct, 2011 1 commit
  17. 14 Oct, 2011 2 commits
  19. 13 Oct, 2011 2 commits
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=70050 · 758dc7c2
      bdakin@apple.com authored 
      DRT and WRT should have HiDPI testing capabilities

Reviewed by Darin Adler.

Source/WebKit/mac: 

New method _backingScaleFactor matches SPI of a similar name that I added 
recently to WKPage in WebKit2. Equivalent functionality is needed for 
DumpRenderTree's HiDPI support.
* WebView/WebView.mm:
(-[WebView _backingScaleFactor]):
* WebView/WebViewPrivate.h:

Tools: 

New layoutTestController function setBackingScaleFactor takes a double for a scale 
factor and a callback function to call once the backing scale factor has 
successfully been set for the view.
* DumpRenderTree/LayoutTestController.cpp:
(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):

On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
platforms do nothing.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setBackingScaleFactor):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setBackingScaleFactor):

Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
value of 0, which resets to the system default.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):

When generating the pixel dump, create a Bitmap of the appropriate size based on 
the backing scale factor. If it is a HiDPI view, paint into the context using 
displayRectIgnoringOpacity.
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):

And now the same stuff for WK2. Again, new layoutTestController function 
setBackingScaleFactor takes a double for a scale factor and a callback function. 
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setBackingScaleFactor):
(WTR::LayoutTestController::callSetBackingScaleFactorCallback):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

The InjectedBundle sends a message to the UI process to set the backing scale 
factor. It also processes a message the UI process will send back once it 
completes this task, and at that time, the InjectedBundle calls the callback.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postSetBackingScaleFactor):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:

Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
with a value of 0, which resets to the system default.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

Upon receiving the SetBackingScaleFactor message, call 
WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
back to InjectedBundle to say it has been done.
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
        
Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
window's scale factor so we have to avoid that.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

LayoutTests: 

New HiDPI tests and results. These should be skipped on all non-Lion platforms.
* fast/hidpi: Added.
* fast/hidpi/broken-image-icon-hidpi.html: Added.
* fast/hidpi/broken-image-with-size-hidpi.html: Added.
* fast/hidpi/clip-text-in-hidpi.html: Added.
* fast/hidpi/resize-corner-hidpi.html: Added.
* fast/hidpi/video-controls-in-hidpi.html: Added.
* platform/gtk-wk2/Skipped:
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac/fast/hidpi: Added.
* platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      758dc7c2
    • adamk@chromium.org's avatar
      Unreviewed, skip MutationObserver tests on wincairo. · 668d8f32
      adamk@chromium.org authored 
      These tests are not yet enabled on any platform.

* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      668d8f32
  21. 07 Oct, 2011 2 commits
  23. 05 Oct, 2011 3 commits