1. 22 Nov, 2011 2 commits
  2. 21 Nov, 2011 2 commits
  3. 18 Nov, 2011 5 commits
    • yutak@chromium.org's avatar
      [Qt] Unreviewed, add one failing test to the Skipped list. · b802bc14
      yutak@chromium.org authored
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b802bc14
    • commit-queue@webkit.org's avatar
      IDL changes for gamepad support · 0ef17682
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71753
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-11-18
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      IDL changes and associated plumbing to expose list of gamepad objects
      on navigator object (per current spec). Full patch is
      https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
      test until more plumbing in future patches.
      
      Test: gamepad/gamepad-api.html
      
      * WebCore.gypi:
      * bindings/generic/RuntimeEnabledFeatures.h:
      (WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
      (WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):
      * page/Gamepad.cpp: Added.
      (WebCore::Gamepad::Gamepad):
      (WebCore::Gamepad::axes):
      (WebCore::Gamepad::buttons):
      (WebCore::Gamepad::~Gamepad):
      * page/Gamepad.h: Added.
      * page/Gamepad.idl: Added.
      * page/GamepadList.cpp: Added.
      (WebCore::GamepadList::~GamepadList):
      (WebCore::GamepadList::set):
      (WebCore::GamepadList::length):
      (WebCore::GamepadList::item):
      * page/GamepadList.h: Added.
      (WebCore::GamepadList::create):
      (WebCore::GamepadList::GamepadList):
      * page/GamepadList.idl: Added.
      * page/Navigator.cpp:
      (WebCore::Navigator::webkitGamepads):
      * page/Navigator.h:
      * page/Navigator.idl:
      
      Source/WebKit/chromium:
      
      Update to use vendor-prefixed enable.
      
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableGamepad):
      (WebKit::WebRuntimeFeatures::isGamepadEnabled):
      
      Tools:
      
      Runtime enable gamepad in chromium test shell.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::TestShell):
      
      LayoutTests:
      
      Add basic api existence test.
      
      * gamepad/gamepad-api-expected.txt: Added.
      * gamepad/gamepad-api.html: Added.
      * gamepad/gamepad-test.js: Added.
      (logConsole):
      (testExpected):
      (reportExpected):
      (waitForEventAndEnd):
      (waitForEvent._eventCallback):
      (waitForEvent):
      (waitForEventAndTest._eventCallback):
      (waitForEventAndTest):
      (waitForEventTestAndEnd):
      (endTest):
      (logResult):
      (consoleWrite):
      * platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
      * platform/efl/Skipped:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      * platform/wincairo/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ef17682
    • yutak@chromium.org's avatar
      [Qt] Enable WebSocket hybi tests · 386ca6bb
      yutak@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72687
      
      Reviewed by Simon Hausmann.
      
      Source/WebKit/qt:
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::defaultHixie76WebSocketProtocolEnabled):
      (DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled):
      Call WebCore::Settings::setUseHixie76WebSocketProtocol() to switch WebSocket protocols.
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Tools:
      
      Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::WebPage::resetSettings):
      * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
      (LayoutTestController::overridePreference):
      
      LayoutTests:
      
      * platform/qt/Skipped:
      Unskip WebSocket hybi tests. Skip some of them which are known to fail probably due to
      a bug in SocketStreamHandleQt implementation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      386ca6bb
    • ossy@webkit.org's avatar
      [Qt] fast/canvas/canvas-lineWidth.html timeouts intermittently on 64 bit · 1f1ecc67
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72694
      
      * platform/qt/Skipped: Skip fast/canvas/canvas-lineWidth.html until fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f1ecc67
    • loki@webkit.org's avatar
      [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore · 5f76c2e7
      loki@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72602
      
      Unskip tests after the fix on Qt.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f76c2e7
  4. 17 Nov, 2011 4 commits
  5. 16 Nov, 2011 6 commits
  6. 15 Nov, 2011 8 commits
  7. 14 Nov, 2011 2 commits
  8. 11 Nov, 2011 3 commits
    • commit-queue@webkit.org's avatar
      Update expected results for composited canvas operations · d0b58d2c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71995
      
      Patch by Ben Wells <benwells@chromium.org> on 2011-11-11
      Reviewed by Kenneth Russell.
      
      * canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
      * canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
      * platform/chromium/test_expectations.txt:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0b58d2c
    • zimmermann@webkit.org's avatar
      2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com> · e6f7204f
      zimmermann@webkit.org authored
              [Qt] 4 new tests fail introduced in r98852
              https://bugs.webkit.org/show_bug.cgi?id=71253
      
              Reviewed by Zoltan Herczeg.
      
              Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
              This is the same fix I applied to the svg/zoom/page tests, I forgot this one.
      
              * fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
              * fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
              * platform/qt/Skipped: Unskip last regression from bug 7153.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6f7204f
    • zimmermann@webkit.org's avatar
      2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com> · 5334860c
      zimmermann@webkit.org authored
              Zooming in SVGs in <object> is flakey
              https://bugs.webkit.org/show_bug.cgi?id=71673
      
              Reviewed by Zoltan Herczeg.
      
              Add another minimal testcase using <object> embedding SVGs + zooming.
      
              * platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
              * platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
              * platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
              * svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
              * svg/zoom/page/zoom-svg-as-object.html: Added.
      
      2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Zooming in SVGs in <object> is flakey
              https://bugs.webkit.org/show_bug.cgi?id=71673
      
              Reviewed by Zoltan Herczeg.
      
              It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
              Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
              though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.
      
              If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the 
              visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
              FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
              RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.
      
              If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
              may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
              "visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
              of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().
      
              If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
              By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.
      
              The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
              sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
              as overflow "hidden" already.
      
              The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
              we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
              if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.
      
              That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
              All svg/overflow tests, still work as expected.
      
              Test: svg/zoom/page/zoom-svg-as-object.html
      
              * page/Frame.cpp:
              (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
              * page/FrameView.cpp:
              (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.
                                                             Otherwise scrollbars will appear, even though the contents would fit without them.
              (WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has
                                                                      an effect though, when the FrameView of the SVG is embedded through <object>/etc.
              (WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.
              * rendering/svg/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before!
              (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument.
              (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
              * rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5334860c
  9. 09 Nov, 2011 3 commits
  10. 08 Nov, 2011 2 commits
  11. 07 Nov, 2011 3 commits