- 24 Feb, 2011 40 commits
-
-
jamesr@google.com authored
Unreviewed, rolling out r79584. http://trac.webkit.org/changeset/79584 https://bugs.webkit.org/show_bug.cgi?id=44797 [chromium] Patch does not compile if ENABLE_FULLSCREEN_API is not set * WebCore.gyp/WebCore.gyp: * WebCore.gypi: 2011-02-24 James Robinson <jamesr@chromium.org> Unreviewed, rolling out r79584. http://trac.webkit.org/changeset/79584 https://bugs.webkit.org/show_bug.cgi?id=44797 [chromium] Patch does not compile if ENABLE_FULLSCREEN_API is not set * features.gypi: * public/WebSettings.h: * src/ChromeClientImpl.cpp: * src/ChromeClientImpl.h: * src/WebSettingsImpl.cpp: * src/WebSettingsImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. Do not cache the default cairo font options using a static variable. It fixes a memory leak reported by valgrind. * platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::getDefaultFontOptions): (WebCore::FontPlatformData::initializeWithFontFace): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
atwilson@chromium.org authored
Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * WebCore.exp.in: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * public/WebFrame.h: * src/WebFrameImpl.cpp: * src/WebFrameImpl.h: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * WebView/WebFrame.mm: * WebView/WebFramePrivate.h: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * WebCoreSupport/DumpRenderTreeSupportQt.cpp: * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * Interfaces/IWebFramePrivate.idl: * Interfaces/WebKit.idl: * WebFrame.cpp: * WebFrame.h: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: 2011-02-24 Andrew Wilson <atwilson@chromium.org> Unreviewed, rolling out r79570. http://trac.webkit.org/changeset/79570 https://bugs.webkit.org/show_bug.cgi?id=54874 Breaks chromium build because glue/mocks/mock_web_frame.h/cc was not updated * DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): * DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::reset): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=55086 Reviewed by Adam Roben and looked over by Jessie Berlin. This patch adds the plumbing and classes that are needed to manage cookies from the web process. The functions that the API calls are currently stubs, but will be implemented in a follow-up patch. Project file changes. * DerivedSources.make: * DerivedSources.pro: * GNUmakefile.am: * WebKit2.pri: * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: * win/WebKit2Common.vsprops: * win/WebKit2Generated.make: Add some needed plumbing for WebCookieManager{Proxy}. * Platform/CoreIPC/MessageID.h: * Shared/API/c/WKBase.h: * Shared/APIObject.h: * UIProcess/API/C/WKAPICast.h: * UIProcess/API/C/WKContext.cpp: (WKContextGetCookieManager): Gets the cookie manager proxy. * UIProcess/API/C/WKContext.h: * UIProcess/API/C/WKCookieManager.cpp: Added. (WKCookieManagerGetTypeID): (WKCookieManagerGetHostnamesWithCookies): Calls through to WebCookieManagerProxy. (WKCookieManagerDeleteCookiesForHostname): Ditto. (WKCookieManagerDeleteAllCookies): Ditto. * UIProcess/API/C/WKCookieManager.h: Added. * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didReceiveMessage): Add a case for the cookie manager. * UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Initialize the cookie manager. (WebKit::WebContext::~WebContext): Invalidate the cookie manager. (WebKit::WebContext::disconnectProcess): Ditto. (WebKit::WebContext::didReceiveMessage): Add a case for the cookie manager. * UIProcess/WebContext.h: (WebKit::WebContext::cookieManagerProxy): Returns the cookie manager. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::didReceiveMessage): Add a case for the cookie manager. * UIProcess/WebCookieManagerProxy.cpp: Added. (WebKit::WebCookieManagerProxy::create): (WebKit::WebCookieManagerProxy::WebCookieManagerProxy): (WebKit::WebCookieManagerProxy::~WebCookieManagerProxy): (WebKit::WebCookieManagerProxy::invalidate): (WebKit::WebCookieManagerProxy::didReceiveMessage): (WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Call through to the web process to get hostnames with cookies. (WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies): Call the callback we were passed in getHostnamesWithCookies. (WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Call through to the web process to delete cookies for the origin. (WebKit::WebCookieManagerProxy::deleteAllCookies): Call through to the web process to delete all cookies. * UIProcess/WebCookieManagerProxy.h: Added. (WebKit::WebCookieManagerProxy::clearContext): (WebKit::WebCookieManagerProxy::type): * UIProcess/WebCookieManagerProxy.messages.in: Added. * WebProcess/Cookies: Added. * WebProcess/Cookies/WebCookieManager.cpp: Added. (WebKit::WebCookieManager::shared): (WebKit::WebCookieManager::WebCookieManager): (WebKit::WebCookieManager::didReceiveMessage): Call through to didReceiveWebCookieManagerMessage. (WebKit::WebCookieManager::getHostnamesWithCookies): Build an array from a HashSet (that isn't filled yet), and convert that HashSet to a Vector to send to the UI process. (WebKit::WebCookieManager::deleteCookiesForHostname): Added a stub. (WebKit::WebCookieManager::deleteAllCookies): Ditto. * WebProcess/Cookies/WebCookieManager.h: Added. * WebProcess/Cookies/WebCookieManager.messages.in: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default. fullscreen javascript bindings not implemented for v8 https://bugs.webkit.org/show_bug.cgi?id=44797 Tested by the existing fullscreen Layout Tests. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: 2011-02-24 David Dorwin <ddorwin@chromium.org> Reviewed by Eric Seidel. Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default. fullscreen javascript bindings not implemented for v8 https://bugs.webkit.org/show_bug.cgi?id=44797 * features.gypi: * public/WebSettings.h: * src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::supportsFullScreenForElement): (WebKit::ChromeClientImpl::enterFullScreenForElement): (WebKit::ChromeClientImpl::exitFullScreenForElement): (WebKit::ChromeClientImpl::fullScreenRendererChanged): * src/ChromeClientImpl.h: * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setFullScreenEnabled): * src/WebSettingsImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs. https://bugs.webkit.org/show_bug.cgi?id=55131 * http/tests/inspector/inspector-test.js: * inspector/elements/dom-agent-query-selector-expected.txt: Added. * inspector/elements/dom-agent-query-selector.html: Added. 2011-02-24 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: move querySelectorAll from CSS agent to DOM agent where it belongs. https://bugs.webkit.org/show_bug.cgi?id=55131 Test: inspector/elements/dom-agent-query-selector.html * inspector/Inspector.idl: * inspector/InspectorCSSAgent.cpp: * inspector/InspectorCSSAgent.h: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeToSelectOn): (WebCore::InspectorDOMAgent::querySelector): (WebCore::InspectorDOMAgent::querySelectorAll): * inspector/InspectorDOMAgent.h: * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): * inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleModel.prototype.addRule): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Darin Adler. Remove obsolete PLATFORM(CI) https://bugs.webkit.org/show_bug.cgi?id=55082 * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alex@webkit.org authored
2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com> Reviewed by Martin Robinson. [GTK] Implement WebEventFactory, WebErrors classes for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=48510 Exported static functions for GTK, we need them to create events in WebKit2. * platform/PlatformKeyboardEvent.h: * platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::keyIdentifierForGdkKeyCode): (WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): (WebCore::PlatformKeyboardEvent::singleCharacterString): 2011-02-24 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com> Reviewed by Martin Robinson. [GTK] Implement WebEventFactory, WebErrors classes for WebKit2 https://bugs.webkit.org/show_bug.cgi?id=48510 * GNUmakefile.am: * Shared/gtk/WebEventFactory.cpp: Added. implementation for WebMouseEvent, WebWheelEvent, WebKeyboardEvent. * Shared/gtk/WebEventFactory.h: Added. * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp: Added. Stubbed implementation for GTK port. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [GTK] Remove the GFile GOwnPtr specialization https://bugs.webkit.org/show_bug.cgi?id=55154 Remove the GFile specialization of GOwnPtr. It's sufficient to use GRefPtr to track GFiles since they are just regular reference-counted GObjects. * wtf/gobject/GOwnPtr.cpp: Remove GFile specialization. * wtf/gobject/GOwnPtr.h: Ditto. 2011-02-24 Martin Robinson <mrobinson@igalia.com> Reviewed by Xan Lopez. [GTK] Remove the GFile GOwnPtr specialization https://bugs.webkit.org/show_bug.cgi?id=55154 Convert uses of GOwnPtr<GFile> to GRefPtr<GFile>. No new tests. This should not change behavior. * plugins/gtk/PluginPackageGtk.cpp: Fix include order and remove unnecessary include. (WebCore::PluginPackage::load): Use GRefPtr for GFile instead of GOwnPtr. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added. * platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.png: Added. * platform/win-xp/fast/text/backslash-to-yen-sign-euc-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Eric Seidel. Rename PLATFORM(SKIA) to USE(SKIA) https://bugs.webkit.org/show_bug.cgi?id=55090 * wtf/Platform.h: 2011-02-24 Patrick Gansterer <paroga@webkit.org> Reviewed by Eric Seidel. Rename PLATFORM(SKIA) to USE(SKIA) https://bugs.webkit.org/show_bug.cgi?id=55090 * config.h: Removed second define of PLATFORM(SKIA). * html/HTMLCanvasElement.cpp: * platform/graphics/FloatPoint.h: * platform/graphics/FloatRect.h: * platform/graphics/Gradient.cpp: * platform/graphics/Gradient.h: * platform/graphics/GraphicsContext.cpp: * platform/graphics/GraphicsContext.h: * platform/graphics/ImageSource.h: * platform/graphics/IntPoint.h: * platform/graphics/IntRect.h: * platform/graphics/Path.h: * platform/graphics/Pattern.cpp: * platform/graphics/Pattern.h: * platform/graphics/chromium/ContentLayerChromium.cpp: * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/GLES2Canvas.cpp: * platform/graphics/chromium/ImageLayerChromium.cpp: * platform/graphics/chromium/LayerChromium.cpp: * platform/graphics/chromium/LayerRendererChromium.cpp: * platform/graphics/chromium/LayerRendererChromium.h: * platform/graphics/chromium/LayerTilerChromium.cpp: * platform/graphics/chromium/ShaderChromium.h: * platform/graphics/gpu/LoopBlinnPathProcessor.cpp: * platform/graphics/transforms/AffineTransform.h: * platform/graphics/transforms/TransformationMatrix.h: * platform/image-decoders/ImageDecoder.cpp: * platform/image-decoders/ImageDecoder.h: * rendering/svg/RenderSVGResourceSolidColor.cpp: 2011-02-24 Patrick Gansterer <paroga@webkit.org> Reviewed by Eric Seidel. Rename PLATFORM(SKIA) to USE(SKIA) https://bugs.webkit.org/show_bug.cgi?id=55090 * src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): * src/GraphicsContext3DInternal.h: * src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alex@webkit.org authored
Rubber-stamped by Martin Robinson. Fixed compilation after r79537, added a bug to solve webkit2 translations: https://bugs.webkit.org/show_bug.cgi?id=55153 * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: follow up to 79566. USE_PARAM not declared https://bugs.webkit.org/show_bug.cgi?id=55155 * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::currentCallFrame): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::currentCallFrameCallback): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Laszlo Gombos. [Qt] add android 2.2 user agent to QtTestBrowser https://bugs.webkit.org/show_bug.cgi?id=55085 Credit to Forrest Hodgkins to find right user-agent which works for youtube. * QtTestBrowser/useragentlist.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
Reviewed by Simon Fraser. Add support for missing properties to getComputedStyle https://bugs.webkit.org/show_bug.cgi?id=23668 Test getComputedStyle for the content, counter and outline-offset properties. * fast/css/getComputedStyle/computed-style-properties-expected.txt: Added. * fast/css/getComputedStyle/computed-style-properties.html: Added. 2011-02-24 Emil A Eklund <eae@chromium.org> Reviewed by Simon Fraser. Add support for missing properties to getComputedStyle https://bugs.webkit.org/show_bug.cgi?id=23668 Implement getComputedStyle for the content, counter and outline-offset properties. Test: fast/css/getComputedStyle/computed-style-properties.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::contentToCSSValue): (WebCore::counterToCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): * css/CSSPrimitiveValue.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
This makes our behavior match Mac more closely, and allows us to remove an incorrect assertion that was firing during some tests. (The assertion was claiming that there was never more than one delegate with delayed work to process, but that was not the case.) Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone when running http/tests/navigation/back-twice-without-commit.html Reviewed by Eric Carlson. * DumpRenderTree/win/FrameLoadDelegate.cpp: (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to process. A single delegate may appear in this Vector more than once (just as, on Mac, a single delegate may have multiple performSelector requests). (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an assertion that the timer firing is the shared process work timer. Instead of using the single, global "delegate waiting for timer" delegate, give all delegates that have delayed work to process a chance to process their work. (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork Vector so our processWork function will be called when the timer fires. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. SegmentedString does not need an m_composite member https://bugs.webkit.org/show_bug.cgi?id=55083 Storing m_composite as distinct from m_substrings.isEmpty() was just error prone and eventually going to get us in trouble. I also cleaned up some of the style in SegementedString.* since this file long predates check-webkit-style. * platform/text/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::length): (WebCore::SegmentedString::setExcludeLineNumbers): (WebCore::SegmentedString::clear): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::advanceSubstring): (WebCore::SegmentedString::toString): * platform/text/SegmentedString.h: (WebCore::SegmentedSubstring::SegmentedSubstring): (WebCore::SegmentedSubstring::appendTo): (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::isComposite): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
Not reviewed. * platform/mac/FileSystemMac.mm: Add include. It should have originally been added with r76614. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Alexey Proskuryakov. DumpRenderTree should reset frame opener between tests. https://bugs.webkit.org/show_bug.cgi?id=54874 No new tests. (no code affected, just exporting a method for DumpRenderTree use) * WebCore.exp.in: 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org> Reviewed by Alexey Proskuryakov. DumpRenderTree should reset frame opener between tests. https://bugs.webkit.org/show_bug.cgi?id=54874 Added clearOpener method to WebFrame. * public/WebFrame.h: * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::clearOpener): * src/WebFrameImpl.h: 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org> Reviewed by Alexey Proskuryakov. DumpRenderTree should reset frame opener between tests. https://bugs.webkit.org/show_bug.cgi?id=54874 Added clearOpener method to DumpRenderTreeSupportGTK. * WebCoreSup...
-
krit@webkit.org authored
Reviewed by Darin Adler. Removing a SVG animation target during animation crashes WebKit https://bugs.webkit.org/show_bug.cgi?id=12065 SVGAnimations with IRI references via 'xlink:href' are slow https://bugs.webkit.org/show_bug.cgi?id=49437 Test that WebKit does not crash, if the target element of a SVG animation gets removed, or if its id changed. * platform/mac/svg/custom/animate-target-id-changed-expected.checksum: Added. * platform/mac/svg/custom/animate-target-id-changed-expected.png: Added. * platform/mac/svg/custom/animate-target-id-changed-expected.txt: Added. * platform/mac/svg/custom/animate-target-removed-from-document-expected.checksum: Added. * platform/mac/svg/custom/animate-target-removed-from-document-expected.png: Added. * platform/mac/svg/custom/animate-target-removed-from-document-expected.txt: Added. * svg/custom/animate-target-id-changed.svg: Added. * svg/custom/animate-target-removed-from-document.svg: Added. 2011-02-24 Dirk Schulze <krit@webkit.org> Reviewed by Darin Adler. Removing a SVG animation target during animation crashes WebKit https://bugs.webkit.org/show_bug.cgi?id=12065 SVGAnimations with IRI references via 'xlink:href' are slow https://bugs.webkit.org/show_bug.cgi?id=49437 Store reference to target element for SVG animation elements. This is important if the target gets referenced via 'xlink:href'. At the moment we would call getElementById() multiple times on every animation step. A very expensive operation. This will be avoided with this patch. On the other hand, we need to be sure that the target element is always valid. The reference is reset, if the target was removed from document or its destructor was called. A HashMap in SVGDocumentExtensions stores all mappings from target element to all current animation elements. Tests: svg/custom/animate-target-id-changed.svg svg/custom/animate-target-removed-from-document.svg * svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): (WebCore::SVGDocumentExtensions::addAnimationElementToTarget): New animation gets applied to target. (WebCore::SVGDocumentExtensions::removeAnimationElementFromTarget): Animation stoped, remove it from HashMap. (WebCore::SVGDocumentExtensions::removeAllAnimationElementsFromTarget): Target no longer in document, reset all references in SVG animation elements. * svg/SVGDocumentExtensions.h: * svg/SVGElement.cpp: (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::removedFromDocument): (WebCore::SVGElement::attributeChanged): * svg/SVGElement.h: * svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::removedFromDocument): * svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::removedFromDocument): * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement): (WebCore::SVGSMILElement::removedFromDocument): (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::targetElement): * svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::resetTargetElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Eric Seidel. REGRESSION: Accelerated transitions are jumpy https://bugs.webkit.org/show_bug.cgi?id=55022 When an accelerated transition used the default timing function, a typo in toCAMediaTimingFunction() resulting in the incorrect timing function being used. Test: transitions/default-timing-function.html * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: (toCAMediaTimingFunction): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Remove bogus optimizations in TextBreakIteratorQt https://bugs.webkit.org/show_bug.cgi?id=55139 Let QTextBoundaryFinder hold a deep copy of the string data it's operating on, and don't use the same working buffer for all iterators. * platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::TextBreakIterator::TextBreakIterator): (WebCore::setUpIterator): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Text editor] Bug in the highlighter https://bugs.webkit.org/show_bug.cgi?id=54876 Fixing two bugs: 1) When restoring the state from a successful updateHighlight() call, we should restore the old state only if it is greater (closer to the end) than the current one. 2) When a long line is being highlighted in more than one chunk (timer tick), we wrongly deleted the result of the work done in the previous tick, rather than updating it with the new results. * inspector/editor/highlighter-long-line-expected.txt: Added. * inspector/editor/highlighter-long-line.html: Added. * inspector/editor/highlighter-paste-in-comment-expected.txt: Added. * inspector/editor/highlighter-paste-in-comment.html: Added. * inspector/editor/highlighter-test.js: Added. (initialize_HighlighterTests.InspectorTest.dumpTextModel): (initialize_HighlighterTests): 2011-02-24 Andrey Adaikin <aandrey@google.com> Reviewed by Pavel Feldman. Web Inspector: [Text editor] Bug in the highlighter https://bugs.webkit.org/show_bug.cgi?id=54876 Tests: inspector/editor/highlighter-long-line.html inspector/editor/highlighter-paste-in-comment.html * inspector/front-end/TextEditorHighlighter.js: (WebInspector.TextEditorHighlighter): (WebInspector.TextEditorHighlighter.prototype.set highlightChunkLimit): (WebInspector.TextEditorHighlighter.prototype.updateHighlight): (WebInspector.TextEditorHighlighter.prototype._highlightLines): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simonjam@chromium.org authored
Reviewed by Tony Gentilcore. [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect https://bugs.webkit.org/show_bug.cgi?id=55068 * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Expect navStart and unload to be zero. * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Expect navStart to be zero. * http/tests/misc/webtiming-origins-expected.txt: 2011-02-24 James Simonsen <simonjam@chromium.org> Reviewed by Tony Gentilcore. [Web Timing] Zero out navigationStart and unloadEvent on cross-origin redirect https://bugs.webkit.org/show_bug.cgi?id=55068 Test: http/tests/misc/webtiming-origins.html * page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart): Zero out on cross origin redirect. (WebCore::PerformanceTiming::unloadEventStart): Ditto. (WebCore::PerformanceTiming::unloadEventEnd): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
paroga@webkit.org authored
Reviewed by Alexey Proskuryakov. Remove pthreads dependecy for JSLock https://bugs.webkit.org/show_bug.cgi?id=54832 JSLock is only needed to support an obsolete execution model where JavaScriptCore automatically protected against concurrent access from multiple threads. So it's safe to disable it on non-mac platforms where we don't have native pthreads. * runtime/JSLock.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Fisher. [chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier https://bugs.webkit.org/show_bug.cgi?id=54516 Give Chromium's NetworkStateNotifier the ability to change the value of m_isOnLine, rather than making it always true. No new tests, not sure how to test this. No other LayoutTests seem to exercise navigator.onLine. * WebCore.gypi: * platform/network/NetworkStateNotifier.cpp: (WebCore::NetworkStateNotifier::setOnLine): Moved and renamed from NetworkStateNotifierAndroid. * platform/network/NetworkStateNotifier.h: (WebCore::NetworkStateNotifier::networkStateChange): Forward to setOnLine. * platform/network/android/NetworkStateNotifierAndroid.cpp: Removed. * platform/network/chromium/NetworkStateNotifierChromium.cpp: Removed. * platform/network/chromium/NetworkStateNotifierPrivate.h: Removed. 2011-02-24 Adam Klein <adamk@chromium.org> Reviewed by Darin Fisher. [chromium] Add code to WebKit Chromium to allow access to NetworkStateNotifier https://bugs.webkit.org/show_bug.cgi?id=54516 Add a new WebNetworkStateNotifier class with a single static method, setOnLine(), which dispatches to WebCore's singleton NetworkStateNotifier. * WebKit.gyp: * public/WebNetworkStateNotifier.h: Added. * src/WebNetworkStateNotifier.cpp: Added. (WebKit::WebNetworkStateNotifier::setOnLine): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
benjamin.poulain@nokia.com authored
Reviewed by Eric Seidel. Support building WebKit with Python 3 https://bugs.webkit.org/show_bug.cgi?id=55038 Add support for Python 3 without breaking support for Python 2. Main issues: -print is a function in Python 3 -list.sort() no longer have the cmp parameter -string.uppercase and string.lowercase have been removed * html/parser/create-html-entity-table: 2011-02-24 Benjamin Poulain <benjamin.poulain@nokia.com> Reviewed by Eric Seidel. Support building WebKit with Python 3 https://bugs.webkit.org/show_bug.cgi?id=55038 Update the generator scripts to support Python 3. * Scripts/generate-message-receiver.py: print is a function in Python 3, write the output to sys.stdout to be compatible with Python 2 and 3. * Scripts/generate-messages-header.py: * Scripts/webkit2/messages.py: dist.iteritems does not e...
-
aroben@apple.com authored
Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440, but did Reviewed by Anders Carlsson. * Scripts/webkitpy/common/config/build.py: (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in. * Scripts/webkitpy/common/config/build_unittest.py: (ShouldBuildTest): Added some more tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Unreviewed, fix bad expectation for new test added in r79555. * inspector/debugger/scripts-panel-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
Reviewed by Eric Seidel. AX: WebKit should expose MathML at least as well as it exposes ARIA role="math" https://bugs.webkit.org/show_bug.cgi?id=55049 * platform/mac/accessibility/math-alttext-expected.txt: Added. * platform/mac/accessibility/math-alttext.html: Added. 2011-02-24 Chris Fleizach <cfleizach@apple.com> Reviewed by Eric Seidel. AX: WebKit should expose MathML at least as well as it exposes ARIA role="math" https://bugs.webkit.org/show_bug.cgi?id=55049 Make <math> elements behave as ARIA math roles and use MathML::alttext as a possible accessible label. Test: platform/mac/accessibility/math-alttext.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityDescription): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * mathml/mathattrs.in: git-svn-id: http:/...
-
loislo@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: adjust protocol message format according to spec. https://bugs.webkit.org/show_bug.cgi?id=55140 * inspector/CodeGeneratorInspector.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* platform/network/cf/AuthenticationCF.cpp: Add an extra #include as a workaround for <rdar://problem/9042114>. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: refactor inspect() workflow so that it did not push dom nodes. https://bugs.webkit.org/show_bug.cgi?id=55057 * http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): * inspector/console/command-line-api-inspect-expected.txt: Added. * inspector/console/command-line-api-inspect.html: Added. 2011-02-23 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: refactor inspect() workflow so that it did not push dom nodes. https://bugs.webkit.org/show_bug.cgi?id=55057 Test: inspector/console/command-line-api-inspect.html I am working on getting rid of DOM agent pushes - everything should happen upon front-end request. This patch changes the way we handle inspect() command line api: instead of pushing nodes, we are telling front-end that inspect(object) has been requested. It is then up to front-end to request dom nodes and focus them in the tree. I also made inspect() work in a generic manner, using same routines for nodes, databases, storages and potentially new elements. As a side-effect, we don't do console.log from within inspect() anymore, but dump inspected value as inspect's result. Also, I added individual object release method and made object groups optional. * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::scriptValueAsNode): (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::JSInjectedScriptHost::inspect): (WebCore::JSInjectedScriptHost::databaseId): (WebCore::JSInjectedScriptHost::storageId): * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::scriptValueAsNode): (WebCore::InjectedScriptHost::nodeAsScriptValue): (WebCore::V8InjectedScriptHost::inspectCallback): (WebCore::V8InjectedScriptHost::databaseIdCallback): (WebCore::V8InjectedScriptHost::storageIdCallback): * inspector/InjectedScript.cpp: (WebCore::InjectedScript::nodeForObjectId): (WebCore::InjectedScript::releaseObject): (WebCore::InjectedScript::wrapForConsole): (WebCore::InjectedScript::inspectNode): * inspector/InjectedScript.h: * inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::inspectImpl): (WebCore::InjectedScriptHost::databaseIdImpl): (WebCore::InjectedScriptHost::storageIdImpl): * inspector/InjectedScriptHost.h: * inspector/InjectedScriptHost.idl: * inspector/InjectedScriptSource.js: * inspector/Inspector.idl: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::focusNode): * inspector/InspectorDOMAgent.cpp: * inspector/InspectorDOMAgent.h: * inspector/InspectorDOMStorageAgent.cpp: (WebCore::InspectorDOMStorageAgent::storageId): (WebCore::InspectorDOMStorageAgent::didUseDOMStorage): * inspector/InspectorDOMStorageAgent.h: * inspector/InspectorDOMStorageResource.cpp: * inspector/InspectorDOMStorageResource.h: * inspector/InspectorDatabaseAgent.cpp: (WebCore::InspectorDatabaseAgent::databaseId): * inspector/InspectorDatabaseAgent.h: * inspector/InspectorDatabaseResource.cpp: * inspector/InspectorDatabaseResource.h: * inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::releaseObject): * inspector/InspectorRuntimeAgent.h: * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): * inspector/front-end/DOMStorage.js: * inspector/front-end/Database.js: * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage): * inspector/front-end/inspector.js: (WebInspector.inspect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
podivilov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: refactor "script or resource" mess in scripts panel. https://bugs.webkit.org/show_bug.cgi?id=54961 - Use sourceName instead of scriptOrResource - Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are calling each other recursively with small one-purpose non-recursive functions * http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource): * http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.assertEquals): (initialize_InspectorTest.InspectorTest.safeWrap): * inspector/debugger/resources/script1.js: Added. (f1): * inspector/debugger/resources/script2.js: Added. (f2): * inspector/debugger/resources/script3.js: Added. (f3): * inspector/debugger/scripts-panel-expected.txt: Added. * inspector/debugger/scripts-panel.html: Added. 2011-02-22 Pavel Podivilov <podivilov@chromium.org> Reviewed by Pavel Feldman. Web Inspector: refactor "script or resource" mess in scripts panel. https://bugs.webkit.org/show_bug.cgi?id=54961 - Use sourceName instead of scriptOrResource - Replace two huge functions _addScriptToFilesMenu and _showScriptOrResource that are calling each other recursively with small one-purpose non-recursive functions Test: inspector/debugger/scripts-panel.html * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare): (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype.showSourceLine): (WebInspector.ScriptsPanel.prototype._showSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameForSourceName): (WebInspector.ScriptsPanel.prototype._recreateSourceFrame): (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded): (WebInspector.ScriptsPanel.prototype._addItemToBackForwardList): (WebInspector.ScriptsPanel.prototype._sourceNameForScript): (WebInspector.ScriptsPanel.prototype._scriptForSourceName): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._filesSelectChanged): (WebInspector.ScriptsPanel.prototype._goBack): (WebInspector.ScriptsPanel.prototype._goForward): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.setExecutionLine): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Fragment parsing does not need to use HTMLSourceTracker https://bugs.webkit.org/show_bug.cgi?id=55011 Remove support of XSS-filtering innerHTML content. * http/tests/security/xssAuditor/dom-write-innerHTML-expected.txt: 2011-02-24 Eric Seidel <eric@webkit.org> Reviewed by Adam Barth. Fragment parsing does not need to use HTMLSourceTracker https://bugs.webkit.org/show_bug.cgi?id=55011 Any performance gains from this patch are likely the result of working around: https://bugs.webkit.org/show_bug.cgi?id=55005 (Which suggests that fixing bug 55005 will speed up normal HTML parsing substantially.) Assuming I ran the numbers correct, here is the change from PerformanceTests/Parser/tiny-innerHTML: Before patch: avg 5586.1 median 5594 stdev 41.295157101045135 min 5425 max 5633 After Patch: avg 2603.9 median 2609.5 stdev 32.500615378789355 min 2475 max 2649 Removing just the HTMLSourceTracker calls brought our score from 5500 to 5200, removing the XSSFilter as well brought it to 2600 on my machine. * html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer): * html/parser/HTMLDocumentParser.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed: beautified inspector test suite output. * http/tests/inspector/debugger-test.js: (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner): (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite): * http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): * inspector/debugger/source-frame-expected.txt: * inspector/elements/insert-node-collapsed-expected.txt: * inspector/elements/insert-node-expected.txt: * inspector/elements/modify-chardata-expected.txt: * inspector/elements/remove-node-expected.txt: * inspector/elements/set-attribute-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Andreas Kling. [Qt] tst_QWebView::setPalette(activeFG) fails https://bugs.webkit.org/show_bug.cgi?id=55029 This time it should be the proper fix. The window needs to be shown before we call activateWindow() otherwise there is no active windows for the application. * tests/qwebview/tst_qwebview.cpp: (tst_QWebView::setPalette): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Fix MIPS build with new patchOffsetPut/GetByIdPropertyMapOffset1/2 values https://bugs.webkit.org/show_bug.cgi?id=54997 * jit/JIT.h: * jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, skipping crashing test on GTK * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Unreviewed Chromium Mac test expectations update. fast/text/shadow-no-blur.html has been passing for a while. http tests have been passing since r79279. media/video-display-toggle.html has been passing since r79415. svg/text/font-size-below-point-five.svg has been passing since r78844. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-