1. 18 Oct, 2006 22 commits
    • ggaren's avatar
      LayoutTests: · 2ebab006
      ggaren authored
              Reviewed by Beth.
              Updated some results now that some global JS objects repeatably report their
              statically declared properties.
              * fast/js/window-properties-expected.txt:
              * fast/js/window-properties.html:
              Reviewed by Beth.
              Fixed http://bugs.webkit.org/show_bug.cgi?id=11222
              Some global JS objects lacked references to their property hashtables,
              so for-in enumeration didn't work. I added the references, and then removed
              a few bogus properties from the tables. The bogus ones got in there through
              bit rot.
              We should come up with some solution to these hand-written bindings bugs.
              Maybe we could use a script to autogenerate them or something.
              * bindings/js/kjs_window.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      Reviewed by Maciej. · b6b8ea01
      aroben authored
              Fix: http://bugs.webkit.org/show_bug.cgi?id=11342
              fast/repaint/4774354 is failing
              It seems that this test got checked in with incorrect results, as it
              has been failing since its introduction in r17093.
              * fast/repaint/4774354-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      LayoutTests: · 92b81413
      aroben authored
              Reviewed by Brady.
              New test to make sure we're generating the correct keycodes for Tab
              and Shift-Tab keypresses.
              * fast/events/js-keyboard-event-creation-expected.txt: Added.
              * fast/events/js-keyboard-event-creation.html: Added.
              Reviewed by Brady.
              Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
              U+000019 (Backtab). This matches our windowsKeyCode for this key
              * platform/mac/KeyEventMac.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sfalken's avatar
      2006-10-18 Steve Falkenburg <sfalken@apple.com> · 62122fa6
      sfalken authored
              Reviewed by Adam, Brady.
              Loader tweaks.
              * platform/cf/ResourceLoaderCFNet.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      Reviewed by Brady. · 54d34471
      aroben authored
              Fix: http://bugs.webkit.org/show_bug.cgi?id=11344
              REGRESSION (r16741): webViewDidChangeSelection delegate not firing in
              2 layout tests
              The behavior for display-none-in-onchange-keyboard is still correct
              (we don't crash when the element about to receive focus gets
              display:none set), so I've just generated new results for it.
              The behavior of tabbing-input-iframe has changed a little. iframe
              elements are now in the tab order, so I've changed the test to take
              that into account and generated new results.
              * fast/forms/display-none-in-onchange-keyboard-expected.txt:
              * fast/forms/tabbing-input-iframe-expected.txt:
              * fast/forms/tabbing-input-iframe.html:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Darin. · f6788593
      thatcher authored
              <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
              - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
              - Convert more ObjC local statics and member variables to use RetainPtr.
              - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
              * bindings/objc/DOM.mm:
              (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
              (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
              * bridge/mac/AXObjectCacheMac.mm:
              (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
              (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
              (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
              * bridge/mac/WebCoreFrameBridge.mm:
              (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
              (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
              * bridge/mac/WebCoreIconDatabaseBridge.mm:
              (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
              * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
              * platform/cf/RetainPtr.h:
              (WTF::::operator): implement a missing operator= template function
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu): remove nil initialization
              (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
              (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
              (WebCore::PopupMenu::populate): ditto 
              (WebCore::PopupMenu::show): ditto
              (WebCore::PopupMenu::hide): ditto
              (WebCore::PopupMenu::addSeparator): ditto
              (WebCore::PopupMenu::addGroupLabel): ditto
              (WebCore::PopupMenu::addOption): ditto
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by Adele. · 733b5db8
      ggaren authored
              Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
              are tracking or menus are down (run loop modes)
              I spent a few hours trying to write an automated test, but DRT doesn't
              seem to support it. Manual tests attached to related bugs.
              * bridge/mac/FrameMac.mm:
              * platform/mac/SharedTimerMac.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2006-10-18 Mark Rowe <bdash@webkit.org> · 07201387
      bdash authored
              Reviewed by Tim H.
              Bug 11304: Drosera fails to link as universal binary on PowerPC machine
              * Drosera/Drosera.xcodeproj/project.pbxproj: Use -weak_framework to link against JavaScriptCore and WebCore directly
              when they are not part of the WebKit umbrella framework.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      WebCore: · 1eb32fed
      weinig authored
              Reviewed by Maciej.
              More Win32 buildfix.
              * bridge/win/FrameWin.h:
              Reviewed by Maciej.
              Win32 build fix.
              * COM/WebFrame.cpp:
              * COM/WebFrame.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      2006-10-18 Anders Carlsson <acarlsson@apple.com> · b5280f6c
      andersca authored
              Reviewed by Adam.
              REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
              Return ObjectElementFrame if the MIME type is one of the image ones we support.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by Mitz · 8efa4752
      weinig authored
              Win32 build fix.
              * bridge/win/BrowserExtensionWin.cpp:
              * bridge/win/BrowserExtensionWin.h:
              * bridge/win/FrameWin.cpp:
              * bridge/win/FrameWin.h:
              * platform/win/CursorWin.cpp:
              * platform/win/TemporaryLinkStubs.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      fixo el buildo II: Release's Pride. · 50df06f3
      aroben authored
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 67b6ea29
      justing authored
              Reviewed by harrison
              GMail Editor: Hang occurs when removing list styling on text in a rich text message
              * editing/execCommand/remove-list-1-expected.checksum: Added.
              * editing/execCommand/remove-list-1-expected.png: Added.
              * editing/execCommand/remove-list-1-expected.txt: Added.
              * editing/execCommand/remove-list-1.html: Added.
              Reviewed by harrison
              GMail Editor: Hang occurs when removing list styling on text in a rich text message
              List removal moves the contents of every list item out of the list it's 
              in. When the code tried to move the contents of an empty list item (an li 
              with no child nodes, not even a placeholder br), moveParagraph didn't prune 
              the li, like it would if the li had a placeholder inside it.  So the list 
              removal code went into an infinite loop, continually attempting to de-list 
              an empty list item.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): If the selection
              to move was empty and in an empty block that doesn't require a 
              placeholder to prop itself open (like a bordered div or an li), 
              remove it during the move.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 9f217b57
      justing authored
              Reviewed by harrison
              REGRESSION: Mail.app: smart deletion of words does not work
              * editing/deleting/smart-delete-003-expected.checksum: Added.
              * editing/deleting/smart-delete-003-expected.png: Added.
              * editing/deleting/smart-delete-003-expected.txt: Added.
              * editing/deleting/smart-delete-003.html: Added.
              * editing/deleting/smart-delete-004-expected.checksum: Added.
              * editing/deleting/smart-delete-004-expected.png: Added.
              * editing/deleting/smart-delete-004-expected.txt: Added.
              * editing/deleting/smart-delete-004.html: Added.
              Reviewed by harrison
              REGRESSION: Mail.app: smart deletion of words does not work
              Regressed when we pushed selecion expansion down into WebCore.  It's OK
              to try a smart delete from _deleteWithDirection:, which is called by
              deleteFoward: and deleteBackward: if the current selection is a 
              * WebView/WebHTMLView.m:
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      fixo el buildo. · a5b13f03
      ggaren authored
              Work around #import of <PDFKit/PDFView.h>.
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Beth. · dbea10d7
      adele authored
              - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
                REGRESSION (r16975): fast/events/objc-event-api is failing
                When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
                a call to invalidateClick.  This change moves it back to the sequence that existed before.  This allows
                the click count to get properly reset during a selection.
              * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Removing SVGZoomEvent.idl from Copy Resources. · 1ebde133
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullo's avatar
      Reviewed by Maciej. · 4fef9f72
      kmccullo authored
              Adjust include paths
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Tim H. · 5f0379c7
      thatcher authored
              Add Xcode 3 style inline breakpoint editor. Credit to xenon for the CSS wizardry to get the appearance working properly.
              * Drosera/Drosera.xcodeproj/project.pbxproj:
              * Drosera/Images/breakpointeditor.png: Added.
              * Drosera/breakpointEditor.css: Removed.
              * Drosera/breakpointEditor.html: Removed.
              * Drosera/breakpointEditor.js: Removed.
              * Drosera/debugger.js:
              * Drosera/viewer.css:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Tim H. · 8143d600
      thatcher authored
              Bug 11341: REGRESSION (r16760): editing/selection/editable-links is failing
              Link editing behavior became a preference. DumpRenderTree needs to specify the
              non-default behavior it wants (WebKitEditableLinkOnlyLiveWithShiftKey).
              * DumpRenderTree/DumpRenderTree.m:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aroben's avatar
      Reviewed by Maciej. · 7a82da6f
      aroben authored
              Fix: http://bugs.webkit.org/show_bug.cgi?id=11340
              editing/pasteboard/4641033 needs new results
              Update results after r17071.
              * editing/pasteboard/4641033-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by Anders. · 6f9abbc0
      ggaren authored
              Factored common scaling code into a helper function.
              * platform/mac/ScreenMac.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 17 Oct, 2006 18 commits
    • sfalken's avatar
      2006-10-17 Steve Falkenburg <sfalken@apple.com> · 3e6b89cc
      sfalken authored
              Build fixes
              * bridge/win/BrowserExtensionWin.cpp:
              * bridge/win/BrowserExtensionWin.h:
              * bridge/win/FrameWin.cpp:
              * bridge/win/FrameWin.h:
              * platform/gdk/BrowserExtensionGdk.h:
              * platform/gdk/TemporaryLinkStubs.cpp:
              * platform/qt/BrowserExtensionQt.cpp:
              * platform/qt/BrowserExtensionQt.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by Anders. · 269dfd5d
      ggaren authored
              Renamed WindowArgs to WindowFeatures, and moved it into its own header.
              ("Features" is the term of art in IE documentation. "Args" is pirate
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_window.cpp:
              * bridge/BrowserExtension.h:
              * bridge/WindowFeatures.h: Added.
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sfalken's avatar
      2006-10-17 Steve Falkenburg <sfalken@apple.com> · 714e8e9e
      sfalken authored
              Reviewed by Maciej.
              Adjust include paths
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by Tim H. · 742c4518
      weinig authored
              Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
              Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
              - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
              - Moves the contents of ksvg/bindings/js/ to bindings/js/.
              - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
              - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching 
                the other CSSValue classing, and allowing the bindings to allocate
              - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
                generation for Objective-C.
              - Assorted style cleanups.
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOMCSS.mm:
              (+[DOMCSSValue _CSSValueWith:WebCore::]):
              * bindings/objc/DOMEvents.mm:
              (+[DOMEvent _eventWith:WebCore::]):
              * bindings/objc/DOMSVG.h:
              * bindings/objc/DOMSVGNumber.mm:
              (-[DOMSVGNumber dealloc]):
              (-[DOMSVGNumber finalize]):
              (-[DOMSVGNumber value]):
              (-[DOMSVGNumber setValue:]):
              (-[DOMSVGNumber _SVGNumber]):
              (-[DOMSVGNumber _initWithFloat:]):
              (+[DOMSVGNumber _SVGNumberWith:]):
              * bindings/objc/DOMSVGPoint.mm:
              (-[DOMSVGPoint dealloc]):
              (-[DOMSVGPoint finalize]):
              (-[DOMSVGPoint x]):
              (-[DOMSVGPoint setX:]):
              (-[DOMSVGPoint y]):
              (-[DOMSVGPoint setY:]):
              (-[DOMSVGPoint WebCore::]):
              (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
              (+[DOMSVGPoint _SVGPointWith:WebCore::]):
              * bindings/objc/DOMSVGRect.mm:
              (-[DOMSVGRect dealloc]):
              (-[DOMSVGRect finalize]):
              (-[DOMSVGRect x]):
              (-[DOMSVGRect setX:]):
              (-[DOMSVGRect y]):
              (-[DOMSVGRect setY:]):
              (-[DOMSVGRect width]):
              (-[DOMSVGRect setWidth:]):
              (-[DOMSVGRect height]):
              (-[DOMSVGRect setHeight:]):
              (-[DOMSVGRect WebCore::]):
              (-[DOMSVGRect _initWithFloatRect:WebCore::]):
              (+[DOMSVGRect _SVGRectWith:WebCore::]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * css/StyleBase.h:
              * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
              * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
              * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
              * ksvg2/bindings/js/JSSVGNumber.h: Removed.
              * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
              * ksvg2/bindings/js/JSSVGPoint.h: Removed.
              * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
              * ksvg2/bindings/js/JSSVGRect.h: Removed.
              * ksvg2/svg/SVGColor.h:
              * ksvg2/svg/SVGFECompositeElement.idl:
              * ksvg2/svg/SVGFEFloodElement.idl:
              * ksvg2/svg/SVGLocatable.idl:
              * ksvg2/svg/SVGMarkerElement.idl:
              * ksvg2/svg/SVGPaint.h:
              * ksvg2/svg/SVGRectElement.idl:
              * ksvg2/svg/SVGZoomEvent.idl: Removed.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix changelog file list. It wasn't right. · 3e215203
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Prepare for the elimination of the RenderLayer for <html> elements. ... · ee2f551e
      hyatt authored
              Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
              but this patch makes everything work without a root layer being around.
              Reviewed by beth
              * WebCore.xcodeproj/project.pbxproj:
              * platform/KURL.cpp: Removed.
              * platform/KURL.h: Removed.
              * rendering/RenderBlock.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderObject.cpp:
              * rendering/RenderView.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Back out my previous patch to the WebCore memory cache. · 7c27fd53
      hyatt authored
              * loader/Cache.cpp:
              * loader/Cache.h:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              * loader/CachedResource.h:
              * loader/CachedScript.cpp:
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              * loader/CachedXSLStyleSheet.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2006-10-17 Oliver Hunt <oliver@apple.com> · 5790cc31
      oliver authored
              Reviewed by Anders.
              Make north and east resize cursors use correct image
              * platform/win/CursorWin.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2006-10-17 Oliver Hunt <oliver@apple.com> · 170f9afd
      oliver authored
              Reviewed by Brady
              Various cursor fixes
              * page/FrameView.cpp:
              * platform/Cursor.h:
              * platform/mac/CursorMac.mm:
              * platform/win/CursorWin.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 7d6f38b7
      justing authored
              Reviewed by harrison
              REGRESSION: In Mail, caret is visible when the message body isn't focused
              * editing/selection/4776665-expected.checksum: Added.
              * editing/selection/4776665-expected.png: Added.
              * editing/selection/4776665-expected.txt: Added.
              * editing/selection/4776665.html: Added.
              Reviewed by harrison
              REGRESSION: In Mail, caret is visible when the message body isn't focused
              * page/Frame.cpp:
              (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
              (like when the frame that contains the caret isn't focused) then we don't 
              want to paint the caret.  We should eventually move to using a single bool
              for caret painting.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 24714dfa
      justing authored
              Reviewed by harrison
              REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
              * fast/repaint/4774354-expected.checksum: Added.
              * fast/repaint/4774354-expected.png: Added.
              * fast/repaint/4774354-expected.txt: Added.
              * fast/repaint/4774354.html: Added.
              * fast/repaint/resources/contenteditable-iframe-src.html: Added.
              Reviewed by harrison
              REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
              Functions call recomputCaretRect to see if the caret rect has changed, 
              and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
              returning false if the caret turned into a range selection or was blown 
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::recomputeCaretRect): Don't early return if
              !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
              may now be null.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by Brady. · 84dc6664
      ggaren authored
              BrowserExtension cleanup.
              - Removed unnecessary #include of BrowserExtension in Frame.h, added
              #includes to compensate in other files.
              - Removed unused versions of createNewWindow.
              * bindings/js/kjs_window.cpp:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              * html/HTMLFormElement.cpp:
              * loader/mac/LoaderFunctionsMac.mm:
              * page/Frame.h:
              * page/FramePrivate.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullo's avatar
      Reviewed by Brady. · ac542a50
      kmccullo authored
              Fixes a JavaScriptCore math issue on win.
              * kjs/math_object.cpp:
              * wtf/MathExtras.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by Adam. · 2e40fc13
      ggaren authored
              - Fixed "FIXME: Violates Liskov Substitution principle."
              IFRAME was never a true subclass of FRAME, since they disagreed on a
              number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
              The fix here is to factor out things common to IFRAME and FRAME into a
              common base class, HTMLFrameElementBase.
              I also changed some " *" to "* " and added #includes in files that implicitly
              assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · ef699414
      justing authored
              Reviewed by sullivan
              REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
              * fast/repaint/4776765-expected.checksum: Added.
              * fast/repaint/4776765-expected.png: Added.
              * fast/repaint/4776765-expected.txt: Added.
              * fast/repaint/4776765.html: Added.
              Reviewed by sullivan
              REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
              We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
              the old caret rect.  It in fact corrects the caret rect for an offset that it 
              believes is due to scrolling but which is actually due to a change in selection
              without an accompanying layout.  So it returns the new caret rect regardless of
              what m_needsLayout is set to.
              * editing/SelectionController.cpp:
              (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
              adds a one pixel slop to this new function.
              (WebCore::SelectionController::caretRepaintRect): Moved this code to
              (WebCore::SelectionController::recomputeCaretRect): Compare the old
              caret rect to the new one that's computed with a fresh layout.  If
              they are different, invalidate both repaint rects.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aliceli1's avatar
      Reviewed by Tim Hatcher. · 9c23ab1c
      aliceli1 authored
              When nodes are removed, selections are cleared, and when http://bugs.webkit.org/show_bug.cgi?id=6498 was fixed, we started sending didChangeSelection notifications.  Updating the test results fixes some of the tests mentioned in http://bugs.webkit.org/show_bug.cgi?id=10924
              * fast/dynamic/move-node-with-selection-expected.txt:
              * fast/events/dblclick-addEventListener-expected.txt:
              * fast/events/updateLayoutForHitTest-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • harrison's avatar
      Reviewed by Adele. · 68b7972d
      harrison authored
              <rdar://problem/4770453> VO not honoring secure edit fields in web pages
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject isPasswordField]):
              New. Checks for input with inputType() of PASSWORD.
              (-[WebCoreAXObject subrole]):
              Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
              (-[WebCoreAXObject roleDescription]):
              Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
              (-[WebCoreAXObject value]):
              Return nil if [self isPasswordField].
              (-[WebCoreAXObject accessibilityAttributeNames]):
              Return generic attributes if [self isPasswordField].
              (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
              Return empty array if [self isPasswordField].
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • aliceli1's avatar
      Reviewed by aroben. · e1db0ba3
      aliceli1 authored
              updating test results after r17068 - http://bugs.webkit.org/show_bug.cgi?id=11320
              * fast/block/float/013-expected.checksum:
              * fast/block/float/013-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17080 268f45cc-cd09-0410-ab3c-d52691b4dbfc