1. 13 Apr, 2012 40 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r114185. · 2e652d98
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/114185
      https://bugs.webkit.org/show_bug.cgi?id=83967
      
      Broke a bunch of JavaScript related tests (Requested by
      andersca on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
      
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncToString):
      (JSC::arrayProtoFuncToLocaleString):
      * runtime/CommonIdentifiers.h:
      * tests/mozilla/ecma/Array/15.4.4.2.js:
      (getTestCases):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e652d98
    • commit-queue@webkit.org's avatar
      convolution-mono-mono test passes now · f816bc49
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83793
      
      Patch by Raymond Toy <rtoy@google.com> on 2012-04-13
      Reviewed by Eric Seidel.
      
      * platform/chromium/test_expectations.txt: Delete entry.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f816bc49
    • commit-queue@webkit.org's avatar
      AudioContext createChannelMerger() method should have optional argument for number of inputs. · 5d34efbd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83759
      
      Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
      Reviewed by Chris Rogers.
      
      Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.
      
      Source/WebCore:
      
      Test: webaudio/audiochannelmerger-basic.html
      
      * Modules/webaudio/AudioChannelMerger.cpp:
      (WebCore):
      (WebCore::AudioChannelMerger::create):
      (WebCore::AudioChannelMerger::AudioChannelMerger):
      * Modules/webaudio/AudioChannelMerger.h:
      (AudioChannelMerger):
      * Modules/webaudio/AudioContext.cpp:
      (WebCore::AudioContext::createChannelMerger):
      (WebCore):
      * Modules/webaudio/AudioContext.h:
      (AudioContext):
      * Modules/webaudio/AudioContext.idl:
      
      LayoutTests:
      
      * webaudio/audiochannelmerger-basic-expected.txt: Added.
      * webaudio/audiochannelmerger-basic.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d34efbd
    • barraclough@apple.com's avatar
      Don't rely on fixed offsets to patch calls · 2c132def
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83966
      
      Rubber stamped by Oliver Hunt.
      
      These aren't being used anywhere!
      
      * jit/JIT.h:
      * jit/JITCall.cpp:
      (JSC::JIT::compileOpCall):
      * jit/JITCall32_64.cpp:
      (JSC::JIT::compileOpCall):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c132def
    • danakj@chromium.org's avatar
      [chromium] Remove viewport memory restrictions · 65f3e476
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83316
      
      Reviewed by Adrienne Walker.
      
      We remove the memory restriction on web pages based on viewport size
      on desktop. This is causing pages that have complex use of layers to
      end up hitting our memory limits, and moreso when the window is small.
      Page complexity is not really a function of the viewport size.
      
      We drop the mininum memory limit entirely, and just evict all
      unprotected textures instead.
      
      Covered by existing tests.
      
      * platform/graphics/chromium/TextureManager.cpp:
      (WebCore::TextureManager::highLimitBytes):
      (WebCore::TextureManager::reclaimLimitBytes):
      * platform/graphics/chromium/TextureManager.h:
      (TextureManager):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::beginCommitOnImplThread):
      (WebCore::CCLayerTreeHost::setVisible):
      (WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
      (WebCore::CCLayerTreeHost::updateLayers):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65f3e476
    • commit-queue@webkit.org's avatar
      Optimize tracking of intruding floats being removed from RenderBlock during layout · 742e8e7c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82928
      
      Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-13
      Reviewed by David Hyatt.
      
      Performance tweaks in RenderBlock layout as a follow up to r112935.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::clearFloats):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      742e8e7c
    • mihnea@adobe.com's avatar
      [CSSRegions]Implement NamedFlow::contentNodes attribute · a230a172
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=80134
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
      In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
      The list of nodes is returned as a static node list.
      
      The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
      and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
      I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).
      
      Test: fast/regions/webkit-named-flow-content-nodes.html
      
      * dom/Document.cpp:
      (WebCore::Document::webkitGetFlowByName):
      * dom/Document.h:
      * dom/Element.cpp:
      (WebCore::Element::detach):
      * dom/Node.h:
      (WebCore::Node::inNamedFlow):
      (WebCore::Node::setInNamedFlow):
      (WebCore::Node::clearInNamedFlow):
      (Node):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
      * dom/WebKitNamedFlow.cpp:
      (WebCore::WebKitNamedFlow::contentNodes):
      (WebCore):
      * dom/WebKitNamedFlow.h:
      (WebKitNamedFlow):
      * dom/WebKitNamedFlow.idl:
      * rendering/FlowThreadController.cpp:
      (WebCore::FlowThreadController::registerNamedFlowContentNode):
      (WebCore):
      (WebCore::FlowThreadController::unregisterNamedFlowContentNode):
      * rendering/FlowThreadController.h:
      (FlowThreadController):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore):
      (WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
      (WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
      * rendering/RenderNamedFlowThread.h:
      (WebCore):
      (RenderNamedFlowThread):
      (WebCore::RenderNamedFlowThread::contentNodes):
      (WebCore::RenderNamedFlowThread::hasContentNode):
      
      LayoutTests:
      
      * fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
      * fast/regions/webkit-named-flow-content-nodes.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a230a172
    • jberlin@webkit.org's avatar
      Remove the calls to CRASH() from ResourceLoader.cpp. · 678bc4a1
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83962
      
      Reviewed by Alexey Proskuryakov.
      
      They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.
      
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::willSendRequest):
      (WebCore::ResourceLoader::didSendData):
      (WebCore::ResourceLoader::didReceiveResponse):
      (WebCore::ResourceLoader::didReceiveData):
      (WebCore::ResourceLoader::didFinishLoading):
      (WebCore::ResourceLoader::didFail):
      (WebCore::ResourceLoader::wasBlocked):
      (WebCore::ResourceLoader::cannotShowURL):
      (WebCore::ResourceLoader::shouldUseCredentialStorage):
      (WebCore::ResourceLoader::willCacheResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      678bc4a1
    • xji@chromium.org's avatar
      REGRESSION(r102190) [chromium] text rendering (font and font size) in some... · 3fdf535f
      xji@chromium.org authored
      REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
      when using certain fonts
      https://bugs.webkit.org/show_bug.cgi?id=83523
      
      Reviewed by Kent Tamura.
      
      Revert r102190.
      Convert characters being treatAsSpace to white space.
      
      * platform/graphics/chromium/UniscribeHelper.cpp:
      (WebCore::UniscribeHelper::fillRuns):
      (WebCore::UniscribeHelper::adjustSpaceAdvances):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fdf535f
    • commit-queue@webkit.org's avatar
      [chromium] Remove fallback code for "Missing plug-in" string. · 8403f7e7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81907
      
      Patch by Bernhard Bauer <bauerb@google.com> on 2012-04-13
      Reviewed by Adam Barth.
      
      * src/LocalizedStrings.cpp:
      (WebCore::missingPluginText):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8403f7e7
    • commit-queue@webkit.org's avatar
      Array.prototype.toString and Array.prototype.toLocaleString should be generic · 502fb9f7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81588
      
      Patch by Hojong Han <hojong.han@samsung.com> on 2012-04-13
      Reviewed by Gavin Barraclough.
      
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncToString):
      (JSC::arrayProtoFuncToLocaleString):
      * runtime/CommonIdentifiers.h:
      * tests/mozilla/ecma/Array/15.4.4.2.js:
      (getTestCases.array.item.new.TestCase):
      (getTestCases):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      502fb9f7
    • timothy@apple.com's avatar
      Change how the Web Insector is installed on Mac builds. · 012a3287
      timothy@apple.com authored
      <rdar://problem/10857918>
      
      Reviewed by Mark Rowe.
      
      * WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources
      and Streamline Inspector Source build phases.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      012a3287
    • barraclough@apple.com's avatar
      Don't rely on fixed offsets to patch method checks · 26677c3d
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83958
      
      Reviewed by Oliver Hunt.
      
      * bytecode/StructureStubInfo.h:
          - Add fields for the method check info.
      * jit/JIT.cpp:
      (JSC::PropertyStubCompilationInfo::copyToStubInfo):
          - Store the offsets on the stub info, instead of asserting.
      * jit/JIT.h:
          - Delete all the method check related offsets.
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::patchMethodCallProto):
          - Use the offset from the stubInfo.
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
          - Pass the stubInfo to patchMethodCallProto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26677c3d
    • simon.fraser@apple.com's avatar
      Rebaseline some compositing tests. Some were affected by the colorspace of · fcb024c4
      simon.fraser@apple.com authored
      the sample image changing.
      
      * compositing/images/direct-pdf-image-expected.png:
      * compositing/repaint/newly-composited-repaint-rect-expected.png:
      * compositing/visibility/visibility-image-layers-expected.png:
      * compositing/visibility/visibility-simple-video-layer-expected.png:
      * platform/mac/compositing/reflections/reflection-in-composited-expected.png:
      * platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcb024c4
    • abarth@webkit.org's avatar
      fast/dom/Window/window-property-descriptors.html is too much work to maintain · 317cff57
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83915
      
      Reviewed by Alexey Proskuryakov.
      
      The goal of this test is to remind us whenever we add something to the
      global scope.  In practice, however, this test is a lot of work to
      maintain because every port has different features enabled, which means
      every port has a different list of things in the global scope.  It's
      very difficult to make changes without causing this test to go red on a
      number of bots.
      
      Rather than use this test to monitor the global scope, we're better off
      paying attention to the IDL files.  If folks are interested in changes
      to what is exposed to JavaScript, they can subscribe to IDL changes
      using a watchlist.  (That's what I do, and it works pretty well.)
      
      * fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
      * fast/dom/Window/window-property-descriptors.html: Removed.
      * platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      317cff57
    • jer.noble@apple.com's avatar
      Video at apple.com gets standard controls in addition to custom controls after... · 55597541
      jer.noble@apple.com authored
      Video at apple.com gets standard controls in addition to custom controls after returning from full screen
      https://bugs.webkit.org/show_bug.cgi?id=83939
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      No new tests; DRT and WKTR don't have the infrastructure to test full-screen animation related bugs.
      
      Instead of asking the media element whether it is in full screen or not, rely on when the media root element
      was told that it enteredFullscreen() or exitedFullscreen(), which may occur at a different time than the
      media element due to animations.
      
      * html/shadow/MediaControlRootElement.cpp:
      (WebCore::MediaControlRootElement::reset):
      (WebCore::MediaControlRootElement::playbackStarted):
      (WebCore::MediaControlRootElement::enteredFullscreen):
      (WebCore::MediaControlRootElement::exitedFullscreen):
      (WebCore::MediaControlRootElement::defaultEventHandler):
      (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer):
      (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired):
      * html/shadow/MediaControlRootElement.h:
      (MediaControlRootElement): Added m_isFullscreen;
      
      Source/WebKit2:
      
      So that the media controls don't show up momentarily during full screen animations, call setAnimatingFullScreen(true)
      before calling will{Enter,Exit}FullScreen(), so that the CSS rule for full screen animation will be in effect
      immediately.
      
      Similarly, call setAnimatingFullScreen(false) after calling did{Enter,Exit}FullScreen, so that the full screen media
      controls don't momentarily appear at the end of an animation.
      
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController enterFullScreen:]):
      (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
      (-[WKFullScreenWindowController exitFullScreen]):
      (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55597541
    • jer.noble@apple.com's avatar
      fullscreen/video-controls-drag.html failing on Mac · 9204397d
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=81176
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      No new tests.  Fixes fullscreen/video-controls-drag.html.
      
      Regressed in r110409.  When the -webkit-media-controls-panel were changed
      from position:absolute to position:relative, this broke dragging of the
      controls in fullscreen, which relies on the panel being absolutely positioned
      to do its drag positioning. Change the way drag positioning is calculated to
      accommodate position:relative.
      
      * css/fullscreenQuickTime.css:
      (video:-webkit-full-screen::-webkit-media-controls-panel): Instead of bottom:50px,
          use margin-bottom:50px to push panel up from the bottom of the screen.
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::startDrag): Do not ask for the current renderer location.
      (WebCore::MediaControlPanelElement::continueDrag): Use the delta between the event locations
          only to calculate the new panel position.
      * html/shadow/MediaControlElements.h:
      
      LayoutTests:
      
      Removed expected failing results from platform/mac.
      
      * platform/mac/fullscreen/video-controls-drag-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9204397d
    • simon.fraser@apple.com's avatar
      Fix two compositing animation tests to not have flakey pixel results · e5f9fb48
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83957
      
      Reviewed by Dean Jackson.
      
      Fix these tests to use the pause animation API by providing an animation
      name in the expected data. There's no need to start the animations by hand.
      
      * compositing/reflections/animation-inside-reflection.html:
      * compositing/reflections/nested-reflection-animated.html:
      * platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
      * platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5f9fb48
    • andersca@apple.com's avatar
      Rebaseline this since svg/custom/resources/green-checker.png changed. · da077a6c
      andersca@apple.com authored
      * svg/custom/image-with-prefix-in-webarchive-expected.webarchive:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da077a6c
    • simon.fraser@apple.com's avatar
      Avoid use of ::webkit-scrollbar to hide scrollbars, since it doesn't work in WK1 · e2ab3ea6
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83950
      
      Reviewed by James Robinson.
      
      Remove use of ::webkit-scrollbar from compositing tests, since this doesn't
      affect WebKit1 scrollbars.
      
      * compositing/geometry/fixed-position-composited-page-scale-down.html:
      * compositing/geometry/fixed-position-composited-page-scale.html:
      * compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
      * compositing/geometry/fixed-position-iframe-composited-page-scale.html:
      * compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
      * compositing/geometry/fixed-position-transform-composited-page-scale.html:
      * platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
      * platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
      * platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
      * platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
      * platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
      * platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2ab3ea6
    • simon.fraser@apple.com's avatar
      Compositing layers not updated after scroll in WebKit1 · c4bbd3f1
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83945
      
      Source/WebCore:
      
      Reviewed by James Robinson.
      
      Fix the WebKit1 code path to correctly update compositing layers
      after a scroll, by calling updateFixedElementsAfterScrolling() from
      scrollPositionChangedViaPlatformWidget().
      
      Covered by existing tests.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
      
      LayoutTests:
      
      Reviewed by James Robinson.
      
      Replace an incorrect Mac baseline with the correct result which was
      already in place for WebKit2.
      
      Remove a passing test from test-expectations.
      
      * compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
      * platform/mac-wk2/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Removed.
      * platform/mac/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4bbd3f1
    • scheib@chromium.org's avatar
      Chromium test_expectations suppress platform/chromium/virtual/gpu/fast/canvas/2d.imageDataHD.html · aca71e51
      scheib@chromium.org authored
      Unreviewed.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aca71e51
    • rniwa@webkit.org's avatar
      Fix skipped list. · 7dfcb2f1
      rniwa@webkit.org authored
      * Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dfcb2f1
    • dino@apple.com's avatar
      Don't process filters if the input region is exceptionally large. · d458b69d
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83317
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      An extremely large element causes problems with filters, either by
      taking too long to compute the output or using too much memory. The
      filter engine already has some constants for maximum expected size.
      Make sure the render tree checks them before deciding to apply
      effects.
      
      Tests: css3/filters/huge-region-composited.html
             css3/filters/huge-region.html
      
      * platform/graphics/filters/FilterEffect.cpp:
      (WebCore::FilterEffect::apply):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore):
      (WebCore::isFilterSizeValid):
      (WebCore::FilterEffectRenderer::build):
      (WebCore::FilterEffectRenderer::updateBackingStore):
      (WebCore::FilterEffectRendererHelper::beginFilterEffect):
      * rendering/FilterEffectRenderer.h:
      (FilterEffectRenderer):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateOrRemoveFilterEffect):
      
      LayoutTests:
      
      * css3/filters/huge-region-composited-expected.txt: Added.
      * css3/filters/huge-region-composited.html: Added.
      * css3/filters/huge-region-expected.txt: Added.
      * css3/filters/huge-region.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d458b69d
    • annacc@chromium.org's avatar
      Queue the cuechange event on HTMLTrackElement for proper sorting. · 086b2942
      annacc@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83858
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      No new tests. Updates to media/track/track-cues-cuechange.html and
      media/track/track-mode.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::updateActiveTextTrackCues):
          Add HTMLTrackElement's cuechange event to the event queue rather than
          firing it synchronously.
      * html/track/LoadableTextTrack.cpp:
          Remove fireCueChangeEvent() as it is no longer used.
      * html/track/LoadableTextTrack.h:
          Ditto.
      * html/track/TextTrack.h:
      (TextTrack):
          Ditto.
      
      LayoutTests:
      
      * media/track/captions-webvtt/captions-fast.vtt:
          Captions were a wee bit too fast: they need to be at least 250ms apart
          for accurate testing as timeupdate events are only fired every 250ms.
      
      * media/track/track-cues-cuechange-expected.txt:
          Changes the order that cuechange events are fired.
      * media/track/track-cues-cuechange.html:
          Ditto.
      
      * media/track/track-mode-expected.txt:
          cuechange events are now fired at the proper times.
          Test now checks for all cuechange events (both enter and exit of cues).
      * media/track/track-mode.html:
          Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      086b2942
    • tonikitoo@webkit.org's avatar
      Be more restrictive when adding ScrollableArea's to FrameView's ScrollableArea's map · d911ca3f
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79611
      
      Reviewed by James Robinson.
      Patch by Antonio Gomes <agomes@rim.com>
      
      Source/WebCore:
      
      As of today, any FrameView attached to the Widget-tree or any
      RenderLayer whose corresponding RenderBox's style has a 'overflow'
      property set to 'auto' is cached in its containing scrollable areas set.
      We could be more restrictive about what we in fact want to
      cache as scrollable areas, by checking if the element as an overflow
      (i.e. more content than its viewport).
      
      * page/FrameView.cpp:
      (WebCore::FrameView::setFrameRect):
      
      Whenever the viewport changes, check if we have an scrollable/overflowed
      content, and update the cache accordingly.
      
      (WebCore::FrameView::setContentsSize):
      
      Whenever the contents size changes, check if we have a scrollable/overflowed
      content, and update the cache accordingly.
      
      (WebCore::FrameView::calculateScrollbarModesForLayout):
      
      Introduces a way to query for the scrollbars by only
      taking into account the "rules" set by the web author.
      For that, a new enum was added called SrollbarModesCalculationStrategy,
      which allows callers to discard for example client-side scrollbar policies
      in order to verify if a given frameview is scrollable or not.
      
      (WebCore::FrameView::updateScrollableAreaSet):
      
      Take into account various factors before considering a FrameView as
      scrollable. If in the end it is, it gets added to its parent FrameView
      scrollable areas map, otherwise removed.
      
      (WebCore):
      (WebCore::FrameView::addScrollableArea):
      
      Became unneeded, thus removed.
      
      (WebCore::FrameView::removeScrollableArea):
      
      Whenever a FrameView is removed from the Widget-tree,
      remove it from the cache.
      
      * page/FrameView.h:
      (FrameView):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateScrollbarsAfterLayout):
      
      Update scrollable area set after layout.
      
      (WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
      
      Update scrollable area set after style changes.
      
      (WebCore::RenderLayer::styleChanged):
      
      Removed the scrollable areas logic detection from it.
      
      (WebCore::RenderLayer::updateScrollableAreaSet):
      
      Updates the containing FrameView scrollable areas cache
      only when needed (i.e. an overflow exists).
      
      (WebCore):
      * rendering/RenderLayer.h:
      (RenderLayer):
      * testing/Internals.cpp:
      (WebCore::Internals::numberOfScrollableAreas):
      (WebCore):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      Tests: fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html
             fast/scrolling/scrollable-area-frame-overflow-hidden.html
             fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html
             fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html
             fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html
             fast/scrolling/scrollable-area-frame-scrolling-no.html
             fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html
             fast/scrolling/scrollable-area-frame-scrolling-yes.html
             fast/scrolling/scrollable-area-frame-visibility-hidden-child.html
             fast/scrolling/scrollable-area-frame-zero-size-and-border.html
             fast/scrolling/scrollable-area-frame.html
             fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html
             fast/scrolling/scrollable-area-overflow-auto-display-none.html
             fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html
             fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html
             fast/scrolling/scrollable-area-overflow-auto-visibility-override.html
             fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html
             fast/scrolling/scrollable-area-overflow-auto.html
             fast/scrolling/scrollable-area-overflow-not-set.html
             fast/scrolling/scrollable-area-overflow-visible.html
      
      LayoutTests:
      
      Reviewed by NOBODY (OOPS!).
      
      Added scrollable area set count tests to many situations observed
      in real world sites.
      
      * fast/scrolling/resources/generic-scrollable-content.html: Added.
      * fast/scrolling/resources/hidden-generic-scrollable-content.html: Added.
      * fast/scrolling/resources/scrollable-area.js: Added.
      (runTest):
      (end):
      * fast/scrolling/resources/scrollable-style.css: Added.
      (.inner):
      (.offscreen):
      * fast/scrolling/scrollable-area-frame-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-inherited-visibility-hidden-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-inherited-visibility-hidden.html: Added.
      * fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-overflow-hidden.html: Added.
      * fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-overried-inherited-visibility-hidden.html: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-no-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-no-overried-inherited-visibility-hidden.html: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-no-visibility-hidden-child.html: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-no.html: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-yes-display-none-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-yes-display-none.html: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-yes-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-scrolling-yes.html: Added.
      * fast/scrolling/scrollable-area-frame-visibility-hidden-child-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-visibility-hidden-child.html: Added.
      * fast/scrolling/scrollable-area-frame-zero-size-and-border-expected.txt: Added.
      * fast/scrolling/scrollable-area-frame-zero-size-and-border.html: Added.
      * fast/scrolling/scrollable-area-frame.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto-display-none-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-display-none-in-parent.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto-display-none.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-hidden-in-parent.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-hidden.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-override-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-override.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-visible-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-auto-visibility-visible.html: Added.
      * fast/scrolling/scrollable-area-overflow-auto.html: Added.
      * fast/scrolling/scrollable-area-overflow-not-set-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-not-set.html: Added.
      * fast/scrolling/scrollable-area-overflow-visible-expected.txt: Added.
      * fast/scrolling/scrollable-area-overflow-visible.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d911ca3f
    • andersca@apple.com's avatar
      Make sure that we're using the right compiler for generating derived sources. · 85a4cf1a
      andersca@apple.com authored
      Rubber-stamped by Dan Bernstein.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85a4cf1a
    • antti@apple.com's avatar
      Track rem unit usage in StyleSheetInternal · 87bb183c
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83923
      
      Reviewed by Andreas Kling.
      
      Currently CSSParser sets usesRemUnits flag directly to Document. It should be set to 
      the stylesheet instead so parser does not need to know about the document. This also 
      avoids setting the flag unnecessarily when the stylesheet is not used.
      
      * css/CSSGrammar.y:
      * css/CSSStyleSheet.cpp:
      (WebCore::StyleSheetInternal::StyleSheetInternal):
      * css/CSSStyleSheet.h:
      (WebCore::StyleSheetInternal::parserSetUsesRemUnits):
      (WebCore::StyleSheetInternal::usesRemUnits):
      (StyleSheetInternal):
      * dom/Document.cpp:
      (WebCore):
      (WebCore::checkUsesRemUnits):
      (WebCore::Document::updateActiveStylesheets):
      * dom/Document.h:
      (WebCore::Document::usesRemUnits):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87bb183c
    • scheib@chromium.org's avatar
      Chromium test_expectations TIMOUT mask for fast/canvas/2d.imageDataHD.html · ddd250e1
      scheib@chromium.org authored
      Unreviewed.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddd250e1
    • jamesr@google.com's avatar
      [chromium] Remove unused compositeToTexture / compositeOffscreen setting · c4b51d2e
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83733
      
      Reviewed by Adrienne Walker.
      
      Source/Platform:
      
      Remove compositeOffscreen setting. This was an experiment that is no longer needed.
      
      * chromium/public/WebLayerTreeView.h:
      (WebKit::WebLayerTreeView::Settings::Settings):
      (Settings):
      
      Source/WebCore:
      
      Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.
      
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::finishDrawingFrame):
      (WebCore::LayerRendererChromium::useRenderSurface):
      (WebCore::LayerRendererChromium::setScissorToRect):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (LayerRendererChromium):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCSettings::CCSettings):
      (CCSettings):
      
      Source/WebKit/chromium:
      
      Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
      
      * public/WebSettings.h:
      * src/WebLayerTreeView.cpp:
      (WebKit::WebLayerTreeView::Settings::operator CCSettings):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::WebSettingsImpl):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      Tools:
      
      Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
      
      * DumpRenderTree/chromium/DumpRenderTree.cpp:
      (main):
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::TestShell):
      (TestShell::resetWebSettings):
      * DumpRenderTree/chromium/TestShell.h:
      (TestShell):
      * DumpRenderTree/chromium/WebPreferences.cpp:
      (WebPreferences::reset):
      (WebPreferences::applyTo):
      * DumpRenderTree/chromium/WebPreferences.h:
      (WebPreferences):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4b51d2e
    • ap@apple.com's avatar
      REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached · f9a5b94d
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=83925
              <rdar://problem/11231790>
      
              Reviewed by Antti Koivisto.
      
              Added subtests to http/tests/cache/subresource-expiration-2.html.
      
              * platform/network/ResourceResponseBase.cpp:
              (WebCore::ResourceResponseBase::parseCacheControlDirectives): Honor first max-age
              instead of the last. New behavior matches both Firefox and IE.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114165 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9a5b94d
    • jamesr@google.com's avatar
      [chromium] Move WebVideoFrame into Platform and remove WebCore::VideoFrameChromium wrapper API · 3997d9d7
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83851
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      Move WebVideoFrame API into Platform.
      
      * Platform.gypi:
      * chromium/public/WebVideoFrame.h: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.h.
      (WebKit):
      (WebVideoFrame):
      (WebKit::WebVideoFrame::~WebVideoFrame):
      (WebKit::WebVideoFrame::format):
      (WebKit::WebVideoFrame::width):
      (WebKit::WebVideoFrame::height):
      (WebKit::WebVideoFrame::planes):
      (WebKit::WebVideoFrame::stride):
      (WebKit::WebVideoFrame::data):
      (WebKit::WebVideoFrame::textureId):
      (WebKit::WebVideoFrame::textureTarget):
      * chromium/src/WebVideoFrame.cpp: Renamed from Source/WebCore/platform/graphics/chromium/VideoFrameChromium.cpp.
      (WebKit):
      
      Source/WebCore:
      
      Remove VideoFrameChromium wrapper and converts WebCore code to using the Platform WebVideoFrame API directly.
      Some utility code that previously existed on VideoFrameChromium and only had one caller, such as doing
      width/height adjustements for YV12 frames, is moved into the calling code (CCVideoLayerImpl).
      
      Covered by existing media/ and compositing/ layout tests.
      
      * WebCore.gypi:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::drawYUV):
      (WebCore::LayerRendererChromium::drawRGBA):
      (WebCore::LayerRendererChromium::copyFrameToTextures):
      * platform/graphics/chromium/LayerRendererChromium.h:
      * platform/graphics/chromium/VideoFrameProvider.h:
      (VideoFrameProvider):
      * platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
      (WebCore::CCVideoDrawQuad::create):
      (WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
      * platform/graphics/chromium/cc/CCVideoDrawQuad.h:
      (WebKit):
      (CCVideoDrawQuad):
      (WebCore::CCVideoDrawQuad::frame):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      (WebCore):
      (WebCore::convertVFCFormatToGC3DFormat):
      (WebCore::CCVideoLayerImpl::willDraw):
      (WebCore::videoFrameDimension):
      (WebCore::hasPaddingBytes):
      (WebCore::CCVideoLayerImpl::computeVisibleSize):
      (WebCore::CCVideoLayerImpl::reserveTextures):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
      (WebKit):
      
      Source/WebKit/chromium:
      
      Moves the WebVideoFrame interface into Platform and removes the now unnecessary VideoFrameChromiumImpl adapter
      implementation.
      
      * WebKit.gyp:
      * public/WebVideoFrame.h:
      * src/AssertMatchingEnums.cpp:
      * src/VideoFrameChromiumImpl.cpp: Removed.
      * src/VideoFrameChromiumImpl.h: Removed.
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
      (WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
      (WebKit::WebMediaPlayerClientImpl::supportsType):
      * src/WebMediaPlayerClientImpl.h:
      (WebMediaPlayerClientImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114164 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3997d9d7
    • scheib@chromium.org's avatar
      Chromium: Should enable -webkit-image-set · 5d3fa078
      scheib@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81859
      
      Patch by Rob Flack <flackr@chromium.org> on 2012-04-13
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Test: fast/css/image-set-parsing.html
      
      * WebCore.gypi:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d3fa078
    • tomz@codeaurora.org's avatar
      Integrate IETC CSS : grid layout tests · 8a6e5112
      tomz@codeaurora.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83830
      
      Patch by Dave Tharp < dtharp@codeaurora.org> on 2012-04-13
      Reviewed by Adam Barth
      
      * ietestcenter/css3/grid/display-grid-001.htm: Added.
      * ietestcenter/css3/grid/display-grid-002.htm: Added.
      * ietestcenter/css3/grid/grid-column-001.htm: Added.
      * ietestcenter/css3/grid/grid-column-002.htm: Added.
      * ietestcenter/css3/grid/grid-column-003.htm: Added.
      * ietestcenter/css3/grid/grid-columns-001.htm: Added.
      * ietestcenter/css3/grid/grid-items-001.htm: Added.
      * ietestcenter/css3/grid/grid-items-002.htm: Added.
      * ietestcenter/css3/grid/grid-items-003.htm: Added.
      * ietestcenter/css3/grid/grid-items-004.htm: Added.
      * ietestcenter/css3/grid/grid-items-005.htm: Added.
      * platform/chromium/test_expectations.txt:
      * platform/efl/test_expectations.txt:
      * platform/gtk/test_expectations.txt:
      * platform/mac/test_expectations.txt:
      * platform/qt/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a6e5112
    • michaeln@google.com's avatar
      [chromium] Now that the chromium port is using a different dom_storage backend · 31780bc5
      michaeln@google.com authored
      library in its main browser process, there are a handful of files that should no
      longer be included in the build, and a few files than should be deleted
      outright, and the webkit api should be modified to reflect the new (and smaller)
      contract between the embedder and webkit/webcore.
      https://bugs.webkit.org/show_bug.cgi?id=83807
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      No new tests, existing tests apply.
      
      * WebCore.gyp/WebCore.gyp: Exclude several files from the WebCore/storage directory.
      * storage/StorageEventDispatcher.h: Delete a stale comment.
      
      Source/WebKit/chromium: 
      
      * WebKit.gyp: Delete a few files.
      * public/WebStorageNamespace.h:  Remove some unused data members and methods, and annotate close() as deprecated.
      * public/platform/WebKitPlatformSupport.h: Annotate a method as deprecated.
      * src/StorageAreaProxy.cpp: Remove the include of a deleted file.
      * src/StorageEventDispatcherChromium.cpp: Removed.
      * src/StorageEventDispatcherImpl.cpp: Added a FIXME comment for upcoming work.
      * src/StorageNamespaceProxy.cpp: Modified to no longer call out to the embedder thru the deprecated close() method.
      * src/StorageNamespaceProxy.h: Moved some blank lines around.
      * src/WebStorageAreaImpl.cpp: Removed.
      * src/WebStorageAreaImpl.h: Removed.
      * src/WebStorageEventDispatcherImpl.cpp: Cleaned up some cruft.
      * src/WebStorageNamespaceImpl.cpp: Removed.
      * src/WebStorageNamespaceImpl.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31780bc5
    • zandobersek@gmail.com's avatar
      Unreviewed, rebaselining after r114150. · 38e284d6
      zandobersek@gmail.com authored
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38e284d6
    • rniwa@webkit.org's avatar
      webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20), · 71c36b7e
      rniwa@webkit.org authored
      and also rebaseline the test results since we ignore the first run now.
      
      * Scripts/webkitpy/performance_tests/perftest.py:
      (PageLoadingPerfTest.run):
      * Scripts/webkitpy/performance_tests/perftest_unittest.py:
      (TestPageLoadingPerfTest.test_run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71c36b7e
    • barraclough@apple.com's avatar
      Don't rely on fixed offsets to patch get_by_id/put_by_id · f14ef92f
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83924
      
      Reviewed by Oliver Hunt.
      
      Store offsets in the structure stub info, as we do for the DFG JIT.
      
      * assembler/AbstractMacroAssembler.h:
      (JSC::AbstractMacroAssembler::differenceBetween):
          - this method can be static (now used from PropertyStubCompilationInfo::copyToStubInfo, will be removed soon!)
      * bytecode/StructureStubInfo.h:
          - added new fields for baseline JIT offsets.
      * jit/JIT.cpp:
      (JSC::PropertyStubCompilationInfo::copyToStubInfo):
          - moved out from JIT::privateCompile.
      (JSC::JIT::privateCompile):
          - moved out code to PropertyStubCompilationInfo::copyToStubInfo.
      * jit/JIT.h:
      (PropertyStubCompilationInfo):
          - added helper functions to initializae PropertyStubCompilationInfo, state to store more offset info.
          - removed many offsets.
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_method_check):
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::compileGetByIdSlowCase):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::emitSlow_op_put_by_id):
      (JSC::JIT::patchGetByIdSelf):
      (JSC::JIT::patchPutByIdReplace):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      (JSC::JIT::resetPatchGetById):
      (JSC::JIT::resetPatchPutById):
          - changed code generation to use new interface to store info on PropertyStubCompilationInfo.
          - changed repatch functions to read offsets from the structure stub info.
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_method_check):
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::compileGetByIdSlowCase):
      (JSC::JIT::emit_op_put_by_id):
      (JSC::JIT::emitSlow_op_put_by_id):
      (JSC::JIT::patchGetByIdSelf):
      (JSC::JIT::patchPutByIdReplace):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      (JSC::JIT::resetPatchGetById):
      (JSC::JIT::resetPatchPutById):
          - changed code generation to use new interface to store info on PropertyStubCompilationInfo.
          - changed repatch functions to read offsets from the structure stub info.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f14ef92f
    • andersca@apple.com's avatar
      More rebaselining. · 26c9b815
      andersca@apple.com authored
      * platform/mac/fast/dom/Window/window-properties-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26c9b815
    • rwlbuis@webkit.org's avatar
      Fix some compiler warnings (miscellaneous) · f63e3099
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Reviewed by Antonio Gomes.
      
      Fix signed/unsigned comparison warning.
      
      * parser/Lexer.cpp:
      (JSC::::record16):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f63e3099