GitLab

https://bugs.webkit.org/show_bug.cgi?id=64077

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

* dfg/DFGRepatch.cpp:
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::tryCacheGetByID):
* runtime/JSObject.h:
(JSC::JSObject::addressOfPropertyAtOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64116

Reviewed by Eric Seidel.

Switching all functions with IntPoint paintOffsets to the new Layout types.

No new tests, no functionality changes.

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):
* rendering/EllipsisBox.h:
* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintCustomHighlight):
* rendering/InlineTextBox.h:
* rendering/LayoutTypes.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintCaret):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::paintSelection):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintCustomHighlight):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintOverflowControls):
(WebCore::RenderLayer::paintScrollCorner):
(WebCore::RenderLayer::paintResizer):
* rendering/RenderLayer.h:
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintScrollbar):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderListBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing):
(WebCore::RenderObject::paintOutline):
* rendering/RenderObject.h:
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
* rendering/RenderReplaced.h:
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
* rendering/RenderScrollbarPart.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
* rendering/RenderTableSection.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::paintPlaceholder):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paintEllipsisBox):
(WebCore::RootInlineBox::paintCustomHighlight):
(WebCore::RootInlineBox::paint):
* rendering/RootInlineBox.h:
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paint):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::paint):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64032

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2011-07-07
Reviewed by James Robinson.

The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
to support antialiased clips doesn't work when printing to Skia's PDF backend because
the backend does not support inverted paths. This manifests as rounded buttons not being
drawn when printing, tracked as Chrome bug 79519.

However, when the output is a vector device, like PDF, we don't need antialiased clips.
It's up to the PDF rendering engine to do that.  So we can simply disable the antialiased
clip code if the output is a vector device.

I think the fix isn't testable because it requires examining the printed output.

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::clipPathAntiAliased):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

slow path.
https://bugs.webkit.org/show_bug.cgi?id=64073

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-07
Reviewed by Gavin Barraclough.

* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchGetMethodFast):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=63762

Reviewed by Eric Seidel.

Switch selection getters and selection gap calculation methods over to
new layout abstraction.

No new tests, no functionality changes.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionTop):
(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::selectionHeight):
(WebCore::InlineTextBox::isSelected):
* rendering/InlineTextBox.h:
* rendering/RenderBR.h:
(WebCore::RenderBR::selectionRectForRepaint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::desiredColumnWidth):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::selectionRectForRepaint):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
* rendering/RenderListMarker.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::selectionRect):
(WebCore::RenderObject::selectionRectForRepaint):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfo::RenderSelectionInfo):
* rendering/RenderText.cpp:
(WebCore::RenderText::selectionRectForRepaint):
* rendering/RenderText.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeight):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=60097

The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher.  This patch
uses a CachedResourceHandle to keep the CachedResource alive.

Source/WebCore:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test.  The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html

* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::stopLoading):

LayoutTests:

The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test.  The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.

* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixes <http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
title.
(ViewController.prototype._displayBuilder): Set the page's title and clear out any old
content immediately instead of waiting for the first set of results for the history
analyzer. As we receive new results from the analyzer we'll just clear out the main content
area and replace it with the new info.
(ViewController.prototype._displayTesters): Set the page's title and clear out any old
content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
in a little use of our removeAllChildren helper, too.
(ViewController.prototype._setTitle): Added. Set's the page's title and the header text.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Stephen White.

Mark layout tests as failing in Chromium after skia roll r1799:r1814
https://bugs.webkit.org/show_bug.cgi?id=64121

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Kenneth Russell.

Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=42912

This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
garbage collection heuristics can account for the memory held by these objects.  On the new test page, this
reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to <300MB.

Test: WebCore/manual-tests/array-buffer-memory.html

* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64118

Reviewed by Alexey Proskuryakov.

Moved m_cachedSelectionStart and m_cachedSelectionEnd from HTMLInputElement
and HTMLTextAreaElement to HTMLTextFormControlElement

Also removed cached selection related functions from RenderTextControl,
RenderTextControlSingleLine, and RenderTextControlMultiLine because they were
merely providing wrapper functions to enable polymorphism between
input and textarea elements and their WML equivalents.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::notifyRendererOfSelectionChange): Calls HTMLTextFormControlElement's
selectionChanged instead of RenderTextControl's.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initialize
m_cachedSelectionStart and m_cachedSelectionEnd.
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection): Added.
(WebCore::HTMLTextFormControlElement::selectionChanged): Extracted from
RenderTextControl::selectionChanged.
* html/HTMLFormControlElement.h:
(WebCore::HTMLTextFormControlElement::cacheSelection): Extracted from HTMLInputElement
and HTMLTextAreaElement.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionStart): Added.
(WebCore::HTMLTextFormControlElement::hasCachedSelectionEnd): Added.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::updateFocusAppearance):
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::isEmptyValue):
* rendering/RenderTextControl.cpp:
(WebCore::setSelectionRange):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp:
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp:
* rendering/RenderTextControlSingleLine.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64114

Reviewed by Eric Seidel.

No new tests, no functionality changes.

* rendering/LayoutTypes.h:
(WebCore::flooredLayoutPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
* rendering/RenderListBox.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
* rendering/RenderTextControl.h:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects):
* rendering/svg/RenderSVGContainer.h:
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::addFocusRingRects):
* rendering/svg/RenderSVGPath.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64052

Reviewed by James Robinson.

Layers and surfaces that are entirely transparent are now skipped.
Parent scissor rects are now applied to the content rect of surfaces
so that offscreen surfaces can be skipped.

Landing this for vangelis@chromium.org.

Covered by existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::calculateVisibleRect):
(WebCore::calculateVisibleLayerRect):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/90581
https://bugs.webkit.org/show_bug.cgi?id=64124

Broke a bunch of inspector tests (Requested by ojan on
#webkit).

* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64119

Reviewed by James Robinson.

WebKit paint can disable compositing and call setRootLayer(0). Adding
a check for this in drawLayers prevents a null pointer deref.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64123

Reviewed by Sam Weinig.

Finally kill off the out of line jump and link size arrays,
so we can avoid icky loads and constant fold the linking arithmetic.

* assembler/ARMv7Assembler.cpp:
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::jumpSizeDelta):
(JSC::ARMv7Assembler::computeJumpType):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        SVGAnimateTransform does not support calcMode=discrete
        https://bugs.webkit.org/show_bug.cgi?id=63914

        Reviewed by Rob Buis.

        CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation.
        Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation,
        we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on
        all other animations as well as on other SVG viewers.

        Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104.

        * manual-tests/svg-animateTransform-calcMode-discrete.svg: Added.
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

This will improve integration with the rest of webkitpy, particularly when invoked via
webkit-patch.

Fixes <http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
Executive inappropriately

Reviewed by Adam Barth.

* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
our own use. SCM might have some super-special Executive that it uses under the covers, and
we want to use it, too!

* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
method to call through to Executive.run_command.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.

Fixes <http://webkit.org/b/64113> REGRESSION (r90564):
webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
Term/ReadKey.pm module

Reviewed by Xan Lopez.

* Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
that existing commit messages will be preserved. (Users can manually remove existing commit
messages using git-reset.)

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore: 

SVGAnimatedPath needs fallback for 'by' animation
https://bugs.webkit.org/show_bug.cgi?id=63865
        
Added fallback to 'to' animation for 'by' animated SVGAnimatedPathAnimator.
        
Clenup of SVGAnimateElement. Removed all switches since we support all AnimatedTypes
with the exception of AnimatedEnumeration. AnimatedEnumeration gets animated as AnimatedString at the moment. 

Test: svg/animations/svgpath-animation-1.html

* svg/SVGAnimateElement.cpp:
(WebCore::getPropertyValue):
(WebCore::inheritsFromProperty):
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateElement::adjustForCurrentColor):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):
* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):

LayoutTests: 

SVGAnimatedPath needs fallback for 'by' animation
https://bugs.webkit.org/show_bug.cgi?id=63865

Test fallback to 'to' animation for 'by' animated SVGPath.

* svg/animations/script-tests/svgpath-animation-1.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgpath-animation-1-expected.txt: Added.
* svg/animations/svgpath-animation-1.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Web Inspector: secure access to extensions API
        https://bugs.webkit.org/show_bug.cgi?id=64080

        Reviewed by Pavel Feldman.

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.Panels.prototype.create):
        (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionPanel):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
        (WebInspector.ExtensionServer.prototype._addExtensions):
        (WebInspector.ExtensionServer.prototype._onWindowMessage):
        (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
        (WebInspector.ExtensionServer.prototype._expandResourcePath):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed.

        Re-skip the inspector tests, they are still timing out on the
        release bot for some reason.

        * platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixes <http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
correctly handle Unicode in commit messages

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in
places in the ChangeLog that will end up being included in the commit message.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64101

Reviewed by Benjamin Poulain.

Source/WebKit2: 

* DerivedSources.pro:
* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/Connection.h:
* Platform/SharedMemory.h:
* Platform/qt/SharedMemorySymbian.cpp: Removed.
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* WebKit2.pri:
* WebKit2.pro:
* WebProcess.pro:
* config.h:

Tools: 

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64099

Reviewed by Benjamin Poulain.

Source/WebKit2: 

* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::setCursor):
(QtWebPageProxy::registerEditCommand):
(QtWebPageProxy::clearAllEditCommands):
(QtWebPageProxy::canUndoRedo):
(QtWebPageProxy::executeUndoRedo):
(QtWebPageProxy::updateAction):
(QtWebPageProxy::webActionTriggered):
(QtWebPageProxy::triggerAction):
(QtWebPageProxy::action):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::didChangeCursor):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:
* UIProcess/qt/WebUndoCommandQt.cpp:
(WebUndoCommandQt::WebUndoCommandQt):
* UIProcess/qt/WebUndoCommandQt.h:
* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::WebDragClient::startDrag):

Tools: 

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::openFile):
(BrowserWindow::screenshot):
(BrowserWindow::loadURLListFromFile):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/win/Skipped: Added fast/forms/file-input-change-event.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=63313

Patch by Kyusun Kim <maniagoon@company100.net> on 2011-07-07
Reviewed by Eric Seidel.

* platform/posix/SharedBufferPOSIX.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64102

Reviewed by Simon Fraser.

Source/WebCore: 

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
'-webkit-column-break-inside: avoid' was specified.

LayoutTests: 

* fast/multicol/break-properties-expected.txt:
* fast/multicol/break-properties.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64093

Reviewed by Benjamin Poulain.

Add processDidCrash() and didRelaunchProcess() to ViewInterface.

QDesktopWebView now displays a simple sad smiley ":(" when the
web process crashes.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(paintCrashedPage):
(QDesktopWebView::paint):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::showContextMenu):
(WebKit::TouchViewInterface::hideContextMenu):
(WebKit::TouchViewInterface::processDidCrash):
(WebKit::TouchViewInterface::didRelaunchProcess):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
really use them to perform regression analysis. The only time we want to pay attention to
too-many-failures builds is when we're trying to explain when the current bout of
too-many-failures started.

Fixes <http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
in a build that didn't even run it (because it exited early due to too many failues)

Patch by Adam Roben <aroben@apple.com> on 2011-07-07
Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
too-many-failures handling that would cause us to blame builds that didn't even run a given
test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
build was itself a too-many-failures build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=63255

Unreviewed gardening.

* platform/qt/Skipped: Skip tests.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64089

Reviewed by Pavel Feldman.

* inspector/front-end/networkPanel.css:
(.data-grid.network-log-grid tr.filler td):
(.network.panel .sidebar):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by David Hyatt.

Partial layout when a flex-box has visibility: collapse
https://bugs.webkit.org/show_bug.cgi?id=63776

Source/WebCore:

Tests: fast/flexbox/crash-button-input-autofocus.html
       fast/flexbox/crash-button-keygen.html
       fast/flexbox/crash-button-relayout.html

The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.

LayoutTests:

Those tests checks some variation of the same underlying issue.

* fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
* fast/flexbox/crash-button-input-autofocus.html: Added.
* fast/flexbox/crash-button-keygen-expected.txt: Added.
* fast/flexbox/crash-button-keygen.html: Added.
* fast/flexbox/crash-button-relayout-expected.txt: Added.
* fast/flexbox/crash-button-relayout.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Web Inspector: URL links in styles open new tab instead of showing resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=64090

        Reviewed by Pavel Feldman.

        * inspector/styles/styles-url-linkify-expected.txt:
        * inspector/styles/styles-url-linkify.html:
2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>

        Web Inspector: URL links in styles open new tab instead of showing resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=64090

        Reviewed by Pavel Feldman.

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=64103

Unreviewed gardening.

* platform/qt/Skipped: Skip test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Web Inspector: active panel does not receive resize event when drawer is resized
        https://bugs.webkit.org/show_bug.cgi?id=64094

        Reviewed by Pavel Feldman.

        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype._statusBarDragging):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
commit-log-editor's

Reviewed by David Kilzer.

* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
the modified ChangeLogs, to generate the commit message, rather than trying to generate one
ourselves.

* Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
to match commit-log-editor's format.
(CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
directories so we can see how the various entries get labeled in the commit message.
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
instance that knows how to find commit-log-editor and pass it to our Checkout instance.
Don't bother capturing output, since there shouldn't be any.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
generates a commit message from those ChangeLogs, prints it to stdout, and exits.

Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

* Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
option, which calls through to createCommitMessage, prints the result, and exits.
(printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

As a bonus, we now skip a bunch of work in the case where we are generating a commit message
for staged git changes.

Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
readable than commit-log-editor's

Reviewed by David Kilzer.

* Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
file so that it will be defined even if we aren't operating on an existing log message.
Moved a bunch of top-level code to generate the commit message from here...
(createCommitMessage): ...to here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90562 268f45cc-cd09-0410-ab3c-d52691b4dbfc