1. 24 Jul, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-07-24 Mike Fenton <mike.fenton@torchmobile.com> · 2def5eb9
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
              Style Guidelines as identified by cpplint.py.
              https://bugs.webkit.org/show_bug.cgi?id=27624
      
              * page/DragController.cpp:
              (WebCore::DragController::~DragController):
              (WebCore::documentFragmentFromDragData):
              (WebCore::DragController::dragEnded):
              (WebCore::DragController::dragEntered):
              (WebCore::DragController::dragExited):
              (WebCore::DragController::dragUpdated):
              (WebCore::DragController::performDrag):
              (WebCore::asFileInput):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::DragController::delegateDragSourceAction):
              (WebCore::DragController::concludeEditDrag):
              (WebCore::DragController::canProcessDrag):
              (WebCore::DragController::tryDHTMLDrag):
              (WebCore::DragController::mayStartDragAtEventLocation):
              (WebCore::getCachedImage):
              (WebCore::getImage):
              (WebCore::prepareClipboardForImageDrag):
              (WebCore::dragLocForDHTMLDrag):
              (WebCore::DragController::startDrag):
              (WebCore::DragController::doImageDrag):
              (WebCore::DragController::doSystemDrag):
              (WebCore::DragController::placeDragCaret):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2def5eb9
  2. 24 Jun, 2009 2 commits
    • eric@webkit.org's avatar
      2009-06-24 Eric Seidel <eric@webkit.org> · 8a0f4c21
      eric@webkit.org authored
              No review, build fix only.
      
              The previous checkin had an improper merge.  This fixes the build.
      
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a0f4c21
    • eric@webkit.org's avatar
      2009-06-05 Eric Seidel <eric@webkit.org> · 3c6ea8a1
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=25922
              Fix dropEffect = "none" to work as expected.
      
              * fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
              * fast/events/drag-to-navigate.html: Added.
              * fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
              * fast/events/prevent-drag-to-navigate.html: Added.
              * fast/events/resources/file-for-drag-to-navigate.html: Added.
              * fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.
      
      2009-06-05  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=25922
              JS setting dropEffect = "none" causes tryDHTMLDrag
              to return DragOperationNone.  Which is also the value
              tryDHTMLDrag previously used to indicate JS did not
              want to handle the drag.
      
              Make it possible for the DragController::try* methods
              to return a bool to indicate if javascript accepted
              or rejected the drag event, separate from the DragOperation.
      
              Tests:
              - fast/events/drag-to-navigate.html
              - fast/events/prevent-drag-to-navigate.html
      
              * page/DragController.cpp:
              (WebCore::DragController::dragEnteredOrUpdated):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::defaultOperationForDrag):
              (WebCore::DragController::tryDHTMLDrag):
              * page/DragController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c6ea8a1
  3. 13 Jun, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-06-13 Victor Wang <victorw@chromium.org> · 15a81fcd
      abarth@webkit.org authored
              Reviewed by Eric Seidel.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26333
              Alert during a dragenter event handler will crash the renderer
              
              This crash is casued by calling NULL pointer m_documentUnderMouse in
              DragController::tryDocumentDrag()
      
              tryDHTMLDrag fires dragenter event. The event listener that listens
              to this event may create a nested message loop (open a modal dialog),
              which could process dragleave event and reset m_documentUnderMouse in
              dragExited.
      
              Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
              do not continue if the pointer has been set to NULL.
      
              Test: DRT does not show alerts so add a manual test:
                    manual-tests/drag-enter-alert.html
      
              * manual-tests/drag-enter-alert.html: Added.
              * manual-tests/resources/drag-image.png: Added.
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15a81fcd
  4. 27 May, 2009 1 commit
  5. 21 May, 2009 3 commits
    • ggaren@apple.com's avatar
      WebCore: · 1625e181
      ggaren@apple.com authored
      2009-05-21  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
              Incorrect URL returned to the DOM while the user drags a file
      
              * page/DragController.cpp:
              (WebCore::DragController::dragExited):
              (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
              since that only looks at the text of the document's URL. Do base our
              decision on the securityOrigin(), which knows more about the document's
              actual origin.
      
      LayoutTests:
      
      2009-05-21  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Tests for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
              Incorrect URL returned to the DOM while the user drags a file
      
              * http/tests/local/drag-over-remote-content-expected.txt: Added.
              * http/tests/local/drag-over-remote-content.html: Added.
              * http/tests/security/drag-over-remote-content-iframe-expected.txt: Added.
              * http/tests/security/drag-over-remote-content-iframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1625e181
    • eric@webkit.org's avatar
      2009-05-21 Eric Seidel <eric@webkit.org> · 3d81d65f
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Clean up DragController
              https://bugs.webkit.org/show_bug.cgi?id=25926
      
              I renamed m_document to m_documentUnderMouse to better document what it does
              I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
              long enough.
      
              I also saw copy/paste code involving clearing the selection when moving out of
              one document and into another.  I moved that code into a function called
              mouseMovedIntoDocument.
      
              I also got rid of a couple needless null-checks after confirming via source
              inspection they were not ever possible.
              In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
              I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
              It's also not possible to return a document from documentAtPoint that is not
              in a frame (as such a document would not be rendered).
      
              No functional changes, thus no tests.
      
              * page/DragController.cpp:
              (WebCore::DragController::DragController):
              (WebCore::DragController::dragIsMove):
              (WebCore::DragController::dragExited):
              (WebCore::DragController::performDrag):
              (WebCore::DragController::mouseMovedIntoDocument):
              (WebCore::DragController::dragEnteredOrUpdated):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::DragController::operationForLoad):
              (WebCore::DragController::concludeEditDrag):
              (WebCore::DragController::canProcessDrag):
              (WebCore::DragController::tryDHTMLDrag):
              (WebCore::DragController::placeDragCaret):
              * page/DragController.h:
              (WebCore::DragController::documentUnderMouse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d81d65f
    • eric@webkit.org's avatar
      2009-05-21 Eric Seidel <eric@webkit.org> · 5797165d
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Rename DragController::dragOperation() to sourceDragOperation() for clarity
              Remove unused setDragOperation()
      
              There are two times DragOperation is used.  The source specifies
              what drag operations it supports (in a mask) and the destination
              picks a subset of those as DragOperations it supports if a drop were
              to occur.  I was confused when I first saw this accessor as to which
              it meant.  It turns out that this is only used when WebKit starts a
              drag, and we keep it around so that we can provide this information
              to other Mac OS X applications when they ask.  I've renamed the method
              for clarity so the next person in this code will be less confused.
      
              No functional changes, thus no tests.
      
              * page/DragController.h:
              (WebCore::DragController::sourceDragOperation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5797165d
  6. 07 May, 2009 1 commit
    • zimmermann@webkit.org's avatar
      Reviewed by Dave Hyatt. · b75da289
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
      
      Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
      
      Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
      gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
      
      The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
      This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
      To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
      methods are renamed to clarify where they belong to. (Detailed list in ChangeLog)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b75da289
  7. 20 Feb, 2009 1 commit
    • jchaffraix@webkit.org's avatar
      2009-02-20 Julien Chaffraix <jchaffraix@webkit.org> · 074bcda0
      jchaffraix@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
      
              Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
              or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
              unneeded.
      
              It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
              enables us to use some generated QualifiedName.
      
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::constructHTMLOptionElement):
              * dom/Document.cpp:
              (WebCore::Document::setTitle):
              * dom/XMLTokenizer.cpp:
              (WebCore::createXHTMLParserErrorHeader):
              (WebCore::XMLTokenizer::insertErrorMessageBlock):
              * editing/CompositeEditCommand.cpp:
              (WebCore::createBlockPlaceholderElement):
              * editing/htmlediting.cpp:
              (WebCore::createTabSpanElement):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::setLength):
              * loader/FTPDirectoryDocument.cpp:
              (WebCore::FTPDirectoryTokenizer::appendEntry):
              (WebCore::FTPDirectoryTokenizer::createTDForFilename):
              (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
              (WebCore::FTPDirectoryTokenizer::createBasicDocument):
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::createDocumentStructure):
              * loader/MediaDocument.cpp:
              (WebCore::MediaTokenizer::createDocumentStructure):
              * loader/PluginDocument.cpp:
              (WebCore::PluginTokenizer::createDocumentStructure):
              * loader/TextDocument.cpp:
              (WebCore::TextTokenizer::write):
              * page/Frame.cpp:
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::styleForSelectionStart):
              Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
      
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
              * page/DragController.cpp:
              (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      074bcda0
  8. 09 Feb, 2009 1 commit
  9. 06 Feb, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Justin Garcia. · 50d7db0a
      eric@webkit.org authored
              DOMSelection.getRangeAt() returns a different range than the selection
              https://bugs.webkit.org/show_bug.cgi?id=23601
      
              Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range
      
              Test: fast/dom/Selection/getRangeAt.html
      
              * WebCore.base.exp:
              * dom/InputElement.cpp:
              (WebCore::InputElement::handleBeforeTextInsertedEvent):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/Editor.cpp:
              (WebCore::Editor::selectedRange):
              (WebCore::Editor::fontForSelection):
              (WebCore::Editor::applyStyleToSelection):
              (WebCore::Editor::applyParagraphStyleToSelection):
              (WebCore::Editor::insertTextWithoutSendingTextEvent):
              (WebCore::Editor::insertLineBreak):
              (WebCore::Editor::insertParagraphSeparator):
              (WebCore::Editor::ignoreSpelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::markMisspellingsOrBadGrammar):
              (WebCore::Editor::rangeForPoint):
              * editing/EditorCommand.cpp:
              (WebCore::expandSelectionToGranularity):
              (WebCore::executeDeleteToMark):
              (WebCore::executeSelectToMark):
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment):
              * editing/Selection.cpp:
              (WebCore::Selection::firstRange):
              (WebCore::Selection::toNormalizedRange):
              * editing/Selection.h:
              * editing/SelectionController.h:
              (WebCore::SelectionController::toNormalizedRange):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/markup.cpp:
              (WebCore::createMarkup):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::createFromSelection):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::getRangeAt):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::toString):
              * page/DragController.cpp:
              (WebCore::setSelectionToDragCaret):
              (WebCore::DragController::concludeEditDrag):
              (WebCore::DragController::startDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent):
              * page/Frame.cpp:
              (WebCore::Frame::selectedText):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::shouldDeleteSelection):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::selectionTextRects):
              (WebCore::Frame::findString):
              (WebCore::Frame::respondToChangedSelection):
              * platform/ContextMenu.cpp:
              (WebCore::selectionContainsPossibleWord):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50d7db0a
  10. 04 Feb, 2009 1 commit
    • weinig@apple.com's avatar
      2009-02-04 Sam Weinig <sam@webkit.org> · bcce4080
      weinig@apple.com authored
              Reviewed by David Hyatt.
      
              Add toRenderImage methods for casting RenderObjects to RenderImages.  The methods will assert if the object
              is not a RenderImage.  Also add a toRenderImage method that takes a RenderImage but returns void and that
              is unimplemented.  This method will catch anyone trying to do a cast when the object is already a RenderImage.
      
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::defaultEventHandler):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::attach):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::parseMappedAttribute):
              (WebCore::HTMLImageElement::attach):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::attach):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::attach):
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::attach):
              * loader/ImageLoader.cpp:
              (WebCore::ImageLoader::setImage):
              (WebCore::ImageLoader::updateFromElement):
              (WebCore::ImageLoader::notifyFinished):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              (WebCore::AccessibilityRenderObject::addChildren):
              * page/DragController.cpp:
              (WebCore::getCachedImage):
              (WebCore::getImage):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeImage):
              * rendering/RenderImage.h:
              (WebCore::toRenderImage):
              * wml/WMLImageElement.cpp:
              (WebCore::WMLImageElement::parseMappedAttribute):
              (WebCore::WMLImageElement::attach):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcce4080
  11. 02 Feb, 2009 1 commit
    • ggaren@apple.com's avatar
      WebCore: · b6b2bfc9
      ggaren@apple.com authored
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * WebCore.base.exp: Renamed some exports.
              
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::createWindow):
              (windowProtoFuncOpen):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::submit):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::JSLocation::setHref):
              (WebCore::JSLocation::setProtocol):
              (WebCore::JSLocation::setHost):
              (WebCore::JSLocation::setHostname):
              (WebCore::JSLocation::setPort):
              (WebCore::JSLocation::setPathname):
              (WebCore::JSLocation::setSearch):
              (WebCore::JSLocation::setHash):
              (WebCore::JSLocation::assign): Treat any navigation that is not initiated
              by the user as a redirect from the perspective of global history.
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect
              chain.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect):
              (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect):
              (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly,
              added yet another way to track redirect state during loading, since none
              of the others did what I wanted, and I didn't want to cause behavior
              changes in existing code.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              Stubbed out a client function to keep things building.
              
              * loader/FrameLoader.cpp:
              (WebCore::isBackForwardLoadType):
              (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect =>
              FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all
              the other meanings of "redirect" in the loading code.
      
              (WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
              redirect as a redirect from the perspective of global history.
      
              (WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
              parameter.
      
              (WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
      
              (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
              (WebCore::FrameLoader::loadURL):
              (WebCore::FrameLoader::load): Updated for rename and extra parameter.
      
              (WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
              in the DocumentLoader, so it's accessible to WebKit's global history code.
      
              (WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
              only has meaning to global history, and m_quickRedirectComing pertains
              to other kinds of history.
      
              (WebCore::FrameLoader::loadPostRequest):
              (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
              (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
              (WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
              
              (WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
              navigations even if they don't create new history items, so we can track
              the redirect in the existing history item.
      
              * loader/FrameLoader.h: See above.
              
              * loader/FrameLoaderClient.h: New client interface used by
              FrameLoader::updateHistory* to record a redirect even if it doesn't create
              a new history item of its own.
      
              * loader/FrameLoaderTypes.h: See above.
              (WebCore::):
      
              * page/DragController.cpp:
              (WebCore::DragController::performDrag):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged): Updated for extra parameter.
      
      WebKit/gtk:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Track redirects in global history.
      
              Keep GTK building.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::createFrame):
              (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * History/WebHistory.mm:
              (-[WebHistoryPrivate dealloc]):
              (-[WebHistoryPrivate lastVisitedEntry]):
              (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history
              entry in case we're asked to add redirect information to it later.
      
              (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
              (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
              information in global history.
      
              * History/WebHistoryInternal.h:
              * WebCoreSupport/WebFrameLoaderClient.h: See above and below.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect
              information in global history.
      
              * WebView/WebFrame.mm:
              (-[WebFrame loadRequest:]):
              (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
              * WebView/WebFramePrivate.h: Updated for rename and extra parameter.
      
      WebKit/qt:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              Keep Qt building.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem):
              (WebCore::FrameLoaderClientQt::createFrame):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              Store redirect information in global history.
      
              (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
      
              * WebCoreSupport/WebFrameLoaderClient.h: See above.
      
              * WebFrame.cpp:
              (WebFrame::loadRequest):
              (WebFrame::loadData): Updated for extra parameter.
      
              * WebHistory.cpp:
              (WebHistory::visitedURL):
              (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
              information in global history.
      
              * WebHistory.h: See above.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b2bfc9
  12. 12 Jan, 2009 1 commit
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · faced26e
      darin@apple.com authored
              Reviewed by Oliver Hunt.
      
              Bug 23102: turn on unused parameter warnings in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=23102
      
              Fourth step: Remove arguments entirely in the many cases where they are not
              needed at all. This step is a little less mechanical than the earlier ones.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
              the regular expression, since we already specify a-zA-Z in our expression.
      
              * dom/Document.cpp:
              (WebCore::Document::databaseThread): Don't pass in the document when creating
              a DatabaseThread.
      
              * dom/Element.cpp:
              (WebCore::Element::createRareData): Don't pass the element when creating an
              ElementRareData.
              (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
              (WebCore::Element::recalcStyle): Ditto.
      
              * dom/ElementRareData.h: Remove the unused Element* from the constructor and
              the resetComputedStyle function.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
              (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
              (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
              * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
      
              * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
              start and end arguments.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
              and end to pushDownTextDecorationStyleAroundNode.
      
              * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
              unused start and end arguments from pushDownTextDecorationStyleAroundNode.
      
              * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
      
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute): Removed unused Document* argument.
              (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
      
              * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
      
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove): Removed unused DragData argument.
              (WebCore::DragController::performDrag): Call concludeEditDrag rather than
              concludeDrag.
              (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
              (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
              should only be called for edit drags. Removed the action mask argument. Also
              changed dragIsMove call sites to not pass dragData.
      
              * page/DragController.h: Updated for above changes and tweaked comment format.
      
              * page/Frame.cpp:
              (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
      
              * page/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetHeadingLevel): Removed unused object argument.
              (AXAttributedStringAppendText): Ditto.
              (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
      
              * page/mac/FrameMac.mm:
              (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * platform/graphics/SegmentedFontData.cpp:
              (WebCore::SegmentedFontData::containsCharacter): Added.
              (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
              instead of just the first one, using containsCharacter.
      
              * platform/graphics/SegmentedFontData.h: Made more members private.
              Added containsCharacter function member.
      
              * platform/mac/DragImageMac.mm:
              (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
              DragImageRef for clarity, since this is platform-specific code.
              (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
              variable warning.
              (WebCore::scaleDragImage): Ditto.
              (WebCore::dissolveDragImageToFraction): Ditto.
              (WebCore::createDragImageFromImage): Ditto.
              (WebCore::createDragImageIconForCachedImage): Ditto.
      
              * platform/mac/WebFontCache.mm:
              (acceptableChoice): Removed the unused weight-related arguments.
              (betterChoice): Ditto.
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
      
              * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
              because we'd rather get a link error rather than a runtime error if we use it
              for anything, and right now it's not used.
      
              * platform/text/RegularExpression.cpp: Removed unused private data,
              including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
              and lastMatchPos. Made the RegularExpression::Private::regex be private
              and use an accessor function to get at it.
              (WebCore::RegularExpression::RegularExpression): Removed the const char* version
              of the constructor because it's not any more efficient. Changed the boolean
              constructor argument to use TextCaseSensitivity instead to make it less likely
              we'll use it wrong.
              (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
              just use plain old assignment on it. The only reason we do this instead of using
              the compiler generated assignment operator is that we want the Private structure
              to be internal to the .cpp file.
              (WebCore::RegularExpression::match): Added a null check so we won't crash if
              we fail to compile the regular expression. Removed the code to handle multiple
              match strings, since that was unused.
      
              * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
              TextCaseSensitivity and not have a default value. Removed the default constructor,
              and the pattern, match, and pos functions.
      
              * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
              Page.h, because we should eventually use it in all the places where we have
              an argument to control case sensitivity, starting with the functions in this
              class.
      
              * platform/text/mac/ShapeArabic.c:
              (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
              this is code borrowed from ICU, this seems like a simple safe change to make.
              (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
      
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::RenderPath): Removed the unused style argument.
              Also removed the type check. The argument already has the correct type,
              so it's not helpful to upcast it and then check its type again, unless
              we have some reason to believe the type is not reliable. And we don't.
      
              * rendering/RenderPath.h: Removed the RenderStyle* argument to the
              constructor. Also removed the explicit declaration of the destructor.
              It's not helpful or needed.
      
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
              make it clear that just returning an empty rect is not a good implementation.
              Removed the argument names to get rid of the warning.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::printBorderStyle): Removed the unused RenderObject argument.
              (WebCore::operator<<): Updated for the change to printBorderStyle function.
      
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
              * storage/DatabaseThread.h: Ditto.
      
              * storage/LocalStorage.cpp:
              (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
              * storage/LocalStorage.h: Ditto.
      
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
              code location to dispatchGenericEvent.
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::dispatchEvent): Ditto.
      
              * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
              (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
              the RenderPath constructor.
      
              * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
      
              * xml/XSLTProcessor.cpp:
              (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
              (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faced26e
  13. 11 Jan, 2009 1 commit
  14. 10 Dec, 2008 1 commit
    • alice.liu@apple.com's avatar
      WebCore: · c408431d
      alice.liu@apple.com authored
      2008-12-10  Alice Liu  <alice.liu@apple.com>
      
              fixed https://bugs.webkit.org/show_bug.cgi?id=20685
      
              Reviewed by Darin Adler.
      
              Manual test case is manual-tests/drag-image-to-desktop.html
      
              Added new files to projects
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
      
              * page/DragController.cpp:
              (WebCore::DragController::startDrag):
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedImageMIMETypes):
              (WebCore::initializeSupportedImageMIMETypesForEncoding):
      
              These changes add a method to obtain the extension for an image
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::filenameExtension):
              * platform/graphics/BitmapImage.h:
              * platform/graphics/Image.h:
              (WebCore::Image::filenameExtension):
              * platform/graphics/ImageSource.h:
              * platform/graphics/cairo/ImageSourceCairo.cpp:
              (WebCore::ImageSource::filenameExtension):
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::filenameExtension):
      
              These changes added a utility that returns the preferred extension for a UTI
              * platform/graphics/cg/ImageSourceCG.h: Added.
              * platform/graphics/cg/ImageSourceCGMac.mm: Added.
              (WebCore::MIMETypeForImageSourceType):
              (WebCore::preferredExtensionForImageSourceType):
              * platform/graphics/cg/ImageSourceCGWin.cpp: Added.
              (WebCore::MIMETypeForImageSourceType):
              (WebCore::preferredExtensionForImageSourceType):
      
              * platform/mac/MIMETypeRegistryMac.mm:
              moved getMIMETypeForUTI to ImageSourceCGMac.mm
      
              Ask image for its file extension instead of relying on MIME type and file path
              * platform/win/ClipboardWin.cpp:
              (WebCore::createGlobalImageFileDescriptor):
      
              Remove extraneous code from getPreferredExtensionForMIMEType.
              Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
              * platform/win/MIMETypeRegistryWin.cpp:
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
      
      WebKit/mac:
      
      2008-12-10  Alice Liu  <alice.liu@apple.com>
      
              fixed https://bugs.webkit.org/show_bug.cgi?id=20685
      
              Reviewed by Darin Adler.
      
              * Misc/WebNSPasteboardExtras.mm:
              Ask image for its file extension instead of falling back on MIME type and file path.
              Also moved this code to before setting the pasteboard data so as not to set any if
              no extension can be determined.
              (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
      
              * WebView/WebHTMLView.mm:
              Fixed a separate but related long-standing bug of how the filename for the promised
              drag data is determined by asking the image for a proper file extension. 
              (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c408431d
  15. 26 Nov, 2008 1 commit
    • darin@chromium.org's avatar
      2008-10-31 Tony Chang <tony@chromium.org> · 89e50aab
      darin@chromium.org authored
              Reviewed by Oliver Hunt.
      
              Add a new platform specific method cleanupAfterSystemDrag
              that platforms can ue to clean up drag state after a
              system drag.  Use this method on PLAFORM(MAC).
              https://bugs.webkit.org/show_bug.cgi?id=21956
      
              * ChangeLog:
              * page/DragController.cpp:
              (WebCore::DragController::doSystemDrag):
              * page/DragController.h:
              * page/gtk/DragControllerGtk.cpp:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/mac/DragControllerMac.mm:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/qt/DragControllerQt.cpp:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/win/DragControllerWin.cpp:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/wx/DragControllerWx.cpp:
            (WebCore::DragController::cleanupAfterSystemDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e50aab
  16. 24 Nov, 2008 1 commit
  17. 24 Oct, 2008 1 commit
    • adele@apple.com's avatar
      WebCore: · 497541bd
      adele@apple.com authored
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
              This is consistent with the direction HTML5 will be going in the future.
      
              The initial implementation here will show "n files" as the text next to the control when multiple files are selected.  You can view
              the individual files in a tooltip for now.  Improvements to this control will come later.  
      
              Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.  
              These FileList Files can also be sent in an XMLHTTPRequest.
      
              * manual-tests/post-multi-file-upload.html: Added.
              * manual-tests/resources/multiFileResources: Added.
              * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
              * manual-tests/resources/multiFileResources/testFile1.html: Added.
              * manual-tests/resources/multiFileResources/testFile2.html: Added.
              * manual-tests/resources/multiFileResources/testFile3.html: Added.
      
              * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
              (WebCore::HTMLInputElement::value): Added comments.  The HTML5 spec says that value shouldn't apply for the file upload control,
              but we don't want to break the behavior for existing websites that may rely on this.
              (WebCore::HTMLInputElement::setValue): ditto.
              (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
              (WebCore::HTMLInputElement::setFileListFromRenderer): Added. 
              * html/HTMLInputElement.h:
      
              * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
      
              * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
      
              * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
              (WebCore::FileChooser::FileChooser):
              (WebCore::FileChooser::create):
              (WebCore::FileChooser::clear):
              (WebCore::FileChooser::chooseFile):
              (WebCore::FileChooser::chooseFiles):
              (WebCore::FileChooser::chooseIcon):
              * platform/FileChooser.h:
              (WebCore::FileChooser::filePaths):
              (WebCore::FileChooser::allowsMultipleFiles):
      
              * platform/graphics/Icon.h:
              * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
              * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
              * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
              * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
      
              * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):  Updated to deal with new filenames vector.
              * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
              * platform/qt/FileChooserQt.cpp:
              (WebCore::FileChooser::openFileChooser):
              (WebCore::FileChooser::basenameForWidth):
              * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
      
              * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
              Removed unnecessary assertion.  This can get hit when connectionDidFinishLoading and cancel
              both get called for the same ResourceHandle.  This getting called twice has no negative effect.
      
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::valueChanged):  Calls setFileListFromRenderer.
              (WebCore::RenderFileUploadControl::allowsMultipleFiles):  Added.
              (WebCore::RenderFileUploadControl::updateFromElement):  Uses the new filenames call from FileChooser.
              (WebCore::RenderFileUploadControl::receiveDroppedFiles):  Updated to support multiple files.
              * rendering/RenderFileUploadControl.h:
      
      WebKit/mac:
      
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
              (-[WebOpenPanelResultListener chooseFilenames:]):
              * WebView/WebUIDelegate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      497541bd
  18. 12 Oct, 2008 1 commit
  19. 07 Jul, 2008 1 commit
  20. 16 Jun, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 60d3e9f9
      darin@apple.com authored
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebCore.base.exp:
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              (WebCore::JSCustomSQLStatementCallback::handleEvent):
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              (WebCore::JSCustomSQLTransactionCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::JSCustomVoidCallback::handleEvent):
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::allowPopUp):
              (WebCore::createWindow):
              (WebCore::windowProtoFuncOpen):
              (WebCore::toJS):
              (WebCore::toJSDOMWindow):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::toJS):
              (WebCore::toJSDOMWindowShell):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::navigateIfAllowed):
              (WebCore::JSLocation::reload):
              * bindings/js/JSNodeFilterCondition.cpp:
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/kjs_events.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/kjs_html.cpp:
              (WebCore::runtimeObjectImplementsCall):
              * bindings/objc/DOMInternal.mm:
              (-[WebScriptObject _initializeScriptDOMNodeImp]):
              * bridge/jni/jni_jsobject.mm:
              (createRootObject):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              * dom/Document.cpp:
              (WebCore::Document::nodeWillBeRemoved):
              (WebCore::Document::createHTMLEventListener):
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::dispatchGenericEvent):
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::startElementNs):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::respondToChangedSelection):
              (WebCore::DeleteButtonController::enable):
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand):
              * editing/Editor.cpp:
              (WebCore::Editor::selectionForCommand):
              (WebCore::Editor::canEdit):
              (WebCore::Editor::canEditRichly):
              (WebCore::Editor::canDHTMLCut):
              (WebCore::Editor::canDHTMLCopy):
              (WebCore::Editor::canCopy):
              (WebCore::Editor::canDelete):
              (WebCore::Editor::deleteWithDirection):
              (WebCore::Editor::deleteSelectionWithSmartDelete):
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::selectedRange):
              (WebCore::Editor::tryDHTMLCopy):
              (WebCore::Editor::tryDHTMLCut):
              (WebCore::Editor::fontForSelection):
              (WebCore::Editor::selectionUnorderedListState):
              (WebCore::Editor::selectionOrderedListState):
              (WebCore::Editor::increaseSelectionListLevel):
              (WebCore::Editor::increaseSelectionListLevelOrdered):
              (WebCore::Editor::increaseSelectionListLevelUnordered):
              (WebCore::Editor::decreaseSelectionListLevel):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              (WebCore::Editor::applyStyleToSelection):
              (WebCore::Editor::applyParagraphStyleToSelection):
              (WebCore::Editor::selectionHasStyle):
              (WebCore::Editor::appliedEditing):
              (WebCore::Editor::unappliedEditing):
              (WebCore::Editor::reappliedEditing):
              (WebCore::Editor::insertLineBreak):
              (WebCore::Editor::insertParagraphSeparator):
              (WebCore::Editor::paste):
              (WebCore::Editor::selectComposition):
              (WebCore::Editor::confirmComposition):
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::getCompositionSelection):
              (WebCore::Editor::transpose):
              * editing/EditorCommand.cpp:
              (WebCore::expandSelectionToGranularity):
              (WebCore::executeDeleteToMark):
              (WebCore::executeMoveBackward):
              (WebCore::executeMoveBackwardAndModifySelection):
              (WebCore::executeMoveDown):
              (WebCore::executeMoveDownAndModifySelection):
              (WebCore::executeMoveForward):
              (WebCore::executeMoveForwardAndModifySelection):
              (WebCore::executeMoveLeft):
              (WebCore::executeMoveLeftAndModifySelection):
              (WebCore::executeMovePageDown):
              (WebCore::executeMovePageDownAndModifySelection):
              (WebCore::executeMovePageUp):
              (WebCore::executeMovePageUpAndModifySelection):
              (WebCore::executeMoveRight):
              (WebCore::executeMoveRightAndModifySelection):
              (WebCore::executeMoveToBeginningOfDocument):
              (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::executeMoveToBeginningOfLine):
              (WebCore::executeMoveToBeginningOfLineAndModifySelection):
              (WebCore::executeMoveToBeginningOfParagraph):
              (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::executeMoveToBeginningOfSentence):
              (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfDocument):
              (WebCore::executeMoveToEndOfDocumentAndModifySelection):
              (WebCore::executeMoveToEndOfSentence):
              (WebCore::executeMoveToEndOfSentenceAndModifySelection):
              (WebCore::executeMoveToEndOfLine):
              (WebCore::executeMoveToEndOfLineAndModifySelection):
              (WebCore::executeMoveToEndOfParagraph):
              (WebCore::executeMoveToEndOfParagraphAndModifySelection):
              (WebCore::executeMoveParagraphBackwardAndModifySelection):
              (WebCore::executeMoveParagraphForwardAndModifySelection):
              (WebCore::executeMoveUp):
              (WebCore::executeMoveUpAndModifySelection):
              (WebCore::executeMoveWordBackward):
              (WebCore::executeMoveWordBackwardAndModifySelection):
              (WebCore::executeMoveWordForward):
              (WebCore::executeMoveWordForwardAndModifySelection):
              (WebCore::executeMoveWordLeft):
              (WebCore::executeMoveWordLeftAndModifySelection):
              (WebCore::executeMoveWordRight):
              (WebCore::executeMoveWordRightAndModifySelection):
              (WebCore::executeSelectAll):
              (WebCore::executeSelectToMark):
              (WebCore::executeSetMark):
              (WebCore::executeSwapWithMark):
              (WebCore::executeUnselect):
              (WebCore::enabledAnySelection):
              (WebCore::enabledAnySelectionAndMark):
              (WebCore::enabledInRichlyEditableText):
              (WebCore::enabledRangeInEditableText):
              (WebCore::enabledRangeInRichlyEditableText):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
              (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::defaultEventHandler):
              (WebCore::HTMLAnchorElement::setActive):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              * html/HTMLPlugInElement.cpp:
              (WebCore::HTMLPlugInElement::createNPObject):
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::evaluateScript):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::processToken):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::executeScript):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::userGestureHint):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::dispatchWindowObjectAvailable):
              (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::createFromSelection):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::selection):
              (WebCore::AccessibilityRenderObject::setSelectedTextRange):
              (WebCore::AccessibilityRenderObject::isFocused):
              (WebCore::AccessibilityRenderObject::doAXTextMarkerRangeForLine):
              (WebCore::AccessibilityRenderObject::doSetAXSelectedTextMarkerRange):
              (WebCore::AccessibilityRenderObject::doAXRangeForLine):
              (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorNode):
              (WebCore::DOMSelection::baseNode):
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::focusNode):
              (WebCore::DOMSelection::extentNode):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::extentOffset):
              (WebCore::DOMSelection::isCollapsed):
              (WebCore::DOMSelection::type):
              (WebCore::DOMSelection::rangeCount):
              (WebCore::DOMSelection::collapse):
              (WebCore::DOMSelection::collapseToEnd):
              (WebCore::DOMSelection::collapseToStart):
              (WebCore::DOMSelection::empty):
              (WebCore::DOMSelection::setBaseAndExtent):
              (WebCore::DOMSelection::setPosition):
              (WebCore::DOMSelection::modify):
              (WebCore::DOMSelection::extend):
              (WebCore::DOMSelection::getRangeAt):
              (WebCore::DOMSelection::removeAllRanges):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::toString):
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::setSelectionToDragCaret):
              (WebCore::DragController::concludeDrag):
              (WebCore::prepareClipboardForImageDrag):
              (WebCore::DragController::startDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventDoubleClick):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::handleMouseReleaseEvent):
              (WebCore::nodeIsNotBeingEdited):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::sendContextMenuEvent):
              (WebCore::EventHandler::handleKeyboardSelectionMovement):
              (WebCore::EventHandler::handleDrag):
              * page/FocusController.cpp:
              (WebCore::FocusController::setFocusedFrame):
              (WebCore::clearSelectionIfNeeded):
              (WebCore::FocusController::setActive):
              * page/Frame.cpp:
              (WebCore::Frame::~Frame):
              (WebCore::Frame::script):
              (WebCore::Frame::setDocument):
              (WebCore::Frame::selectedText):
              (WebCore::Frame::selection):
              (WebCore::Frame::animation):
              (WebCore::Frame::notifyRendererOfSelectionChange):
              (WebCore::Frame::invalidateSelection):
              (WebCore::Frame::clearCaretRectIfNeeded):
              (WebCore::Frame::setFocusedNodeIfNeeded):
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::caretBlinkTimerFired):
              (WebCore::Frame::paintCaret):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::updateSecureKeyboardEntryIfActive):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::bindingRootObject):
              (WebCore::Frame::windowScriptNPObject):
              (WebCore::Frame::clearScriptController):
              (WebCore::Frame::selectionTextRects):
              (WebCore::Frame::currentForm):
              (WebCore::Frame::revealSelection):
              (WebCore::Frame::revealCaret):
              (WebCore::Frame::clearTimers):
              (WebCore::Frame::styleForSelectionStart):
              (WebCore::Frame::setSelectionFromNone):
              (WebCore::Frame::findString):
              (WebCore::Frame::pageDestroyed):
              (WebCore::Frame::respondToChangedSelection):
              (WebCore::FramePrivate::FramePrivate):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/InspectorController.cpp:
              (WebCore::canPassNodeToJavaScript):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              * page/JavaScriptDebugServer.cpp:
              (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
              * page/Page.cpp:
              (WebCore::Page::findString):
              (WebCore::Page::selection):
              (WebCore::Page::setDebugger):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::baseWritingDirectionForSelectionStart):
              (WebCore::Frame::dragImageForSelection):
              (WebCore::Frame::createScriptInstanceForWidget):
              (WebCore::Frame::windowScriptObject):
              * page/win/FrameWin.cpp:
              (WebCore::Frame::dragImageForSelection):
              * platform/ContextMenu.cpp:
              (WebCore::selectionContainsPossibleWord):
              (WebCore::ContextMenu::populate):
              (WebCore::ContextMenu::checkOrEnableIfNeeded):
              * plugins/PluginView.cpp:
              (WebCore::PluginView::performRequest):
              (WebCore::PluginView::bindingInstance):
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::isSelected):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::paintItemForeground):
              (WebCore::RenderListBox::paintItemBackground):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::selectionBackgroundColor):
              (WebCore::RenderObject::selectionForegroundColor):
              (WebCore::RenderObject::setAnimatableStyle):
              (WebCore::RenderObject::destroy):
              (WebCore::RenderObject::animation):
              * rendering/RenderObject.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionStart):
              (WebCore::RenderTextControl::selectionEnd):
              (WebCore::RenderTextControl::setSelectionRange):
              (WebCore::RenderTextControl::selectionChanged):
              (WebCore::RenderTextControl::capsLockStateMayHaveChanged):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::isFocused):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::destroy):
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::createSVGEventListener):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::deselectAll):
              * svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::selectSubString):
      
      WebKit/gtk:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebCoreSupport/EditorClientGtk.cpp:
              (WebKit::EditorClient::handleKeyboardEvent):
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::windowObjectCleared):
              * webkit/webkitwebframe.cpp:
              * webkit/webkitwebview.cpp:
      
      WebKit/mac:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * Plugins/WebPluginController.mm:
              (-[WebPluginController webPlugInContainerSelectionColor]):
              * WebView/WebFrame.mm:
              (-[WebFrame _attachScriptDebugger]):
              (-[WebFrame _hasSelection]):
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
              (-[WebFrame _convertToNSRange:]):
              (-[WebFrame _convertToDOMRange:]):
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
              (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
              (-[WebFrame _selectedNSRange]):
              (-[WebFrame _selectNSRange:]):
              (-[WebFrame globalContext]):
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _selectedRange]):
              (-[WebHTMLView _hasSelection]):
              (-[WebHTMLView _hasSelectionOrInsertionPoint]):
              (-[WebHTMLView _hasInsertionPoint]):
              (-[WebHTMLView _isEditable]):
              (-[WebHTMLView _updateFocusedAndActiveState]):
              (-[WebHTMLView readSelectionFromPasteboard:]):
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebHTMLView maintainsInactiveSelection]):
              (-[WebHTMLView paste:]):
              (isTextInput):
              (-[WebHTMLView inputContext]):
              (-[WebTextCompleteController doCompletion]):
              (-[WebHTMLView selectAll]):
              (-[WebHTMLView deselectAll]):
              (-[WebHTMLView selectedAttributedString]):
              * WebView/WebView.mm:
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
              (-[WebView setSelectedDOMRange:affinity:]):
              (-[WebView selectedDOMRange]):
              (-[WebView selectionAffinity]):
      
      WebKit/qt:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * Api/qwebframe.cpp:
              (QWebFrame::evaluateJavaScript):
              * Api/qwebpage.cpp:
              (QWebPagePrivate::focusInEvent):
              (QWebPagePrivate::focusOutEvent):
              (QWebPage::inputMethodQuery):
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleKeyboardEvent):
      
      WebKit/win:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebFrame.cpp:
              (WebFrame::globalContext):
              (WebFrame::windowObjectCleared):
              * WebView.cpp:
              (WebView::handleContextMenuEvent):
              (WebViewWndProc):
              (WebView::updateFocusedAndActiveState):
              (WebView::hasSelectedRange):
              (WebView::replaceSelectionWithText):
              (WebView::clearSelection):
              (WebView::prepareCandidateWindow):
              (WebView::onIMERequestCharPosition):
              (WebView::onIMERequestReconvertString):
      
      WebKit/wx:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebKitSupport/EditorClientWx.cpp:
              (WebCore::EditorClientWx::handleKeyboardEvent):
              * WebView.cpp:
              (wxWebView::RunScript):
              (wxWebView::OnSetFocus):
              (wxWebView::OnKillFocus):
      
      WebKitTools:
      
      2008-06-15  Darin Adler  <darin@apple.com>
      
              * Scripts/do-webcore-rename: Updated for the latest round of renaming.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60d3e9f9
  21. 14 Jun, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 48ac3c40
      darin@apple.com authored
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCore.base.exp:
              * bindings/js/JSSVGMatrixCustom.cpp:
              (WebCore::JSSVGMatrix::multiply):
              (WebCore::JSSVGMatrix::inverse):
              (WebCore::JSSVGMatrix::translate):
              (WebCore::JSSVGMatrix::scale):
              (WebCore::JSSVGMatrix::scaleNonUniform):
              (WebCore::JSSVGMatrix::rotate):
              (WebCore::JSSVGMatrix::rotateFromVector):
              (WebCore::JSSVGMatrix::flipX):
              (WebCore::JSSVGMatrix::flipY):
              (WebCore::JSSVGMatrix::skewX):
              (WebCore::JSSVGMatrix::skewY):
              * bindings/js/JSSVGPODTypeWrapper.h:
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
              (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
              (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
              * bindings/js/JSSVGPointListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGPointList::clear):
              (WebCore::JSSVGPointList::initialize):
              (WebCore::JSSVGPointList::getItem):
              (WebCore::JSSVGPointList::insertItemBefore):
              (WebCore::JSSVGPointList::replaceItem):
              (WebCore::JSSVGPointList::removeItem):
              (WebCore::JSSVGPointList::appendItem):
              * bindings/js/JSSVGTransformListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGTransformList::clear):
              (WebCore::JSSVGTransformList::initialize):
              (WebCore::JSSVGTransformList::getItem):
              (WebCore::JSSVGTransformList::insertItemBefore):
              (WebCore::JSSVGTransformList::replaceItem):
              (WebCore::JSSVGTransformList::removeItem):
              (WebCore::JSSVGTransformList::appendItem):
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::CSSFontSelector):
              (WebCore::CSSFontSelector::~CSSFontSelector):
              * css/CSSFontSelector.h:
              (WebCore::CSSFontSelector::create):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Attribute.cpp:
              (WebCore::Attribute::clone):
              * dom/Attribute.h:
              (WebCore::Attribute::create):
              (WebCore::Attribute::Attribute):
              * dom/BeforeTextInsertedEvent.h:
              (WebCore::BeforeTextInsertedEvent::create):
              * dom/BeforeUnloadEvent.h:
              (WebCore::BeforeUnloadEvent::create):
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::dispatchModifiedEvent):
              * dom/ClipboardEvent.cpp:
              (WebCore::ClipboardEvent::ClipboardEvent):
              * dom/ClipboardEvent.h:
              (WebCore::ClipboardEvent::create):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::removeChild):
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/Document.cpp:
              (WebCore::Document::createTextNode):
              (WebCore::Document::createComment):
              (WebCore::Document::createCDATASection):
              (WebCore::Document::createProcessingInstruction):
              (WebCore::Document::createEntityReference):
              (WebCore::Document::createEditingTextNode):
              (WebCore::Document::createEvent):
              (WebCore::Document::createAttributeNS):
              (WebCore::Document::finishedParsing):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::createAttribute):
              * dom/Element.h:
              * dom/Event.cpp:
              (WebCore::Event::Event):
              * dom/Event.h:
              (WebCore::Event::create):
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
              (WebCore::EventTargetNode::dispatchWindowEvent):
              (WebCore::EventTargetNode::dispatchUIEvent):
              (WebCore::EventTargetNode::dispatchKeyEvent):
              (WebCore::EventTargetNode::dispatchMouseEvent):
              (WebCore::EventTargetNode::dispatchWheelEvent):
              (WebCore::EventTargetNode::dispatchHTMLEvent):
              (WebCore::EventTargetNode::dispatchProgressEvent):
              (WebCore::EventTargetNode::dispatchStorageEvent):
              * dom/KeyboardEvent.h:
              (WebCore::KeyboardEvent::create):
              * dom/MappedAttribute.cpp:
              (WebCore::MappedAttribute::clone):
              * dom/MappedAttribute.h:
              (WebCore::MappedAttribute::create):
              (WebCore::MappedAttribute::setDecl):
              (WebCore::MappedAttribute::MappedAttribute):
              * dom/MessageEvent.cpp:
              (WebCore::MessageEvent::MessageEvent):
              * dom/MessageEvent.h:
              (WebCore::MessageEvent::create):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              (WebCore::MouseEvent::initMouseEvent):
              * dom/MouseEvent.h:
              (WebCore::MouseEvent::create):
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              * dom/MouseRelatedEvent.h:
              * dom/MutationEvent.cpp:
              (WebCore::MutationEvent::MutationEvent):
              (WebCore::MutationEvent::initMutationEvent):
              * dom/MutationEvent.h:
              (WebCore::MutationEvent::create):
              * dom/OverflowEvent.h:
              (WebCore::OverflowEvent::create):
              * dom/ProgressEvent.h:
              (WebCore::ProgressEvent::create):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::getMappedAttributeDecl):
              (WebCore::StyledElement::setMappedAttributeDecl):
              (WebCore::StyledElement::removeMappedAttributeDecl):
              (WebCore::StyledElement::createAttribute):
              * dom/StyledElement.h:
              * dom/TextEvent.cpp:
              (WebCore::TextEvent::TextEvent):
              (WebCore::TextEvent::initTextEvent):
              * dom/TextEvent.h:
              (WebCore::TextEvent::create):
              * dom/UIEvent.cpp:
              (WebCore::UIEvent::UIEvent):
              (WebCore::UIEvent::initUIEvent):
              * dom/UIEvent.h:
              (WebCore::UIEvent::create):
              * dom/UIEventWithKeyState.h:
              (WebCore::UIEventWithKeyState::ctrlKey):
              (WebCore::UIEventWithKeyState::shiftKey):
              (WebCore::UIEventWithKeyState::altKey):
              (WebCore::UIEventWithKeyState::metaKey):
              (WebCore::UIEventWithKeyState::UIEventWithKeyState):
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
              (WebCore::WheelEvent::initWheelEvent):
              * dom/WheelEvent.h:
              (WebCore::WheelEvent::create):
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand):
              * editing/AppendNodeCommand.h:
              (WebCore::AppendNodeCommand::create):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::create):
              * editing/BreakBlockquoteCommand.h:
              (WebCore::BreakBlockquoteCommand::create):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::applyStyle):
              (WebCore::CompositeEditCommand::applyStyledElement):
              (WebCore::CompositeEditCommand::removeStyledElement):
              (WebCore::CompositeEditCommand::insertParagraphSeparator):
              (WebCore::CompositeEditCommand::insertLineBreak):
              (WebCore::CompositeEditCommand::insertNodeBefore):
              (WebCore::CompositeEditCommand::appendNode):
              (WebCore::CompositeEditCommand::removeNode):
              (WebCore::CompositeEditCommand::removeNodePreservingChildren):
              (WebCore::CompositeEditCommand::splitTextNode):
              (WebCore::CompositeEditCommand::splitElement):
              (WebCore::CompositeEditCommand::mergeIdenticalElements):
              (WebCore::CompositeEditCommand::wrapContentsInDummySpan):
              (WebCore::CompositeEditCommand::splitTextNodeContainingElement):
              (WebCore::CompositeEditCommand::joinTextNodes):
              (WebCore::CompositeEditCommand::inputText):
              (WebCore::CompositeEditCommand::insertTextIntoNode):
              (WebCore::CompositeEditCommand::deleteTextFromNode):
              (WebCore::CompositeEditCommand::replaceTextInNode):
              (WebCore::CompositeEditCommand::deleteSelection):
              (WebCore::CompositeEditCommand::removeCSSProperty):
              (WebCore::CompositeEditCommand::removeNodeAttribute):
              (WebCore::CompositeEditCommand::setNodeAttribute):
              (WebCore::CompositeEditCommand::appendBlockPlaceholder):
              (WebCore::CompositeEditCommand::insertBlockPlaceholder):
              (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::splitTreeToNode):
              * editing/CompositeEditCommand.h:
              (WebCore::CompositeEditCommand::isFirstCommand):
              * editing/CreateLinkCommand.h:
              (WebCore::CreateLinkCommand::create):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/DeleteFromTextNodeCommand.cpp:
              (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * editing/DeleteFromTextNodeCommand.h:
              (WebCore::DeleteFromTextNodeCommand::create):
              * editing/DeleteSelectionCommand.h:
              (WebCore::DeleteSelectionCommand::create):
              * editing/EditCommand.h:
              (WebCore::SimpleEditCommand::SimpleEditCommand):
              * editing/Editor.cpp:
              (WebCore::Editor::deleteSelectionWithSmartDelete):
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::removeFormattingAndStyle):
              (WebCore::Editor::clearLastEditCommand):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              (WebCore::Editor::indent):
              (WebCore::Editor::outdent):
              (WebCore::dispatchEditableContentChangedEvents):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertFragment):
              (WebCore::executeCreateLink):
              (WebCore::executeFormatBlock):
              (WebCore::executeIndent):
              (WebCore::executeInsertOrderedList):
              (WebCore::executeInsertUnorderedList):
              (WebCore::executeOutdent):
              (WebCore::executeUnlink):
              * editing/FormatBlockCommand.h:
              (WebCore::FormatBlockCommand::create):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/IndentOutdentCommand.h:
              (WebCore::IndentOutdentCommand::create):
              * editing/InsertIntoTextNodeCommand.cpp:
              (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * editing/InsertIntoTextNodeCommand.h:
              (WebCore::InsertIntoTextNodeCommand::create):
              * editing/InsertLineBreakCommand.h:
              (WebCore::InsertLineBreakCommand::create):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h:
              (WebCore::InsertListCommand::create):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
              * editing/InsertNodeBeforeCommand.h:
              (WebCore::InsertNodeBeforeCommand::create):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.h:
              (WebCore::InsertParagraphSeparatorCommand::create):
              * editing/InsertTextCommand.h:
              (WebCore::InsertTextCommand::create):
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
              * editing/JoinTextNodesCommand.h:
              (WebCore::JoinTextNodesCommand::create):
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
              * editing/MergeIdenticalElementsCommand.h:
              (WebCore::MergeIdenticalElementsCommand::create):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/MoveSelectionCommand.h:
              (WebCore::MoveSelectionCommand::create):
              * editing/RemoveCSSPropertyCommand.cpp:
              (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
              * editing/RemoveCSSPropertyCommand.h:
              (WebCore::RemoveCSSPropertyCommand::create):
              * editing/RemoveFormatCommand.h:
              (WebCore::RemoveFormatCommand::create):
              * editing/RemoveNodeAttributeCommand.cpp:
              (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
              * editing/RemoveNodeAttributeCommand.h:
              (WebCore::RemoveNodeAttributeCommand::create):
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::RemoveNodeCommand):
              * editing/RemoveNodeCommand.h:
              (WebCore::RemoveNodeCommand::create):
              * editing/RemoveNodePreservingChildrenCommand.cpp:
              (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
              (WebCore::RemoveNodePreservingChildrenCommand::doApply):
              * editing/RemoveNodePreservingChildrenCommand.h:
              (WebCore::RemoveNodePreservingChildrenCommand::create):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd):
              (WebCore::ReplacementFragment::ReplacementFragment):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::ReplaceSelectionCommand::create):
              * editing/SetNodeAttributeCommand.cpp:
              (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
              * editing/SetNodeAttributeCommand.h:
              (WebCore::SetNodeAttributeCommand::create):
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::SplitElementCommand):
              * editing/SplitElementCommand.h:
              (WebCore::SplitElementCommand::create):
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
              * editing/SplitTextNodeCommand.h:
              (WebCore::SplitTextNodeCommand::create):
              * editing/SplitTextNodeContainingElementCommand.cpp:
              (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              * editing/SplitTextNodeContainingElementCommand.h:
              (WebCore::SplitTextNodeContainingElementCommand::create):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertLineBreak):
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
              (WebCore::TypingCommand::insertParagraphSeparator):
              (WebCore::TypingCommand::insertTextRunWithoutNewlines):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
              (WebCore::TypingCommand::smartDelete):
              * editing/UnlinkCommand.h:
              (WebCore::UnlinkCommand::create):
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
              * editing/WrapContentsInDummySpanCommand.h:
              (WebCore::WrapContentsInDummySpanCommand::create):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
              (WebCore::HTMLTableElement::addSharedCellBordersDecl):
              (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
              (WebCore::HTMLTableElement::addSharedGroupDecls):
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createContainingTable):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              (WebCore::HTMLViewSourceDocument::addLine):
              (WebCore::HTMLViewSourceDocument::addLink):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didOpenURL):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::callListener):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMWindow.cpp:
              (WebCore::PostMessageTimer::PostMessageTimer):
              (WebCore::PostMessageTimer::fired):
              (WebCore::DOMWindow::postMessage):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::keyEvent):
              (WebCore::EventHandler::handleTextInputEvent):
              * page/Frame.cpp:
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::shouldClose):
              * page/FrameView.cpp:
              (WebCore::FrameView::updateOverflowStatus):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::currentKeyboardEvent):
              * page/mac/FrameMac.mm:
              * platform/DeprecatedValueListImpl.cpp:
              (WebCore::DeprecatedValueListImpl::Private::Private):
              (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl):
              (WebCore::DeprecatedValueListImpl::copyOnWrite):
              * platform/graphics/FontSelector.h:
              * platform/graphics/GlyphPageTreeNode.cpp:
              (WebCore::GlyphPageTreeNode::initializePage):
              * platform/graphics/GlyphPageTreeNode.h:
              (WebCore::GlyphPage::create):
              (WebCore::GlyphPage::GlyphPage):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::updateOverflowStatus):
              (WebCore::RenderLayer::updateReflectionStyle):
              * rendering/style/RenderStyle.h:
              (WebCore::TransformOperation::~TransformOperation):
              (WebCore::ScaleTransformOperation::create):
              (WebCore::ScaleTransformOperation::ScaleTransformOperation):
              (WebCore::RotateTransformOperation::create):
              (WebCore::RotateTransformOperation::RotateTransformOperation):
              (WebCore::SkewTransformOperation::create):
              (WebCore::SkewTransformOperation::operator==):
              (WebCore::SkewTransformOperation::SkewTransformOperation):
              (WebCore::TranslateTransformOperation::create):
              (WebCore::TranslateTransformOperation::operator==):
              (WebCore::TranslateTransformOperation::TranslateTransformOperation):
              (WebCore::MatrixTransformOperation::create):
              (WebCore::MatrixTransformOperation::MatrixTransformOperation):
              (WebCore::StyleReflection::create):
              (WebCore::StyleReflection::StyleReflection):
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.h:
              (WebCore::StorageEvent::create):
              (WebCore::StorageEvent::StorageEvent):
              * svg/SVGAngle.cpp:
              (WebCore::SVGAngle::SVGAngle):
              * svg/SVGAngle.h:
              (WebCore::SVGAngle::create):
              * svg/SVGAnimatedTemplate.h:
              (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
              (WebCore::lookupOrCreateWrapper):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible):
              * svg/SVGElement.h:
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::SVGMarkerElement):
              (WebCore::SVGMarkerElement::parseMappedAttribute):
              (WebCore::SVGMarkerElement::setOrientToAngle):
              * svg/SVGMarkerElement.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::createSVGAngle):
              * svg/SVGSVGElement.h:
              * svg/SVGZoomEvent.h:
              (WebCore::SVGZoomEvent::create):
              * svg/graphics/SVGImage.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::callReadyStateChangeListener):
              (WebCore::XMLHttpRequest::dispatchProgressEvent):
              * xml/XMLHttpRequestProgressEvent.cpp:
              * xml/XMLHttpRequestProgressEvent.h:
              (WebCore::XMLHttpRequestProgressEvent::create):
              (WebCore::XMLHttpRequestProgressEvent::position):
              (WebCore::XMLHttpRequestProgressEvent::totalSize):
              (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):
      
      WebKit/mac:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebView/WebFrame.mm:
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ac3c40
  22. 18 Apr, 2008 1 commit
    • eric@webkit.org's avatar
      Reviewed by beth. · 25a1cdf3
      eric@webkit.org authored
              Rename Frame::renderer() to contentRenderer() and fix uses.
      
              * WebCore.base.exp:
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::gotoAnchor):
              * page/DragController.cpp:
              (WebCore::DragController::canProcessDrag):
              (WebCore::DragController::mayStartDragAtEventLocation):
              (WebCore::DragController::startDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::eventMayStartDrag):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::hitTestResultAtPoint):
              (WebCore::EventHandler::hoverTimerFired):
              (WebCore::EventHandler::handleDrag):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::contentRenderer):
              (WebCore::Frame::paint):
              (WebCore::Frame::markAllMatchesForText):
              (WebCore::Frame::documentAtPoint):
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::~FrameView):
              (WebCore::FrameView::adjustViewSize):
              (WebCore::FrameView::layout):
              (WebCore::FrameView::scheduleRelayoutOfSubtree):
              (WebCore::FrameView::needsLayout):
              (WebCore::FrameView::setNeedsLayout):
              (WebCore::FrameView::updateControlTints):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::nativeImageForCurrentFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25a1cdf3
  23. 10 Mar, 2008 1 commit
    • hausmann@webkit.org's avatar
      2008-03-07 Simon Hausmann <hausmann@webkit.org> · 9999bb88
      hausmann@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=16815
      
              Reviewed by Darin.
      
              Done with Lars.
      
      WebCore:
      
              Ported the manually written JS bindings of window.navigator,
              window.navigator.plugins and window.navigator.mimeTypes to
              auto-generated bindings.
      
              Moved the globally cached plugin and mimetype information to a
              per WebCore::Page shared PluginData structure.
      
              Implemented window.navigator.plugins.refresh() in a
              platform-independent way.
      
      LayoutTests:
      
              Added a testcase for http://bugs.webkit.org/show_bug.cgi?id=16815
      
      WebKit/qt:
      
              Replaced the QWebObjectPlugin interfaces with QWebPluginFactory.
      
      WebKit/mac:
      
              Simplified WebViewFactory's refreshPlugins method to only refresh the
              plugins and not reload the frames anymore since that's now done in a
              platform independent manner by WebCore::Page.
      
              Also removed the now unused pluginNameForMIMEType and
              pluginSupportsMIMEType methods.
      
      WebKitTools/DumpRenderTree/qt:
      
              Ported the netscape test plugin to QWebPluginFactory.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9999bb88
  24. 05 Feb, 2008 1 commit
  25. 20 Jan, 2008 1 commit
  26. 08 Jan, 2008 1 commit
  27. 24 Jul, 2007 1 commit
    • oliver's avatar
      WebCore: · 55cc92b5
      oliver authored
              Reviewed by Adam and Justin.
      
              <rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
      
              Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:. 
              Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
              This required lifting local code from DragController.cpp into the shared methods
              Frame::visiblePositionForPoint and Frame::documentAtPoint.
      
              * WebCore.exp:
              * editing/Editor.cpp:
              (WebCore::Editor::rangeForPoint):
              * editing/Editor.h:
              * page/DragController.cpp:
              (WebCore::DragController::dragEnded):
              (WebCore::DragController::performDrag):
              (WebCore::DragController::dragEnteredOrUpdated):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::DragController::operationForLoad):
              (WebCore::setSelectionToDragCaret):
              (WebCore::DragController::concludeDrag):
              (WebCore::DragController::placeDragCaret):
              * page/DragController.h:
              * page/Frame.cpp:
              (WebCore::Frame::visiblePositionForPoint):
              (WebCore::Frame::documentAtPoint):
              * page/Frame.h:
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
      
      WebKit:
      
              Reviewed by Adam and Justin.
      
              <rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
      
              editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
              WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebView.mm:
              (-[WebView moveDragCaretToPoint:]):
              (-[WebView removeDragCaret]):
              (-[WebView editableDOMRangeForPoint:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55cc92b5
  28. 10 Jul, 2007 1 commit
    • darin's avatar
      Reviewed by Anders. · e0cef43d
      darin authored
              - fix <rdar://problem/5318732> REGRESSION: In Mail, a crash occurs when attempting to send
                a HTML based message (nytimes.com, washingtonpost.com, latimes.com)
      
              Did an audit of calls to get the inspector and most other uses of Page* and added null
              checks since Frame* can outlast its Page*.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::createWindow): Added null check.
              (WebCore::FrameLoader::loadSubframe): Ditto.
              (WebCore::FrameLoader::load): Ditto.
              (WebCore::FrameLoader::transitionToCommitted): Ditto.
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.
              (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Ditto.
              (WebCore::FrameLoader::addExtraFieldsToRequest): Ditto.
              (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
              (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
              (WebCore::FrameLoader::requestFromDelegate): Ditto.
              (WebCore::FrameLoader::canGoBackOrForward): Ditto.
              (WebCore::FrameLoader::getHistoryLength): Ditto.
              (WebCore::FrameLoader::historyURL): Ditto.
              (WebCore::FrameLoader::cachePageForHistoryItem): Ditto.
              (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Ditto.
              (WebCore::FrameLoader::goToItem): Ditto.
              (WebCore::FrameLoader::dispatchWindowObjectAvailable): Ditto.
              (WebCore::FrameLoader::dispatchDidCommitLoad): Ditto.
              (WebCore::FrameLoader::dispatchAssignIdentifierToInitialRequest): Ditto.
              (WebCore::FrameLoader::dispatchWillSendRequest): Ditto.
              (WebCore::FrameLoader::dispatchDidReceiveResponse): Ditto.
              (WebCore::FrameLoader::dispatchDidReceiveContentLength): Ditto.
              (WebCore::FrameLoader::dispatchDidFinishLoading): Ditto.
              (WebCore::FrameLoader::dispatchDidLoadResourceFromMemoryCache): Ditto.
      
              * page/ContextMenuController.h:
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::ContextMenuController): Removed unneeded and
              unused Page* parameter.
              (WebCore::openNewWindow): Added null check.
              (WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
      
              * page/InspectorController.h:
              (WebCore::InspectorController::pageDestroyed): Added. Since this object is
              owned by the Page and has a back-pointer to it, it needs an explicit disconnect.
              There's already a higher-level one, but this is more reliable than that.
              * page/InspectorController.cpp:
              (WebCore::InspectorController::windowScriptObjectAvailable): Added null check.
              (WebCore::InspectorController::windowUnloading): Ditto.
      
              * page/Page.cpp:
              (WebCore::Page::Page): Updated for change in parameters of ContextMenuController 
              constructor.
              (WebCore::Page::~Page): Added call to InspectorController pageDestroyed().
      
              * page/Chrome.cpp: Updated includes.
              * page/DragController.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0cef43d
  29. 25 Jun, 2007 1 commit
  30. 25 May, 2007 1 commit
    • ggaren's avatar
      Reviewed by Darin Adler. · 6ad6e760
      ggaren authored
              Fixed a bug with Settings where a number of different objects held bare 
              Settings* data members, even though the Page owns the Settings object and 
              deletes it upon destruction.
      
              Added NULL checks since the Page can be deleted before the frame/document.
      
              * page/Settings.cpp: Removed reliance on setNeedsReapplyStylesForSettingsChange.
      
              * css/cssstyleselector.cpp: CSSStyleSelector was the worst offender. It 
              held a number of back pointers that were not guaranteed. I removed the 
              Settings*, Frame*, and FrameView* back pointers, but others could probably 
              go, too. I replaced them with a single Document* pointer, which is guaranteed
              because the Document owns the CSSStyleSelector.
      
              * page/Page.cpp: Removed setNeedsReapplyStylesForSettingsChange -- the 
              Settings object is now a proper subcontroller of Page, so it doesn't need
              to use a global table to find its page anymore. Also, this function
              confusingly implied that the Frames in a page can have heterogeneous settings,
              which is not true.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad6e760
  31. 12 May, 2007 1 commit
    • oliver's avatar
      2007-05-12 Oliver Hunt <oliver@apple.com> · 52e744de
      oliver authored
      LayoutTests:
      
              Reviewed by Hyatt.
              
              Add test to verify files can be dragged to <input type="file">
      
              * fast/forms/dragging-to-file-input-expected.txt: Added.
              * fast/forms/dragging-to-file-input.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              <rdar://problem/4728842> Can't drag-and-drop files onto <input type="file">
              
              This patch allows a file to be dropped on to a file input field.  There
              are a few changes for data handling and a  few to allow the data to be
              threaded to the appropriate places.
      
              * page/DragController.cpp:
              (WebCore::asFileInput):
                 When dropping a file onto a file input we may mouse over either 
                 the element itself, or the contained button element.  This method
                 returns the base element for the file input in either of these
                 cases.
              (WebCore::DragController::tryDocumentDrag):
                 Don't try to set the drag caret to a file input.
              (WebCore::DragController::concludeDrag):
                 Handle dropping onto a file input element.
              (WebCore::DragController::canProcessDrag):
                 We can now process a file being dragged onto a file input element.
                 
              * platform/DragData.h:
                 New accessors
                 
              * platform/gdk/DragDataGdk.cpp:
              (WebCore::DragData::containsFiles):
              (WebCore::DragData::asFilenames):
                 Link stubs.
                 
              * platform/mac/DragDataMac.mm:
              (WebCore::DragData::containsFiles):
              (WebCore::DragData::asFilenames):
                 Implement new accessors
              (WebCore::DragData::containsCompatibleContent):
                 Update containsCompatibleContent to allow standalone files.
                
              * platform/qt/DragDataQt.cpp:
              (WebCore::DragData::containsFiles):
              (WebCore::DragData::asFilenames):
                 Link stubs
                            
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::receiveDroppedFile):
              * rendering/RenderFileUploadControl.h:
                 For security reasons we don't have an api to allow us to set 
                 a value directly on a file input -- attempts to do so are
                 blocked.  By adding a method to set the target through the 
                 render we bypass such restrictions, and ensure the renderer
                 is updated correctly.
      
      WebKitTools:
      
              Reviewed by Hyatt.
              
              Add new api to DRT to allow us to test a file being dragged 
              onto <input type="file">
      
              * DumpRenderTree/DumpRenderTree.h:
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController addFileToPasteboardOnDrag]):
              (runTest):
              * DumpRenderTree/UIDelegate.m:
              (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52e744de
  32. 10 May, 2007 1 commit
    • adele's avatar
      LayoutTests: · eaa0055b
      adele authored
              Reviewed by Hyatt.
      
              Test for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
      
              * fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum: Added.
              * fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png: Added.
              * fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
              * fast/overflow/scroll-nested-positioned-layer-in-overflow.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              WebCore part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
      
              Test: fast/overflow/scroll-nested-positioned-layer-in-overflow.html
      
              Merged visibleSelectionRect into selectionRect.  selectionRect() now takes an argument to determine
              whether or not to return a rect that clips to the visible content.  This change makes all of the implementations of selectionRect
              consistent by having them all consider the repaint rect when clipping to visible content.
      
              * page/Frame.cpp:
              (WebCore::Frame::revealSelection): Call selectionRect with clipToVisibleContent = false, so we can get a rect that's not visible to reveal.
              (WebCore::Frame::selectionRect): Added clipToVisibleContent argument, and merged visibleSelectionRect into this method.
              (WebCore::Frame::setIsActive): Use selectionRect instead of visibleSelectionRect.
              * page/Frame.h:
              * page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): Update layout before creating the image.  Use selectionRect instead of visibleSelectionRect.
              * page/DragController.cpp: (WebCore::dragLocForSelectionDrag): Use selectionRect instead of visibleSelectionRect.
      
              * rendering/RenderBR.h: (WebCore::RenderBR::selectionRect): Updated argument.
              * rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRect): ditto.
              * rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRect): ditto.
              * rendering/RenderSVGInlineText.h: ditto.
              * rendering/RenderObject.h: 
              (WebCore::RenderObject::selectionRect): ditto.
              (WebCore::RenderObject::SelectionInfo::SelectionInfo): ditto.
              * rendering/RenderView.cpp:
              (WebCore::RenderView::selectionRect): ditto.
              (WebCore::RenderView::setSelection): ditto.
              * rendering/RenderView.h:
      
              * rendering/RenderText.h:
              * rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Only call computeAbsoluteRepaintRect when clipping to visible content.
              Otherwise, just adjust the rect to the correct position.
              * rendering/RenderListMarker.h:
              * rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRect):
                To match what we do in RenderText, if we're trying to clip to visible content, just call computeAbsoluteRepaintRect.
              * rendering/RenderReplaced.h:
              * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): ditto.
      
              * rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Check for a parent layer at the beginning, so we can try to scroll all of our parent layers 
                first, before trying to scroll the top level view.  Also, don't try to scroll overflow layers that have -webkit-line-clamp restricting the height.
                This will prevent us from revealing text hidden by the slider in Safari RSS.
      
              * WebCore.exp: Update symbols for WebKit.
      
      WebKit:
      
              Reviewed by Hyatt.
      
              WebKit part of fix for <rdar://problem/4100616> Doing a "find" in RSS doesn't scroll to result
      
              Updated to use selectionRect instead of visibleSelectionRect.  selectionRect() now returns the visible rect by default.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
              (-[WebHTMLView selectionImageRect]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa0055b
  33. 29 Apr, 2007 1 commit
    • oliver's avatar
      Reviewed by Steve. · 73b4f89f
      oliver authored
              Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)
      
              Added logic to ensure that when we create the drag image
              we're looking at the rendered image size.
      
              * page/DragController.cpp:
              (WebCore::DragController::doImageDrag):
                Pass the rendered image size to fitDragImageToMaxSize
      
              * platform/DragImage.cpp:
              (WebCore::fitDragImageToMaxSize):
                 Need to do scaling relative to rendered image size
      
              * platform/DragImage.h:
                 scaleDragImage needs x and y scales to allow for them to be
                 scaled seperately on a page
      
              * platform/gdk/DragImageGdk.cpp:
              (WebCore::scaleDragImage):
                 Prevent build bustage
      
              * platform/mac/DragImageMac.mm:
              (WebCore::scaleDragImage):
                 scale width and height independently
      
              * platform/qt/DragImageQt.cpp:
              (WebCore::scaleDragImage):
                 Prevent build bustage
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73b4f89f
  34. 08 Apr, 2007 1 commit
  35. 05 Apr, 2007 1 commit
    • ggaren's avatar
      Reviewed by Beth Dakin. · 85a705e0
      ggaren authored
              More clean-up while fixing <rdar://problem/5112273> REGRESSION(TOT): 
              Reproducible crash loading an old version of amazon.com as a web archive
              
              Layout tests pass.
              
              Removed more superfluous document NULL checks. (Node::document() never 
              returns NULL, and it asserts as much.)
              
              Merged some duplicate editing code into a static inline function.
              
              * page/mac/WebCoreFrameBridge.mm:
              (updateRenderingForBindings): Removed superfluous static_cast.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85a705e0
  36. 29 Mar, 2007 1 commit
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 06d89a01
      oliver authored
              Reviewed by Hyatt.
      
              Rename DocLoader::setPasteInProgress, etc to more generic 
              setAllowStaleResources, etc
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
              (WebCore::DocLoader::checkForReload):
              * loader/DocLoader.h:
              (WebCore::DocLoader::setAllowStaleResources):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d89a01
  37. 28 Mar, 2007 1 commit
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c8a4876
      oliver authored
              Reviewed by Anders and Steve.
      
              Add a flag to DocLoader to prevent it from reloading 
              when performing a paste or drop operation.
              
              Remove m_cachePolicy from CachedResource as it is never used
              
              Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures 
              dragging image into GMail message in _web_writeImage and 
              documentFragmentFromDragData
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
                prevent the docloader from reloading resources on paste
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::updateFromElement):
              * loader/Cache.cpp:
              (WebCore::createResource):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::CachedImage):
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource):
              * loader/CachedResource.h:
              * loader/CachedScript.cpp:
              (WebCore::CachedScript::CachedScript):
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              (WebCore::CachedXBLDocument::CachedXBLDocument):
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
                 Tidy up constructor initialise new field
              (WebCore::DocLoader::checkForReload):
                 Prevent reload when pasting
              * loader/DocLoader.h:
              (WebCore::DocLoader::setPasteInProgress):
                new field and setter
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
                prevent the docloader from reloading resources on drop
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c8a4876