1. 18 Jan, 2011 8 commits
    • commit-queue@webkit.org's avatar
      2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn> · 2d2bdd50
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Unable to indirectly animate visibility of SVGUseElement
              https://bugs.webkit.org/show_bug.cgi?id=50240
      
              Test case to verify if SVGUseElement inherits parent's
              style change.
      
              * svg/custom/use-inherit-style-expected.txt: Added.
              * svg/custom/use-inherit-style.svg: Added.
      2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>
      
              Reviewed by Nikolas Zimmermann.
      
              Unable to indirectly animate visibility of SVGUseElement
              https://bugs.webkit.org/show_bug.cgi?id=50240
      
              SVGUseElement::recalcStyle should take care of its shadow
              tree's style recalculation when it is called with change >= Inherit
              or when childNeedsStyleRecalc() is true because in these two
              cases needStyleRecalc() may not be true.
      
              Test: svg/custom/use-inherit-style.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::recalcStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d2bdd50
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 7d9eb55d
      podivilov@chromium.org authored
              Unreviewed, remove wrong chromium expectation for console-xhr-logging test.
      
              * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d9eb55d
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · cc9a61db
      podivilov@chromium.org authored
              Unreviewed, test fix for r76019.
      
              * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
              * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc9a61db
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 37dda3c5
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix flaky debugger tests.
              https://bugs.webkit.org/show_bug.cgi?id=51320
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.setBreakpoint):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              (initialize_DebuggerTest.InspectorTest._showScriptSource):
              * inspector/debugger-pause-on-breakpoint-expected.txt:
              * inspector/debugger-pause-on-breakpoint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37dda3c5
    • antti@apple.com's avatar
      Source/WebCore: 2011-01-18 Antti Koivisto <antti@apple.com> · 84c087a0
      antti@apple.com authored
      Reviewed by Dave Hyatt.
      
      https://bugs.webkit.org/show_bug.cgi?id=52370
      <rdar://problem/8856808>
      Style sharing optimization no longer works on major web sites
              
      The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated 
      by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
      the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.  
              
      This patch gets the style sharing back to 25-40% range on most web sites.
      
      * css/CSSMutableStyleDeclaration.h:
      (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
                  
          Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
              
      * css/CSSSelector.h:
      (WebCore::CSSSelector::isSiblingSelector):
              
          Test for selectors that are affected by the sibling elements.
              
      * css/CSSStyleSelector.cpp:
      (WebCore::elementCanUseSimpleDefaultStyle):
      (WebCore::collectSiblingRulesInDefaultStyle):
      (WebCore::assertNoSiblingRulesInDefaultStyle):
                  
          Extract sibling rules from the MathML default stylesheet. 
          Assert that no other default stylesheet has them.
                  
      (WebCore::CSSStyleSelector::CSSStyleSelector):
      (WebCore::CSSStyleSelector::locateCousinList):
      (WebCore::CSSStyleSelector::matchesSiblingRules):
      (WebCore::CSSStyleSelector::canShareStyleWithElement):
      (WebCore::CSSStyleSelector::locateSharedStyle):
      (WebCore::CSSStyleSelector::styleForElement):
      (WebCore::collectIdsAndSiblingRulesFromList):
      (WebCore::CSSRuleSet::collectIdsAndSiblingRules):
      
          Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
          where style sharing can't be used.
      
      * css/CSSStyleSelector.h:
      * dom/NamedNodeMap.cpp:
      (WebCore::NamedNodeMap::mappedMapsEquivalent):
                  
          Check also for CSSValue mutation from DOM. 
                  
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedIntoDocument):
      * mathml/MathMLMathElement.h:
              
          MathML default style sheet has sibling rules which don't get noticed by the normal document
          stylesheet parsing.
              
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::setFirstChildState):
      (WebCore::InheritedFlags::setLastChildState):
      (WebCore::InheritedFlags::setChildIndex):
              
          These all make style non-shareable (unique).
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
      Style sharing optimization no longer works on major web sites
              
      Reviewed by Dave Hyatt.
      
      These are progressions (with no noticable visual change). 
      MathML code was improperly sharing style.
      
      * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
      * platform/mac/mathml/presentation/subsup-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c087a0
    • philn@webkit.org's avatar
      2011-01-18 Philippe Normand <pnormand@igalia.com> · e4ac69da
      philn@webkit.org authored
              Unreviewed, rolling out r76002.
              http://trac.webkit.org/changeset/76002
              https://bugs.webkit.org/show_bug.cgi?id=49790
      
              breaks a bunch of fast/forms tests on mac and GTK
      
              * fast/forms/select-option-background-color-change.html: Removed.
              * fast/forms/select-option-color-change.html: Removed.
              * fast/forms/select-option-visibility-change.html: Removed.
              * platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
              * platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
              * platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
              * platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
              * platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
              * platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
              * platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
              * platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
              * platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.
      2011-01-18  Philippe Normand  <pnormand@igalia.com>
      
              Unreviewed, rolling out r76002.
              http://trac.webkit.org/changeset/76002
              https://bugs.webkit.org/show_bug.cgi?id=49790
      
              breaks a bunch of fast/forms tests on mac and GTK
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::setRenderStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4ac69da
    • ossy@webkit.org's avatar
      Unreviewed. · 146ded8e
      ossy@webkit.org authored
      [Qt] Fix LoadHTMLStringItem::invoke() after r75966
      https://bugs.webkit.org/show_bug.cgi?id=52614
      
      * platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      146ded8e
    • rwlbuis@webkit.org's avatar
      2011-01-17 Rob Buis <rwlbuis@gmail.com> · f5461080
      rwlbuis@webkit.org authored
              Reviewed by Kent Tamura.
      
              Color changes to option elements in a select multiple aren't drawn immediately
              https://bugs.webkit.org/show_bug.cgi?id=49790
      
              Redirect style changes on <option> element to the owner <select> element.
      
              Tests: fast/forms/select-option-background-color-change.html
                     fast/forms/select-option-color-change.html
                     fast/forms/select-option-visibility-change.html
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::setRenderStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5461080
  2. 17 Jan, 2011 21 commits
    • commit-queue@webkit.org's avatar
      2011-01-17 Steve Lacey <sjl@chromium.org> · f939c8ad
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Rebaseline media/video-zoom-controls for chromium.
              https://bugs.webkit.org/show_bug.cgi?id=52415
      
              * platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added.
              * platform/chromium-linux/media/video-zoom-controls-expected.png: Added.
              * platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added.
              * platform/chromium-mac/media/video-zoom-controls-expected.png: Added.
              * platform/chromium-mac/media/video-zoom-controls-expected.txt: Added.
              * platform/chromium-win/media/video-zoom-controls-expected.checksum: Added.
              * platform/chromium-win/media/video-zoom-controls-expected.png: Added.
              * platform/chromium-win/media/video-zoom-controls-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f939c8ad
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 95d4bfae
      dimich@chromium.org authored
      Added TIMEOUT to  fast/canvas/canvas-fillPath-pattern-shadow.html
      
      * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d4bfae
    • msaboff@apple.com's avatar
      2011-01-17 Michael Saboff <msaboff@apple.com> · b1155bd1
      msaboff@apple.com authored
              Reviewed by Oliver Hunt.
      
              [regexfuzz] Crash running regex with lookahead
              https://bugs.webkit.org/show_bug.cgi?id=52548
      
              Eliminated agressive chaining of backtracks.  This code was overwriting
              already valid backtrack information.
      
              * yarr/YarrJIT.cpp:
              (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):
      2011-01-17  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Oliver Hunt.
      
              [regexfuzz] Crash running regex with lookahead
              https://bugs.webkit.org/show_bug.cgi?id=52548
      
              New tests from regex fuzzer.
      
              * fast/regex/parentheses-expected.txt:
              * fast/regex/script-tests/parentheses.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1155bd1
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 212b8fc1
      dimich@chromium.org authored
      Same as previous patch, now for -gpu file.
      
      * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212b8fc1
    • dimich@chromium.org's avatar
      [Chromium] Not reviewed, test expectations update. · 5951b3da
      dimich@chromium.org authored
      fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5951b3da
    • aroben@apple.com's avatar
      Don't access the CACFLayerRef's sublayers directly from PlatformCALayer · 7317c459
      aroben@apple.com authored
      There might be a secret extra sublayer (the tile parent layer) that
      PlatformCALayer doesn't know about. When PlatformCALayer would
      encounter this, it would try to use the tile parent layer's
      PlatformCALayer wrapper, which was null, and then would crash. We now
      ask PlatformCALayerWinInternal for the sublayer list, since that class
      knows about the tile parent layer and can exclude it from the sublayer
      list.
      
      Covered by compositing/tiling/huge-layer-resize.html.
      
      Fixes <http://webkit.org/b/52597> Crash beneath
      PlatformCALayer::adoptSublayers when switching out of tiling mode
      (null-dereference of a PlatformCALayer)
      
      Reviewed by Darin Adler and Chris Marrin.
      
      LayoutTests:
      
      Make compositing/tiling/huge-layer-resize.html faster, more reliable,
      and more crashy (when there's a WebKit bug)
      
      This test was trying to cause a layout/paint to happen by returning to
      the event loop for a certain amount of time via setTimeout. But this
      didn't always result in a layout/paint (at least on Windows). We now
      force the layout/paint explicitly, which also lets us speed up the test
      by removing the setTimeouts.
      
      * compositing/tiling/huge-layer-resize.html:
      (testOnLoad): Changed to use recordLayerTree, which forces a
      layout/paint, instead of hoping that setTimeout will do the trick.
      (recordLayerTree): Forces a layout/paint, then dumps the layer tree.
      
      Source/WebCore:
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      (PlatformCALayer::adoptSublayers):
      (printLayer):
      Changed to use PlatformCALayerWinInternal::getSublayers.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
      (PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
      of PlatformCALayers that represent our sublayers. Significantly, this
      code knows about the tile parent layer and can thus exclude it.
      
      * platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added
      getSublayers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7317c459
    • mitz@apple.com's avatar
      Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font · 78de1d02
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52598
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Test: fast/css/font-face-zero-hash-key.html
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.
      * css/CSSSegmentedFontFace.cpp:
      (WebCore::CSSSegmentedFontFace::getFontData): Ditto.
      
      LayoutTests: 
      
      * fast/css/font-face-zero-hash-key-expected.txt: Added.
      * fast/css/font-face-zero-hash-key.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78de1d02
    • commit-queue@webkit.org's avatar
      2011-01-17 Helder Correia <helder@sencha.com> · 51fd6f02
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Incorrect shadow alpha with pattern fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52559
      
              The shadow color opacity needs to be set on the shadow painter.
              This is related to bug 52556.
      
              * fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.
      2011-01-17  Helder Correia  <helder@sencha.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] Incorrect shadow alpha with pattern fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52559
      
              The shadow color opacity needs to be set on the shadow painter.
              This is related to bug 52556.
      
              Test: fast/canvas/canvas-fillPath-pattern-shadow.html
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51fd6f02
    • ddkilzer@apple.com's avatar
      2011-01-17 David Kilzer <ddkilzer@apple.com> · 5827990f
      ddkilzer@apple.com authored
              <http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows
      
              Reviewed by Alexey Proskuryakov.
      
              * platform/win/Skipped: Removed
              fast/dom/Range/range-clone-contents.html.  It appears the
              Windows buildbots need a clean build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5827990f
    • jberlin@webkit.org's avatar
      REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when · d617a3b2
      jberlin@webkit.org authored
      navigating back to an unreachable URL
      https://bugs.webkit.org/show_bug.cgi?id=52388
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Test: http/tests/navigation/go-back-to-error-page.html
      
      * history/PageCache.cpp:
      (WebCore::PageCache::canCachePageContainingThisFrame):
      Do not cache any error pages (which we can recognize as having substitute data and/or an
      unreachableURL).
      
      Tools: 
      
      Add a third parameter (unreachableURL) to queueLoadHTMLString.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (queueLoadHTMLStringCallback):
      (LayoutTestController::queueLoadHTMLString):
      (LayoutTestController::queueLoadAlternateHTMLString):
      * DumpRenderTree/LayoutTestController.h:
      
      * DumpRenderTree/WorkQueueItem.h:
      (LoadHTMLStringItem::LoadHTMLStringItem):
      
      * DumpRenderTree/chromium/LayoutTestController.cpp:
      (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
      (WorkItemLoadHTMLString::run):
      (LayoutTestController::queueLoadHTMLString):
      
      * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/mac/WorkQueueItemMac.mm:
      (LoadHTMLStringItem::invoke):
      * DumpRenderTree/win/WorkQueueItemWin.cpp:
      (LoadHTMLStringItem::invoke):
      
      LayoutTests: 
      
      Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
      page, and then goes back to the "unreachable" URL, which is now reachable.
      
      This tests two things:
      1) No assertion failure when going back to an unreachable URL.
      2) There is no page cached for the unreachable URL.
      
      * http/tests/navigation/go-back-to-error-page-expected.txt: Added.
      * http/tests/navigation/go-back-to-error-page.html: Added.
      * http/tests/navigation/resources/page-to-go-back-from.html: Added.
      * http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d617a3b2
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · d55413b4
      pfeldman@chromium.org authored
              Not reviewed: skip flaky inspector test (will look at it tomorrow).
      
              * platform/mac-leopard/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d55413b4
    • caseq@chromium.org's avatar
      2011-01-17 Andrey Kosyakov <caseq@chromium.org> · 0b0683cc
      caseq@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
              Make resource start/finish hanlding more consistent.
              https://bugs.webkit.org/show_bug.cgi?id=52452
      
              * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
              (WebInspector.AuditLauncherView.prototype._resetResourceCount):
              (WebInspector.AuditLauncherView.prototype.resourceStarted):
              (WebInspector.AuditLauncherView.prototype.resourceFinished):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
              (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
              (WebInspector.NetworkManager.prototype.willSendRequest):
              (WebInspector.NetworkManager.prototype.markResourceAsCached):
              (WebInspector.NetworkManager.prototype.didReceiveResponse):
              (WebInspector.NetworkManager.prototype.didReceiveContentLength):
              (WebInspector.NetworkManager.prototype.didFinishLoading):
              (WebInspector.NetworkManager.prototype.didFailLoading):
              (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
              (WebInspector.NetworkManager.prototype.didCreateWebSocket):
              (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
              (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
              (WebInspector.NetworkManager.prototype.didCloseWebSocket):
              (WebInspector.NetworkManager.prototype._appendRedirect):
              (WebInspector.NetworkManager.prototype._startResource):
              (WebInspector.NetworkManager.prototype._finishResource):
      
      2011-01-17  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
              Added test for finished event being sent for redirected resources.
              https://bugs.webkit.org/show_bug.cgi?id=52452
      
              * http/tests/inspector/extensions-resources-redirect-expected.txt:
              * http/tests/inspector/extensions-resources-redirect.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b0683cc
    • pfeldman@chromium.org's avatar
      2011-01-17 Pavel Feldman <pfeldman@chromium.org> · 429bcf2c
      pfeldman@chromium.org authored
              Not reviewed: first timeline-network-resource flakiness.
      
              * inspector/timeline-network-resource.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429bcf2c
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 126363a4
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix flaky debugger tests.
              https://bugs.webkit.org/show_bug.cgi?id=51320
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.setBreakpoint):
              * inspector/debugger-breakpoints-not-activated-on-reload.html:
              * inspector/debugger-pause-on-breakpoint-expected.txt:
              * inspector/debugger-pause-on-breakpoint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      126363a4
    • ossy@webkit.org's avatar
      Unreviewed. · 54a5efd6
      ossy@webkit.org authored
      Add Qt specific expected results for passing CSS tests.
      Compared to Mac png files and Mac expected files.
      
      * platform/qt/Skipped: Unskip passing tests.
      * platform/qt/css1/[...]: Added.
      * platform/qt/css2.1/[...]: Added.
      * platform/qt/css3/[...]: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54a5efd6
    • rik@webkit.org's avatar
      2011-01-17 Anthony Ricaud <rik@webkit.org> · 4cfa85f5
      rik@webkit.org authored
              Reviewed by Kent Tamura.
      
              [HTML5] Revert display:none on datalist
              https://bugs.webkit.org/show_bug.cgi?id=52214
      
              * fast/forms/datalist-expected.txt:
              * fast/forms/datalist-nonoption-child-expected.txt:
              * fast/forms/datalist.html:
      2011-01-17  Anthony Ricaud  <rik@webkit.org>
      
              Reviewed by Kent Tamura.
      
              [HTML5] Revert display:none on datalist
              https://bugs.webkit.org/show_bug.cgi?id=52214
      
              * css/html.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cfa85f5
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 3dcea969
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
              https://bugs.webkit.org/show_bug.cgi?id=51738
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              (initialize_DebuggerTest.InspectorTest._showScriptSource):
              * inspector/debugger-pause-in-eval-script-expected.txt:
              * inspector/debugger-pause-in-eval-script.html:
      2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
              https://bugs.webkit.org/show_bug.cgi?id=51738
      
              Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
              Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.
      
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              (WebInspector.SourceFrameContentProviderForScript):
              (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
              (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
              (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._addScript):
              (WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
              (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype.set visible):
              (WebInspector.SourceFrame.prototype._createTextViewer):
              (WebInspector.SourceFrame.prototype._breakpointAdded):
              (WebInspector.SourceFrame.prototype._breakpoints):
              (WebInspector.SourceFrame.prototype._sourceIDForLine):
              (WebInspector.SourceFrame.prototype._sourceIDSet):
              (WebInspector.SourceFrameContentProvider):
              (WebInspector.SourceFrameContentProvider.prototype.requestContent):
              (WebInspector.SourceFrameContentProvider.prototype.scripts):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
              (WebInspector.SourceView.prototype.show):
              (WebInspector.SourceView.prototype.resize):
              (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
              (WebInspector.SourceView.prototype.performSearch):
              (WebInspector.SourceView.prototype.revealLine):
              (WebInspector.SourceView.prototype.highlightLine):
              (WebInspector.SourceView.prototype._jumpToSearchResult):
              (WebInspector.SourceFrameContentProviderForResource):
              (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
              (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dcea969
    • jknotten@chromium.org's avatar
      2011-01-17 John Knottenbelt <jknotten@chromium.org> · 390c2e34
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              fast/dom/window-close-crash.html tests that we do not fail the
              assertion in the mock GeolocationClient that the GeolocationClient
              is not updating when the GeolocationController is destroyed.
      
              * fast/dom/Geolocation/resources/window-close-popup.html: Added.
              * fast/dom/Geolocation/script-tests/window-close-crash.js: Added.
              (gotPosition):
              (waitForWindowToClose):
              (failedToCreateWatch):
              * fast/dom/Geolocation/window-close-crash-expected.txt: Added.
              * fast/dom/Geolocation/window-close-crash.html: Added.
              * platform/gtk/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      2011-01-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              Test: fast/dom/Geolocation/window-close-crash.html
      
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
      2011-01-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              GeolocationController should call stopUpdating on destruction
              https://bugs.webkit.org/show_bug.cgi?id=52216
      
              fast/dom/Geolocation/window-close-crash.html requires that a
              Geolocation watch be started in a secondary window. Consequently,
              we need to allow geolocation permission and provide a mock
              geolocation position for the secondary window's
              GeolocationClientMock.
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setGeolocationPermission):
              (LayoutTestController::setMockGeolocationPosition):
              (LayoutTestController::setMockGeolocationError):
              * DumpRenderTree/chromium/TestShell.h:
              (TestShell::windowList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      390c2e34
    • loislo@chromium.org's avatar
      2011-01-14 Ilya Tikhonovsky <loislo@chromium.org> · 86cbf0cf
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Enable inspector's tests for chromium Linux.
              https://bugs.webkit.org/show_bug.cgi?id=52445
      
              * platform/chromium/inspector/timeline-network-resource-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86cbf0cf
    • commit-queue@webkit.org's avatar
      2011-01-17 Helder Correia <helder@sencha.com> · fd84b4d1
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
              https://bugs.webkit.org/show_bug.cgi?id=52556
      
              The shadow color opacity needs to be set on the shadow painter.
              Additionally, the gradient brush should be transformed.
      
              * platform/qt/Skipped: Remove test from skipped list.
      2011-01-17  Helder Correia  <helder@sencha.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
              https://bugs.webkit.org/show_bug.cgi?id=52556
      
              The shadow color opacity needs to be set on the shadow painter.
              Additionally, the gradient brush should be transformed.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd84b4d1
    • philn@webkit.org's avatar
      2011-01-17 Philippe Normand <pnormand@igalia.com> · 29c909d5
      philn@webkit.org authored
              Unreviewed, rolling out r75914.
              http://trac.webkit.org/changeset/75914
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              multiple crashes on GTK
      
              * platform/gtk/Skipped:
      2011-01-17  Philippe Normand  <pnormand@igalia.com>
      
              Unreviewed, rolling out r75914.
              http://trac.webkit.org/changeset/75914
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              multiple crashes on GTK
      
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::removeChild):
              (WebCore::ScrollView::wheelEvent):
              * platform/gtk/MainFrameScrollbarGtk.cpp:
              (MainFrameScrollbarGtk::attachAdjustment):
              (MainFrameScrollbarGtk::gtkValueChanged):
              * platform/gtk/ScrollViewGtk.cpp:
              (WebCore::ScrollView::platformInit):
              (WebCore::ScrollView::platformAddChild):
              (WebCore::ScrollView::platformRemoveChild):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29c909d5
  3. 16 Jan, 2011 5 commits
    • mrobinson@webkit.org's avatar
      2011-01-16 Martin Robinson <mrobinson@igalia.com> · 9229f615
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              * platform/gtk/Skipped: Unskip this test, as it's now passing.
      2011-01-16  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
              https://bugs.webkit.org/show_bug.cgi?id=49177
      
              * platform/ScrollView.cpp: Move the platform guards around a little. GTK+
              now shares the implementation of platformAddChild and platformRemoveChild,
              but has its own implementation of removeChild, which knows how to inform
              main frame scrollbars that they no longer control the WebCore scrollbar.
              * platform/gtk/MainFrameScrollbarGtk.cpp:
              (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
              that we already have, bail out early. Apply the value changed signal handler
              after configuring the adjustment. We don't want our reset of the adjustment to
              stomp on WebCore values.
              (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
              state already matches ours. This prevents some unnecessary recursion
              * platform/gtk/ScrollViewGtk.cpp:
              (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
              which need their adjustments detached.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9229f615
    • oliver@apple.com's avatar
      2011-01-16 Oliver Hunt <oliver@apple.com> · 3e7b1a63
      oliver@apple.com authored
              Reviewed by Sam Weinig.
      
              [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
              https://bugs.webkit.org/show_bug.cgi?id=52516
      
              Add test for the case where a syntax error immediately follows
              multiple declarations in a for-loop initialiser.
      
              * fast/js/parser-syntax-check-expected.txt:
              * fast/js/script-tests/parser-syntax-check.js:
      2011-01-16  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Sam Weinig.
      
              [jsfunfuzz] Parser doesn't correctly validate for-loop syntax
              https://bugs.webkit.org/show_bug.cgi?id=52516
      
              Ensure that we always check for a semicolon after encountering
              multiple declarations in the initialiser portion of a for-loop.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::parseForStatement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7b1a63
    • oliver@apple.com's avatar
      2011-01-16 Oliver Hunt <oliver@apple.com> · fc1b3f8f
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Strict mode restrictions on arguments and eval usage aren't complete
              https://bugs.webkit.org/show_bug.cgi?id=52528
      
              Add a helper function to aid parse failure tests by testing both direct
              eval/global code, and nested code (so that we test the syntax checker
              mode as well)
      
              * fast/js/basic-strict-mode-expected.txt:
              * fast/js/script-tests/basic-strict-mode.js:
              (shouldBeSyntaxError):
      2011-01-16  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Strict mode restrictions on arguments and eval usage aren't complete
              https://bugs.webkit.org/show_bug.cgi?id=52528
      
              Fix a few bugs in strict mode where we incorrect allow mutation of
              arguments and eval in the parser.
      
              Alas the "optimisation" used by the syntax checker for validating
              binary and unary expressions was too aggressive: we do actually need
              a stack for operations and operands although it needn't be as complete
              as that used for the full AST builder.
      
              Also disallow assignment to arguments in all cases as allowing arguments
              to be assignable is always an error in strict mode, regardless of context.
      
              * parser/ASTBuilder.h:
              (JSC::ASTBuilder::BinaryExprContext::BinaryExprContext):
              (JSC::ASTBuilder::UnaryExprContext::UnaryExprContext):
              * parser/JSParser.cpp:
              (JSC::JSParser::parseAssignmentExpression):
              (JSC::JSParser::parseBinaryExpression):
              (JSC::JSParser::parseUnaryExpression):
              * parser/SyntaxChecker.h:
              (JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext):
              (JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext):
              (JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext):
              (JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext):
              (JSC::SyntaxChecker::appendBinaryExpressionInfo):
              (JSC::SyntaxChecker::operatorStackPop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc1b3f8f
    • robert@webkit.org's avatar
      2011-01-16 Robert Hogan <robert@webkit.org> · b8633a7b
      robert@webkit.org authored
              Unreviewed, re-skip test after r75894.
      
              [Qt] plugins/keyboard-events.html fails after r72717
      
              Re-skip plugins/keyboard-events.html.
              Using XKeysymToKeycode(QX11Info::display(), ..) doesn't work on
              a headless build, such as the buildbot. So need to solve this a
              different way.
      
              https://bugs.webkit.org/show_bug.cgi?id=50050
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8633a7b
    • robert@webkit.org's avatar
      2011-01-16 Robert Hogan <robert@webkit.org> · 4f6f8d5d
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] plugins/keyboard-events.html fails after r72717
              https://bugs.webkit.org/show_bug.cgi?id=50050
      
              * platform/qt/Skipped: Unskip plugins/keyboard-events.html
      2011-01-16  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] plugins/keyboard-events.html fails after r72717
              https://bugs.webkit.org/show_bug.cgi?id=50050
      
              * plugins/qt/PluginViewQt.cpp:
              (WebCore::setXKeyEventSpecificFields): map event text to keycode
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f6f8d5d
  4. 15 Jan, 2011 6 commits