1. 16 Jul, 2007 27 commits
    • kmccullo's avatar
      Reviewed by Darin. · 29a46fe2
      kmccullo authored
              - Continued x-platform modifications.
      
              * Drosera/win/DebuggerDocumentWin.cpp: Copied from Drosera/win/DebuggerObjectCallbacks.cpp.
              * Drosera/win/DebuggerDocumentWin.h: Copied from Drosera/win/DebuggerObjectCallbacks.h.
              * Drosera/win/DebuggerObjectCallbacks.cpp: Removed.
              * Drosera/win/DebuggerObjectCallbacks.h: Removed.
              * Drosera/win/Drosera.cpp:
              * Drosera/win/Drosera.vcproj/Drosera.vcproj:
              * Drosera/win/stdafx.cpp: Removed.
              * Drosera/win/stdafx.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29a46fe2
    • weinig's avatar
      Reviewed by Geoff Garen. · 9f1fa40e
      weinig authored
              Rename cross-frame-access.html to cross-frame-access-get.html
      
              * http/tests/security/cross-frame-access-expected.txt: Removed.
              * http/tests/security/cross-frame-access-get-expected.txt: Copied from http/tests/security/cross-frame-access-expected.txt.
              * http/tests/security/cross-frame-access-get.html: Copied from http/tests/security/cross-frame-access.html.
              * http/tests/security/cross-frame-access.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f1fa40e
    • weinig's avatar
      Reviewed by Geoff Garen. · 1eb1040b
      weinig authored
              Move cross frame access put tests into cross-frame-access-put.html.
      
              * http/tests/security/cross-frame-access-custom-expected.txt:
              * http/tests/security/cross-frame-access-custom.html:
              * http/tests/security/cross-frame-access-expected.txt:
              * http/tests/security/cross-frame-access-first-time-expected.txt:
              * http/tests/security/cross-frame-access-first-time.html:
              * http/tests/security/cross-frame-access-frames.html:
              * http/tests/security/cross-frame-access-history.html:
              * http/tests/security/cross-frame-access-location-expected.txt:
              * http/tests/security/cross-frame-access-location.html:
              * http/tests/security/cross-frame-access-name-getter-expected.txt:
              * http/tests/security/cross-frame-access-name-getter.html:
              * http/tests/security/cross-frame-access-put-expected.txt:
              * http/tests/security/cross-frame-access-put.html:
              * http/tests/security/cross-frame-access.html:
              * http/tests/security/resources/cross-frame-iframe-for-get-test.html: Copied from http/tests/security/resources/cross-frame-iframe.html.
              * http/tests/security/resources/cross-frame-iframe-for-put-test.html:
              * http/tests/security/resources/cross-frame-iframe.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1eb1040b
    • justing's avatar
      Correctly check for input fields and text areas. · 5241962b
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5241962b
    • adele's avatar
      Updated results for Tiger and filed: · 50dc2166
      adele authored
              <rdar://problem/5338680> fast/forms/hidden-listbox and fast/forms/hidden-input-file are missing empty RenderText on Leopard
      
              * fast/forms/hidden-input-file-expected.txt:
              * fast/forms/hidden-listbox-expected.txt:
              * mac/leopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50dc2166
    • justing's avatar
      LayoutTests: · e5eed761
      justing authored
              Reviewed by Adele.
              
              <rdar://problem/5240265> REGRESSION: Clicking a <button> clears the selection in contenteditable areas
      
              * editing/selection/5240265-expected.checksum: Added.
              * editing/selection/5240265-expected.png: Added.
              * editing/selection/5240265-expected.txt: Added.
              * editing/selection/5240265.html: Added.
      
      WebCore:
      
              Reviewed by Adele.
      
              <rdar://problem/5240265> 
              REGRESSION: Clicking a <button> clears the selection in contenteditable areas
      
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded): Don't clear the selection if
              the mouse press that caused the focus shift occurred in 
              a -webkit-user-select: ignore region.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5eed761
    • pewtermoose's avatar
      2007-07-16 Charles Gaudette <charles@gaudette-net.com> · f2d70b14
      pewtermoose authored
              Reviewed by Niko.
      
              - http://bugs.webkit.org/show_bug.cgi?id=14628
                broken link on webkit.org home page - "KHTML" points to http://khtml.info/
      
              * index.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2d70b14
    • hyatt's avatar
      Added a manual test to test calling window.print on a subframe. · 2edc0f4a
      hyatt authored
              Reviewed by Darin.
      
              * manual-tests/resources/print-subframe.html: Added.
              * manual-tests/window-print-subframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2edc0f4a
    • aroben's avatar
      WebKit/win part of <rdar://problem/5336005> Calling window.print() on a... · 74ba3d97
      aroben authored
      WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
      
      WebKit/win:
      
              WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
      
              Reviewed by Darin.
      
              * Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer
              match the Mac method, and copy more of the Mac API comments.
              * WebChromeClient.cpp:
              (WebChromeClient::print): Call printFrame instead of print.
      
      WebCore:
      
              Added a manual test to test calling window.print on a subframe.
      
              Reviewed by Darin.
      
              * manual-tests/resources/print-subframe.html: Added.
              * manual-tests/window-print-subframe.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74ba3d97
    • aroben's avatar
      Replace Frame::print with Chrome::print and remove -[WebFrameBridge print] · a64dcca8
      aroben authored
      WebCore:
      
              Replace Frame::print with Chrome::print
      
              This also adds a Frame* parameter to Chrome::print and
              ChromeClient::print so that it knows which Frame to print.
      
              Reviewed by Darin.
      
              All tests pass.
      
              * bindings/js/kjs_window.cpp:
              (KJS::WindowFunc::callAsFunction): Call Chrome::print.
              * editing/JSEditor.cpp: Ditto.
      
              * bridge/win/FrameWin.cpp: Removed Frame::print.
              * page/Frame.h: Ditto.
              * page/mac/FrameMac.mm: Ditto.
              * page/qt/FrameQt.cpp: Ditto.
              * platform/gdk/FrameGdk.cpp: Ditto.
              * page/mac/WebCoreFrameBridge.h: Removed -print.
      
              * page/Chrome.cpp: Added Frame* parameter to Chrome::print and pass it
              up to the ChromeClient.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h: Ditto.
              * platform/gdk/TemporaryLinkStubs.cpp: Ditto.
              * platform/graphics/svg/SVGImageEmptyClients.h: Ditto.
      
      WebKit:
      
              Move printing from WebFrameBridge to WebChromeClient
      
              Reviewed by Darin.
      
              * WebCoreSupport/WebChromeClient.h: Updated for ChromeClient changes.
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::print): Moved code from WebFrameBridge.
              * WebCoreSupport/WebFrameBridge.mm: Removed -print.
      
      WebKit/win:
      
              Updated WebChromeClient for ChromeClient changes.
      
              Reviewed by Darin.
      
              * WebChromeClient.cpp:
              (WebChromeClient::print): Added a Frame* parameter.
              * WebChromeClient.h: Ditto.
      
      WebKitQt:
      
              Updated ChromeClientQt for ChromeClient changes.
      
              Reviewed by Darin.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::print): Added a Frame* parameter.
              * WebCoreSupport/ChromeClientQt.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a64dcca8
    • kmccullo's avatar
      Reviewed by Sam. · c8d72539
      kmccullo authored
              - Modified files to use cross-platform code.
      
              * Drosera/DebuggerDocument.cpp: Added.
              (DebuggerDocument::breakpointEditorHTML):
              (DebuggerDocument::isPaused):
              (DebuggerDocument::pause):
              (DebuggerDocument::resume):
              (DebuggerDocument::stepInto):
              (DebuggerDocument::evaluateScript):
              (DebuggerDocument::currentFunctionStack):
              (DebuggerDocument::localScopeVariableNamesForCallFrame):
              (DebuggerDocument::valueForScopeVariableNamed):
              * Drosera/DebuggerDocument.h: Added.
              (DebuggerDocument::DebuggerDocument):
              * Drosera/config.h: Added.
              * Drosera/mac/DebuggerApplication.mm:
              (-[DebuggerApplication attach:]):
              * Drosera/mac/DebuggerDocument.h: Removed.
              * Drosera/mac/DebuggerDocument.mm: Removed.
              * Drosera/mac/DebuggerDocumentMac.h: Copied from Drosera/mac/DebuggerDocument.h.
              * Drosera/mac/DebuggerDocumentMac.mm: Copied from Drosera/mac/DebuggerDocument.mm.
              (-[DebuggerDocumentMac initWithServerName:]):
              (-[DebuggerDocumentMac dealloc]):
              (-[DebuggerDocumentMac breakpointEditorHTML]):
              (-[DebuggerDocumentMac isPaused]):
              (-[DebuggerDocumentMac pause]):
              (-[DebuggerDocumentMac resume]):
              * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
              * Drosera/win/DebuggerApplication.cpp:
              * Drosera/win/DebuggerObjectCallbacks.cpp:
              (breakpointEditorHTMLCallback):
              (currentFunctionStackCallback):
              (evaluateScript_inCallFrame_Callback):
              (isPausedCallback):
              (localScopeVariableNamesForCallFrame_Callback):
              (pauseCallback):
              (resumeCallback):
              (stepIntoCallback):
              (valueForScopeVariableNamed_inCallFrame_Callback):
              (staticFunctions):
              * Drosera/win/Drosera.cpp:
              * Drosera/win/DroseraPrefix.cpp: Added.
              * Drosera/win/DroseraPrefix.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8d72539
    • darin's avatar
      * StringsNotToBeLocalized.txt: Update for recent changes. · 1a5ced2a
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a5ced2a
    • adele's avatar
      LayoutTests: · 56151df4
      adele authored
              Reviewed by Brady.
      
              Test for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element
              http://bugs.webkit.org/show_bug.cgi?id=14565
      
              * fast/forms/hidden-input-file-expected.checksum: Added.
              * fast/forms/hidden-input-file-expected.png: Added.
              * fast/forms/hidden-input-file-expected.txt: Added.
              * fast/forms/hidden-input-file.html: Added.
              * fast/forms/hidden-listbox-expected.checksum
              * fast/forms/hidden-listbox-expected.png
              * fast/forms/hidden-listbox-expected.txt
              * fast/forms/hidden-listbox.html
      
      WebCore:
      
              Reviewed by Brady.
      
              Fix for <rdar://problem/5321490> REGRESSION: visibility:hidden property doesn't hide parts of file input element and listbox
              http://bugs.webkit.org/show_bug.cgi?id=14565
      
              Tests:
              fast/forms/hidden-input-file.html
              fast/forms/hidden-listbox.html
      
              * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
              Only paint if the control is supposed to be visible.
              * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
              ditto.  We already had checks to prevent drawing the text that considered the option's style too, but if visibility: hidden
              was just set on the listbox then a lot of extra work was being done, and the scrollbar was drawing too.  This change fixes that.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56151df4
    • oliver's avatar
      Reviewed by Steve. · 6fa94eca
      oliver authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=14630
      
              Remove bogus assertion
      
              * WebView.cpp:
              (WebView::getIMMContext):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fa94eca
    • weinig's avatar
      Reviewed by Darin. · 65854320
      weinig authored
              Add all the window's functions to cross-frame-access-put.html test.
      
              * http/tests/security/cross-frame-access-put-expected.txt:
              * http/tests/security/cross-frame-access-put.html:
              * http/tests/security/resources/cross-frame-iframe-for-put-test.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65854320
    • hyatt's avatar
      Fix for Radar 5338081, text-shadow should be reset on form controls so that · 7d19430f
      hyatt authored
              it doesn't inherit in when set e.g., on the <body>.
      
              Reviewed by beth
      
              * css/html4.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d19430f
    • treat's avatar
      skip these crashing tests · ea85dbf4
      treat authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea85dbf4
    • zecke's avatar
      2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org> · 968d35e5
      zecke authored
              Reviewed by Niko.
      
              FrameView, PlatformScrollbar and changes to the way we draw
      
              Fix the lifetime of PlatformScrollbar, use a default width and
              height and fix drawing of the PlatformScrollbar and other widgets
              the following way: FrameGdk handles the expose events of the Frame
              and will make the frame redraw and now it will draw the childrent of
              the FrameView as well. This approach has the issue of honoring the
              z-order of elements inside the RenderTree. Honoring the z-order will
              be a bit more work
      
              Widget can now handle Widget::setGtkWidget call where the GtkWidget
              has not yet a GdkWindow allocated. We will lazily set the GdkDrawable.
      
              In preparation of honoring the z-order of the RenderTree for RenderWidgets
              it is started to store native objects inside the GraphicsContext. Doing this
              nicely eliminates the need of RenderThemeGdk to do any drawing to a temporary
              GdkPixmap. This should fix themes with rounded buttons.
      
              ScrollView implement add- and removeChild to get a working PlatformScrollbar
      
      
              * platform/Widget.h:
              * platform/gdk/FrameGdk.cpp:
              (frame_gdk_expose_child): Will send the expose to all children
              (WebCore::FrameGdk::handleGdkEvent): Painting changes, move to mouseMoved
              * platform/gdk/PlatformScreenGdk.cpp:
              (WebCore::screenDepth): gdkDrawable
              * platform/gdk/PlatformScrollBarGdk.cpp:
              (PlatformScrollbar::PlatformScrollbar): Fix ownership
              (PlatformScrollbar::~PlatformScrollbar): Fix ownership
              (PlatformScrollbar::paint): Widget::paint will do the right thing soon
              * platform/gdk/RenderThemeGdk.cpp: No need for using a GdkPixmap, draw directly
              (WebCore::RenderThemeGdk::paintCheckbox): No need for using a GdkPixmap, draw directly
              (WebCore::RenderThemeGdk::paintRadio): No need for using a GdkPixmap, draw directly
              (WebCore::RenderThemeGdk::paintButton): No need for using a GdkPixmap, draw directly
              * platform/gdk/RenderThemeGdk.h: remove the copyContext call
              * platform/gdk/ScrollViewGdk.cpp: gdkDrawable
              (WebCore::ScrollView::updateView): gdkDrawable
              (WebCore::ScrollView::update): clear the area to fix repainting issues
              (WebCore::ScrollView::setGtkWidget): gdkDrawable
              (WebCore::ScrollView::addChild): implement
              (WebCore::ScrollView::removeChild): implement
              * platform/gdk/TemporaryLinkStubs.cpp: Not needed header removed
              * platform/gdk/WidgetGdk.cpp:
              (WebCore::Widget::gdkDrawable): Renamed from drawable
              (WebCore::Widget::setGtkWidget): use gdkDrawable
              (WebCore::Widget::setCursor): gdkDrawable
              (WebCore::Widget::show): gdkDrawable
              (WebCore::Widget::hide): gdkDrawable
              * platform/graphics/GraphicsContext.h: Allow to set the GdkDrawable, e.g. used inside a expose event
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
              (WebCore::GraphicsContext::setGdkDrawable):
              (WebCore::GraphicsContext::gdkDrawable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      968d35e5
    • zecke's avatar
      2007-07-16 Holger Hans Peter Freyther <zecke@selfish.org> · 7b63736c
      zecke authored
              Reviewed by Maciej.
      
              Lazily update the scrollbars (e.g. on loading a page) to
              generate less expose events, which will lead to laying out less often
              and will fix http://bugs.webkit.org/show_bug.cgi?id=14020.
      
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
              (WebCore::ScrollView::update):
              (WebCore::ScrollView::resizeContents):
              (WebCore::ScrollView::updateScrollbars):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b63736c
    • kmccullo's avatar
      Reviewed by Adam, Sam and Tim. · db772108
      kmccullo authored
              - Moving files to prepare for cross-platform architecture.
      
              * Drosera/DebuggerApplication.h: Removed.
              * Drosera/DebuggerApplication.m: Removed.
              * Drosera/DebuggerDocument.h: Removed.
              * Drosera/DebuggerDocument.m: Removed.
              * Drosera/Drosera.pch: Removed.
              * Drosera/Drosera.xcodeproj: Removed.
              * Drosera/Drosera.xcodeproj/project.pbxproj: Removed.
              * Drosera/Info.plist: Removed.
              * Drosera/LauncherInfo.plist: Removed.
              * Drosera/Makefile: Removed.
              * Drosera/launcher.m: Removed.
              * Drosera/mac: Added.
              * Drosera/mac/DebuggerApplication.h: Copied from Drosera/DebuggerApplication.h.
              * Drosera/mac/DebuggerApplication.mm: Copied from Drosera/DebuggerApplication.m.
              * Drosera/mac/DebuggerDocument.h: Copied from Drosera/DebuggerDocument.h.
              * Drosera/mac/DebuggerDocument.mm: Copied from Drosera/DebuggerDocument.m.
              * Drosera/mac/Drosera.pch: Copied from Drosera/Drosera.pch.
              * Drosera/mac/Drosera.xcodeproj: Copied from Drosera/Drosera.xcodeproj.
              * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
              * Drosera/mac/Info.plist: Copied from Drosera/Info.plist.
              * Drosera/mac/LauncherInfo.plist: Copied from Drosera/LauncherInfo.plist.
              * Drosera/mac/Makefile: Copied from Drosera/Makefile.
              * Drosera/mac/launcher.m: Copied from Drosera/launcher.m.
              * Drosera/mac/main.m: Copied from Drosera/main.m.
              * Drosera/main.m: Removed.
              * Makefile:
              * Makefile.Drosera: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db772108
    • sullivan's avatar
      Reviewed by Kevin Decker and Darin Adler · f3674ad3
      sullivan authored
              
              - fixed <rdar://problem/5337529> Holes in Find banner overlay on PDF pages are left in wrong place after changing scale
      
              * WebView/WebPDFView.mm:
              (-[WebPDFView _scaleOrDisplayModeChanged:]):
              tell UI delegate that the entire PDF view has been redrawn
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3674ad3
    • weinig's avatar
      Reviewed by Kevin McCullough. · 523b5fc2
      weinig authored
              Breakup http/tests/security/cross-frame-access.html into multiple tests to
              make it easier to identify flaws should they arise.
      
              - Also factors out JS into a separate file.
      
              * http/tests/security/cross-frame-access-custom-expected.txt: Added.
              * http/tests/security/cross-frame-access-custom.html: Added.
              * http/tests/security/cross-frame-access-expected.txt:
              * http/tests/security/cross-frame-access-frames-expected.txt: Added.
              * http/tests/security/cross-frame-access-frames.html: Added.
              * http/tests/security/cross-frame-access-history-expected.txt: Added.
              * http/tests/security/cross-frame-access-history.html: Added.
              * http/tests/security/cross-frame-access-location-expected.txt: Added.
              * http/tests/security/cross-frame-access-location.html: Added.
              * http/tests/security/cross-frame-access-name-getter-expected.txt: Added.
              * http/tests/security/cross-frame-access-name-getter.html: Added.
              * http/tests/security/cross-frame-access.html:
              * http/tests/security/resources/cross-frame-access.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      523b5fc2
    • andersca's avatar
      Forgot Skipped file · 2726cbcb
      andersca authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2726cbcb
    • andersca's avatar
      Remove basic-auth.html, it no longer hangs on Leopard. · 98c416c9
      andersca authored
              
              * mac/leopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98c416c9
    • bdash's avatar
      2007-07-16 Mark Rowe <mrowe@apple.com> · 69117bd5
      bdash authored
              Update expected result after r24302.
      
              * fast/css/empty-script-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69117bd5
    • bdash's avatar
      2007-07-16 Rob Buis <buis@kde.org> · e0f7f140
      bdash authored
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=14462
              non empty <style> element doesn't work
      
              Return an empty sheet for empty <style> elements
              instead of a null sheet. Clean up StyleElement a bit.
      
              * dom/StyleElement.cpp:
              (WebCore::StyleElement::StyleElement):
              (WebCore::StyleElement::sheet):
              (WebCore::StyleElement::childrenChanged):
              (WebCore::StyleElement::createSheet):
              * dom/StyleElement.h:
              (WebCore::StyleElement::setLoading):
              * html/HTMLStyleElement.cpp:
              (WebCore::HTMLStyleElement::HTMLStyleElement):
              (WebCore::HTMLStyleElement::sheet):
              * html/HTMLStyleElement.h:
              (WebCore::HTMLStyleElement::setLoading):
              * ksvg2/svg/SVGStyleElement.cpp:
              (WebCore::SVGStyleElement::sheet):
              (WebCore::SVGStyleElement::sheetLoaded):
              * ksvg2/svg/SVGStyleElement.h:
      
      2007-07-16  Rob Buis  <buis@kde.org>
      
              Reviewed by Maciej.
      
              Testcase for:
              http://bugs.webkit.org/show_bug.cgi?id=14462
              non empty <style> element doesn't work
      
              * fast/css/empty-script-expected.txt: Added.
              * fast/css/empty-script.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0f7f140
    • oliver's avatar
      LayoutTests: · e57dfa21
      oliver authored
              Reviewed by Adam.
      
              Update for changed behaviour now that we allow tab characters in input fields again
      
              * editing/inserting/typing-tab-designmode-forms-expected.checksum:
              * editing/inserting/typing-tab-designmode-forms-expected.png:
              * editing/inserting/typing-tab-designmode-forms-expected.txt:
      
      WebCore:
      
              Reviewed by Adam.
      
              Fix for fix for <rdar://problem/5336602> REGRESSION: tab characters
                              cannot be entered into text fields
                              http://bugs.webkit.org/show_bug.cgi?id=14032
      
              Need to use UChar not char.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::constrainValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e57dfa21
  2. 15 Jul, 2007 3 commits
    • weinig's avatar
      LayoutTests: · 2ef765ec
      weinig authored
              Reviewed by Geoff Garen.
      
              Update results after removing redundant calls to isSafeScript()
      
              * http/tests/security/cross-frame-access-expected.txt:
      
      WebCore:
      
              Reviewed by Geoff Garen.
      
              Remove redundant calls to isSafeScript()
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::customPut):
              * bindings/js/kjs_window.cpp:
              (KJS::Window::put):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ef765ec
    • ggaren's avatar
      Reviewed by Maciej Stachowiak. · 2d4a5550
      ggaren authored
              
              Removed incorrect error log, seen while running layout tests.
              
              Perhaps at some point FrameLoadTypeInteral had a specific meaning
              that prevented it from being used in non-child frame, non-redirect
              situations. However, that meaning has been lost and nobody remembers
              how to get it back.
              
              We currently use FrameLoadTypeInternal for any load that is not
              initiated by a user gesture, so it's trivial to produce this error
              log, even though nothing has gone wrong.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::updateHistoryForInternalLoad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d4a5550
    • oliver's avatar
      LayoutTests: · e5dd7112
      oliver authored
              Reviewed by Maciej.
      
              Testcase for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields
                           http://bugs.webkit.org/show_bug.cgi?id=14032
      
              * fast/forms/tab-in-input-expected.txt: Added.
              * fast/forms/tab-in-input.html: Added.
      
      WebCore:
      
              Reviewed by Maciej
      
              Fix for <rdar://problem/5336602> REGRESSION: tab characters cannot be entered into text fields
                      http://bugs.webkit.org/show_bug.cgi?id=14032
      
              constrainValue attempted to block control characters from being inserted 
              by a simple less than ' ' check, which prevent tab characters from being
              inserted.  This patch adds an additional check to allow the tab character 
              again
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::constrainValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5dd7112
  3. 14 Jul, 2007 10 commits
    • beidson's avatar
      Third shot at blind Qt/GDK build fix · 1a759f64
      beidson authored
              * platform/gdk/TemporaryLinkStubs.cpp:
              (FTPDirectoryDocument::createTokenizer):
              * platform/qt/TemporaryLinkStubs.cpp:
              (FTPDirectoryDocument::createTokenizer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a759f64
    • beidson's avatar
      RUBBERSTAMPED BY SAM WEINIG - Try to (actually) fix Qt and GDK · a122e7ca
      beidson authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a122e7ca
    • beidson's avatar
    • weinig's avatar
      Fix Tiger build. · 951fc8d1
      weinig authored
              * config.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      951fc8d1
    • beidson's avatar
      Blind attempt at (hopefully) fixing the Qt and GDK builds · 95f0bf85
      beidson authored
              * platform/gdk/TemporaryLinkStubs.cpp:
              (FTPDirectoryDocument::FTPDirectoryDocument):
              * platform/qt/TemporaryLinkStubs.cpp:
              (FTPDirectoryDocument::FTPDirectoryDocument):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95f0bf85
    • beidson's avatar
      JavaScriptCore: · 7a243283
      beidson authored
              Reviewed by Sam Weinig
      
              Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
      
              * wtf/Platform.h: Add ENABLE_FTPDIR feature to handle building on platforms that don't have the
                proper network-layer support
      
      WebCore:
      
              Reviewed by Sam Weinig
      
              Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
      
              Development has taken place on both Leopard and Windows (windows enabling patch will follow shortly)
              Support will only exist on platforms whose network layers (ie, ResourceHandle) support piping the raw
              FTP Directory data into the engine.  
      
              This is known to include Leopard, Windows, and CURL based platforms - probably others
              Known incompatible platforms include Tiger.
      
              The FTP listing page is built in HTML.  An external HTML document can be provided as a template for the 
              directory listing.  This document is parsed, and expected to have a <table> with a certain class in it.
              As FTP directory listings come in, each entry is added to this table as a row.
      
              If no HTML template is provided to work with, a very basic empty document is hard coded that contains only 
              this special table.
      
              Upgrades to the look and feel of the directory listings can take place largely in this HTML template which,
              admittedly, is conspicuously absent in this initial checkin
      
              * WebCore.exp: New Settings symbols for WebKit
              * WebCore.xcodeproj/project.pbxproj:
      
              * config.h: If BUILDING_ON_TIGER, disable FTP directory listing support
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument): Create an FTPDirectoryDocument if the mime type is 
                "application/x-ftp-directory"
      
              * loader/FTPDirectoryDocument.cpp: Added.
              (WebCore::FTPDirectoryTokenizer::isWaitingForScripts):
              (WebCore::FTPDirectoryTokenizer::checkBuffer):
              (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer): Building on HTML tokenizer, this facilitates 
                parsing FTP Directory listings in the engine
              (WebCore::FTPDirectoryTokenizer::appendEntry): Add a table row for a directory listing to the document
              (WebCore::FTPDirectoryTokenizer::createTDForFilename): Create the TD for the filename with the anchor in it
      
              (WebCore::processFilesizeString): Prettify the filesize
              (WebCore::wasLastDayOfMonth):
              (WebCore::processFileDateString): Prettify the date
              (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine):
              (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): Loads the HTML template that FTP directory listings
                can build on top of
              (WebCore::FTPDirectoryTokenizer::createBasicDocument): Creates a most basic document (body and one table) to
                append the rows to in case the document template is not loaded and parsed
              (WebCore::FTPDirectoryTokenizer::write): Add the FTP listing to the buffer and parse entries out of it
              (WebCore::FTPDirectoryTokenizer::finish): 
      
              (WebCore::FTPDirectoryDocument::FTPDirectoryDocument): Special document-type for FTP directory listings
              (WebCore::FTPDirectoryDocument::createTokenizer):
              * loader/FTPDirectoryDocument.h: Added.
              (WebCore::FTPDirectoryDocument::isImageDocument):
              
              * loader/FTPDirectoryParser.cpp: Added.
              (WebCore::parseOneFTPLine): Adapted from ParseFTPList.cpp from Firefox - parses most known
                FTP directory listing styles into discrete FTP directory entries
              * loader/FTPDirectoryParser.h: Added.
              (WebCore::ListState::ListState): Maintains FTP Parser state
              (WebCore::ListResult::ListResult): Represents one FTP directory listing
              (WebCore::ListResult::clear):
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkContentPolicy): If the Settings say to bypass the policy check for 
                "application/x-ftp-directory", skip it.  This will allow people to test this feature even if their 
                browser/WebKit app would otherwise not allow it
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setFTPDirectoryTemplatePath): Set the path to the FTP listing document template
              (WebCore::Settings::setForceFTPDirectoryListings): Set to bypass the policy delegate check for mime type
                "application/x-ftp-directory"
              * page/Settings.h:
              (WebCore::Settings::ftpDirectoryTemplatePath):
              (WebCore::Settings::forceFTPDirectoryListings):
      
              * platform/Logging.cpp: Add an "LogFTP" logging channel
              * platform/Logging.h:
              * platform/mac/LoggingMac.mm:
              (WebCore::InitializeLoggingChannelsIfNecessary):
      
              * platform/MimeTypeRegistry.cpp:
              (WebCore::initialiseSupportedNonImageMimeTypes): Add "application/x-ftp-directory"
      
              * platform/SharedBuffer.cpp:
              (WebCore::SharedBuffer::createWithContentsOfFile): Stub for now
              * platform/SharedBuffer.h:
      
              * platform/mac/SharedBufferMac.mm:
              (WebCore::SharedBuffer::createWithContentsOfFile): Load contents of the file into an NSData, then
                wrap that NSData
      
      WebKit:
      
              Reviewed by Sam Weinig
      
              Initial check-in for <rdar://problem/3154486> - Supporting FTP directory listings in the browser
      
              * WebView/WebPreferenceKeysPrivate.h: Added preference keys for the FTP template location, as well as to force 
                FTP directory listings, bypassing the policy delegate.  This is necessary to test the new feature until browser
                policy delegate support is added.
      
              * WebView/WebPreferences.m:
              (-[WebPreferences _setFTPDirectoryTemplatePath:]):
              (-[WebPreferences _ftpDirectoryTemplatePath]):
              (-[WebPreferences _setForceFTPDirectoryListings:]):
              (-[WebPreferences _forceFTPDirectoryListings]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a243283
    • ap's avatar
      Reviewed by Darin. · a46b387b
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=14618
              REGRESSION(13464): drivehq.com login form doesn't work
      
              Test: http/tests/misc/post-submit-button.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::appendFormData): Append a submit even if its value is empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a46b387b
    • bdash's avatar
      2007-07-14 Cameron Zwarich <cwzwarich@uwaterloo.ca> · b122302c
      bdash authored
              Reviewed by Darin.
      
              Fixes http://bugs.webkit.org/show_bug.cgi?id=13517,
                    http://bugs.webkit.org/show_bug.cgi?id=14237, and
                    the failure of test js1_5/Scope/regress-185485.js
      
              Bug 13517: DOM Exception 8 in finance.aol.com sub-page
              Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope
      
              * kjs/nodes.cpp:
              (VarDeclNode::evaluate):
              * tests/mozilla/expected.html:
      
      2007-07-14  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
      
              Reviewed by Darin.
      
              Added tests for the following bugs:
              http://bugs.webkit.org/show_bug.cgi?id=13517
              http://bugs.webkit.org/show_bug.cgi?id=14237
      
              Bug 13517: DOM Exception 8 in finance.aol.com sub-page
              Bug 14237: Javascript "var" statement interprets initialization in the topmost function scope
      
              * fast/js/resources/vardecl-blocks-init.js: Added.
              * fast/js/resources/vardecl-preserve-arguments.js: Updated.
              * fast/js/vardecl-blocks-init-expected.txt: Added.
              * fast/js/vardecl-blocks-init.html: Added.
              * fast/js/vardecl-preserve-arguments-expected.txt: Updated result.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b122302c
    • bdash's avatar
      2007-07-15 Mark Rowe <mrowe@apple.com> · 6644c3c0
      bdash authored
              * Scripts/generate-coverage-data: Don't fail if WebKitBuild directory does not exist.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6644c3c0
    • oliver's avatar
      Reviewed by Darin and Alexey. · c8fd443a
      oliver authored
              Fix for <rdar://problem/5231528> Inline input of International text (IME)
                      http://bugs.webkit.org/show_bug.cgi?id=14331
      
              This patch adds IME support to WebKit/win, it currently does not support
              reconversion (<rdar://problem/5334818>) and has issues with the chinese
              IMEs (<rdar://problem/5334826>)
      
              * WebEditorClient.cpp:
              (WebEditorClient::respondToChangedSelection):
              (WebEditorClient::handleInputMethodKeypress):
                Prevent the initial keydown for an IME from triggering a keypressed event
              * WebView.cpp:
              (WebView::WebView):
              (WebView::keyUp):
              (WebView::keyDown):
              (WebViewWndProc):
              (IMMDict::dict):
              (IMMDict::IMMDict):
                 Dynamic loader for IME libraries
      
              (WebView::getIMMContext):
              (WebView::releaseIMMContext):
              (WebView::prepareCandidateWindow):
              (selectionInsideMarkedText):
              (setSelectionToEndOfRange):
              (WebView::resetIME):
              (WebView::updateSelectionForIME):
              (WebView::selectionChanged):
              (getCompositionString):
              (compositionToUnderlines):
                 Helper functions
      
              (WebView::onIMEStartComposition):
              (WebView::onIMEComposition):
              (WebView::onIMEEndComposition):
              (WebView::onIMEChar):
              (WebView::onIMENotify):
              (WebView::onIMERequest):
              (WebView::onIMESelect):
              (WebView::onIMESetContext):
                 IME event handling, so far most of these are not implemented, but the bulk of functionality 
                 is performed the the composition event handlers
              * WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8fd443a