1. 14 Jun, 2008 21 commits
    • cwzwarich@webkit.org's avatar
      2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 29477592
      cwzwarich@webkit.org authored
              Reviewed by Maciej.
      
              Make code generation not use a temporary for the left-hand side of an
              expression if the right-hand side is a local variable.
      
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::isLocal):
              * VM/CodeGenerator.h:
              (KJS::CodeGenerator::leftHandSideNeedsCopy):
              (KJS::CodeGenerator::emitNodeForLeftHandSide):
              * kjs/nodes.cpp:
              (KJS::ResolveNode::isPure):
              (KJS::BracketAccessorNode::emitCode):
              (KJS::AddNode::emitCode):
              (KJS::SubNode::emitCode):
              (KJS::ReadModifyResolveNode::emitCode):
              (KJS::AssignDotNode::emitCode):
              (KJS::ReadModifyDotNode::emitCode):
              (KJS::AssignBracketNode::emitCode):
              (KJS::ReadModifyBracketNode::emitCode):
              * kjs/nodes.h:
              (KJS::ExpressionNode::):
              (KJS::BooleanNode::):
              (KJS::NumberNode::):
              (KJS::StringNode::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29477592
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · ec650339
      darin@apple.com authored
              - more build fixing
      
              * platform/gtk/DragDataGtk.cpp: Added missing header.
              * platform/wx/DragDataWx.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec650339
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · bb28b975
      darin@apple.com authored
              - try to fix Windows build
      
              * WebActionPropertyBag.cpp:
              (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
              * WebFrame.h: Added missing FormState arguments.
              * WebScrollBar.cpp:
              (WebScrollBar::init): Use create instead of new.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb28b975
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 6c46d604
      darin@apple.com authored
              Reviewed by Sam.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=19544
                DashboardRegion pieces are leaking
      
              My recent change introduced a leak of objects owned by each DashboardRegion,
              because I made ~Rect non-virtual. By using a separate RefCounted class for
              each of Rect and DashboardRegion, the leak is gone. It's not clear if the
              DashboardRegion class should really exist -- it doesn't have a DOM binding,
              so it could conceivably be removed some day.
      
              * css/DashboardRegion.h: Derive from RectBase instead of from Rect.
              * css/Rect.h: Added RectBase. Changed Rect to derive from RectBase.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c46d604
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 3aa89278
      darin@apple.com authored
              Reviewed by Sam.
      
              - https://bugs.webkit.org/show_bug.cgi?id=19545
                use PassRefPtr, not RefPtr, for return values
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseGradient): Call release() when assigning result to avoid
              a little bit of refcount churn.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::styleRulesForElement): Changed return value to PassRefPtr.
              (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
              * css/CSSStyleSelector.h: Ditto.
      
              * svg/SVGElementInstanceList.cpp:
              (WebCore::SVGElementInstanceList::length): Tweaked formatting.
              (WebCore::SVGElementInstanceList::item): Changed return value to raw pointer.
              * svg/SVGElementInstanceList.h: Ditto.
      
              * xml/XSLTProcessor.cpp:
              (WebCore::XSLTProcessor::createDocumentFromSource): Changed return value to PassRefPtr.
              (WebCore::XSLTProcessor::transformToDocument): Ditto.
              (WebCore::XSLTProcessor::transformToFragment): Ditto.
              * xml/XSLTProcessor.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aa89278
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 0cd074ea
      darin@apple.com authored
              - try to fix the gtk build
      
              * platform/gtk/DragDataGtk.cpp:
              (WebCore::DragData::createClipboard): Changed return type to PassRefPtr.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cd074ea
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · c6c2b233
      darin@apple.com authored
              - another try at fixing the wx build
      
              * platform/wx/DragDataWx.cpp:
              (WebCore::DragData::createClipboard): Changed return type to PassRefPtr.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6c2b233
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 9ef41dfc
      darin@apple.com authored
              - try to fix Windows build
      
              * svg/graphics/SVGImageEmptyClients.h: Added missing include.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ef41dfc
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · a5581f52
      darin@apple.com authored
              - fix wx build
      
              * platform/wx/TemporaryLinkStubs.cpp: Removed unneeded Icon constructor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5581f52
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 3370f744
      darin@apple.com authored
              - fix build
      
              * Api/qwebframe.cpp:
              (QWebFramePrivate::init): Added a missing semicolon.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3370f744
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 5eff5774
      darin@apple.com authored
              - fix build
      
              * webkit/webkitwebframe.cpp: Remove a bogus release() call.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eff5774
    • darin@apple.com's avatar
      JavaScriptCore: · d5ceaf86
      darin@apple.com authored
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more of https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * kjs/nodes.cpp:
              (KJS::ParserRefCounted::hasOneRef): Added. Replaces refcount.
              * kjs/nodes.h: Replaced refcount with hasOneRef.
      
              * wtf/ListRefPtr.h:
              (WTF::ListRefPtr::~ListRefPtr): Changed to use hasOneRef instead of
              refcount, so this class can be used with the RefCounted template.
      
              * wtf/RefCounted.h:
              (WTF::RefCounted::hasOneRef): Made const, since there's no reason for
              it to be non-const.
      
      WebCore:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCore.base.exp: Added some new exports needed for functions that are now
              non-virtual.
      
              * WebCore.xcodeproj/project.pbxproj: Moved the "icon" group to the correct
              location in the project. Before it was inside "appcache"!
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Clipboard.cpp:
              (WebCore::Clipboard::Clipboard):
              * editing/mac/EditorMac.mm:
              (WebCore::Editor::newGeneralClipboard):
              * editing/qt/EditorQt.cpp:
              (WebCore::Editor::newGeneralClipboard):
              * editing/wx/EditorWx.cpp:
              (WebCore::Editor::newGeneralClipboard):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::create):
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::defaultIcon):
              (WebCore::IconDatabase::setIconDataForIconURL):
              (WebCore::IconDatabase::setIconURLForPageURL):
              (WebCore::IconDatabase::getOrCreateIconRecord):
              (WebCore::IconDatabase::performURLImport):
              * loader/icon/IconDatabase.h:
              * loader/icon/IconRecord.cpp:
              (WebCore::IconRecord::IconRecord):
              * loader/icon/IconRecord.h:
              (WebCore::IconRecord::create):
              * page/EventHandler.h:
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              * page/Frame.h:
              (WebCore::Frame::create):
              * page/gtk/EventHandlerGtk.cpp:
              (WebCore::EventHandler::createDraggingClipboard):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::createDraggingClipboard):
              * page/qt/EventHandlerQt.cpp:
              (WebCore::EventHandler::createDraggingClipboard):
              * page/win/EventHandlerWin.cpp:
              (WebCore::EventHandler::createDraggingClipboard):
              * page/wx/EventHandlerWx.cpp:
              (WebCore::EventHandler::createDraggingClipboard):
              * platform/Cursor.h:
              (WebCore::SharedCursor::create):
              (WebCore::SharedCursor::~SharedCursor):
              (WebCore::SharedCursor::SharedCursor):
              * platform/DragData.h:
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::create):
              (WebCore::PopupMenu::isActive):
              * platform/ScrollBar.cpp:
              (WebCore::Scrollbar::Scrollbar):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::create):
              * platform/graphics/FontFamily.cpp:
              (WebCore::FontFamily::FontFamily):
              (WebCore::operator==):
              * platform/graphics/FontFamily.h:
              (WebCore::FontFamily::FontFamily):
              (WebCore::SharedFontFamily::create):
              (WebCore::SharedFontFamily::SharedFontFamily):
              (WebCore::operator!=):
              (WebCore::FontFamily::next):
              (WebCore::FontFamily::appendFamily):
              (WebCore::FontFamily::releaseNext):
              * platform/graphics/Icon.h:
              * platform/graphics/gtk/IconGtk.cpp:
              (WebCore::Icon::Icon):
              (WebCore::Icon::~Icon):
              (WebCore::Icon::newIconForFile):
              * platform/graphics/mac/IconMac.mm:
              (WebCore::Icon::Icon):
              (WebCore::Icon::newIconForFile):
              * platform/graphics/qt/IconQt.cpp:
              (WebCore::Icon::Icon):
              (WebCore::Icon::newIconForFile):
              * platform/graphics/win/IconWin.cpp:
              (WebCore::Icon::Icon):
              (WebCore::Icon::~Icon):
              (WebCore::Icon::newIconForFile):
              * platform/gtk/ClipboardGtk.cpp:
              (WebCore::Editor::newGeneralClipboard):
              * platform/gtk/ClipboardGtk.h:
              (WebCore::ClipboardGtk::create):
              * platform/gtk/PlatformScrollBar.h:
              (WebCore::PlatformScrollbar::create):
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenu::PopupMenu):
              * platform/gtk/ScrollViewGtk.cpp:
              (WebCore::ScrollViewScrollbar::create):
              (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
              (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
              * platform/mac/ClipboardMac.h:
              (WebCore::ClipboardMac::create):
              * platform/mac/DragDataMac.mm:
              (WebCore::DragData::createClipboard):
              (WebCore::DragData::containsCompatibleContent):
              * platform/mac/PlatformScrollBar.h:
              (WebCore::PlatformScrollbar::create):
              (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
              (WebCore::PlatformScrollbar::verticalScrollbarWidth):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu):
              * platform/qt/ClipboardQt.h:
              (WebCore::ClipboardQt::create):
              * platform/qt/DragDataQt.cpp:
              (WebCore::DragData::createClipboard):
              * platform/qt/PlatformScrollBar.h:
              (WebCore::PlatformScrollbar::create):
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenu::PopupMenu):
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
              (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
              * platform/win/ClipboardWin.h:
              (WebCore::ClipboardWin::create):
              * platform/win/CursorWin.cpp:
              (WebCore::Cursor::Cursor):
              (WebCore::loadSharedCursor):
              * platform/win/DragDataWin.cpp:
              (WebCore::DragData::createClipboard):
              * platform/win/EditorWin.cpp:
              (WebCore::Editor::newGeneralClipboard):
              * platform/win/PlatformScrollBar.h:
              (WebCore::PlatformScrollbar::create):
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::show):
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
              (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
              * platform/wx/ClipboardWx.h:
              (WebCore::ClipboardWx::create):
              * platform/wx/PlatformScrollBar.h:
              (WebCore::PlatformScrollbar::create):
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenu::PopupMenu):
              * platform/wx/TemporaryLinkStubs.cpp:
              (Icon::Icon):
              (Icon::newIconForFile):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::createScrollbar):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::updateFromElement):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged):
              * svg/graphics/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
      
      WebKit/gtk:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::createDocumentLoader): Use create instead of new.
              * webkit/webkitwebframe.cpp:
              (webkit_web_frame_new): Ditto.
              (webkit_web_frame_init_with_web_view): Ditto.
      
      WebKit/mac:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more of https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
              (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
              a ref call inside the Frame constructor. The lifetime rules for Frame are now the
              conventional ones without a special case.
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
              this function takes ownership of the DocumentLoader.
              (-[WebDataSource initWithRequest:]): Use create instead of new.
              * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
              PassRefPtr and also cleaned up the header a bit.
      
              * WebView/WebDocumentLoaderMac.h:
              (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
              functions private.
      
              * WebView/WebFrame.mm:
              (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
              of new.
      
      WebKit/qt:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * Api/qwebframe.cpp:
              (QWebFramePrivate::init): Use create instead of new.
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::createDocumentLoader): Ditto.
      
      WebKit/win:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more of https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
              a ref call inside the Frame constructor. The lifetime rules for Frame are now the
              conventional ones without a special case.
      
              * WebFrame.cpp:
              (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused
              IWebFrameView argument (every caller was passing 0). Also changed this to return the
              WebCore Frame object, which is needed to straighten out the lifetime and ownership
              issues.
              * WebFrame.h: Ditto.
      
              * WebView.cpp:
              (WebView::initWithFrame): Changed to call new init function and use the return value.
      
      WebKit/wx:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::createDocumentLoader): Use create function
              instead of new.
      
      LayoutTests:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=19538
                <rdar://problem/5957595> Reading transition property from the style JS gives the wrong value
      
              * fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
              * fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
              * fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5ceaf86
    • weinig@apple.com's avatar
      WebCore: · fa4b1a10
      weinig@apple.com authored
      2008-06-14  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix for <rdar://problem/5775192>
              insertAdjacentHTML and insertAdjacentText are not implemented although insertAdjacentElement is.
      
              - Implements insertAdjacentHTML and insertAdjacentText for HTMLElement.
              - Moves the insertAdjacentElement implementation from Element to HTMLElement.
      
              Tests: fast/dynamic/insertAdjacentHTML.html
                     fast/dynamic/insertAdjacentText.html
      
              * dom/Element.cpp:
              * dom/Element.h:
              * dom/Element.idl:
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::insertAdjacent):
              (WebCore::HTMLElement::insertAdjacentElement):
              (WebCore::HTMLElement::insertAdjacentHTML):
              (WebCore::HTMLElement::insertAdjacentText):
              * html/HTMLElement.h:
              * html/HTMLElement.idl:
      
      LayoutTests:
      
      2008-06-14  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Tests for <rdar://problem/5775192>
              insertAdjacentHTML and insertAdjacentText are not implemented although insertAdjacentElement is.
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/domListEnumeration-expected.txt:
              * fast/dom/resources/domListEnumeration.js:
              * fast/dynamic/insertAdjacentElement.html:
              * fast/dynamic/insertAdjacentHTML-expected.txt: Added.
              * fast/dynamic/insertAdjacentHTML.html: Copied from fast/dynamic/insertAdjacentElement.html.
              * fast/dynamic/insertAdjacentText-expected.txt: Added.
              * fast/dynamic/insertAdjacentText.html: Copied from fast/dynamic/insertAdjacentElement.html.
              * platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa4b1a10
    • darin@apple.com's avatar
      WebCore: · 166f2512
      darin@apple.com authored
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=19538
                <rdar://problem/5957595> Reading transition property from the style JS gives the wrong value
      
              Test: fast/dom/CSSStyleDeclaration/transition-property-names.html
      
              * css/CSSPrimitiveValue.cpp:
              (WebCore::valueOrPropertyName): Added.
              (WebCore::CSSPrimitiveValue::getStringValue): Use valueOrPropertyName since the ident can either
              be a value or property ID.
              (WebCore::CSSPrimitiveValue::cssText): Ditto.
      
              * css/makeprop.pl: Assign property IDs starting at 1001 instead of 1 so they can be stored along
              with value IDs with no ambiguity.
      
      LayoutTests:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Maciej.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=19538
                <rdar://problem/5957595> Reading transition property from the style JS gives the wrong value
      
              * fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
              * fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
              * fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      166f2512
    • mjs@apple.com's avatar
      2008-06-14 Maciej Stachowiak <mjs@apple.com> · ff10c48f
      mjs@apple.com authored
              Reviewed by Oliver.
              
              - initialize local vars as side effect of call instead of in bytecode
              1.004x speedup on SunSpider.
      
              This removes just the dispatch overhead for these loads - in the
              future, dead store elimination might be able to eliminate them
              entirely.
              
              * VM/CodeGenerator.cpp:
              (KJS::CodeGenerator::CodeGenerator): For function blocks, don't
              emit loads of undefined for var initialization.
              * VM/Machine.cpp:
              (KJS::slideRegisterWindowForCall): Instead, initialize locals
              as part of the call.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff10c48f
    • abarth@webkit.org's avatar
      2008-06-14 Adam Barth <abarth@webkit.org> · 1b74c09a
      abarth@webkit.org authored
              Reviewed by David Kilzer.
      
              Fix typo.
      
              * dom/XMLTokenizer.cpp:
              (WebCore::shouldAllowExternalLoad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b74c09a
    • cwzwarich@webkit.org's avatar
      2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca> · ac94d2dc
      cwzwarich@webkit.org authored
              Reviewed by Oliver.
      
              Remove helper functions in the parser that are no longer needed.
      
              * kjs/grammar.y:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac94d2dc
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · bef31ab6
      darin@apple.com authored
              - fix build
      
              * plugins/PluginStream.h: Move functions back into public section.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bef31ab6
    • darin@apple.com's avatar
      2008-06-14 Darin Adler <darin@apple.com> · 1c8ef087
      darin@apple.com authored
              * Scripts/do-webcore-rename: Fixed obvious typo.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c8ef087
    • darin@apple.com's avatar
      WebCore: · 48ac3c40
      darin@apple.com authored
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCore.base.exp:
              * bindings/js/JSSVGMatrixCustom.cpp:
              (WebCore::JSSVGMatrix::multiply):
              (WebCore::JSSVGMatrix::inverse):
              (WebCore::JSSVGMatrix::translate):
              (WebCore::JSSVGMatrix::scale):
              (WebCore::JSSVGMatrix::scaleNonUniform):
              (WebCore::JSSVGMatrix::rotate):
              (WebCore::JSSVGMatrix::rotateFromVector):
              (WebCore::JSSVGMatrix::flipX):
              (WebCore::JSSVGMatrix::flipY):
              (WebCore::JSSVGMatrix::skewX):
              (WebCore::JSSVGMatrix::skewY):
              * bindings/js/JSSVGPODTypeWrapper.h:
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
              (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
              (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
              * bindings/js/JSSVGPointListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGPointList::clear):
              (WebCore::JSSVGPointList::initialize):
              (WebCore::JSSVGPointList::getItem):
              (WebCore::JSSVGPointList::insertItemBefore):
              (WebCore::JSSVGPointList::replaceItem):
              (WebCore::JSSVGPointList::removeItem):
              (WebCore::JSSVGPointList::appendItem):
              * bindings/js/JSSVGTransformListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGTransformList::clear):
              (WebCore::JSSVGTransformList::initialize):
              (WebCore::JSSVGTransformList::getItem):
              (WebCore::JSSVGTransformList::insertItemBefore):
              (WebCore::JSSVGTransformList::replaceItem):
              (WebCore::JSSVGTransformList::removeItem):
              (WebCore::JSSVGTransformList::appendItem):
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::CSSFontSelector):
              (WebCore::CSSFontSelector::~CSSFontSelector):
              * css/CSSFontSelector.h:
              (WebCore::CSSFontSelector::create):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Attribute.cpp:
              (WebCore::Attribute::clone):
              * dom/Attribute.h:
              (WebCore::Attribute::create):
              (WebCore::Attribute::Attribute):
              * dom/BeforeTextInsertedEvent.h:
              (WebCore::BeforeTextInsertedEvent::create):
              * dom/BeforeUnloadEvent.h:
              (WebCore::BeforeUnloadEvent::create):
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::dispatchModifiedEvent):
              * dom/ClipboardEvent.cpp:
              (WebCore::ClipboardEvent::ClipboardEvent):
              * dom/ClipboardEvent.h:
              (WebCore::ClipboardEvent::create):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::removeChild):
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/Document.cpp:
              (WebCore::Document::createTextNode):
              (WebCore::Document::createComment):
              (WebCore::Document::createCDATASection):
              (WebCore::Document::createProcessingInstruction):
              (WebCore::Document::createEntityReference):
              (WebCore::Document::createEditingTextNode):
              (WebCore::Document::createEvent):
              (WebCore::Document::createAttributeNS):
              (WebCore::Document::finishedParsing):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::createAttribute):
              * dom/Element.h:
              * dom/Event.cpp:
              (WebCore::Event::Event):
              * dom/Event.h:
              (WebCore::Event::create):
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
              (WebCore::EventTargetNode::dispatchWindowEvent):
              (WebCore::EventTargetNode::dispatchUIEvent):
              (WebCore::EventTargetNode::dispatchKeyEvent):
              (WebCore::EventTargetNode::dispatchMouseEvent):
              (WebCore::EventTargetNode::dispatchWheelEvent):
              (WebCore::EventTargetNode::dispatchHTMLEvent):
              (WebCore::EventTargetNode::dispatchProgressEvent):
              (WebCore::EventTargetNode::dispatchStorageEvent):
              * dom/KeyboardEvent.h:
              (WebCore::KeyboardEvent::create):
              * dom/MappedAttribute.cpp:
              (WebCore::MappedAttribute::clone):
              * dom/MappedAttribute.h:
              (WebCore::MappedAttribute::create):
              (WebCore::MappedAttribute::setDecl):
              (WebCore::MappedAttribute::MappedAttribute):
              * dom/MessageEvent.cpp:
              (WebCore::MessageEvent::MessageEvent):
              * dom/MessageEvent.h:
              (WebCore::MessageEvent::create):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              (WebCore::MouseEvent::initMouseEvent):
              * dom/MouseEvent.h:
              (WebCore::MouseEvent::create):
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              * dom/MouseRelatedEvent.h:
              * dom/MutationEvent.cpp:
              (WebCore::MutationEvent::MutationEvent):
              (WebCore::MutationEvent::initMutationEvent):
              * dom/MutationEvent.h:
              (WebCore::MutationEvent::create):
              * dom/OverflowEvent.h:
              (WebCore::OverflowEvent::create):
              * dom/ProgressEvent.h:
              (WebCore::ProgressEvent::create):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::getMappedAttributeDecl):
              (WebCore::StyledElement::setMappedAttributeDecl):
              (WebCore::StyledElement::removeMappedAttributeDecl):
              (WebCore::StyledElement::createAttribute):
              * dom/StyledElement.h:
              * dom/TextEvent.cpp:
              (WebCore::TextEvent::TextEvent):
              (WebCore::TextEvent::initTextEvent):
              * dom/TextEvent.h:
              (WebCore::TextEvent::create):
              * dom/UIEvent.cpp:
              (WebCore::UIEvent::UIEvent):
              (WebCore::UIEvent::initUIEvent):
              * dom/UIEvent.h:
              (WebCore::UIEvent::create):
              * dom/UIEventWithKeyState.h:
              (WebCore::UIEventWithKeyState::ctrlKey):
              (WebCore::UIEventWithKeyState::shiftKey):
              (WebCore::UIEventWithKeyState::altKey):
              (WebCore::UIEventWithKeyState::metaKey):
              (WebCore::UIEventWithKeyState::UIEventWithKeyState):
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
              (WebCore::WheelEvent::initWheelEvent):
              * dom/WheelEvent.h:
              (WebCore::WheelEvent::create):
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand):
              * editing/AppendNodeCommand.h:
              (WebCore::AppendNodeCommand::create):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::create):
              * editing/BreakBlockquoteCommand.h:
              (WebCore::BreakBlockquoteCommand::create):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::applyStyle):
              (WebCore::CompositeEditCommand::applyStyledElement):
              (WebCore::CompositeEditCommand::removeStyledElement):
              (WebCore::CompositeEditCommand::insertParagraphSeparator):
              (WebCore::CompositeEditCommand::insertLineBreak):
              (WebCore::CompositeEditCommand::insertNodeBefore):
              (WebCore::CompositeEditCommand::appendNode):
              (WebCore::CompositeEditCommand::removeNode):
              (WebCore::CompositeEditCommand::removeNodePreservingChildren):
              (WebCore::CompositeEditCommand::splitTextNode):
              (WebCore::CompositeEditCommand::splitElement):
              (WebCore::CompositeEditCommand::mergeIdenticalElements):
              (WebCore::CompositeEditCommand::wrapContentsInDummySpan):
              (WebCore::CompositeEditCommand::splitTextNodeContainingElement):
              (WebCore::CompositeEditCommand::joinTextNodes):
              (WebCore::CompositeEditCommand::inputText):
              (WebCore::CompositeEditCommand::insertTextIntoNode):
              (WebCore::CompositeEditCommand::deleteTextFromNode):
              (WebCore::CompositeEditCommand::replaceTextInNode):
              (WebCore::CompositeEditCommand::deleteSelection):
              (WebCore::CompositeEditCommand::removeCSSProperty):
              (WebCore::CompositeEditCommand::removeNodeAttribute):
              (WebCore::CompositeEditCommand::setNodeAttribute):
              (WebCore::CompositeEditCommand::appendBlockPlaceholder):
              (WebCore::CompositeEditCommand::insertBlockPlaceholder):
              (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::splitTreeToNode):
              * editing/CompositeEditCommand.h:
              (WebCore::CompositeEditCommand::isFirstCommand):
              * editing/CreateLinkCommand.h:
              (WebCore::CreateLinkCommand::create):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/DeleteFromTextNodeCommand.cpp:
              (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * editing/DeleteFromTextNodeCommand.h:
              (WebCore::DeleteFromTextNodeCommand::create):
              * editing/DeleteSelectionCommand.h:
              (WebCore::DeleteSelectionCommand::create):
              * editing/EditCommand.h:
              (WebCore::SimpleEditCommand::SimpleEditCommand):
              * editing/Editor.cpp:
              (WebCore::Editor::deleteSelectionWithSmartDelete):
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::removeFormattingAndStyle):
              (WebCore::Editor::clearLastEditCommand):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              (WebCore::Editor::indent):
              (WebCore::Editor::outdent):
              (WebCore::dispatchEditableContentChangedEvents):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertFragment):
              (WebCore::executeCreateLink):
              (WebCore::executeFormatBlock):
              (WebCore::executeIndent):
              (WebCore::executeInsertOrderedList):
              (WebCore::executeInsertUnorderedList):
              (WebCore::executeOutdent):
              (WebCore::executeUnlink):
              * editing/FormatBlockCommand.h:
              (WebCore::FormatBlockCommand::create):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/IndentOutdentCommand.h:
              (WebCore::IndentOutdentCommand::create):
              * editing/InsertIntoTextNodeCommand.cpp:
              (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * editing/InsertIntoTextNodeCommand.h:
              (WebCore::InsertIntoTextNodeCommand::create):
              * editing/InsertLineBreakCommand.h:
              (WebCore::InsertLineBreakCommand::create):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h:
              (WebCore::InsertListCommand::create):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
              * editing/InsertNodeBeforeCommand.h:
              (WebCore::InsertNodeBeforeCommand::create):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.h:
              (WebCore::InsertParagraphSeparatorCommand::create):
              * editing/InsertTextCommand.h:
              (WebCore::InsertTextCommand::create):
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
              * editing/JoinTextNodesCommand.h:
              (WebCore::JoinTextNodesCommand::create):
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
              * editing/MergeIdenticalElementsCommand.h:
              (WebCore::MergeIdenticalElementsCommand::create):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/MoveSelectionCommand.h:
              (WebCore::MoveSelectionCommand::create):
              * editing/RemoveCSSPropertyCommand.cpp:
              (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
              * editing/RemoveCSSPropertyCommand.h:
              (WebCore::RemoveCSSPropertyCommand::create):
              * editing/RemoveFormatCommand.h:
              (WebCore::RemoveFormatCommand::create):
              * editing/RemoveNodeAttributeCommand.cpp:
              (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
              * editing/RemoveNodeAttributeCommand.h:
              (WebCore::RemoveNodeAttributeCommand::create):
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::RemoveNodeCommand):
              * editing/RemoveNodeCommand.h:
              (WebCore::RemoveNodeCommand::create):
              * editing/RemoveNodePreservingChildrenCommand.cpp:
              (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
              (WebCore::RemoveNodePreservingChildrenCommand::doApply):
              * editing/RemoveNodePreservingChildrenCommand.h:
              (WebCore::RemoveNodePreservingChildrenCommand::create):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd):
              (WebCore::ReplacementFragment::ReplacementFragment):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::ReplaceSelectionCommand::create):
              * editing/SetNodeAttributeCommand.cpp:
              (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
              * editing/SetNodeAttributeCommand.h:
              (WebCore::SetNodeAttributeCommand::create):
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::SplitElementCommand):
              * editing/SplitElementCommand.h:
              (WebCore::SplitElementCommand::create):
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
              * editing/SplitTextNodeCommand.h:
              (WebCore::SplitTextNodeCommand::create):
              * editing/SplitTextNodeContainingElementCommand.cpp:
              (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              * editing/SplitTextNodeContainingElementCommand.h:
              (WebCore::SplitTextNodeContainingElementCommand::create):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertLineBreak):
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
              (WebCore::TypingCommand::insertParagraphSeparator):
              (WebCore::TypingCommand::insertTextRunWithoutNewlines):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
              (WebCore::TypingCommand::smartDelete):
              * editing/UnlinkCommand.h:
              (WebCore::UnlinkCommand::create):
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
              * editing/WrapContentsInDummySpanCommand.h:
              (WebCore::WrapContentsInDummySpanCommand::create):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
              (WebCore::HTMLTableElement::addSharedCellBordersDecl):
              (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
              (WebCore::HTMLTableElement::addSharedGroupDecls):
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createContainingTable):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              (WebCore::HTMLViewSourceDocument::addLine):
              (WebCore::HTMLViewSourceDocument::addLink):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didOpenURL):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::callListener):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMWindow.cpp:
              (WebCore::PostMessageTimer::PostMessageTimer):
              (WebCore::PostMessageTimer::fired):
              (WebCore::DOMWindow::postMessage):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::keyEvent):
              (WebCore::EventHandler::handleTextInputEvent):
              * page/Frame.cpp:
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::shouldClose):
              * page/FrameView.cpp:
              (WebCore::FrameView::updateOverflowStatus):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::currentKeyboardEvent):
              * page/mac/FrameMac.mm:
              * platform/DeprecatedValueListImpl.cpp:
              (WebCore::DeprecatedValueListImpl::Private::Private):
              (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl):
              (WebCore::DeprecatedValueListImpl::copyOnWrite):
              * platform/graphics/FontSelector.h:
              * platform/graphics/GlyphPageTreeNode.cpp:
              (WebCore::GlyphPageTreeNode::initializePage):
              * platform/graphics/GlyphPageTreeNode.h:
              (WebCore::GlyphPage::create):
              (WebCore::GlyphPage::GlyphPage):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::updateOverflowStatus):
              (WebCore::RenderLayer::updateReflectionStyle):
              * rendering/style/RenderStyle.h:
              (WebCore::TransformOperation::~TransformOperation):
              (WebCore::ScaleTransformOperation::create):
              (WebCore::ScaleTransformOperation::ScaleTransformOperation):
              (WebCore::RotateTransformOperation::create):
              (WebCore::RotateTransformOperation::RotateTransformOperation):
              (WebCore::SkewTransformOperation::create):
              (WebCore::SkewTransformOperation::operator==):
              (WebCore::SkewTransformOperation::SkewTransformOperation):
              (WebCore::TranslateTransformOperation::create):
              (WebCore::TranslateTransformOperation::operator==):
              (WebCore::TranslateTransformOperation::TranslateTransformOperation):
              (WebCore::MatrixTransformOperation::create):
              (WebCore::MatrixTransformOperation::MatrixTransformOperation):
              (WebCore::StyleReflection::create):
              (WebCore::StyleReflection::StyleReflection):
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.h:
              (WebCore::StorageEvent::create):
              (WebCore::StorageEvent::StorageEvent):
              * svg/SVGAngle.cpp:
              (WebCore::SVGAngle::SVGAngle):
              * svg/SVGAngle.h:
              (WebCore::SVGAngle::create):
              * svg/SVGAnimatedTemplate.h:
              (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
              (WebCore::lookupOrCreateWrapper):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible):
              * svg/SVGElement.h:
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::SVGMarkerElement):
              (WebCore::SVGMarkerElement::parseMappedAttribute):
              (WebCore::SVGMarkerElement::setOrientToAngle):
              * svg/SVGMarkerElement.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::createSVGAngle):
              * svg/SVGSVGElement.h:
              * svg/SVGZoomEvent.h:
              (WebCore::SVGZoomEvent::create):
              * svg/graphics/SVGImage.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::callReadyStateChangeListener):
              (WebCore::XMLHttpRequest::dispatchProgressEvent):
              * xml/XMLHttpRequestProgressEvent.cpp:
              * xml/XMLHttpRequestProgressEvent.h:
              (WebCore::XMLHttpRequestProgressEvent::create):
              (WebCore::XMLHttpRequestProgressEvent::position):
              (WebCore::XMLHttpRequestProgressEvent::totalSize):
              (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):
      
      WebKit/mac:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebView/WebFrame.mm:
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ac3c40
    • cwzwarich@webkit.org's avatar
      2008-06-14 Cameron Zwarich <cwzwarich@uwaterloo.ca> · ce46a1c5
      cwzwarich@webkit.org authored
              Reviewed by Oliver.
      
              Bug 19484: More instructions needs to use temporary registers
              <https://bugs.webkit.org/show_bug.cgi?id=19484>
      
              Make code generation for AddNode and SubNode use temporaries when
              necessary.
      
              JavaScriptCore:
      
              * kjs/grammar.y:
              * kjs/nodes.cpp:
              (KJS::AddNode::emitCode):
              (KJS::SubNode::emitCode):
              * kjs/nodes.h:
              (KJS::AddNode::):
              (KJS::SubNode::):
      
              LayoutTests:
      
              * fast/js/codegen-temporaries-expected.txt:
              * fast/js/resources/codegen-temporaries.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce46a1c5
  2. 13 Jun, 2008 16 commits
    • abarth@webkit.org's avatar
      WebCore: · 838a53ca
      abarth@webkit.org authored
      2008-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=19199
      
              Prevent external entities from loading across origins.
      
              Test: http/tests/security/xss-DENIED-xsl-external-entity.xml
      
              * dom/XMLTokenizer.cpp:
              (WebCore::shouldAllowExternalLoad):
              (WebCore::openFunc):
      
      LayoutTests:
      
      2008-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Test that an XSL style sheet can't include an external entity from
              another origin.
      
              * http/tests/security/resources/xsl-using-external-entity.xsl: Added.
              * http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
              * http/tests/security/xss-DENIED-xsl-external-entity.xml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      838a53ca
    • abarth@webkit.org's avatar
      WebCore: · 7f2ccfa0
      abarth@webkit.org authored
      2008-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19450
      
              Allow loads of same-origin documents only.
      
              Test: http/tests/security/xss-DENIED-xsl-document.xml
      
              * xml/XSLTProcessor.cpp:
              (WebCore::docLoaderFunc):
      
      LayoutTests:
      
      2008-06-13  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Test that the XSL document() function doesn't load a document from a
              foreign origin.
      
              * http/tests/security/resources/target.xml: Added.
              * http/tests/security/resources/xsl-using-document.xsl: Added.
              * http/tests/security/xss-DENIED-xsl-document-expected.txt: Added.
              * http/tests/security/xss-DENIED-xsl-document.xml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f2ccfa0
    • abarth@webkit.org's avatar
      2008-06-13 Adam Barth <abarth@webkit.org> · ff45fe9a
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Fixes <https://bugs.webkit.org/show_bug.cgi?id=15100>:
                XMLHttpRequest::urlMatchesDocumentDomain raises error if port
                information does not match exactly
      
              Refactor our security check for XMLHttpRequest into SecurityOrigin so
              we can reuse it in other places.  This leverages our default port
              technology in SecurityOrigin.
      
              I wasn't sure how to write a test for this because the LayoutTests run
              on non-default ports.
      
              * platform/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canRequest):
              * platform/SecurityOrigin.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::send):
              (WebCore::XMLHttpRequest::willSendRequest):
              * xml/XMLHttpRequest.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff45fe9a
    • abarth@webkit.org's avatar
      2008-06-13 Adam Barth <abarth@webkit.org> · e95d8b24
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Test whether we permit XMLHttpRequest once document.domain is set.
      
              * http/tests/xmlhttprequest/document-domain-set-expected.txt: Added.
              * http/tests/xmlhttprequest/document-domain-set.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e95d8b24
    • abarth@webkit.org's avatar
      2008-06-13 Adam Barth <abarth@webkit.org> · ab4c3e29
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Removed unnecessary dependencies.
      
              * platform/SecurityOrigin.cpp:
              * platform/SecurityOrigin.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab4c3e29
    • cwzwarich@webkit.org's avatar
      2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 9cb74e33
      cwzwarich@webkit.org authored
              Reviewed by Maciej.
      
              Combine TrueNode and FalseNode to make BooleanNode, and remove the
              unused class PlaceholderTrueNode.
      
              * kjs/grammar.y:
              * kjs/nodes.cpp:
              (KJS::BooleanNode::emitCode):
              * kjs/nodes.h:
              (KJS::BooleanNode::):
              (KJS::BooleanNode::precedence):
              * kjs/nodes2string.cpp:
              (KJS::BooleanNode::streamTo):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cb74e33
    • cwzwarich@webkit.org's avatar
      2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca> · e5ab63c4
      cwzwarich@webkit.org authored
              Reviewed by Maciej.
      
              Eliminate the use of temporaries to store the left hand side of an
              expression when the right hand side is a constant. This slightly
              improves the generated bytecode for a few SunSpider tests, but it is
              mostly in preparation for fixing
      
              Bug 19484: More instructions needs to use temporary registers
              <https://bugs.webkit.org/show_bug.cgi?id=19484>
      
              * VM/CodeGenerator.h:
              (KJS::CodeGenerator::leftHandSideNeedsCopy):
              (KJS::CodeGenerator::emitNodeForLeftHandSide):
              * kjs/nodes.cpp:
              (KJS::BracketAccessorNode::emitCode):
              (KJS::ReadModifyResolveNode::emitCode):
              (KJS::AssignDotNode::emitCode):
              (KJS::ReadModifyDotNode::emitCode):
              (KJS::AssignBracketNode::emitCode):
              (KJS::ReadModifyBracketNode::emitCode):
              * kjs/nodes.h:
              (KJS::ExpressionNode::):
              (KJS::FalseNode::):
              (KJS::TrueNode::):
              (KJS::NumberNode::):
              (KJS::StringNode::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5ab63c4
    • mjs@apple.com's avatar
      2008-06-13 Maciej Stachowiak <mjs@apple.com> · 51ad1d0e
      mjs@apple.com authored
              Reviewed by Oliver.
              
              - prettify opcode stats output
              
              I changed things to be a bit more aligned, also there is a new
              section listing most common opcodes and most common sequences that
              include them.
      
              * VM/Opcode.cpp:
              (KJS::):
              (KJS::OpcodeStats::~OpcodeStats):
              * VM/Opcode.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51ad1d0e
    • darin@apple.com's avatar
      WebKit/gtk: · 89589120
      darin@apple.com authored
      2008-06-13  Darin Adler  <darin@apple.com>
      
              - try to fix build
      
              * WebCoreSupport/FrameLoaderClientGtk.h: Add missing argument.
      
      WebKit/qt:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              - try to fix build
      
              * WebCoreSupport/FrameLoaderClientQt.h: Add missing argument.
      
      WebKit/wx:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              - try to fix build
      
              * WebKitSupport/FrameLoaderClientWx.h: Add missing argument.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89589120
    • cwzwarich@webkit.org's avatar
      2008-06-13 Cameron Zwarich <cwzwarich@uwaterloo.ca> · bf948af3
      cwzwarich@webkit.org authored
              Reviewed by Darin.
      
              Add a test for existing loader behaviour in preparation for:
      
              Bug 19422: Distinct redirects from the same link do not create distinct history items
              <https://bugs.webkit.org/show_bug.cgi?id=19422>
      
              * http/tests/navigation/redirect-cycle-expected.txt: Added.
              * http/tests/navigation/redirect-cycle.html: Added.
              * http/tests/navigation/resources/redirect-cycle-1.pl: Added.
              * http/tests/navigation/resources/redirect-cycle-2.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf948af3
    • mjs@apple.com's avatar
      2008-06-13 Maciej Stachowiak <mjs@apple.com> · d7eeb24e
      mjs@apple.com authored
              Reviewed by Darin.
              
              - enable a bunch of disabled layout tests which now run ok
              https://bugs.webkit.org/show_bug.cgi?id=19540
              
              I also made a minor change to selftxhtml.js to handle the case
              where the body is a frameset properly, and to frame.xhtml to match
              the HTML version of that file, and what the tests expect.
      
              * dom/html/level2/html/HTMLFormElement10-expected.txt: Added.
              * dom/html/level2/html/HTMLFormElement10.html: Copied from dom/html/level2/html/HTMLFormElement10.html-disabled.
              * dom/html/level2/html/HTMLFormElement10.html-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFormElement10-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFormElement10.xhtml: Copied from dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFormElement10.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement01-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement01.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement02-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement02.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement03-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement03.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement03.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement04-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement04.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement04.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement05-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement05.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement05.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement06-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement06.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement06.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement07-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement07.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement07.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement08-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement08.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement08.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameElement09-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameSetElement01-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameSetElement01.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/HTMLFrameSetElement02-expected.txt: Added.
              * dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml: Copied from dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled.
              * dom/xhtml/level2/html/HTMLFrameSetElement02.xhtml-disabled: Removed.
              * dom/xhtml/level2/html/resources/frame.xhtml:
              * dom/xhtml/level2/html/selfxhtml.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7eeb24e
    • darin@apple.com's avatar
      WebCore: · f6b094cd
      darin@apple.com authored
      2008-06-13  Darin Adler  <darin@apple.com>
      
              Reviewed by John Sullivan.
      
              - added FormState argument to action policy functions
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkNewWindowPolicy):
              (WebCore::FrameLoader::checkNavigationPolicy):
              * loader/FrameLoaderClient.h:
              * svg/graphics/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      
      WebKit/gtk:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              Reviewed by John Sullivan.
      
              - updated for addition of FormState argument to action policy functions
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
              (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      
      WebKit/mac:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              Reviewed by John Sullivan.
      
              - updated for addition of FormState argument to action policy functions
              - added WebActionFormKey
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
              (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
              (WebFrameLoaderClient::actionDictionary):
              * WebKit.exp:
              * WebView/WebPolicyDelegate.mm:
              * WebView/WebPolicyDelegatePrivate.h:
      
      WebKit/qt:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              Reviewed by John Sullivan.
      
              - updated for addition of FormState argument to action policy functions
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      
      WebKit/win:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              Reviewed by John Sullivan.
      
              - updated for addition of FormState argument to action policy functions
              - added WebActionFormKey
      
              * Interfaces/IWebPolicyDelegate.idl:
              * WebActionPropertyBag.cpp:
              (WebActionPropertyBag::WebActionPropertyBag):
              (WebActionPropertyBag::createInstance):
              (WebActionPropertyBag::AddRef):
              (WebActionPropertyBag::Release):
              (WebActionPropertyBag::Read):
              * WebActionPropertyBag.h:
              * WebFrame.cpp:
              (WebFrame::dispatchDecidePolicyForNewWindowAction):
              (WebFrame::dispatchDecidePolicyForNavigationAction):
      
      WebKit/wx:
      
      2008-06-13  Darin Adler  <darin@apple.com>
      
              Reviewed by John Sullivan.
      
              - updated for addition of FormState argument to action policy functions
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNewWindowAction):
              (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6b094cd
    • darin@apple.com's avatar
      2008-06-13 Darin Adler <darin@apple.com> · 49d3096c
      darin@apple.com authored
              * Scripts/make-js-test-wrappers: Added three more exceptions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49d3096c
    • kmccullough@apple.com's avatar
      2008-06-13 Kevin McCullough <kmccullough@apple.com> · 25284dfd
      kmccullough@apple.com authored
              Reviewed by Geoff.
      
              <rdar://problem/5969992> JSProfiler: Remove the recursion limit in the
              profiler.
              - Remove recursion from exclude().  This leaves only focus() to fix.
      
              * JavaScriptCore.exp: Change the signatures of the exported functions.
              * profiler/Profile.cpp:
              (KJS::Profile::forEach): I added a traverseNextNodePreOrder() function
              and so needed to distinguish the other function by labeling it
              traverseNextNodePostOrder().
              (KJS::Profile::exclude): All new exclude that iteratively walks the tree
              * profiler/Profile.h:
              (KJS::Profile::focus): Add a null check for m_head.
              * profiler/ProfileNode.cpp:
              (KJS::ProfileNode::traverseNextNodePostOrder): Renamed
              (KJS::ProfileNode::traverseNextNodePreOrder): Walks the tree in pre-
              order, where the parent is processed before the children.
              (KJS::ProfileNode::setTreeVisible): Iterate over the sub-tree and set
              all of the nodes visible value.  This changes another function that used
              recursion.
              (KJS::ProfileNode::exclude): Remove recursion from this function.
              Because we now check for m_visible and we are walking the tree in pre-
              order we do not need to check if an excluded node is in an excluded
              sub-tree.
              * profiler/ProfileNode.h: Added specific selfTime functions to
              facilitate exclude().
              (KJS::ProfileNode::setSelfTime):
              (KJS::ProfileNode::setActualSelfTime):
              (KJS::ProfileNode::setVisibleSelfTime):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25284dfd
    • justin.garcia@apple.com's avatar
      2008-06-13 Justin Garcia <justin.garcia@apple.com> · e9e0418e
      justin.garcia@apple.com authored
              Reviewed by Jess.
      
              <rdar://problem/5702248> Crash on Copy Image from the contextual menu on a broken image in Mail
      
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeImage): Check to see the image loaded successfully
              before trying to put data for it on the Pasteboard.  Mail shouldn't really
              include the Copy Image menu item, but if it does and the user selects it,
              we shouldn't crash.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9e0418e
    • hausmann@webkit.org's avatar
      2008-06-11 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk> · 30fa88a8
      hausmann@webkit.org authored
              With help from Siraj Razick  <siraj.razick@collabora.co.uk>
      
              Reviewed by Simon.
      
              https://bugs.webkit.org/show_bug.cgi?id=19367
              [Qt] Plugins are drawn over the scrollbars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30fa88a8
  3. 12 Jun, 2008 3 commits
    • darin@apple.com's avatar
      2008-06-12 Darin Adler <darin@apple.com> · 68dbe316
      darin@apple.com authored
              Reviewed by Maciej.
      
              - https://bugs.webkit.org/show_bug.cgi?id=19434
                speed up SunSpider by avoiding some string boxing
      
              Speeds up SunSpider by 1.1%.
      
              Optimized code path for getting built-in properties from strings -- avoid
              boxing with a string object in that case. We can make further changes to avoid
              even more boxing, but this change alone is a win.
      
              * API/JSCallbackObjectFunctions.h:
              (KJS::JSCallbackObject::staticValueGetter): Use isObject instead of inherits
              in asssert, since the type of slotBase() is now JSValue, not JSObject.
              (KJS::JSCallbackObject::staticFunctionGetter): Ditto.
              (KJS::JSCallbackObject::callbackGetter): Ditto.
      
              * kjs/internal.cpp:
              (KJS::StringImp::getPrimitiveNumber): Updated for change of data member name.
              (KJS::StringImp::toBoolean): Ditto.
              (KJS::StringImp::toNumber): Ditto.
              (KJS::StringImp::toString): Ditto.
              (KJS::StringInstance::create): Added; avoids a bit of cut and paste code.
              (KJS::StringImp::toObject): Use StringInstance::create.
              (KJS::StringImp::toThisObject): Ditto.
              (KJS::StringImp::lengthGetter): Added. Replaces the getter that used to live in
              the StringInstance class.
              (KJS::StringImp::indexGetter): Ditto.
              (KJS::StringImp::indexNumericPropertyGetter): Ditto.
              (KJS::StringImp::getOwnPropertySlot): Added. Deals with built in properties of
              the string class without creating a StringInstance.
      
              * kjs/internal.h:
              (KJS::StringImp::getStringPropertySlot): Added. To be used by both the string
              and string object getOwnPropertySlot function.
      
              * kjs/lookup.h:
              (KJS::staticFunctionGetter): Updated since slotBase() is now a JSValue rather
              than a JSObject.
      
              * kjs/object.h: Removed PropertySlot::slotBase() function, which can now move
              back into property_slot.h where it belongs since it doesn't have to cast to
              JSObject*.
      
              * kjs/property_slot.cpp:
              (KJS::PropertySlot::functionGetter): Updated since slot.slotBase() is now a JSValue*
              instead of JSObject*. setGetterSlot still guarantees the base is a JSObject*.
              * kjs/property_slot.h:
              (KJS::PropertySlot::PropertySlot): Changed base to JSValue* intead of JSCell*.
              (KJS::PropertySlot::setStaticEntry): Ditto.
              (KJS::PropertySlot::setCustom): Ditto.
              (KJS::PropertySlot::setCustomIndex): Ditto.
              (KJS::PropertySlot::setCustomNumeric): Ditto.
              (KJS::PropertySlot::slotBase): Moved inline here since it no longer involves a
              downcast to JSObject*.
              (KJS::PropertySlot::setBase): Changed to JSValue*.
      
              * kjs/string_object.cpp:
              (KJS::StringInstance::getOwnPropertySlot): Changed to use getStringPropertySlot
              instead of coding the properties here. This allows sharing the code with StringImp.
      
              * kjs/string_object.h: Removed inlineGetOwnPropertySlot, lengthGetter, and indexGetter.
              Made one of the constructors protected.
      
              * kjs/value.h: Made getOwnPropertySlot private in the JSCell class -- this is better
              since it's not the real JSObject getOwnPropertySlot semantic and most callers shouldn't
              use it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68dbe316
    • sullivan@apple.com's avatar
      2008-06-12 John Sullivan <sullivan@apple.com> · 6276a603
      sullivan@apple.com authored
              Reviewed by Dan and Darin
      
              Clear up the confusion about _close (older private method) vs -close (newer public method).
      
              * WebView/WebView.mm:
              (-[WebView _isClosed]):
              simplified style
              (-[WebView _close]):
              added a comment about how clients and subclasses should use -close instead
              (-[WebView dealloc]):
              call -close instead of _close, so subclasses that override the public method will have the intended behavior
              (-[WebView close]):
              added a comment
              (-[WebView _windowWillClose:]):
              call -close instead of _close, so subclasses that override the public method will have the intended behavior
      
              * WebView/WebViewPrivate.h:
              added a comment about how clients and subclasses should use -close instead
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6276a603
    • darin@apple.com's avatar
      2008-06-12 Darin Adler <darin@apple.com> · 9da1da72
      darin@apple.com authored
              - try to fix no-SVG build
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a case for
              CSSPropertyWebkitMask.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9da1da72