GitLab

2008-05-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Don't try to store the resource data if it's empty.
        
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store):

LayoutTests:

2008-05-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add test where a manifest references an empty file.
        
        * http/tests/appcache/manifest-with-empty-file.html: Added.
        * http/tests/appcache/resources/empty.txt: Added.
        * http/tests/appcache/resources/manifest-with-empty-file.manifest: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * platform/network/NetworkStateNotifier.cpp: Added a missing #include.
        * platform/network/NetworkStateNotifier.h:
        (WebCore::NetworkStateNotifier::NetworkStateNotifier): Removed 'void'
        return type from the constructor, and fixed the spelling of a member
        variable.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam.

        <rdar://problem/5770054> JavaScript profiler (10928)
        - Add support for interacting with the JavaScriptCore profiler.

        * ForwardingHeaders/profiler/FunctionCallProfile.h: Added.
        * ForwardingHeaders/profiler/Profile.h: Added.
        * GNUmakefile.am: Add the new files to all the projects.
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * page/InspectorController.cpp: Add the ability to retrieve all of the
        profiles in JavaScript from the InspectorController.
        (WebCore::allProfiles):
        (WebCore::InspectorController::windowScriptObjectAvailable):
        * page/JavaScriptFunctionCallProfile.cpp: Added. Wrapper around the JSC
        FunctionCallProfile.
        (WebCore::functionCallProfileCache): This cache makes sure we don't
        needlessly create duplicate wrappers around the same
        FunctionCallProfile*.
        (WebCore::getFunctionName): Callback to return the name of the function.
        (WebCore::getTotalTime): Callback to return the total time spent in the
        function.
        (WebCore::getSelfTime): Callback to return the time spent in self (total
        - time in children) in the function.
        (WebCore::getNumberOfCalls): Callback to return the number of times this
        function was called.
        (WebCore::getChildren): Callback to return the children of this function
        where the children are the functions this function called.
        (WebCore::finalize): Cleanup.
        (WebCore::functionCallProfileClass): Define the JSClassRef for this
        object.
        (WebCore::toJS): Create a conversion function to make a usable JSValue
        to wrap the FunctionCallProfile in JSC.
        * page/JavaScriptFunctionCallProfile.h: Added.
        * page/JavaScriptProfile.cpp: Added. Wrapper around the JSC Profile.
        (WebCore::profileCache): This cache makes sure we don't needlessly
        create duplicate wrappers aroudn the same Profile*.
        (WebCore::getHeadCallback): Callback to return the head of the graph of
        the functions profiled durring this profile's run.
        (WebCore::finalize):
        (WebCore::profileClass): Define the JSClassRef for this object.
        (WebCore::toJS): Create a conversion function to make a usable JSValue
        to wrap the Profile from JSC.
        * page/JavaScriptProfile.h: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <https://bugs.webkit.org/show_bug.cgi?id=18767>

        Reviewed by Tim Hatcher.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::highlight): Only move the highlight behind the
        Inspector window when first creating the highlight, not every time we
        update it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix for bug https://bugs.webkit.org/show_bug.cgi?id=16130.

        Opacity, transforms, reflections and masks should not honor z-index unless the element is also
        positioned.  Always reset to auto if the element is not positioned (and then the following code will
        adjust auto to 0 as needed).

        Reviewed by Dan Bernstein

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Brady.

        <rdar://problem/5931742> Support navigator.onLine from HTML5
        
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Add NetworkStateNotifier files.
        
        * dom/EventNames.h:
        Add offline and online events.
        
        * page/Navigator.cpp:
        (WebCore::Navigator::onLine):
        * page/Navigator.h:
        * page/Navigator.idl:
        Add navigator.onLine.
        
        * page/Page.cpp:
        (WebCore::networkStateChanged):
        Dispatch offline/online events to all frames.
        
        (WebCore::Page::Page):
        Set state change callback.
        
        * platform/network/NetworkStateNotifier.cpp: Added.
        * platform/network/NetworkStateNotifier.h: Added.

        * platform/network/mac/NetworkStateNotifierMac.cpp: Added.
        Mac network state notifier.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add missing NULL check to match rest of file, this was found by the editing fuzzer.

        * WebView/WebResource.mm:
        (-[WebResource data]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tim Hatcher.

        Tested by pre-existing
        manual-tests/inspector/console-log-formatting.html.

        * page/inspector/Console.js:
        (WebInspector.ConsoleMessage.prototype._format): Changed to explicitly
        wrap Console._format instead of using bind to do it. Using bind was
        causing us to pass plainText in as the first parameter instead of as
        the second.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

call stack (would look like it stepped out twice.)

Reviewed by Adam Roben.

* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::returnEvent):
Call pauseIfNeeded before setting m_currentCallFrame to the caller.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

   
        Fix 64bit build

        * plugins/PluginView.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        REGRESSION (r26474): WebKit fails jQuery test 64 core module: text(String) subtest 1 Check escaped text (createTextNode)

        <https://bugs.webkit.org/show_bug.cgi?id=18976>
        <rdar://problem/5924793>

        Reviewed by Darin.

        Tests: fast/dom/dom-parse-serialize-expected.txt:
               fast/xsl/xslt-processor-expected.txt:
               fast/xsl/xslt-text-expected.txt:

        Commit r26474 removed escaping of '>' characters to '&gt;' in serialized
        HTML content, which broke one jQuery test.  This change restores that
        serialization behavior to both attributes and content for consistency.

        * editing/markup.cpp:
        (WebCore::appendAttributeValue): Escape '>' as '&gt;'.
        (WebCore::escapeContentText): Ditto.
        (WebCore::appendEscapedContent): Ditto.  This is the bug fix for the jQuery test.

LayoutTests:

        REGRESSION (r26474): WebKit fails jQuery test 64 core module: text(String) subtest 1 Check escaped text (createTextNode)

        <https://bugs.webkit.org/show_bug.cgi?id=18976>
        <rdar://problem/5924793>

        Reviewed by Darin.

        Updated test results now that '>' is escaped to '&gt;' in both
        attributes and content.

        * fast/xsl/xslt-processor-expected.txt:
        * fast/xsl/xslt-text-expected.txt:
        * platform/mac/fast/dom/dom-parse-serialize-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix Bug 19051: REGRESSION (r33447): Assertion in JSDebugServer::removeListener closing tab with Inspector open

        m_inspectedPage is now cleared when the Page is destroyed, which never
        used to happen. Some of InspectorController's code was not prepared
        for this.

        Reviewed by Dave Hyatt.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController): Removed a call
        to stopDebugging and added an assertion. Debugging should have already
        been stopped by this point.
        (WebCore::InspectorController::inspectedPageDestroyed): Moved here
        from the header file. Added a call to stopDebugging.
        (WebCore::InspectorController::enabled): Return false if our inspected
        Page has already been destroyed, since we can't really do much at this
        point anyway.
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::startDebuggingAndReloadInspectedPage):
        (WebCore::InspectorController::stopDebugging):
        (WebCore::InspectorController::drawNodeHighlight):
        Assert that m_inspectedPage hasn't been cleared.
        * page/InspectorController.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-05-14  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5914803> Improve performance of WebCore::Editor::setComposition

        * editing/Editor.cpp:
        (WebCore::Editor::confirmComposition): Remove the previous composition
        when we insert the new one, not with a separate, slower, delete operation.
        (WebCore::Editor::setComposition): Ditto.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace): Remove the selected
        text with a low level operation that doesn't perform a layout and insert
        the new text in a way that won't trigger a layout from the removal.
        (WebCore::InsertTextCommand::input): Call the optimized replace.
        * editing/InsertTextCommand.h:
        * editing/htmlediting.cpp:
        (WebCore::isTabSpanNode): Check to see if the node is a span, to avoid 
        the expense of getAttribute in the common case.
        * page/Frame.cpp:
        (WebCore::Frame::selectionLayoutChanged): Selection::start() and end()
        will already be at VisiblePosition deepEquivalents. Selection::validate()
        ensures this.

LayoutTests:

2008-05-14  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5914803> Improve performance of WebCore::Editor::setComposition
        
        Replacing all the text in a node is now much less likely to remove it
        and cause selection changes.

        * platform/mac/editing/input/text-input-controller-expected.txt:
        * platform/mac/editing/inserting/4959067-expected.txt:
        * platform/mac/editing/style/style-3681552-fix-001-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.

        * Plugins/nptextinput.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        When Reload was selected from the context menu in the Inspector, the
        Inspector window would close and never be openable again. Now it
        closes, then reopens when the page finishes loading.

        Reviewed by Tim Hatcher.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::close): Removed code that cleared out
        m_page. This is now handled by pageDestroyed.
        * page/InspectorController.h:
        (WebCore::InspectorController::inspectedPageDestroyed): Added.
        * page/Page.cpp:
        (WebCore::Page::~Page): Fixed a bug and added a call to the new
        inspectedPageDestroyed. If we have a parent InspectorController, that
        means that we are the Page in the Inspector's window (i.e., we are the
        Inspector's UI), so when we are destroyed we should call
        InspectorController::pageDestroyed. We also need to call
        inspectedPageDestroyed on our own InspectorController so that it won't
        try to call into us.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

       
        Reviewed by Eric.
       
        - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
          We now force the return value to be numeric.

        - Removed platform checks as it was a work around the previous issue.

        - Replaced isDarwin() by isOSX() as they have now the same behaviour.

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

with a toggle buttons to enable or disable it.

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::pauseOnExceptions): Call the InspectorController.
(WebCore::setPauseOnExceptions): Ditto.
(WebCore::InspectorController::windowScriptObjectAvailable): Add the new
setPauseOnExceptions and pauseOnExceptions functions to the JS class.
(WebCore::InspectorController::pauseOnExceptions): Call JavaScriptDebugServer.
(WebCore::InspectorController::setPauseOnExceptions): Ditto.
* page/InspectorController.h:
* page/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::setPauseOnExceptions): Set m_pauseOnExceptions.
(WebCore::JavaScriptDebugServer::exception): Check m_pauseOnExceptions
and set m_pauseOnNextStatement to true before calling pauseIfNeeded.
* page/JavaScriptDebugServer.h:
* page/inspector/Images/pauseOnExceptionButtons.png: Added.
* page/inspector/ScriptsPanel.js: Adds a status bar button that calls
the new InspectorController functions.
* page/inspector/inspector.css: New styles.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

object Global. Name objects before the locals "With Block".
Name colsure scopes "Closure". Name any element or document
after Local, "Event Target" and "Event Document", respectfully.

Reviewed by Adam Roben.

* English.lproj/localizedStrings.js: Add new strings.
* page/inspector/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection): Add a new argument that is used
for the empty placeholder text.
(WebInspector.ObjectPropertiesSection.prototype.onpopulate): Use the
empty placeholder text.
* page/inspector/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane): Rename Scope Chain to Scope Variables.
(WebInspector.ScopeChainSidebarPane.prototype.update): Use the object name as
the subtitle. Use "Global" for the global object title. Use "With Block" for
the title of objects before the locals. Use "No Variables" for the empty
placeholder text for locals.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <rdar://problem/5934376> REGRESSION: A script fails because of a straw BOM character in it.

        <https://bugs.webkit.org/show_bug.cgi?id=4931>
        Unicode format characters (Cf) should be removed from JavaScript source

        Of all Cf characters, we are only removing BOM, because this is what Firefox trunk has
        settled upon, after extensive discussion and investigation.

        Based on Darin's work on this bug.

        Test: fast/js/removing-Cf-characters.html

        * kjs/lexer.cpp:
        (KJS::Lexer::setCode): Tweak formatting. Use a call to shift(4) to read in the
        first characters, instead of having special case code here.
        (KJS::Lexer::shift): Add a loop when reading a character to skip BOM characters.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Alexey.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=16923 
        Attr nodes with a value of "" should not have any childNodes
        
        In Opera, Firefox and IE, when an attribute node has a value
        of "", the attribute node doesn't have any childNodes. This
        is true in WebKit also, but not when you assign "" to the
        Attr's value when the existing value is non-empty.
        
        Test: fast/dom/attribute-empty-value-no-children.html

        * dom/Attr.cpp: (WebCore::Attr::setValue): Use createTextChild(), which only appends
        a child text node if the value being assigned is not empty.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric.

        GCC 4.3 build fix.
        Removes some compiler warnings.

        * dom/Document.h:
        (WebCore::FormElementKey::hashTableDeletedValue): GCC complained about the const keyword
        so remove it as it is only used inside FormElementKey.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Correct coding style (removes
        a warning too).

        * loader/appcache/ApplicationCacheResource.cpp: Include stdio.h for gcc4.3 build.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::PluginPackage): Changed initialization order in the constructor.
        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView): Ditto.
        * plugins/PluginView.h:
        * xml/AccessControlList.cpp: Include stdio.h
        * xml/AccessItem.cpp: Ditto.
        * xml/AccessItemRule.cpp: Ditto.




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Simon.

Qt build fix. Add JSJavaScriptCallFrameCustom.cpp to the build
and implemented EventLoopQt.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon.

        Qt build fix. Add JavaScriptCallFrame.{idl,cpp} to the build.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by John Sullivan.

        - Windows part of <rdar://problem/5725912> improve render quality of transformed text

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Added call to
        wkSetCGContextFontRenderingStyle().

WebKitLibraries:

        Reviewed by John Sullivan.

        - WebKitSystemInterface support for <rdar://problem/5725912> improve render quality of transformed text

        * libWebKitSystemInterfaceLeopard.a: Improved glyph positioning in
        transformed graphics contexts.
        * win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added
        wkSetCGContextFontRenderingStyle().
        * win/lib/WebKitSystemInterface.lib: Updated.
        * win/lib/WebKitSystemInterface_debug.lib: Updated.

LayoutTests:

        Reviewed by John Sullivan.

        - updated pixel results for <rdar://problem/5725912> improve render quality of transformed text

        * platform/mac-leopard/fast/backgrounds: Added.
        * platform/mac-leopard/fast/backgrounds/repeat: Added.
        * platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum: Added.
        * platform/mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-02-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-03-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-04-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
        * platform/mac-leopard/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
        * platform/mac-leopard/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
        * platform/mac-leopard/svg/batik/text/textAnchor-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textAnchor-expected.png:
        * platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
        * platform/mac-leopard/svg/batik/text/textFeatures-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textFeatures-expected.png:
        * platform/mac-leopard/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
        * platform/mac-leopard/svg/batik/text/textLayout-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textLayout-expected.png:
        * platform/mac-leopard/svg/batik/text/textLength-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textLength-expected.png:
        * platform/mac-leopard/svg/batik/text/textOnPath-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textOnPath-expected.png:
        * platform/mac-leopard/svg/batik/text/textOnPath2-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textOnPath2-expected.png:
        * platform/mac-leopard/svg/batik/text/textOnPath3-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textOnPath3-expected.png:
        * platform/mac-leopard/svg/batik/text/textOnPathSpaces-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textOnPathSpaces-expected.png:
        * platform/mac-leopard/svg/batik/text/textProperties2-expected.checksum:
        * platform/mac-leopard/svg/batik/text/textProperties2-expected.png:
        * platform/mac-leopard/svg/batik/text/verticalText-expected.checksum:
        * platform/mac-leopard/svg/batik/text/verticalText-expected.png:
        * platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.checksum:
        * platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.png:
        * platform/mac-leopard/svg/carto.net/button-expected.checksum:
        * platform/mac-leopard/svg/carto.net/button-expected.png:
        * platform/mac-leopard/svg/carto.net/colourpicker-expected.checksum:
        * platform/mac-leopard/svg/carto.net/colourpicker-expected.png:
        * platform/mac-leopard/svg/carto.net/combobox-expected.checksum:
        * platform/mac-leopard/svg/carto.net/combobox-expected.png:
        * platform/mac-leopard/svg/carto.net/scrollbar-expected.checksum:
        * platform/mac-leopard/svg/carto.net/scrollbar-expected.png:
        * platform/mac-leopard/svg/carto.net/selectionlist-expected.checksum:
        * platform/mac-leopard/svg/carto.net/selectionlist-expected.png:
        * platform/mac-leopard/svg/carto.net/slider-expected.checksum:
        * platform/mac-leopard/svg/carto.net/slider-expected.png:
        * platform/mac-leopard/svg/carto.net/textbox-expected.checksum:
        * platform/mac-leopard/svg/carto.net/textbox-expected.png:
        * platform/mac-leopard/svg/carto.net/window-expected.checksum:
        * platform/mac-leopard/svg/carto.net/window-expected.png:
        * platform/mac-leopard/svg/custom/coords-relative-units-transforms-expected.checksum:
        * platform/mac-leopard/svg/custom/coords-relative-units-transforms-expected.png:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.checksum:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.checksum:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.checksum:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.checksum:
        * platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/mac-leopard/svg/custom/focus-ring-expected.checksum:
        * platform/mac-leopard/svg/custom/focus-ring-expected.png:
        * platform/mac-leopard/svg/custom/font-platformDestroy-crash-expected.checksum:
        * platform/mac-leopard/svg/custom/font-platformDestroy-crash-expected.png:
        * platform/mac-leopard/svg/custom/foreign-object-skew-expected.checksum:
        * platform/mac-leopard/svg/custom/foreign-object-skew-expected.png:
        * platform/mac-leopard/svg/custom/getTransformToElement-expected.checksum:
        * platform/mac-leopard/svg/custom/getTransformToElement-expected.png:
        * platform/mac-leopard/svg/custom/invalid-css-expected.checksum:
        * platform/mac-leopard/svg/custom/invalid-css-expected.png:
        * platform/mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.checksum:
        * platform/mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png:
        * platform/mac-leopard/svg/custom/js-late-clipPath-creation-expected.checksum:
        * platform/mac-leopard/svg/custom/js-late-clipPath-creation-expected.png:
        * platform/mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.checksum:
        * platform/mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
        * platform/mac-leopard/svg/custom/js-late-gradient-creation-expected.checksum:
        * platform/mac-leopard/svg/custom/js-late-gradient-creation-expected.png:
        * platform/mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
        * platform/mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
        * platform/mac-leopard/svg/custom/js-late-pattern-creation-expected.checksum:
        * platform/mac-leopard/svg/custom/js-late-pattern-creation-expected.png:
        * platform/mac-leopard/svg/custom/marker-default-width-height-expected.checksum:
        * platform/mac-leopard/svg/custom/marker-default-width-height-expected.png:
        * platform/mac-leopard/svg/custom/multiple-title-elements-expected.checksum:
        * platform/mac-leopard/svg/custom/multiple-title-elements-expected.png:
        * platform/mac-leopard/svg/custom/path-textPath-simulation-expected.checksum:
        * platform/mac-leopard/svg/custom/path-textPath-simulation-expected.png:
        * platform/mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.checksum:
        * platform/mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
        * platform/mac-leopard/svg/custom/shapes-supporting-markers-expected.checksum:
        * platform/mac-leopard/svg/custom/shapes-supporting-markers-expected.png:
        * platform/mac-leopard/svg/custom/stroked-pattern-expected.checksum:
        * platform/mac-leopard/svg/custom/stroked-pattern-expected.png:
        * platform/mac-leopard/svg/custom/struct-use-09-b-expected.checksum:
        * platform/mac-leopard/svg/custom/struct-use-09-b-expected.png:
        * platform/mac-leopard/svg/custom/tref-update-expected.checksum:
        * platform/mac-leopard/svg/custom/tref-update-expected.png:
        * platform/mac-leopard/svg/custom/use-detach-expected.checksum:
        * platform/mac-leopard/svg/custom/use-detach-expected.png:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-1-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-2-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-3-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-4-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-5-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-6-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
        * platform/mac-leopard/svg/custom/use-on-non-svg-namespaced-element-expected.checksum:
        * platform/mac-leopard/svg/custom/use-on-non-svg-namespaced-element-expected.png:
        * platform/mac-leopard/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
        * platform/mac-leopard/svg/custom/use-referencing-nonexisting-symbol-expected.png:
        * platform/mac-leopard/svg/custom/viewbox-syntax-expected.checksum:
        * platform/mac-leopard/svg/custom/viewbox-syntax-expected.png:
        * platform/mac-leopard/svg/hixie/text/003-expected.checksum:
        * platform/mac-leopard/svg/hixie/text/003-expected.png:
        * platform/mac-leopard/svg/hixie/text/003b-expected.checksum:
        * platform/mac-leopard/svg/hixie/text/003b-expected.png:
        * platform/mac-leopard/svg/text/text-align-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-align-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-align-02-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-align-02-b-expected.png:
        * platform/mac-leopard/svg/text/text-align-03-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-align-03-b-expected.png:
        * platform/mac-leopard/svg/text/text-align-04-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-align-04-b-expected.png:
        * platform/mac-leopard/svg/text/text-align-05-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-align-05-b-expected.png:
        * platform/mac-leopard/svg/text/text-align-06-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-align-06-b-expected.png:
        * platform/mac-leopard/svg/text/text-altglyph-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-altglyph-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-deco-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-deco-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-fonts-01-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-fonts-01-t-expected.png:
        * platform/mac-leopard/svg/text/text-fonts-02-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-fonts-02-t-expected.png:
        * platform/mac-leopard/svg/text/text-intro-05-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-intro-05-t-expected.png:
        * platform/mac-leopard/svg/text/text-path-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-path-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-text-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-text-03-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-03-b-expected.png:
        * platform/mac-leopard/svg/text/text-text-04-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-04-t-expected.png:
        * platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-05-t-expected.png:
        * platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-06-t-expected.png:
        * platform/mac-leopard/svg/text/text-text-07-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-07-t-expected.png:
        * platform/mac-leopard/svg/text/text-text-08-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-text-08-b-expected.png:
        * platform/mac-leopard/svg/text/text-tref-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-tref-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-tselect-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-tselect-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-tselect-02-f-expected.checksum:
        * platform/mac-leopard/svg/text/text-tselect-02-f-expected.png:
        * platform/mac-leopard/svg/text/text-tspan-01-b-expected.checksum:
        * platform/mac-leopard/svg/text/text-tspan-01-b-expected.png:
        * platform/mac-leopard/svg/text/text-ws-01-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-ws-01-t-expected.png:
        * platform/mac-leopard/svg/text/text-ws-02-t-expected.checksum:
        * platform/mac-leopard/svg/text/text-ws-02-t-expected.png:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        GTK+ build fix. Implement EventLoopGtk.cpp.

        * GNUmakefile.am:
        * platform/gtk/EventLoopGtk.cpp: Added.
        (WebCore::EventLoop::cycle):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        GTK+ build fix. Fix IDL filename typo and add JavaScriptCallFrame.cpp
        to the build.

        * GNUmakefile.am:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Not reviewed, partial Gtk build fix.

        * GNUmakefile.am:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://bugs.webkit.org/show_bug.cgi?id=19037

Reviewed by Dan Bernstein.

* page/InspectorController.cpp:
(WebCore::currentCallFrame): Adds a null check of currentCallFrame,
since it can be null. Also returns JSNull to better signify this.
* page/inspector/ScriptsPanel.js: Updates the debugger interface
when stepping so the currentCallFrame isn't accessed when not paused.
Adds a _clearInterface function to remove duplicate code.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Not reviewed, build fix.

        * kjs/date_object.cpp:
        (KJS::DateObjectFuncImp::callAsFunction):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam.

        Don't empty the application cache in _setCacheModel, since it will be called during initialization.
        Instead, do it in [WebCache empty].
        
        * Misc/WebCache.mm:
        (+[WebCache empty]):
        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Sam.

        <rdar://problem/5933644> Implement Date.now
        
        Implement Date.now which returns the number of milliseconds since the epoch.
        
        * kjs/CommonIdentifiers.h:
        * kjs/date_object.cpp:
        (KJS::DateObjectFuncImp::):
        (KJS::DateObjectImp::DateObjectImp):
        (KJS::DateObjectFuncImp::callAsFunction):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

informs the user that they need to attach the debugger.
Provides an "Attach Debugger" button below the info text.

Reviewed by Dan Bernstein.

* English.lproj/localizedStrings.js: New strings.
* page/inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel): Create the overlay elements and
append to the main panel element.
* page/inspector/inspector.css: New styles for the over lay elements.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

was referencing a nil WebView under validateUserInterfaceItem.
The validateUserInterfaceItem methods was being called at a time
when the WebHTMLView is being torndown.

<rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
while mousing down on menu bar after Xcode News window is opened

Reviewed by Ada Chan.

* WebView/WebHTMLView.mm:
(-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
return NO when it is nil. Adds a comment.
* WebView/WebPDFView.mm:
(-[WebPDFView validateUserInterfaceItem:]): Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

This change makes JSInspectedObjectWrapper pass unwrapped objects around for global objects
that share the same page group identifier. Also returns jsUndefined() instead of 0 to prevent
crashing in release builds if the page groups don't match.

Passes all the tests in: manual-tests/inspector-wrappers

Reviewed by Adam Roben.

* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::JSInspectedObjectWrapper::prepareIncomingValue): Return jsUndefined() instead of 0.
Call allowsUnwrappedAccessFrom instead of unwrappedExecStateMatches.
* bindings/js/JSQuarantinedObjectWrapper.cpp:
(WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Renamed from unwrappedExecStateMatches.
Return true if the pageGroupIdentifier of both wrappers match.
(WebCore::JSQuarantinedObjectWrapper::callAsFunction): Return jsUndefined() instead of 0.
* bindings/js/JSQuarantinedObjectWrapper.h: Renamed unwrappedExecStateMatches to allowsUnwrappedAccessFrom.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a disclosure triangle in the Properties pane. This change limits
the recursion depth when expanding the tree elements.

<rdar://problem/5847681> Safari hangs when option-clicking a
disclosure triangle in the Inspector's Properties pane

Reviewed by John Sullivan.

* page/inspector/treeoutline.js:
(TreeElement.prototype.expandRecursively): Pass an empty info object to
traverseNextTreeElement to get the depthChange value. This is used to
compute a current depth. If the depth exceeds the maxDepth argument, the
item isn't expanded and children wont be populated when traverseNextTreeElement
is called until the depth goes below the maxDepth.
(TreeElement.prototype.traverseNextTreeElement): Added a new info
argument that can be optionally used to return extra info like depth change.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

that would normally be empty. These help the user know why there
is nothing in these sections.

Reviewed by John Sullivan.

* English.lproj/localizedStrings.js: Add strings.
* page/inspector/BreakpointsSidebarPane.js: Adds "No Breakpoints".
* page/inspector/CallStackSidebarPane.js: Adds "Not Paused".
* page/inspector/ObjectPropertiesSection.js: Adds "No Properties".
* page/inspector/ScopeChainSidebarPane.js: Adds "Not Paused".
* page/inspector/inspector.css: Adds style rules for the info elements.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33412 268f45cc-cd09-0410-ab3c-d52691b4dbfc