1. 05 Sep, 2012 40 commits
    • mihaip@chromium.org's avatar
      [Chromium] history.{push,replace}State should no longer be V8EnabledAtRuntime · 278aaeaf
      mihaip@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95865
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      r55549 made them be runtime-enabled (since the Chromium implementation
      was not complete at the time), but they've been enabled by default
      since http://crrev.com/41850
      
      * bindings/generic/RuntimeEnabledFeatures.cpp:
      (WebCore):
      * bindings/generic/RuntimeEnabledFeatures.h:
      (RuntimeEnabledFeatures):
      * page/History.idl:
      
      Source/WebKit/chromium:
      
      Make WebRuntimeFeatures::{enablePushState,isPushStateEnabled} into
      no-ops.
      
      * public/WebRuntimeFeatures.h:
      (WebRuntimeFeatures):
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enablePushState):
      (WebKit::WebRuntimeFeatures::isPushStateEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      278aaeaf
    • bashi@chromium.org's avatar
      [Chromium] unreviewed gardening after r127564 · 69e4642f
      bashi@chromium.org authored
      Added missing text expectation.
      
      * fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69e4642f
    • jamesr@google.com's avatar
      [chromium] Move static WebCompositor functions to WebCompositorSupport · 02b03ced
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95785
      
      Reviewed by Darin Fisher.
      
      The statics on WebCompositor need to be moved to WebCompositorSupport so the embedder can inject an
      implementation for these via PlatformSupport. This adds the interface for the statics to WebCompositorSupport.
      After an implementation of these lands on the chromium side, I'll switch all callers over to use these and
      remove the WebCompositor interface from the API.
      
      * chromium/public/WebCompositorSupport.h:
      (WebCompositorSupport):
      (WebKit::WebCompositorSupport::initialize):
      (WebKit::WebCompositorSupport::threadingEnabled):
      (WebKit::WebCompositorSupport::shutdown):
      (WebKit::WebCompositorSupport::setPerTilePaintingEnabled):
      (WebKit::WebCompositorSupport::setPartialSwapEnabled):
      (WebKit::WebCompositorSupport::setAcceleratedAnimationEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02b03ced
    • staikos@webkit.org's avatar
      [BlackBerry] Match th ebuild flags from the platform library · fcde6392
      staikos@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95423
      
      Reviewed by Antonio Gomes.
      
      Unaligned build flags can cause crashes and other strange behavior.
      These two were not defined here but were defined on the system.
      
      * Source/cmake/OptionsBlackBerry.cmake:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcde6392
    • staikos@webkit.org's avatar
      [BlackBerry] Assignment operators missing self-check · a9556e8e
      staikos@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95774
      
      Reviewed by Rob Buis.
      
      Add a test for self-assignment.
      
      * Api/WebAnimation.cpp:
      (BlackBerry::WebKit::WebAnimation::operator=):
      * Api/WebString.cpp:
      (BlackBerry::WebKit::WebString::operator=):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9556e8e
    • jsbell@chromium.org's avatar
      IndexedDB: Integer version lost after first open/close/open cycle · 829c5536
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95864
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      New backing stores were being created with an old schema version, causing migration
      to occur when the backing store was re-opened, which would overwrite valid integer
      version metadata. New backing stores should be created with the latest schema version
      since no migration is desired.
      
      Test: storage/indexeddb/intversion-persistence.html
      
      * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
      (WebCore::setUpMetadata):
      
      LayoutTests:
      
      Ensure integer versions are persisted across open/close/open cycles.
      
      Note that although this is a useful and valid test in general, the specific bug that
      prompted adding this test will only repro if the origin has no pre-existing backing
      store, which is not guaranteed by DRT or other shells. See http://webkit.org/b/92166
      
      * storage/indexeddb/intversion-persistence-expected.txt: Added.
      * storage/indexeddb/intversion-persistence.html: Added.
      * storage/indexeddb/resources/intversion-persistence.js: Added.
      (test):
      (openFirstTime.request.onupgradeneeded):
      (openFirstTime.request.onsuccess):
      (openFirstTime):
      (openSecondTime.request.onsuccess):
      (openSecondTime):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      829c5536
    • yosin@chromium.org's avatar
      [Tests] We should have mouse events test for multiple fields time input UI · ebf88455
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95829
      
      Reviewed by Kent Tamura.
      
      This patch adds test cases of mouse actions on multiple fields time
      input UI.
      
      The test checks:
       - Mouse click to set focus to field under mouse pointer
       - Mouse click on spin button
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      * fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebf88455
    • bashi@chromium.org's avatar
      [Chromium] unreviewed test expectation update · 9624a2cc
      bashi@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9624a2cc
    • barraclough@apple.com's avatar
      Bug, assignment within subscript of prefix/postfix increment of bracket access · e3aa3f54
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95913
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      javascript:alert((function(){ var a = { x:1 }; var b = { x:1 }; a[a=b,"x"]++; return a.x; })())
      
      * bytecompiler/NodesCodegen.cpp:
      (JSC::PostfixNode::emitBracket):
      (JSC::PrefixNode::emitBracket):
          - Should check for assigments in the subscript when loading the base.
      * parser/Nodes.h:
      (JSC::BracketAccessorNode::subscriptHasAssignments):
      (BracketAccessorNode):
          - Used by emitBracket methods.
      
      LayoutTests: 
      
      Added test cases.
      
      * fast/js/inc-bracket-assign-subscript-expected.txt: Added.
      * fast/js/inc-bracket-assign-subscript.html: Added.
      * fast/js/script-tests/inc-bracket-assign-subscript.js: Added.
      (testPreIncBracketAccessWithAssignSubscript):
      (testPostIncBracketAccessWithAssignSubscript):
          - Tests a pre/post increment to a bracket access, where subscript contains assignment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3aa3f54
    • bashi@chromium.org's avatar
      [Chromium] Unreviewed, build fix attempt after r127660 · 36c0f806
      bashi@chromium.org authored
      Make clang happy.
      
      * platform/mediastream/RTCPeerConnectionHandler.cpp:
      (WebCore::RTCPeerConnectionHandlerDummy::RTCPeerConnectionHandlerDummy):
      Use ASSERT_UNUSED() to suppress -Wunused-private-field warning
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36c0f806
    • mitz@apple.com's avatar
      Renamed a misnamed expected result. · 15e13854
      mitz@apple.com authored
      * platform/mac/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Copied from LayoutTests/platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt.
      * platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15e13854
    • paroga@webkit.org's avatar
      Build fix for Windows. · 3da03940
      paroga@webkit.org authored
      * rendering/RenderThemeWin.cpp: Added missing header include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3da03940
    • bashi@chromium.org's avatar
      [Chromium] Unreviewed, build fix attempt on win · 3cb75c1f
      bashi@chromium.org authored
      r127612 breaks chromium win build.
      
      * WebCore.gypi:
      * platform/mediastream/RTCPeerConnectionHandler.cpp:
      (WebCore::RTCPeerConnectionHandler::RTCPeerConnectionHandler):
      (WebCore):
      (WebCore::RTCPeerConnectionHandler::~RTCPeerConnectionHandler):
      * platform/mediastream/RTCPeerConnectionHandler.h:
      (RTCPeerConnectionHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cb75c1f
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Provide implementation for WebProcess functions · 565b297e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95857
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Add implementation for getVolumeFreeSizeForPath()
      in FileSystem which is required by soup-related
      code in WebKit2.
      
      No new tests, no behavior change.
      
      * platform/FileSystem.h:
      (WebCore):
      * platform/efl/FileSystemEfl.cpp:
      (WebCore::getVolumeFreeSizeForPath):
      (WebCore):
      
      Source/WebKit2:
      
      Rename WebProcessGtk to WebProcessSoup and reuse it in
      EFL port since all the code is soup-related. We now
      have a proper implementation for the WebProcess
      platform methods.
      
      * GNUmakefile.list.am:
      * PlatformEfl.cmake:
      * WebProcess/efl/WebProcessEfl.cpp: Removed.
      * WebProcess/efl/WebProcessMainEfl.cpp:
      (WebKit::WebProcessMainEfl): Enable soup cache for the soup session similarly to GTK port.
      * WebProcess/soup/WebProcessSoup.cpp: Renamed from Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp.
      (WebKit):
      (WebKit::getCacheDiskFreeSize):
      (WebKit::getMemorySize):
      (WebKit::WebProcess::platformSetCacheModel):
      (WebKit::WebProcess::platformClearResourceCaches):
      (WebKit::buildAcceptLanguages):
      (WebKit::setSoupSessionAcceptLanguage):
      (WebKit::languageChanged):
      (WebKit::WebProcess::platformInitializeWebProcess):
      (WebKit::WebProcess::platformTerminate):
      
      LayoutTests:
      
      Unskip several test cases that are now passing on
      WK2 EFL since WebProcess platform functions have been
      implemented.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      565b297e
    • barraclough@apple.com's avatar
      Merge prefix/postfix nodes · ff7867a9
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95898
      
      Reviewed by Geoff Garen.
      
      Simplify the AST.
      This will also mean we have access to m_subscriptHasAssignments when generating a prefix/postfix op applied to a bracket access.
      
      * bytecompiler/NodesCodegen.cpp:
      (JSC::PostfixNode::emitResolve):
          - was PostfixResolveNode::emitBytecode
      (JSC::PostfixNode::emitBracket):
          - was PostfixBracketNode::emitBytecode
      (JSC::PostfixNode::emitDot):
          - was PostfixDotNode::emitBytecode
      (JSC::PostfixNode::emitBytecode):
          - was PostfixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.
      (JSC::PrefixNode::emitResolve):
          - was PrefixResolveNode::emitBytecode
      (JSC::PrefixNode::emitBracket):
          - was PrefixBracketNode::emitBytecode
      (JSC::PrefixNode::emitDot):
          - was PrefixDotNode::emitBytecode
      (JSC::PrefixNode::emitBytecode):
          - was PrefixErrorNode::emitBytecode, call resolve/bracket/dot version as appropriate.
      * parser/ASTBuilder.h:
      (JSC::ASTBuilder::makePrefixNode):
          - Just makes a PrefixNode!
      (JSC::ASTBuilder::makePostfixNode):
          - Just makes a PostfixNode!
      * parser/NodeConstructors.h:
      (JSC::PostfixNode::PostfixNode):
          - Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.
      (JSC::PrefixNode::PrefixNode):
          - Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
      * parser/Nodes.h:
      (PostfixNode):
          - Added, merge of PostfixResolveNode/PostfixBracketNode/PostfixDotNode/PostfixErrorNode.
      (PrefixNode):
          - Added, merge of PrefixResolveNode/PrefixBracketNode/PrefixDotNode/PrefixErrorNode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff7867a9
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r127635. · a1a6b067
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/127635
      https://bugs.webkit.org/show_bug.cgi?id=95905
      
      breaks chromium win and mac build (Requested by bashi1 on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-05
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1a6b067
    • leoyang@rim.com's avatar
      [BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob · ab24a3f5
      leoyang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95897
      
      Reviewed by Antonio Gomes.
      
      Bail out the loop early if one of the not-rendered rectangle is
      not current regular render job.
      
      No behavior change, just code optimization.
      
      * Api/BackingStore.cpp:
      (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab24a3f5
    • commit-queue@webkit.org's avatar
      Make RenderStyle::colorIncludingFallback use private getters · 9633d976
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95863
      
      Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-09-05
      Reviewed by Eric Seidel.
      
      For readibility and maintanability reasons, it is better to use getters for
      visited* color variables than accessing them directly.
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::colorIncludingFallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9633d976
    • mhahnenberg@apple.com's avatar
      Remove use of JSCell::classInfoOffset() from tryCacheGetByID · 229ad85c
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95860
      
      Reviewed by Oliver Hunt.
      
      We should just do the indirection through the Structure instead.
      
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryCacheGetByID):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      229ad85c
    • ggaren@apple.com's avatar
      Throw exceptions when assigning to const in strict mode · 6e309822
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95894
      
      Reviewed by Oliver Hunt.
      
      Currently, this never happens; but it will start happening once the
      callee is a local const register. In this patch, there's no change in
      behavior.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded): Helper function
      for doing the throwing.
      * bytecompiler/BytecodeGenerator.h:
      
      * bytecompiler/NodesCodegen.cpp:
      (JSC::PostfixResolveNode::emitBytecode):
      (JSC::PrefixResolveNode::emitBytecode):
      (JSC::ReadModifyResolveNode::emitBytecode):
      (JSC::AssignResolveNode::emitBytecode): Call the helper function.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e309822
    • roger_fong@apple.com's avatar
    • mitz@apple.com's avatar
      Added expected results for this test from r127620 for the Mac port, which does not have · 9e9fd9a0
      mitz@apple.com authored
      OVERFLOW_SCROLLING enabled at this time.
      
      * platform/mac/compositing/overflow/overflow-with-touch-toggle-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e9fd9a0
    • commit-queue@webkit.org's avatar
      [BlackBerry] JavaScriptVariant can crash when operator= is called with itself · 3cd5c21b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95859
      
      Patch by Benjamin C Meyer <bmeyer@rim.com> on 2012-09-05
      Reviewed by George Staikos.
      
      * Api/JavaScriptVariant.cpp:
      (BlackBerry::WebKit::JavaScriptVariant::operator=):
      When JavaScriptVariant contains a string and operator= is
      called with itself the memory will be free'd in 'this' and
      then a copy will be attempted from 'that' resulting in a crash.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cd5c21b
    • ggaren@apple.com's avatar
      Refactored callee access in the DFG to support it in the general case · 3413a017
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95887
      
      Reviewed by Phil Pizlo and Gavin Barraclough.
      
      To support named function expressions, the DFG needs to understand the
      callee register being used in arbitrary expressions, and not just
      create_this.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::getDirect): 
      (JSC::DFG::ByteCodeParser::getCallee): Remap access to the callee register
      into a GetCallee node. Otherwise, we get confused and think we have a
      negatively indexed argument.
      
      (ByteCodeParser):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand): Inlining also
      needs to remap, but to the callee in the inline frame, and not the caller's
      callee.
      
      (JSC::DFG::ByteCodeParser::parseBlock): Since we support the callee in
      the general case now, there's no need to handle it in a special way for
      create_this.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3413a017
    • allan.jensen@nokia.com's avatar
      Ignore-metrics includes scroll offsets. · bf8fe35b
      allan.jensen@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95845
      
      Reviewed by Dirk Pranke.
      
      Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
      
      * Scripts/old-run-webkit-tests:
      (stripMetrics):
      * Scripts/webkitpy/layout_tests/port/driver.py:
      (DriverOutput):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf8fe35b
    • benjamin@webkit.org's avatar
      More fixes for String::operator+=() on Mac · efcd2e44
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95880
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-05
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      Followup for r127574, I forgot some use of strings.
      
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getShorthandValue): Use String builder to construct the shorthand.
      
      Source/WebKit/mac: 
      
      * WebView/WebRenderLayer.mm:
      (+[WebRenderLayer nameForLayer:]): Use StringBuilder to concatenate the class names
      efficiently.
      * WebView/WebView.mm:
      (+[WebView _decodeData:]): This is a legitimate use of String::append(), there
      is no other concatenation done on that string.
      
      Source/WebKit2: 
      
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::WebInspectorProxy::createInspectorPage): This is a legitimate use of append(),
      there is no other concatenation outside that branch.
      * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
      (WebKit::parseRFC822HeaderFields): Use string operators instead of +=.
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::userAgent): Another legitimate use of append().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efcd2e44
    • jamesr@google.com's avatar
      [chromium] Put webcore_platform_files in separate gyp target instead of... · b0aac188
      jamesr@google.com authored
      [chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
      https://bugs.webkit.org/show_bug.cgi?id=95876
      
      Reviewed by Tony Chang.
      
      This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
      path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0aac188
    • jamesr@google.com's avatar
      Unreviewed, rolling out r127629. · 8908a2fe
      jamesr@google.com authored
      http://trac.webkit.org/changeset/127629
      https://bugs.webkit.org/show_bug.cgi?id=95876
      
      Broke build
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8908a2fe
    • jamesr@google.com's avatar
      [chromium] Put webcore_platform_files in separate gyp target instead of... · 0b6d6c3d
      jamesr@google.com authored
      [chromium] Put webcore_platform_files in separate gyp target instead of relying on exclusion patterns
      https://bugs.webkit.org/show_bug.cgi?id=95876
      
      Reviewed by Tony Chang.
      
      This puts the list of WebCore/platform files in a webcore_platform_files gyp variable instead of filtering by
      path out of webcore_files. This simplifies the .gyp a bit and makes it possible to split this target up further.
      
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b6d6c3d
    • leoyang@rim.com's avatar
      [BlackBerry] Rotation and then reload causes less sized webpage (PR 190469) · fad5312a
      leoyang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95870
      
      Reviewed by George Staikos.
      Reviewed internally by Jacky Jiang.
      
      Use the new zoom to fit scale if the page was zoomed to fit initial scale
      When a page is reloaded the layout size may be changed. So the contents
      size on which the initial scale depends may be changed. Use the new initial
      scale in this case to make sure the page will be zoomed to correct scale.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fad5312a
    • commit-queue@webkit.org's avatar
      [EFL] Slider progress bar goes crazy with negative ranges · 69bb5ca1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95753
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-09-05
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Now the calculation of what the current value represents in terms
      of progress (from 0 to 1) is correctly done.
      
      Test: fast/forms/range/input-range-progress-indicator.html
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::paintThemePart):
      
      LayoutTests:
      
      Added ref test to check if rendering results of sliders using
      negative value ranges are coherent.
      
      * fast/forms/range/input-range-progress-indicator-expected.html: Added.
      * fast/forms/range/input-range-progress-indicator.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69bb5ca1
    • mhahnenberg@apple.com's avatar
      Remove use of JSCell::classInfoOffset() from virtualForThunkGenerator · e9678dec
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95821
      
      Reviewed by Oliver Hunt.
      
      We can replace the load of the ClassInfo from the object with a load from the Structure.
      
      * dfg/DFGThunks.cpp:
      (JSC::DFG::virtualForThunkGenerator):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9678dec
    • pilgrim@chromium.org's avatar
      [Chromium] Remove getRenderStyleForStrike from PlatformSupport · cfa06484
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95363
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/linux/WebFontInfo.h: Added.
      (WebKit):
      (WebFontInfo):
      * chromium/public/linux/WebFontRenderStyle.h: Added.
      (WebKit):
      
      Source/WebCore:
      
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
      (WebCore::FontPlatformData::operator==):
      (WebCore::FontPlatformData::getRenderStyleForStrike):
      (WebCore):
      (WebCore::FontPlatformData::querySystemForRenderStyle):
      * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
      (FontPlatformData):
      
      Source/WebKit/chromium:
      
      * public/linux/WebFontInfo.h:
      * public/linux/WebFontRenderStyle.h:
      * src/PlatformSupport.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfa06484
    • commit-queue@webkit.org's avatar
      Enable/disable composited scrolling based on overflow · 8076984b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95323
      
      Patch by Sami Kyostila <skyostil@google.com> on 2012-09-05
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      When an overflow:{auto,overlay} and -webkit-overflow-scrolling:touch
      element gains or loses overflow, we should correspondingly enable and
      disable composited scrolling depending on whether the element can be
      scrolled or not.
      
      The previous logic in RenderLayer::usesCompositedScrolling() already
      checked for actual overflow, but we also need to recompute the
      compositing requirements when the amount of overflow changes during
      layout. Additionally, layers using composited scrolling are marked as
      self-painting to ensure they are always promoted to composited layers
      when needed.
      
      Test: compositing/overflow/overflow-auto-with-touch-toggle.html
      
      Note that the behavior for maintaining a stacking context even without
      the presense of overflow is covered by platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateScrollInfoAfterLayout):
      (WebCore::RenderLayer::shouldBeSelfPaintingLayer):
      
      LayoutTests:
      
      Added a new test for making sure composited scrolling is enabled when overflow
      is introduced.
      
      Note that this test will pass only if OVERFLOW_SCROLLING is enabled.
      
      * compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
      * compositing/overflow/overflow-auto-with-touch-toggle.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8076984b
    • loislo@chromium.org's avatar
      Unreviewed: WebInspector: remove accidentally committed speed test. · 4bd04071
      loislo@chromium.org authored
      * tests/MemoryInstrumentationTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bd04071
    • zandobersek@gmail.com's avatar
      Unreviewed test fix. · b322397d
      zandobersek@gmail.com authored
      Including a plugin source file into the build that was added in r127595.
      
      * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b322397d
    • commit-queue@webkit.org's avatar
      [CSS Shaders] Update custom filter tests to use the new security model · 01c6aefd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95760
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-05
      Reviewed by Dirk Schulze.
      
      This patch updates the custom filter tests to not sample u_texture and not write
      to gl_FragColor. Now, the tests use the new security model by writing to
      css_MixColor and indirectly blending with the DOM element texture.
      
      This patch prepares us to remove direct DOM texture access via "u_texture":
      https://bugs.webkit.org/show_bug.cgi?id=93871
      
      * css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png:
      * css3/filters/custom/custom-filter-shader-cache-expected.png:
      * css3/filters/custom/custom-filter-shader-cache.html:
          Use the CSS mix function with the updated color-offset.fs.
      * css3/filters/custom/effect-color-check-expected.png:
      * css3/filters/custom/effect-color-check.html:
          Use the CSS mix function with the updated color-fill.fs.
      * css3/filters/custom/effect-custom-combined-missing-expected.png:
      * css3/filters/custom/effect-custom-combined-missing.html:
          Use the CSS mix function with the updated color-offset.fs.
      * css3/filters/custom/effect-custom-expected.png:
      * css3/filters/custom/effect-custom-parameters-expected.png:
      * css3/filters/custom/effect-custom-parameters.html:
          Use the mix-color.fs shader instead of color-offset-parameters.fs.
      * css3/filters/custom/effect-custom.html:
          Use the CSS mix function with the updated color-offset.fs.
      * css3/filters/custom/filter-repaint-custom-clipped-expected.png:
      * css3/filters/custom/filter-repaint-custom-clipped.html:
          Use the mix-color.fs shader instead of color-add.fs.
      * css3/filters/custom/filter-repaint-custom-expected.png:
      * css3/filters/custom/filter-repaint-custom-rotated-expected.png:
      * css3/filters/custom/filter-repaint-custom-rotated.html:
          Use the mix-color.fs shader instead of color-add.fs. Fix a small typo in a comment.
      * css3/filters/custom/filter-repaint-custom.html:
          Use the mix-color.fs shader instead of color-add.fs.
      * css3/filters/custom/invalid-custom-filter-shader.html:
          Use the CSS mix function with the updated color-offset.fs.
      * css3/filters/custom/missing-custom-filter-shader-expected.png:
      * css3/filters/custom/missing-custom-filter-shader.html:
          Use the CSS mix function with the updated color-offset.fs.
      * css3/filters/resources/color-add.fs:
          Removed. The mix-color.fs shader can perform this shader's function.
      * css3/filters/resources/color-fill.fs:
          Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
          to gl_FragColor.
      * css3/filters/resources/color-offset-parameters.fs:
          Removed. The mix-color.fs shader can perform this shader's function.
      * css3/filters/resources/color-offset.fs:
          Rewrote this shader to write to css_MixColor instead of sampling u_texture and writing
          to gl_FragColor.
      * platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-custom-expected.png:
      * platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
      * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-clipped-expected.png:
      * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-expected.png:
      * platform/chromium-mac/css3/filters/custom/filter-repaint-custom-rotated-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01c6aefd
    • ap@apple.com's avatar
      [WK2] Make visited link tracking work in multi-process mode · 02393d96
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=95869
      
              Reviewed by Dan Bernstein.
      
              * UIProcess/VisitedLinkProvider.h:
              * UIProcess/VisitedLinkProvider.cpp:
              (WebKit::VisitedLinkProvider::VisitedLinkProvider): m_webProcessHasVisitedLinkState
              was making no sense in multi-process world, so it was let go.
              (WebKit::VisitedLinkProvider::processDidFinishLaunching): Track new processes.
              (WebKit::VisitedLinkProvider::processDidClose): Clean up pointers that are going
              to become stale.
              (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added comments. Fixed
              a bug where we would churn table size in some cases. Added debug logging in failure
              case. Re-implemented messaging code to work with multiple web processes.
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::processDidFinishLaunching): Pass process proxy pointer to
              m_visitedLinkProvider, as it now needs to track processes.
              (WebKit::WebContext::disconnectProcess): Ditto. Also re-enabled visited link provider
              cleanup in multi-process mode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02393d96
    • mifenton@rim.com's avatar
      [BlackBerry] PlatformKeyboardEvent::getCurrentModifierState should initialize values. · 865e5e04
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95773
      
      Reviewed by Rob Buis.
      
      Properly initialize the passed variables even
      though we haven't implemented the modifier state
      to ensure the values are deterministic.
      
      * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      865e5e04
    • tommyw@google.com's avatar
      MediaStream API: Add the local and remote description functionality to RTCPeerConnection · 7c43e5af
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95839
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      * Platform.gypi:
      * chromium/public/WebRTCPeerConnectionHandler.h:
      (WebKit):
      (WebRTCPeerConnectionHandler):
      * chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
      (WebCore):
      (WebKit):
      (WebRTCVoidRequest):
      (ExtraData):
      (WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
      (WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
      (WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
      (WebKit::WebRTCVoidRequest::operator=):
      (WebKit::WebRTCVoidRequest::isNull):
      
      Source/WebCore:
      
      As well as adding the local/remote descriptions stuff, I removed the source attribute from
      RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.
      
      Tests: fast/mediastream/RTCPeerConnection-localDescription.html
             fast/mediastream/RTCPeerConnection-remoteDescription.html
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCErrorCallback.h:
      (RTCErrorCallback):
      * Modules/mediastream/RTCErrorCallback.idl:
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::createOffer):
      (WebCore::RTCPeerConnection::setLocalDescription):
      (WebCore):
      (WebCore::RTCPeerConnection::localDescription):
      (WebCore::RTCPeerConnection::setRemoteDescription):
      (WebCore::RTCPeerConnection::remoteDescription):
      * Modules/mediastream/RTCPeerConnection.h:
      (WebCore):
      (RTCPeerConnection):
      * Modules/mediastream/RTCPeerConnection.idl:
      * Modules/mediastream/RTCSessionDescriptionCallback.h:
      (RTCSessionDescriptionCallback):
      * Modules/mediastream/RTCSessionDescriptionCallback.idl:
      * Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
      (WebCore::RTCSessionDescriptionRequestImpl::create):
      (WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
      (WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
      (WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
      (WebCore::RTCSessionDescriptionRequestImpl::clear):
      * Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
      (RTCSessionDescriptionRequestImpl):
      * Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.
      (WebCore):
      (WebCore::RTCVoidRequestImpl::create):
      (WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
      (WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
      (WebCore::RTCVoidRequestImpl::requestSucceeded):
      (WebCore::RTCVoidRequestImpl::requestFailed):
      (WebCore::RTCVoidRequestImpl::stop):
      (WebCore::RTCVoidRequestImpl::clear):
      * Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.
      (WebCore):
      (RTCVoidRequestImpl):
      * WebCore.gypi:
      * platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
      (WebKit):
      (WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
      (WebKit::WebRTCVoidRequest::assign):
      (WebKit::WebRTCVoidRequest::reset):
      (WebKit::WebRTCVoidRequest::requestSucceeded):
      (WebKit::WebRTCVoidRequest::requestFailed):
      (ExtraDataContainer):
      (WebKit::ExtraDataContainer::ExtraDataContainer):
      (WebKit::ExtraDataContainer::extraData):
      (WebKit::WebRTCVoidRequest::extraData):
      (WebKit::WebRTCVoidRequest::setExtraData):
      * platform/mediastream/RTCPeerConnectionHandler.cpp:
      (RTCPeerConnectionHandlerDummy):
      (WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
      (WebCore):
      (WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
      (WebCore::RTCPeerConnectionHandlerDummy::localDescription):
      (WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):
      * platform/mediastream/RTCPeerConnectionHandler.h:
      (WebCore):
      (RTCPeerConnectionHandler):
      * platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.
      (WebCore):
      (RTCVoidRequest):
      (ExtraData):
      (WebCore::RTCVoidRequest::ExtraData::~ExtraData):
      (WebCore::RTCVoidRequest::~RTCVoidRequest):
      (WebCore::RTCVoidRequest::extraData):
      (WebCore::RTCVoidRequest::setExtraData):
      (WebCore::RTCVoidRequest::RTCVoidRequest):
      * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
      (WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
      (WebCore):
      (WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
      (WebCore::RTCPeerConnectionHandlerChromium::localDescription):
      (WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):
      * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
      (RTCPeerConnectionHandlerChromium):
      
      Tools:
      
      In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
      up the task definitions a bit. There was no need to have them in the header file.
      
      * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
      (RTCSessionDescriptionRequestSuccededTask):
      (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
      (RTCSessionDescriptionRequestFailedTask):
      (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
      (RTCVoidRequestTask):
      (RTCVoidRequestTask::RTCVoidRequestTask):
      (MockWebRTCPeerConnectionHandler::createOffer):
      (MockWebRTCPeerConnectionHandler::setLocalDescription):
      (MockWebRTCPeerConnectionHandler::setRemoteDescription):
      (MockWebRTCPeerConnectionHandler::localDescription):
      (MockWebRTCPeerConnectionHandler::remoteDescription):
      * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
      (MockWebRTCPeerConnectionHandler):
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-createOffer.html:
      * fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
      * fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
      * fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
      * fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c43e5af