1. 23 Sep, 2011 40 commits
    • oliver@apple.com's avatar
      PutScopedVar nodes should report that it has a var number · 273cb6ac
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68721
      
      Reviewed by Anders Carlsson.
      
      Another assertion fix.
      
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasVarNumber):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      273cb6ac
    • andersca@apple.com's avatar
      Move WebHitTestResult files to Shared/ in the Xcode project · 3a8d816a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68718
      
      Reviewed by Sam Weinig.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a8d816a
    • jchaffraix@webkit.org's avatar
      Redrawing dirty parts of a large table is very slow · 38e74af0
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64546
      
      Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Move CollapsedBorderValues into RenderTable.h.
      Calculate collapsed borders only once and re-use during paintObject().
      Invalidate cache when cell, row, row group, col, col group or table border is changed.
      
      Tests: fast/table/border-collapsing/cached-cell-append.html
             fast/table/border-collapsing/cached-cell-remove.html
             fast/table/border-collapsing/cached-change-cell-border-color.html
             fast/table/border-collapsing/cached-change-cell-border-width.html
             fast/table/border-collapsing/cached-change-col-border-color.html
             fast/table/border-collapsing/cached-change-col-border-width.html
             fast/table/border-collapsing/cached-change-colgroup-border-color.html
             fast/table/border-collapsing/cached-change-colgroup-border-width.html
             fast/table/border-collapsing/cached-change-row-border-color.html
             fast/table/border-collapsing/cached-change-row-border-width.html
             fast/table/border-collapsing/cached-change-table-border-color.html
             fast/table/border-collapsing/cached-change-table-border-width.html
             fast/table/border-collapsing/cached-change-tbody-border-color.html
             fast/table/border-collapsing/cached-change-tbody-border-width.html
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::RenderTable):
      (WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
      (WebCore::RenderTable::layout): Invalidate cache if layout changed.
      (WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
      (WebCore::RenderTable::paintObject): Use cached collapsed borders.
      * rendering/RenderTable.h:
      (WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
      (WebCore::RenderTable::currentBorderValue): Rename to use word "value".
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.
      
      Rename to use word "value".
      (WebCore::addBorderStyle):
      (WebCore::RenderTableCell::collectBorderValues):
      (WebCore::compareBorderValuesForQSort):
      (WebCore::RenderTableCell::sortBorderValues):
      (WebCore::RenderTableCell::paintCollapsedBorder):
      * rendering/RenderTableCell.h:
      
      If border changed, invalidate cache.
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::styleDidChange):
      * rendering/RenderTableCol.h:
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::styleDidChange):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::styleDidChange):
      
      LayoutTests:
      
      Tests for invalidating collapsed borders cache.
      
      * fast/table/border-collapsing/cached-cell-append-expected.png: Added.
      * fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
      * fast/table/border-collapsing/cached-cell-append.html: Added.
      * fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
      * fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
      * fast/table/border-collapsing/cached-cell-remove.html: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-col-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-col-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-row-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-row-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-table-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-table-border-width.html: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
      * fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38e74af0
    • oliver@apple.com's avatar
      Add a bunch of unhandled node types to the propagator · bb4455db
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68716
      
      Reviewed by Darin Adler.
      
      Remove the ASSERT_NOT_REACHED() default for debug builds in the
      prediction propagator, this way unhandled nodes will just cause
      compile time failures rather than failing at some point in the
      future.
      
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb4455db
    • mihaip@chromium.org's avatar
      update layout_tests to account for new default of use_skia=1 · b99a6dfc
      mihaip@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68698
      
      Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
      from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
      (Chromium-on-Mac now uses the Skia graphics library instead of
      Core Graphics).
      
      Also updates layout_test code to work with that change.
      
      Patch by Elliot Poger <epoger@google.com> on 2011-09-23
      Reviewed by Mihai Parparita.
      
      Source/WebKit/chromium:
      
      * DEPS:
      
      Tools:
      
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b99a6dfc
    • mhahnenberg@apple.com's avatar
      Add static version of JSCell::visitChildren · 982c9ea2
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68404
      
      Reviewed by Darin Adler.
      
      .: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * Source/autotools/symbols.filter:
      
      Source/JavaScriptCore: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * API/JSCallbackObject.h:
      (JSC::JSCallbackObject::visitChildrenVirtual):
      (JSC::JSCallbackObject::visitChildren):
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::visitChildrenVirtual):
      (JSC::DebuggerActivation::visitChildren):
      * debugger/DebuggerActivation.h:
      * heap/MarkStack.cpp:
      (JSC::SlotVisitor::visitChildren):
      (JSC::SlotVisitor::drain):
      * runtime/Arguments.cpp:
      (JSC::Arguments::visitChildrenVirtual):
      (JSC::Arguments::visitChildren):
      * runtime/Arguments.h:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::visitChildrenVirtual):
      (JSC::EvalExecutable::visitChildren):
      (JSC::ProgramExecutable::visitChildrenVirtual):
      (JSC::ProgramExecutable::visitChildren):
      (JSC::FunctionExecutable::visitChildrenVirtual):
      (JSC::FunctionExecutable::visitChildren):
      * runtime/Executable.h:
      * runtime/GetterSetter.cpp:
      (JSC::GetterSetter::visitChildrenVirtual):
      (JSC::GetterSetter::visitChildren):
      * runtime/GetterSetter.h:
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::visitChildrenVirtual):
      (JSC::JSActivation::visitChildren):
      * runtime/JSActivation.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::visitChildrenVirtual):
      (JSC::JSArray::visitChildren):
      * runtime/JSArray.h:
      * runtime/JSBoundFunction.cpp:
      (JSC::JSBoundFunction::visitChildrenVirtual):
      (JSC::JSBoundFunction::visitChildren):
      * runtime/JSBoundFunction.h:
      * runtime/JSCell.h:
      (JSC::JSCell::visitChildrenVirtual):
      (JSC::JSCell::visitChildren):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::visitChildrenVirtual):
      (JSC::JSFunction::visitChildren):
      * runtime/JSFunction.h:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::visitChildrenVirtual):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::visitChildrenVirtual):
      (JSC::JSObject::visitChildren):
      * runtime/JSObject.h:
      (JSC::JSObject::visitChildrenDirect):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::visitChildrenVirtual):
      (JSC::JSPropertyNameIterator::visitChildren):
      * runtime/JSPropertyNameIterator.h:
      * runtime/JSStaticScopeObject.cpp:
      (JSC::JSStaticScopeObject::visitChildrenVirtual):
      (JSC::JSStaticScopeObject::visitChildren):
      * runtime/JSStaticScopeObject.h:
      * runtime/JSWrapperObject.cpp:
      (JSC::JSWrapperObject::visitChildrenVirtual):
      (JSC::JSWrapperObject::visitChildren):
      * runtime/JSWrapperObject.h:
      * runtime/NativeErrorConstructor.cpp:
      (JSC::NativeErrorConstructor::visitChildrenVirtual):
      (JSC::NativeErrorConstructor::visitChildren):
      * runtime/NativeErrorConstructor.h:
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::visitChildrenVirtual):
      (JSC::RegExpObject::visitChildren):
      * runtime/RegExpObject.h:
      * runtime/ScopeChain.cpp:
      (JSC::ScopeChainNode::visitChildrenVirtual):
      (JSC::ScopeChainNode::visitChildren):
      * runtime/ScopeChain.h:
      * runtime/Structure.cpp:
      (JSC::Structure::visitChildrenVirtual):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      * runtime/StructureChain.cpp:
      (JSC::StructureChain::visitChildrenVirtual):
      (JSC::StructureChain::visitChildren):
      * runtime/StructureChain.h:
      
      Source/JavaScriptGlue: 
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * UserObjectImp.cpp:
      (UserObjectImp::visitChildrenVirtual):
      (UserObjectImp::visitChildren):
      * UserObjectImp.h:
      
      Source/WebCore: 
      
      No new tests.
      
      In this patch we just extract the bodies of the virtual visitChildren methods
      throughout the JSCell inheritance hierarchy out into static methods, which are 
      now called from the virtual methods.  This is an intermediate step in trying to 
      move the virtual-ness of visitChildren into our own custom vtable stored in 
      ClassInfo.  We need to convert the methods to static methods in order to be 
      able to more easily store and refer to them in our custom vtable since normal 
      member methods store some implicit information in their types, making it 
      impossible to store them generically in ClassInfo.
      
      * WebCore.exp.in:
      * bindings/js/JSAttrCustom.cpp:
      (WebCore::JSAttr::visitChildrenVirtual):
      (WebCore::JSAttr::visitChildren):
      * bindings/js/JSAudioContextCustom.cpp:
      (WebCore::JSAudioContext::visitChildrenVirtual):
      (WebCore::JSAudioContext::visitChildren):
      * bindings/js/JSCSSRuleCustom.cpp:
      (WebCore::JSCSSRule::visitChildrenVirtual):
      (WebCore::JSCSSRule::visitChildren):
      * bindings/js/JSCSSStyleDeclarationCustom.cpp:
      (WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
      (WebCore::JSCSSStyleDeclaration::visitChildren):
      * bindings/js/JSCanvasRenderingContextCustom.cpp:
      (WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
      (WebCore::JSCanvasRenderingContext::visitChildren):
      * bindings/js/JSDOMGlobalObject.cpp:
      (WebCore::JSDOMGlobalObject::visitChildrenVirtual):
      (WebCore::JSDOMGlobalObject::visitChildren):
      * bindings/js/JSDOMGlobalObject.h:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::visitChildrenVirtual):
      (WebCore::JSDOMWindow::visitChildren):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::visitChildrenVirtual):
      (WebCore::JSDOMWindowShell::visitChildren):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
      (WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
      (WebCore::JSJavaScriptAudioNode::visitChildren):
      * bindings/js/JSMessageChannelCustom.cpp:
      (WebCore::JSMessageChannel::visitChildrenVirtual):
      (WebCore::JSMessageChannel::visitChildren):
      * bindings/js/JSMessagePortCustom.cpp:
      (WebCore::JSMessagePort::visitChildrenVirtual):
      (WebCore::JSMessagePort::visitChildren):
      * bindings/js/JSNamedNodeMapCustom.cpp:
      (WebCore::JSNamedNodeMap::visitChildrenVirtual):
      (WebCore::JSNamedNodeMap::visitChildren):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::JSNode::visitChildrenVirtual):
      (WebCore::JSNode::visitChildren):
      * bindings/js/JSNodeFilterCustom.cpp:
      (WebCore::JSNodeFilter::visitChildrenVirtual):
      (WebCore::JSNodeFilter::visitChildren):
      * bindings/js/JSNodeIteratorCustom.cpp:
      (WebCore::JSNodeIterator::visitChildrenVirtual):
      (WebCore::JSNodeIterator::visitChildren):
      * bindings/js/JSSVGElementInstanceCustom.cpp:
      (WebCore::JSSVGElementInstance::visitChildrenVirtual):
      (WebCore::JSSVGElementInstance::visitChildren):
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorker::visitChildrenVirtual):
      (WebCore::JSSharedWorker::visitChildren):
      * bindings/js/JSStyleSheetCustom.cpp:
      (WebCore::JSStyleSheet::visitChildrenVirtual):
      (WebCore::JSStyleSheet::visitChildren):
      * bindings/js/JSTreeWalkerCustom.cpp:
      (WebCore::JSTreeWalker::visitChildrenVirtual):
      (WebCore::JSTreeWalker::visitChildren):
      * bindings/js/JSWebGLRenderingContextCustom.cpp:
      (WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
      (WebCore::JSWebGLRenderingContext::visitChildren):
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::visitChildrenVirtual):
      (WebCore::JSWorkerContext::visitChildren):
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::visitChildrenVirtual):
      (WebCore::JSXMLHttpRequest::visitChildren):
      * bindings/js/JSXPathResultCustom.cpp:
      (WebCore::JSXPathResult::visitChildrenVirtual):
      (WebCore::JSXPathResult::visitChildren):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObj::visitChildrenVirtual):
      (WebCore::JSTestObj::visitChildren):
      * bindings/scripts/test/JS/JSTestObj.h:
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeObject::visitChildren):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
      (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
      * bridge/qt/qt_runtime.h:
      * workers/WorkerContext.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      982c9ea2
    • andersca@apple.com's avatar
      Axe WebImageRendererFactory · 6504077a
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68715
      
      Reviewed by Darin Adler.
      
      ../..: 
      
      Remove WebImageRendererFactory.m from the Xcode project.
      
      * WebKit.xcodeproj/project.pbxproj:
      
      ../../mac: 
      
      Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
      
      * WebCoreSupport/WebImageRendererFactory.m: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6504077a
    • andersca@apple.com's avatar
      Add OVERRIDE to a bunch of virtual member functions on clients · 2fccbb0f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68712
      
      Reviewed by Sam Weinig.
      
      ../..: 
      
      * WebKit.xcodeproj/project.pbxproj:
      
      ../../mac: 
      
      * Configurations/Base.xcconfig:
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebContextMenuClient.h:
      * WebCoreSupport/WebDeviceOrientationClient.h:
      * WebCoreSupport/WebDragClient.h:
      * WebCoreSupport/WebEditorClient.h:
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameNetworkingContext.h:
      * WebCoreSupport/WebGeolocationClient.h:
      * WebCoreSupport/WebIconDatabaseClient.h:
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebPlatformStrategies.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fccbb0f
    • oliver@apple.com's avatar
      Node propagation doesn't handle PutScopedVar · 5bc8af1d
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68713
      
      Reviewed by Sam Weinig.
      
      This was causing assertion failures.
      
      * dfg/DFGPropagator.cpp:
      (JSC::DFG::Propagator::propagateNodePredictions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bc8af1d
    • jochen@chromium.org's avatar
      Clarify wording in cross origin XSL tests and enable on all platforms · 63184e94
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68683
      
      The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.
      
      Reviewed by Alexey Proskuryakov.
      
      * http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * http/tests/security/cross-origin-xsl-BLOCKED.html:
      * http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
      * platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/gtk/Skipped:
      * platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
      * platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
      * platform/wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63184e94
    • andersca@apple.com's avatar
      Make sure to define OVERRIDE and FINAL for older builds of clang. · 1bf95290
      andersca@apple.com authored
      * wtf/Compiler.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bf95290
    • mihaip@chromium.org's avatar
      Mark two more tests as flaky. · 995b46f5
      mihaip@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      995b46f5
    • barraclough@apple.com's avatar
      Implement op_resolve_global in the DFG JIT · 014d4beb
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68704
      
      Reviewed by Oliver Hunt.
      
      This is performance neutral, but increases coverage.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::ByteCodeParser):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::hasIdentifier):
      (JSC::DFG::Node::resolveInfoIndex):
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      014d4beb
    • mario@webkit.org's avatar
      [GTK] Remove extra space at the beginning of the last line. · 2f92fa4a
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68710
      
      Reviewed by Gustavo Noronha Silva.
      
      * platform/network/soup/SocketStreamHandleSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f92fa4a
    • mihaip@chromium.org's avatar
      Mark a test as flaky. · 8445cc8f
      mihaip@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8445cc8f
    • mario@webkit.org's avatar
      2011-09-23 Mario Sanchez Prada <msanchez@igalia.com> · 788e91d8
      mario@webkit.org authored
              [GTK] Fix coding style issues in ResourceRequestSoup.cpp
              https://bugs.webkit.org/show_bug.cgi?id=68707
      
              Reviewed by Xan Lopez.
      
              This patch fixes some issues as reported by check-webkit-style.
      
              * platform/network/soup/ResourceRequestSoup.cpp:
              (WebCore::ResourceRequest::updateFromSoupMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788e91d8
    • andersca@apple.com's avatar
      Add OVERRIDE to overrides of virtual member functions in client classes · b4a311d2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68702
      
      Reviewed by Darin Adler.
      
      Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
      and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
      WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
      they have been removed from their respective base classes.
              
      * Configurations/Base.xcconfig:
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebContextMenuClient.h:
      * WebProcess/WebCoreSupport/WebDatabaseManager.h:
      * WebProcess/WebCoreSupport/WebDragClient.h:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      * WebProcess/WebCoreSupport/WebGeolocationClient.h:
      * WebProcess/WebCoreSupport/WebInspectorClient.h:
      * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
      * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
      * WebProcess/WebCoreSupport/WebPopupMenu.h:
      * WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
      * win/WebKit2Common.vsprops:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4a311d2
    • mrowe@apple.com's avatar
      Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h. · 381747ac
      mrowe@apple.com authored
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      381747ac
    • mrowe@apple.com's avatar
      Fix the build. · 8b9084a9
      mrowe@apple.com authored
      * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
      the WTF namespace.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b9084a9
    • ademar.reis@openbossa.org's avatar
      Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit · 27450a40
      ademar.reis@openbossa.org authored
      Include MSVC2010 in the list of compilers where incremental
      build is disabled (INCREMENTAL:NO).
      
      Change suggested by Simo Falt <simo.falt@nokia.com>, already present
      in the Qt-4.8 repository where the problem was identified.
      
      * WebCore.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27450a40
    • loislo@chromium.org's avatar
      Unreviewed. Normalize test names. · 0ebfa91e
      loislo@chromium.org authored
      * inspector/performance/resources/first-open-elements.html:
      * inspector/performance/resources/first-open-resources.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ebfa91e
    • darin@apple.com's avatar
      Try to fix warning seen in some 32-bit builds. · cd6ab6a4
      darin@apple.com authored
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::backgroundRectAdjustedForBleedAvoidance):
      Use an explicit cast for the conversion from a double to a LayoutUnit.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6ab6a4
    • andersca@apple.com's avatar
      We should add support for OVERRIDE and FINAL annotations · b6bc2135
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68654
      
      Reviewed by David Hyatt.
      
      Add OVERRIDE and FINAL macros for compilers that support them.
      
      * wtf/Compiler.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6bc2135
    • yael.aharon@nokia.com's avatar
      Fix typo in file name from http://trac.webkit.org/changeset/95813. · 101104f8
      yael.aharon@nokia.com authored
      Unreviewed.
      
      * platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
      * platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      101104f8
    • yael.aharon@nokia.com's avatar
      Rebaseline after http://trac.webkit.org/changeset/95799 · f4b90881
      yael.aharon@nokia.com authored
      Unreviewed.
      
      * platform/mac-wk2/media/video-playing-and-pause-expected.txt: Added.
      * platform/mac/media/video-playing-and-pause-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4b90881
    • yael.aharon@nokia.com's avatar
      Rebaseline after http://trac.webkit.org/changeset/95799 · 2e764ec6
      yael.aharon@nokia.com authored
      Unreviewed.
      
      * platform/gtk/media/video-playing-and-pause-actual.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e764ec6
    • xan@webkit.org's avatar
      2011-09-23 Xan Lopez <xlopez@igalia.com> · 2c4a6cc3
      xan@webkit.org authored
              [GTK] Skip crashing test fast/workers/storage/interrupt-database.html
              https://bugs.webkit.org/show_bug.cgi?id=68700
      
              Unreviewed.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c4a6cc3
    • vsevik@chromium.org's avatar
      Web Inspector: Clicking on error doesn't point on the correct line if user searched something · 1d437fed
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68627
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/front-end/SearchController.js:
      (WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
      * inspector/front-end/inspector.js:
      (WebInspector._showAnchorLocationInPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d437fed
    • vsevik@chromium.org's avatar
      Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one. · d73fec12
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68631
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: http/tests/inspector/styles/styles-redirected-css.html
      
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::InspectorStyleSheet::resourceStyleSheetText):
      
      LayoutTests:
      
      * http/tests/inspector/elements-test.js:
      (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
      (initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
      (initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):
      * http/tests/inspector/styles/resources/styles-redirected-css.css: Added.
      (div):
      * http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
      * http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
      * http/tests/inspector/styles/styles-redirected-css.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d73fec12
    • vsevik@chromium.org's avatar
      Web Inspector: XHRs requests with the same url as main resource should have correct category. · f915e783
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68646
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html
      
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didReceiveResponse):
      
      LayoutTests:
      
      * http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
      * http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f915e783
    • jesus@webkit.org's avatar
      [Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead() · af391531
      jesus@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68696
      
      Reviewed by Andreas Kling.
      
      Instead of connecting signals and calling QtFileDownloader::onReadyRead()
      on its constructor, QtFileDownloader will now handle this in start().
      
      * WebProcess/Downloads/qt/DownloadQt.cpp:
      (WebKit::Download::start):
      * WebProcess/Downloads/qt/QtFileDownloader.cpp:
      (WebKit::QtFileDownloader::QtFileDownloader):
      (WebKit::QtFileDownloader::start):
      * WebProcess/Downloads/qt/QtFileDownloader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af391531
    • bulach@chromium.org's avatar
      [chromium] Update expectation for pservers-grad-14-b.svg on snowleopard · 77de4ff4
      bulach@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68697
      
      Unreviewed rebaseline.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77de4ff4
    • vsevik@chromium.org's avatar
      Web Inspector: Add context menu action to navigate from resources panel resource to network panel. · 21504e64
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68657
      
      Reviewed by Yury Semikhatsky.
      
      * English.lproj/localizedStrings.js:
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkPanel.prototype.showAnchorLocation):
      (WebInspector.NetworkPanel.prototype.revealAndHighlightResource):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
      (WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
      * inspector/front-end/inspector.js:
      (WebInspector.openInNetworkPanelLabel):
      (WebInspector.openRequestInNetworkPanel):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21504e64
    • commit-queue@webkit.org's avatar
      [Gtk] Title attribute is not respected on option elements. · 2a36a479
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68615
      
      Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
      Reviewed by Martin Robinson.
      
      Set tooltip on PopupMenuGtk items created from GtkActions.
      
      * platform/gtk/GtkPopupMenu.cpp:
      (WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()
          to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text
          from client when creating a GtkAction.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a36a479
    • yael.aharon@nokia.com's avatar
      [Qt][Gtk] Wrong state when pausing a video in the "playing" event handler · 01f5bb70
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=68589
      
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      Test: media/video-playing-and-pause.html
      
      As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
      in MediaPlayerGstreamerPrivate::paused().
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::paused):
      
      LayoutTests:
      
      * media/video-playing-and-pause.html: Added.
      * media/video-paint-test.js:
      * platform/qt/media/video-playing-and-pause-expected.txt: Added.
      * platform/qt/media/video-playing-and-pause-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01f5bb70
    • bulach@chromium.org's avatar
      [chromium, gtk, qt] Rebaseline following r95726 · 08f266fa
      bulach@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68694
      
      Unreviewed rebaseline.
      
      * css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt.
      * css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt.
      * platform/chromium/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
      * platform/chromium/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
      * platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
      * platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08f266fa
    • podivilov@chromium.org's avatar
      Web Inspector: skip overlapping scripts when displaying concatenated content. · d40176bb
      podivilov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68144
      
      Source/WebCore:
      
      Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/SourceFile.js:
      (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
      (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
      
      LayoutTests:
      
      Reviewed by Pavel Feldman.
      
      * inspector/debugger/content-providers-expected.txt:
      * inspector/debugger/content-providers.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d40176bb
    • xan@webkit.org's avatar
      2011-09-23 Xan Lopez <xlopez@igalia.com> · 10f08ccb
      xan@webkit.org authored
              [GTK] Rebaseline following r95745, r95725
      
              Unreviewed rebaseline.
      
              * platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10f08ccb
    • bulach@chromium.org's avatar
      [chromium] Rebaseline following r95745, r95725 · 34cd4397
      bulach@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68685
      
      Unreviewed rebaseline.
      
      * platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
      * platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
      * platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
      * platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
      * platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34cd4397
    • loislo@chromium.org's avatar
      Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel. · 49cb35ce
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=68312
      
      Reviewed by Yury Semikhatsky.
      
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel.prototype._createFileSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49cb35ce