1. 29 Mar, 2007 17 commits
    • ggaren's avatar
      LayoutTests: · 2663f9a7
      ggaren authored
              Reviewed by Beth Dakin.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
      
              * plugins/destroy-stream-twice-expected.txt: Added.
              * plugins/destroy-stream-twice.html: Added.
      
      WebKit:
      
              Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
              every time you run it.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      WebKitTools:
      
              Reviewed by Beth Dakin.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              Added hasStream property and destroyStream function, used by layout test.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginGetProperty):
              (pluginInvoke):
              (pluginAllocate):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_NewStream):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2663f9a7
    • bdakin's avatar
      Rubber-stamped by Adam. · 4b1e6748
      bdakin authored
              Keep OpenSource building.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterface.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b1e6748
    • pyeh's avatar
      <rdar://problem/4918397> Exception raise inspecting note contents in the background · aa8721f0
      pyeh authored
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject subrole]):
              (-[WebCoreAXObject title]):
      	Check that attachment supports the attribute before requesting it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8721f0
    • justing's avatar
      I forgot add this expected result in my previous checkin. · 3b45d4ce
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b45d4ce
    • bdakin's avatar
      Reviewed by Brady. · 88c795d7
      bdakin authored
              Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text 
              blinks when mouse is moved, and is invisible otherwise
      
              -and-
      
              <rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround 
              methodology
      
              The fix for the first bug is to compare against the bundle 
              identifiers for Adobe Reader and the non-Pro Adobe Acrobat in 
              addition to Adobe Acrobat Pro. The fix for the second bug is to 
              check the version number of Acrobat/Reader through 
              WebKitSystemInterface instead of checking which version of WebKit 
              it has been linked against.
      
              * English.lproj/StringsNotToBeLocalized.txt: Two new bundle 
              identifiers.
              * Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
              * WebView/WebView.mm:
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88c795d7
    • justing's avatar
      LayoutTests: · b7701503
      justing authored
              Reviewed by john
      
              <rdar://problem/5032066> <Delete> should work between To Dos
      
              Demonstrates the fix:
              * editing/deleting/5032066-expected.checksum: Added.
              * editing/deleting/5032066-expected.png: Added.
              * editing/deleting/5032066-expected.txt: Added.
              * editing/deleting/5032066.html: Added.
              
              Fixed:
              * editing/deleting/delete-block-table-expected.checksum:
              * editing/deleting/delete-block-table-expected.png:
              * editing/deleting/delete-block-table-expected.txt:
              
              shouldInsertNode:... now being called during moves:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/nsresponder-indent-expected.txt:
              * editing/execCommand/outdent-selection-expected.txt:
              * editing/execCommand/queryCommandState-01-expected.txt:
              * editing/execCommand/remove-list-1-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-item-1-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * editing/pasteboard/interchange-newline-1-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-1-expected.txt:
              * editing/pasteboard/merge-end-2-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-4-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-borders-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-008-expected.txt:
              * editing/pasteboard/paste-text-009-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/smart-paste-001-expected.txt:
              * editing/pasteboard/smart-paste-002-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-boundary-005-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5032066> Delete should work between ToDos
              
              Stop selecting the table when the user attempts to delete
              the line break just after it, instead, extend the selection
              into the last table cell.
              Let deletion merge content into table cells (as long as 
              its not from another table cell).  
              Start calling shouldInsertNode:replacingDOMRange:givenAction: 
              when moving content with moveParagraphs, so that Mail can 
              modify content before it is moved into a ToDo during a delete.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Ask the
              delegate before performing the move.  This will let Mail
              prevent styles from entering a ToDo.
              Added a FIXME about adding a new WebViewInsertAction
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData):
              Allow merging into table cells from content not in a table.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              Don't select the table when extending by character/word from
              just before it.  This code was here to make it easier to select
              tables in order to delete them, but the deletion UI makes it 
              largely unnecessary.
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              Ditto.
              * editing/TypingCommand.cpp:
              (WebCore::isFirstPositionAfterTable): Added.
              (WebCore::isLastPositionBeforeTable): Ditto.
              (WebCore::TypingCommand::deleteKeyPressed): When pressing
              the delete key with a caret at the beginning of a paragraph
              just after a table, move the paragraph into the last table
              cell.
              Do not do this if it would mean moving a block table.
              Removed some old irrelevant comments.
              * editing/htmlediting.cpp: Removed unused functions.
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7701503
    • thatcher's avatar
      Build fix for Leopard. · 3619ea1d
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3619ea1d
    • staikos's avatar
      Add a comment since our current fix is not really acceptable. · dd4e40c2
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4e40c2
    • staikos's avatar
      Remove redundant line. · 64c14577
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c14577
    • staikos's avatar
      correct the changelog entry for the patch author. · 4eeb87ad
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eeb87ad
    • staikos's avatar
      Take into account the entire run length to get a proper selection. · 4afb0159
      staikos authored
              Doesn't seem to affect the Mac build but is a problem for Qt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4afb0159
    • ggaren's avatar
      Rubber stamped by Beth Dakin. · c8c5fb4e
      ggaren authored
              
              WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
              it's ObjC++ now.
      
              * Plugins/WebBaseNetscapePluginStream.m: Removed.
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c5fb4e
    • darin's avatar
      Layout test for <rdar://problem/4545060>, technorati and arstechnica fail · a5177246
      darin authored
              because of getComputedStyle not reporting display:none.
              http://bugs.webkit.org/show_bug.cgi?id=13103
      
              * fast/css/computed-style-display-none.html: Added.
              * fast/css/computed-style-display-none-expected.txt: Added.
      
              * fast/css/computed-style-negative-top.html: Updated to work with Gecko.
              * fast/css/computed-style-negative-top-expected.txt: Newline change needed
              because of change above.
      
              * fast/css/computed-style.html: Updated to work with Gecko.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5177246
    • ggaren's avatar
      Reluctantly tolerated by Darin Adler. · ff861b0b
      ggaren authored
              
              Fixed <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              The problem was that the DivX plug-in would ask us to destroy an NPStream
              that had already been destroyed, causing us to wander off into freed
              memory. (I believe the reason this was a regression was that we never used 
              to destroy plug-in streams, period.)
              
              The solution here is to track the NPStreams belonging to a plug-in, and 
              guard against plug-ins making calls with NPStreams that don't belong to 
              them. (It turns out that NPN_DestroyStream is the only stream-based 
              plug-in call we support.)
      
              (CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix.
              Use helper method to guard against a plug-in using an NPStream that doesn't
              belong to it.
              * WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++
              so I could use HashMap.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff861b0b
    • hyatt's avatar
      Fix for <rdar://problem/4545060>, technorati and arstechnica fail... · 3666feb9
      hyatt authored
              Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
              reporting display:none properly when it is set.  This is bugzilla bug 13103.
      
              Reviewed by mitz
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3666feb9
    • dsmith's avatar
      JavaScriptCore: · ebd6d4e5
      dsmith authored
              Reviewed by Darin.
      
              http://bugs.webkit.org/show_bug.cgi?id=12963
              Fix some inconsistencies in the Mozilla JS Array extras implementations
              with respect to the Mozilla implementation:
      
                - holes in arrays should be skipped, not treated as undefined,
                  by all such methods
                - an element with value undefined is not a hole
                - Array.prototype.forEach should return undefined
      
              * kjs/array_object.cpp:
              (ArrayInstance::getOwnPropertySlot):
              (ArrayProtoFunc::callAsFunction):
      
      LayoutTests:
      
              Reviewed by Darin.
      
               http://bugs.webkit.org/show_bug.cgi?id=12963
               Fix some inconsistencies in the Mozilla JS Array extras implementations
               with respect to the Mozilla implementation:
      
                 - holes in arrays should be skipped, not treated as undefined,
                   by all such methods
                 - an element with value undefined is not a hole
                 - Array.prototype.forEach should return undefined
      
              * fast/js/array-every-expected.txt:
              * fast/js/array-filter-expected.txt: Added.
              * fast/js/array-filter.html: Added.
              * fast/js/array-foreach-expected.txt:
              * fast/js/array-foreach.html:
              * fast/js/array-indexof-expected.txt:
              * fast/js/array-indexof.html:
              * fast/js/array-lastIndexOf-expected.txt:
              * fast/js/array-map-expected.txt: Added.
              * fast/js/array-map.html: Added.
              * fast/js/array-some-expected.txt:
              * fast/js/array-some.html:
              * fast/js/resources/array-every.js:
              * fast/js/resources/array-lastIndexOf.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebd6d4e5
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 06d89a01
      oliver authored
              Reviewed by Hyatt.
      
              Rename DocLoader::setPasteInProgress, etc to more generic 
              setAllowStaleResources, etc
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
              (WebCore::DocLoader::checkForReload):
              * loader/DocLoader.h:
              (WebCore::DocLoader::setAllowStaleResources):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d89a01
  2. 28 Mar, 2007 11 commits
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c8a4876
      oliver authored
              Reviewed by Anders and Steve.
      
              Add a flag to DocLoader to prevent it from reloading 
              when performing a paste or drop operation.
              
              Remove m_cachePolicy from CachedResource as it is never used
              
              Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures 
              dragging image into GMail message in _web_writeImage and 
              documentFragmentFromDragData
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
                prevent the docloader from reloading resources on paste
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::updateFromElement):
              * loader/Cache.cpp:
              (WebCore::createResource):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::CachedImage):
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource):
              * loader/CachedResource.h:
              * loader/CachedScript.cpp:
              (WebCore::CachedScript::CachedScript):
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              (WebCore::CachedXBLDocument::CachedXBLDocument):
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
                 Tidy up constructor initialise new field
              (WebCore::DocLoader::checkForReload):
                 Prevent reload when pasting
              * loader/DocLoader.h:
              (WebCore::DocLoader::setPasteInProgress):
                new field and setter
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
                prevent the docloader from reloading resources on drop
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c8a4876
    • kjk's avatar
      Not reviewed - fix typo in gdk build. · b6a0acea
      kjk authored
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::contentsToWindow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a0acea
    • mjs's avatar
      LayoutTests: · 14590a57
      mjs authored
              Reviewed by Darin.
              
              - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
      
              * fast/overflow/scrollRevealButton-expected.checksum:
              * fast/overflow/scrollRevealButton-expected.png:
              * fast/overflow/scrollRevealButton-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
              
              - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
                      
              Handle scrolling external scrollviews around the webview during
              autoscroll or when scrolling into view.
              
              This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollRectIntoViewRecursively):
              * page/FrameView.h:
              * platform/ScrollView.h:
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::visibleContentRect):
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              (WebCore::ScrollView::updateContents):
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14590a57
    • adele's avatar
      Reviewed by Brady. · 1d3bb180
      adele authored
              Update to last fix.
      
              * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
              Added check to only use the VitalSource workaround if the app is not linked on or after
              the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d3bb180
    • darin's avatar
      Reviewed and landed by Darin · 993602c1
      darin authored
              Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
              http://bugs.webkit.org/show_bug.cgi?id=13138
      
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::isLower):
              (WebCore::StringImpl::lower):
              (WebCore::StringImpl::equalIgnoringCase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      993602c1
    • antti's avatar
      Reviewed by Hyatt. · 60c2cceb
      antti authored
              Fix <rdar://problem/5092653>
              REGRESSION: Image decoding making scrolling slow
              
              If decoder gave back a null frame (which I think happens regularly if you don't have full frame 
              data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
              led to massive growth in calculated image size and eventually made cache prune constantly. 
              
              No test, I don't know how to make one for this.
      
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::cacheFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60c2cceb
    • adele's avatar
      WebCore: · cc025d83
      adele authored
              Reviewed by Kevin M.
      
              WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              Convert return value to a string.  This matches the behavior in Safari 2.0.
      
      WebKit:
      
              Reviewed by Kevin M.
      
              WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings.  We used to allow this
              but now we throw a JavaScript exception for return statements that aren't in functions.
      
              Filed this evangelism bug so we can notify VitalSource of the problem:
              <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc025d83
    • ap's avatar
      Reviewed by Darin. · 16c9b5f7
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=13190
              XPath incorrectly handles namespaces on attributes
      
      WebCore:
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but 
              measurable performance improvement for bug 13021.
              (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
      
              * xml/XPathStep.h:
              (WebCore::XPath::Step::NodeTest::NodeTest):
              (WebCore::XPath::Step::NodeTest::namespaceURI):
              (WebCore::XPath::Step::nodeTest):
              (WebCore::XPath::Step::setNodeTest):
              Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
      
              * xml/XPathGrammar.y:
              * xml/XPathPath.cpp:
              (WebCore::XPath::LocationPath::optimizeStepPair):
              Accounted for the above change.
      
      LayoutTests:
              * fast/xpath/attr-namespace-expected.txt: Added.
              * fast/xpath/attr-namespace.html: Added.
      
              * fast/xpath/xpath-namespaces-expected.txt:
              * fast/xpath/xpath-namespaces.html:
              Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16c9b5f7
    • antti's avatar
      Update libWebKitSystemInterface, previous version was out of date. · 6ef858f4
      antti authored
              * libWebKitSystemInterface.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef858f4
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c0320b6
      oliver authored
              rs=Hyatt.
      
              Rollout local changes :-/
      
              * loader/Cache.cpp:
              (WebCore::Cache::pruneAllResources):
              (WebCore::Cache::remove):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c0320b6
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 97c1d600
      oliver authored
              Reviewed by Hyatt.
      
              Roll out r20511 due to incredible badness
      
              * loader/Cache.cpp:
              (WebCore::Cache::pruneAllResources):
              (WebCore::Cache::remove):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97c1d600
  3. 27 Mar, 2007 12 commits
    • darin's avatar
      * svg/hixie/text/003-expected.txt: Updated results for this one test that now has · 2a254a04
      darin authored
              different results due to the painting Adele added to DumpRenderTree. Long term,
              we just have to fix SVG so that painting doesn't cause changes to the render tree!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a254a04
    • oliver's avatar
      2007-03-27 Oliver Hunt <oliver@apple.com> · 798912f8
      oliver authored
              Reviewed by Adam.
      
              Don't enforce text-selection drag delay when we are
              going to drag an image anyway.
      
              Fixes rdar://problem/4668935
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleDrag):
      Layout tests:
              Test to ensure there is no delay forced when dragging a selected image
      
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798912f8
    • andersca's avatar
      JavaScriptCore: · d74e433f
      andersca authored
              Reviewed by Geoff.
      
              * bindings/NP_jsobject.cpp:
              (_NPN_InvokeDefault):
              Call JSObject:call for native JavaScript objects.
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              Add NPN_InvokeDefault test.
              
              * plugins/netscape-invoke-default-expected.txt: Added.
              * plugins/netscape-invoke-default.html: Added.
      
      WebKitTools:
      
              Reviewed by Geoff.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginInvoke):
              Add new function which takes a function and calls it using NPN_InvokeDefault.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d74e433f
    • justing's avatar
      Build fix · 7eaa01a4
      justing authored
              
              * editing/markup.cpp:
              (WebCore::startMarkup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eaa01a4
    • justing's avatar
      LayoutTests: · 7d3dbfed
      justing authored
              Reviewed by darin
              
              <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
      
              Demonstrates the bug fixed:
              * editing/style/5091898-expected.checksum: Added.
              * editing/style/5091898-expected.png: Added.
              * editing/style/5091898-expected.txt: Added.
              * editing/style/5091898.html: Added.
              Demonstrates a related bug fixed (deleting
              the line break before a paragraph could remove
              its underlining):
              * editing/deleting/5091898-expected.checksum: Added.
              * editing/deleting/5091898-expected.png: Added.
              * editing/deleting/5091898-expected.txt: Added.
              * editing/deleting/5091898.html: Added.
              Demonstrates that a link now (correctly) exists, 
              instead of just underlined text:
              * editing/pasteboard/4840662-expected.txt:
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
              
              createMarkup skipped elements if they were blocks
              when called from moveParagraphs (because that function 
              must receive only inline content).  This patch adds 
              code to inline these blocks instead of skipping them 
              so that we don't lose any of the style that they 
              contribute to the copied markup.
      
              * editing/markup.cpp:
              (WebCore::startMarkup): Add an inlineBlocks option.
              Make sure to overwrite display:block coming from
              a style sheet or the inline style declaration.
              (WebCore::createMarkup): Don't refuse to include a 
              specialCommonAncestor that's a block if we were asked 
              to include only inline content, since we can now inline 
              block elements in startMarkup.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d3dbfed
    • adele's avatar
      Oops- my comment was missing a word. · 97ab9364
      adele authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ab9364
    • adele's avatar
      Adding comment. · ad634f59
      adele authored
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad634f59
    • adele's avatar
      Fix svg tests by calling displayIfNeeded. · 37405f5e
      adele authored
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37405f5e
    • sullivan's avatar
      Reviewed by Tim · 93cf3a55
      sullivan authored
              
              - fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]):
              initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not
              be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93cf3a55
    • adele's avatar
      Reviewed by Hyatt. · 7c2f10dc
      adele authored
              Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery
      
              This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
              move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.
      
              * dom/Document.cpp: (WebCore::Document::implicitClose):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2f10dc
    • justing's avatar
      LayoutTests: · dcdb2794
      justing authored
              Reviewed by darin
              
              <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
              <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
              <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
              <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
      
              * editing/pasteboard/5065605-expected.checksum: Added.
              * editing/pasteboard/5065605-expected.png: Added.
              * editing/pasteboard/5065605-expected.txt: Added.
              * editing/pasteboard/5065605.html: Added.
              * editing/style/4916887-expected.checksum: Added.
              * editing/style/4916887-expected.png: Added.
              * editing/style/4916887-expected.txt: Added.
              * editing/style/4916887.html: Added.
              * editing/style/5065910-expected.checksum: Added.
              * editing/style/5065910-expected.png: Added.
              * editing/style/5065910-expected.txt: Added.
              * editing/style/5065910.html: Added.
              * editing/style/5084241-expected.checksum: Added.
              * editing/style/5084241-expected.png: Added.
              * editing/style/5084241-expected.txt: Added.
              * editing/style/5084241.html: Added.
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
              <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
              <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
              <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
              If a node's text fill color is invalid, then its children use 
              their font-color as their text fill color (they don't inherit 
              it).  Likewise for stroke color.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcdb2794
    • andersca's avatar
      * platform/ScrollBar.h: · c3c0159f
      andersca authored
              Use wtf/MathExtras.h instead of math.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3c0159f