1. 03 Nov, 2008 1 commit
  2. 28 Oct, 2008 2 commits
    • timothy@apple.com's avatar
      Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time. · 7dec1b92
      timothy@apple.com authored
      Make the Profiles panel in the Web Inspector have an enable screen.
      Profiling now needs to be enabled before console.profile() works.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Make the Profiles panel in the Web Inspector have an enable screen.
              Profiling now needs to be enabled before console.profile() works.
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * English.lproj/localizedStrings.js: New strings.
              * WebCore.base.exp: New and changed exports.
              * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
              Timer to call InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
              that calls InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
              and enable the profiler if the profiler was not enabled.
              (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
              (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
              if the skipRecompile argument is false. Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
              Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
              so it won't be started later.
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
              * inspector/front-end/Images/debuggingButtons.png: Remove.
              * inspector/front-end/Images/enableButtons.png: Added.
              * inspector/front-end/Images/profilesSilhouette.png: Added.
              * inspector/front-end/Images/scriptsSilhouette.png: Added.
              * inspector/front-end/PanelEnablerView.js: Added.
              (WebInspector.PanelEnablerView):
              (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
              event so listeners can do their thing.
              (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
              (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
              (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
              (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
              show/hide other buttons. Also show/hide the PanelEnablerView.
              (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
              (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
              disableProfiler or enableProfiler.
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
              debuggingButton with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
              the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
              when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
              with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
              (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
              since reset is called from debuggerWasEnabled and debuggerWasDisabled.
              * inspector/front-end/View.js: Inherit from WebInspector.Object.
              * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
              * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.js:
              (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
              (WebInspector.profilerWasDisabled): Ditto.
              * page/Console.cpp:
              (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
              (WebCore::Console::info): Ditto.
              (WebCore::Console::log): Ditto.
              (WebCore::Console::assertCondition): Ditto.
              (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
              (WebCore::Console::count): Ditto.
              (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
              (WebCore::Console::profileEnd): Ditto.
              (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
              (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
              Now just sets the member boolean.
              * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
      
      WebKit/mac:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add WebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector/WebInspector.h:
              * WebInspector/WebInspector.mm:
              (-[WebInspector isJavaScriptProfilingEnabled]): Added. Calls InspectorController::profilerEnabled.
              (-[WebInspector setJavaScriptProfilingEnabled:]): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
      
      WebKit/win:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add IWebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector.cpp:
              (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
              (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
              * WebInspector.h:
      
      WebKitTools:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add support for enabling the profiler, so the profiling tests can continue
              work now that the profiler is not always enabled.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
              * DumpRenderTree/LayoutTestController.cpp:
              (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
              (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
      
      LayoutTests:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Update profiler tests to opt-in to profiling and clean up the output.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
              does not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * fast/profiler/anonymous-event-handler-expected.txt:
              * fast/profiler/anonymous-event-handler.html:
              * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
              * fast/profiler/anonymous-function-called-from-different-contexts.html:
              * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
              * fast/profiler/anonymous-function-calls-built-in-functions.html:
              * fast/profiler/anonymous-function-calls-eval-expected.txt:
              * fast/profiler/anonymous-function-calls-eval.html:
              * fast/profiler/apply-expected.txt:
              * fast/profiler/apply.html:
              * fast/profiler/built-in-function-calls-anonymous-expected.txt:
              * fast/profiler/built-in-function-calls-anonymous.html:
              * fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
              * fast/profiler/built-in-function-calls-user-defined-function.html:
              * fast/profiler/call-expected.txt:
              * fast/profiler/call-nodelist-as-function-expected.txt:
              * fast/profiler/call-nodelist-as-function.html:
              * fast/profiler/call.html:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
              * fast/profiler/compare-multiple-profiles-expected.txt:
              * fast/profiler/compare-multiple-profiles.html:
              * fast/profiler/constructor-expected.txt:
              * fast/profiler/constructor.html:
              * fast/profiler/dead-time-expected.txt:
              * fast/profiler/dead-time.html:
              * fast/profiler/document-dot-write-expected.txt:
              * fast/profiler/document-dot-write.html:
              * fast/profiler/event-handler-expected.txt:
              * fast/profiler/event-handler.html:
              * fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
              * fast/profiler/execution-context-and-eval-on-same-line.html:
              * fast/profiler/heavy-view-expected.txt:
              * fast/profiler/heavy-view.html:
              * fast/profiler/inline-event-handler-expected.txt:
              * fast/profiler/inline-event-handler.html:
              * fast/profiler/many-calls-in-the-same-scope-expected.txt:
              * fast/profiler/many-calls-in-the-same-scope.html:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
              * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-function-calls.html:
              * fast/profiler/multiple-frames-expected.txt:
              * fast/profiler/multiple-frames.html:
              * fast/profiler/nested-anonymous-functon-expected.txt:
              * fast/profiler/nested-anonymous-functon.html:
              * fast/profiler/nested-start-and-stop-profiler-expected.txt:
              * fast/profiler/nested-start-and-stop-profiler.html:
              * fast/profiler/no-execution-context-expected.txt:
              * fast/profiler/no-execution-context.html:
              * fast/profiler/one-execution-context-expected.txt:
              * fast/profiler/one-execution-context.html:
              * fast/profiler/profile-calls-in-included-file-expected.txt:
              * fast/profiler/profile-calls-in-included-file.html:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
              * fast/profiler/profiling-from-a-nested-location-expected.txt:
              * fast/profiler/profiling-from-a-nested-location.html:
              * fast/profiler/resources/profiler-test-JS-resources.js:
              (endTest): Remove some whitespace.
              (insertGivenText): Hide the output of this method, sicne it is not important to the test.
              (insertNewText): Ditto.
              (printHeavyProfilesDataWithoutTime): Output plain text an not console.log.
              (printProfilesDataWithoutTime): Ditto.
              (printProfileNodeWithoutTime): Ditto.
              * fast/profiler/simple-event-call-expected.txt:
              * fast/profiler/simple-event-call.html:
              * fast/profiler/simple-no-level-change-expected.txt:
              * fast/profiler/simple-no-level-change.html:
              * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
              * fast/profiler/start-and-stop-profiler-multiple-times.html:
              * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
              * fast/profiler/start-but-dont-stop-profiling-expected.txt:
              * fast/profiler/start-but-dont-stop-profiling.html:
              * fast/profiler/stop-profiling-after-setTimeout-expected.txt:
              * fast/profiler/stop-profiling-after-setTimeout.html:
              * fast/profiler/stop-then-function-call-expected.txt:
              * fast/profiler/stop-then-function-call.html:
              * fast/profiler/throw-exception-from-eval-expected.txt:
              * fast/profiler/throw-exception-from-eval.html:
              * fast/profiler/two-execution-contexts-expected.txt:
              * fast/profiler/two-execution-contexts.html:
              * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
              * fast/profiler/user-defined-function-calls-built-in-functions.html:
              * fast/profiler/window-dot-eval-expected.txt:
              * fast/profiler/window-dot-eval.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dec1b92
    • simon.fraser@apple.com's avatar
      2008-10-28 Pierre-Olivier Latour <pol@apple.com> · bdbd3f77
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein
      
              Primary changes in DumpRenderTree:
              - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
              is different from regular font CG anti-aliasing) as font-smoothing settings
              depends on the display and can also be changed by the user
              - Use a new cleared buffer for each test instead of the reusing same one to
              avoid potential result corruption across tests
              - Can now receive the expected pixel hash as a suffix to the test path or
              url as "path'hash"
              - Make sure hash is computed in a endian-independent way
              - Improve the code that sets/restores the screen color profile
              - Make the code more cross-platformy with std::string goodness
              - Added an "on-screen" mode where the snapshot will take into account surfaces
              on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
              reading from the display framebuffer on 10.4. This mode is not active by
              default for performance reason, but must be explicitly activated from the test
              file using the new "testOnscreen()" JS API.
      
              Primary changes in ImageDiff:
              - Provide a new comparison algorithm that is more tolerant to "acceptable"
              failures (i.e. very small differences in font rendering, which --threshold is
              not really good at handling)
              - Generate normalized intensity-only diff images
      
              Primary changes in run-webkit-tests:
              - Take advantage of hashes for pixel tests which makes them much faster by
              minimizing image comparisons
              - Removed repaint options as these should be set from within test files using
              JS API
              - Replaced "threshold" option in  by "tolerance" expressed in percents
              - Added more logging when in "verbose" mode
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdbd3f77
  3. 16 Oct, 2008 1 commit
    • darin@apple.com's avatar
      WebKitTools: · 2e940225
      darin@apple.com authored
      2008-10-15  Glenn Wilson  <gwilson@google.com>
      
              Added new method to allow tests to disable smart editing in the course of a test.
              This is a possible solution to bug .20655
      
              Reviewed by Tim Hatcher.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setSmartInsertDeleteEnabledCallback): new method
              (LayoutTestController::staticFunctions): added new method to static list of callbacks
              * DumpRenderTree/LayoutTestController.h: added signature of new method
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting): added state resetting
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setSmartInsertDeleteEnabled): added new method
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting): added state resetting
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setSmartInsertDeleteEnabled): added new method
      
      LayoutTests:
      
      2008-10-15  Glenn Wilson  <gwilson@google.com>
      
              Added tests to verify that smart editing can be disabled for some tests.
      
              Reviewed by Tim Hatcher.
      
              * editing/deleting/smart-editing-disabled-expected.txt: Added.
              * editing/deleting/smart-editing-disabled.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e940225
  4. 11 Oct, 2008 1 commit
  5. 08 Oct, 2008 1 commit
  6. 30 Sep, 2008 2 commits
  7. 20 Sep, 2008 1 commit
  8. 19 Sep, 2008 1 commit
  9. 18 Sep, 2008 2 commits
    • mrowe@apple.com's avatar
      Clear the main frame's name between tests to get more consistent test results · a520659a
      mrowe@apple.com authored
      when running the WebKit tests with --nthly.
      
      Reviewed by Dan Bernstein.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetWebViewToConsistentStateBeforeTesting):
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (resetWebViewToConsistentStateBeforeTesting):
      
      Add SPI to WebView to allow DRT to clear the main frame's name between tests.
      
      * Interfaces/IWebViewPrivate.idl:
      * WebView.cpp:
      (WebView::clearMainFrameName):
      * WebView.h:
      
      Add SPI to WebView to allow DRT to clear the main frame's name between tests.
      
      * WebView/WebView.mm:
      (-[WebView _clearMainFrameName]):
      * WebView/WebViewPrivate.h:
      
      Add a means of clearing a FrameTree's name.
      
      * WebCore.base.exp:
      * page/FrameTree.cpp:
      (WebCore::FrameTree::clearName):
      * page/FrameTree.h:
      
      Update test results now that frame tree names are cleared between tests.
      
      * fast/events/onunload-clears-onbeforeunload-expected.txt:
      * fast/events/onunload-expected.txt:
      * fast/events/onunload-not-on-body-expected.txt:
      * fast/events/onunload-window-property-expected.txt:
      * fast/forms/button-state-restore-expected.txt:
      * fast/forms/form-and-frame-interaction-retains-values-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a520659a
    • mrowe@apple.com's avatar
      Fix a crash seen running DumpRenderTree on... · 3b74c1b6
      mrowe@apple.com authored
      Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
      
      Reviewed by Sam Weinig.
      
      The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
      attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
      LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
      
      * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
      (layoutTestControllerObjectFinalize): Deref the wrapped object.
      (LayoutTestController::makeWindowObject): Ref the wrapped object.
      * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
      * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
      * DumpRenderTree/win/DumpRenderTree.cpp:
      (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b74c1b6
  10. 16 Sep, 2008 1 commit
  11. 08 Sep, 2008 1 commit
  12. 31 Jul, 2008 1 commit
    • ddkilzer@apple.com's avatar
      Fix layout test results for webarchive/test-xml-stylesheet.xml · 719388a1
      ddkilzer@apple.com authored
      WebKit:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              * WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h.
              Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h
              to private so they're copied into PrivateHeaders.
      
      WebKit/mac:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
              for DumpRenderTree.
      
              * WebView/WebHTMLRepresentationInternal.h: Added.
      
      WebKitTools:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (convertMIMEType): Work around the "text/xml" local file type
              regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
              stop mangling "application/x-javascript" into "text/javascript".
              (convertWebResourceDataToString): When checking whether to dump a
              resource as text, also check to see if the MIME type is in the
              -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
              * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
              macro.
      
      LayoutTests:
      
              Fix layout test results for webarchive/test-xml-stylesheet.xml
      
              Reviewed by Darin.
      
              * platform/mac/webarchive/test-xml-stylesheet-expected.txt:
              Removed unused test results.
      
              * webarchive/test-duplicate-resources-expected.webarchive: Updated
              results now that we don't mangle application/x-javascript into
              text/javascript.
              * webarchive/test-script-src-expected.webarchive: Ditto.
      
              * webarchive/test-xml-stylesheet-expected.webarchive: Updated
              results now that we handle application/xml correctly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      719388a1
  13. 11 Jul, 2008 1 commit
    • slewis@apple.com's avatar
      2008-07-11 Stephanie Lewis <slewis@apple.com> · a7615caa
      slewis@apple.com authored
              Reviewed by Darin Adler and Oliver Hunt.
      
      JavaScriptCore:
              Refactor RefCounting Leak counting code into a common class.
      
              In order to export the symbols I needed to put the debug defines inside the function names
              
              Before we had a separate channel for each Logging each Leak type.  Since the leak channels were only used in one location, and only at quit for simplicity I combined them all into one leak channel.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj: add new class
              * kjs/nodes.cpp: remove old leak counting code
              * wtf/RefCountedLeakCounter.cpp: Added. create a common leak counting class
              * wtf/RefCountedLeakCounter.h: Added.
      
      WebCore:
              No Functionality Changed.  Change all the leak counting code to use the new WTF leak counter class.
      
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
              (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::~JSEventListener):
              * dom/Node.cpp:
              (WebCore::Node::Node):
              (WebCore::Node::~Node):
              * dom/Range.cpp:
              (WebCore::Range::Range):
              (WebCore::Range::~Range):
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::~CachedPage):
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::SubresourceLoader):
              (WebCore::SubresourceLoader::~SubresourceLoader):
              * page/Frame.cpp:
              (WebCore::Frame::Frame):
              (WebCore::Frame::~Frame):
              * page/Page.cpp:
              (WebCore::Page::Page):
              (WebCore::Page::~Page):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::RenderObject):
              (WebCore::RenderObject::~RenderObject):
              * rendering/bidi.cpp:
              (WebCore::throw):
              (WebCore::BidiRun::operator delete):
      
      WebKit
      
              Move WebPreferences.m to objc++ so it can include the new WTF leak counting class.
      
              * WebKit.xcodeproj/project.pbxproj:
      
              Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
      
              * WebView/WebPreferences.m: Removed.
              * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
              (+[WebPreferences initialize]): if running in Default enable full  document teardown
              (-[WebPreferences editableLinkBehavior]):
              (-[WebPreferences setFullDocumentTeardownEnabled:]):
              * WebView/WebView.mm:
              (-[WebView _close]): disable leak messages if using fast teardown
      
      WebKitTools:
              Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
      
              Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (setDefaultsToConsistentValuesForTesting):
              (resetWebViewToConsistentStateBeforeTesting):
              * Scripts/run-webkit-tests:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7615caa
  14. 09 Jul, 2008 3 commits
  15. 24 Jun, 2008 2 commits
    • bdakin@apple.com's avatar
      WebKitTools: · e1d57dbb
      bdakin@apple.com authored
      2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
      
              Reviewed by Darin.
      
              Fix for <rdar://problem/5884881> Make DumpRenderTree support 
              accessibility tests
      
              This patch adds some basic support for accessibility layout tests 
              on the Mac.
      
              * DumpRenderTree/AccessibilityController.cpp: Added.
              (AccessibilityController::AccessibilityController):
              (AccessibilityController::~AccessibilityController):
              (dumpCurrentAttributesCallback):
              (AccessibilityController::makeWindowObject):
              (AccessibilityController::getJSClass):
              (AccessibilityController::staticFunctions):
              * DumpRenderTree/AccessibilityController.h: Added.
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
              (descriptionOfValue):
              (AccessibilityController::dumpCurrentAttributes):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              * DumpRenderTree/mac/FrameLoadDelegate.h:
              * DumpRenderTree/mac/FrameLoadDelegate.mm:
              (-[FrameLoadDelegate init]):
              (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
      
      LayoutTests:
      
      2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
      
              Reviewed by Darin.
              
              First test for <rdar://problem/5884881> Make DumpRenderTree support 
              accessibility tests
      
              * accessibility: Added.
              * accessibility/document-attributes-expected.txt: Added.
              * accessibility/document-attributes.html: Added.
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1d57dbb
    • mitz@apple.com's avatar
      WebKitTools: · 4a84907d
      mitz@apple.com authored
              Rubber-stamped by Darin Adler.
      
              - add a font family for testing font-weight
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
              flags to create data sections for the WeightWatcher fonts.
              * DumpRenderTree/fonts: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
              * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (activateFonts): Renamed activateAhemFont to this and made it activate
              the WeightWatcher fonts in addition to Ahem.
              (prepareConsistentTestingEnvironment): Adjusted for the name change.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (initialize): Added the WeightWatcher fonts.
      
      LayoutTests:
      
              Rubber-stamped by Darin Adler.
      
              - add font-weight test for a family that has 9 weights
      
              * fast/css/font-weight-1.html: Added.
              * platform/mac/fast/css/font-weight-1-expected.checksum: Added.
              * platform/mac/fast/css/font-weight-1-expected.png: Added.
              * platform/mac/fast/css/font-weight-1-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a84907d
  16. 12 May, 2008 1 commit
    • andersca@apple.com's avatar
      WebCore: · bbe3968b
      andersca@apple.com authored
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Make it possible to perform synchronous loads from the application cache.
              
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
              Factor out code from scheduleApplicationCacheLoad in its own method.
              
              (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
              Call shouldLoadResourceFromApplicationCache here instead.
              
              * loader/DocumentLoader.h:
              
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadResourceSynchronously):
              Call shouldLoadResourceFromApplicationCache.
      
      WebKitTools:
      
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add support for testing application caches.
              
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dumpRenderTree):
              Empty the cache.
              
              (resetWebViewToConsistentStateBeforeTesting):
              Turn on support for the application cache.
      
      LayoutTests:
      
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add simple appcache test.
      
              * http/conf/mime.types:
              * http/tests/appcache: Added.
              * http/tests/appcache/resources: Added.
              * http/tests/appcache/resources/not-in-cache.txt: Added.
              * http/tests/appcache/resources/simple.manifest: Added.
              * http/tests/appcache/resources/simple.txt: Added.
              * http/tests/appcache/simple-expected.txt: Added.
              * http/tests/appcache/simple.html: Added.
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbe3968b
  17. 08 May, 2008 1 commit
    • mrowe@apple.com's avatar
      Update DumpRenderTree to build 64-bit. · a088e71a
      mrowe@apple.com authored
      The three major changes here are:
      1) Use NSInteger in the appropriate places.
      2) Use ColorSync API that is available in 64-bit to switch display profiles.
      3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
      
      The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
      needs updated to successfully build.
      
      Reviewed by Oliver Hunt and Dan Bernstein.
      
      * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (swizzleAllMethods):
      (poseAsClass):
      (prepareConsistentTestingEnvironment):
      * DumpRenderTree/mac/DumpRenderTreeMac.h:
      * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
      * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
      * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
      * DumpRenderTree/mac/PixelDumpSupportMac.mm:
      (restoreColorSpace):
      (failedGettingCurrentProfile):
      (setDefaultColorProfileToRGB):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a088e71a
  18. 24 Apr, 2008 1 commit
  19. 18 Apr, 2008 1 commit
    • aroben@apple.com's avatar
      Get rid of DRT's Watchdog · c45ddc94
      aroben@apple.com authored
              run-webkit-tests now detects hangs and samples DRT as needed.
      
              Reviewed by Mitz Pettel.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
              Watchdog* files from the project.
              * DumpRenderTree/Watchdog.cpp: Removed.
              * DumpRenderTree/Watchdog.h: Removed.
              * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
              (dumpRenderTree):
              (runTest):
              * DumpRenderTree/mac/WatchdogMac.h: Removed.
              * DumpRenderTree/mac/WatchdogMac.mm: Removed.
              * Scripts/run-webkit-tests:
              (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
              (sub sampleDumpTool): Added. Writes a sample report to
              ~/Library/Logs/DumpRenderTree/HangReport.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c45ddc94
  20. 08 Apr, 2008 2 commits
  21. 24 Mar, 2008 1 commit
    • weinig@apple.com's avatar
      2008-03-24 Sam Weinig <sam@webkit.org> · 4544725b
      weinig@apple.com authored
              Reviewed by Dave Hyatt.
      
              Add EventSender.zoomPageIn/zoomPageOut support to DRT.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting):
              * DumpRenderTree/mac/EventSendingController.mm:
              (+[EventSendingController isSelectorExcludedFromWebScript:]):
              (-[EventSendingController zoomPageIn]):
              (-[EventSendingController zoomPageOut]):
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting):
              * DumpRenderTree/win/EventSender.cpp:
              (textZoomInCallback):
              (textZoomOutCallback):
              (zoomPageInCallback):
              (zoomPageOutCallback):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4544725b
  22. 07 Mar, 2008 2 commits
  23. 06 Mar, 2008 1 commit
    • beidson@apple.com's avatar
      JavaScriptCore: · 674b7969
      beidson@apple.com authored
              Reviewed by Darin
      
              Add a timedWait() method to ThreadCondition
      
              * JavaScriptCore.exp:
      
              * wtf/Threading.h:
      
              * wtf/ThreadingGtk.cpp:
              (WTF::ThreadCondition::timedWait):
      
              * wtf/ThreadingNone.cpp:
              (WTF::ThreadCondition::timedWait):
      
              * wtf/ThreadingPthreads.cpp:
              (WTF::ThreadCondition::timedWait):
      
              * wtf/ThreadingWin.cpp:
              (WTF::ThreadCondition::timedWait): Needs implementation
      
      WebKitTools:
      
              Reviewed by Darin
      
              Added a cross-platform Watchdog thread to DRT.
      
              The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
              main thread hangs still affect DRT.
      
              By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
              and true deadlocks can be caught.
      
              There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
              `sample` available, the Mac implementation of this hook samples the process before it is killed.
      
              I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
      
              * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
              * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
      
              * DumpRenderTree/Watchdog.cpp: Added.
              (Watchdog::Watchdog):
              (Watchdog::~Watchdog):
              (Watchdog::start):
              (Watchdog::stop):
              (Watchdog::checkIn):
              (Watchdog::setWatchdogInterval):
              (Watchdog::handleHang):
              (Watchdog::watchdogThreadStart):
              (Watchdog::watchdogThread):
              * DumpRenderTree/Watchdog.h: Added.
      
              * DumpRenderTree/mac/WatchdogMac.h: Added.
              * DumpRenderTree/mac/WatchdogMac.mm: Added.
              (WatchdogMac::handleHang): Sample the process and write it out to a file
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dumpRenderTree): Setup and start the watchdog before running any tests
              (runTest): Checkin with the watchdog after each test
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      674b7969
  24. 29 Feb, 2008 1 commit
    • ddkilzer@apple.com's avatar
      Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks · 5e749f4b
      ddkilzer@apple.com authored
              <http://bugs.webkit.org/show_bug.cgi?id=15754>
      
              Reviewed by Geoff and Darin.
      
              We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
              then removing that path from all file:/// URLs in the WebArchive output so these tests
              would pass no matter where they were run.
      
              The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
              current working directory, but the WebArchive does not.  This left the current working
              directory in all file:/// URLs in the test output, and thus all tests failed, for any
              developer that used symlinks to get to their WebKit source directory.
      
              The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
              remove the current working directory path (no matter what it is) after "file://" but
              before "/LayoutTests/".  
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
              current working directory as described above.
              (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
              calls to normalizeWebResourceURL().
              (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
              normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e749f4b
  25. 05 Feb, 2008 1 commit
  26. 27 Jan, 2008 1 commit
    • mitz@apple.com's avatar
      WebKitTools: · aeb03f26
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - add support for directory prologues and epilogues to run-webkit-tests
              - allow setting a persistent user style sheet in DumpRenderTree
              - activate the WebKit Layout Tests font in Windows DumpRenderTree
      
              * DumpRenderTree/LayoutTestController.cpp:
              (clearPersistentUserStyleSheetCallback): Added.
              (setPersistentUserStyleSheetLocationCallback): Added.
              (LayoutTestController::staticFunctions): Added.
              clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (setPersistentUserStyleSheetLocation): Added.
              (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
              to the set of things this function resets. Now it either disables the
              user style sheet or sets it to the persistent user style sheet and
              enables it.
              * DumpRenderTree/mac/DumpRenderTreeMac.h:
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
              (LayoutTestController::clearPersistentUserStyleSheet): Added.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (setPersistentUserStyleSheetLocation): Added.
              (initialize): Added the WebKit Layout Tests font to the set of fonts to
              install.
              (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
              * DumpRenderTree/win/DumpRenderTreeWin.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
              (LayoutTestController::clearPersistentUserStyleSheet): Added.
              * Scripts/run-webkit-tests: Changed to look for, and if found process in
              DumpRenderTree, files named run-webkit-tests-prologue.html and
              run-webkit-tests-epilogue.html in the resources subdirectory of any
              test directory and platform test results directory. The prologues are
              processed before the first test from the directory (and its
              subdirectories) is run, and the epilogues are processed after the last
              test from the directory is run. Platform-specific prologues and
              epilogues are processed in order of specificity.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - make some CSS2.1 tests pass on Windows by using @font-face to force
                font fallback to match Mac OS X.
      
              * platform/win/Skipped:
              * platform/win/css2.1: Added.
              * platform/win/css2.1/resources: Added.
              * platform/win/css2.1/resources/Mac-compatible-font-fallback.css: Added.
              * platform/win/css2.1/resources/run-webkit-tests-epilogue.html: Added.
              * platform/win/css2.1/resources/run-webkit-tests-prologue.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeb03f26
  27. 10 Jan, 2008 2 commits
    • weinig@apple.com's avatar
      WebCore: · 7742780b
      weinig@apple.com authored
              Reviewed by Sam Weinig and Anders Carlsson.
      
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
              <rdar://problem/5657355>
      
              This patch makes two changes:
      
              1) Java calls FrameLoader::load in a slightly different way than
                 JavaScript, which previously let a malicious web site bypass the
                 shouldAllowNavigation check.  This patch adds that check to that
                 code path.
      
              2) FrameLoader now wraps calls to m_frame->tree()->find(name) with
                 findFrameForNavigation, which calls shouldAllowNavigation.  This
                 treats disallowed frame navigations as if the named frame did not
                 exist, resulting in a popup window when appropriate.
      
              Tests: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html
                     http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html
      
              * WebCore.base.exp:
              * bindings/js/kjs_window.cpp:
              (KJS::WindowProtoFuncOpen::callAsFunction):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::createWindow):
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::post):
              (WebCore::FrameLoader::findFrameForNavigation):
              * loader/FrameLoader.h:
      
      WebKit/mac:
      
              Reviewed by Anders Carlsson.
      
              Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
              <rdar://problem/5657355>
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
              to ensure the shouldAllowNavigation check is made.
      
      WebKitTools:
      
              Reviewed by Anders Carlsson.
      
              Make DRT track open windows instead of allocated windows so that
              we can avoid ASSERTION due to late deallocs out of our control.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dumpBackForwardListForAllWindows):
              (runTest):
              * DumpRenderTree/mac/DumpRenderTreeMac.h:
              * DumpRenderTree/mac/DumpRenderTreeWindow.h:
              * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
              (+[DumpRenderTreeWindow openWindows]):
              (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
              (-[DumpRenderTreeWindow close]):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::windowCount):
      
      LayoutTests:
      
              Reviewed by Anders Carlsson.
      
              Tests for http://bugs.webkit.org/show_bug.cgi?id=16522
              <rdar://problem/5657355>
      
              * http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html: Added.
              * http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html: Added.
              * http/tests/security/frameNavigation/resources/navigation-happened.html: Added.
              * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt: Added.
              * http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html: Added.
              * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt: Added.
              * http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html: Added.
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7742780b
    • kmccullough@apple.com's avatar
      WebCore: · fcacf34a
      kmccullough@apple.com authored
              Reviewed by Darin, Sam, and Adam.
      
              - <rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
              - link in gmail message displays JavaScript alert falsely complaining
              about pop-up blocking
              - When trying to open a new window, we now see if the user gesture 
              occurred in the global dynamic object instead of the frame since that is
              the only place an event can occur. 
      
              * bindings/js/kjs_window.cpp: - Check the dynamic global object instead
              of the frame.
              (KJS::allowPopUp):
              (KJS::showModalDialog):
              (KJS::WindowProtoFuncOpen::callAsFunction):
      
      WebKitTools:
      
              Reviewed by Darin, Sam and Adam.
      
              -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
              link in gmail message displays JavaScript alert falsely complaining
              about pop-up blocking.
              - Added the ability to enable the pop-up blocker via the
              LayoutTestController.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setPopupBlockingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (setDefaultsToConsistentValuesForTesting):
              (resetWebViewToConsistentStateBeforeTesting):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setPopupBlockingEnabled):
      
      LayoutTests:
      
              Reviewed by Darin, Sam, and Adam.
      
              -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
              link in gmail message displays JavaScript alert falsely complaining
              about pop-up blocking
              - When trying to open a new window, we now see if the user gesture
              occurred in the global dynamic object instead of the frame since that is
              the only place an event can occur.
      
              * fast/events/open-window-from-another-frame-expected.txt: Added.
              * fast/events/open-window-from-another-frame.html: Added.
              * fast/events/resources/open-window-from-another-frame-otherFrame.html: Added.
              * fast/events/resources/window-opened.html: Added.
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcacf34a
  28. 03 Jan, 2008 1 commit
    • alice.liu@apple.com's avatar
      WebKitTools: · 758215af
      alice.liu@apple.com authored
              Reviewed by Darin, Mitz.
      
              fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
      
              the clickcount should not increase if the last click was at a different location.  it's a new click.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (runTest):
              * DumpRenderTree/mac/EventSendingController.h:
              * DumpRenderTree/mac/EventSendingController.mm:
              (-[EventSendingController mouseDown]):
              (-[EventSendingController mouseUp]):
      
      LayoutTests:
      
              Reviewed by Darin, Mitz.
      
              updating expected results after fixing clickcount for 
              <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
      
              * fast/forms/focus-selection-input-expected.txt:
              * fast/forms/focus-selection-textarea-expected.txt:
              * platform/mac/fast/events/objc-event-api-expected.txt:
              * platform/mac/fast/inline/dirtyLinesForInline-expected.txt:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
              * platform/mac/svg/custom/pointer-events-image-expected.txt:
              * platform/mac/svg/custom/pointer-events-path-expected.txt:
              * platform/mac/svg/custom/pointer-events-text-expected.txt:
              * platform/mac/svg/custom/text-hit-test-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      758215af
  29. 21 Dec, 2007 1 commit
    • weinig@apple.com's avatar
      Reviewed by Mark Rowe. · 8c41b5f4
      weinig@apple.com authored
              - Disable the back/forward cache using the new WebPreferences API
                instead of through the BackForwardList.  This makes us match what
                we do on Windows.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (createWebViewAndOffscreenWindow):
              (setDefaultsToConsistentValuesForTesting):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c41b5f4
  30. 11 Dec, 2007 1 commit
    • beidson@apple.com's avatar
      Reviewed by Anders · 774a1659
      beidson@apple.com authored
              Make DumpRenderTree on mac use its own path for Databases testing
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
                for future DRT-only use, then use it to construct the Databases path and set that default
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      774a1659
  31. 27 Nov, 2007 1 commit