1. 09 Feb, 2012 2 commits
    • haraken@chromium.org's avatar
      Rename [Optional=CallWithDefaultValue] and [Optional=CallWithNullValue] · 18d2e414
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78200
      
      Reviewed by Adam Barth.
      
      [Optional=CallWithDefaultValue] and [Optional=CallWithNullValue] are confusing.
      
      - [Optional=CallWithDefaultValue] indicates that a missing value should be treated
      as if the JavaScript undefined is passed.
      - [Optional=CallWithNullValue] indicates that a missing value should be treated as
      the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).
      - Actually, the difference between [Optional=CallWithDefaultValue] and
      [Optional=CallWithNullValue] will appear only when the type of the missing value
      is DOMString. In case of [Optional=CallWithDefaultValue], the missing value is
      converted to the string "undefined". On the other hand, in case of
      [Optional=CallWithNullValue], the missing value is converted to the WebKit null string.
      
      With these observations, this patch renames as follows:
      
      - Rename [Optional=CallWithDefaultValue] to [Optional=DefaultIsUndefined].
      - Rename [Optional=CallWithNullValue] to [Optional=DefaultIsNullString].
      
      Test: bindings/scripts/test/TestObj.idl
      
      * bindings/js/JSDOMBinding.h: Renamed MissingIsEmpty to DefaultIsNullString,
      renamed MissingIsUndefined to DefaultIsUndefined.
      * bindings/v8/V8Binding.h: Ditto.
      * bindings/v8/custom/V8BindingMacros.h: Ditto.
      
      * bindings/scripts/CodeGeneratorJS.pm: Modified to support the renaming.
      (GenerateParametersCheck):
      * bindings/scripts/CodeGeneratorV8.pm: Ditto.
      (GenerateParametersCheck):
      (RequiresCustomSignature):
      
      * bindings/scripts/test/TestObj.idl: Renamed [Optional=...] as described above.
      * bindings/scripts/test/TestInterface.idl: Ditto.
      * bindings/scripts/test/TestNamedConstructor.idl: Ditto.
      
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
      (WebDOMTestObj::methodWithOptionalString):
      (WebDOMTestObj::methodWithOptionalStringIsUndefinedString):
      (WebDOMTestObj::methodWithOptionalStringIsNullString):
      * bindings/scripts/test/CPP/WebDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      (webkit_dom_test_obj_method_with_optional_string):
      (webkit_dom_test_obj_method_with_optional_string_is_undefined_string):
      (webkit_dom_test_obj_method_with_optional_string_is_null_string):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      (WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefinedString):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
      * bindings/scripts/test/JS/JSTestObj.h:
      (WebCore):
      * bindings/scripts/test/ObjC/DOMTestObj.h:
      * bindings/scripts/test/ObjC/DOMTestObj.mm:
      (-[DOMTestObj methodWithOptionalString:]):
      (-[DOMTestObj methodWithOptionalStringIsUndefinedString:]):
      (-[DOMTestObj methodWithOptionalStringIsNullString:]):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore::V8TestNamedConstructorConstructorCallback):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::methodWithOptionalStringCallback):
      (TestObjInternal):
      (WebCore::TestObjInternal::methodWithOptionalStringIsUndefinedStringCallback):
      (WebCore::TestObjInternal::methodWithOptionalStringIsNullStringCallback):
      (WebCore):
      
      * Modules/gamepad/GamepadList.idl: Renamed [Optional=...] as described above.
      * Modules/intents/Intent.idl:
      * css/CSSMediaRule.idl:
      * css/CSSPrimitiveValue.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSValueList.idl:
      * css/MediaList.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSMatrix.idl:
      * dom/CharacterData.idl:
      * dom/ClientRectList.idl:
      * dom/CompositionEvent.idl:
      * dom/CustomEvent.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMStringList.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/DeviceMotionEvent.idl:
      * dom/DeviceOrientationEvent.idl:
      * dom/Document.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/HashChangeEvent.idl:
      * dom/KeyboardEvent.idl:
      * dom/MessageEvent.idl:
      * dom/MouseEvent.idl:
      * dom/MutationEvent.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeList.idl:
      * dom/OverflowEvent.idl:
      * dom/Range.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * dom/TextEvent.idl:
      * dom/TouchEvent.idl:
      * dom/UIEvent.idl:
      * dom/WheelEvent.idl:
      * html/DOMFormData.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLOptionElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLTableElement.idl:
      * html/HTMLTableRowElement.idl:
      * html/HTMLTableSectionElement.idl:
      * html/HTMLTextAreaElement.idl:
      * html/TextTrackCue.idl:
      * html/canvas/CanvasGradient.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * page/Console.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/IDBDatabase.idl:
      * storage/StorageEvent.idl:
      * svg/ElementTimeControl.idl:
      * svg/SVGDocument.idl:
      * svg/SVGElementInstanceList.idl:
      * svg/SVGFEDropShadowElement.idl:
      * svg/SVGFEGaussianBlurElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFilterElement.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGMarkerElement.idl:
      * svg/SVGPathElement.idl:
      * svg/SVGSVGElement.idl:
      * svg/SVGStylable.idl:
      * svg/SVGTests.idl:
      * svg/SVGTextContentElement.idl:
      * webaudio/AudioNode.idl:
      * workers/SharedWorker.idl:
      * workers/WorkerContext.idl:
      * xml/DOMParser.idl:
      * xml/XMLSerializer.idl:
      * xml/XPathEvaluator.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      * xml/XPathResult.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18d2e414
    • haraken@chromium.org's avatar
      Unreviewed, rolling out r107182, r107186, r107189, r107191, · a5566bbd
      haraken@chromium.org authored
      and r107199.
      http://trac.webkit.org/changeset/107182
      http://trac.webkit.org/changeset/107186
      http://trac.webkit.org/changeset/107189
      http://trac.webkit.org/changeset/107191
      http://trac.webkit.org/changeset/107199
      https://bugs.webkit.org/show_bug.cgi?id=78200
      
      Layout tests of JSC-related port are crashing
      
      * Modules/gamepad/GamepadList.idl:
      * Modules/intents/Intent.idl:
      * bindings/js/JSDOMBinding.h:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateParametersCheck):
      (NativeToJSValue):
      (GenerateConstructorDefinition):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateParametersCheck):
      (GenerateImplementationIndexer):
      (RequiresCustomSignature):
      (NativeToJSValue):
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp:
      * bindings/scripts/test/CPP/WebDOMTestObj.h:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
      * bindings/scripts/test/JS/JSFloat64Array.cpp:
      (WebCore::jsFloat64ArrayPrototypeFunctionFoo):
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
      (WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
      (WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
      (WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
      * bindings/scripts/test/JS/JSTestEventTarget.cpp:
      (WebCore::jsTestEventTargetPrototypeFunctionItem):
      (WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
      (WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      (WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore):
      (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
      (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
      (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
      (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
      (WebCore::jsTestObjPrototypeFunctionSerializedValue):
      (WebCore::jsTestObjPrototypeFunctionIdbKey):
      (WebCore::jsTestObjPrototypeFunctionOptionsObject):
      (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
      (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
      (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
      (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
      (WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
      (WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
      (WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
      (WebCore::jsTestObjPrototypeFunctionConvert1):
      (WebCore::jsTestObjPrototypeFunctionConvert2):
      (WebCore::jsTestObjPrototypeFunctionConvert3):
      (WebCore::jsTestObjPrototypeFunctionConvert4):
      (WebCore::jsTestObjPrototypeFunctionConvert5):
      (WebCore::jsTestObjPrototypeFunctionStrictFunction):
      * bindings/scripts/test/JS/JSTestObj.h:
      (WebCore):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
      * bindings/scripts/test/ObjC/DOMTestObj.h:
      * bindings/scripts/test/ObjC/DOMTestObj.mm:
      * bindings/scripts/test/TestInterface.idl:
      * bindings/scripts/test/TestNamedConstructor.idl:
      * bindings/scripts/test/TestObj.idl:
      * bindings/scripts/test/V8/V8Float64Array.cpp:
      (WebCore::Float64ArrayInternal::fooCallback):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
      (WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
      (WebCore::TestActiveDOMObjectInternal::postMessageCallback):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
      (WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
      * bindings/scripts/test/V8/V8TestEventTarget.cpp:
      (WebCore::TestEventTargetInternal::itemCallback):
      (WebCore::TestEventTargetInternal::dispatchEventCallback):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::TestInterfaceInternal::supplementalMethod2Callback):
      (WebCore::V8TestInterface::constructorCallback):
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
      (WebCore::TestMediaQueryListListenerInternal::methodCallback):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore::V8TestNamedConstructorConstructorCallback):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore::TestObjInternal::voidMethodWithArgsCallback):
      (WebCore::TestObjInternal::intMethodWithArgsCallback):
      (WebCore::TestObjInternal::objMethodWithArgsCallback):
      (WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
      (WebCore::TestObjInternal::idbKeyCallback):
      (WebCore::TestObjInternal::optionsObjectCallback):
      (WebCore::TestObjInternal::customArgsAndExceptionCallback):
      (WebCore::TestObjInternal::methodWithOptionalArgCallback):
      (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
      (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
      (WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
      (WebCore::TestObjInternal::overloadedMethod1Callback):
      (WebCore::TestObjInternal::overloadedMethod2Callback):
      (WebCore::TestObjInternal::overloadedMethod3Callback):
      (WebCore::TestObjInternal::overloadedMethod4Callback):
      (WebCore::TestObjInternal::overloadedMethod6Callback):
      (WebCore::TestObjInternal::overloadedMethod7Callback):
      (WebCore::TestObjInternal::classMethodWithOptionalCallback):
      (WebCore::TestObjInternal::overloadedMethod11Callback):
      (WebCore::TestObjInternal::overloadedMethod12Callback):
      (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
      (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
      (WebCore::TestObjInternal::convert1Callback):
      (WebCore::TestObjInternal::convert2Callback):
      (WebCore::TestObjInternal::convert3Callback):
      (WebCore::TestObjInternal::convert4Callback):
      (WebCore::TestObjInternal::convert5Callback):
      (WebCore::TestObjInternal::strictFunctionCallback):
      (WebCore):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
      (WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
      * bindings/v8/V8Binding.h:
      * bindings/v8/custom/V8BindingMacros.h:
      * css/CSSCharsetRule.idl:
      * css/CSSImportRule.idl:
      * css/CSSMediaRule.idl:
      * css/CSSPageRule.idl:
      * css/CSSPrimitiveValue.idl:
      * css/CSSRule.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleRule.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSValue.idl:
      * css/CSSValueList.idl:
      * css/MediaList.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheet.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSMatrix.idl:
      * dom/Attr.idl:
      * dom/CharacterData.idl:
      * dom/ClientRectList.idl:
      * dom/Clipboard.idl:
      * dom/CompositionEvent.idl:
      * dom/CustomEvent.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMStringList.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/DeviceMotionEvent.idl:
      * dom/DeviceOrientationEvent.idl:
      * dom/Document.idl:
      * dom/DocumentType.idl:
      * dom/Element.idl:
      * dom/Entity.idl:
      * dom/Event.idl:
      * dom/HashChangeEvent.idl:
      * dom/KeyboardEvent.idl:
      * dom/MessageEvent.idl:
      * dom/MouseEvent.idl:
      * dom/MutationEvent.idl:
      * dom/MutationRecord.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeList.idl:
      * dom/Notation.idl:
      * dom/OverflowEvent.idl:
      * dom/ProcessingInstruction.idl:
      * dom/Range.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * dom/TextEvent.idl:
      * dom/TouchEvent.idl:
      * dom/UIEvent.idl:
      * dom/WheelEvent.idl:
      * html/DOMFormData.idl:
      * html/DOMTokenList.idl:
      * html/DOMURL.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLOptionElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLTableElement.idl:
      * html/HTMLTableRowElement.idl:
      * html/HTMLTableSectionElement.idl:
      * html/HTMLTextAreaElement.idl:
      * html/TextTrackCue.idl:
      * html/canvas/CanvasGradient.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/canvas/WebGLDebugShaders.idl:
      * html/canvas/WebGLRenderingContext.idl:
      * page/Console.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/IDBDatabase.idl:
      * storage/IDBObjectStore.idl:
      * storage/IDBRequest.idl:
      * storage/Storage.idl:
      * storage/StorageEvent.idl:
      * svg/ElementTimeControl.idl:
      * svg/SVGDocument.idl:
      * svg/SVGElementInstanceList.idl:
      * svg/SVGFEDropShadowElement.idl:
      * svg/SVGFEGaussianBlurElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFilterElement.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGMarkerElement.idl:
      * svg/SVGPathElement.idl:
      * svg/SVGSVGElement.idl:
      * svg/SVGStylable.idl:
      * svg/SVGTests.idl:
      * svg/SVGTextContentElement.idl:
      * webaudio/AudioNode.idl:
      * websockets/WebSocket.idl:
      * workers/SharedWorker.idl:
      * workers/WorkerContext.idl:
      * xml/DOMParser.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XMLSerializer.idl:
      * xml/XPathEvaluator.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      * xml/XPathResult.idl:
      * xml/XSLTProcessor.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5566bbd
  2. 08 Feb, 2012 1 commit
    • haraken@chromium.org's avatar
      Rename [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue] · c76764bd
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78200
      
      Reviewed by Adam Barth.
      
      [Optional=CallWithDefalutValue] and [Optional=CallWithNullValue] are confusing.
      
      - [Optional=CallWithDefalutValue] indicates that a missing value should be treated
      as if the JavaScript undefined is passed.
      - [Optional=CallWithNullValue] indicates that a missing value should be treated as
      the WebKit null value (i.e. JSValue() or v8::Local<v8::Value>()).
      - Actually, the difference between [Optional=CallWithDefalutValue] and
      [Optional=CallWithNullValue] appears only when the type of the missing value is DOMString.
      In case of [Optional=CallWithDefalutValue], the missing value is converted to the string
      "undefined". On the other hand, in case of [Optional=CallWithNullValue], the missing
      value is converted to the WebKit null string.
      
      With these observations, this patch renames them as follows:
      
      - Rename [Optional=CallWithDefalutValue] to [Optional=TreatAsUndefined].
      - Remove [Optional=CallWithNullValue]. Instead, we use
      [Optional=TreatAsUndefined, TreatUndefinedAs=NullString].
      
      Test: bindings/scripts/test/TestInterface.idl
      
      * bindings/js/JSDOMBinding.h: Renamed MissingIsUndefined to MissingIsUndefinedValue,
      renamed MissingIsEmpty to MissingIsNullValue.
      * bindings/v8/V8Binding.h: Ditto.
      * bindings/v8/custom/V8BindingMacros.h: Ditto.
      
      * bindings/scripts/CodeGeneratorJS.pm: Modified to support the IDL attribute renaming.
      (GenerateParametersCheck):
      (GenerateConstructorDefinition):
      * bindings/scripts/CodeGeneratorV8.pm: Ditto.
      (GenerateParametersCheck):
      (RequiresCustomSignature):
      
      * Modules/gamepad/GamepadList.idl: Renamed IDL attributes as described above.
      * Modules/intents/Intent.idl:
      * css/CSSMediaRule.idl:
      * css/CSSPrimitiveValue.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSStyleSheet.idl:
      * css/CSSValueList.idl:
      * css/MediaList.idl:
      * css/MediaQueryList.idl:
      * css/MediaQueryListListener.idl:
      * css/StyleMedia.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSMatrix.idl:
      * dom/CharacterData.idl:
      * dom/ClientRectList.idl:
      * dom/CompositionEvent.idl:
      * dom/CustomEvent.idl:
      * dom/DOMImplementation.idl:
      * dom/DOMStringList.idl:
      * dom/DataTransferItem.idl:
      * dom/DataTransferItemList.idl:
      * dom/DeviceMotionEvent.idl:
      * dom/DeviceOrientationEvent.idl:
      * dom/Document.idl:
      * dom/Element.idl:
      * dom/Event.idl:
      * dom/HashChangeEvent.idl:
      * dom/KeyboardEvent.idl:
      * dom/MessageEvent.idl:
      * dom/MouseEvent.idl:
      * dom/MutationEvent.idl:
      * dom/NamedNodeMap.idl:
      * dom/Node.idl:
      * dom/NodeFilter.idl:
      * dom/NodeList.idl:
      * dom/OverflowEvent.idl:
      * dom/Range.idl:
      * dom/ShadowRoot.idl:
      * dom/Text.idl:
      * dom/TextEvent.idl:
      * dom/TouchEvent.idl:
      * dom/UIEvent.idl:
      * dom/WheelEvent.idl:
      * html/DOMFormData.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLAudioElement.idl:
      * html/HTMLCanvasElement.idl:
      * html/HTMLCollection.idl:
      * html/HTMLDocument.idl:
      * html/HTMLElement.idl:
      * html/HTMLInputElement.idl:
      * html/HTMLMediaElement.idl:
      * html/HTMLOptionElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/HTMLTableElement.idl:
      * html/HTMLTableRowElement.idl:
      * html/HTMLTableSectionElement.idl:
      * html/HTMLTextAreaElement.idl:
      * html/TextTrackCue.idl:
      * html/canvas/CanvasGradient.idl:
      * html/canvas/CanvasRenderingContext2D.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/OESVertexArrayObject.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * page/Console.idl:
      * page/DOMSelection.idl:
      * page/DOMWindow.idl:
      * page/History.idl:
      * page/Location.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/IDBDatabase.idl:
      * storage/StorageEvent.idl:
      * svg/ElementTimeControl.idl:
      * svg/SVGDocument.idl:
      * svg/SVGElementInstanceList.idl:
      * svg/SVGFEDropShadowElement.idl:
      * svg/SVGFEGaussianBlurElement.idl:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFilterElement.idl:
      * svg/SVGLocatable.idl:
      * svg/SVGMarkerElement.idl:
      * svg/SVGPathElement.idl:
      * svg/SVGSVGElement.idl:
      * svg/SVGStylable.idl:
      * svg/SVGTests.idl:
      * svg/SVGTextContentElement.idl:
      * webaudio/AudioNode.idl:
      * workers/SharedWorker.idl:
      * workers/WorkerContext.idl:
      * xml/DOMParser.idl:
      * xml/XMLSerializer.idl:
      * xml/XPathEvaluator.idl:
      * xml/XPathExpression.idl:
      * xml/XPathNSResolver.idl:
      * xml/XPathResult.idl:
      
      * bindings/scripts/test/TestInterface.idl: Added test cases for [Optional],
      [Optional=TreatAsUndefined] and [Optional=TreatAsUndefined, TreatUndefinedAs=NullString]
      * bindings/scripts/test/TestNamedConstructor.idl: Renamed IDL attributes as described above.
      * bindings/scripts/test/TestObj.idl: Ditto.
      
      * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
      (WebDOMTestObj::methodWithOptionalString):
      (WebDOMTestObj::methodWithOptionalIsTreatAsUndefinedString):
      (WebDOMTestObj::methodWithOptionalIsNullStringString):
      * bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
      * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
      (webkit_dom_test_obj_method_with_optional_string):
      (webkit_dom_test_obj_method_with_optional_is_treat_as_undefined_string):
      (webkit_dom_test_obj_method_with_optional_is_null_string_string):
      * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
      * bindings/scripts/test/JS/JSFloat64Array.cpp: Ditto.
      (WebCore::jsFloat64ArrayPrototypeFunctionFoo):
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Ditto.
      (WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
      (WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
      (WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
      * bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
      (WebCore::jsTestEventTargetPrototypeFunctionItem):
      (WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
      * bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
      (WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
      (WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
      (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
      (WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
      * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
      (WebCore):
      (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
      (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
      (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
      (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
      (WebCore::jsTestObjPrototypeFunctionSerializedValue):
      (WebCore::jsTestObjPrototypeFunctionIdbKey):
      (WebCore::jsTestObjPrototypeFunctionOptionsObject):
      (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
      (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
      (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsTreatAsUndefinedString):
      (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalIsNullStringString):
      (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
      (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
      (WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
      (WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
      (WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
      (WebCore::jsTestObjPrototypeFunctionConvert1):
      (WebCore::jsTestObjPrototypeFunctionConvert2):
      (WebCore::jsTestObjPrototypeFunctionConvert3):
      (WebCore::jsTestObjPrototypeFunctionConvert4):
      (WebCore::jsTestObjPrototypeFunctionConvert5):
      (WebCore::jsTestObjPrototypeFunctionStrictFunction):
      * bindings/scripts/test/JS/JSTestObj.h: Ditto.
      (WebCore):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
      (WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
      * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
      * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
      (-[DOMTestObj methodWithOptionalString:]):
      (-[DOMTestObj methodWithOptionalIsTreatAsUndefinedString:]):
      (-[DOMTestObj methodWithOptionalIsNullStringString:]):
      * bindings/scripts/test/V8/V8Float64Array.cpp: Ditto.
      (WebCore::Float64ArrayInternal::fooCallback):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp: Ditto.
      (WebCore::TestActiveDOMObjectInternal::excitingFunctionCallback):
      (WebCore::TestActiveDOMObjectInternal::postMessageCallback):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp: Ditto.
      (WebCore::TestCustomNamedGetterInternal::anotherFunctionCallback):
      * bindings/scripts/test/V8/V8TestEventTarget.cpp: Ditto.
      (WebCore::TestEventTargetInternal::itemCallback):
      (WebCore::TestEventTargetInternal::dispatchEventCallback):
      * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
      (WebCore::TestInterfaceInternal::supplementalMethod2Callback):
      (WebCore::V8TestInterface::constructorCallback):
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.
      (WebCore::TestMediaQueryListListenerInternal::methodCallback):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp: Ditto.
      (WebCore::V8TestNamedConstructorConstructorCallback):
      * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
      (WebCore::TestObjInternal::voidMethodWithArgsCallback):
      (WebCore::TestObjInternal::intMethodWithArgsCallback):
      (WebCore::TestObjInternal::objMethodWithArgsCallback):
      (WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
      (WebCore::TestObjInternal::idbKeyCallback):
      (WebCore::TestObjInternal::optionsObjectCallback):
      (WebCore::TestObjInternal::customArgsAndExceptionCallback):
      (WebCore::TestObjInternal::methodWithOptionalArgCallback):
      (WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
      (WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
      (WebCore::TestObjInternal::methodWithOptionalStringCallback):
      (TestObjInternal):
      (WebCore::TestObjInternal::methodWithOptionalIsTreatAsUndefinedStringCallback):
      (WebCore::TestObjInternal::methodWithOptionalIsNullStringStringCallback):
      (WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
      (WebCore::TestObjInternal::overloadedMethod1Callback):
      (WebCore::TestObjInternal::overloadedMethod2Callback):
      (WebCore::TestObjInternal::overloadedMethod3Callback):
      (WebCore::TestObjInternal::overloadedMethod4Callback):
      (WebCore::TestObjInternal::overloadedMethod6Callback):
      (WebCore::TestObjInternal::overloadedMethod7Callback):
      (WebCore::TestObjInternal::classMethodWithOptionalCallback):
      (WebCore::TestObjInternal::overloadedMethod11Callback):
      (WebCore::TestObjInternal::overloadedMethod12Callback):
      (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback):
      (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback):
      (WebCore::TestObjInternal::convert1Callback):
      (WebCore::TestObjInternal::convert2Callback):
      (WebCore::TestObjInternal::convert3Callback):
      (WebCore::TestObjInternal::convert4Callback):
      (WebCore::TestObjInternal::convert5Callback):
      (WebCore::TestObjInternal::strictFunctionCallback):
      (WebCore):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp: Ditto.
      (WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c76764bd
  3. 06 Feb, 2012 1 commit
    • haraken@chromium.org's avatar
      Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs · 6d052a1e
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77848
      
      Reviewed by Adam Barth.
      
      For naming consistency with [CustomGetter] and [CustomSetter],
      this patch renames the following IDLs:
      
      [HasIndexGetter] => [IndexedGetter]  (Remove "Has". This IDL is for "indexed" properties
      in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
      [HasCustomIndexSetter] => [CustomIndexedSetter]  (Ditto.)
      [HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
      in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertySlotBody):
      (GenerateGetOwnPropertyDescriptorBody):
      (GenerateHeader):
      (GenerateImplementation):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeaderNamedAndIndexedPropertyAccessors):
      (GenerateImplementationIndexer):
      (GenerateImplementationNamedPropertyGetter):
      
      * bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
      * bindings/scripts/test/TestTypedArray.idl: Ditto.
      
      * Modules/gamepad/GamepadList.idl:
      * css/CSSRuleList.idl:
      * css/CSSStyleDeclaration.idl:
      * css/CSSValueList.idl:
      * css/MediaList.idl:
      * css/StyleSheetList.idl:
      * css/WebKitCSSFilterValue.idl:
      * css/WebKitCSSKeyframesRule.idl:
      * css/WebKitCSSTransformValue.idl:
      * dom/ClientRectList.idl:
      * dom/DOMStringList.idl:
      * dom/DOMStringMap.idl:
      * dom/DataTransferItemList.idl:
      * dom/NamedNodeMap.idl:
      * dom/NodeList.idl:
      * dom/TouchList.idl:
      * fileapi/EntryArray.idl:
      * fileapi/EntryArraySync.idl:
      * fileapi/FileList.idl:
      * html/DOMSettableTokenList.idl:
      * html/DOMTokenList.idl:
      * html/HTMLAllCollection.idl:
      * html/HTMLCollection.idl:
      * html/HTMLFormElement.idl:
      * html/HTMLOptionsCollection.idl:
      * html/HTMLPropertiesCollection.idl:
      * html/HTMLSelectElement.idl:
      * html/TextTrackCueList.idl:
      * html/canvas/CanvasPixelArray.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/canvas/Uint8ClampedArray.idl:
      * html/track/TextTrackList.idl:
      * mediastream/MediaStreamList.idl:
      * mediastream/MediaStreamTrackList.idl:
      * page/SpeechInputResultList.idl:
      * page/WebKitAnimationList.idl:
      * plugins/DOMMimeTypeArray.idl:
      * plugins/DOMPlugin.idl:
      * plugins/DOMPluginArray.idl:
      * storage/Storage.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d052a1e
  4. 21 Nov, 2011 1 commit
  5. 19 Nov, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Move gamepad to Modules/ (+ some cleanup) · 963ac560
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72785
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-11-19
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Move main files from page/ to Modules/gamepad/. #include guard the
      gamepad header inclusions in Navigator.cpp to avoid including for
      ports that do not enable GAMEPAD.
      
      * Modules/gamepad/Gamepad.cpp: Renamed from Source/WebCore/page/Gamepad.cpp.
      (WebCore::Gamepad::Gamepad):
      (WebCore::Gamepad::axes):
      (WebCore::Gamepad::buttons):
      (WebCore::Gamepad::~Gamepad):
      * Modules/gamepad/Gamepad.h: Renamed from Source/WebCore/page/Gamepad.h.
      * Modules/gamepad/Gamepad.idl: Renamed from Source/WebCore/page/Gamepad.idl.
      * Modules/gamepad/GamepadList.cpp: Renamed from Source/WebCore/page/GamepadList.cpp.
      (WebCore::GamepadList::~GamepadList):
      (WebCore::GamepadList::set):
      (WebCore::GamepadList::length):
      (WebCore::GamepadList::item):
      * Modules/gamepad/GamepadList.h: Renamed from Source/WebCore/page/GamepadList.h.
      (WebCore::GamepadList::create):
      (WebCore::GamepadList::GamepadList):
      * Modules/gamepad/GamepadList.idl: Renamed from Source/WebCore/page/GamepadList.idl.
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * page/Navigator.cpp:
      
      LayoutTests:
      
      Use standard pre/post js test harness rather than custom one.
      
      * gamepad/gamepad-api-expected.txt:
      * gamepad/gamepad-api.html:
      * gamepad/gamepad-test.js: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      963ac560
  6. 18 Nov, 2011 1 commit
    • commit-queue@webkit.org's avatar
      IDL changes for gamepad support · 0ef17682
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71753
      
      Patch by Scott Graham <scottmg@chromium.org> on 2011-11-18
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      IDL changes and associated plumbing to expose list of gamepad objects
      on navigator object (per current spec). Full patch is
      https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
      test until more plumbing in future patches.
      
      Test: gamepad/gamepad-api.html
      
      * WebCore.gypi:
      * bindings/generic/RuntimeEnabledFeatures.h:
      (WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
      (WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):
      * page/Gamepad.cpp: Added.
      (WebCore::Gamepad::Gamepad):
      (WebCore::Gamepad::axes):
      (WebCore::Gamepad::buttons):
      (WebCore::Gamepad::~Gamepad):
      * page/Gamepad.h: Added.
      * page/Gamepad.idl: Added.
      * page/GamepadList.cpp: Added.
      (WebCore::GamepadList::~GamepadList):
      (WebCore::GamepadList::set):
      (WebCore::GamepadList::length):
      (WebCore::GamepadList::item):
      * page/GamepadList.h: Added.
      (WebCore::GamepadList::create):
      (WebCore::GamepadList::GamepadList):
      * page/GamepadList.idl: Added.
      * page/Navigator.cpp:
      (WebCore::Navigator::webkitGamepads):
      * page/Navigator.h:
      * page/Navigator.idl:
      
      Source/WebKit/chromium:
      
      Update to use vendor-prefixed enable.
      
      * src/WebRuntimeFeatures.cpp:
      (WebKit::WebRuntimeFeatures::enableGamepad):
      (WebKit::WebRuntimeFeatures::isGamepadEnabled):
      
      Tools:
      
      Runtime enable gamepad in chromium test shell.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::TestShell):
      
      LayoutTests:
      
      Add basic api existence test.
      
      * gamepad/gamepad-api-expected.txt: Added.
      * gamepad/gamepad-api.html: Added.
      * gamepad/gamepad-test.js: Added.
      (logConsole):
      (testExpected):
      (reportExpected):
      (waitForEventAndEnd):
      (waitForEvent._eventCallback):
      (waitForEvent):
      (waitForEventAndTest._eventCallback):
      (waitForEventAndTest):
      (waitForEventTestAndEnd):
      (endTest):
      (logResult):
      (consoleWrite):
      * platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
      * platform/efl/Skipped:
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      * platform/wincairo/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ef17682