1. 31 Jan, 2008 5 commits
    • justin.garcia@apple.com's avatar
      WebCore: · 25222377
      justin.garcia@apple.com authored
              Reviewed by Darin Adler.
              
              <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
      
              * page/mac/WebCoreFrameBridge.h: Re-exposed smartInsertForString:, it's used by a WebKit method used by Mail.
      
      WebKit/mac:
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought 
              this back, it's used by Mail.
              (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
              also used by Mail.  Moved to WebPrivate.
              * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
              accidently remove them in the future.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25222377
    • aroben@apple.com's avatar
      Add line box drawing code to InspectorController::drawNodeHighlight · 1c699690
      aroben@apple.com authored
              This makes drawNodeHighlight a complete replacement for the painting
              code in WebKit/mac/WebNodeHighlightView.mm, and also brings line box
              rects to Windows for the first time.
      
              Reviewed by Darin.
      
              * dom/Node.h: Changed isSVGElement to always exist, but to only be
              virtual when ENABLE(SVG) is true. This way you can always call
              node->isSVGElement() without checking ENABLE(SVG).
              * page/InspectorController.cpp:
              (WebCore::InspectorController::drawNodeHighlight): Ported line box
              rect code from the Mac implementation in WebNodeHighlightView.mm.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c699690
    • aroben@apple.com's avatar
      Let WebCore take care of the highlight drawing entirely · c141692a
      aroben@apple.com authored
       WebCore:
      
               Put more knowledge about the node highlight in WebCore
      
               InspectorController now calculates the overlay rect and node rect when
               drawing the node highlight instead of having them be passed in.
               InspectorController now holds onto the highlighted node so that it can
               determine these rects.
      
               Once all platforms are calling down to drawNodeHighlight instead of
               drawing the highlight themselves, we can change
               InspectorClient::highlight(Node*) to something like
               InspectorClient::updateAndShowHighlight().
      
               This also fixes Bug 14264: Node highlight makes it impossible to
               scroll the page
               <http://bugs.webkit.org/show_bug.cgi?id=14264>
               <rdar://5712788>
      
               Reviewed by Darin.
      
               * page/InspectorController.cpp:
               (WebCore::InspectorController::highlight): Store the node for use in
               drawNodeHighlight.
               (WebCore::InspectorController::drawNodeHighlight): Changed to be a
               const instance method. Now calculates the overlay rect and node rect
               instead of having them passed in.
               * page/InspectorController.h:
      
       WebKit/win:
      
               Let WebCore take care of the highlight drawing entirely
      
               Reviewed by Darin.
      
               * WebInspectorClient.cpp:
               (WebInspectorClient::highlight): We now just show our highlight
               window and let WebCore figure out what/where to paint. Once all ports
               follow suit the Node* parameter to this method should be removed
               entirely, and the name should probably change to
               updateAndShowHighlight or something similar.
               * WebNodeHighlight.cpp: Renamed m_webView to m_inspectedWebViewWindow.
               (WebNodeHighlight::WebNodeHighlight): Now takes a WebView* parameter.
               (WebNodeHighlight::show): Renamed from highlight(). Now gets the
               WebView's HWND. Updated for member rename/removal.
               (WebNodeHighlight::updateWindow): Updated for member rename and for
               InspectorController changes.
               * WebNodeHighlight.h: Added m_inspectedWebView member, removed m_rect
               member, renamed highlight(Node*) -> show().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c141692a
    • aroben@apple.com's avatar
      Move node highlight drawing code to WebCore · 5590d84b
      aroben@apple.com authored
       WebCore:
      
               Add node highlight drawing code to InspectorController
      
               The code came from WebKit/win/WebNodeHighlight.cpp. It's not quite as
               complete as the Mac implementation (in particular, it doesn't handle
               line-box rects), but it's a start.
      
               Reviewed by Darin.
      
               * page/InspectorController.cpp:
               (WebCore::InspectorController::drawNodeHighlight): Added.
               * page/InspectorController.h:
      
       WebKit/win:
      
               Move node highlight drawing code to WebCore
      
               Reviewed by Darin.
      
               * WebNodeHighlight.cpp:
               (WebNodeHighlight::updateWindow): Call into WebCore to do the node
               highlight drawing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5590d84b
    • mitz@apple.com's avatar
      WebCore: · 1d9f3043
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17107
                <rdar://problem/5716722> REGRESSION (r29834): Article text on redhat.com magazine site appears to be painting twice
      
              Test: fast/block/float/intruding-painted-twice.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock): Pass 'false' for the new
              makeChildPaintOtherFloats parameter to addOverhangingFloats() because at
              this point we are only taking away floats from the child.
              (WebCore::RenderBlock::layoutBlockChildren): Pass 'true' for the new
              makeChildPaintOtherFloats parameter to addOverhangingFloats() iff the
              child was not laid out again. Only in that case, it may have overhanging
              floats that it does not paint because they used to be overhanging from
              the parent, but now they are not.
              (WebCore::RenderBlock::addOverhangingFloats): Refined the conditions for
              making the child paint the float: require that the float be a descendant
              of the child (the other case is when it intrudes into the child from
              another sibling) and that it does not have a layer (in which case it
              paints itself). In addition, do the check only if the caller passed
              'true' for the makeChildPaintOtherFloats parameter.
              * rendering/RenderBlock.h:
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - pixel test for http://bugs.webkit.org/show_bug.cgi?id=17107
                <rdar://problem/5716722> REGRESSION (r29834): Article text on redhat.com magazine site appears to be painting twice
      
              * fast/block/float/intruding-painted-twice.html: Added.
              * platform/mac-leopard/fast/block/float/intruding-painted-twice-expected.checksum: Added.
              * platform/mac-leopard/fast/block/float/intruding-painted-twice-expected.png: Added.
              * platform/mac/fast/block/float/intruding-painted-twice-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d9f3043
  2. 30 Jan, 2008 16 commits
    • mitz@apple.com's avatar
      WebCore: · 94d9dc04
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - change the interpretation of unicode-range values in "from-to" form
                to include the "to" character.
      
              Test: fast/css/font-face-unicode-range.html
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseFontFaceUnicodeRange):
              * css/CSSSegmentedFontFace.cpp:
              (WebCore::CSSSegmentedFontFace::overlayRange):
              * platform/graphics/GlyphPageTreeNode.cpp:
              (WebCore::GlyphPageTreeNode::initializePage):
              * platform/graphics/SegmentedFontData.cpp:
              (WebCore::SegmentedFontData::fontDataForCharacter):
              (WebCore::SegmentedFontData::containsCharacters):
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - add a test for the unicode-range @font-face property
              - update @font-face rules in existing tests after changing unicode-range
                values in "from-to" form to include the "to" character
      
              * fast/css/font-face-unicode-range.html: Added.
              * fast/css/rtl-ordering.html:
              * fast/text/international/resources/Mac-compatible-font-fallback.css:
              * platform/mac-leopard/fast/css/font-face-unicode-range-expected.checksum: Added.
              * platform/mac-leopard/fast/css/font-face-unicode-range-expected.png: Added.
              * platform/mac/fast/css/font-face-unicode-range-expected.txt: Added.
              * platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94d9dc04
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · a8b70a23
      mitz@apple.com authored
              - prune references to custom fonts' SimpleFontData from the glyph page
                tree when they are destroyed
      
              * css/CSSFontFaceSource.cpp:
              (WebCore::CSSFontFaceSource::pruneTable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8b70a23
    • justin.garcia@apple.com's avatar
      This test started failed with my last checkin. The new results are *correct*... · 11ab3c01
      justin.garcia@apple.com authored
      This test started failed with my last checkin.  The new results are *correct* but I don't know why my changes would have fixed the test, so I want to investigate a bit before I check in new results.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11ab3c01
    • timothy@apple.com's avatar
      Reviewed by Tim Hatcher. · 9b885fbb
      timothy@apple.com authored
              New fix for <rdar://problem/5688428> Reproducible assertion failure
              in SQLTransaction::performNextStep() (16876)
      
              Fixes a deadlock that was happening for all Database use. All
              storage layout tests pass.
      
              * storage/Database.cpp:
              (WebCore::CurrentThreadSetter::CurrentThreadSetter): New helper class
              to set the current thread and zero it on destruction.
              (WebCore::CurrentThreadSetter::~CurrentThreadSetter): Set threadIdentifierStorage to 0.
              (WebCore::Database::Database): Set m_transactionStepThread to 0.
              (WebCore::Database::performTransactionStep): Set m_transactionStepThread to currentThread().
              (WebCore::Database::scheduleTransactionCallback): Assert m_transactionStepThread
              is currentThread().
              * storage/Database.h: Add m_transactionStepThread for debug builds
              to track which thread performTransactionStep() was called on. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b885fbb
    • slewis@apple.com's avatar
      2008-01-30 Stephanie <slewis@apple.com> · 1f0a0921
      slewis@apple.com authored
              Reviewed by Geoff.
      
              Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f0a0921
    • timothy@apple.com's avatar
      Reviewed by Darin Adler. · b598623a
      timothy@apple.com authored
              ASSERTION FAILED: JSLock::lockCount() > 0 when opening the
              Web Inspector on a page with a Database.
      
              Fix the ASSERT by taking a JSLock before calling toJS().
      
              * page/InspectorController.cpp:
              (WebCore::InspectorController::addDatabaseScriptResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b598623a
    • bdakin@apple.com's avatar
      Reviewed by Darin. · 2ced6b3d
      bdakin@apple.com authored
              Fix for <rdar://problem/5598609> CrashTracer: [USER] 626 crashes in 
              Safari at com.apple.WebCore: WebCore::FrameView::needsFullRepaint 
              const + 6
      
              The real problem here is tracked by rdar://5598072, which is that 
              frames can lose sync between their view and their document when a 
              non-HTML view is loaded (such as bookmarks view or a PDF). That can 
              cause this crash if the layout timer fires before things have fixed 
              themselves. This fix turns an ASSERT in FrameView::layout() into an 
              early return to cause graceful failure until the root of the 
              problem is addressed. 
      
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ced6b3d
    • justin.garcia@apple.com's avatar
      WebCore: · c2c4e923
      justin.garcia@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline
      
              * editing/FormatBlockCommand.cpp:
              (WebCore::FormatBlockCommand::doApply): If the selected paragraph was empty,
              we may still need to call moveParagrah to remove the line break that holds that
              paragraph open because the new block of the requested type needs to to replace it.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5700414> REGRESSION (Adama-ToT): Selecting "Header 1" style in Leopard Server wiki inserts newline
      
              * editing/execCommand/5700414-1.html: Added.
              * editing/execCommand/5700414-2.html: Added.
              * platform/mac/editing/execCommand/5700414-1-expected.checksum: Added.
              * platform/mac/editing/execCommand/5700414-1-expected.png: Added.
              * platform/mac/editing/execCommand/5700414-1-expected.txt: Added.
              * platform/mac/editing/execCommand/5700414-2-expected.checksum: Added.
              * platform/mac/editing/execCommand/5700414-2-expected.png: Added.
              * platform/mac/editing/execCommand/5700414-2-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2c4e923
    • timothy@apple.com's avatar
      Reviewed by Darin Adler. · b1b3e4ec
      timothy@apple.com authored
              <rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)
      
              Revised fix to use the globalCallbackMutex() mutex and hold the mutex
              for the entire function scope.
      
              * storage/Database.cpp:
              (WebCore::Database::performTransactionStep):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1b3e4ec
    • timothy@apple.com's avatar
      Reviewed by Adam Roben. · 7efe508e
      timothy@apple.com authored
              Make ResourceTreeElement inherit the prototype of TreeElement.
      
              * page/inspector/Resource.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7efe508e
    • jess@apple.com's avatar
      Reviewed by Tim Hatcher. · 1c30fca4
      jess@apple.com authored
              * coding/coding-style.html:
              Adding a note about avoiding explicit nil/NO initialization of Objective-C instance variables.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c30fca4
    • weinig@apple.com's avatar
      Reviewed by Adam Roben. · 8fb8fd2f
      weinig@apple.com authored
              Don't include SecurityOrigin.h in Document.h so that we can avoid massive
              recompilation when changing the SecurityOrigin.
      
              * dom/Document.cpp:
              (WebCore::Document::setSecurityOrigin):
              * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fb8fd2f
    • timothy@apple.com's avatar
      Reviewed by Tim Hatcher and Brady. · 0fdfc912
      timothy@apple.com authored
              <rdar://problem/5688428> Reproducible assertion failure in SQLTransaction::performNextStep() (16876)
      
              * storage/Database.cpp:
              (WebCore::Database::performTransactionStep): Do not perform the next transaction if
              a global callback is already scheduled.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fdfc912
    • jhoneycutt@apple.com's avatar
      2008-01-30 Jon Honeycutt <jhoneycutt@apple.com> · f4ea64f6
      jhoneycutt@apple.com authored
              Reviewed by Darin.
      
              <rdar://problem/5669317> Crash closing pop up window with Real Player
              content
      
              Some RealPlayer versions hang on unload. To prevent this hang, don't
              unload versions since the last known unloadable version.
              <rdar://problem/5713147> tracks revisiting this when the bug in
              RealPlayer is fixed and we can again unload the plug-in.
      
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackageWin::compareFileVersion): Compare the plug-in's
              file version to the passed file version, returning -1, 0, or 1 if the
              plug-in's version is less than, equal to, or greater than the version
              passed.
              (WebCore::PluginPackageWin::isPluginBlacklisted): Use
              compareFileVersion()
              * plugins/win/PluginPackageWin.h:
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginViewWin::determineQuirks): If the plug-in version is
              newer than the last-known unloadable version, add the DontUnloadPlugin
              quirk
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4ea64f6
    • ap@webkit.org's avatar
      Reviewed by Adam Roben. · 041afc1b
      ap@webkit.org authored
              One more debug (external) fix.
      
              * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
              and Debug configurations. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      041afc1b
    • mrowe@apple.com's avatar
      Move off deprecated NSTableView methods. · e4bcd9cc
      mrowe@apple.com authored
      Reviewed by Oliver Hunt.
      
      * WebView/WebHTMLView.mm:
      (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
      (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
      (-[WebTextCompleteController filterKeyDown:]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4bcd9cc
  3. 29 Jan, 2008 19 commits
    • mrowe@apple.com's avatar
      Look for headers relative to NEXT_ROOT so that build-root picks up the... · 1c8a6caa
      mrowe@apple.com authored
      Look for headers relative to NEXT_ROOT so that build-root picks up the WebCoreSQLite version of sqlite3.h rather than the older system version.
      
      Reviewed by Tim Hatcher.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c8a6caa
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 7d343aa3
      mitz@apple.com authored
              - try to make this test more robust on slower machines
      
              * fast/css/font-face-remote.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d343aa3
    • mitz@apple.com's avatar
      - build fix · 0fec5b46
      mitz@apple.com authored
              * loader/CachedFont.cpp:
              (WebCore::CachedFont::CachedFont):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fec5b46
    • mrowe@apple.com's avatar
      Add the correct directory to the header search paths in Production builds. ... · 56cd245f
      mrowe@apple.com authored
      Add the correct directory to the header search paths in Production builds.  Reviewed by Brady Eidson.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56cd245f
    • mitz@apple.com's avatar
      WebCore: · 2eb96ca7
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17085
                <rdar://problem/5714136> REGRESSION (r29839): All remote fonts are treated as SVG fonts
      
              Test: fast/css/font-face-remote.html
      
              Added an isSVGFont method to CachedFont and use it to decide how to
              process the font data. Currently whether the data is SVG is determined
              based on the format property in the @font-face rule, but in the future
              the MIME type or other metadata may be used when the format is
              unspecified.
      
              * css/CSSFontFaceSource.cpp:
              (WebCore::CSSFontFaceSource::getFontData): Changed to parse the data as
              SVG only if the CachedFont is an SVG font.
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::addFontFaceRule): Mark the CachedFont as an
              SVG font based on format.
              * loader/CachedFont.cpp:
              (WebCore::CachedFont::CachedFont): Initialize m_isSVGFont to false.
              (WebCore::CachedFont::ensureCustomFontData):
              (WebCore::CachedFont::ensureSVGFontData):
              (WebCore::CachedFont::getSVGFontById):
              * loader/CachedFont.h:
              (WebCore::CachedFont::isSVGFont): Added.
              (WebCore::CachedFont::setSVGFont): Added.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=17085
                <rdar://problem/5714136> REGRESSION (r29839): All remote fonts are treated as SVG fonts
      
              This is the first @font-face test that actually tests loading font data
              from a URL.
      
              * fast/css/font-face-remote.html: Added.
              * fast/css/resources/Ahem.ttf: Added.
              * platform/mac/fast/css/font-face-remote-expected.checksum: Added.
              * platform/mac/fast/css/font-face-remote-expected.png: Added.
              * platform/mac/fast/css/font-face-remote-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2eb96ca7
    • aroben@apple.com's avatar
      Fix a crash when opening the Inspector · 564f0db6
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebInspectorClient.cpp:
               (WebInspectorClient::createPage): Call
               WebPreferences::initWithIdentifier so our custom WebPreferences will
               have all its members initialized.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      564f0db6
    • aroben@apple.com's avatar
      Fix Bug 16786: "Display images when page opens" preference affects Inspector · c27d7fc1
      aroben@apple.com authored
              <http://bugs.webkit.org/show_bug.cgi?id=16786>
              <rdar://5712914>
      
              Reviewed by Anders and Darin.
      
              * WebInspectorClient.cpp:
              (WebInspectorClient::createPage): Create our own custom WebPreferences
              so that we won't be affected by global preference changes. This
              matches what Mac does.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c27d7fc1
    • antti@apple.com's avatar
      Some comment cleanup. · fec6705e
      antti@apple.com authored
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
              * platform/graphics/win/QTMovieWin.cpp:
              (QTMovieWin::load):
              (QTMovieWin::disableUnsupportedTracks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fec6705e
    • adele@apple.com's avatar
      Reviewed by Oliver. · a05faac8
      adele@apple.com authored
              Remove pixel results for text-only tests that I mistakingly added.
      
              * platform/mac/media/audio-constructor-expected.checksum: Removed.
              * platform/mac/media/audio-constructor-expected.png: Removed.
              * platform/mac/media/audio-constructor-src-expected.checksum: Removed.
              * platform/mac/media/audio-constructor-src-expected.png: Removed.
              * platform/mac/media/broken-video-expected.checksum: Removed.
              * platform/mac/media/broken-video-expected.png: Removed.
              * platform/mac/media/constructors-expected.checksum: Removed.
              * platform/mac/media/constructors-expected.png: Removed.
              * platform/mac/media/fallback-expected.checksum: Removed.
              * platform/mac/media/fallback-expected.png: Removed.
              * platform/mac/media/progress-event-expected.checksum: Removed.
              * platform/mac/media/progress-event-expected.png: Removed.
              * platform/mac/media/remove-from-document-expected.checksum: Removed.
              * platform/mac/media/remove-from-document-expected.png: Removed.
              * platform/mac/media/unsupported-rtsp-expected.checksum: Removed.
              * platform/mac/media/unsupported-rtsp-expected.png: Removed.
              * platform/mac/media/unsupported-tracks-expected.checksum: Removed.
              * platform/mac/media/unsupported-tracks-expected.png: Removed.
              * platform/mac/media/video-append-source-expected.checksum: Removed.
              * platform/mac/media/video-append-source-expected.png: Removed.
              * platform/mac/media/video-autoplay-expected.checksum: Removed.
              * platform/mac/media/video-autoplay-expected.png: Removed.
              * platform/mac/media/video-buffered-expected.checksum: Removed.
              * platform/mac/media/video-buffered-expected.png: Removed.
              * platform/mac/media/video-controls-expected.checksum: Removed.
              * platform/mac/media/video-controls-expected.png: Removed.
              * platform/mac/media/video-currentTime-expected.checksum: Removed.
              * platform/mac/media/video-currentTime-expected.png: Removed.
              * platform/mac/media/video-currentTime-set-expected.checksum: Removed.
              * platform/mac/media/video-currentTime-set-expected.png: Removed.
              * platform/mac/media/video-currentTime-set2-expected.checksum: Removed.
              * platform/mac/media/video-currentTime-set2-expected.png: Removed.
              * platform/mac/media/video-dom-autoplay-expected.checksum: Removed.
              * platform/mac/media/video-dom-autoplay-expected.png: Removed.
              * platform/mac/media/video-dom-end-expected.checksum: Removed.
              * platform/mac/media/video-dom-end-expected.png: Removed.
              * platform/mac/media/video-dom-loopcount-expected.checksum: Removed.
              * platform/mac/media/video-dom-loopcount-expected.png: Removed.
              * platform/mac/media/video-dom-loopend-expected.checksum: Removed.
              * platform/mac/media/video-dom-loopend-expected.png: Removed.
              * platform/mac/media/video-dom-loopstart-expected.checksum: Removed.
              * platform/mac/media/video-dom-loopstart-expected.png: Removed.
              * platform/mac/media/video-dom-src-expected.checksum: Removed.
              * platform/mac/media/video-dom-src-expected.png: Removed.
              * platform/mac/media/video-dom-start-expected.checksum: Removed.
              * platform/mac/media/video-dom-start-expected.png: Removed.
              * platform/mac/media/video-end-expected.checksum: Removed.
              * platform/mac/media/video-end-expected.png: Removed.
              * platform/mac/media/video-error-abort-expected.checksum: Removed.
              * platform/mac/media/video-error-abort-expected.png: Removed.
              * platform/mac/media/video-error-does-not-exist-expected.checksum: Removed.
              * platform/mac/media/video-error-does-not-exist-expected.png: Removed.
              * platform/mac/media/video-load-networkState-expected.checksum: Removed.
              * platform/mac/media/video-load-networkState-expected.png: Removed.
              * platform/mac/media/video-load-readyState-expected.checksum: Removed.
              * platform/mac/media/video-load-readyState-expected.png: Removed.
              * platform/mac/media/video-loopcount-expected.checksum: Removed.
              * platform/mac/media/video-loopcount-expected.png: Removed.
              * platform/mac/media/video-loopend-expected.checksum: Removed.
              * platform/mac/media/video-loopend-expected.png: Removed.
              * platform/mac/media/video-loopstart-expected.checksum: Removed.
              * platform/mac/media/video-loopstart-expected.png: Removed.
              * platform/mac/media/video-muted-expected.checksum: Removed.
              * platform/mac/media/video-muted-expected.png: Removed.
              * platform/mac/media/video-no-autoplay-expected.checksum: Removed.
              * platform/mac/media/video-no-autoplay-expected.png: Removed.
              * platform/mac/media/video-pause-empty-events-expected.checksum: Removed.
              * platform/mac/media/video-pause-empty-events-expected.png: Removed.
              * platform/mac/media/video-play-empty-events-expected.checksum: Removed.
              * platform/mac/media/video-play-empty-events-expected.png: Removed.
              * platform/mac/media/video-play-pause-events-expected.checksum: Removed.
              * platform/mac/media/video-play-pause-events-expected.png: Removed.
              * platform/mac/media/video-play-pause-exception-expected.checksum: Removed.
              * platform/mac/media/video-play-pause-exception-expected.png: Removed.
              * platform/mac/media/video-poster-expected.checksum: Removed.
              * platform/mac/media/video-poster-expected.png: Removed.
              * platform/mac/media/video-seek-past-end-paused-expected.checksum: Removed.
              * platform/mac/media/video-seek-past-end-paused-expected.png: Removed.
              * platform/mac/media/video-seek-past-end-playing-expected.checksum: Removed.
              * platform/mac/media/video-seek-past-end-playing-expected.png: Removed.
              * platform/mac/media/video-seekable-expected.checksum: Removed.
              * platform/mac/media/video-seekable-expected.png: Removed.
              * platform/mac/media/video-seeking-expected.checksum: Removed.
              * platform/mac/media/video-seeking-expected.png: Removed.
              * platform/mac/media/video-size-expected.checksum: Removed.
              * platform/mac/media/video-size-expected.png: Removed.
              * platform/mac/media/video-source-expected.checksum: Removed.
              * platform/mac/media/video-source-expected.png: Removed.
              * platform/mac/media/video-source-media-expected.checksum: Removed.
              * platform/mac/media/video-source-media-expected.png: Removed.
              * platform/mac/media/video-source-type-expected.checksum: Removed.
              * platform/mac/media/video-source-type-expected.png: Removed.
              * platform/mac/media/video-src-change-expected.checksum: Removed.
              * platform/mac/media/video-src-change-expected.png: Removed.
              * platform/mac/media/video-src-expected.checksum: Removed.
              * platform/mac/media/video-src-expected.png: Removed.
              * platform/mac/media/video-src-remove-expected.checksum: Removed.
              * platform/mac/media/video-src-remove-expected.png: Removed.
              * platform/mac/media/video-src-set-expected.checksum: Removed.
              * platform/mac/media/video-src-set-expected.png: Removed.
              * platform/mac/media/video-src-source-expected.checksum: Removed.
              * platform/mac/media/video-src-source-expected.png: Removed.
              * platform/mac/media/video-start-expected.checksum: Removed.
              * platform/mac/media/video-start-expected.png: Removed.
              * platform/mac/media/video-volume-expected.checksum: Removed.
              * platform/mac/media/video-volume-expected.png: Removed.
              * platform/mac/media/video-width-height-expected.checksum: Removed.
              * platform/mac/media/video-width-height-expected.png: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05faac8
    • adele@apple.com's avatar
      WebCore: · 2bc3e6de
      adele@apple.com authored
              Reviewed by Antti.
      
              Fix for <rdar://5683527> media/{audio,video|-controls-rendering.html failing
              
              * rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled):
              Don't treat all media controls as styled.  This causes builds with an old version of SafariTheme to have different metrics for these controls.
      
      LayoutTests:
      
              Reviewed by Antti.
      
              Removing test from Skipped list for <rdar://5683527> media/{audio,video|-controls-rendering.html failing
              
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bc3e6de
    • mitz@apple.com's avatar
      - re-add a couple of tests that are still failing back to the list · ed81945c
      mitz@apple.com authored
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed81945c
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · b27615fe
      mitz@apple.com authored
              - make Font instances cache their primary font
      
              * WebCore.base.exp:
              * platform/graphics/Font.cpp:
              (WebCore::Font::Font):
              (WebCore::Font::operator=):
              (WebCore::Font::cachePrimaryFont):
              (WebCore::Font::update):
              * platform/graphics/Font.h:
              (WebCore::Font::primaryFont):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b27615fe
    • ggaren@apple.com's avatar
      WebKitTools: · 8bc8cf05
      ggaren@apple.com authored
              Reviewed by Sam Weinig. Sam Weinig.
              
              Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
              fails when run after fast/dom/Window/window-property-shadowing.html (16902)
      
              Modified our policy delegates not to output window.name. Since a
              previous test may have explicitly set window.name, we can't rely on its
              implicit value in test results.
      
              * DumpRenderTree/mac/PolicyDelegate.mm:
              (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
      
              * DumpRenderTree/win/PolicyDelegate.cpp:
              (PolicyDelegate::decidePolicyForNavigationAction):
      
      LayoutTests:
      
              Reviewed by Sam Weinig. Sam Weinig.
              
              Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
              fails when run after fast/dom/Window/window-property-shadowing.html (16902)
      
              These layout tests demonstrate the expected behavior of window.name,
              including the fact that one test can change the window.name value seen
              by another test:
      
              * fast/dom/Window/window-property-shadowing-name-expected.txt: Added.
              * fast/dom/Window/window-property-shadowing-name.html: Added.
              * fast/dom/Window/window-property-clearing-expected.txt:
              * fast/dom/Window/window-property-clearing.html:
              
              Modified these expected results not to depend on window.name. Since a
              previous test may have explicitly set window.name, we can't rely on its
              implicit value:
      
              * fast/encoding/mailto-always-utf-8-expected.txt:
              * fast/forms/mailto/advanced-get-expected.txt:
              * fast/forms/mailto/advanced-put-expected.txt:
              * fast/forms/mailto/get-multiple-items-expected.txt:
              * fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
              * fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
              * fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
              * fast/forms/mailto/get-non-ascii-expected.txt:
              * fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
              * fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
              * fast/forms/mailto/get-overwrite-query-expected.txt:
              * fast/forms/mailto/post-append-query-expected.txt:
              * fast/forms/mailto/post-multiple-items-expected.txt:
              * fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
              * fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
              * fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
              * fast/forms/mailto/post-text-plain-expected.txt:
              * fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
              * http/tests/security/feed-urls-from-remote-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bc8cf05
    • mitz@apple.com's avatar
      - Leopard build fix · 20eaa7be
      mitz@apple.com authored
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20eaa7be
    • mrowe@apple.com's avatar
      <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite... · e7b9ccb0
      mrowe@apple.com authored
      <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
      
      Reviewed by Tim Hatcher.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7b9ccb0
    • mitz@apple.com's avatar
      WebCore: · e0721f27
      mitz@apple.com authored
              Reviewed by Adam Roben and Oliver Hunt.
      
              - fix <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing
      
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData): Use double instead of float
              for consistent rounding behavior between Mac OS X and Windows.
      
      LayoutTests:
      
              Reviewed by Adam Roben and Oliver Hunt.
      
              - remove skipped tests after fixing <rdar://problem/5713131> REGRESSION (r29246): Many SVG font tests are failing
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0721f27
    • ddkilzer@apple.com's avatar
      Refactor ChangeLog path code · 1242ec43
      ddkilzer@apple.com authored
              Reviewed by Adam.
      
              * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
              duplicate code in another foreach() loop.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1242ec43
    • aroben@apple.com's avatar
      Fix <rdar://5713302> Web Inspector on Windows is not using the localized strings · f544d510
      aroben@apple.com authored
      WebCore:
      
              Fix <rdar://5713302> Web Inspector on Windows is not using the
              localized strings
      
              Reviewed by Steve.
      
              * WebCore.vcproj/WebCore.vcproj: Copy InspectorLocalizedStrings.js to
              $WebKitOutputDir.
              * page/InspectorController.cpp: Touch this to force the project to
              build.
      
      WebKit/win:
      
              Fix <rdar://5713302> Web Inspector on Windows is not using the
              localized strings
      
              Reviewed by Steve.
      
              * WebInspectorClient.cpp:
              (getWebKitBundle): Added.
              (WebInspectorClient::createPage): Call getWebKitBundle.
              (WebInspectorClient::localizedStringsURL): Implemented.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f544d510
    • eric@webkit.org's avatar
      Reviewed by Nikolas. · e831c746
      eric@webkit.org authored
              Acid3 after double-attach
              http://bugs.webkit.org/show_bug.cgi?id=17058
      
              I believe SVGTextPathElement::buildPendingResource() was entirely
              bogus, removing it did not cause any tests to fail.
      
              Test: svg/custom/textPath-assert.svg
      
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::insertedIntoDocument): remove buildPendingResource()
              * svg/SVGTextPathElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e831c746