1. 18 Feb, 2010 1 commit
    • tony@chromium.org's avatar
      2010-02-17 Tony Chang <tony@chromium.org> · 2509fab1
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=26937
              No longer allow span styles to surround block elements like
              divs when pasting (see paste-text-012 and 5065605 which had divs in
              spans).  This also causes a few cases of empty spans to be removed
              (see 19089 and 5245519).
      
              * editing/execCommand/19089-expected.txt:
              * editing/pasteboard/5245519-expected.txt:
              * editing/pasteboard/5245519.html:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-011-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
      2010-02-17  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Copying and pasting into a contenteditable area can create <div>s surrounded by <span>s
              https://bugs.webkit.org/show_bug.cgi?id=26937
      
              This happens because of a span added when we copy that is used to
              preserve styles.  To avoid this, when we paste, make sure to apply
              the styles to the span's children and then remove the style span.
      
              This change is covered by existing layout tests.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::handleStyleSpans):
              (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
              * editing/ReplaceSelectionCommand.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2509fab1
  2. 17 Feb, 2010 39 commits
    • eric@webkit.org's avatar
      2010-02-17 Tony Chang <tony@chromium.org> · 28d03110
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=34914
              When pasting absolute font sizes into a content editable area with
              page zoom, adjust the font sizes to be the same after page zoom is
              applied.
      
              * editing/pasteboard/page-zoom-expected.txt: Added.
              * editing/pasteboard/page-zoom.html: Added.
      2010-02-17  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=34914
              When pasting absolute font sizes into a content editable area with
              page zoom, adjust the font sizes to be the same after page zoom is
              applied.
      
              Test: editing/pasteboard/page-zoom.html
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28d03110
    • eric@webkit.org's avatar
      2010-02-17 Tony Chang <tony@chromium.org> · 9efd914a
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=34737
              Test to verify that pasting styled list items works
              the same as pasting unstyle list items.
      
              * editing/pasteboard/paste-list-003-expected.txt: Added.
              * editing/pasteboard/paste-list-003.html: Added.
      2010-02-17  Tony Chang  <tony@chromium.org>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=34737
              Copying styled list items then pasting into a list
              should work the same as copying unstyle list items:
              it shouldn't indent an extra level, but styles should
              be copied.
      
              Small cleanups to insertAsListItems to make variable names
              more descriptive.
      
              Test: editing/pasteboard/paste-list-003.html
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              (WebCore::ReplaceSelectionCommand::insertAsListItems):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9efd914a
    • eric@webkit.org's avatar
      2010-02-17 Kwang Yul Seo <skyul@company100.net> · 91e543ee
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Port PlatformKeyboardEvent
              https://bugs.webkit.org/show_bug.cgi?id=34794
      
              Retrieve the type, key code, text and modifiers from BREW's keyboard event.
      
              * platform/PlatformKeyboardEvent.h:
              * platform/brew/PlatformKeyboardEventBrew.cpp: Added.
              (WebCore::keyIdentifierForBrewKeyCode):
              (WebCore::windowsKeyCodeForKeyEvent):
              (WebCore::singleCharacterString):
              (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
              (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
              (WebCore::PlatformKeyboardEvent::currentCapsLockState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91e543ee
    • eric@webkit.org's avatar
      2010-02-17 Hayato Ito <hayato@chromium.org> · 160ba786
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Support CSS page-break-inside with a value of 'avoid'.
      
              https://bugs.webkit.org/show_bug.cgi?id=34080
      
              * printing/page-break-inside-expected.txt: Added.
              * printing/page-break-inside.html: Added.
              * printing/script-tests/page-break-inside.js: Added.
              (createParagraph):
              (pageNumber):
      2010-02-17  Hayato Ito  <hayato@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Support CSS page-break-inside with a value of 'avoid'.
      
              https://bugs.webkit.org/show_bug.cgi?id=34080
      
              Test: printing/page-break-inside.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintChildren):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      160ba786
    • eric@webkit.org's avatar
      2010-02-17 Evan Martin <evan@chromium.org> · b96f638b
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] expose cache-bypass flag in reload() API
              https://bugs.webkit.org/show_bug.cgi?id=34969
      
              This flag is used to force a reload to ignore caches.
              (Aka "shift-reload".)
      
              * public/WebFrame.h:
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::reload):
              * src/WebFrameImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b96f638b
    • ukai@chromium.org's avatar
      2010-02-17 Fumitoshi Ukai <ukai@chromium.org> · 3065d182
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              WebSocket bufferedAmount should not be 0 when send after close.
              https://bugs.webkit.org/show_bug.cgi?id=34633
      
              * websocket/tests/bufferedAmount-after-close-expected.txt: Added.
              * websocket/tests/bufferedAmount-after-close.html: Added.
              * websocket/tests/script-tests/bufferedAmount-after-close.js: Added.
      2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              WebSocket bufferedAmount should not be 0 when send after close.
              https://bugs.webkit.org/show_bug.cgi?id=34633
      
              Fixed bug in webkit r54694.  check m_client after it calls user
              callback, because user callback may call close(), which would
              call onclose event handler.
      
              Test: websocket/tests/bufferedAmount-after-close.html
      
              * websockets/ThreadableWebSocketChannelClientWrapper.h:
              (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
              * websockets/WebSocket.cpp:
              (WebCore::WebSocket::WebSocket):
              (WebCore::WebSocket::send):
              (WebCore::WebSocket::close):
              (WebCore::WebSocket::bufferedAmount):
              (WebCore::WebSocket::didConnect):
              (WebCore::WebSocket::didClose):
              * websockets/WebSocket.h:
              * websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::WebSocketChannel):
              (WebCore::WebSocketChannel::send):
              (WebCore::WebSocketChannel::bufferedAmount):
              (WebCore::WebSocketChannel::didClose):
              (WebCore::WebSocketChannel::didReceiveData):
              * websockets/WebSocketChannel.h:
              * websockets/WebSocketChannelClient.h:
              (WebCore::WebSocketChannelClient::didClose):
              * websockets/WorkerThreadableWebSocketChannel.cpp:
              (WebCore::workerContextDidClose):
              (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
              * websockets/WorkerThreadableWebSocketChannel.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3065d182
    • eric@webkit.org's avatar
      2010-02-17 Yuzo Fujishima <yuzo@google.com> · 0b21a9bf
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              In diffing render styles, consider all pseudo style changes.
              Without this patch, only :before and :after are considered. This is the cause of the following bug.
              https://bugs.webkit.org/show_bug.cgi?id=32187
      
              * fast/css/first-letter-first-line-hover.html: Added.
              * platform/mac/fast/css/first-letter-first-line-hover-expected.checksum: Added.
              * platform/mac/fast/css/first-letter-first-line-hover-expected.png: Added.
              * platform/mac/fast/css/first-letter-first-line-hover-expected.txt: Added.
      2010-02-17  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by Eric Seidel.
      
              In diffing render styles, consider all pseudo style changes.
              Without this patch, only :before and :after are considered. This is the cause of the following bug.
              https://bugs.webkit.org/show_bug.cgi?id=32187
      
              Test: fast/css/first-letter-first-line-hover.html
      
              * dom/Node.cpp:
              (WebCore::Node::diff):
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::hasAnyPublicPseudoStyles):
              * rendering/style/RenderStyle.h:
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b21a9bf
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=35070 · 9f6d7a00
      barraclough@apple.com authored
      Addition of 2 strings of length 2^31 may result in a string of length 0.
      
      Reviewed by Oliver Hunt.
      
      Check for overflow when creating a new JSString as a result of an addition
      or concatenation, throw an out of memory exception.
      
      * runtime/JSString.h:
      (JSC::):
      * runtime/Operations.h:
      (JSC::jsString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f6d7a00
    • eric@webkit.org's avatar
      2010-02-17 Kwang Yul Seo <skyul@company100.net> · 0f0871cb
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Add WebCore::prefetchDNS
              https://bugs.webkit.org/show_bug.cgi?id=34873
      
              DNS prefetching is not implemented because the maximum number
              of UDP sockets is quite small in most BREW devices.
      
              * platform/network/brew/DNSBrew.cpp: Added.
              (WebCore::prefetchDNS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f0871cb
    • tkent@chromium.org's avatar
      2010-02-17 Kent Tamura <tkent@chromium.org> · 8c78e27c
      tkent@chromium.org authored
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              It's hard for Chromium port to load an icon inside
              Icon::createIconForFiles() because of sanbox and multi-process
              architecture. So this change adds a method to request an icon to
              Chrome class, and makes FileChooser receives an Icon instance
              asynchronously.  Synchronous loading also works with the new interface.
      
              Because all ports don't have implementations of Chrome::iconForFiles()
              yet, FileChooser tries to load an Icon synchronously with
              Icon::createIconForFiles(), then tries to load an Icon asynchronously
              with Chrome::iconForFiles() if Icon::createIconForFiles() returns 0.
      
              The existing Icon::createIconForFiles() implementations should be
              moved to Chrome::iconForFiles(). We're going to remove
              Icon::createIconForFiles().
      
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::iconForFiles): Add an empty implementation.
              * page/Chrome.cpp:
              (WebCore::Chrome::iconForFiles): Delegate to ChromeClient::iconForFiles().
              * page/Chrome.h:
              * page/ChromeClient.h:
              (WebCore::ChromeClient::iconForFiles): Add a declaration as a pure virtual method.
              * platform/FileChooser.cpp:
              (WebCore::FileChooser::FileChooser): Use loadIcon().
              (WebCore::FileChooser::chooseFiles): ditto.
              (WebCore::FileChooser::loadIcon): Added.
              (WebCore::FileChooser::iconLoaded): Added.
              * platform/FileChooser.h: Add two methods to FileChooserClient; repaint() and iconForFiles().
              * platform/graphics/Icon.h: Add a FIXME comment.
              * platform/graphics/gtk/IconGtk.cpp: ditto.
              * platform/graphics/mac/IconMac.mm: ditto.
              * platform/graphics/qt/IconQt.cpp: ditto.
              * platform/graphics/win/IconWin.cpp: ditto.
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::iconForFiles): Delegate to Chrome::iconForFiles().
              (WebCore::RenderFileUploadControl::click): Use chrome().
              (WebCore::RenderFileUploadControl::chrome):
              * rendering/RenderFileUploadControl.h:
              (WebCore::RenderFileUploadControl::repaint):
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::iconForFiles):
              * src/ChromeClientImpl.h:
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::iconForFiles):
              * WebCoreSupport/ChromeClientGtk.h:
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::iconForFiles):
              * WebCoreSupport/ChromeClientHaiku.h:
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::iconForFiles):
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::iconForFiles):
              * WebCoreSupport/ChromeClientQt.h:
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::iconForFiles):
              * WebCoreSupport/WebChromeClient.h:
      
      2010-02-17  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Introduces new Icon loading interface in order to support
              asynchronous loading.
              https://bugs.webkit.org/show_bug.cgi?id=32054
      
              Add an empty implementation of ChromeClient::iconForFiles().
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::iconForFiles):
              * WebKitSupport/ChromeClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c78e27c
    • hamaji@chromium.org's avatar
      2010-02-17 Shinichiro Hamaji <hamaji@chromium.org> · 6a78ced4
      hamaji@chromium.org authored
              Unreviewed. Touch WebKit.idl to fix the build.
      
              [Win] Implement test functions for printing
              https://bugs.webkit.org/show_bug.cgi?id=34570
      
              * Interfaces/WebKit.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a78ced4
    • hamaji@chromium.org's avatar
      2010-02-17 Shinichiro Hamaji <hamaji@chromium.org> · 490dfea6
      hamaji@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Win] Implement layoutTestController.pageNumberForElementById
              https://bugs.webkit.org/show_bug.cgi?id=34570
      
              * platform/win/Skipped:
      2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [Win] Implement test functions for printing
              https://bugs.webkit.org/show_bug.cgi?id=34570
      
              * Interfaces/IWebFramePrivate.idl:
              * WebFrame.cpp:
              (WebFrame::pageNumberForElementById):
              (WebFrame::numberOfPages):
              * WebFrame.h:
      2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [Win] Implement test functions for printing
              https://bugs.webkit.org/show_bug.cgi?id=34570
      
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::pageNumberForElementById):
              (LayoutTestController::numberOfPages):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      490dfea6
    • ukai@chromium.org's avatar
      2010-02-17 Fumitoshi Ukai <ukai@chromium.org> · 67ae8c4f
      ukai@chromium.org authored
              Reviewed by Eric Seidel.
      
              websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
              https://bugs.webkit.org/show_bug.cgi?id=35001
      
              * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67ae8c4f
    • mrowe@apple.com's avatar
      Bug 35065: Delay between page loading and animated GIF playing · 484121c1
      mrowe@apple.com authored
      <http://webkit.org/b/35065> / <rdar://problem/7109548>
      
      Reviewed by Darin Adler.
      
      BitmapImage::startAnimation was adding the current frame duration to the desired start time
      of the frame for every time it was called.  If the function then bailed out due to not having
      sufficient data to render the frame, this would lead to the desired start time of the frame
      being pushed out multiple times.  On an animated GIF that took mulitple seconds to load this
      could happen many times for a single frame, resulting in the start time of the second frame
      of the animation being pushed out by as much as five seconds.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::startAnimation): Change the order of the code slightly so that the
      desired start time is only updated after determining that we have sufficient data to handle
      the next frame.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      484121c1
    • hamaji@chromium.org's avatar
      2010-02-17 Shinichiro Hamaji <hamaji@chromium.org> · ea001ce4
      hamaji@chromium.org authored
              Reviewed by Eric Seidel.
      
              check-webkit-style: Misses variables that contain underscores.
              https://bugs.webkit.org/show_bug.cgi?id=33724
      
              - Check identifiers whose types are unsigned.
              - Check bitfields properly.
      
              * Scripts/webkitpy/style/processors/cpp.py:
              * Scripts/webkitpy/style/processors/cpp_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea001ce4
    • hamaji@chromium.org's avatar
      2010-02-17 Shinichiro Hamaji <hamaji@chromium.org> · d1194266
      hamaji@chromium.org authored
              Reviewed by Eric Seidel.
      
              check-webkit-style should report the number of files checked
              https://bugs.webkit.org/show_bug.cgi?id=34971
      
              * Scripts/check-webkit-style:
              * Scripts/webkitpy/style/checker.py:
              * Scripts/webkitpy/style/checker_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1194266
    • eric@webkit.org's avatar
      2010-02-17 Stephan Aßmus <superstippi@gmx.de> · 3a361eab
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implemented homeDirectoryPath() and listDirectory() on the Haiku platform.
              https://bugs.webkit.org/show_bug.cgi?id=34687
      
              Covered by existing tests.
      
              * platform/haiku/FileSystemHaiku.cpp:
              (WebCore::homeDirectoryPath): Implemented
              (WebCore::listDirectory): Implemented
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a361eab
    • eric@webkit.org's avatar
      2010-02-17 Kwang Yul Seo <skyul@company100.net> · dc0edf78
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Port userIdleTime
              https://bugs.webkit.org/show_bug.cgi?id=34259
      
              Return an arbitrarily high userIdleTime so that releasing pages from the page
              cache isn't postponed.
      
              * platform/brew/SystemTimeBrew.cpp: Added.
              (WebCore::userIdleTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc0edf78
    • bweinstein@apple.com's avatar
      Actually land the changes to the Skipped list · 2b2b5260
      bweinstein@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b2b5260
    • bweinstein@apple.com's avatar
      Rubber-stamped by Dan Bernstein. · a86a4090
      bweinstein@apple.com authored
      Unskip glyph-reordering, because now it passes on Windows.
      
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a86a4090
    • mitz@apple.com's avatar
      [GTK][Qt] Fails glyph reordering test fast/text/glyph-reordering.html · 2e898aca
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34918
      
      Reviewed by Eric Seidel.
      
      Made the test less dependent on the complex text implementation.
      
      * fast/text/glyph-reordering-expected.txt:
      * fast/text/glyph-reordering.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e898aca
    • krit@webkit.org's avatar
      2010-02-17 Dirk Schulze <krit@webkit.org> · 80c9b0a8
      krit@webkit.org authored
              Rolling out r54909. Breaks SL and Win.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80c9b0a8
    • dumi@chromium.org's avatar
      WebCore: Fix Chromium's bindings for Database.transaction(): a 'null' · f0e229ce
      dumi@chromium.org authored
      callback should be treated as no callback.
      
      Reviewed by Dimitri Glazkov.
      
      Test: storage/null-callbacks.html
      
      https://bugs.webkit.org/show_bug.cgi?id=35047
      
      * bindings/v8/custom/V8DatabaseCustom.cpp:
      (WebCore::createTransaction):
      
      LayoutTests: Add a test that verifies that null transaction callbacks are
      accepted and treated as no callbacks.
      
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=35047
      
      * storage/null-callbacks-expected.txt: Added.
      * storage/null-callbacks.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0e229ce
    • krit@webkit.org's avatar
      2010-02-17 Dirk Schulze <krit@webkit.org> · e71d1897
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Move SVGResources to Renderers, starting with Masker
              https://bugs.webkit.org/show_bug.cgi?id=35020
      
              We have rendering specific code in WebCore/svg/graphics. The goal is to move
              this code into suitable Renderers. This helps us to clean up the code and makes
              maintenance easier. It also makes it possible to remove rendering specific code
              from SVG*Elements into this renderers. So the Renderer contains everything that
              is needed to use the resource.
              RenderSVGResource will be the base class for all new resource render classes like
              RenderSVGResourceMasker, RenderSVGResourceClipper and the other resources.
      
              This patch starts moving SVGResourceMasker to RenderSVGResourceMasker.
              Another benefit is the much more useful result in DRT on using masker.
      
              * Android.mk:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::toRenderSVGResource): Conversion to RenderSVGResource base class.
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isSVGResource): Check if renderer is a resource.
              * rendering/RenderPath.cpp:
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::destroy): Renderer gets destroyed, unregister it from it's resources.
              * rendering/RenderSVGImage.h: Some code clean up according to the webkit style.
              (WebCore::RenderSVGImage::toSVGRenderBase):
              (WebCore::RenderSVGImage::renderName):
              (WebCore::RenderSVGImage::isSVGImage):
              (WebCore::RenderSVGImage::localToParentTransform):
              (WebCore::RenderSVGImage::strokeBoundingBox):
              (WebCore::RenderSVGImage::requiresLayer):
              (WebCore::RenderSVGImage::localTransform):
              * rendering/RenderSVGInlineText.h:
              (WebCore::RenderSVGInlineText::objectBoundingBox): Needed for SVGRenderTreeAsText
              * rendering/RenderSVGModelObject.cpp:
              (WebCore::RenderSVGModelObject::destroy): Renderer gets destroyed, unregister it from it's resources.
              * rendering/RenderSVGModelObject.h:
              * rendering/RenderSVGResource.h: Added.
              (WebCore::): Base class for all Resource renderers like masker, clipper and others.
              (WebCore::RenderSVGResource::RenderSVGResource):
              (WebCore::RenderSVGResource::cast):
              (WebCore::RenderSVGResource::toRenderSVGResource):
              (WebCore::RenderSVGResource::isSVGResource): 
              (WebCore::RenderSVGResource::drawsContents):
              (WebCore::getRenderSVGResourceById):
              * rendering/RenderSVGResourceMasker.cpp: Added.
              (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
              (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
              (WebCore::RenderSVGResourceMasker::invalidateClients): Status of masker changed, remove all clients.
              (WebCore::RenderSVGResourceMasker::invalidateClient): Status of an object changed, remove pending client.
              (WebCore::RenderSVGResourceMasker::applyResource): Apply masker to object.
              (WebCore::RenderSVGResourceMasker::resourceBoundingBox): boundingBox of the resource, depending on the object.
              (WebCore::RenderSVGResourceMasker::createMaskImage): Creates the mask image, the context gets clipped with.
              * rendering/RenderSVGResourceMasker.h: Added.
              (WebCore::MaskerData::MaskerData):
              (WebCore::RenderSVGResourceMasker::renderName):
              (WebCore::RenderSVGResourceMasker::maskUnits): Unit of mask for DRT.
              (WebCore::RenderSVGResourceMasker::maskContentUnits): Unit of childs from mask for DRT.
              (WebCore::RenderSVGResourceMasker::resourceType):
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::destroy): Renderer gets destroyed, unregister it from it's resources.
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::destroy): dito.
              * rendering/RenderSVGText.h:
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::SVGRenderBase::prepareToRenderSVGContent):
              (WebCore::SVGRenderBase::maskerBoundingBoxForRenderer):
              (WebCore::SVGRenderBase::deregisterFromResources): Unregister object from all it's resources after status changed.
              * rendering/SVGRenderSupport.h:
              (WebCore::SVGRenderBase::toSVGRenderBase):
              (WebCore::SVGRenderBase::strokeBoundingBox):
              (WebCore::SVGRenderBase::markerBoundingBox):
              * rendering/SVGRenderTreeAsText.cpp: Update TreeAsText to dump maskers correctly.
              (WebCore::operator<<):
              (WebCore::writeSVGResource):
              (WebCore::writeSVGContainer):
              (WebCore::writeSVGText):
              (WebCore::writeSVGInlineText):
              (WebCore::writeSVGImage):
              (WebCore::write):
              (WebCore::writeResourcesToObject):
              * rendering/SVGRenderTreeAsText.h:
              * svg/SVGMaskElement.cpp: Update Masker to use the new renderer.
              (WebCore::SVGMaskElement::svgAttributeChanged):
              (WebCore::SVGMaskElement::childrenChanged):
              (WebCore::SVGMaskElement::maskBoundingBox):
              (WebCore::SVGMaskElement::createRenderer):
              * svg/SVGMaskElement.h:
              * svg/SVGStyledElement.cpp: We need to tell the renderer to unregister object, after the status changed.
              (WebCore::SVGStyledElement::invalidateResources):
              (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
              * svg/SVGUnitTypes.h: Conversion of integer to SVGUnitType.
              (WebCore::toUnitType):
              * svg/graphics/SVGResource.h:
              (WebCore::):
              (WebCore::SVGResource::isMarker):
              * svg/graphics/SVGResourceMasker.cpp: Removed.
              * svg/graphics/SVGResourceMasker.h: Removed.
      
      2010-02-17  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Move SVGResources to Renderers, starting with Masker
              https://bugs.webkit.org/show_bug.cgi?id=35020
      
              With the move from SVGResourceMasker to RenderSVGResourceMasker, I changed
              the way DRT dumps resources. DRT is now able to dump multi-access
              of resources.
              Also the size of a Mask resource (depending of the object) and the access of
              the resource (togeter with the resource name) is pointed out as an insertion
              under the object.
      
              * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/batik/masking/maskRegions-expected.txt:
              * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
              * platform/mac/svg/css/mask-with-shadow-expected.txt:
              * platform/mac/svg/custom/empty-mask-expected.txt:
              * platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
              * platform/mac/svg/custom/js-late-mask-and-object-creation-expected.txt:
              * platform/mac/svg/custom/js-late-mask-creation-expected.txt:
              * platform/mac/svg/custom/mask-changes-expected.txt:
              * platform/mac/svg/custom/mask-child-changes-expected.txt:
              * platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
              * platform/mac/svg/custom/mask-inside-defs-expected.txt:
              * platform/mac/svg/custom/mask-invalidation-expected.txt:
              * platform/mac/svg/custom/mask-on-multiple-objects-expected.txt:
              * platform/mac/svg/custom/mask-with-all-units-expected.txt:
              * platform/mac/svg/custom/mask-with-default-value-expected.txt:
              * platform/mac/svg/custom/resource-invalidate-on-target-update-expected.txt:
              * platform/mac/svg/custom/visibility-override-mask-expected.txt:
              * platform/mac/svg/filters/filter-clip-expected.txt:
              * svg/custom/transformedMaskFails-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e71d1897
    • timothy@apple.com's avatar
      Add a way for WebView and its dependancies to be selectively included · ec77e33a
      timothy@apple.com authored
      in WebKitStatistics leak tracking. By default WebView is not included and
      you need to subclass WebView and implement +isIncludedInWebKitStatistics
      to be included.
      
      rdar://problem/7567677&7572900
      https://webkit.org/b/35045
      
      Reviewed by Adam Roben.
      
      * WebView/WebDataSource.mm:
      (-[WebDataSource _initWithDocumentLoader:]): Increment WebDataSourceCount if the WebFrame is included in statistics.
      (-[WebDataSource dealloc]): Only --WebDataSourceCount if _private->includedInWebKitStatistics is YES.
      (-[WebDataSource finalize]): Ditto.
      * WebView/WebFrame.mm:
      (-[WebFrame _isIncludedInWebKitStatistics]): Return _private->includedInWebKitStatistics.
      (-[WebFrame _initWithWebFrameView:webView:]): Increment WebFrameCount if the WebView's class is included in statistics.
      (-[WebFrame dealloc]): Only --WebFrameCount if _private->includedInWebKitStatistics is YES.
      (-[WebFrame finalize]): Ditto.
      * WebView/WebFrameInternal.h:
      * WebView/WebFrameView.mm:
      (-[WebFrameView _setWebFrame:]): Increment WebFrameViewCount if the WebFrame is included in statistics.
      (-[WebFrameView initWithFrame:]): Move ++WebFrameViewCount from here since we don't
      know what WebFrame we belong to yet.
      (-[WebFrameView dealloc]): Only --WebFrameViewCount if _private->includedInWebKitStatistics is YES.
      (-[WebFrameView finalize]): Ditto.
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation init]): Move ++WebHTMLRepresentationCount from here since we don't
      know what WebFrame we belong to yet.
      (-[WebHTMLRepresentation dealloc]): Only --WebHTMLRepresentationCount if _private->includedInWebKitStatistics is YES.
      (-[WebHTMLRepresentation finalize]): Ditto.
      (-[WebHTMLRepresentation setDataSource:]): Increment WebHTMLRepresentationCount if the WebFrame of the dataSource is
      included in statistics.
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      (-[WebView dealloc]):
      (+[WebView shouldIncludeInWebKitStatistics]): Return NO, so any WebView wont be included.
      Subclasses that care can return YES to be included.
      * WebView/WebViewInternal.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec77e33a
    • eric@webkit.org's avatar
      2010-02-17 Kenneth Russell <kbr@google.com> · f5eaf118
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Refactor texImage2D and texSubImage2D taking Image to use common code
              https://bugs.webkit.org/show_bug.cgi?id=34458
      
              Merged the Safari and Chromium code which extracts the data from
              Image objects into common entry points on GraphicsContext3D. This
              immediately fixes the following three problems:
                - Chromium not implementing texSubImage2D taking Image.
                - Safari not obeying the flipY parameter to texImage2D or
                  texSubImage2D taking Image.
                - Safari not obeying the premultipyAlpha parameter to texImage2D
                  or texSubImage2D taking Image.
              Added new test verifying the behavior of texImage2D and
              texSubImage2D and the flipY parameter. The premultiplyAlpha
              parameter can not be tested yet as the implementation is not yet
              spec compliant. This will be fixed in a follow-on bug.
      
              Ran all WebGL demos in demo repository on Safari and Chromium;
              textures are now the right way up in both browsers, and
              transparent textures in Particles demo now look correct in Safari.
      
              * fast/canvas/webgl/resources/red-green.png: Added.
              * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
              * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html: Added.
      2010-02-17  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Oliver Hunt.
      
              Refactor texImage2D and texSubImage2D taking Image to use common code
              https://bugs.webkit.org/show_bug.cgi?id=34458
      
              Merged the Safari and Chromium code which extracts the data from
              Image objects into common entry points on GraphicsContext3D. This
              immediately fixes the following three problems:
                - Chromium not implementing texSubImage2D taking Image.
                - Safari not obeying the flipY parameter to texImage2D or
                  texSubImage2D taking Image.
                - Safari not obeying the premultipyAlpha parameter to texImage2D
                  or texSubImage2D taking Image.
              Added new test verifying the behavior of texImage2D and
              texSubImage2D and the flipY parameter. The premultiplyAlpha
              parameter can not be tested yet as the implementation is not yet
              spec compliant. This will be fixed in a follow-on bug.
      
              Ran all WebGL demos in demo repository on Safari and Chromium;
              textures are now the right way up in both browsers, and
              transparent textures in Particles demo now look correct in Safari.
      
              Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext3D.cpp: Added.
              (WebCore::GraphicsContext3D::extractImageData):
              (WebCore::GraphicsContext3D::processImageData):
              (WebCore::GraphicsContext3D::premultiplyAlpha):
              (WebCore::GraphicsContext3D::unmultiplyAlpha):
              * platform/graphics/GraphicsContext3D.h:
              (WebCore::GraphicsContext3D::):
              * platform/graphics/cg/GraphicsContext3DCG.cpp: Added.
              (WebCore::GraphicsContext3D::getImageData):
              * platform/graphics/mac/GraphicsContext3DMac.cpp:
              (WebCore::GraphicsContext3D::texImage2D):
              (WebCore::GraphicsContext3D::texSubImage2D):
              * platform/graphics/skia/GraphicsContext3DSkia.cpp: Added.
              (WebCore::GraphicsContext3D::getImageData):
      2010-02-17  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Oliver Hunt.
      
              Refactor texImage2D and texSubImage2D taking Image to use common code
              https://bugs.webkit.org/show_bug.cgi?id=34458
      
              Merged the Safari and Chromium code which extracts the data from
              Image objects into common entry points on GraphicsContext3D. This
              immediately fixes the following three problems:
                - Chromium not implementing texSubImage2D taking Image.
                - Safari not obeying the flipY parameter to texImage2D or
                  texSubImage2D taking Image.
                - Safari not obeying the premultipyAlpha parameter to texImage2D
                  or texSubImage2D taking Image.
              Added new test verifying the behavior of texImage2D and
              texSubImage2D and the flipY parameter. The premultiplyAlpha
              parameter can not be tested yet as the implementation is not yet
              spec compliant. This will be fixed in a follow-on bug.
      
              Ran all WebGL demos in demo repository on Safari and Chromium;
              textures are now the right way up in both browsers, and
              transparent textures in Particles demo now look correct in Safari.
      
              * src/GraphicsContext3D.cpp:
              (WebCore::GraphicsContext3D::texImage2D):
              (WebCore::GraphicsContext3D::texSubImage2D):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5eaf118
    • eric@webkit.org's avatar
      2010-02-17 Noam Rosenthal <noam.rosenthal@nokia.com> · 06afd293
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              [Qt] GraphicsLayer: support perspective and 3D transforms
              https://bugs.webkit.org/show_bug.cgi?id=34960
      
              * WebKit.pri: added appropriate define: ENABLED_3D_RENDERING
      2010-02-17  Noam Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Ariya Hidayat.
      
              [Qt] GraphicsLayer: support perspective and 3D transforms
              https://bugs.webkit.org/show_bug.cgi?id=34960
      
              New tests: http://webkit.org/blog-files/3d-transforms/perspective-by-example.html
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::GraphicsLayerQtImpl::updateTransform):
              (WebCore::GraphicsLayerQtImpl::setBaseTransform):
              (WebCore::GraphicsLayerQtImpl::computeTransform):
              (WebCore::GraphicsLayerQtImpl::flushChanges):
              (WebCore::TransformAnimationQt::~TransformAnimationQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06afd293
    • pkasting@chromium.org's avatar
      Unreviewed, build fix. · fd10f5b6
      pkasting@chromium.org authored
      Fix crashes due to an omitted line in r54839.
      
      * platform/image-decoders/png/PNGImageDecoder.cpp:
      (WebCore::decodingFailed):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd10f5b6
    • eric@webkit.org's avatar
      2010-02-17 Alok Priyadarshi <alokp@chromium.org> · 94439526
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Bug 34900: Implement accelerated compositing for chromium.
              https://bugs.webkit.org/show_bug.cgi?id=34900
      
              Do not exclude files needed for accelerated compositing. In fact there is no need to exclude these files.
              These files are already guarded with WTF_USE_ACCELERATED_COMPOSITING flag.
      
              * WebCore.gyp/WebCore.gyp: Removed GraphicsLayer.cpp, RenderLayerBacking.cpp,
              and RenderLayerCompositor.cpp from excluded list.
      2010-02-17  Alok Priyadarshi  <alokp@chromium.org>
      
              Reviewed by Ariya Hidayat.
      
              Bug 34900: Implement accelerated compositing for chromium.
              https://bugs.webkit.org/show_bug.cgi?id=34900
      
              * features.gypi: Added WTF_USE_ACCELERATED_COMPOSITING flag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94439526
    • jianli@chromium.org's avatar
      [chromium] Remove the obsolete chromium interface for handling DownloadURL. · dfa326a7
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34982
      
      Reviewed by Darin Fisher.
      
      WebCore:
      
      * platform/chromium/ChromiumDataObject.cpp:
      (WebCore::ChromiumDataObject::clear):
      (WebCore::ChromiumDataObject::hasData):
      (WebCore::ChromiumDataObject::ChromiumDataObject):
      * platform/chromium/ChromiumDataObject.h:
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::setData):
      
      WebKit/chromium:
      
      * public/WebDragData.h:
      * src/WebDragData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfa326a7
    • eric@webkit.org's avatar
      2010-02-17 Diego Gonzalez <diego.gonzalez@openbossa.org> · e445f8f9
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Make possible Qt DRT to get total number of pages to be printed
      
              LayoutTests:
                  printing/numberOfPages.html
      
              [Qt] DRT: Get total number of pages to be printed
              https://bugs.webkit.org/show_bug.cgi?id=34955
      
              * Api/qwebframe.cpp:
              (qt_drt_numberOfPages):
              (qt_drt_evaluateScriptInIsolatedWorld):
      2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Ariya Hidayat.
      
              Make possible Qt DRT to get total number of pages to be printed
      
              LayoutTests:
                  printing/numberOfPages.html
      
              [Qt] DRT: Get total number of pages to be printed
              https://bugs.webkit.org/show_bug.cgi?id=34955
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::numberOfPages):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e445f8f9
    • mitz@apple.com's avatar
      <rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for... · 67df0a78
      mitz@apple.com authored
      <rdar://problem/7645569> REGRESSION (r51324): Incorrect marker rects for blocks that span multiple columns
      
      Reviewed by Darin Adler.
      
      * manual-tests/match-marker-rects.html: Added.
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintTextMatchMarker): Use the text renderer rather
      than its ancestor block for the local-to-absolute transformation.
      (WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67df0a78
    • xan@webkit.org's avatar
      WebKit/gtk: · e9b293b4
      xan@webkit.org authored
      2010-02-17  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Rename 'enable-java' setting to 'enable-java-applet', since it
              only controls whether <applet> is supported or not instead of
              whether all Java content is supported or not.
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (DNDContentsRequest::webkit_web_view_update_settings):
              (DNDContentsRequest::webkit_web_view_settings_notify):
      
      WebKitTools:
      
      2010-02-17  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Update to use new property name.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9b293b4
    • eric@webkit.org's avatar
      2010-02-17 Julien Chaffraix <jchaffraix@webkit.org> · b7a2a590
      eric@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Remove some warnings seen when building Qt
              https://bugs.webkit.org/show_bug.cgi?id=35017
      
              Using a machine without the needed tools to build WebKit leads to
              several errors and warnings.
      
              * Scripts/webkitdirs.pm: Refactored the code testing the command's
              presence into a commandExists routine. While doing so removed, stderr
              output as it usually does not give anything more than our message. Also
              added a Qt check for qmake that was missing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7a2a590
    • zimmermann@webkit.org's avatar
      2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com> · dc14d89f
      zimmermann@webkit.org authored
              Not reviewed. Try to turn windows slaves again, by skipping two websocket tests that fail reliable.
      
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc14d89f
    • kov@webkit.org's avatar
      Typo in test name · b4e43657
      kov@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4e43657
    • ossy@webkit.org's avatar
      Rubber-stamped by Tor Arne Vestbø. · cce369d1
      ossy@webkit.org authored
      [Qt] Add platform specific expected files for new tests pass in fast/css.
      
      Rendertree results compared to Mac expected files with --ignore-metrics,
      pixel results compared to Mac png files.
      
      fast/css/font-face-opentype.html introduced in r54855.
      fast/css/inline-element-line-break.html introduced in r54544.
      fast/css/pseudo-element-line-break.html introduced in r54544.
      
      * platform/qt/fast/css/font-face-opentype-expected.txt: Added.
      * platform/qt/fast/css/inline-element-line-break-expected.txt: Added.
      * platform/qt/fast/css/pseudo-element-line-break-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cce369d1
    • zimmermann@webkit.org's avatar
      2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com> · 129d1d5c
      zimmermann@webkit.org authored
              Not reviewed. Try to turn SnowLeopard slave green again. Skipping media/video-load-networkState.html - already filed a bug last year.
      
              * platform/mac-snowleopard/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      129d1d5c
    • zimmermann@webkit.org's avatar
      2010-02-17 Nikolas Zimmermann <nzimmermann@rim.com> · 542936e8
      zimmermann@webkit.org authored
              Not reviewed. Try to turn Tiger slave green again. Skipping media/video-display-aspect-ratio.html - already skipped on the other mac variants & win.
      
              * platform/mac-tiger/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542936e8