1. 24 Aug, 2010 40 commits
    • eric@webkit.org's avatar
      2010-08-24 Dumitru Daniliuc <dumi@chromium.org> · 24f75d92
      eric@webkit.org authored
              Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet.
      
              * platform/chromium/test_expectations.txt:
      2010-08-24  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Fix one more html5lib test case for button scoping
              https://bugs.webkit.org/show_bug.cgi?id=44583
      
              I <3 test driven development.
      
              * html/HTMLTreeBuilder.cpp:
              (WebCore::HTMLTreeBuilder::processStartTagForInBody):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f75d92
    • dumi@chromium.org's avatar
      Unreviewed, Chromium's LayoutTestController does not implement markerTextForListItem() yet. · a7bfdbd1
      dumi@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7bfdbd1
    • eric@webkit.org's avatar
      2010-08-24 Eric Seidel <eric@webkit.org> · 95f68a53
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              commit-queue and EWS bots should report all failures
              https://bugs.webkit.org/show_bug.cgi?id=41820
      
              Right now commit-queue/EWS only report failures when the
              patch under testing fails.  We should report all failures
              to the status server so that we can diagnose when the bots
              are wedged w/o needing to log into the machines.
      
              I also reduced the amount of data we upload since we've seen
              timeouts during status upload.
      
              * Scripts/webkitpy/common/system/executive.py:
              * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95f68a53
    • eric@webkit.org's avatar
      2010-08-24 Eric Seidel <eric@webkit.org> · 34e90339
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Remove HTML5 parser testing infrastructure now that we don't need it
              https://bugs.webkit.org/show_bug.cgi?id=44581
      
              * html5lib/runner-expected-html5.txt: Removed.
              * html5lib/webkit-resumer-expected-html5.txt: Removed.
      2010-08-24  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Remove HTML5 parser testing infrastructure now that we don't need it
              https://bugs.webkit.org/show_bug.cgi?id=44581
      
              Just removing dead code, no tests.
      
              * dom/DocumentFragment.cpp:
              * dom/DocumentFragment.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
      2010-08-24  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Remove HTML5 parser testing infrastructure now that we don't need it
              https://bugs.webkit.org/show_bug.cgi?id=44581
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      2010-08-24  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Remove HTML5 parser testing infrastructure now that we don't need it
              https://bugs.webkit.org/show_bug.cgi?id=44581
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              (initializeGlobalsFromCommandLineOptions):
              * Scripts/old-run-webkit-tests:
              * Scripts/test-html5-parser: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34e90339
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · d7243ab1
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove unneeded include in HTMLPreloadScanner
              https://bugs.webkit.org/show_bug.cgi?id=44552
      
              Slowly but steadily sweeping up the dust in the HTML parser.
      
              * html/HTMLPreloadScanner.cpp:
              * html/HTMLPreloadScanner.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7243ab1
    • eric@webkit.org's avatar
      2010-08-24 Eric Seidel <eric@webkit.org> · 1ac12b95
      eric@webkit.org authored
              Unreviewed.  Just adding test results.
      
              XMLDocumentParser needs to implement DocumentParser::detach()
              https://bugs.webkit.org/show_bug.cgi?id=44533
      
              I was lame before and forgot to add results or mark this test
              as dumpAsText().
      
              * fast/css/font-face-svg-decoding-error-expected.txt: Added.
              * fast/css/font-face-svg-decoding-error.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ac12b95
    • kinuko@chromium.org's avatar
      2010-08-24 Kinuko Yasuda <kinuko@chromium.org> · a25a1c55
      kinuko@chromium.org authored
              Reviewed by Dumitru Daniliuc.
      
              Implement virtual path utilities for FileSystem API
              https://bugs.webkit.org/show_bug.cgi?id=44132
      
              No new tests; tests will be added later. (Each DOMFilePath's method is briefly tested locally.)
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * storage/DOMFilePath.cpp: Added.
              * storage/DOMFilePath.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a25a1c55
    • dumi@chromium.org's avatar
      Unreviewed, updating Chromium expectations. · 530ba652
      dumi@chromium.org authored
      * platform/chromium-mac/fast/js/kde/Number-expected.txt:
      * platform/chromium-mac/fast/js/number-toExponential-expected.txt:
      * platform/chromium-mac/fast/js/number-tofixed-expected.txt:
      * platform/chromium-mac/fast/js/number-toprecision-expected.txt:
      * platform/chromium-win/fast/js/kde/Number-expected.txt:
      * platform/chromium-win/fast/js/number-toExponential-expected.txt:
      * platform/chromium-win/fast/js/number-tofixed-expected.txt:
      * platform/chromium-win/fast/js/number-toprecision-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      530ba652
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · 31430aa9
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              HTMLParserScheduler::create
              https://bugs.webkit.org/show_bug.cgi?id=44551
      
              * html/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::HTMLDocumentParser):
              * html/HTMLParserScheduler.h:
              (WebCore::HTMLParserScheduler::create):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31430aa9
    • jianli@chromium.org's avatar
      [chromium] WebBlobRegistry cleanup. · e924d9c5
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44571
      
      Reviewed by Darin Fisher.
      
      Remove unneeded method from WebBlobRegistry interface.
      Also remove unneeded WebBlobRegistryImpl.* files. They're already
      excluded from gyp files.
      
      * public/WebBlobRegistry.h:
      * src/WebBlobRegistryImpl.cpp: Removed.
      * src/WebBlobRegistryImpl.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e924d9c5
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · 58db5806
      abarth@webkit.org authored
              Add http/tests/security/xssAuditor/dom-write-location-inline-event.html
              to the Skipped list.  It's flaky after enabling the HTML5 fragment
              parser.  I need to investigate.  However, I'm planning to redesign the
              XSSAuditor to make use of the new parser, so it seems to make sense to
              wait a bit.
      
              * platform/mac/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58db5806
    • dbates@webkit.org's avatar
      2010-08-24 Daniel Bates <dbates@rim.com> · 262b42a4
      dbates@webkit.org authored
              Fix the change log date associated with changeset 65967
              <http://trac.webkit.org/changeset/65967> in both the
              LayoutTests and WebCore change log.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      262b42a4
    • dbates@webkit.org's avatar
      2010-08-24 Daniel Bates <dbates@rim.com> · 9bbce728
      dbates@webkit.org authored
              Fix code comment as per Darin Adler's suggestion in <https://bugs.webkit.org/show_bug.cgi?id=44486#c2>.
              I inadvertently did not update this comment when I landed changeset 65967 <http://trac.webkit.org/changeset/65967>.
      
              * rendering/RenderListMarker.cpp:
              (WebCore::listMarkerSuffix):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bbce728
    • weinig@apple.com's avatar
      WebKit2 should launch the WebProcess in 32-bit mode if the UIProcess is in 32-bit mode · 7f2f86c3
      weinig@apple.com authored
      <rdar://problem/8348100>
      https://bugs.webkit.org/show_bug.cgi?id=44537
      
      Reviewed by Mark Rowe.
      
      * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
      (WebKit::ProcessLauncher::launchProcess): Use posix_spawnattr_setbinpref_np
      to tell posix_spawn to launch the WebProcess in 32-bit mode when the UIProcess
      is running in 32-bit mode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f2f86c3
    • dbates@webkit.org's avatar
      2010-08-23 Daniel Bates <dbates@rim.com> · dd6ec3e5
      dbates@webkit.org authored
              Reviewed by Darin Adler.
      
              Suffix for CSS alphabetic list style types should fallback to
              decimal for ordinals outside of their representable range
              https://bugs.webkit.org/show_bug.cgi?id=44486
      
              Test: fast/lists/w3-css3-list-styles-fallback-style.html
      
              Fixes an issue where the decimal suffix is not used for
              ordinals that cannot be represented by the alphabetic list
              style type.
      
              Currently, for ordinals that cannot be represented in the
              alphabetic list style we use the suffix associated with the
              list style. Instead, we should use the suffix for the decimal
              list style ('.'). For instance, when the list style type is
              Afar and the starting ordinal is 0, then we fallback to the
              decimal list style suffix '.' because 0 cannot be represented
              in Afar.
      
              * rendering/RenderListMarker.cpp:
              (WebCore::toRoman): Moved bounds check into WebCore::effectiveListMarkerType().
              (WebCore::toAlphabetic): Ditto.
              (WebCore::toHebrew): Ditto.
              (WebCore::toArmenian): Ditto.
              (WebCore::toGeorgian): Ditto.
              (WebCore::toCJKIdeographic): Ditto.
              (WebCore::effectiveListMarkerType): Added.
              (WebCore::listMarkerSuffix): Added value parameter to prototype.
              Modified to call WebCore::effectiveListMarkerType.
              (WebCore::listMarkerText): Modified to call WebCore::effectiveListMarkerType().
              (WebCore::RenderListMarker::paint): Modified to pass list item ordinal (i.e. m_listItem->value()) to WebCore::listMarkerSuffix().
              (WebCore::RenderListMarker::calcPrefWidths): Ditto.
              (WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
      2010-08-23  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Darin Adler.
      
              Suffix for CSS alphabetic list style types should fallback to
              decimal for ordinals outside of their representable range
              https://bugs.webkit.org/show_bug.cgi?id=44486
      
              Tests that CSS list styles fallback to the decimal list style
              for ordinals that cannot be represented. We need to implement
              DRT support to test the actual suffix (see bug #44489).
      
              Also, adds test for ordinal 0 for each numeric list style type.
      
              * fast/lists/resources/w3-css3-list-styles-alphabetic.css: Added.
              * fast/lists/w3-css3-list-styles-alphabetic.html: Moved CSS list styles to file w3-css3-list-styles-alphabetic.css,
              * fast/lists/w3-css3-list-styles-fallback-style-expected.txt: Added.
              * fast/lists/w3-css3-list-styles-fallback-style.html: Added.
              * fast/lists/w3-css3-list-styles-numeric-expected.txt: Added test for ordinal 0 for each list style type.
              * fast/lists/w3-css3-list-styles-numeric.html: Rebased result.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd6ec3e5
    • tkent@chromium.org's avatar
      2010-08-24 Kent Tamura <tkent@chromium.org> · c70650e6
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Fix 28 inspector test crashes
              https://bugs.webkit.org/show_bug.cgi?id=44574
      
              * platform/chromium/drt_expectations.txt:
      2010-08-24  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Fix 28 inspector test crashes
              https://bugs.webkit.org/show_bug.cgi?id=44574
      
              Reset DevToolsClient and DevToolsAgent before closing a DevTools
              WebView in order to avoid accessing to a deleted WebView instance.
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::closeDevTools):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70650e6
    • barraclough@apple.com's avatar
      Windows build fix. · d80c23c8
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d80c23c8
    • abarth@webkit.org's avatar
      2010-08-24 Adam Barth <abarth@webkit.org> · e7ba617a
      abarth@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Hulu popups are blocked
              https://bugs.webkit.org/show_bug.cgi?id=44572
      
              We were blocking popups created by Flash Player because we were never
              setting the UserGestureIndicator for events.  Most WebKit ports handle
              events through EventHandler, but Chromium is special (for some unknown
              reason) and dispatches events directly.  That means Chromium misses out
              on some of the work done by EventHandler, including setting the
              UserGestureIndicator.
      
              I suspect this is covered by an existing LayoutTest, but I don't have
              the ability to run the Chromium LayoutTests on this machine.  :(
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::handleInputEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7ba617a
    • barraclough@apple.com's avatar
      Windows build fix. · aad73d3a
      barraclough@apple.com authored
      * ForwardingHeaders/wtf/DecimalNumber.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aad73d3a
    • barraclough@apple.com's avatar
      Windows build fix. · 3f640ba9
      barraclough@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * wtf/DecimalNumber.h:
      (WTF::DecimalNumber::intPow10):
      * wtf/dtoa.cpp:
      * wtf/dtoa.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f640ba9
    • ojan@chromium.org's avatar
      2010-08-24 Ojan Vafai <ojan@chromium.org> · 9a75910c
      ojan@chromium.org authored
              Reviewed by Darin Adler.
      
              GC before running an iteration in the perf tests
              https://bugs.webkit.org/show_bug.cgi?id=44570
      
              This is a speculative attempt at reducing flakiness.
              There definitely are a lot of collected for some tests,
              so, having GC happen in the middle of a run may very well
              be causing flakiness.
      
              * resources/magnitude-perf.js:
              (Magnitude._runIteration):
              (Magnitude):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a75910c
    • tony@chromium.org's avatar
      2010-08-24 Tony Chang <tony@chromium.org> · f2ad94b0
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] rebaseline chromium linux svg tests
              https://bugs.webkit.org/show_bug.cgi?id=44562
      
              These are anti-aliasing (rounding) differences on Linux.
      
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: The number 600 has a few pixels of extra space between characters.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
              * platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
              * platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
              * platform/chromium-linux/svg/custom/animate-path-morphing-expected.checksum:
              * platform/chromium-linux/svg/custom/animate-path-morphing-expected.png:
              * platform/chromium-linux/svg/custom/use-transform-expected.checksum:
              * platform/chromium-linux/svg/custom/use-transform-expected.png:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2ad94b0
    • barraclough@apple.com's avatar
      JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=44487 · 798f064d
      barraclough@apple.com authored
      Reviewed by Oliver Hunt.
      
      Number.toExponential/toFixed/toPrecision all contain a spaghetti of duplicated
      code & unnecessary complexity. Add a new DecimalNumber class to encapsulate
      double to string conversion, share the implementations of rounding &
      decimal-fraction/exponential formatting.
      
      * JavaScriptCore.exp:
          Update exports.
      
      * runtime/NumberPrototype.cpp:
      (JSC::toThisNumber):
      (JSC::getIntegerArgumentInRange):
          Helper methods used in implementing toExponential/toFixed/toString.
      (JSC::numberProtoFuncToExponential):
      (JSC::numberProtoFuncToFixed):
      (JSC::numberProtoFuncToPrecision):
          Reimplemented using new DecimalNumber class.
                  
      * runtime/UString.cpp:
      (JSC::UString::number):
          Updated to call numberToString.
      
      * wtf/DecimalNumber.h: Added.
      (WTF::):
      (WTF::DecimalNumber::DecimalNumber):
      (WTF::DecimalNumber::toStringDecimal):
      (WTF::DecimalNumber::toStringExponential):
      (WTF::DecimalNumber::sign):
      (WTF::DecimalNumber::exponent):
      (WTF::DecimalNumber::significand):
      (WTF::DecimalNumber::precision):
      (WTF::DecimalNumber::init):
      (WTF::DecimalNumber::isZero):
      (WTF::DecimalNumber::roundToPrecision):
          New class to perform double to string conversion.
          Has three constructors, which allow conversion with no rounding,
          rounding to significant-figures, or rounding to decimal-places,
          and two methods for formatting strings, either using decimal
          fraction or exponential encoding. Internal implementation uses
          pre-rounding of the values before calling dtoa rather than
          relying on dtoa to correctly round, which does not produce
          fully accurate results. Hopefully we can address this in the
          near future.
      
      * wtf/dtoa.cpp:
      (WTF::intPow10):
      * wtf/dtoa.h:
          intPow10 is used internally by DecimalNumber.
                  
      * wtf/text/WTFString.cpp:
      (WTF::copyToString):
      (WTF::nanOrInfToString):
          Used internally in numberToString for NaN/Infinity handling.
      (WTF::numberToString):
          Added new method to convert doubles to strings.
      
      * wtf/text/WTFString.h:
          Added declaration for numberToString. This is here because
          we should switch over to using this for all double to string
          conversion in WebCore (see section 2.4.4.3 of the HTML5 spec).
      
      JavaScriptGlue: https://bugs.webkit.org/show_bug.cgi?id=44487
      
      Reviewed by Oliver Hunt.
      
      * ForwardingHeaders/wtf/text/WTFString.h: Added.
      
      WebCore: https://bugs.webkit.org/show_bug.cgi?id=44487
      
      Reviewed by Oliver Hunt.
      
      * html/LegacyHTMLTreeBuilder.cpp:
      (WebCore::serializeForNumberType):
          Update function call to numberToString.
      
      LayoutTests: Bug 44487 - Clean up NumberPrototype.cpp
      
      Reviewed by Oliver Hunt.
      
      This patch changes some layout test results - in all these cases we were
      not previously accurate to spec defined behaviour, and we are still not
      - but overall this changes reduces the overall magnitude of error due to
      rounding differences. The underlying problem is that we should be using
      dtoa to generate results to a specified accuracy, rather than relying on
      pre-rounding the input values. We should look at reenabling our dtoa
      implementation to work in this fashion as a separate change.
      
      * fast/js/kde/Number-expected.txt:
      * fast/js/kde/script-tests/Number.js:
      * fast/js/number-toExponential-expected.txt:
      * fast/js/number-tofixed-expected.txt:
      * fast/js/number-toprecision-expected.txt:
      * fast/js/script-tests/number-toExponential.js:
      * fast/js/script-tests/number-tofixed.js:
      * fast/js/script-tests/number-toprecision.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798f064d
    • eric@webkit.org's avatar
      2010-08-24 Eric Seidel <eric@webkit.org> · 20943561
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              XMLDocumentParser needs to implement DocumentParser::detach()
              https://bugs.webkit.org/show_bug.cgi?id=44533
      
              Added a test which uses an image as an SVG font (decoding errors galore).
      
              XML versions of one of the tests from
              http://trac.webkit.org/changeset/65692
      
              * fast/css/font-face-svg-decoding-error.html: Added.
              * fast/frames/resources/set-src-to-javascript-url.xhtml: Added.
              * fast/frames/set-parent-src-synchronously.xhtml: Added.
      2010-08-24  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              XMLDocumentParser needs to implement DocumentParser::detach()
              https://bugs.webkit.org/show_bug.cgi?id=44533
      
              Test: fast/frames/set-parent-src-synchronously.xhtml
      
              In the example from the page we were accessing document()
              after DocumentParser::detach() was called.  To prevent this
              I added an ASSERT(m_document) to document(), causing many
              test cases to cover the bug shown in bug 44533.
      
              To fix the bug, I implemented XMLDocumentParser::detach()
              and had it call clearCurrentNodeStack(), thus making
              it impossible for XMLDocumentParser to still have the Document
              on the node stack after detach (which was what was causing this bug).
      
              While fixing this, I noticed that XMLDocumentParser may have the
              same trouble crashing that the HTMLDocumentParser did when
              synchronously deleted from JS (for example by an iframe navigation).
              I added a test case to cover this and protected the parser after
              the two places it executes scripts.
      
              * dom/DocumentParser.h:
              (WebCore::DocumentParser::document):
              (WebCore::DocumentParser::isDetached):
              * dom/RawDataDocumentParser.h:
              (WebCore::RawDataDocumentParser::finish):
              * dom/XMLDocumentParser.cpp:
              (WebCore::XMLDocumentParser::append):
              (WebCore::XMLDocumentParser::detach):
              (WebCore::XMLDocumentParser::notifyFinished):
              * dom/XMLDocumentParser.h:
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::XMLDocumentParser::doWrite):
              (WebCore::XMLDocumentParser::endElementNs):
              (WebCore::XMLDocumentParser::resumeParsing):
              * html/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::pumpTokenizer):
              (WebCore::HTMLDocumentParser::willPumpLexer):
              (WebCore::HTMLDocumentParser::didPumpLexer):
              (WebCore::HTMLDocumentParser::end):
              (WebCore::HTMLDocumentParser::endIfDelayed):
              (WebCore::HTMLDocumentParser::script):
              * html/HTMLViewSourceParser.cpp:
              (WebCore::HTMLViewSourceParser::updateTokenizerState):
              * html/HTMLViewSourceParser.h:
              (WebCore::HTMLViewSourceParser::document):
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocumentParser::document):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20943561
    • commit-queue@webkit.org's avatar
      2010-08-24 Patrick Gansterer <paroga@paroga.com> · d778ab0b
      commit-queue@webkit.org authored
              Reviewed by Adam Roben.
      
              Add SynchronousLoader for ResourceHandleWin
              https://bugs.webkit.org/show_bug.cgi?id=44452
      
              * platform/network/win/ResourceHandleWin.cpp:
              (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
              (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
              (WebCore::WebCoreSynchronousLoader::didReceiveData):
              (WebCore::WebCoreSynchronousLoader::didFinishLoading):
              (WebCore::WebCoreSynchronousLoader::didFail):
              (WebCore::ResourceHandle::loadResourceSynchronously):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d778ab0b
    • dumi@chromium.org's avatar
      Unreviewed, updating a chromium-linux expectation. · 20859a46
      dumi@chromium.org authored
      * platform/chromium-linux/svg/css/shadow-changes-expected.checksum: Added.
      * platform/chromium-linux/svg/css/shadow-changes-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20859a46
    • kbr@google.com's avatar
      2010-08-24 Kenneth Russell <kbr@google.com> · 7a95d225
      kbr@google.com authored
              Unreviewed, test expectations update. Skip
              fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html while
              root cause of failure is being investigated. See
              https://bugs.webkit.org/show_bug.cgi?id=44459 .
      
              * platform/mac-snowleopard/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a95d225
    • tkent@chromium.org's avatar
      2010-08-24 Kent Tamura <tkent@chromium.org> · ad5f6044
      tkent@chromium.org authored
              Unreviewed, test expectation update.
      
              * platform/chromium/drt_expectations.txt: Add inspector test failures.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad5f6044
    • dpranke@chromium.org's avatar
      2010-08-24 Dirk Pranke <dpranke@chromium.org> · bbf56387
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              new-run-webkit-tests: clean up code for test_types, test_failures
      
              Add a bunch of unit tests for webkitpy.layout_tests.test_types and
              webkitpy.layout_tests.layout_package.test_failures, and remove
              some dead code and otherwise clean up things.
      
              https://bugs.webkit.org/show_bug.cgi?id=44559
      
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
              * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
              * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
              * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbf56387
    • adachan@apple.com's avatar
      Reviewed by Steve Falkenburg. · 4acc1e98
      adachan@apple.com authored
              <rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
              https://bugs.webkit.org/show_bug.cgi?id=44564
      
              * WebView.cpp:
              (WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
              if plugins are disabled.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4acc1e98
    • dpranke@chromium.org's avatar
      2010-08-24 Dirk Pranke <dpranke@chromium.org> · af00a02f
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              new-run-webkit-tests: revise unit testing strategy for test failures
      
              This change revamps the way we store test data for new-run-webkit-tests.
              Previously we had a few copies of test files from the main test tree.
              Now we have a bunch of completely fake test data and use the test
              data to generate different kinds of test failures, getting
              much better coverage.
      
              https://bugs.webkit.org/show_bug.cgi?id=44556
      
              * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
              * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
              * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
              * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
              * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
              * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
              * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
              * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
              * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
              * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
              * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
              * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
              * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
              * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
              * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
              * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
              * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
              * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
              * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
              * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af00a02f
    • rniwa@webkit.org's avatar
      2010-08-24 Ryosuke Niwa <rniwa@webkit.org> · 367f437e
      rniwa@webkit.org authored
              Unreviewed.
      
              Replaced soft tab indentation by hard tab indentation for LegacyWebArchive.h.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      367f437e
    • dpranke@chromium.org's avatar
      2010-08-24 Dirk Pranke <dpranke@chromium.org> · de2c27a7
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              speed up new-run-webkit-tests unit tests
      
              Add a --no-record-results flag that turns off generating the JSON
              results file on every test run. Generating the file requires us to
              fetch the old results down from the bots, which can be slow. This
              flag is off by default.
      
              Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
      
              These changes together shorten the test cycle from ~4.5s to ~1.5s
              - a 3x speedup.
      
              https://bugs.webkit.org/show_bug.cgi?id=44553
      
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de2c27a7
    • dumi@chromium.org's avatar
      Unreviewed, more Chromium-specific expectations. · 302794ec
      dumi@chromium.org authored
      * platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/multicol-repaint-expected.png: Added.
      * platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum: Added.
      * platform/chromium-win/fast/repaint/multicol-repaint-expected.png: Added.
      * platform/chromium-win/fast/repaint/multicol-repaint-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      302794ec
    • oliver@apple.com's avatar
      2010-08-24 Oliver Hunt <oliver@apple.com> · a27a7a70
      oliver@apple.com authored
              Reviewed by Geoff Garen.
      
              Don't seed the JS random number generator from time()
              https://bugs.webkit.org/show_bug.cgi?id=41868
              <rdar://problem/8171025>
      
              Switch to using the secure random number generator to
              seed the fast random generator, and make the generator
              be per global object.
      
              * runtime/JSGlobalData.cpp:
              (JSC::JSGlobalData::JSGlobalData):
              * runtime/JSGlobalData.h:
              * runtime/JSGlobalObject.h:
              (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
              (JSC::JSGlobalObject::weakRandomNumber):
              * runtime/MathObject.cpp:
              (JSC::mathProtoFuncRandom):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a27a7a70
    • jianli@chromium.org's avatar
      [chromium] Update WebBlobData. · 60409623
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44481
      
      Reviewed by Darin Fisher.
      
      Some changes to WebBlobData to match with chromium implementation.
      1) Change to use WebCString for data, instead of WebData.
      2) Separate path from URL.
      
      * public/WebBlobData.h:
      * src/WebBlobData.cpp:
      (WebKit::WebBlobData::itemAt):
      (WebKit::WebBlobData::appendData):
      (WebKit::WebBlobData::appendBlob):
      * src/WebBlobStorageData.cpp:
      (WebKit::WebBlobStorageData::itemAt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60409623
    • dumi@chromium.org's avatar
      Unreviewed, updating Chromium-specific expectations. · 1d6278b8
      dumi@chromium.org authored
      * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
      * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
      * platform/chromium-win/svg/css/shadow-changes-expected.checksum: Added.
      * platform/chromium-win/svg/css/shadow-changes-expected.png: Added.
      * platform/chromium-win/svg/css/shadow-changes-expected.txt: Added.
      * platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.checksum: Added.
      * platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d6278b8
    • tony@chromium.org's avatar
      2010-08-24 Tony Chang <tony@chromium.org> · 8f3e3280
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              [chromium] fix the platform result fallback order on mac/win
              https://bugs.webkit.org/show_bug.cgi?id=44483
      
              * Scripts/webkitpy/layout_tests/port/google_chrome.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f3e3280
    • joepeck@webkit.org's avatar
      2010-08-24 Joseph Pecoraro <joepeck@webkit.org> · 8b4beca5
      joepeck@webkit.org authored
              Reviewed by Mark Rowe.
      
              Web Inspector: RemoteInspectorFrontend can be renamed to InspectorFrontend
              https://bugs.webkit.org/show_bug.cgi?id=44499
      
              Follow-up. No longer generate the RemoteInspectorFrontend files, just
              generate the required InspectorFrontend files.
      
              * DerivedSources.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b4beca5
    • joepeck@webkit.org's avatar
      2010-08-20 Joseph Pecoraro <joepeck@webkit.org> · 514c5cf4
      joepeck@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Backend Should Provide Full Supported CSS Properties List
              https://bugs.webkit.org/show_bug.cgi?id=40886
      
              This allows the backend to send the front-end its complete list of
              supported CSS Properties. This is used in CSS Autocompletion and
              CSS Syntax Highlighting to show which styles are supported.
      
              * css/makeprop.pl: moved CSS properties to the header file.
              * inspector/Inspector.idl: expose getSupportedCSSProperties.
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
              * inspector/InspectorDOMAgent.h:
              * inspector/front-end/CSSCompletions.js:
              (WebInspector.CSSCompletions._firstIndexOfPrefix): handle a possible error case before properties have loaded.
              (WebInspector.CSSCompletions._load): fill up the special array with the received properties.
              * inspector/front-end/SourceCSSTokenizer.js:
              (WebInspector.SourceCSSTokenizer): use the list of support properties from the backend.
              * inspector/front-end/SourceCSSTokenizer.re2js:
              * inspector/front-end/inspector.js: request the list of supported CSS properties on load.
              (WebInspector.doLoadedDone):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      514c5cf4