1. 18 Jan, 2011 40 commits
    • commit-queue@webkit.org's avatar
      2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com> · 24d88faf
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Support background-clip: content-box
              https://bugs.webkit.org/show_bug.cgi?id=48771
      
              Addded content-box as a valid background-clip value.
      
              * WebCore/css/CSSParser.cpp:
              (WebCore::parseBackgroundClip):
      2011-01-18  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
      
              Reviewed by Simon Fraser.
      
              Support background-clip: content-box
              https://bugs.webkit.org/show_bug.cgi?id=48771
      
              Added test cases to check the various valid background-clip values.
      
              * fast/css/background-clip-text-expected.txt:
              * fast/css/background-clip-values-expected.checksum: Added.
              * fast/css/background-clip-values-expected.txt: Added.
              * fast/css/background-clip-values.html: Added.
              * fast/css/script-tests/background-clip-text.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24d88faf
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · 866b5d48
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Assertion when loading two URLs in quick succession
              https://bugs.webkit.org/show_bug.cgi?id=52649
              <rdar://problem/8764645>
      
              If beginLoad is called twice without didStartProvisionalLoad being called in between,
              m_pendingProvisionalSandboxExtension would be non-null and an assert would fire.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::SandboxExtensionTracker::beginLoad):
              Instead of asserting that m_pendingProvisionalSandboxExtension is null, invalidate it
              if it is not null, since that's valid.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      866b5d48
    • dpranke@chromium.org's avatar
      2011-01-18 Dirk Pranke <dpranke@chromium.org> · aa663460
      dpranke@chromium.org authored
              Reviewed by Mihai Parparita.
      
              new-run-webkit-tests shouldn't crash when you try to run a
              directory containing only skipped files.
      
              https://bugs.webkit.org/show_bug.cgi?id=52478
      
              * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa663460
    • cfleizach@apple.com's avatar
      REGRESSION: A problem with Voiceover and finding links · 99abb088
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52324
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Fallout from recent change to make WebCore return its own scroll view.
         1) There were two scroll views in the hierarchy, one which no needed to be ignored.
         2) Hit tests for sub frames needed to be offset.
         3) The check for whether an attachment is ignored must happen earlier than using
            the helpText to determine if an element should be ignored.
      
      Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper scrollViewParent]):
      
      Source/WebKit/mac: 
      
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView accessibilityIsIgnored]):
      
      LayoutTests: 
      
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
      * platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99abb088
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · b6d7b24d
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Implement NPN_PopUpContextMenu
              https://bugs.webkit.org/show_bug.cgi?id=52646
              <rdar://problem/8735616>
      
              * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
              (WebKit::NPN_PopUpContextMenu):
              Call NetscapePlugin::popUpContextMenu.
      
              * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
              (WebKit::NetscapePlugin::NetscapePlugin):
              Initialize m_currentMouseEvent.
      
              * WebProcess/Plugins/Netscape/NetscapePlugin.h:
              Add m_currentMouseEvent.
      
              * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
              (WebKit::NetscapePlugin::popUpContextMenu):
              Convert the coordinates from the current mouse event to screen coordinates and call
              WKPopupContextMenu.
      
              (WebKit::NetscapePlugin::platformHandleMouseEvent):
              Update m_currentMouseEvent.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6d7b24d
    • andersca@apple.com's avatar
      Add WKPopupContextMenu. · 13cf2448
      andersca@apple.com authored
      Reviewed by Darin Adler.
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13cf2448
    • aroben@apple.com's avatar
      Call alternate CFHTTPCookie functions if available · f367cb5f
      aroben@apple.com authored
      Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.
      
      Reviewed by Darin Adler.
      
      * platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to
      pull in the alternate CFHTTPCookie functions.
      
      (WebCore::cookieDomain):
      (WebCore::cookieExpirationTime):
      (WebCore::cookieName):
      (WebCore::cookiePath):
      (WebCore::cookieValue):
      Added these wrappers around the CFHTTPCookie functions. We call the
      alternate functions if they exist, otherwise fall back to the current
      functions.
      
      (WebCore::filterCookies):
      (WebCore::getRawCookies):
      (WebCore::deleteCookie):
      Changed to use the wrapper functions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f367cb5f
    • jberlin@webkit.org's avatar
      WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null · d83d34db
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52641
      
      Reviewed by Darin Adler.
      
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::didStartProvisionalLoad):
      (WebKit::WebFrameProxy::didCommitLoad):
      (WebKit::WebFrameProxy::didFinishLoad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d83d34db
    • mrobinson@webkit.org's avatar
      2011-01-18 Martin Robinson <mrobinson@igalia.com> · d418a3a1
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] Filenames are converted to URLs during edit drags
              https://bugs.webkit.org/show_bug.cgi?id=52096
      
              * platform/gtk/Skipped: Unskip passing test. Fix a misspelled
              drag and drop test on the list as well.
      2011-01-18  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Eric Seidel.
      
              [GTK] Filenames are converted to URLs during edit drags
              https://bugs.webkit.org/show_bug.cgi?id=52096
      
              * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
              conversion policy allows it.
              (WebCore::DragData::containsURL): Ditto.
              (WebCore::DragData::asURL): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d418a3a1
    • jorlow@chromium.org's avatar
      2011-01-18 Jeremy Orlow <jorlow@chromium.org> · 9b84d5f3
      jorlow@chromium.org authored
              [Chromium] Create baselines for svg/css/text-gradient-shadow.svg
              https://bugs.webkit.org/show_bug.cgi?id=52640
      
              * platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b84d5f3
    • mrobinson@webkit.org's avatar
      2011-01-18 Martin Robinson <mrobinson@igalia.com> · 6492a44c
      mrobinson@webkit.org authored
              Skip two tests which were incorrectly passing before GTK+
              had support for beginDragWithFiles.
      
              * platform/gtk/Skipped: Skip failing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6492a44c
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · cecb7419
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              ASSERT in plug-in code when going to youtube
              https://bugs.webkit.org/show_bug.cgi?id=52638
      
              * PluginProcess/PluginControllerProxy.cpp:
              (WebKit::PluginControllerProxy::paintEntirePlugin):
              Don't try to paint the plug-in if the plug-in frame is empty.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cecb7419
    • jknotten@chromium.org's avatar
      2011-01-18 John Knottenbelt <jknotten@chromium.org> · 775c7bc1
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
              https://bugs.webkit.org/show_bug.cgi?id=52633
      
              Combine test expectations for the test into one line.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      775c7bc1
    • andersca@apple.com's avatar
      2011-01-18 Anders Carlsson <andersca@apple.com> · b1adb2d7
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
      
              Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess
              https://bugs.webkit.org/show_bug.cgi?id=52635
              <rdar://problem/8731337>
      
              * PluginProcess/PluginProcess.cpp:
              (WebKit::PluginProcess::initialize):
              Call platformInitialize.
      
              * PluginProcess/PluginProcess.h:
              Add platformInitialize.
      
              * PluginProcess/mac/PluginProcessMac.mm:
              (WebKit::PluginProcess::platformInitialize):
              Set the compositing render server port and the visible application name.
      
              * Shared/Plugins/PluginProcessCreationParameters.cpp:
              (WebKit::PluginProcessCreationParameters::encode):
              (WebKit::PluginProcessCreationParameters::decode):
              Encode/decode the parent process name.
      
              * Shared/Plugins/PluginProcessCreationParameters.h:
              Add parentProcessName.
      
              * Shared/WebProcessCreationParameters.cpp:
              (WebKit::WebProcessCreationParameters::encode):
              (WebKit::WebProcessCreationParameters::decode):
              Encode/decode the parent process name.
      
              * Shared/WebProcessCreationParameters.h:
              Add parentProcessName.
      
              * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
              (WebKit::ProcessLauncher::launchProcess):
              Don't pass the parent process name here.
      
              * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
              (WebKit::PluginProcessProxy::platformInitializePluginProcess):
              Set the visible name.
      
              * UIProcess/mac/WebContextMac.mm:
              (WebKit::WebContext::platformInitializeWebProcess):
              Pass along the parent process name.
      
              * WebProcess/mac/WebProcessMac.mm:
              (WebKit::WebProcess::platformInitializeWebProcess):
              Set the visible name.
      
              * WebProcess/mac/WebProcessMainMac.mm:
              (WebKit::WebProcessMain):
              Don't set the visible name here. It's done in platformInitializeWebProcess.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1adb2d7
    • commit-queue@webkit.org's avatar
      2011-01-18 Helder Correia <helder@sencha.com> · 6f93041c
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52611
      
              This is related to bug 52559. The shadow color alpha must be multiplied
              by the context brush alpha.
      
              New test to ensure correct behavior of canvas with fillPath using a
              semi-transparent fillStyle color and a shadow.
      
              * fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.
      2011-01-18  Helder Correia  <helder@sencha.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
              https://bugs.webkit.org/show_bug.cgi?id=52611
      
              This is related to bug 52559. The shadow color alpha must be multiplied
              by the context brush alpha.
      
              Test: fast/canvas/canvas-fillPath-alpha-shadow.html
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f93041c
    • jknotten@chromium.org's avatar
      2011-01-18 John Knottenbelt <jknotten@chromium.org> · 30d4f8e3
      jknotten@chromium.org authored
              Unreviewed; updated chromium test expectations.
      
              [Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
              https://bugs.webkit.org/show_bug.cgi?id=52633
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30d4f8e3
    • mrobinson@webkit.org's avatar
      2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson ... · ed7744cb
      mrobinson@webkit.org authored
      2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] The GTK+ EventSender needs support for beginDragWithFiles
              https://bugs.webkit.org/show_bug.cgi?id=40833
      
              Unskip passing tests, add in a GTK+-specific result and one more result
              which is necessary because GTK+ tests run in Xvfb.
      
              * platform/gtk/Skipped: Unskip tests that are now passing and organize
              the remaining skipped tests.
              * platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
              * platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.
      2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] The GTK+ EventSender needs support for beginDragWithFiles
              https://bugs.webkit.org/show_bug.cgi?id=40833
      
              * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
              GTK+ event sender.
              (dragWithFilesDragDataGetCallback): Added.
              (dragWithFilesDragEndCallback): Added.
              (beginDragWithFilesCallback): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed7744cb
    • caseq@chromium.org's avatar
      2011-01-18 Andrey Kosyakov <caseq@chromium.org> · d4c0590f
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fail resource.requestContent() immediately for WebSocket resources
              Remove webInspector.resources.Types from test expectations.
              https://bugs.webkit.org/show_bug.cgi?id=52628
      
              * inspector/extensions-api-expected.txt:
      2011-01-18  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fail resource.requestContent() immediately for WebSocket resources
              https://bugs.webkit.org/show_bug.cgi?id=52628
      
              * English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
              * inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete)
              (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used.
              (WebInspector.Resource.Type.toString): ditto.
              (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
              * inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c0590f
    • commit-queue@webkit.org's avatar
      2011-01-18 Helder Correia <helder@sencha.com> · f5812287
      commit-queue@webkit.org authored
              Reviewed by Dirk Schulze.
      
              REGRESSION(75139): SVG gradients are not applied to texts
              https://bugs.webkit.org/show_bug.cgi?id=52531
      
              r75139 caused a problem with filling and stroking text with a gradient
              fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
              was mixed up.
      
              * platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
              * svg/css/text-gradient-shadow.svg: Added.
      2011-01-18  Helder Correia  <helder@sencha.com>
      
              Reviewed by Dirk Schulze.
      
              REGRESSION(75139): SVG gradients are not applied to texts
              https://bugs.webkit.org/show_bug.cgi?id=52531
      
              r75139 caused a problem with filling and stroking text with a gradient
              fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
              was mixed up.
      
              Test: svg/css/text-gradient-shadow.svg
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5812287
    • jknotten@chromium.org's avatar
      2011-01-18 John Knottenbelt <jknotten@chromium.org> · 964064a2
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Add pixel test baseline for svg/custom/use-inherit-style.svg
              https://bugs.webkit.org/show_bug.cgi?id=52630
      
              * svg/custom/use-inherit-style-expected.checksum: Added.
              * svg/custom/use-inherit-style-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      964064a2
    • commit-queue@webkit.org's avatar
      2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn> · 2d2bdd50
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Unable to indirectly animate visibility of SVGUseElement
              https://bugs.webkit.org/show_bug.cgi?id=50240
      
              Test case to verify if SVGUseElement inherits parent's
              style change.
      
              * svg/custom/use-inherit-style-expected.txt: Added.
              * svg/custom/use-inherit-style.svg: Added.
      2011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>
      
              Reviewed by Nikolas Zimmermann.
      
              Unable to indirectly animate visibility of SVGUseElement
              https://bugs.webkit.org/show_bug.cgi?id=50240
      
              SVGUseElement::recalcStyle should take care of its shadow
              tree's style recalculation when it is called with change >= Inherit
              or when childNeedsStyleRecalc() is true because in these two
              cases needStyleRecalc() may not be true.
      
              Test: svg/custom/use-inherit-style.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::recalcStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d2bdd50
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 95363d75
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: provide script length to frontend.
              https://bugs.webkit.org/show_bug.cgi?id=52620
      
              * inspector/Inspector.idl:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype._parsedScriptSource):
              (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
              * inspector/front-end/Script.js:
              (WebInspector.Script):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95363d75
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 7d9eb55d
      podivilov@chromium.org authored
              Unreviewed, remove wrong chromium expectation for console-xhr-logging test.
      
              * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d9eb55d
    • zherczeg@webkit.org's avatar
      Fixing ChangeLog · ce5b5074
      zherczeg@webkit.org authored
      Rubber-stamped by Csaba Osztrogonác
      
      Removing a line introduced by
      http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
      Removing an unnecessary space before a time stamp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce5b5074
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · cc9a61db
      podivilov@chromium.org authored
              Unreviewed, test fix for r76019.
      
              * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
              * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc9a61db
    • caseq@chromium.org's avatar
      2011-01-17 Andrey Kosyakov <caseq@chromium.org> · 10d59b29
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [refactoring] use events to notify NetworkManager clients
              https://bugs.webkit.org/show_bug.cgi?id=52588
      
              * inspector/front-end/AuditLauncherView.js:
              (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset().
              (WebInspector.AuditLauncherView.prototype._resetResourceCount):
              (WebInspector.AuditLauncherView.prototype._onResourceStarted):
              (WebInspector.AuditLauncherView.prototype._onResourceFinished):
              * inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer):
              (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
              (WebInspector.ExtensionServer.prototype.initExtensions):
              * inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients.
              (WebInspector.NetworkManager):
              (WebInspector.NetworkManager.prototype.willSendRequest):
              (WebInspector.NetworkManager.prototype.markResourceAsCached):
              (WebInspector.NetworkManager.prototype.didReceiveResponse):
              (WebInspector.NetworkManager.prototype.didReceiveContentLength):
              (WebInspector.NetworkManager.prototype.setInitialContent):
              (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
              (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
              (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
              (WebInspector.NetworkManager.prototype._startResource):
              (WebInspector.NetworkManager.prototype._finishResource):
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkPanel):
              (WebInspector.NetworkPanel.prototype._onResourceStarted):
              (WebInspector.NetworkPanel.prototype._appendResource):
              (WebInspector.NetworkPanel.prototype._onResourceUpdated):
              (WebInspector.NetworkPanel.prototype._refreshResource):
              (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel):
              (WebInspector.ResourcesPanel.prototype._refreshResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10d59b29
    • pfeldman@chromium.org's avatar
      2011-01-18 Pavel Feldman <pfeldman@chromium.org> · 3d78324a
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: preserve pause on exception state in settings.
              https://bugs.webkit.org/show_bug.cgi?id=52619
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::getInspectorState):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState):
              (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
              (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
              (WebInspector.doLoadedDone.populateInspectorState):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d78324a
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 37dda3c5
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: fix flaky debugger tests.
              https://bugs.webkit.org/show_bug.cgi?id=51320
      
              * http/tests/inspector/debugger-test2.js:
              (initialize_DebuggerTest.InspectorTest.setBreakpoint):
              (initialize_DebuggerTest.InspectorTest.showScriptSource):
              (initialize_DebuggerTest.InspectorTest._showScriptSource):
              * inspector/debugger-pause-on-breakpoint-expected.txt:
              * inspector/debugger-pause-on-breakpoint.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37dda3c5
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 8e0c8f10
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
              https://bugs.webkit.org/show_bug.cgi?id=52623
      
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.prototype._formatMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e0c8f10
    • pfeldman@chromium.org's avatar
      2011-01-18 Pavel Feldman <pfeldman@chromium.org> · 027f107e
      pfeldman@chromium.org authored
              Revert r76017. No need to guard InspectorInstrumentation:: in WebCore.
      
              * page/Page.cpp:
              (WebCore::networkStateChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      027f107e
    • commit-queue@webkit.org's avatar
      2011-01-18 Konstantin Tokarev <annulen@yandex.ru> · 3e34da8e
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Fixed compilation when Inspector is disabled
              https://bugs.webkit.org/show_bug.cgi?id=52564
      
              * page/Page.cpp:
              (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e34da8e
    • morrita@google.com's avatar
      2011-01-18 MORITA Hajime <morrita@google.com> · fdba390e
      morrita@google.com authored
              Unreviewed, rolling out r76004, r76005, r76007, and r76011.
              http://trac.webkit.org/changeset/76004
              http://trac.webkit.org/changeset/76005
              http://trac.webkit.org/changeset/76007
              http://trac.webkit.org/changeset/76011
              https://bugs.webkit.org/show_bug.cgi?id=51664
      
              The r76004 broke pixel tests.
              (The failure was missed due to the tolerance.)
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip):
              (WebCore::GraphicsContext::clipOutRoundedRect):
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/RoundedIntRect.cpp: Removed.
              * platform/graphics/RoundedIntRect.h: Removed.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::pushContentsClip):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::paintBorder):
              (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
              (WebCore::uniformlyExpandBorderRadii):
              (WebCore::RenderBoxModelObject::paintBoxShadow):
              * rendering/RenderBoxModelObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBoxSideFromPath):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::paint):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintMenuListButtonGradients):
              (WebCore::RenderThemeMac::paintSliderTrack):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
              (WebCore::RenderThemeSafari::paintSliderTrack):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
              * rendering/style/BorderData.h:
              * rendering/style/RenderStyle.cpp:
              (WebCore::constrainCornerRadiiForRect):
              (WebCore::RenderStyle::getBorderRadiiForRect):
              (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
              * rendering/style/RenderStyle.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdba390e
    • hayato@chromium.org's avatar
      2011-01-18 Hayato Ito <hayato@chromium.org> · 7a4c7696
      hayato@chromium.org authored
              Reviewed by Kent Tamura.
      
              Update .gitignore file to reflect a recent WebKit directory movement.
      
              https://bugs.webkit.org/show_bug.cgi?id=52618
      
              * .gitignore:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a4c7696
    • kbalazs@webkit.org's avatar
      [Qt][WK2] Not implemented warnings should not break layout tests · a931a010
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52616
      
      Reviewed by Csaba Osztrogonác.
      
      * WebKit2Prefix.h: Define DISABLE_NOT_IMPLEMENTED_WARNINGS on Qt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a931a010
    • podivilov@chromium.org's avatar
      2011-01-17 Pavel Podivilov <podivilov@chromium.org> · 49f4cb5f
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add source column field to debugger call frames.
              https://bugs.webkit.org/show_bug.cgi?id=52443
      
              * bindings/js/JavaScriptCallFrame.cpp:
              (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
              * bindings/js/JavaScriptCallFrame.h:
              (WebCore::JavaScriptCallFrame::create):
              (WebCore::JavaScriptCallFrame::line):
              (WebCore::JavaScriptCallFrame::column):
              (WebCore::JavaScriptCallFrame::update):
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
              (WebCore::ScriptDebugServer::callEvent):
              (WebCore::ScriptDebugServer::atStatement):
              (WebCore::ScriptDebugServer::returnEvent):
              (WebCore::ScriptDebugServer::exception):
              (WebCore::ScriptDebugServer::willExecuteProgram):
              (WebCore::ScriptDebugServer::didExecuteProgram):
              (WebCore::ScriptDebugServer::didReachBreakpoint):
              * bindings/js/ScriptDebugServer.h:
              * bindings/v8/DebuggerScript.js:
              ():
              * bindings/v8/JavaScriptCallFrame.cpp:
              (WebCore::JavaScriptCallFrame::column):
              * bindings/v8/JavaScriptCallFrame.h:
              * inspector/InjectedScriptSource.js:
              ():
              * inspector/JavaScriptCallFrame.idl:
      
       2011-01-18  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=52370
              <rdar://problem/8856808>
              Style sharing optimization no longer works on major web sites
      
              The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
              by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
              the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.
      
              This patch gets the style sharing back to 25-40% range on most web sites.
      
              * css/CSSMutableStyleDeclaration.h:
              (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
      
                  Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
      
              * css/CSSSelector.h:
              (WebCore::CSSSelector::isSiblingSelector):
      
                  Test for selectors that are affected by the sibling elements.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::elementCanUseSimpleDefaultStyle):
              (WebCore::collectSiblingRulesInDefaultStyle):
              (WebCore::assertNoSiblingRulesInDefaultStyle):
      
                  Extract sibling rules from the MathML default stylesheet.
                  Assert that no other default stylesheet has them.
      
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::locateCousinList):
              (WebCore::CSSStyleSelector::matchesSiblingRules):
              (WebCore::CSSStyleSelector::canShareStyleWithElement):
              (WebCore::CSSStyleSelector::locateSharedStyle):
              (WebCore::CSSStyleSelector::styleForElement):
              (WebCore::collectIdsAndSiblingRulesFromList):
              (WebCore::CSSRuleSet::collectIdsAndSiblingRules):
      
                  Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
                  where style sharing can't be used.
      
              * css/CSSStyleSelector.h:
              * dom/NamedNodeMap.cpp:
              (WebCore::NamedNodeMap::mappedMapsEquivalent):
      
                  Check also for CSSValue mutation from DOM.
      
              * mathml/MathMLMathElement.cpp:
              (WebCore::MathMLMathElement::insertedIntoDocument):
              * mathml/MathMLMathElement.h:
      
                  MathML default style sheet has sibling rules which don't get noticed by the normal document
                  stylesheet parsing.
      
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setFirstChildState):
              (WebCore::InheritedFlags::setLastChildState):
              (WebCore::InheritedFlags::setChildIndex):
      
                  These all make style non-shareable (unique).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49f4cb5f
    • antti@apple.com's avatar
      Source/WebCore: 2011-01-18 Antti Koivisto <antti@apple.com> · 84c087a0
      antti@apple.com authored
      Reviewed by Dave Hyatt.
      
      https://bugs.webkit.org/show_bug.cgi?id=52370
      <rdar://problem/8856808>
      Style sharing optimization no longer works on major web sites
              
      The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated 
      by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
      the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.  
              
      This patch gets the style sharing back to 25-40% range on most web sites.
      
      * css/CSSMutableStyleDeclaration.h:
      (WebCore::CSSMutableStyleDeclaration::propertiesEqual):
                  
          Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.
              
      * css/CSSSelector.h:
      (WebCore::CSSSelector::isSiblingSelector):
              
          Test for selectors that are affected by the sibling elements.
              
      * css/CSSStyleSelector.cpp:
      (WebCore::elementCanUseSimpleDefaultStyle):
      (WebCore::collectSiblingRulesInDefaultStyle):
      (WebCore::assertNoSiblingRulesInDefaultStyle):
                  
          Extract sibling rules from the MathML default stylesheet. 
          Assert that no other default stylesheet has them.
                  
      (WebCore::CSSStyleSelector::CSSStyleSelector):
      (WebCore::CSSStyleSelector::locateCousinList):
      (WebCore::CSSStyleSelector::matchesSiblingRules):
      (WebCore::CSSStyleSelector::canShareStyleWithElement):
      (WebCore::CSSStyleSelector::locateSharedStyle):
      (WebCore::CSSStyleSelector::styleForElement):
      (WebCore::collectIdsAndSiblingRulesFromList):
      (WebCore::CSSRuleSet::collectIdsAndSiblingRules):
      
          Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
          where style sharing can't be used.
      
      * css/CSSStyleSelector.h:
      * dom/NamedNodeMap.cpp:
      (WebCore::NamedNodeMap::mappedMapsEquivalent):
                  
          Check also for CSSValue mutation from DOM. 
                  
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedIntoDocument):
      * mathml/MathMLMathElement.h:
              
          MathML default style sheet has sibling rules which don't get noticed by the normal document
          stylesheet parsing.
              
      * rendering/style/RenderStyle.h:
      (WebCore::InheritedFlags::setFirstChildState):
      (WebCore::InheritedFlags::setLastChildState):
      (WebCore::InheritedFlags::setChildIndex):
              
          These all make style non-shareable (unique).
      
      LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
      Style sharing optimization no longer works on major web sites
              
      Reviewed by Dave Hyatt.
      
      These are progressions (with no noticable visual change). 
      MathML code was improperly sharing style.
      
      * platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
      * platform/mac/mathml/presentation/subsup-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c087a0
    • morrita@google.com's avatar
      2011-01-18 MORITA Hajime <morrita@google.com> · 6d5597a4
      morrita@google.com authored
              Unreviewed crash fix on release builds.
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d5597a4
    • podivilov@chromium.org's avatar
      2011-01-18 Pavel Podivilov <podivilov@chromium.org> · 2c0f0395
      podivilov@chromium.org authored
              Unreviewed, update localizedStrings.js.
      
              * English.lproj/localizedStrings.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c0f0395
    • podivilov@chromium.org's avatar
      2011-01-11 Pavel Podivilov <podivilov@chromium.org> · 98c4f5a5
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: implement script beautifier prototype.
              https://bugs.webkit.org/show_bug.cgi?id=51588
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/ScriptFormatter.js: Added.
              (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and
              formatted line numbers
              (WebInspector.ScriptFormatter.findLineEndings):
              (WebInspector.ScriptFormatter.locationToPosition):
              (WebInspector.ScriptFormatter.positionToLocation):
              (WebInspector.ScriptFormatter.upperBound):
              (WebInspector.ScriptFormatter.prototype.format):
              (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber):
              (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber):
              (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber):
              (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition):
              (WebInspector.ScriptFormatter.prototype._convertPosition):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
              (WebInspector.ScriptsPanel.prototype._callFrameSelected):
              (WebInspector.ScriptsPanel.prototype._formatScript):
              * inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98c4f5a5
    • gyuyoung.kim@samsung.com's avatar
      2011-01-18 Gyuyoung Kim <gyuyoung.kim@samsung.com> · 97067a4b
      gyuyoung.kim@samsung.com authored
              Reviewed by Adam Barth.
      
              ews: Add additional watcher to efl ews
              https://bugs.webkit.org/show_bug.cgi?id=52613
      
              Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
      
              * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97067a4b