- 11 Feb, 2011 13 commits
-
-
abarth@webkit.org authored
Update Qt expected results for window.crypto. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/prototype-inheritance-expected.txt: * platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78329 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: command line's API inspect() is broken. https://bugs.webkit.org/show_bug.cgi?id=54275 * http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump): * inspector/command-line-api-expected.txt: Added. * inspector/command-line-api.html: Added. 2011-02-11 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: command line's API inspect() is broken. https://bugs.webkit.org/show_bug.cgi?id=54275 Test: inspector/command-line-api.html * inspector/InjectedScriptSource.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78328 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
abarth@webkit.org authored
Turns out window.crypto is supposed to be readonly. * page/DOMWindow.idl: 2011-02-11 Adam Barth <abarth@webkit.org> Update test expectations to show window.crypto. * fast/dom/Window/window-properties-expected.txt: * fast/dom/prototype-inheritance-2-expected.txt: * fast/dom/prototype-inheritance-expected.txt: * http/tests/security/cross-frame-access-put-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78327 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sergio@webkit.org authored
Unreviewed. Added new test expectations for the GTK port. * platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added. * platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added. * platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added. * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added. * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added. * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added. * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78326 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
abarth@webkit.org authored
Actually add Crypto.cpp to the Windows build. I'm terrible. * WebCore.vcproj/WebCore.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78325 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
abarth@webkit.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Attempt to fix the Windows build. Apparently we don't support conditional attributes on functions. This patch makes the whole Crypto interface conditional on ArrayBuffer support. * page/DOMWindow.idl: * page/Crypto.cpp: * page/Crypto.h: * page/Crypto.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78323 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54241 Reviewed by Dave Hyatt. Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent element stack as needed. This roughly halves the remaining time in style matching over a typical page load. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pushParentStackFrame): (WebCore::CSSStyleSelector::popParentStackFrame): (WebCore::CSSStyleSelector::pushParent): (WebCore::CSSStyleSelector::popParent): * css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame): * dom/Document.h: (WebCore::Document::styleSelectorIfExists): * dom/Element.cpp: (WebCore::Element::beginParsingChildren): (WebCore::Element::finishParsingChildren): * dom/Element.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. WebKit should have a cryptographic RNG https://bugs.webkit.org/show_bug.cgi?id=22049 Test crypto.getRandomValues API. It's pretty hard to write a deterministic API for a randomized API, but this test should catch some regressions. * security/crypto-random-values-expected.txt: Added. * security/crypto-random-values.html: Added. 2011-02-10 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. WebKit should have a cryptographic RNG https://bugs.webkit.org/show_bug.cgi?id=22049 Teach JavaScriptCore how to export this function. * JavaScriptCore.exp: * JavaScriptCore.xcodeproj/project.pbxproj: 2011-02-10 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. WebKit should have a cryptographic RNG https://bugs.webkit.org/show_bug.cgi?id=22049 Add crypto.getRandomValues. Yes, all these diffs are required to expose a single function to the DOM. Test: security/crypto-random-values.html * Android.mk: * CMakeLists.txt: * DerivedSources.cpp: * DerivedSources.make: * ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added. * GNUmakefile.am: * WebCore.gypi: * WebCore.pri: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMWindowCustom.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * config.h: * page/Crypto.cpp: Added. (WebCore::Crypto::Crypto): (WebCore::Crypto::getRandomValues): * page/Crypto.h: Added. (WebCore::Crypto::create): * page/Crypto.idl: Added. * page/DOMWindow.cpp: (WebCore::DOMWindow::clear): (WebCore::DOMWindow::crypto): * page/DOMWindow.h: (WebCore::DOMWindow::optionalCrypto): * page/DOMWindow.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78321 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Unreviewed build fix. [GTK] Build break with 2.18.3 https://bugs.webkit.org/show_bug.cgi?id=54057 * platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78320 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Adam Barth. Templatize KURLGooglePrivate::init https://bugs.webkit.org/show_bug.cgi?id=53749 No new tests. Refactoring. * platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::init): * platform/KURLGooglePrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78319 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mjs@apple.com authored
Reviewed by Dan Bernstein. Temporarily skip a test that fails in WebKit2 due to a recent regression https://bugs.webkit.org/show_bug.cgi?id=54276 * platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78318 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aestes@apple.com authored
Reviewed by Eric Seidel. Convert ContainerNode::firstElementChild() to a free function. https://bugs.webkit.org/show_bug.cgi?id=54269 No new tests. No change in behavior. It seemed incorrect to have a method on ContainerNode that had the concept of an Element but couldn't return an Element*, but a method on Element could not be called by holders of ContainerNodes or other non-Element ContainerNode subclasses. A free function can both return an Element* and be called by anyone with a ContainerNode*. * dom/ContainerNode.h: (WebCore::ContainerNode::lastChild): (WebCore::Node::lastChild): * dom/Document.cpp: (WebCore::Document::cacheDocumentElement): * dom/Element.cpp: (WebCore::Element::firstElementChild): * dom/Element.h: (WebCore::firstElementChild): * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 10 Feb, 2011 27 commits
-
-
ager@chromium.org authored
Reviewed by Nate Chapin. [V8] Don't crash on exception getting event handler function https://bugs.webkit.org/show_bug.cgi?id=54216 Check for exceptions when attempting to get the handleEvent property of an event-handler object. Test: fast/dom/exception-getting-event-handler.html * bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::getListenerFunction): 2011-02-10 Mads Ager <ager@chromium.org> Reviewed by Nate Chapin. [V8] Don't crash on exception getting event handler function https://bugs.webkit.org/show_bug.cgi?id=54216 Add crash regression test with custom chromium expectations. * fast/dom/exception-getting-event-handler-expected.txt: Added. * fast/dom/exception-getting-event-handler.html: Added. * platform/chromium/fast/dom/exception-getting-event-handler-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78316 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by James Robinson. [Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. https://bugs.webkit.org/show_bug.cgi?id=53857 This fix is for 2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. Add 2d.composite.globalAlpha.fillPath.html as a new test for the combination with globalAlpha and fillPath(). * fast/canvas/2d.composite.globalAlpha.fillPath-expected.txt: Added. * fast/canvas/2d.composite.globalAlpha.fillPath.html: Added. 2011-02-10 Naoki Takano <takano.naoki@gmail.com> Reviewed by James Robinson. [Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. https://bugs.webkit.org/show_bug.cgi?id=53857 globalAlpha is not applied to fillPath() and fillRect(). Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. * platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called. (WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor. (WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78315 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aestes@apple.com authored
Reviewed by Adam Barth. Remove an unneeded argument from HTMLDocument::create(). https://bugs.webkit.org/show_bug.cgi?id=54268 Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for fragment parsing, there isn't a need to explicitly specify a baseURL when constructing an HTMLDocument. We can remove the unneeded argument. Also fix some style issues in Document.h and HTMLDocument.h caught by check-webkit-style. No new tests. No change in behavior. * dom/Document.cpp: (WebCore::Document::Document): * dom/Document.h: * html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): * html/HTMLDocument.h: (WebCore::HTMLDocument::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78314 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrobinson@webkit.org authored
Clean up the skipped list and skip some tests that show differences between the bots. Rebaseline Acid2 tests results. * platform/gtk/Skipped: Clean up the skipped list. Skip failing test. * platform/gtk/http/tests/misc/acid2-expected.txt: * platform/gtk/http/tests/misc/acid2-pixel-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78313 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren@apple.com authored
Reviewed by Sam Weinig. A little more encapsulation for MarkedBlock: Made all constants private so clients don't know whether allocations are fixed-sized or not https://bugs.webkit.org/show_bug.cgi?id=54270 SunSpider reports no change. * runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::advance): Updated for removal of HeapConstants. * runtime/Error.cpp: Switched to using ASSERT_CLASS_FITS_IN_CELL, like all other classes. * runtime/Heap.cpp: (JSC::Heap::allocate): Updated for removal of HeapConstants. (JSC::Heap::reset): Updated to use size(), instead of calculating size on our own. * runtime/Heap.h: Moved the ASSERT here to MarkedBlock, since it enforces on special knowledge of fixed-sizery, which only MarkedBlock is supposed to know about. * runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Updated for removal of HeapConstants. Also changed to reset nextCell to 0 at the end of a block, since that seems more consistent. * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Changed to use a fixed array of char. This hard-coded size is a little wonky, but the compiler will tell us if it's ever wrong, so I think it's OK. * runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep): Updated for removal of HeapConstants. * runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::size): (JSC::MarkedBlock::capacity): Made constants private to this class. Removed HeapConstants. Added size() and capacity() functions. * runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::size): (JSC::MarkedSpace::capacity): * runtime/MarkedSpace.h: Use MarkedBlock helper functions instead of direct knowledge of MarkedBlock internals. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78312 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ojan@chromium.org authored
Reviewed by Adam Barth. remove extra space from expansion lines https://bugs.webkit.org/show_bug.cgi?id=54266 * code-review.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78311 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ojan@chromium.org authored
Reviewed by Adam Barth. only erase draft comments after publish is successful https://bugs.webkit.org/show_bug.cgi?id=54163 If there is a conflict or 500, then draft comments will survive. One drawback here is that the form post is now to the iframe, so to break out of the iframe we redirect to the bug page, which loses the information of who the email was sent to. Once WebKit supports seamless iframes we should be able to avoid the redirect. * code-review.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78310 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, fix a typo. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78309 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, test expectations update. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78308 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, test expectation update. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78307 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, test expectations update. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78306 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, test expectations update. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78305 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, build fix. * DumpRenderTree/DumpRenderTree.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78304 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren@apple.com authored
Reviewed by Sam Weinig. A little more encapsulation for MarkedBlock: Made mark bits private https://bugs.webkit.org/show_bug.cgi?id=54264 SunSpider reports no change. * runtime/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::reset): Renamed clearMarkBits => clearMarks, since clients don't need to know that marks are represented as bits. Renamed markedCells => markCount, since clients don't need to know that blocks are split into cells. * runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::markCount): New helper functions for encapsulating the information clients actually need. * runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::clearMarks): (JSC::MarkedSpace::markCount): (JSC::MarkedSpace::objectCount): * runtime/MarkedSpace.h: Use new helper functions instead of accessing MarkedBlock data directly. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78303 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
dpranke@chromium.org authored
Reviewed by Tony Chang. This patch adds the bulk of the remaining functionality for the NRWT message-passing implementation. The patch adds a new Worker class that will eventually replace the TestShellThread class in dump_render_tree_thread.py, and implements enough of TestRunner2 and the inline version of the manager_worker_broker to actually be able to send a full set of messages back and forth. The Worker stubs do not actually run tests, and there's lots of error handling and stats needed, but this is the core logic. https://bugs.webkit.org/show_bug.cgi?id=54068 * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: * Scripts/webkitpy/layout_tests/layout_package/worker.py: Added. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78302 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrowe@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Dan Bernstein. Repro crash with Sony Google TV ad at Gizmodo https://bugs.webkit.org/show_bug.cgi?id=54150 <rdar://problem/8782346> Re-landing this fix, bug without the test case, since it causes hangs on the bots. https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding back the test. Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it. * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier. (WebKit::PluginView::evaluate): Add a plug-in protector. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78299 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, build fix. * DumpRenderTree/DumpRenderTree.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78298 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
msaboff@apple.com authored
Reviewed by Geoffrey Garen. Cached JavaScript Parser Data Being Left in Memory Cache https://bugs.webkit.org/show_bug.cgi?id=54245 Added clear method which removes SourceProviderCache items. Cleaned up extraneous whitespace. * JavaScriptCore.exp: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * parser/SourceProviderCache.cpp: (JSC::SourceProviderCache::~SourceProviderCache): (JSC::SourceProviderCache::clear): (JSC::SourceProviderCache::byteSize): (JSC::SourceProviderCache::add): * parser/SourceProviderCache.h: 2011-02-10 Michael Saboff <msaboff@apple.com> Reviewed by Geoffrey Garen. Cached JavaScript Parser Data Being Left in Memory Cache https://bugs.webkit.org/show_bug.cgi?id=54245 Added logic in CachedScript to clear SourceProviderCache data in destroyDecodedData(). Added and changed CachedScript timeout to act similar to CachedImage. Changed didAddClient to call super class method instead of duplicating the logic in the derived classes. * loader/cache/CachedImage.cpp: (WebCore::CachedImage::didAddClient): * loader/cache/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData): * loader/cache/CachedScript.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78297 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, build fix. * DumpRenderTree/DumpRenderTree.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78296 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, attempt to fix crashing plugin tests. * DumpRenderTree/DumpRenderTree.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78295 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zmo@google.com authored
Unreviewed, build fix. * DumpRenderTree/DumpRenderTree.gypi: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78294 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
bdakin@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54228 Patch by Cosmin Truta <ctruta@chromium.org> on 2011-02-10 Reviewed by David Levin. Replace occurrences of NULL with 0, '\0' or null (as applicable), to appease check-webkit-style. No new tests. This is a style fix. * platform/KURLGoogle.cpp: * platform/KURLGooglePrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
Follow-up fix to r78291. I should pass (int) 0, not '0' to memset. * runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::commonConstructor): fix mistaken post-review change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78292 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
joepeck@webkit.org authored
Reviewed by Geoffrey Garen. Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass https://bugs.webkit.org/show_bug.cgi?id=54257 A subclass may want to specify the CFRunLoop that the Garbage Collection will happen on. It was difficult to manipulate this in a subclass because the current DefaultGCActivityCallback class does this in its constructor. This patch generalizes things a bit more so that a specific run loop can be passed in to the constructor. This makes it so all run loop management can stay in DefaultGCActivityCallback and a subclass can specify any runloop. * runtime/GCActivityCallback.h: expose a PLATFORM(CF) constructor that can specify the runloop GC can be scheduled on. * runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback): two constructors, one that specifies the run loop and passes that on to commonConstructor and the old constructor defaults to the current run loop. (JSC::DefaultGCActivityCallback::commonConstructor): do normal construction, adding the timer to the given runloop. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78291 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrobinson@webkit.org authored
Generate GTK+ results for many SVG tests missing them. * platform/gtk/Skipped: Unskip tests which now have results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78290 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by David Levin. Fix style in KURLGooglePrivate https://bugs.webkit.org/show_bug.cgi?id=54228 Replace occurrences of NULL with 0, '\0' or null (as applicable), to appease check-webkit-style. No new tests. This is a style fix. * platform/KURLGoogle.cpp: * platform/KURLGooglePrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
