1. 11 Dec, 2010 9 commits
  2. 10 Dec, 2010 31 commits
    • commit-queue@webkit.org's avatar
      2010-12-10 John Knottenbelt <jknotten@chromium.org> · 958bb629
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove WebCore/platform/mac/GeolocationService.{h,mm}
              https://bugs.webkit.org/show_bug.cgi?id=50074
      
              Remove unused non-client-based geolocation code.
      
              * platform/mac/GeolocationServiceMac.h: Removed.
              * platform/mac/GeolocationServiceMac.mm: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      958bb629
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · f93fce22
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              commit-queue flaky test messages show cryptic version information for mac os x
              https://bugs.webkit.org/show_bug.cgi?id=50864
      
              Turns out platform.platform() returns kernel version information
              which isn't helpful, and just plain confusing on Mac
              (OS X 10.6.5 uses Darwin Kernel 10.5.0).
      
              So I've updated PlatformInfo.display_name() to special case
              mac.  I also found a bad use of sys.platform in the process
              and fixed that.  (sys.platform always returns 'darwin' on mac).
      
              * Scripts/webkitpy/common/system/platforminfo.py:
              * Scripts/webkitpy/common/system/user.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f93fce22
    • sfalken@apple.com's avatar
      Windows production build fix. · b95c7a8a
      sfalken@apple.com authored
              
      Don't stop if react-to-vsprops-changes.py exits with an error,
      since this will occur in production builds.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b95c7a8a
    • ap@apple.com's avatar
      2010-12-10 Alexey Proskuryakov <ap@apple.com> · cec44cd5
      ap@apple.com authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=46573
              <rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work
      
              * http/tests/mime/quoted-charset-expected.txt: Added.
              * http/tests/mime/quoted-charset.php: Added.
      2010-12-10  Alexey Proskuryakov  <ap@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=46573
              <rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work
      
              Test: http/tests/mime/quoted-charset.php
      
              * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
              * platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
              Work around a CFNetwork issue, strip quotes if they are present.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cec44cd5
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · 0dd75ec3
      eric@webkit.org authored
              Unreviewed.
      
              Exception seen while reporting flaky test with commit-queue.
              Just a missing include.
      
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dd75ec3
    • commit-queue@webkit.org's avatar
      2010-12-10 Siddharth Mathur <siddharth.mathur@nokia.com> · cd568f5b
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt][WK2] Make WebKit2 static library compile on Symbian
              https://bugs.webkit.org/show_bug.cgi?id=50861
      
              * WebKit2.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd568f5b
    • kinuko@chromium.org's avatar
      2010-12-10 Kinuko Yasuda <kinuko@chromium.org> · 2e71eb4c
      kinuko@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
              https://bugs.webkit.org/show_bug.cgi?id=50796
      
              Also updating the test code to use JSONResultsGeneratorBase and
              to improve test coverage for incremental cases.
      
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e71eb4c
    • commit-queue@webkit.org's avatar
      2010-12-10 Vincent Scheib <scheib@chromium.org> · 3d311431
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Shader::loadShader() must initialize variable passed to getShaderiv
              https://bugs.webkit.org/show_bug.cgi?id=50842
      
              Test: fast/canvas/canvas-largedraws.html
      
              * platform/graphics/gpu/Shader.cpp:
              (WebCore::Shader::loadShader):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d311431
    • commit-queue@webkit.org's avatar
      2010-12-10 Vincent Scheib <scheib@chromium.org> · aaf1fb25
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Texture::updateSubRect should pass IntRect by reference
              https://bugs.webkit.org/show_bug.cgi?id=50845
      
              No test, changing to pass by ref.
      
              * platform/graphics/gpu/Texture.cpp:
              (WebCore::Texture::updateSubRect):
              * platform/graphics/gpu/Texture.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaf1fb25
    • mihaip@chromium.org's avatar
      2010-12-10 Mihai Parparita <mihaip@chromium.org> · 008e521a
      mihaip@chromium.org authored
              Unreviewed Chromium test expectation update.
      
              Attach more specific bug IDs to Philip canvas test suite failures.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      008e521a
    • darin@apple.com's avatar
      2010-12-10 Darin Adler <darin@apple.com> · 341ee641
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Move open and showModalDialog implementations from bindings into DOM class DOMWindow
              https://bugs.webkit.org/show_bug.cgi?id=50836
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::open): Removed most of the code and changed to call
              DOMWindow::open.
              (WebCore::DialogHandler::DialogHandler): Added. Object is used to handle the
              arguments and return value in showModalDialog.
              (WebCore::DialogHandler::dialogCreated): Ditto.
              (WebCore::DialogHandler::returnValue): Ditto.
              (WebCore::setUpDialog): Added. Function passed to showModalDialog that just
              casts pointer to DialogHandler can calls dialogCreated.
              (WebCore::JSDOMWindow::showModalDialog): Removed most of the code and changed
              to call DOMWindow::showModalDialog.
              (WebCore::JSDOMWindow::postMessage): Made style match the rest of the file by
              renaming local variables and getting rid of a needless ones.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::parseModalDialogFeatures): Moved body of this function
              to the WindowFeatures class.
              (WebCore::DOMWindow::allowPopUp): Renamed argument from activeFrame to firstFrame,
              because that's the frame we pass in here. Also added an overload so this can be
              called on a window rather than a frame.
              (WebCore::DOMWindow::setLocation): Renamed a couple variables so the names are
              the same as in open and showModalDialog. Factored the JavaScript security check
              into a new function named isInsecureScriptAccess.
              (WebCore::DOMWindow::isInsecureScriptAccess): Here is the new function.
              (WebCore::DOMWindow::createWindow): Added. Contains logic shared by open and
              showModalDialog just as the function named createWindow in JSDOMWindowCustom.cpp
              used to.
              (WebCore::DOMWindow::open): Added. Code from JSDOMWindowCustom without the
              JavaScript language binding part, and with a bit of refactoring to share code
              with the rest of the DOMWindow class.
              (WebCore::DOMWindow::showModalDialog): Ditto.
      
              * page/DOMWindow.h: Moved conditional parts of the file into separate paragraphs
              in alphabetical order so they are not scattered thorugh the file. Removed redundant
              includes. Added some blank lines for clarity. Added an open function and a
              showModalDialog function. Added private createWindow and isInsecureScriptAccess
              functions.
      
              * page/WindowFeatures.cpp:
              (WebCore::isWindowFeaturesSeparator): Renamed from isSeparator for clarity.
              (WebCore::WindowFeatures::WindowFeatures): Updated for name change. Used isEmpty
              instead of checking length. Added a new constructor for use when making dialogs,
              with code from the showModalDialog function.
              (WebCore::WindowFeatures::boolFeature): Use DialogFeaturesMap typedef.
              (WebCore::WindowFeatures::floatFeature): Use DialogFeaturesMap typedef.
              Renamed a local variable and tweaked the comments a bit.
              (WebCore::WindowFeatures::parseDialogFeatures): Added. Code moved here from
              DOMWindow::parseDialogFeatures and refactored a bit.
      
              * page/WindowFeatures.h: Added new constructor, new parseDialogFeatures
              function, DialogFeaturesMap typedef, and made setWindowFeature function private.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      341ee641
    • weinig@apple.com's avatar
      Ensure that we are not getting too many wheel events · d252730d
      weinig@apple.com authored
      <rdar://problem/7881465>
      
      Reviewed by Anders Carlsson.
      
      Add simple coalescing of wheel events being sent to the WebProcess. This 
      adds two models, one which drops interim events and one which merges events
      together. For now, we are using the simpler dropping model.
      
      * Shared/WebEvent.h:
      (WebKit::WebEvent::modifiers):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::coalesceWheelEvents):
      (WebKit::WebPageProxy::handleWheelEvent):
      (WebKit::WebPageProxy::didReceiveEvent):
      * UIProcess/WebPageProxy.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d252730d
    • joepeck@webkit.org's avatar
      2010-12-10 Joseph Pecoraro <joepeck@webkit.org> · 3dfb6322
      joepeck@webkit.org authored
              Reviewed by Darin Adler.
      
              prepare-ChangeLog --help doesn't mention --bug shorthand -b
              https://bugs.webkit.org/show_bug.cgi?id=50835
      
              * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dfb6322
    • joepeck@webkit.org's avatar
      2010-12-10 Joseph Pecoraro <joepeck@webkit.org> · c7bc540a
      joepeck@webkit.org authored
              Reviewed by Darin Adler.
      
              prepare-ChangeLog --help doesn't mention --bug shorthand -b
              https://bugs.webkit.org/show_bug.cgi?id=50835
      
              * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7bc540a
    • cfleizach@apple.com's avatar
      AX: refactor AccessibilityRenderObject::doAccessibilityHitTest · 8665fa25
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50574
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Refactors accessibility hit testing to allow for a more flexible model when handling elements
      with fake sub-elements (like sliders or list boxes).
      
      Renamed doAccessibilityHitTest -> accessibilityHitTest, which is called on the root
      accessibility render object. Then subclassers are able to override 
      elementAccessibilityHitTest to return their own specific elements.
      
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::elementAccessibilityHitTest):
      * accessibility/AccessibilityListBox.h:
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::accessibilityHitTest):
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::elementAccessibilityHitTest):
      * accessibility/AccessibilitySlider.h:
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (webkit_accessible_component_ref_accessible_at_point):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      
      WebKit/chromium: 
      
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::hitTest):
      
      WebKit/win: 
      
      * AccessibleBase.cpp:
      (AccessibleBase::accHitTest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8665fa25
    • commit-queue@webkit.org's avatar
      2010-12-10 W. James MacLean <wjmaclean@chromium.org> · 9a312562
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
              https://bugs.webkit.org/show_bug.cgi?id=50233
      
              First part of two-part patch to remove unnecessary pixel tests, and (in part two)
              have a single set of text expectations for all platforms. The standardized text
              expectations are added in this patch.
      
              * platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.png: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.png: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.png: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.png: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
              * platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.png: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
              * platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
              * platform/mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
              * svg/custom/svg-parse-overflow-1-expected.txt: Added.
              * svg/custom/svg-parse-overflow-1.html:
              * svg/custom/svg-parse-overflow-2-expected.txt: Added.
              * svg/custom/svg-parse-overflow-2.html:
              * svg/custom/svg-parse-overflow-3-expected.txt: Added.
              * svg/custom/svg-parse-overflow-3.html:
              * svg/custom/svg-parse-overflow-4-expected.txt: Added.
              * svg/custom/svg-parse-overflow-4.html:
              * svg/custom/svg-parse-overflow-5-expected.txt: Added.
              * svg/custom/svg-parse-overflow-5.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a312562
    • eric@webkit.org's avatar
      2010-12-10 Eric Seidel <eric@webkit.org> · 0f763c81
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
              https://bugs.webkit.org/show_bug.cgi?id=50853
      
              I also discovered when doing this that the code was posting
              the comment on the wrong bug, but that's fixed here too.
      
              * Scripts/webkitpy/common/net/bugzilla/bug.py:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f763c81
    • pkasting@chromium.org's avatar
      Unreviewed Chromium test expectations update. · a8dcdcb5
      pkasting@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8dcdcb5
    • kbr@google.com's avatar
      2010-12-10 Kenneth Russell <kbr@google.com> · e4d7cc42
      kbr@google.com authored
              Reviewed by Darin Adler.
      
              Clean up assertion in Extensions3DOpenGL.cpp
              https://bugs.webkit.org/show_bug.cgi?id=50852
      
              Built Release mode to test. No functionality change.
      
              * platform/graphics/opengl/Extensions3DOpenGL.cpp:
              (WebCore::Extensions3DOpenGL::ensureEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4d7cc42
    • commit-queue@webkit.org's avatar
      2010-12-10 Cosmin Truta <ctruta@chromium.org> · ea6bdc73
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Crash while processing ill-formed <textPath> ouside of <text>
              https://bugs.webkit.org/show_bug.cgi?id=47759
      
              Ensure that ill-formed text content child elements do not crash.
      
              * svg/custom/invalid-text-content.svg: Added.
              * svg/custom/invalid-text-content-expected.checksum: Added.
              * svg/custom/invalid-text-content-expected.png: Added.
              * svg/custom/invalid-text-content-expected.txt: Added.
      2010-12-10  Cosmin Truta  <ctruta@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Crash while processing ill-formed <textPath> ouside of <text>
              https://bugs.webkit.org/show_bug.cgi?id=47759
      
              Renderers within a <text> subtree are created only when their corresponding elements
              satisfy the content model.
      
              Test: svg/custom/invalid-text-content.svg
      
              * svg/SVGTRefElement.cpp:
              (WebCore::SVGTRefElement::childShouldCreateRenderer): Fixed to comply with the content model.
              (WebCore::SVGTRefElement::rendererIsNeeded): Added.
              * svg/SVGTRefElement.h:
              * svg/SVGTSpanElement.cpp:
              (WebCore::SVGTSpanElement::childShouldCreateRenderer): Fixed to comply with the content model.
              (WebCore::SVGTSpanElement::rendererIsNeeded): Added.
              * svg/SVGTSpanElement.h: Changed indentation.
              * svg/SVGTextElement.cpp:
              (WebCore::SVGTextElement::childShouldCreateRenderer): Reformatted.
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::childShouldCreateRenderer): Fixed to comply with the content model.
              (WebCore::SVGTextPathElement::rendererIsNeeded): Added.
              * svg/SVGTextPathElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea6bdc73
    • zmo@google.com's avatar
      2010-12-10 Zhenyao Mo <zmo@google.com> · da0531cf
      zmo@google.com authored
              Reviewed by Adam Barth.
      
              Use enums instead of booleans in ImageSource/ImageDecoder constructors
              https://bugs.webkit.org/show_bug.cgi?id=50818
      
              * src/WebImageDecoder.cpp:
              (WebKit::WebImageDecoder::init): Use enums instead of boolean in ImageDecoder constructor.
      2010-12-10  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Adam Barth.
      
              Use enums instead of booleans in ImageSource/ImageDecoder constructors
              https://bugs.webkit.org/show_bug.cgi?id=50818
      
              This patch basically defines two enum type in ImageSource: AlphaOption
              and GammaAndColorProfileOption and use them as ImageSource and ImageDecoder
              constructor parameters instead of boolean typs.
      
              * platform/graphics/ImageSource.cpp:
              (WebCore::ImageSource::ImageSource):
              (WebCore::ImageSource::setData):
              * platform/graphics/ImageSource.h: Define the two enum types.
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::GraphicsContext3D::getImageData):
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::ImageSource):
              * platform/graphics/qt/ImageDecoderQt.cpp:
              (WebCore::ImageDecoder::create):
              (WebCore::ImageDecoderQt::ImageDecoderQt):
              * platform/graphics/qt/ImageDecoderQt.h:
              * platform/graphics/skia/GraphicsContext3DSkia.cpp:
              (WebCore::GraphicsContext3D::getImageData):
              * platform/image-decoders/ImageDecoder.cpp:
              (WebCore::ImageDecoder::create):
              * platform/image-decoders/ImageDecoder.h:
              (WebCore::ImageDecoder::ImageDecoder):
              * platform/image-decoders/bmp/BMPImageDecoder.cpp:
              (WebCore::BMPImageDecoder::BMPImageDecoder):
              * platform/image-decoders/bmp/BMPImageDecoder.h:
              * platform/image-decoders/gif/GIFImageDecoder.cpp:
              (WebCore::GIFImageDecoder::GIFImageDecoder):
              * platform/image-decoders/gif/GIFImageDecoder.h:
              * platform/image-decoders/ico/ICOImageDecoder.cpp:
              (WebCore::ICOImageDecoder::ICOImageDecoder):
              (WebCore::ICOImageDecoder::decodeAtIndex):
              * platform/image-decoders/ico/ICOImageDecoder.h:
              * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
              (WebCore::JPEGImageDecoder::JPEGImageDecoder):
              * platform/image-decoders/jpeg/JPEGImageDecoder.h:
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::PNGImageDecoder):
              * platform/image-decoders/png/PNGImageDecoder.h:
              * platform/image-decoders/webp/WEBPImageDecoder.cpp:
              (WebCore::WEBPImageDecoder::WEBPImageDecoder):
              * platform/image-decoders/webp/WEBPImageDecoder.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da0531cf
    • rniwa@webkit.org's avatar
      2010-12-10 Ryosuke Niwa <rniwa@webkit.org> · 4dc664ac
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION(r73799): editing/execCommand/4920488.html fails
              https://bugs.webkit.org/show_bug.cgi?id=50854
      
              The regression was caused by Range::processContents's not extracting
              m_end.container()->firstChild(). Fixed the bug by always adding the first child.
      
              * dom/Range.cpp:
              (WebCore::Range::processContents):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dc664ac
    • abarth@webkit.org's avatar
      2010-12-10 Adam Barth <abarth@webkit.org> · 905a9492
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION: Infinite redirect on developer.apple.com
              https://bugs.webkit.org/show_bug.cgi?id=45627
      
              Tests: fast/loader/form-submit-aborts-parsing.html
                     fast/loader/location-change-aborts-parsing.html
      
              This patch is not pretty, but it fixes the bug.  I stole this approach
              from the old HTML parser (as suggested by Eric Seidel).  The other
              approaches that folks tried for this bug are better, but it's inclear
              how to get them to work correctly.  I've added a large FIXME comment.
      
              * html/parser/HTMLDocumentParser.cpp:
              (WebCore::HTMLDocumentParser::pumpTokenizer):
              * html/parser/HTMLTreeBuilder.h:
              (WebCore::HTMLTreeBuilder::isParsingFragment):
      2010-12-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION: Infinite redirect on developer.apple.com
              https://bugs.webkit.org/show_bug.cgi?id=45627
      
              Tests originally by Tony Gentilcore.
      
              * fast/loader/form-submit-aborts-parsing-expected.txt: Added.
              * fast/loader/form-submit-aborts-parsing.html: Added.
              * fast/loader/location-change-aborts-parsing-expected.txt: Added.
              * fast/loader/location-change-aborts-parsing.html: Added.
              * fast/loader/resources/location-change-aborts-parsing-fail.html: Added.
              * fast/loader/resources/location-change-aborts-parsing-pass.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      905a9492
    • andersca@apple.com's avatar
      Make WKContextGetStatistics gather global statistics · fcb497f2
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=50850
      
      Reviewed by John Sullivan.
      
      WebKit2:
      
      Change WKContextGetStatistics to work on all objects in the process, and
      make it more robust by incrementing/decrementing the counts in the constructor
      and destructor respectively.
      
      Also, rename WKContextGetStatistics to WKContextGetGlobalStatistics to better match
      what it's actually doing.
      
      * UIProcess/API/C/WKContext.cpp:
      (WKContextGetStatistics):
      * UIProcess/API/C/WKContextPrivate.h:
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
      (-[WKView dealloc]):
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::statistics):
      * UIProcess/WebContext.h:
      * UIProcess/WebFrameProxy.cpp:
      (WebKit::WebFrameProxy::WebFrameProxy):
      (WebKit::WebFrameProxy::~WebFrameProxy):
      * UIProcess/WebPageNamespace.cpp:
      * UIProcess/WebPageNamespace.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::~WebPageProxy):
      * UIProcess/WebPageProxy.h:
      
      WebKitTools:
      
      Remove the code that gets the statistics and fills in the per context
      statistics information for now.
      
      * MiniBrowser/mac/BrowserStatisticsWindowController.m:
      (-[BrowserStatisticsWindowController refreshStatistics:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcb497f2
    • bweinstein@apple.com's avatar
      WebKit2: Context menu support on Windows · 01fc7a4d
      bweinstein@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=50514>
              
      Reviewed by Darin Adler.
      
      Implment showing of the context menu on Windows for WebKit2, and calling through to
      WebPageProxy::contextMenuItemSelected.
      
      * UIProcess/win/WebContextMenuProxyWin.cpp:
      (WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin): Initialize the member variables.
      (WebKit::WebContextMenuProxyWin::populateMenu): Iterate over the vector of WebContextMenuItemData
          that was passed in, adding the menu items and recursively calling back into this function to populate
          any submenus that are needed. This function also sets up the map from action identifierss to WebContextMenuItemData,
          to use to find the WebContextMenuItemData from a selected menu item.
      (WebKit::WebContextMenuProxyWin::showContextMenu): Destroy any menu we have already created, populate the menu
          to show, and show the context menu. Once TrackPopupMenuEx returns, it returns identifier of the selected menu item.
          Look up that identifier in the map we created, and tell the WebPageProxy that a context menu item was selected.
      (WebKit::WebContextMenuProxyWin::hideContextMenu): Destroy the HMENU if it is non-null, and clear the identifier map. 
      * UIProcess/win/WebContextMenuProxyWin.h:
      (WebKit::WebContextMenuProxyWin::create): Call through to the constructor, and change the arguments that it takes.
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::createContextMenuProxy): Call with the correct arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01fc7a4d
    • jberlin@webkit.org's avatar
      Qt Build Fix. Unreviewed. · b8bf6a92
      jberlin@webkit.org authored
      * WebKit2.pro:
      Add the Messages.h and MessageReceivers.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8bf6a92
    • bweinstein@apple.com's avatar
      When we are creating a ContextMenuItem, only call setSubMenu if we have · 00e2dc90
      bweinstein@apple.com authored
      a subMenu to set.
      
      Reviewed by Ada Chan.
      
      * platform/ContextMenuItem.cpp:
      (WebCore::ContextMenuItem::ContextMenuItem):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00e2dc90
    • kbr@google.com's avatar
      2010-12-10 Kenneth Russell <kbr@google.com> · c6d77daa
      kbr@google.com authored
              Reviewed by James Robinson.
      
              Regression: fast/canvas/webgl/constants.html failing
              https://bugs.webkit.org/show_bug.cgi?id=50851
      
              * fast/canvas/webgl/constants.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6d77daa
    • mihaip@chromium.org's avatar
      2010-12-10 Mihai Parparita <mihaip@chromium.org> · 7b75300b
      mihaip@chromium.org authored
              Unreviewed Chromium test expectation update.
      
              Attach more specific bug IDs to Philip canvas test suite failures (for
              existing bugs only).
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b75300b
    • kbr@google.com's avatar
      2010-12-10 Kenneth Russell <kbr@google.com> · c35f4d25
      kbr@google.com authored
              Unreviewed, another build fix. #include <wtf/UnusedParam.h> needed
              for Release builds.
      
              * platform/graphics/opengl/Extensions3DOpenGL.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c35f4d25
    • kbr@google.com's avatar
      2010-12-10 Kenneth Russell <kbr@google.com> · 84870ae2
      kbr@google.com authored
              Unreviewed, build fix. Change #ifndef NDEBUG to #ifdef NDEBUG.
      
              * platform/graphics/opengl/Extensions3DOpenGL.cpp:
              (WebCore::Extensions3DOpenGL::ensureEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84870ae2