1. 17 Oct, 2006 11 commits
    • justing's avatar
      LayoutTests: · 24714dfa
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4774354>
              REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
      
              * fast/repaint/4774354-expected.checksum: Added.
              * fast/repaint/4774354-expected.png: Added.
              * fast/repaint/4774354-expected.txt: Added.
              * fast/repaint/4774354.html: Added.
              * fast/repaint/resources/contenteditable-iframe-src.html: Added.
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4774354>
              REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
      
              Functions call recomputCaretRect to see if the caret rect has changed, 
              and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
              returning false if the caret turned into a range selection or was blown 
              away.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::recomputeCaretRect): Don't early return if
              !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
              may now be null.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24714dfa
    • ggaren's avatar
      Reviewed by Brady. · 84dc6664
      ggaren authored
              BrowserExtension cleanup.
              
              - Removed unnecessary #include of BrowserExtension in Frame.h, added
              #includes to compensate in other files.
              
              - Removed unused versions of createNewWindow.
              
              * bindings/js/kjs_window.cpp:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              (WebCore::BrowserExtensionMac::createNewWindow):
              * bridge/mac/WebCoreFrameBridge.mm:
              * html/HTMLFormElement.cpp:
              * loader/mac/LoaderFunctionsMac.mm:
              * page/Frame.h:
              * page/FramePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84dc6664
    • kmccullo's avatar
      Reviewed by Brady. · ac542a50
      kmccullo authored
              Fixes a JavaScriptCore math issue on win.
      
              * kjs/math_object.cpp:
              (MathFuncImp::callAsFunction):
              * wtf/MathExtras.h:
              (wtf_atan2):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac542a50
    • ggaren's avatar
      Reviewed by Adam. · 2e40fc13
      ggaren authored
              
              - Fixed "FIXME: Violates Liskov Substitution principle."
              
              IFRAME was never a true subclass of FRAME, since they disagreed on a
              number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
      
              The fix here is to factor out things common to IFRAME and FRAME into a
              common base class, HTMLFrameElementBase.
              
              I also changed some " *" to "* " and added #includes in files that implicitly
              assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e40fc13
    • justing's avatar
      LayoutTests: · ef699414
      justing authored
              Reviewed by sullivan
              
              <rdar://problem/4776765>
              REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
      
              * fast/repaint/4776765-expected.checksum: Added.
              * fast/repaint/4776765-expected.png: Added.
              * fast/repaint/4776765-expected.txt: Added.
              * fast/repaint/4776765.html: Added.
      
      WebCore:
      
              Reviewed by sullivan
              
              <rdar://problem/4776765>
              REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
      
              We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
              the old caret rect.  It in fact corrects the caret rect for an offset that it 
              believes is due to scrolling but which is actually due to a change in selection
              without an accompanying layout.  So it returns the new caret rect regardless of
              what m_needsLayout is set to.
              
              * editing/SelectionController.cpp:
              (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
              adds a one pixel slop to this new function.
              (WebCore::SelectionController::caretRepaintRect): Moved this code to
              repaintRectForCaret.
              (WebCore::SelectionController::recomputeCaretRect): Compare the old
              caret rect to the new one that's computed with a fresh layout.  If
              they are different, invalidate both repaint rects.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef699414
    • aliceli1's avatar
      Reviewed by Tim Hatcher. · 9c23ab1c
      aliceli1 authored
              When nodes are removed, selections are cleared, and when http://bugs.webkit.org/show_bug.cgi?id=6498 was fixed, we started sending didChangeSelection notifications.  Updating the test results fixes some of the tests mentioned in http://bugs.webkit.org/show_bug.cgi?id=10924
      
              * fast/dynamic/move-node-with-selection-expected.txt:
              * fast/events/dblclick-addEventListener-expected.txt:
              * fast/events/updateLayoutForHitTest-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c23ab1c
    • harrison's avatar
      Reviewed by Adele. · 68b7972d
      harrison authored
              <rdar://problem/4770453> VO not honoring secure edit fields in web pages
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject isPasswordField]):
              New. Checks for input with inputType() of PASSWORD.
              
              (-[WebCoreAXObject subrole]):
              Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
              
              (-[WebCoreAXObject roleDescription]):
              Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
              
              (-[WebCoreAXObject value]):
              Return nil if [self isPasswordField].
              
              (-[WebCoreAXObject accessibilityAttributeNames]):
              Return generic attributes if [self isPasswordField].
      
              (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
              Return empty array if [self isPasswordField].
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68b7972d
    • aliceli1's avatar
      Reviewed by aroben. · e1db0ba3
      aliceli1 authored
              updating test results after r17068 - http://bugs.webkit.org/show_bug.cgi?id=11320
      
              * fast/block/float/013-expected.checksum:
              * fast/block/float/013-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1db0ba3
    • aroben's avatar
      Reviewed by Adele. · c0f0805a
      aroben authored
              Fixes http://bugs.webkit.org/show_bug.cgi?id=11214
              http/tests/xmlhttprequest/exceptions.html needs new results
      
              Updating results after r16794.
      
              * http/tests/xmlhttprequest/exceptions-expected.txt:
              * http/tests/xmlhttprequest/exceptions.html: Add comments about why we
              don't follow the XHR spec.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0f0805a
    • hyatt's avatar
      Fix "flash to white' problem on yahoo.com as it finishes loading. ... · 72907f4a
      hyatt authored
              Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
              code so that it will only run if the body still has no renderer.
      
              * dom/Document.cpp:
              (WebCore::Document::updateLayoutIgnorePendingStylesheets):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72907f4a
    • hyatt's avatar
      Fix a bug where the WebCore memory cache could grow without bound during extended browsing · 8b08c2f5
      hyatt authored
              sessions.
      
              Reviewed by mjs
      
              * loader/Cache.cpp:
              (WebCore::Cache::flush):
              (WebCore::Cache::setSize):
              (WebCore::Cache::getLRUListFor):
              (WebCore::Cache::removeFromLRUList):
              (WebCore::Cache::insertInLRUList):
              * loader/Cache.h:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::setRequest):
              (WebCore::CachedResource::deref):
              * loader/CachedResource.h:
              (WebCore::CachedResource::allowInLRUList):
              * loader/CachedScript.cpp:
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              * loader/CachedXSLStyleSheet.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b08c2f5
  2. 16 Oct, 2006 7 commits
    • justing's avatar
      LayoutTests: · 66f5d700
      justing authored
              Reviewed by harrison
              
              <rdar://problem/3655385>
              Editing: -indent: method unimplemented
      
              * editing/execCommand/nsresponder-indent-expected.checksum: Added.
              * editing/execCommand/nsresponder-indent-expected.png: Added.
              * editing/execCommand/nsresponder-indent-expected.txt: Added.
              * editing/execCommand/nsresponder-indent.html: Added.
              * editing/execCommand/nsresponder-outdent-expected.checksum: Added.
              * editing/execCommand/nsresponder-outdent-expected.png: Added.
              * editing/execCommand/nsresponder-outdent-expected.txt: Added.
              * editing/execCommand/nsresponder-outdent.html: Added.
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/3655385>
              Editing: -indent: method unimplemented
      
              Added Frame and bridge methods.
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge indent]):
              (-[WebCoreFrameBridge outdent]):
              * page/Frame.cpp:
              (WebCore::Frame::indent): 
              (WebCore::Frame::outdent):
              * page/Frame.h:
      
      WebKit:
      
              Reviewed by harrison
              
              <rdar://problem/3655385>
              Editing: -indent: method unimplemented
      
              * WebView/WebHTMLView.m:
              (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in
              richly editable areas.
              (-[NSArray indent:]):
              (-[NSArray outdent:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66f5d700
    • kmccullo's avatar
      Reviewed by Geof. · 14d87aa5
      kmccullo authored
              Removed unecessary global specifiers.
      
              * kjs/math_object.cpp:
              (MathFuncImp::callAsFunction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14d87aa5
    • kmccullo's avatar
      Reviewed by John. · 0868a4e9
      kmccullo authored
              Fixes a compile order issue for testkjs on win.
      
              * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0868a4e9
    • aroben's avatar
      Reviewed by John. · 56576653
      aroben authored
              More menulist cleanup/tweaking.
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
              parameter to 'optionIndex' for clarity.
              (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
              items that are not enabled <option> elements when using arrow keys, and
              make sure we pass an option index to setSelectedIndex.
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::setWasClicked): Specify default argument.
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
              option text before setting the control text so that options within
              <optgroup>s don't appear indented in the actual control.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56576653
    • weinig's avatar
      Reviewed by Adam. · ef7ad103
      weinig authored
              Win32 build fix.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * bridge/win/BrowserExtensionWin.cpp:
              (WebCore::BrowserExtensionWin::createNewWindow):
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::urlSelected):
              (WebCore::FrameWin::submitForm):
              (WebCore::FrameWin::createNewWindow):
              * bridge/win/FrameWin.h:
              * loader/loader.cpp:
              (WebCore::Loader::receivedResponse):
              * platform/win/GraphicsContextWin.cpp:
              (WebCore::GraphicsContext::getWindowsContext):
              (WebCore::GraphicsContext::releaseWindowsContext):
              * platform/win/TemporaryLinkStubs.cpp:
              (FrameWin::openURLRequest):
              (WebCore::ServeSynchronousRequest):
              (WebCore::CheckIfReloading):
              (WebCore::IsResponseURLEqualToURL):
              (WebCore::ResponseMIMEType):
              (WebCore::ResponseIsMultipart):
              (WebCore::CacheObjectExpiresTime):
              (CachedResource::setResponse):
              (CachedResource::setAllData):
              * rendering/RenderThemeWin.cpp:
              (WebCore::doneDrawing):
              (WebCore::RenderThemeWin::paintButton):
              (WebCore::RenderThemeWin::paintTextField):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef7ad103
    • hyatt's avatar
      Fix for bug 9347, positioned elements have the wrong containing block.... · 444d7747
      hyatt authored
              Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
              CSS2.1.  In the absence of any other enclosing positioned elements, the containing block for a positioned
              element is the initial containing block (our RenderView).
      
              Reviewed by mjs
      
              Test cases added to fast/block/positioning for quirks and strict modes.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::lowestPosition):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::leftmostPosition):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteVertical):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::containingBlock):
              (WebCore::RenderObject::container):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      444d7747
    • hyatt's avatar
      Add test cases for bug 9347. · c992de41
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c992de41
  3. 15 Oct, 2006 4 commits
    • bdash's avatar
      2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com> · 1dc19f48
      bdash authored
              Reviewed by Anders.
      
              Remove junk (as gcc calls it) after #else clause.
      
              * wtf/FastMalloc.cpp:
              (WTF::do_free):
      
      2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
      
              Reviewed by Anders.
      
              Misc Gdk/Linux build fixes.
      
              * platform/gdk/BrowserExtensionGdk.h:
              * platform/gdk/FrameGdk.cpp:
              (WebCore::FrameGdk::submitForm):
              (WebCore::FrameGdk::urlSelected):
              * platform/gdk/FrameGdk.h:
              * platform/gdk/RenderPopupMenuGdk.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::addSeparator):
              (WebCore::PopupMenu::addGroupLabel):
              (WebCore::PopupMenu::addOption):
              * platform/gdk/RenderPopupMenuGdk.h:
              * platform/gdk/RenderThemeGdk.cpp:
              * platform/gdk/RenderThemeGdk.h:
              (WebCore::RenderThemeGdk::RenderThemeGdk):
              * platform/gdk/TemporaryLinkStubs.cpp:
              (BrowserExtensionGdk::createNewWindow):
              (BrowserExtensionGdk::BrowserExtensionGdk):
              (BrowserExtensionGdk::setTypedIconURL):
              (BrowserExtensionGdk::setIconURL):
              (BrowserExtensionGdk::getHistoryLength):
              (WebCore::CheckIfReloading):
              (WebCore::CacheObjectExpiresTime):
              (WebCore::ResponseURL):
              (WebCore::IsResponseURLEqualToURL):
              (WebCore::ResponseIsMultipart):
              (WebCore::ResponseMIMEType):
              (WebCore::CachedResource::setResponse):
              (WebCore::CachedResource::setAllData):
              (FileChooser::disconnectUploadControl):
              * rendering/RenderTheme.h:
              * rendering/RenderThemeMac.h:
      
      2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
      
              Reviewed by Anders.
      
              Make compiler not complain about unused gk. SpinneretWebHost was not setting
              initial refcount upon creation, so it is completely bogus.
      
              * GdkLauncher/main.cpp:
              (main):
              * Spinneret/Spinneret/Spinneret.h:
              (SpinneretWebHost::SpinneretWebHost):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dc19f48
    • weinig's avatar
      Reviewed by Mitz. · 1ed1c69e
      weinig authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
              Add getModifierState method to KeyboardEvent
      
              * bindings/objc/DOMEvents.h:
              * bindings/objc/DOMEvents.mm:
              * bindings/objc/PublicDOMInterfaces.h:
              * dom/KeyboardEvent.cpp:
              (WebCore::KeyboardEvent::getModifierState):
              * dom/KeyboardEvent.h:
              * dom/KeyboardEvent.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ed1c69e
    • ap's avatar
      2006-10-15 Nikolas Zimmermann <zimmermann@kde.org> · 2f7abe65
      ap authored
              Reviewed and landed by ap.
      
              Changed PlatformResponse handling for Qt. Don't just store
              a QString object containing the data but a new PlatformResponseQt struct
              containing data and url, and store it as pointer. This is compatible
              to the OS X handling and removes the Qt plaform specific hacks from
              CachedCSSStyleSheet, CachedResource & loader.
      
              Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
              all methods from TemporaryLinkStubs related to loading in there, and implement
              some like ServeSynchronousRequest (yay for xslt handling!).
      
              * CMakeLists.txt:
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::checkNotify):
              * loader/CachedResource.h:
              (WebCore::CachedResource::CachedResource):
              * loader/loader.cpp:
              (WebCore::Loader::receivedResponse):
              * platform/ResourceLoaderClient.h:
              * platform/ResourceLoaderInternal.h:
              * platform/qt/FrameQt.cpp:
              (WebCore::FrameQt::~FrameQt):
              (WebCore::FrameQt::createEmptyDocument):
              * platform/qt/FrameQt.h:
              (WebCore::QtFrame):
              * platform/qt/FrameQtClient.cpp:
              (WebCore::FrameQtClientDefault::setFrame):
              (WebCore::FrameQtClientDefault::openURL):
              (WebCore::FrameQtClientDefault::loadFinished):
              (WebCore::FrameQtClientDefault::receivedAllData):
              * platform/qt/FrameQtClient.h:
              * platform/qt/LoaderFunctionsQt.cpp: Added.
              (WebCore::ServeSynchronousRequest):
              (WebCore::NumberOfPendingOrLoadingRequests):
              (WebCore::CheckIfReloading):
              (WebCore::CheckCacheObjectStatus):
              (WebCore::IsResponseURLEqualToURL):
              (WebCore::ResponseURL):
              (WebCore::ResponseMIMEType):
              (WebCore::ResponseIsMultipart):
              (WebCore::CacheObjectExpiresTime):
              (WebCore::CachedResource::setResponse):
              (WebCore::CachedResource::setAllData):
              * platform/qt/ResourceLoaderManager.cpp:
              (WebCore::ResourceLoaderManager::remove):
              * platform/qt/ResourceLoaderQt.cpp:
              (WebCore::ResourceLoader::~ResourceLoader):
              (WebCore::ResourceLoader::start):
              (WebCore::ResourceLoader::assembleResponseHeaders):
              (WebCore::ResourceLoader::receivedResponse):
              * platform/qt/TemporaryLinkStubs.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f7abe65
    • rwlbuis's avatar
      Reviewed by Mitz. · 65d3502a
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11217
              Cleanup svg coding style
      
              Cleanup coding style in svg basic datastructure classes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65d3502a
  4. 14 Oct, 2006 7 commits
    • oliver's avatar
      2006-10-15 Nikolas Zimmermann <zimmermann@kde.org> · 492e22a3
      oliver authored
              Reviewed by Oliver.
      
              Implement some functions in FrameQt / ScrollViewQt.
      
              Added comments what needs to be done in quite some places,
              marked some functions as no-ops.
      
              * CMakeLists.txt:
              * platform/qt/FrameQt.cpp:
              (WebCore::FrameQt::FrameQt):
              (WebCore::FrameQt::runJavaScriptConfirm):
              (WebCore::FrameQt::locationbarVisible):
              (WebCore::FrameQt::createFrame):
              (WebCore::FrameQt::passSubframeEventToSubframe):
              (WebCore::FrameQt::menubarVisible):
              (WebCore::FrameQt::personalbarVisible):
              (WebCore::FrameQt::statusbarVisible):
              (WebCore::FrameQt::toolbarVisible):
              (WebCore::FrameQt::markedTextRange):
              (WebCore::FrameQt::lastEventIsMouseUp):
              (WebCore::FrameQt::openURLRequest):
              (WebCore::FrameQt::scheduleClose):
              (WebCore::FrameQt::unfocusWindow):
              (WebCore::FrameQt::focusWindow):
              (WebCore::FrameQt::overrideMediaType):
              (WebCore::FrameQt::runJavaScriptPrompt):
              (WebCore::FrameQt::bindingRootObject):
              (WebCore::FrameQt::addPluginRootObject):
              (WebCore::FrameQt::registerCommandForUndo):
              (WebCore::FrameQt::registerCommandForRedo):
              (WebCore::FrameQt::clearUndoRedoOperations):
              (WebCore::FrameQt::respondToChangedSelection):
              (WebCore::FrameQt::respondToChangedContents):
              (WebCore::FrameQt::shouldChangeSelection):
              (WebCore::FrameQt::canGoBackOrForward):
              (WebCore::FrameQt::canPaste):
              (WebCore::FrameQt::canRedo):
              (WebCore::FrameQt::canUndo):
              * platform/qt/FrameQt.h:
              * platform/qt/FrameQtClient.cpp:
              (WebCore::FrameQtClientDefault::runJavaScriptAlert):
              (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
              (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
              (WebCore::FrameQtClientDefault::menubarVisible):
              (WebCore::FrameQtClientDefault::toolbarVisible):
              (WebCore::FrameQtClientDefault::statusbarVisible):
              (WebCore::FrameQtClientDefault::personalbarVisible):
              (WebCore::FrameQtClientDefault::locationbarVisible):
              * platform/qt/FrameQtClient.h:
              * platform/qt/ImageSourceQt.cpp:
              * platform/qt/RenderThemeQt.cpp:
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::scrollPointRecursively):
              * platform/qt/TemporaryLinkStubs.cpp:
              (WebCore::CachedResource::setResponse):
              (WebCore::CachedResource::setAllData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      492e22a3
    • oliver's avatar
      2006-10-15 Nikolas Zimmermann <zimmermann@kde.org> · e45a182b
      oliver authored
              Reviewed by Oliver.
      
              Add another hanging test, to the "to be skipped" list.
      
              * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e45a182b
    • harrison's avatar
      Reviewed by Geoff. · c1f1de75
      harrison authored
              <rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
              <rdar://problem/4783926> REGRESSION: Typing tab key enters no text
      
              The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
              of whether frame->view()->advanceFocus() actually changed the focus.
      
              Trivial fix is to preventDefault() only if advanceFocus() returns true.
      
              * No test is possible because DumpRenderTree sets the WebView preference to
              tab to links, and that preference cannot be changed dynamically after
              the webview is initialized. Also, the "tab from last link" is not testable
              because DumpRenderTree uses the WebView for the whole window, so tabs can't
              shift focus out of the WebView regardless.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::defaultEventHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f1de75
    • weinig's avatar
      Reviewed by Anders. · 6c92b3cc
      weinig authored
              Some fixes to get the Qt BuildSlave to run the LayoutTests.
      
              * Scripts/build-dumprendertree: No need to call cmake again.
              * Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c92b3cc
    • weinig's avatar
      Reviewed by Mitz. · 0fc3b60a
      weinig authored
              Fix Qt/Linux build & some little fixes:
      
              - Adapt to Maciej's FrameLoadRequest changes.
              - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
              - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
              - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
      
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::checkNotify):
              * loader/CachedResource.h:
              (WebCore::CachedResource::CachedResource):
              * loader/loader.cpp:
              (WebCore::Loader::receivedAllData):
              (WebCore::Loader::receivedResponse):
              * platform/qt/BrowserExtensionQt.cpp:
              (WebCore::BrowserExtensionQt::createNewWindow):
              * platform/qt/BrowserExtensionQt.h:
              * platform/qt/FrameQt.cpp:
              (WebCore::FrameQt::submitForm):
              (WebCore::FrameQt::urlSelected):
              (WebCore::FrameQt::openURLRequest):
              *...
      0fc3b60a
    • bdash's avatar
      2006-10-14 David Carson <dacarson@gmail.com> · 300e5b8e
      bdash authored
              Reviewed by Maciej.
      
              Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
              Removed Mac platform dependance, changed WebCore functions to
              use PlatformResponse/PlatformData rather than NSURLResponse/
              NSData. 
      
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::checkNotify):
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::createImage):
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::~CachedResource):
              * loader/CachedResource.h:
              (WebCore::CachedResource::CachedResource):
              (WebCore::CachedResource::response):
              (WebCore::CachedResource::allData):
              * loader/LoaderFunctions.h:
              * loader/loader.cpp:
              (WebCore::Loader::receivedResponse):
              * loader/mac/LoaderFunctionsMac.mm:
              (WebCore::ResponseMIMEType):
              (WebCore::ResponseIsMultipart):
              (WebCore::CacheObjectExpiresTime):
              (WebCore::CachedResource::setResponse):
              (WebCore::CachedResource::setAllData):
              * platform/qt/TemporaryLinkStubs.cpp:
              (WebCore::CacheObjectExpiresTime):
              (WebCore::ResponseIsMultipart):
              (WebCore::ResponseMIMEType):
              (WebCore::CachedResource::setResponse):
              (WebCore::CachedResource::setAllData):
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::CacheObjectExpiresTime):
              (WebCore::ResponseIsMultipart):
              (WebCore::ResponseMIMEType):
              (WebCore::CachedResource::setResponse):
              (WebCore::CachedResource::setAllData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      300e5b8e
    • bdash's avatar
      2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com> · e0bfe232
      bdash authored
              Reviewed by Maciej.
      
              Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
              networking, and set it for GDK build
      
              * wtf/Platform.h:
      
      2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
      
              Reviewed by Maciej.
      
              Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
              Pure virtual classes require non-pure destructor, who knew.
      
              Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
              so that other platforms can also use CURL, if they wish.
      
              Silence compiler warning about unused variable in SharedTimerLinux.cpp
      
              * platform/ResourceLoaderInternal.h:
              (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
              * platform/gdk/FrameGdk.h:
              (WebCore::FrameGdkClient::~FrameGdkClient):
              * platform/gdk/ResourceLoaderManager.cpp:
              (WebCore::ResourceLoaderManager::downloadTimerCallback):
              * platform...
      e0bfe232
  5. 13 Oct, 2006 11 commits
    • bdakin's avatar
      Reviewed by Geoff. · 8a2bb060
      bdakin authored
              Build fix from my last check-in. Make hasOutlineAnnotation() non-
              inline so that we don't have to include Document.h in 
              RenderObject.h
              Doing so causes a build failure in WebKit, and it probably isn't a 
              good idea anyway.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::hasOutlineAnnotation):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasOutline):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a2bb060
    • ggaren's avatar
      Reviewed by Beth. · f1dbe6ac
      ggaren authored
              
              Split build, run, and debug steps into separate pages. Darin recommended
              this a while back.
      
              * building/build.html:
              * building/checkout.html:
              * building/debug.html: Added.
              * building/run.html: Added.
              * nav.inc:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1dbe6ac
    • bdakin's avatar
      Patch written mostly by Ken Kraisler, but also by me. · 6e760ffb
      bdakin authored
              Reviewed by Hyatt.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
              problem/3391162> PDF created by printing should have live 
              hyperlinks
      
              * platform/GraphicsContext.cpp:
              (WebCore::GraphicsContext::focusRingBoundingRect):
              * platform/GraphicsContext.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::setURLForRect):
              * platform/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::setURLForRect): Implement method to add 
              URL link to PDF document.
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
              querying the outline width
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject): Same as above.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::paintLines): Call the new paintOutline()
              (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
              pdf url rects, and outline painting.
              * rendering/RenderFlow.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
              link to a rectanglular region.
              (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
              well as focus ring painting.
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
              element is a link and we are printing.
              (WebCore::RenderObject::hasOutline): Returns true is the style has 
              an outline and hasOutlineAnnotation() is true.
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
              greater than 0 and outlineStyle is greater than BHIDDEN.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e760ffb
    • justing's avatar
      LayoutTests: · 9763f319
      justing authored
              Reviewed by ggaren and harrison
              
              <rdar://problem/4744008>
              9A270: Mail crashes when I try to paste large items from Safari
              
              * editing/pasteboard/4744008-expected.txt: Added.
              * editing/pasteboard/4744008.html: Added.
      
      WebCore:
      
              Reviewed by ggaren and harrison
              
              <rdar://problem/4744008>
              9A270: Mail crashes when I try to paste large items from Safari
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
              Even though we put nodes in the hash map in pre-order, they don't necessary
              come out of the iterator that way.  If a node is a redundant style span
              and one of its pruned ancestors comes off the hash map after it, and that
              ancestor is a redundant style span or font tag, we will try to remove it
              even though it has already been removed and we'll crash.
              The test case added with the fix depends on our hash map implementation
              because it requires that a particular redundant style span come out of 
              the iterator before its parent. So, it may eventually not provide 
              coverage for the fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9763f319
    • mjs's avatar
      Reviewed by Darin. · 159df82d
      mjs authored
              - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_window.cpp:
              (KJS::createNewWindow):
              (KJS::WindowFunc::callAsFunction):
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              (WebCore::BrowserExtensionMac::createNewWindow):
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::submitForm):
              (WebCore::FrameMac::openURLRequest):
              (WebCore::FrameMac::urlSelected):
              * bridge/win/BrowserExtensionWin.h:
              * page/Frame.cpp:
              (WebCore::Frame::changeLocation):
              (WebCore::Frame::urlSelected):
              (WebCore::Frame::requestFrame):
              (WebCore::Frame::submitForm):
              * page/Frame.h:
              * page/FrameLoadRequest.h: Added.
              (WebCore::FrameLoadRequest::FrameLoadRequest):
              (WebCore::FrameLoadRequest::lockHistory):
              (WebCore::FrameLoadRequest::setLockHistory):
              * page/ResourceRequest.h:
              (WebCore::ResourceRequest::ResourceRequest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      159df82d
    • sullivan's avatar
      Reviewed by Maciej · 9118e5a7
      sullivan authored
              * loader/mac/WebFrameLoader.mm:
              (-[WebFrameLoader loadDocumentLoader:]):
              Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
              happen when loading a page during a decidePolicyForNavigationAction callback.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9118e5a7
    • mjs's avatar
      Not reviewed, build fix. · 064f0b51
      mjs authored
              
              * icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      064f0b51
    • mjs's avatar
      Not reviewed, build fix. · 83593159
      mjs authored
              
              * icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83593159
    • hyatt's avatar
      Transparency layer work. · d3b68ca5
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3b68ca5
    • mjs's avatar
      Reviewed by Anders. · c34d8df3
      mjs authored
              
              - add a bunch of casts to get this compiling with older Xcode versions
              
              (I used static_cast so it will be easier to find and remove these once we have completely moved
              on to a new enough compiler version.)
      
              * Plugins/WebBaseNetscapePluginView.m:
              (+[WebBaseNetscapePluginView getCarbonEvent:]):
              (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
              (-[WebBaseNetscapePluginView fixWindowPort]):
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
              (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
              (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c34d8df3
    • rwlbuis's avatar
      Reviewed by Mitz. · 60957636
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11217
              Cleanup svg coding style
      
              Cleanup coding style in svg paint server classes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60957636