- 25 Apr, 2011 33 commits
-
-
oliver@apple.com authored
Reviewed by Geoffrey Garen. Make ClassInfo required when creating a Structure https://bugs.webkit.org/show_bug.cgi?id=59340 Add ClassInfo to all those types which currently don't have it, and add an assertion to Structure::create to ensure that the provided classInfo is not null. * runtime/Executable.h: (JSC::EvalExecutable::createStructure): (JSC::ProgramExecutable::createStructure): (JSC::FunctionExecutable::createStructure): * runtime/GetterSetter.cpp: * runtime/GetterSetter.h: (JSC::GetterSetter::createStructure): * runtime/JSAPIValueWrapper.cpp: * runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::createStructure): * runtime/JSCell.cpp: * runtime/JSCell.h: * runtime/JSString.cpp: * runtime/JSString.h: (JSC::RopeBuilder::createStructure): * runtime/Structure.h: (JSC::Structure::create): (JSC::JSCell::createDummyStructure): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=59342 Reviewed by Adam Barth. This patch is to prepare for the strict OwnPtr hack-a-thon. * runtime/PropertyMapHashTable.h: (JSC::PropertyTable::copy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Maciej Stachowiak. ImageBuffer.h should work with strict OwnPtrs https://bugs.webkit.org/show_bug.cgi?id=59341 This patch is to prepare for the strict OwnPtr hack-a-thon. * platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
Reviewed by Brian Weinstein. WebCore build on Windows should include windows.h in its precompiled header to speed builds https://bugs.webkit.org/show_bug.cgi?id=59339 windows.h is included by several of the underlying wtf headers, including Atomics.h and ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation. On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes (a 12% speedup). * WebCorePrefix.h: Include windows.h git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Gavin Barraclough. Rationalize MacroAssembler branch methods https://bugs.webkit.org/show_bug.cgi?id=58950 split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition' and apply related changes (only for SH4 platforms). * assembler/MacroAssemblerSH4.cpp: * assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::compare32): (JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords): (JSC::MacroAssemblerSH4::branchDouble): (JSC::MacroAssemblerSH4::branch32): (JSC::MacroAssemblerSH4::branchTest8): (JSC::MacroAssemblerSH4::branch8): (JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32): (JSC::MacroAssemblerSH4::test8): (JSC::MacroAssemblerSH4::branch16): (JSC::MacroAssemblerSH4::branchTest32): (JSC::MacroAssemblerSH4::branchAdd32): (JSC::MacroAssemblerSH4::branchMul32): (JSC::MacroAssemblerSH4::branchSub32): (JSC::MacroAssemblerSH4::branchOr32): (JSC::MacroAssemblerSH4::branchConvertDoubleToInt32): (JSC::MacroAssemblerSH4::branchPtrWithPatch): (JSC::MacroAssemblerSH4::SH4Condition): * assembler/SH4Assembler.h: (JSC::SH4Assembler::cmpEqImmR0): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. PropertyMapHashTable should work with strict OwnPtr https://bugs.webkit.org/show_bug.cgi?id=59337 This patch is in preparation for the strict OwnPtr hack-a-thon. * runtime/PropertyMapHashTable.h: (JSC::PropertyTable::PropertyTable): (JSC::PropertyTable::addDeletedOffset): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Reviewed by Xan Lopez. [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint() https://bugs.webkit.org/show_bug.cgi?id=59311 * platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar disconnect any lingering signal handlers. This prevents an adjustment from controlling the active ScrollView and some zombie ScrollView. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Sam Weinig. * heap/MarkStack.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
* UseJSC.cmake: * bindings/js/JSDOMBinding.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
* UseJSC.cmake: Added a missing file. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Oliver Hunt. Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts https://bugs.webkit.org/show_bug.cgi?id=59333 * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing. * bindings/js/JSDOMBinding.cpp: * bindings/js/JSDOMBinding.h: * bindings/js/JSDocumentCustom.cpp: * bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions. * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject lifetime management. * dom/Document.idl: No need for a custom mark function anymore, since ActiveDOMObjets now manage their own lifetimes. * dom/MessagePort.cpp: (WebCore::MessagePort::hasPendingActivity): Correctly report that we have pending activity when we're remotely entangled, instead of relying on our clients to know this about us and do the check for us. * dom/MessagePort.h: FIXME! * dom/MessagePort.idl: * fileapi/DOMFileSystem.idl: * fileapi/FileReader.idl: * fileapi/FileWriter.idl: * notifications/Notification.idl: * notifications/NotificationCenter.idl: * page/EventSource.idl: * storage/IDBDatabase.idl: * storage/IDBRequest.idl: * storage/IDBTransaction.idl: * webaudio/AudioContext.idl: * websockets/WebSocket.idl: * workers/AbstractWorker.idl: * workers/SharedWorker.idl: * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management. * workers/WorkerContext.cpp: (WebCore::WorkerContext::hasPendingActivity): No need to make up for MessagePort::hasPendingActivity being wrong anymore, since it's now right. * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=59335 * platform/qt-wk2/Skipped: Add fast/dom/shadow/gc-shadow.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=59334 * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=59134 <rdar://problem/8739005> Reviewed by Adam Roben. Implement attaching and detaching of the Web Inspector on Windows, and also support setAttachedWindowHeight when the user changes the height of the docked inspector. This patch doesn't remember whether the user prefers attached or detached, and doesn't remember the user's preferred docked height, but that will be a separate bug. * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::attach): Set the attached flag and call platform-specific code. (WebKit::WebInspectorProxy::detach): Ditto. (WebKit::WebInspectorProxy::setAttachedWindowHeight): Call platform-specific code. (WebKit::WebInspectorProxy::didClose): Set m_isVisible before calling platformClose. platformClose calls detach if the inspector was docked, and detach needs to know whether or not the window is visible. * UIProcess/WebInspectorProxy.h: * UIProcess/WebInspectorProxy.messages.in: Add new messages. * UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pageClient): Add a getter for the page client. * UIProcess/win/WebInspectorProxyWin.cpp: (WebKit::WebInspectorProxy::windowReceivedMessage): Relay WM_WINDOWPOSCHANGING messages from the inspected web view to the WebInspectorProxy. (WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Resize the inspected web view to behave well with the docked inspector. (WebKit::WebInspectorProxy::platformClose): If we are attached, detach before destroying. (WebKit::WebInspectorProxy::platformAttach): Set the inspector's host window to be the inspected web view's parent window, so the inspected web view and the inspector are siblings. (WebKit::WebInspectorProxy::platformDetach): Set the inspector's host window to be the standalone inspector window. (WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Size the views. * WebProcess/WebCoreSupport/WebInspectorClient.cpp: * WebProcess/WebCoreSupport/WebInspectorClient.h: * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::attachWindow): Call WebInspector::attach. (WebKit::WebInspectorFrontendClient::closeWindow): Add a call to the InspectorController to disconnect the inspector frontend from the inspector backend. Without this line, when we close the attached inspector, it won't re-open, because the inspector controller still thinks there is a frontend. This matches WebKit1's behavior, although it seems like this is something WebCore should handle. (WebKit::WebInspectorFrontendClient::detachWindow): Call WebInspector::detach. (WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Call WebInspector::setAttachedWindowHeight. * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaImpl::sendUpdateBackingStoreState): Add an early return if the WebPageProxy's viewSize is empty. This can be needed if the inspector takes up the whole view, and it is useful to prevent a possible synchronous message from the UIProcess -> WebProcess to update a backing store that isn't visible in the first place. * WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::attach): Send a message to the UIProcess. (WebKit::WebInspector::detach): Ditto. (WebKit::WebInspector::setAttachedWindowHeight): Ditto. * WebProcess/WebPage/WebInspector.h: Remove some dead code. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
* platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
compositing/iframes/invisible-nested-iframe-show.html failing since r84037. https://bugs.webkit.org/show_bug.cgi?id=58990 Add failing expected results for SL WK2 to get the bots green. These tests are already Skipped on Windows or have their own expected results. * platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added. * platform/mac-wk2/editing/undo/undo-iframe-location-change-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
since Windows does not have an implementation of HTMLProgressElement. * platform/win/Skipped: Add fast/dom/HTMLProgressElement/progress-writing-mode.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=59263 <rdar://problem/8767659> Reviewed by Alice Liu. Support highlighting of page elements for the inspector in WebKit2 by having the WebInspectorClient be a PageOverlay Client and be responsible for calling InspectorController::drawNodeHighlight. * WebProcess/WebCoreSupport/WebInspectorClient.cpp: (WebKit::WebInspectorClient::highlight): Create our overlay if it hasn't been created, or call setNeedsDisplay if it has. (WebKit::WebInspectorClient::hideHighlight): Uninstall the page overlay if it exists. (WebKit::WebInspectorClient::pageOverlayDestroyed): (WebKit::WebInspectorClient::willMoveToWebPage): If it's being destroyed (moving to a null WebPage), clear the member variable. (WebKit::WebInspectorClient::didMoveToWebPage): (WebKit::WebInspectorClient::drawRect): Call InspectorController::drawNodeHighlight. (WebKit::WebInspectorClient::mouseEvent): * WebProcess/WebCoreSupport/WebInspectorClient.h: (WebKit::WebInspectorClient::WebInspectorClient): Add a new member variable. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: worker messages should be routed to corresponding worker front-end https://bugs.webkit.org/show_bug.cgi?id=59323 Added WorkerManager which is responsible for routing messages between Page inspector front-end and Worker inspector front-ends. * WebCore.gypi: * inspector/front-end/WebKit.qrc: * inspector/front-end/WorkerManager.js: Added. (WebInspector.WorkerManager): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend): (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded): (WebInspector.WorkerManager.loaded): (WebInspector.WorkerFrontendStub): (WebInspector.WorkerFrontendStub.prototype._receiveMessage): (WebInspector.WorkerDispatcher): (WebInspector.WorkerDispatcher.prototype._receiveMessage): (WebInspector.WorkerDispatcher.prototype.workerCreated): (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker): * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: (WebInspector.loaded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
scherkus@chromium.org authored
Reviewed by Dimitri Glazkov. Adding a few Chromium contributors to committers.py. https://bugs.webkit.org/show_bug.cgi?id=59327 * Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Resources panel] Should be easy to copy data. https://bugs.webkit.org/show_bug.cgi?id=45662 Adds context menu items to copy resource location, resource request headers, and resource response headers. * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu. (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard. (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard. (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard. * inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders. (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM https://bugs.webkit.org/show_bug.cgi?id=59322 * inspector/styles/parse-utf8-bom-expected.txt: Added. * inspector/styles/parse-utf8-bom.html: Added. * inspector/styles/resources/parse-utf8-bom-main.css: Added. (h1): (h2): * inspector/styles/resources/parse-utf8-bom-reset.css: Added. 2011-04-25 Alexander Pavlov <apavlov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM https://bugs.webkit.org/show_bug.cgi?id=59322 Use TextResourceDecoder to determine external stylesheet charsets correctly. Test: inspector/styles/parse-utf8-bom.html * inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::originalStyleSheetText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jberlin@webkit.org authored
since Windows does not have an implementation of HTMLProgressElement. * platform/win/Skipped: Add fast/dom/HTMLProgressElement/progress-writing-mode.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed: Inspector.json cleanup. * inspector/Inspector.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: move Frame and Resource Tree management into the Page agent. https://bugs.webkit.org/show_bug.cgi?id=59321 * inspector/report-protocol-errors.html: 2011-04-25 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Web Inspector: introduce InspectorWorkerAgent https://bugs.webkit.org/show_bug.cgi?id=59320 InspectorWorkerAgent is responsible for routing inspector messages between worker context inspector agents and corresponding worker inspector front-end. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/CodeGeneratorInspector.pm: * inspector/Inspector.json: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): * inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent): * inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext): * inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext): * inspector/InspectorWorkerAgent.h: Added. * inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent): * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): * inspector/generate-inspector-idl: * workers/Worker.cpp: (WebCore::Worker::notifyFinished): * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy): * workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: introduce InspectorWorkerAgent https://bugs.webkit.org/show_bug.cgi?id=59320 InspectorWorkerAgent is responsible for routing inspector messages between worker context inspector agents and corresponding worker inspector front-end. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/CodeGeneratorInspector.pm: * inspector/Inspector.json: * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): * inspector/InspectorAgent.h: (WebCore::InspectorAgent::workerAgent): * inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willStartWorkerContext): (WebCore::InspectorInstrumentation::didStartWorkerContext): * inspector/InspectorWorkerAgent.cpp: Added. (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::setFrontend): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector): (WebCore::InspectorWorkerAgent::didStartWorkerContext): * inspector/InspectorWorkerAgent.h: Added. * inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorWorkerAgent): (WebCore::InstrumentingAgents::setInspectorWorkerAgent): * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): * inspector/generate-inspector-idl: * workers/Worker.cpp: (WebCore::Worker::notifyFinished): * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector messages sent from the inspected page worker agent to the worker context inspector agents. (WebCore::WorkerContextInspectorProxy::connectFrontend): (WebCore::WorkerContextInspectorProxy::disconnectFrontend): (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector): (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy): * workers/WorkerContextProxy.h: (WebCore::WorkerContextProxy::inspectorProxy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: few protocol improvements. https://bugs.webkit.org/show_bug.cgi?id=59319 * http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.reloadPage): 2011-04-25 Pavel Feldman <pfeldman@google.com> Reviewed by Yury Semikhatsky. Web Inspector: few protocol improvements. https://bugs.webkit.org/show_bug.cgi?id=59319 - Page domain is documented - setUserAgentOverride is moved to the Network agent - setSearchingForNode -> setInspectModeEnabled - highlightDOMNode -> highlightNode - reloadPage -> reload - openInNewWindow -> open with optional parameter * inspector/Inspector.json: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setInspectModeEnabled): (WebCore::InspectorDOMAgent::highlightNode): * inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::hideNodeHighlight): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): * inspector/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::clearFrontend): (WebCore::InspectorPageAgent::reload): (WebCore::InspectorPageAgent::open): * inspector/InspectorPageAgent.h: * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearFrontend): (WebCore::InspectorResourceAgent::applyUserAgentOverride): (WebCore::InspectorResourceAgent::setUserAgentOverride): * inspector/InspectorResourceAgent.h: * inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setSearchingForNode): * inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._openInNewTab): * inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.ondblclick): * inspector/front-end/inspector.js: (WebInspector.highlightDOMNode): (WebInspector.openResource): (WebInspector.documentKeyDown): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Antonio Gomes. [EFL] Remove ewk_eapi.h https://bugs.webkit.org/show_bug.cgi?id=59091 * ewk/EWebKit.h: * ewk/ewk_contextmenu.h: * ewk/ewk_cookies.h: * ewk/ewk_eapi.h: Removed. * ewk/ewk_frame.h: * ewk/ewk_history.h: * ewk/ewk_main.h: * ewk/ewk_settings.h: * ewk/ewk_tiled_matrix.h: * ewk/ewk_tiled_model.h: * ewk/ewk_window_features.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Reviewed by Cameron Zwarich. Fix tests after URL parsing fix https://bugs.webkit.org/show_bug.cgi?id=59317 * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Update expected behavior. * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Update expected behavior. * fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Update expectations. * fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Update expectations. * fast/loader/url-parse-1-expected.txt: Update expectations. * http/tests/loading/cross-origin-XHR-willLoadRequest.html: Replace single slash in an http: URL with a double slash - the single slash seemed to be erroneous. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Maciej Stachowiak. Overlay scroller hard to see on pages with dark background (59183) https://bugs.webkit.org/show_bug.cgi?id=59183 <rdar://problem/8975367> Switch the scrollbar's overlay style depending on its frame's background color. This refactors the getDocumentBackgroundColor method needed for gestures. The style is determined and set on every paint() call to the Mac scrollbar theme. * WebCore.exp.in: adding method to allow changing style * page/Frame.cpp: (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView * page/Frame.h: * page/FrameView.cpp: (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color * page/FrameView.h: * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles * platform/ScrollableArea.h: (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style * platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: 2011-04-25 Jon Lee <jonlee@apple.com> Reviewed by Maciej Stachowiak. Overlay scroller hard to see on pages with dark background (59183) https://bugs.webkit.org/show_bug.cgi?id=59183 <rdar://problem/8975367> * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style 2011-04-25 Jon Lee <jonlee@apple.com> Reviewed by Maciej Stachowiak. Overlay scroller hard to see on pages with dark background (59183) https://bugs.webkit.org/show_bug.cgi?id=59183 <rdar://problem/8975367> * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): adding method to allow changing style * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::getDocumentBackgroundColor): refactoring to use common code for retrieving background color git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation) https://bugs.webkit.org/show_bug.cgi?id=59315 Reviewed by Maciej Stachowiak. * platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): Initialize new member variables. (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document is scrolled a distance equal to the change in the mouse position. (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag the document rather than the thumb, and pass the result to moveThumb. (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument. * platform/Scrollbar.h: * platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation returns false. * platform/mac/ScrollbarThemeMac.h: * platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the Option key is down. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Unreviewed, expectations change. Add Chromium baselines for fast/table/auto-100-percent-width.html. Mark fast/dom/HTMLMeterElement/meter-element.html and http/tests/misc/will-send-request-returns-null-on-redirect.html as failing - need triage. * platform/chromium-mac/fast/table/auto-100-percent-width-expected.png: Added. * platform/chromium-win/fast/table/auto-100-percent-width-expected.png: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 24 Apr, 2011 7 commits
-
-
abarth@webkit.org authored
Update Chromium results for standard-url.html (again). * platform/chromium-linux/fast/url/standard-url-expected.txt: * platform/chromium-mac/fast/url/standard-url-expected.txt: * platform/chromium-win/fast/url/standard-url-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren@apple.com authored
Reviewed by Sam Weinig. Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration https://bugs.webkit.org/show_bug.cgi?id=59307 * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit. * bindings/js/JSCSSRuleCustom.cpp: * bindings/js/JSCSSStyleDeclarationCustom.cpp: * bindings/js/JSCanvasRenderingContextCustom.cpp: * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead of hand-coding them. * bindings/js/JSDOMBinding.h: (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because they're reasonably generic. * bindings/js/JSDOMImplementationCustom.cpp: * bindings/js/JSDOMStringMapCustom.cpp: * bindings/js/JSDOMTokenListCustom.cpp: * bindings/js/JSHTMLCollectionCustom.cpp: * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of hand-coding them. * bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::visitChildren): * bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper. This is one of the few cases where a DOM object is considered a stand-alone root. It's not as efficient as the shared root case, but workers and message ports are very rare objects, so it's no big deal. * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate! * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h. * bindings/js/JSSharedWorkerCustom.cpp: (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, a stand-alone root. * bindings/js/JSStyleSheetCustom.cpp: * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate! * bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots system for marking WebGL contexts and their associated satellite objects. * bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::visitChildren): * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of markDOMObjectWrapper, as above. Once again, stand-alone roots. (WebCore::JSXMLHttpRequest::visitChildren): * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner XHR because it is not reachable from us. * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a bunch of repetitive cases of isReachableFromOpaqueRoots callbacks. * css/CSSRule.idl: * css/CSSStyleDeclaration.idl: * css/MediaList.idl: * css/StyleMedia.idl: * css/StyleSheet.idl: * css/StyleSheetList.idl: * dom/DOMImplementation.idl: * dom/DOMStringMap.idl: * dom/MessagePort.idl: * dom/NamedNodeMap.idl: * fileapi/Blob.idl: * html/DOMTokenList.idl: Opt in to autogeneration. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious. * html/HTMLCollection.idl: * html/canvas/ArrayBuffer.idl: Opt in to autogeneration. * html/canvas/CanvasRenderingContext.cpp: * html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::ref): (WebCore::CanvasRenderingContext::deref): * html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::create): (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr usage, to reduce human error and make ownership rules more obvious. Inlined some functions to match our standard idiom and to make the code in the header document itself. * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration. * html/canvas/OESStandardDerivatives.cpp: (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::create): * html/canvas/OESStandardDerivatives.h: * html/canvas/OESStandardDerivatives.idl: * html/canvas/OESTextureFloat.cpp: (WebCore::OESTextureFloat::OESTextureFloat): (WebCore::OESTextureFloat::create): * html/canvas/OESTextureFloat.h: * html/canvas/OESTextureFloat.idl: * html/canvas/OESVertexArrayObject.cpp: (WebCore::OESVertexArrayObject::OESVertexArrayObject): (WebCore::OESVertexArrayObject::create): * html/canvas/OESVertexArrayObject.h: * html/canvas/OESVertexArrayObject.idl: * html/canvas/WebGLExtension.cpp: (WebCore::WebGLExtension::WebGLExtension): * html/canvas/WebGLExtension.h: (WebCore::WebGLExtension::ref): (WebCore::WebGLExtension::deref): (WebCore::WebGLExtension::context): * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::~WebGLRenderingContext): (WebCore::WebGLRenderingContext::getExtension): * html/canvas/WebGLRenderingContext.h: * html/canvas/WebKitLoseContext.cpp: (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext): * html/canvas/WebKitLoseContext.h: * html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL canavs rendering contexts to match the model for 2D canvas rendering contexts. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable. (Previously, satellite objects would magically stop working when the last reference to their owner object was dropped. Now, satellite objects keep their owner alive through reference counting.) * loader/appcache/DOMApplicationCache.idl: * page/BarInfo.idl: * page/Console.idl: * page/DOMSelection.idl: * page/Geolocation.idl: * page/History.idl: * page/Location.idl: * page/Navigator.idl: * page/Screen.idl: * page/WorkerNavigator.idl: * plugins/DOMMimeTypeArray.h: (WebCore::DOMMimeTypeArray::frame): * plugins/DOMMimeTypeArray.idl: * plugins/DOMPluginArray.h: (WebCore::DOMPluginArray::frame): * plugins/DOMPluginArray.idl: * storage/Storage.idl: * workers/WorkerLocation.idl: Opt in to autogeneration. * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::~XMLHttpRequest): * xml/XMLHttpRequest.h: * xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext): * xml/XMLHttpRequestUpload.h: (WebCore::XMLHttpRequestUpload::create): (WebCore::XMLHttpRequestUpload::ref): (WebCore::XMLHttpRequestUpload::deref): (WebCore::XMLHttpRequestUpload::xmlHttpRequest): (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload): * xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and its associated upload object to match the model for canvas. This makes garbage collection a lot more straightforward, but it also makes the behavior of these objects more reliable. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r84759. http://trac.webkit.org/changeset/84759 https://bugs.webkit.org/show_bug.cgi?id=59306 Caused gc-shadow.html to start crashing in V8. (Requested by dglazkov|away on #webkit). * fast/dom/shadow/append-child-text-expected.txt: Removed. * fast/dom/shadow/append-child-text.html: Removed. 2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r84759. http://trac.webkit.org/changeset/84759 https://bugs.webkit.org/show_bug.cgi?id=59306 Caused gc-shadow.html to start crashing in V8. (Requested by dglazkov|away on #webkit). * dom/Node.cpp: (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mjs@apple.com authored
Reviewed by George Staikos. Handling of URLs like http:/example.com/ is incorrect https://bugs.webkit.org/show_bug.cgi?id=59300 <rdar://problem/9231956> URLs like http:/example.com/ or http:example.com/ are now correctly canonicalized as http://example.com/ The code still doesn't quite match other browsers - at least some other browsers seem to base parsing behavior on whether they recongize a scheme from a fixed list, and ignore whether // is present in the URL or not. * platform/KURL.cpp: (WebCore::isNonFileHierarchicalScheme): New helper function. (WebCore::KURL::parse): For a particular list of whitelisted schemes, assume they are hierarchical and need an authority even if there is no // after the :/ 2011-04-24 Maciej Stachowiak <mjs@apple.com> Reviewed by George Staikos. Handling of URLs like http:/example.com/ is incorrect https://bugs.webkit.org/show_bug.cgi?id=59300 <rdar://problem/9231956> Added some new test cases. Also updated results for the change. The changes are progressions. * fast/url/relative-expected.txt: * fast/url/script-tests/segments.js: * fast/url/script-tests/standard-url.js: * fast/url/segments-expected.txt: * fast/url/segments-from-data-url-expected.txt: * fast/url/standard-url-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Update Chromium results for standard-url.html * platform/chromium-linux/fast/url/standard-url-expected.txt: Added. * platform/chromium-mac/fast/url/standard-url-expected.txt: * platform/chromium-win/fast/url/standard-url-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
* page/ContentSecurityPolicy.cpp: Removed an unused function. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Crash when adding a text node to a shadow root https://bugs.webkit.org/show_bug.cgi?id=59304 * fast/dom/shadow/append-child-text-expected.txt: Added. * fast/dom/shadow/append-child-text.html: Added. 2011-04-24 Dominic Cooney <dominicc@chromium.org> Reviewed by Dimitri Glazkov. Crash when adding a text node to a shadow root https://bugs.webkit.org/show_bug.cgi?id=59304 Text nodes need to consult their host element for style. Test: fast/dom/shadow/append-child-text.html * dom/Node.cpp: (WebCore::NodeRendererFactory::styleForRenderer): (WebCore::NodeRendererFactory::createRendererAndStyle): (WebCore::Node::styleForRenderer): forward to NodeRendererFactory git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-