1. 01 May, 2008 2 commits
    • kmccullough@apple.com's avatar
      2008-05-01 Kevin McCullough <kmccullough@apple.com> · 21b94191
      kmccullough@apple.com authored
              Reviewed by Darin.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              - Fix "sample" output so that it can be imported into Instruments
              - Also keep track of number of times a function is profiled.
      
              * JavaScriptCore.xcodeproj/project.pbxproj: Add StrHash.h which needed
              to be pulled out of identifier.cpp so that it could be used by the
              profiler and identifiers.
              * kjs/identifier.cpp: Ditto.
              * profiler/FunctionCallProfile.cpp:
              (KJS::FunctionCallProfile::printDataInspectorStyle): Inspector style
              printing should show microseconds.
              (KJS::FunctionCallProfile::printDataSampleStyle): Sample style printing
              now counts the number of times a function is in the stack tree and does
              not print microseconds since that does not make sense for a sampler.
              * profiler/FunctionCallProfile.h: Keep track of number of times a
              function is profiled.
              (KJS::FunctionCallProfile::numberOfCalls):
              * profiler/Profiler.cpp:
              (KJS::functionNameCountPairComparator): Comparator for sort function in
              printDataSampleStyle.
              (KJS::Profiler::printDataSampleStyle): Print the number of times that a
              function is listed in the stack tree in order of most times listed.
              * wtf/HashCountedSet.h: Added copyToVector since it didn't exist and is
              a more standard way to copy a HashSet to a Vector. I added on variant
              that takes a pair as the Vector's type and so the HashCountedSet simply
              fills in that pair with its internal pair, and another variant that
              takes a Vector of the type of the HashCountedSet and only fills in the
              Vector with the first element of the pair.
              (WTF::copyToVector):
              * wtf/StrHash.h: Added.
              (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21b94191
    • alp@webkit.org's avatar
      2008-05-01 Alp Toker <alp@nuanti.com> · 55996084
      alp@webkit.org authored
              Rubber-stamped by Anders.
      
              GTK+ build fix for changes in r32752. Use int32, not int32_t types in
              npapi.h.
      
              Additional fix to use same signedness in npapi.h and Mac for the
              interval parameter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55996084
  2. 30 Apr, 2008 26 commits
    • jchaffraix@webkit.org's avatar
      2008-04-30 Julien Chaffraix <jchaffraix@webkit.org> · 02f02977
      jchaffraix@webkit.org authored
              Qt 4.3 build fix.
      
              Fixes a brace error that made Qt 4.4 build but not Qt 4.3.
      
              * Api/qwebview.cpp:
              (QWebView::event):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02f02977
    • andersca@apple.com's avatar
      WebCore: · 31c218a6
      andersca@apple.com authored
      2008-04-30  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add new Cocoa event model type declarations.
              
              * bridge/npapi.h:
      
      WebKit:
      
      2008-04-30  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add Cocoa event handler.
              
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2008-04-30  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
              
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (PluginTimer::PluginTimer):
              (PluginTimer::start):
              (PluginTimer::fired):
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView stopTimers]):
              (-[WebBaseNetscapePluginView restartTimers]):
              (-[WebBaseNetscapePluginView scrollWheel:]):
              (-[WebBaseNetscapePluginView flagsChanged:]):
              (-[WebBaseNetscapePluginView start]):
              (-[WebBaseNetscapePluginView eventModel]):
              (-[WebBaseNetscapePluginView fini]):
              (-[WebBaseNetscapePluginView getVariable:value:]):
              (-[WebBaseNetscapePluginView setVariable:value:]):
              (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
              (-[WebBaseNetscapePluginView unscheduleTimer:]):
              * Plugins/WebBaseNetscapePluginViewInternal.h:
              * Plugins/WebBaseNetscapePluginViewPrivate.h:
              * Plugins/WebNetscapePluginEventHandler.h:
              * Plugins/WebNetscapePluginEventHandler.mm:
              (WebNetscapePluginEventHandler::create):
              * Plugins/WebNetscapePluginEventHandlerCarbon.h:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              (WebNetscapePluginEventHandlerCarbon::scrollWheel):
              (WebNetscapePluginEventHandlerCarbon::flagsChanged):
              (WebNetscapePluginEventHandlerCarbon::platformWindow):
              * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
              (WebNetscapePluginEventHandlerCocoa::startTimers):
              (WebNetscapePluginEventHandlerCocoa::stopTimers):
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
              (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
              (WebNetscapePluginEventHandlerCocoa::drawRect):
              (WebNetscapePluginEventHandlerCocoa::mouseDown):
              (WebNetscapePluginEventHandlerCocoa::mouseDragged):
              (WebNetscapePluginEventHandlerCocoa::mouseEntered):
              (WebNetscapePluginEventHandlerCocoa::mouseExited):
              (WebNetscapePluginEventHandlerCocoa::mouseMoved):
              (WebNetscapePluginEventHandlerCocoa::mouseUp):
              (WebNetscapePluginEventHandlerCocoa::scrollWheel):
              (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
              (WebNetscapePluginEventHandlerCocoa::keyDown):
              (WebNetscapePluginEventHandlerCocoa::keyUp):
              (WebNetscapePluginEventHandlerCocoa::flagsChanged):
              (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
              (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
              (WebNetscapePluginEventHandlerCocoa::focusChanged):
              (WebNetscapePluginEventHandlerCocoa::platformWindow):
              (WebNetscapePluginEventHandlerCocoa::sendEvent):
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
              * Plugins/npapi.m:
              (NPN_ScheduleTimer):
              (NPN_UnscheduleTimer):
              * Plugins/npfunctions.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31c218a6
    • bdakin@apple.com's avatar
      2008-04-30 Beth Dakin <bdakin@apple.com> · 90a00ff8
      bdakin@apple.com authored
              Reviewed by Sam Weinig.
      
              This patch does three things:
              1. Adds support for the "img" ARIA role
              2. Switches over to a HashMap for converting ARIA role attributes 
              to WebCore's AccessibilityRole type. 
              3. Fixes a crash in the new ARIA code that I ran into while 
              browsing with VoiceOver enabled.
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::headingLevel): This is the crash 
              fix. Make sure the node's renderer is not null before looking up 
              its corresponding AccessibilityObject in the cache.
              (WebCore::AccessibilityObject::accessibilityIsIgnored): Account for 
              ARIA images.
              (WebCore::createARIARoleMap): Switch to HashMap, and add "img" to 
              the Map.
              (WebCore::RoleEntry::): Same.
              (WebCore::ariaRoleToWebCoreRole): Same.
              (WebCore::AccessibilityObject::ariaRoleAttribute): Same.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90a00ff8
    • beidson@apple.com's avatar
      2008-04-30 Brady Eidson <beidson@apple.com> · c6bb8dfd
      beidson@apple.com authored
              Fix my WebPreferences revert check-in
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6bb8dfd
    • beidson@apple.com's avatar
      2008-04-30 Brady Eidson <beidson@apple.com> · 8eef61cb
      beidson@apple.com authored
              Rubberstamped by John Sullivan
      
              Revert the remainder of my original preferences changes from last week.
              They caused a massive PLT regression (too many notifications being sent out
              or listened to that weren't previously) and it's not in my schedule to refine
              the preferences code instead of working on my feature!
      
              * WebView/WebView.mm:
              (-[WebView _updateSettingsFromPreferences:]):
              (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8eef61cb
    • andersca@apple.com's avatar
      2008-04-30 Anders Carlsson <andersca@apple.com> · 375cd93d
      andersca@apple.com authored
              Fix the 64-bit build.
              
              * Plugins/WebNetscapePluginEventHandler.h:
              * Plugins/WebNetscapePluginEventHandler.mm:
              * Plugins/WebNetscapePluginEventHandlerCarbon.h:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      375cd93d
    • rwlbuis@webkit.org's avatar
      Reviewed by Nikolas. · d7295f7f
      rwlbuis@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=16447
              onload called too many times for <svg:image>
              https://bugs.webkit.org/show_bug.cgi?id=12282
              SVG wastes time in malloc to send loadEvents to non-existent listeners
      
              Postpone load event dispatching for image when externalResourcesRequired        is true, delaying parents but not siblings, and make sure the load event        is sent once for image in all cases.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7295f7f
    • hyatt@apple.com's avatar
      WebCore: · 46ab9613
      hyatt@apple.com authored
      2008-04-30  David Hyatt  <hyatt@apple.com>
      
              Fix crashes when dynamically removing <video> elements with layers that establish stacking contexts.  This
              won't typically crash release builds because of arena recycling.
      
              Reviewed by Dan Bernstein
              
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::~RenderLayer):
              Make sure to remove the reflection's child layer from its parent.
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::~RenderMedia):
              (WebCore::RenderMedia::destroy):
              (WebCore::RenderMedia::removeChild):
              * rendering/RenderMedia.h:
              Adjust the teardown of RenderMedia so that it does all of its teardown inside destroy() (this makes it more
              like other renderers and doesn't leave you staring at a trashed layer hierarchy in the RenderMedia
              destructor).
      
      LayoutTests:
      
      2008-04-30  David Hyatt  <hyatt@apple.com>
      
              Add test for video crasher.
      
              Reviewed by Dan Bernstein
      
              * media/video-layer-crash.html: Added.
              * platform/mac/media/video-layer-crash-expected.checksum: Added.
              * platform/mac/media/video-layer-crash-expected.png: Added.
              * platform/mac/media/video-layer-crash-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ab9613
    • rwlbuis@webkit.org's avatar
      Fix the ChangeLogs so it includes the details about r32719. · 0a86c6f8
      rwlbuis@webkit.org authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a86c6f8
    • mitz@apple.com's avatar
      Adding Radar link · a26871c7
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a26871c7
    • mitz@apple.com's avatar
      2008-04-30 Rémi Zara <remi_zara@mac.com> · 7b4c3374
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              fix https://bugs.webkit.org/show_bug.cgi?id=18618
              REGRESSION (r31823-r31847): Patterns are upside down
      
              * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
              (WebCore::patternCallback): flip the y axis when drawing the tile
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b4c3374
    • timothy@apple.com's avatar
      Fixes an undefined type exception that fires when adding a resource to the inspector · 40aae8dc
      timothy@apple.com authored
      that has a MIME type warning.
      
      Reviewed by Adam Roben.
      
      * page/inspector/Resource.js:
      (WebInspector.Resource.prototype._addTip): Call WebInspector.console instead of
      WebInspector.consolePanel.
      (WebInspector.Resource.prototype._checkWarning): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40aae8dc
    • timothy@apple.com's avatar
      Fixes the bug where the selected resource would be deselected after · 1daf52a8
      timothy@apple.com authored
      changing the sort order in the Resources panel.
      
      Reviewed by Dan Bernstein.
      
      * page/inspector/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
      Rememebr if the tree element that we are sorting was selected, so
      the selection can be restored after it is re-inserted. The onSelect
      is suppressed since we don't need to show the resource again.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1daf52a8
    • timothy@apple.com's avatar
      Fixes the regression where error bubbles in source views always show · 9061c9a8
      timothy@apple.com authored
      "undefined" for the content because the message property on
      ConsoleMessage was removed. Adds support for a plain text formated
      message that is stored in the message proeprty.
      
      Reviewed by Adam Roben.
      
      * page/inspector/Console.js:
      (WebInspector.Console.prototype._format): Add a plainText argument that is passed to
      the formatters.
      (WebInspector.Console.prototype._formatvalue): Add a plainText argument, and a comment
      about needing to honor it if the textContent of the output doesn't make sense.
      (WebInspector.Console.prototype._formatvalue): Ditto.
      (WebInspector.Console.prototype._formatstring): Ditto.
      (WebInspector.Console.prototype._formatregexp): Ditto.
      (WebInspector.Console.prototype._formatarray): Ditto.
      (WebInspector.Console.prototype._formatnode): Ditto.
      (WebInspector.Console.prototype._formatobject): Ditto.
      (WebInspector.Console.prototype._formaterror): Ditto.
      (WebInspector.ConsoleMessage): Call _format passing true for plainText. Get the
      textContnet of the result and assign to the message proeprty. This property is
      referenced from the SourceView.
      (WebInspector.ConsoleMessage.prototype._format): Add a plainText argument. Build the
      result element as a local and return it, instead of using formatedMessage directly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9061c9a8
    • timothy@apple.com's avatar
      Adds a helper function to convert a JSValueRef to a String. · 1bcccab5
      timothy@apple.com authored
      Reviewed by Adam Roben.
      
      * page/InspectorController.cpp:
      (WebCore::toString): Converts a JSValueRef to a String.
      (WebCore::search): Use toString.
      (WebCore::InspectorController::handleException): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bcccab5
    • hausmann@webkit.org's avatar
      2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com> · 57097f63
      hausmann@webkit.org authored
              Rubber-stamped by Simon
      
              Updated the expected test results to reflect the fact that most render objects now are anonymous.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57097f63
    • hausmann@webkit.org's avatar
      2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com> · 742aa43e
      hausmann@webkit.org authored
                  Reviewed by Simon.
      
                  Build the Qt port with SVG Foreign Object support.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      742aa43e
    • hausmann@webkit.org's avatar
      2008-04-30 Simon Hausmann <hausmann@webkit.org> · b5fc07f7
      hausmann@webkit.org authored
              Reviewed by Holger.
      
              Fix null pointer deference triggered by
              LayoutTests/fast/loader/cancel-load-during-port-block-timer.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5fc07f7
    • hausmann@webkit.org's avatar
      2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com> · 3cc10b19
      hausmann@webkit.org authored
              Rubber-stamped by Simon.
      
              Updated the expected test results to the current font metrics.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cc10b19
    • hausmann@webkit.org's avatar
      2008-04-30 Simon Hausmann <hausmann@webkit.org> · 42942d04
      hausmann@webkit.org authored
              Rubber-stamped by Holger.
      
              Updated the skip list for the Qt port to exclude features currently
              not implemented.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42942d04
    • hausmann@webkit.org's avatar
      2008-04-30 Tor Arne Vestbø <tavestbo@trolltech.com> · 7a4e63fd
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              In focusIn and focusOut event always update the active state of the
              focus controller. Fixes ~400 failing layout tests due to missing
              editing callbacks that relied on the correct focus.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a4e63fd
    • zecke@webkit.org's avatar
      2008-04-30 Sean Egan <seanegan@gmail.com> · 69745189
      zecke@webkit.org authored
              Reviewed and modified by Holger.
      
              https://bugs.webkit.org/show_bug.cgi?id=17626
              Support setting background color and a 16-bit alpha channel.
      
              * webkit/webkitprivate.h:
              * webkit/webkitwebview.cpp:
              * webkit/webkitwebview.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69745189
    • hyatt@apple.com's avatar
      2008-04-29 David Hyatt <hyatt@apple.com> · cee4af67
      hyatt@apple.com authored
              Improve the performance of masks by adding code to set more precise clips on the transparency layers
              used to paint the content under the mask, and then also avoid creating transparency layers for the masks
              themselves in common cases.
      
              Reviewed by Dan Bernstein
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawTiledImage):
              Fix a bug in drawTiledImage where the composite mode got lost in the double stretch case for nine piece
              images.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintFillLayers):
              (WebCore::InlineFlowBox::paintFillLayer):
              (WebCore::InlineFlowBox::paintMask):
              Optimize to only push a transparency layer for the mask if multiple images are combining.  Add a new
              composite operator argument for use when painting fill layers to do direct destination-in compositing while
              painting images.
      
      
              * rendering/InlineFlowBox.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintMask):
              (WebCore::RenderBox::paintMaskImages):
              Optimize to only push a transparency layer for the mask if multiple images are combining.
      
              (WebCore::RenderBox::maskClipRect):
              A new method that attempts to compute a precise clip rect for the mask images.
      
              (WebCore::RenderBox::paintFillLayers):
              (WebCore::RenderBox::paintFillLayer):
              (WebCore::RenderBox::paintFillLayerExtended):
              * rendering/RenderBox.h:
              Added the composite operator argument to the paintFillLayer methods.
      
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintMask):
              Call the new base class paintMaskImages method for optimized mask painting.
      
              * rendering/RenderLayer.cpp:
              (WebCore::transparencyClipBox):
              Fix a coordinate space issue with transparencyClipBox when masks were used.  The border box was in the
              wrong coordinate space.  Moved the code into the layer's boundingBox() method instead.
      
              (WebCore::RenderLayer::paintLayer):
              Removed the code that always pushed a transparency layer before painting masks.
      
              (WebCore::RenderLayer::boundingBox):
              Call maskClipRect to shrink the bounding box of the layer to fit the mask clip.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintNinePieceImage):
              Added a composite operator argument for direct destination-in painting of nine piece images.
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::maskClipRect):
              (WebCore::RenderObject::paintFillLayerExtended):
              Base class stubs for RenderBox-implemented methods.
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintMask):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintMask):
              Modified to call the new paintMaskImages function.
      
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::draw):
              SVG images now respect composite modes by pushing a transparency layer when the composite mode
              is anything other than source-over.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cee4af67
    • hausmann@webkit.org's avatar
      2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com> · e4600cb9
      hausmann@webkit.org authored
              Rubber-stamped by Rob Buis.
      
              Fixed crash or assertion if SVG_FOREIGN_OBJECT is not enabled
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4600cb9
    • hausmann@webkit.org's avatar
      2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com> · 605fa04a
      hausmann@webkit.org authored
              Rubber-stamped by Rob Buis.
      
              Fixed compile, due to API change in XMLSerializer
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      605fa04a
    • rwlbuis@webkit.org's avatar
      Reviewed by Eric. · f212b922
      rwlbuis@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=11939
              Quirksmode: Ignores media types in stylesheet PIs
      
              Transfer the xml-stylesheet pseudo attribute media to the css
              stylesheet created from the ProcessingInstruction.
      
              Tests: fast/css/xml-stylesheet-media-processing.xhtml
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f212b922
  3. 29 Apr, 2008 12 commits
    • adachan@apple.com's avatar
      Support text shadow in WebDrawText(). · 63bcd63c
      adachan@apple.com authored
              Remove DrawTextAtPoint() since it is only called by WebDrawText().
      
              Reviewed by Adam.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
              * WebKitGraphics.cpp:
              (WebDrawText):
              * WebKitGraphics.h:
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63bcd63c
    • ddkilzer@apple.com's avatar
      BUILD FIX for export of WTF::RefCounted<WebCore::FormData>::deref() · 7b3b129e
      ddkilzer@apple.com authored
              On the buildbot, this is a fatal error:
      
              ld: symbols names listed in -exported_symbols_list: WebKitBuild/Release/DerivedSources/WebCore/WebCore.exp not in linked objects
              __ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv
              /usr/bin/libtool: internal link edit command failed
      
              Newer dev tools only produce a warning:
      
              ld warning: cannot export hidden symbol __ZN3WTF10RefCountedIN7WebCore8FormDataEE5derefEv from WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/DocumentLoader.o
      
              * WebCore.base.exp: Remove hidden symbol from export list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b3b129e
    • ddkilzer@apple.com's avatar
      2008-04-29 David D. Kilzer <ddkilzer@apple.com> · 421ac045
      ddkilzer@apple.com authored
              BUILD FIX for Release build.
      
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
              separately so the compiler doesn't complain about an unused variable.
              (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      421ac045
    • andersca@apple.com's avatar
      WebKit: · d9ec98af
      andersca@apple.com authored
      2008-04-29  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add new event handlers.
              
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2008-04-29  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Refactor the Carbon event handling code out into a separate class in preparation for adding
              the Cocoa event handling code.
              
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
              (-[WebBaseNetscapePluginView sendActivateEvent:]):
              (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
              (-[WebBaseNetscapePluginView stopTimers]):
              (-[WebBaseNetscapePluginView restartTimers]):
              (-[WebBaseNetscapePluginView setHasFocus:]):
              (-[WebBaseNetscapePluginView mouseDown:]):
              (-[WebBaseNetscapePluginView mouseUp:]):
              (-[WebBaseNetscapePluginView mouseEntered:]):
              (-[WebBaseNetscapePluginView mouseExited:]):
              (-[WebBaseNetscapePluginView mouseDragged:]):
              (-[WebBaseNetscapePluginView keyUp:]):
              (-[WebBaseNetscapePluginView keyDown:]):
              (-[WebBaseNetscapePluginView cut:]):
              (-[WebBaseNetscapePluginView copy:]):
              (-[WebBaseNetscapePluginView paste:]):
              (-[WebBaseNetscapePluginView selectAll:]):
              (-[WebBaseNetscapePluginView start]):
              (-[WebBaseNetscapePluginView stop]):
              (-[WebBaseNetscapePluginView fini]):
              (-[WebBaseNetscapePluginView drawRect:]):
              (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
              (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
              (-[WebBaseNetscapePluginView windowBecameKey:]):
              (-[WebBaseNetscapePluginView windowResignedKey:]):
              (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
              (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
              (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
              (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
              (-[WebBaseNetscapePluginView _viewHasMoved]):
              * Plugins/WebBaseNetscapePluginViewInternal.h:
              * Plugins/WebNetscapePluginEmbeddedView.h:
              * Plugins/WebNetscapePluginEventHandler.h: Added.
              (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
              (WebNetscapePluginEventHandler::currentEventIsUserGesture):
              (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
              * Plugins/WebNetscapePluginEventHandler.mm: Added.
              (WebNetscapePluginEventHandler::create):
              * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
              (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
              (getCarbonEvent):
              (modifiersForEvent):
              (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
              (WebNetscapePluginEventHandlerCarbon::drawRect):
              (WebNetscapePluginEventHandlerCarbon::mouseDown):
              (WebNetscapePluginEventHandlerCarbon::mouseUp):
              (WebNetscapePluginEventHandlerCarbon::mouseEntered):
              (WebNetscapePluginEventHandlerCarbon::mouseExited):
              (WebNetscapePluginEventHandlerCarbon::mouseDragged):
              (WebNetscapePluginEventHandlerCarbon::mouseMoved):
              (WebNetscapePluginEventHandlerCarbon::keyDown):
              (keyMessageForEvent):
              (WebNetscapePluginEventHandlerCarbon::keyUp):
              (WebNetscapePluginEventHandlerCarbon::focusChanged):
              (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
              (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
              (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
              (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
              (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
              (WebNetscapePluginEventHandlerCarbon::startTimers):
              (WebNetscapePluginEventHandlerCarbon::stopTimers):
              (WebNetscapePluginEventHandlerCarbon::sendEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9ec98af
    • ddkilzer@apple.com's avatar
      Another BUILD FIX for ENABLE(DASHBOARD_SUPPORT) · 3bc06f75
      ddkilzer@apple.com authored
              * dom/make_names.pl: Added #if ENABLE(DASHBOARD_SUPPORT) to Dashboard code.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bc06f75
    • ddkilzer@apple.com's avatar
      Top: · e9e33f3e
      ddkilzer@apple.com authored
              BUILD FIX for ENABLE(DASHBOARD_SUPPORT)
      
              * configure.ac: Added conditional for ENABLE_DASHBOARD_SUPPORT.
      
      JavaScriptCore:
      
              BUILD FIX for ENABLE(DASHBOARD_SUPPORT)
      
              * wtf/Platform.h: Defined ENABLE(DASHBOARD_SUPPORT) to 1 only for
              PLATFORM(MAC) and PLATFORM(WIN).  Changed default to 0 for other
              ports.
      
      WebCore:
      
              BUILD FIX for ENABLE(DASHBOARD_SUPPORT)
      
              * DerivedSources.make: Removed duplication of targets for
              generating CSSPropertyNames.h and CSSValueKeywords.h.
              * GNUmakefile.am: Ditto.  Added support for ENABLE_DASHBOARD_SUPPORT.
              * WebCore.pro: Added support for ENABLE_DASHBOARD_SUPPORT.
              Made both SVG and non-SVG variables of GENERATOR 6-A use new
              DASHBOARDSUPPORTCSSPROPERTIES variable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9e33f3e
    • adachan@apple.com's avatar
      Added missing return. · 1bca9321
      adachan@apple.com authored
              * platform/win/COMPtr.h:
              (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bca9321
    • alp@webkit.org's avatar
      2008-04-29 Alp Toker <alp@nuanti.com> · 5bd11fab
      alp@webkit.org authored
              GTK+ build fix attempt following breakage in r32700 which
              conditionalised dashboard support.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bd11fab
    • mrowe@apple.com's avatar
      2008-04-29 Mark Rowe <mrowe@apple.com> · 7a3bb2a6
      mrowe@apple.com authored
              Reviewed by David Harrison.
      
              Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
      
              * WebKit.exp:
              * WebView/WebDynamicScrollBarsView.h:
              * WebView/WebDynamicScrollBarsView.m:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a3bb2a6
    • mitz@apple.com's avatar
      2008-04-29 Anatoli Papirovski <apapirovski@mac.com> · a118904f
      mitz@apple.com authored
              Reviewed by Dan Bernstein.
      
              Modified the SVG test case for RGB and RGBA parsing - mixing percentage and 
              numerical values is illegal.
      
              * svg/custom/rgbcolor-syntax.svg:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a118904f
    • aroben@apple.com's avatar
      Restore the beloved COMPtr::operator& · 59b4963b
      aroben@apple.com authored
      WebCore:
      
              Restore the beloved COMPtr::operator&
      
              * platform/win/COMPtr.h: Removed the HashTableDeletedValueType
              constructor and isHashTableDeletedValue and hashTableDeletedValue
              functions.
              (WTF::): Changed constructDeletedValue to play nicely with
              COMPtr::operator&.
      
      WebKit/win:
      
              Restore the beloved COMPtr::operator&
      
      WebKitTools:
      
              Restore the beloved COMPtr::operator&
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59b4963b
    • aroben@apple.com's avatar
      Fixed ChangeLog order · ab7a7726
      aroben@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab7a7726