1. 12 Jan, 2009 13 commits
    • dglazkov@chromium.org's avatar
      2008-01-12 Dimitri Glazkov <dglazkov@chromium.org> · 21b604ca
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=22936
              Fix uninitialized memory read error, reported by Purify.
      
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData): Added initializer for
                  m_unitsPerEm using cDefaultUnitsPerEm constant.
              * svg/SVGFontFaceElement.cpp:
              (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
                  the constant.
              * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21b604ca
    • treat@webkit.org's avatar
      Do not set fixedLayoutSize for anything other than the mainframe during · 4f74203a
      treat@webkit.org authored
      the transition as this is a page level state like the viewportSize.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f74203a
    • vestbo@webkit.org's avatar
      2009-01-12 Tor Arne Vestbø <tavestbo@trolltech.com> · 7e4c3b13
      vestbo@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Ensure that we're always notified of navigation actions for local anchors
      
              FrameLoader::checkNavigationPolicy() does not notify us if the request has
              been checked before (which happens for local anchors), but in the case of
              our clients not accepting the navigation request we do want to be notified
              again later on, so we clear the lastCheckedRequest flag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e4c3b13
    • vestbo@webkit.org's avatar
      2009-01-12 Ariya Hidayat <ariya.hidayat@trolltech.com> · c2f234f9
      vestbo@webkit.org authored
              Rubber-stamped by Tor Arne Vestbø.
      
              Build fix: use qobject_cast which does not rely on RTTI. This fixes the
              unit test when building it with a version of Qt (e.g. Qt/Embedded)
              configured without RTTI.
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c2f234f9
    • ap@webkit.org's avatar
      Update test results. · 7c9ac7c3
      ap@webkit.org authored
              * fast/dom/Window/window-properties-expected.txt: Remove appcache dynamic entries methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c9ac7c3
    • jchaffraix@webkit.org's avatar
      WebCore: · 898a61ca
      jchaffraix@webkit.org authored
      2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
      
              Reviewed by Darin Adler.
      
              Bug 22861: Turn the FontCache into a singleton
              https://bugs.webkit.org/show_bug.cgi?id=22861
      
              - Added fontCache() to get the global FontCache.
      
              - Made all the methods in FontCache instance method.
      
              - Changed FontCache:: to fontCache()-> in WebCore.
      
              * WebCore.base.exp: Now export fontCache().
              * css/CSSFontFaceSource.cpp:
              (WebCore::CSSFontFaceSource::getFontData):
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::CSSFontSelector):
              (WebCore::CSSFontSelector::~CSSFontSelector):
              (WebCore::CSSFontSelector::addFontFaceRule):
              (WebCore::fontDataForGenericFamily):
              * platform/graphics/Font.cpp:
              (WebCore::Font::glyphDataForCharacter):
              * platform/graphics/FontCache.cpp:
              (WebCore::fontCache):
              (WebCore::FontCache::FontCache):
              * platform/graphics/FontCache.h:
              * platform/graphics/FontFallbackList.cpp:
              (WebCore::FontFallbackList::FontFallbackList):
              (WebCore::FontFallbackList::invalidate):
              (WebCore::FontFallbackList::releaseFontData):
              (WebCore::FontFallbackList::fontDataAt):
              (WebCore::FontFallbackList::fontDataForCharacters):
              (WebCore::FontFallbackList::setPlatformFont):
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::~SimpleFontData):
              * platform/graphics/mac/FontCacheMac.mm:
              (WebCore::fontCacheATSNotificationCallback):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::smallCapsFontData):
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::getCJKCodePageMasks):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::containsCharacters):
      
      WebKit/mac:
      
      2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
      
              Reviewed by Darin Adler.
      
              Bug 22861: Turn the FontCache into a singleton
              https://bugs.webkit.org/show_bug.cgi?id=22861
      
              * Misc/WebCoreStatistics.mm:
              (+[WebCoreStatistics cachedFontDataCount]):
              (+[WebCoreStatistics cachedFontDataInactiveCount]):
              (+[WebCoreStatistics purgeInactiveFontData]):
              Redirected all the static calls to the global FontCache
              instance.
      
      WebKit/win:
      
      2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
      
              Reviewed by Darin Adler.
      
              Bug 22861: Turn the FontCache into a singleton
              https://bugs.webkit.org/show_bug.cgi?id=22861
      
              * WebCoreStatistics.cpp:
              (WebCoreStatistics::cachedFontDataCount):
              (WebCoreStatistics::cachedFontDataInactiveCount):
              (WebCoreStatistics::purgeInactiveFontData):
              Redirected all the static calls to the global FontCache
              instance.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      898a61ca
    • hausmann@webkit.org's avatar
      2009-01-12 Simon Hausmann <simon.hausmann@nokia.com> · 4356d8e3
      hausmann@webkit.org authored
              Rubber-stamped by Tor Arne Vestbø.
      
              When the QWebView is disabled context menus implemented in JavaScript should not pop up.
      
              Just like in QWidget::event() we have to check for the disabled state and
              ignore context menu events.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4356d8e3
    • hausmann@webkit.org's avatar
      2009-01-12 Simon Hausmann <simon.hausmann@nokia.com · f3604d90
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Fix QWebView appearance when showed uninitialized without page.
      
              Only set WA_OpaquePaintEvent if we have a page set that will actually
              paint the entire contents, otherwise the optimization does not apply
              as we do not have a paintEvent() implementation and Qt has to fill the
              view with its default background instead.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3604d90
    • vestbo@webkit.org's avatar
      2009-01-11 Ariya Hidayat <ariya.hidayat@trolltech.com> · e861dcdd
      vestbo@webkit.org authored
              Rubber-stamped by Tor Arne Vestbø.
      
              Do not create a QVariant from QObject* directly, use the
              template-specialized function.
      
              * tests/qwebframe/tst_qwebframe.cpp:
              (MyQObject::myOverloadedSlot):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e861dcdd
    • darin@apple.com's avatar
      WebCore: · d88cb6b4
      darin@apple.com authored
      2009-01-11  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
              https://bugs.webkit.org/show_bug.cgi?id=23247
      
              Also fix problems where partially parsed paths will still have an effect
              rather than failing parsing and being ignored.
      
              Test: dom/path-segments.html
      
              * platform/graphics/Path.h:
              (WebCore::Path::swap): Added.
      
              * svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
              (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
              (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
              parsing fails.
              (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
              not directly into the segment list.
              (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
              (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
              (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
              (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
              (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
              (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
              (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
              (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
              (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
      
              * svg/SVGPathSegCurvetoCubicSmooth.h:
              (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
              Set y2 to y2, not to y.
      
      WebKitTools:
      
      2009-01-11  Darin Adler  <darin@apple.com>
      
              * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
              directory that aren't using standard wrappers.
      
      LayoutTests:
      
      2009-01-11  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
              https://bugs.webkit.org/show_bug.cgi?id=23247
      
              Also fix problems where partially parsed paths will still have an effect
              rather than failing parsing and being ignored.
      
              Renamed the path-parser.html test to fuzz-path-parser.html, since it's a fuzz test,
              to make room for a non-fuzz test of the path parser.
      
              * platform/mac/svg/custom/path-bad-data-expected.txt: Updated results, since the old
              ones were based on incorrect path parsing behavior.
      
              * svg/dom/fuzz-path-parser-expected.txt: Copied from svg/dom/path-parser-expected.txt.
              Also updated because the parser no longer tolerates extra characters at the end of the
              string, which it was doing by accident.
              * svg/dom/fuzz-path-parser.html: Copied from svg/dom/path-parser.html.
      
              * svg/dom/path-parser-expected.txt: Replaced fuzz test results with new test results.
              * svg/dom/path-parser.html: Replaced fuzz test with a new test.
              * svg/dom/path-segments-expected.txt: Added.
              * svg/dom/path-segments.html: Added.
      
              * svg/dom/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
      
              * svg/dom/resources/path-parser.js: Added. Mostly, this test shows that we are
              processing the path while parsing it, which is a bug. This test would be much more
              useful if that was fixed. But it also shows that we were incorrectly tolerating
              extra characters after the path, which is now fixed.
      
              * svg/dom/resources/path-segments.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d88cb6b4
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · faced26e
      darin@apple.com authored
              Reviewed by Oliver Hunt.
      
              Bug 23102: turn on unused parameter warnings in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=23102
      
              Fourth step: Remove arguments entirely in the many cases where they are not
              needed at all. This step is a little less mechanical than the earlier ones.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
              the regular expression, since we already specify a-zA-Z in our expression.
      
              * dom/Document.cpp:
              (WebCore::Document::databaseThread): Don't pass in the document when creating
              a DatabaseThread.
      
              * dom/Element.cpp:
              (WebCore::Element::createRareData): Don't pass the element when creating an
              ElementRareData.
              (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
              (WebCore::Element::recalcStyle): Ditto.
      
              * dom/ElementRareData.h: Remove the unused Element* from the constructor and
              the resetComputedStyle function.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
              (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
              (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
              * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
      
              * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
              start and end arguments.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
              and end to pushDownTextDecorationStyleAroundNode.
      
              * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
              unused start and end arguments from pushDownTextDecorationStyleAroundNode.
      
              * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
      
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute): Removed unused Document* argument.
              (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
      
              * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
      
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove): Removed unused DragData argument.
              (WebCore::DragController::performDrag): Call concludeEditDrag rather than
              concludeDrag.
              (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
              (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
              should only be called for edit drags. Removed the action mask argument. Also
              changed dragIsMove call sites to not pass dragData.
      
              * page/DragController.h: Updated for above changes and tweaked comment format.
      
              * page/Frame.cpp:
              (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
      
              * page/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetHeadingLevel): Removed unused object argument.
              (AXAttributedStringAppendText): Ditto.
              (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
      
              * page/mac/FrameMac.mm:
              (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * platform/graphics/SegmentedFontData.cpp:
              (WebCore::SegmentedFontData::containsCharacter): Added.
              (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
              instead of just the first one, using containsCharacter.
      
              * platform/graphics/SegmentedFontData.h: Made more members private.
              Added containsCharacter function member.
      
              * platform/mac/DragImageMac.mm:
              (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
              DragImageRef for clarity, since this is platform-specific code.
              (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
              variable warning.
              (WebCore::scaleDragImage): Ditto.
              (WebCore::dissolveDragImageToFraction): Ditto.
              (WebCore::createDragImageFromImage): Ditto.
              (WebCore::createDragImageIconForCachedImage): Ditto.
      
              * platform/mac/WebFontCache.mm:
              (acceptableChoice): Removed the unused weight-related arguments.
              (betterChoice): Ditto.
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
      
              * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
              because we'd rather get a link error rather than a runtime error if we use it
              for anything, and right now it's not used.
      
              * platform/text/RegularExpression.cpp: Removed unused private data,
              including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
              and lastMatchPos. Made the RegularExpression::Private::regex be private
              and use an accessor function to get at it.
              (WebCore::RegularExpression::RegularExpression): Removed the const char* version
              of the constructor because it's not any more efficient. Changed the boolean
              constructor argument to use TextCaseSensitivity instead to make it less likely
              we'll use it wrong.
              (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
              just use plain old assignment on it. The only reason we do this instead of using
              the compiler generated assignment operator is that we want the Private structure
              to be internal to the .cpp file.
              (WebCore::RegularExpression::match): Added a null check so we won't crash if
              we fail to compile the regular expression. Removed the code to handle multiple
              match strings, since that was unused.
      
              * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
              TextCaseSensitivity and not have a default value. Removed the default constructor,
              and the pattern, match, and pos functions.
      
              * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
              Page.h, because we should eventually use it in all the places where we have
              an argument to control case sensitivity, starting with the functions in this
              class.
      
              * platform/text/mac/ShapeArabic.c:
              (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
              this is code borrowed from ICU, this seems like a simple safe change to make.
              (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
      
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::RenderPath): Removed the unused style argument.
              Also removed the type check. The argument already has the correct type,
              so it's not helpful to upcast it and then check its type again, unless
              we have some reason to believe the type is not reliable. And we don't.
      
              * rendering/RenderPath.h: Removed the RenderStyle* argument to the
              constructor. Also removed the explicit declaration of the destructor.
              It's not helpful or needed.
      
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
              make it clear that just returning an empty rect is not a good implementation.
              Removed the argument names to get rid of the warning.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::printBorderStyle): Removed the unused RenderObject argument.
              (WebCore::operator<<): Updated for the change to printBorderStyle function.
      
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
              * storage/DatabaseThread.h: Ditto.
      
              * storage/LocalStorage.cpp:
              (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
              * storage/LocalStorage.h: Ditto.
      
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
              code location to dispatchGenericEvent.
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::dispatchEvent): Ditto.
      
              * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
              (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
              the RenderPath constructor.
      
              * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
      
              * xml/XSLTProcessor.cpp:
              (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
              (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faced26e
    • ap@webkit.org's avatar
      2009-01-11 David Levin <levin@chromium.org> · e1016fc0
      ap@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=23245
      
              Add initializeThreading to key places in JS API to ensure that
              UString is properly initialized.
      
              * API/JSContextRef.cpp:
              (JSContextGroupCreate):
              (JSGlobalContextCreate):
              * API/JSObjectRef.cpp:
              (JSClassCreate):
              * API/JSStringRef.cpp:
              (JSStringCreateWithCharacters):
              (JSStringCreateWithUTF8CString):
              * API/JSStringRefCF.cpp:
              (JSStringCreateWithCFString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1016fc0
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 0a293b81
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=23165
              Disable application cache dynamic entries support.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a293b81
  2. 11 Jan, 2009 27 commits
    • darin@apple.com's avatar
      2009-01-11 David Levin <levin@chromium.org> · 3e2f9798
      darin@apple.com authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=23175
      
              Separate out BaseString information from UString::Rep and make all baseString access go through
              a member function, so that it may be used for something else (in the future) in the BaseString
              case.
      
              * runtime/SmallStrings.cpp:
              (JSC::SmallStringsStorage::rep):
              (JSC::SmallStringsStorage::SmallStringsStorage):
              (JSC::SmallStrings::SmallStrings):
              (JSC::SmallStrings::mark):
              Adjust to account for the changes in UString and put the UString in place in
              SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.
      
              * runtime/SmallStrings.h:
              * runtime/UString.cpp:
              (JSC::initializeStaticBaseString):
              (JSC::initializeUString):
              (JSC::UString::Rep::create):
              (JSC::UString::Rep::destroy):
              (JSC::UString::Rep::checkConsistency):
              (JSC::expandCapacity):
              (JSC::UString::expandPreCapacity):
              (JSC::concatenate):
              (JSC::UString::append):
              (JSC::UString::operator=):
              * runtime/UString.h:
              (JSC::UString::Rep::baseIsSelf):
              (JSC::UString::Rep::setBaseString):
              (JSC::UString::Rep::baseString):
              (JSC::UString::Rep::):
              (JSC::UString::Rep::null):
              (JSC::UString::Rep::empty):
              (JSC::UString::Rep::data):
              (JSC::UString::cost):
              Separate out the items out used by base strings from those used in Rep's that only
              point to base strings.  (This potentially saves 24 bytes per Rep.)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e2f9798
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · 15b09546
      darin@apple.com authored
              * fast/frames/frame-deep-nested-resize-expected.txt: This time for sure.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15b09546
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · 81b508cb
      darin@apple.com authored
              Fix failure of new test seen on buildbots.
      
              * fast/frames/frame-deep-nested-resize-expected.txt: Updated newlines to
              match what DumpRenderTree generates on Mac. I believe Adam generated his
              results under Qt DumpRenderTree. If so, then the Qt version will need to
              change to match the Mac version, since all the expected results were
              generated on Mac.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81b508cb
    • treat@webkit.org's avatar
    • mrowe@apple.com's avatar
      Tiger build fix. The connection parameter is still used on Tiger in this method. · 36f2397f
      mrowe@apple.com authored
      * platform/network/mac/ResourceHandleMac.mm:
      (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36f2397f
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · 62808318
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Bug 23102: turn on unused parameter warnings in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=23102
      
              Third step: Deal with cases of arguments used only in assertions.
      
              * dom/MessagePort.cpp:
              (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
              * dom/Worker.cpp:
              (WebCore::Worker::notifyFinished): Ditto.
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::notifyFinished): Ditto.
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::didReceiveData): Since loader and size are only
              used when logging, use UNUSED_PARAM when logging is disabled.
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
              argument since it's probably a tiny bit more efficient and gets rid
              of the unused argument warning.
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createInlineBox): Ditto.
              * rendering/RenderSVGInline.cpp:
              (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
              I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
              the only use for two different arguments.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
              * rendering/RenderThemeMac.mm:
              (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62808318
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · e3f0f283
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Bug 23239: improve handling of unused arguments in JavaScriptCore
              https://bugs.webkit.org/show_bug.cgi?id=23239
      
              * runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if
              so we can use this on all platforms. Changed valueOf to share the same
              function with getTime, since the contents of the two are identical. Removed
              a FIXME since the idea isn't really specific enough or helpful enough to
              need to sit here in the source code.
              (JSC::formatLocaleDate): Changed the Mac version of this function to take
              the same arguments as the non-Mac version so the caller doesn't have to
              special-case the two platforms. Also made the formatString array be const;
              before the characters were, but the array was a modifiable global variable.
              (JSC::dateProtoFuncToLocaleString): Changed to call the new unified
              version of formatLocaleDate and remove the ifdef.
              (JSC::dateProtoFuncToLocaleDateString): Ditto.
              (JSC::dateProtoFuncToLocaleTimeString): Ditto.
      
              * runtime/JSNotAnObject.cpp:
              (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the
              old UNUSED_PARAM.
      
              * runtime/RegExp.cpp:
              (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter
              is actually unused.
      
              * wtf/TCSystemAlloc.cpp:
              (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter
              is actually unused.
              (TCMalloc_SystemCommit): Changed to omit the argument names instead of using
              UNUSED_PARAM.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3f0f283
    • mitz@apple.com's avatar
      907a85ec
    • simon.fraser@apple.com's avatar
      2009-01-11 Simon Fraser <simon.fraser@apple.com> · 4a530692
      simon.fraser@apple.com authored
              Reviewed by Oliver Hunt
      
              https://bugs.webkit.org/show_bug.cgi?id=23242
      
              Fix CanvasRenderingContext2D::transform to do a pre-multiply,
              rather than a post-multiply into m_transform. This bug did not affect
              drawing, but did cause m_transform to be incorrect, which impacted
              willDraw(), and isPointInPath.
      
              Test: fast/canvas/canvas-incremental-repaint-2.html
      
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::transform):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a530692
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · 1de8ec8c
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Bug 23102: turn on unused parameter warnings in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=23102
      
              Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
              That's because you can't omit an argument name in Objective-C methods.
      
              * bindings/objc/DOMObject.mm:
              (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
              the word "unused" so we don't just start using it without removing the macro.
              * bindings/objc/WebScriptObject.mm:
              (+[WebUndefined allocWithZone:]): Ditto.
              (-[WebUndefined initWithCoder:]): Ditto.
              (-[WebUndefined encodeWithCoder:]): Ditto.
              (-[WebUndefined copyWithZone:]): Ditto.
              * page/mac/WebDashboardRegion.m:
              (-[WebDashboardRegion copyWithZone:]): Ditto.
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
              (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
              (-[WebCoreMovieObserver rateChanged:]): Ditto.
              (-[WebCoreMovieObserver sizeChanged:]): Ditto.
              (-[WebCoreMovieObserver timeChanged:]): Ditto.
              (-[WebCoreMovieObserver didEnd:]): Ditto.
              (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
              * platform/mac/ScrollbarThemeMac.mm:
              (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
              (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
              * platform/mac/SharedTimerMac.mm:
              (-[WebCorePowerNotifier didWake:]): Ditto.
              * platform/mac/WebCoreKeyGenerator.m:
              (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
              (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
              (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
              (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
              (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1de8ec8c
    • krit@webkit.org's avatar
      2009-01-11 Dirk Schulze <krit@webkit.org> · 0e7803e9
      krit@webkit.org authored
              Reviewed by Darin Adler.
      
              Move platform dependent strokeContains back to RenderPath, Path and delete
              unneeded Code in svg.
      
              RenderPath clean-up for strokeContains
              [https://bugs.webkit.org/show_bug.cgi?id=22957]
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/Path.h:
              * platform/graphics/cairo/PathCairo.cpp:
              (WebCore::Path::strokeContains):
              * platform/graphics/cg/PathCG.cpp:
              (WebCore::Path::strokeContains):
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::strokeContains):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::strokeContains):
              * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
              * svg/graphics/cg/CgSupport.cpp: Removed.
              * svg/graphics/cg/CgSupport.h: Removed.
              * svg/graphics/cg/RenderPathCg.cpp: Removed.
              * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
              * svg/graphics/cg/SVGResourceMaskerCg.mm:
              * svg/graphics/qt/RenderPathQt.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e7803e9
    • zecke@webkit.org's avatar
      2009-01-11 Xan Lopez <xan@gnome.org> · 839009ed
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              Bump version to 1.1.0 since we are breaking ABI and adding new
              major features.
      
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      839009ed
    • zecke@webkit.org's avatar
      2009-01-11 Xan Lopez <xan@gnome.org> · b4d69235
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              Use NULL instead of 0 when dealing with pointers, as agreed for
              the coding style of the WebKit GTK port for its GTK+ specific
              files.
      
              * webkit/webkitwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4d69235
    • zecke@webkit.org's avatar
      2009-01-11 Xan Lopez <xan@gnome.org> · 3ef201db
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              Add padding to the class structs to avoid breaking ABI each time
              we add stuff there.
      
              * webkit/webkitnetworkrequest.h:
              * webkit/webkitwebbackforwardlist.h:
              * webkit/webkitwebhistoryitem.h:
              * webkit/webkitwebnavigationaction.h:
              * webkit/webkitwebpolicydecision.h:
              * webkit/webkitwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ef201db
    • zecke@webkit.org's avatar
      [GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h · 36d59a64
      zecke@webkit.org authored
      make distcheck pass by adding JSWorkerContextBase.lut.h to the
      CLEANFILES that will be cleaned on a make distclean.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36d59a64
    • oliver@apple.com's avatar
      build fix · ad17c705
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad17c705
    • oliver@apple.com's avatar
      Bug 23128: get/put_by_val need to respecialise in the face of ByteArray · 9de3c6fb
      oliver@apple.com authored
      Reviewed by Darin Adler and Anders Carlsson
      
      Restructure the code slightly, and add comments per Darin's suggestions
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9de3c6fb
    • oliver@apple.com's avatar
      Fix exception check for string indexing · 7bb5031e
      oliver@apple.com authored
      Reviewed by Anders Carlsson.
      
      Whoops, I accidentally removed an exception check from fast the
      fast path for string indexing when i originally landed the
      byte array logic.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bb5031e
    • oliver@apple.com's avatar
      attempt to fix win build · 2d40c696
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d40c696
    • oliver@apple.com's avatar
      Bug 23128: get/put_by_val need to respecialise in the face of ByteArray · c73808b0
      oliver@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=23128>
      
      Reviewed by Anders Carlsson.
      
      Fairly simple patch, add specialised versions of cti_op_get/put_by_val
      that assume ByteArray, thus avoiding a few branches in the case of bytearray
      manipulation.
      
      No effect on SunSpider.  15% win on the original testcase.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c73808b0
    • ap@webkit.org's avatar
      2009-01-11 Zalan Bujtas <zbujtas@gmail.com> · 72b24786
      ap@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=23235
              Build fix for non-VIDEO builds.
      
              * rendering/RenderTheme.cpp:
              * rendering/RenderTheme.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72b24786
    • ap@webkit.org's avatar
      Try to fix Windows build. · 914cddbf
      ap@webkit.org authored
              * wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in
              DateMath.cpp, with constant definition in DateTime.h)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      914cddbf
    • ap@webkit.org's avatar
      2009-01-11 Alexey Proskuryakov <ap@webkit.org> · f28dbd60
      ap@webkit.org authored
              Try to fix Windows build.
      
              * wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f28dbd60
    • ap@webkit.org's avatar
      2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu> · 25169756
      ap@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19287
              return value of malloc() is not checked in npruntime.cpp
      
              Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
              (like in fastMalloc).
         
              * bridge/npruntime.cpp:
              (_NPN_GetStringIdentifier):
              (_NPN_GetIntIdentifier):
              (NPN_InitializeVariantWithStringCopy):
              (_NPN_CreateObject):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25169756
    • ap@webkit.org's avatar
      2009-01-11 Glenn Wilson <gwilson@google.com> · af67f5f3
      ap@webkit.org authored
              Reviewed by Darin Adler.
      
              Changes radio buttons so they can be 'checked' even if they
              don't have the name attribute set.
      
              See https://bugs.webkit.org/show_bug.cgi?id=21534
      
              Test: fast/html/select-unnamed-radio.html
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::preDispatchEventHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af67f5f3
    • ap@webkit.org's avatar
      2009-01-11 tony chang <tony@chromium.org> · 32b74007
      ap@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove svn:eol-style native from some utf16 files so
              windows-svn doesn't alter them on checkout.
      
              * fast/xsl/xslt-enc16.xml: remove svn:eol-style
              * fast/xsl/xslt-enc16to16.xml: remove svn:eol-style
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32b74007
    • ap@webkit.org's avatar
      Fix ChangeLog date. · 71afd884
      ap@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71afd884