1. 17 Sep, 2013 1 commit
    • enrica@apple.com's avatar
      Upstream changes to WebHTMLConverter to support HTML · 2194a86a
      enrica@apple.com authored
      to NSAttributedString conversion on both iOS and OS X.
      
      Reviewed by Benjamin Poulain.
      
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      (WebDefaultFont):
      (_fontForNameAndSize):
      (+[WebHTMLConverter defaultParagraphStyle]):
      (-[WebHTMLConverter _computedStyleForElement:]):
      (-[WebHTMLConverter _specifiedStyleForElement:]):
      (-[WebHTMLConverter _computedStringForNode:property:]):
      (-[WebHTMLConverter _stringForNode:property:]):
      (-[WebHTMLConverter _getComputedFloat:forNode:property:]):
      (-[WebHTMLConverter _getFloat:forNode:property:]):
      (_NSFirstPathForDirectoriesInDomains):
      (_NSSystemLibraryPath):
      (-[WebHTMLConverter _webKitBundle]):
      (_colorForRGBColor):
      (_shadowForShadowStyle):
      (-[WebHTMLConverter _elementIsBlockLevel:]):
      (-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
      (-[WebHTMLConverter _computedColorForNode:property:]):
      (-[WebHTMLConverter _colorForNode:property:]):
      (-[WebHTMLConverter _computedAttributesForElement:]):
      (-[WebHTMLConverter _attributesForElement:]):
      (-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
      (-[WebHTMLConverter _newLineForElement:]):
      (-[WebHTMLConverter _newTabForElement:]):
      (-[WebHTMLConverter _WebMessageDocumentClass]):
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (-[WebHTMLConverter _addQuoteForElement:opening:level:]):
      (-[WebHTMLConverter _addValue:forElement:]):
      (-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
      (_dateForString):
      (_colCompare):
      (-[WebHTMLConverter _processMetaElementWithName:content:]):
      (-[WebHTMLConverter _processHeadElement:]):
      (-[WebHTMLConverter _enterElement:tag:display:embedded:]):
      (-[WebHTMLConverter _addTableForElement:]):
      (-[WebHTMLConverter _addTableCellForElement:]):
      (-[WebHTMLConverter _processElement:tag:display:depth:]):
      (-[WebHTMLConverter _addMarkersToList:range:]):
      (-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
      (-[WebHTMLConverter _processText:]):
      (-[WebHTMLConverter _traverseNode:depth:embedded:]):
      (-[WebHTMLConverter _traverseFooterNode:depth:]):
      (-[WebHTMLConverter _loadFromDOMRange]):
      (-[WebHTMLConverter dealloc]):
      (-[WebHTMLConverter init]):
      (-[WebHTMLConverter initWithDOMRange:]):
      (-[WebHTMLConverter attributedString]):
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2194a86a
  2. 12 Sep, 2013 1 commit
    • andersca@apple.com's avatar
      SharedBuffer::createNSData should return a RetainPtr<NSData> · ac6917cd
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121237
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      This makes memory management cleared and fixes a leak in PDFDocumentImage::createPDFDocument.
      We use a RetainPtr subclass as a stopgap measure to prevent code that does [buffer->createNSData() autorelease]
      from compiling and crashing due to the NSData object being overreleased.
      
      * loader/ResourceBuffer.h:
      * loader/mac/ResourceBuffer.mm:
      (WebCore::ResourceBuffer::createNSData):
      * platform/SharedBuffer.h:
      (WebCore::SharedBuffer::NSDataRetainPtr::NSDataRetainPtr):
      * platform/graphics/mac/PDFDocumentImageMac.mm:
      (WebCore::PDFDocumentImage::createPDFDocument):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (fileWrapperForURL):
      * platform/mac/PasteboardMac.mm:
      (WebCore::fileWrapper):
      (WebCore::Pasteboard::read):
      (WebCore::documentFragmentWithRTF):
      (WebCore::fragmentFromWebArchive):
      * platform/mac/PlatformPasteboardMac.mm:
      (WebCore::PlatformPasteboard::setBufferForType):
      * platform/mac/SharedBufferMac.mm:
      (WebCore::SharedBuffer::createNSData):
      
      Source/WebKit/mac:
      
      Update for WebCore changes. This also fixes a leak where we'd create an NSFileWrapper from NSData but never release the data.
      
      * WebView/WebDataSource.mm:
      (-[WebDataSource data]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation documentSource]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
      * WebView/WebResource.mm:
      (-[WebResource encodeWithCoder:]):
      (-[WebResource data]):
      
      Source/WebKit2:
      
      Update for WebCore changes.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView writeSelectionToPasteboard:types:]):
      (-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
      (-[WKView namesOfPromisedFilesDroppedAtDestination:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac6917cd
  3. 30 Aug, 2013 1 commit
  4. 15 Aug, 2013 1 commit
    • andersca@apple.com's avatar
      <https://webkit.org/b/119859> Frame::loader() should return a reference · df550b96
      andersca@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::willOpenSocketStream):
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::updateTitle):
      (WebCore::Document::open):
      (WebCore::Document::explicitClose):
      (WebCore::Document::implicitClose):
      (WebCore::Document::user...
      df550b96
  5. 25 Jul, 2013 1 commit
    • weinig@apple.com's avatar
      -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not... · 212f5170
      weinig@apple.com authored
      -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
      https://bugs.webkit.org/show_bug.cgi?id=119099
      <rdar://problem/13439291>
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore: 
      
      Tests:
          API Test: AttributedStringTest_Strikethrough
      
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      Set the NSStrikethroughStyleAttributeName attribute when text-decoration: line-through is seen.
      
      Tools: 
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/mac/AttributedString.mm:
      (TestWebKitAPI::attributedString):
      (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
      (TestWebKitAPI::AttributedStringTest_CustomFont::url):
      (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
      (TestWebKitAPI::TEST_F):
      (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
      (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
      (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
      * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
      Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
      to make adding more easier in the future.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212f5170
  6. 08 Jul, 2013 1 commit
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLTableElement for code cleanup · b44a6811
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118393
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts is/toHTMLTableElement.
      This also helps out to reduce duplicated use of static_cast.
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::isDataTable):
      (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
      (WebCore::AccessibilityTable::title):
      * accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
      (webkitAccessibleTableGetCaption):
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (webkitAccessibleGetDescription):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::adjustRenderStyle):
      * dom/Position.cpp:
      (WebCore::endsOfNodeAreVisuallyDistinctPositions):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::handleGeneralDelete):
      * editing/InsertLineBreakCommand.cpp:
      (WebCore::InsertLineBreakCommand::doApply):
      * editing/htmlediting.cpp:
      (WebCore::isNonTableCellHTMLBlockElement):
      * editing/markup.cpp:
      (WebCore::ancestorToRetainStructureAndAppearanceForBlock):
      * html/FTPDirectoryDocument.cpp:
      (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
      (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::rendererIsNeeded):
      * html/HTMLTableElement.h:
      (WebCore::isHTMLTableElement):
      (WebCore::toHTMLTableElement):
      * html/HTMLTablePartElement.cpp:
      (WebCore::HTMLTablePartElement::findParentTable):
      * html/HTMLTableRowElement.cpp:
      (WebCore::HTMLTableRowElement::rowIndex):
      * html/HTMLTableRowsCollection.cpp:
      (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
      (WebCore::HTMLTableRowsCollection::virtualItemAfter):
      * html/parser/HTMLElementStack.cpp:
      (WebCore::HTMLNames::isScopeMarker):
      (WebCore::HTMLNames::isTableScopeMarker):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
      (WebCore::HTMLTreeBuilder::processCharacterBuffer):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _computedStringForNode:property:]):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::offsetParent):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
      (WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b44a6811
  7. 28 Jun, 2013 1 commit
    • kangil.han@samsung.com's avatar
      Adopt is/toHTMLImageElement for code cleanup · 2489e830
      kangil.han@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118182
      
      Reviewed by Andreas Kling.
      
      To enhance readability, this patch adopts is/toHTMLImageElement.
      This also helps out to reduce duplicated use of static_cast.
      
      Source/WebCore:
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::isNativeImage):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::url):
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::isReachableFromDOM):
      * bridge/qt/qt_pixmapruntime.cpp:
      (JSC::Bindings::assignToHTMLImageElement):
      (JSC::Bindings::QtPixmapRuntime::toQt):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::setDragImage):
      * dom/Node.cpp:
      (WebCore::Node::enclosingLinkEventParentOrSelf):
      * editing/Editor.cpp:
      (WebCore::imageElementFromImageDocument):
      * html/HTMLAnchorElement.cpp:
      (WebCore::appendServerMapMousePosition):
      * html/HTMLImageElement.h:
      (WebCore::isHTMLImageElement):
      (WebCore::toHTMLImageElement):
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::imageElement):
      * html/HTMLNameCollection.cpp:
      (WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
      (WebCore::DocumentNameCollection::nodeMatches):
      * page/DragController.cpp:
      (WebCore::DragController::draggableElement):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeFrame):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::altDisplayString):
      (WebCore::HitTestResult::absoluteImageURL):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintIntoRect):
      (WebCore::RenderImage::imageMap):
      (WebCore::RenderImage::updateAltText):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::shouldRespectImageOrientation):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      (BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
      (BlackBerry::WebKit::WebPage::blockZoom):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::isElementClickable):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2489e830
  8. 22 May, 2013 1 commit
    • bruno.abinader@basyskom.com's avatar
      [css] Update ETextDecorations enum to TextDecorations · 8d67e0a9
      bruno.abinader@basyskom.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116581
      
      Reviewed by Andreas Kling.
      
      Currently, ETextDecorations enum uses a C-like coding style for its
      enumeration values, as well as a 'E' prefix that surely had some meaning
      in the past, but not nowadays.
      
      No behavior changes, covered by existing tests.
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::hasPlainText):
      (WebCore::AccessibilityRenderObject::hasUnderline):
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (getAttributeSetForAccessibilityObject):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (AXAttributeStringSetStyle):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (AXAttributeStringSetStyle):
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::renderTextDecorationFlagsToCSSValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::operator TextDecoration):
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyTextDecoration::applyValue):
      (WebCore::ApplyPropertyTextDecoration::createHandler):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontAttributesForSelectionStart):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::paintDecoration):
      * rendering/InlineTextBox.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::getTextDecorationColors):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      (WebCore::operator|):
      (WebCore::operator|=):
      * rendering/style/StyleVisualData.h:
      (StyleVisualData):
      * rendering/svg/SVGInlineTextBox.cpp:
      (WebCore::SVGInlineTextBox::paint):
      (WebCore::positionOffsetForDecoration):
      (WebCore::thicknessForDecoration):
      (WebCore::findRenderObjectDefininingTextDecoration):
      (WebCore::SVGInlineTextBox::paintDecoration):
      (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
      * rendering/svg/SVGInlineTextBox.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d67e0a9
  9. 27 Apr, 2013 1 commit
    • darin@apple.com's avatar
      Move from constructor and member function adoptCF/NS to free function adoptCF/NS. · 051fed91
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=115307
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      * heap/HeapTimer.cpp:
      (JSC::HeapTimer::HeapTimer):
      * runtime/VM.cpp:
      (JSC::enableAssembler):
      Use adoptCF free function.
      
      Source/WebCore:
      
      This change was done by a global replace followed by compiling and inspecting for
      cases that needed to be tweaked by hand.
      
      * accessibility/ios/AXObjectCacheIOS.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::attachWrapper):
      * bridge/objc/objc_class.mm:
      (JSC::Bindings::ObjcClass::methodNamed):
      (JSC::Bindings::ObjcClass::fieldNamed):
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcField::ObjcField):
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::fontAttributesForSelectionStart):
      * history/cf/HistoryPropertyList.cpp:
      (WebCore::HistoryPropertyListWriter::releaseData):
      * html/HTMLMediaElement.cpp:
      (WebCore::createFileURLForApplicationCacheResource):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::createPropertyListRepresentation):
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::rawDataRepresentation):
      * loader/archive/cf/LegacyWebArchiveMac.mm:
      (WebCore::LegacyWebArchive::createPropertyListRepresentation):
      * loader/mac/ResourceLoaderMac.mm:
      (WebCore::ResourceLoader::willCacheResponse):
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::userPrefersCaptions):
      (WebCore::CaptionUserPreferencesMac::userPrefersSubtitles):
      (WebCore::CaptionUserPreferencesMac::captionsWindowCSS):
      (WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS):
      (WebCore::CaptionUserPreferencesMac::captionsTextColor):
      (WebCore::CaptionUserPreferencesMac::captionsDefaultFontCSS):
      (WebCore::CaptionUserPreferencesMac::preferredLanguages):
      (WebCore::trackDisplayName):
      * platform/Language.cpp:
      (WebCore::displayNameForLanguageLocale):
      * platform/LocalizedStrings.cpp:
      (WebCore::contextMenuItemTagSearchWeb):
      (WebCore::imageTitle):
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeSupportedImageMIMETypes):
      (WebCore::initializeSupportedImageMIMETypesForEncoding):
      * platform/audio/mac/AudioFileReaderMac.cpp:
      (WebCore::AudioFileReader::AudioFileReader):
      * platform/cf/KURLCFNet.cpp:
      (WebCore::KURL::fileSystemPath):
      * platform/cf/SharedBufferCF.cpp:
      (WebCore::SharedBuffer::maybeTransferPlatformData):
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::setContentsToImage):
      * platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
      (WebCore::LayerFlushScheduler::schedule):
      * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
      (PlatformCAAnimation::PlatformCAAnimation):
      * platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
      (PlatformCAFilters::filterValueForOperation):
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::PlatformCALayer):
      (PlatformCALayer::addAnimationForKey):
      (PlatformCALayer::setBackgroundColor):
      (PlatformCALayer::setBorderColor):
      * platform/graphics/cg/BitmapImageCG.cpp:
      (WebCore::BitmapImage::checkForSolidColor):
      (WebCore::BitmapImage::getCGImageArray):
      * platform/graphics/cg/ColorCG.cpp:
      (WebCore::cachedCGColor):
      * platform/graphics/cg/GraphicsContext3DCG.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::applyStrokePattern):
      (WebCore::GraphicsContext::applyFillPattern):
      (WebCore::GraphicsContext::setURLForRect):
      * platform/graphics/cg/ImageBufferCG.cpp:
      (WebCore::createIOSurface):
      (WebCore::ImageBuffer::ImageBuffer):
      (WebCore::ImageBuffer::copyImage):
      (WebCore::ImageBuffer::draw):
      (WebCore::ImageBuffer::clip):
      (WebCore::ImageBuffer::putByteArray):
      (WebCore::CGImageEncodeToData):
      (WebCore::CGImageToDataURL):
      (WebCore::ImageBuffer::toDataURL):
      (WebCore::ImageDataToDataURL):
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      (WebCore::ImageBufferData::getData):
      (WebCore::ImageBufferData::putData):
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::Image::imageWithColorSpace):
      (WebCore::Image::drawPattern):
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::ImageSource::setData):
      (WebCore::ImageSource::isSizeAvailable):
      (WebCore::ImageSource::frameSizeAtIndex):
      (WebCore::ImageSource::orientationAtIndex):
      (WebCore::ImageSource::getHotSpot):
      (WebCore::ImageSource::repetitionCount):
      (WebCore::ImageSource::createFrameAtIndex):
      (WebCore::ImageSource::frameDurationAtIndex):
      * platform/graphics/cg/PDFDocumentImage.cpp:
      (WebCore::PDFDocumentImage::dataChanged):
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::createScratchContext):
      (WebCore::Path::contains):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::FontPlatformData):
      (WebCore::FontPlatformData::setFont):
      (WebCore::createFeatureSettingDictionary):
      (WebCore::cascadeToLastResortFontDescriptor):
      (WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor):
      (WebCore::FontPlatformData::ctFont):
      (WebCore::FontPlatformData::description):
      * platform/graphics/gpu/mac/DrawingBufferMac.mm:
      (WebCore::DrawingBuffer::DrawingBuffer):
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      (-[WebCascadeList objectAtIndex:]):
      (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
      (WebCore::GlyphPage::fill):
      * platform/graphics/mac/GraphicsContext3DMac.mm:
      (WebCore::GraphicsContext3D::GraphicsContext3D):
      * platform/graphics/mac/GraphicsContextMac.mm:
      (WebCore::GraphicsContext::drawFocusRing):
      (WebCore::linearRGBColorSpaceRef):
      * platform/graphics/mac/ImageMac.mm:
      (WebCore::BitmapImage::getTIFFRepresentation):
      (WebCore::BitmapImage::getNSImage):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
      (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
      (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
      (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
      (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
      (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
      (WebCore::addFileTypesToCache):
      * platform/graphics/mac/SimpleFontDataCoreText.cpp:
      (WebCore::SimpleFontData::getCFStringAttributes):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::fontHasVerticalGlyphs):
      (WebCore::SimpleFontData::getCompositeFontReferenceFontData):
      (WebCore::SimpleFontData::platformCharWidthInit):
      (WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
      * platform/graphics/mac/WebGLLayer.mm:
      (-[WebGLLayer copyImageSnapshotWithColorSpace:]):
      * platform/mac/ContentFilterMac.mm:
      (WebCore::ContentFilter::ContentFilter):
      * platform/mac/ContextMenuItemMac.mm:
      (WebCore::ContextMenuItem::ContextMenuItem):
      * platform/mac/CursorMac.mm:
      (WebCore::createCustomCursor):
      (WebCore::createNamedCursor):
      * platform/mac/DisplaySleepDisabler.cpp:
      (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
      * platform/mac/DragImageMac.mm:
      (WebCore::dissolveDragImageToFraction):
      (WebCore::createDragImageFromImage):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * platform/mac/Language.mm:
      (WebCore::httpStyleLanguageCode):
      (WebCore::platformUserPreferredLanguages):
      * platform/mac/LocalizedStringsMac.cpp:
      (WebCore::localizedString):
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::getDataSelection):
      (WebCore::Pasteboard::writeSelectionForTypes):
      (WebCore::fragmentFromWebArchive):
      * platform/mac/PlatformClockCM.mm:
      (PlatformClockCM::PlatformClockCM):
      (PlatformClockCM::initializeWithTimingSource):
      * platform/mac/PlatformPasteboardMac.mm:
      (WebCore::PlatformPasteboard::addTypes):
      (WebCore::PlatformPasteboard::setTypes):
      (WebCore::PlatformPasteboard::setPathnamesForType):
      * platform/mac/PlatformSpeechSynthesizerMac.mm:
      (WebCore::PlatformSpeechSynthesizer::speak):
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenuMac::populate):
      (WebCore::PopupMenuMac::show):
      * platform/mac/ScrollAnimatorMac.mm:
      (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
      (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
      (-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
      (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
      (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
      (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
      * platform/mac/SharedBufferMac.mm:
      (WebCore::SharedBuffer::createCFData):
      * platform/mac/WebCoreNSStringExtras.mm:
      (stringEncodingForResource):
      * platform/network/ProtectionSpace.cpp:
      (WebCore::ProtectionSpace::receivesCredentialSecurely):
      * platform/network/SynchronousLoaderClient.cpp:
      (WebCore::SynchronousLoaderClient::platformBadResponseError):
      * platform/network/cf/CredentialStorageCFNet.cpp:
      (WebCore::CredentialStorage::getFromPersistentStorage):
      * platform/network/cf/DNSCFNet.cpp:
      (WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
      * platform/network/cf/FormDataStreamCFNet.cpp:
      (WebCore::advanceCurrentStream):
      * platform/network/cf/NetworkStorageSessionCFNet.cpp:
      (WebCore::overrideCookieStorage):
      * platform/network/cf/ProxyServerCFNet.cpp:
      (WebCore::proxyAutoConfigurationResultCallback):
      (WebCore::processProxyServers):
      (WebCore::addProxyServersForURL):
      * platform/network/cf/ResourceErrorCF.cpp:
      (WebCore::ResourceError::platformLazyInit):
      (WebCore::ResourceError::cfError):
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::willSendRequest):
      (WebCore::ResourceHandle::createCFURLConnection):
      (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
      (WebCore::ResourceHandle::receivedCredential):
      (WebCore::ResourceHandle::handleDataArray):
      * platform/network/cf/ResourceRequestCFNet.cpp:
      (WebCore::setHeaderFields):
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      (WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
      (WebCore::ResourceRequest::doUpdateResourceRequest):
      (WebCore::ResourceRequest::setStorageSession):
      * platform/network/cf/ResourceResponseCFNet.cpp:
      (WebCore::ResourceResponse::cfURLResponse):
      (WebCore::ResourceResponse::platformLazyInit):
      * platform/network/cf/SocketStreamHandleCFNet.cpp:
      (WebCore::SocketStreamHandle::SocketStreamHandle):
      (WebCore::SocketStreamHandle::executePACFileURL):
      (WebCore::SocketStreamHandle::chooseProxy):
      (WebCore::SocketStreamHandle::createStreams):
      (WebCore::SocketStreamHandle::addCONNECTCredentials):
      (WebCore::SocketStreamHandle::readStreamCallback):
      (WebCore::SocketStreamHandle::writeStreamCallback):
      (WebCore::SocketStreamHandle::reportErrorToClient):
      * platform/network/mac/AuthenticationMac.mm:
      (WebCore::mac):
      (WebCore::AuthenticationChallenge::setAuthenticationClient):
      * platform/network/mac/CookieJarMac.mm:
      (WebCore::filterCookies):
      * platform/network/mac/NetworkStateNotifierMac.cpp:
      (WebCore::NetworkStateNotifier::updateState):
      (WebCore::NetworkStateNotifier::NetworkStateNotifier):
      * platform/network/mac/ResourceErrorMac.mm:
      (WebCore::createNSErrorFromResourceErrorBase):
      (WebCore::ResourceError::nsError):
      * platform/network/mac/ResourceHandleMac.mm:
      (WebCore::ResourceHandle::createNSURLConnection):
      * platform/network/mac/ResourceRequestMac.mm:
      (WebCore::ResourceRequest::updateNSURLRequest):
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      (WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
      (WebCore::ResourceRequest::setStorageSession):
      * platform/network/mac/ResourceResponseMac.mm:
      (WebCore::ResourceResponse::initNSURLResponse):
      (WebCore::ResourceResponse::nsURLResponse):
      (WebCore::ResourceResponse::platformLazyInit):
      * platform/network/mac/UTIUtilities.mm:
      (WebCore::mimeTypeFromUTITree):
      * platform/network/mac/WebCoreURLResponse.mm:
      (WebCore::adjustMIMETypeIfNecessary):
      * platform/text/cf/HyphenationCF.cpp:
      (WebCore::::createValueForNullKey):
      (WebCore::lastHyphenLocation):
      * platform/text/mac/HyphenationMac.mm:
      (WebCore::::createValueForKey):
      (WebCore::lastHyphenLocation):
      * platform/text/mac/LocaleMac.mm:
      (WebCore::determineLocale):
      (WebCore::LocaleMac::LocaleMac):
      (WebCore::LocaleMac::initializeLocaleData):
      * platform/text/mac/TextBreakIteratorInternalICUMac.mm:
      (WebCore::textBreakLocalePreference):
      (WebCore::canonicalLanguageIdentifier):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::RenderThemeMac):
      (WebCore::RenderThemeMac::levelIndicatorFor):
      (WebCore::RenderThemeMac::paintMenuListButtonGradients):
      (WebCore::RenderThemeMac::paintSliderTrack):
      (WebCore::RenderThemeMac::popupButton):
      (WebCore::RenderThemeMac::search):
      (WebCore::RenderThemeMac::searchMenuTemplate):
      (WebCore::RenderThemeMac::sliderThumbHorizontal):
      (WebCore::RenderThemeMac::sliderThumbVertical):
      (WebCore::RenderThemeMac::textField):
      Use adoptNS and adoptCF free functions.
      
      Source/WebKit/cf:
      
      * WebCoreSupport/WebInspectorClientCF.cpp:
      (populateSetting): Use adoptCF.
      
      Source/WebKit/mac:
      
      This change was done by a global replace followed by compiling and inspecting for
      cases that needed to be tweaked by hand.
      
      * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
      (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
      * Misc/WebNSFileManagerExtras.mm:
      (-[NSFileManager _webkit_startupVolumeName]):
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
      * Plugins/Hosted/NetscapePluginHostManager.mm:
      (WebKit::NetscapePluginHostManager::spawnPluginHost):
      (WebKit::NetscapePluginHostManager::instantiatePlugin):
      * Plugins/Hosted/NetscapePluginHostProxy.mm:
      (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
      (WebKit::NetscapePluginHostProxy::beginModal):
      (WKPCBooleanAndDataReply):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::print):
      (WebKit::NetscapePluginInstanceProxy::snapshot):
      (WebKit::NetscapePluginInstanceProxy::status):
      (WebKit::NetscapePluginInstanceProxy::loadURL):
      (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
      (WebKit::NetscapePluginInstanceProxy::enumerate):
      (WebKit::NetscapePluginInstanceProxy::marshalValue):
      (WebKit::NetscapePluginInstanceProxy::marshalValues):
      (WebKit::NetscapePluginInstanceProxy::demarshalValue):
      (WebKit::NetscapePluginInstanceProxy::demarshalValues):
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
      (-[WebHostedNetscapePluginView createPlugin]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
      (-[WebBaseNetscapePluginView cacheSnapshot]):
      (WebKit::getAuthenticationInfo):
      * Plugins/WebBasePluginPackage.mm:
      (-[WebBasePluginPackage initWithPath:]):
      * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
      (WebNetscapePluginEventHandlerCarbon::startTimers):
      * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
      (WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
      (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
      * Plugins/WebNetscapePluginPackage.mm:
      (-[WebNetscapePluginPackage _initWithPath:]):
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::WebNetscapePluginStream):
      (WebNetscapePluginStream::deliverData):
      (WebNetscapePluginStream::deliverDataToFile):
      (WebNetscapePluginStream::didReceiveData):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView createPlugin]):
      (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
      (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
      * Storage/WebDatabaseManagerClient.mm:
      (WebDatabaseManagerClient::dispatchDidModifyOrigin):
      (WebDatabaseManagerClient::dispatchDidModifyDatabase):
      * Storage/WebStorageTrackerClient.mm:
      (WebStorageTrackerClient::dispatchDidModifyOrigin):
      * WebCoreSupport/CorrectionPanel.mm:
      (CorrectionPanel::handleAcceptedReplacement):
      * WebCoreSupport/WebApplicationCache.mm:
      (+[WebApplicationCache originsWithCache]):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::didRunInsecureContent):
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::WebInspectorClient):
      (WebInspectorClient::openInspectorFrontend):
      * WebView/WebFullScreenController.mm:
      (-[WebFullScreenController enterFullScreen:]):
      * WebView/WebPDFDocumentExtras.mm:
      (allScriptsInPDFDocument):
      * WebView/WebPreferences.mm:
      (-[WebPreferences initWithIdentifier:]):
      (-[WebPreferences initWithCoder:]):
      * WebView/WebScriptDebugger.mm:
      (WebScriptDebugger::initGlobalCallFrame):
      (WebScriptDebugger::callEvent):
      * WebView/WebView.mm:
      (-[WebView previousValidKeyView]):
      Use adoptNS and adoptCF free functions.
      
      Source/WebKit2:
      
      This change was done by a global replace followed by compiling and inspecting for
      cases that needed to be tweaked by hand.
      
      * Platform/cg/CGUtilities.cpp:
      (WebKit::paintBitmapContext):
      * Platform/mac/ModuleMac.mm:
      (WebKit::Module::load):
      (WebKit::Module::platformFunctionPointer):
      * PluginProcess/mac/PluginProcessMac.mm:
      (WebKit::PluginProcess::initializeSandbox):
      * Shared/API/c/mac/WKURLRequestNS.mm:
      (WKURLRequestCreateWithNSURLRequest):
      * Shared/API/c/mac/WKURLResponseNS.mm:
      (WKURLResponseCreateWithNSURLResponse):
      * Shared/Downloads/mac/DownloadMac.mm:
      (WebKit::Download::start):
      (WebKit::Download::startWithHandle):
      * Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
      (WebKit::ChildProcessMain):
      * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
      (WebKit::getPluginArchitecture):
      (WebKit::contentsOfPropertyListAtURL):
      (WebKit::getMIMETypesFromPluginBundle):
      (WebKit::getStringListResource):
      (WebKit::NetscapePluginModule::getPluginInfo):
      * Shared/ShareableResource.cpp:
      (WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
      * Shared/cf/ArgumentCodersCF.cpp:
      (CoreIPC::decode):
      (CoreIPC::encode):
      * Shared/cg/ShareableBitmapCG.cpp:
      (WebKit::ShareableBitmap::createGraphicsContext):
      (WebKit::ShareableBitmap::makeCGImageCopy):
      (WebKit::ShareableBitmap::makeCGImage):
      (WebKit::ShareableBitmap::createCGImage):
      * Shared/mac/ArgumentCodersMac.mm:
      (CoreIPC::decode):
      * Shared/mac/PlatformCertificateInfo.mm:
      (WebKit::PlatformCertificateInfo::dump):
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::::encodePlatformData):
      (CoreIPC::::decodePlatformData):
      * UIProcess/API/mac/FindIndicatorWindow.mm:
      (WebKit::FindIndicatorWindow::setFindIndicator):
      (WebKit::FindIndicatorWindow::startFadeOutTimerFired):
      * UIProcess/API/mac/PDFViewController.mm:
      (-[WKPDFView initWithFrame:PDFViewController:]):
      (WebKit::PDFViewController::PDFViewController):
      (WebKit::convertPostScriptDataSourceToPDF):
      (WebKit::PDFViewController::setPDFDocumentData):
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::PageClientImpl):
      (WebKit::PageClientImpl::registerEditCommand):
      (WebKit::PageClientImpl::setDragImage):
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (didFailProvisionalLoadWithErrorForFrame):
      (didFailLoadWithErrorForFrame):
      * UIProcess/API/mac/WKConnection.mm:
      (didReceiveMessage):
      * UIProcess/API/mac/WKPrintingView.mm:
      (-[WKPrintingView drawRect:]):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView browsingContextController]):
      (-[WKView _setAcceleratedCompositingModeRootLayer:]):
      (-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
      (-[WKView namesOfPromisedFilesDroppedAtDestination:]):
      (-[WKView fullScreenWindowController]):
      (-[WKView _executeSavedCommandBySelector:]):
      (-[WKView printOperationWithPrintInfo:forFrame:]):
      * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
      (WebKit::createProcess):
      * UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
      (WebKit::PluginInfoStore::pluginPathsInDirectory):
      (WebKit::PluginInfoStore::getMIMETypeForExtension):
      * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
      (WebKit::PluginProcessProxy::beginModal):
      * UIProcess/cf/WebBackForwardListCF.cpp:
      (WebKit::WebBackForwardList::createCFDictionaryRepresentation):
      * UIProcess/cf/WebPageProxyCF.cpp:
      (WebKit::WebPageProxy::sessionStateData):
      (WebKit::WebPageProxy::restoreFromSessionStateData):
      (WebKit::WebPageProxy::saveRecentSearches):
      (WebKit::WebPageProxy::loadRecentSearches):
      * UIProcess/cf/WebPreferencesCF.cpp:
      (WebKit::cfStringFromWebCoreString):
      (WebKit::setStringValueIfInUserDefaults):
      (WebKit::setBoolValueIfInUserDefaults):
      (WebKit::setUInt32ValueIfInUserDefaults):
      (WebKit::setDoubleValueIfInUserDefaults):
      (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
      (WebKit::WebPreferences::platformUpdateDoubleValueForKey):
      (WebKit::WebPreferences::platformUpdateFloatValueForKey):
      * UIProcess/mac/BackingStoreMac.mm:
      (WebKit::BackingStore::resetScrolledRect):
      (WebKit::BackingStore::backingStoreContext):
      * UIProcess/mac/CorrectionPanel.mm:
      (WebKit::CorrectionPanel::handleAcceptedReplacement):
      * UIProcess/mac/TextCheckerMac.mm:
      (WebKit::TextChecker::checkTextOfParagraph):
      (WebKit::TextChecker::updateSpellingUIWithGrammarString):
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController enterFullScreen:]):
      (-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
      (-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::platformDefaultDiskCacheDirectory):
      * UIProcess/mac/WebContextMenuProxyMac.mm:
      (WebKit::nsMenuItemVector):
      (WebKit::WebContextMenuProxyMac::populate):
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (WebKit::WebInspectorProxy::createInspectorWindow):
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      * UIProcess/mac/WebPopupMenuProxyMac.mm:
      (WebKit::WebPopupMenuProxyMac::populate):
      (WebKit::WebPopupMenuProxyMac::showPopupMenu):
      * WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
      (WebKit::InjectedBundle::load):
      * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
      (WebKit::NetscapePlugin::updatePluginLayer):
      * WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
      (WebKit::PluginProxy::pluginLayer):
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::PDFPlugin):
      (WebKit::PDFPlugin::createScrollbar):
      (WebKit::PDFPlugin::pdfDocumentDidLoad):
      (WebKit::PDFPlugin::writeItemsToPasteboard):
      * WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
      (getAllScriptsInPDFDocument):
      (WebKit::SimplePDFPlugin::pdfDocumentDidLoad):
      (WebKit::SimplePDFPlugin::streamDidReceiveData):
      (WebKit::SimplePDFPlugin::manualStreamDidReceiveData):
      * WebProcess/ResourceCache/WebResourceCacheManager.cpp:
      (WebKit::WebResourceCacheManager::clearCacheForOrigin):
      * WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
      (WebKit::WebResourceCacheManager::cfURLCacheHostNames):
      (WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):
      * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
      (WebKit::createNSError):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::drawPagesToPDF):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::performDictionaryLookupForRange):
      (WebKit::cachedResponseForURL):
      (WebKit::WebPage::drawPagesToPDFFromPDFDocument):
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::WebProcess::platformSetCacheModel):
      Use adoptCF and adoptNS free functions.
      
      Source/WTF:
      
      * wtf/RunLoopTimerCF.cpp:
      (WTF::RunLoopTimerBase::start):
      * wtf/SchedulePair.h:
      (WTF::SchedulePair::SchedulePair):
      * wtf/SchedulePairMac.mm:
      (WTF::SchedulePair::SchedulePair):
      * wtf/unicode/icu/CollatorICU.cpp:
      (WTF::Collator::userDefault):
      Use adoptCF free function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      051fed91
  10. 05 Apr, 2013 1 commit
    • rniwa@webkit.org's avatar
      Remove code for 10.5 and earlier from Source/WebCore · 6690896b
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113754
      
      Reviewed by Benjamin Poulain.
      
      Removed the code for 10.5 and removed if-def for 10.6.
      
      * WebCore.xcodeproj/project.pbxproj:
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * platform/LocalizedStrings.cpp:
      (WebCore::imageTitle):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::setAllowsFontSmoothing):
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::Image::drawPattern):
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::ImageSource::clear):
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::boundingRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore):
      (WebCore::FontPlatformData::ctFont):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
      (WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore):
      (WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
      (WebCore::FontCache::platformInit):
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
      (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
      (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
      (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit):
      * platform/graphics/mac/WebLayer.h:
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/DisplaySleepDisabler.cpp:
      (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
      (WebCore):
      * platform/mac/DisplaySleepDisabler.h:
      (DisplaySleepDisabler):
      * platform/mac/EmptyProtocolDefinitions.h:
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenuMac::populate):
      * platform/mac/ScrollElasticityController.mm:
      (systemUptime):
      * platform/mac/SharedTimerMac.mm:
      (PowerObserver):
      (WebCore::PowerObserver::PowerObserver):
      (WebCore::PowerObserver::~PowerObserver):
      (WebCore::PowerObserver::didReceiveSystemPowerNotification):
      * platform/mac/SuddenTermination.mm:
      * platform/mac/WebCoreFullScreenWindow.mm:
      (-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
      * platform/mac/WebFontCache.mm:
      (+[WebFontCache getTraits:inFamily:]):
      (+[WebFontCache internalFontWithFamily:traits:weight:size:]):
      * platform/mac/WebVideoFullscreenController.mm:
      (SOFT_LINK_POINTER):
      (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      (createControlWithMediaUIControlType):
      (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
      * platform/network/Credential.h:
      * platform/network/cf/DNSCFNet.cpp:
      (WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
      * platform/network/cf/ProxyServerCFNet.cpp:
      (WebCore):
      (WebCore::proxyServersForURL):
      * platform/network/cf/SocketStreamHandleCFNet.cpp:
      (WebCore::SocketStreamHandle::chooseProxy):
      * platform/network/mac/AuthenticationMac.mm:
      (WebCore):
      * platform/network/mac/WebCoreURLResponse.mm:
      (WebCore::adjustMIMETypeIfNecessary):
      * platform/text/TextChecking.h:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6690896b
  11. 11 Mar, 2013 1 commit
    • inferno@chromium.org's avatar
      Replace static_cast with to* helper functions. · b9af1c12
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112045
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      (WebCore::V8HTMLOptionsCollection::removeMethodCustom):
      (WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
      * bindings/v8/custom/V8NamedNodesCollection.cpp:
      (WebCore::V8NamedNodesCollection::namedItem):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::wrap):
      * editing/BreakBlockquoteCommand.cpp:
      (WebCore::BreakBlockquoteCommand::doApply):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::insertNodeAt):
      (WebCore::CompositeEditCommand::pushAnchorElementDown):
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
      (WebCore::CompositeEditCommand::splitTreeToNode):
      * editing/InsertParagraphSeparatorCommand.cpp:
      (WebCore::InsertParagraphSeparatorCommand::doApply):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeImage):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::frameContentsCompositor):
      (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::plugInImageElement):
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::updateFromElement):
      * rendering/svg/RenderSVGResourceContainer.cpp:
      (WebCore::RenderSVGResourceContainer::idChanged):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::findChildByExpression):
      (WebKit::WebFrameImpl::fromFrameOwnerElement):
      * src/WebHelperPluginImpl.cpp:
      (WebKit::WebHelperPluginImpl::getPlugin):
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::loadInternal):
      (WebKit::WebMediaPlayerClientImpl::create):
      * src/WebPageSerializerImpl.cpp:
      (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
      (WebKit::WebPageSerializerImpl::endTagToString):
      (WebKit::WebPageSerializerImpl::buildContentForNode):
      (WebKit::WebPageSerializerImpl::collectTargetFrames):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
      (WebKit::WebViewImpl::enterFullScreenForElement):
      
      Source/WebKit/mac:
      
      * WebView/WebRenderLayer.mm:
      (+[WebRenderLayer nameForLayer:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9af1c12
  12. 03 Mar, 2013 2 commits
    • abarth@webkit.org's avatar
      Unreviewed attempted build fix. Adds back some includes removed in · 401a3791
      abarth@webkit.org authored
      http://trac.webkit.org/changeset/144565.
      
      Source/WebCore: 
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      * bindings/ScriptControllerBase.cpp:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/FrameLoader.cpp:
      * loader/MainResourceLoader.cpp:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/icon/IconController.cpp:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401a3791
    • abarth@webkit.org's avatar
      Unreviewed rollout of http://trac.webkit.org/r144530 · fa616dd3
      abarth@webkit.org authored
      As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
      https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
      large number of ASSERTs in chromium-win.
      
      Source/WebCore: 
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      (WebCore):
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      (WebCore):
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      (WebCore):
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      (WebCore):
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore):
      * loader/cache/CachedResourceHandle.h:
      (WebCore):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore):
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      (WebCore):
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore):
      * platform/graphics/filters/FilterOperation.h:
      (WebCore):
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      (WebCore):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      (WebCore):
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk: 
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa616dd3
  13. 01 Mar, 2013 3 commits
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · fc363ce1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111035
      
              Reviewed by Eric Seidel.
      
              This uses a number of common unsurprising techniques. One interesting observation
              is that including CachedResource related headers is very expensive. We can usually
              get away with their Client counterparts, and with CachedResourceHandle.
      
              * page/Frame.cpp:
              * page/Frame.h:
              Don't include FrameLoader, greatly reducing include graph for most non-loader files.
              This required making Frame::init() non-inline - I'm not sure why it ever was.
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              Even though FrameLoader is logically on loading side of WebCore, it's included in
              too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
              largest wins. As a future improvement, we should probably convert other members
              to OwnPtrs.
      
              * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
              definition of a class it holds, but default construction does not.
      
              * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
              not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
              * loader/cache/CachedFont.h:
              * loader/cache/CachedFontClient.h: Added.
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/cache/CachedSVGDocument.h:
              * loader/cache/CachedSVGDocumentClient.h: Added.
              These types were defining client types in the same headers, making it impossible
              to avoid including networking headers through CachedResource. Moved clients into
              separate files.
      
              * plugins/PluginStream.h:
              * plugins/PluginStreamClient.h: Added.
              Similar situation here.
      
              * loader/cache/CachedResourceHandle.cpp:
              * loader/cache/CachedResourceHandle.h:
              Moved functions that need to know about CachedResource to .cpp file. This is another
              huge win. Added a destructor, so that CachedResource woudn't be needed in all files
              that include CachedResourceHandle.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved constructor and virtual function implementations to a .cpp file - they need
              not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
              * platform/graphics/filters/FilterOperation.cpp:
              * platform/graphics/filters/FilterOperation.h:
              Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
              CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
              rendering code that it seems best to cut any ties with resources and loading.
              Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
              classes are generally harmful (due to code bloat).
      
              * plugins/PluginRequest.h: Added.
              * plugins/PluginView.h:
              Moved PluginRequest into a separate file, it was out of place in a view hierarchy
              class file.
      
              * rendering/RenderImageResource.cpp:
              * rendering/RenderImageResource.h:
              Moved definitions of virtual functions to a .cpp file. Thre is no win from having
              them inline, and now we don't need CachedImage.h in the header.
      
              * rendering/style/StyleCustomFilterProgram.cpp: Added.
              * rendering/style/StyleCustomFilterProgram.h:
              Ditto.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Modules/mediastream/RTCPeerConnection.cpp:
              * Modules/notifications/Notification.cpp:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/ScriptControllerBase.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptSourceCode.h:
              * bindings/objc/DOM.mm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * css/CSSFontFaceSource.h:
              * css/CSSFontSelector.cpp:
              * css/WebKitCSSSVGDocumentValue.cpp:
              * css/WebKitCSSSVGDocumentValue.h:
              * dom/Clipboard.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/PendingScript.h:
              * dom/ScriptElement.cpp:
              * dom/ScriptElement.h:
              * history/CachedFrame.cpp:
              * html/DOMURL.cpp:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAppletElement.cpp:
              * html/HTMLElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLHtmlElement.cpp:
              * html/HTMLImageElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/ImageDocument.cpp:
              * html/ImageInputType.cpp:
              * html/MediaDocument.cpp:
              * html/PluginDocument.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLParserOptions.cpp:
              * html/parser/HTMLScriptRunner.h:
              * html/parser/XSSAuditor.cpp:
              * html/parser/XSSAuditorDelegate.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorFileSystemAgent.cpp:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorPageAgent.cpp:
              * inspector/NetworkResourcesData.cpp:
              * inspector/NetworkResourcesData.h:
              * loader/CookieJar.cpp:
              * loader/CrossOriginAccessControl.cpp:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/DocumentThreadableLoader.h:
              * loader/ImageLoader.cpp:
              * loader/ImageLoader.h:
              * loader/LinkLoader.h:
              * loader/MainResourceLoader.cpp:
              * loader/MainResourceLoader.h:
              * loader/MixedContentChecker.cpp:
              * loader/PingLoader.cpp:
              * loader/PolicyChecker.h:
              * loader/ProgressTracker.cpp:
              * loader/SubframeLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/TextTrackLoader.cpp:
              * loader/TextTrackLoader.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedStyleSheetClient.h:
              * loader/cache/MemoryCache.cpp:
              * loader/cache/MemoryCache.h:
              * loader/chromium/CachedRawResourceChromium.cpp:
              * loader/icon/IconController.cpp:
              * loader/icon/IconLoader.h:
              * loader/mac/ResourceLoaderMac.mm:
              * page/DOMWindowExtension.cpp:
              * page/DragController.cpp:
              * page/PerformanceNavigation.cpp:
              * page/PerformanceTiming.cpp:
              * page/PointerLockController.cpp:
              * page/Settings.cpp:
              * page/animation/CSSPropertyAnimation.cpp:
              * platform/chromium/PasteboardChromium.cpp:
              * platform/efl/ErrorsEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              * platform/gtk/ErrorsGtk.cpp:
              * platform/gtk/PasteboardGtk.cpp:
              * platform/gtk/PasteboardHelper.h:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/HTMLConverter.mm:
              * platform/mac/PasteboardMac.mm:
              * platform/network/AuthenticationChallengeBase.cpp:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/mac/CookieStorageMac.mm:
              * platform/qt/PasteboardQt.cpp:
              * plugins/DOMMimeType.cpp:
              * plugins/PluginView.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderImage.cpp:
              * rendering/RenderImageResourceStyleImage.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerFilterInfo.h:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderSnapshottedPlugIn.cpp:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/style/StyleCachedShader.h:
              * svg/SVGFEImageElement.h:
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGImageLoader.cpp:
              * svg/SVGUseElement.cpp:
              * svg/SVGUseElement.h:
              * svg/graphics/SVGImageCache.cpp:
              * testing/MockPagePopupDriver.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessorLibxslt.cpp:
              * xml/parser/XMLDocumentParser.cpp:
              * xml/parser/XMLDocumentParser.h:
              * xml/parser/XMLDocumentParserLibxml2.cpp:
              Many self-evident changes - removing unnecessary header includes, adding smaller
              more local ones that are now necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc363ce1
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r144422 and r144424. · 0b87a6c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/144422
      http://trac.webkit.org/changeset/144424
      https://bugs.webkit.org/show_bug.cgi?id=111167
      
      Caused over 20 tests to fail assertion on Chromium Win port as
      ASSERTION FAILED: m_platformRequestUpdated (Requested by
      toyoshim on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium:
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b87a6c7
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · b2f13721
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111035
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This uses a number of common unsurprising techniques. One interesting observation
      is that including CachedResource related headers is very expensive. We can usually
      get away with their Client counterparts, and with CachedResourceHandle.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Don't include FrameLoader, greatly reducing include graph for most non-loader files.
      This required making Frame::init() non-inline - I'm not sure why it ever was.
      
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      Even though FrameLoader is logically on loading side of WebCore, it's included in
      too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
      largest wins. As a future improvement, we should probably convert other members
      to OwnPtrs.
      
      * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
      definition of a class it holds, but default construction does not.
      
      * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
      not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      * loader/cache/CachedRawResource.h:
      * loader/cache/CachedRawResourceClient.h: Added.
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      These types were defining client types in the same headers, making it impossible
      to avoid including networking headers through CachedResource. Moved clients into
      separate files.
      
      * plugins/PluginStream.h:
      * plugins/PluginStreamClient.h: Added.
      Similar situation here.
      
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      Moved functions that need to know about CachedResource to .cpp file. This is another
      huge win. Added a destructor, so that CachedResource woudn't be needed in all files
      that include CachedResourceHandle.
      
      * loader/cache/CachedSVGDocumentReference.cpp: Added.
      * loader/cache/CachedSVGDocumentReference.h:
      Moved constructor and virtual function implementations to a .cpp file - they need
      not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
      CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
      rendering code that it seems best to cut any ties with resources and loading.
      Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
      classes are generally harmful (due to code bloat).
      
      * plugins/PluginRequest.h: Added.
      * plugins/PluginView.h:
      Moved PluginRequest into a separate file, it was out of place in a view hierarchy
      class file.
      
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResource.h:
      Moved definitions of virtual functions to a .cpp file. Thre is no win from having
      them inline, and now we don't need CachedImage.h in the header.
      
      * rendering/style/StyleCustomFilterProgram.cpp: Added.
      * rendering/style/StyleCustomFilterProgram.h:
      Ditto.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      * dom/Clipboard.cpp:
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      Many self-evident changes - removing unnecessary header includes, adding smaller
      more local ones that are now necessary.
      
      Source/WebKit/chromium:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f13721
  14. 05 Feb, 2013 1 commit
    • mkwst@chromium.org's avatar
      Cleanup: Use exceptionless Range::* methods rather than ignoring exceptions. · e12976ac
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108773
      
      Reviewed by Darin Adler.
      
      We often call Range::{start,end}{Container,Offset} with an ExceptionCode
      that's completely ignored. In these cases, we should simply use the
      exceptionless version of the method instead.
      
      * dom/DocumentMarkerController.cpp:
      (WebCore::DocumentMarkerController::addMarker):
          Here, I also moved parameters onto one line to make the
          stylebot happy.
      (WebCore::DocumentMarkerController::addTextMatchMarker):
      (WebCore::DocumentMarkerController::setMarkersActive):
          Dropped ignored ExceptionCode variable entirely.
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
          Can't drop the variable because of the selectNodeContents call.
      * editing/Editor.cpp:
      (WebCore::Editor::canDeleteRange):
          Dropped ignored ExceptionCode variable entirely.
      (WebCore::Editor::advanceToNextMisspelling):
          Can't drop the variable because of setStart/setEnd.
      * editing/EditorCommand.cpp:
      (WebCore::unionDOMRanges):
          Can't drop the variable because of compareBoundaryPoints.
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::appendNodeValue):
          Dropped ignored ExceptionCode variable entirely.
      * editing/TextCheckingHelper.cpp:
      (WebCore::TextCheckingParagraph::offsetAsRange):
      (WebCore::TextCheckingHelper::findFirstMisspelling):
      (WebCore::TextCheckingHelper::findFirstGrammarDetail):
      (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::renderedText):
      (WebCore::StyledMarkupAccumulator::stringValueForRange):
          Dropped ignored ExceptionCode variable entirely.
      * editing/visible_units.cpp:
      (WebCore::previousBoundary):
          Can't drop the variable due to many other calls.
      * page/DOMSelection.cpp:
      (WebCore::DOMSelection::deleteFromDocument):
      (WebCore::DOMSelection::containsNode):
          For both these cases, the 'ASSERT(!ec)' after the statement I've
          edited only checked the last occurance of the exception: that is,
          if 'startXxx(ec)' threw an exception, it would be overwritten by
          the 'setBaseAndExtend()' or 'compareBoundaryPoints()' exception.
          Removing the exception parameters from the parameters' calls
          shouldn't effect behavior.
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeSelection):
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      * platform/win/ClipboardWin.cpp:
      (WebCore::ClipboardWin::writeRange):
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writeSelection):
      * platform/wince/PasteboardWinCE.cpp:
      (WebCore::Pasteboard::writeSelection):
          Dropped ignored ExceptionCode variable entirely.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e12976ac
  15. 28 Nov, 2012 1 commit
  16. 23 Oct, 2012 1 commit
    • benjamin@webkit.org's avatar
      [Mac] Remove extraneous conversion to String->NSString · 0cf8566d
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100044
      
      Reviewed by Darin Adler.
      
      Improve some unfortunate use of String->NSString.
      
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification): The variable macNotification is ultimately
      needed as NSString, and all its value are or can be NSString.
      Convert the last 3 char* values to NSString literal and use NSString* all the way.
      
      * loader/mac/LoaderNSURLExtras.h:
      * loader/mac/LoaderNSURLExtras.mm:
      (suggestedFilenameWithMIMEType):
      We converted the String to NSString to pass to suggestedFilenameWithMIMEType. There is no need
      for the string to be a NSSTring there, we can leave it in its original type.
      
      The case checking for a nil MIMEType was dead code because the implicit conversion never returns nil.
      
      * platform/mac/DragImageMac.mm:
      (WebCore::createDragImageForLink):
      Use String's nsStringNilIfEmpty().
      
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      Fix the coding style. Do the conversion to NSString only when needed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cf8566d
  17. 22 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Reduce Font.h includes across project -- improves RenderObject.h compile time · d0c076d4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93629
      
      Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-22
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      RenderStyle.h no longer depends on Font.h. The files that transitively
      need to be updated with proper includes are fixed.
      
      No new tests. Functionality should remain the same.
      
      * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
      * accessibility/mac/WebAccessibilityObjectWrapper.mm:
      * bindings/objc/DOM.mm:
      * css/CSSComputedStyleDeclaration.cpp:
      * css/CSSPrimitiveValue.cpp:
      * css/StyleResolver.h:
      * dom/CharacterData.cpp:
      * dom/ElementRareData.h:
      * dom/NodeRenderingContext.cpp:
      * dom/Text.cpp:
      * editing/TextIterator.cpp:
      * editing/mac/EditorMac.mm:
      * html/HTMLTitleElement.cpp:
      * html/shadow/TextControlInnerElements.cpp:
      * inspector/InspectorOverlay.cpp:
      * page/ContextMenuController.cpp:
      * page/PrintContext.cpp:
      * platform/efl/RenderThemeEfl.cpp:
      * platform/graphics/FontMetrics.h:
      * platform/gtk/RenderThemeGtk.cpp:
      * platform/gtk/RenderThemeGtk2.cpp:
      * platform/mac/HTMLConverter.mm:
      * rendering/EllipsisBox.cpp:
      * rendering/FlowThreadController.cpp:
      * rendering/InlineBox.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/InlineFlowBox.h:
      (WebCore):
      * rendering/RenderButton.cpp:
      * rendering/RenderCombineText.cpp:
      * rendering/RenderCombineText.h:
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      * rendering/RenderEmbeddedObject.h:
      (WebCore):
      * rendering/RenderFileUploadControl.cpp:
      * rendering/RenderFullScreen.h:
      * rendering/RenderImage.cpp:
      * rendering/RenderInline.cpp:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderMultiColumnBlock.cpp:
      * rendering/RenderRegion.h:
      * rendering/RenderRuby.cpp:
      * rendering/RenderRubyRun.cpp:
      * rendering/RenderScrollbar.cpp:
      * rendering/RenderTable.cpp:
      * rendering/RenderTableCell.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/RenderTextControl.cpp:
      * rendering/RenderTextControlMultiLine.cpp:
      * rendering/RenderThemeChromiumSkia.cpp:
      * rendering/RenderView.cpp:
      * rendering/TextAutosizer.cpp:
      * rendering/mathml/RenderMathMLBlock.h:
      * rendering/style/KeyframeList.h:
      * rendering/style/RenderStyle.cpp:
      * rendering/style/RenderStyle.h:
      (WebCore):
      * rendering/style/StyleInheritedData.cpp:
      * rendering/svg/RenderSVGBlock.cpp:
      * rendering/svg/RenderSVGInlineText.h:
      * svg/SVGLengthContext.cpp:
      * svg/SVGTRefElement.cpp:
      
      Source/WebKit/chromium:
      
      Adds includes due to change in RenderStyle.h
      
      * src/WebFrameImpl.cpp:
      * src/mac/WebSubstringUtil.mm:
      
      Source/WebKit/win:
      
      Adds includes due to change in RenderStyle.h
      
      * DOMCoreClasses.cpp:
      
      Source/WebKit2:
      
      Adds includes due to change in RenderStyle.h
      
      * WebProcess/WebPage/mac/WebPageMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0c076d4
  18. 14 Jul, 2012 1 commit
    • mrowe@apple.com's avatar
      Make it explicit which code paths iOS should use when doing checks based on OS X versions. · e3cb3cf9
      mrowe@apple.com authored
      Rubber-stamped by David Kilzer.
      
      * WebCore.exp.in:
      * accessibility/AccessibilityList.h:
      * accessibility/AccessibilityTable.h:
      * accessibility/mac/AXObjectCacheMac.mm:
      * editing/mac/EditorMac.mm:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * page/AlternativeTextClient.h:
      * page/mac/SettingsMac.mm:
      * platform/LocalizedStrings.cpp:
      * platform/MemoryPressureHandler.cpp:
      * platform/audio/mac/AudioBusMac.mm:
      * platform/graphics/Gradient.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      * platform/graphics/ca/mac/TileCache.mm:
      * platform/graphics/cg/GraphicsContextCG.cpp:
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/cg/ImageBufferDataCG.h:
      * platform/graphics/cg/ImageCG.cpp:
      * platform/graphics/cg/ImageSourceCG.cpp:
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      * platform/graphics/mac/ComplexTextController.cpp:
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      * platform/graphics/mac/FontCacheMac.mm:
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      * platform/graphics/mac/FontMac.mm:
      * platform/graphics/mac/GraphicsContextMac.mm:
      * platform/graphics/mac/SimpleFontDataMac.mm:
      * platform/graphics/mac/WebLayer.h:
      * platform/graphics/mac/WebLayer.mm:
      * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
      * platform/mac/DisplaySleepDisabler.cpp:
      * platform/mac/DisplaySleepDisabler.h:
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/MemoryPressureHandlerMac.mm:
      * platform/mac/SharedTimerMac.mm:
      * platform/mac/SuddenTermination.mm:
      * platform/mac/WebFontCache.mm:
      * platform/network/Credential.h:
      * platform/network/ResourceHandle.h:
      * platform/network/cf/DNSCFNet.cpp:
      * platform/network/cf/ProxyServerCFNet.cpp:
      * platform/network/cf/ResourceRequest.h:
      * platform/network/cf/SocketStreamHandleCFNet.cpp:
      * platform/network/mac/AuthenticationMac.mm:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      * platform/network/mac/ResourceRequestMac.mm:
      * platform/network/mac/WebCoreURLResponse.mm:
      * platform/text/TextChecking.h:
      * platform/text/cf/HyphenationCF.cpp:
      * platform/text/mac/HyphenationMac.mm:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerCompositor.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3cb3cf9
  19. 11 Jul, 2012 1 commit
    • mrowe@apple.com's avatar
      <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of... · d67332ee
      mrowe@apple.com authored
      <http://webkit.org/b/91015> Remove BUILDING_ON / TARGETING macros in favor of system availability macros
      
      This removal was handled by a script that translates the relevant macros in to the equivalent checks
      using the system availability macros.
      
      Reviewed by Filip Pizlo.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * accessibility/AccessibilityList.h:
      * accessibility/AccessibilityTable.h:
      * accessibility/mac/AXObjectCacheMac.mm:
      * editing/mac/EditorMac.mm:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * page/AlternativeTextClient.h:
      * page/ContextMenuController.cpp:
      * page/mac/SettingsMac.mm:
      * platform/LocalizedStrings.cpp:
      * platform/MemoryPressureHandler.cpp:
      * platform/audio/mac/AudioBusMac.mm:
      * platform/graphics/Gradient.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      * platform/graphics/ca/mac/TileCache.mm:
      * platform/graphics/cg/GraphicsContextCG.cpp:
      * platform/graphics/cg/ImageBufferCG.cpp:
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      * platform/graphics/cg/ImageBufferDataCG.h:
      * platform/graphics/cg/ImageCG.cpp:
      * platform/graphics/cg/ImageSourceCG.cpp:
      * platform/graphics/cg/PathCG.cpp:
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      * platform/graphics/mac/ComplexTextController.cpp:
      * platform/graphics/mac/ComplexTextControllerCoreText.mm:
      * platform/graphics/mac/FontCacheMac.mm:
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      * platform/graphics/mac/FontMac.mm:
      * platform/graphics/mac/GraphicsContextMac.mm:
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      * platform/graphics/mac/SimpleFontDataMac.mm:
      * platform/graphics/mac/WebLayer.h:
      * platform/graphics/mac/WebLayer.mm:
      * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
      * platform/mac/CursorMac.mm:
      * platform/mac/DisplaySleepDisabler.cpp:
      * platform/mac/DisplaySleepDisabler.h:
      * platform/mac/EmptyProtocolDefinitions.h:
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/MemoryPressureHandlerMac.mm:
      * platform/mac/NSScrollerImpDetails.h:
      * platform/mac/PlatformEventFactoryMac.mm:
      * platform/mac/PopupMenuMac.mm:
      * platform/mac/ScrollAnimatorMac.mm:
      * platform/mac/ScrollElasticityController.mm:
      * platform/mac/SharedTimerMac.mm:
      * platform/mac/SuddenTermination.mm:
      * platform/mac/WebCoreFullScreenWindow.mm:
      * platform/mac/WebCoreNSCellExtras.h:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * platform/mac/WebFontCache.mm:
      * platform/mac/WebVideoFullscreenController.mm:
      * platform/mac/WebVideoFullscreenHUDWindowController.mm:
      * platform/network/Credential.h:
      * platform/network/ResourceHandle.h:
      * platform/network/cf/DNSCFNet.cpp:
      * platform/network/cf/ProxyServerCFNet.cpp:
      * platform/network/cf/ResourceRequest.h:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/cf/SocketStreamHandleCFNet.cpp:
      * platform/network/mac/AuthenticationMac.mm:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      * platform/network/mac/ResourceRequestMac.mm:
      * platform/network/mac/WebCoreURLResponse.mm:
      * platform/text/TextChecking.h:
      * platform/text/cf/HyphenationCF.cpp:
      * platform/text/mac/HyphenationMac.mm:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerCompositor.cpp:
      * rendering/RenderThemeMac.mm:
      
      Source/WebKit/chromium:
      
      * src/mac/WebInputEventFactory.mm:
      
      Source/WebKit/mac:
      
      * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
      * Misc/WebKitErrors.m:
      * Misc/WebNSControlExtras.m:
      * Misc/WebNSFileManagerExtras.mm:
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      * Plugins/WebBaseNetscapePluginView.mm:
      * Plugins/WebNetscapePluginView.mm:
      * WebCoreSupport/WebChromeClient.mm:
      * WebCoreSupport/WebEditorClient.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      * WebCoreSupport/WebSystemInterface.mm:
      * WebView/WebClipView.mm:
      * WebView/WebDynamicScrollBarsView.mm:
      * WebView/WebFrameView.mm:
      * WebView/WebFullScreenController.mm:
      * WebView/WebHTMLView.mm:
      * WebView/WebHTMLViewInternal.h:
      * WebView/WebPDFDocumentExtras.mm:
      * WebView/WebPreferences.mm:
      * WebView/WebResourceInternal.h:
      * WebView/WebScriptDebugDelegate.h:
      * WebView/WebView.mm:
      * WebView/WebViewPrivate.h:
      
      Source/WebKit2:
      
      * Shared/DictionaryPopupInfo.cpp:
      * Shared/DictionaryPopupInfo.h:
      * Shared/mac/PasteboardTypes.mm:
      * Shared/mac/WebEventFactory.mm:
      * UIProcess/API/mac/PDFViewController.mm:
      * UIProcess/API/mac/PageClientImpl.mm:
      * UIProcess/API/mac/WKView.mm:
      * UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
      * UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
      * UIProcess/Launcher/mac/EnvironmentVariables.cpp:
      * UIProcess/Launcher/mac/EnvironmentVariables.h:
      * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
      * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
      * UIProcess/WebPageProxy.cpp:
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * UIProcess/mac/TextCheckerMac.mm:
      * UIProcess/mac/WKFullScreenWindowController.mm:
      * UIProcess/mac/WebContextMac.mm:
      * UIProcess/mac/WebPageProxyMac.mm:
      * WebKit2Prefix.h:
      * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
      * WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.h:
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      * WebProcess/WebPage/WebPage.cpp:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/com.apple.WebProcess.sb.in:
      * WebProcess/mac/KeychainItemShimMethods.mm:
      * WebProcess/mac/SecItemShimMethods.mm:
      * WebProcess/mac/WebProcessMac.mm:
      * WebProcess/mac/WebProcessMainMac.mm:
      * WebProcess/mac/WebProcessShim.mm:
      
      Source/WTF:
      
      * wtf/Assertions.cpp:
      * wtf/FastMalloc.cpp:
      * wtf/Platform.h:
      * wtf/ThreadingPthreads.cpp:
      * wtf/unicode/icu/CollatorICU.cpp:
      
      Tools:
      
      * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
      * DumpRenderTree/mac/CheckedMalloc.cpp:
      * DumpRenderTree/mac/DumpRenderTree.mm:
      * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
      * DumpRenderTree/mac/LayoutTestControllerMac.mm:
      * DumpRenderTree/mac/TextInputController.m:
      * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
      * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d67332ee
  20. 29 Jun, 2012 2 commits
    • tony@chromium.org's avatar
      Unreviewed, rolling out r121547. · 9d07d6c2
      tony@chromium.org authored
      http://trac.webkit.org/changeset/121547
      https://bugs.webkit.org/show_bug.cgi?id=90256
      
      Breaks Chromium Mac build
      
      * platform/LocalizedStrings.cpp:
      (WebCore::imageTitle):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::setAllowsFontSmoothing):
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::Image::drawPattern):
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::ImageSource::clear):
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::boundingRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore):
      (WebCore::canSetCascadeListForCustomFont):
      (WebCore::FontPlatformData::ctFont):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      * platform/graphics/mac/ComplexTextController.cpp:
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore):
      (WebCore::fontCacheATSNotificationCallback):
      (WebCore::FontCache::platformInit):
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/FontCustomPlatformData.h:
      (WebCore::FontCustomPlatformData::FontCustomPlatformData):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit):
      * platform/graphics/mac/WebLayer.h:
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/DisplaySleepDisabler.cpp:
      (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
      (WebCore):
      (WebCore::DisplaySleepDisabler::systemActivityTimerFired):
      * platform/mac/DisplaySleepDisabler.h:
      (DisplaySleepDisabler):
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenuMac::populate):
      * platform/mac/ScrollElasticityController.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d07d6c2
    • eric@webkit.org's avatar
      Remove still more BUILDING_ON_LEOPARD branches now that no port supports leopard · 07569c46
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90256
      
      Reviewed by Ryosuke Niwa.
      
      * platform/LocalizedStrings.cpp:
      (WebCore::imageTitle):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::setAllowsFontSmoothing):
      * platform/graphics/cg/ImageCG.cpp:
      (WebCore::Image::drawPattern):
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::ImageSource::clear):
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::boundingRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::ctFont):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      * platform/graphics/mac/ComplexTextController.cpp:
      * platform/graphics/mac/FontCacheMac.mm:
      (WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
      (WebCore::FontCache::platformInit):
      * platform/graphics/mac/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
      (WebCore::createFontCustomPlatformData):
      * platform/graphics/mac/FontCustomPlatformData.h:
      (WebCore::FontCustomPlatformData::FontCustomPlatformData):
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit):
      * platform/graphics/mac/WebLayer.h:
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/DisplaySleepDisabler.cpp:
      (WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
      (WebCore::DisplaySleepDisabler::~DisplaySleepDisabler):
      * platform/mac/DisplaySleepDisabler.h:
      (DisplaySleepDisabler):
      * platform/mac/HTMLConverter.h:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenuMac::populate):
      * platform/mac/ScrollElasticityController.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07569c46
  21. 20 Mar, 2012 1 commit
  22. 03 Mar, 2012 1 commit
    • andersca@apple.com's avatar
      Fix build with newer versions of clang. · 43578ad3
      andersca@apple.com authored
      Source/WebCore:
      
      * bindings/objc/DOM.mm:
      (-[DOMNode description]):
      Remove an unused parameter.
      
      * bridge/objc/objc_instance.mm:
      (ObjcInstance::getClass):
      Use object_getClass instead of accessing isa directly.
      
      * platform/LocalizedStrings.cpp:
      (WebCore::formatLocalizedString):
      Disable the -Wformat-nonliteral warning around the call to CFStringCreateWithFormatAndArguments.
      
      * platform/graphics/mac/WebLayer.mm:
      (-[CALayer _descriptionWithPrefix:]):
      Use %p for the CALayer pointer, and use %lu for the number of sublayers.
      
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      Cast the NSAttachmentCharacte enum to unichar.
      
      Source/WebKit/mac:
      
      * Panels/WebAuthenticationPanel.m:
      (-[WebAuthenticationPanel setUpForChallenge:]):
      Use %ld and cast to long.
      
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView getVariable:value:]):
      Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
      
      Source/WebKit2:
      
      * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
      (WebKit::NPN_GetValue):
      Cast the switch parameter to unsigned to prevent warnings about case values not being part of the enum type.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@109663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43578ad3
  23. 19 Jan, 2012 1 commit
  24. 14 Oct, 2011 1 commit
    • zimmermann@webkit.org's avatar
      2011-10-13 Nikolas Zimmermann <nzimmermann@rim.com> · 8cf217f7
      zimmermann@webkit.org authored
              Prepare SVGImage intrinsic size negotiation: Introduce an IntSize <-> SVGImage cache in CachedImage
              https://bugs.webkit.org/show_bug.cgi?id=69416
      
              Reviewed by Antti Koivisto.
      
              Refactor ImageBySizeCache out of CSSImageGeneratorValue as CachedImage wants to use the same type of cache for its purposes.
              When introducing the SVGImage intrinsic size negotiation the container size of an SVGImage is dependant on the place where
              it gets embedded (eg width/height attributes of host documents <img> force a certain size).
      
              Currently CachedImage only contains a single RefPtr<Image>, which it constructs out of the decoded data.
              Multiple RenderObjects share the same CachedImages, when embedding eg. a SVG document in a <html:img> or using it in a background-image for a <div>.
              Consider the case where two RenderObjects use the same CachedImage, each with a different container size (200x100 vs 100x200) and the embedded
              document contains a viewBox and some arbitary preserveAspectRatio settings. To honour these we have to relayout the document with the desired
              size (percentual unit resolving etc, all depend on the RenderSVGRoots size).
      
              With the current design this is hard to realize, w/o requring to relayout the embedded document for each embedder that uses an SVGImage.
              This patch introduces a cache right within CachedImage, which manages a map of images to certain sizes, by utilizing the new ImageBySizeCache.
      
              CachedImage::imageForRenderer() takes a RenderObject* parameter, which it uses to look up the last set image container size for a renderer.
              Using that size it queries the cache whether it already has an SVGImage for that size, if not it gets created, by creating a whole
              new instance of SVGImage, filling it with the already decoded data, and passing on a fixed image container size, which overrides the
              size that RenderSVGRoot reports, when computeReplacedLogicalWidth/Height is called and thus laying out the document at the desired size.
              This image is then put in the cache for further reusability.
      
              Likewise CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter and stores that in the cache with an associated container size.
              It requires to touch several files which use CachedImage throughout WebCore/WebKit/WebKit2.
      
              The actual cache is not yet turned on yet, so this is not a functional change so far, as it needs some other changes to SVGImage,
              which will come with the master patch in bug 47156.
      
              No new tests yet, as the new cache isn't turned on yet.
      
              * CMakeLists.txt: Add rendering/ImageBySizeCache.* to build.
              * GNUmakefile.list.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
              * bindings/objc/DOM.mm: Ditto (for CachedImage::image()).
              (-[DOMElement image]):
              (-[DOMElement _imageTIFFRepresentation]):
              * bridge/qt/qt_pixmapruntime.cpp:
              (JSC::Bindings::QtPixmapInstance::variantFromObject): Ditto (for CachedImage::image()).
              * css/CSSCanvasValue.cpp: s/m_clients/clients()/, which now live in the ImageBySizeCache instead of CSSImageGeneratorValue.
              (WebCore::CSSCanvasValue::canvasChanged):
              (WebCore::CSSCanvasValue::canvasResized):
              (WebCore::CSSCanvasValue::image):
              * css/CSSGradientValue.cpp: Ditto.
              (WebCore::CSSGradientValue::image):
              * css/CSSImageGeneratorValue.cpp: Move the sizes/clients/images cache into a new ImageBySizeCache class, to make it usable for CachedImage as well.
              (WebCore::CSSImageGeneratorValue::addClient): Adapt to move.
              (WebCore::CSSImageGeneratorValue::removeClient): Ditto.
              (WebCore::CSSImageGeneratorValue::getImage): Ditto.
              (WebCore::CSSImageGeneratorValue::putImage): Ditto.
              * css/CSSImageGeneratorValue.h:
              (WebCore::CSSImageGeneratorValue::clients): Forwarded to the ImageBySizeCache.
              * editing/DeleteButtonController.cpp: 
              (WebCore::isDeletableElement): CachedImage::canRender() now takes a RenderObject* parameter.
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::width): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
              (WebCore::HTMLImageElement::height): Ditto.
              (WebCore::HTMLImageElement::naturalWidth): Ditto.
              (WebCore::HTMLImageElement::naturalHeight): Ditto.
              * html/ImageDocument.cpp:
              (WebCore::ImageDocumentParser::finish): Ditto.
              (WebCore::ImageDocument::scale): Ditto.
              (WebCore::ImageDocument::resizeImageToFit): Ditto.
              (WebCore::ImageDocument::imageUpdated): Ditto.
              (WebCore::ImageDocument::restoreImageSize): Ditto.
              (WebCore::ImageDocument::imageFitsInWindow): Ditto.
              * html/canvas/CanvasRenderingContext.cpp:
              (WebCore::CanvasRenderingContext::wouldTaintOrigin): Use new CachedImage::imageForRenderer(RenderObject*) method.
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::isOriginClean): Ditto.
              (WebCore::size): Ditto (for CachedImage::imageSizeForRenderer()).
              (WebCore::CanvasRenderingContext2D::drawImage): Ditto.
              (WebCore::CanvasRenderingContext2D::createPattern): Ditto.
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::texImage2D): Ditto.
              (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
              * loader/cache/CachedImage.cpp: Add currently _disabled_ cache for SVGImages. The intrinsic size negotiation will need to use multiple SVGImages
              for each requested size (equal to the size of the embedding place for the image) - make it possible to cache these SVGImages, and maintain a cache
              for them. The hash code is a 1:1 refactoring from the already present code in CSSImageGeneratorValue, now named 'ImageBySizeCache'.
              (WebCore::CachedImage::lookupImageForSize): Looks up an Image from the cache for a given IntSize. Currently turned off.
              (WebCore::CachedImage::lookupImageForRenderer): Looks up an Image from the cache for a given renderer. Currently turned off.
              (WebCore::CachedImage::lookupOrCreateImageForRenderer): Looks up an Image from the cache or creates a new SVGImage for a given size and caches it, if possible. Currently turned off.
              All following changes share this: Don't operate on m_image directly, instead always look up one from the cache for a given size or renderer - if that's not present fallback to m_image.
              When an SVGImage is first created by CachedImage::createImage() and stored in m_image, the cache remains empty.
      
              If eg. <img width="30" height="70" src="foo.svg"> is used which implies a container size of 30x70 a new SVGImage is created with the additional information of a 30x70 container size
              which is immediately passed to the SVGImage after its creation. This SVGImage is put in the ImageBySizeCache associated with a container size of 30x70.
              We now have two SVGImage objects present, one living in CachedImage::m_image, created by createImage() during data decoding, and one living in the ImageBySizeCache
              created by lookupOrCreateImageForRenderer() associated with the 30x70 container. The first SVGImage::size() will return a value as defined in the referenced foo.svg,
              whereas the SVGImage::size() call of the new SVGImage living in the cache reports 30x70 and renders according to that.
      
              Whenever any method of CachedImage is called with a RenderObject* or IntSize, we can't just operate on m_image anymore but instead have to lookup the right
              images for a certain renderer/size from the cache and operate on these. When calling eg. CachedImage::image() with a null renderer, m_image is returned.
              When passing with a valid renderer only cache lookups are done if the m_image is actually a SVGImage, otherwhise lookupImageForSize/Renderer will just return the m_image.
              There is no logical change induced for non-SVGImage derived images.
      
              CachedImage::image() of course needs a RenderObject* parameter now, to identify which of the images from the cache to use, if the underlying image is a SVGImage.
              Luckily these information are already present in StyleCachedImage/StyleImage & friends and only need to be added for some additional methods.
              (WebCore::CachedImage::image): FIXME
              (WebCore::CachedImage::imageForRenderer): Call lookupOrCreateImageForRenderer() instead of returning m_image, if it's not null. Its a no-op for non SVGImage derived objects.
              (WebCore::CachedImage::setContainerSizeForRenderer): For non-SVGImages, just pass on the size to the m_image. For SVGImages, associate the passed in renderer with the IntSize in the cache.
                                                                   This does NOT create the SVGImage yet, this is delayed until imageForRenderer() is called for a given renderer that wants this size.
              (WebCore::CachedImage::imageSize): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
              (WebCore::CachedImage::imageRect): Ditto.
              (WebCore::CachedImage::clear): Force clearing the m_svgImageCache.
              (WebCore::CachedImage::data): Call m_image->size() instead of imageSize(), to avoid having to pass a null renderer to imageSize() as here no renderer is available yet.
              (WebCore::CachedImage::destroyDecodedData): Don't destroy decoded data for SVG images, as m_data needs to be accessable at any time to construct a cloned SVGImage.
                                                          In future we don't need this anymore if we make sure multiple SVGImages share the same trees, but that's for a follow-up patch.
              (WebCore::CachedImage::decodedSizeChanged): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
              (WebCore::CachedImage::didDraw): Ditto.
              (WebCore::CachedImage::shouldPauseAnimation): Ditto.
              (WebCore::CachedImage::animationAdvanced): Ditto.
              (WebCore::CachedImage::changedInRect): Ditto. (eg. when leaving out this change animated SVG images wouldn't update anymore, as the animation didn't happen on m_image!)
              * loader/cache/CachedImage.h: imageForRenderer/canRender/setContainerSizeForRenderer/imageSizeForRenderer now all take a RenderObject* parameter to identifiy the current user of the image.
              (WebCore::CachedImage::canRender): Pass on the incoming renderer to imageSizeForRenderer().
              * page/DragController.cpp:
              (WebCore::getImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectCursor): Ditto.
              * page/PageSerializer.cpp:
              (WebCore::PageSerializer::serializeFrame): Ditto.
              (WebCore::PageSerializer::addImageToResources): Ditto.
              (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration): Ditto.
              * page/PageSerializer.h:
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::writeImageToDataObject): Ditto.
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeImage): Ditto.
              * platform/graphics/Image.h:
              (WebCore::Image::isSVGImage): Add boolean helper to identify SVGImages, just like isBitmapImage().
              * platform/gtk/ClipboardGtk.cpp:
              (WebCore::ClipboardGtk::declareAndWriteDragImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
              * platform/gtk/PasteboardGtk.cpp:
              (WebCore::Pasteboard::writeImage): Ditto.
              * platform/mac/HTMLConverter.mm:
              (fileWrapperForElement): Ditto.
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeImage): Ditto.
              * platform/qt/ClipboardQt.cpp:
              (WebCore::ClipboardQt::declareAndWriteDragImage): Ditto.
              * platform/qt/PasteboardQt.cpp:
              (WebCore::Pasteboard::writeImage): Ditto.
              * platform/win/ClipboardWin.cpp:
              (WebCore::writeImageToDataObject): Ditto.
              * platform/win/PasteboardWin.cpp:
              (WebCore::Pasteboard::writeImage): Ditto.
              * platform/wince/PasteboardWinCE.cpp:
              (WebCore::Pasteboard::writeImage): Ditto.
              * rendering/HitTestResult.cpp:
              (WebCore::HitTestResult::image): Ditto.
              * rendering/ImageBySizeCache.cpp: Copied from WebCore/css/CSSImageGeneratorValue.cpp, to preserve history for the original cache code.
              (WebCore::ImageBySizeCache::ImageBySizeCache): Straight copy from CSSImageGeneratorValue, renamed to ImageBySizeCache, removing all but the cache relevant code.
              (WebCore::ImageBySizeCache::addClient): Ditto.
              (WebCore::ImageBySizeCache::removeClient): Ditto.
              (WebCore::ImageBySizeCache::getImage): Ditto.
              (WebCore::ImageBySizeCache::putImage): Ditto.
              (WebCore::ImageBySizeCache::clear): New function, that clears the cache, introduced for the needs of CachedImage.
              (WebCore::ImageBySizeCache::imageForSize): New function to query an Image* for a given IntSize, introduced for the needs of CachedImage.
              (WebCore::ImageBySizeCache::sizeForClient): New function to query an IntSize for a given renderer.
              * rendering/ImageBySizeCache.h: Copied from WebCore/css/CSSImageGeneratorValue.h.
              (WebCore::ImageBySizeCache::clients):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintFillLayer): CachedImage::canRender() now takes a RenderObject* parameter.
              (WebCore::InlineFlowBox::paintBoxDecorations): Ditto.
              (WebCore::InlineFlowBox::paintMask): Ditto.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintMaskImages): Ditto.
              (WebCore::RenderBox::repaintLayerRectsForImage): Ditto.
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended): Ditto.
              (WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto (for CachedImage::setContainerSizeForRenderer()).
              (WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::imageSizeForError): Use new CachedImage::imageForRenderer(RenderObject*) method.
              (WebCore::RenderImage::setImageSizeForAltText): Ditto.
              (WebCore::RenderImage::computeReplacedLogicalWidth): FIXME
              * rendering/RenderImageResource.cpp:
              (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass on m_renderer to CachedImage::setContainerSizeForRenderer().
              * rendering/RenderImageResource.h: Remove constness from setContainerSizeForRenderer.
              (WebCore::RenderImageResource::image): Pass on m_renderer to CachedImage::image().
              (WebCore::RenderImageResource::imageSize): Pass on m_renderer to CachedImage::imageSizeForRenderer().
              * rendering/RenderImageResourceStyleImage.h:
              (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Remove constness, pass on m_renderer to StyleImage::setContainerSizeForRenderer().
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
              (WebCore::RenderLayerBacking::updateImageContents): Ditto.
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::computePreferredLogicalWidths): CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter.
              * rendering/RenderObject.cpp:
              (WebCore::mustRepaintFillLayers): CachedImage::canRender() now takes a RenderObject* parameter.
              (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Ditto.
              * rendering/style/StyleCachedImage.cpp:
              (WebCore::StyleCachedImage::canRender): Pass on incoming renderer to CachedImage::canRender().
              (WebCore::StyleCachedImage::imageSize): Pass on incoming renderer to CachedImage::imageSizeForRenderer().
              (WebCore::StyleCachedImage::setContainerSizeForRenderer): Pass on incoming renderer to CachedImage::setContainerSizeForRenderer().
              (WebCore::StyleCachedImage::addClient): Remove unneeded return statment in void method.
              (WebCore::StyleCachedImage::removeClient): Ditto.
              (WebCore::StyleCachedImage::image): Pass on incoming renderer to CachedImage::image().
              * rendering/style/StyleCachedImage.h: Add RenderObject* parameter to canRender()/setContainerSizeForRenderer(). image() already has one, that was unused so far.
              * rendering/style/StyleGeneratedImage.cpp: Inlined setContainerSizeForRenderer.
              * rendering/style/StyleGeneratedImage.h: 
              (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Add RenderObject* parameter.
              * rendering/style/StyleImage.h:
              (WebCore::StyleImage::canRender): Ditto.
              * rendering/style/StylePendingImage.h:
              (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::build): Use new CachedImage::imageForRenderer(RenderObject*) method.
              * svg/graphics/SVGImage.cpp: Cleanup file, the include hack seems not needed anymore.
              (WebCore::SVGImage::setContainerSize): s/LayoutSize/IntSize/ to match the code in platform/.
              * svg/graphics/SVGImage.h: Ditto.
              (WebCore::SVGImage::isSVGImage): Return true.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cf217f7
  25. 02 Sep, 2011 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r94421. · 03477c8b
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/94421
      https://bugs.webkit.org/show_bug.cgi?id=67496
      
      Broke a number of tests on Chromium builders (including the
      "cr-linux" EWS bot) (Requested by apavlov on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-02
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (webkit_accessible_get_name):
      * dom/Document.cpp:
      (WebCore::Document::buildAccessKeyMap):
      (WebCore::Document::recalcStyleSelector):
      * dom/Element.cpp:
      (WebCore::Element::baseURI):
      (WebCore::Element::formatForDebugger):
      (WebCore::Element::spellcheckAttributeState):
      * dom/NameNodeList.cpp:
      (WebCore::NameNodeList::nodeMatches):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
      * editing/SplitElementCommand.cpp:
      (WebCore::SplitElementCommand::doUnapply):
      * editing/markup.cpp:
      (WebCore::shouldIncludeWrapperForFullySelectedRoot):
      (WebCore::createMarkup):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::draggable):
      (WebCore::HTMLAnchorElement::href):
      (WebCore::HTMLAnchorElement::name):
      (WebCore::HTMLAnchorElement::target):
      (WebCore::HTMLAnchorElement::sendPings):
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::createRenderer):
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::target):
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::aLink):
      (WebCore::HTMLBodyElement::bgColor):
      (WebCore::HTMLBodyElement::link):
      (WebCore::HTMLBodyElement::text):
      (WebCore::HTMLBodyElement::vLink):
      (WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::value):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      * html/HTMLCollection.cpp:
      (WebCore::HTMLCollection::checkForNameMatch):
      (WebCore::HTMLCollection::updateNameCache):
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::dir):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::parseMappedAttribute):
      (WebCore::HTMLElement::draggable):
      (WebCore::HTMLElement::title):
      (WebCore::setHasDirAutoFlagRecursively):
      (WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
      (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
      (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      (WebCore::HTMLEmbedElement::insertedIntoDocument):
      (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):
      * html/HTMLFormCollection.cpp:
      (WebCore::HTMLFormCollection::getNamedFormItem):
      (WebCore::HTMLFormCollection::updateNameCache):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::autofocus):
      (WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::name):
      (WebCore::HTMLFormElement::action):
      (WebCore::HTMLFormElement::method):
      (WebCore::HTMLFormElement::target):
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::noResize):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
      (WebCore::HTMLFrameElementBase::location):
      (WebCore::HTMLFrameElementBase::allowFullScreen):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::altText):
      (WebCore::HTMLImageElement::width):
      (WebCore::HTMLImageElement::height):
      (WebCore::HTMLImageElement::alt):
      (WebCore::HTMLImageElement::draggable):
      (WebCore::HTMLImageElement::src):
      (WebCore::HTMLImageElement::addSubresourceAttributeURLs):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::finishParsingChildren):
      (WebCore::HTMLInputElement::altText):
      (WebCore::HTMLInputElement::reset):
      (WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
      (WebCore::HTMLInputElement::isSpeechEnabled):
      * html/HTMLLabelElement.cpp:
      (WebCore::HTMLLabelElement::control):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::process):
      (WebCore::HTMLLinkElement::href):
      (WebCore::HTMLLinkElement::rel):
      (WebCore::HTMLLinkElement::target):
      (WebCore::HTMLLinkElement::type):
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::imageElement):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::attributeChanged):
      (WebCore::HTMLMediaElement::insertedIntoDocument):
      * html/HTMLMetaElement.cpp:
      (WebCore::HTMLMetaElement::content):
      (WebCore::HTMLMetaElement::httpEquiv):
      (WebCore::HTMLMetaElement::name):
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::min):
      (WebCore::HTMLMeterElement::max):
      (WebCore::HTMLMeterElement::value):
      (WebCore::HTMLMeterElement::low):
      (WebCore::HTMLMeterElement::high):
      (WebCore::HTMLMeterElement::optimum):
      * html/HTMLNameCollection.cpp:
      (WebCore::HTMLNameCollection::itemAfter):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateWidget):
      (WebCore::HTMLObjectElement::containsJavaApplet):
      (WebCore::HTMLObjectElement::addSubresourceAttributeURLs):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::groupLabelText):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::max):
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::sourceAttributeValue):
      (WebCore::HTMLScriptElement::charsetAttributeValue):
      (WebCore::HTMLScriptElement::typeAttributeValue):
      (WebCore::HTMLScriptElement::languageAttributeValue):
      (WebCore::HTMLScriptElement::forAttributeValue):
      (WebCore::HTMLScriptElement::eventAttributeValue):
      * html/HTMLSourceElement.cpp:
      (WebCore::HTMLSourceElement::media):
      (WebCore::HTMLSourceElement::type):
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::media):
      (WebCore::HTMLStyleElement::type):
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::abbr):
      (WebCore::HTMLTableCellElement::axis):
      (WebCore::HTMLTableCellElement::headers):
      (WebCore::HTMLTableCellElement::scope):
      (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):
      * html/HTMLTableColElement.cpp:
      (WebCore::HTMLTableColElement::width):
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::rules):
      (WebCore::HTMLTableElement::summary):
      (WebCore::HTMLTableElement::addSubresourceAttributeURLs):
      * html/HTMLTableSectionElement.cpp:
      (WebCore::HTMLTableSectionElement::align):
      (WebCore::HTMLTableSectionElement::ch):
      (WebCore::HTMLTableSectionElement::chOff):
      (WebCore::HTMLTableSectionElement::vAlign):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::maxLength):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::strippedPlaceholder):
      (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::src):
      (WebCore::HTMLTrackElement::kind):
      (WebCore::HTMLTrackElement::srclang):
      (WebCore::HTMLTrackElement::label):
      (WebCore::HTMLTrackElement::isDefault):
      (WebCore::HTMLTrackElement::load):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::width):
      (WebCore::HTMLVideoElement::height):
      * html/StepRange.cpp:
      (WebCore::StepRange::StepRange):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::updateFromElement):
      * page/Frame.cpp:
      (WebCore::Frame::matchLabelsAgainstElement):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeFrame):
      * page/mac/FrameMac.mm:
      (WebCore::Frame::matchLabelsAgainstElement):
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::writeImageToDataObject):
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeImage):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForElement):
      * platform/win/ClipboardWin.cpp:
      (WebCore::writeImageToDataObject):
      (WebCore::ClipboardWin::declareAndWriteDragImage):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::altDisplayString):
      (WebCore::HitTestResult::absoluteImageURL):
      (WebCore::HitTestResult::absoluteLinkURL):
      * rendering/RenderDetails.cpp:
      (WebCore::RenderDetails::isOpen):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemAccessibilityText):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::addPDFURLRect):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::computePreferredLogicalWidths):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::autosaveName):
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::calculateIntrinsicSize):
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::updateFromElement):
      * rendering/mathml/RenderMathMLFraction.cpp:
      (WebCore::RenderMathMLFraction::updateFromElement):
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::updateFromElement):
      * svg/SVGFontData.cpp:
      (WebCore::SVGFontData::applySVGGlyphSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03477c8b
    • andreas.kling@nokia.com's avatar
      Use fastGetAttribute() and fastHasAttribute() where appropriate. · baab8915
      andreas.kling@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=67394
      
      Reviewed by Darin Adler.
      
      Change call sites that don't check the "style" or SVG animatable
      attributes to use fastGetAttribute()/fastHasAttribute() instead
      of getAttribute()/hasAttribute().
      
      No new tests, this is a minor performance optimization.
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::nodeHasRole):
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (webkit_accessible_get_name):
      * dom/Document.cpp:
      (WebCore::Document::buildAccessKeyMap):
      (WebCore::Document::recalcStyleSelector):
      * dom/Element.cpp:
      (WebCore::Element::baseURI):
      (WebCore::Element::formatForDebugger):
      (WebCore::Element::spellcheckAttributeState):
      * dom/NameNodeList.cpp:
      (WebCore::NameNodeList::nodeMatches):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
      * editing/SplitElementCommand.cpp:
      (WebCore::SplitElementCommand::doUnapply):
      * editing/markup.cpp:
      (WebCore::shouldIncludeWrapperForFullySelectedRoot):
      (WebCore::createMarkup):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::draggable):
      (WebCore::HTMLAnchorElement::href):
      (WebCore::HTMLAnchorElement::name):
      (WebCore::HTMLAnchorElement::target):
      (WebCore::HTMLAnchorElement::sendPings):
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::createRenderer):
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::target):
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::aLink):
      (WebCore::HTMLBodyElement::bgColor):
      (WebCore::HTMLBodyElement::link):
      (WebCore::HTMLBodyElement::text):
      (WebCore::HTMLBodyElement::vLink):
      (WebCore::HTMLBodyElement::addSubresourceAttributeURLs):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::value):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::reset):
      * html/HTMLCollection.cpp:
      (WebCore::HTMLCollection::checkForNameMatch):
      (WebCore::HTMLCollection::updateNameCache):
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::dir):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::parseMappedAttribute):
      (WebCore::HTMLElement::draggable):
      (WebCore::HTMLElement::title):
      (WebCore::setHasDirAutoFlagRecursively):
      (WebCore::HTMLElement::directionalityIfhasDirAutoAttribute):
      (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildAttributeChanged):
      (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      (WebCore::HTMLEmbedElement::insertedIntoDocument):
      (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):
      * html/HTMLFormCollection.cpp:
      (WebCore::HTMLFormCollection::getNamedFormItem):
      (WebCore::HTMLFormCollection::updateNameCache):
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::autofocus):
      (WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::name):
      (WebCore::HTMLFormElement::action):
      (WebCore::HTMLFormElement::method):
      (WebCore::HTMLFormElement::target):
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::noResize):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
      (WebCore::HTMLFrameElementBase::location):
      (WebCore::HTMLFrameElementBase::allowFullScreen):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::altText):
      (WebCore::HTMLImageElement::width):
      (WebCore::HTMLImageElement::height):
      (WebCore::HTMLImageElement::alt):
      (WebCore::HTMLImageElement::draggable):
      (WebCore::HTMLImageElement::src):
      (WebCore::HTMLImageElement::addSubresourceAttributeURLs):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::finishParsingChildren):
      (WebCore::HTMLInputElement::altText):
      (WebCore::HTMLInputElement::reset):
      (WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
      (WebCore::HTMLInputElement::isSpeechEnabled):
      * html/HTMLLabelElement.cpp:
      (WebCore::HTMLLabelElement::control):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::process):
      (WebCore::HTMLLinkElement::href):
      (WebCore::HTMLLinkElement::rel):
      (WebCore::HTMLLinkElement::target):
      (WebCore::HTMLLinkElement::type):
      * html/HTMLMapElement.cpp:
      (WebCore::HTMLMapElement::imageElement):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::attributeChanged):
      (WebCore::HTMLMediaElement::insertedIntoDocument):
      * html/HTMLMetaElement.cpp:
      (WebCore::HTMLMetaElement::content):
      (WebCore::HTMLMetaElement::httpEquiv):
      (WebCore::HTMLMetaElement::name):
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::min):
      (WebCore::HTMLMeterElement::max):
      (WebCore::HTMLMeterElement::value):
      (WebCore::HTMLMeterElement::low):
      (WebCore::HTMLMeterElement::high):
      (WebCore::HTMLMeterElement::optimum):
      * html/HTMLNameCollection.cpp:
      (WebCore::HTMLNameCollection::itemAfter):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::updateWidget):
      (WebCore::HTMLObjectElement::containsJavaApplet):
      (WebCore::HTMLObjectElement::addSubresourceAttributeURLs):
      * html/HTMLOptGroupElement.cpp:
      (WebCore::HTMLOptGroupElement::groupLabelText):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::max):
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::sourceAttributeValue):
      (WebCore::HTMLScriptElement::charsetAttributeValue):
      (WebCore::HTMLScriptElement::typeAttributeValue):
      (WebCore::HTMLScriptElement::languageAttributeValue):
      (WebCore::HTMLScriptElement::forAttributeValue):
      (WebCore::HTMLScriptElement::eventAttributeValue):
      * html/HTMLSourceElement.cpp:
      (WebCore::HTMLSourceElement::media):
      (WebCore::HTMLSourceElement::type):
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::media):
      (WebCore::HTMLStyleElement::type):
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::abbr):
      (WebCore::HTMLTableCellElement::axis):
      (WebCore::HTMLTableCellElement::headers):
      (WebCore::HTMLTableCellElement::scope):
      (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):
      * html/HTMLTableColElement.cpp:
      (WebCore::HTMLTableColElement::width):
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::rules):
      (WebCore::HTMLTableElement::summary):
      (WebCore::HTMLTableElement::addSubresourceAttributeURLs):
      * html/HTMLTableSectionElement.cpp:
      (WebCore::HTMLTableSectionElement::align):
      (WebCore::HTMLTableSectionElement::ch):
      (WebCore::HTMLTableSectionElement::chOff):
      (WebCore::HTMLTableSectionElement::vAlign):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::maxLength):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::strippedPlaceholder):
      (WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::src):
      (WebCore::HTMLTrackElement::kind):
      (WebCore::HTMLTrackElement::srclang):
      (WebCore::HTMLTrackElement::label):
      (WebCore::HTMLTrackElement::isDefault):
      (WebCore::HTMLTrackElement::load):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::width):
      (WebCore::HTMLVideoElement::height):
      * html/StepRange.cpp:
      (WebCore::StepRange::StepRange):
      * html/shadow/TextControlInnerElements.cpp:
      (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * loader/FormSubmission.cpp:
      (WebCore::FormSubmission::create):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::updateFromElement):
      * page/Frame.cpp:
      (WebCore::Frame::matchLabelsAgainstElement):
      * page/PageSerializer.cpp:
      (WebCore::PageSerializer::serializeFrame):
      * page/mac/FrameMac.mm:
      (WebCore::Frame::matchLabelsAgainstElement):
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::writeImageToDataObject):
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeImage):
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::getURLForImageNode):
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForElement):
      * platform/win/ClipboardWin.cpp:
      (WebCore::writeImageToDataObject):
      (WebCore::ClipboardWin::declareAndWriteDragImage):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::altDisplayString):
      (WebCore::HitTestResult::absoluteImageURL):
      (WebCore::HitTestResult::absoluteLinkURL):
      * rendering/RenderDetails.cpp:
      (WebCore::RenderDetails::isOpen):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemAccessibilityText):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::addPDFURLRect):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::computePreferredLogicalWidths):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::autosaveName):
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::calculateIntrinsicSize):
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::updateFromElement):
      * rendering/mathml/RenderMathMLFraction.cpp:
      (WebCore::RenderMathMLFraction::updateFromElement):
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::updateFromElement):
      * svg/SVGFontData.cpp:
      (WebCore::SVGFontData::applySVGGlyphSelection):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baab8915
  26. 31 May, 2011 1 commit
    • beidson@apple.com's avatar
      Another swipe at resolving <rdar://problem/9125145> and... · 197fbd30
      beidson@apple.com authored
      Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
              
      Reviewed by Darin Adler.
      
      Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.
      
      No new tests. No change in behavior.
      
      Instead of storing the DocumentLoader at construction and never changing it,
      always calculate it based on the FrameLoader's current DocumentLoader:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::suggestedMIMEType):
      (WebCore::Document::lastModified):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loader):
      * dom/Document.h:
      
      Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForElement):
      
      * WebCore.exp.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      197fbd30
  27. 29 May, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com> · 3ff33222
      commit-queue@webkit.org authored
              Unreviewed, rolling out r87566.
              http://trac.webkit.org/changeset/87566
              https://bugs.webkit.org/show_bug.cgi?id=61702
      
              It made all tests assert on Qt in debug mode (Requested by
              Ossy_weekend on #webkit).
      
              * WebCore.exp.in:
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::suggestedMIMEType):
              (WebCore::Document::lastModified):
              (WebCore::Document::initSecurityContext):
              (WebCore::Document::updateURLForPushOrReplaceState):
              * dom/Document.h:
              (WebCore::Document::setDocumentLoader):
              (WebCore::Document::loader):
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::replaceMediaElementTimerFired):
              * html/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::createDocumentStructure):
              * platform/mac/HTMLConverter.mm:
              (fileWrapperForElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ff33222
  28. 27 May, 2011 1 commit
    • beidson@apple.com's avatar
      First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494 · fdf7571f
      beidson@apple.com authored
              
      Reviewed by Darin Adler.
      
      Make the Document be intelligent about returning its DocumentLoader, including the possibility that
      the DocumentLoader will be null.
      
      No new tests. No change in behavior.
      
      Instead of storing the DocumentLoader at construction and never changing it,
      always calculate it based on the FrameLoader's current DocumentLoader:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::suggestedMIMEType):
      (WebCore::Document::lastModified):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loader):
      * dom/Document.h:
      
      Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForElement):
      
      * WebCore.exp.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdf7571f
  29. 27 Apr, 2011 1 commit
  30. 07 Apr, 2011 1 commit
    • ap@apple.com's avatar
      Reviewed by Anders Carlsson. · 8199f90c
      ap@apple.com authored
              REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
              https://bugs.webkit.org/show_bug.cgi?id=58066
              <rdar://problem/8965302>
      
              * Scripts/webkit2/messages.py:
              * Shared/mac/AttributedString.h: Added.
              * Shared/mac/AttributedString.mm: Added.
              (WebKit::AttributedString::encode):
              (WebKit::AttributedString::decode):
              Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF
              or NS object to another process without wrapping it in a C++ one.
              
              * Shared/mac/ArgumentCodersMac.h: Added.
              * Shared/mac/ArgumentCodersMac.mm: Added.
              Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why
              these are needed:
              1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't
              work properly for them (I've been just getting 1).
              2) NSColor isn't toll free bridged to CF.
              This adds just the types necessary for editing NSAttributedString (and I don't yet know what
              happens with attachments).
      
              * UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
              * UIProcess/WebPageProxy.h:
              * UIProcess/mac/WebPageProxyMac.mm:
              (WebKit::WebPageProxy::getAttributedSubstringFromRange):
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in:
              Boilerplate code for making a sync call to web process.
      
              * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange):
              Ported from WebHTMLView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8199f90c
  31. 05 Apr, 2011 3 commits
  32. 08 Mar, 2011 1 commit
    • enrica@apple.com's avatar
      REGRESSION: Copied content loses formatting on paste to external apps. · c7ca00ac
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=47615
      <rdar://problem/9001214>
              
      Reviewed by Darin Adler.
      
      This is a resubmission of a patch that was landed a while ago then rolled
      back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
      
      This patch adds a way for WebKit2 to create NSAttributedStrings from
      a DOM range without using the AppKit api initWithDOMRange that internally
      needs to access the WebView. The NSAttributedString is needed to create
      RTF formats in the pasteboard.
      This is to be considered a first step, since in the future we want to have
      an implementation based on the TextIterator.
      * WebCore.xcodeproj/project.pbxproj:
      * platform/mac/HTMLConverter.h: Added.
      * platform/mac/HTMLConverter.mm: Added.
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::writeSelection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7ca00ac
  33. 07 Mar, 2011 1 commit